gdb/ChangeLog

   1 2019-12-11  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
   4         Implement.
   5         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
   6         Implement.
   7         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
   8         method.
   9         (struct tui_win_info) <min_height>: Implement.
  10
  11 2019-12-11  Tom Tromey  <tom@tromey.com>
  12
  13         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
  14         (struct tui_win_info) <can_box>: Update.
  15
  16 2019-12-11  Tom Tromey  <tom@tromey.com>
  17
  18         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
  19         method.
  20         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
  21         method.
  22         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
  23         method.
  24         (struct tui_win_info) <max_height>: Now override.
  25
  26 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
  27
  28         * NEWS: Create a new section for the next release branch.
  29         Rename the section of the current branch, now that it has
  30         been cut.
  31
  32 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
  33
  34         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
  35         * version.in: Bump version to 10.0.50.DATE-git.
  36
  37 2019-12-11  Tom Tromey  <tromey@adacore.com>
  38
  39         PR build/25268:
  40         * gdbsupport/thread-pool.c (set_thread_name): New function.
  41         (thread_pool::set_thread_count): Don't call pthread_setname_np.
  42         (thread_pool::thread_function): Call set_thread_name.
  43
  44 2019-12-11  Tom Tromey  <tromey@adacore.com>
  45
  46         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
  47         bfd_get_signed_8.
  48
  49 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  50
  51         * NEWS: Document -raw-values option and the related setting commands.
  52         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
  53         only set it on when /r is given.
  54         * valprint.c (value_print_option_defs): New element raw-values.
  55         * Makefile.in: Add the new file.
  56
  57 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
  58
  59         * gdbsupport/safe-strerror.c: Supress the unused function warning
  60         for select_strerror_r.
  61
  62 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
  63
  64         * config.in: Regenerate.
  65         * configure: Regenerate.
  66         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
  67         safe_strerror instead of strerror.
  68         * gdbsupport/common.m4: Don't check for strerror.
  69         * gdbsupport/safe-strerror.c: Support both the glibc version
  70         of strerror_r and the XSI version.
  71
  72 2019-12-10  Tom Tromey  <tromey@adacore.com>
  73
  74         * ada-typeprint.c (print_choices): Use a single "?".
  75         (print_variant_part): Print "?" if the discriminant name
  76         is not known.
  77
  78 2019-12-10  George Barrett  <bob@bob131.so>
  79
  80         Fix scripted probe breakpoints.
  81         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
  82         declaration forward.
  83         (breakpoint_ops_for_event_location_type)
  84         (breakpoint_ops_for_event_location): Add function definitions.
  85         (break_command_1, trace_command): Use
  86         breakpoint_ops_for_event_location.
  87         * breakpoint.h (breakpoint_ops_for_event_location): Add function
  88         declarations.
  89         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
  90         breakpoint_ops_for_event_location.
  91         * python/py-breakpoint.c (bppy_init): Use
  92         breakpoint_ops_for_event_location.
  93
  94 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  95
  96         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
  97         when ranking an lvalue argument for an rvalue parameter.
  98
  99 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 100
 101         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 102         template argument for scoped_restore_tmpl from bool to int.
 103
 104 2019-12-07  Keith Seitz  <keiths@redhat.com>
 105
 106         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 107         (build_id_to_debug_bfd): Make static, rewriting to use
 108         build_id_to_bfd_suffix.
 109         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 110         adding `suffix' parameter. Append SUFFIX to file names
 111         when searching for matching files.
 112         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 113         (build_id_to_exec_bfd): Likewise.
 114         * build-id.h (build_id_to_debug_bfd): Clarify that function
 115         searches for BFD of debug info file.
 116         (build_id_to_exec_bfd): Declare.
 117         * corelow.c: Include build-id.h.
 118         (locate_exec_from_corefile_build_id): New function.
 119         (core_target_open): If no executable BFD is found,
 120         search for a core file BFD using build-id.
 121
 122 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 123
 124         * bcache.c: Put in namespace gdb.
 125         * bcache.h: Likewise.
 126         * gdbtypes.c (check_types_worklist): Update.
 127         (types_deeply_equal): Update.
 128         * macrotab.c (struct macro_table) <bcache>: Update.
 129         (new_macro_table): Update.
 130         * macrotab.h (struct bcache): Put this forward declaration
 131         inside namespace gdb.
 132         (new_macro_table): Update.
 133         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 134         Update.
 135         <macro_cache>: Update.
 136         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 137
 138 2019-12-06  Tom de Vries  <tdevries@suse.de>
 139
 140         PR symtab/24971
 141         * block.c (best_symbol, better_symbol): New function.
 142         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 143         decl.
 144
 145 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 146
 147         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 148         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 149         for ranking see-through reference cases.
 150
 151 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 152         * stack.c (faas_command): Check a command is provided.
 153         * thread.c (taas_command, tfaas_command): Likewise.
 154
 155 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 156         * inferior.c (prune_inferiors):  Only call delete_inferior,
 157         Do not modify the inferior list.
 158
 159 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 160
 161         * c-exp.y: Update calls to lookup_typename,
 162         lookup_signed_typename and lookup_unsigned_typename.
 163         * c-lang.c (evaluate_subexp_c): Likewise.
 164         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 165         Likewise.
 166         * eval.c (binop_promote): Likewise.
 167         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 168         (lookup_unsigned_typename): Likewise.
 169         (lookup_signed_typename): Likewise.
 170         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 171         (lookup_signed_typename): Likewise.
 172         (lookup_typename): Likewise.
 173         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 174         lookup_typename, lookup_signed_typename,
 175         lookup_unsigned_typename.
 176         * m2-exp.y: Likewise.
 177         * printcmd.c (printf_wide_c_string): Likewise.
 178         (ui_printf): Likewise.
 179         * python/py-type.c (typy_lookup_typename): Likewise.
 180         * python/py-xmethods.c (python_xmethod_worker::invoke):
 181         Likewise.
 182         * rust-exp.y: Likewise.
 183
 184 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 185
 186         * configure.nat (obsd64): Add missing files x86-nat.o and
 187         nat/x86-dregs.o.
 188
 189 2019-12-04  Tom Tromey  <tom@tromey.com>
 190
 191         * valprint.c (val_print_string): Use metadata_style.
 192         * go-valprint.c (print_go_string): Use metadata style.
 193         * p-valprint.c (pascal_object_print_static_field): Use metadata
 194         style.
 195         * cp-valprint.c (cp_print_static_field): Use metadata style.
 196
 197 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 198             Chris January  <chris.january@arm.com>
 199
 200         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
 201         tokens.
 202         (typebase): New patterns for complex, single/double precision, and
 203         single/double complex.
 204         (f77_keywords): Change token for complex keyword, and add single,
 205         double, and precision keywords.
 206
 207 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 208
 209         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
 210         "info io_registers".
 211
 212 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 213
 214         * regcache.c (cooked_read_test): Initialize thread list of
 215         mock_inferior.
 216
 217 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 218
 219         * aarch64-linux-tdep.c: Remove includes.
 220
 221 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 222
 223         * aarch64-tdep.c: Remove includes.
 224
 225 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
 226
 227         * filtered-iterator.h (filtered_iterator) <operator==,
 228         operator!=>: Compare wrapped iterators, not wrapped pointers.
 229         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 230         unittests/filtered_iterator-selftests.c.
 231         * unittests/filtered_iterator-selftests.c: New file.
 232
 233 2019-12-04  Tom Tromey  <tromey@adacore.com>
 234
 235         * gdbtypes.c (create_range_type): Inherit endianity
 236         from base type.
 237
 238 2019-12-04  Tom Tromey  <tromey@adacore.com>
 239
 240         * ada-lang.c (decode_constrained_packed_array)
 241         (ada_value_assign, value_assign_to_component): Update.
 242         * dwarf2loc.c (rw_pieced_value, access_memory)
 243         (dwarf2_compile_expr_to_ax): Update.
 244         * dwarf2read.c (dwarf2_add_field): Update.
 245         * eval.c (evaluate_subexp_standard): Update.
 246         * gdbarch.c, gdbarch.h: Rebuild.
 247         * gdbarch.sh (bits_big_endian): Remove.
 248         * gdbtypes.h (union field_location): Update comment.
 249         * target-descriptions.c (make_gdb_type): Update.
 250         * valarith.c (value_bit_index): Update.
 251         * value.c (struct value) <bitpos>: Update comment.
 252         (unpack_bits_as_long, modify_field): Update.
 253         * value.h (value_bitpos): Update comment.
 254
 255 2019-12-04  Tom Tromey  <tromey@adacore.com>
 256
 257         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
 258         endian-ness.
 259
 260 2019-12-04  Tom Tromey  <tromey@adacore.com>
 261
 262         * dwarf2read.c (dwarf2_init_float_type)
 263         (dwarf2_init_complex_target_type): Add byte_order parameter.
 264         (read_base_type): Compute byte order earlier.
 265         * gdbtypes.c (init_float_type): Add byte_order parameter.
 266         * gdbtypes.h (init_float_type): Add byte_order parameter.
 267
 268 2019-12-04  Tom Tromey  <tromey@adacore.com>
 269
 270         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
 271
 272 2019-12-04  Tom Tromey  <tromey@adacore.com>
 273
 274         * dwarf2read.c (process_structure_scope): Initialize
 275         "discr_offset".
 276
 277 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 278
 279         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
 280         add it into the search spec.
 281         (parse_max_results_option): New function.
 282         (mi_info_functions_or_variables): Parse -max-results flag and pass
 283         it to mi_symbol_info.
 284         (mi_cmd_symbol_info_modules): Likewise.
 285         (mi_cmd_symbol_info_types): Likewise.
 286         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
 287         return type to bool, change result container into a set, and don't
 288         add new results if we have enough already.
 289         (global_symbol_searcher::add_matching_msymbols): Change return
 290         type to bool, and don't add new results if we have enough already.
 291         (sort_search_symbols_remove_dups): Delete.
 292         (global_symbol_searcher::search): Early exit from search loop when
 293         we have enough results.  Use a std::set to collect the results
 294         from calling add_matching_symbols.
 295         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
 296         member function.
 297         (global_symbol_searcher) <m_max_search_results>: New member
 298         variable.
 299         (global_symbol_searcher) <add_matching_symbols>: Update header
 300         comment and change return type to bool.
 301         (global_symbol_searcher) <add_matching_msymbols>: Update header
 302         comment and change return type to bool.
 303
 304 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 305
 306         * symtab.c (symbol_search::compare_search_syms): Update header
 307         comment.
 308         (global_symbol_searcher::is_suitable_msymbol): New function.
 309         (global_symbol_searcher::expand_symtabs): New function.
 310         (global_symbol_searcher::add_matching_symbols): New function.
 311         (global_symbol_searcher::add_matching_msymbols): New function.
 312         (global_symbol_searcher::search): Move most of the content
 313         into the new functions above, and call them as needed.
 314         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
 315         function.
 316         (global_symbol_searcher) <add_matching_symbols>: New member
 317         function.
 318         (global_symbol_searcher) <add_matching_msymbols>: New member
 319         function.
 320         (global_symbol_searcher) <is_suitable_msymbol>: New member
 321         function.
 322
 323 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 324
 325         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
 326         -symbol-info-module-variables entries.
 327         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
 328         (mi_cmd_symbol_info_module_variables): Declare.
 329         * mi/mi-symbol-cmds.c
 330         (module_symbol_search_iterator): New typedef.
 331         (output_module_symbols_in_single_module_and_file): New function.
 332         (output_module_symbols_in_single_module): New function.
 333         (mi_info_module_functions_or_variables): New function.
 334         (mi_cmd_symbol_info_module_functions): New function.
 335         (mi_cmd_symbol_info_module_variables): New function.
 336         * NEWS: Mention new MI command.
 337
 338 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
 339
 340         * bcache.c (hash): Remove.
 341         (hash_continue): Remove.
 342         * bcache.h (hash): Remove.
 343         (hash_continue): Remove.
 344         (struct bcache) <ctor>: Update.
 345         * psymtab.c (psymbol_hash): Update.
 346         * stabsread.c (hashname): Update.
 347         * utils.h (fast_hash): Add an argument for a start value,
 348         defaulting to zero.
 349
 350 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 351         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
 352         (destroy_block_symbol_cache): New function.
 353         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
 354         (resize_symbol_cache): Likewise.
 355
 356 2019-12-02  Tom Tromey  <tom@tromey.com>
 357
 358         * unittests/tui-selftests.c (run_tests): Make conditional.
 359         (_initialize_tui_selftest): Make conditional.
 360
 361 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
 362
 363         * aix-thread.c (debug_aix_thread): Change type to bool.
 364
 365 2019-12-02  Luis Machado  <luis.machado@linaro.org>
 366
 367         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
 368
 369 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 370
 371         * dwarf2read.c (read_tag_string_type): Read the fields required to
 372         make a dynamic string, and possibly create a dynamic range for the
 373         string.
 374         (attr_to_dynamic_prop): Setup is_reference based on the type of
 375         attribute being processed.
 376         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
 377         (resolve_dynamic_array): Rename to...
 378         (resolve_dynamic_array_or_string): ...this, update header comment,
 379         and accept TYPE_CODE_STRING.
 380         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
 381
 382 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 383
 384         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
 385         of its implementation from...
 386         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
 387         the new function.
 388
 389 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 390
 391         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
 392         create a range with stride where appropriate.
 393         * f-valprint.c: Include 'gdbarch.h'.
 394         (f77_print_array_1): Take the stride into account when walking the
 395         array.  Also convert the stride into addressable units.
 396         * gdbtypes.c (create_range_type): Initialise the stride to
 397         constant zero.
 398         (create_range_type_with_stride): New function, initialise the
 399         range as normal, and then setup the stride.
 400         (has_static_range): Include the stride here.  Also change the
 401         return type to bool.
 402         (create_array_type_with_stride): Consider the range stride if the
 403         array isn't given its own stride.
 404         (resolve_dynamic_range): Resolve the stride if needed.
 405         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
 406         (struct range_bounds) <flag_is_byte_stride>: New member variable.
 407         (TYPE_BIT_STRIDE): Define.
 408         (TYPE_ARRAY_BIT_STRIDE): Define.
 409         (create_range_type_with_stride): Declare.
 410         * valarith.c (value_subscripted_rvalue): Take range stride into
 411         account when walking the array.
 412
 413 2019-12-01  Tom Tromey  <tom@tromey.com>
 414
 415         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
 416         specially.
 417
 418 2019-12-01  Tom Tromey  <tom@tromey.com>
 419
 420         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
 421         \0.
 422         * unittests/tui-selftests.c: New file.
 423         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
 424
 425 2019-12-01  Tom Tromey  <tom@tromey.com>
 426
 427         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
 428
 429 2019-12-01  Tom Tromey  <tom@tromey.com>
 430
 431         * NEWS: Document new settings.
 432         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
 433         * tui/tui-win.c (_initialize_tui_win): Add border style
 434         observers.
 435         * tui/tui-io.h (tui_apply_style): Declare.
 436         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
 437         longer static.
 438         (apply_ansi_escape, tui_set_reverse_mode): Update.
 439         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
 440         Add "skip_intensity" parameter.
 441         <changed>: New member.
 442         <do_set_value>: Declare.
 443         (tui_border_style, tui_active_border_style): Declare.
 444         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
 445         globals.
 446         (cli_style_option): Initialize "changed".
 447         (cli_style_option::do_set_value): New function.
 448         (cli_style_option::add_setshow_commands): Add "skip_intensity"
 449         parameter.  Update.
 450         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
 451         (_initialize_cli_style): Update.  Create TUI border style
 452         commands.
 453
 454 2019-12-01  Tom Tromey  <tom@tromey.com>
 455
 456         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
 457         parameter.
 458         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
 459         parameter.
 460         * tui/tui-win.h (compact_source): Declare.
 461         * tui/tui-win.c (compact_source): New global.
 462         (tui_set_compact_source, tui_show_compact_source): New functions.
 463         (_initialize_tui_win): Add "compact-source" setting.
 464         * tui/tui-source.c (tui_source_window::set_contents): Handle
 465         compact_source setting.
 466         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 467         * NEWS: Document new setting.
 468
 469 2019-11-30  Tom Tromey  <tom@tromey.com>
 470
 471         * dwarf2read.c (dwarf2_add_field): Include field offset when
 472         computing variant part length.
 473
 474 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 475         * NEWS:  Mention define-prefix.  Tell that command names can now
 476         contain a . character.
 477
 478 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 479
 480         * command.h (valid_cmd_char_p): Declare.
 481         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
 482         the check of valid command char.
 483         (find_command_name_length, valid_user_defined_cmd_name_p): Use
 484         valid_cmd_char_p.
 485         * cli/cli-script.c (validate_comname): Likewise.
 486         * completer.c (gdb_completer_command_word_break_characters):
 487         Do not remove . from the word break char, update comments.
 488         (complete_line_internal_1): Use valid_cmd_char_p.
 489         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
 490         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
 491
 492 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 493
 494         * cli/cli-script.c (do_define_command): Ensure a redefined
 495         prefix command is kept as a prefix command.
 496         (define_prefix_command): New function.
 497         (show_user_1): Report user defined prefixes.
 498         (_initialize_cli_script):  Create the new 'define-prefix' command.
 499         Add completers for 'define' and 'document'.
 500         * top.c (execute_command):  If command is a user-defined prefix only
 501         command, report the list of commands for this prefix command.
 502
 503 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 504
 505         * valops.c (find_oload_champ): Improve debug output.
 506
 507 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 508
 509         * valops.c (find_oload_champ): Print part of debug messages
 510         before the badness vector is std::move'd.
 511
 512 2019-11-28  Tom Tromey  <tom@tromey.com>
 513
 514         * value.c (creal_internal_fn): Fix comment.
 515
 516 2019-11-28  Tom Tromey  <tom@tromey.com>
 517
 518         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
 519         flag_bound_evaluated>: Now unsigned.
 520
 521 2019-11-28  Tom Tromey  <tom@tromey.com>
 522
 523         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
 524         declare.
 525
 526 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
 527
 528         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
 529         debug output.
 530         * jit.c (jit_unregister_code): Add debug print to match
 531         `jit_register_code`.
 532
 533 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 534
 535         * NEWS: Mention the new multithreaded symbol loading.
 536
 537 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 538
 539         * maint.c (n_worker_threads): Default to 0.
 540         (worker_threads_disabled): New function.
 541         * maint.h (worker_threads_disabled): New function.
 542         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
 543         here if worker_threads_disabled () is true.
 544         (minimal_symbol_reader::install): Skip all threading if
 545         worker_threads_disabled () is true.
 546
 547 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 548
 549         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
 550         hash code if possible.
 551         (add_minsym_to_demangled_hash_table): Likewise.
 552         (minimal_symbol_reader::install): Compute the hash codes for msymbol
 553         on the background thread.
 554         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
 555         Add these fields.
 556
 557 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 558
 559         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
 560         of the mangled name on the background thread.
 561         * symtab.c (symbol_set_names): Allow passing in the hash of the
 562         linkage_name.
 563         * symtab.h (symbol_set_names): Likewise.
 564
 565 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
 566
 567         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
 568         physnames are computed for inherited DIEs.
 569
 570 2019-11-27  Tom Tromey  <tromey@adacore.com>
 571
 572         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
 573         backslashes.
 574         * cp-support.c: Remove unnecessary backslashes.
 575
 576 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 577
 578         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
 579         with sym->set_linkage_name.
 580         * coffread.c (coff_read_enum_type): Likewise.
 581         * mdebugread.c (parse_symbol): Likewise.
 582         * stabsread.c (patch_block_stabs): Likewise.
 583         (define_symbol): Likewise.
 584         (read_enum_type): Likewise.
 585         (common_block_end): Likewise.
 586         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
 587         function.
 588         (SYMBOL_SET_LINKAGE_NAME): Remove.
 589         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
 590         with sym->set_linkage_name.
 591
 592 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 593
 594         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
 595         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
 596         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
 597         * NEWS: Mention new MI command.
 598
 599 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 600
 601         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
 602         '-symbol-info-types', and '-symbol-info-variables'.
 603         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
 604         (mi_cmd_symbol_info_types): Declare.
 605         (mi_cmd_symbol_info_variables): Declare.
 606         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
 607         (output_debug_symbol): New function.
 608         (output_nondebug_symbol): New function.
 609         (mi_symbol_info): New function.
 610         (mi_info_functions_or_variables): New function.
 611         (mi_cmd_symbol_info_functions): New function.
 612         (mi_cmd_symbol_info_types): New function.
 613         (mi_cmd_symbol_info_variables): New function.
 614         * NEWS: Mention new commands.
 615
 616 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 617
 618         * symtab.c (symbol_to_info_string): New function, most content
 619         moved from print_symbol_info, but updated to return a std::string.
 620         (print_symbol_info): Update to use symbol_to_info_string and print
 621         returned string.
 622         * symtab.h (symbol_to_info_string): Declare new function.
 623
 624 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 625
 626         * python/python.c (gdbpy_rbreak): Convert to using
 627         global_symbol_searcher.
 628         * symtab.c (file_matches): Convert return type to bool, change
 629         file list to std::vector, update header comment.
 630         (search_symbols): Rename to...
 631         (global_symbol_searcher::search): ...this and update now its
 632         a member function of global_symbol_searcher.  Take account of the
 633         changes to file_matches.
 634         (symtab_symbol_info): Convert to using global_symbol_searcher.
 635         (rbreak_command): Likewise.
 636         (search_module_symbols): Likewise.
 637         * symtab.h (enum symbol_search): Update comment.
 638         (search_symbols): Remove declaration.
 639         (class global_symbol_searcher): New class.
 640
 641 2019-11-26  Tom Tromey  <tromey@adacore.com>
 642
 643         * cp-support.c (_initialize_cp_support): Conditionally initialize
 644         gdb_demangle_attempt_core_dump.
 645
 646 2019-11-26  Tom Tromey  <tom@tromey.com>
 647
 648         * python/py-function.c (fnpy_init): Update.
 649         * value.h (add_internal_function): Adjust declaration.
 650         * value.c (function_destroyer): Remove.
 651         (do_add_internal_function): Don't set destroyer or copy name.
 652         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
 653         Set name_allocated.
 654         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
 655         (cmdpy_init): Set name_allocated.
 656         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
 657         member.
 658         (~cmd_list_element): Free "name" if needed.
 659
 660 2019-11-26  Tom Tromey  <tom@tromey.com>
 661
 662         * value.h (add_internal_function): Add new overload.  Move
 663         documentation from value.h.
 664         * value.c (do_add_internal_function): New function.
 665         (add_internal_function): Use it.  Add new overload.
 666         (function_destroyer): Don't free doc.
 667         * python/py-function.c (fnpy_init): Update.
 668
 669 2019-11-26  Tom Tromey  <tom@tromey.com>
 670
 671         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
 672         (cmdpy_init): Set "doc_allocated".
 673
 674 2019-11-26  Tom Tromey  <tom@tromey.com>
 675
 676         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
 677         name of worker thread.
 678         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 679         pthread_setname_np.
 680         * configure, config.in: Rebuild.
 681
 682 2019-11-26  Tom Tromey  <tom@tromey.com>
 683
 684         * python/python.c (class gdbpy_gil): New.
 685         (struct gdbpy_event): Add constructor, destructor, operator().
 686         (gdbpy_post_event): Use run_on_main_thread.
 687         (gdbpy_initialize_events): Remove.
 688         (do_start_initialization): Update.
 689
 690 2019-11-26  Tom Tromey  <tom@tromey.com>
 691
 692         * NEWS: Add entry.
 693         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
 694         commands.  Call update_thread_pool_size.
 695         (update_thread_pool_size, maintenance_set_worker_threads): New
 696         functions.
 697         (n_worker_threads): New global.
 698
 699 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 700             Tom Tromey  <tom@tromey.com>
 701
 702         * minsyms.c (minimal_symbol_reader::install): Use
 703         parallel_for_each.
 704         * gdbsupport/parallel-for.h: New file.
 705         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
 706
 707 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 708             Tom Tromey  <tom@tromey.com>
 709
 710         * gdbsupport/thread-pool.h: New file.
 711         * gdbsupport/thread-pool.c: New file.
 712         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
 713         (HFILES_NO_SRCDIR): Add thread-pool.h.
 714
 715 2019-11-26  Tom Tromey  <tom@tromey.com>
 716
 717         * event-top.h (thread_local_segv_handler): Declare.
 718         * event-top.c (thread_local_segv_handler): New global.
 719         (install_handle_sigsegv, handle_sigsegv): New functions.
 720         (async_init_signals): Install SIGSEGV handler.
 721         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
 722         thread-local.
 723         (report_failed_demangle): New function.
 724         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
 725         handler-setting code, instead use segv_handler.  Run warning code
 726         on main thread.
 727
 728 2019-11-26  Tom Tromey  <tom@tromey.com>
 729
 730         * run-on-main-thread.c: New file.
 731         * run-on-main-thread.h: New file.
 732         * unittests/main-thread-selftests.c: New file.
 733         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 734         main-thread-selftests.c.
 735         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
 736         (COMMON_SFILES): Add run-on-main-thread.c.
 737
 738 2019-11-26  Tom Tromey  <tom@tromey.com>
 739
 740         * main.c (setup_alternate_signal_stack): Remove.
 741         (captured_main_1): Use gdb::alternate_signal_stack.
 742         * gdbsupport/alt-stack.h: New file.
 743
 744 2019-11-26  Tom Tromey  <tom@tromey.com>
 745
 746         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
 747         Remove comment.
 748         (save_original_signals_state, restore_original_signals_state): Use
 749         gdb_sigmask.
 750         * linux-nat.c (block_child_signals, restore_child_signals_mask)
 751         (_initialize_linux_nat): Use gdb_sigmask.
 752         * guile/guile.c (_initialize_guile): Use block_signals.
 753         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
 754         * gdbsupport/gdb-sigmask.h: New file.
 755         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
 756         * cp-support.c (gdb_demangle): Use gdb_sigmask.
 757         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 758         pthread_sigmask.
 759         * configure, config.in: Rebuild.
 760         * gdbsupport/block-signals.h: New file.
 761
 762 2019-11-26  Tom Tromey  <tom@tromey.com>
 763
 764         * acinclude.m4: Include ax_pthread.m4.
 765         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
 766         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
 767         (CLIBS): Use PTHREAD_LIBS.
 768         (aclocal_m4_deps): Add ax_pthread.m4.
 769         * config.in, configure: Rebuild.
 770         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
 771
 772 2019-11-26  Tom Tromey  <tom@tromey.com>
 773
 774         * symtab.h (struct minimal_symbol) <name_set>: New member.
 775         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
 776         Don't call symbol_set_names.
 777         (minimal_symbol_reader::install): Call symbol_set_names.
 778
 779 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 780
 781         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
 782         restore_active_ext_lang, as GIL is needed for (indirectly)
 783         called PyOS_InterruptOccurred.
 784
 785 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 786
 787         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
 788         definition.
 789
 790 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 791
 792         * remote-sim.c (simulator_command): Make static, remove
 793         declaration.
 794
 795 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 796
 797         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
 798         static.
 799         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
 800         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
 801         (main): Likewise.
 802         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
 803         (main): Likewise.
 804         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
 805         (main): Likewise.
 806         * unittests/basic_string_view/element_access/char/1.cc (test01):
 807         Likewise.
 808         (main): Likewise.
 809         * unittests/basic_string_view/element_access/char/empty.cc (main):
 810         Likewise.
 811         * unittests/basic_string_view/element_access/char/front_back.cc
 812         (test01): Likewise.
 813         (main): Likewise.
 814         * unittests/basic_string_view/inserters/char/2.cc (test05):
 815         Likewise.
 816         (main): Likewise.
 817         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
 818         (test01): Likewise.
 819         (main): Likewise.
 820         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
 821         (test01): Likewise.
 822         (main): Likewise.
 823         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
 824         Likewise.
 825         * unittests/basic_string_view/operations/compare/char/1.cc
 826         (test01): Likewise.
 827         (main): Likewise.
 828         * unittests/basic_string_view/operations/compare/char/13650.cc
 829         (test01): Likewise.
 830         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
 831         Likewise.
 832         (main): Likewise.
 833         * unittests/basic_string_view/operations/data/char/1.cc (test01):
 834         Likewise.
 835         (main): Likewise.
 836         * unittests/basic_string_view/operations/find/char/1.cc (test01):
 837         Likewise.
 838         (main): Likewise.
 839         * unittests/basic_string_view/operations/find/char/2.cc (test02):
 840         Likewise.
 841         (main): Likewise.
 842         * unittests/basic_string_view/operations/find/char/3.cc (test03):
 843         Likewise.
 844         (main): Likewise.
 845         * unittests/basic_string_view/operations/find/char/4.cc (main):
 846         Likewise.
 847         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
 848         Likewise.
 849         (main): Likewise.
 850         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
 851         Likewise.
 852         (main): Likewise.
 853         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
 854         Likewise.
 855         (main): Likewise.
 856         * unittests/basic_string_view/operations/substr/char/1.cc
 857         (test01): Likewise.
 858         (main): Likewise.
 859         * unittests/basic_string_view/operators/char/2.cc (main):
 860         Likewise.
 861         * unittests/optional/assignment/1.cc (test): Likewise.
 862         * unittests/optional/assignment/2.cc (test): Likewise.
 863         * unittests/optional/assignment/3.cc (test): Likewise.
 864         * unittests/optional/assignment/4.cc (test): Likewise.
 865         * unittests/optional/assignment/5.cc (test): Likewise.
 866         * unittests/optional/assignment/6.cc (test): Likewise.
 867         * unittests/optional/assignment/7.cc (test): Likewise.
 868         * unittests/optional/cons/copy.cc (test): Likewise.
 869         * unittests/optional/cons/default.cc (test): Likewise.
 870         * unittests/optional/cons/move.cc (test): Likewise.
 871         * unittests/optional/cons/value.cc (test): Likewise.
 872         * unittests/optional/in_place.cc (test): Likewise.
 873         * unittests/optional/observers/1.cc (test): Likewise.
 874         * unittests/optional/observers/2.cc (test): Likewise.
 875
 876 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 877
 878         * tui-win.h (tui_set_var_cmd): Remove.
 879         * tui-win.c (tui_set_var_cmd): Make static.
 880
 881 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 882
 883         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
 884         rbreak_command_wrapper): Remove.
 885         * symtab.c (rbreak_command_wrapper): Remove.
 886
 887 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 888
 889         * inferior.h (info_terminal_command): Remove declaration.
 890         * inflow.c (info_terminal_command): Make static.
 891
 892 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 893
 894         * inferior.c (exit_inferior_silent): Remove.
 895
 896 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 897
 898         * dictionary.c (dict_empty, mdict_empty): Remove.
 899         * dictionary.c (mdict_empty): Remove.
 900
 901 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 902
 903          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
 904          (arc_insn_get_memory_offset): Likewise.
 905          (arc_insn_dump): Likewise.
 906          * cp-support.c (test_cp_symbol_name_matches): Likewise.
 907          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
 908          * dictionary.c (dict_iterator_next): Likewise.
 909          (dict_iter_match_first): Likewise.
 910          (dict_iter_match_next): Likewise.
 911          * f-lang.c (evaluate_subexp_f): Likewise.
 912          * hppa-tdep.c (hppa_read_pc): Likewise.
 913          * i386-tdep.c (i386_floatformat_for_type): Likewise.
 914          * parse.c (write_exp_elt_msym): Likewise.
 915          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
 916          * remote.c (remote_packet_size): Likewise.
 917          (remote_notif_stop_parse): Likewise.
 918          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
 919          * s12z-tdep.c (s12z_disassemble_info): Likewise.
 920          * source.c (prepare_path_for_appending): Likewise.
 921          * sparc64-linux-tdep.c
 922          (sparc64_linux_handle_segmentation_fault); Likewise.
 923          * stack.c (frame_selection_by_function_completer): Likewise.
 924
 925 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 926
 927         * completer.c (set_gdb_completion_word_break_characters):
 928         Remove.
 929
 930 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 931
 932         * dwarf-index-write.c: Include dwarf-index-write.h.
 933         * mi/mi-interp.c: Include mi/mi-interp.h.
 934
 935 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 936
 937         * aarch32-tdep.c: Include aarch32-tdep.h.
 938         * aarch32-tdep.h: Forward-declare struct target_desc.
 939
 940 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 941
 942         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
 943         strerror.
 944         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
 945         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
 946
 947 2019-11-25  Tom de Vries  <tdevries@suse.de>
 948
 949         * contrib/words.sh: Add -c option.
 950
 951 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
 952
 953         * solib.c (solib_find_1): Change int to bool.
 954         (exec_file_find): Change int to bool.
 955         (solib_find): Change int to bool.
 956         (solib_read_symbols): Change int to bool.
 957         (solib_used): Change int to bool.
 958         (solib_add): Change int to bool.
 959         (info_sharedlibrary_command): Change int to bool.
 960         (solib_contains_address_p): Change int to bool.
 961         (solib_keep_data_in_core): Change int to bool.
 962         (in_solib_dynsym_resolve_code): Change int to bool.
 963         (reload_shared_libraries_1): Change int to bool.
 964         (gdb_sysroot_changed): Change int to bool.
 965         * solib.h (solib_read_symbols): Change int to bool.
 966         (solib_contains_address_p): Change int to bool.
 967         (solib_keep_data_in_core): Change int to bool.
 968         (in_solib_dynsym_resolve_code): Change int to bool.
 969         (libpthread_name_p): Change int to bool.
 970
 971 2019-11-25  Luis Machado  <luis.machado@linaro.org>
 972
 973         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
 974         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
 975         (remote_packet_max_chars): New static global.
 976         (show_remote_packet_max_chars): New function.
 977         (remote_target::putpkt_binary): Adjust to use new
 978         remote_packet_max_chars option.
 979         (remote_target::getpkt_or_notif_sane_1): Likewise.
 980         (_initialize_remote): Register new remote-packet-max-chars option.
 981
 982 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
 983
 984         * m68k-linux-nat.c: Include gdbarch.h.
 985
 986 2019-11-24  Tom Tromey  <tom@tromey.com>
 987
 988         * symfile.c (read_symbols): Update.
 989         * psymtab.c (require_partial_symbols): Change type of "verbose" to
 990         bool.
 991         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 992         (psym_lookup_symbol, psym_find_last_source_symtab)
 993         (psym_forget_cached_source_info, psym_print_stats)
 994         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 995         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 996         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 997         (psym_find_compunit_symtab_by_address)
 998         (maintenance_print_psymbols, maintenance_info_psymtabs)
 999         (maintenance_check_psymtabs): Update.
1000         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1001         bool.
1002
1003 2019-11-22  Tom Tromey  <tom@tromey.com>
1004
1005         * observable.h: Update comments.
1006
1007 2019-11-22  Tom Tromey  <tromey@adacore.com>
1008
1009         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1010         (print_ada_task_info): Don't try to fetch thread id if task is not
1011         alive.
1012
1013 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1014
1015         * ada-exp.y: Update.
1016         * ada-lang.c (sort_choices): Update.
1017         (ada_print_symbol_signature): Update.
1018         (resolve_subexp): Update.
1019         (ada_parse_renaming): Update.
1020         (ada_read_renaming_var_value): Update.
1021         (lesseq_defined_than): Update.
1022         (remove_extra_symbols): Update.
1023         (remove_irrelevant_renamings): Update.
1024         (ada_add_block_symbols): Update.
1025         (ada_collect_symbol_completion_matches): Update.
1026         (ada_is_renaming_symbol): Update.
1027         (aggregate_assign_from_choices): Update.
1028         (ada_evaluate_subexp): Update.
1029         (ada_has_this_exception_support): Update.
1030         (ada_is_non_standard_exception_sym): Update.
1031         (ada_add_exceptions_from_frame): Update.
1032         (ada_add_global_exceptions): Update.
1033         (ada_print_subexp): Update.
1034         * ax-gdb.c (gen_var_ref): Update.
1035         (gen_maybe_namespace_elt): Update.
1036         (gen_expr_for_cast): Update.
1037         (gen_expr): Update.
1038         * block.h: Update.
1039         * blockframe.c (find_pc_partial_function): Update.
1040         * breakpoint.c (print_breakpoint_location): Update.
1041         (update_static_tracepoint): Update.
1042         * btrace.c (ftrace_print_function_name): Update.
1043         (ftrace_function_switched): Update.
1044         * buildsym.c (find_symbol_in_list): Update.
1045         * c-exp.y: Update.
1046         * c-typeprint.c (c_print_typedef): Update.
1047         (c_type_print_template_args): Update.
1048         * cli/cli-cmds.c (edit_command): Update.
1049         (list_command): Update.
1050         (print_sal_location): Update.
1051         * coffread.c (patch_opaque_types): Update.
1052         (process_coff_symbol): Update.
1053         (coff_read_enum_type): Update.
1054         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1055         (convert_one_symbol): Update.
1056         (hash_symname): Update.
1057         (eq_symname): Update.
1058         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1059         * compile/compile-cplus-types.c (debug_print_scope): Update.
1060         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1061         * compile/compile-object-load.c (get_out_value_type): Update.
1062         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1063         (search_symbol_list): Update.
1064         (cp_lookup_symbol_imports_or_template): Update.
1065         * cp-support.c (overload_list_add_symbol): Update.
1066         * ctfread.c (psymtab_to_symtab): Update.
1067         * dbxread.c (cp_set_block_scope): Update.
1068         * dictionary.c (iter_match_first_hashed): Update.
1069         (iter_match_next_hashed): Update.
1070         (insert_symbol_hashed): Update.
1071         (iter_match_next_linear): Update.
1072         * dictionary.h: Update.
1073         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1074         (locexpr_describe_location_piece): Update.
1075         (locexpr_describe_location_1): Update.
1076         (locexpr_generate_c_location): Update.
1077         (loclist_describe_location): Update.
1078         (loclist_generate_c_location): Update.
1079         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1080         (read_func_scope): Update.
1081         (process_enumeration_scope): Update.
1082         (new_symbol): Update.
1083         (dwarf2_const_value): Update.
1084         (dwarf2_symbol_mark_computed): Update.
1085         * eval.c (evaluate_funcall): Update.
1086         (evaluate_subexp_standard): Update.
1087         * expprint.c (print_subexp_standard): Update.
1088         (dump_subexp_body_standard): Update.
1089         * f-valprint.c (info_common_command_for_block): Update.
1090         * findvar.c (get_hosting_frame): Update.
1091         (default_read_var_value): Update.
1092         * go-lang.c (go_symbol_package_name): Update.
1093         * guile/scm-block.c (bkscm_print_block_smob): Update.
1094         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1095         (gdbscm_symbol_name): Update.
1096         (gdbscm_symbol_linkage_name): Update.
1097         (gdbscm_symbol_print_name): Update.
1098         * infcall.c (get_function_name): Update.
1099         * infcmd.c (jump_command): Update.
1100         (finish_command): Update.
1101         * infrun.c (insert_exception_resume_breakpoint): Update.
1102         * linespec.c (canonicalize_linespec): Update.
1103         (create_sals_line_offset): Update.
1104         (convert_linespec_to_sals): Update.
1105         (complete_label): Update.
1106         (find_label_symbols_in_block): Update.
1107         * m2-typeprint.c (m2_print_typedef): Update.
1108         * mdebugread.c (mdebug_reg_to_regnum): Update.
1109         (parse_symbol): Update.
1110         (mylookup_symbol): Update.
1111         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1112         (list_args_or_locals): Update.
1113         * objc-lang.c (compare_selectors): Update.
1114         (info_selectors_command): Update.
1115         (compare_classes): Update.
1116         (info_classes_command): Update.
1117         (find_imps): Update.
1118         * p-typeprint.c (pascal_print_typedef): Update.
1119         * printcmd.c (build_address_symbolic): Update.
1120         (info_address_command): Update.
1121         (print_variable_and_value): Update.
1122         * python/py-framefilter.c (extract_sym): Update.
1123         (py_print_single_arg): Update.
1124         * python/py-symbol.c (sympy_str): Update.
1125         (sympy_get_name): Update.
1126         (sympy_get_linkage_name): Update.
1127         * python/python.c (gdbpy_rbreak): Update.
1128         * record-btrace.c (btrace_get_bfun_name): Update.
1129         (btrace_call_history): Update.
1130         * rust-lang.c (rust_print_typedef): Update.
1131         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1132         * stabsread.c (stab_reg_to_regnum): Update.
1133         (define_symbol): Update.
1134         (read_enum_type): Update.
1135         (common_block_end): Update.
1136         (cleanup_undefined_types_1): Update.
1137         (scan_file_globals): Update.
1138         * stack.c (print_frame_arg): Update.
1139         (print_frame_args): Update.
1140         (find_frame_funname): Update.
1141         (info_frame_command_core): Update.
1142         (iterate_over_block_locals): Update.
1143         (print_block_frame_labels): Update.
1144         (do_print_variable_and_value): Update.
1145         (iterate_over_block_arg_vars): Update.
1146         (return_command): Update.
1147         * symmisc.c (dump_symtab_1): Update.
1148         (print_symbol): Update.
1149         * symtab.c (eq_symbol_entry): Update.
1150         (symbol_cache_dump): Update.
1151         (lookup_language_this): Update.
1152         (find_pc_sect_line): Update.
1153         (skip_prologue_sal): Update.
1154         (symbol_search::compare_search_syms): Update.
1155         (treg_matches_sym_type_name): Update.
1156         (search_symbols): Update.
1157         (print_symbol_info): Update.
1158         (rbreak_command): Update.
1159         (completion_list_add_symbol): Update.
1160         (find_gnu_ifunc): Update.
1161         (get_symbol_address): Update.
1162         (search_module_symbols): Update.
1163         (info_module_subcommand): Update.
1164         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1165         (SYMBOL_LINKAGE_NAME): Remove.
1166         (SYMBOL_DEMANGLED_NAME): Remove.
1167         (SYMBOL_PRINT_NAME): Remove.
1168         (SYMBOL_SEARCH_NAME): Remove.
1169         * tracepoint.c (set_traceframe_context): Update.
1170         (validate_actionline): Update.
1171         (collection_list::collect_symbol): Update.
1172         (encode_actions_1): Update.
1173         (info_scope_command): Update.
1174         (print_one_static_tracepoint_marker): Update.
1175         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1176         * valops.c (address_of_variable): Update.
1177         (find_overload_match): Update.
1178         (find_oload_champ): Update.
1179
1180 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1181
1182         * ada-lang.c (ada_lookup_simple_minsym): Update.
1183         (ada_collect_symbol_completion_matches): Update.
1184         * ada-tasks.c (read_atcb): Update.
1185         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1186         (amd64_windows_skip_trampoline_code): Update.
1187         * arm-tdep.c (skip_prologue_function): Update.
1188         (arm_skip_stack_protector): Update.
1189         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1190         (arm_wince_skip_main_prologue): Update.
1191         * ax-gdb.c (gen_expr): Update.
1192         * block.c (call_site_for_pc): Update.
1193         * blockframe.c (find_pc_partial_function): Update.
1194         * breakpoint.c (set_breakpoint_location_function): Update.
1195         * btrace.c (ftrace_print_function_name): Update.
1196         (ftrace_function_switched): Update.
1197         * c-valprint.c (print_unpacked_pointer): Update.
1198         * coffread.c (coff_symfile_read): Update.
1199         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1200         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1201         * dwarf-index-write.c (write_psymbols): Update.
1202         * dwarf2loc.c (call_site_to_target_addr): Update.
1203         (func_verify_no_selftailcall): Update.
1204         (tailcall_dump): Update.
1205         (call_site_find_chain_1): Update.
1206         (dwarf_expr_reg_to_entry_parameter): Update.
1207         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1208         * eval.c (evaluate_funcall): Update.
1209         (evaluate_subexp_standard): Update.
1210         (evaluate_subexp_for_sizeof): Update.
1211         * expprint.c (print_subexp_standard): Update.
1212         (dump_subexp_body_standard): Update.
1213         * frame.c (get_prev_frame_always_1): Update.
1214         * frv-tdep.c (frv_skip_main_prologue): Update.
1215         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1216         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1217         (gnuv3_get_typename_from_type_info): Update.
1218         (gnuv3_skip_trampoline): Update.
1219         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1220         * i386-tdep.c (i386_skip_main_prologue): Update.
1221         (i386_pe_skip_trampoline_code): Update.
1222         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1223         * infcall.c (get_function_name): Update.
1224         * linespec.c (minsym_found): Update.
1225         * linux-fork.c (info_checkpoints_command): Update.
1226         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1227         (m32c_m16c_pointer_to_address): Update.
1228         * maint.c (maintenance_translate_address): Update.
1229         * minsyms.c (add_minsym_to_hash_table): Update.
1230         (add_minsym_to_demangled_hash_table): Update.
1231         (lookup_minimal_symbol_mangled): Update.
1232         (lookup_minimal_symbol_demangled): Update.
1233         (lookup_minimal_symbol_linkage): Update.
1234         (lookup_minimal_symbol_text): Update.
1235         (lookup_minimal_symbol_by_pc_name): Update.
1236         (minimal_symbol_is_less_than): Update.
1237         (compact_minimal_symbols): Update.
1238         (build_minimal_symbol_hash_tables): Update.
1239         (find_solib_trampoline_target): Update.
1240         * mips-tdep.c (mips_stub_frame_sniffer): Update.
1241         (mips_skip_pic_trampoline_code): Update.
1242         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1243         * objc-lang.c (info_selectors_command): Update.
1244         (info_classes_command): Update.
1245         (find_methods): Update.
1246         (find_imps): Update.
1247         * p-valprint.c (pascal_val_print): Update.
1248         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1249         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1250         * printcmd.c (build_address_symbolic): Update.
1251         (info_symbol_command): Update.
1252         * psymtab.c (psymbol_name_matches): Update.
1253         (match_partial_symbol): Update.
1254         (lookup_partial_symbol): Update.
1255         (print_partial_symbols): Update.
1256         (sort_pst_symbols): Update.
1257         (maintenance_check_psymtabs): Update.
1258         * python/py-framefilter.c (py_print_frame): Update.
1259         * python/python.c (gdbpy_rbreak): Update.
1260         * record-btrace.c (btrace_get_bfun_name): Update.
1261         (btrace_call_history): Update.
1262         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1263         (rs6000_skip_trampoline_code): Update.
1264         * sol-thread.c (info_cb): Update.
1265         * stabsread.c (scan_file_globals): Update.
1266         * stack.c (find_frame_funname): Update.
1267         (info_frame_command_core): Update.
1268         * symmisc.c (dump_msymbols): Update.
1269         * symtab.c (symbol_natural_name): Rename to..,
1270         (general_symbol_info::natural_name): ...this.
1271         (symbol_demangled_name): Rename to...
1272         (general_symbol_info::demangled_name): ...this.
1273         (symbol_search_name): Rename to...
1274         (general_symbol_info::search_name): ...this.
1275         (symbol_matches_search_name): Update.
1276         (find_pc_sect_line): Update.
1277         (skip_prologue_sal): Update.
1278         (search_symbols): Update.
1279         (print_msymbol_info): Update.
1280         (rbreak_command): Update.
1281         (completion_list_add_msymbol): Update.
1282         (completion_list_objc_symbol): Update.
1283         (get_msymbol_address): Update.
1284         * symtab.h (struct general_symbol_info): Add member functions
1285         natural_name (), linkage_name (), print_name (), demangled_name (),
1286         and search_name ().
1287         (SYMBOL_NATURAL_NAME): Update.
1288         (symbol_natural_name): Move to a member function on general_symbol_info.
1289         (SYMBOL_DEMANGLED_NAME): Update.
1290         (symbol_demangled_name): Move to a member function on
1291         general_symbol_info.
1292         (SYMBOL_SEARCH_NAME): Update.
1293         (symbol_search_name): Move to a member function on general_symbol_info.
1294         (MSYMBOL_NATURAL_NAME): Remove.
1295         (MSYMBOL_LINKAGE_NAME): Remove.
1296         (MSYMBOL_PRINT_NAME): Remove.
1297         (MSYMBOL_DEMANGLED_NAME): Remove.
1298         (MSYMBOL_SEARCH_NAME): Remove.
1299         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1300
1301 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1302
1303         * symtab.c (create_demangled_names_hash): Use per_bfd->
1304         minimal_symbol_count for computing the initial size, if greater
1305         than our default size.
1306
1307 2019-11-22  Tom de Vries  <tdevries@suse.de>
1308
1309         * contrib/words.sh: Improve words extraction.
1310
1311 2019-11-22  Tom de Vries  <tdevries@suse.de>
1312
1313         * contrib/words.sh: Combine sed invocations.
1314
1315 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
1316
1317         * Makefile.in: Update.
1318         * demangle.c: Rename to...
1319         * gdb-demangle.c: ..this.
1320         (is_cplus_marker): Change return type to bool.
1321         (_initialize_demangler): Rename to...
1322         (_initialize_gdb_demangle): ...this.
1323         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1324         * symtab.h (demangle): Remove declaration; instead include
1325         gdb-demangle.h.
1326
1327 2019-11-21  Tom Tromey  <tromey@adacore.com>
1328
1329         * gdbsupport/format.c (format_pieces): Parse %I64d.
1330         * unittests/format_pieces-selftests.c (test_windows_formats): New
1331         function.
1332         (run_tests): Call it.
1333
1334 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
1335
1336         Byte reverse display of variables with DW_END_big, DW_END_little
1337         (DW_AT_endianity) dwarf attributes if different than the native
1338         byte order.
1339         * ada-lang.c (ada_value_binop):
1340         Use type_byte_order instead of gdbarch_byte_order.
1341         * ada-valprint.c (printstr):
1342         (ada_val_print_string):
1343         * ada-lang.c (value_pointer):
1344         (ada_value_binop):
1345         Use type_byte_order instead of gdbarch_byte_order.
1346         * c-lang.c (c_get_string):
1347         Use type_byte_order instead of gdbarch_byte_order.
1348         * c-valprint.c (c_val_print_array):
1349         Use type_byte_order instead of gdbarch_byte_order.
1350         * cp-valprint.c (cp_print_class_member):
1351         Use type_byte_order instead of gdbarch_byte_order.
1352         * dwarf2loc.c (rw_pieced_value):
1353         Use type_byte_order instead of gdbarch_byte_order.
1354         * dwarf2read.c (read_base_type): Handle DW_END_big,
1355         DW_END_little
1356         * f-lang.c (f_get_encoding):
1357         Use type_byte_order instead of gdbarch_byte_order.
1358         * findvar.c (default_read_var_value):
1359         Use type_byte_order instead of gdbarch_byte_order.
1360         * gdbtypes.c (check_types_equal):
1361         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1362         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1363         and TYPE_ENDIANITY_LITTLE if set.
1364         (type_byte_order): new function.
1365         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1366         (struct main_type) <flag_endianity_not_default>:
1367         New field.
1368         (type_byte_order): New function.
1369         * infcmd.c (default_print_one_register_info):
1370         Use type_byte_order instead of gdbarch_byte_order.
1371         * p-lang.c (pascal_printstr):
1372         Use type_byte_order instead of gdbarch_byte_order.
1373         * p-valprint.c (pascal_val_print):
1374         Use type_byte_order instead of gdbarch_byte_order.
1375         * printcmd.c (print_scalar_formatted):
1376         Use type_byte_order instead of gdbarch_byte_order.
1377         * solib-darwin.c (darwin_current_sos):
1378         Use type_byte_order instead of gdbarch_byte_order.
1379         * solib-svr4.c (solib_svr4_r_ldsomap):
1380         Use type_byte_order instead of gdbarch_byte_order.
1381         * stap-probe.c (stap_modify_semaphore):
1382         Use type_byte_order instead of gdbarch_byte_order.
1383         * target-float.c (target_float_same_format_p):
1384         Use type_byte_order instead of gdbarch_byte_order.
1385         * valarith.c (scalar_binop):
1386         (value_bit_index):
1387         Use type_byte_order instead of gdbarch_byte_order.
1388         * valops.c (value_cast):
1389         Use type_byte_order instead of gdbarch_byte_order.
1390         * valprint.c (generic_emit_char):
1391         (generic_printstr):
1392         (val_print_string):
1393         Use type_byte_order instead of gdbarch_byte_order.
1394         * value.c (unpack_long):
1395         (unpack_bits_as_long):
1396         (unpack_value_bitfield):
1397         (modify_field):
1398         (pack_long):
1399         (pack_unsigned_long):
1400         Use type_byte_order instead of gdbarch_byte_order.
1401         * findvar.c (unsigned_pointer_to_address):
1402         (signed_pointer_to_address):
1403         (unsigned_address_to_pointer):
1404         (address_to_signed_pointer):
1405         (default_read_var_value):
1406         (default_value_from_register):
1407         Use type_byte_order instead of gdbarch_byte_order.
1408         * gnu-v3-abi.c (gnuv3_make_method_ptr):
1409         Use type_byte_order instead of gdbarch_byte_order.
1410         * riscv-tdep.c (riscv_print_one_register_info):
1411         Use type_byte_order instead of gdbarch_byte_order.
1412
1413 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
1414
1415         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1416         (current_ui_gdb_stdin_ptr): Likewise.
1417         (current_ui_gdb_stderr_ptr): Likewise.
1418         (current_ui_gdb_stdlog_ptr): Likewise.
1419         (current_ui_current_uiout_ptr): Likewise.
1420         (gen_ret_current_ui_field_ptr): Remove.
1421
1422 2019-11-21  Tom de Vries  <tdevries@suse.de>
1423
1424         PR gdb/24956
1425         * cli/cli-script.c (execute_control_command): Only switch to
1426         INTERP_CONSOLE's ui_out when INTERP_MI is active.
1427
1428 2019-11-19  Tom Tromey  <tom@tromey.com>
1429
1430         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1431         Now static.  Change type of "name".
1432         (tui_set_win_height_command): Don't copy "arg".
1433         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1434         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1435
1436 2019-11-19  Ali Tamur <tamur@google.com>
1437
1438         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1439         "if (attr != nullptr)".
1440         (dwarf2_find_base_address): Likewise.
1441         (dwarf2_build_include_psymtabs): Likewise.
1442         (read_cutu_die_from_dwo): Likewise.
1443         (read_func_scope): Likewise.
1444         (read_call_site_scope): Likewise.
1445         (dwarf2_get_pc_bounds): Likewise.
1446         (dwarf2_record_block_ranges): Likewise.
1447         (dwarf2_add_field): Likewise.
1448         (dwarf2_add_member_fn): Likewise.
1449         (read_structure_type): Likewise.
1450         (read_enumeration_type): Likewise.
1451         (read_array_type): Likewise.
1452         (read_array_order): Likewise.
1453         (read_set_type): Likewise.
1454         (read_common_block): Likewise.
1455         (read_tag_reference_type): Likewise.
1456         (read_tag_string_type): Likewise.
1457         (read_subroutine_type): Likewise.
1458         (read_base_type): Likewise.
1459         (read_subrange_type): Likewise.
1460         (new_symbol): Likewise.
1461         (prepare_one_comp_unit): Likewise.
1462
1463 2019-11-19  Tom Tromey  <tromey@adacore.com>
1464
1465         * windows-nat.c (windows_nat_target::attach): Include GetLastError
1466         result in error when DebugActiveProcess fails.
1467
1468 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
1469             Pedro Alves  <palves@redhat.com>
1470
1471         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1472         * target.c (target_stack::push): Call 'unpush' if there's a
1473         target on top of the stack.
1474
1475 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1476
1477         * python/py-block.c (blpy_dealloc): Call tp_free.
1478         (blpy_block_syms_dealloc): Likewise.
1479         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1480         * python/py-inferior.c (infpy_dealloc): Likewise.
1481         * python/py-lazy-string.c (stpy_dealloc): Likewise.
1482         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1483         * python/py-symbol.c (sympy_dealloc): Likewise.
1484         * python/py-symtab.c (stpy_dealloc): Likewise.
1485         * python/py-type.c (typy_iterator_dealloc): Likewise.
1486
1487 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
1488
1489         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1490         constructor instead of using a class initializer.
1491
1492 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1493
1494         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1495         * configure: Regenerate.
1496         * configure.ac: Don't source common.host.
1497         * gdbsupport/common.host: Remove.
1498         * gdbsupport/mingw-strerror.c: Remove.
1499         * gdbsupport/posix-strerror.c: Rename to...
1500         * gdbsupport/safe-strerror.c: ...this.
1501
1502 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1503
1504         * maint.c (scoped_command_stats::print_time): Use localtime_r
1505         instead of localtime (provided through gnulib if necessary).
1506         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1507         of ctime.
1508
1509 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1510
1511         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1512         avoid compile errors.
1513
1514 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1515
1516         * config.in: Regenerate.
1517         * configure: Regenerate.
1518         * gdbsupport/common.m4: No longer check for strerror_r.
1519         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1520         POSIX version of strerror_r, now that gnulib provides it if
1521         necessary.
1522
1523 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
1524
1525         * README (`configure' options): Update.
1526
1527 2019-11-14  Tom Tromey  <tromey@adacore.com>
1528
1529         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1530         expected type for the RHS if the LHS is a convenience variable.
1531
1532 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
1533
1534         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1535         Provide explicit default and copy constructor.
1536
1537 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1538
1539         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1540         only call Py_INCREF (newbp) in the bppy_pending_object case.
1541
1542 2019-11-13  Tom Tromey  <tromey@adacore.com>
1543
1544         PR build/25182:
1545         * psympriv.h (partial_symbol): Remove static assert.
1546         * symtab.h (general_symbol_info, symbol): Remove static assert.
1547
1548 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1549
1550         * gdbsupport/format.c (format_pieces::format_pieces): Support
1551         printf 'z' size modifier.
1552         * gdbsupport/format.h (enum argclass): Add size_t_arg.
1553         * printcmd.c (ui_printf):  Handle size_t_arg.
1554         * ui-out.c (ui_out::vmessage): Likewise.
1555         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1556         function.
1557         (run_tests): Call test_format_int_sizes.
1558
1559 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
1560
1561         * ada-exp.y (write_ambiguous_var): Update.
1562         * buildsym.c (add_symbol_to_list): Update.
1563         * dwarf2read.c (read_variable): Update.
1564         (new_symbol): Update.
1565         * jit.c (finalize_symtab): Update.
1566         * language.c (language_alloc_type_symbol): Update.
1567         * symtab.c (fixup_symbol_section): Update.
1568         (initialize_objfile_symbol_1): Move code to...
1569         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1570         (allocate_symbol): Update.
1571         (allocate_template_symbol): Update.
1572         (get_symbol_address): Update.
1573         * symtab.h (struct symbol): Inherit from general_symbol_info instead
1574         of having as a field, and add a constructor.
1575         (SYMBOL_VALUE): Update.
1576         (SYMBOL_VALUE_ADDRESS): Update.
1577         (SET_SYMBOL_VALUE_ADDRESS): Update.
1578         (SYMBOL_VALUE_BYTES): Update.
1579         (SYMBOL_VALUE_COMMON_BLOCK): Update.
1580         (SYMBOL_BLOCK_VALUE): Update.
1581         (SYMBOL_VALUE_CHAIN): Update.
1582         (SYMBOL_LANGUAGE): Update.
1583         (SYMBOL_SECTION): Update.
1584         (SYMBOL_OBJ_SECTION): Update.
1585         (SYMBOL_SET_LANGUAGE): Update.
1586         (SYMBOL_SET_LINKAGE_NAME): Update.
1587         (SYMBOL_SET_NAMES): Update.
1588         (SYMBOL_NATURAL_NAME): Update.
1589         (SYMBOL_LINKAGE_NAME): Update.
1590         (SYMBOL_DEMANGLED_NAME): Update.
1591         (SYMBOL_SEARCH_NAME): Update.
1592         (SYMBOL_MATCHES_SEARCH_NAME): Update.
1593         (struct symbol): Update.
1594         (struct template_symbol): Update.
1595         (struct rust_vtable_symbol): Update.
1596         * xcoffread.c (SYMBOL_DUP): Update.
1597
1598 2019-11-12  Tom Tromey  <tom@tromey.com>
1599
1600         * tui/tui-layout.c (show_layout): Set current_layout.
1601         (show_source_disasm_command, show_data)
1602         (show_source_or_disasm_and_command): Don't set current_layout.
1603
1604 2019-11-12  Tom Tromey  <tom@tromey.com>
1605
1606         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1607
1608 2019-11-12  Tom Tromey  <tom@tromey.com>
1609
1610         * tui/tui-win.c (resize_message): New global.
1611         (show_tui_resize_message): New function.
1612         (tui_async_resize_screen): Print message if requested.
1613         (_initialize_tui_win): Add tui-resize-message setting.
1614         * NEWS: Add entry for new commands.
1615
1616 2019-11-11  Tom Tromey  <tom@tromey.com>
1617
1618         * tui/tui.c (tui_initialize_readline): Add new bindable readline
1619         functions.
1620
1621 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
1622
1623         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1624
1625 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1626
1627         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1628         function.
1629         * python/python-internal.h (gdbpy_lookup_static_symbols):
1630         Declare new function.
1631         * python/python.c (python_GdbMethods): Add
1632         gdb.lookup_static_symbols method.
1633         * NEWS: Mention gdb.lookup_static_symbols.
1634
1635 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1636
1637         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1638         static block of current object file first.  Also fix typo in
1639         header comment.
1640
1641 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1642
1643         * stack.c (set_last_displayed_sal): Delete.
1644         (last_displayed_sal_valid): Delete.
1645         (last_displayed_pspace): Delete.
1646         (last_displayed_addr): Delete.
1647         (last_displayed_symtab): Delete.
1648         (last_displayed_line): Delete.
1649         (class last_displayed_symtab_info_type): New.
1650         (last_displayed_symtab_info): New static global variable.
1651         (print_frame_info): Call methods on last_displayed_symtab_info.
1652         (clear_last_displayed_sal): Update header comment, and make use of
1653         last_displayed_symtab_info.
1654         (last_displayed_sal_is_valid): Likewise.
1655         (get_last_displayed_pspace): Likewise.
1656         (get_last_displayed_addr): Likewise.
1657         (get_last_displayed_symtab): Likewise.
1658         (get_last_displayed_line): Likewise.
1659         (get_last_displayed_sal): Likewise.
1660         * stack.h (clear_last_displayed_sal): Update header comment.
1661         (last_displayed_sal_is_valid): Likewise.
1662         (get_last_displayed_pspace): Likewise.
1663         (get_last_displayed_addr): Likewise.
1664         (get_last_displayed_symtab): Likewise.
1665         (get_last_displayed_line): Likewise.
1666         (get_last_displayed_sal): Likewise.
1667
1668 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1669
1670         * stack.c (frame_show_address): Convert return type to bool.
1671         * stack.h (frame_show_address): Likewise, and update header
1672         comment.
1673
1674 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1675
1676         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1677         * unittests/vec-utils-selftests.c: New file.
1678         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1679
1680 2019-11-10  Tom Tromey  <tom@tromey.com>
1681
1682         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1683         (tui_highlight_win): Likewise.
1684         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1685         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1686         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1687         Don't set can_highlight.
1688
1689 2019-11-10  Tom Tromey  <tom@tromey.com>
1690
1691         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1692         Remove unused declaration.
1693
1694 2019-11-08  Tom Tromey  <tromey@adacore.com>
1695
1696         * top.c (read_command_file): Update.
1697         (command_line_input): Make return type const.
1698         * python/py-gdb-readline.c: Update.
1699         * linespec.c (decode_line_2): Update.
1700         * defs.h (command_line_input): Make return type const.
1701         * cli/cli-script.c (read_next_line): Make return type const.
1702         * ada-lang.c (get_selections): Update.
1703
1704 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
1705
1706         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1707         * mi/mi-main.c (output_cores): Likewise.
1708         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1709         (linux_xfer_osdata_modules): Likewise.
1710         * remote.c (register_remote_support_xml): Likewise.
1711         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1712         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1713
1714 2019-11-06  Tom Tromey  <tom@tromey.com>
1715
1716         * tui/tui-interp.c: Don't include readline.h.
1717         * tui/tui-hooks.c: Don't include readline.h.
1718         * symmisc.c: Include tilde.h, not readline.h.
1719         * symfile.c: Include tilde.h, not readline.h.
1720         * source.c: Include tilde.h, not readline.h.
1721         * solib.c: Include tilde.h, not readline.h.
1722         * psymtab.c: Include tilde.h, not readline.h.
1723         * exec.c: Include tilde.h, not readline.h.
1724         * corelow.c: Include tilde.h, not readline.h.
1725         * cli/cli-dump.c: Include tilde.h, not readline.h.
1726         * cli/cli-cmds.c: Don't include readline.h.
1727
1728 2019-11-05  Tom Tromey  <tom@tromey.com>
1729
1730         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1731         (tui_disassemble): Set addr_size.
1732         (tui_disasm_window::set_contents): Use addr_size.
1733
1734 2019-11-05  Tom Tromey  <tom@tromey.com>
1735
1736         * rust-lang.c (rust_language_defn): Update.
1737         * python/py-value.c (valpy_string): Call c_get_string.
1738         * p-lang.c (pascal_language_defn): Update.
1739         * opencl-lang.c (opencl_language_defn): Update.
1740         * objc-lang.c (objc_language_defn): Update.
1741         * m2-lang.c (m2_language_defn): Update.
1742         * language.c (unknown_language_defn, auto_language_defn): Update.
1743         (default_get_string): Remove.
1744         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1745         * go-lang.c (go_language_defn): Update.
1746         * f-lang.c (f_language_defn): Update.
1747         * d-lang.c (d_language_defn): Update.
1748         * c-lang.c (c_language_defn, cplus_language_defn)
1749         (asm_language_defn, minimal_language_defn): Update.
1750         * ada-lang.c (ada_language_defn): Update.
1751         * language.h (struct language_defn) <la_get_string>: Remove.
1752         (LA_GET_STRING): Remove.
1753         (default_get_string): Don't declare.
1754
1755 2019-11-05  Tom Tromey  <tom@tromey.com>
1756
1757         * tui/tui-source.h (struct tui_source_window): Inline
1758         constructor.  Remove destructor.
1759         <style_changed, m_observable>: Move to superclass.
1760         * tui/tui-winsource.h (tui_copy_source_line): Declare.
1761         (struct tui_source_window_base): Move private members to end.
1762         <style_changed, m_observable>: Move from tui_source_window.
1763         * tui/tui-winsource.c (tui_copy_source_line): Move from
1764         tui-source.c.  Rename from copy_source_line.  Add special handling
1765         for negative line number.
1766         (tui_source_window_base::style_changed): Move from
1767         tui_source_window.
1768         (tui_source_window_base): Register observer.
1769         (~tui_source_window_base): New.
1770         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1771         rename.
1772         (tui_source_window::set_contents): Use tui_copy_source_line.
1773         (tui_source_window::tui_source_window): Move to tui-source.h.
1774         (tui_source_window::~tui_source_window): Remove.
1775         (tui_source_window::style_changed): Move to superclass.
1776         * tui/tui-disasm.c (tui_disassemble): Create string file with
1777         styling, when possible.  Add "addr_size" parameter.
1778         (tui_disasm_window::set_contents): Use tui_copy_source_line.
1779         Don't compute maximum size.
1780         (len_without_escapes): New function
1781
1782 2019-11-05  Tom Tromey  <tom@tromey.com>
1783
1784         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1785         std::string.
1786         * tui/tui-winsource.c (tui_show_source_line): Update.
1787         * tui/tui-source.c (tui_source_window::set_contents): Update.
1788         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1789
1790 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
1791
1792         * symtab.h (gdb_static_assert): Put && operator at the beginning
1793         of the line instead of the end.
1794
1795 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
1796
1797         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1798         and sizeof (symbol).
1799         * symtab.h: Add a static_assert for sizeof (partial_symbol).
1800
1801 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1802
1803         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1804         * configure.host: Mark *-*-solaris2.10* obsolete.
1805         * configure.tgt: Mark Solaris < 11 obsolete.
1806         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1807         Update target triplet.
1808
1809 2019-11-01  Tom Tromey  <tromey@adacore.com>
1810
1811         * utils.c (print_sys_errmsg): Simplify.
1812
1813 2019-11-01  Tom Tromey  <tromey@adacore.com>
1814
1815         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1816
1817 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
1818
1819         * configure: Regenerate.
1820         * configure.ac: Remove check for strerror_r.
1821         * gdbsupport/common.m4: Check for strerror_r.
1822
1823 2019-11-01  Luis Machado  <luis.machado@linaro.org>
1824
1825         PR gdb/25124
1826
1827         * arm-tdep.c (arm_per_objfile): Rename to ...
1828         (arm_per_bfd): ... this.
1829         (arm_objfile_data_key): Rename to ...
1830         (arm_bfd_data_key): ... this.
1831         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1832         data.
1833         (arm_record_special_symbol): Likewise.
1834
1835 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1836
1837         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1838         end.
1839         * c-typeprint.c (c_print_typedef): Likewise.
1840         * f-typeprint.c (f_print_typedef): Likewise.
1841         * m2-typeprint.c (m2_print_typedef): Likewise.
1842         * p-typeprint.c (pascal_print_typedef): Likewise.
1843         * rust-lang.c (rust_print_typedef): Likewise.
1844         * symtab.c (print_symbol_info): Print a newline after calling
1845         typedef_print.
1846
1847 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1848
1849         * symtab.c (info_module_cmdlist): New variable.
1850         (info_module_command): New function.
1851         (search_module_symbols): New function.
1852         (info_module_subcommand): New function.
1853         (struct info_modules_var_func_options): New struct.
1854         (info_modules_var_func_options_defs): New variable.
1855         (make_info_modules_var_func_options_def_group): New function.
1856         (info_module_functions_command): New function.
1857         (info_module_variables_command): New function.
1858         (info_module_var_func_command_completer): New function.
1859         (_initialize_symtab): Register new 'info module functions' and
1860         'info module variables' commands.
1861         * symtab.h (typedef symbol_search_in_module): New typedef.
1862         (search_module_symbols): Declare new function.
1863         * NEWS: Mention new commands.
1864
1865 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1866
1867         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1868         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1869         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1870         MODULES_DOMAIN.
1871         (scan_partial_symbols): Only create partial module symbols for non
1872         declarations.
1873         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1874         and MODULES_DOMAIN.
1875         * symtab.c (search_domain_name): Likewise.
1876         (search_symbols): Likewise.
1877         (print_symbol_info): Likewise.
1878         (symtab_symbol_info): Likewise.
1879         (info_modules_command): New function.
1880         (_initialize_symtab): Register 'info modules' command.
1881         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1882         * NEWS: Mention new 'info modules' command.
1883
1884 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1885
1886         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1887         and $_gdb_maint_setting_str.
1888
1889 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1890
1891         * cli/cli-cmds.c (setting_cmd, value_from_setting)
1892         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1893         (str_value_from_setting, gdb_setting_str_internal_fn)
1894         (gdb_maint_setting_str_internal_fn): New functions.
1895         (_initialize_cli_cmds): Define the new convenience functions.
1896         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1897         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1898
1899 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1900
1901         * agent.c (set_can_use_agent): When the setting is turned on,
1902         look up agent symbols if we don't have them yet.
1903         (agent_new_objfile): Don't look up agent symbols when the agent
1904         setting is off.
1905
1906 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1907
1908         * config.in: Regenerate.
1909
1910 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1911
1912         * configure: Regenerate.
1913         * configure.ac: Check for strerror_r.
1914         * gdbsupport/common-utils.h (safe_strerror): Change return value
1915         to const char * and document that this function is now threadsafe.
1916         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1917         thread_local and call strerror_r, if available.
1918         * utils.c (perror_string): Update.
1919         (print_sys_errmsg): Update.
1920
1921 2019-10-31  Luis Machado  <luis.machado@linaro.org>
1922
1923         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
1924         objfile_key.
1925         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
1926         objfile to fetch per-bfd data.
1927         (arm_find_exidx_entry): Likewise.
1928
1929 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1930
1931         * gdbsupport/agent.c (debug_agent): Change type to bool.
1932         (use_agent): Likewise.
1933         (all_agent_symbols_look_up): Likewise.
1934         (agent_loaded_p): Change return value to bool.
1935         (agent_look_up_symbols): Update.
1936         (agent_capability_check): Change return value to bool.
1937         * gdbsupport/agent.h (agent_loaded_p): Likewise.
1938         (debug_agent): Change type to bool.
1939         (use_agent): Likewise.
1940         (agent_capability_check): Change return value to bool.
1941
1942 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
1943
1944         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
1945         (build_minimal_symbol_hash_tables): Code to clear the table moved
1946         to clear_minimal_symbol_hash_tables.
1947         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
1948         when needed.
1949
1950 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1951
1952         * infcmd.c: Remove includes.
1953         * infrun.c: Remove includes.
1954
1955 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1956
1957         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
1958         (grow_vect): Remove declaration.
1959         (ada_type_of_array): Remove declaration.
1960         (ada_update_initial_language): Remove declaration.
1961         (ada_fold_name): Remove declaration.
1962         (ada_fill_in_ada_prototype): Remove declaration.
1963         (user_select_syms): Remove declaration.
1964         (get_selections): Remove declaration.
1965         (ada_tag_type): Remove declaration.
1966         (ada_value_tag): Remove declaration.
1967         (ada_is_others_clause): Remove declaration.
1968         (ada_in_variant): Remove declaration.
1969         (ada_value_struct_elt): Remove declaration.
1970         (ada_attribute_name): Remove declaration.
1971         (ada_system_address_type): Remove declaration.
1972         * ada-lang.c (ada_watch_location_expression): Make static.
1973         (GROW_VECT): Move here from ada-lang.h.
1974         (grow_vect): Make static.
1975         (ada_update_initial_language): Make static.
1976         (ada_fold_name): Make static.
1977         (ada_type_of_array): Make static.
1978         (encoded_ordered_before): Move up.
1979         (sort_choices): Move up.
1980         (print_signatures): Move up.
1981         (ada_print_symbol_signature): Move up.
1982         (get_selections): Move up and make static.
1983         (user_select_syms): Move up and make static.
1984         (ada_value_struct_elt): Move up and make static.
1985         (ada_tag_type): Make static.
1986         (ada_value_tag): Make static.
1987         (ada_is_others_clause): Make static.
1988         (ada_in_variant): Make static.
1989         (ada_attribute_name): Make static.
1990
1991 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1992
1993         * ada-lang.c: Remove includes.
1994         * ada-typeprint.c: Remove includes.
1995         * ada-valprint.c: Remove includes.
1996
1997 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
1998
1999         * addrmap.c: Add static assertions of type size, moved from
2000         _initialize_addrmap.
2001         (_initialize_addrmap): Remove.
2002
2003 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2004
2005         * coffread.c (record_minimal_symbol): Update.
2006         (process_coff_symbol): Update.
2007         * dbxread.c (read_dbx_symtab): Update.
2008         * dwarf2read.c (add_partial_symbol): Update.
2009         (fixup_go_packaging): Update.
2010         (load_partial_dies): Update.
2011         (new_symbol): Update.
2012         * elfread.c (record_minimal_symbol): Change signature to use
2013         gdb::string_view instead of name+len.
2014         (elf_symtab_read): Update.
2015         (elf_rel_plt_read): Update.
2016         * mdebugread.c (parse_partial_symbols): Update.
2017         (handle_psymbol_enumerators): Update.
2018         (new_symbol): Update.
2019         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2020         to use gdb::string_view instead of name+len.
2021         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2022         * psympriv.h (add_psymbol_to_list): Likewise.
2023         * psymtab.c (add_psymbol_to_bcache): Likewise.
2024         (add_psymbol_to_list): Likewise.
2025         * stabsread.c (define_symbol): Update.
2026         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2027         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2028         (symbol_set_names): Likewise.
2029         * xcoffread.c (scan_xcoff_symtab): Update.
2030
2031 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2032
2033         * symtab.h (symbol_set_names): Document that copy_name must be
2034         set to true for non-nullterminated strings.
2035         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2036         linkage_name if the entry was not found and we need to demangle.
2037
2038 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2039
2040         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2041         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2042         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2043         * gdbsupport/gdb_binary_search.h: New file.
2044
2045 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2046
2047         * NEWS: Mention new --with-system-gdbinit-dir option.
2048         * config.in: Regenerate.
2049         * configure: Regenerate.
2050         * configure.ac: Add new option --with-system-gdbinit-dir.
2051         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2052         for a ".gdb" suffix.
2053         * main.c (get_init_files): Change system_gdbinit argument to
2054         a vector and return the files in SYSTEM_GDBINIT_DIR in
2055         addition to SYSTEM_GDBINIT.
2056         (captured_main_1): Update.
2057         (print_gdb_help): Update.
2058         * top.c (print_gdb_configuration): Also print the value of
2059         SYSTEM_GDBINIT_DIR.
2060
2061 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2062
2063         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2064         that takes gdb::string_view arguments.
2065
2066 2019-10-26  Tom de Vries  <tdevries@suse.de>
2067
2068         * aarch64-linux-tdep.c: Fix typos in comments.
2069         * aarch64-tdep.c: Same.
2070         * ada-lang.c: Same.
2071         * amd64-nat.c: Same.
2072         * arc-tdep.c: Same.
2073         * arch/aarch64-insn.c: Same.
2074         * block.c: Same.
2075         * breakpoint.h: Same.
2076         * btrace.h: Same.
2077         * c-varobj.c: Same.
2078         * cli/cli-decode.c: Same.
2079         * cli/cli-script.c: Same.
2080         * cli/cli-utils.h: Same.
2081         * coff-pe-read.c: Same.
2082         * coffread.c: Same.
2083         * compile/compile-cplus-symbols.c: Same.
2084         * compile/compile-object-run.c: Same.
2085         * completer.c: Same.
2086         * corelow.c: Same.
2087         * cp-support.c: Same.
2088         * demangle.c: Same.
2089         * dwarf-index-write.c: Same.
2090         * dwarf2-frame.c: Same.
2091         * dwarf2-frame.h: Same.
2092         * eval.c: Same.
2093         * frame-base.h: Same.
2094         * frame.h: Same.
2095         * gdbcmd.h: Same.
2096         * gdbtypes.h: Same.
2097         * gnu-nat.c: Same.
2098         * guile/scm-objfile.c: Same.
2099         * i386-tdep.c: Same.
2100         * i386-tdep.h: Same.
2101         * infcall.c: Same.
2102         * infcall.h: Same.
2103         * linux-nat.c: Same.
2104         * m68k-tdep.c: Same.
2105         * macroexp.c: Same.
2106         * memattr.c: Same.
2107         * mi/mi-cmd-disas.c: Same.
2108         * mi/mi-getopt.h: Same.
2109         * mi/mi-main.c: Same.
2110         * minsyms.c: Same.
2111         * nat/aarch64-sve-linux-sigcontext.h: Same.
2112         * objfiles.h: Same.
2113         * ppc-linux-nat.c: Same.
2114         * ppc-linux-tdep.c: Same.
2115         * ppc-tdep.h: Same.
2116         * progspace.h: Same.
2117         * prologue-value.h: Same.
2118         * python/py-evtregistry.c: Same.
2119         * python/py-instruction.h: Same.
2120         * record-btrace.c: Same.
2121         * record-full.c: Same.
2122         * remote.c: Same.
2123         * rs6000-tdep.c: Same.
2124         * ser-tcp.c: Same.
2125         * sol-thread.c: Same.
2126         * sparc-sol2-tdep.c: Same.
2127         * sparc64-tdep.c: Same.
2128         * stabsread.c: Same.
2129         * symfile.c: Same.
2130         * symtab.h: Same.
2131         * target.c: Same.
2132         * tracepoint.c: Same.
2133         * tui/tui-data.h: Same.
2134         * tui/tui-io.c: Same.
2135         * tui/tui-win.c: Same.
2136         * tui/tui.c: Same.
2137         * unittests/rsp-low-selftests.c: Same.
2138         * user-regs.h: Same.
2139         * utils.c: Same.
2140         * utils.h: Same.
2141         * valarith.c: Same.
2142         * valops.c: Same.
2143         * valprint.c: Same.
2144         * valprint.h: Same.
2145         * value.c: Same.
2146         * value.h: Same.
2147         * varobj.c: Same.
2148         * x86-nat.h: Same.
2149         * xtensa-tdep.c: Same.
2150
2151 2019-10-25  Ali Tamur <tamur@google.com>
2152
2153         * charset.c (find_charset_names): Reflect API change.
2154
2155 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2156
2157         * symtab.c (struct demangled_name_entry): Change demangled name
2158         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2159         part of the struct anymore.
2160         (symbol_set_names): No longer obstack allocate + copy the demangled
2161         name, just store the allocated name from bfd.
2162
2163 2019-10-25  Tom Tromey  <tromey@adacore.com>
2164
2165         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2166         (bsearch_cie_cmp, add_cie): Remove.
2167         (find_cie): Reimplement.
2168         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2169         (dwarf2_build_frame_info): Update.
2170
2171 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2172
2173         PR gdb/25126
2174         * symfile.c (reread_symbols): Call forget_cached_source_info to
2175         clear the stale source cache.
2176
2177 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2178
2179         * configure: Regenerate.
2180         * configure.ac: Remove code that sets python_has_threads.
2181
2182 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2183
2184         * config.in: Regenerate.
2185         * configure: Regenerate.
2186         * configure.ac: Remove the code that uses sed to get the python
2187         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2188
2189 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2190
2191         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2192         error paths.
2193
2194 2019-10-23  Tom Tromey  <tom@tromey.com>
2195
2196         * arc-tdep.c: Remove ".." from include.
2197         * frv-tdep.c: Remove ".." from include.
2198         * lm32-tdep.c: Remove ".." from include.
2199         * microblaze-tdep.c: Remove ".." from include.
2200         * or1k-tdep.h: Remove ".." from include.
2201         * s12z-tdep.c: Remove ".." from include.
2202         * Makefile.in (OPCODES_CFLAGS): Add comment.
2203         (TOP_CFLAGS): New variable.
2204         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2205
2206 2019-10-23  Tom Tromey  <tom@tromey.com>
2207
2208         * Makefile.in (READLINE_DIR): Update.
2209
2210 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2211
2212         * infcall.c (call_function_by_hand_dummy): Fix the function
2213         comment.  And extract out a code section into...
2214         (reserve_stack_space): ...this new function.
2215
2216 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2217
2218         * infcall.c (value_arg_coerce): Remove an unused parameter.
2219         (call_function_by_hand_dummy): Update the call to
2220         'value_arg_coerce'.
2221
2222 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2223
2224         * infcall.c (call_function_by_hand_dummy): Refactor.
2225
2226 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2227
2228         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2229
2230 2019-10-23  Tom Tromey  <tom@tromey.com>
2231
2232         * configure: Rebuild.
2233         * configure.ac: Don't check for sigprocmask.
2234         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2235
2236 2019-10-23  Tom Tromey  <tom@tromey.com>
2237
2238         * configure: Rebuild.
2239         * acinclude.m4: Use m4_include, not sinclude.
2240
2241 2019-10-23  Tom de Vries  <tdevries@suse.de>
2242
2243         PR breakpoints/24687
2244         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2245
2246 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2247
2248         * symtab.c (struct demangled_name_entry) <language>: Change from
2249         bitfield to regular variable.
2250
2251 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2252
2253         * symtab.c (struct demangled_name_entry): Add a constructor.
2254         (free_demangled_name_entry): New function to call the destructor
2255         for demangled_name_entry.
2256         (create_demangled_names_hash): Pass free_demangled_name_entry to
2257         htab_create_alloc.
2258         (symbol_set_names): Call placement new for demangled_name_entry.
2259         * utils.c: No longer include xxhash.h here, now that fast_hash
2260         is inlined in the header.
2261         * utils.h: Instead, include it here.
2262
2263 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2264
2265         * Makefile.in: Link with libxxhash.
2266         * config.in: Regenerate.
2267         * configure: Regenerate.
2268         * configure.ac: Search for libxxhash.
2269         * utils.c (fast_hash): Use xxhash if present.
2270
2271 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2272
2273         * utils.h (fast_hash): New function.
2274         * symtab.c (hash_demangled_name_entry): Call new function
2275         fast_hash.
2276
2277 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2278
2279         * symtab.c (struct demangled_name_entry): Change type of mangled
2280         to gdb::string_view. Also adds a constructor that takes the
2281         mangled name.
2282         (hash_demangled_name_entry): Update.
2283         (eq_demangled_name_entry): Update.
2284         (free_demangled_name_entry): New function to call the destructor
2285         now that this is not a POD anymore.
2286         (create_demangled_names_hash): Pass free_demangled_name_entry to
2287         htab_create_alloc.
2288         (symbol_set_names): Update.
2289
2290 2019-10-21  Ali Tamur  <tamu@google.com>
2291
2292         * dwarf2read.c (dir_index): Change type.
2293         (file_name_index): Likewise.
2294         (line_header::include_dir_at): Change comment and implementation on
2295         whether it is DWARF 5.
2296         (line_header::is_valid_file_index): New function.
2297         (line_header::file_name_at): Change comment and implementation on
2298         whether it is DWARF 5.
2299         (line_header::file_names): Change to private field renamed as
2300         m_file_names and introduce a new accessor method.
2301         (line_header::file_names_size): New method.
2302         (line_header::include_dirs): Change to private field and rename as
2303         m_include_dirs.
2304         (dw2_get_file_names_reader): Define local var at a smaller scope and
2305         reflect API change.
2306         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2307         (process_structure_scope): Likewise.
2308         (line_header::add_include_dir): Change message and reflect renaming.
2309         (line_header::add_file_name): Likewise.
2310         (read_formatted_entries): Handle DW_FORM_data16.
2311         (dwarf_decode_line_header): Fix line header length calculation.
2312         (psymtab_include_file_name): Change comment and API.
2313         (lnp_state_machine::m_file): Update comment and reflect type change.
2314         (lnp_state_machine::record_line): Reflect type change.
2315         (dwarf_decode_lines): Reflect API change.
2316         (file_file_name): Likewise.
2317         (file_full_name): Likewise.
2318
2319 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2320
2321         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2322
2323 2019-10-21  Tom Tromey  <tom@tromey.com>
2324
2325         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2326
2327 2019-10-21  Tom Tromey  <tom@tromey.com>
2328
2329         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
2330         NM_H.   Use AC_CONFIG_LINKS.
2331         * configure: Rebuild.
2332         * Makefile.in (NM_H): New variable.
2333         (generated_files): Add NM_H.  Remove gcore.
2334         (nm.h, stamp-nmh): New targets.
2335
2336 2019-10-20  Tom Tromey  <tom@tromey.com>
2337
2338         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2339         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
2340         obsolete comment.
2341         (put_objfile_before): Now static.
2342
2343 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
2344
2345         * gdbsupport/common-utils.h (startswith): Change return type to
2346         bool.
2347
2348 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
2349
2350         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2351         * breakpoint.c (bp_locations_compare): Rename to...
2352         (bp_location_is_less_than): ...this, and change to std::sort semantics.
2353         (update_global_location_list): Use std::sort instead of qsort.
2354         * buildsym.c (compare_line_numbers): Rename to...
2355         (lte_is_less_than): ...this, and change to std::sort semantics.
2356         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2357         instead of qsort.
2358         * disasm.c (compare_lines): Rename to...
2359         (line_is_less_than): ...this, and change to std::sort semantics.
2360         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2361         of qsort.
2362         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2363         (fde_is_less_than): ...this, and change to std::sort semantics.
2364         (dwarf2_build_frame_info): Call std::sort instead of qsort.
2365         * mdebugread.c (compare_blocks):
2366         (block_is_less_than): ...this, and change to std::sort semantics.
2367         (sort_blocks): Call std::sort instead of qsort.
2368         * objfiles.c (qsort_cmp): Rename to...
2369         (sort_cmp): ...this, and change to std::sort semantics.
2370         (update_section_map): Call std::sort instead of qsort.
2371         * remote.c (compare_pnums): Remove.
2372         (map_regcache_remote_table): Call std::sort instead of qsort.
2373         * utils.c (compare_positive_ints): Remove.
2374         * utils.h (compare_positive_ints): Remove.
2375         * xcoffread.c (compare_lte): Remove.
2376         (arrange_linetable): Call std::sort instead of qsort.
2377
2378 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
2379
2380         * symfile.c (init_entry_point_info): Fix typo.
2381         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2382
2383 2019-10-18  Tom de Vries  <tdevries@suse.de>
2384
2385         * aarch64-tdep.c: Fix typos in comments.
2386         * ada-lang.c: Same.
2387         * ada-tasks.c: Same.
2388         * alpha-tdep.c: Same.
2389         * alpha-tdep.h: Same.
2390         * amd64-nat.c: Same.
2391         * amd64-windows-tdep.c: Same.
2392         * arc-tdep.c: Same.
2393         * arc-tdep.h: Same.
2394         * arch-utils.c: Same.
2395         * arm-nbsd-tdep.c: Same.
2396         * arm-tdep.c: Same.
2397         * ax-gdb.c: Same.
2398         * blockframe.c: Same.
2399         * btrace.c: Same.
2400         * c-varobj.c: Same.
2401         * coff-pe-read.c: Same.
2402         * coffread.c: Same.
2403         * cris-tdep.c: Same.
2404         * darwin-nat.c: Same.
2405         * dbxread.c: Same.
2406         * dcache.c: Same.
2407         * disasm.c: Same.
2408         * dtrace-probe.c: Same.
2409         * dwarf-index-write.c: Same.
2410         * dwarf2-frame-tailcall.c: Same.
2411         * dwarf2-frame.c: Same.
2412         * dwarf2read.c: Same.
2413         * eval.c: Same.
2414         * exceptions.c: Same.
2415         * fbsd-tdep.c: Same.
2416         * findvar.c: Same.
2417         * frame.c: Same.
2418         * frv-tdep.c: Same.
2419         * gnu-v3-abi.c: Same.
2420         * go32-nat.c: Same.
2421         * h8300-tdep.c: Same.
2422         * hppa-tdep.c: Same.
2423         * i386-linux-tdep.c: Same.
2424         * i386-tdep.c: Same.
2425         * ia64-libunwind-tdep.c: Same.
2426         * ia64-tdep.c: Same.
2427         * infcmd.c: Same.
2428         * infrun.c: Same.
2429         * linespec.c: Same.
2430         * linux-nat.c: Same.
2431         * linux-thread-db.c: Same.
2432         * machoread.c: Same.
2433         * mdebugread.c: Same.
2434         * mep-tdep.c: Same.
2435         * mn10300-tdep.c: Same.
2436         * namespace.c: Same.
2437         * objfiles.c: Same.
2438         * opencl-lang.c: Same.
2439         * or1k-tdep.c: Same.
2440         * osabi.c: Same.
2441         * ppc-linux-nat.c: Same.
2442         * ppc-linux-tdep.c: Same.
2443         * ppc-sysv-tdep.c: Same.
2444         * printcmd.c: Same.
2445         * procfs.c: Same.
2446         * record-btrace.c: Same.
2447         * record-full.c: Same.
2448         * remote-fileio.c: Same.
2449         * remote.c: Same.
2450         * rs6000-tdep.c: Same.
2451         * s12z-tdep.c: Same.
2452         * score-tdep.c: Same.
2453         * ser-base.c: Same.
2454         * ser-go32.c: Same.
2455         * skip.c: Same.
2456         * sol-thread.c: Same.
2457         * solib-svr4.c: Same.
2458         * solib.c: Same.
2459         * source.c: Same.
2460         * sparc-nat.c: Same.
2461         * sparc-sol2-tdep.c: Same.
2462         * sparc-tdep.c: Same.
2463         * sparc64-tdep.c: Same.
2464         * stabsread.c: Same.
2465         * stack.c: Same.
2466         * symfile.c: Same.
2467         * symtab.c: Same.
2468         * target-descriptions.c: Same.
2469         * target-float.c: Same.
2470         * thread.c: Same.
2471         * utils.c: Same.
2472         * valops.c: Same.
2473         * valprint.c: Same.
2474         * value.c: Same.
2475         * varobj.c: Same.
2476         * windows-nat.c: Same.
2477         * xcoffread.c: Same.
2478         * xstormy16-tdep.c: Same.
2479         * xtensa-tdep.c: Same.
2480
2481 2019-10-17  Tom Tromey  <tromey@adacore.com>
2482
2483         * configure: Rebuild.
2484         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
2485         in AC_CONFIG_FILES invocation.
2486         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2487         new-style config.status invocation.
2488
2489 2019-10-17  Tom de Vries  <tdevries@suse.de>
2490
2491         * arm-nbsd-nat.c: Fix typos in comments.
2492         * arm-tdep.c: Same.
2493         * darwin-nat-info.c: Same.
2494         * dwarf2read.c: Same.
2495         * elfread.c: Same.
2496         * event-top.c: Same.
2497         * findvar.c: Same.
2498         * gdbtypes.c: Same.
2499         * hppa-tdep.c: Same.
2500         * i386-tdep.c: Same.
2501         * jit.c: Same.
2502         * main.c: Same.
2503         * mdebugread.c: Same.
2504         * moxie-tdep.c: Same.
2505         * nto-procfs.c: Same.
2506         * osabi.c: Same.
2507         * ppc-linux-tdep.c: Same.
2508         * remote.c: Same.
2509         * riscv-tdep.c: Same.
2510         * s390-tdep.c: Same.
2511         * sh-tdep.c: Same.
2512         * sparc-linux-tdep.c: Same.
2513         * sparc-nat.c: Same.
2514         * stack.c: Same.
2515         * target-descriptions.c: Same.
2516         * top.c: Same.
2517         * varobj.c: Same.
2518
2519 2019-10-16  Tom Tromey  <tom@tromey.com>
2520
2521         * objfiles.h (struct objfile) <original_name>: Now const.
2522
2523 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2524
2525         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2526         pass on to sigsetjmp's second argument.
2527         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2528
2529 2019-10-16  Keith Seitz  <keiths@redhat.com>
2530
2531         PR gdb/23567
2532         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2533         sections whose size is greater than the file size.
2534
2535 2019-10-16  Jim Wilson  <jimw@sifive.com>
2536
2537         * riscv-tdep.c (riscv_gcc_target_options): New.
2538         (riscv_gnu_triplet_regexp): New.
2539         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2540         set_gdbarch_gnu_triplet_regexp.
2541
2542 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2543
2544         * Makefile.in: Add xml-builtin.h.
2545         * features/feature_to_c.sh: Add an include for xml-builtin.h
2546         to ensure that the compiler checks that the types match.
2547         * xml-builtin.h: New file.
2548         * xml-support.c (fetch_xml_builtin): Add missing const.
2549         * xml-support.h: Remove declaration of xml_builtins.
2550
2551 2019-10-16  Tom de Vries  <tdevries@suse.de>
2552
2553         PR tdep/25096
2554         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2555         (amd64_classify_aggregate): ... here.
2556         (amd64_classify_aggregate_field): Handled fiels of nested structs
2557         recursively.
2558
2559 2019-10-16  Tom de Vries  <tdevries@suse.de>
2560
2561         PR tdep/24104
2562         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2563         that handles 'theclass'.
2564
2565 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2566
2567         * linespec.c (decode_digits_ordinary): Update comment.
2568         * make-target-delegates: No longer need to handle VEC case.
2569         * memrange.c (normalize_mem_ranges): Update comment.
2570         * namespace.c (add_using_directive): Update comment.
2571         * objc-lang.c (uniquify_strings): Update comment.
2572         * ppc-linux-nat.c (struct thread_points): Update comment.
2573         * probe.h (find_probes_in_objfile): Update comment.
2574         * target.h (enum flash_preserve_mode): Update comment.
2575         * varobj.c (varobj_restrict_range): Update comment.
2576         * varobj.h (varobj_list_children): Update comment.
2577
2578 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2579
2580         * Makefile.in: Remove references to vec.h and vec.c.
2581         * aarch64-tdep.c: No longer include vec.h.
2582         * ada-lang.c: Likewise.
2583         * ada-lang.h: Likewise.
2584         * arm-tdep.c: Likewise.
2585         * ax.h: Likewise.
2586         * breakpoint.h: Likewise.
2587         * charset.c: Likewise.
2588         * cp-support.h: Likewise.
2589         * dtrace-probe.c: Likewise.
2590         * dwarf2read.c: Likewise.
2591         * extension.h: Likewise.
2592         * gdb_bfd.c: Likewise.
2593         * gdbsupport/gdb_vecs.h: Likewise.
2594         * gdbsupport/vec.c: Remove.
2595         * gdbsupport/vec.h: Remove.
2596         * gdbthread.h: Likewise.
2597         * guile/scm-type.c: Likewise.
2598         * inline-frame.c: Likewise.
2599         * machoread.c: Likewise.
2600         * memattr.c: Likewise.
2601         * memrange.h: Likewise.
2602         * namespace.h: Likewise.
2603         * nat/linux-btrace.h: Likewise.
2604         * osdata.c: Likewise.
2605         * parser-defs.h: Likewise.
2606         * progspace.h: Likewise.
2607         * python/py-type.c: Likewise.
2608         * record-btrace.c: Likewise.
2609         * rust-exp.y: Likewise.
2610         * solib-target.c: Likewise.
2611         * stap-probe.c: Likewise.
2612         * target-descriptions.c: Likewise.
2613         * target-memory.c: Likewise.
2614         * target.h: Likewise.
2615         * varobj.c: Likewise.
2616         * varobj.h: Likewise.
2617         * xml-support.h: Likewise.
2618
2619 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2620
2621         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2622         Update for new std::vector based implementation.
2623         (process_psymtab_comp_unit_reader): Likewise.
2624         (scan_partial_symbols): Likewise.
2625         (recursively_compute_inclusions): Likewise.
2626         (compute_compunit_symtab_includes): Likewise.
2627         (process_imported_unit_die): Likewise.
2628         (queue_and_load_dwo_tu): Likewise.
2629         (follow_die_sig_1): Likewise.
2630         * gdb/dwarf2read.h: Remove DEF_VEC_P.
2631         (typedef dwarf2_per_cu_ptr): Remove.
2632         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2633         function.
2634         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2635         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2636         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2637         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2638         std::vector.
2639
2640 2019-10-15  Tom Tromey  <tromey@adacore.com>
2641
2642         * windows-nat.c (windows_nat_target::resume): Use %x when logging
2643         TID.
2644
2645 2019-10-15  Tom Tromey  <tromey@adacore.com>
2646
2647         * windows-nat.c (windows_nat_target::fetch_registers)
2648         (windows_nat_target::store_registers): Rename "pid" to "tid".
2649
2650 2019-10-15  Tom Tromey  <tromey@adacore.com>
2651
2652         * gdbarch.h, gdbarch.c: Rebuild.
2653         * gdbarch.sh (gcc_target_options): Change return type to
2654         std::string.
2655         * compile/compile.c (get_args): Update.
2656         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2657         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2658         std::string.
2659         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2660         std::string.
2661         * arch-utils.c (default_gcc_target_options): Return std::string.
2662         * arch-utils.h (default_gcc_target_options): Return std::string.
2663         * s390-tdep.c (s390_gcc_target_options): Return std::string.
2664
2665 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2666
2667         * breakpoint.c (breakpoint_chain): Make static.
2668         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2669         of accessing breakpoint_chain.
2670
2671 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2672
2673         * breakpoint.c (iterate_over_breakpoints): Change function pointer
2674         to a gdb::function_view and return value to bool.
2675         * breakpoint.h (iterate_over_breakpoints): Likewise.
2676         * dummy-frame.c (pop_dummy_frame_bpt): Update.
2677         (pop_dummy_frame): Update.
2678         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2679         (gdbscm_breakpoints): Update.
2680         * python/py-breakpoint.c (build_bp_list): Update.
2681         (gdbpy_breakpoints): Update.
2682         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2683         Update.
2684         (bpfinishpy_handle_stop): Update.
2685         (bpfinishpy_handle_exit): Update.
2686         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2687         (svr4_update_solib_event_breakpoints): Update.
2688
2689 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
2690
2691         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2692         when unwrapping single-field structs.
2693
2694 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
2695
2696         * dwarf2read.c: Remove includes.
2697
2698 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
2699
2700         * ui-out.c (ui_out::call_do_message): Silence
2701         -Wformat-nonliteral warning.
2702
2703 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
2704
2705         * breakpoint.c: Remove some includes: continuations.h, skip.h,
2706         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
2707         include: readline/tilde.h.
2708
2709 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2710
2711         * remote.c (remote_target::get_trace_status): Remove declaration of
2712         trace_regblock_size.
2713
2714 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2715
2716         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2717         (show_user): Remove declaration of cmdlist.
2718         * cli/cli-cmds.h (max_user_call_depth): Declare.
2719         * cli/cli-script.c (execute_user_command): Remove declaration
2720         of max_user_call_depth.
2721
2722 2019-10-11  Jim Wilson  <jimw@sifive.com>
2723
2724         * gdbsupport/print-utils.h (pulongest): Fix comment.
2725         (plongest): Likewise.
2726         (phex): Add missing comment, mention leading zeros.
2727         (phex_nz): Add mention of no leading zeros to comment.
2728
2729         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2730         plongest instead of unsigned long long cast.
2731
2732 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2733
2734         * main.c (captured_main_1): Include gdbtk.h and remove declarations
2735         for external_editor_command and gdbtk_test.
2736
2737 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2738
2739         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2740         * varobj.c (varobjdebug): Move comment to...
2741         * varobj.h (varobjdebug): ...here, and declare.
2742
2743 2019-10-09  Tom Tromey  <tom@tromey.com>
2744
2745         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2746         erase_data_content.
2747
2748 2019-10-09  Tom Tromey  <tom@tromey.com>
2749
2750         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2751         * tui/tui-stack.c (tui_locator_window::rerender): Update.
2752         * tui/tui-command.c (tui_cmd_window::resize)
2753         (tui_refresh_cmd_win): Update.
2754         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2755         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2756         * tui/tui-data.c (~tui_gen_win_info): Remove.
2757         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2758         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2759         (tui_redisplay_readline, tui_mld_flush)
2760         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2761         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2762         (tui_data_window::erase_data_content)
2763         (tui_data_item_window::rerender)
2764         (tui_data_item_window::refresh_window): Update.
2765         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2766         (box_win, tui_gen_win_info::make_window)
2767         (tui_gen_win_info::make_visible): Update.
2768         (tui_delete_win): Remove.
2769         * tui/tui-winsource.c
2770         (tui_source_window_base::do_erase_source_content): Update.
2771         (tui_show_source_line, tui_source_window_base::update_tab_width)
2772         (tui_source_window_base::update_exec_info): Update.
2773         * tui/tui-data.h (struct curses_deleter): New.
2774         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2775         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2776
2777 2019-10-09  Tom Tromey  <tom@tromey.com>
2778
2779         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2780
2781 2019-10-09  Tom Tromey  <tom@tromey.com>
2782
2783         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2784         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2785
2786 2019-10-09  Tom Tromey  <tom@tromey.com>
2787
2788         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2789         window height directly.
2790         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2791         declare.
2792         * tui/tui-layout.c (tui_default_win_height): Remove.
2793         (tui_default_win_viewport_height): Remove.
2794
2795 2019-10-09  Tom Tromey  <tom@tromey.com>
2796
2797         * tui/tui.h: Remove comments.
2798
2799 2019-10-09  Tom de Vries  <tdevries@suse.de>
2800
2801         * python/lib/gdb/printer/bound_registers.py: Use
2802         '^builtin_type_bound128' as regexp argument for
2803         add_builtin_pretty_printer.
2804
2805 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
2806
2807         * guile/guile.c (guile_extension_script_ops): Remove forward
2808         declaration and mark as static.
2809         (guile_script_ops): Likewise.
2810         (extension_language_guile): Move further down in the file so
2811         it can reference the definitions for guile_{extension_,}script_ops.
2812
2813 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
2814
2815         * s390-tdep.c (390_process_record): Handle new arch13 instructions
2816         except SORTL, DFLTCC, and KDSA.
2817
2818 2019-10-08  Tom Tromey  <tromey@adacore.com>
2819
2820         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2821         (struct safe_symbol_file_add_args): Remove.
2822
2823 2019-10-08  Tom Tromey  <tromey@adacore.com>
2824
2825         * windows-nat.c: Don't include buildsym-legacy.h.
2826
2827 2019-10-08  Tom Tromey  <tromey@adacore.com>
2828
2829         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2830
2831 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2832
2833         * gdbtypes.c (overload_debug): Move comment to header.
2834         * gdbtypes.h (overload_debug): Declare.
2835         * valops.c: Remove declaration of overload_debug, instead
2836         include gdbtypes.h.
2837
2838 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2839
2840         * language.c (show_language_command): Pass lang_frame_mismatch_warn
2841         through _().
2842         (lang_frame_mismatch_warn): Make const, mark with N_(), and
2843         move comment...
2844         * language.h (lang_frame_mismatch_warn): ... here. Also add
2845         declaration.
2846         * top.c (lang_frame_mismatch_warn): Remove declaration.
2847         (check_frame_language_change): Pass lang_frame_mismatch_warn
2848         through _().
2849
2850 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2851
2852         * c-lang.h (vtbl_ptr_name): Declare.
2853         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2854         it from the header.
2855         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2856
2857 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2858
2859         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2860         gdb_static_assert.
2861
2862 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2863
2864         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2865         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
2866         * ctfread.c: New file.
2867         * ctfread.h: New file.
2868         * elfread.c: Include ctfread.h.
2869         (struct elfinfo text_p): New member ctfsect.
2870         (elf_locate_sections): Mark CTF section.
2871         (elf_symfile_read): Call elfctf_build_psymtabs.
2872         * Makefile.in (LIBCTF): Add.
2873         (CLIBS): Use it.
2874         (CDEPS): Likewise.
2875         (DIST): Add ctfread.c.
2876
2877 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2878
2879         * ctfread.c (struct nextfield): Renamed to ...
2880         (struct ctf_nextfield): ... this.
2881         (struct field_info): Renamed to ...
2882         (strut ctf_field_info): ... this.
2883         (attach_fields_to_type): Update for renamed structures.
2884         (ctf_add_member_cb): Likewise.
2885         (ctf_add_enum_member_cb): Likewise.
2886         (process_struct_members): Likewise.
2887         (process_enum_type): Likewise.
2888
2889 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2890
2891         * tracectf.h: Rename, was ctf.h.
2892         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2893         * tracefile.c: Likewise.
2894         * tracepoint.c: Remove unused include ctf.h.
2895         * mi/mi-main.c: Likewise.
2896         * Makefile.in Replace ctf.c with tracectf.c.
2897
2898 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
2899
2900         * version.in: Change version number to "9.0.50.DATE-git".
2901
2902 2019-10-03  Tom Tromey  <tom@tromey.com>
2903
2904         PR rust/24976:
2905         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2906
2907 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2908
2909         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2910         cp_search_name_hash.
2911         * NEWS: Add entry about nested function support.
2912
2913 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
2914             Andrew Burgess  <andrew.burgess@embecosm.com>
2915
2916         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2917         for nested static variables when searchin VAR_DOMAIN.
2918         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2919         global scope, update comment.
2920         (add_partial_subprogram): Call add_partial_subprogram recursively
2921         for nested subroutines when processinng Fortran.
2922         (load_partial_dies): Process the child entities of a subprogram
2923         when processing Fortran.
2924         (partial_die_parent_scope): Handle building scope
2925         for Fortran nested functions.
2926         (process_die): Record that nested functions have a scope.
2927         (new_symbol): Always record Fortran subprograms on the global
2928         symbol list.
2929         (determine_prefix): How to build the prefix for Fortran
2930         subprograms.
2931
2932 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2933
2934         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
2935         have just sent the thread a SIGSTOP and are waiting for it to
2936         arrive.
2937
2938 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2939
2940         * btrace.c (btrace_add_pc): Remove whitespace before the template
2941         parameter in 'std::vector <...>'.
2942         (parse_xml_btrace_block): Likewise.
2943         (btrace_maint_decode_pt): Likewise.
2944         (btrace_maint_update_packets): Likewise.
2945         (btrace_maint_print_packets): Likewise.
2946         * btrace.h (struct btrace_maint_info): Likewise.
2947         * dwarf2read.c (struct type_unit_group): Likewise.
2948         (build_type_psymtabs_reader): Likewise.
2949         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
2950         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
2951         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
2952
2953 2019-10-03  Tom de Vries  <tdevries@suse.de>
2954
2955         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
2956         the first line of the help text for set/show style metadata.
2957
2958 2019-10-02  Tom Tromey  <tromey@adacore.com>
2959
2960         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
2961         * gdbsupport/common-inferior.c: New file.
2962         * infcmd.c (startup_with_shell): Don't define.
2963         * nat/fork-inferior.h (startup_with_shell): Don't declare.
2964         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
2965         * inferior.h (startup_with_shell): Don't declare.
2966
2967 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
2968
2969         * gdbsupport/gdb_assert.h: Include errors.h.
2970         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
2971
2972 2019-10-02  Tom Tromey  <tromey@adacore.com>
2973
2974         * NEWS: Add $_ada_exception entry.
2975         * ada-lang.c (struct ada_catchpoint): Add constructor.
2976         <m_kind>: New member.
2977         (allocate_location_exception, re_set_exception): Remove
2978         "ex" parameter.
2979         (should_stop_exception): Compute $_ada_exception.
2980         (check_status_exception, print_it_exception)
2981         (print_one_exception, print_mention_exception): Remove
2982         "ex" parameter.
2983         (allocate_location_catch_exception, re_set_catch_exception)
2984         (check_status_exception, print_it_catch_exception)
2985         (print_one_catch_exception, print_mention_catch_exception)
2986         (print_recreate_catch_exception)
2987         (allocate_location_catch_exception_unhandled)
2988         (re_set_catch_exception_unhandled)
2989         (check_status_exception, print_it_catch_exception_unhandled)
2990         (print_one_catch_exception_unhandled)
2991         (print_mention_catch_exception_unhandled)
2992         (print_recreate_catch_exception_unhandled)
2993         (allocate_location_catch_assert, re_set_catch_assert)
2994         (check_status_assert, print_it_catch_assert)
2995         (print_one_catch_assert, print_mention_catch_assert)
2996         (print_recreate_catch_assert)
2997         (allocate_location_catch_handlers, re_set_catch_handlers)
2998         (check_status_handlers, print_it_catch_handlers)
2999         (print_one_catch_handlers, print_mention_catch_handlers)
3000         (print_recreate_catch_handlers): Remove.
3001         (create_ada_exception_catchpoint): Update.
3002         (initialize_ada_catchpoint_ops): Update.
3003
3004 2019-10-02  Tom Tromey  <tromey@adacore.com>
3005
3006         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3007         (create_excep_cond_exprs): Simplify exception string computation.
3008         (ada_exception_catchpoint_cond_string): Likewise.
3009
3010 2019-10-02  Tom Tromey  <tromey@adacore.com>
3011
3012         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3013         * ada-lang.c (lesseq_defined_than): Handle
3014         LOC_STATIC.
3015         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3016         parameter.
3017         (dwarf2_has_info): Likewise.
3018         (new_symbol): Set maybe_copied on symbol when
3019         appropriate.
3020         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3021         parameter.
3022         <can_copy>: New member.
3023         * elfread.c (record_minimal_symbol): Set maybe_copied
3024         on symbol when appropriate.
3025         (elf_symfile_read): Update call to dwarf2_has_info.
3026         * minsyms.c (lookup_minimal_symbol_linkage): New
3027         function.
3028         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3029         * symtab.c (get_symbol_address, get_msymbol_address):
3030         New functions.
3031         * symtab.h (get_symbol_address, get_msymbol_address):
3032         Declare.
3033         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3034         maybe_copied.
3035         (struct symbol, struct minimal_symbol) <maybe_copied>:
3036         New member.
3037
3038 2019-10-02  Tom Tromey  <tromey@adacore.com>
3039
3040         * source.c (struct current_source_location): New.
3041         (current_source_key): New global.
3042         (current_source_symtab, current_source_line)
3043         (current_source_pspace): Remove.
3044         (get_source_location): New function.
3045         (get_current_source_symtab_and_line)
3046         (set_default_source_symtab_and_line)
3047         (set_current_source_symtab_and_line)
3048         (clear_current_source_symtab_and_line, select_source_symtab)
3049         (info_source_command, print_source_lines_base)
3050         (info_line_command, search_command_helper, _initialize_source):
3051         Update.
3052
3053 2019-10-02  Tom Tromey  <tromey@adacore.com>
3054
3055         * source.c (select_source_symtab): Don't call
3056         decode_line_with_current_source.
3057
3058 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3059
3060         * symtab.c (lookup_global_symbol): Search global block.
3061
3062 2019-10-02  Tom Tromey  <tromey@adacore.com>
3063
3064         * coffread.c (process_coff_symbol): Update.
3065         * dwarf2read.c (var_decode_location, new_symbol): Update.
3066         * mdebugread.c (parse_symbol): Update.
3067         * objfiles.c (relocate_one_symbol): Update.
3068         * stabsread.c (define_symbol, fix_common_block)
3069         (scan_file_globals): Update.
3070         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3071         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3072         * xcoffread.c (process_xcoff_symbol): Update.
3073
3074 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3075
3076         * MAINTAINERS: Update my email address.
3077
3078 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3079
3080         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3081         std::vector.
3082         (build_type_psymtabs_reader): Update for std::vector.
3083         (build_type_psymtab_dependencies): Likewise.
3084         * dwarf2read.h: Remove use of DEF_VEC_P.
3085         (typedef sig_type_ptr): Delete.
3086
3087 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3088
3089         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3090         to std::vector.
3091         (btrace_maint_decode_pt): Likewise, and move allocation of the
3092         vector outside of the loop.
3093         (btrace_maint_update_packets): Update to handle change from VEC to
3094         std::vector.
3095         (btrace_maint_print_packets): Likewise.
3096         (maint_info_btrace_cmd): Likewise.
3097         * btrace.h: Remove use of DEF_VEC_O.
3098         (typedef btrace_pt_packet_s): Delete.
3099         (struct btrace_maint_info) <packets>: Change fromm VEC to
3100         std::vector.
3101         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3102
3103 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3104
3105         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3106         make accesses into the vector constant references.
3107         (btrace_add_pc): Update for std::vector.
3108         (btrace_stitch_bts): Likewise.
3109         (parse_xml_btrace_block): Likewise.
3110         (btrace_maint_update_packets): Likewise.
3111         (btrace_maint_print_packets): Likewise.
3112         (maint_info_btrace_cmd): Likewise.
3113         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3114         std::vector.
3115         (btrace_data::empty): Likewise.
3116         (btrace_data_append): Likewise.
3117         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3118         (typedef btrace_block_s): Delete.
3119         (struct btrace_block): Add constructor.
3120         (struct btrace_data_bts) <blocks>: Change to std::vector.
3121         * nat/linux-btrace.c (perf_event_read_bts): Update for
3122         std::vector.
3123         (linux_read_bts): Likewise.
3124
3125 2019-10-01  Tom Tromey  <tom@tromey.com>
3126
3127         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3128
3129 2019-10-01  Tom Tromey  <tom@tromey.com>
3130
3131         * stack.c (print_frame, info_frame_command_core): Use
3132         styled_string.
3133         * linux-thread-db.c (try_thread_db_load_1)
3134         (try_thread_db_load_from_pdir_1): Use styled_string.
3135         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3136         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3137         (maybe_print_unsupported_script_warning)
3138         (maybe_print_script_not_found_warning): Use styled_string.
3139         * ada-lang.c (user_select_syms): Use styled_string.
3140
3141 2019-10-01  Tom Tromey  <tom@tromey.com>
3142
3143         * p-lang.c (pascal_printstr): Use metadata style.
3144         * value.c (show_convenience): Use metadata style.
3145         * valprint.c (valprint_check_validity, val_print_optimized_out)
3146         (val_print_not_saved, val_print_unavailable)
3147         (val_print_invalid_address, generic_val_print, val_print)
3148         (value_check_printable, val_print_array_elements): Use metadata
3149         style.
3150         * ui-out.h (class ui_out) <field_fmt>: New overload.
3151         <do_field_fmt>: Add style parameter.
3152         * ui-out.c (ui_out::field_fmt): New overload.
3153         * typeprint.c (type_print_unknown_return_type)
3154         (val_print_not_allocated, val_print_not_associated): Use metadata
3155         style.
3156         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3157         parameter.
3158         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3159         * tracepoint.c (tvariables_info_1): Use metadata style.
3160         * stack.c (print_frame_arg, print_frame_info, print_frame)
3161         (info_frame_command_core): Use metadata style.
3162         * skip.c (info_skip_command): Use metadata style.
3163         * rust-lang.c (rust_print_enum): Use metadata style.
3164         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3165         metadata style.
3166         * python/py-framefilter.c (py_print_single_arg): Use metadata
3167         style.
3168         * printcmd.c (do_one_display, print_variable_and_value): Use
3169         metadata style.
3170         * p-valprint.c (pascal_val_print)
3171         (pascal_object_print_value_fields): Use metadata style.
3172         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3173         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3174         parameter.
3175         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3176         * m2-valprint.c (m2_print_long_set): Use metadata style.
3177         * m2-typeprint.c (m2_print_type): Use metadata style.
3178         * infcmd.c (print_return_value_1): Use metadata style.
3179         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3180         * f-valprint.c (info_common_command_for_block): Use metadata
3181         style.
3182         * f-typeprint.c (f_type_print_base): Use metadata style.
3183         * expprint.c (print_subexp_standard): Use metadata style.
3184         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3185         * cli/cli-style.h (class cli_style_option): Add constructor.
3186         (metadata_style): Declare.
3187         * cli/cli-style.c (metadata_style): New global.
3188         (_initialize_cli_style): Register metadata style.
3189         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3190         parameter.
3191         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3192         * c-typeprint.c (c_type_print_base_struct_union)
3193         (c_type_print_base_1): Use metadata style.
3194         * breakpoint.c (watchpoint_value_print)
3195         (print_one_breakpoint_location): Use metadata style.
3196         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3197         style.
3198         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3199         style.
3200         * ada-valprint.c (val_print_packed_array_elements, printstr)
3201         (print_field_values, ada_val_print_ref, ada_val_print): Use
3202         metadata style.
3203         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3204         style.
3205         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3206         style.
3207         * ada-lang.c (user_select_syms): Use metadata style.
3208
3209 2019-10-01  Tom Tromey  <tom@tromey.com>
3210
3211         * cli/cli-cmds.c (pwd_command): Style output.
3212
3213 2019-10-01  Pedro Alves  <palves@redhat.com>
3214             Tom Tromey  <tom@tromey.com>
3215
3216         * symtab.c (print_symbol_info): Use %ps.
3217         (print_msymbol_info): Use %ps.
3218         * symfile.c (symbol_file_add_with_addrs): Use %ps.
3219         * printcmd.c (print_variable_and_value): Use %ps.
3220         * macrocmd.c (show_pp_source_pos): Use %ps.
3221         * infrun.c (print_exited_reason): Use ui_out::message.
3222         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3223         (describe_other_breakpoints): Use ui_out::message and new
3224         formats.
3225         (say_where): Use new formats.
3226         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3227         and new formats.
3228
3229 2019-10-01  Pedro Alves  <palves@redhat.com>
3230             Tom Tromey  <tom@tromey.com>
3231
3232         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3233         (test_gdb_formats): New function.
3234         (run_tests): Call it.
3235         (test_format_specifier): Update.
3236         * utils.h (fputs_filtered): Update comment.
3237         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3238         (fputs_styled_unfiltered): Declare.
3239         * utils.c (fputs_styled_unfiltered): New function.
3240         (vfprintf_maybe_filtered): Add gdbfmt parameter.
3241         (vfprintf_filtered): Update.
3242         (vfprintf_unfiltered, vprintf_filtered): Update.
3243         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3244         * ui-out.h (enum ui_out_flag) <unfiltered_output,
3245         disallow_ui_out_field>: New constants.
3246         (enum class field_kind): New.
3247         (struct base_field_s, struct signed_field_s): New.
3248         (signed_field): New function.
3249         (struct string_field_s): New.
3250         (string_field): New function.
3251         (struct styled_string_s): New.
3252         (styled_string): New function.
3253         (class ui_out) <message>: Add comment.
3254         <vmessage, call_do_message>: New methods.
3255         <do_message>: Add style parameter.
3256         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3257         methods.
3258         (ui_out::message): Rewrite.
3259         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3260         parameter.
3261         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3262         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3263         gdb_extensions parameter.
3264         (class format_piece): Add parameter to constructor.
3265         (n_int_args): New field.
3266         * gdbsupport/format.c (format_pieces::format_pieces): Add
3267         gdb_extensions parameter.  Handle '*'.
3268         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3269         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
3270         vfprintf_styled_no_gdbfmt.
3271         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3272         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3273         unfiltered output.
3274         * ui-style.h (struct ui_file_style) <ptr>: New method.
3275
3276 2019-10-01  Tom Tromey  <tom@tromey.com>
3277
3278         * unittests/format_pieces-selftests.c: Update.  Add final format.
3279         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3280         empty literal pieces.
3281
3282 2019-10-01  Tom Tromey  <tom@tromey.com>
3283
3284         * ui-out.h (enum class ui_out_style_kind): Remove.
3285         (class ui_out) <field_string, field_stsream, do_field_string>:
3286         Change type of "style".
3287         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3288         (ui_out::field_string): Update.
3289         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3290         of "style".
3291         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3292         * tracepoint.c (print_one_static_tracepoint_marker): Update.
3293         * stack.c (print_frame_arg, print_frame_info, print_frame):
3294         Update.
3295         * source.c (print_source_lines_base): Update.
3296         * solib.c (info_sharedlibrary_command): Update.
3297         * skip.c (info_skip_command): Update.
3298         * record-btrace.c (btrace_call_history_src_line)
3299         (btrace_call_history): Update.
3300         * python/py-framefilter.c (py_print_frame): Update.
3301         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3302         "style".
3303         * mi/mi-out.c (mi_ui_out::do_table_header)
3304         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3305         (mi_ui_out::do_field_string): Update.
3306         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3307         Update.
3308         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3309         "style".
3310         * cli-out.c (cli_ui_out::do_table_header)
3311         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3312         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3313         (cli_ui_out::do_field_fmt): Update.
3314         * breakpoint.c (print_breakpoint_location): Update.
3315         (update_static_tracepoint): Update.
3316
3317 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3318
3319         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3320         conversion of gdb_datadir.
3321         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3322         remove not needed c_str ().
3323
3324 2019-09-30  Ali Tamur <tamur@google.com>
3325
3326         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3327         (dwarf2_string_attr): Likewise.
3328
3329 2019-09-30  Ali Tamur <tamur@google.com>
3330
3331         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3332         (process_full_type_unit): Likewise.
3333         (dump_die_shallow): Likewise.
3334         (cu_debug_loc_section): Likewise.
3335
3336 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
3337
3338         * minsyms.c (compare_minimal_symbols): Rename to...
3339         (minimal_symbol_is_less_than): ...this, and adjust to STL
3340         conventions (return bool, take arguments as references)
3341         (minimal_symbol_reader::install): Call std::sort instead
3342         of qsort.
3343
3344 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
3345
3346         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3347         hash and why.
3348         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3349         msymbol_hash, msymbol_demangled_hash>: Improve comments.
3350
3351 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
3352
3353         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3354         * psympriv.h (add_psymbol_to_list): Move comment here and update
3355         it.
3356
3357 2019-09-29  Tom de Vries  <tdevries@suse.de>
3358
3359         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3360         Use $tmpdir/$(basename "$output_file").dwz instead of
3361         "${output_file}.dwz".
3362
3363 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
3364
3365         PR gdb/25045
3366         * hppa-linux-nat.c: Include gdbarch.h.
3367
3368 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
3369
3370         * blockframe.c (find_pc_partial_function): Change return type to bool.
3371         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3372         * minsyms.c (in_gnu_ifunc_stub): Likewise.
3373         (stub_gnu_ifunc_resolve_name): Likewise.
3374         * symtab.c (compare_filenames_for_search): Likewise.
3375         (compare_glob_filenames_for_search): Likewise.
3376         (matching_obj_sections): Likewise.
3377         (symbol_matches_domain): Likewise.
3378         (find_line_symtab): Change out param EXACT_MATCH to bool *.
3379         (find_line_pc): Change return type to bool.
3380         (find_line_pc_range): Likewise.
3381         (producer_is_realview): Likewise.
3382         * symtab.h (symbol_matches_domain): Likewise.
3383         (find_pc_partial_function): Likewise.
3384         (find_pc_line_pc_range): Likewise.
3385         (in_gnu_ifunc_stub): Likewise.
3386         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3387         (find_line_pc): Likewise.
3388         (find_line_pc_range): Likewise.
3389         (matching_obj_sections): Likewise.
3390         (find_line_symtab): Change out parameter to bool.
3391         (producer_is_realview): Change return type to bool.
3392         (compare_filenames_for_search): Likewise.
3393         (compare_glob_filenames_for_search): Likewise.
3394
3395 2019-09-26  Tom Tromey  <tom@tromey.com>
3396
3397         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3398         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3399         * gdb_usleep.h: Remove.
3400         * gdb_usleep.c: Remove.
3401         * utils.c: Don't include gdb_usleep.h.
3402
3403 2019-09-26  Tom Tromey  <tromey@adacore.com>
3404
3405         * python/py-type.c (type_to_type_object): Call check_typedef
3406         for stub types.
3407
3408 2019-09-26  Tom Tromey  <tom@tromey.com>
3409
3410         * utils.h (initialize_utils): Don't declare.
3411         * top.c (gdb_init): Don't call initialize_utils.
3412         * utils.c (initialize_utils): Remove.  Move contents...
3413         (_initialize_utils): ... here.
3414
3415 2019-09-25  Tom Tromey  <tom@tromey.com>
3416
3417         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3418         * utils.h (make_hex_string): Don't declare.
3419         * utils.c (make_hex_string): Remove.
3420
3421 2019-09-24  Tom de Vries  <tdevries@suse.de>
3422
3423         PR gdb/23815
3424         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3425         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3426
3427 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
3428
3429         * NEWS: Mention new simulator port for PRU.
3430
3431 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
3432
3433         * ada-exp.y (write_object_remaining): Update.
3434         * ada-lang.c (ada_decode): Return a std::string instead of a char*
3435         and eliminate the static buffer.
3436         (ada_decode_symbol): Update.
3437         (ada_la_decode): Update.
3438         (ada_sniff_from_mangled_name): Update.
3439         (is_valid_name_for_wild_match): Update.
3440         (ada_lookup_name_info::matches): Update and simplify.
3441         (name_matches_regex): Update.
3442         (ada_add_global_exceptions): Update.
3443         * ada-lang.h (ada_decode): Update signature.
3444         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3445         * dwarf-index-write.c (debug_names::insert): Update.
3446
3447 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3448
3449         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3450         formatting.
3451
3452 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3453
3454         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3455         Change "nonzero" to "true" in documentation.
3456
3457 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
3458
3459         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3460         (_initialize_darwin_solib): Don't set
3461         darwin_so_ops.lookup_lib_global_symbol.
3462         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3463         set_gdbarch_iterate_over_objfiles_in_search_order.
3464         (elf_lookup_lib_symbol): Rename to...
3465         (svr4_iterate_over_objfiles_in_search_order): this, and update
3466         to iterate semantics.
3467         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3468         * solib.c (solib_global_lookup): Remove.
3469         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3470         (solib_global_lookup): Remove.
3471         * symtab.c (lookup_global_or_static_symbol): Remove call to
3472         solib_global_lookup.
3473
3474 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3475
3476         * NEWS: Move entries about default MI version now being
3477         version 3, and about the GDB/MI fix for multi-location
3478         breakpoints to the "since GDB 8.3" section.
3479
3480 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3481
3482         GDB 8.3.1 released.
3483
3484 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
3485
3486         * NEWS: Mention that Cell/B.E. debugging support was removed.
3487         * MAINTAINERS: Remove spu target.
3488
3489         * config/djgpp/fnchange.lst: Remove entries for removed files.
3490
3491         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3492         spu-multiarch.o, and spu-tdep.o.
3493         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3494         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3495         spu-multiarch.c, and spu-tdep.c.
3496         * spu-linux-nat.c: Remove file.
3497         * spu-multiarch.c: Remove file.
3498         * spu-tdep.c: Remove file.
3499         * spu-tdep.h: Remove file.
3500         * solib-spu.c: Remove file.
3501         * solib-spu.h: Remove file.
3502
3503         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3504         * configure.nat (spu-linux): Remove.
3505         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3506         solib-multiarch.o from gdb_target_obs.
3507         (spu*-*-*): Remove.
3508
3509         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3510         feature flag.
3511         (ppc_linux_no_features): Update.
3512         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3513         Cell/B.E. support.
3514         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3515         (tdesc_powerpc_cell64l): Likewise.
3516         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3517         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3518         Cell/B.E. support.
3519         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3520         Do not include "features/rs6000/powerpc-cell32l.c" or
3521         "features/rs6000/powerpc-cell64l.c".
3522         (ppc_linux_spu_section): Remove.
3523         (ppc_linux_core_read_description): Remove Cell/B.E. support.
3524         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3525         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3526         (ppc_linux_spe_context_lookup): Remove.
3527         (ppc_linux_spe_context_inferior_created): Remove.
3528         (ppc_linux_spe_context_solib_loaded): Remove.
3529         (ppc_linux_spe_context_solib_unloaded): Remove.
3530         (ppc_linux_spe_context): Remove.
3531         (struct ppu2spu_cache): Remove.
3532         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3533         (struct ppu2spu_data): Remove.
3534         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3535         ppu2spu_unwind): Remove.
3536         (ppc_linux_init_abi): Remove Cell/B.E. support.
3537         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3538
3539         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3540         (rs6000/powerpc-cell64l-expedite): Likewise
3541         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3542         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3543         rs6000/powerpc-cell64l.xml.
3544         * features/rs6000/powerpc-cell32l.xml: Remove.
3545         * features/rs6000/powerpc-cell64l.xml: Likewise.
3546         * features/rs6000/powerpc-cell32l.c: Remove generated file.
3547         * features/rs6000/powerpc-cell64l.c: Likewise.
3548         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3549         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3550         * regformats/reg-spu.dat: Remove.
3551
3552         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3553         * corelow.c (struct spuid_list): Remove.
3554         (add_to_spuid_list): Remove.
3555         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3556         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3557         (remote_protocol_features): Remove associated entries.
3558         (_initialize_remote): No longer initialize them.
3559         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3560         * linux-nat.c (SPUFS_MAGIC): Remove.
3561         (linux_proc_xfer_spu): Remove.
3562         (spu_enumerate_spu_ids): Remove.
3563         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3564         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3565         (linux_make_corefile_notes): No longer call it.
3566
3567         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3568         (cooked_write_test): Likewise.
3569
3570 2019-09-20  Tom Tromey  <tom@tromey.com>
3571
3572         * NEWS: Mention case-sensitivity of TUI commands.
3573         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3574         (tui_set_win_height_command, parse_scrolling_args): Likewise.
3575         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3576
3577 2019-09-20  Tom Tromey  <tom@tromey.com>
3578
3579         * tui/tui-source.c (tui_source_window::set_contents): Use
3580         make_unique_xstrdup.
3581         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3582         make_unique_xstrdup.
3583
3584 2019-09-20  Tom Tromey  <tom@tromey.com>
3585
3586         * tui/tui-data.c: Remove separator comments.
3587         * tui/tui-layout.c: Remove separator comments.
3588         * tui/tui-win.c: Remove separator comments.
3589         * tui/tui-wingeneral.c: Remove separator comments.
3590
3591 2019-09-20  Tom Tromey  <tom@tromey.com>
3592
3593         * tui/tui.h (strcat_to_buf): Don't declare.
3594         * tui/tui.c (strcat_to_buf): Remove.
3595
3596 2019-09-20  Tom Tromey  <tom@tromey.com>
3597
3598         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3599         from "fullname".
3600         * tui/tui-source.c (tui_source_window::set_contents)
3601         (tui_source_window::location_matches_p)
3602         (tui_source_window::maybe_update): Update.
3603
3604 2019-09-20  Tom Tromey  <tom@tromey.com>
3605
3606         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3607         Update.
3608         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3609         prefix.
3610         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3611         (tui_data_window::line_from_reg_element_no)
3612         (tui_data_window::first_reg_element_no_inline)
3613         (tui_data_window::show_registers)
3614         (tui_data_window::show_register_group)
3615         (tui_data_window::display_registers_from)
3616         (tui_data_window::display_registers_from_line)
3617         (tui_data_window::first_data_item_displayed)
3618         (tui_data_window::delete_data_content_windows)
3619         (tui_data_window::erase_data_content)
3620         (tui_data_window::do_scroll_vertical)
3621         (tui_data_window::refresh_window)
3622         (tui_data_window::check_register_values): Update.
3623
3624 2019-09-20  Tom Tromey  <tom@tromey.com>
3625
3626         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3627         (struct tui_locator_window) <full_name, proc_name>: Now
3628         std::string.
3629         * tui/tui-stack.c (tui_locator_window::make_status_line)
3630         (tui_locator_window::set_locator_fullname)
3631         (tui_locator_window::set_locator_info): Update.
3632         * tui/tui-source.c (tui_source_window::set_contents)
3633         (tui_source_window::showing_source_p): Update.
3634
3635 2019-09-20  Tom Tromey  <tom@tromey.com>
3636
3637         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3638         Don't call tui_locator_win_info_ptr.
3639
3640 2019-09-20  Tom Tromey  <tom@tromey.com>
3641
3642         * tui/tui-win.c (tui_resize_all): Don't call refresh.
3643
3644 2019-09-20  Tom Tromey  <tom@tromey.com>
3645
3646         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3647         height for locator.
3648         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3649         * tui/tui-layout.c (show_source_disasm_command, show_data)
3650         (show_source_or_disasm_and_command): Use 1 as height for locator.
3651
3652 2019-09-20  Tom Tromey  <tom@tromey.com>
3653
3654         * tui/tui.c (tui_enable): Update.
3655         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3656         Update.
3657         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3658         Update.
3659         * tui/tui-data.c (win_resized): Now bool.
3660         (tui_win_resized): Return bool.
3661         (tui_set_win_resized_to): Accept a bool.
3662
3663 2019-09-20  Tom Tromey  <tom@tromey.com>
3664
3665         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3666         Change type of "refresh_values_only".
3667         * tui/tui-regs.c (tui_data_window::show_register_group): Change
3668         type of "refresh_values_only".
3669
3670 2019-09-20  Tom Tromey  <tom@tromey.com>
3671
3672         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3673         std::string.
3674         (tui_disassemble): Add "pos" parameter.
3675         (tui_disasm_window::set_contents): Simplify.
3676
3677 2019-09-20  Tom Tromey  <tom@tromey.com>
3678
3679         * tui/tui-winsource.h (struct tui_source_window_base)
3680         <show_source_content>: Now private.
3681         * tui/tui-winsource.c
3682         (tui_source_window_base::show_source_content): Don't handle empty
3683         content case.
3684
3685 2019-09-20  Tom Tromey  <tom@tromey.com>
3686
3687         * tui/tui-layout.c (show_source_disasm_command)
3688         (show_source_or_disasm_and_command): Don't call
3689         show_source_content.
3690
3691 2019-09-20  Tom Tromey  <tom@tromey.com>
3692
3693         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3694         Declare.
3695         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3696         from tui_make_status_line.
3697         (tui_locator_window::rerender): Update.
3698
3699 2019-09-20  Tom Tromey  <tom@tromey.com>
3700
3701         * tui/tui-stack.c (tui_make_status_line): Return std::string.
3702         (tui_locator_window::rerender): Update.
3703
3704 2019-09-20  Tom Tromey  <tom@tromey.com>
3705
3706         * tui/tui-winsource.h (struct tui_source_window_base)
3707         <~tui_source_window_base>: Don't declare.
3708         <fullname>: Remove.
3709         * tui/tui-winsource.c (~tui_source_window_base): Remove.
3710         * tui/tui-source.h (struct tui_source_window) <fullname>: New
3711         member.
3712         * tui/tui-source.c (tui_source_window::set_contents): Update.
3713         (tui_source_window::location_matches_p)
3714         (tui_source_window::maybe_update): Update.
3715
3716 2019-09-20  Tom Tromey  <tom@tromey.com>
3717
3718         * tui/tui-winsource.h (~tui_source_element): Remove.
3719         (tui_source_element): Update.
3720         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3721         * tui/tui-winsource.c (tui_show_source_line): Update.
3722         * tui/tui-source.c (tui_source_window::set_contents): Update.
3723         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3724
3725 2019-09-20  Tom Tromey  <tom@tromey.com>
3726
3727         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3728         declare.
3729         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3730         tui_clear_source_windows_detail.
3731         * tui/tui-winsource.h (struct tui_source_window_base)
3732         <clear_detail>: Don't declare.
3733         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3734         Remove.
3735         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3736
3737 2019-09-20  Tom Tromey  <tromey@adacore.com>
3738
3739         PR ada/24919:
3740         * block.c (contained_in): Fix final return value.
3741
3742 2019-09-20  Alan Modra  <amodra@gmail.com>
3743
3744         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3745         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3746         (read_indirect_string_from_dwz): Use bfd accessor.
3747         * dwarf2read.h (struct dwz_file <filename>): Likewise.
3748         * machoread.c (macho_symfile_read_all_oso): Likewise.
3749         * solib.c (solib_bfd_open): Likewise.
3750
3751 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3752
3753         * eval.c: Move declaration of overload_resolution to...
3754         * value.h: ...here.
3755
3756 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3757
3758         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3759         * arm-linux-tdep.c: Likewise.
3760         * arm-nbsd-nat.c: Likewise.
3761         * arm-tdep.h: Declare arm_apcs_32.
3762         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3763
3764 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3765
3766         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3767         * dwarf2read.h: Declare dwarf_always_disassemble.
3768
3769 2019-09-19  Tom de Vries  <tdevries@suse.de>
3770
3771         PR gdb/25009
3772         * source-cache.c (source_cache::ensure): Catch exception thrown during
3773         construction of the highlighter.
3774
3775 2019-09-18  Alan Modra  <amodra@gmail.com>
3776
3777         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3778         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3779         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3780         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3781         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3782         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3783         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3784         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3785         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3786         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3787         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3788         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3789         * solib-spu.c, * solib-svr4.c, * solib-target.c,
3790         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3791         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3792         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3793         * mi/mi-interp.c: Update throughout for bfd section macro and
3794         function changes.
3795         * gcore (gcore_create_callback): Use bfd_set_section_lma.
3796         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3797
3798 2019-09-18  Tom Tromey  <tom@tromey.com>
3799
3800         * NEWS: Add entry.
3801         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
3802         call rl_initialize.
3803         (tui_enable): Do not call rl_initialize.
3804
3805 2019-09-18  Christian Groessler  <chris@groessler.org>
3806
3807         * alpha-linux-nat.c: Include gdbarch.h.
3808
3809 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
3810
3811         * ui-file.c: Include cli/cli-style.h.
3812         (term_cli_styling): Remove cli_styling declaration.
3813
3814 2019-09-18  Alan Modra  <amodra@gmail.com>
3815
3816         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3817         to bfd_asymbol_section.
3818
3819 2019-09-18  Alan Modra  <amodra@gmail.com>
3820
3821         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3822         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3823         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3824
3825 2019-09-18  Alan Modra  <amodra@gmail.com>
3826
3827         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3828         * spu-linux-nat.c (spu_bfd_open): Likewise.
3829
3830 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
3831
3832         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3833         to bool to match definition in dwarf2read.c.
3834
3835 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
3836
3837         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3838         (print_signatures): Likewise.
3839         (trust_pad_over_xvs): Likewise.
3840         * arch/aarch64-insn.c (aarch64_debug): Likewise.
3841         * arch/aarch64-insn.h (aarch64_debug): Likewise.
3842         * arm-linux-nat.c (arm_apcs_32): Likewise.
3843         * arm-linux-tdep.c (arm_apcs_32): Likewise.
3844         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3845         * arm-tdep.c (arm_debug): Likewise.
3846         (arm_apcs_32): Likewise.
3847         * auto-load.c (debug_auto_load): Likewise.
3848         (auto_load_gdb_scripts): Likewise.
3849         (global_auto_load): Likewise.
3850         (auto_load_local_gdbinit): Likewise.
3851         (auto_load_local_gdbinit_loaded): Likewise.
3852         * auto-load.h (global_auto_load): Likewise.
3853         (auto_load_local_gdbinit): Likewise.
3854         (auto_load_local_gdbinit_loaded): Likewise.
3855         * breakpoint.c (disconnected_dprintf): Likewise.
3856         (breakpoint_proceeded): Likewise.
3857         (automatic_hardware_breakpoints): Likewise.
3858         (always_inserted_mode): Likewise.
3859         (target_exact_watchpoints): Likewise.
3860         (_initialize_breakpoint): Update.
3861         * breakpoint.h (target_exact_watchpoints): Change to bool.
3862         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3863         * cli/cli-cmds.c (trace_commands): Likewise.
3864         * cli/cli-cmds.h (trace_commands): Likewise.
3865         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3866         to bool*.
3867         * cli/cli-logging.c (logging_overwrite): Change to bool.
3868         (logging_redirect): Likewise.
3869         (debug_redirect): Likewise.
3870         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3871         (struct boolean_option_def) <get_var_address_cb_>: Change return type
3872         to bool.
3873         <boolean_option_def>: Update.
3874         (struct flag_option_def): Change default type of Context to bool
3875         from int.
3876         <flag_option_def>: Change return type of var_address_cb_ to bool*.
3877         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3878         (get_setshow_command_value_string): Likewise.
3879         * cli/cli-style.c (cli_styling): Change to bool.
3880         (source_styling): Likewise.
3881         * cli/cli-style.h (source_styling): Likewise.
3882         (cli_styling): Likewise.
3883         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3884         to bool.
3885         * command.h (var_types): Update comment.
3886         (add_setshow_boolean_cmd): Change int* var argument to bool*.
3887         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3888         bool.
3889         (debug_compile_cplus_scopes): Likewise.
3890         * compile/compile-internal.h (compile_debug): Likewise.
3891         * compile/compile.c (compile_debug): Likewise.
3892         (struct compile_options) <raw>: Likewise.
3893         * cp-support.c (catch_demangler_crashes): Likewise.
3894         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3895         (usr_cmd_cris_dwarf2_cfi): Likewise.
3896         * csky-tdep.c (csky_debug): Likewise.
3897         * darwin-nat.c (enable_mach_exceptions): Likewise.
3898         * dcache.c (dcache_enabled_p): Likewise.
3899         * defs.h (info_verbose): Likewise.
3900         * demangle.c (demangle): Likewise.
3901         (asm_demangle): Likewise.
3902         * dwarf-index-cache.c (debug_index_cache): Likewise.
3903         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3904         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3905         * dwarf2read.c (check_physname): Likewise.
3906         (use_deprecated_index_sections): Likewise.
3907         (dwarf_always_disassemble): Likewise.
3908         * eval.c (overload_resolution): Likewise.
3909         * event-top.c (set_editing_cmd_var): Likewise.
3910         (exec_done_display_p): Likewise.
3911         * event-top.h (set_editing_cmd_var): Likewise.
3912         (exec_done_display_p): Likewise.
3913         * exec.c (write_files): Likewise.
3914         * fbsd-nat.c (debug_fbsd_lwp): Likewise
3915         (debug_fbsd_nat): Likewise.
3916         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3917         Likewise.
3918         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3919         <backtrace_past_entry> Likewise.
3920         * gdb-demangle.h (demangle): Likewise.
3921         (asm_demangle): Likewise.
3922         * gdb_bfd.c (bfd_sharing): Likewise.
3923         * gdbcore.h (write_files): Likewise.
3924         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
3925         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
3926         * gdbthread.h (print_thread_events): Likewise.
3927         * gdbtypes.c (opaque_type_resolution): Likewise.
3928         (strict_type_checking): Likewise.
3929         * gnu-nat.c (gnu_debug_flag): Likewise.
3930         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
3931         * guile/scm-param.c (pascm_variable): Add boolval.
3932         (add_setshow_generic): Update.
3933         (pascm_param_value): Update.
3934         (pascm_set_param_value_x): Update.
3935         * hppa-tdep.c (hppa_debug): Change to bool..
3936         * infcall.c (may_call_functions_p): Likewise.
3937         (coerce_float_to_double_p): Likewise.
3938         (unwind_on_signal_p): Likewise.
3939         (unwind_on_terminating_exception_p): Likewise.
3940         * infcmd.c (startup_with_shell): Likewise.
3941         * inferior.c (print_inferior_events): Likewise.
3942         * inferior.h (startup_with_shell): Likewise.
3943         (print_inferior_events): Likewise.
3944         * infrun.c (step_stop_if_no_debug): Likewise.
3945         (detach_fork): Likewise.
3946         (debug_displaced): Likewise.
3947         (disable_randomization): Likewise.
3948         (non_stop): Likewise.
3949         (non_stop_1): Likewise.
3950         (observer_mode): Likewise.
3951         (observer_mode_1): Likewise.
3952         (set_observer_mode): Update.
3953         (sched_multi): Change to bool.
3954         * infrun.h (debug_displaced): Likewise.
3955         (sched_multi): Likewise.
3956         (step_stop_if_no_debug): Likewise.
3957         (non_stop): Likewise.
3958         (disable_randomization): Likewise.
3959         * linux-tdep.c (use_coredump_filter): Likewise.
3960         (dump_excluded_mappings): Likewise.
3961         * linux-thread-db.c (auto_load_thread_db): Likewise.
3962         (check_thread_db_on_load): Likewise.
3963         * main.c (captured_main_1): Update.
3964         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
3965         xx2_opt, boolean_opt>: Change to bool.
3966         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
3967         * maint.c (maintenance_profile_p): Likewise.
3968         (per_command_time): Likewise.
3969         (per_command_space): Likewise.
3970         (per_command_symtab): Likewise.
3971         * memattr.c (inaccessible_by_default): Likewise.
3972         * mi/mi-main.c (mi_async): Likewise.
3973         (mi_async_1): Likewise.
3974         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
3975         * nat/fork-inferior.h (startup_with_shell): Likewise.
3976         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
3977         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
3978         * nios2-tdep.c (nios2_debug): Likewise.
3979         * or1k-tdep.c (or1k_debug): Likewise.
3980         * parse.c (parser_debug): Likewise.
3981         * parser-defs.h (parser_debug): Likewise.
3982         * printcmd.c (print_symbol_filename): Likewise.
3983         * proc-api.c (procfs_trace): Likewise.
3984         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
3985         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
3986         (set_parameter_value): Update.
3987         (add_setshow_generic): Update.
3988         * python/py-value.c (copy_py_bool_obj): Change argument from int*
3989         to bool*.
3990         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
3991         int*.
3992         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
3993         * record-btrace.c (record_btrace_target::store_registers): Update.
3994         * record-full.c (record_full_memory_query): Change to bool.
3995         (record_full_stop_at_limit): Likewise.
3996         * record-full.h (record_full_memory_query): Likewise.
3997         * remote-notif.c (notif_debug): Likewise.
3998         * remote-notif.h (notif_debug): Likewise.
3999         * remote.c (use_range_stepping): Likewise.
4000         (interrupt_on_connect): Likewise.
4001         (remote_break): Likewise.
4002         * ser-tcp.c (tcp_auto_retry): Likewise.
4003         * ser-unix.c (serial_hwflow): Likewise.
4004         * skip.c (debug_skip): Likewise.
4005         * solib-aix.c (solib_aix_debug): Likewise.
4006         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4007         (spu_auto_flush_cache_p): Likewise.
4008         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4009         Likewise.
4010         (struct info_print_options) <quiet>: Likewise.
4011         * symfile-debug.c (debug_symfile): Likewise.
4012         * symfile.c (auto_solib_add): Likewise.
4013         (separate_debug_file_debug): Likewise.
4014         * symfile.h (auto_solib_add): Likewise.
4015         (separate_debug_file_debug): Likewise.
4016         * symtab.c (basenames_may_differ): Likewise.
4017         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4018         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4019         (struct info_types_options) <quiet>: Likewise.
4020         * symtab.h (demangle): Likewise.
4021         (basenames_may_differ): Likewise.
4022         * target-dcache.c (stack_cache_enabled_1): Likewise.
4023         (code_cache_enabled_1): Likewise.
4024         * target.c (trust_readonly): Likewise.
4025         (may_write_registers): Likewise.
4026         (may_write_memory): Likewise.
4027         (may_insert_breakpoints): Likewise.
4028         (may_insert_tracepoints): Likewise.
4029         (may_insert_fast_tracepoints): Likewise.
4030         (may_stop): Likewise.
4031         (auto_connect_native_target): Likewise.
4032         (target_stop_and_wait): Update.
4033         (target_async_permitted): Change to bool.
4034         (target_async_permitted_1): Likewise.
4035         (may_write_registers_1): Likewise.
4036         (may_write_memory_1): Likewise.
4037         (may_insert_breakpoints_1): Likewise.
4038         (may_insert_tracepoints_1): Likewise.
4039         (may_insert_fast_tracepoints_1): Likewise.
4040         (may_stop_1): Likewise.
4041         * target.h (target_async_permitted): Likewise.
4042         (may_write_registers): Likewise.
4043         (may_write_memory): Likewise.
4044         (may_insert_breakpoints): Likewise.
4045         (may_insert_tracepoints): Likewise.
4046         (may_insert_fast_tracepoints): Likewise.
4047         (may_stop): Likewise.
4048         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4049         (make_thread_apply_all_options_def_group): Change argument from int*
4050         to bool*.
4051         (thread_apply_all_command): Update.
4052         (print_thread_events): Change to bool.
4053         * top.c (confirm): Likewise.
4054         (command_editing_p): Likewise.
4055         (history_expansion_p): Likewise.
4056         (write_history_p): Likewise.
4057         (info_verbose): Likewise.
4058         * top.h (confirm): Likewise.
4059         (history_expansion_p): Likewise.
4060         * tracepoint.c (disconnected_tracing): Likewise.
4061         (circular_trace_buffer): Likewise.
4062         * typeprint.c (print_methods): Likewise.
4063         (print_typedefs): Likewise.
4064         * utils.c (debug_timestamp): Likewise.
4065         (sevenbit_strings): Likewise.
4066         (pagination_enabled): Likewise.
4067         * utils.h (sevenbit_strings): Likewise.
4068         (pagination_enabled): Likewise.
4069         * valops.c (overload_resolution): Likewise.
4070         * valprint.h (struct value_print_options) <prettyformat_arrays,
4071         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4072         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4073         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4074         Likewise.
4075         * windows-nat.c (new_console): Likewise.
4076         (cygwin_exceptions): Likewise.
4077         (new_group): Likewise.
4078         (debug_exec): Likewise.
4079         (debug_events): Likewise.
4080         (debug_memory): Likewise.
4081         (debug_exceptions): Likewise.
4082         (useshell): Likewise.
4083         * windows-tdep.c (maint_display_all_tib): Likewise.
4084         * xml-support.c (debug_xml): Likewise.
4085
4086 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4087
4088         * source.c (prepare_path_for_appending): New function.
4089         (openp): Make use of new function.
4090         (find_and_open_source): Search for the compilation directory and
4091         source file as a relative path beneath the directory search path.
4092
4093 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4094
4095         * source-cache.c (source_cache::get_line_charpos): Catch
4096         exceptions and return false, this matches the behaviour documented
4097         in the header file.
4098
4099 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4100
4101         * ada-tasks.c (info_task): Remove quoting of the task's name.
4102
4103 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4104
4105         * symfile.c (auto_solib_add): Replace comment with a reference
4106         to the header file.
4107
4108 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4109
4110         * NEWS: Mention that gdb can now be compiled with Python 3
4111         on Windows.
4112
4113 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4114
4115         * maint.c (maint_print_section_data::maint_print_section_data):
4116         Force use of 'float log10 (float)' by casting the argument to
4117         float.
4118
4119 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4120
4121         * maint.c: Add 'cmath' include.
4122         (struct maint_print_section_data): New structure.
4123         (print_section_index): New function.
4124         (print_bfd_section_info): Add header comment, small whitespace
4125         cleanup, and update to call new print_section_index function.
4126         (print_objfile_section_info): Likewise.
4127         (maint_obj_section_from_bfd_section): New function.
4128         (print_bfd_section_info_maybe_relocated): New function.
4129         (maintenance_info_sections): Add header comment, always use
4130         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4131
4132 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4133
4134         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4135         inner scope, add check that the objfile has psymtabs before
4136         checking psymtabs_addrmap.
4137         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4138
4139 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4140
4141         * NEWS: Announce that Ada task names are now shown at more places,
4142         and between quotes (except in info task output).
4143         * gdb/ada-tasks.c (task_to_str): New function.
4144         (display_current_task_id): Call task_to_str.
4145         (task_command_1): Likewise.
4146         (print_ada_task_info): In non-mi mode, Properly align headers and data
4147         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4148
4149 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4150
4151         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4152         prstatus.pr_lwp.pr_info instead of making it up.
4153
4154 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4155
4156         * auto-load.c (auto_load_expand_dir_vars): Update.
4157         * defs.h (gdb_datadir): Change to std::string.
4158         (python_libdir): Likewise.
4159         (relocate_gdb_directory): Change return type to std::string.
4160         * guile/guile.c (gdbscm_data_directory): Update.
4161         (initialize_scheme_side): Update.
4162         * jit.c (jit_reader_dir): Change to std::string.
4163         (jit_reader_load_command): Update.
4164         * main.c (gdb_datadir): Change to std::string.
4165         (python_libdir): Likewise.
4166         (set_gdb_data_directory): Update.
4167         (relocate_path): Change to return std::string.
4168         (relocate_gdb_directory): Change to return std::string.
4169         (relocate_gdbinit_path_maybe_in_datadir): Update.
4170         (captured_main_1): Update.
4171         * python/python.c (do_start_initialization): Update.
4172         * top.c (show_gdb_datadir): Update.
4173         * xml-syscall.c (xml_init_syscalls_info): Update.
4174         (init_syscalls_info): Update.
4175
4176 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4177
4178         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4179         out of get_init_files.
4180         (get_init_files): Update.
4181
4182 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4183
4184         * main.c (get_init_files): Change to use std::string.
4185         (captured_main_1): Update.
4186         (print_gdb_help): Update.
4187
4188 2019-09-11  Ali Tamur  <tamur@google.com>
4189
4190         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4191         implementation.
4192
4193 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4194
4195         * dbxread.c (read_dbx_symtab): Update.
4196         * dwarf2read.c (load_partial_dies): Update.
4197         * mdebugread.c (parse_partial_symbols): Update.
4198         (handle_psymbol_enumerators): Update.
4199         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4200         * psymtab.c (add_psymbol_to_bcache): Likewise.
4201         (add_psymbol_to_list): Likewise.
4202         * symtab.c (symbol_set_names): Likewise.
4203         * symtab.h (symbol_set_names): Likewise.
4204         * xcoffread.c (scan_xcoff_symtab): Update.
4205
4206 2019-09-11  Tom Tromey  <tom@tromey.com>
4207
4208         * symfile-mem.c (symbol_file_add_from_memory): Use
4209         bfd_set_filename.
4210         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4211         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4212
4213 2019-09-10  Tom Tromey  <tromey@adacore.com>
4214
4215         * dwarf-index-write.c (write_psymbols): Extend error message.
4216         (debug_names::insert): Add Ada code.
4217         (debug_names::write_psymbols): Remove Ada check.
4218         (debug_names) <m_string_obstack>: New member.
4219         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4220         (gdb_index_symbol_name_matcher::matches): Remove.
4221         (mapped_index_base::find_name_components_bounds): Add "lang"
4222         parameter.
4223         (mapped_index_base::build_name_components): Also split names
4224         according to Ada syntax.
4225         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
4226         type of "match_callback".
4227         (check_match, check_find_bounds_finds)
4228         (dw2_expand_symtabs_matching): Update.
4229         (dw2_debug_names_iterator): Add new constructor.
4230         (dw2_debug_names_map_matching_symbols): New function.
4231         (dw2_debug_names_expand_symtabs_matching): Update.
4232         (dwarf2_debug_names_functions): Use
4233         dw2_debug_names_map_matching_symbols.
4234
4235 2019-09-10  Tom Tromey  <tromey@adacore.com>
4236
4237         * dwarf2read.c (dw2_get_file_names_reader): Add the
4238         CU's file name to the results.
4239
4240 2019-09-10  Tom Tromey  <tromey@adacore.com>
4241
4242         * ada-lang.c (add_nonlocal_symbols): Combine calls to
4243         map_matching_symbols.  Update.
4244         * dwarf2read.c (dw2_map_matching_symbols): Update.
4245         * psymtab.c (match_partial_symbol): Change type; update.
4246         (psym_map_matching_symbols): Likewise.
4247         * symfile-debug.c (debug_qf_map_matching_symbols): Change
4248         type; update.
4249         * symfile.h (struct quick_symbol_functions)
4250         <map_matching_symbols>: Change "name" to be a lookup_name_info.
4251         Remove "match".
4252
4253 2019-09-10  Tom Tromey  <tromey@adacore.com>
4254
4255         * psymtab.c (map_block): Remove.
4256         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4257         * symtab.c (iterate_over_symbols_terminated): New function.
4258         * symtab.c (iterate_over_symbols_terminated): Declare.
4259
4260 2019-09-10  Tom Tromey  <tromey@adacore.com>
4261
4262         * ada-lang.c (ada_iterate_over_symbols): Return bool.
4263         * language.h (struct language_defn) <la_iterate_over_symbols>:
4264         Return bool.
4265         * symtab.c (iterate_over_symbols): Return bool.
4266         * symtab.h (iterate_over_symbols): Return bool.
4267
4268 2019-09-10  Tom Tromey  <tromey@adacore.com>
4269
4270         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4271         (add_nonlocal_symbols): Update.
4272         * dwarf2read.c (dw2_map_matching_symbols): Change type.
4273         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4274         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4275         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4276         Change type of "callback".  Remove "data".
4277
4278
4279 2019-09-09  Ali Tamur  <tamur@google.com>
4280
4281         * dwarf2read.c (comp_unit_head): Update comment.
4282         (dwarf2_dwo_name): New function declaration.
4283         (dwarf_unit_type_name): New function declaration.
4284         (read_comp_unit_head): Add support for new compilation units,
4285         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4286         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4287         (currently named as "signature") in their header. Also clarify error
4288         messages.
4289         (lookup_dwo_id): New function. Returns the dwo id of the given
4290         compile unit.
4291         (lookup_dwo_unit): Use the new lookup_dwo_id function.
4292         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4293         functions.
4294         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4295         (dwarf2_dwo_name): Get the dwo name if present.
4296         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4297         purposes.
4298
4299 2019-09-09  Tom Tromey  <tom@tromey.com>
4300
4301         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4302
4303 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4304
4305         * python/python.c (do_start_initialization): Make progname_copy static,
4306         to avoid a leak report.
4307
4308 2019-09-08  Tom Tromey  <tom@tromey.com>
4309
4310         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4311
4312 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
4313
4314         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4315         Change type to gdb::optional<block_enum>.
4316         (dw2_symtab_iter_init): Change block_index parameter type
4317         to gdb::optional<block_enum>.
4318         (dw2_lookup_symbol): Change block_index parameter
4319         type to block_enum.c
4320         (dw2_debug_names_lookup_symbol): Likewise.
4321         * psymtab.c (psym_lookup_symbol): Likewise.
4322         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4323         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4324         Likewise.
4325
4326 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
4327
4328         * defs.h (relocate_gdb_directory): Change int to bool in
4329         signature and rename flag to relocatable.
4330         * main.c (relocate_path): Likewise.
4331         (relocate_gdb_directory): Likewise.
4332
4333 2019-09-06  Alan Modra  <amodra@gmail.com>
4334
4335         * coffread.c (coff_symfile_read): Constify filename variable.
4336         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4337         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4338         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4339         * solib.c (reload_shared_libraries_1): Likewise.
4340         * symfile.c (reread_symbols): Likewise.
4341         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4342         * solib-darwin.c (darwin_bfd_open): Likewise.
4343         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4344
4345 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4346
4347         * psymtab.c (print_partial_symbols): Handle missing domain_enum
4348         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4349
4350 2019-09-03  Tom Tromey  <tromey@adacore.com>
4351
4352         * ada-valprint.c (ada_val_print_num): Don't recurse for range
4353         types.
4354         (has_negatives): Unbias a range type bound.
4355         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4356         * gdbtypes.c (operator==): Handle new field.
4357         (create_range_type): Add "bias" parameter.
4358         (create_static_range_type, resolve_dynamic_range): Update.
4359         * gdbtypes.h (struct range_bounds) <bias>: New member.
4360         (create_range_type): Add bias parameter.
4361         * printcmd.c (print_scalar_formatted): Unbias range types.
4362         * value.c (unpack_long): Unbias range types.
4363         (pack_long): Bias range types.
4364
4365 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4366
4367         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4368         probe arguments.
4369
4370 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4371
4372         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4373         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4374         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4375         (compile_probe_arg): Likewise.
4376         * probe.h (get_argument_count): Likewise.
4377         * solib-svr4.c (solib_event_probe_action): Likewise.
4378         * stap-probe.c (stap_probe::get_argument_count): Likewise.
4379
4380 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4381
4382         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4383         code to here...
4384         (svr4_create_solib_event_breakpoints): ...from here.
4385
4386 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
4387
4388         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4389         suffix from warning message.
4390
4391 2019-08-30  Tom Tromey  <tom@tromey.com>
4392
4393         * tui/tui-winsource.h (struct tui_source_window_base)
4394         <refresh_all>: Don't declare.
4395         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4396         Remove.
4397         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4398         tui_show_locator_content.
4399         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4400         declare.
4401         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4402         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4403         declare.
4404
4405 2019-08-30  Tom Tromey  <tom@tromey.com>
4406
4407         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4408
4409 2019-08-30  Tom Tromey  <tom@tromey.com>
4410
4411         * tui/tui-stack.c (_initialize_tui_stack): Move later.
4412         Remove unnecessary forward declarations.
4413
4414 2019-08-30  Tom Tromey  <tom@tromey.com>
4415
4416         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4417         rerender.
4418         (tui_update_locator_fullname, tui_show_frame_info): Don't call
4419         tui_show_locator_content.
4420
4421 2019-08-30  Tom Tromey  <tom@tromey.com>
4422
4423         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
4424         (tui_locator_window::rerender): Rewrite using body of previous
4425         tui_show_locator_content.
4426
4427 2019-08-30  Tom Tromey  <tom@tromey.com>
4428
4429         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4430         set_locator_fullname>: New methods.
4431         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4432         Rename from tui_set_locator_fullname.
4433         (tui_locator_window::set_locator_info): Rename from
4434         tui_set_locator_info.  Return bool.
4435         (tui_update_locator_fullname, tui_show_frame_info): Update.
4436
4437 2019-08-30  Tom Tromey  <tom@tromey.com>
4438
4439         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4440
4441 2019-08-30  Tom Tromey  <tom@tromey.com>
4442
4443         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4444         call touchwin.
4445
4446 2019-08-30  Tom Tromey  <tom@tromey.com>
4447
4448         * tui/tui-wingeneral.c (box_win): Assume win_info and
4449         win_info->handle cannot be NULL.
4450
4451 2019-08-30  Tom Tromey  <tom@tromey.com>
4452
4453         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4454         refresh_window>: Declare.
4455         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4456         resize.
4457         (tui_data_item_window::rerender): Rename from
4458         tui_display_register.
4459         (tui_data_item_window::refresh_window): New method.
4460         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4461         no-op.
4462
4463 2019-08-30  Tom Tromey  <tom@tromey.com>
4464
4465         * tui/tui-regs.h (struct tui_data_window) <regs_content,
4466         regs_column_count, current_group>: Move later.  Now private.
4467         <get_current_group>: New method.
4468         * tui/tui-regs.c (tui_reg_command): Update.
4469         * tui/tui-layout.c (tui_set_layout): Update.
4470
4471 2019-08-30  Tom Tromey  <tom@tromey.com>
4472
4473         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4474         (tui_data_window::rerender): Don't call
4475         check_and_display_highlight_if_needed.
4476         (tui_data_window::refresh_all): Remove call to
4477         erase_data_content.
4478
4479 2019-08-30  Tom Tromey  <tom@tromey.com>
4480
4481         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4482         (tui_data_window::display_registers_from)
4483         (tui_data_window::display_reg_element_at_line)
4484         (tui_data_window::display_registers_from_line): Remove checks of
4485         "empty".
4486
4487 2019-08-30  Tom Tromey  <tom@tromey.com>
4488
4489         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4490         Don't declare.
4491         * tui/tui-regs.c (tui_data_window::show_registers): Call
4492         rerender.
4493         (tui_data_window::rerender): Rename from display_all_data.
4494         (tui_data_window::rerender): Remove old implementation.
4495
4496 2019-08-30  Tom Tromey  <tom@tromey.com>
4497
4498         * tui/tui-regs.c (tui_data_window::display_all_data): Change
4499         text.
4500         * tui/tui-data.h (NO_DATA_STRING): Remove define.
4501
4502 2019-08-29  Bernhard Wodok  <barto@gmx.net>
4503             Sergio Durigan Junior  <sergiodj@redhat.com>
4504
4505         PR win32/24284
4506         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4507
4508 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4509
4510         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4511         when searching for types.
4512
4513 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4514
4515         * f-lang.c (f_language_defn): Use f_print_typedef.
4516         * f-lang.h (f_print_typedef): Declare.
4517         * f-typeprint.c (f_print_typedef): Define.
4518
4519 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
4520
4521         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4522
4523 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4524
4525         * cli/cli-utils.c (info_print_options_defs): Delete.
4526         (make_info_print_options_def_group): Delete.
4527         (extract_info_print_options): Delete.
4528         (info_print_command_completer): Delete.
4529         (info_print_args_help): Add extra parameter, and optionally
4530         include text about -n flag.
4531         * cli/cli-utils.h (struct info_print_options): Delete.
4532         (extract_info_print_options): Delete declaration.
4533         (info_print_command_completer): Delete declaration.
4534         (info_print_args_help): Add extra parameter, extend header
4535         comment.
4536         * python/python.c (gdbpy_rbreak): Pass additional parameter to
4537         search_symbols.
4538         * stack.c (struct info_print_options): New type.
4539         (info_print_options_defs): New file scoped variable.
4540         (make_info_print_options_def_group): New static function.
4541         (info_print_command_completer): New static function.
4542         (info_locals_command): Update to use new local functions.
4543         (info_args_command): Likewise.
4544         (_initialize_stack): Add extra parameter to calls to
4545         info_print_args_help.
4546         * symtab.c (search_symbols): Add extra parameter, use this to
4547         possibly excluse non-debug symbols.
4548         (symtab_symbol_info): Add extra parameter, which is passed on to
4549         search_symbols.
4550         (struct info_print_options): New type.
4551         (info_print_options_defs): New file scoped variable.
4552         (make_info_print_options_def_group): New static function.
4553         (info_print_command_completer): New static function.
4554         (info_variables_command): Update to use local functions, and pass
4555         extra parameter through to symtab_symbol_info.
4556         (info_functions_command): Likewise.
4557         (info_types_command): Pass additional argument through to
4558         symtab_symbol_info.
4559         (rbreak_command): Pass extra argument to search_symbols.
4560         (_initialize_symtab): Add extra arguments for calls to
4561         info_print_args_help, and update help text for 'info variables',
4562         'whereis', and 'info functions' commands.
4563         * symtab.h (search_symbols): Add extra argument to declaration.
4564         * NEWS: Mention new flags.
4565
4566 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
4567
4568         * symtab.c (lookup_static_symbol): Call the new function (and move
4569         it down to be next to lookup_global_symbol).
4570         (struct global_sym_lookup_data): Add block_enum member and rename to...
4571         (struct global_or_static_sym_lookup_data): ...this.
4572         (lookup_symbol_global_iterator_cb): Pass block_index instead of
4573         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4574         (lookup_symbol_global_or_static_iterator_cb): ...this.
4575         (lookup_global_or_static_symbol): New function.
4576         (lookup_global_symbol): Call new function.
4577
4578 2019-08-26  Tom de Vries  <tdevries@suse.de>
4579
4580         PR c++/24852
4581         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4582         when pc_probe.prob == NULL.
4583
4584 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4585
4586         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4587         variable symbol_linkage to symbol_linkage_.
4588
4589 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4590
4591         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4592         represent whether the symbol is static, dynamic, or we don't
4593         know.
4594
4595 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
4596
4597         * gdb/rx-tdep.c (rx_register_names): New.
4598         (rx_register_name): Delete.
4599         (rx_psw_type): Delete.
4600         (rx_fpsw_type): Delete.
4601         (rx_register_type): Delete.
4602         (rx_gdbarch_init): Convert target-descriptions.
4603         (_initialize_rx_tdep): Add initialize_tdesc_rx.
4604         * gdb/features/Makefile: Add rx.xml.
4605         * gdb/features/rx.xml: New.
4606         * gdb/features/rx.c: Generated.
4607         * gdb/NEWS: Mention target description support.
4608
4609 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4610
4611         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4612         *slot_ptr.
4613
4614 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4615
4616         * configure.ac: Don't check for 'dlfcn.h' (moved to
4617         gdbsupport/common.m4).
4618         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4619         'gdbsupport/'.
4620         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4621         * compile/compile-c-support.c: Include
4622         'gdbsupport/gdb-dlfcn.h'.
4623         * gdbsupport/common.m4: Check for 'dlfcn.h'.
4624         * gdb-dlfcn.c: Move to...
4625         * gdbsupport/gdb-dlfcn.c: ... here.
4626         * gdb-dlfcn.h: Move to...
4627         * gdbsupport/gdb-dlfcn.h: ... here.
4628
4629 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
4630
4631         * nios2-tdep.c (struct reg_value): Improve comments.  Make
4632         the offset field signed.
4633
4634 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4635
4636         * python/lib/gdb/__init__.py (_execute_file): New function.
4637         * python/python.c (python_run_simple_file): Call gdb._execute_file
4638         on Windows.
4639
4640 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4641
4642         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4643         all uses as this was never set to anything but a zero value.
4644
4645 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
4646
4647         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4648
4649 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
4650
4651         * tui/tui-data.h (tui_gen_win_info): Add an =default
4652         move constructor, required by some GCC versions.
4653
4654 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
4655
4656         * go32-nat.c (go32_sysinfo): Add hygon_p.
4657
4658 2019-08-20  Tom Tromey  <tom@tromey.com>
4659
4660         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4661         line_from_reg_element_no, first_reg_element_no_inline,
4662         display_all_data, delete_data_content_windows,
4663         erase_data_content>: Now private.
4664
4665 2019-08-20  Tom Tromey  <tom@tromey.com>
4666
4667         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4668         (tui_unhighlight_win, tui_highlight_win)
4669         (tui_win_info::make_window): Update.
4670         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4671
4672 2019-08-20  Tom Tromey  <tom@tromey.com>
4673
4674         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4675         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4676         (MAX_PID_WIDTH): Move to tui-stack.c.
4677         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4678         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4679         (MAX_PID_WIDTH): Move from tui-data.h.
4680
4681 2019-08-20  Tom Tromey  <tom@tromey.com>
4682
4683         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4684         * tui/tui-wingeneral.c (box_win): Change type of win_info.
4685         (box_win): Update.
4686         (tui_gen_win_info::make_window): Rename from tui_make_window.
4687         (tui_win_info::make_window): New method.
4688         (tui_gen_win_info::make_visible): Update.
4689         * tui/tui-source.c (tui_source_window::set_contents): Update.
4690         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4691         (tui_data_window::display_registers_from): Update.
4692         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4693         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4694         Declare.
4695         <can_box>: Remove.
4696         <title>: Remove.
4697         (struct tui_win_info) <make_window>: Declare.
4698         <can_box>: Now virtual.
4699         <title>: New member.
4700         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4701         * tui/tui-command.c (tui_cmd_window::resize): Update.
4702
4703 2019-08-20  Tom Tromey  <tom@tromey.com>
4704
4705         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4706         * tui/tui-regs.c (tui_data_window::show_registers): Update.
4707         (tui_data_window::check_register_values): Update.
4708
4709 2019-08-20  Tom Tromey  <tom@tromey.com>
4710
4711         * tui/tui-regs.h (struct tui_data_window): Use
4712         DISABLE_COPY_AND_ASSIGN.
4713         <regs_content>: Change type, removing unique_ptr.
4714         <tui_data_window>: Add move constructor.
4715         * tui/tui-regs.c (tui_data_window::show_registers)
4716         (tui_data_window::show_register_group)
4717         (tui_data_window::display_registers_from)
4718         (tui_data_window::display_registers_from)
4719         (tui_data_window::first_data_item_displayed)
4720         (tui_data_window::delete_data_content_windows)
4721         (tui_data_window::rerender, tui_data_window::refresh_window)
4722         (tui_data_window::check_register_values): Update.
4723
4724 2019-08-20  Tom Tromey  <tom@tromey.com>
4725
4726         * tui/tui-regs.h (struct tui_data_window) <show_registers,
4727         show_register_group>: Declare.
4728         (tui_show_register_group): Don't declare.
4729         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4730         tui_show_registers.
4731         (tui_data_window::show_register_group): Rename from
4732         tui_show_register_group.
4733         (tui_data_window::check_register_values, tui_reg_command):
4734         Update.
4735         * tui/tui-layout.c (tui_set_layout): Update.
4736
4737 2019-08-20  Tom Tromey  <tom@tromey.com>
4738
4739         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4740         Declare.
4741         (tui_check_register_values): Don't declare.
4742         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4743         from tui_check_register_values.
4744         * tui/tui-hooks.c (tui_register_changed): Update.
4745
4746 2019-08-20  Tom Tromey  <tom@tromey.com>
4747
4748         * tui/tui-regs.c (tui_reg_layout): Move later.
4749         (tui_show_registers): Don't enable TUI mode or change layout.
4750
4751 2019-08-20  Tom Tromey  <tom@tromey.com>
4752
4753         * tui/tui-regs.h (struct tui_data_item_window)
4754         <~tui_data_item_window>: Remove.
4755         <content>: Now a unique_xmalloc_ptr.
4756         * tui/tui-regs.c (tui_register_format): Return a
4757         unique_xmalloc_ptr.
4758         (tui_get_register): Update.
4759         (~tui_data_item_window): Remove.
4760         (tui_data_window::display_registers_from, tui_display_register):
4761         Update.
4762         * tui/tui-io.h (tui_expand_tabs): Update.
4763         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4764         Remove "col" parameter.
4765
4766 2019-08-20  Tom Tromey  <tom@tromey.com>
4767
4768         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4769         field.
4770         * tui/tui-regs.c (~tui_data_item_window): Update.
4771
4772 2019-08-20  Tom Tromey  <tom@tromey.com>
4773
4774         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4775         earlier.
4776
4777 2019-08-20  Tom Tromey  <tom@tromey.com>
4778
4779         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4780
4781 2019-08-20  Tom Tromey  <tom@tromey.com>
4782
4783         * tui/tui-source.h (struct tui_source_window): Update.
4784         * tui/tui-regs.c (tui_show_registers): Update.
4785         * tui/tui-disasm.h (struct tui_disasm_window): Update.
4786         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4787         (NO_REGS_STRING): Remove defines.
4788
4789 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
4790
4791         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4792         unnecessary thread walk if remote doesn't support the packet.
4793
4794 2019-08-19  Tom Tromey  <tromey@adacore.com>
4795
4796         * python/py-value.c (value_has_field): Fix indentation.
4797
4798 2019-08-19  Tom Tromey  <tromey@adacore.com>
4799
4800         * printcmd.c (do_one_display, info_display_command): Update.
4801         * block.h (contained_in): Return bool.  Add allow_nested
4802         parameter.
4803         * block.c (contained_in): Return bool.  Add allow_nested
4804         parameter.
4805
4806 2019-08-19  Tom Tromey  <tom@tromey.com>
4807
4808         * configure: Rebuild.
4809         * configure.ac: Disallow the combination of -static-libstdc++ and
4810         source highlight.
4811         * source-cache.c (get_language_name): Handle rust.
4812         (source_cache::get_source_lines): Ignore highlighting exceptions.
4813
4814 2019-08-16  Tom Tromey  <tom@tromey.com>
4815
4816         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4817         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4818         (struct tui_source_window_base) <make_visible, refresh_window,
4819         resize>: Remove methods.
4820         <execution_info>: Remove field.
4821         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4822         (tui_show_source_line, tui_source_window_base)
4823         (~tui_source_window_base): Update.
4824         (tui_source_window_base::resize)
4825         (tui_source_window_base::make_visible)
4826         (tui_source_window_base::refresh_window): Remove.
4827         (tui_source_window_base::update_exec_info): Update.
4828         * tui/tui-source.c (tui_source_window::set_contents): Update.
4829         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4830
4831 2019-08-16  Tom Tromey  <tom@tromey.com>
4832
4833         * tui/tui-hooks.c (tui_remove_hooks): Don't set
4834         deprecated_query_hook.
4835
4836 2019-08-16  Tom Tromey  <tom@tromey.com>
4837
4838         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4839         (tui_update_source_windows_with_line): Update.
4840         * tui/tui-source.h (struct tui_source_window)
4841         <show_symtab_source>: Declare.
4842         (tui_show_symtab_source): Don't declare.
4843         * tui/tui-source.c (tui_show_symtab_source): Rename from
4844         tui_show_symtab_source.
4845
4846 2019-08-16  Tom Tromey  <tom@tromey.com>
4847
4848         * tui/tui-winsource.h (struct tui_source_window_base)
4849         <set_contents>: Declare.
4850         * tui/tui-winsource.c
4851         (tui_source_window_base::update_source_window_as_is): Update.
4852         * tui/tui-source.h (struct tui_source_window) <set_contents>:
4853         Declare.
4854         (tui_set_source_content): Don't declare.
4855         * tui/tui-source.c (tui_source_window::set_contents): Rename from
4856         tui_set_source_content.
4857         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4858         Declare.
4859         (tui_set_disassem_content): Don't declare.
4860         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4861         tui_set_disassem_content.
4862
4863 2019-08-16  Tom Tromey  <tom@tromey.com>
4864
4865         * tui/tui-winsource.h (struct tui_source_window_base)
4866         <update_breakpoint_info>: Declare.
4867         (tui_update_breakpoint_info): Don't declare.
4868         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4869         (tui_update_all_breakpoint_info): Update.
4870         (tui_source_window_base::update_breakpoint_info): Rename from
4871         tui_update_breakpoint_info.
4872         (tui_source_window_base::update_exec_info): Update.
4873
4874 2019-08-16  Tom Tromey  <tom@tromey.com>
4875
4876         * tui/tui-winsource.h (struct tui_source_window_base)
4877         <update_source_window>: Declare.
4878         (tui_update_source_window): Don't declare.
4879         * tui/tui-winsource.c
4880         (tui_source_window_base::update_source_window): Rename from
4881         tui_update_source_window.
4882         (tui_source_window_base::rerender): Update.
4883         * tui/tui-source.c (tui_source_window::maybe_update): Update.
4884         * tui/tui-disasm.c (tui_show_disassem)
4885         (tui_show_disassem_and_update_source)
4886         (tui_disasm_window::maybe_update): Update.
4887
4888 2019-08-16  Tom Tromey  <tom@tromey.com>
4889
4890         * tui/tui-winsource.h (struct tui_source_window_base)
4891         <update_source_window_as_is>: Declare.
4892         (tui_update_source_window_as_is): Don't declare.
4893         * tui/tui-winsource.c (tui_update_source_window): Update
4894         (tui_source_window_base::update_source_window_as_is): Rename from
4895         tui_update_source_window_as_is.
4896         (tui_source_window_base::refill): Update.
4897         * tui/tui-source.c (tui_show_symtab_source): Update.
4898         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4899         Update.
4900
4901 2019-08-16  Tom Tromey  <tom@tromey.com>
4902
4903         * tui/tui-winsource.h (tui_update_source_window)
4904         (tui_update_source_window_as_is): Remove "noerror" parameter.
4905         * tui/tui-winsource.c (tui_update_source_window)
4906         (tui_update_source_window_as_is): Remove "noerror" parameter.
4907         (tui_update_source_windows_with_addr)
4908         (tui_update_source_windows_with_line)
4909         (tui_source_window_base::rerender)
4910         (tui_source_window_base::refill): Update.
4911         * tui/tui-source.h (tui_set_source_content)
4912         (tui_show_symtab_source): Remove "noerror" parameter.
4913         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4914         parameter.
4915         (tui_show_symtab_source): Likewise.
4916         (tui_source_window::maybe_update): Update.
4917         * tui/tui-disasm.c (tui_show_disassem)
4918         (tui_show_disassem_and_update_source)
4919         (tui_disasm_window::do_scroll_vertical)
4920         (tui_disasm_window::maybe_update): Update.
4921
4922 2019-08-16  Tom Tromey  <tom@tromey.com>
4923
4924         * tui/tui.c (tui_is_window_visible): Update.
4925         * tui/tui-wingeneral.c (tui_make_window)
4926         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
4927         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
4928         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
4929         (tui_set_win_height_command, parse_scrolling_args): Update.
4930         * tui/tui-source.c (tui_source_window::style_changed): Update.
4931         * tui/tui-regs.c (tui_show_registers)
4932         (tui_data_window::first_data_item_displayed)
4933         (tui_data_window::delete_data_content_windows)
4934         (tui_check_register_values, tui_reg_command): Update.
4935         * tui/tui-disasm.c (tui_show_disassem): Update.
4936         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
4937         method.
4938         <is_visible>: Remove field.
4939         * tui/tui-data.c (tui_next_win, tui_prev_win)
4940         (tui_delete_invisible_windows): Update.
4941
4942 2019-08-16  Tom Tromey  <tom@tromey.com>
4943
4944         * tui/tui-winsource.h (struct tui_source_window_base)
4945         <m_has_locator>: Remove.
4946         * tui/tui-layout.c (show_source_disasm_command, show_data)
4947         (show_source_or_disasm_and_command): Update.
4948
4949 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
4950
4951         * NEWS (Other MI changes): New subsection.
4952         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
4953         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
4954         * arch-utils.c (default_get_pc_address_flags): New function.
4955         * arch-utils.h (default_get_pc_address_flags): New declaration.
4956         * gdbarch.sh: Add get_pc_address_flags.
4957         * gdbarch.c: Regenerate.
4958         * gdbarch.h: Likewise.
4959         * stack.c (print_pc): New function.
4960         (print_frame_info) (print_frame): Call print_pc.
4961
4962 2019-08-16  Tom de Vries  <tdevries@suse.de>
4963
4964         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
4965         print_objfile_section_info.
4966
4967 2019-08-15  Tom Tromey  <tom@tromey.com>
4968
4969         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
4970         calling update_cmdwin_start_line.
4971         * tui/tui-winsource.h (struct tui_source_window_base)
4972         <do_make_visible_with_new_height, set_new_height>: Don't declare.
4973         <rerender>: Declare.
4974         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
4975         Call rerender.
4976         (tui_source_window_base::set_new_height): Remove.
4977         (tui_source_window_base::rerender): Rename from
4978         do_make_visible_with_new_height.
4979         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
4980         resize method.
4981         (tui_win_info::make_invisible_and_set_new_height)
4982         (tui_win_info::make_visible_with_new_height): Remove.
4983         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
4984         Declare.
4985         * tui/tui-stack.c (tui_locator_window::rerender): New method.
4986         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
4987         do_make_visible_with_new_height>: Don't declare.
4988         <rerender>: Declare.
4989         * tui/tui-regs.c (tui_data_window::rerender): Rename from
4990         set_new_height.
4991         (tui_data_window::do_make_visible_with_new_height): Remove.
4992         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
4993         call tui_show_locator_content.
4994         (tui_gen_win_info::resize): Call rerender.
4995         (show_source_or_disasm_and_command): Don't call
4996         tui_show_locator_content.
4997         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
4998         method.
4999         (struct tui_win_info) <rerender>: Declare.
5000         <set_new_height, make_invisible_and_set_new_height,
5001         make_visible_with_new_height>: Don't declare.
5002         * tui/tui-data.c (tui_win_list::rerender): New method.
5003         * tui/tui-command.h (struct tui_cmd_window)
5004         <do_make_visible_with_new_height>: Don't declare.
5005         * tui/tui-command.c
5006         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5007
5008 2019-08-15  Tom Tromey  <tromey@adacore.com>
5009
5010         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5011         * ada-lang.c (ada_enum_name): Likewise.
5012
5013 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5014
5015         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5016         leading underscore.
5017         (GdbOutputErrorFile): Likewise.
5018         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5019         accordingly.
5020         (execute_unwinders): Rename to have a leading underscore.
5021         (auto_load_packages): Likewise.
5022         (global scope): Adjust call to auto_load_packages accordingly.
5023         (GdbSetPythonDirectory): Likewise.
5024         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5025         instead of execute_unwinders.
5026
5027 2019-08-15  Tom Tromey  <tom@tromey.com>
5028
5029         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5030         (show_data): Don't change window visibility.
5031         (tui_gen_win_info::resize): Remove special case for command
5032         window.  Use wresize, when available.
5033         (show_source_or_disasm_and_command): Don't change window
5034         visibility.
5035         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5036         <make_visible>: New method.
5037         * tui/tui-command.c (tui_cmd_window::resize): New method.
5038
5039 2019-08-15  Tom Tromey  <tom@tromey.com>
5040
5041         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5042         (struct tui_source_windows): New.
5043         * tui/tui-winsource.c (tui_display_main): Update.
5044         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5045         (new_height_ok, parse_scrolling_args): Update.
5046         * tui/tui-layout.c (show_layout, show_data): Update.
5047         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5048         (tui_add_to_source_windows): Don't declare.
5049         * tui/tui-data.c (source_windows, tui_source_windows)
5050         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5051
5052 2019-08-15  Tom Tromey  <tom@tromey.com>
5053
5054         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5055         Rename from reset.
5056         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5057         * tui/tui-layout.c (show_source_disasm_command, show_data):
5058         Update.
5059         (tui_gen_win_info::resize): Rename.
5060         (show_source_or_disasm_and_command): Update.
5061         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5062         reset.
5063
5064 2019-08-15  Tom Tromey  <tom@tromey.com>
5065
5066         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5067         * tui/tui-interp.c (tui_interp::init): Don't call
5068         tui_initialize_static_data.
5069         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5070
5071 2019-08-15  Tom Tromey  <tom@tromey.com>
5072
5073         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5074         examine tui_win_list.
5075
5076 2019-08-15  Tom Tromey  <tom@tromey.com>
5077
5078         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5079         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5080         tui_clear_source_content.
5081         (tui_clear_source_content): Remove.
5082         (tui_source_window_base::do_erase_source_content): Hoist call to
5083         content.clear().
5084         * tui/tui-stack.c (tui_show_frame_info): Don't call
5085         tui_clear_source_content.
5086
5087 2019-08-15  Tom Tromey  <tom@tromey.com>
5088
5089         * tui/tui-winsource.h (struct tui_source_window_base)
5090         <do_erase_source_content>: New method.
5091         <erase_source_content>: New method.
5092         (tui_erase_source_content): Don't declare.
5093         * tui/tui-winsource.c (tui_clear_source_content): Update.
5094         (tui_source_window_base::do_erase_source_content): Rename from
5095         tui_erase_source_content.
5096         (tui_source_window_base::show_source_content): Update.
5097         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5098         * tui/tui-source.h (struct tui_source_window)
5099         <erase_source_content>: New method.
5100         * tui/tui-disasm.h (struct tui_disasm_window)
5101         <erase_source_content>: New method.
5102
5103 2019-08-15  Tom Tromey  <tom@tromey.com>
5104
5105         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5106         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5107         constructor.
5108         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5109         * tui/tui-source.c (tui_set_source_content): Update.
5110         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5111
5112 2019-08-15  Tom Tromey  <tom@tromey.com>
5113
5114         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5115         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5116         tui-source.c.
5117         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5118         Declare.
5119         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5120         method.
5121         (tui_source_window::maybe_update): Update.
5122
5123 2019-08-15  Tom Tromey  <tom@tromey.com>
5124
5125         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5126         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5127         tui-disasm.c.
5128         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5129         Declare.
5130         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5131         method.
5132         (tui_disasm_window::maybe_update): Update.
5133
5134 2019-08-15  Tom Tromey  <tom@tromey.com>
5135
5136         * tui/tui-winsource.h (struct tui_source_window_base)
5137         <maybe_update>: Declare.
5138         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5139         method.
5140         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5141         Declare.
5142         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5143         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5144         Declare.
5145         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5146
5147 2019-08-15  Tom Tromey  <tom@tromey.com>
5148
5149         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5150
5151 2019-08-15  Tom Tromey  <tom@tromey.com>
5152
5153         * tui/tui-wingeneral.c: Include tui-stack.h.
5154         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5155         (struct tui_locator_window): Move from tui-data.h.
5156         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5157         (tui_initialize_static_data): Move from tui-data.c.
5158         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5159         (struct tui_locator_window): Move to tui-stack.c.
5160         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5161         (tui_initialize_static_data): Move to tui-stack.c.
5162
5163 2019-08-15  Tom Tromey  <tom@tromey.com>
5164
5165         * tui/tui-layout.c (show_source_disasm_command)
5166         (show_source_or_disasm_and_command): Use make_visible method, not
5167         tui_make_window.
5168         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5169         Remove.
5170
5171 2019-08-15  Tom Tromey  <tom@tromey.com>
5172
5173         * tui/tui-wingeneral.h (tui_make_window): Update.
5174         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5175         parameter.
5176         (tui_gen_win_info::make_visible): Update.
5177         * tui/tui-regs.c (tui_data_window::display_registers_from):
5178         Update.
5179         * tui/tui-layout.c (show_source_disasm_command)
5180         (show_source_or_disasm_and_command): Update.
5181         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5182         (enum tui_box): Remove.
5183         (struct tui_win_info) <can_box>: New method.
5184         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5185         method.
5186
5187 2019-08-15  Tom de Vries  <tdevries@suse.de>
5188
5189         * linux-nat-trad.c: Include gdbarch.h.
5190
5191 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5192
5193         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5194         register sizes.
5195
5196 2019-08-14  Tom Tromey  <tromey@adacore.com>
5197
5198         * darwin-nat.c: Include gdbarch.h.
5199         * darwin-nat-info.c: Include gdbarch.h.
5200
5201 2019-08-13  Tom Tromey  <tom@tromey.com>
5202
5203         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5204         Remove.
5205         * tui/tui-data.c (tui_initialize_static_data): Update.
5206
5207 2019-08-13  Tom Tromey  <tom@tromey.com>
5208
5209         * tui/tui-winsource.h (struct tui_exec_info_window)
5210         <~tui_exec_info_window, maybe_allocate_content, get_content,
5211         m_content>: Remove.
5212         (struct tui_source_window_base) <set_exec_info_content,
5213         show_exec_info_content>: Don't declare.
5214         * tui/tui-winsource.c
5215         (tui_exec_info_window::maybe_allocate_content): Remove.
5216         (tui_source_window_base::update_exec_info): Rename from
5217         set_exec_info_content.
5218         (tui_source_window_base::show_exec_info_content)
5219         (tui_source_window_base::update_exec_info): Remove.
5220
5221 2019-08-13  Tom Tromey  <tom@tromey.com>
5222
5223         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5224         declare.
5225         * tui/tui-winsource.c (tui_update_source_window_as_is)
5226         (tui_update_source_windows_with_addr, tui_erase_source_content):
5227         Update.
5228         (tui_clear_exec_info_content): Remove.
5229
5230 2019-08-13  Tom Tromey  <tom@tromey.com>
5231
5232         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5233         declare.
5234         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5235         call tui_erase_exec_info_content.
5236         (tui_clear_exec_info_content): Rename from
5237         tui_erase_exec_info_content.
5238         (tui_clear_exec_info_content): Delete.
5239
5240 2019-08-13  Tom Tromey  <tom@tromey.com>
5241
5242         * tui/tui-winsource.h (struct tui_source_window_base)
5243         <show_exec_info_content>: Declare.
5244         (tui_show_exec_info_content): Don't declare.
5245         * tui/tui-winsource.c
5246         (tui_source_window_base::show_exec_info_content): Rename from
5247         tui_show_exec_info_content.
5248         (tui_source_window_base::update_exec_info): Update.
5249
5250 2019-08-13  Tom Tromey  <tom@tromey.com>
5251
5252         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5253         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5254         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5255         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5256         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5257         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5258         ... here.
5259
5260 2019-08-13  Tom Tromey  <tom@tromey.com>
5261
5262         * tui/tui-winsource.h (struct tui_source_window_base)
5263         <update_exec_info>: Declare.
5264         (tui_update_exec_info): Don't declare.
5265         * tui/tui-winsource.c (tui_update_source_window_as_is)
5266         (tui_source_window_base::refresh_all)
5267         (tui_update_all_breakpoint_info): Update.
5268         (tui_source_window_base::update_exec_info): Rename from
5269         tui_update_exec_info.
5270         * tui/tui-stack.c (tui_show_frame_info): Update.
5271
5272 2019-08-13  Tom Tromey  <tom@tromey.com>
5273
5274         * tui/tui-winsource.h (struct tui_source_window_base)
5275         <set_exec_info_content>: Declare.
5276         (tui_set_exec_info_content): Don't declare.
5277         * tui/tui-winsource.c
5278         (tui_source_window_base::set_exec_info_content): Rename from
5279         tui_set_exec_info_content.
5280         (tui_update_exec_info): Update.
5281
5282 2019-08-13  Tom Tromey  <tom@tromey.com>
5283
5284         * tui/tui-winsource.h (struct tui_source_window_base)
5285         <show_source_content>: Declare.
5286         (tui_show_source_content): Don't declare.
5287         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5288         (tui_source_window_base::show_source_content): Rename from
5289         tui_show_source_content.
5290         (tui_source_window_base::refresh_all): Update.
5291         * tui/tui-layout.c (show_source_disasm_command)
5292         (show_source_or_disasm_and_command): Update.
5293
5294 2019-08-13  Tom Tromey  <tom@tromey.com>
5295
5296         * tui/tui-winsource.c (tui_erase_source_content)
5297         (tui_show_source_content, tui_source_window_base::refresh_all):
5298         Update.
5299         * tui/tui-wingeneral.h
5300         (tui_check_and_display_highlight_if_needed): Don't declare.
5301         * tui/tui-wingeneral.c
5302         (tui_win_info::check_and_display_highlight_if_needed): Rename from
5303         check_and_display_highlight_if_needed.
5304         * tui/tui-win.c (tui_rehighlight_all)
5305         (tui_win_info::make_visible_with_new_height): Update.
5306         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5307         (tui_data_window::erase_data_content)
5308         (tui_data_window::display_all_data): Update.
5309         * tui/tui-data.h (struct tui_win_info)
5310         <check_and_display_highlight_if_needed>: Declare.
5311
5312 2019-08-13  Tom Tromey  <tom@tromey.com>
5313
5314         * tui/tui-win.c (tui_resize_all): Call
5315         tui_delete_invisible_windows.
5316         * tui/tui-layout.c (show_layout): Call
5317         tui_delete_invisible_windows.
5318         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5319         * tui/tui-data.c (tui_delete_invisible_windows): New function.
5320
5321 2019-08-13  Tom Tromey  <tom@tromey.com>
5322
5323         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
5324         tui_add_win_to_layout.
5325
5326 2019-08-13  Tom Tromey  <tom@tromey.com>
5327
5328         * tui/tui-layout.h (tui_default_win_height): Don't declare.
5329         * tui/tui-layout.c (tui_default_win_height): Now static.
5330
5331 2019-08-13  Tom Tromey  <tom@tromey.com>
5332
5333         * tui/tui-layout.c (show_layout): Unify all layout cases into a
5334         single switch.
5335         (show_source_disasm_command, show_source_or_disasm_and_command):
5336         Don't check current layout.
5337
5338 2019-08-13  Tom Tromey  <tom@tromey.com>
5339
5340         * tui/tui-wingeneral.c (make_all_visible): Remove.
5341         (tui_make_all_invisible): Simplify.
5342         * tui/tui-layout.c (tui_make_all_invisible): Move from
5343         tui-wingeneral.c; simplify.
5344         (show_layout): Hoist call to tui_make_all_invisible.
5345         (show_data): Don't call tui_make_all_invisible.
5346
5347 2019-08-13  Tom Tromey  <tom@tromey.com>
5348
5349         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5350         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5351
5352 2019-08-13  Tom Tromey  <tom@tromey.com>
5353
5354         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5355         tui-data.c.
5356         (show_source_disasm_command, show_data)
5357         (show_source_or_disasm_and_command): Don't use
5358         tui_set_current_layout_to.
5359         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5360         * tui/tui-data.c (current_layout, tui_current_layout): Move to
5361         tui-layout.c.
5362         (tui_set_current_layout_to): Remove.
5363
5364 2019-08-13  Tom Tromey  <tom@tromey.com>
5365
5366         * tui/tui-layout.c (tui_set_layout): Update.
5367         * tui/tui-data.h (struct tui_layout_def): Remove.
5368         (tui_layout_def): Don't declare.
5369         * tui/tui-data.c (layout_def): Remove.
5370         (tui_layout_def): Remove.
5371
5372 2019-08-13  Tom Tromey  <tom@tromey.com>
5373
5374         * tui/tui-winsource.h (struct tui_source_window_base)
5375         <clear_detail>: No longer "override".
5376         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5377         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5378         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5379         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5380         Remove.
5381         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5382
5383 2019-08-13  Tom Tromey  <tromey@adacore.com>
5384
5385         * tracepoint.c: Don't include readline.h or history.h.
5386
5387 2019-08-12  Tom Tromey  <tom@tromey.com>
5388
5389         * configure: Rebuild.
5390         * configure.ac: Check for readline 7.
5391         * NEWS: Mention readline 7 requirement.
5392         * README: Update.
5393
5394 2019-08-12  Tom Tromey  <tom@tromey.com>
5395
5396         * mingw-hdep.c (gdb_select): Remove readline hack.
5397
5398 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5399
5400         * blockframe.c (find_pc_partial_function): Set *block to nullptr
5401         when the function fails.
5402
5403 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
5404
5405         * s390-tdep.c (s390_type_align): New function.
5406         (s390_gdbarch_init): Set it as type_align gdbarch method.
5407
5408 2019-08-09  Tom de Vries  <tdevries@suse.de>
5409
5410         PR gdb/24591
5411         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5412         pc_low with relocation offset.
5413
5414 2019-08-07  Tom Tromey  <tromey@adacore.com>
5415
5416         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5417         (print_frame_args): Update.
5418         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5419         Update.
5420         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5421         * frame.h (struct frame_arg): Add initializers.
5422         <error>: Now a unique_xmalloc_ptr.
5423
5424 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
5425
5426         * NEWS: Expand the Pointer Authentication entry.
5427         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5428         (aarch64_frame_unmask_lr): ... to this.
5429         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5430         Call aarch64_frame_unmask_lr.
5431         * frame.c (struct frame_info): Add "masked" variable.
5432         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5433         (fprint_frame): Check for masked pc.
5434         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5435         declarations.
5436         * python/py-framefilter.c (py_print_frame): Check for masked pc.
5437         * stack.c (print_frame): Check for masked pc.
5438
5439 2019-08-06  Tom Tromey  <tom@tromey.com>
5440
5441         * stabsread.c (patch_block_stabs, read_one_struct_field)
5442         (read_enum_type): Use obstack_strndup.
5443         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5444         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5445         * dwarf2read.c (guess_full_die_structure_name)
5446         (anonymous_struct_prefix): Use obstack_strndup.
5447         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5448         * c-exp.y (yylex): Use obstack_strndup.
5449         * ada-exp.y (write_object_renaming, write_ambiguous_var)
5450         (write_var_or_type): Use obstack_strndup.
5451
5452 2019-08-06  Tom Tromey  <tom@tromey.com>
5453
5454         * symfile.c (reread_symbols): Use obstack_strdup.
5455         * stabsread.c (read_type): Use obstack_strdup.
5456         * gdb_obstack.h (obstack_strdup): New overload.
5457         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5458         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5459         (dwarf2_canonicalize_name): Use obstack_strdup.
5460         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5461         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5462         Use obstack_strdup.
5463
5464 2019-08-06  Tom Tromey  <tom@tromey.com>
5465
5466         * gdb_obstack.h (obstack_strdup): Define.
5467         * gdb_obstack.c (obstack_strdup): Don't define.
5468
5469 2019-08-06  Tom Tromey  <tom@tromey.com>
5470
5471         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5472         obstack_strdup.
5473         * typeprint.c (typedef_hash_table::find_global_typedef): Use
5474         obstack_strdup.
5475         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5476         * stabsread.c (common_block_start): Use obstack_strdup.
5477         * objfiles.c (set_objfile_main_name, objfile): Use
5478         obstack_strdup.
5479         * namespace.c (add_using_directive): Use obstack_strdup.
5480         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5481         * jit.c (finalize_symtab): Use obstack_strdup.
5482         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5483         (guess_partial_die_structure_name, partial_die_info::fixup)
5484         (dwarf2_name): Use obstack_strdup.
5485         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5486         obstack_strdup.
5487         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5488         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5489         obstack_strdup.
5490         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5491
5492 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5493
5494         * unittests/help-doc-selftests.c: New file.
5495         * Makefile.in: Add the new file.
5496
5497 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5498
5499         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5500         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
5501         the full first line, except when FOR_VALUE_PREFIX.  In this case,
5502         the trailing '.' is not output, and the first character is uppercased.
5503         (print_help_for_command): Update call to print_doc_line.
5504         (print_doc_of_command): Likewise.
5505         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5506         * cli/cli-option.c (append_indented_doc): Do not append newline.
5507         (build_help_option): Append newline after first appended_indented_doc
5508         only if a second call is done.
5509         (build_help): Append 2 new lines before each option, except the first
5510         one.
5511         * compile/compile.c (_initialize_compile): Add new lines after
5512         %OPTIONS%, when not at the end of the help.
5513         Change help doc or code
5514         producing the help doc to respect the invariants.
5515         * maint-test-options.c (_initialize_maint_test_options): Likewise.
5516         Also removed the new line after 'Options:', as all other commands
5517         do not put an empty line between 'Options:' and the first option.
5518         * printcmd.c (_initialize_printcmd): Likewise.
5519         * stack.c (_initialize_stack): Likewise.
5520         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5521         incorrectly telling COMMAND is optional.
5522         * ada-lang.c (_initialize_ada_language): Change help doc or code
5523         producing the help doc to respect the invariants.
5524         * ada-tasks.c (_initialize_ada_tasks): Likewise.
5525         * breakpoint.c (_initialize_breakpoint): Likewise.
5526         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5527         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5528         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5529         * cli/cli-style.c (cli_style_option::add_setshow_commands,
5530         _initialize_cli_style): Likewise.
5531         * corelow.c (core_target_info): Likewise.
5532         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5533         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5534         * filesystem.c (_initialize_filesystem): Likewise.
5535         * frame.c (_initialize_frame): Likewise.
5536         * gnu-nat.c (add_task_commands): Likewise.
5537         * infcall.c (_initialize_infcall): Likewise.
5538         * infcmd.c (_initialize_infcmd): Likewise.
5539         * interps.c (_initialize_interpreter): Likewise.
5540         * language.c (_initialize_language): Likewise.
5541         * linux-fork.c (_initialize_linux_fork): Likewise.
5542         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5543         * maint.c (_initialize_maint_cmds): Likewise.
5544         * memattr.c (_initialize_mem): Likewise.
5545         * printcmd.c (_initialize_printcmd): Likewise.
5546         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5547         _RegEx): Likewise.
5548         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5549         * record-btrace.c (_initialize_record_btrace): Likewise.
5550         * record-full.c (_initialize_record_full): Likewise.
5551         * record.c (_initialize_record): Likewise.
5552         * regcache-dump.c (_initialize_regcache_dump): Likewise.
5553         * regcache.c (_initialize_regcache): Likewise.
5554         * remote.c (add_packet_config_cmd, init_remote_threadtests,
5555         _initialize_remote): Likewise.
5556         * ser-tcp.c (_initialize_ser_tcp): Likewise.
5557         * serial.c (_initialize_serial): Likewise.
5558         * skip.c (_initialize_step_skip): Likewise.
5559         * source.c (_initialize_source): Likewise.
5560         * stack.c (_initialize_stack): Likewise.
5561         * symfile.c (_initialize_symfile): Likewise.
5562         * symtab.c (_initialize_symtab): Likewise.
5563         * target-descriptions.c (_initialize_target_descriptions): Likewise.
5564         * top.c (init_main): Likewise.
5565         * tracefile-tfile.c (tfile_target_info): Likewise.
5566         * tracepoint.c (_initialize_tracepoint): Likewise.
5567         * tui/tui-win.c (_initialize_tui_win): Likewise.
5568         * utils.c (add_internal_problem_command): Likewise.
5569         * valprint.c (value_print_option_defs): Likewise.
5570
5571 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
5572
5573         PR build/24886
5574         * configure.ac: Drop enable-libmcheck support.
5575         * configure, config.in: Rebuild.
5576         * libmcheck.m4: Remove.
5577         * acinclude.m4: Don't include it.
5578         * Makefile.in: Don't distribute it.
5579         * top.c (print_gdb_configuration): Don't mention it.
5580
5581 2019-08-06  Tom Tromey  <tom@tromey.com>
5582
5583         * utils.c (set_output_style): Sometimes pass stream to
5584         emit_style_escape.
5585         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5586         * record-btrace.c (btrace_insn_history): Update.
5587         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5588         method.
5589         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5590         Update initializers.
5591         <m_uiout>: New field.
5592         <m_di>: Move lower.
5593         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5594         Remove "uiout" parameter.
5595         (dump_insns): Update.
5596         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5597         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5598
5599 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
5600
5601         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5602         (error_in_psymtab_expansion): Likewise.
5603         (lookup_symbol_via_quick_fns): Likewise.
5604         (basic_lookup_transparent_type_quick): Likewise.
5605         (basic_lookup_transparent_type_1): Likewise.
5606
5607 2019-08-06  Tom Tromey  <tromey@adacore.com>
5608
5609         * source.c (last_source_error): Now bool.
5610         (print_source_lines_base): Make "noprint" bool.  Only open
5611         source file when last_source_visited changes.
5612
5613 2019-08-06  Tom Tromey  <tromey@adacore.com>
5614
5615         * annotate.c (annotate_source_line): Use g_source_cache.
5616         * source-cache.c (source_cache::get_plain_source_lines): Change
5617         parameters.  Populate m_offset_cache.
5618         (source_cache::ensure): New method.
5619         (source_cache::get_line_charpos): New method.
5620         (extract_lines): Move lower.  Change parameters.
5621         (source_cache::get_source_lines): Move lower.
5622         * source-cache.h (class source_cache): Update comment.
5623         <get_line_charpos>: New method.
5624         <get_source_lines>: Update comment.
5625         <clear>: Clear m_offset_cache.
5626         <get_plain_source_lines>: Change parameters.
5627         <ensure>: New method
5628         <m_offset_cache>: New member.
5629         * source.c (forget_cached_source_info_for_objfile): Update.
5630         (info_source_command): Use g_source_cache.
5631         (find_source_lines, open_source_file_with_line_charpos): Remove.
5632         (print_source_lines_base, search_command_helper): Use g_source_cache.
5633         * source.h (open_source_file_with_line_charpos): Don't declare.
5634         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5635         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5636         Use g_source_cache.
5637
5638 2019-08-06  Tom Tromey  <tromey@adacore.com>
5639
5640         * source-cache.c (source_cache::get_plain_source_lines):
5641         Remove "first_line" and "last_line" parameters.
5642         (source_cache::get_source_lines): Cache plain text.
5643         * source-cache.h (class source_cache)
5644         <get_plain_source_lines>: Update.
5645
5646 2019-08-06  Tom Tromey  <tromey@adacore.com>
5647
5648         * source-cache.c (extract_lines): No longer a method.
5649         Changed type of parameter.  Include final newline.
5650         (selftests::extract_lines_test): New function.
5651         (_initialize_source_cache): Likewise.
5652         * source-cache.h (class source_cache)
5653         <extract_lines>: Don't declare.
5654
5655 2019-08-06  Tom Tromey  <tromey@adacore.com>
5656
5657         * breakpoint.c (init_breakpoint_sal): Update.
5658         (breakpoint): Update.
5659         * breakpoint.h (struct breakpoint) <filter>: Now a
5660         unique_xmalloc_ptr.
5661
5662 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5663
5664         * NEWS: Mention dictionary access on blocks.
5665         * python/py-block.c (blpy_getitem): New function.
5666         (block_object_as_mapping): New struct.
5667         (block_object_type): Use new struct for tp_as_mapping field.
5668
5669 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5670
5671         * objfiles.h (objfile): Add a comment describing partial symbols.
5672
5673 2019-08-05  Tom Tromey  <tromey@adacore.com>
5674
5675         * compile/compile.c (_initialize_compile): Use _(), not N_().
5676         * thread.c (_initialize_thread): Use _(), not N_().
5677         * stack.c (_initialize_stack): Use _(), not N_().
5678         * printcmd.c (_initialize_printcmd): Use _(), not N_().
5679
5680 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
5681
5682         * dwarf2read.c (struct dw2_symtab_iterator):
5683         <want_specific_block>: Remove.
5684         <block_index>: Change type to gdb::optional.
5685         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5686         change type of BLOCK_INDEX parameter to gdb::optional.
5687         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5688         (dw2_lookup_symbol): Don't pass argument for
5689         WANT_SPECIFIC_BLOCK.
5690         (dw2_expand_symtabs_for_function): Don't pass argument for
5691         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5692         (class dw2_debug_names_iterator)
5693         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5694         parameter, change BLOCK_INDEX type to gdb::optional.
5695         <m_want_specific_block>: Remove.
5696         <m_block_index>: Change type to gdb::optional.
5697         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5698         gdb::optional.  Re-write in function of gdb::optional.
5699         (dw2_debug_names_lookup_symbol): Don't pass argument for
5700         WANT_SPECIFIC_BLOCK.
5701         (dw2_debug_names_expand_symtabs_for_function): Don't pass
5702         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5703         BLOCK_INDEX.
5704
5705 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5706
5707         * NEWS: Mention changes to "info sources" command.
5708
5709 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5710
5711         * symtab.c (filename_partial_match_opts): New struct type.
5712         (struct output_source_filename_data): New members
5713         regexp, c_regexp, partial_match.
5714         (output_source_filename): Use new members to decide to print file.
5715         (info_sources_option_defs): New variable.
5716         (make_info_sources_options_def_group, print_info_sources_header,
5717         info_sources_command_completer):
5718         New functions.
5719         (info_sources_command): Read new optional arguments.
5720         (_initialize_symtab): Update info sources help.
5721
5722 2019-08-02  Alexandre Oliva <oliva@adacore.com>
5723
5724         * ada-lang.c (exception_support_info_v0): Renamed from...
5725         (default_exception_support_info): ... this.  Create new
5726         definition for v1.
5727         (ada_has_this_exception_support): Look up catch_handlers_sym.
5728         (ada_exception_support_info_sniffer): Try v0 after default.
5729
5730 2019-08-01  Tom Tromey  <tromey@adacore.com>
5731
5732         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5733         gdbarch.h.
5734
5735 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
5736
5737         * s12z-tdep.c: Fix include path for s12z-opc.h.
5738
5739 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
5740
5741         * NEWS: Require GNU make 3.82.
5742
5743 2019-07-16  Tom Tromey  <tom@tromey.com>
5744
5745         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5746         declare.
5747
5748 2019-07-30  Tom Tromey  <tromey@adacore.com>
5749
5750         * block.c (contained_in): Remove BLOCK_FUNCTION check.
5751
5752 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
5753
5754         * printcmd.c (print_address_symbolic): Print negative offsets.
5755         (build_address_symbolic): Force signed arithmetic when computing
5756         offset.
5757
5758 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
5759
5760         PR/24474: Add a function to lookup static variables.
5761         * NEWS: Mention this new function.
5762         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5763         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5764         * python/python.c (python_GdbMethods): Add new function.
5765
5766 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
5767
5768         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5769         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5770         (objfpy_lookup_static_symbol): New function.
5771         (objfile_object_methods): Add new functions.
5772
5773 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5774
5775         * NEWS: Mention 'set|show print frame-info'.  Mention new
5776         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
5777         backtrace argument.  Mention that python frame filtering code
5778         is now consistent with what 'backtrace' command prints.
5779
5780 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5781
5782         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5783         comments.
5784         (print_frame_info_auto, print_frame_info_source_line,
5785         print_frame_info_location, print_frame_info_source_and_location,
5786         print_frame_info_location_and_address, print_frame_info_short_location):
5787         New declarations.
5788         (struct frame_print_options): New member print_frame_info.
5789         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5790         * stack.h (get_user_print_what_frame_info): New declaration.
5791         (frame_show_address): New declaration.
5792         * stack.c (print_frame_arguments_choices): New value 'presence'.
5793         (print_frame_info_auto, print_frame_info_source_line,
5794         print_frame_info_location, print_frame_info_source_and_location,
5795         print_frame_info_location_and_address, print_frame_info_short_location,
5796         print_frame_info_choices, print_frame_info_print_what): New definitions.
5797         (print_frame_args): Only print dots for args if print frame-arguments
5798         is 'presence'.
5799         (frame_print_option_defs): New element for "frame-info".
5800         (get_user_print_what_frame_info): New function.
5801         (frame_show_address): Make non static.  Move comment to stack.h.
5802         (print_frame_info_to_print_what): New function.
5803         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
5804         to decide what to print.
5805         (backtrace_command_1): Handle the new print_frame_arguments_presence
5806         value.
5807         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5808         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5809         (py_print_frame): In non-mi mode, use LOCATION as default for
5810         print_what, similarly to frame information printed directly by
5811         backtrace command. Handle frame-info user option in non MI mode.
5812
5813 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5814
5815         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5816         Add case for debugging 32-bit target on 64-bit host.  Revise
5817         comment.
5818
5819 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5820
5821         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5822         instead of find_function_entry_range_from_pc.
5823
5824 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5825
5826         * stack.c (find_frame_funname): Remove code which preferred
5827         minsym over symtab sym in "certain pathological cases".
5828
5829         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5830         parameter.  Change type of "do_demangle" to bool.
5831         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5832         Pass suitable "prefer_sym_over_minsym" flag to
5833         build_address_symbolic().  Don't output "+" for negative offsets.
5834         * printcmd.c (print_address_symbolic): Update invocation of
5835         build_address_symbolic to include a "prefer_sym_over_minsym"
5836         flag.
5837         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5838         Restrict cases in which use of minimal symbol is preferred to that
5839         of a found symbol.  Update comments.
5840
5841         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5842         for entry pc when entry pc is out of range for that FDE.
5843
5844 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
5845
5846         PR gdb/24839:
5847         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5848         type.
5849
5850 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
5851
5852         * python/py-objfile.c (add_separate_debug_file): Fix comment about
5853         this function's Python signature.
5854
5855
5856 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
5857
5858         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5859         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5860         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5861         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5862         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5863
5864
5865 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
5866
5867         * h8300-tdep.c (h8300_register_name_common): New.
5868         h8300_register_name): Use h8300_register_name_common.
5869         (h8300s_register_name): Likewise.
5870         (h8300sx_register_name): Likewise.
5871         (h8300h_register_nam): New.
5872         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5873
5874
5875 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
5876
5877         * arm-tdep.c (arm_skip_cmse_entry): New function.
5878         (arm_is_sgstubs_section): New function.
5879         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5880
5881 2019-07-22  Tom Tromey  <tom@tromey.com>
5882
5883         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5884         Don't self-assign.
5885
5886 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5887
5888         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5889         type_print.
5890
5891 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5892
5893         * symtab.c (search_symbols): Adjust msymbol matching type arrays
5894         so that GDB doesn't match any msymbols when searching in the
5895         TYPES_DOMAIN.
5896         (print_symbol_info): Print using typedef_print or type_print based
5897         on the type of the symbol.  Add updated FIXME comment moved from...
5898         (_initialize_symtab): ... move and update FIXME comment to above.
5899
5900 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5901
5902         * NEWS: Mention adding -q option to "info types".
5903         * symtab.c (struct info_types_options): New struct.
5904         (info_types_options_defs): New variable.
5905         (make_info_types_options_def_group): New function.
5906         (info_types_command): Use gdb::option framework to parse options.
5907         (info_types_command_completer): New function.
5908         (_initialize_symtab): Extend the help text on "info types" and
5909         register command completer.
5910
5911 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
5912
5913         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5914         (lookup_symbol_in_objfile): Change int to block_enum and add a
5915         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5916
5917 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
5918
5919         * MAINTAINERS (Write After Approval): Add self.
5920
5921 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5922
5923         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
5924         instruction to the dummy code region.
5925
5926 2019-07-19  Tom Tromey  <tromey@adacore.com>
5927
5928         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
5929         (ARGSUSED, PARAMS, __func__): Remove rules.
5930
5931 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5932
5933         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
5934         * features/arm/arm-with-iwmmxt.c: Remove.
5935         * features/arm/arm-with-iwmmxt.xml: Remove.
5936         * features/arm/arm-with-m-fpa-layout.c: Remove.
5937         * features/arm/arm-with-m-fpa-layout.xml: Remove.
5938         * features/arm/arm-with-m-vfp-d16.c: Remove.
5939         * features/arm/arm-with-m-vfp-d16.xml: Remove.
5940         * features/arm/arm-with-m.c: Remove.
5941         * features/arm/arm-with-m.xml: Remove.
5942         * features/arm/arm-with-neon.c: Remove.
5943         * features/arm/arm-with-neon.xml: Remove.
5944         * features/arm/arm-with-vfpv2.c: Remove.
5945         * features/arm/arm-with-vfpv2.xml: Remove.
5946         * features/arm/arm-with-vfpv3.c: Remove.
5947         * features/arm/arm-with-vfpv3.xml: Remove.
5948
5949 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5950
5951         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
5952
5953 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5954
5955         * arch/aarch32.c (aarch32_create_target_description): Create
5956         target descriptions using features.
5957         * arch/arm.c (arm_create_target_description)
5958         (arm_create_mprofile_target_description): Likewise.
5959         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
5960
5961 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5962
5963         * Makefile.in: Add new files.
5964         * aarch32-tdep.c: New file.
5965         * aarch32-tdep.h: New file.
5966         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5967         Call aarch32_read_description.
5968         * arch/aarch32.c: New file.
5969         * arch/aarch32.h: New file.
5970         * arch/arm.c (arm_create_target_description)
5971         (arm_create_mprofile_target_description): New function.
5972         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
5973         (arm_create_target_description)
5974         (arm_create_mprofile_target_description): New declaration.
5975         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
5976         read_description functions.
5977         * arm-linux-nat.c (arm_linux_nat_target::read_description):
5978         Likewise.
5979         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5980         * arm-tdep.c (tdesc_arm_list): New variable.
5981         (arm_register_g_packet_guesses): Call create description functions.
5982         (arm_read_description) (arm_read_mprofile_description): New
5983         function.
5984         * arm-tdep.h (arm_read_description)
5985         (arm_read_mprofile_description): Add declaration.
5986         * configure.tgt: Add new files.
5987
5988 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
5989
5990         * top.c (new_ui_command): Open specified terminal just once.
5991
5992 2019-07-18  Tom Tromey  <tromey@adacore.com>
5993
5994         * symtab.c (main_name): Constify return type.
5995         * symfile.c (set_initial_language): Update.
5996         * symtab.h (main_name): Constify return type.
5997
5998 2019-07-17  Tom Tromey  <tom@tromey.com>
5999
6000         * tui/tui-winsource.c (tui_update_source_window)
6001         (tui_update_source_window_as_is)
6002         (tui_update_source_windows_with_line): Remove return.
6003         * tui/tui-disasm.c (tui_show_disassem)
6004         (tui_show_disassem_and_update_source): Remove return.
6005         * tui/tui.c (tui_reset): Remove return.
6006         * tui/tui-wingeneral.c
6007         (tui_check_and_display_highlight_if_needed): Remove return.
6008
6009 2019-07-17  Tom Tromey  <tom@tromey.com>
6010
6011         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6012
6013 2019-07-17  Tom Tromey  <tom@tromey.com>
6014
6015         * tui/tui-winsource.h (struct tui_exec_info_window)
6016         (struct tui_source_window_base): Move from tui-data.h.
6017         * tui/tui-winsource.c: Move many method definitions from
6018         elsewhere.  Remove "structuring" comments.
6019         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6020         (tui_source_window_base::refresh_window): Move to
6021         tui-winsource.c.
6022         * tui/tui-win.c (tui_source_window_base::refresh_all)
6023         (tui_source_window_base::update_tab_width)
6024         (tui_source_window_base::set_new_height)
6025         (tui_source_window_base::do_make_visible_with_new_height): Move to
6026         tui-winsource.c.
6027         * tui/tui-source.h: Update.
6028         * tui/tui-source.c (tui_source_window_base::reset): Move to
6029         tui-winsource.c.
6030         * tui/tui-disasm.h: Update.
6031         * tui/tui-data.h (struct tui_exec_info_window): Move to
6032         tui-winsource.h.
6033         (struct tui_source_window_base): Likewise.
6034         * tui/tui-data.c (tui_source_window_base::clear_detail)
6035         (tui_source_window_base, ~tui_source_window_base): Move to
6036         tui-winsource.c.
6037
6038 2019-07-17  Tom Tromey  <tom@tromey.com>
6039
6040         * tui/tui-win.c (tui_resize_all)
6041         (tui_source_window_base::update_tab_width)
6042         (tui_adjust_win_heights): Update.
6043         (tui_win_info::make_invisible_and_set_new_height): Rename from
6044         make_invisible_and_set_new_height.
6045         * tui/tui-data.h (struct tui_win_info)
6046         <make_invisible_and_set_new_height>: New method.
6047
6048 2019-07-17  Tom Tromey  <tom@tromey.com>
6049
6050         * tui/tui.c: Update.
6051         * tui/tui-source.h (struct tui_source_window): Move from
6052         tui-data.h.
6053         * tui/tui-layout.c: Update.
6054         * tui/tui-disasm.c: Update.
6055         * tui/tui-data.h (struct tui_source_window): Move to
6056         tui-source.h.
6057
6058 2019-07-17  Tom Tromey  <tom@tromey.com>
6059
6060         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6061         tui-data.h.
6062         * tui/tui-data.h (struct tui_disasm_window): Move to
6063         tui-disasm.h.
6064
6065 2019-07-17  Tom Tromey  <tom@tromey.com>
6066
6067         * tui/tui-regs.h (struct tui_data_item_window): Move from
6068         tui-data.h.
6069         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6070         * tui/tui-data.h (struct tui_data_item_window): Move to
6071         tui-regs.h.
6072         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6073
6074 2019-07-17  Tom Tromey  <tom@tromey.com>
6075
6076         * tui/tui.c: Update.
6077         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6078         (tui_cmd_window::max_height): Move to tui-command.c.
6079         * tui/tui-layout.c: Update.
6080         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6081         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6082         tui-command.c.
6083         * tui/tui-command.h (struct tui_cmd_window): Move from
6084         tui-data.h.
6085         * tui/tui-command.c: Remove "structuring" comments.
6086         (tui_cmd_window::clear_detail)
6087         (tui_cmd_window::do_make_visible_with_new_height)
6088         (tui_cmd_window::max_height): Move from elsewhere.
6089
6090 2019-07-17  Tom Tromey  <tom@tromey.com>
6091
6092         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6093         Now static.
6094         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6095         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6096
6097 2019-07-17  Tom Tromey  <tom@tromey.com>
6098
6099         * tui/tui.c: Update.
6100         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6101         tui-regs.c.
6102         * tui/tui-windata.h: Remove file.
6103         * tui/tui-windata.c: Remove file.
6104         * tui/tui-win.c (tui_data_window::set_new_height)
6105         (tui_data_window::do_make_visible_with_new_height): Move to
6106         tui-regs.c.
6107         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6108         * tui/tui-regs.c: Remove "structuring" comments.
6109         (tui_data_window::first_data_item_displayed)
6110         (tui_data_window::delete_data_content_windows)
6111         (tui_data_window::erase_data_content)
6112         (tui_data_window::display_all_data)
6113         (tui_data_window::refresh_all)
6114         (tui_data_window::do_scroll_vertical)
6115         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6116         (tui_data_window::do_make_visible_with_new_height)
6117         (tui_data_window::refresh_window): Move from elsewhere.
6118         (_initialize_tui_regs): Move to end of file.
6119         * tui/tui-layout.c: Update.
6120         * tui/tui-hooks.c: Update.
6121         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6122         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6123         tui-regs.c.
6124         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6125
6126 2019-07-17  Tom Tromey  <tom@tromey.com>
6127
6128         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6129         seen.
6130
6131 2019-07-17  Tom Tromey  <tom@tromey.com>
6132
6133         * tui/tui-win.c (tui_source_window_base::set_new_height)
6134         (tui_source_window_base::do_make_visible_with_new_height): Use
6135         m_has_locator field directly.
6136         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6137         method.
6138         (struct tui_source_window_base) <has_locator>: Likewise.
6139
6140 2019-07-17  Tom Tromey  <tom@tromey.com>
6141
6142         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6143         Don't declare.
6144         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6145         Remove.
6146         * tui/tui-win.c (tui_source_window_base::set_new_height)
6147         (tui_source_window_base::set_new_height)
6148         (make_invisible_and_set_new_height)
6149         (tui_source_window_base::do_make_visible_with_new_height)
6150         (tui_source_window_base::do_make_visible_with_new_height):
6151         Update.
6152         * tui/tui-layout.c (show_source_disasm_command, show_data)
6153         (show_source_or_disasm_and_command): Update.
6154         * tui/tui-layout.c (show_layout): Update.
6155
6156 2019-07-17  Tom Tromey  <tom@tromey.com>
6157
6158         * tui/tui-layout.c (make_data_window): Remove.
6159         (show_data): Unify creation and re-initialization cases.
6160
6161 2019-07-17  Tom Tromey  <tom@tromey.com>
6162
6163         * tui/tui-layout.c (make_source_window, make_disasm_window):
6164         Remove.
6165         (show_data): Unify creation and re-initialization cases.
6166
6167 2019-07-17  Tom Tromey  <tom@tromey.com>
6168
6169         * tui/tui-layout.c (make_command_window): Remove.
6170         (show_source_disasm_command, show_source_or_disasm_and_command):
6171         Unify creation and re-initialization cases.
6172
6173 2019-07-17  Tom Tromey  <tom@tromey.com>
6174
6175         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6176         creation and re-initialization cases.
6177
6178 2019-07-17  Tom Tromey  <tom@tromey.com>
6179
6180         * tui/tui-regs.c (tui_get_register): Return void.
6181
6182 2019-07-17  Tom Tromey  <tom@tromey.com>
6183
6184         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6185         Simplify.
6186
6187 2019-07-17  Tom Tromey  <tom@tromey.com>
6188
6189         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6190         resetting.
6191
6192 2019-07-17  Tom Tromey  <tom@tromey.com>
6193
6194         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6195         * tui/tui-regs.c (tui_reg_layout): New function.
6196         (tui_show_registers, tui_reg_command): Use it.
6197         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6198         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6199         parameters.
6200         (tui_layout_command): Remove.
6201
6202 2019-07-17  Tom Tromey  <tom@tromey.com>
6203
6204         * tui/tui-layout.h (tui/tui-layout): Return void.
6205         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6206
6207 2019-07-17  Tom Tromey  <tom@tromey.com>
6208
6209         * tui/tui-layout.c (show_source_disasm_command, show_data):
6210         Update.
6211         (reset_locator): Remove.
6212         (show_source_or_disasm_and_command): Update.
6213
6214 2019-07-17  Tom Tromey  <tom@tromey.com>
6215
6216         * tui/tui-source.c (tui_source_window_base::reset): Remove
6217         win_type parameter.
6218         * tui/tui-layout.c (make_command_window, make_source_window)
6219         (make_disasm_window, make_data_window)
6220         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6221         (reset_locator, show_source_or_disasm_and_command): Update.
6222         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6223         win_type parameter.
6224         (struct tui_source_window_base) <reset>: Likewise.
6225
6226 2019-07-17  Tom Tromey  <tom@tromey.com>
6227
6228         * tui/tui-layout.c (show_source_disasm_command): Use
6229         reset_locator.
6230         (reset_locator): New function.
6231         (init_and_make_win): Remove.
6232         (show_source_or_disasm_and_command): Use reset_locator.
6233
6234 2019-07-17  Tom Tromey  <tom@tromey.com>
6235
6236         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6237         condition.
6238         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6239         Remove condition.
6240         * tui/tui-source.c (tui_source_window_base::reset): New method.
6241         * tui/tui-layout.c (make_command_window): Don't call
6242         init_and_make_win.
6243         (make_source_window, make_disasm_window): Don't call
6244         make_source_or_disasm_window.
6245         (make_data_window): Don't call init_and_make_win.  Change calling
6246         convention.
6247         (show_source_disasm_command, show_data): Simplify.
6248         (make_source_or_disasm_window): Remove.
6249         (show_source_or_disasm_and_command): Simplify.
6250         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6251         (struct tui_source_window_base) <reset>: Likewise.
6252         <execution_info>: Remove initializer.
6253         * tui/tui-data.c (tui_source_window_base): Initialize
6254         execution_info.
6255
6256 2019-07-17  Tom Tromey  <tom@tromey.com>
6257
6258         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6259         variable.
6260
6261 2019-07-17  Tom Tromey  <tom@tromey.com>
6262
6263         * tui/tui.c (tui_rl_other_window): Update.
6264         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6265         superclass method first.  Always iterate over regs_content.
6266         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6267         method.
6268         * tui/tui-win.c (tui_set_focus_command): Update.
6269
6270 2019-07-17  Tom Tromey  <tom@tromey.com>
6271
6272         * tui/tui-win.c (tui_set_focus_command): Rename from
6273         tui_set_focus.  Call tui_enable.
6274         (tui_set_focus_command): Remove.
6275
6276 2019-07-17  Tom Tromey  <tom@tromey.com>
6277
6278         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6279         refresh_window.
6280         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6281         touchwin.
6282         (tui_data_window::refresh_window): Call refresh_window on data
6283         items.  Always call superclass refresh_window.
6284         (tui_win_info::refresh): Remove.
6285         (tui_source_window_base::refresh_window): Update.
6286         (tui_refresh_all): Update.
6287         * tui/tui-layout.c (show_source_disasm_command): Remove call to
6288         refresh_window.
6289         (show_source_or_disasm_and_command): Likewise.
6290         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6291         (struct tui_source_window_base) <refresh>: Likewise.
6292
6293 2019-07-17  Tom Tromey  <tom@tromey.com>
6294
6295         * tui/tui-winsource.c (tui_clear_source_content)
6296         (tui_show_source_content): Update.
6297         * tui/tui-source.c (tui_source_window::showing_source_p): Check
6298         whether content is empty.
6299         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6300         Remove.
6301
6302 2019-07-17  Tom Tromey  <tom@tromey.com>
6303
6304         * tui/tui-winsource.c (tui_erase_source_content): Clear the
6305         window's contents.
6306         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6307         * tui/tui-source.c (tui_set_source_content_nil): Remove.
6308
6309 2019-07-17  Tom Tromey  <tom@tromey.com>
6310
6311         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6312         (struct tui_data_item_window): Update.
6313
6314 2019-07-17  Tom Tromey  <tom@tromey.com>
6315
6316         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6317         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6318         defines.
6319
6320 2019-07-17  Tom Tromey  <tom@tromey.com>
6321
6322         * tui/tui-winsource.h (tui_erase_source_content)
6323         (tui_clear_source_content): Remove "display_prompt" parameter.
6324         * tui/tui-winsource.c (tui_update_source_window_as_is)
6325         (tui_update_source_windows_with_addr): Update.
6326         (tui_clear_source_content): Remove "display_prompt" parameter.
6327         (tui_erase_source_content): Likewise.  Simplify.
6328         (tui_show_source_content): Update.
6329         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6330         * tui/tui-stack.c (tui_show_frame_info): Update.
6331         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6332         Remove defines.
6333
6334 2019-07-17  Tom Tromey  <tom@tromey.com>
6335
6336         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6337         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6338         parameter.
6339         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6340         parameter.
6341
6342 2019-07-17  Tom Tromey  <tom@tromey.com>
6343
6344         * tui/tui-winsource.c (tui_clear_source_content)
6345         (tui_show_source_content, tui_show_exec_info_content)
6346         (tui_clear_exec_info_content): Update.
6347         * tui/tui-stack.c (tui_show_locator_content): Update.
6348         (tui_show_frame_info): Update.
6349         * tui/tui-source.h (tui_source_window): Don't declare.
6350         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6351         from tui_source_is_displayed.
6352         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6353         Remove field.
6354         (struct tui_source_window_base) <content_in_use>: New field.  Now
6355         bool.
6356         (struct tui_source_window) <showing_source_p>: New method.
6357         (TUI_SRC_WIN): Change cast.
6358         * tui/tui-data.c (tui_initialize_static_data): Update.
6359
6360 2019-07-17  Tom Tromey  <tom@tromey.com>
6361
6362         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6363         location_matches_p.
6364         * tui/tui-source.c (tui_source_window::location_matches_p): New
6365         method.
6366         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6367         method.
6368         * tui/tui-data.h (struct tui_source_window_base)
6369         <location_matches_p>: New method.
6370         (struct tui_source_window, struct tui_disasm_window)
6371         <location_matches_p>: Likewise.
6372
6373 2019-07-17  Tom Tromey  <tom@tromey.com>
6374
6375         * tui/tui-win.c (tui_set_win_height_command): Rename from
6376         tui_set_win_height.
6377         (tui_set_win_height_command): Remove.
6378
6379 2019-07-17  Tom Tromey  <tom@tromey.com>
6380
6381         * tui/tui-source.c (tui_source_window): New constructor.  Add
6382         observer.
6383         (~tui_source_window): New destructor.
6384         (tui_source_window::style_changed): New method.
6385         * tui/tui-hooks.c (tui_redisplay_source): Remove.
6386         (tui_attach_detach_observers): Update.
6387         * tui/tui-data.h (struct tui_source_window): Make constructor not
6388         inline.  Add destructor.
6389         (struct tui_source_window) <style_changed>: New method.
6390         <m_observable>: New member.
6391
6392 2019-07-17  Tom Tromey  <tom@tromey.com>
6393
6394         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6395         * tui/tui-win.c (tui_resize_all): Fix typo.
6396
6397 2019-07-17  Tom Tromey  <tom@tromey.com>
6398
6399         * tui/tui-wingeneral.h (tui_refresh_all): Update.
6400         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6401         (tui_refresh_all): Remove "list" parameter.  Use foreach.
6402         * tui/tui-win.c (window_name_completer): Use foreach.
6403         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6404         (update_tab_width): Likewise.
6405         * tui/tui-layout.c (show_layout): Update.
6406         * tui/tui-data.h (class tui_window_iterator): New.
6407         (struct all_tui_windows): New.
6408         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6409
6410 2019-07-17  Tom Tromey  <tom@tromey.com>
6411
6412         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6413         parameter.  Don't reference globals.
6414         (tui_reg_command): Update.
6415
6416 2019-07-17  Tom Tromey  <tom@tromey.com>
6417
6418         * tui/tui-regs.c (tui_show_registers): Simplify.
6419
6420 2019-07-17  Tom Tromey  <tom@tromey.com>
6421
6422         * tui/tui-regs.c (tui_show_registers): Update.
6423         (tui_show_register_group): Add win_info parameter.
6424
6425 2019-07-17  Tom Tromey  <tom@tromey.com>
6426
6427         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6428         Rename from tui_display_reg_element_at_line.
6429         (tui_data_window::display_registers_from_line): Update.
6430         * tui/tui-data.h (struct tui_data_window)
6431         <display_reg_element_at_line>: New method.
6432
6433 2019-07-17  Tom Tromey  <tom@tromey.com>
6434
6435         * tui/tui-regs.h (tui_display_registers_from)
6436         (tui_display_registers_from_line): Don't declare.
6437         * tui/tui-windata.c (tui_data_window::display_all_data)
6438         (tui_data_window::refresh_all)
6439         (tui_data_window::do_scroll_vertical): Update.
6440         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6441         from tui_display_registers_from.
6442         (tui_display_reg_element_at_line): Update.
6443         (tui_data_window::display_registers_from_line): Rename from
6444         tui_display_registers_from_line.
6445         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6446         display_registers_from_line>: New methods.
6447
6448 2019-07-17  Tom Tromey  <tom@tromey.com>
6449
6450         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6451         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6452         from tui_erase_data_content.
6453         (tui_data_window::display_all_data)
6454         (tui_data_window::refresh_all)
6455         (tui_data_window::do_scroll_vertical): Update.
6456         * tui/tui-regs.c (tui_show_registers): Update.
6457         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6458         New method.
6459
6460 2019-07-17  Tom Tromey  <tom@tromey.com>
6461
6462         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6463         declare.
6464         * tui/tui-windata.c
6465         (tui_data_window::delete_data_content_windows): Rename from
6466         tui_delete_data_content_windows.
6467         (tui_data_window::display_all_data)
6468         (tui_data_window::do_scroll_vertical): Update.
6469         * tui/tui-data.h (struct tui_data_window)
6470         <delete_data_content_windows>: New method.
6471
6472 2019-07-17  Tom Tromey  <tom@tromey.com>
6473
6474         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6475         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6476
6477 2019-07-17  Tom Tromey  <tom@tromey.com>
6478
6479         * tui/tui-windata.h (tui_display_all_data): Don't declare.
6480         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6481         from tui_display_all_data.
6482         * tui/tui-win.c
6483         (tui_data_window::do_make_visible_with_new_height): Update.
6484         * tui/tui-regs.c (tui_show_registers): Update.
6485         * tui/tui-layout.c (tui_set_layout): Update.
6486         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6487         method.
6488
6489 2019-07-17  Tom Tromey  <tom@tromey.com>
6490
6491         * tui/tui-windata.h (tui_display_data_from): Don't declare.
6492         * tui/tui-windata.c (tui_display_data_from): Remove.
6493         (tui_data_window::refresh_all): Update.
6494
6495 2019-07-17  Tom Tromey  <tom@tromey.com>
6496
6497         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6498         * tui/tui-windata.c (tui_display_data_from_line): Remove.
6499         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6500         tui_display_registers_from_line.
6501         * tui/tui-regs.h (tui_display_registers_from_line): Update.
6502         * tui/tui-regs.c (tui_display_registers_from_line): Remove
6503         "force_display" parameter.
6504
6505 2019-07-17  Tom Tromey  <tom@tromey.com>
6506
6507         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6508         declare.
6509         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6510         Rename from tui_first_reg_element_no_inline.
6511         (tui_display_reg_element_at_line)
6512         (tui_display_registers_from_line): Update.
6513         * tui/tui-data.h (struct tui_data_window)
6514         <first_reg_element_no_inline>: New method.
6515
6516 2019-07-17  Tom Tromey  <tom@tromey.com>
6517
6518         * tui/tui-windata.c (tui_display_data_from)
6519         (tui_data_window::do_scroll_vertical): Update.
6520         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6521         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6522         Rename from tui_line_from_reg_element_no.
6523         (tui_display_registers_from_line): Update.
6524         * tui/tui-data.h (struct tui_data_window)
6525         <line_from_reg_element_no>: New method.
6526
6527 2019-07-17  Tom Tromey  <tom@tromey.com>
6528
6529         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6530         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6531         tui_last_regs_line_no.
6532         (tui_display_reg_element_at_line)
6533         (tui_display_registers_from_line): Update.
6534         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6535         method.
6536
6537 2019-07-17  Tom Tromey  <tom@tromey.com>
6538
6539         PR tui/24722:
6540         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6541         (tui_update_breakpoint_info): Add "being_deleted" parameter.
6542         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6543         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6544         (tui_update_breakpoint_info): Likewise.
6545         * tui/tui-hooks.c (tui_event_create_breakpoint)
6546         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6547         Update.
6548
6549 2019-07-17  Tom Tromey  <tom@tromey.com>
6550
6551         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6552
6553 2019-07-17  Tom Tromey  <tom@tromey.com>
6554
6555         * tui/tui-winsource.c (tui_update_source_window_as_is)
6556         (tui_update_source_windows_with_addr): Update.
6557         * tui/tui-source.h (tui_set_source_content)
6558         (tui_show_symtab_source): Add "win_info" parameter.
6559         * tui/tui-source.c (tui_set_source_content): Add "win_info"
6560         parameter.
6561         (tui_show_symtab_source): Likewise.
6562
6563 2019-07-17  Tom Tromey  <tom@tromey.com>
6564
6565         * tui/tui-wingeneral.c
6566         (tui_check_and_display_highlight_if_needed): Check can_highlight.
6567
6568 2019-07-17  Tom Tromey  <tom@tromey.com>
6569
6570         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6571         (struct tui_cmd_window) <can_scroll>: New method.
6572         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6573         method.
6574
6575 2019-07-17  Tom Tromey  <tromey@adacore.com>
6576
6577         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6578         do_field_signed>: Rename.  Change type of "value".
6579         * ui-out.c (ui_out::field_signed): Rename from field_int.
6580         Change type of "value".
6581         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
6582         type of "value".
6583         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6584         do_field_int.  Change type of "value".
6585         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6586         do_field_int.  Change type of "value".
6587         * tracepoint.c (trace_status_mi, tfind_1)
6588         (print_one_static_tracepoint_marker): Update.
6589         * thread.c (print_thread_info_1, print_selected_thread_frame):
6590         Update.
6591         * stack.c (print_frame, print_frame_info): Update.
6592         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6593         Update.
6594         * source.c (print_source_lines_base): Update.
6595         * skip.c (info_skip_command): Update.
6596         * record-btrace.c (btrace_ui_out_decode_error)
6597         (btrace_call_history_src_line): Update.
6598         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6599         Update.
6600         * progspace.c (print_program_space): Update.
6601         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6602         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6603         do_field_int.  Change type of "value".
6604         * mi/mi-out.c (mi_ui_out::do_table_begin)
6605         (mi_ui_out::do_table_header): Update.
6606         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
6607         type of "value".
6608         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6609         (mi_cmd_data_list_changed_registers, output_register)
6610         (mi_cmd_data_read_memory, mi_load_progress)
6611         (mi_cmd_trace_frame_collected): Update.
6612         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6613         Update.
6614         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6615         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6616         (mi_cmd_var_list_children, varobj_update_one): Update.
6617         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6618         (mi_cmd_stack_list_args, list_arg_or_local): Update.
6619         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6620         * inferior.c (print_inferior): Update.
6621         * gdb_bfd.c (print_one_bfd): Update.
6622         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6623         Update.
6624         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6625         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6626         do_field_int.  Change type of "value".
6627         * cli-out.c (cli_ui_out::do_field_signed): Rename from
6628         do_field_int.  Change type of "value".
6629         * breakpoint.c (watchpoint_check, print_breakpoint_location)
6630         (print_one_breakpoint_location, print_it_catch_fork)
6631         (print_one_catch_fork, print_it_catch_vfork)
6632         (print_one_catch_vfork, print_it_catch_solib)
6633         (print_it_catch_exec, print_it_ranged_breakpoint)
6634         (print_mention_watchpoint, print_mention_masked_watchpoint)
6635         (bkpt_print_it, update_static_tracepoint): Update.
6636         * break-catch-throw.c (print_it_exception_catchpoint): Update.
6637         * break-catch-syscall.c (print_it_catch_syscall): Update.
6638         * ada-tasks.c (print_ada_task_info): Update.
6639         * ada-lang.c (print_it_exception, print_mention_exception):
6640         Update.
6641
6642 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
6643
6644         PR breakpoints/24541
6645         * gdbarch.c: Regenerate.
6646         * gdbarch.h: Regenerate.
6647         * gdbarch.sh: Adjust return type and parameter types for
6648         'stap_adjust_register'.
6649         (i386_stap_adjust_register): Adjust signature and return new
6650         register name.
6651         * stap-probe.c (stap_parse_register_operand): Adjust use of
6652         'gdbarch_stap_adjust_register'.
6653
6654 2019-07-17  Tom Tromey  <tromey@adacore.com>
6655
6656         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
6657         declare VEC.
6658         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6659         std::vector.
6660         (struct s390_process_info): Add initializers.
6661         (s390_add_process): Use new.
6662         (s390_linux_nat_target::low_forget_process): Use delete.
6663         (s390_linux_nat_target::low_new_fork)
6664         (s390_linux_nat_target::stopped_by_watchpoint)
6665         (s390_linux_nat_target::low_prepare_to_resume)
6666         (s390_linux_nat_target::insert_watchpoint)
6667         (s390_linux_nat_target::insert_hw_breakpoint)
6668         (s390_linux_nat_target::remove_watchpoint)
6669         (s390_linux_nat_target::remove_hw_breakpoint): Update.
6670
6671 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6672
6673         * aarch64-fbsd-nat.c: Include regcache.h.
6674         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6675         argument.
6676         (aarch64_fbsd_nat_target::fetch_registers)
6677         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6678         variable.
6679         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6680
6681 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6682
6683         * fbsd-nat.c: Include gdbarch.h.
6684
6685 2019-07-15  Tom Tromey  <tromey@adacore.com>
6686
6687         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6688
6689 2019-07-15  Tom Tromey  <tromey@adacore.com>
6690
6691         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6692         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6693         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6694         * cli-out.c (cli_ui_out::do_field_int): New method.
6695         * ui-out.c (ui_out::field_unsigned): New method.
6696         * symfile.c (generic_load): Use field_unsigned.
6697         (print_transfer_performance): Likewise.
6698         * record-btrace.c (ui_out_field_uint): Remove.
6699         (btrace_call_history_insn_range, btrace_call_history): Use
6700         field_unsigned.
6701         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6702         field_unsigned.
6703         * ui-out.h (class ui_out) <field_unsigned>: New method.
6704         <do_field_unsigned>: Likewise.
6705
6706 2019-07-15  Tom Tromey  <tromey@adacore.com>
6707
6708         * mi/mi-main.c (list_available_thread_groups): Use field_string.
6709         * mi/mi-interp.c (mi_memory_changed): Use field_string.
6710         * target.c (flash_erase_command): Use field_string.
6711         * infrun.c (print_signal_received_reason): Use field_string.
6712         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6713         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6714         field_string.
6715         * ada-tasks.c (print_ada_task_info): Use field_string.
6716
6717 2019-07-15  Tom Tromey  <tromey@adacore.com>
6718
6719         * target.c (flash_erase_command): Use field_core_addr.
6720         * symfile.c (generic_load): Use field_core_addr.
6721         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6722         Use field_core_addr.
6723         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6724         field_core_addr.
6725
6726 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6727
6728         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6729         value if its desired type is smaller than a CORE_ADDR and signed.
6730
6731 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6732
6733         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6734         of changes to field names, and use new is_reference field to
6735         decide if a property is a reference or not.
6736         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6737         field.
6738         (struct dwarf2_property_baton): Update header comment, rename
6739         'referenced_type' to 'property_type' and update comments.
6740         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6741         default property type, store in property baton, update to take
6742         accound of renamed field.
6743         (read_func_scope): Update call to attr_to_dynamic_prop.
6744         (read_array_type): Likewise.
6745         (dwarf2_per_cu_addr_sized_int_type): New function.
6746         (read_subrange_index_type): Move type finding code to
6747         dwarf2_per_cu_addr_sized_int_type.
6748         (read_subrange_type): Update calls to attr_to_dynamic_prop.
6749         (dwarf2_per_cu_addr_type): New function.
6750         (set_die_type): Update calls to attr_to_dynamic_prop.
6751
6752 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6753
6754         * dwarf2read.c (read_subrange_index_type): New function.
6755         (read_subrange_type): Move code into new function and call it.
6756         * gdbtypes.c (create_range_type): Add some asserts.
6757
6758 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6759
6760         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6761         update return statements.
6762         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6763         declaration, and update comment to match.
6764         * gdbtypes.c (resolve_dynamic_array): Update call to
6765         dwarf2_evaluate_property to match new return type.
6766
6767 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6768
6769         * valarith.c (value_subscripted_rvalue): Change lowerbound
6770         parameter type from int to LONGEST.
6771         * value.h (value_subscripted_rvalue): Likewise in declaration.
6772
6773 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6774
6775         * cli/cli-utils.c (info_print_command_completer): New function.
6776         * cli/cli-utils.h: Add 'completer.h' include, and forward
6777         declaration for 'struct cmd_list_element'.
6778         (info_print_command_completer): Declare.
6779         * stack.c (_initialize_stack): Add completer for 'info locals' and
6780         'info args'.
6781         * symtab.c (_initialize_symtab): Add completer for 'info
6782         variables' and 'info functions'.
6783         * NEWS: Mention completion for additional info commands.
6784
6785 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6786
6787         * cli/cli-utils.c (extract_info_print_args): Delete.
6788         (extract_arg_maybe_quoted): Delete.
6789         (info_print_options_defs): New variable.
6790         (make_info_print_options_def_group): New function.
6791         (extract_info_print_options): Define new function.
6792         * cli/cli-utils.h (extract_info_print_args): Delete.
6793         (struct info_print_options): New structure.
6794         (extract_info_print_options): Declare new function.
6795         * stack.c (info_locals_command): Update to use new
6796         extract_info_print_options, also add a header comment.
6797         (info_args_command): Likewise.
6798         * symtab.c (info_variables_command): Likewise.
6799         (info_functions_command): Likewise.
6800
6801 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6802
6803         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6804         to extract string arguments.
6805         * common/common-utils.c (extract_string_maybe_quoted): New function.
6806         * common/common-utils.h (extract_string_maybe_quoted): Declare.
6807
6808 2019-07-11  Tom Tromey  <tromey@adacore.com>
6809
6810         * main.c (get_init_files): Use GDBINIT, not gdbinit.
6811         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6812         * top.h (gdbinit): Don't declare.
6813         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6814         into...
6815         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
6816         * top.c (gdb_init): Don't call init_cli_cmds.
6817         (gdbinit): Remove.
6818         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6819
6820 2019-07-11  Tom Tromey  <tromey@adacore.com>
6821
6822         * python/py-inferior.c (add_thread_object): Don't use thread_obj
6823         after it has been moved.
6824
6825 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6826
6827         * valops.c (value_must_coerce_to_target): Change return type to
6828         bool.
6829         * value.h (value_must_coerce_to_target): Likewise.
6830
6831 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
6832
6833         * breakpoint.c (is_hardware_watchpoint): Remove
6834         forward-declaration.
6835         (is_masked_watchpoint): Change return type to bool.
6836         (is_tracepoint): Likewise.
6837         (is_breakpoint): Likewise.
6838         (is_hardware_watchpoint): Likewise.
6839         (is_watchpoint): Likewise.
6840         (is_no_memory_software_watchpoint): Likewise.
6841         (is_catchpoint): Likewise.
6842         (breakpoint_1): Make FILTER parameter's return type bool.
6843         is_masked_watchpoint): Change return type to bool.
6844         (save_breakpoints): Make FILTER parameter's return type bool.
6845         * breakpoint.h (is_breakpoint): Change return type to bool.
6846         (is_watchpoint): Likewise.
6847         (is_catchpoint): Likewise.
6848         (is_tracepoint): Likewise.
6849
6850 2019-07-10  Tom Tromey  <tom@tromey.com>
6851
6852         * defs.h: Don't include gdbarch.h.
6853         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6854         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6855         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6856         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6857         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6858         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6859         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6860         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6861         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6862         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6863         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6864         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6865         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6866         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6867         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6868         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6869         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6870         record-btrace.c, record.h, regcache-dump.c, regcache.h,
6871         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6872         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6873         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6874         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6875         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6876         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6877         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6878         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6879         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6880
6881 2019-07-10  Tom Tromey  <tromey@adacore.com>
6882
6883         * ada-lang.h (is_ada_exception_catchpoint): Declare.
6884         * breakpoint.c (init_ada_exception_breakpoint): Register as
6885         bp_catchpoint.
6886         (print_one_breakpoint_location, print_one_breakpoint): Use
6887         is_ada_exception_catchpoint.
6888         * ada-lang.c (class ada_catchpoint_location): Pass
6889         bp_loc_software_breakpoint to bp_location constructor.
6890         (is_ada_exception_catchpoint): New function.
6891
6892 2019-07-10  Tom Tromey  <tromey@adacore.com>
6893
6894         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
6895         VEC.
6896         (struct arm_exidx_entry): New method operator<.
6897         (struct arm_exidx_data) <section_maps>: Change type.
6898         (arm_exidx_data_free): Remove.
6899         (arm_exidx_data_key): Change type.  Move lower.
6900         (arm_exidx_new_objfile): Update.
6901         (arm_compare_exidx_entries): Remove.
6902         (arm_find_exidx_entry, _initialize_arm_tdep)
6903
6904 2019-07-10  Tom Tromey  <tromey@adacore.com>
6905
6906         * solib-spu.c (ocl_program_data_key): Change type.
6907         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6908         Update.
6909
6910 2019-07-10  Tom Tromey  <tromey@adacore.com>
6911
6912         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
6913         (struct solib_aix_inferior_data) <library_list>: Change type.
6914         (solib_aix_inferior_data_handle): Change type.
6915         (get_solib_aix_inferior_data): Update.
6916         (solib_aix_free_library_list): Remove.
6917         (library_list_start_library): Update.
6918         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6919         return type.
6920         (solib_aix_get_library_list)
6921         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6922         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
6923
6924 2019-07-10  Tom Tromey  <tromey@adacore.com>
6925
6926         * solib-dsbt.c (struct dsbt_info): Add initializers.
6927         (solib_dsbt_pspace_data): Change type.
6928         (dsbt_pspace_data_cleanup): Remove.
6929         (get_dsbt_info, _initialize_dsbt_solib): Update.
6930
6931 2019-07-10  Tom Tromey  <tromey@adacore.com>
6932
6933         * spu-tdep.c (spu_overlay_data): Change type.
6934         (spu_get_overlay_table, spu_overlay_new_objfile)
6935         (_initialize_spu_tdep): Update.
6936
6937 2019-07-10  Tom Tromey  <tromey@adacore.com>
6938
6939         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
6940         destructor.
6941         (dbx_objfile_data_key): Change type and declare later.
6942         (DBX_SYMFILE_INFO): Rewrite.
6943         * dbxread.c (dbx_objfile_data_key): Change type.
6944         (dbx_symfile_init): Update.
6945         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
6946         (coffstab_build_psymtabs, elfstab_build_psymtabs)
6947         (stabsect_build_psymtabs, _initialize_dbxread): Update.
6948
6949 2019-07-10  Tom Tromey  <tromey@adacore.com>
6950
6951         * jit.c (jit_program_space_key): Change type.  Move lower.
6952         (get_jit_program_space_data): Update.
6953         (jit_program_space_data_cleanup): Remove.
6954         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
6955         Update.
6956         (struct jit_program_space_data): Add initializers.
6957
6958 2019-07-10  Tom Tromey  <tromey@adacore.com>
6959
6960         * solib-darwin.c (struct darwin_info): Add initializers.
6961         (solib_darwin_pspace_data): Change type.
6962         (darwin_pspace_data_cleanup): Remove.
6963         (get_darwin_info, _initialize_darwin_solib): Update.
6964
6965 2019-07-10  Tom Tromey  <tromey@adacore.com>
6966
6967         * remote-sim.c (struct sim_inferior_data): Add initializers,
6968         constructor, and destructor.
6969         (sim_inferior_data_key): Change type.  Move lower.
6970         (check_for_duplicate_sim_descriptor): Update.
6971         (get_sim_inferior_data): Use new.  Update.
6972         (~sim_inferior_data_cleanup): Rename from
6973         sim_inferior_data_cleanup.  Simplify.
6974         (gdbsim_close_inferior, simulator_command)
6975         (sim_command_completer, _initialize_remote_sim): Update.
6976         (next_pid, INITIAL_PID): Move earlier.
6977
6978 2019-07-10  Tom Tromey  <tromey@adacore.com>
6979
6980         * python/python-internal.h (create_thread_object): Return
6981         gdbpy_ref.
6982         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
6983         * python/py-inferior.c (struct threadlist_entry): Add
6984         constructor.
6985         <thread_obj>: Now a gdbpy_ref.
6986         (thread_to_thread_object): Update.
6987         (add_thread_object): Use new.
6988         (delete_thread_object): Use delete.
6989         (infpy_threads): Update.
6990         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
6991         GIL.
6992
6993 2019-07-10  Tom Tromey  <tromey@adacore.com>
6994
6995         * valops.c (value_cast): Specialize error message for Ada.
6996
6997 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6998
6999         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7000
7001 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7002
7003         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7004         bpstat_should_step): Return bool, adjust comments.
7005         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7006         bpstat_should_step): Likewise.
7007
7008 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7009
7010         * features/Makefile: Use feature target descriptions for Arm.
7011         * features/arm/arm-core.c: Generate new file.
7012         * features/arm/arm-fpa.c: Likewise.
7013         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7014         * features/arm/arm-m-profile.c: Likewise.
7015         * features/arm/arm-vfpv2.c: Likewise.
7016         * features/arm/arm-vfpv3.c: Likewise.
7017         * features/arm/xscale-iwmmxt.c: Likewise.
7018         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7019
7020 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7021
7022         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7023         ptrace earlier.
7024
7025 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7026
7027         * features/aarch64-pauth.c: Regenerate.
7028
7029 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7030
7031         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7032         bool.
7033         (bpstat_what): Use false instead of 0.
7034
7035 2019-07-09  Pedro Alves  <palves@redhat.com>
7036
7037         * break-catch-throw.c (is_exception_catchpoint): New.
7038         * breakpoint.c (print_one_breakpoint_location): New parameter
7039         'raw_loc'.  Handle it.  Use
7040         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7041         looking at the breakpoint's type.
7042         (print_one_breakpoint): If handling "maint info breakpoints", also
7043         print locations of exception catchpoints.
7044         * breakpoint.h (is_exception_catchpoint): Declare.
7045
7046 2019-07-09  Pedro Alves  <palves@redhat.com>
7047
7048         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7049         "addr" field.
7050         (allocate_location_exception_catchpoint): New.
7051         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7052         (initialize_throw_catchpoint_ops): Install
7053         allocate_location_exception_catchpoint as allocate_location
7054         method.
7055         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7056         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7057         bp_loc_other.
7058         (breakpoint_address_is_meaningful): Delete.
7059         (bl_address_is_meaningful): New.
7060         (breakpoint_locations_match): Adjust comment.
7061         (bp_location_from_bp_type): New, factored out of...
7062         (bp_location::bp_location(breakpoint *)): ... this.
7063         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7064         factored out of...
7065         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7066         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7067         breakpoint_address_is_meaningful.
7068         (bp_locations_compare): Adjust comment.
7069         (update_global_location_list): Use bl_address_is_meaningful
7070         instead of breakpoint_address_is_meaningful.
7071         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7072         explicit.
7073         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7074         * python/py-breakpoint.c (bppy_get_location): No longer check
7075         whether location is null.
7076
7077 2019-07-09  Pedro Alves  <palves@redhat.com>
7078
7079         PR c++/15468
7080         * breakpoint.c (print_one_breakpoint_location): Remove
7081         single-location assert.
7082
7083 2019-07-09  Tom Tromey  <tom@tromey.com>
7084
7085         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7086         * configure: Rebuild.
7087         * configure.ac: Change common to gdbsupport.
7088         * gdbsupport: Rename from common.
7089         * acinclude.m4: Change common to gdbsupport.
7090         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7091         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7092         gdbsupport.
7093         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7094         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7095         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7096         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7097         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7098         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7099         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7100         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7101         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7102         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7103         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7104         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7105         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7106         coff-pe-read.c, command.h, compile/compile-c-support.c,
7107         compile/compile-c.h, compile/compile-cplus-symbols.c,
7108         compile/compile-cplus-types.c, compile/compile-cplus.h,
7109         compile/compile-loc2c.c, compile/compile.c, completer.c,
7110         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7111         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7112         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7113         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7114         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7115         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7116         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7117         features/aarch64-core.c, features/aarch64-fpu.c,
7118         features/aarch64-pauth.c, features/aarch64-sve.c,
7119         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7120         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7121         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7122         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7123         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7124         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7125         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7126         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7127         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7128         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7129         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7130         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7131         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7132         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7133         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7134         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7135         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7136         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7137         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7138         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7139         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7140         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7141         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7142         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7143         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7144         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7145         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7146         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7147         minsyms.c, mips-linux-tdep.c, namespace.h,
7148         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7149         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7150         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7151         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7152         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7153         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7154         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7155         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7156         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7157         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7158         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7159         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7160         procfs.c, producer.c, progspace.h, psymtab.h,
7161         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7162         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7163         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7164         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7165         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7166         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7167         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7168         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7169         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7170         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7171         target-memory.c, target.c, target.h, target/waitstatus.c,
7172         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7173         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7174         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7175         unittests/array-view-selftests.c,
7176         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7177         unittests/common-utils-selftests.c,
7178         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7179         unittests/format_pieces-selftests.c,
7180         unittests/function-view-selftests.c,
7181         unittests/lookup_name_info-selftests.c,
7182         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7183         unittests/mkdir-recursive-selftests.c,
7184         unittests/observable-selftests.c,
7185         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7186         unittests/parse-connection-spec-selftests.c,
7187         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7188         unittests/scoped_fd-selftests.c,
7189         unittests/scoped_mmap-selftests.c,
7190         unittests/scoped_restore-selftests.c,
7191         unittests/string_view-selftests.c, unittests/style-selftests.c,
7192         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7193         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7194         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7195         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7196         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7197         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7198
7199 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7200
7201         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7202         bool value.
7203         (decode_digits_ordinary): Set explicit_line field in sal.
7204         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7205         symtab_and_line that was set on an explicit line number in
7206         assembler code.  Do always update the recorded symtab and line if
7207         we do skip the prologue.
7208
7209 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7210
7211         * breakpoint.c (set_breakpoint_location_function): Remove
7212         explicit_loc parameter.
7213         (momentary_breakpoint_from_master): Update call to
7214         set_breakpoint_location_function.
7215         (add_location_to_breakpoint): Likewise.
7216
7217 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7218
7219         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7220         required features based on default bfd type when no specific bfd
7221         is present.
7222
7223 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7224
7225         * NEWS: Mention that GDB printf and eval commands can now print
7226         C-style and Ada-style convenience var strings without
7227         calling the inferior.
7228         * printcmd.c (printf_c_string): Locally print GDB internal var
7229         instead of transiting via the inferior.
7230         (printf_wide_c_string): Likewise.
7231
7232 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7233
7234         PR breakpoints/25011
7235         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7236
7237 2019-07-04  Tom Tromey  <tom@tromey.com>
7238
7239         PR tui/24724:
7240         * tui/tui-winsource.c (tui_clear_source_content): Update.
7241         (tui_source_window_base::set_is_exec_point_at): Fix comment.
7242         (tui_update_breakpoint_info): Update.
7243         (tui_set_exec_info_content): Update.
7244         * tui/tui-source.c (tui_set_source_content_nil): Update.
7245         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7246         has_break.
7247         * tui/tui-data.h (enum tui_bp_flag): New.
7248         (tui_bp_flags): New enum flags type.
7249         (struct tui_source_element) <break_mode>: Change type.  Rename
7250         from has_break.
7251         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7252         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
7253         constants.
7254         * tui/tui-winsource.h: Fix comment.
7255
7256 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7257
7258         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7259         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7260         (store_fpregs_to_thread)
7261         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7262         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7263         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7264         (IWMMXT_REGS_SIZE): Add define.
7265         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7266         (fetch_vfp_regs, store_vfp_regs)
7267         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7268         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7269
7270 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7271
7272         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7273         defines.
7274         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7275         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7276         (ARM_INT_REGISTER_SIZE): ...to this.
7277         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7278         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7279         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7280         (arm_linux_collect_gregset, supply_nwfpe_register)
7281         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7282         defines.
7283         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7284         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7285         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7286         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7287         (arm_return_in_memory, arm_store_return_value)
7288         (arm_get_longjmp_target, arm_register_g_packet_guesses)
7289         (arm_record_ld_st_multiple): Likewise.
7290         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7291         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7292
7293 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7294
7295         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7296         AARCH64_DISPLACED_MODIFIED_INSNS.
7297         * aarch64-tdep.c (struct aarch64_displaced_step_data)
7298         (aarch64_displaced_step_copy_insn): Likewise.
7299         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7300         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7301         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7302         ARM_DISPLACED_MODIFIED_INSNS.
7303         * arm-tdep.c (arm_gdbarch_init): Likewise.
7304         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7305         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7306         (struct arm_displaced_step_closure): Use
7307         ARM_DISPLACED_MODIFIED_INSNS.
7308
7309 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7310
7311         * features/Makefile: Remove unused xml files.
7312         * features/aarch64.xml: Remove.
7313         * features/i386/amd64-avx-avx512-linux.xml: Remove.
7314         * features/i386/amd64-avx-avx512.xml: Remove.
7315         * features/i386/amd64-avx-linux.xml: Remove.
7316         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7317         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7318         * features/i386/amd64-avx-mpx-linux.xml: Remove.
7319         * features/i386/amd64-avx-mpx.xml: Remove.
7320         * features/i386/amd64-avx.xml: Remove.
7321         * features/i386/amd64-linux.xml: Remove.
7322         * features/i386/amd64-mpx-linux.xml: Remove.
7323         * features/i386/amd64-mpx.xml: Remove.
7324         * features/i386/amd64.xml: Remove.
7325         * features/i386/i386-avx-avx512-linux.xml: Remove.
7326         * features/i386/i386-avx-avx512.xml: Remove.
7327         * features/i386/i386-avx-linux.xml: Remove.
7328         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7329         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7330         * features/i386/i386-avx-mpx-linux.xml: Remove.
7331         * features/i386/i386-avx-mpx.xml: Remove.
7332         * features/i386/i386-avx.xml: Remove.
7333         * features/i386/i386-linux.xml: Remove.
7334         * features/i386/i386-mmx-linux.xml: Remove.
7335         * features/i386/i386-mmx.xml: Remove.
7336         * features/i386/i386-mpx-linux.xml: Remove.
7337         * features/i386/i386-mpx.xml: Remove.
7338         * features/i386/i386.xml: Remove.
7339         * features/i386/x32-avx-avx512-linux.xml: Remove.
7340         * features/i386/x32-avx-linux.xml: Remove.
7341         * features/i386/x32-linux.xml: Remove.
7342
7343 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7344
7345         * regformats/aarch64.dat: Remove.
7346         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7347         * regformats/i386/amd64-avx-linux.dat: Remove.
7348         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7349         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7350         * regformats/i386/amd64-linux.dat: Remove.
7351         * regformats/i386/amd64-mpx-linux.dat: Remove.
7352         * regformats/i386/amd64.dat: Remove.
7353         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7354         * regformats/i386/i386-avx-linux.dat: Remove.
7355         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7356         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7357         * regformats/i386/i386-linux.dat: Remove.
7358         * regformats/i386/i386-mmx-linux.dat: Remove.
7359         * regformats/i386/i386-mpx-linux.dat: Remove.
7360         * regformats/i386/i386.dat: Remove.
7361         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7362         * regformats/i386/x32-avx-linux.dat: Remove.
7363         * regformats/i386/x32-linux.dat: Remove.
7364
7365 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7366
7367         * aarch64-tdep.c: Remove xml self tests.
7368         * amd64-linux-tdep.c: Likewise.
7369         * amd64-tdep.c: Likewise.
7370         * i386-linux-tdep.c: Likewise.
7371         * i386-tdep.c: Likewise.
7372
7373 2019-07-03  Pedro Alves  <palves@redhat.com>
7374
7375         PR cli/24732
7376         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7377         (pipe_cmd_option_defs): New.
7378         (make_pipe_cmd_options_def_group): New.
7379         (pipe_command): Use gdb::option::process_options.
7380         (pipe_command_completer): New function.
7381         (_initialize_cli_cmds): Install completer for "pipe" command.
7382
7383 2019-07-03  Pedro Alves  <palves@redhat.com>
7384
7385         * cli/cli-option.c (union option_value) <string>: New field.
7386         (struct option_def_and_value): Add ctor, move ctor, dtor and
7387         use DISABLE_COPY_AND_ASSIGN.
7388         (option_def_and_value::clear_value): New.
7389         (parse_option, save_option_value_in_ctx, get_val_type_str)
7390         (add_setshow_cmds_for_options): Handle var_string.
7391         * cli-option.h (union option_def::var_address) <string>: New
7392         field.
7393         (struct string_option_def): New.
7394         * maint-test-options.c (struct test_options_opts): Add default
7395         ctor and use DISABLE_COPY_AND_ASSIGN.
7396         <string_opt>: New field.
7397         (test_options_opts::~test_options_opts): New.
7398         (test_options_opts::dump): Also dump "-string".
7399         (test_options_option_defs): Install "string.
7400
7401 2019-07-03  Pedro Alves  <palves@redhat.com>
7402
7403         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7404         option_value with a null enumeration.
7405         (complete_options): Save the option values in the context.
7406         (save_option_value_in_ctx): New, factored out from ...
7407         (process_options): ... here.
7408         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7409         of the function.
7410         * maint-test-options.c (test_options_opts::dump): New, factored
7411         out from ...
7412         (maintenance_test_options_command_mode): ... here.
7413         (maintenance_test_options_command_completion_result): Delete.
7414         (maintenance_test_options_command_completion_text): Update
7415         comment.
7416         (maintenance_show_test_options_completion_result): Change
7417         prototype.  Just print
7418         maintenance_test_options_command_completion_text.
7419         (save_completion_result): New.
7420         (maintenance_test_options_completer_mode): Pass options context to
7421         complete_options, and then save a dump.
7422         (_initialize_maint_test_options): Use add_cmd to install "maint
7423         show test-options-completion-result".
7424
7425 2019-07-03  Pedro Alves  <palves@redhat.com>
7426
7427         * NEWS (New commands): Mention "with" and "maint with".
7428         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7429         (with_command, with_command_completer): New.
7430         (pipe_command): Adjust to new repeat_previous
7431         interface.
7432         (_initialize_cli_cmds): Install the "with" command and its "w"
7433         alias.
7434         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7435         declarations.
7436         * cli/cli-setshow.c (parse_cli_var_uinteger)
7437         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7438         argument strings for all var_types.
7439         (get_setshow_command_value_string): New, factored out from ...
7440         (do_show_command): ... this.
7441         * cli/cli-setshow.h: Include <string>.
7442         (get_setshow_command_value_string): Declare.
7443         * command.h (repeat_previous): Now returns const char *.  Adjust
7444         comment.
7445         * maint.c: Include "cli/cli-cmds.h".
7446         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7447         (_initialize_maint_cmds): Register the "maintenance with" command.
7448         * top.c (repeat_previous): Move bits from pipe_command here:
7449         Return the saved command line, if any; error out if there's no
7450         command to relaunch.
7451
7452 2019-07-03  Pedro Alves  <palves@redhat.com>
7453
7454         * NEWS (New commands): Mention "maint set/show test-settings"
7455         instead of "maint test-settings".
7456         * maint-test-settings.c (maintenance_test_settings_list): Delete.
7457         (maintenance_test_settings_set_list): Rename to ...
7458         (maintenance_set_test_settings_list): ... this.
7459         (maintenance_test_settings_show_list): Rename to  ...
7460         (maintenance_show_test_settings_list): ... this.
7461         (maintenance_test_settings_cmd): Delete.
7462         (maintenance_test_settings_set_cmd): ...
7463         (maintenance_set_test_settings_cmd): ... this.
7464         (maintenance_test_settings_show_cmd): ...
7465         (maintenance_show_test_settings_cmd): ... this.
7466         (maintenance_test_settings_show_value_cmd):
7467         (maintenance_show_test_settings_value_cmd): ... this.
7468         (_initialize_maint_test_settings): No longer install the "maint
7469         test-settings" prefix command.  Rename "maint test-settings set"
7470         to "maint set test-settings", and "maint test-settings show" to
7471         "maint show test-settings".  Adjust all subcommands.
7472
7473 2019-07-03  Pedro Alves  <palves@redhat.com>
7474
7475         * maint-test-settings.c: Fix file's intro comment.  Replace all
7476         references to "test-options" with references to "test-settings",
7477         in comments.
7478
7479 2019-07-03  Pedro Alves  <palves@redhat.com>
7480
7481         * maint-test-settings.c (maintenance_test_settings_xxx)
7482         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7483         New.
7484         (maintenance_test_settings_enums): Use them.
7485         (maintenance_test_settings_enum): Default to
7486         maintenance_test_settings_xxx.
7487         (_initialize_maint_test_settings): Initialize
7488         MAINTENANCE_TEST_SETTINGS_FILENAME.
7489
7490 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7491
7492         * breakpoint.h (remove_breakpoints_inf): Change return type to
7493         void, move function documentation here.
7494         * breakpoint.c (remove_breakpoints_inf): Change return type to
7495         void, move function documentation to header.
7496
7497 2019-07-02  Pedro Alves  <palves@redhat.com>
7498
7499         * NEWS (Completion improvements): Mention "info threads".
7500         * thread.c (struct info_threads_opts, info_threads_option_defs)
7501         (make_info_threads_options_def_group): New.
7502         (info_threads_command): Use gdb::option::process_options.
7503         (info_threads_command_completer): New.
7504         (_initialize_thread): Use gdb::option::build_help to build the
7505         help text for "info threads".
7506
7507 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7508
7509         * defs.h (generic_load): Move from here...
7510         * symfile.h (generic_load): ... to here.  Rename name parameter
7511         to args.
7512         * symfile.c (generic_load): Add comment.
7513
7514 2019-07-01  Tom Tromey  <tromey@adacore.com>
7515
7516         * dwarf2read.c
7517         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7518         declaration of without_params.  Fix formatting.
7519
7520 2019-07-01  Tom Tromey  <tromey@adacore.com>
7521
7522         * ada-exp.y (find_primitive_type): Update.
7523         * ada-lang.h (ada_lookup_symbol): Update.
7524         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7525         parameter.
7526         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7527
7528 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7529
7530         PR breakpoints/24541
7531         * gdbarch.c: Regenerate.
7532         * gdbarch.h: Regenerate.
7533         * gdbarch.sh: Add 'stap_adjust_register'.
7534         * i386-tdep.c: Include '<unordered_set>'.
7535         (i386_stap_adjust_register): New function.
7536         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7537         * stap-probe.c (stap_parse_register_operand): Call
7538         'gdbarch_stap_adjust_register'.
7539
7540 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7541
7542         PR python/24742
7543         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7544         * python/python.c (do_start_initialization): Use 'xmalloc'
7545         instead of 'PyMem_Malloc'.
7546
7547 2019-06-28  Tom Tromey  <tromey@adacore.com>
7548
7549         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7550         for Ada.
7551
7552 2019-06-27  Tom Tromey  <tromey@adacore.com>
7553
7554         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
7555         objfile_key.
7556         (arm_find_mapping_symbol, arm_record_special_symbol)
7557         (_initialize_arm_tdep): Update.
7558         (arm_objfile_data_free): Remove.
7559
7560 2019-06-27  Tom Tromey  <tromey@adacore.com>
7561
7562         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7563         to cp_print_static_field.
7564
7565 2019-06-26  Tom Tromey  <tromey@adacore.com>
7566
7567         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7568         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7569         declare.
7570
7571 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7572
7573         * features/aarch64-core.c (create_feature_aarch64_core):
7574         Regenerate.
7575         * features/aarch64-core.xml: Add cpsr flags.
7576
7577 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7578
7579         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7580         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7581
7582 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7583
7584         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7585         field.
7586         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7587         use.
7588         (arm_record_special_symbol): Don't insert new symbol in sorted
7589         position, push it at the end.
7590
7591 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7592
7593         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7594         (arm_mapping_symbol_s): Remove.
7595         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7596         (arm_mapping_symbol_vec): New typedef.
7597         (struct arm_per_objfile): Add constructor.
7598         <section_maps>: Change type to
7599         std::unique_ptr<arm_mapping_symbol_vec[]>.
7600         (arm_compare_mapping_symbols): Remove.
7601         (arm_find_mapping_symbol): Adjust to section_maps type change.
7602         (arm_objfile_data_free): Call delete on arm_per_objfile.
7603         (arm_record_special_symbol): Adjust to section_maps type change.
7604         Allocate arm_per_objfile with new.
7605
7606 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7607
7608         * cli/cli-cmds.c (alias_command): Compare the alias prefix
7609         with the command prefix.
7610
7611 2019-06-25  Tom Tromey  <tom@tromey.com>
7612
7613         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7614         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7615
7616 2019-06-25  Tom Tromey  <tom@tromey.com>
7617
7618         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7619         type.
7620         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7621         protected.
7622
7623 2019-06-25  Tom Tromey  <tom@tromey.com>
7624
7625         * tui/tui-winsource.c
7626         (tui_source_window_base::set_is_exec_point_at): Add check against
7627         LOA_ADDRESS.
7628
7629 2019-06-25  Tom Tromey  <tom@tromey.com>
7630
7631         * tui/tui-source.c (tui_set_source_content): Don't check before
7632         xfree.
7633         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7634
7635 2019-06-25  Tom Tromey  <tom@tromey.com>
7636
7637         * tui/tui-winsource.h (tui_update_source_window_as_is)
7638         (tui_alloc_source_buffer, tui_line_is_displayed)
7639         (tui_addr_is_displayed): Change type of win_info.
7640         * tui/tui-winsource.c (tui_update_source_window_as_is)
7641         (tui_clear_source_content, tui_show_source_line)
7642         (tui_show_source_content, tui_source_window_base::refill)
7643         (tui_source_window_base::set_is_exec_point_at)
7644         (tui_source_window_base::set_is_exec_point_at)
7645         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7646         (tui_alloc_source_buffer, tui_line_is_displayed)
7647         (tui_addr_is_displayed): Change type of win_info.  Update.
7648         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7649         (tui_source_window_base::do_make_visible_with_new_height):
7650         Update.
7651         * tui/tui-source.c (tui_set_source_content)
7652         (tui_set_source_content_nil)
7653         (tui_source_window::do_scroll_vertical): Update.
7654         * tui/tui-layout.c (show_layout): Update.
7655         * tui/tui-disasm.c (tui_set_disassem_content)
7656         (tui_disasm_window::do_scroll_vertical): Update.
7657         * tui/tui-data.h (tui_win_content): Remove.
7658         (struct tui_gen_win_info) <content, content_size>: Remove.
7659         (struct tui_source_element): Add initializers and destructor.
7660         (union tui_which_element, struct tui_win_element): Remove.
7661         (struct tui_source_window_base) <content>: New field.
7662         (struct tui_data_window): Remove destructor.
7663         (tui_alloc_content, tui_free_win_content)
7664         (tui_free_all_source_wins_content): Don't declare.
7665         * tui/tui-data.c (tui_initialize_static_data): Update.
7666         (init_content_element, tui_alloc_content): Remove.
7667         (~tui_gen_win_info): Update.
7668         (~tui_data_window, tui_free_all_source_wins_content)
7669         (tui_free_win_content, free_content, free_content_elements):
7670         Remove.
7671
7672 2019-06-25  Tom Tromey  <tom@tromey.com>
7673
7674         * tui/tui-winsource.h (tui_clear_source_content)
7675         (tui_erase_source_content, tui_show_source_content): Change type
7676         of win_info.
7677         * tui/tui-winsource.c (tui_clear_source_content)
7678         (tui_erase_source_content, tui_show_source_content): Change type
7679         of win_info.
7680         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7681         * tui/tui-source.h (tui_set_source_content_nil): Change type of
7682         win_info.
7683         * tui/tui-source.c (tui_set_source_content_nil): Change type of
7684         win_info.
7685         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7686
7687 2019-06-25  Tom Tromey  <tom@tromey.com>
7688
7689         * tui/tui-winsource.c (tui_clear_source_content)
7690         (tui_source_window_base::set_is_exec_point_at): Update.
7691         * tui/tui-source.c (tui_set_source_content_nil): Update.
7692         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7693         a bool.
7694         * tui/tui-data.c (init_content_element): Update.
7695
7696 2019-06-25  Tom Tromey  <tom@tromey.com>
7697
7698         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7699         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7700         * tui/tui-layout.c (init_and_make_win): Update.
7701         * tui/tui.h (enum tui_win_type): Update.
7702         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7703         tui_win_is_auxillary.
7704         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7705         tui_win_is_auxillary.
7706
7707 2019-06-25  Tom Tromey  <tom@tromey.com>
7708
7709         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7710         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7711         (tui_delete_data_content_windows, tui_display_all_data)
7712         (tui_data_window::do_scroll_vertical, tui_display_data_from):
7713         Update.
7714         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7715         * tui/tui-regs.c (tui_last_regs_line_no)
7716         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7717         (tui_show_registers): Update.
7718         (tui_show_register_group): Return void.  Update.
7719         (tui_display_registers_from, tui_display_reg_element_at_line)
7720         (tui_display_registers_from_line, tui_check_register_values):
7721         Update.
7722         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7723         member.
7724         (struct tui_data_window) <regs_content>: Now a std::vector.
7725         <regs_content_count>: Remove.
7726         (tui_add_content_elements, tui_free_data_content): Don't declare.
7727         * tui/tui-data.c (tui_data_window::clear_detail): Update.
7728         (init_content_element): Remove DATA_WIN case.  Add assert.
7729         (tui_add_content_elements): Remove.
7730         (tui_data_window): Update.
7731         (tui_free_data_content): Remove.
7732         (free_content_elements): Remove DATA_WIN case.
7733
7734 2019-06-25  Tom Tromey  <tom@tromey.com>
7735
7736         * tui/tui-data.c (tui_data_item_window): Update.
7737         * tui/tui-windata.h (tui_check_data_values): Don't declare.
7738         * tui/tui-windata.c (tui_display_all_data)
7739         (tui_display_data_from_line): Update.
7740         (tui_check_data_values): Remove.
7741         * tui/tui-regs.c (tui_show_register_group)
7742         (tui_display_reg_element_at_line): Update.
7743         * tui/tui-hooks.c (tui_register_changed)
7744         (tui_refresh_frame_and_register_information): Call
7745         tui_check_register_values.
7746         * tui/tui-data.h (struct tui_data_window) <data_content,
7747         data_content_count, data_type>: Remove.
7748         (enum tui_data_type): Remove.
7749
7750         * tui/tui-data.c (tui_data_window::clear_detail)
7751         (~tui_data_window): Update.
7752
7753 2019-06-25  Tom Tromey  <tom@tromey.com>
7754
7755         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7756         declare.
7757         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7758         Rename from tui_first_data_item_displayed.  Update.
7759         (tui_data_window::refresh_all)
7760         (tui_data_window::do_scroll_vertical): Update.
7761         * tui/tui-data.h (struct tui_data_window)
7762         <first_data_item_displayed>: Declare new method.
7763
7764 2019-06-25  Tom Tromey  <tom@tromey.com>
7765
7766         * tui/tui-data.h (tui_init_generic_part): Don't declare.
7767         * tui/tui-data.c (tui_init_generic_part): Remove, moving
7768         contents...
7769         (tui_initialize_static_data): ...here.
7770
7771 2019-06-25  Tom Tromey  <tom@tromey.com>
7772
7773         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7774         (tui_display_registers_from, tui_check_register_values): Update.
7775         (tui_display_register): Remove win_info parameter; update.
7776         (tui_get_register): Change type of parameters.
7777         * tui/tui-data.h (struct tui_data_element): Remove.
7778         (union tui_which_element) <data>: Remove.
7779         <data_window>: Change type.
7780         (struct tui_data_item_window): New.
7781         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7782         case.  Add assert.
7783         (~tui_data_item_window): New destructor.
7784         (free_content_elements): Remove DATA_ITEM_WIN case.
7785
7786 2019-06-25  Tom Tromey  <tom@tromey.com>
7787
7788         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7789         Remove.
7790
7791 2019-06-25  Tom Tromey  <tom@tromey.com>
7792
7793         * tui/tui-data.h (struct tui_command_element): Remove.
7794         (union tui_which_element) <command>: Remove.
7795         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
7796         assert.
7797         (free_content_elements): Remove CMD_WIN case.
7798
7799 2019-06-25  Tom Tromey  <tom@tromey.com>
7800
7801         * tui/tui-layout.c (tui_set_layout): Update.
7802         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7803         * tui/tui-data.c (layout_def): Update.
7804
7805 2019-06-25  Tom Tromey  <tom@tromey.com>
7806
7807         * tui/tui-wingeneral.c (tui_refresh_all): Update.
7808         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7809         (tui_source_window_base::set_new_height): Update.
7810         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7811         Update.
7812         (tui_set_locator_fullname, tui_set_locator_info)
7813         (tui_show_frame_info): Update.
7814         * tui/tui-source.c (tui_set_source_content)
7815         (tui_source_is_displayed): Update.
7816         * tui/tui-layout.c (show_source_disasm_command, show_data)
7817         (show_source_or_disasm_and_command): Update.
7818         * tui/tui-disasm.c (tui_set_disassem_content)
7819         (tui_get_begin_asm_address): Update.
7820         * tui/tui-data.h (struct tui_locator_element): Remove.
7821         (union tui_which_element) <locator>: Remove.
7822         (struct tui_locator_window): New.
7823         (tui_locator_win_info_ptr): Change return type.
7824         * tui/tui-data.c (_locator): Change type.
7825         (tui_locator_win_info_ptr): Change return type.
7826         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
7827         (tui_alloc_content): Add assert.
7828
7829 2019-06-25  Tom Tromey  <tom@tromey.com>
7830
7831         * tui/tui-winsource.c
7832         (tui_exec_info_window::maybe_allocate_content): New method.
7833         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7834         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7835         (make_source_or_disasm_window): Add cast.
7836         * tui/tui-data.h (union tui_which_element) <simple_string>:
7837         Remove.
7838         (struct tui_source_info): New.
7839         (struct tui_source_window_base) <execution_info>: Change type.
7840         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7841         case, and add assert.
7842         (tui_alloc_content): Add assert.
7843
7844 2019-06-25  Tom Tromey  <tom@tromey.com>
7845
7846         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7847         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7848         * tui/tui-data.c (tui_alloc_win_info): Remove.
7849
7850 2019-06-25  Tom Tromey  <tom@tromey.com>
7851
7852         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7853         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7854         can_highlight.
7855
7856 2019-06-25  Tom Tromey  <tom@tromey.com>
7857
7858         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7859         make_visible_with_new_height method.
7860         (tui_win_info::make_visible_with_new_height): New method.
7861         (tui_source_window_base::do_make_visible_with_new_height)
7862         (tui_data_window::do_make_visible_with_new_height)
7863         (tui_cmd_window::do_make_visible_with_new_height): New methods.
7864         (make_visible_with_new_height): Remove.
7865         (tui_resize_all, tui_adjust_win_heights): Use
7866         make_visible_with_new_height method.
7867         * tui/tui-data.h (struct tui_win_info)
7868         <do_make_visible_with_new_height, make_visible_with_new_height>:
7869         New methods.
7870         (struct tui_source_window_base, struct tui_data_window)
7871         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7872         methods.
7873
7874 2019-06-25  Tom Tromey  <tom@tromey.com>
7875
7876         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7877         method.
7878         (update_tab_width): Call update_tab_width method.
7879         * tui/tui-data.h (struct tui_win_info)
7880         (struct tui_source_window_base) <update_tab_width>: New methods.
7881
7882 2019-06-25  Tom Tromey  <tom@tromey.com>
7883
7884         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7885         parameter.
7886         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7887         parameter.
7888         (tui_gen_win_info::make_visible): Update.
7889         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7890         parameter.
7891         * tui/tui-data.h (enum tui_box): New enum.
7892         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7893
7894 2019-06-25  Tom Tromey  <tom@tromey.com>
7895
7896         * tui/tui-layout.c (make_source_or_disasm_window): Always use
7897         init_and_make_win for EXEC_INFO_WIN.
7898         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7899         longer inline.
7900         (struct tui_win_info) <~tui_win_info>: Inline.
7901         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7902         Don't declare.
7903         * tui/tui-data.c (source_win, disasm_win): Remove globals.
7904         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7905         Remove.
7906         (tui_initialize_static_data): Update.
7907         (~tui_gen_win_info): Handle more cleanup here.
7908         (~tui_source_window_base): Delete "execution_info".
7909         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7910
7911 2019-06-25  Tom Tromey  <tom@tromey.com>
7912
7913         * tui/tui-layout.c (make_command_window): Don't set
7914         can_highlight.
7915         (show_source_disasm_command): Call the reset method.
7916         (show_data): Don't set can_highlight.  Call the reset method.
7917         (tui_gen_win_info::reset): Rename from init_gen_win_info
7918         (init_and_make_win): Simplify.  Return tui_gen_win_info.
7919         (show_source_or_disasm_and_command): Call the reset method.
7920         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7921         (struct tui_cmd_window): Set can_highlight.
7922
7923 2019-06-25  Tom Tromey  <tom@tromey.com>
7924
7925         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
7926         from make_visible.
7927         (tui_make_visible, tui_make_invisible): Rewrite.
7928         (tui_win_info::make_visible): Remove.
7929         (tui_source_window_base::make_visible): Update.
7930         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
7931         method.  Moved from...
7932         (struct tui_win_info) <make_visible>: ...here.
7933
7934 2019-06-25  Tom Tromey  <tom@tromey.com>
7935
7936         * tui/tui-winsource.c
7937         (tui_source_window_base::do_scroll_horizontal): Remove direction
7938         parameter.
7939         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
7940         direction parameter.
7941         * tui/tui-win.c (tui_win_info::forward_scroll)
7942         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7943         (tui_win_info::right_scroll): Update.
7944         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
7945         direction parameter.
7946         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
7947         direction parameter.
7948         * tui/tui-data.h (enum tui_scroll_direction): Remove.
7949         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
7950         Remove direction parameter.
7951         (struct tui_source_window_base, struct tui_source_window)
7952         (struct tui_disasm_window, struct tui_data_window)
7953         (struct tui_cmd_window): Update.
7954
7955 2019-06-25  Tom Tromey  <tom@tromey.com>
7956
7957         * tui/tui-winsource.h (tui_set_exec_info_content)
7958         (tui_show_exec_info_content, tui_erase_exec_info_content)
7959         (tui_clear_exec_info_content, tui_update_exec_info): Change
7960         argument to tui_source_window_base.
7961         * tui/tui-winsource.c (tui_set_exec_info_content)
7962         (tui_show_exec_info_content, tui_erase_exec_info_content)
7963         (tui_clear_exec_info_content, tui_update_exec_info): Change
7964         argument to tui_source_window_base.
7965
7966 2019-06-25  Tom Tromey  <tom@tromey.com>
7967
7968         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
7969         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
7970
7971 2019-06-25  Tom Tromey  <tom@tromey.com>
7972
7973         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
7974         check.
7975
7976 2019-06-25  Tom Tromey  <tom@tromey.com>
7977
7978         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
7979         type to void.
7980         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
7981         type to void.
7982         * tui/tui-source.c (tui_set_source_content): Update.
7983         * tui/tui-disasm.c (tui_set_disassem_content): Update.
7984
7985 2019-06-25  Tom Tromey  <tom@tromey.com>
7986
7987         * tui/tui-win.c (window_name_completer, tui_set_focus)
7988         (tui_all_windows_info): Use name method.
7989         * tui/tui-data.h (struct tui_gen_win_info)
7990         (struct tui_source_window, struct tui_disasm_window)
7991         (struct tui_data_window, struct tui_cmd_window) <name>: New
7992         method.
7993         (tui_win_name): Don't declare.
7994         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
7995         (tui_win_name): Remove.
7996
7997 2019-06-25  Tom Tromey  <tom@tromey.com>
7998
7999         * tui/tui-winsource.h (tui_update_source_window)
8000         (tui_update_source_window_as_is): Change parameter type.
8001         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8002         to be a tui_source_window_base.
8003         (tui_update_source_window_as_is): Likewise.
8004         * tui/tui-win.c (make_visible_with_new_height): Update.
8005
8006 2019-06-25  Tom Tromey  <tom@tromey.com>
8007
8008         * tui/tui-winsource.c (tui_erase_source_content)
8009         (tui_show_source_content, tui_show_exec_info_content)
8010         (tui_erase_exec_info_content): Use refresh_window method.
8011         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8012         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8013         from tui_refresh_win.
8014         (tui_data_window::refresh_window): New method.
8015         (tui_win_info::refresh, tui_source_window_base::refresh)
8016         (tui_refresh_all): Use refresh_window method.
8017         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8018         method.
8019         * tui/tui-regs.c (tui_display_register): Call refresh_window
8020         method.
8021         * tui/tui-layout.c (show_source_disasm_command)
8022         (show_source_or_disasm_and_command): Call refresh_window method.
8023         * tui/tui-data.h (struct tui_gen_win_info)
8024         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8025         New method.
8026
8027 2019-06-25  Tom Tromey  <tom@tromey.com>
8028
8029         * tui/tui.c (tui_rl_other_window, tui_enable)
8030         (tui_is_window_visible, tui_get_command_dimension): Update.
8031         * tui/tui-winsource.c (tui_update_source_window_as_is)
8032         (tui_clear_source_content, tui_erase_source_content)
8033         (tui_show_source_line, tui_source_window_base::refill)
8034         (tui_source_window_base::do_scroll_horizontal)
8035         (tui_source_window_base::set_is_exec_point_at)
8036         (tui_update_breakpoint_info, tui_set_exec_info_content)
8037         (tui_alloc_source_buffer, tui_line_is_displayed)
8038         (tui_addr_is_displayed): Update.
8039         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8040         (tui_check_and_display_highlight_if_needed)
8041         (tui_win_info::make_visible, tui_win_info::refresh)
8042         (tui_refresh_all): Update.
8043         * tui/tui-windata.c (tui_first_data_item_displayed)
8044         (tui_delete_data_content_windows, tui_erase_data_content)
8045         (tui_display_all_data, tui_data_window::refresh_all)
8046         (tui_check_data_values): Update.
8047         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8048         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8049         (tui_win_info::backward_scroll, tui_refresh_all_win)
8050         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8051         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8052         (tui_source_window_base::set_new_height)
8053         (tui_data_window::set_new_height)
8054         (make_invisible_and_set_new_height)
8055         (make_visible_with_new_height, new_height_ok)
8056         (parse_scrolling_args): Update.
8057         * tui/tui-stack.c (tui_show_frame_info): Update.
8058         * tui/tui-source.c (tui_set_source_content)
8059         (tui_set_source_content_nil, tui_source_is_displayed)
8060         (tui_source_window::do_scroll_vertical): Update.
8061         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8062         (tui_display_registers_from, tui_display_reg_element_at_line)
8063         (tui_check_register_values, tui_reg_command): Update.
8064         * tui/tui-layout.c (tui_default_win_height)
8065         (show_source_disasm_command, show_data, init_and_make_win)
8066         (show_source_or_disasm_and_command): Update.
8067         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8068         (tui_redisplay_readline, tui_mld_flush)
8069         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8070         (tui_getc): Update.
8071         * tui/tui-disasm.c (tui_set_disassem_content)
8072         (tui_disasm_window::do_scroll_vertical): Update.
8073         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8074         Now virtual.
8075         (struct tui_win_info): Derive from tui_gen_win_info.
8076         <~tui_win_info>: Mark as override.
8077         <generic>: Remove member.
8078         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8079         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8080         (~tui_data_window, ~tui_win_info)
8081         (tui_free_all_source_wins_content): Update.
8082         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8083
8084 2019-06-25  Tom Tromey  <tom@tromey.com>
8085
8086         * tui/tui-layout.c (init_and_make_win): Use new.
8087         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8088         destructor, initializers.
8089         (tui_alloc_generic_win_info): Don't declare.
8090         * tui/tui-data.c (_locator): Add argument to constructor.
8091         (source_win, disasm_win): New globals.
8092         (exec_info): Remove.
8093         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8094         Update.
8095         (tui_alloc_generic_win_info): Remove.
8096         (init_content_element): Use new.
8097         (tui_win_info::tui_win_info): Update.
8098         (free_content_elements) <case DATA_WIN>: Use delete.
8099
8100 2019-06-25  Tom Tromey  <tom@tromey.com>
8101
8102         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8103         * tui/tui-windata.c (tui_first_data_item_displayed)
8104         (tui_delete_data_content_windows): Update.
8105         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8106         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8107         (tui_display_registers_from, tui_check_register_values): Update.
8108         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8109         pointer.
8110         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8111         window.
8112         (tui_free_data_content): Update.
8113         (free_content_elements) <case DATA_WIN>: Free the window.
8114
8115 2019-06-25  Tom Tromey  <tom@tromey.com>
8116
8117         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8118         Update.
8119         * tui/tui-layout.c (make_command_window)
8120         (show_source_disasm_command, show_data, init_and_make_win)
8121         (show_source_or_disasm_and_command): Update.
8122         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8123         method.
8124         <can_highight, is_highlighted>: Now bool.
8125         (tui_set_win_highlight): Don't declare.
8126         * tui/tui-data.c (tui_set_win_highlight): Remove.
8127
8128 2019-06-25  Tom Tromey  <tom@tromey.com>
8129
8130         * tui/tui-wingeneral.c (make_visible): Remove check of window
8131         type.
8132
8133 2019-06-25  Tom Tromey  <tom@tromey.com>
8134
8135         * tui/tui-win.c (tui_win_info::max_height)
8136         (tui_cmd_window::max_height): New methods.
8137         (new_height_ok): Call max_height.
8138         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8139         <max_height>: New method.
8140
8141 2019-06-25  Tom Tromey  <tom@tromey.com>
8142
8143         * tui/tui-win.c (tui_source_window_base::set_new_height)
8144         (tui_data_window::set_new_height): New methods.
8145         (make_invisible_and_set_new_height): Call set_new_height method.
8146         * tui/tui-data.h (struct tui_win_info)
8147         (struct tui_source_window_base, struct tui_data_window)
8148         <set_new_height>: New method.
8149
8150 2019-06-25  Tom Tromey  <tom@tromey.com>
8151
8152         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8153         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8154         tui_refresh_data_win.
8155         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8156         method.
8157         (tui_refresh_all_win): Call the refresh_all method.
8158         (tui_set_focus): Likewise.
8159         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8160         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8161         Likewise.
8162
8163 2019-06-25  Tom Tromey  <tom@tromey.com>
8164
8165         * tui/tui-winsource.h (tui_refill_source_window)
8166         (tui_set_is_exec_point_at): Don't declare.
8167         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8168         (tui_source_window_base::refill): Rename from
8169         tui_refill_source_window.
8170         (tui_source_window_base::do_scroll_horizontal): Update.
8171         (tui_source_window_base::set_is_exec_point_at): Rename from
8172         tui_set_is_exec_point_at.
8173         (tui_update_all_breakpoint_info): Update.
8174         * tui/tui-stack.c (tui_show_frame_info): Update.
8175         * tui/tui-layout.c (show_data): Add cast.
8176         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8177         * tui/tui-data.h (struct tui_source_window_base) <refill,
8178         set_is_exec_point_at>: New methods.
8179         (tui_source_windows, tui_add_to_source_windows): Update types.
8180         (tui_add_to_source_windows): Remove redundant declaration.
8181         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8182         (tui_source_windows): Change return type.
8183         (tui_clear_source_windows_detail): Update.
8184         (tui_add_to_source_windows): Change type of parameter.
8185         (tui_free_all_source_wins_content): Update.
8186
8187 2019-06-25  Tom Tromey  <tom@tromey.com>
8188
8189         * tui/tui-wingeneral.c (tui_win_info::refresh)
8190         (tui_source_window_base::refresh): New methods.
8191         (tui_refresh_all): Call the refresh method.
8192         * tui/tui-data.h (struct tui_win_info)
8193         (struct tui_source_window_base) <refresh>: New method.
8194
8195 2019-06-25  Tom Tromey  <tom@tromey.com>
8196
8197         * tui/tui.h (tui_is_window_visible): Return bool.
8198         * tui/tui.c (tui_is_window_visible): Return bool.
8199         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8200         (tui_make_visible, tui_make_invisible)
8201         (tui_win_info::make_visible)
8202         (tui_source_window_base::make_visible, make_all_visible)
8203         (tui_make_all_visible, tui_make_all_invisible): Update.
8204         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8205         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8206         bool.
8207         (struct tui_win_info, struct tui_source_window_base)
8208         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8209         * tui/tui-data.c (tui_init_generic_part): Update.
8210
8211 2019-06-25  Tom Tromey  <tom@tromey.com>
8212
8213         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8214         (tui_source_window_base::make_visible): New methods.
8215         (make_all_visible): Make method call.
8216         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8217         (struct tui_source_window_base, struct tui_cmd_window): Override
8218         make_visible.
8219         (tui_win_is_source_type): Don't declare.
8220         * tui/tui-data.c (tui_win_is_source_type): Remove.
8221
8222 2019-06-25  Tom Tromey  <tom@tromey.com>
8223
8224         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8225         NULL check.
8226
8227 2019-06-25  Tom Tromey  <tom@tromey.com>
8228
8229         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8230         Inline constructor.  Add initializers for members.
8231         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8232         constructors; now inline in class.
8233
8234 2019-06-25  Tom Tromey  <tom@tromey.com>
8235
8236         * tui/tui-regs.c (tui_show_registers): Update.
8237         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8238         bool.
8239         * tui/tui-data.c (tui_data_window::clear_detail)
8240         (tui_data_window): Update.
8241
8242 2019-06-25  Tom Tromey  <tom@tromey.com>
8243
8244         * tui/tui-windata.c (tui_display_all_data)
8245         (tui_display_data_from_line, tui_display_data_from)
8246         (tui_check_data_values, tui_data_window::do_scroll_vertical):
8247         Update.
8248         * tui/tui-regs.c (tui_last_regs_line_no)
8249         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8250         (tui_show_registers, tui_show_register_group)
8251         (tui_display_registers_from, tui_display_reg_element_at_line)
8252         (tui_display_registers_from_line, tui_check_register_values)
8253         (tui_reg_next, tui_reg_prev): Update.
8254         * tui/tui-layout.c (tui_set_layout, show_data): Update.
8255         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
8256         tui_data_window.
8257         (struct tui_win_info) <detail>: Remove.  Add new fields from
8258         tui_data_info.
8259         (TUI_DATA_WIN): Add cast.
8260         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8261         (~tui_data_window): Simplify.
8262
8263 2019-06-25  Tom Tromey  <tom@tromey.com>
8264
8265         * tui/tui-layout.c (show_source_disasm_command)
8266         (show_source_or_disasm_and_command): Update.
8267         * tui/tui-io.c (update_cmdwin_start_line)
8268         (tui_redisplay_readline): Update.
8269         * tui/tui-data.h (struct tui_command_info): Remove.
8270         (struct tui_win_info) <detail>: Remove command_info member.
8271         (struct tui_data_window) <start_line>: New member, from
8272         tui_command_info.
8273         (TUI_CMD_WIN): Add casts.
8274
8275 2019-06-25  Tom Tromey  <tom@tromey.com>
8276
8277         * tui/tui-winsource.c (tui_update_source_window)
8278         (tui_refill_source_window)
8279         (tui_source_window_base::do_scroll_horizontal)
8280         (tui_update_breakpoint_info, tui_set_exec_info_content)
8281         (tui_show_exec_info_content, tui_erase_exec_info_content)
8282         (tui_clear_exec_info_content): Update.
8283         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8284         Update.
8285         * tui/tui-win.c (make_invisible_and_set_new_height)
8286         (make_visible_with_new_height): Update.
8287         * tui/tui-source.c (tui_set_source_content)
8288         (tui_show_symtab_source): Update.
8289         * tui/tui-layout.c (extract_display_start_addr)
8290         (show_source_disasm_command, show_data)
8291         (make_source_or_disasm_window)
8292         (show_source_or_disasm_and_command): Update.
8293         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8294         (tui_disasm_window::do_scroll_vertical): Remove shadowing
8295         "gdbarch".
8296         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
8297         to tui_source_window_base.
8298         (struct tui_win_info) <detail>: Remove source_info member.
8299         (struct tui_source_window_base) <has_locator>: Inline.
8300         Move contents from tui_source_info; rename has_locator member to
8301         m_has_locator.
8302         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8303         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8304         header file.
8305         (tui_source_window_base::clear_detail, ~tui_source_window_base):
8306         Simplify.
8307         (tui_free_all_source_wins_content): Cast to
8308         tui_source_window_base.
8309
8310 2019-06-25  Tom Tromey  <tom@tromey.com>
8311
8312         * tui/tui-win.c (make_invisible_and_set_new_height)
8313         (make_visible_with_new_height): Call has_locator method.
8314         * tui/tui-layout.c (show_source_disasm_command, show_data)
8315         (show_source_or_disasm_and_command): Update for bool change.
8316         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8317         (tui_win_info) <has_locator>: New method.
8318         (struct tui_source_window_base) <has_locator>: New method.
8319         (tui_win_has_locator): Don't declare.
8320         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8321         from tui_win_has_locator.
8322         (tui_source_window_base): Use false, not FALSE.
8323
8324 2019-06-25  Tom Tromey  <tom@tromey.com>
8325
8326         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8327         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8328         clear_detail method directly.
8329         (tui_clear_win_detail): Remove.
8330
8331 2019-06-25  Tom Tromey  <tom@tromey.com>
8332
8333         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8334         "this", not TUI_DISASM_WIN.
8335
8336 2019-06-25  Tom Tromey  <tom@tromey.com>
8337
8338         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
8339         declare.
8340         * tui/tui-winsource.c
8341         (tui_source_window_base::do_scroll_horizontal): Rename from
8342         tui_horizontal_source_scroll.
8343         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8344         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8345         from tui_vertical_data_scroll.
8346         * tui/tui-win.h (tui_scroll): Don't declare.
8347         * tui/tui-win.c (tui_win_info::forward_scroll)
8348         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8349         (tui_win_info::right_scroll): Rename and update.
8350         (tui_scroll_forward_command, tui_scroll_backward_command)
8351         (tui_scroll_left_command, tui_scroll_right_command): Update.
8352         (tui_scroll): Remove.
8353         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8354         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8355         from tui_vertical_source_scroll.
8356         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8357         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8358         from tui_vertical_disassem_scroll.
8359         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8360         do_scroll_horizontal>: New methods.
8361         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8362         Likewise.
8363         (struct tui_source_window_base): Add do_scroll_horizontal.
8364         (struct tui_source_window, struct tui_disasm_window): Add
8365         do_scroll_vertical.
8366         (struct tui_data_window, struct tui_cmd_window): Add
8367         do_scroll_horizontal and do_scroll_vertical.
8368         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8369
8370 2019-06-25  Tom Tromey  <tom@tromey.com>
8371
8372         * tui/tui-data.h (struct tui_source_window_base): New struct.
8373         (struct tui_source_window): Derive from tui_source_window_base.
8374         (struct tui_disasm_window): New struct.
8375         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8376         from tui_source_window::clear_detail.
8377         (tui_source_window_base): Rename from tui_source_window.
8378         (~tui_source_window_base): Rename from ~tui_source_window.
8379         (tui_alloc_win_info): Create a tui_disasm_window.
8380
8381 2019-06-25  Tom Tromey  <tom@tromey.com>
8382
8383         * tui/tui-data.h (struct tui_source_window)
8384         (struct tui_data_window): Declare destructors.
8385         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8386         destructors.
8387         (tui_win_info): Simplify.
8388
8389 2019-06-25  Tom Tromey  <tom@tromey.com>
8390
8391         * tui/tui-winsource.c (tui_display_main)
8392         (tui_update_source_windows_with_addr)
8393         (tui_update_all_breakpoint_info): Update.
8394         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8395         (new_height_ok, parse_scrolling_args): Update.
8396         * tui/tui-stack.c (tui_show_frame_info): Update.
8397         * tui/tui-data.h (struct tui_list): Remove.
8398         (tui_source_windows): Return a reference to a std::vector.
8399         * tui/tui-data.c (source_windows): Now a std::vector.
8400         (tui_source_windows): Change return type.
8401         (tui_clear_source_windows): Rewrite.
8402         (tui_clear_source_windows_detail, tui_add_to_source_windows)
8403         (tui_free_all_source_wins_content): Rewrite.
8404
8405 2019-06-25  Tom Tromey  <tom@tromey.com>
8406
8407         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8408         (struct tui_data_window, struct tui_cmd_window): Declare
8409         clear_detail method.
8410         * tui/tui-data.c (tui_source_window::clear_detail)
8411         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8412         methods.
8413         (tui_clear_win_detail): Simplify.
8414
8415 2019-06-25  Tom Tromey  <tom@tromey.com>
8416
8417         * tui/tui-layout.c (make_source_window, make_disasm_window)
8418         (make_source_or_disasm_window): Remove win_info_ptr parameter.
8419         Return the new window.
8420         (show_source_disasm_command, show_data)
8421         (show_source_or_disasm_and_command): Update.
8422
8423 2019-06-25  Tom Tromey  <tom@tromey.com>
8424
8425         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8426         parameter.  Return the new window.
8427         (show_source_disasm_command): Update and remove NULL check.
8428         (show_source_or_disasm_and_command): Update.
8429
8430 2019-06-25  Tom Tromey  <tom@tromey.com>
8431
8432         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8433
8434 2019-06-25  Tom Tromey  <tom@tromey.com>
8435
8436         * tui/tui-data.h (struct tui_win_info): Make constructor
8437         protected.  Make destructor virtual.  Add initializers.
8438         (tui_source_window, tui_data_window, tui_cmd_window): New
8439         classes.
8440         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
8441         constructor.  Add "type" parameter.
8442         (tui_source_window, tui_data_window, tui_cmd_window): New
8443         constructors.
8444         (tui_alloc_win_info): Instantiate the appropriate subclass.
8445
8446 2019-06-25  Tom Tromey  <tom@tromey.com>
8447
8448         * tui/tui-win.c (tui_resize_all): Use delete.
8449         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8450         destructor.
8451         (tui_free_window): Don't declare.
8452         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8453         Update.
8454
8455 2019-06-25  Tom Tromey  <tom@tromey.com>
8456
8457         * tui/tui-data.h (struct tui_win_info): Add constructor.
8458         * tui/tui-data.c (tui_alloc_win_info): Use new.
8459         (tui_free_window): Use delete.
8460
8461 2019-06-22  Tom Tromey  <tom@tromey.com>
8462
8463         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8464         declare.
8465         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8466
8467 2019-06-22  Tom Tromey  <tom@tromey.com>
8468
8469         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8470         declare.
8471         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8472
8473 2019-06-22  Tom de Vries  <tdevries@suse.de>
8474
8475         * dwarf2read.c (create_addrmap_from_aranges)
8476         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8477         instead of '%zu'.
8478
8479 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
8480
8481         * dwarf2read.h (dwarf2_section_info_def): Remove.
8482         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8483         * dwarf2read.c (struct dwo_sections) <types>: Change type to
8484         std::vector<dwarf2_section_info>.
8485         (struct dwo_file) <~dwo_file>: Remove.
8486         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8487         types field.
8488         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8489         (dwarf2_read_debug_names): Likewise.
8490         (create_debug_types_hash_table): Change parameter type to
8491         array_view, adjust code accordingly.
8492         (dwarf2_locate_dwo_sections): Adjust to std::vector.
8493         (partial_die_info::fixup): Likewise.
8494         (determine_prefix): Likewise.
8495         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8496
8497 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8498
8499         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8500         gdb_bfd_ref_ptr.
8501         <~dwo_file>: Remove call to gdb_bfd_unref.
8502         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8503         gdb_bfd_ref_ptr::get.
8504
8505 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8506
8507         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8508         type to htab_up.
8509         * dwarf2read.c (struct dwo_file): Initialize fields.
8510         <~dwo_file>: New.
8511         (free_dwo_file): Remove, move content to ~dwo_file.
8512         (struct dwo_file_deleter): Remove.
8513         (dwo_file_up>: Remove custom deleter.
8514         (free_dwo_files): Remove.
8515         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8516         dwo_files.
8517         (process_skeletonless_type_units): Call unique_ptr::get.
8518         (allocate_dwo_file_hash_table): Add deleter to created hash
8519         table.  Change return type to htab_up.
8520         (lookup_dwo_file_slot): Don't memset dwo_file, call
8521         unique_ptr::get.
8522         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8523         (create_dwo_unit_in_dwp_v2): Likewise.
8524         (open_and_init_dwo_file): Likewise.
8525         (free_dwo_file_from_slot): Remove.
8526
8527 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8528
8529         * dwarf2read.h (struct dwarf2_section_info) <readin,
8530         is_virtual>: Change type to bool.
8531         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8532         true instead of 1.
8533
8534 2019-06-19  Tom Tromey  <tom@tromey.com>
8535
8536         * tui/tui-data.h (tui_init_content_element): Don't declare.
8537
8538 2019-06-19  Tom Tromey  <tom@tromey.com>
8539
8540         * tui/tui-data.h (tui_init_win_info): Don't declare.
8541
8542 2019-06-19  Tom de Vries  <tdevries@suse.de>
8543
8544         * dwarf2read.h (abstract_to_concrete): Change type to
8545         std::unordered_map<sect_offset, std::vector<sect_offset>,
8546         gdb::hash_enum<sect_offset>>.
8547
8548 2019-06-19  Tom Tromey  <tromey@adacore.com>
8549
8550         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8551         EVAL_AVOID_SIDE_EFFECTS specially.
8552
8553 2019-06-19  Tom Tromey  <tromey@adacore.com>
8554
8555         * source-cache.c (highlighter): New global.
8556         (source_cache::get_source_lines): Create a highlighter on demand.
8557
8558 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8559
8560         * defs.h (deprecated_interactive_hook): Delete declaration.
8561         * interps.c (clear_interpreter_hooks): Remove use of
8562         deprecated_interactive_hook.
8563         * top.c (deprecated_interactive_hook): Delete definition.
8564         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8565
8566 2019-06-18  Tom de Vries  <tdevries@suse.de>
8567
8568         PR gdb/24515
8569         * dwarf2read.h (abstract_to_concrete): Change type from
8570         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8571         std::unordered_map<sect_offset, std::vector<sect_offset>>.
8572         * dwarf2read.c (read_variable): Update.
8573         (dwarf2_fetch_die_loc_sect_off): Update.
8574
8575 2019-06-17  Tom de Vries  <tdevries@suse.de>
8576
8577         PR gdb/24617
8578         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8579         accessing parent[parent_len - 1].
8580
8581 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
8582
8583         PR gdb/24364
8584         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8585         call dtrace_process_dof with NULL dof.
8586
8587 2019-06-16  Tom de Vries  <tdevries@suse.de>
8588
8589         PR gdb/24445
8590         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8591
8592 2019-06-16  Tom Tromey  <tom@tromey.com>
8593
8594         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8595         (make_all_visible): Use address of member.
8596
8597 2019-06-16  Tom Tromey  <tom@tromey.com>
8598
8599         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8600         (tui_free_window, free_content, free_content_elements): Remove
8601         unnecessary cast.
8602         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8603         cast.
8604         * tui/tui-regs.c (tui_show_register_group)
8605         (tui_display_registers_from, tui_display_reg_element_at_line):
8606         Remove unnecessary cast.
8607
8608 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
8609
8610         * linux-nat.c (normal_mask): Delete.
8611         (_initialize_linux_nat): Don't initialise normal_mask.
8612
8613 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
8614
8615         PR gdb/24445
8616         * dwarf-index-write.h (write_psymtabs_to_index): Add
8617         dwz_basename parameter.
8618         * dwarf-index-write.c (write_gdbindex): Move file writing to
8619         write_gdbindex_1.  Change return type void.
8620         (assert_file_size): Move up, remove filename parameter.
8621         (write_gdbindex_1): New function.
8622         (write_debug_names): Change return type to void, call
8623         assert_file_size.
8624         (struct index_wip_file): New struct.
8625         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
8626         file logic to index_wip_file.  Write index for dwz file if
8627         needed.
8628         (save_gdb_index_command): Pass basename of dwz file, if present.
8629         * dwarf-index-cache.c (index_cache::store): Obtain and pass
8630         build-id of dwz file, if present.
8631         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8632         (dwarf2_get_dwz_file): Likewise.
8633         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8634         (dwarf2_get_dwz_file): Likewise.
8635
8636 2019-06-16  Tom Tromey  <tom@tromey.com>
8637
8638         * coffread.c (process_coff_symbol): Use xstrdup.
8639         * value.c (create_internalvar): Use xstrdup.
8640
8641 2019-06-16  Tom Tromey  <tom@tromey.com>
8642
8643         * valops.c (value_cast, value_slice): Remove unnecessary cast.
8644         * breakpoint.c (stopin_command, stopat_command)
8645         (until_break_command, decode_location_default): Remove unnecessary
8646         cast.
8647         * utils.c (subset_compare): Remove unnecessary cast.
8648         * ada-lang.c (ada_update_initial_language): Remove unnecessary
8649         cast.
8650         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8651         cast.
8652         * infcmd.c (path_command): Remove unnecessary cast.
8653         * coffread.c (decode_type): Remove unnecessary cast.
8654         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8655         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8656         * tui/tui-stack.c (tui_show_locator_content)
8657         (tui_show_frame_info): Remove unnecessary cast.
8658         * tui/tui-win.c (tui_scroll_forward_command)
8659         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8660         (parse_scrolling_args): Remove unnecessary cast.
8661         * tui/tui-data.c (init_win_info, tui_del_window)
8662         (tui_free_window, tui_del_data_windows, tui_free_data_content)
8663         (free_content_elements): Remove unnecessary cast.
8664         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8665         unnecessary cast.
8666         * tui/tui-source.c (tui_set_source_content)
8667         (tui_vertical_source_scroll): Remove unnecessary cast.
8668         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8669         cast.
8670         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8671         * tui/tui-regs.c (tui_display_registers_from)
8672         (tui_display_register): Remove unnecessary cast.
8673         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8674         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8675         (make_visible): Remove unnecessary cast.
8676         * tui/tui-winsource.c (tui_erase_source_content)
8677         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8678         unnecessary cast.
8679         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8680         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8681         * stabsread.c (read_type, read_array_type, read_range_type):
8682         Remove unnecessary cast.
8683         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8684         (parse_symbol, parse_type, upgrade_type, parse_external)
8685         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8686         unnecessary cast.
8687         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8688
8689 2019-06-16  Tom Tromey  <tom@tromey.com>
8690
8691         * tui/tui-data.c (tui_alloc_generic_win_info)
8692         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8693         checks.
8694
8695 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
8696             Andrew Burgess  <andrew.burgess@embecosm.com>
8697
8698         * f-typeprint.c (f_print_type): Don't return early for not
8699         associated or not allocated types.
8700         (f_type_print_varspec_suffix): Add print_rank parameter and print
8701         ranks of array types in case they dangling.
8702         (f_type_print_base): Add print_rank parameter.
8703
8704 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8705
8706         * NEWS: Mention new MI commands.
8707         * break-catch-throw.c (enum exception_event_kind): Move to
8708         breakpoint.h.
8709         (print_mention_exception_catchpoint): Output text as a single
8710         message.
8711         (catch_exception_command_1): Rename to...
8712         (catch_exception_event): ...this, make non-static, update header
8713         command, and change some parameter types.
8714         (catch_catch_command): Update for changes to
8715         catch_exception_command_1.
8716         (catch_throw_command): Likewise.
8717         (catch_rethrow_command): Likewise.
8718         * breakpoint.c (enum exception_event_kind): Delete.
8719         * breakpoint.h (enum exception_event_kind): Moved here from
8720         break-catch-throw.c.
8721         (catch_exception_event): Declare.
8722         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8723         (mi_cmd_catch_throw): New function.
8724         (mi_cmd_catch_rethrow): New function.
8725         (mi_cmd_catch_catch): New function.
8726         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8727         'catch-catch' entries.
8728         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8729         (mi_cmd_catch_rethrow): Declare.
8730         (mi_cmd_catch_catch): Declare.
8731
8732 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8733
8734         * annotate.c (annotate_source_line): Change return type to void,
8735         update implementation to match.
8736         * annotate.h (annotate_source_line): Change return type to void,
8737         update header comment.
8738         * stack.c (print_frame_info): Don't change what frame information
8739         is printed based on whether annotations are on or not.
8740
8741 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8742
8743         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8744         (annotate_source): Make static.
8745         (annotate_source_line): Moved from source.c and renamed from
8746         identify_source_line.  Update the return type.
8747         * annotate.h (annotate_source): Delete declaration.
8748         (annotate_source_line): Declaration moved from source.h, and
8749         renamed from identify_source_line.  Return type updated.
8750         * source.c (identify_source_line): Moved to annotate.c and renamed
8751         to annotate_source_line.
8752         (info_line_command): Remove check of annotation_level.
8753         * source.h (identify_source_line): Move declaration to annotate.h
8754         and rename to annotate_source_line.
8755         * stack.c: Add 'annotate.h' include.
8756         (print_frame_info): Remove check of annotation_level before
8757         calling annotate_source_line.
8758
8759 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8760
8761         * source-cache.c (source_cache::get_plain_source_lines): Use
8762         open_source_file_with_line_charpos instead of just
8763         open_source_file, remove call to find_source_lines.
8764         (source_cache::get_source_lines): Likewise.
8765         * source.c (find_source_lines): Make static.
8766         (get_filename_and_charpos): Renamed into...
8767         (open_source_file_with_line_charpos): ..this along with changes to
8768         return a scoped_fd, and some other minor clean ups.
8769         (identify_source_line): Use open_source_file_with_line_charpos.
8770         (search_command_helper): Use open_source_file_with_line_charpos
8771         instead of just open_source_file, remove call to
8772         find_source_lines.
8773         * source.h (open_source_file_with_line_charpos): Declare new
8774         function.
8775         (find_source_lines): Delete declaration.
8776
8777 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8778
8779         * source.c (get_filename_and_charpos): Remove fullname
8780         parameter.
8781         (identify_source_line): Update call to get_filename_and_charpos.
8782
8783 2019-06-14  Tom Tromey  <tromey@adacore.com>
8784
8785         PR gdb/24502:
8786         * ui-style.h (skip_ansi_escape): Update comment.
8787         * ui-file.h (class no_terminal_escape_file): New class.
8788         * ui-file.c (no_terminal_escape_file::write)
8789         (no_terminal_escape_file::puts): New methods.
8790         * cli/cli-logging.c (handle_redirections): Use
8791         no_terminal_escape_file.
8792
8793 2019-06-14  Tom Tromey  <tromey@adacore.com>
8794
8795         * NEWS: Move convenience variable news above Python news.
8796
8797 2019-06-14  Tom Tromey  <tom@tromey.com>
8798
8799         * gnulib: Move directory to top-level.
8800         * configure.ac: Don't configure gnulib.
8801         * configure: Rebuild.
8802         * common/common-defs.h: Use new path to gnulib.
8803         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8804         (GNULIB_H): Remove.
8805         (INCGNU): Look in new gnulib location.
8806         (HFILES_NO_SRCDIR): Remove gnulib files.
8807         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8808         (generated_files): Remove GNULIB_H.
8809         ($(LIBGNU), all-lib): Remove targets.
8810         (distclean): Don't mention GNULIB_BUILDDIR.
8811         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8812
8813 2019-06-14  Tom Tromey  <tromey@adacore.com>
8814
8815         * symfile.c (add_symbol_file_command): Remove obsolete comment.
8816         Warn if symbol file does not provide any symbols.
8817
8818 2019-06-14  Tom Tromey  <tromey@adacore.com>
8819
8820         * source.c (find_and_open_source): Respect basenames_may_differ.
8821
8822 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
8823
8824         * annotate.c (annotate_breakpoints_invalid): Make use of
8825         scoped_restore_terminal_state.
8826         (annotate_frames_invalid): Likewise.
8827
8828 2019-06-14  Tom Tromey  <tromey@adacore.com>
8829
8830         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8831         allow assignment to an internalvar.
8832
8833 2019-06-14  Tom Tromey  <tromey@adacore.com>
8834
8835         * ada-lex.l: Allow "_" in attribute names.
8836
8837 2019-06-14  Tom Tromey  <tromey@adacore.com>
8838
8839         PR gdb/24653:
8840         * regcache.c (registers_changed): Don't call alloca.
8841         * top.c (execute_command): Don't call alloca.
8842
8843 2019-06-13  Pedro Alves  <palves@redhat.com>
8844
8845         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8846         'expression'.  When parsing an expression, error out if there's
8847         junk after "unlimited".
8848         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8849         (do_set_command): Adjust calls to is_unlimited_literal.
8850
8851 2019-06-13  Pedro Alves  <palves@redhat.com>
8852
8853         * compile/compile.c (make_compile_options_def_group): Add braces
8854         around array_view initializer.
8855         * thread.c (make_thread_apply_all_options_def_group)
8856         (make_thread_apply_all_options_def_group): Likewise.
8857
8858 2019-06-13  Pedro Alves  <palves@redhat.com>
8859
8860         * NEWS (New commands): Mention "maint test-options
8861         require-delimiter", "maint test-options unknown-is-error", "maint
8862         test-options unknown-is-operand" and "maint show
8863         test-options-completion-result".
8864         (New command options, command completion): New section.
8865         (Completion improvements): New section.
8866         Mention that you can abbreviate "unlimited".
8867
8868 2019-06-13  Pedro Alves  <palves@redhat.com>
8869
8870         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8871         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8872         * unittests/cli-utils-selftests.c (test_parse_flags)
8873         (test_parse_flags_qcs): Delete.
8874         (test_cli_utils): Don't call deleted functions.
8875
8876 2019-06-13  Pedro Alves  <palves@redhat.com>
8877
8878         * thread.c: Include "cli/cli-option.h".
8879         (tp_array_compar_ascending): Global.
8880         (tp_array_compar): Delete function.
8881         (tp_array_compar_ascending, tp_array_compar_descending): New
8882         functions.
8883         (ascending_option_def, qcs_flag_option_def)
8884         (thr_qcs_flags_option_defs)
8885         (make_thread_apply_all_options_def_group)
8886         (make_thread_apply_options_def_group): New.
8887         (thread_apply_all_command): Use gdb::option::process_options.
8888         (thread_apply_command_completer)
8889         (thread_apply_all_command_completer): New.
8890         (thread_apply_command): Use gdb::option::process_options.
8891         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8892         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
8893         to generate help text of "thread apply".  Adjust "taas"'s help.
8894         * tid-parse.c (tid_range_parser::in_thread_range): New method.
8895         * tid-parse.h (tid_range_parser::in_thread_range): New method.
8896
8897 2019-06-13  Pedro Alves  <palves@redhat.com>
8898
8899         * thread.c (thread_apply_command): Check for invalid TID with
8900         isdigit instead of !isalpha.
8901
8902 2019-06-13  Pedro Alves  <palves@redhat.com>
8903
8904         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8905         (validate_flags_qcs): New.
8906         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8907         (validate_flags_qcs): Declare.
8908         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8909         (make_frame_apply_options_def_group): New.
8910         (frame_apply_command_count): Process options with
8911         gdb::option::process_options.
8912         (frame_apply_completer): New.
8913         (frame_apply_level_completer, frame_apply_all_completer)
8914         (frame_apply_completer): New.
8915         (_initialize_stack): Update help of "frame apply", "frame apply
8916         level", "frame apply all" and "faas" to mention supported options
8917         and install command completers.
8918         * stack.h (frame_apply_all_completer): Declare.
8919         * thread.c: Include "stack.h".
8920         (tfaas_command): Add "--".
8921         (_initialize_thread): Update help "tfaas" to mention supported
8922         options and install command completer.
8923
8924 2019-06-13  Pedro Alves  <palves@redhat.com>
8925
8926         * completer.c (complete_nested_command_line): New.
8927         (gdb_completion_word_break_characters_throw): Add assertion.
8928         * completer.h (complete_nested_command_line): Declare.
8929
8930 2019-06-13  Pedro Alves  <palves@redhat.com>
8931
8932         * stack.c (parse_backtrace_qualifiers): New.
8933         (backtrace_command): Use it.
8934         (backtrace_command_completer): Complete on qualifiers.
8935
8936 2019-06-13  Pedro Alves  <palves@redhat.com>
8937
8938         * frame.c: Include "cli/cli-option.h.
8939         (user_set_backtrace_options): New.
8940         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
8941         Delete.
8942         (get_prev_frame): Adjust.
8943         (boolean_option_def, uinteger_option_def)
8944         (set_backtrace_option_defs): New.
8945         (_initialize_frame): Adjust and use
8946         gdb::option::add_setshow_cmds_for_options to install "set
8947         backtrace past-main" and "set backtrace past-entry".
8948         * frame.h: Include "cli/cli-option.h".
8949         (struct frame_print_options): Forward declare.
8950         (print_frame_arguments_all, print_frame_arguments_scalars)
8951         (print_frame_arguments_none): Declare.
8952         (print_entry_values): Delete declaration.
8953         (struct frame_print_options, user_frame_print_options): New.
8954         (struct set_backtrace_options): New.
8955         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
8956         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
8957         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
8958         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
8959         (list_args_or_locals): Add frame_print_options parameter.
8960         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8961         * python/py-framefilter.c (enumerate_args): Pass down
8962         USER_FRAME_PRINT_OPTIONS.
8963         * stack.c: Include "cli/cli-option.h".
8964         (print_frame_arguments_all, print_frame_arguments_scalars)
8965         (print_frame_arguments_none): Declare.
8966         (print_raw_frame_arguments, print_entry_values): Delete.
8967         (user_frame_print_options): New.
8968         (boolean_option_def, enum_option_def, frame_print_option_defs):
8969         New.
8970         (struct backtrace_cmd_options): New.
8971         (bt_flag_option_def): New.
8972         (backtrace_command_option_defs): New.
8973         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8974         (print_frame_arg, read_frame_arg, print_frame_args)
8975         (print_frame_info, print_frame): Add frame_print_options parameter
8976         and use it.
8977         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
8978         (backtrace_command_1): Add frame_print_options and
8979         backtrace_cmd_options parameters and use them.
8980         (make_backtrace_options_def_group): New.
8981         (backtrace_command): Process command options with
8982         gdb::option::process_options.
8983         (backtrace_command_completer): New.
8984         (_initialize_stack): Extend "backtrace"'s help to mention
8985         supported options.  Install completer for "backtrace".
8986         Install some settings commands with add_setshow_cmds_for_options.
8987
8988 2019-06-13  Pedro Alves  <palves@redhat.com>
8989
8990         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
8991         and that "set/show print raw frame-arguments" are now deprecated.
8992
8993         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
8994         command.
8995         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
8996         * stack.c (_initialize_stack): Install "set/show print
8997         raw-frame-arguments", and deprecate "set/show print raw
8998         frame-arguments".
8999         * valprint.c (_initialize_valprint): Deprecate "set/show print
9000         raw".
9001
9002 2019-06-13  Pedro Alves  <palves@redhat.com>
9003
9004         * compile/compile.c (struct compile_options): New.
9005         (compile_flag_option_def, compile_command_option_defs)
9006         (make_compile_options_def_group): New.
9007         (compile_file_command): Handle options with
9008         gdb::option::process_options.
9009         (compile_file_command_completer): New function.
9010         (compile_code_command): Handle options with
9011         gdb::option::process_options.
9012         (compile_code_command_completer): New function.
9013         (_initialize_compiler): Install completers for "compile code" and
9014         "compile file".  Mention available options in "compile code" and
9015         "compile code"'s help.
9016         * completer.c (advance_to_completion_word): New, factored out from
9017         ...
9018         (advance_to_expression_complete_word_point): ... this.
9019         (advance_to_filename_complete_word_point): New.
9020         * completer.h (advance_to_filename_complete_word_point): New
9021         declaration.
9022
9023 2019-06-13  Pedro Alves  <palves@redhat.com>
9024
9025         * compile/compile.c: Include "cli/cli-option.h".
9026         (compile_print_value): Scope data pointer is now a
9027         value_print_options pointer; adjust.
9028         (compile_print_command): Process options.  Scope data pointer is
9029         now a value_print_options pointer; adjust.
9030         (_initialize_compile): Update "compile print"'s help to include
9031         supported options.  Install a completer for "compile print".
9032         * cp-valprint.c (show_vtblprint, show_objectprint)
9033         (show_static_field_print): Delete.
9034         (_initialize_cp_valprint): Don't install "set print
9035         static-members", "set print vtbl", "set print object" here.
9036         * printcmd.c: Include "cli/cli-option.h" and
9037         "common/gdb_optional.h".
9038         (print_command_parse_format): Rework to fill in a
9039         value_print_options instead of a format_data.
9040         (print_value): Change parameter type from format_data pointer to
9041         value_print_options reference.  Adjust.
9042         (print_command_1): Process options.  Adjust to pass down a
9043         value_print_options.
9044         (print_command_completer): New.
9045         (_initialize_printcmd): Install print_command_completer as
9046         handle_brkchars completer for the "print" command.  Update
9047         "print"'s help to include supported options.
9048         * valprint.c: Include "cli/cli-option.h".
9049         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9050         here from cp-valprint.c.
9051         (boolean_option_def, uinteger_option_def)
9052         (value_print_option_defs, make_value_print_options_def_group):
9053         New.  Use gdb::option::add_setshow_cmds_for_options to install
9054         "set print elements", "set print null-stop", "set print repeats",
9055         "set print pretty", "set print union", "set print array", "set
9056         print address", "set print symbol", "set print array-indexes".
9057         * valprint.h: Include <string> and "cli/cli-option.h".
9058         (make_value_print_options_def_group): Declare.
9059         (print_value): Change parameter type from format_data pointer to
9060         value_print_options reference.
9061         (print_command_completer): Declare.
9062
9063 2019-06-13  Pedro Alves  <palves@redhat.com>
9064
9065         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9066         (COMMON_SFILES): Add maint-test-settings.c.
9067         * cli/cli-decode.c (boolean_enums): New global, factored out from
9068         ...
9069         (add_setshow_boolean_cmd): ... here.
9070         * cli/cli-decode.h (boolean_enums): Declare.
9071         * cli/cli-option.c: New file.
9072         * cli/cli-option.h: New file.
9073         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9074         factored out from ...
9075         (parse_cli_boolean_value(const char *)): ... this.
9076         (is_unlimited_literal): Change parameter type to pointer to
9077         pointer.  Adjust and advance ARG pointer.
9078         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9079         (parse_cli_var_enum): New, factored out from ...
9080         (do_set_command): ... this.  Adjust.
9081         * cli/cli-setshow.h (parse_cli_boolean_value)
9082         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9083         (parse_cli_var_enum): Declare.
9084         * cli/cli-utils.c: Include "cli/cli-option.h".
9085         (get_ulongest): New.
9086         * cli/cli-utils.h (get_ulongest): Declare.
9087         (check_for_argument): New overloads.
9088         * maint-test-options.c: New file.
9089
9090 2019-06-13  Pedro Alves  <palves@redhat.com>
9091
9092         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9093         parse a range if "-" is at the end of the string.
9094
9095 2019-06-13  Pedro Alves  <palves@redhat.com>
9096
9097         * cli/cli-setshow.c (parse_auto_binary_operation)
9098         (parse_cli_boolean_value): Don't allow "o".
9099
9100 2019-06-13  Pedro Alves  <palves@redhat.com>
9101
9102         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9103         * NEWS: Mention maint test-settings KIND.
9104         * maint-test-settings.c: New file.
9105
9106 2019-06-13  Pedro Alves  <palves@redhat.com>
9107
9108         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9109         completer.
9110         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9111         "set" completers.
9112
9113 2019-06-13  Pedro Alves  <palves@redhat.com>
9114
9115         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9116         after item.
9117
9118 2019-06-13  Pedro Alves  <palves@redhat.com>
9119
9120         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9121
9122 2019-06-13  Pedro Alves <palves@redhat.com>
9123
9124         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9125         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9126         call.
9127         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9128         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9129         calls.
9130         (check_for_argument): Skip spaces after argument.
9131
9132 2019-06-13  Pedro Alves  <palves@redhat.com>
9133
9134         * thread.c (thread_apply_command): Adjust TID parsing.
9135         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9136         detected before end of string.
9137         (tid_is_in_list): Error out if LIST is invalid.
9138
9139 2019-06-13  Pedro Alves  <palves@redhat.com>
9140
9141         * completer.c (complete_line_internal_1): Rewind completion word
9142         point.
9143         (completion_tracker::advance_custom_word_point_by): Change
9144         parameter type to int.
9145         * completer.h (completion_tracker::advance_custom_word_point_by):
9146         Likewise.
9147
9148 2019-06-13  Pedro Alves  <palves@redhat.com>
9149
9150         * completer.c (advance_to_completion_word): Handle delimiters.
9151
9152 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9153
9154         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9155
9156 2019-06-11  Tom Tromey  <tom@tromey.com>
9157
9158         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9159         (xmalloc_failed): Move to alloc.c.
9160         * alloc.c: New file.
9161         * Makefile.in (COMMON_SFILES): Add alloc.c.
9162
9163 2019-06-11  Tom Tromey  <tom@tromey.com>
9164
9165         * nat/linux-waitpid.c: Don't include server.h.
9166         (linux_debug): Remove.
9167         (my_waitpid): Update.
9168
9169 2019-06-11  Tom Tromey  <tromey@adacore.com>
9170
9171         * infcall.c (_initialize_infcall): Remove trailing newline from
9172         help.
9173         * user-regs.c (_initialize_user_regs): Remove trailing newline
9174         from help.
9175         * typeprint.c (_initialize_typeprint): Remove trailing newline
9176         from help.
9177         * reverse.c (_initialize_reverse): Remove trailing newlines from
9178         help.
9179         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9180         from help.
9181         * language.c (add_set_language_command): Remove trailing newline
9182         from help.
9183         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9184         help.
9185         * disasm.c (_initialize_disasm): Remove trailing newline from
9186         help.
9187         * top.c (init_main): Remove trailing newline from help.
9188         * interps.c (_initialize_interpreter): Remove trailing newline
9189         from help.
9190         * btrace.c (_initialize_btrace): Remove trailing newlines from
9191         help.
9192         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9193         from help.
9194         * python/python.c (_initialize_python): Remove trailing newline
9195         from help.
9196         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9197         help.
9198         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9199         from help.  Reformat some text.
9200         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9201         from help.
9202         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9203         newline from help.
9204
9205 2019-06-11  Tom Tromey  <tromey@adacore.com>
9206
9207         * darwin-nat.c (darwin_decode_exception_message)
9208         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9209
9210 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9211
9212         * valops.c (value_slice): Check for not allocated or not
9213         associated values.
9214
9215 2019-06-10  Tom de Vries  <tdevries@suse.de>
9216
9217         PR gdb/24618
9218         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9219         sure an empty slot (defined by a 32-bit zero pair) is recognized as
9220         invalid.
9221
9222 2019-06-10  Tom de Vries  <tdevries@suse.de>
9223
9224         PR gdb/24611
9225         * linespec.c (linespec_lexer_lex_string): Remove incorrect
9226         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
9227
9228 2019-06-10  Tom de Vries  <tdevries@suse.de>
9229
9230         PR symtab/24545
9231         * symtab.c (struct demangled_name_entry): Add language field.
9232         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
9233         static minimal symbol".  Set and use language field.
9234
9235 2019-06-10  Tom Tromey  <tromey@adacore.com>
9236
9237         * ada-lang.c (_initialize_ada_language): Update help text.
9238
9239 2019-06-10  Tom Tromey  <tromey@adacore.com>
9240
9241         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9242         with a newline.
9243         * guile/guile.c (handle_boot_error): Don't end warning with a
9244         newline.
9245         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9246         warning with a newline.
9247         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9248         newline.
9249         (s12z_frame_cache): Likewise.
9250         * dwarf-index-cache.c (index_cache::store): Don't end warning with
9251         a newline.
9252         * solib-svr4.c (disable_probes_interface): Don't end warning with
9253         a newline.
9254         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9255         newline.
9256         * python/python.c (do_finish_initialization): Don't end warning
9257         with a newline.
9258
9259 2019-06-10  Tom Tromey  <tom@tromey.com>
9260
9261         * python/py-breakpoint.c (gdbpy_breakpoint_created)
9262         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9263         gdbpy_enter.
9264
9265 2019-06-10  Tom Tromey  <tromey@adacore.com>
9266
9267         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9268         data.
9269         (elf_new_init): Don't call stabsread_new_init.
9270         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9271         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
9272         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9273
9274 2019-06-10  Tom de Vries  <tdevries@suse.de>
9275
9276         PR symtab/16264
9277         PR symtab/24517
9278         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9279
9280 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
9281
9282         * source.c (find_and_open_source): Also rewrite relative file
9283         names.
9284
9285 2019-04-26  Amos Bird  <amosbird@gmail.com>
9286
9287         * annotate.c (annotate_thread_exited): Add "thread-exited"
9288         annotation.
9289
9290 2019-06-06  Tom Tromey  <tromey@adacore.com>
9291
9292         * maint.h (class scoped_command_stats): Use
9293         DISABLE_COPY_AND_ASSIGN.
9294         <print_time>: New method.
9295         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9296         print_time.
9297         (scoped_command_stats::print_time): New method.
9298
9299 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9300
9301         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9302         instructions of lengths 6 or 8 bytes.
9303
9304 2019-06-04  Pedro Alves  <palves@redhat.com>
9305
9306         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9307
9308         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9309         * breakpoint.c (condition_completer): Likewise.
9310         * cli/cli-dump.c (scan_expression): Likewise.
9311         * common/filestuff.c (mkdir_recursive): Likewise.
9312         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9313         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9314         (gdb_abspath): Likewise.
9315         * compile/compile-cplus-types.c
9316         (compile_cplus_instance::decl_name): Likewise.
9317         * completer.c (complete_explicit_location):
9318         (signal_completer, reg_or_group_completer_1): Likewise.
9319         * cp-support.c (cp_remove_params_if_any): Likewise.
9320         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9321         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9322         * infcmd.c (strip_bg_char): Likewise.
9323         * linespec.c (copy_token_string): Likewise.
9324         * mi/mi-main.c (output_cores): Likewise.
9325         * psymtab.c (psymtab_search_name):
9326         * symfile.c (test_set_ext_lang_command): Likewise.
9327         * target.c (target_fileio_read_stralloc): Likewise.
9328         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9329         * value.c (complete_internalvar): Likewise.
9330
9331 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
9332
9333         Add objfile property to gdb.Type.
9334         * NEWS: Mention Python API addition.
9335         * python/py-type.c (typy_get_objfile): New method.
9336
9337 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9338
9339         * NEWS: Mention the new set|show style [title|highlight].
9340         Mention changes to "show style", "help" and "apropos".
9341
9342 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9343
9344         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9345         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
9346         instead of print_help_for_command.
9347         (print_doc_of_command): New function.
9348         (help_list): Add 'apropos -v word' suggestion.
9349         (print_help_for_command): Style the command name using title style.
9350         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9351         (_initialize_cli_cmds): Describe -v in apropos_command help.
9352
9353 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9354
9355         * cli/cli-style.h (cli_style_option): Add name in constructor,
9356         add m_name class member, add constructor with intensity,
9357         add name class function.
9358         (cli_style_option::add_setshow_commands): Remove name argument.
9359         (highlight_style, title_style): New styles.
9360         * cli/cli-style.c (do_show): New function that shows a style
9361         characteristic styling the style name with itself.
9362         (set_style_name): New function.
9363         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9364         Update all callers according to the changes in cli/cli-style.h.
9365         * utils.h (fputs_highlighted): New function.
9366         * utils.c (fputs_highlighted): Likewise.
9367
9368 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9369
9370         * NEWS: Mention new pipe command and new convenience variables.
9371
9372 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9373
9374         * cli/cli-cmds.c (pipe_command): New function.
9375         (_initialize_cli_cmds): Call add_com for pipe_command.
9376         Define | as an alias for pipe.
9377         (exit_status_set_internal_vars): New function.
9378         (shell_escape): Call exit_status_set_internal_vars.
9379         cli/cli-decode.c (find_command_name_length): Recognize | as
9380         a single character command.
9381
9382 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9383
9384         * gdbcmd.h (execute_command_to_ui_file): New declaration.
9385         top.c (execute_command_to_ui_file): New function, mostly a copy
9386         of execute_command_to_string.
9387         (execute_command_to_string): Implement by calling
9388         execute_command_to_ui_file.
9389
9390 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9391
9392         * top.h (saved_command_line): Remove declaration.
9393         * top.c (previous_saved_command_line, previous_repeat_arguments):
9394         New variables.
9395         (saved_command_line): Make static, define together with other
9396         'repeat variables'.
9397         (dont_repeat): Clear repeat_arguments.
9398         (repeat_previous, get_saved_command_line, save_command_line):
9399         New functions.
9400         (gdb_init): Initialize saved_command_line
9401         and previous_saved_command_line.
9402         * main.c (captured_main_1): Remove saved_command_line initialization.
9403         * event-top.c (handle_line_of_input): Update to use
9404         the new 'repeat' related functions instead of direct access to
9405         saved_command_line.
9406         * command.h (repeat_previous, get_saved_command_line,
9407         save_command_line): New declarations.
9408         (dont_repeat): Add comment.
9409
9410 2019-05-30  Tom Tromey  <tromey@adacore.com>
9411
9412         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9413         Fix comment.
9414         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9415
9416 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
9417
9418         PR cli/24587
9419         * completer.c (complete): Initialize variable word.
9420
9421 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
9422
9423         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9424         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9425         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9426         'body' is NULL to the outter 'if', protecting the '!is_define'
9427         situation as well.
9428
9429 2019-05-29  Tom Tromey  <tromey@adacore.com>
9430
9431         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9432         (dwarf_unknown): New function.
9433         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9434         (dwarf_type_encoding_name): Use dwarf_unknown.
9435
9436 2019-05-29  Tom Tromey  <tromey@adacore.com>
9437
9438         PR c++/20020:
9439         * cp-valprint.c (cp_print_value_fields): Call
9440         cp_print_static_field inside "try".
9441
9442 2019-05-29  Tom Tromey  <tromey@adacore.com>
9443
9444         * inflow.c (struct terminal_info): Add default operator=.
9445         * configure: Rebuild.
9446         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9447         -Wdeprecated-copy-dtor, -Wredundant-move.
9448
9449 2019-05-29  Tom Tromey  <tromey@adacore.com>
9450
9451         * NEWS: Add entry.
9452         * infcmd.c (print_return_value_1): Handle finish_print
9453         option.
9454         (show_print_finish): New function.
9455         (_initialize_infcmd): Add "set/show print finish" commands.
9456         * valprint.c (user_print_options): Initialize new member.
9457         * valprint.h (struct value_print_options) <finish_print>: New
9458         member.
9459
9460 2019-05-28  Tom Tromey  <tromey@adacore.com>
9461
9462         * ada-lang.c (ada_remove_Xbn_suffix)
9463         (find_old_style_renaming_symbol)
9464         (parse_old_style_renaming): Remove.
9465         (ada_find_renaming_symbol): Don't call
9466         find_old_style_renaming_symbol.
9467         (ada_is_renaming_symbol): Rename from
9468         ada_find_renaming_symbol.  Remove "block" parameter.  Return
9469         bool.  Now static.
9470         (ada_read_var_value): Update and simplify.
9471         * ada-exp.y (write_var_or_type): Remove old code.
9472
9473 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
9474
9475         PR gdb/25010
9476         * event-top.c: Remove include comment.
9477         * inflow.c (class scoped_ignore_sigttou): Move from here...
9478         * inflow.h (class scoped_ignore_sigttou): ...to here.
9479         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9480         * top.c:  Remove include comment.
9481
9482 2019-05-27  Tom Tromey  <tom@tromey.com>
9483
9484         * NEWS: Fix typo.
9485
9486 2019-05-22  Tom Tromey  <tromey@adacore.com>
9487
9488         * target.c (target_follow_exec): Constify parameter.
9489         * target-delegates.c: Rebuild.
9490         * remote.c (remote_target::follow_exec): Constify parameter.
9491         * infrun.c (follow_exec): Constify parameter.
9492         * target.h (struct target_ops) <follow_exec>: Constify parameter.
9493         (target_follow_exec): Likewise.
9494
9495 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9496
9497         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9498         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9499
9500 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9501
9502         * NEWS: Add debugredirect and testsuite sections.
9503
9504 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
9505
9506         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9507         target descriptions using exclusively floating point register name
9508         aliases.
9509
9510 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
9511
9512         PR gdb/18644:
9513         * f-lang.c (build_fortran_types): Handle the case where
9514         gdbarch_floatformat_for_type returns a nullptr.
9515
9516 2019-05-21  Tom de Vries  <tdevries@suse.de>
9517
9518         PR cli/24587
9519         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9520
9521 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9522
9523         PR gdb/18644:
9524         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9525         16-byte floats.
9526         * i386-tdep.c (i386_floatformat_for_type): Use
9527         floatformats_ia64_quad for the 16-byte floating point component
9528         within a fortran 32-byte complex number.
9529
9530 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9531
9532         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9533         delete default constructor.
9534         (find_partial_die): Update to return const struct.
9535         (partial_die_parent_scope): Move variable declaration into scope
9536         of its use and change its type to auto.
9537         (guess_partial_die_structure_name): Likewise.
9538         (partial_die_info::fixup): Likewise.
9539
9540 2019-05-17  Tom Tromey  <tromey@adacore.com>
9541
9542         * source.c (find_and_open_source): Remove cast.
9543
9544 2019-05-17  Tom Tromey  <tromey@adacore.com>
9545
9546         * annotate.c (annotate_source): Make "filename" const.
9547         * annotate.h (annotate_source): Use const.
9548
9549 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9550
9551         * disasm.c (set_disassembler_options): Send errors to stderr.
9552
9553 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9554
9555         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9556         (cli_interp_base::set_logging): Check debug_redirect.
9557         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9558         * cli/cli-logging.c (debug_redirect): Add static variable.
9559         (pop_output_files): Add default param.
9560         (handle_redirections): Print debug setting.
9561         (show_logging_command): Likewise.
9562         (_initialize_cli_logging): Add debugredirect command.
9563         * interps.c (current_interp_set_logging): Add debug_redirect
9564         parameter.
9565         * interps.h (set_logging): Add debug_redirect parameter.
9566         (current_interp_set_logging): Likewise.
9567         * mi/mi-common.h: Likewise.
9568         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9569
9570 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9571             Tom Tromey  <tromey@adacore.com>
9572
9573         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9574         directly.
9575         * cli/cli-interp.h (make_logging_output): Remove declaration.
9576         * cli/cli-logging.c (make_logging_output): Remove function.
9577         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9578         directly.
9579         * ui-file.c (tee_file::tee_file): Remove bools.
9580         (tee_file::~tee_file): Remove deletes.
9581         * ui-file.h (tee_file): Remove bools.
9582
9583 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
9584
9585         * mi/mi-cmds.h (mi_cmd_complete): New function.
9586         * mi/mi-main.c (mi_cmd_complete): Likewise.
9587         * mi/mi-cmds.c: Define new MI command -complete.
9588         * NEWS: Mention new -complete command.
9589
9590 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
9591
9592         * completer.h (complete): New function.
9593         * completer.c (complete): Likewise.
9594         * cli/cli-cmds.c: (complete_command): Update to use new complete()
9595         function defined in completer.h.
9596
9597 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
9598
9599         * MAINTAINERS (Write After Approval): Add myself.
9600
9601 2019-05-17  Tom de Vries  <tdevries@suse.de>
9602
9603         PR gdb/24094
9604         * dwarf2read.c (struct cu_partial_die_info): New struct.
9605         (find_partial_die): Return cu_partial_die_info.
9606         (partial_die_parent_scope, guess_partial_die_structure_name)
9607         (partial_die_info::fixup): Handle new return type of find_partial_die.
9608
9609 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9610
9611         PR breakpoints/24541
9612         * stap-probe.c (stap_parse_register_operand): Make "regname" an
9613         "std::string", simplifying the algorithm.
9614
9615 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9616
9617         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9618         (stap_static_probe_ops::get_probes): Likewise.
9619
9620 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9621
9622         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9623         '-')" and "else if".
9624         (stap_parse_single_operand): Join checks for
9625         "gdbarch_stap_parse_special_token_p" and
9626         "gdbarch_stap_parse_special_token" in the same "if" statement.
9627         Invert check when verifying for operation on register
9628         displacement.
9629
9630 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9631
9632         * stap-probe.c (stap_get_opcode): Update comment.
9633         (stap_get_expected_argument_type): Likewise.
9634         (handle_stap_probe): Likewise.
9635
9636 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9637
9638         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9639         return type to 'bool'.  Adjust comment.  Use 'bool' when
9640         appropriate.
9641         (i386_stap_parse_special_token_three_arg_disp): Likewise.
9642         * stap-probe.c (stap_parse_argument_1): Likewise.
9643         (stap_is_operator): Likewise.
9644         (stap_is_generic_prefix): Likewise.
9645         (stap_is_register_prefix): Likewise.
9646         (stap_is_register_indirection_prefix): Likewise.
9647         (stap_is_integer_prefix): Likewise.
9648         (stap_generic_check_suffix): Likewise.
9649         (stap_check_integer_suffix): Likewise.
9650         (stap_check_register_suffix): Likewise.
9651         (stap_check_register_indirection_suffix): Likewise.
9652         (stap_parse_register_operand): Likewise.
9653         (stap_parse_single_operand): Likewise.
9654         (stap_parse_argument_1): Likewise.
9655         (stap_probe::get_argument_count): Likewise.
9656         (stap_is_operator): Likewise.
9657
9658 2019-05-16  Tom Tromey  <tromey@adacore.com>
9659
9660         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9661         keyword to foreach.
9662
9663 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
9664
9665         * linux-thread-db.c (try_thread_db_load_1): Change return type
9666         to bool.
9667         (try_thread_db_load): Likewise.
9668         (try_thread_db_load_from_pdir_1): Likewise.
9669         (try_thread_db_load_from_pdir): Likewise.
9670         (try_thread_db_load_from_sdir): Likewise.
9671         (try_thread_db_load_from_dir): Likewise.
9672         (thread_db_load_search): Likewise.
9673         (has_libpthread): Likewise.
9674         (thread_db_load): Likewise.
9675
9676 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
9677
9678         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9679         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9680         NULL, and complain/return if that's the case.
9681
9682 2019-05-15  John Darrington <john@darrington.wattle.id.au>
9683
9684         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9685         (advance, posn, abstract_read_memory): New functions.
9686         [struct mem_read_abstraction]: New struct.
9687         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9688
9689 2019-05-14  Tom Tromey  <tromey@adacore.com>
9690
9691         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9692         value is not lval_memory.
9693
9694 2019-05-14  Tom Tromey  <tromey@adacore.com>
9695
9696         * solib.c (info_sharedlibrary_command): Style the file name.
9697
9698 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
9699
9700         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9701         (aarch64_vnv_type): Likewise.
9702         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9703         * common/tdesc.c: Likewise.
9704         * common/tdesc.h (enum tdesc_type_kind): Likewise.
9705         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9706         * features/aarch64-fpu.xml: Add ieee half view.
9707         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9708         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9709         * gdbtypes.h (struct builtin_type): Likewise.
9710         (struct objfile_type): Likewise.
9711
9712 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
9713
9714         * language.c (language_sniff_from_mangled_name): Fix "langauge"
9715         typo.
9716         * location.h (string_to_event_location): Likewise.
9717
9718 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
9719
9720         GDB 8.3 released.
9721
9722 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9723
9724         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9725         New variable declaration.
9726         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9727         New variable.
9728         (print_one_breakpoint): Use ui_out::test_flags and new global
9729         variable to compute use_fixed_output.
9730         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9731         Remove.
9732         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9733         (mi_multi_location_breakpoint_output_fixed): Remove.
9734         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9735         new variable.
9736         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9737         fix_multi_location_breakpoint_output flag if version >= 3.
9738         * ui-out.h (enum ui_out_flag)
9739         <fix_multi_location_breakpoint_output>: New enumerator.
9740
9741 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9742
9743         * contrib/cc-with-tweaks.sh: Validate dwz's work.
9744
9745 2019-05-10  Tom Tromey  <tromey@adacore.com>
9746
9747         * ada-lang.c (catch_ada_completer): New function.
9748         (_initialize_ada_language): Use it.
9749
9750 2019-05-10  Tom Tromey  <tromey@adacore.com>
9751
9752         * thread.c (print_thread_info): Make "requested_threads" const.
9753         * gdbthread.h (print_thread_info): Make "requested_threads"
9754         const.
9755         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9756         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9757
9758 2019-05-08  Tom Tromey  <tom@tromey.com>
9759
9760         * gdbtypes.c (objfile_type_data): Change type.
9761         (objfile_type, _initialize_gdbtypes): Update.
9762
9763 2019-05-08  Tom Tromey  <tom@tromey.com>
9764
9765         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9766         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9767         (_initialize_dwarf2_frame): Update.
9768
9769 2019-05-08  Tom Tromey  <tom@tromey.com>
9770
9771         * objc-lang.c (objc_objfile_data): Change type.
9772         (find_methods): Update.
9773         (_initialize_objc_lang): Remove.
9774
9775 2019-05-08  Tom Tromey  <tom@tromey.com>
9776
9777         * stabsread.c (rs6000_builtin_type_data): Change type.
9778         (rs6000_builtin_type, _initialize_stabsread): Update.
9779
9780 2019-05-08  Tom Tromey  <tom@tromey.com>
9781
9782         * mips-tdep.c (mips_pdr_data): Remove.
9783         (_initialize_mips_tdep): Update.
9784
9785 2019-05-08  Tom Tromey  <tom@tromey.com>
9786
9787         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9788         (hppa_init_objfile_priv_data, read_unwind_info)
9789         (find_unwind_entry, _initialize_hppa_tdep): Update.
9790
9791 2019-05-08  Tom Tromey  <tom@tromey.com>
9792
9793         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9794         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
9795         on obstack.
9796         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9797
9798 2019-05-08  Tom Tromey  <tom@tromey.com>
9799
9800         * mdebugread.c (basic_type_data): Change type.
9801         (basic_type, _initialize_mdebugread): Update.
9802
9803 2019-05-08  Tom Tromey  <tom@tromey.com>
9804
9805         * common/gdb_unique_ptr.h (struct noop_deleter): New.
9806
9807 2019-05-08  Tom Tromey  <tom@tromey.com>
9808
9809         * nto-tdep.c (nto_inferior_data_reg): Change type.
9810         (nto_inferior_data): Update.
9811         (nto_inferior_data_cleanup, nto_new_inferior_data)
9812         (_initialize_nto_tdep): Remove.
9813         * nto-tdep.h (struct nto_inferior_data): Add initializers.
9814
9815 2019-05-08  Tom Tromey  <tom@tromey.com>
9816
9817         * ada-lang.c (struct ada_inferior_data): Add initializers.
9818         (ada_inferior_data): Change type.
9819         (ada_inferior_data_cleanup): Remove.
9820         (get_ada_inferior_data, ada_inferior_exit)
9821         (struct ada_pspace_data): Add initializers, destructor.
9822         (ada_pspace_data_handle): Change type.
9823         (get_ada_pspace_data): Update.
9824         (ada_pspace_data_cleanup): Remove.
9825
9826 2019-05-08  Tom Tromey  <tom@tromey.com>
9827
9828         * coffread.c (struct coff_symfile_info): Add initializers.
9829         (coff_objfile_data_key): Move lower.  Change type.
9830         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9831         Update.
9832         (coff_free_info): Remove.
9833
9834 2019-05-08  Tom Tromey  <tom@tromey.com>
9835
9836         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9837         (fbsd_pspace_data_handle): Move lower.  Change type.
9838         (get_fbsd_pspace_data): Update.
9839         (fbsd_pspace_data_cleanup): Remove.
9840         (_initialize_fbsd_tdep): Update.
9841
9842 2019-05-08  Tom Tromey  <tom@tromey.com>
9843
9844         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9845         (get_ada_tasks_pspace_data): Update.
9846         (ada_tasks_pspace_data_cleanup): Remove.
9847         (_initialize_tasks): Update.
9848         (ada_tasks_inferior_data_handle): Change type.
9849         (get_ada_tasks_inferior_data): Update.
9850         (ada_tasks_inferior_data_cleanup): Remove.
9851         (struct ada_tasks_pspace_data): Add initializers.
9852
9853 2019-05-08  Tom Tromey  <tom@tromey.com>
9854
9855         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9856         * symfile-debug.c (debug_sym_get_probes): Change type.
9857         * stap-probe.c (handle_stap_probe):
9858         (stap_static_probe_ops::get_probes): Change type.
9859         * probe.h (class static_probe_ops) <get_probes>: Change type.
9860         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9861         (parse_probes_in_pspace): Update.
9862         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9863         Update.
9864         (any_static_probe_ops::get_probes): Change type.
9865         * elfread.c (elfread_data): New typedef.
9866         (probe_key): Change type.
9867         (elf_get_probes): Likewise.  Update.
9868         (probe_key_free): Remove.
9869         (_initialize_elfread): Update.
9870         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9871         Change type.
9872         (dtrace_process_dof_probe, dtrace_process_dof)
9873         (dtrace_static_probe_ops::get_probe): Change type.
9874
9875 2019-05-08  Tom Tromey  <tom@tromey.com>
9876
9877         * xcoffread.c (struct xcoff_symfile_info): Rename from
9878         coff_symfile_info.  Add initializers.
9879         (xcoff_objfile_data_key): Move lower.  Change type.
9880         (XCOFF_DATA): Rewrite.
9881         (xcoff_free_info): Remove.
9882         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9883         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9884         (xcoff_initial_scan): Update.
9885
9886 2019-05-08  Tom Tromey  <tom@tromey.com>
9887
9888         * solib-svr4.c (struct svr4_info): Add initializers and
9889         destructor.
9890         <probes_table>: Now an htab_up.
9891         (solib_svr4_pspace_data): Change type.
9892         (free_probes_table): Simplify.
9893         (~svr4_info): Rename from svr4_pspace_data_cleanup.
9894         (get_svr4_info, probes_table_htab_remove_objfile_probes)
9895         (probes_table_remove_objfile_probes, register_solib_event_probe)
9896         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9897         (_initialize_svr4_solib): Update.
9898
9899 2019-05-08  Tom Tromey  <tom@tromey.com>
9900
9901         * remote.c (remote_pspace_data): Change type.
9902         (remote_pspace_data_cleanup): Remove.
9903         (get_remote_exec_file, set_pspace_remote_exec_file)
9904         (_initialize_remote): Update.
9905
9906 2019-05-08  Tom Tromey  <tom@tromey.com>
9907
9908         * breakpoint.c (breakpoint_objfile_key): Change type.
9909         (get_breakpoint_objfile_data): Update.
9910         (free_breakpoint_objfile_data): Remove.
9911         (_initialize_breakpoint): Update.
9912
9913 2019-05-08  Tom Tromey  <tom@tromey.com>
9914
9915         * linux-tdep.c (struct linux_info): Add initializers.
9916         (linux_inferior_data): Move.  Change type.
9917         (invalidate_linux_cache_inf): Update.
9918         (linux_inferior_data_cleanup): Remove.
9919         (get_linux_inferior_data, _initialize_linux_tdep): Update.
9920
9921 2019-05-08  Tom Tromey  <tom@tromey.com>
9922
9923         * auxv.c (auxv_inferior_data): Move.  Change type.
9924         (auxv_inferior_data_cleanup): Remove.
9925         (invalidate_auxv_cache_inf): Rewrite.
9926         (get_auxv_inferior_data, _initialize_auxv): Update.
9927
9928 2019-05-08  Tom Tromey  <tom@tromey.com>
9929
9930         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
9931         (symfile_debug_objfile_data_key): Change type.
9932         (symfile_debug_installed, debug_qf_has_symbols)
9933         (debug_qf_find_last_source_symtab)
9934         (debug_qf_forget_cached_source_info)
9935         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
9936         (debug_qf_print_stats, debug_qf_dump)
9937         (debug_qf_expand_symtabs_for_function)
9938         (debug_qf_expand_all_symtabs)
9939         (debug_qf_expand_symtabs_with_fullname)
9940         (debug_qf_map_matching_symbols)
9941         (debug_qf_expand_symtabs_matching)
9942         (debug_qf_find_pc_sect_compunit_symtab)
9943         (debug_qf_map_symbol_filenames)
9944         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
9945         (debug_sym_new_init, debug_sym_init, debug_sym_read)
9946         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
9947         (debug_sym_read_linetable, debug_sym_relocate): Update.
9948         (symfile_debug_free_objfile): Remove.
9949         (install_symfile_debug_logging, _initialize_symfile_debug):
9950         Update.
9951
9952 2019-05-08  Tom Tromey  <tom@tromey.com>
9953
9954         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
9955         allocate_on_obstack.
9956         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
9957         (get_dwarf2_per_objfile): Update.
9958         (set_dwarf2_per_objfile): Remove.
9959         (dwarf2_has_info, dwarf2_get_section_info): Update.
9960         (dwarf2_free_objfile): Remove.
9961         (_initialize_dwarf2_read): Update.
9962
9963 2019-05-08  Tom Tromey  <tom@tromey.com>
9964
9965         * auto-load.c (struct auto_load_pspace_info): Add destructor and
9966         initializers.
9967         <unsupported_script_warning_printed,
9968         script_not_found_warning_printed>: Now bool.
9969         (auto_load_pspace_data): Change type.
9970         (~auto_load_pspace_info): Rename from
9971         auto_load_pspace_data_cleanup.
9972         (get_auto_load_pspace_data, init_loaded_scripts_info)
9973         (clear_section_scripts, maybe_print_unsupported_script_warning)
9974         (maybe_print_script_not_found_warning, _initialize_auto_load):
9975         Update.
9976
9977 2019-05-08  Tom Tromey  <tom@tromey.com>
9978
9979         * objfiles.c (objfile_pspace_info): Add destructor and
9980         initializers.
9981         (objfiles_pspace_data): Change type.
9982         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
9983         (get_objfile_pspace_data): Update.
9984         (objfiles_bfd_data): Change type.
9985         (get_objfile_bfd_data): Update.
9986         (objfile_bfd_data_free, _initialize_objfiles): Remove.
9987
9988 2019-05-08  Tom Tromey  <tom@tromey.com>
9989
9990         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
9991         Change type.
9992         (get_catch_syscall_inferior_data): Update.
9993         (catch_syscall_inferior_data_cleanup): Remove.
9994         (_initialize_break_catch_syscall): Update.
9995
9996 2019-05-08  Tom Tromey  <tom@tromey.com>
9997
9998         * inflow.c (struct terminal_info): Add destructor and
9999         initializers.
10000         (inflow_inferior_data): Change type.
10001         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10002         (get_inflow_inferior_data, inflow_inferior_exit)
10003         (swap_terminal_info, _initialize_inflow): Update.
10004
10005 2019-05-08  Tom Tromey  <tom@tromey.com>
10006
10007         * target-dcache.c (target_dcache_cleanup): Remove.
10008         (target_dcache_aspace_key): Change type.
10009         (target_dcache_init_p, target_dcache_invalidate)
10010         (target_dcache_get, target_dcache_get_or_init)
10011         (_initialize_target_dcache): Update.
10012         * dcache.h (struct dcache_deleter): New.
10013
10014 2019-05-08  Tom Tromey  <tom@tromey.com>
10015
10016         * symtab.c (struct symbol_cache): Add destructor and
10017         initializers.
10018         (symbol_cache_key): Move.  Change type.
10019         (make_symbol_cache, free_symbol_cache): Remove.
10020         (get_symbol_cache): Update.
10021         (symbol_cache_cleanup): Remove.
10022         (ALL_PSPACES, symbol_cache_flush)
10023         (maintenance_print_symbol_cache)
10024         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10025         Update.
10026
10027 2019-05-08  Tom Tromey  <tom@tromey.com>
10028
10029         * symtab.c (struct main_info): Add destructor and initializers.
10030         (main_progspace_key): Move.  Change type.
10031         (get_main_info): Update.
10032         (main_info_cleanup): Remove.
10033         (_initialize_symtab): Update.
10034
10035 2019-05-08  Tom Tromey  <tom@tromey.com>
10036
10037         * registry.h (DECLARE_REGISTRY): Define the _key class.
10038
10039 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10040
10041         * NEWS: Merge two 'New commands' sections.
10042
10043 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10044
10045         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10046         parameter and use Ada language definition instead.
10047         (ada_val_print_ptr): Remove unused language parameter.
10048         (ada_val_print_num): Remove language parameter and use Ada language
10049         definition instead.
10050         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10051         parameter.
10052         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10053         parameter and use Ada language definition instead.
10054         (ada_val_print_1): Update all ada_val_print_xxx calls.
10055         Remove language parameter.
10056         (ada_val_print): Update ada_val_print_1 call.
10057
10058 2019-05-08  Tom Tromey  <tromey@adacore.com>
10059
10060         * remote.c (remote_hw_watchpoint_limit)
10061         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10062         Now static.
10063
10064 2019-05-08  Tom Tromey  <tromey@adacore.com>
10065
10066         * maint.c (_initialize_maint_cmds): Move initialization code to
10067         remote.c.
10068         (watchdog, show_watchdog): Move to remote.c.
10069         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10070         "watchdog" static.
10071         (_initialize_remote): Move initialization code from maint.c.
10072         * defs.h (watchdog): Don't declare.
10073
10074 2019-05-08  Tom Tromey  <tromey@adacore.com>
10075
10076         * tui/tui-interp.c: Include main.h.
10077         * interps.c: Include main.h.
10078         * main.h (interpreter_p): Declare.
10079         * defs.h (interpreter_p): Don't declare.
10080
10081 2019-05-08  Tom Tromey  <tromey@adacore.com>
10082
10083         * dwarf2loc.c: Include dwarf2read.h.
10084         * defs.h (read_unsigned_leb128): Don't declare.
10085         * dwarf2read.h (read_unsigned_leb128): Declare.
10086
10087 2019-05-08  Tom Tromey  <tromey@adacore.com>
10088
10089         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10090         method.
10091
10092 2019-05-08  Tom Tromey  <tromey@adacore.com>
10093
10094         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10095         when no wrap column is set.
10096
10097 2019-05-08  Tom Tromey  <tromey@adacore.com>
10098
10099         * c-lang.c (c_get_string): Handle non-C-style arrays.
10100
10101 2019-05-08  Tom Tromey  <tromey@adacore.com>
10102
10103         * typeprint.c (print_offset_data::update): Print the bit offset,
10104         not the number of bits remaining.
10105
10106 2019-05-08  Tom Tromey  <tromey@adacore.com>
10107
10108         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10109         padding at end of comment.
10110
10111 2019-05-08  Tom Tromey  <tromey@adacore.com>
10112
10113         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10114         Compare main types.
10115
10116 2019-05-06  Tom Tromey  <tom@tromey.com>
10117
10118         * common/scoped_mmap.c: Include common-defs.h.
10119         * common/scoped_mmap.h: Don't include config.h.
10120
10121 2019-05-04  Tom Tromey  <tom@tromey.com>
10122
10123         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10124         (struct aarch64_call_info): Add initializers.
10125         <si>: Now a std::vector.
10126         (pass_on_stack, aarch64_push_dummy_call): Update.
10127
10128 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10129             Tom Tromey  <tom@tromey.com>
10130
10131         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10132         (ppc_threads): Now a std::vector.  Now static.
10133         (hwdebug_find_thread_points_by_tid)
10134         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10135         Update.
10136
10137 2019-05-04  Tom Tromey  <tom@tromey.com>
10138
10139         * arc-tdep.c (arc_tdesc_init): Return bool.
10140
10141 2019-05-04  Tom Tromey  <tom@tromey.com>
10142
10143         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10144         Use gdb_assert_not_reached.
10145
10146 2019-05-04  Tom Tromey  <tom@tromey.com>
10147
10148         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10149         "false".
10150
10151 2019-05-04  Tom Tromey  <tom@tromey.com>
10152
10153         * arc-tdep.c (arc_tdesc_init): Use bool.
10154
10155 2019-05-04  Tom Tromey  <tom@tromey.com>
10156
10157         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10158
10159 2019-05-04  Tom Tromey  <tom@tromey.com>
10160
10161         * cli/cli-cmds.c (valid_command_p): Return bool.
10162
10163 2019-05-04  Tom Tromey  <tom@tromey.com>
10164
10165         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10166         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10167
10168 2019-05-04  Raul Tambre  <raul@tambre.ee>
10169
10170         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10171         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10172         operator for comparison.
10173
10174 2019-05-04  Tom Tromey  <tom@tromey.com>
10175
10176         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10177         (lookup_partial_symbol, print_partial_symbols)
10178         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10179         (psymbol_compare): Update.
10180         (add_psymbol_to_bcache): Clear the entire psymbol.
10181         (maintenance_check_psymtabs): Update.
10182         * psympriv.h (struct partial_symbol): Don't derive from
10183         general_symbol_info.
10184         <obj_section, unrelocated_address, address,
10185         set_unrelocated_address>: Update.
10186         <ginfo>: New member.
10187         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10188         (debug_names::write_psymbols): Update.
10189
10190 2019-05-04  Tom de Vries  <tdevries@suse.de>
10191
10192         * contrib/cc-with-tweaks.sh: Support -n arg.
10193
10194 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10195
10196         * corelow.c (core_target::detach): Ensure frame cache and
10197         register caches are cleared.
10198         inferior.c (exit_inferior_1): Likewise.
10199
10200 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10201             Tom Tromey  <tom@tromey.com>
10202
10203         * dictionary.c (collate_pending_symbols_by_language): Remove
10204         "struct" from foreach.
10205         * symtab.c (lookup_global_symbol_from_objfile)
10206         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10207         foreach.
10208         * ser-tcp.c (net_open): Remove "struct" from foreach.
10209         * objfiles.c (objfile_relocate, objfile_rebase)
10210         (objfile_has_symbols): Remove "struct" from foreach.
10211         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10212         from foreach.
10213         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10214         foreach.
10215         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10216         "struct" from foreach.
10217         * ada-lang.c (create_excep_cond_exprs)
10218         (ada_exception_catchpoint_cond_string): Remove "struct" from
10219         foreach.
10220
10221 2019-05-03  Tom Tromey  <tromey@adacore.com>
10222
10223         * ada-exp.y (convert_char_literal): Check suffix of each
10224         enumerator.
10225
10226 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
10227
10228         PR ada/21406:
10229         * ada-exp.y (yywrap): Don't define.
10230         * ada-lex.l (%option): Add noyywrap
10231         (yywrap): Remove.
10232
10233 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
10234
10235         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10236         _WIN32_WINNT to the XP level, unless already defined to a higher
10237         level.
10238
10239         * unittests/parse-connection-spec-selftests.c:
10240         * ser-tcp.c:
10241         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
10242         override.
10243
10244         * symfile.c (find_separate_debug_file): Remove colon from the
10245         drive spec of DOS/Windows file names of the target, so that the
10246         file name produced from DEBUGDIR and the target's directory will
10247         be valid on DOS/Windows systems.
10248
10249 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
10250
10251         * rust-lang.c (val_print_struct): Handle printing structures
10252         containing strings.
10253
10254 2019-05-02  Tom Tromey  <tromey@adacore.com>
10255
10256         * valarith.c (_initialize_valarith): Remove.
10257
10258 2019-05-01  Tom Tromey  <tromey@adacore.com>
10259
10260         * ada-lang.c (ada_value_primitive_field): Treat more fields as
10261         bitfields.
10262
10263 2019-05-01  Tom Tromey  <tromey@adacore.com>
10264
10265         * ada-lang.c (ada_value_assign): Correctly compute starting offset
10266         for big-endian copies.
10267
10268 2019-04-30  Ali Tamur  <tamur@google.com>
10269         * gdb/dwarf2read.c (read_3_bytes): New declaration.
10270         (read_attribute_value): Added DW_FORM_strx1-4 cases.
10271         (read_3_bytes): New function.
10272
10273 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10274
10275         * windows-nat.c (main_thread_id): Delete.
10276         (handle_output_debug_string): Replace main_thread_id by
10277         current_event.dwThreadId.
10278         (fake_create_process): Likewise.
10279         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10280         Do not set main_thread_id.
10281         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10282         current_event.dwThreadId.
10283         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10284
10285 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10286
10287         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10288         Use current_event.dwThreadId instead of main_thread_id.
10289
10290 2019-04-30  Tom Tromey  <tromey@adacore.com>
10291
10292         * ada-lang.c (ada_lookup_simple_minsyms): New function.
10293         (create_excep_cond_exprs): Iterate over program spaces.
10294         (ada_exception_catchpoint_cond_string): Examine all minimal
10295         symbols for exception types.
10296
10297 2019-04-30  Tom Tromey  <tromey@adacore.com>
10298
10299         PR c++/24470:
10300         * dwarf2read.c (process_structure_scope): Handle case where type
10301         has template parameters but no symbol was created.
10302
10303 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10304             Chris January  <chris.january@arm.com>
10305
10306         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10307         qualifier.
10308         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10309
10310 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10311
10312         * f-typeprint.c (f_print_type): Update rules for printing
10313         whitespace.
10314         (f_type_print_varspec_suffix): Likewise.
10315
10316 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10317             Chris January  <chris.january@arm.com>
10318
10319         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10320         function arguments.
10321
10322 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10323
10324         * f-lang.c (build_fortran_types): Change name of void type to
10325         lower case.
10326         * f-typeprint.c (f_type_print_base): Print the name of the void
10327         type, rather than a fixed string.
10328         * f-valprint.c (f_decorations): Use lower case void string.
10329
10330 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10331             Chris January  <chris.january@arm.com>
10332
10333         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10334         types for Fortran.
10335
10336 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10337             Chris January  <chris.january@arm.com>
10338             David Lecomber  <david.lecomber@arm.com>
10339
10340         * f-exp.y (BINOP_INTRINSIC): New token.
10341         (exp): New parser rule handling BINOP_INTRINSIC.
10342         (f77_keywords): Add new builtin procedures.
10343         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10344         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10345         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10346         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10347         (print_unop_subexp_f): New function.
10348         (print_binop_subexp_f): New function.
10349         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10350         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10351         (dump_subexp_body_f): Likewise.
10352         (operator_check_f): Likewise.
10353         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10354         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10355
10356 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10357
10358         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10359         UNOP_KIND.
10360         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10361         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10362         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10363         (operator_length_f): New fuction.
10364         (print_subexp_f): New function.
10365         (op_name_f): New function.
10366         (dump_subexp_body_f): New function.
10367         (operator_check_f): New function.
10368         (exp_descriptor_f): Replace standard expression handling functions
10369         with new functions.
10370         * gdb/fortran-operator.def: New file.
10371         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10372         * gdb/std-operator.def: Remove UNOP_KIND.
10373
10374 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10375
10376         * std-operator.def: Remove unbalanced, stray double quote
10377         character.
10378
10379 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10380             Chris January  <chris.january@arm.com>
10381             Daniel Everett  <daniel.everett@arm.com>
10382             Nick Forrington  <nick.forrington@arm.com>
10383             Richard Bunt  <richard.bunt@arm.com>
10384
10385         * cp-valprint.c (cp_print_value_fields): Allow an additional level
10386         of depth when printing anonymous structs or unions.
10387         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10388         Don't print either the top-level value, or the children if the
10389         max-depth is exceeded.
10390         (ppscm_print_children): When printing the key of a map, allow one
10391         extra level of depth.
10392         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10393         print either the top-level value, or the children if the max-depth
10394         is exceeded.
10395         (print_children): When printing the key of a map, allow one extra
10396         level of depth.
10397         * python/py-value.c (valpy_format_string): Add max_depth keyword.
10398         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10399         (user_print_options): Initialise max_depth field.
10400         (val_print_scalar_or_string_type_p): New function.
10401         (val_print): Check to see if the max depth has been reached.
10402         (val_print_check_max_depth): Define new function.
10403         (show_print_max_depth): New function.
10404         (_initialize_valprint): Add 'print max-depth' option.
10405         * valprint.h (struct value_print_options) <max_depth>: New field.
10406         (val_print_check_max_depth): Declare new function.
10407         * NEWS: Document new feature.
10408
10409 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10410
10411         * ada-lang.c (ada_language_defn): Initialise new field.
10412         * c-lang.c (c_is_string_type_p): New function.
10413         (c_language_defn): Initialise new field.
10414         (cplus_language_defn): Initialise new field.
10415         (asm_language_defn): Initialise new field.
10416         (minimal_language_defn): Initialise new field.
10417         * c-lang.h (c_is_string_type_p): Declare new function.
10418         * d-lang.c (d_language_defn): Initialise new field.
10419         * f-lang.c (f_is_string_type_p): New function.
10420         (f_language_defn): Initialise new field.
10421         * go-lang.c (go_is_string_type_p): New function.
10422         (go_language_defn): Initialise new field.
10423         * language.c (default_is_string_type_p): New function.
10424         (unknown_language_defn): Initialise new field.
10425         (auto_language_defn): Initialise new field.
10426         * language.h (struct language_defn) <la_is_string_type_p>: New
10427         member variable.
10428         (default_is_string_type_p): Declare new function.
10429         * m2-lang.c (m2_language_defn): Initialise new field.
10430         * objc-lang.c (objc_language_defn): Initialise new field.
10431         * opencl-lang.c (opencl_language_defn): Initialise new field.
10432         * p-lang.c (pascal_is_string_type_p): New function.
10433         (pascal_language_defn): Initialise new field.
10434         * rust-lang.c (rust_is_string_type_p): New function.
10435         (rust_language_defn): Initialise new field.
10436
10437 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10438
10439         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10440         New field.
10441         * ada-lang.c (ada_language_defn): Initialise new field.
10442         * c-lang.c (c_language_defn): Likewise.
10443         (cplus_language_defn): Likewise.
10444         (asm_language_defn): Likewise.
10445         (minimal_language_defn): Likewise.
10446         * d-lang.c (d_language_defn): Likewise.
10447         * f-lang.c (f_language_defn): Likewise.
10448         * go-lang.c (go_language_defn): Likewise.
10449         * language.c (unknown_language_defn): Likewise.
10450         (auto_language_defn): Likewise.
10451         * m2-lang.c (m2_language_defn): Likewise.
10452         * objc-lang.c (objc_language_defn): Likewise.
10453         * opencl-lang.c (opencl_language_defn): Likewise.
10454         * p-lang.c (pascal_language_defn): Likewise.
10455         * rust-lang.c (rust_language_defn): Likewise.
10456
10457 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10458
10459         * ada-lang.c (ada_is_character_type): Change return type to bool.
10460         (ada_is_string_type): Likewise.
10461         * ada-lang.h (ada_is_character_type): Update declaration
10462         (ada_is_string_type): Likewise.
10463
10464 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10465
10466         Support style in 'frame|thread apply'
10467
10468         * gdbcmd.h (execute_command_to_string): New term_out parameter.
10469         * record.c (record_start, record_stop): Update callers of
10470         execute_command_to_string with false.
10471         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10472         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10473         methods.
10474         (class string_file): New constructor with term_out parameter.
10475         Override methods term_out and can_emit_style_escape.  New member
10476         term_out.
10477         (class stdio_file): Override can_emit_style_escape.
10478         (class tee_file): Override term_out and can_emit_style_escape.
10479         * utils.h (can_emit_style_escape): Remove.
10480         * utils.c (can_emit_style_escape): Likewise.
10481         Update all callers of can_emit_style_escape (SOMESTREAM) to
10482         SOMESTREAM->can_emit_style_escape.
10483         * source-cache.c (source_cache::get_source_lines): Likewise.
10484         * stack.c (frame_apply_command_count): Call execute_command_to_string
10485         passing the term_out characteristic of the current gdb_stdout.
10486         * thread.c (thr_try_catch_cmd): Likewise.
10487         * top.c (execute_command_to_string): pass term_out parameter
10488         to construct the string_file for the command output.
10489         * ui-file.c (term_cli_styling): New function (most code moved
10490         from utils.c can_emit_style_escape).
10491         (string_file::string_file, string_file::can_emit_style_escape,
10492         stdio_file::can_emit_style_escape, tee_file::term_out,
10493         tee_file::can_emit_style_escape): New functions.
10494
10495 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10496
10497         * NEWS: Mention the new set|show may-call-functions.
10498         * infcall.c (may_call_functions_p): New variable.
10499         (show_may_call_functions_p): New function.
10500         (call_function_by_hand_dummy): Throws an error if not
10501         may-call-functions.
10502         (_initialize_infcall): Call add_setshow_boolean_cmd for
10503         may-call-functions.
10504
10505 2019-04-25  Keith Seitz  <keiths@redhat.com>
10506
10507         PR c++/24367
10508         * cp-support.c (inspect_type): Don't attempt substitutions
10509         of symbol with the same name.
10510
10511 2019-04-25  Tom Tromey  <tromey@adacore.com>
10512
10513         PR gdb/24475:
10514         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10515         static.
10516
10517 2019-04-25  Tom Tromey  <tromey@adacore.com>
10518
10519         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10520         rvalue reference.
10521         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10522         (gdb_xml_parser::parse): Use std::move.
10523         * python/python-internal.h (gdbpy_convert_exception): Take a const
10524         reference.
10525         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10526         std::move.
10527         * python/py-utils.c (gdbpy_convert_exception): Take a const
10528         reference.
10529         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10530         Use std::move.
10531         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10532         Use std::move.
10533         * mi/mi-main.c (mi_print_exception): Take a const reference.
10534         * main.c (handle_command_errors): Take a const reference.
10535         * linespec.c (parse_linespec): Use std::move.
10536         * infcall.c (run_inferior_call): Use std::move.
10537         (call_function_by_hand_dummy): Use std::move.
10538         * exec.c (try_open_exec_file): Use std::move.
10539         * exceptions.h (exception_print, exception_fprintf)
10540         (exception_print_same): Update.
10541         * exceptions.c (print_exception, exception_print)
10542         (exception_fprintf, exception_print_same): Change parameters to
10543         const reference.
10544         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10545         * common/new-op.c: Use std::move.
10546         * common/common-exceptions.h (struct gdb_exception): Add move
10547         constructor.
10548         (struct gdb_exception_error, struct gdb_exception_quit, struct
10549         gdb_quit_bad_alloc): Change constructor to move constructor.
10550         (throw_exception): Change parameter to rvalue reference.
10551         * common/common-exceptions.c (throw_exception): Take rvalue
10552         reference.
10553         * cli/cli-interp.c (safe_execute_command): Use std::move.
10554         * breakpoint.c (insert_bp_location, location_to_sals): Use
10555         std::move.
10556
10557 2019-04-25  Tom Tromey  <tromey@adacore.com>
10558
10559         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10560         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10561         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10562         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10563         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10564         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10565         guile/scm-value.c: Use unpack.
10566         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10567         gdbscm_gdb_exception.
10568         (gdbscm_throw_gdb_exception): Likewise.
10569         (struct gdbscm_gdb_exception): New.
10570         (unpack): New function.
10571         (gdbscm_wrap): Use unpack.
10572
10573 2019-04-25  Tom Tromey  <tromey@adacore.com>
10574
10575         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10576         (gdb_rl_callback_handler): Use std::move.
10577         * common/common-exceptions.h (struct gdb_exception): Add move
10578         assignment operator.
10579         (throw_exception_sjlj): Change "exception" to const reference.
10580         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10581         (throw_exception_sjlj): Change "exception" to const reference.
10582
10583 2019-04-25  Tom Tromey  <tromey@adacore.com>
10584
10585         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10586         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10587         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10588         Update.
10589         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10590         Update.
10591         * mi/mi-interp.c (mi_interp::exec): Update.
10592         * linespec.c (parse_linespec): Update.
10593         * infcall.c (run_inferior_call): Update.
10594         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10595         * guile/scm-symbol.c (gdbscm_lookup_symbol)
10596         (gdbscm_lookup_global_symbol): Update.
10597         * guile/scm-param.c (gdbscm_parameter_value): Update.
10598         * guile/scm-frame.c (gdbscm_frame_read_register)
10599         (gdbscm_frame_read_var): Update.
10600         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10601         * exec.c (try_open_exec_file): Update.
10602         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10603         (gdb_rl_callback_handler): Update.
10604         * common/common-exceptions.h (exception_none): Don't declare.
10605         * common/common-exceptions.c (exception_none): Don't define.
10606         (struct catcher) <exception>: Update.
10607         * cli/cli-interp.c (safe_execute_command): Update.
10608         * breakpoint.c (insert_bp_location, location_to_sals): Update.
10609
10610 2019-04-25  Ali Tamur  <tamur@google.com>
10611
10612         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10613         (read_attribute_value): Likewise.
10614         (dwarf2_read_addr_index): Update comment.
10615         (read_str_index): Add DW_FORM_strx.
10616         (dwarf2_string_attr): Likewise.
10617         (dwarf2_const_value_attr): Likewise.
10618         (dump_die_shallow): Likewise.
10619         (dwarf2_fetch_constant_bytes): Likewise.
10620         (skip_form_bytes): Likewise.
10621         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10622
10623 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
10624
10625         PR corefiles/11608
10626         PR corefiles/18187
10627         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10628         OFFSET.  Verify if current mapping contains an ELF header.
10629         (linux_find_memory_regions_full): Adjust call to
10630         dump_mapping_p.
10631
10632 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
10633             Kang Li <kanglictf@gmail.com>
10634
10635         PR gdb/21600
10636
10637         * dwarf2-frame.c (read_initial_length): Be consistent about using
10638         unsigned representation of length.
10639         (decode_frame_entry_1): Likewise.  Check for wraparound of
10640         end pointer as well as buffer overflow.
10641
10642 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
10643
10644         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10645         "vq".
10646
10647 2019-04-24  Tom Tromey  <tromey@adacore.com>
10648
10649         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10650
10651 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10652
10653         * s12z-tdep.c (s12z_unwind_pc): Delete.
10654         (s12z_unwind_sp): Delete.
10655         (s12z_gdbarch_init): Don't register deleted functions with
10656         gdbarch.
10657
10658 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10659
10660         * rl78-tdep.c (rl78_unwind_sp): Delete.
10661         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10662
10663 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10664
10665         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10666         (xstormy16_unwind_pc): Delete.
10667         (xstormy16_dummy_id): Delete.
10668         (xstormy16_gdbarch_init): Don't register deleted functions with
10669         gdbarch.
10670
10671 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10672
10673         * vax-tdep.c (vax_unwind_pc): Delete.
10674         (vax_gdbarch_init): Don't register deleted function with gdbarch.
10675
10676 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10677
10678         * v850-tdep.c (v850_unwind_sp): Delete.
10679         (v850_unwind_pc): Delete.
10680         (v850_dummy_id): Delete.
10681         (v850_gdbarch_init): Don't register deleted functions with
10682         gdbarch.
10683
10684 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10685
10686         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10687         (tilegx_unwind_pc): Delete.
10688         (tilegx_unwind_dummy_id): Delete.
10689         (tilegx_gdbarch_init): Don't register deleted functions with
10690         gdbarch.
10691
10692 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10693
10694         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10695         (tic6x_dummy_id): Delete.
10696         (tic6x_gdbarch_init): Don't register deleted functions with
10697         gdbarch.
10698
10699 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10700
10701         * sparc-tdep.c (sparc_unwind_pc): Delete.
10702         (sparc32_gdbarch_init): Don't register deleted function with
10703         gdbarch.
10704
10705 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10706
10707         * sh-tdep.c (sh_unwind_sp): Delete.
10708         (sh_unwind_pc): Delete.
10709         (sh_dummy_id): Delete.
10710         (sh_gdbarch_init): Don't register deleted functions with
10711         gdbarch.
10712
10713 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10714
10715         * score-tdep.c (score_unwind_sp): Delete.
10716         (score_unwind_pc): Delete.
10717         (score_dummy_id): Delete.
10718         (score_gdbarch_init): Don't register deleted functions with
10719         gdbarch.
10720
10721 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10722
10723         * rx-tdep.c (rx_unwind_pc): Delete.
10724         (rx_unwind_sp): Delete.
10725         (rx_dummy_id): Delete.
10726         (rx_gdbarch_init): Don't register deleted functions with
10727         gdbarch.  Update comment.
10728
10729 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10730
10731         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10732         (rs6000_dummy_id): Delete.
10733         (rs6000_gdbarch_init): Don't register deleted functions with
10734         gdbarch.
10735
10736 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10737
10738         * or1k-tdep.c (or1k_dummy_id): Delete.
10739         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10740
10741 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10742
10743         * nios2-tdep.c (nios2_dummy_id): Delete.
10744         (nios2_unwind_sp): Delete.
10745         (nios2_gdbarch_init): Don't register deleted functions with
10746         gdbarch.
10747
10748 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10749
10750         * nds32-tdep.c (nds32_dummy_id): Delete.
10751         (nds32_unwind_pc): Delete.
10752         (nds32_unwind_sp): Delete.
10753         (nds32_gdbarch_init): Don't register deleted functions with
10754         gdbarch.
10755
10756 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10757
10758         * msp430-tdep.c (msp430_unwind_pc): Delete.
10759         (msp430_unwind_sp): Delete.
10760         (msp430_dummy_id): Delete.
10761         (msp430_gdbarch_init): Don't register deleted functions with
10762         gdbarch.
10763
10764 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10765
10766         * moxie-tdep.c (moxie_unwind_sp): Delete.
10767         (moxie_unwind_pc): Delete.
10768         (moxie_dummy_id): Delete.
10769         (moxie_gdbarch_init): Don't register deleted functions with
10770         gdbarch.
10771
10772 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10773
10774         * mn10300-tdep.c (mn10300_dummy_id): Delete.
10775         (mn10300_unwind_pc): Delete.
10776         (mn10300_unwind_sp): Delete.
10777         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10778         mn10300_unwind_sp.
10779         (mn10300_frame_unwind_init): Don't register deleted functions with
10780         gdbarch.
10781
10782 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10783
10784         * mep-tdep.c (mep_unwind_pc): Delete.
10785         (mep_unwind_sp): Delete.
10786         (mep_dummy_id): Delete.
10787         (mep_gdbarch_init): Don't register deleted functions with
10788         gdbarch.
10789
10790 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10791
10792         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10793         (m68hc11_unwind_sp): Delete.
10794         (m68hc11_gdbarch_init): Don't register deleted functions with
10795         gdbarch.
10796
10797 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10798
10799         * m32r-tdep.c (m32r_unwind_sp): Delete.
10800         (m32r_unwind_pc): Delete.
10801         (m32r_dummy_id): Delete.
10802         (m32r_gdbarch_init): Don't register deleted functions with
10803         gdbarch.
10804
10805 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10806
10807         * m32c-tdep.c (m32c_unwind_pc): Delete.
10808         (m32c_unwind_sp): Delete.
10809         (m32c_dummy_id): Delete.
10810         (m32c_gdbarch_init): Don't register deleted functions with
10811         gdbarch.
10812
10813 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10814
10815         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10816         (lm32_unwind_pc): Delete.
10817         (lm32_dummy_id): Delete.
10818         (lm32_gdbarch_init): Don't register deleted functions with
10819         gdbarch.
10820
10821 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10822
10823         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10824         (iq2000_unwind_pc): Delete.
10825         (iq2000_dummy_id): Delete.
10826         (iq2000_gdbarch_init): Don't register deleted functions with
10827         gdbarch.
10828
10829 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10830
10831         * nds32-tdep.c (nds32_type_align): Delete.
10832         (nds32_push_dummy_call): Use type_align instead.
10833
10834 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10835
10836         * arm-tdep.c (arm_type_align): Only handle vector override case.
10837         (arm_push_dummy_call): Use type_align.
10838         (arm_gdbarch_init): Register arm_type_align gdbarch function.
10839
10840 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10841
10842         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10843         case.
10844         (pass_on_stack): Use type_align.
10845         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10846         function.
10847
10848 2019-04-23  Tom Tromey  <tromey@adacore.com>
10849
10850         * dwarf2read.c (line_header::file_name_at): Remove unused
10851         overload.
10852
10853 2019-04-23  Tom de Vries  <tdevries@suse.de>
10854
10855         PR gdb/24438
10856         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10857         invocation.
10858
10859
10860 2019-03-27  Ali Tamur  <tamur@google.com>
10861
10862         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10863         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10864         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10865         (dwarf_expr_context::get_addr_index): Likewise
10866         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10867         (symbol_needs_eval_context::get_addr_index): Likewise
10868         (disassemble_dwarf_expression): Add DW_OP_addrx
10869         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10870         (read_cutu_die_from_dwo): Update comment
10871         (skip_one_die): Add DW_FORM_addrx
10872         (read_attribute_value): Likewise
10873         (var_decode_location): Add DW_OP_addrx
10874         (dwarf2_const_value_attr): Add DW_FORM_addrx
10875         (dump_die_shallow): Likewise
10876         (dwarf2_fetch_constant_bytes): Likewise
10877         (decode_locdesc): Add DW_OP_addrx
10878         (skip_form_bytes): Add DW_FORM_addrx
10879
10880 2019-04-22  Ali Tamur  <tamur@google.com>
10881
10882         * MAINTAINERS (Write After Approval): Add self.
10883
10884 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
10885
10886         * solib-svr4.c (get_svr4_info): Add pspace parameter.
10887         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10888         (open_symbol_file_object): Likewise.
10889         (svr4_default_sos): Add info parameter.
10890         (svr4_read_so_list): Likewise.
10891         (svr4_current_sos_direct): Adjust functions calls to pass down
10892         info.
10893         (svr4_current_sos_1): Add info parameter.
10894         (svr4_current_sos): Call get_svr4_info, pass info down to
10895         svr4_current_sos_1.
10896         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10897         get_svr4_info.
10898         (svr4_in_dynsym_resolve_code): Pass current_program_space to
10899         get_svr4_info.
10900         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10901         to get_svr4_info.
10902         (probes_table_remove_objfile_probes): Likewise.
10903         (register_solib_event_probe): Add info parameter.
10904         (solist_update_incremental): Pass info parameter down to
10905         svr4_read_so_list.
10906         (disable_probes_interface): Add info parameter.
10907         (svr4_handle_solib_event): Pass current_program_space to
10908         get_svr4_info.  Adjust disable_probes_interface cleanup.
10909         (svr4_create_probe_breakpoints): Add info parameter, pass it
10910         down to register_solib_event_probe.
10911         (svr4_create_solib_event_breakpoints): Add info parameter,
10912         pass it down to svr4_create_probe_breakpoints.
10913         (enable_break): Pass info down to
10914         svr4_create_solib_event_breakpoints.
10915         (svr4_solib_create_inferior_hook): Pass current_program_space to
10916         get_svr4_info.
10917         (svr4_clear_solib): Likewise.
10918
10919 2019-04-22  Pedro Alves  <palves@redhat.com>
10920
10921         * solib-svr4.c (svr4_free_objfile_observer): New.
10922         (probe_and_action::objfile): New field.
10923         (probes_table_htab_remove_objfile_probes)
10924         (probes_table_remove_objfile_probes): New functions.
10925         (register_solib_event_probe): Add 'objfile' parameter.  Store it
10926         in the new probe_and_action.  Don't store the probe in 'lookup'.
10927         (svr4_create_probe_breakpoints): Pass objfile to
10928         register_solib_event_probe.
10929         (_initialize_svr4_solib): Register a free_objfile observer.
10930
10931 2019-04-19  Tom Tromey  <tom@tromey.com>
10932
10933         * common/queue.h: Remove.
10934
10935 2019-04-19  Tom Tromey  <tom@tromey.com>
10936
10937         * event-loop.c: Don't include "common/queue.h".
10938
10939 2019-04-19  Tom Tromey  <tom@tromey.com>
10940
10941         * remote.c (remote_target): Use delete.
10942         * remote-notif.h: Include <list>, not "common/queue.h".
10943         (notif_client_p): Remove typedef.
10944         (remote_notif_state): Add constructor, destructor, initializer.
10945         <notif_queue>: Now a std::list.
10946         (remote_notif_state_xfree): Don't declare.
10947         * remote-notif.c (remote_notif_process, handle_notification)
10948         (remote_notif_state_allocate): Update.
10949         (~remote_notif_state): Rename from remote_notif_state_xfree.
10950
10951 2019-04-19  Tom Tromey  <tom@tromey.com>
10952
10953         * symfile.c (reread_symbols): Update.
10954         * objfiles.c (objfile_register_static_link)
10955         (objfile_lookup_static_link): Update
10956         (~objfile) Don't delete static_links.
10957         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
10958
10959 2019-04-19  Tom Tromey  <tom@tromey.com>
10960
10961         * type-stack.h (struct type_stack) <insert>: Constify string.
10962         * type-stack.c (type_stack::insert): Constify string.
10963         * gdbtypes.h (lookup_template_type): Update.
10964         (address_space_name_to_int): Update.
10965         * gdbtypes.c (address_space_name_to_int): Make space_identifier
10966         const.
10967         (lookup_template_type): Make name const.
10968         * c-exp.y: Update rules.
10969         (lex_one_token, classify_name, classify_inner_name)
10970         (c_print_token): Update.
10971         * p-exp.y: Update rules.
10972         (yylex): Update.
10973         * f-exp.y: Update rules.
10974         (yylex): Update.
10975         * d-exp.y: Update rules.
10976         (lex_one_token, classify_name, classify_inner_name): Update.
10977         * parse.c (write_dollar_variable, copy_name): Return std::string.
10978         * parser-defs.h (copy_name): Change return type.
10979         * m2-exp.y: Update rules.
10980         (yylex): Update.
10981         * go-exp.y (lex_one_token): Update.
10982         Update rules.
10983         (classify_unsafe_function, classify_packaged_name)
10984         (classify_name, yylex): Update.
10985
10986 2019-04-19  Sergei Trofimovich <siarheit@google.com>
10987
10988         * configure.ac: add --enable-source-highlight switch.
10989         * configure: Regenerate.
10990         * top.c (print_gdb_version): plumb --enable-source-highlight
10991         status to "show configuration".
10992
10993 2019-04-19  Tom Tromey  <tromey@adacore.com>
10994
10995         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
10996         Check ADA_TYPE_P.
10997         (empty_record, ada_template_to_fixed_record_type_1)
10998         (template_to_static_fixed_type)
10999         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11000         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11001         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11002         macros.
11003
11004 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11005
11006         PR symtab/24423:
11007         * source.c (print_source_lines_base): Advance "iter" when a
11008         control character is seen.
11009
11010 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11011
11012         * inferior.h (struct infcall_suspend_state_deleter):
11013         Catch exception in destructor to avoid crash.
11014
11015 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11016
11017         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11018         close to the add_com "shell".
11019
11020 2019-04-18  Tom Tromey  <tromey@adacore.com>
11021
11022         * process-stratum-target.h (class process_stratum_target)
11023         <stratum>: Add "final".
11024
11025 2019-04-17  Tom Tromey  <tromey@adacore.com>
11026
11027         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11028         against nullptr before use.
11029
11030 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11031
11032         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11033
11034 2019-04-17  Jim Wilson  <jimw@sifive.com>
11035             Andrew Burgess  <andrew.burgess@embecosm.com>
11036
11037         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11038         code read might fail, assume 4-byte breakpoint in that case.
11039
11040 2019-04-15  Leszek Swirski  <leszeks@google.com>
11041
11042         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11043         rather than a hand-rolled POD check when checking for forced MEMORY
11044         classification.
11045
11046 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11047
11048         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11049         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11050         function.
11051         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11052         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11053         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11054         declaration.
11055
11056 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11057
11058         * aarch64-linux-nat.c
11059         (aarch64_linux_nat_target::thread_architecture): Add override.
11060         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11061         each VQ.
11062
11063 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11064
11065         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11066
11067 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11068
11069         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11070         target types of size 96-bits, add some additional comments, and
11071         check that the builtin type we found was the correct size.
11072
11073 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11074
11075         * utils.c (prompt_for_continue): Don't restore the styling at the
11076         end, as applied_style has the wrong value.  This fixes styling in
11077         long lists of file names that are interrupted by the "Continue?"
11078         prompt.
11079
11080 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11081
11082         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11083         * c-lang.c (c_language_defn): Likewise.
11084         (cplus_language_defn): Likewise.
11085         (asm_language_defn): Likewise.
11086         (minimal_language_defn): Likewise.
11087         * d-lang.c (d_language_defn): Likewise.
11088         * f-lang.c (f_language_defn): Likewise.
11089         * go-lang.c (go_language_defn): Likewise.
11090         * language.c (unknown_language_defn): Likewise.
11091         (auto_language_defn): Likewise.
11092         * language.h (struct language_defn): Remove la_magic field.
11093         (LANG_MAGIC): Delete.
11094         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11095         * objc-lang.c (objc_language_defn): Likewise.
11096         * opencl-lang.c (opencl_language_defn): Likewise.
11097         * p-lang.c (pascal_language_defn): Likewise.
11098         * rust-lang.c (rust_language_defn): Likewise.
11099
11100 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11101
11102         * riscv-tdep.c (riscv_type_align): New function.
11103         (riscv_type_alignment): Delete.
11104         (riscv_arg_location): Use 'type_align'.
11105         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11106
11107 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11108
11109         * gdbtypes.c (type_align): A struct with no non-static fields also
11110         has alignment of 1.
11111
11112 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11113
11114         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11115         component to 0.
11116         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11117         member.
11118         (riscv_struct_info::analyse): New implementation using new
11119         analyse_inner member function.
11120         (riscv_struct_info::field_offset): New member function.
11121         (riscv_struct_info::m_offsets): New member variable.
11122         (riscv_struct_info::analyse_inner): New private member function,
11123         takes the old implementation of riscv_struct_info::analyse but
11124         extended to track field offsets.
11125         (riscv_call_arg_struct): Update the struct folding special cases
11126         to handle cases where empty C++ structs, which are non-zero
11127         length, are found.
11128         (riscv_arg_location): Initialise the length of each location, a
11129         non-zero length now indicates the location is in use.
11130         (riscv_push_dummy_call): Allow for the first location having a
11131         non-zero offset when setting up arguments.
11132         (riscv_return_value): Likewise, but for return values.
11133
11134 2019-04-11  Tom Tromey  <tromey@adacore.com>
11135
11136         * utils.c (internal_vproblem): Make "msg" const.
11137
11138 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11139
11140         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11141         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11142         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11143         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11144
11145 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11146
11147         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11148         function.
11149         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11150         of amd64_collect_native_gregset.
11151         (amd64_linux_nat_target::store_registers): Likewise.
11152
11153 2019-04-10  Tom Tromey  <tom@tromey.com>
11154
11155         * symtab.c (lookup_global_symbol_from_objfile)
11156         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11157         * objfiles.h (class separate_debug_iterator): New.
11158         (class separate_debug_range): New.
11159         (struct objfile) <separate_debug_objfiles>: New method.
11160         (objfile_separate_debug_iterate): Don't declare.
11161         * objfiles.c (separate_debug_iterator::operator++): Rename from
11162         objfile_separate_debug_iterate.
11163         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11164         iterator.
11165         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11166         iterator.
11167
11168 2019-04-10  Tom Tromey  <tom@tromey.com>
11169
11170         * symfile.c (reread_symbols): Remove old comment.
11171         * objfiles.c (free_all_objfiles): Fix a typo.
11172
11173 2019-04-10  Tom Tromey  <tom@tromey.com>
11174
11175         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11176         * minsyms.c (lookup_minimal_symbol): Use foreach.
11177         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11178         (lookup_minimal_symbol_solib_trampoline): Likewise.
11179         * symfile.c (reread_symbols): Use foreach.
11180
11181 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
11182             Tom Tromey  <tromey@adacore.com>
11183
11184         PR rust/24414:
11185         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11186         (rust_lex_int_test): Change "value" to be LONGEST.
11187         (rust_lex_tests): Add test for long integer literal.
11188
11189 2019-04-09  Tom Tromey  <tromey@adacore.com>
11190
11191         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11192         to bool.
11193         (extended_remote_target::attach): Update.
11194         (remote_target::remote_notice_new_inferior): Update.
11195         (remote_target::add_current_inferior_and_thread): Update.
11196         * inferior.c (exit_inferior_1): Use "false".
11197         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11198
11199 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11200
11201         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11202         the "start" command.
11203
11204 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11205
11206         * python/py-inferior.c (infpy_thread_from_thread_handle):
11207         Adjust comments to reflect renaming of thread_from_thread_handle
11208         to thread_from_handle.  Adjust keywords.  Fix type error message.
11209         (inferior_object_methods): Add thread_from_handle.  Retain
11210         thread_from_thread_handle, but mark it as deprecated.
11211
11212 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11213
11214         * gdbthread.h (find_thread_by_handle): Revise declaration.
11215         * thread.c (find_thread_by_handle): Likewise.  Adjust
11216         implementation too.
11217         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11218         support for buffer objects as handles.
11219
11220 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11221
11222         * python/py-infthread.c (thpy_thread_handle): New function.
11223         (thread_object_methods): Register thpy_thread_handle.
11224
11225 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11226
11227         * gdbthread.h (thread_to_thread_handle): Declare.
11228         * thread.c (gdbtypes.h): Include.
11229         (thread_to_thread_handle): New function.
11230
11231         * target.h (struct target_ops): Add thread_info_to_thread_handle.
11232         (target_thread_info_to_thread_handle): Declare.
11233         * target.c (target_thread_info_to_thread_handle): New function.
11234         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11235         * target-delegates.c: Regenerate.
11236
11237         * linux-thread-db.c (class thread_db_target): Add method
11238         thread_info_to_thread_handle.
11239         (thread_db_target::thread_info_to_thread_handle): Define.
11240         * remote.c (class remote_target): Add new method
11241         thread_info_to_thread_handle.
11242         (remote_target::thread_info_to_thread_handle): Define.
11243
11244 2019-04-08  Pedro Alves  <palves@redhat.com>
11245
11246         * common/common-exceptions.c (throw_exception): Don't create
11247         named object to throw; throw directly.
11248         (throw_it): Likewise.  Don't initialize gdb_exception::message
11249         here, with new; pass FMT and AP to the ctor instead.
11250         * common/common-exceptions.h: Include <string>.
11251         (gdb_exception::gdb_exception(enum return_reason, enum errors,
11252         const char *, va_list)): New ctor.  Use std::make_shared.
11253         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11254         errors)): Delete.
11255         (gdb_exception_error::gdb_exception_error(enum errors, const char
11256         *, va_list)): New.
11257         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11258         Add assertion.
11259         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11260         errors)): Delete.
11261         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11262         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11263         Add assertion.
11264
11265 2019-04-08  Tom Tromey  <tom@tromey.com>
11266
11267         * valops.c (value_rtti_indirect_type): Replace throw_exception
11268         with throw.
11269         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11270         with throw.
11271         * thread.c (thr_try_catch_cmd): Replace throw_exception with
11272         throw.
11273         * target.c (target_translate_tls_address): Replace throw_exception
11274         with throw.
11275         * stack.c (frame_apply_command_count): Replace throw_exception
11276         with throw.
11277         * solib-spu.c (append_ocl_sos): Replace throw_exception with
11278         throw.
11279         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11280         with throw.
11281         * rs6000-tdep.c (rs6000_frame_cache)
11282         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11283         * remote.c: Replace throw_exception with throw.
11284         * record-full.c (record_full_message, record_full_wait_1)
11285         (record_full_restore): Replace throw_exception with throw.
11286         * record-btrace.c:
11287         (get_thread_current_frame_id, record_btrace_start_replaying)
11288         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11289         (cmd_record_btrace_start): Replace throw_exception with throw.
11290         * parse.c (parse_exp_in_context_1): Replace throw_exception with
11291         throw.
11292         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11293         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11294         * linespec.c:
11295         (find_linespec_symbols): Replace throw_exception with throw.
11296         * infrun.c (displaced_step_prepare, resume): Replace
11297         throw_exception with throw.
11298         * infcmd.c (post_create_inferior): Replace throw_exception with
11299         throw.
11300         * inf-loop.c (inferior_event_handler): Replace throw_exception
11301         with throw.
11302         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11303         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11304         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11305         (get_prev_frame_always, get_frame_pc_if_available)
11306         (get_frame_address_in_block_if_available, get_frame_language):
11307         Replace throw_exception with throw.
11308         * frame-unwind.c (frame_unwind_try_unwinder): Replace
11309         throw_exception with throw.
11310         * eval.c (fetch_subexp_value, evaluate_var_value)
11311         (evaluate_funcall, evaluate_subexp_standard): Replace
11312         throw_exception with throw.
11313         * dwarf2loc.c (call_site_find_chain)
11314         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11315         Replace throw_exception with throw.
11316         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11317         with throw.
11318         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11319         throw.
11320         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11321         * completer.c (complete_line_internal): Replace throw_exception
11322         with throw.
11323         * compile/compile-object-run.c (compile_object_run): Replace
11324         throw_exception with throw.
11325         * cli/cli-script.c (process_next_line): Replace throw_exception
11326         with throw.
11327         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11328         (btrace_enable, btrace_maint_update_pt_packets): Replace
11329         throw_exception with throw.
11330         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11331         throw_exception with throw.
11332         * break-catch-throw.c (re_set_exception_catchpoint): Replace
11333         throw_exception with throw.
11334         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11335         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11336         * aarch64-tdep.c (aarch64_make_prologue_cache)
11337         (aarch64_make_stub_cache): Replace throw_exception with throw.
11338
11339 2019-04-08  Tom Tromey  <tom@tromey.com>
11340
11341         * common/common-exceptions.c (throw_exception): Rename from
11342         throw_exception_cxx.  Remove old copy.  Make argument const.
11343         (throw_it): Create and throw exception objects directly.
11344         * common/common-exceptions.h (throw_exception): Make argument
11345         const.
11346         (struct gdb_exception_error): Add constructor.
11347         (struct gdb_exception_quit): Add constructor.
11348
11349 2019-04-08  Tom Tromey  <tom@tromey.com>
11350
11351         * common/common-exceptions.h (exception_rethrow): Don't declare.
11352         (TRY_SJLJ): Update comment.
11353         (TRY, CATCH, END_CATCH): Remove.
11354         * common/common-exceptions.c (exception_rethrow): Remove.
11355
11356 2019-04-08  Tom Tromey  <tom@tromey.com>
11357
11358         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11359         Remove.
11360         (gdb_exception_error): Rename from
11361         gdb_exception_RETURN_MASK_ERROR.
11362         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11363         (gdb_quit_bad_alloc): Update.
11364         * aarch64-tdep.c: Update.
11365         * ada-lang.c: Update.
11366         * ada-typeprint.c: Update.
11367         * ada-valprint.c: Update.
11368         * amd64-tdep.c: Update.
11369         * arch-utils.c: Update.
11370         * break-catch-throw.c: Update.
11371         * breakpoint.c: Update.
11372         * btrace.c: Update.
11373         * c-varobj.c: Update.
11374         * cli/cli-cmds.c: Update.
11375         * cli/cli-interp.c: Update.
11376         * cli/cli-script.c: Update.
11377         * common/common-exceptions.c: Update.
11378         * common/new-op.c: Update.
11379         * common/selftest.c: Update.
11380         * compile/compile-c-symbols.c: Update.
11381         * compile/compile-cplus-symbols.c: Update.
11382         * compile/compile-object-load.c: Update.
11383         * compile/compile-object-run.c: Update.
11384         * completer.c: Update.
11385         * corelow.c: Update.
11386         * cp-abi.c: Update.
11387         * cp-support.c: Update.
11388         * cp-valprint.c: Update.
11389         * darwin-nat.c: Update.
11390         * disasm-selftests.c: Update.
11391         * dtrace-probe.c: Update.
11392         * dwarf-index-cache.c: Update.
11393         * dwarf-index-write.c: Update.
11394         * dwarf2-frame-tailcall.c: Update.
11395         * dwarf2-frame.c: Update.
11396         * dwarf2loc.c: Update.
11397         * dwarf2read.c: Update.
11398         * eval.c: Update.
11399         * event-loop.c: Update.
11400         * event-top.c: Update.
11401         * exec.c: Update.
11402         * f-valprint.c: Update.
11403         * fbsd-tdep.c: Update.
11404         * frame-unwind.c: Update.
11405         * frame.c: Update.
11406         * gdbtypes.c: Update.
11407         * gnu-v3-abi.c: Update.
11408         * guile/guile-internal.h: Update.
11409         * guile/scm-block.c: Update.
11410         * guile/scm-breakpoint.c: Update.
11411         * guile/scm-cmd.c: Update.
11412         * guile/scm-disasm.c: Update.
11413         * guile/scm-frame.c: Update.
11414         * guile/scm-lazy-string.c: Update.
11415         * guile/scm-math.c: Update.
11416         * guile/scm-param.c: Update.
11417         * guile/scm-ports.c: Update.
11418         * guile/scm-pretty-print.c: Update.
11419         * guile/scm-symbol.c: Update.
11420         * guile/scm-symtab.c: Update.
11421         * guile/scm-type.c: Update.
11422         * guile/scm-value.c: Update.
11423         * i386-linux-tdep.c: Update.
11424         * i386-tdep.c: Update.
11425         * inf-loop.c: Update.
11426         * infcall.c: Update.
11427         * infcmd.c: Update.
11428         * infrun.c: Update.
11429         * jit.c: Update.
11430         * language.c: Update.
11431         * linespec.c: Update.
11432         * linux-fork.c: Update.
11433         * linux-nat.c: Update.
11434         * linux-tdep.c: Update.
11435         * linux-thread-db.c: Update.
11436         * main.c: Update.
11437         * mi/mi-cmd-break.c: Update.
11438         * mi/mi-cmd-stack.c: Update.
11439         * mi/mi-interp.c: Update.
11440         * mi/mi-main.c: Update.
11441         * objc-lang.c: Update.
11442         * p-valprint.c: Update.
11443         * parse.c: Update.
11444         * ppc-linux-tdep.c: Update.
11445         * printcmd.c: Update.
11446         * python/py-arch.c: Update.
11447         * python/py-breakpoint.c: Update.
11448         * python/py-cmd.c: Update.
11449         * python/py-finishbreakpoint.c: Update.
11450         * python/py-frame.c: Update.
11451         * python/py-framefilter.c: Update.
11452         * python/py-gdb-readline.c: Update.
11453         * python/py-inferior.c: Update.
11454         * python/py-infthread.c: Update.
11455         * python/py-lazy-string.c: Update.
11456         * python/py-linetable.c: Update.
11457         * python/py-objfile.c: Update.
11458         * python/py-param.c: Update.
11459         * python/py-prettyprint.c: Update.
11460         * python/py-progspace.c: Update.
11461         * python/py-record-btrace.c: Update.
11462         * python/py-record.c: Update.
11463         * python/py-symbol.c: Update.
11464         * python/py-type.c: Update.
11465         * python/py-unwind.c: Update.
11466         * python/py-utils.c: Update.
11467         * python/py-value.c: Update.
11468         * python/python.c: Update.
11469         * record-btrace.c: Update.
11470         * record-full.c: Update.
11471         * remote-fileio.c: Update.
11472         * remote.c: Update.
11473         * riscv-tdep.c: Update.
11474         * rs6000-aix-tdep.c: Update.
11475         * rs6000-tdep.c: Update.
11476         * rust-exp.y: Update.
11477         * rust-lang.c: Update.
11478         * s390-tdep.c: Update.
11479         * selftest-arch.c: Update.
11480         * solib-dsbt.c: Update.
11481         * solib-frv.c: Update.
11482         * solib-spu.c: Update.
11483         * solib-svr4.c: Update.
11484         * solib.c: Update.
11485         * sparc64-linux-tdep.c: Update.
11486         * stack.c: Update.
11487         * symfile-mem.c: Update.
11488         * symmisc.c: Update.
11489         * target.c: Update.
11490         * thread.c: Update.
11491         * top.c: Update.
11492         * tracefile-tfile.c: Update.
11493         * tui/tui.c: Update.
11494         * typeprint.c: Update.
11495         * unittests/cli-utils-selftests.c: Update.
11496         * unittests/parse-connection-spec-selftests.c: Update.
11497         * valops.c: Update.
11498         * valprint.c: Update.
11499         * value.c: Update.
11500         * varobj.c: Update.
11501         * windows-nat.c: Update.
11502         * x86-linux-nat.c: Update.
11503         * xml-support.c: Update.
11504
11505 2019-04-08  Tom Tromey  <tom@tromey.com>
11506
11507         * xml-support.c: Use C++ exception handling.
11508         * x86-linux-nat.c: Use C++ exception handling.
11509         * windows-nat.c: Use C++ exception handling.
11510         * varobj.c: Use C++ exception handling.
11511         * value.c: Use C++ exception handling.
11512         * valprint.c: Use C++ exception handling.
11513         * valops.c: Use C++ exception handling.
11514         * unittests/parse-connection-spec-selftests.c: Use C++ exception
11515         handling.
11516         * unittests/cli-utils-selftests.c: Use C++ exception handling.
11517         * typeprint.c: Use C++ exception handling.
11518         * tui/tui.c: Use C++ exception handling.
11519         * tracefile-tfile.c: Use C++ exception handling.
11520         * top.c: Use C++ exception handling.
11521         * thread.c: Use C++ exception handling.
11522         * target.c: Use C++ exception handling.
11523         * symmisc.c: Use C++ exception handling.
11524         * symfile-mem.c: Use C++ exception handling.
11525         * stack.c: Use C++ exception handling.
11526         * sparc64-linux-tdep.c: Use C++ exception handling.
11527         * solib.c: Use C++ exception handling.
11528         * solib-svr4.c: Use C++ exception handling.
11529         * solib-spu.c: Use C++ exception handling.
11530         * solib-frv.c: Use C++ exception handling.
11531         * solib-dsbt.c: Use C++ exception handling.
11532         * selftest-arch.c: Use C++ exception handling.
11533         * s390-tdep.c: Use C++ exception handling.
11534         * rust-lang.c: Use C++ exception handling.
11535         * rust-exp.y: Use C++ exception handling.
11536         * rs6000-tdep.c: Use C++ exception handling.
11537         * rs6000-aix-tdep.c: Use C++ exception handling.
11538         * riscv-tdep.c: Use C++ exception handling.
11539         * remote.c: Use C++ exception handling.
11540         * remote-fileio.c: Use C++ exception handling.
11541         * record-full.c: Use C++ exception handling.
11542         * record-btrace.c: Use C++ exception handling.
11543         * python/python.c: Use C++ exception handling.
11544         * python/py-value.c: Use C++ exception handling.
11545         * python/py-utils.c: Use C++ exception handling.
11546         * python/py-unwind.c: Use C++ exception handling.
11547         * python/py-type.c: Use C++ exception handling.
11548         * python/py-symbol.c: Use C++ exception handling.
11549         * python/py-record.c: Use C++ exception handling.
11550         * python/py-record-btrace.c: Use C++ exception handling.
11551         * python/py-progspace.c: Use C++ exception handling.
11552         * python/py-prettyprint.c: Use C++ exception handling.
11553         * python/py-param.c: Use C++ exception handling.
11554         * python/py-objfile.c: Use C++ exception handling.
11555         * python/py-linetable.c: Use C++ exception handling.
11556         * python/py-lazy-string.c: Use C++ exception handling.
11557         * python/py-infthread.c: Use C++ exception handling.
11558         * python/py-inferior.c: Use C++ exception handling.
11559         * python/py-gdb-readline.c: Use C++ exception handling.
11560         * python/py-framefilter.c: Use C++ exception handling.
11561         * python/py-frame.c: Use C++ exception handling.
11562         * python/py-finishbreakpoint.c: Use C++ exception handling.
11563         * python/py-cmd.c: Use C++ exception handling.
11564         * python/py-breakpoint.c: Use C++ exception handling.
11565         * python/py-arch.c: Use C++ exception handling.
11566         * printcmd.c: Use C++ exception handling.
11567         * ppc-linux-tdep.c: Use C++ exception handling.
11568         * parse.c: Use C++ exception handling.
11569         * p-valprint.c: Use C++ exception handling.
11570         * objc-lang.c: Use C++ exception handling.
11571         * mi/mi-main.c: Use C++ exception handling.
11572         * mi/mi-interp.c: Use C++ exception handling.
11573         * mi/mi-cmd-stack.c: Use C++ exception handling.
11574         * mi/mi-cmd-break.c: Use C++ exception handling.
11575         * main.c: Use C++ exception handling.
11576         * linux-thread-db.c: Use C++ exception handling.
11577         * linux-tdep.c: Use C++ exception handling.
11578         * linux-nat.c: Use C++ exception handling.
11579         * linux-fork.c: Use C++ exception handling.
11580         * linespec.c: Use C++ exception handling.
11581         * language.c: Use C++ exception handling.
11582         * jit.c: Use C++ exception handling.
11583         * infrun.c: Use C++ exception handling.
11584         * infcmd.c: Use C++ exception handling.
11585         * infcall.c: Use C++ exception handling.
11586         * inf-loop.c: Use C++ exception handling.
11587         * i386-tdep.c: Use C++ exception handling.
11588         * i386-linux-tdep.c: Use C++ exception handling.
11589         * guile/scm-value.c: Use C++ exception handling.
11590         * guile/scm-type.c: Use C++ exception handling.
11591         * guile/scm-symtab.c: Use C++ exception handling.
11592         * guile/scm-symbol.c: Use C++ exception handling.
11593         * guile/scm-pretty-print.c: Use C++ exception handling.
11594         * guile/scm-ports.c: Use C++ exception handling.
11595         * guile/scm-param.c: Use C++ exception handling.
11596         * guile/scm-math.c: Use C++ exception handling.
11597         * guile/scm-lazy-string.c: Use C++ exception handling.
11598         * guile/scm-frame.c: Use C++ exception handling.
11599         * guile/scm-disasm.c: Use C++ exception handling.
11600         * guile/scm-cmd.c: Use C++ exception handling.
11601         * guile/scm-breakpoint.c: Use C++ exception handling.
11602         * guile/scm-block.c: Use C++ exception handling.
11603         * guile/guile-internal.h: Use C++ exception handling.
11604         * gnu-v3-abi.c: Use C++ exception handling.
11605         * gdbtypes.c: Use C++ exception handling.
11606         * frame.c: Use C++ exception handling.
11607         * frame-unwind.c: Use C++ exception handling.
11608         * fbsd-tdep.c: Use C++ exception handling.
11609         * f-valprint.c: Use C++ exception handling.
11610         * exec.c: Use C++ exception handling.
11611         * event-top.c: Use C++ exception handling.
11612         * event-loop.c: Use C++ exception handling.
11613         * eval.c: Use C++ exception handling.
11614         * dwarf2read.c: Use C++ exception handling.
11615         * dwarf2loc.c: Use C++ exception handling.
11616         * dwarf2-frame.c: Use C++ exception handling.
11617         * dwarf2-frame-tailcall.c: Use C++ exception handling.
11618         * dwarf-index-write.c: Use C++ exception handling.
11619         * dwarf-index-cache.c: Use C++ exception handling.
11620         * dtrace-probe.c: Use C++ exception handling.
11621         * disasm-selftests.c: Use C++ exception handling.
11622         * darwin-nat.c: Use C++ exception handling.
11623         * cp-valprint.c: Use C++ exception handling.
11624         * cp-support.c: Use C++ exception handling.
11625         * cp-abi.c: Use C++ exception handling.
11626         * corelow.c: Use C++ exception handling.
11627         * completer.c: Use C++ exception handling.
11628         * compile/compile-object-run.c: Use C++ exception handling.
11629         * compile/compile-object-load.c: Use C++ exception handling.
11630         * compile/compile-cplus-symbols.c: Use C++ exception handling.
11631         * compile/compile-c-symbols.c: Use C++ exception handling.
11632         * common/selftest.c: Use C++ exception handling.
11633         * common/new-op.c: Use C++ exception handling.
11634         * cli/cli-script.c: Use C++ exception handling.
11635         * cli/cli-interp.c: Use C++ exception handling.
11636         * cli/cli-cmds.c: Use C++ exception handling.
11637         * c-varobj.c: Use C++ exception handling.
11638         * btrace.c: Use C++ exception handling.
11639         * breakpoint.c: Use C++ exception handling.
11640         * break-catch-throw.c: Use C++ exception handling.
11641         * arch-utils.c: Use C++ exception handling.
11642         * amd64-tdep.c: Use C++ exception handling.
11643         * ada-valprint.c: Use C++ exception handling.
11644         * ada-typeprint.c: Use C++ exception handling.
11645         * ada-lang.c: Use C++ exception handling.
11646         * aarch64-tdep.c: Use C++ exception handling.
11647
11648 2019-04-08  Tom Tromey  <tom@tromey.com>
11649
11650         * xml-support.c (gdb_xml_parser::parse): Update.
11651         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11652         * value.c (show_convenience): Update.
11653         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11654         (test_parse_flags_qcs): Update.
11655         * thread.c (thr_try_catch_cmd): Update.
11656         * target.c (target_translate_tls_address): Update.
11657         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11658         (info_frame_command_core, frame_apply_command_count): Update.
11659         * rust-exp.y (rust_lex_exception_test): Update.
11660         * riscv-tdep.c (riscv_print_one_register_info): Update.
11661         * remote.c (remote_target::enable_btrace): Update.
11662         * record-btrace.c (record_btrace_enable_warn): Update.
11663         * python/py-utils.c (gdbpy_convert_exception): Update.
11664         * printcmd.c (do_one_display, print_variable_and_value): Update.
11665         * mi/mi-main.c (mi_print_exception): Update.
11666         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11667         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11668         * linux-nat.c (linux_nat_target::attach): Update.
11669         * linux-fork.c (class scoped_switch_fork_info): Update.
11670         * infrun.c (displaced_step_prepare): Update.
11671         * infcall.c (call_function_by_hand_dummy): Update.
11672         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11673         * gnu-v3-abi.c (print_one_vtable): Update.
11674         * frame.c (get_prev_frame_always): Update.
11675         * f-valprint.c (info_common_command_for_block): Update.
11676         * exec.c (try_open_exec_file): Update.
11677         * exceptions.c (print_exception, exception_print)
11678         (exception_fprintf, exception_print_same): Update.
11679         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11680         * dwarf-index-cache.c (index_cache::store)
11681         (index_cache::lookup_gdb_index): Update.
11682         * darwin-nat.c (maybe_cache_shell): Update.
11683         * cp-valprint.c (cp_print_value_fields): Update.
11684         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11685         (gcc_cplus_symbol_address): Update.
11686         * compile/compile-c-symbols.c (gcc_convert_symbol)
11687         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11688         * common/selftest.c: Update.
11689         * common/common-exceptions.h (struct gdb_exception) <message>: Now
11690         a std::string.
11691         (exception_try_scope_entry, exception_try_scope_exit): Don't
11692         declare.
11693         (struct exception_try_scope): Remove.
11694         (TRY): Don't use exception_try_scope.
11695         (struct gdb_exception): Add constructor, operator=.
11696         <what>: New method.
11697         (struct gdb_exception_RETURN_MASK_ALL)
11698         (struct gdb_exception_RETURN_MASK_ERROR)
11699         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11700         (struct gdb_quit_bad_alloc): Update.
11701         * common/common-exceptions.c (exception_none): Change
11702         initializer.
11703         (struct catcher) <state, exception>: Initialize inline.
11704         <prev>: Remove member.
11705         (current_catcher): Remove.
11706         (catchers): New global.
11707         (exceptions_state_mc_init): Simplify.
11708         (catcher_pop): Remove.
11709         (exceptions_state_mc, exceptions_state_mc_catch): Update.
11710         (try_scope_depth, exception_try_scope_entry)
11711         (exception_try_scope_exit): Remove.
11712         (throw_exception_sjlj): Update.
11713         (exception_messages, exception_messages_size): Remove.
11714         (throw_it): Simplify.
11715         (gdb_exception_sliced_copy): Remove.
11716         (throw_exception_cxx): Update.
11717         * cli/cli-script.c (script_from_file): Update.
11718         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11719         Update.
11720         * ada-valprint.c (ada_val_print): Update.
11721         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11722         (create_excep_cond_exprs): Update.
11723
11724 2019-04-08  Tom Tromey  <tom@tromey.com>
11725
11726         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11727         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11728         (TRY, CATCH, END_CATCH): Remove some definitions.
11729         * common/common-exceptions.c: Don't use GDB_XCPT.
11730         (catcher_list_size): Remove.
11731         (throw_exception, throw_it): Simplify.
11732
11733 2019-04-05  Tom Tromey  <tom@tromey.com>
11734
11735         Revert the header-sorting patch.
11736         * ft32-tdep.c: Revert.
11737         * frv-tdep.c: Revert.
11738         * frv-linux-tdep.c: Revert.
11739         * frame.c: Revert.
11740         * frame-unwind.c: Revert.
11741         * frame-base.c: Revert.
11742         * fork-child.c: Revert.
11743         * findvar.c: Revert.
11744         * findcmd.c: Revert.
11745         * filesystem.c: Revert.
11746         * filename-seen-cache.h: Revert.
11747         * filename-seen-cache.c: Revert.
11748         * fbsd-tdep.c: Revert.
11749         * fbsd-nat.h: Revert.
11750         * fbsd-nat.c: Revert.
11751         * f-valprint.c: Revert.
11752         * f-typeprint.c: Revert.
11753         * f-lang.c: Revert.
11754         * extension.h: Revert.
11755         * extension.c: Revert.
11756         * extension-priv.h: Revert.
11757         * expprint.c: Revert.
11758         * exec.h: Revert.
11759         * exec.c: Revert.
11760         * exceptions.c: Revert.
11761         * event-top.c: Revert.
11762         * event-loop.c: Revert.
11763         * eval.c: Revert.
11764         * elfread.c: Revert.
11765         * dwarf2read.h: Revert.
11766         * dwarf2read.c: Revert.
11767         * dwarf2loc.c: Revert.
11768         * dwarf2expr.h: Revert.
11769         * dwarf2expr.c: Revert.
11770         * dwarf2-frame.c: Revert.
11771         * dwarf2-frame-tailcall.c: Revert.
11772         * dwarf-index-write.h: Revert.
11773         * dwarf-index-write.c: Revert.
11774         * dwarf-index-common.c: Revert.
11775         * dwarf-index-cache.h: Revert.
11776         * dwarf-index-cache.c: Revert.
11777         * dummy-frame.c: Revert.
11778         * dtrace-probe.c: Revert.
11779         * disasm.h: Revert.
11780         * disasm.c: Revert.
11781         * disasm-selftests.c: Revert.
11782         * dictionary.c: Revert.
11783         * dicos-tdep.c: Revert.
11784         * demangle.c: Revert.
11785         * dcache.h: Revert.
11786         * dcache.c: Revert.
11787         * darwin-nat.h: Revert.
11788         * darwin-nat.c: Revert.
11789         * darwin-nat-info.c: Revert.
11790         * d-valprint.c: Revert.
11791         * d-namespace.c: Revert.
11792         * d-lang.c: Revert.
11793         * ctf.c: Revert.
11794         * csky-tdep.c: Revert.
11795         * csky-linux-tdep.c: Revert.
11796         * cris-tdep.c: Revert.
11797         * cris-linux-tdep.c: Revert.
11798         * cp-valprint.c: Revert.
11799         * cp-support.c: Revert.
11800         * cp-namespace.c: Revert.
11801         * cp-abi.c: Revert.
11802         * corelow.c: Revert.
11803         * corefile.c: Revert.
11804         * continuations.c: Revert.
11805         * completer.h: Revert.
11806         * completer.c: Revert.
11807         * complaints.c: Revert.
11808         * coffread.c: Revert.
11809         * coff-pe-read.c: Revert.
11810         * cli-out.h: Revert.
11811         * cli-out.c: Revert.
11812         * charset.c: Revert.
11813         * c-varobj.c: Revert.
11814         * c-valprint.c: Revert.
11815         * c-typeprint.c: Revert.
11816         * c-lang.c: Revert.
11817         * buildsym.c: Revert.
11818         * buildsym-legacy.c: Revert.
11819         * build-id.h: Revert.
11820         * build-id.c: Revert.
11821         * btrace.c: Revert.
11822         * bsd-uthread.c: Revert.
11823         * breakpoint.h: Revert.
11824         * breakpoint.c: Revert.
11825         * break-catch-throw.c: Revert.
11826         * break-catch-syscall.c: Revert.
11827         * break-catch-sig.c: Revert.
11828         * blockframe.c: Revert.
11829         * block.c: Revert.
11830         * bfin-tdep.c: Revert.
11831         * bfin-linux-tdep.c: Revert.
11832         * bfd-target.c: Revert.
11833         * bcache.c: Revert.
11834         * ax-general.c: Revert.
11835         * ax-gdb.h: Revert.
11836         * ax-gdb.c: Revert.
11837         * avr-tdep.c: Revert.
11838         * auxv.c: Revert.
11839         * auto-load.c: Revert.
11840         * arm-wince-tdep.c: Revert.
11841         * arm-tdep.c: Revert.
11842         * arm-symbian-tdep.c: Revert.
11843         * arm-pikeos-tdep.c: Revert.
11844         * arm-obsd-tdep.c: Revert.
11845         * arm-nbsd-tdep.c: Revert.
11846         * arm-nbsd-nat.c: Revert.
11847         * arm-linux-tdep.c: Revert.
11848         * arm-linux-nat.c: Revert.
11849         * arm-fbsd-tdep.c: Revert.
11850         * arm-fbsd-nat.c: Revert.
11851         * arm-bsd-tdep.c: Revert.
11852         * arch-utils.c: Revert.
11853         * arc-tdep.c: Revert.
11854         * arc-newlib-tdep.c: Revert.
11855         * annotate.h: Revert.
11856         * annotate.c: Revert.
11857         * amd64-windows-tdep.c: Revert.
11858         * amd64-windows-nat.c: Revert.
11859         * amd64-tdep.c: Revert.
11860         * amd64-sol2-tdep.c: Revert.
11861         * amd64-obsd-tdep.c: Revert.
11862         * amd64-obsd-nat.c: Revert.
11863         * amd64-nbsd-tdep.c: Revert.
11864         * amd64-nbsd-nat.c: Revert.
11865         * amd64-nat.c: Revert.
11866         * amd64-linux-tdep.c: Revert.
11867         * amd64-linux-nat.c: Revert.
11868         * amd64-fbsd-tdep.c: Revert.
11869         * amd64-fbsd-nat.c: Revert.
11870         * amd64-dicos-tdep.c: Revert.
11871         * amd64-darwin-tdep.c: Revert.
11872         * amd64-bsd-nat.c: Revert.
11873         * alpha-tdep.c: Revert.
11874         * alpha-obsd-tdep.c: Revert.
11875         * alpha-nbsd-tdep.c: Revert.
11876         * alpha-mdebug-tdep.c: Revert.
11877         * alpha-linux-tdep.c: Revert.
11878         * alpha-linux-nat.c: Revert.
11879         * alpha-bsd-tdep.c: Revert.
11880         * alpha-bsd-nat.c: Revert.
11881         * aix-thread.c: Revert.
11882         * agent.c: Revert.
11883         * addrmap.c: Revert.
11884         * ada-varobj.c: Revert.
11885         * ada-valprint.c: Revert.
11886         * ada-typeprint.c: Revert.
11887         * ada-tasks.c: Revert.
11888         * ada-lang.c: Revert.
11889         * aarch64-tdep.c: Revert.
11890         * aarch64-ravenscar-thread.c: Revert.
11891         * aarch64-newlib-tdep.c: Revert.
11892         * aarch64-linux-tdep.c: Revert.
11893         * aarch64-linux-nat.c: Revert.
11894         * aarch64-fbsd-tdep.c: Revert.
11895         * aarch64-fbsd-nat.c: Revert.
11896         * aarch32-linux-nat.c: Revert.
11897
11898 2019-04-05  Tom Tromey  <tom@tromey.com>
11899
11900         * ft32-tdep.c: Sort headers.
11901         * frv-tdep.c: Sort headers.
11902         * frv-linux-tdep.c: Sort headers.
11903         * frame.c: Sort headers.
11904         * frame-unwind.c: Sort headers.
11905         * frame-base.c: Sort headers.
11906         * fork-child.c: Sort headers.
11907         * findvar.c: Sort headers.
11908         * findcmd.c: Sort headers.
11909         * filesystem.c: Sort headers.
11910         * filename-seen-cache.h: Sort headers.
11911         * filename-seen-cache.c: Sort headers.
11912         * fbsd-tdep.c: Sort headers.
11913         * fbsd-nat.h: Sort headers.
11914         * fbsd-nat.c: Sort headers.
11915         * f-valprint.c: Sort headers.
11916         * f-typeprint.c: Sort headers.
11917         * f-lang.c: Sort headers.
11918         * extension.h: Sort headers.
11919         * extension.c: Sort headers.
11920         * extension-priv.h: Sort headers.
11921         * expprint.c: Sort headers.
11922         * exec.h: Sort headers.
11923         * exec.c: Sort headers.
11924         * exceptions.c: Sort headers.
11925         * event-top.c: Sort headers.
11926         * event-loop.c: Sort headers.
11927         * eval.c: Sort headers.
11928         * elfread.c: Sort headers.
11929         * dwarf2read.h: Sort headers.
11930         * dwarf2read.c: Sort headers.
11931         * dwarf2loc.c: Sort headers.
11932         * dwarf2expr.h: Sort headers.
11933         * dwarf2expr.c: Sort headers.
11934         * dwarf2-frame.c: Sort headers.
11935         * dwarf2-frame-tailcall.c: Sort headers.
11936         * dwarf-index-write.h: Sort headers.
11937         * dwarf-index-write.c: Sort headers.
11938         * dwarf-index-common.c: Sort headers.
11939         * dwarf-index-cache.h: Sort headers.
11940         * dwarf-index-cache.c: Sort headers.
11941         * dummy-frame.c: Sort headers.
11942         * dtrace-probe.c: Sort headers.
11943         * disasm.h: Sort headers.
11944         * disasm.c: Sort headers.
11945         * disasm-selftests.c: Sort headers.
11946         * dictionary.c: Sort headers.
11947         * dicos-tdep.c: Sort headers.
11948         * demangle.c: Sort headers.
11949         * dcache.h: Sort headers.
11950         * dcache.c: Sort headers.
11951         * darwin-nat.h: Sort headers.
11952         * darwin-nat.c: Sort headers.
11953         * darwin-nat-info.c: Sort headers.
11954         * d-valprint.c: Sort headers.
11955         * d-namespace.c: Sort headers.
11956         * d-lang.c: Sort headers.
11957         * ctf.c: Sort headers.
11958         * csky-tdep.c: Sort headers.
11959         * csky-linux-tdep.c: Sort headers.
11960         * cris-tdep.c: Sort headers.
11961         * cris-linux-tdep.c: Sort headers.
11962         * cp-valprint.c: Sort headers.
11963         * cp-support.c: Sort headers.
11964         * cp-namespace.c: Sort headers.
11965         * cp-abi.c: Sort headers.
11966         * corelow.c: Sort headers.
11967         * corefile.c: Sort headers.
11968         * continuations.c: Sort headers.
11969         * completer.h: Sort headers.
11970         * completer.c: Sort headers.
11971         * complaints.c: Sort headers.
11972         * coffread.c: Sort headers.
11973         * coff-pe-read.c: Sort headers.
11974         * cli-out.h: Sort headers.
11975         * cli-out.c: Sort headers.
11976         * charset.c: Sort headers.
11977         * c-varobj.c: Sort headers.
11978         * c-valprint.c: Sort headers.
11979         * c-typeprint.c: Sort headers.
11980         * c-lang.c: Sort headers.
11981         * buildsym.c: Sort headers.
11982         * buildsym-legacy.c: Sort headers.
11983         * build-id.h: Sort headers.
11984         * build-id.c: Sort headers.
11985         * btrace.c: Sort headers.
11986         * bsd-uthread.c: Sort headers.
11987         * breakpoint.h: Sort headers.
11988         * breakpoint.c: Sort headers.
11989         * break-catch-throw.c: Sort headers.
11990         * break-catch-syscall.c: Sort headers.
11991         * break-catch-sig.c: Sort headers.
11992         * blockframe.c: Sort headers.
11993         * block.c: Sort headers.
11994         * bfin-tdep.c: Sort headers.
11995         * bfin-linux-tdep.c: Sort headers.
11996         * bfd-target.c: Sort headers.
11997         * bcache.c: Sort headers.
11998         * ax-general.c: Sort headers.
11999         * ax-gdb.h: Sort headers.
12000         * ax-gdb.c: Sort headers.
12001         * avr-tdep.c: Sort headers.
12002         * auxv.c: Sort headers.
12003         * auto-load.c: Sort headers.
12004         * arm-wince-tdep.c: Sort headers.
12005         * arm-tdep.c: Sort headers.
12006         * arm-symbian-tdep.c: Sort headers.
12007         * arm-pikeos-tdep.c: Sort headers.
12008         * arm-obsd-tdep.c: Sort headers.
12009         * arm-nbsd-tdep.c: Sort headers.
12010         * arm-nbsd-nat.c: Sort headers.
12011         * arm-linux-tdep.c: Sort headers.
12012         * arm-linux-nat.c: Sort headers.
12013         * arm-fbsd-tdep.c: Sort headers.
12014         * arm-fbsd-nat.c: Sort headers.
12015         * arm-bsd-tdep.c: Sort headers.
12016         * arch-utils.c: Sort headers.
12017         * arc-tdep.c: Sort headers.
12018         * arc-newlib-tdep.c: Sort headers.
12019         * annotate.h: Sort headers.
12020         * annotate.c: Sort headers.
12021         * amd64-windows-tdep.c: Sort headers.
12022         * amd64-windows-nat.c: Sort headers.
12023         * amd64-tdep.c: Sort headers.
12024         * amd64-sol2-tdep.c: Sort headers.
12025         * amd64-obsd-tdep.c: Sort headers.
12026         * amd64-obsd-nat.c: Sort headers.
12027         * amd64-nbsd-tdep.c: Sort headers.
12028         * amd64-nbsd-nat.c: Sort headers.
12029         * amd64-nat.c: Sort headers.
12030         * amd64-linux-tdep.c: Sort headers.
12031         * amd64-linux-nat.c: Sort headers.
12032         * amd64-fbsd-tdep.c: Sort headers.
12033         * amd64-fbsd-nat.c: Sort headers.
12034         * amd64-dicos-tdep.c: Sort headers.
12035         * amd64-darwin-tdep.c: Sort headers.
12036         * amd64-bsd-nat.c: Sort headers.
12037         * alpha-tdep.c: Sort headers.
12038         * alpha-obsd-tdep.c: Sort headers.
12039         * alpha-nbsd-tdep.c: Sort headers.
12040         * alpha-mdebug-tdep.c: Sort headers.
12041         * alpha-linux-tdep.c: Sort headers.
12042         * alpha-linux-nat.c: Sort headers.
12043         * alpha-bsd-tdep.c: Sort headers.
12044         * alpha-bsd-nat.c: Sort headers.
12045         * aix-thread.c: Sort headers.
12046         * agent.c: Sort headers.
12047         * addrmap.c: Sort headers.
12048         * ada-varobj.c: Sort headers.
12049         * ada-valprint.c: Sort headers.
12050         * ada-typeprint.c: Sort headers.
12051         * ada-tasks.c: Sort headers.
12052         * ada-lang.c: Sort headers.
12053         * aarch64-tdep.c: Sort headers.
12054         * aarch64-ravenscar-thread.c: Sort headers.
12055         * aarch64-newlib-tdep.c: Sort headers.
12056         * aarch64-linux-tdep.c: Sort headers.
12057         * aarch64-linux-nat.c: Sort headers.
12058         * aarch64-fbsd-tdep.c: Sort headers.
12059         * aarch64-fbsd-nat.c: Sort headers.
12060         * aarch32-linux-nat.c: Sort headers.
12061
12062 2019-04-04  Tom Tromey  <tom@tromey.com>
12063
12064         * varobj.c (varobj_create): Update.
12065         * rust-exp.y (struct rust_parser) <update_innermost_block,
12066         lookup_symbol>: New methods.
12067         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12068         Rename.
12069         (rust_parser::rust_lookup_type)
12070         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12071         * printcmd.c (display_command, do_one_display): Update.
12072         * parser-defs.h (struct parser_state) <parser_state>: Add
12073         "tracker" parameter.
12074         (block_tracker): New member.
12075         (class innermost_block_tracker) <innermost_block_tracker>: Add
12076         "types" parameter.
12077         <reset>: Remove method.
12078         (innermost_block): Don't declare.
12079         (null_post_parser): Update.
12080         * parse.c (innermost_block): Remove global.
12081         (write_dollar_variable): Update.
12082         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12083         Remove "tracker_types" parameter.
12084         (parse_expression): Add "tracker" parameter.
12085         (parse_expression_for_completion): Update.
12086         (null_post_parser): Add "tracker" parameter.
12087         * p-exp.y: Update rules.
12088         * m2-exp.y: Update rules.
12089         * language.h (struct language_defn) <la_post_parser>: Add
12090         "tracker" parameter.
12091         * go-exp.y: Update rules.
12092         * f-exp.y: Update rules.
12093         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12094         parameter.
12095         * d-exp.y: Update rules.
12096         * c-exp.y: Update rules.
12097         * breakpoint.c (set_breakpoint_condition): Create an
12098         innermost_block_tracker.
12099         (watch_command_1): Likewise.
12100         * ada-lang.c (resolve): Add "tracker" parameter.
12101         (resolve_subexp): Likewise.
12102         * ada-exp.y (write_var_from_sym): Update.
12103
12104 2019-04-04  Tom Tromey  <tom@tromey.com>
12105
12106         * type-stack.h: New file.
12107         * type-stack.c: New file.
12108         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12109         type-stack.h.
12110         (insert_into_type_stack, insert_type, push_type, push_type_int)
12111         (insert_type_address_space, pop_type, pop_type_int)
12112         (pop_typelist, pop_type_stack, append_type_stack)
12113         (push_type_stack, get_type_stack, push_typelist)
12114         (follow_type_instance_flags, follow_types): Don't declare.
12115         * parse.c (type_stack): Remove global.
12116         (parse_exp_in_context): Update.
12117         (insert_into_type_stack, insert_type, push_type, push_type_int)
12118         (insert_type_address_space, pop_type, pop_type_int)
12119         (pop_typelist, pop_type_stack, append_type_stack)
12120         (push_type_stack, get_type_stack, push_typelist)
12121         (follow_type_instance_flags, follow_types): Remove (moved to
12122         type-stack.c).
12123         * f-exp.y (type_stack): New global.
12124         Update rules.
12125         (push_kind_type, f_parse): Update.
12126         * d-exp.y (type_stack): New global.
12127         Update rules.
12128         (d_parse): Update.
12129         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12130         Update rules.
12131         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12132         (HFILES_NO_SRCDIR): Add type-stack.h.
12133
12134 2019-04-04  Tom Tromey  <tom@tromey.com>
12135
12136         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12137         (rust_parser::convert_ast_to_expression, rust_parse)
12138         (rust_lex_test_completion, rust_lex_tests): Update.
12139         * parser-defs.h (struct expr_completion_state): New.
12140         (struct parser_state) <parser_state>: Add completion parameter.
12141         <mark_struct_expression, mark_completion_tag>: New methods.
12142         <parse_completion, m_completion_state>: New members.
12143         (prefixify_expression, null_post_parser): Update.
12144         (mark_struct_expression, mark_completion_tag): Don't declare.
12145         * parse.c (parse_completion, expout_last_struct)
12146         (expout_tag_completion_type, expout_completion_name): Remove
12147         globals.
12148         (parser_state::mark_struct_expression)
12149         (parser_state::mark_completion_tag): Now methods.
12150         (prefixify_expression): Add last_struct parameter.
12151         (prefixify_subexp): Likewise.
12152         (parse_exp_1): Update.
12153         (parse_exp_in_context): Add cstate parameter.  Update.
12154         (parse_expression_for_completion): Create an
12155         expr_completion_state.
12156         (null_post_parser): Add "completion" parameter.
12157         * p-exp.y: Update rules.
12158         (yylex): Update.
12159         * language.h (struct language_defn) <la_post_parser>: Add
12160         "completing" parameter.
12161         * go-exp.y: Update rules.
12162         (lex_one_token): Update.
12163         * expression.h (parse_completion): Don't declare.
12164         * d-exp.y: Update rules.
12165         (lex_one_token): Update rules.
12166         * c-exp.y: Update rules.
12167         (lex_one_token): Update.
12168         * ada-lang.c (resolve): Add "parse_completion" parameter.
12169         (resolve_subexp): Likewise.
12170         (ada_resolve_function): Likewise.
12171
12172 2019-04-04  Tom Tromey  <tom@tromey.com>
12173
12174         * parser-defs.h (struct parser_state) <start_arglist,
12175         end_arglist>: New methods.
12176         <arglist_len, m_funcall_chain>: New members.
12177         (arglist_len, start_arglist, end_arglist): Don't declare.
12178         * parse.c (arglist_len, funcall_chain): Remove global.
12179         (start_arglist, end_arglist): Remove functions.
12180         (parse_exp_in_context): Update.
12181         * p-exp.y: Update rules.
12182         * m2-exp.y: Update rules.
12183         * go-exp.y: Update rules.
12184         * f-exp.y: Update rules.
12185         * d-exp.y: Update rules.
12186         * c-exp.y: Update rules.
12187
12188 2019-04-04  Tom Tromey  <tom@tromey.com>
12189
12190         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12191         lex_operator, push_back>: New methods.
12192         Update all rules.
12193         (rust_parser::lex_hex, lex_escape): Rename and update.
12194         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12195         (rust_parser::lex_operator): Rename and update.
12196         (rust_parser::lex_number, rustyylex, rustyyerror)
12197         (rust_lex_test_init, rust_lex_test_sequence)
12198         (rust_lex_test_push_back, rust_lex_tests): Update.
12199         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12200         parameter.
12201         <lexptr, prev_lexptr>: New members.
12202         (lexptr, prev_lexptr): Don't declare.
12203         * parse.c (lexptr, prev_lexptr): Remove globals.
12204         (parse_exp_in_context): Update.
12205         * p-exp.y (yylex, yyerror): Update.
12206         * m2-exp.y (parse_number, yylex, yyerror): Update.
12207         * go-exp.y (lex_one_token, yyerror): Update.
12208         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12209         * d-exp.y (lex_one_token, yyerror): Update.
12210         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12211         (lex_one_token, yyerror): Update.
12212         * ada-lex.l (YY_INPUT): Update.
12213         (rewind_to_char): Update.
12214         * ada-exp.y (yyerror): Update.
12215
12216 2019-04-04  Tom Tromey  <tom@tromey.com>
12217
12218         * rust-exp.y (rustyylex, rust_lex_tests): Update.
12219         * parser-defs.h (struct parser_state) <parser_state>: Add new
12220         parameter.
12221         <comma_terminates>: New member.
12222         (comma_terminates): Don't declare global.
12223         * parse.c (comma_terminates): Remove global.
12224         (parse_exp_in_context): Update.
12225         * p-exp.y (yylex): Update.
12226         * m2-exp.y (yylex): Update.
12227         * go-exp.y (lex_one_token): Update.
12228         * f-exp.y (yylex): Update.
12229         * d-exp.y (lex_one_token): Update.
12230         * c-exp.y (lex_one_token): Update.
12231         * ada-lex.l: Update.
12232
12233 2019-04-04  Tom Tromey  <tom@tromey.com>
12234
12235         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12236         (rustyylex, rust_lex_test_init, rust_lex_test_one)
12237         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12238         * parser-defs.h (paren_depth): Don't declare.
12239         * parse.c (paren_depth): Remove global.
12240         (parse_exp_in_context): Update.
12241         * p-exp.y (paren_depth): New global.
12242         (pascal_parse): Initialize it.
12243         * m2-exp.y (paren_depth): New global.
12244         (m2_parse): Initialize it.
12245         * go-exp.y (paren_depth): New global.
12246         (go_parse): Initialize it.
12247         * f-exp.y (paren_depth): New global.
12248         (f_parse): Initialize it.
12249         * d-exp.y (paren_depth): New global.
12250         (d_parse): Initialize it.
12251         * c-exp.y (paren_depth): New global.
12252         (c_parse): Initialize it.
12253         * ada-lex.l (paren_depth): New global.
12254         (lexer_init): Initialize it.
12255
12256 2019-04-04  Tom Tromey  <tom@tromey.com>
12257
12258         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12259         (rust_parser::convert_ast_to_type)
12260         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12261         * parser-defs.h (struct parser_state) <parser_state>: Add
12262         parameters.  Initialize new members.
12263         <expression_context_block, expression_context_pc>: New members.
12264         * parse.c (expression_context_block, expression_context_pc):
12265         Remove globals.
12266         (parse_exp_in_context): Update.
12267         * p-exp.y: Update all rules.
12268         (yylex): Update.
12269         * m2-exp.y: Update all rules.
12270         (yylex): Update.
12271         * go-exp.y (yylex): Update.
12272         * f-exp.y (yylex): Update.
12273         * d-exp.y: Update all rules.
12274         (yylex): Update.
12275         * c-exp.y: Update all rules.
12276         (lex_one_token, classify_name, yylex, c_parse): Update.
12277         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12278
12279 2019-04-04  Tom Tromey  <tom@tromey.com>
12280
12281         * gdbarch.h, gdbarch.c: Rebuild.
12282         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12283         * stap-probe.h:
12284         (struct stap_parse_info): Replace "parser_state" with
12285         "expr_builder".
12286         * parser-defs.h (struct expr_builder): Rename from "parser_state".
12287         (parser_state): New class.
12288         * parse.c (expr_builder): Rename.
12289         (expr_builder::release): Rename.
12290         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12291         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12292         (write_exp_elt_longcst, write_exp_elt_floatcst)
12293         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12294         (write_exp_string_vector, write_exp_bitstring)
12295         (write_exp_msymbol, mark_struct_expression)
12296         (write_dollar_variable)
12297         (insert_type_address_space, increase_expout_size): Replace
12298         "parser_state" with "expr_builder".
12299         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12300         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12301         "parser_state" with "expr_builder".
12302
12303 2019-04-04  Tom Tromey  <tom@tromey.com>
12304
12305         * rust-exp.y: Replace "parse_language" with method call.
12306         * p-exp.y:
12307         (yylex): Replace "parse_language" with method call.
12308         * m2-exp.y:
12309         (yylex): Replace "parse_language" with method call.
12310         * go-exp.y (classify_name): Replace "parse_language" with method
12311         call.
12312         * f-exp.y (yylex): Replace "parse_language" with method call.
12313         * d-exp.y (lex_one_token): Replace "parse_language" with method
12314         call.
12315         * c-exp.y:
12316         (lex_one_token, classify_name, yylex): Replace "parse_language"
12317         with method call.
12318         * ada-exp.y (find_primitive_type, type_char)
12319         (type_system_address): Replace "parse_language" with method call.
12320
12321 2019-04-04  Tom Tromey  <tom@tromey.com>
12322
12323         * rust-exp.y: Replace "parse_gdbarch" with method call.
12324         * parse.c (write_dollar_variable, insert_type_address_space):
12325         Replace "parse_gdbarch" with method call.
12326         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12327         call.
12328         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12329         call.
12330         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12331         "parse_gdbarch" with method call.
12332         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12333         with method call.
12334         * f-exp.y (parse_type, parse_f_type, yylex): Replace
12335         "parse_gdbarch" with method call.
12336         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12337         "parse_gdbarch" with method call.
12338         * c-exp.y (parse_type, parse_number, classify_name): Replace
12339         "parse_gdbarch" with method call.
12340         * ada-lex.l: Replace "parse_gdbarch" with method call.
12341         * ada-exp.y (parse_type, find_primitive_type, type_char)
12342         (type_system_address): Replace "parse_gdbarch" with method call.
12343
12344 2019-04-04  Tom Tromey  <tom@tromey.com>
12345
12346         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12347         * stap-probe.c (stap_parse_argument): Update.
12348         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12349         initial_size parameter.
12350         * rust-exp.y (rust_lex_tests): Update.
12351         * parse.c (parser_state): Update.
12352         (parse_exp_in_context): Update.
12353         * parser-defs.h (struct parser_state) <parser_state>: Remove
12354         "initial_size" parameter.
12355
12356 2019-04-04  Tom Tromey  <tom@tromey.com>
12357
12358         * parser-defs.h (increase_expout_size): Don't declare.
12359         * parse.c (increase_expout_size): Now static.
12360
12361 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
12362
12363         * gnu-nat.c (gnu_nat_target::wait): Fix
12364         target_waitstatus_to_string call.
12365
12366 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12367
12368         * eval.c (evaluate_subexp_standard): Handle internal functions
12369         during Fortran function call handling.
12370
12371 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12372
12373         * NEWS: Mention new internal functions.
12374         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12375         (read_base_type): Use dwarf2_init_complex_target_type.
12376         * value.c (creal_internal_fn): New function.
12377         (cimag_internal_fn): New function.
12378         (_initialize_values): Register new internal functions.
12379
12380 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12381
12382         * infrun.c (stop_all_threads): If debug_infrun, always
12383         trace the wait status after wait_one, using
12384         target_waitstatus_to_string and target_pid_to_str.
12385         (handle_inferior_event): Replace various trace of
12386         wait status kind by a single trace.
12387         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12388         wait status kind image by target_waitstatus_to_string.
12389         * target/waitstatus.c (target_waitstatus_to_string): Fix
12390         obsolete comment.
12391
12392 2019-04-01  Tom Tromey  <tromey@adacore.com>
12393
12394         PR symtab/23331:
12395         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12396
12397 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
12398             Pedro Alves  <palves@redhat.com>
12399
12400         * top.c (quit_force): Call 'finalize_values'.
12401         * value.c (finalize_values): New function.
12402         * value.h (finalize_values): Declare.
12403
12404 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
12405
12406         * NEWS: Announce $_gdb_major and $_gdb_minor.
12407
12408         * top.c (init_gdb_version_vars): New function.
12409         (gdb_init): Call init_gdb_version_vars.
12410
12411 2019-03-29  Tom Tromey  <tromey@adacore.com>
12412
12413         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
12414         help text.  Remove dead code.
12415
12416 2019-03-29  Keith Seitz  <keiths@redhat.com>
12417
12418         From Siddhesh Poyarekar:
12419         * f-lang.h (f77_get_upperbound): Return LONGEST.
12420         (f77_get_lowerbound): Likewise.
12421         * f-typeprint.c (f_type_print_varspec_suffix): Expand
12422         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
12423         print them.
12424         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
12425         plongest to format print it.
12426         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12427         (f77_get_upperbound): Likewise.
12428         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12429         LOWER_BOUND to LONGEST.
12430         (f77_create_arrayprint_offset_tbl): Likewise.
12431
12432 2019-03-29  Keith Seitz  <keiths@redhat.com>
12433
12434         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12435         %s/pulongest for TYPE_LENGTH instead of %d in format
12436         strings.
12437         * ada-typerint.c (ada_print_type): Likewise.
12438         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12439         * compile/compile-c-support.c (generate_register_struct): Likewise.
12440         * gdbtypes.c (recursive_dump_type): Likewise.
12441         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12442         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
12443         instead of %d in format strings.
12444         * riscv-tdep.c (riscv_type_alignment): Cast second argument
12445         to std::min to ULONGEST.
12446         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12447         instead of %d in format strings.
12448         * tracepoint.c (info_scope_command): Likewise.
12449         * typeprint.c (print_offset_data::update)
12450         (print_offset_data::finish): Likewise.
12451         * xtensa-tdep.c (xtensa_store_return_value)
12452         (xtensa_push_dummy_call): Likewise.
12453
12454 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
12455
12456         * windows-nat.c (display_selector): Fixed format specifications
12457         for 64-bit Cygwin.
12458
12459 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12460
12461         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12462
12463 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
12464
12465         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12466         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12467         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12468         (nios2_linux_init_abi): Install it.
12469
12470 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12471
12472         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12473
12474 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12475
12476         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12477
12478 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12479             Tom Tromey  <tromey@adacore.com>
12480
12481         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12482
12483 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
12484
12485         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12486         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12487         method to compute the bounds of range types. Also print "[evaluated]"
12488         if the bounds' values come from a dynamic evaluation.
12489
12490 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12491
12492         * cp-valprint.c (cp_print_value_fields): Don't print trailing
12493         whitespace when pretty printing is on.
12494
12495 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12496
12497         * ppc-linux-nat.c: Add include.
12498
12499 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12500
12501         * NEWS: Mention AArch64 Pointer Authentication.
12502
12503 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12504
12505         * arm-linux-nat.c: Add include.
12506
12507 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
12508
12509         * source-cache.c (source_cache::get_source_lines): Re-read
12510         fullname after calling open_source_file.
12511
12512 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
12513
12514         * NEWS: Mention TLS support for FreeBSD.
12515
12516 2019-03-25  Tom Tromey  <tromey@adacore.com>
12517
12518         * minsyms.c (BUNCH_SIZE): Update comment.
12519         (~minimal_symbol_reader): Remove old comment.
12520         (compact_minimal_symbols): Update comment.
12521         (minimal_symbol_reader::install): Remove old comment.  Update
12522         other comments.
12523
12524 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12525
12526         * s390-linux-nat.c: Add include.
12527
12528 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12529
12530         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12531         Call linux_get_hwcap.
12532         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12533         Likewise.
12534         (aarch64_linux_get_hwcap): Remove function.
12535         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12536         declaration.
12537         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12538         linux_get_hwcap.
12539         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12540         * linux-tdep.c (linux_get_hwcap): Add function.
12541         (linux_get_hwcap2): Likewise.
12542         * linux-tdep.h (linux_get_hwcap): Add declaration.
12543         (linux_get_hwcap2): Likewise.
12544         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12545         (ppc_linux_get_hwcap2): Likewise.
12546         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12547         linux_get_hwcap.
12548         (ppc_linux_nat_target::insert_watchpoint): Likewise.
12549         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12550         (ppc_linux_nat_target::read_description): Likewise.
12551         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12552         * s390-linux-nat.c: Likewise.
12553         * s390-linux-tdep.c (s390_core_read_description): Likewise.
12554
12555 2019-03-24  Tom Tromey  <tom@tromey.com>
12556
12557         * ada-lang.c (standard_lookup): Simplify initialization.
12558         (ada_lookup_symbol_nonlocal): Simplify return.
12559         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12560         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12561         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12562         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12563         initialization.
12564         * solib.c (solib_global_lookup): Simplify.
12565         * symtab.c (null_block_symbol): Remove.
12566         (symbol_cache_lookup): Simplify returns.
12567         (lookup_language_this): Simplify returns.
12568         (lookup_symbol_aux): Simplify return.
12569         (lookup_local_symbol): Simplify returns.
12570         (lookup_global_symbol_from_objfile): Simplify return.
12571         (lookup_symbol_in_objfile_symtabs)
12572         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12573         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12574         (lookup_static_symbol, lookup_global_symbol): Simplify return.
12575         * cp-namespace.c (cp_lookup_bare_symbol)
12576         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12577         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12578         (cp_lookup_nested_symbol): Don't use null_block_symbol.
12579         (cp_lookup_symbol_via_imports): Simplify initialization.
12580         (find_symbol_in_baseclass): Likewise.
12581         * symtab.h (null_block_symbol): Remove.
12582         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12583         (d_lookup_nested_symbol, d_lookup_symbol_imports)
12584         (d_lookup_symbol_module): Likewise.
12585         (find_symbol_in_baseclass): Simplify initialization.
12586
12587 2019-03-24  Tom Tromey  <tom@tromey.com>
12588
12589         * expression.h: Don't include symtab.h.
12590         (struct block): Forward declare.
12591
12592 2019-03-24  Tom Tromey  <tom@tromey.com>
12593
12594         * c-exp.y (typebase): Remove casts.
12595         * gdbtypes.c (lookup_unsigned_typename, )
12596         (lookup_signed_typename): Remove cast.
12597         * eval.c (parse_to_comma_and_eval): Remove cast.
12598         * parse.c (write_dollar_variable): Remove cast.
12599         * block.h (struct block) <superblock>: Now const.
12600         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12601         * psymtab.c (psym_map_matching_symbols): Make "block" const.
12602         (map_block): Make "block" const.
12603         * symfile.h (struct quick_symbol_functions)
12604         <map_matching_symbols>: Constify block argument to "callback".
12605         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12606         const.
12607         (find_pc_sect_compunit_symtab): Make "b" const.
12608         (find_symbol_at_address): Likewise.
12609         (search_symbols): Likewise.
12610         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12611         (dw2_debug_names_lookup_symbol): Likewise.
12612         (dw2_map_matching_symbols): Update.
12613         * p-valprint.c (pascal_val_print): Remove "block".
12614         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12615         (aux_add_nonlocal_symbols): Make "block" const.
12616         (resolve_subexp): Remove cast.
12617         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12618         const.
12619         (iterate_over_file_blocks): Likewise.
12620         * f-exp.y (%union) <bval>: Remove.
12621         * coffread.c (patch_opaque_types): Make "b" const.
12622         * spu-tdep.c (spu_catch_start): Make "block" const.
12623         * c-valprint.c (print_unpacked_pointer): Remove "block".
12624         * symmisc.c (dump_symtab_1): Make "b" const.
12625         (block_depth): Make "block" const.
12626         * d-exp.y (%union) <bval>: Remove.
12627         * cp-support.h (cp_lookup_rtti_type): Update.
12628         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12629         * psymtab.c (psym_lookup_symbol): Make "block" const.
12630         (maintenance_check_psymtabs): Make "b" const.
12631         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12632         (enumerate_locals, enumerate_args): Update.
12633         * python/py-symtab.c (stpy_global_block): Make "block" const.
12634         (stpy_static_block): Likewise.
12635         * inline-frame.c (block_starting_point_at): Make "new_block"
12636         const.
12637         * block.c (find_block_in_blockvector): Make return type const.
12638         (blockvector_for_pc_sect): Make "b" const.
12639         (find_block_in_blockvector): Make "b" const.
12640
12641 2019-03-23  Tom Tromey  <tom@tromey.com>
12642
12643         * varobj.c (varobj_create): Update.
12644         * symfile.c (clear_symtab_users): Don't reset innermost_block.
12645         * printcmd.c (display_command, do_one_display): Don't reset
12646         innermost_block.
12647         * parser-defs.h (enum innermost_block_tracker_type): Move to
12648         expression.h.
12649         (innermost_block): Update comment.
12650         * parse.c (parse_exp_1): Add tracker_types parameter.
12651         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
12652         tracker_types parameter.  Reset innermost_block.
12653         (parse_exp_in_context): Remove.
12654         (parse_expression_for_completion): Update.
12655         * objfiles.c (~objfile): Don't reset expression_context_block or
12656         innermost_block.
12657         * expression.h (enum innermost_block_tracker_type): Move from
12658         parser-defs.h.
12659         (parse_exp_1): Add tracker_types parameter.
12660         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12661         reset innermost_block.
12662
12663 2019-03-23  Tom Tromey  <tom@tromey.com>
12664
12665         * objfiles.h: Include bcache.h.
12666
12667 2019-03-23  Tom Tromey  <tom@tromey.com>
12668
12669         * linespec.c (get_current_search_block): Use
12670         scoped_restore_current_language.
12671         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12672
12673 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12674             Jiong Wang  <jiong.wang@arm.com>
12675
12676         * aarch64-linux-tdep.c
12677         (aarch64_linux_iterate_over_regset_sections): Check for pauth
12678         section.
12679         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12680
12681 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12682             Jiong Wang  <jiong.wang@arm.com>
12683
12684         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12685         instructions.
12686         (aarch64_analyze_prologue_test): Add PACIASP test.
12687         (aarch64_prologue_prev_register): Unmask PC value.
12688
12689 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12690             Jiong Wang  <jiong.wang@arm.com>
12691
12692         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12693         (aarch64_dwarf2_prev_register): Unmask PC value.
12694         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12695         (aarch64_execute_dwarf_cfa_vendor_op): Check for
12696         DW_CFA_AARCH64_negate_ra_state.
12697         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12698
12699 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12700             Jiong Wang  <jiong.wang@arm.com>
12701
12702         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12703         registers.
12704         (aarch64_pseudo_register_name): Likewise.
12705         (aarch64_pseudo_register_type): Likewise.
12706         (aarch64_pseudo_register_reggroup_p): Likewise.
12707         (aarch64_gdbarch_init): Add pauth registers.
12708         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12709         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12710         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12711         (struct gdbarch_tdep): Add regnum for ra_state.
12712
12713 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12714             Jiong Wang  <jiong.wang@arm.com>
12715
12716         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12717
12718 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12719             Jiong Wang  <jiong.wang@arm.com>
12720
12721         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12722         function.
12723         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12724         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12725         (aarch64_gdbarch_init): Add puth registers.
12726         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12727         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12728         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12729
12730 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12731             Jiong Wang  <jiong.wang@arm.com>
12732
12733         * aarch64-linux-nat.c
12734         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12735         * aarch64-linux-tdep.c
12736         (aarch64_linux_core_read_description): Likewise.
12737         (aarch64_linux_get_hwcap): New function.
12738         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12739         (aarch64_linux_get_hwcap): New declaration.
12740
12741 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12742             Jiong Wang  <jiong.wang@arm.com>
12743
12744         * aarch64-linux-nat.c
12745         (aarch64_linux_nat_target::read_description): Add pauth param.
12746         * aarch64-linux-tdep.c
12747         (aarch64_linux_core_read_description): Likewise.
12748         * aarch64-tdep.c (struct target_desc): Add in pauth.
12749         (aarch64_read_description): Add pauth param.
12750         (aarch64_gdbarch_init): Likewise.
12751         * aarch64-tdep.h (aarch64_read_description): Likewise.
12752         * arch/aarch64.c (aarch64_create_target_description): Likewise.
12753         * arch/aarch64.h (aarch64_create_target_description): Likewise.
12754         * features/Makefile: Add new files.
12755         * features/aarch64-pauth.c: New file.
12756         * features/aarch64-pauth.xml: New file.
12757
12758 2019-03-20  Tom Tromey  <tromey@adacore.com>
12759
12760         * infrun.c (handle_inferior_event): Rename from
12761         handle_inferior_event_1.  Create a scoped_value_mark.
12762         (handle_inferior_event): Remove.
12763
12764 2019-03-19  Tom Tromey  <tromey@adacore.com>
12765
12766         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12767         * infrun.h (print_stop_event): Add "displays" parameter.
12768         * infrun.c (print_stop_event): Add "displays" parameter.
12769
12770 2019-03-19  Pedro Alves  <palves@redhat.com>
12771
12772         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12773         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
12774         to -1.  Fix TABs vs spaces.
12775         (tui_ui_out::tui_ui_out): Don't initialize fields here.
12776         * tui/tui-out.h (tui_ui_out) Add intro comments.
12777         <m_line, m_start_of_line>: In-class initialize, and add describing
12778         comment.
12779
12780 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
12781
12782         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12783         variable names.
12784         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12785
12786 2019-03-18  Pedro Alves  <palves@redhat.com>
12787             Eli Zaretskii <eliz@gnu.org>
12788
12789         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12790         m_line and m_start_of_line.
12791
12792 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
12793
12794         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12795         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12796         it returns a newline.  This fixes a regression in TU mode, whereby
12797         the next line is output on the same screen line as the user input.
12798
12799 2019-03-18  Tom Tromey  <tromey@adacore.com>
12800
12801         * minsyms.c (minimal_symbol_reader::install): Remove call to
12802         obstack_blank.
12803
12804 2019-03-18  Pedro Alves  <palves@redhat.com>
12805
12806         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12807         New globals.
12808         (apply_style): New, factored out from ...
12809         (apply_ansi_escape): ... this.  Handle reverse video mode.
12810         (tui_set_reverse_mode): New function.
12811         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12812         * tui/tui-winsource.c (tui_show_source_line): Use
12813         tui_set_reverse_mode instead of setting A_STANDOUT.
12814         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12815         New setter methods.
12816
12817 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
12818
12819         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12820         Handle tabs.
12821
12822 2019-03-18  Tom Tromey  <tromey@adacore.com>
12823
12824         * ada-lang.c (empty_array): Add "high" parameter.
12825         (ada_evaluate_subexp): Update.
12826
12827 2019-03-17  Sergei Trofimovich <siarheit@google.com>
12828
12829         * unittests/string_view-selftests.c: Define
12830         _initialize_string_view_selftests unconditionally.
12831
12832 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12833
12834         PR gdb/24350
12835         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12836
12837 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12838
12839         PR gdb/24351
12840         * windows-nat.c (display_selector): Fix format specifiers.
12841
12842 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
12843
12844         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12845         tui_refill_source_window instead of tui_refresh_win, to update the
12846         current execution line.  This fixes redisplay of the current line
12847         when stepping through the code with "next" or "step".
12848
12849 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12850
12851         * source-cache.c (source_cache::get_source_lines): Call
12852         find_source_lines to initialize s->nlines.  This fixes vertical
12853         scrolling of TUI source window when the DOWN arrow is pressed.
12854
12855 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12856
12857         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12858         linux-thread-db.c (_initialize_thread_db): Likewise.
12859
12860 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12861
12862         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12863         wclrtoeol in tui_show_source_line".  This reverts changes made in
12864         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12865
12866 2019-03-15  Tom Tromey  <tom@tromey.com>
12867
12868         * symtab.h (struct minimal_symbol): Derive from
12869         general_symbol_info.
12870         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12871         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12872         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12873         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12874         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12875         (MSYMBOL_SEARCH_NAME): Update.
12876         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12877         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12878         * minsyms.c (minimal_symbol_reader::record_full): Update.
12879
12880 2019-03-15  Tom Tromey  <tom@tromey.com>
12881
12882         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12883
12884 2019-03-15  Tom Tromey  <tom@tromey.com>
12885
12886         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12887         unique_xmalloc_ptr.
12888         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12889         Update.
12890         * minsyms.c (lookup_minimal_symbol_by_pc_section)
12891         (build_minimal_symbol_hash_tables)
12892         (minimal_symbol_reader::install): Update.
12893
12894 2019-03-15  Tom Tromey  <tom@tromey.com>
12895
12896         * symtab.c (create_demangled_names_hash): Update.
12897         (symbol_set_names): Update.
12898         * objfiles.h (struct objfile_per_bfd_storage)
12899         <demangled_names_hash>: Now an htab_up.
12900         * objfiles.c (objfile_per_bfd_storage): Simplify.
12901
12902 2019-03-15  Tom Tromey  <tom@tromey.com>
12903
12904         * objfiles.h (struct objfile_per_bfd_storage): Declare
12905         destructor.
12906         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12907         New.
12908         (get_objfile_bfd_data): Use new.  Don't initialize
12909         language_of_main.
12910         (free_objfile_per_bfd_storage): Remove.
12911         (objfile_bfd_data_free, objfile::~objfile): Use delete.
12912
12913 2019-03-15  Tom Tromey  <tom@tromey.com>
12914
12915         * symfile.c (reread_symbols): Update.
12916         * objfiles.c (objfile::objfile): Update.
12917         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12918         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12919         comment.
12920         (minimal_symbol_reader::install): Update.
12921         (terminate_minimal_symbol_table): Remove.
12922         * jit.c (jit_object_close_impl): Update.
12923
12924 2019-03-15  Tom Tromey  <tom@tromey.com>
12925
12926         * minsyms.c (minimal_symbol_reader::record_full): Remove some
12927         initializations.
12928
12929 2019-03-15  Tom Tromey  <tom@tromey.com>
12930
12931         * objfiles.h (struct objfile_per_bfd_storage)
12932         <demangled_hash_languages>: Now a bitset.
12933         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
12934         (lookup_minimal_symbol): Update.
12935
12936 2019-03-15  Tom Tromey  <tom@tromey.com>
12937
12938         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
12939         Don't return the symbol.
12940         * coffread.c (record_minimal_symbol): Use record_full.
12941
12942 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
12943
12944         The MS-Windows port of ncurses fails to switch to a color pair if
12945         one or both of the colors are the implicit default colors.  This
12946         change records the default colors when TUI is initialized, and
12947         then specifies them explicitly when a color pair uses the default
12948         colors.  This allows color styling in TUI mode on MS-Windows.
12949
12950         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
12951         ncurses_norm_attr.
12952         (tui_initialize_io) [__MINGW32__]: Record the default terminal
12953         colors in ncurses_norm_attr.
12954         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
12955         "none", replace it with the default color recorded in
12956         ncurses_norm_attr.
12957
12958 2019-03-14  Tom Tromey  <tromey@adacore.com>
12959
12960         * source-cache.h (class source_cache) <get_source_lines>: Return
12961         std::string.
12962         * source-cache.c (source_cache::extract_lines): Handle case where
12963         first_pos==npos.  Return std::string.
12964         (source_cache::get_source_lines): Update.
12965
12966 2019-03-14  Tom Tromey  <tromey@adacore.com>
12967
12968         * NEWS: Add item for "style sources" commands.
12969         * source-cache.c (source_cache::get_source_lines): Check
12970         source_styling.
12971         * cli/cli-style.c (source_styling): New global.
12972         (_initialize_cli_style): Add "style sources" commands.
12973         (show_style_sources): New function.
12974         * cli/cli-style.h (source_styling): Declare.
12975
12976 2019-03-14  Pedro Alves  <palves@redhat.com>
12977             Tom Tromey  <tromey@adacore.com>
12978
12979         * tui/tui-winsource.h (tui_refill_source_window): Declare.
12980         * tui/tui-winsource.c (tui_refill_source_window): New function,
12981         from...
12982         (tui_horizontal_source_scroll): ... here.  Move some logic.
12983         * cli/cli-style.c (set_style_enabled): Notify new observable.
12984         * tui/tui-hooks.c (tui_redisplay_source): New function.
12985         (tui_attach_detach_observers): Attach or detach
12986         tui_redisplay_source.
12987         * observable.h (source_styling_changed): New observable.
12988         * observable.c: Define source_styling_changed observable.
12989
12990 2019-03-13  Tom Tromey  <tromey@adacore.com>
12991
12992         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
12993         (i386_gnu_nat_target::store_registers): Update.
12994         * target-debug.h (target_debug_print_std_string): New macro.
12995         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12996         * windows-tdep.c (display_one_tib): Update.
12997         * tui/tui-stack.c (tui_make_status_line): Update.
12998         * top.c (print_inferior_quit_action): Update.
12999         * thread.c (thr_try_catch_cmd): Update.
13000         (add_thread_with_info): Update.
13001         (thread_target_id_str): Update.
13002         (thr_try_catch_cmd): Update.
13003         (thread_command): Update.
13004         (thread_find_command): Update.
13005         * record-btrace.c (record_btrace_target::info_record)
13006         (record_btrace_resume_thread, record_btrace_target::resume)
13007         (record_btrace_cancel_resume, record_btrace_step_thread)
13008         (record_btrace_target::wait, record_btrace_target::wait)
13009         (record_btrace_target::wait, record_btrace_target::stop): Update.
13010         * progspace.c (print_program_space): Update.
13011         * process-stratum-target.c
13012         (process_stratum_target::thread_address_space): Update.
13013         * linux-fork.c (linux_fork_mourn_inferior)
13014         (detach_checkpoint_command, info_checkpoints_command)
13015         (linux_fork_context): Update.
13016         (linux_fork_detach): Update.
13017         (class scoped_switch_fork_info): Update.
13018         (delete_checkpoint_command): Update.
13019         * infrun.c (follow_fork_inferior): Update.
13020         (follow_fork_inferior): Update.
13021         (proceed_after_vfork_done): Update.
13022         (handle_vfork_child_exec_or_exit): Update.
13023         (follow_exec): Update.
13024         (displaced_step_prepare_throw): Update.
13025         (displaced_step_restore): Update.
13026         (start_step_over): Update.
13027         (resume_1): Update.
13028         (clear_proceed_status_thread): Update.
13029         (proceed): Update.
13030         (print_target_wait_results): Update.
13031         (do_target_wait): Update.
13032         (context_switch): Update.
13033         (stop_all_threads): Update.
13034         (restart_threads): Update.
13035         (finish_step_over): Update.
13036         (handle_signal_stop): Update.
13037         (switch_back_to_stepped_thread): Update.
13038         (keep_going_pass_signal): Update.
13039         (print_exited_reason): Update.
13040         (normal_stop): Update.
13041         * inferior.c (inferior_pid_to_str): Change return type.
13042         (print_selected_inferior): Update.
13043         (add_inferior): Update.
13044         (detach_inferior): Update.
13045         * dummy-frame.c (fprint_dummy_frames): Update.
13046         * dcache.c (dcache_info_1): Update.
13047         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13048         (btrace_fetch, btrace_clear): Update.
13049         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13050         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13051         type.
13052         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13053         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13054         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13055         * gdbarch.c, gdbarch.h: Rebuild.
13056         * gdbarch.sh (core_pid_to_str): Change return type.
13057         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13058         return type.
13059         (windows_nat_target::pid_to_str): Change return type.
13060         (windows_delete_thread): Update.
13061         (windows_nat_target::attach): Update.
13062         (windows_nat_target::files_info): Update.
13063         * target-delegates.c: Rebuild.
13064         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13065         return type.
13066         (sol_thread_target::pid_to_str): Change return type.
13067         * remote.c (class remote_target) <pid_to_str>: Change return
13068         type.
13069         (remote_target::pid_to_str): Change return type.
13070         (extended_remote_target::attach, remote_target::remote_stop_ns)
13071         (remote_target::remote_notif_remove_queued_reply)
13072         (remote_target::push_stop_reply, remote_target::disable_btrace):
13073         Update.
13074         (extended_remote_target::attach): Update.
13075         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13076         type.
13077         (gdbsim_target::pid_to_str): Change return type.
13078         * ravenscar-thread.c (struct ravenscar_thread_target)
13079         <pid_to_str>: Change return type.
13080         (ravenscar_thread_target::pid_to_str): Change return type.
13081         * procfs.c (class procfs_target) <pid_to_str>: Change return
13082         type.
13083         (procfs_target::pid_to_str): Change return type.
13084         (procfs_target::attach): Update.
13085         (procfs_target::detach): Update.
13086         (procfs_target::fetch_registers): Update.
13087         (procfs_target::store_registers): Update.
13088         (procfs_target::wait): Update.
13089         (procfs_target::files_info): Update.
13090         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13091         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13092         return type.
13093         (nto_procfs_target::pid_to_str): Change return type.
13094         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13095         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13096         return type.
13097         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13098         (exit_lwp): Update.
13099         (attach_proc_task_lwp_callback, get_detach_signal)
13100         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13101         (linux_nat_target::resume, wait_lwp, stop_callback)
13102         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13103         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13104         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13105         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13106         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13107         type.
13108         (inf_ptrace_target::attach): Update.
13109         (inf_ptrace_target::files_info): Update.
13110         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13111         type.
13112         (go32_nat_target::pid_to_str): Change return type.
13113         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13114         (gnu_nat_target::wait): Update.
13115         (gnu_nat_target::wait): Update.
13116         (gnu_nat_target::resume): Update.
13117         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13118         (fbsd_nat_target::wait): Update.
13119         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13120         type.
13121         (darwin_nat_target::attach): Update.
13122         * corelow.c (class core_target) <pid_to_str>: Change return type.
13123         (core_target::pid_to_str): Change return type.
13124         * target.c (normal_pid_to_str): Change return type.
13125         (default_pid_to_str): Likewise.
13126         (target_pid_to_str): Change return type.
13127         (target_translate_tls_address): Update.
13128         (target_announce_detach): Update.
13129         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13130         return type.
13131         (bsd_uthread_target::pid_to_str): Change return type.
13132         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13133         type.
13134         (bsd_kvm_target::pid_to_str): Change return type.
13135         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13136         return type.
13137         (aix_thread_target::pid_to_str): Change return type.
13138         * target.h (struct target_ops) <pid_to_str>: Change return type.
13139         (target_pid_to_str, normal_pid_to_str): Likewise.
13140         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13141         type.
13142         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13143         type.
13144         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13145         return type.
13146         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13147         type.
13148         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13149         type.
13150         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13151         return type.
13152
13153 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13154
13155         * NEWS: Mention that the new default MI version is 3.  Mention
13156         changes to the output of commands and events that deal with
13157         multi-location breakpoints.
13158         * breakpoint.c: Include "mi/mi-out.h".
13159         (print_one_breakpoint): Change output syntax if using MI version
13160         >= 3.
13161         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13162         New.
13163         (mi_multi_location_breakpoint_output_fixed): New.
13164         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13165         (mi_cmd_fix_multi_location_breakpoint_output): New.
13166         (mi_multi_location_breakpoint_output_fixed): New.
13167         * mi/mi-cmds.c (mi_cmds): Register command
13168         -fix-multi-location-breakpoint-output.
13169         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13170         interpreter "mi".
13171
13172 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13173
13174         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13175         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13176         instantiate mi_ui_out based on interpreter name.
13177         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13178         * mi/mi-main.c (mi_load_progress): Likewise.
13179
13180 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13181
13182         * NEWS: Combine separate "New targets" sections for 8.3.
13183
13184 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13185
13186         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13187         (ppcfbsd_init_abi): Install gdbarch
13188         "fetch_tls_load_module_address" and "get_thread_local_address"
13189         methods.
13190
13191 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13192
13193         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13194         (riscv_fbsd_init_abi): Install gdbarch
13195         "fetch_tls_load_module_address" and "get_thread_local_address"
13196         methods.
13197
13198 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13199
13200         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13201         (i386fbsd_init_abi): Install gdbarch
13202         "fetch_tls_load_module_address" and "get_thread_local_address"
13203         methods.
13204
13205 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13206
13207         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13208         (amd64fbsd_init_abi): Install gdbarch
13209         "fetch_tls_load_module_address" and "get_thread_local_address"
13210         methods.
13211
13212 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13213
13214         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13215         (struct fbsd_pspace_data): New type.
13216         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13217         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13218         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13219         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13220         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13221
13222 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13223
13224         * gdbtypes.c (lookup_struct_elt): New function.
13225         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13226         * gdbtypes.h (struct struct_elt): New type.
13227         (lookup_struct_elt): New prototype.
13228
13229 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13230
13231         * gdbtypes.c (lookup_struct_elt_type): Update comment and
13232         remove disabled code block.
13233
13234 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13235
13236         * gdbarch.sh (get_thread_local_address): New method.
13237         * gdbarch.h, gdbarch.c: Regenerate.
13238         * target.c (target_translate_tls_address): Use
13239         gdbarch_get_thread_local_address if present instead of
13240         target::get_thread_local_address.
13241
13242 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13243
13244         * target.h (target::get_thread_local_address): Update comment.
13245
13246 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13247
13248         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13249         objfile->separate_debug_objfile_backlink if not NULL.
13250
13251 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13252
13253         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13254         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13255         (amd64bsd_store_inferior_registers): Likewise.
13256         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13257         Enable segment base registers.
13258         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13259         PT_GETFSBASE and PT_GETGSBASE.
13260         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13261         PT_SETGSBASE.
13262         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13263         segment base registers.
13264         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13265
13266 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13267
13268         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13269         Update calls to i386_target_description to add 'segments'
13270         parameter.
13271         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
13272         add segment base registers.
13273         * arch/i386.c (i386_create_target_description): Add 'segments'
13274         parameter to enable segment base registers.
13275         * arch/i386.h (i386_create_target_description): Likewise.
13276         * features/i386/32bit-segments.xml: New file.
13277         * features/i386/32bit-segments.c: Generate.
13278         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13279         call to i386_target_description to add 'segments' parameter.
13280         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13281         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13282         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13283         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13284         if feature is present.
13285         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13286         Add 'segments' parameter to call to i386_target_description.
13287         (i386_target_description): Add 'segments' parameter to enable
13288         segment base registers.
13289         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13290         to call to i386_target_description.
13291         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13292         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13293         Define I386_NUM_REGS.
13294         (i386_target_description): Add 'segments' parameter to enable
13295         segment base registers.
13296
13297 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
13298
13299         PR/24325
13300         * source-cache.c: #undef open and close, to avoid unresolved
13301         externals during linking.
13302
13303 2019-03-12  Tom Tromey  <tromey@adacore.com>
13304
13305         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13306         const.  Add initializers.
13307         (_initialize_remote): Don't initialize ptid globals.
13308
13309 2019-03-12  Pedro Alves  <palves@redhat.com>
13310
13311         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13312
13313 2019-03-12  Pedro Alves  <palves@redhat.com>
13314
13315         * cp-name-parser.y (main): Remove unused 'len' variable.
13316
13317 2019-03-12  Tom Tromey  <tromey@adacore.com>
13318
13319         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13320         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13321
13322 2019-03-12  Tom Tromey  <tromey@adacore.com>
13323
13324         * linux-nat.c (iterate_over_lwps): Update.
13325         (stop_callback): Remove parameter.
13326         (stop_wait_callback, detach_callback, resume_set_callback)
13327         (select_singlestep_lwp_callback, set_ignore_sigint)
13328         (status_callback, resumed_callback, resume_clear_callback)
13329         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13330         data parameter.
13331         (linux_nat_target::detach, linux_nat_target::resume)
13332         (linux_stop_and_wait_all_lwps, select_event_lwp)
13333         (linux_nat_filter_event, linux_nat_wait_1)
13334         (linux_nat_target::kill, linux_nat_target::stop)
13335         (linux_nat_target::stop): Update.
13336         (linux_nat_resume_callback): Change type.
13337         (resume_stopped_resumed_lwps, count_events_callback)
13338         (select_event_lwp_callback): Likewise.
13339         (linux_stop_lwp, linux_nat_stop_lwp): Update.
13340         * arm-linux-nat.c (struct update_registers_data): Remove.
13341         (update_registers_callback): Change type.
13342         (arm_linux_insert_hw_breakpoint1): Update.
13343         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13344         parameter.
13345         (x86_linux_dr_set_addr): Update.
13346         (x86_linux_dr_set_control): Update.
13347         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13348         (iterate_over_lwps): Use gdb::function_view.
13349         * nat/aarch64-linux-hw-point.c (struct
13350         aarch64_dr_update_callback_param): Remove.
13351         (debug_reg_change_callback): Change type.
13352         (aarch64_notify_debug_reg_change): Update.
13353         * s390-linux-nat.c (s390_refresh_per_info): Update.
13354
13355 2019-03-11  Tom Tromey  <tromey@adacore.com>
13356
13357         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13358         redundant assignment to "this_cu".
13359
13360 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13361
13362         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13363
13364 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13365
13366         * gdbtypes.c (rank_one_type_parm_set): New function extracted
13367         from...
13368         (rank_one_type): ... this.
13369
13370 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13371
13372         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13373         from...
13374         (rank_one_type): ... this.
13375
13376 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13377
13378         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13379         from...
13380         (rank_one_type): ... this.
13381
13382 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13383
13384         * gdbtypes.c (rank_one_type_parm_float): New function extracted
13385         from...
13386         (rank_one_type): ... this.
13387
13388 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13389
13390         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13391         from...
13392         (rank_one_type): ... this.
13393
13394 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13395
13396         * gdbtypes.c (rank_one_type_parm_range): New function extracted
13397         from...
13398         (rank_one_type): ... this.
13399
13400 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13401
13402         * gdbtypes.c (rank_one_type_parm_char): New function extracted
13403         from...
13404         (rank_one_type): ... this.
13405
13406 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13407
13408         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13409         from...
13410         (rank_one_type): ... this.
13411
13412 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13413
13414         * gdbtypes.c (rank_one_type_parm_int): New function extracted
13415         from...
13416         (rank_one_type): ... this.
13417
13418 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13419
13420         * gdbtypes.c (rank_one_type_parm_func): New function extracted
13421         from...
13422         (rank_one_type): ... this.
13423
13424 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13425
13426         * gdbtypes.c (rank_one_type_parm_array): New function extracted
13427         from...
13428         (rank_one_type): ... this.
13429
13430 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13431
13432         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13433         from...
13434         (rank_one_type): ... this.
13435
13436 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13437
13438         * inferior.c (initialize_inferiors): Ensure 'help set/show print
13439         inferior-events' shows the example events.
13440
13441 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
13442
13443         Support styling on native MS-Windows console
13444
13445         PR/24315
13446         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13447         on MS-Windows if $TERM is not defined.
13448
13449         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13450
13451         * posix-hdep.c (gdb_console_fputs):
13452         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13453         functions.
13454         * ui-file.h (gdb_console_fputs): Add prototype.
13455
13456         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13457         back to fputs only if the former returns zero.
13458
13459 2019-03-07  Tom Tromey  <tom@tromey.com>
13460
13461         * symmisc.c (print_symbol_bcache_statistics): Update.
13462         (print_objfile_statistics): Update.
13463         * symfile.c (allocate_symtab): Update.
13464         * stabsread.c: Don't include bcache.h.
13465         * psymtab.h (struct psymbol_bcache): Don't declare.
13466         (class psymtab_storage) <psymbol_cache>: Now a bcache.
13467         (psymbol_bcache_init, psymbol_bcache_free)
13468         (psymbol_bcache_get_bcache): Don't declare.
13469         * psymtab.c (struct psymbol_bcache): Remove.
13470         (psymtab_storage::psymtab_storage): Update.
13471         (psymtab_storage::~psymtab_storage): Update.
13472         (psymbol_bcache_init, psymbol_bcache_free)
13473         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13474         (add_psymbol_to_bcache): Update.
13475         (allocate_psymtab): Update.
13476         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13477         macro_cache>: No longer pointers.
13478         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13479         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13480         * macrotab.c (macro_bcache): Update.
13481         * macroexp.c: Don't include bcache.h.
13482         * gdbtypes.c (check_types_worklist): Update.
13483         (types_deeply_equal): Remove TRY/CATCH.  Update.
13484         * elfread.c (elf_symtab_read): Update.
13485         * dwarf2read.c: Don't include bcache.h.
13486         * buildsym.c (buildsym_compunit::get_macro_table): Update.
13487         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13488         (print_bcache_statistics, bcache_memory_used): Don't declare.
13489         (struct bcache): Move from bcache.c.  Add constructor, destructor,
13490         methods.  Rename all data members.
13491         * bcache.c (struct bcache): Move to bcache.h.
13492         (bcache::expand_hash_table): Rename from expand_hash_table.
13493         (bcache): Remove.
13494         (bcache::insert): Rename from bcache_full.
13495         (bcache::compare): Rename from bcache_compare.
13496         (bcache_xmalloc): Remove.
13497         (bcache::~bcache): Rename from bcache_xfree.
13498         (bcache::print_statistics): Rename from print_bcache_statistics.
13499         (bcache::memory_used): Rename from bcache_memory_used.
13500
13501 2019-03-07  Pedro Alves  <palves@redhat.com>
13502
13503         * infrun.c (normal_stop): Also check for
13504         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13505
13506 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
13507
13508         * f-lang.c (value_from_host_double): Moved to...
13509         * value.c (value_from_host_double): ...here.
13510         * value.h (value_from_host_double): Declare.
13511         * guile/scm-math.c (vlscm_convert_typed_number): Use
13512         value_from_host_double.
13513         (vlscm_convert_number): Likewise.
13514         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13515         * python/py-value.c (convert_value_from_python): Likewise.
13516
13517 2019-03-06  Tom Tromey  <tom@tromey.com>
13518
13519         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13520
13521 2019-03-06  Tom Tromey  <tom@tromey.com>
13522
13523         * utils.h (free_current_contents): Don't declare.
13524         * utils.c (free_current_contents): Remove.
13525
13526 2019-03-06  Tom Tromey  <tom@tromey.com>
13527
13528         * top.c (quit_force): Update.
13529         * main.c (captured_command_loop): Update.
13530         * common/new-op.c (operator new): Update.
13531         * common/common-exceptions.c (struct catcher)
13532         <save_cleanup_chain>: Remove member.
13533         (exceptions_state_mc_init): Update.
13534         (exception_try_scope_entry): Return nullptr.
13535         (exception_try_scope_exit, exception_rethrow)
13536         (throw_exception_sjlj, throw_exception_cxx): Update.
13537         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13538         (all_cleanups, do_cleanups, discard_cleanups)
13539         (discard_final_cleanups, save_cleanups, save_final_cleanups)
13540         (restore_cleanups, restore_final_cleanups): Don't declare.
13541         (do_final_cleanups): Remove parameter.
13542         * common/cleanups.c (cleanup_chain, make_cleanup)
13543         (make_cleanup_dtor, all_cleanups, do_cleanups)
13544         (discard_my_cleanups, discard_cleanups)
13545         (discard_final_cleanups, save_my_cleanups, save_cleanups)
13546         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13547         (null_cleanup): Remove.
13548         (do_final_cleanups): Remove parameter.
13549
13550 2019-03-06  Tom Tromey  <tom@tromey.com>
13551
13552         * remote.c (remote_target::remote_parse_stop_reply): Use
13553         unique_xmalloc_ptr.
13554
13555 2019-03-06  Tom Tromey  <tom@tromey.com>
13556
13557         * stabsread.c (struct stabs_field_info): Rename from field_info.
13558         <list, fnlist>: Add initializers.
13559         <obstack>: New member.
13560         (read_member_functions, read_struct_fields, read_baseclasses):
13561         Allocate on obstack.  Don't use cleanups.
13562         (read_one_struct_field, read_member_functions, read_struct_fields)
13563         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13564         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13565         (read_struct_type): Update.
13566
13567 2019-03-06  Tom Tromey  <tom@tromey.com>
13568
13569         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13570         * common/filestuff.h (make_cleanup_close): Don't declare.
13571         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13572         Remove.
13573
13574 2019-03-06  Tom Tromey  <tom@tromey.com>
13575
13576         * solib-aix.c: Use make_scope_exit.
13577
13578 2019-03-06  Tom Tromey  <tom@tromey.com>
13579
13580         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13581         Use make_scope_exit.
13582
13583 2019-03-06  Tom Tromey  <tom@tromey.com>
13584
13585         * solib-svr4.c (disable_probes_interface): Remove parameter.
13586         (svr4_handle_solib_event): Use make_scope_exit.
13587
13588 2019-03-06  Tom Tromey  <tom@tromey.com>
13589
13590         * remote.c (struct stop_reply_deleter): Remove.
13591         (stop_reply_up): Update.
13592         (struct stop_reply): Derive from notif_event.  Don't typedef.
13593         <regcache>: Now a std::vector.
13594         (stop_reply_xfree): Remove.
13595         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13596         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
13597         (remote_target::discard_pending_stop_replies): Use delete.
13598         (remote_target::remote_parse_stop_reply): Update.
13599         (remote_target::process_stop_reply): Update.
13600         * remote-notif.h (struct notif_event): Add virtual destructor.
13601         Remove "dtr" member.
13602         (struct notif_client) <alloc_event>: Return a unique_ptr.
13603         (notif_event_xfree): Don't declare.
13604         (notif_event_up): New typedef.
13605         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13606         (notif_event_xfree, do_notif_event_xfree): Remove.
13607         (remote_notif_state_xfree): Update.
13608
13609 2019-03-06  Tom Tromey  <tom@tromey.com>
13610
13611         * infrun.c (displaced_step_clear_cleanup): Now a
13612         forward_scope_exit type.
13613         (displaced_step_prepare_throw): Update.
13614         (displaced_step_fixup): Update.
13615
13616 2019-03-06  Tom Tromey  <tom@tromey.com>
13617
13618         * inferior.h (class inferior): Update comment.
13619         * gdbthread.h (class thread_info): Update comment.
13620
13621 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
13622             Tom Tromey  <tom@tromey.com>
13623
13624         * stabsread.h (struct stab_section_list): Remove.
13625         (coffstab_build_psymtabs): Update.
13626         * dbxread.c (symbuf_sections): Now a std::vector.
13627         (sect_idx): New global.
13628         (fill_symbuf): Update.
13629         (coffstab_build_psymtabs): Change type of stabsects parameter.
13630         Update.
13631         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13632         std::vector.
13633         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13634         (coff_locate_sections): Update.
13635         (coff_symfile_read): Remove cleanups.  Update.
13636         (init_stringtab): Add storage parameter.
13637         (free_stringtab, free_stringtab_cleanup): Remove.
13638         (init_lineno): Add storage parameter.
13639         (free_linetab, free_linetab_cleanup): Remove.
13640
13641 2019-03-06  Pedro Alves  <palves@redhat.com>
13642
13643         * linux-fork.c (fork_info::clobber_regs): Delete.
13644         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13645         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
13646         comment.  Adjust.
13647         (scoped_switch_fork_info::scoped_switch_fork_info)
13648         (checkpoint_command, linux_fork_context): Adjust
13649         fork_save_infrun_state calls.
13650
13651 2019-03-06  Pedro Alves  <palves@redhat.com>
13652
13653         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13654         (inf_has_multiple_threads): Return 'bool' and rewrite using
13655         inferior_info::threads().
13656
13657 2019-03-06  Pedro Alves  <palves@redhat.com>
13658
13659         * linux-fork.c: Include <list>.
13660         (fork_list): Now a std::list instance.
13661         (fork_info): Add ctor, dtor, and in-class initialize all fields.
13662         (forks_exist_p, find_last_fork): Adjust.
13663         (new_fork): Delete.
13664         (one_fork_p): New.
13665         (add_fork): Adjust.
13666         (free_fork): Delete, folded into fork_info::~fork_info().
13667         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13668         Adjust.
13669         (init_fork_list): Delete.
13670         (linux_fork_killall, linux_fork_mourn_inferior)
13671         (linux_fork_detach, info_checkpoints_command): Adjust.
13672         (_initialize_linux_fork): No longer call init_fork_list.
13673
13674 2019-03-06  Pedro Alves  <palves@redhat.com>
13675
13676         * linux-fork.c (new_fork): New, split out of ...
13677         (add_fork): ... this.  Return void.  Move "first fork" special
13678         case from here, to ...
13679         (checkpoint_command): ... here.
13680         * linux-linux.h (add_fork): Return void.
13681
13682 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13683
13684         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13685
13686 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13687             Chris January  <chris.january@arm.com>
13688             David Lecomber  <david.lecomber@arm.com>
13689
13690         * f-exp.y: New token, UNOP_INTRINSIC.
13691         (exp): New pattern using UNOP_INTRINSIC token.
13692         (f77_keywords): Add 'abs' keyword.
13693         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13694         (value_from_host_double): New function.
13695         (evaluate_subexp_f): Support UNOP_ABS.
13696
13697 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13698
13699         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13700         types.
13701
13702 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13703
13704         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13705         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13706         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13707
13708 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13709
13710         * f-exp.y (convert_to_kind_type): Handle more type kinds.
13711
13712 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13713             Chris January  <chris.january@arm.com>
13714
13715         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13716         * f-exp.y: Define 'KIND' token.
13717         (exp): New pattern for KIND expressions.
13718         (ptype): Handle types with a kind extension.
13719         (direct_abs_decl): Extend to spot kind extensions.
13720         (f77_keywords): Add 'kind' to the list.
13721         (push_kind_type): New function.
13722         (convert_to_kind_type): New function.
13723         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13724         * parse.c (operator_length_standard): Likewise.
13725         * parser-defs.h (enum type_pieces): Add tp_kind.
13726         * std-operator.def: Add UNOP_KIND.
13727
13728 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13729
13730         * f-exp.y (f_parse): Set yydebug.
13731
13732 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13733
13734         * f-lang.c (evaluate_subexp_f): New function.
13735         (exp_descriptor_f): New global.
13736         (f_language_defn): Use exp_descriptor_f instead of
13737         exp_descriptor_standard.
13738
13739 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13740
13741         * f-exp.y (struct token): Add comments.
13742         (dot_ops): Remove uppercase versions and the end marker.
13743         (f77_keywords): Likewise.
13744         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13745         entries in the dot_ops array are case insensitive, and use
13746         strncasecmp to compare strings.  Also some whitespace cleanup in
13747         this area.  Similar for the f77_keywords array, except entries in
13748         this list might be case sensitive.
13749
13750 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13751
13752         * f-exp.y (struct f77_boolean_val): Add comments.
13753         (boolean_values): Remove uppercase versions, and end marker.
13754         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13755         and use strncasecmp to achieve case insensitivity.  Additionally,
13756         perform whitespace cleanup around this code.
13757
13758 2019-03-06  Tom Tromey  <tromey@adacore.com>
13759
13760         * remote-sim.c (gdbsim_target_open): Use result of
13761         gdb_argv::release.
13762
13763 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
13764         Dirk Schubert  <dirk.schubert@arm.com>
13765         Chris January  <chris.january@arm.com>
13766
13767         * eval.c (evaluate_subexp_standard): Call Fortran argument
13768         wrapping logic.
13769         * f-lang.c (struct value): A value which can be passed into a
13770         Fortran function call.
13771         (fortran_argument_convert): Wrap Fortran arguments in a pointer
13772         where appropriate.
13773         (struct type): Value ready for a Fortran function call.
13774         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13775         is needed.
13776         * f-lang.h (fortran_argument_convert): Declaration.
13777         (fortran_preserve_arg_pointer): Declaration.
13778         * infcall.c (value_arg_coerce): Call Fortran argument logic.
13779
13780 2019-03-05  Tom Tromey  <tromey@adacore.com>
13781
13782         * python/py-prettyprint.c (print_string_repr): Remove #if.
13783         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13784
13785 2019-03-05  Tom Tromey  <tromey@adacore.com>
13786
13787         * target.c (the_dummy_target): Move later.  Change type to
13788         "dummy_target".
13789         (initialize_targets): Don't initialize the_dummy_target.
13790
13791 2019-03-05  Tom Tromey  <tromey@adacore.com>
13792
13793         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13794         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13795
13796 2019-03-05  Tom Tromey  <tromey@adacore.com>
13797
13798         * windows-nat.c (windows_nat_target::attach)
13799         (windows_nat_target::detach): Don't call gdb_flush.
13800         * valprint.c (generic_val_print, val_print, val_print_string):
13801         Don't call gdb_flush.
13802         * utils.c (defaulted_query): Don't call gdb_flush.
13803         * typeprint.c (print_type_scalar): Don't call gdb_flush.
13804         * target.c (target_announce_detach): Don't call gdb_flush.
13805         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13806         * remote.c (extended_remote_target::attach): Don't call
13807         gdb_flush.
13808         * procfs.c (procfs_target::detach): Don't call gdb_flush.
13809         * printcmd.c (do_examine): Don't call gdb_flush.
13810         (info_display_command): Don't call gdb_flush.
13811         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13812         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13813         * memattr.c (info_mem_command): Don't call gdb_flush.
13814         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13815         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13816         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13817         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13818         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13819         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13820         (gnu_nat_target::detach): Don't call gdb_flush.
13821         * f-valprint.c (f_val_print): Don't call gdb_flush.
13822         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13823         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13824         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13825         gdb_flush.
13826         * c-valprint.c (c_val_print): Don't call gdb_flush.
13827         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13828
13829 2019-03-05  Tom Tromey  <tromey@adacore.com>
13830
13831         * varobj.c (update_dynamic_varobj_children): Update.
13832         (install_default_visualizer): Use reset, not release.
13833         * value.c (set_internalvar): Update.
13834         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13835         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13836         ATTRIBUTE_UNUSED_RESULT.
13837
13838 2019-03-05  Tom Tromey  <tromey@adacore.com>
13839
13840         * remote.c (class scoped_remote_fd) <release>: Add
13841         ATTRIBUTE_UNUSED_RESULT.
13842
13843 2019-03-05  Tom Tromey  <tromey@adacore.com>
13844
13845         * macroexp.c (struct macro_buffer) <release>: Add
13846         ATTRIBUTE_UNUSED_RESULT.
13847
13848 2019-03-05  Tom Tromey  <tromey@adacore.com>
13849
13850         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13851         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13852         ATTRIBUTE_UNUSED_RESULT.
13853
13854 2019-03-05  Tom Tromey  <tromey@adacore.com>
13855
13856         * common/scoped_fd.h (class scoped_fd) <release>: Add
13857         ATTRIBUTE_UNUSED_RESULT.
13858
13859 2019-03-05  Tom Tromey  <tromey@adacore.com>
13860
13861         * parser-defs.h (struct parser_state) <release>: Add
13862         ATTRIBUTE_UNUSED_RESULT.
13863
13864 2019-03-05  Tom Tromey  <tromey@adacore.com>
13865
13866         * utils.h (class gdb_argv) <release>: Add
13867         ATTRIBUTE_UNUSED_RESULT.
13868         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13869
13870 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
13871
13872         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13873         for-loop range, to avoid compiler warnings.
13874
13875         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13876         avoid compiler warnings about unused variables.
13877
13878         * NEWS: Mention end of support for native debugging on MS-Windows
13879         before XP.
13880
13881         PR gdb/24292
13882         * common/netstuff.c:
13883         * gdbserver/gdbreplay.c
13884         * gdbserver/remote-utils.c:
13885         * ser-tcp.c:
13886         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13887         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
13888         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13889         'getaddrinfo' and 'freeaddrinfo' were not available before
13890         Windows XP, and mingw.org's MinGW headers by default define
13891         _WIN32_WINNT to 0x500.
13892
13893 2019-03-01  Gary Benson <gbenson@redhat.com>
13894
13895         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13896
13897 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
13898             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
13899
13900         PR gdb/8527
13901         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13902         set_sigint_trap, clear_sigint_trap.
13903
13904 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13905
13906         * target.c (target_detach): Clear the regcache and the
13907         frame cache.
13908
13909 2019-02-27  Pedro Alves  <palves@redhat.com>
13910
13911         * utils.c (set_screen_size): When we cap the height/width sizes,
13912         tweak the corresponding command variable to show "unlimited":
13913
13914 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
13915             Pedro Alves  <palves@redhat.com>
13916
13917         * utils.c (set_screen_size): Reduce "infinite" rows and columns
13918         before calling rl_set_screen_size.
13919
13920 2019-02-27  Tom Tromey  <tromey@adacore.com>
13921
13922         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
13923         define.
13924         * python/py-value.c: Remove Python 2.4 workaround.
13925         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
13926         workaround.
13927         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
13928         Python 2.4 workaround.
13929         * python/python-internal.h: Remove Python 2.4 comment.
13930         (Py_ssize_t): Don't define.
13931         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
13932         (gdb_Py_DECREF): Remove Python 2.4 workaround.
13933         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
13934         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
13935         * python/python.c (do_start_initialization): Remove Python 2.4
13936         workaround.
13937         * python/py-prettyprint.c (class dummy_python_frame): Remove.
13938         (print_children): Remove Python 2.4 workaround.
13939         * python/py-inferior.c (buffer_procs): Remove Python 2.4
13940         workaround.
13941         (CHARBUFFERPROC_NAME): Remove.
13942         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
13943         Python 2.4 workaround.
13944
13945 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
13946
13947         * NEWS: Note minimum Python version.
13948
13949 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
13950
13951         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
13952         code from these functions.  Remove corresponding ifdefs.  Use
13953         Py_buffer_up instead of explicit calls to PyBuffer_Release.
13954         Remove gotos and target of gotos.
13955         (infpy_search_memory): Likewise.
13956
13957 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13958
13959         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
13960         (hppa_gdbarch_init): Don't register deleted functions with
13961         gdbarch.
13962
13963 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13964
13965         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
13966         (h8300_unwind_sp): Delete.
13967         (h8300_dummy_id): Delete.
13968         (h8300_gdbarch_init): Don't register deleted functions with
13969         gdbarch.
13970
13971 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13972
13973         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
13974         (ft32_unwind_pc): Delete.
13975         (ft32_unwind_sp): Delete.
13976         (ft32_gdbarch_init): Don't register deleted functions with
13977         gdbarch.
13978
13979 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13980
13981         * gdb/frv-tdep.c (frv_dummy_id): Delete.
13982         (frv_unwind_pc): Delete.
13983         (frv_unwind_sp): Delete.
13984         (frv_gdbarch_init): Don't register deleted functions with
13985         gdbarch.
13986
13987 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13988
13989         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
13990         (riscv_unwind_pc): Delete.
13991         (riscv_unwind_sp): Delete.
13992         (riscv_gdbarch_init): Don't register deleted functions with
13993         gdbarch.
13994
13995 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13996
13997         * gdb/csky-tdep.c (csky_dummy_id): Delete.
13998         (csky_unwind_pc): Delete.
13999         (csky_unwind_sp): Delete.
14000         (csky_gdbarch_init): Don't register deleted functions with
14001         gdbarch.
14002
14003 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14004
14005         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14006         (cris_unwind_pc): Delete.
14007         (cris_unwind_sp): Delete.
14008         (cris_gdbarch_init): Don't register deleted functions with
14009         gdbarch.
14010
14011 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14012
14013         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14014         (bfin_unwind_pc): Delete.
14015         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14016
14017 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14018
14019         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14020         (arm_unwind_pc): Delete.
14021         (arm_unwind_sp): Delete.
14022         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14023
14024 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14025
14026         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14027         (arc_unwind_pc): Delete.
14028         (arc_unwind_sp): Delete.
14029         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14030
14031 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14032
14033         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14034         (alpha_unwind_pc): Delete.
14035         (alpha_gdbarch_init): Don't register deleted functions with
14036         gdbarch.
14037
14038 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14039
14040         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14041         (aarch64_unwind_pc): Delete.
14042         (aarch64_unwind_sp): Delete.
14043         (aarch64_gdbarch_init): Don't register deleted functions with
14044         gdbarch.
14045
14046 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14047
14048         * gdbtypes.c (type_align): Don't consider static members when
14049         computing structure alignment.
14050
14051 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14052
14053         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14054         return 0 for other types.
14055         * arch-utils.c (default_type_align): Always return 0.
14056         * gdbarch.h: Regenerate.
14057         * gdbarch.sh (type_align): Extend comment.
14058         * gdbtypes.c (type_align): Add additional comments, always call
14059         gdbarch_type_align before applying the default rules.
14060         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14061         generic code will then apply a suitable default.
14062         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14063         types, return 0 for other types.
14064
14065 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14066
14067         * NEWS: Create a new section for the next release branch.
14068         Rename the section of the current branch, now that it has
14069         been cut.
14070
14071 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14072
14073         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14074         * version.in: Bump version to 8.3.50.DATE-git.
14075
14076 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14077
14078         * aix-thread.c (ptid_cmp): Remove unused variable.
14079         (get_signaled_thread): Likewise.
14080         (store_regs_user_thread): Likewise.
14081         (store_regs_kernel_thread): Likewise.
14082         (fetch_regs_kernel_thread): Remove shadowed variable.
14083
14084 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14085
14086         * features/riscv/32bit-cpu.xml: Add register numbers.
14087         * features/riscv/32bit-fpu.c: Regenerate.
14088         * features/riscv/32bit-fpu.xml: Add register numbers.
14089         * features/riscv/64bit-cpu.xml: Add register numbers.
14090         * features/riscv/64bit-fpu.c: Regenerate.
14091         * features/riscv/64bit-fpu.xml: Add register numbers.
14092
14093 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14094
14095         * NEWS: Mention two argument form of gdb.Value constructor.
14096         * python/py-value.c (convert_buffer_and_type_to_value): New
14097         function.
14098         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14099         Add support for handling an optional second argument.  Call
14100         convert_buffer_and_type_to_value as appropriate.
14101         * python/python-internal.h (Py_buffer_deleter): New struct.
14102         (Py_buffer_up): New typedef.
14103
14104 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14105
14106         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14107         instead of releasing ownership.
14108
14109 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14110
14111         * dwarf2read.c (open_and_init_dwp_file): Call
14112         elf_numsections instead of bfd_count_sections to initialize
14113         dwp_file->num_sections.
14114
14115 2019-02-25  Tom Tromey  <tromey@adacore.com>
14116
14117         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14118
14119 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14120
14121         * gcore.in: Add '--readnever' option when invoking GDB.
14122
14123 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14124
14125         * MAINTAINERS: Update my email address.
14126
14127 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14128
14129         * build-id.c (build_id_to_debug_bfd_1): New function.
14130         (build_id_to_debug_bfd): Look for separate debug file in
14131         sysroot.
14132
14133 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14134
14135         * gdbarch.sh: Update the copyright year range that is placed into
14136         generated files.
14137
14138 2019-02-22  Keith Seitz  <keiths@redhat.com>
14139
14140         PR symtab/23853
14141         * linespec.c (create_sals_line_offset): Search for the default
14142         symtab's filename instead of its fullname.
14143
14144 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14145
14146         * NEWS: Update style defaults.
14147
14148 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14149
14150         * main.c (captured_main_1): Disable styling in batch mode.
14151
14152 2019-02-20  Tom Tromey  <tom@tromey.com>
14153
14154         * symtab.c (symtab_symbol_info): Fix typos.
14155
14156 2019-02-20  Tom Tromey  <tromey@adacore.com>
14157
14158         * findcmd.c (_initialize_mem_search): Use upper case for
14159         metasyntactic variables.
14160
14161 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14162
14163         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14164         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14165
14166 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14167
14168         * top.h (source_file_name): Change to std::string.
14169         * top.c (source_file_name): Likewise.
14170         (command_line_input): Adjust.
14171         * cli/cli-script.c (script_from_file): Adjust.
14172
14173 2019-02-19  Tom Tromey  <tromey@adacore.com>
14174
14175         * ravenscar-thread.c
14176         (ravenscar_thread_target::update_thread_list): Don't call
14177         ada_build_task_list.
14178         * ada-lang.h (ada_build_task_list): Don't declare.
14179         * ada-tasks.c (struct ada_tasks_inferior_data)
14180         <task_list_valid_p>: Now bool.
14181         (read_known_tasks, ada_task_list_changed)
14182         (ada_tasks_invalidate_inferior_data): Update.
14183         (read_known_tasks_array): Return bool.
14184         (read_known_tasks_list): Likewise.
14185         (read_known_tasks): Return void.
14186         (ada_build_task_list): Now static.
14187
14188 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14189
14190         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14191         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14192
14193 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14194
14195         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14196         variant for ada_tasks_pspace_data_handle and
14197         ada_tasks_inferior_data_handle.
14198         (ada_tasks_pspace_data_cleanup): New function.
14199         (ada_tasks_inferior_data_cleanup): New function.
14200
14201 2019-02-17  Tom Tromey  <tom@tromey.com>
14202
14203         * macrotab.h (macro_source_fullname): Return a std::string.
14204         * macrotab.c (macro_include, check_for_redefinition)
14205         (macro_undef, macro_lookup_definition, foreach_macro)
14206         (foreach_macro_in_scope): Update.
14207         (macro_source_fullname): Return a std::string.
14208         * macrocmd.c (show_pp_source_pos): Update.
14209
14210 2019-02-17  Tom Tromey  <tom@tromey.com>
14211
14212         * macrocmd.c (show_pp_source_pos): Style the file names.
14213
14214 2019-02-17  Tom Tromey  <tom@tromey.com>
14215
14216         PR tui/24197:
14217         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14218
14219 2019-02-17  Tom Tromey  <tom@tromey.com>
14220
14221         * ada-lang.c (user_select_syms): Use filtered printing.
14222         * utils.c (wrap_style): New global.
14223         (desired_style): Remove.
14224         (emit_style_escape): Add stream parameter.
14225         (set_output_style, reset_terminal_style, prompt_for_continue):
14226         Update.
14227         (flush_wrap_buffer): Only flush gdb_stdout.
14228         (wrap_here): Set wrap_style.
14229         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
14230         treat escape sequences as a character.  Change when wrap buffer is
14231         flushed.
14232         (fputs_styled): Do not set the output style when the default is
14233         requested.
14234         * ui-style.h (struct ui_file_style) <is_default>: New method.
14235         * source.c (print_source_lines_base): Emit escape sequences in one
14236         piece.
14237
14238 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14239
14240         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14241         integers and enumeration types.
14242
14243 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14244
14245         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14246         instead of lookup_symbol_in_language
14247         (do_exact_match): New function.
14248         (ada_get_symbol_name_matcher): Return do_exact_match when
14249         doing a verbatim match.
14250
14251 2019-02-15  Tom Tromey  <tromey@adacore.com>
14252
14253         * ravenscar-thread.c (ravenscar_thread_target::resume)
14254         (ravenscar_thread_target::wait): Special case wildcard requests.
14255
14256 2019-02-15  Tom Tromey  <tromey@adacore.com>
14257
14258         * ravenscar-thread.c (base_ptid): Remove.
14259         (struct ravenscar_thread_target) <close>: New method.
14260         <m_base_ptid>: New member.
14261         <update_inferior_ptid, active_task, task_is_currently_active,
14262         runtime_initialized>: Declare methods.
14263         <ravenscar_thread_target>: Add constructor.
14264         (ravenscar_thread_target::task_is_currently_active)
14265         (ravenscar_thread_target::update_inferior_ptid)
14266         (ravenscar_runtime_initialized): Rename.  Now methods.
14267         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14268         (ravenscar_thread_target::update_thread_list): Update.
14269         (ravenscar_thread_target::active_task): Now method.
14270         (ravenscar_thread_target::store_registers)
14271         (ravenscar_thread_target::prepare_to_store)
14272         (ravenscar_thread_target::prepare_to_store)
14273         (ravenscar_thread_target::mourn_inferior): Update.
14274         (ravenscar_inferior_created): Use "new" to create target.
14275         (ravenscar_thread_target::get_ada_task_ptid): Update.
14276         (_initialize_ravenscar): Don't initialize base_ptid.
14277         (ravenscar_ops): Remove global.
14278
14279 2019-02-15  Tom Tromey  <tromey@adacore.com>
14280
14281         * target.h (push_target): Declare new overload.
14282         * target.c (push_target): New overload, taking an rvalue reference.
14283         * remote.c (remote_target::open_1): Use push_target overload.
14284         * corelow.c (core_target_open): Use push_target overload.
14285
14286 2019-02-15  Tom Tromey  <tromey@adacore.com>
14287
14288         * ravenscar-thread.c (is_ravenscar_task)
14289         (ravenscar_task_is_currently_active): Return bool.
14290         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14291         (_initialize_ravenscar): Remove "(void)".
14292         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14293         Return bool.
14294
14295 2019-02-15  Tom Tromey  <tromey@adacore.com>
14296
14297         * ravenscar-thread.c (ravenscar_runtime_initializer)
14298         (has_ravenscar_runtime, get_running_thread_id)
14299         (ravenscar_thread_target::resume): Fix indentation.
14300
14301 2019-02-15  Tom Tromey  <tromey@adacore.com>
14302
14303         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14304         from ravenscar_arch_ops.
14305         (sparc_ravenscar_ops::fetch_registers)
14306         (sparc_ravenscar_ops::store_registers): Now methods.
14307         (sparc_ravenscar_prepare_to_store): Remove.
14308         (sparc_ravenscar_ops): Redefine.
14309         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14310         methods and destructor.  Remove members.
14311         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14312         (ravenscar_thread_target::store_registers)
14313         (ravenscar_thread_target::prepare_to_store): Update.
14314         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14315         Remove.
14316         (struct ppc_ravenscar_powerpc_ops): Derive from
14317         ravenscar_arch_ops.
14318         (ppc_ravenscar_powerpc_ops::fetch_registers)
14319         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14320         (ppc_ravenscar_powerpc_ops): Redefine.
14321         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14322         (ppc_ravenscar_e500_ops::fetch_registers)
14323         (ppc_ravenscar_e500_ops::store_registers): Now methods.
14324         (ppc_ravenscar_e500_ops): Redefine.
14325         * aarch64-ravenscar-thread.c
14326         (aarch64_ravenscar_generic_prepare_to_store): Remove.
14327         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14328         (aarch64_ravenscar_fetch_registers)
14329         (aarch64_ravenscar_store_registers): Now methods.
14330         (aarch64_ravenscar_ops): Redefine.
14331
14332 2019-02-15  Tom Tromey  <tromey@adacore.com>
14333
14334         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14335         (ravenscar_thread_target::stopped_by_hw_breakpoint)
14336         (ravenscar_thread_target::stopped_by_watchpoint)
14337         (ravenscar_thread_target::stopped_data_address)
14338         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14339
14340 2019-02-15  Tom Tromey  <tromey@adacore.com>
14341
14342         * ravenscar-thread.c: Fix some typos.
14343
14344 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14345             Tom Tromey  <tromey@adacore.com>
14346
14347         * ada-lang.c (ada_exception_sal): Change addr_string to a
14348         std::string.
14349         (create_ada_exception_catchpoint): Update.
14350
14351 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14352             Tom Tromey  <tromey@adacore.com>
14353
14354         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14355         (bp_location_ops): Remove.
14356         (base_breakpoint_allocate_location): Update.
14357         (free_bp_location): Update.
14358         * ada-lang.c (class ada_catchpoint_location)
14359         <ada_catchpoint_location>: Remove ops parameter.
14360         (ada_catchpoint_location_dtor): Remove.
14361         (ada_catchpoint_location_ops): Remove.
14362         (allocate_location_exception): Update.
14363         * breakpoint.h (struct bp_location_ops): Remove.
14364         (class bp_location) <bp_location>: Remove bp_location_ops
14365         parameter.
14366         <~bp_location>: Add destructor.
14367         <ops>: Remove.
14368
14369 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14370             Pedro Alves  <palves@redhat.com>
14371
14372         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14373         'PATH_MAX'.
14374
14375 2019-02-14  David Michael  <fedora.dm0@gmail.com>
14376             Samuel Thibault  <samuel.thibault@gnu.org>
14377             Thomas Schwinge  <thomas@codesourcery.com>
14378
14379         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14380         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14381
14382 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14383
14384         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14385         (check_empty): Use "const char *".
14386
14387         * gnu-nat.c (gnu_nat_target::detach): Instead of
14388         'detach_inferior (pid)' call
14389         'detach_inferior (find_inferior_pid (pid))'.
14390
14391         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14392         'nat/fork-inferior.o'.
14393         * gnu-nat.c: #include "nat/fork-inferior.h".
14394
14395         * gnu-nat.c (gnu_nat_target::detach): Instead of
14396         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14397         * gnu-nat.h: #include "inf-child.h".
14398         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14399         'i386_gnu_nat_target::fetch_registers'.
14400         (gnu_store_registers): Rename/move to
14401         'i386_gnu_nat_target::store_registers'.
14402
14403         * config/i386/nm-i386gnu.h: Don't "#include" any files.
14404         * gnu-nat.h (mach_thread_info): New function.
14405         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14406
14407         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14408
14409 2019-02-14  Frederic Konrad  <konrad@adacore.com>
14410
14411         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14412
14413 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
14414
14415         * windows-nat.c (windows_add_thread): Add new parameter
14416         "main_thread_p" with default value set to false.  Update
14417         function documentation as well as all callers.
14418         (windows_delete_thread): Likewise.
14419         (fake_create_process): Update call to windows_add_thread.
14420         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14421         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14422         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14423         call to windows_delete_thread.
14424
14425 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
14426
14427         * MAINTAINERS: Add Andrew Burgess as global maintainer.
14428
14429 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14430
14431         * symfile.c (find_separate_debug_file): Use canonical path of
14432         sysroot with child_path instead of gdb_sysroot if it is valid.
14433
14434 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14435
14436         * symfile.c (find_separate_debug_file): Use child_path to
14437         determine if an object file is under a sysroot.
14438
14439 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14440
14441         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14442         unittests/child-path-selftests.c.
14443         * common/pathstuff.c (child_path): New function.
14444         * common/pathstuff.h (child_path): New prototype.
14445         * unittests/child-path-selftests.c: New file.
14446
14447 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14448
14449         * symfile.c (find_separate_debug_file): Look for separate debug
14450         files in debug directories under the sysroot.
14451
14452 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14453
14454         * symtab.h (struct minimal_symbol data_p): New const method.
14455         (struct minimal_symbol text_p): Likewise.
14456         * symtab.c (output_source_filename): Use file name style
14457         to print file name.
14458         (print_symbol_info): Likewise.
14459         (print_msymbol_info): Use address style to print addresses.
14460         Use function name style to print executable text symbols.
14461         (expand_symtab_containing_pc): Use data_p.
14462         (find_pc_sect_compunit_symtab): Likewise.
14463
14464 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14465
14466         * breakpoint.c (describe_other_breakpoints): Use address style
14467         to print addresses.
14468         (say_where): Likewise.
14469
14470 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14471
14472         * ada-typeprint.c (print_func_type): Print function name
14473         style to print function name.
14474         * c-typeprint.c (c_print_type_1): Likewise.
14475
14476 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
14477
14478         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14479         for execve.
14480
14481 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14482
14483         * c-exp.y (direct_abs_decl): Use emplace_back to record the
14484         type_stack.
14485
14486 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
14487
14488         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14489         TYPE_CODE_REF types.
14490
14491 2019-02-08  Jim Wilson  <jimw@sifive.com>
14492
14493         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14494         (riscv_linux_fregset): New.
14495         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14496
14497 2019-02-07  Tom Tromey  <tom@tromey.com>
14498
14499         * thread.c (thread_cancel_execution_command): Update.
14500         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14501         methods.
14502         (struct thread_fsm_ops): Remove.
14503         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14504         (thread_fsm_should_stop, thread_fsm_return_value)
14505         (thread_fsm_set_finished, thread_fsm_finished_p)
14506         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14507         Don't declare.
14508         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14509         * infrun.c (clear_proceed_status_thread)
14510         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14511         (print_stop_event): Update.
14512         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14513         Add constructor.
14514         (step_command_fsm_ops): Remove.
14515         (new_step_command_fsm): Remove.
14516         (step_1): Update.
14517         (step_command_fsm::should_stop): Rename from
14518         step_command_fsm_should_stop.
14519         (step_command_fsm::clean_up): Rename from
14520         step_command_fsm_clean_up.
14521         (step_command_fsm::do_async_reply_reason): Rename from
14522         step_command_fsm_async_reply_reason.
14523         (struct until_next_fsm): Inherit from thread_fsm.  Add
14524         constructor.
14525         (until_next_fsm_ops): Remove.
14526         (new_until_next_fsm): Remove.
14527         (until_next_fsm::should_stop): Rename from
14528         until_next_fsm_should_stop.
14529         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14530         (until_next_fsm::do_async_reply_reason): Rename from
14531         until_next_fsm_async_reply_reason.
14532         (struct finish_command_fsm): Inherit from thread_fsm.  Add
14533         constructor.  Change type of breakpoint.
14534         (finish_command_fsm_ops): Remove.
14535         (new_finish_command_fsm): Remove.
14536         (finish_command_fsm::should_stop): Rename from
14537         finish_command_fsm_should_stop.
14538         (finish_command_fsm::clean_up): Rename from
14539         finish_command_fsm_clean_up.
14540         (finish_command_fsm::return_value): Rename from
14541         finish_command_fsm_return_value.
14542         (finish_command_fsm::do_async_reply_reason): Rename from
14543         finish_command_fsm_async_reply_reason.
14544         (finish_command): Update.
14545         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14546         Add constructor.
14547         (call_thread_fsm_ops): Remove.
14548         (call_thread_fsm::call_thread_fsm): Rename from
14549         new_call_thread_fsm.
14550         (call_thread_fsm::should_stop): Rename from
14551         call_thread_fsm_should_stop.
14552         (call_thread_fsm::should_notify_stop): Rename from
14553         call_thread_fsm_should_notify_stop.
14554         (run_inferior_call, call_function_by_hand_dummy): Update.
14555         * cli/cli-interp.c (should_print_stop_to_console): Update.
14556         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14557         Add constructor.  Change type of location_breakpoint,
14558         caller_breakpoint.
14559         (until_break_fsm_ops): Remove.
14560         (new_until_break_fsm): Remove.
14561         (until_break_fsm::should_stop): Rename from
14562         until_break_fsm_should_stop.
14563         (until_break_fsm::clean_up): Rename from
14564         until_break_fsm_clean_up.
14565         (until_break_fsm::do_async_reply_reason): Rename from
14566         until_break_fsm_async_reply_reason.
14567         (until_break_command): Update.
14568         * thread-fsm.c: Remove.
14569         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14570
14571 2019-02-07  Tom Tromey  <tom@tromey.com>
14572
14573         * yy-remap.h: Add include guard.
14574         * xtensa-tdep.h: Add include guard.
14575         * xcoffread.h: Rename include guard.
14576         * varobj-iter.h: Add include guard.
14577         * tui/tui.h: Rename include guard.
14578         * tui/tui-winsource.h: Rename include guard.
14579         * tui/tui-wingeneral.h: Rename include guard.
14580         * tui/tui-windata.h: Rename include guard.
14581         * tui/tui-win.h: Rename include guard.
14582         * tui/tui-stack.h: Rename include guard.
14583         * tui/tui-source.h: Rename include guard.
14584         * tui/tui-regs.h: Rename include guard.
14585         * tui/tui-out.h: Rename include guard.
14586         * tui/tui-layout.h: Rename include guard.
14587         * tui/tui-io.h: Rename include guard.
14588         * tui/tui-hooks.h: Rename include guard.
14589         * tui/tui-file.h: Rename include guard.
14590         * tui/tui-disasm.h: Rename include guard.
14591         * tui/tui-data.h: Rename include guard.
14592         * tui/tui-command.h: Rename include guard.
14593         * tic6x-tdep.h: Add include guard.
14594         * target/waitstatus.h: Rename include guard.
14595         * target/wait.h: Rename include guard.
14596         * target/target.h: Rename include guard.
14597         * target/resume.h: Rename include guard.
14598         * target-float.h: Rename include guard.
14599         * stabsread.h: Add include guard.
14600         * rs6000-tdep.h: Add include guard.
14601         * riscv-fbsd-tdep.h: Add include guard.
14602         * regformats/regdef.h: Rename include guard.
14603         * record.h: Rename include guard.
14604         * python/python.h: Rename include guard.
14605         * python/python-internal.h: Rename include guard.
14606         * python/py-stopevent.h: Rename include guard.
14607         * python/py-ref.h: Rename include guard.
14608         * python/py-record.h: Rename include guard.
14609         * python/py-record-full.h: Rename include guard.
14610         * python/py-record-btrace.h: Rename include guard.
14611         * python/py-instruction.h: Rename include guard.
14612         * python/py-events.h: Rename include guard.
14613         * python/py-event.h: Rename include guard.
14614         * procfs.h: Add include guard.
14615         * proc-utils.h: Add include guard.
14616         * p-lang.h: Add include guard.
14617         * or1k-tdep.h: Rename include guard.
14618         * observable.h: Rename include guard.
14619         * nto-tdep.h: Rename include guard.
14620         * nat/x86-linux.h: Rename include guard.
14621         * nat/x86-linux-dregs.h: Rename include guard.
14622         * nat/x86-gcc-cpuid.h: Add include guard.
14623         * nat/x86-dregs.h: Rename include guard.
14624         * nat/x86-cpuid.h: Rename include guard.
14625         * nat/ppc-linux.h: Rename include guard.
14626         * nat/mips-linux-watch.h: Rename include guard.
14627         * nat/linux-waitpid.h: Rename include guard.
14628         * nat/linux-ptrace.h: Rename include guard.
14629         * nat/linux-procfs.h: Rename include guard.
14630         * nat/linux-osdata.h: Rename include guard.
14631         * nat/linux-nat.h: Rename include guard.
14632         * nat/linux-namespaces.h: Rename include guard.
14633         * nat/linux-btrace.h: Rename include guard.
14634         * nat/glibc_thread_db.h: Rename include guard.
14635         * nat/gdb_thread_db.h: Rename include guard.
14636         * nat/gdb_ptrace.h: Rename include guard.
14637         * nat/fork-inferior.h: Rename include guard.
14638         * nat/amd64-linux-siginfo.h: Rename include guard.
14639         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14640         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14641         * nat/aarch64-linux.h: Rename include guard.
14642         * nat/aarch64-linux-hw-point.h: Rename include guard.
14643         * mn10300-tdep.h: Add include guard.
14644         * mips-linux-tdep.h: Add include guard.
14645         * mi/mi-parse.h: Rename include guard.
14646         * mi/mi-out.h: Rename include guard.
14647         * mi/mi-main.h: Rename include guard.
14648         * mi/mi-interp.h: Rename include guard.
14649         * mi/mi-getopt.h: Rename include guard.
14650         * mi/mi-console.h: Rename include guard.
14651         * mi/mi-common.h: Rename include guard.
14652         * mi/mi-cmds.h: Rename include guard.
14653         * mi/mi-cmd-break.h: Rename include guard.
14654         * m2-lang.h: Add include guard.
14655         * location.h: Rename include guard.
14656         * linux-record.h: Rename include guard.
14657         * linux-nat.h: Add include guard.
14658         * linux-fork.h: Add include guard.
14659         * i386-darwin-tdep.h: Rename include guard.
14660         * hppa-linux-offsets.h: Add include guard.
14661         * guile/guile.h: Rename include guard.
14662         * guile/guile-internal.h: Rename include guard.
14663         * gnu-nat.h: Rename include guard.
14664         * gdb-stabs.h: Rename include guard.
14665         * frv-tdep.h: Add include guard.
14666         * f-lang.h: Add include guard.
14667         * event-loop.h: Add include guard.
14668         * darwin-nat.h: Rename include guard.
14669         * cp-abi.h: Rename include guard.
14670         * config/sparc/nm-sol2.h: Rename include guard.
14671         * config/nm-nto.h: Rename include guard.
14672         * config/nm-linux.h: Add include guard.
14673         * config/i386/nm-i386gnu.h: Rename include guard.
14674         * config/djgpp/nl_types.h: Rename include guard.
14675         * config/djgpp/langinfo.h: Rename include guard.
14676         * compile/gcc-cp-plugin.h: Add include guard.
14677         * compile/gcc-c-plugin.h: Add include guard.
14678         * compile/compile.h: Rename include guard.
14679         * compile/compile-object-run.h: Rename include guard.
14680         * compile/compile-object-load.h: Rename include guard.
14681         * compile/compile-internal.h: Rename include guard.
14682         * compile/compile-cplus.h: Rename include guard.
14683         * compile/compile-c.h: Rename include guard.
14684         * common/xml-utils.h: Rename include guard.
14685         * common/x86-xstate.h: Rename include guard.
14686         * common/version.h: Rename include guard.
14687         * common/vec.h: Rename include guard.
14688         * common/tdesc.h: Rename include guard.
14689         * common/selftest.h: Rename include guard.
14690         * common/scoped_restore.h: Rename include guard.
14691         * common/scoped_mmap.h: Rename include guard.
14692         * common/scoped_fd.h: Rename include guard.
14693         * common/safe-iterator.h: Rename include guard.
14694         * common/run-time-clock.h: Rename include guard.
14695         * common/refcounted-object.h: Rename include guard.
14696         * common/queue.h: Rename include guard.
14697         * common/ptid.h: Rename include guard.
14698         * common/print-utils.h: Rename include guard.
14699         * common/preprocessor.h: Rename include guard.
14700         * common/pathstuff.h: Rename include guard.
14701         * common/observable.h: Rename include guard.
14702         * common/netstuff.h: Rename include guard.
14703         * common/job-control.h: Rename include guard.
14704         * common/host-defs.h: Rename include guard.
14705         * common/gdb_wait.h: Rename include guard.
14706         * common/gdb_vecs.h: Rename include guard.
14707         * common/gdb_unlinker.h: Rename include guard.
14708         * common/gdb_unique_ptr.h: Rename include guard.
14709         * common/gdb_tilde_expand.h: Rename include guard.
14710         * common/gdb_sys_time.h: Rename include guard.
14711         * common/gdb_string_view.h: Rename include guard.
14712         * common/gdb_splay_tree.h: Rename include guard.
14713         * common/gdb_setjmp.h: Rename include guard.
14714         * common/gdb_ref_ptr.h: Rename include guard.
14715         * common/gdb_optional.h: Rename include guard.
14716         * common/gdb_locale.h: Rename include guard.
14717         * common/gdb_assert.h: Rename include guard.
14718         * common/filtered-iterator.h: Rename include guard.
14719         * common/filestuff.h: Rename include guard.
14720         * common/fileio.h: Rename include guard.
14721         * common/environ.h: Rename include guard.
14722         * common/common-utils.h: Rename include guard.
14723         * common/common-types.h: Rename include guard.
14724         * common/common-regcache.h: Rename include guard.
14725         * common/common-inferior.h: Rename include guard.
14726         * common/common-gdbthread.h: Rename include guard.
14727         * common/common-exceptions.h: Rename include guard.
14728         * common/common-defs.h: Rename include guard.
14729         * common/common-debug.h: Rename include guard.
14730         * common/cleanups.h: Rename include guard.
14731         * common/buffer.h: Rename include guard.
14732         * common/btrace-common.h: Rename include guard.
14733         * common/break-common.h: Rename include guard.
14734         * cli/cli-utils.h: Rename include guard.
14735         * cli/cli-style.h: Rename include guard.
14736         * cli/cli-setshow.h: Rename include guard.
14737         * cli/cli-script.h: Rename include guard.
14738         * cli/cli-interp.h: Rename include guard.
14739         * cli/cli-decode.h: Rename include guard.
14740         * cli/cli-cmds.h: Rename include guard.
14741         * charset-list.h: Add include guard.
14742         * buildsym-legacy.h: Rename include guard.
14743         * bfin-tdep.h: Add include guard.
14744         * ax.h: Rename include guard.
14745         * arm-linux-tdep.h: Add include guard.
14746         * arm-fbsd-tdep.h: Add include guard.
14747         * arch/xtensa.h: Rename include guard.
14748         * arch/tic6x.h: Add include guard.
14749         * arch/i386.h: Add include guard.
14750         * arch/arm.h: Rename include guard.
14751         * arch/arm-linux.h: Rename include guard.
14752         * arch/arm-get-next-pcs.h: Rename include guard.
14753         * arch/amd64.h: Add include guard.
14754         * arch/aarch64-insn.h: Rename include guard.
14755         * arch-utils.h: Rename include guard.
14756         * annotate.h: Add include guard.
14757         * amd64-darwin-tdep.h: Rename include guard.
14758         * aarch64-linux-tdep.h: Add include guard.
14759         * aarch64-fbsd-tdep.h: Add include guard.
14760         * aarch32-linux-nat.h: Add include guard.
14761
14762 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14763
14764         * macrotab.c (macro_define_internal): New function that
14765         factorizes macro_define_object_internal and macro_define_function
14766         code.
14767         (macro_define_object_internal): Use macro_define_internal.
14768         (macro_define_function): Likewise.
14769
14770 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14771
14772         * macrocmd.c (extract_identifier): Return
14773         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14774         callers.
14775
14776 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
14777
14778         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14779
14780 2019-02-05  Tom Tromey  <tom@tromey.com>
14781
14782         * target.c (target_stack::unpush): Move assertion earlier.
14783
14784 2019-01-30  Tom Tromey  <tom@tromey.com>
14785
14786         PR python/23615:
14787         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14788         (gdbpy_parse_and_eval): Likewise.
14789         * python/python-internal.h (gdbpy_allow_threads): New class.
14790
14791 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
14792
14793         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14794         (aarch64_fbsd_fpregmap): Move earlier.
14795         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14796         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14797         instead of individual calls to trad_frame_set_reg_addr.
14798         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14799         earlier.
14800         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14801         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14802         instead of individual calls to trad_frame_set_reg_addr.
14803
14804 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
14805
14806         * CONTRIBUTE: Replace contribution list with wiki link.
14807
14808 2019-01-25  Tom Tromey  <tom@tromey.com>
14809
14810         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14811
14812 2019-01-25  Tom Tromey  <tom@tromey.com>
14813
14814         * xtensa-linux-nat.c: Fix common/ includes.
14815         * xml-support.h: Fix common/ includes.
14816         * xml-support.c: Fix common/ includes.
14817         * x86-linux-nat.c: Fix common/ includes.
14818         * windows-nat.c: Fix common/ includes.
14819         * varobj.h: Fix common/ includes.
14820         * varobj.c: Fix common/ includes.
14821         * value.c: Fix common/ includes.
14822         * valops.c: Fix common/ includes.
14823         * utils.c: Fix common/ includes.
14824         * unittests/xml-utils-selftests.c: Fix common/ includes.
14825         * unittests/utils-selftests.c: Fix common/ includes.
14826         * unittests/unpack-selftests.c: Fix common/ includes.
14827         * unittests/tracepoint-selftests.c: Fix common/ includes.
14828         * unittests/style-selftests.c: Fix common/ includes.
14829         * unittests/string_view-selftests.c: Fix common/ includes.
14830         * unittests/scoped_restore-selftests.c: Fix common/ includes.
14831         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14832         * unittests/scoped_fd-selftests.c: Fix common/ includes.
14833         * unittests/rsp-low-selftests.c: Fix common/ includes.
14834         * unittests/parse-connection-spec-selftests.c: Fix common/
14835         includes.
14836         * unittests/optional-selftests.c: Fix common/ includes.
14837         * unittests/offset-type-selftests.c: Fix common/ includes.
14838         * unittests/observable-selftests.c: Fix common/ includes.
14839         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14840         * unittests/memrange-selftests.c: Fix common/ includes.
14841         * unittests/memory-map-selftests.c: Fix common/ includes.
14842         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14843         * unittests/function-view-selftests.c: Fix common/ includes.
14844         * unittests/environ-selftests.c: Fix common/ includes.
14845         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14846         * unittests/common-utils-selftests.c: Fix common/ includes.
14847         * unittests/cli-utils-selftests.c: Fix common/ includes.
14848         * unittests/array-view-selftests.c: Fix common/ includes.
14849         * ui-file.c: Fix common/ includes.
14850         * tui/tui-io.c: Fix common/ includes.
14851         * tracepoint.h: Fix common/ includes.
14852         * tracepoint.c: Fix common/ includes.
14853         * tracefile-tfile.c: Fix common/ includes.
14854         * top.h: Fix common/ includes.
14855         * top.c: Fix common/ includes.
14856         * thread.c: Fix common/ includes.
14857         * target/waitstatus.h: Fix common/ includes.
14858         * target/waitstatus.c: Fix common/ includes.
14859         * target.h: Fix common/ includes.
14860         * target.c: Fix common/ includes.
14861         * target-memory.c: Fix common/ includes.
14862         * target-descriptions.c: Fix common/ includes.
14863         * symtab.h: Fix common/ includes.
14864         * symfile.c: Fix common/ includes.
14865         * stap-probe.c: Fix common/ includes.
14866         * spu-linux-nat.c: Fix common/ includes.
14867         * sparc-nat.c: Fix common/ includes.
14868         * source.c: Fix common/ includes.
14869         * solib.c: Fix common/ includes.
14870         * solib-target.c: Fix common/ includes.
14871         * ser-unix.c: Fix common/ includes.
14872         * ser-tcp.c: Fix common/ includes.
14873         * ser-pipe.c: Fix common/ includes.
14874         * ser-base.c: Fix common/ includes.
14875         * selftest-arch.c: Fix common/ includes.
14876         * s12z-tdep.c: Fix common/ includes.
14877         * rust-exp.y: Fix common/ includes.
14878         * rs6000-aix-tdep.c: Fix common/ includes.
14879         * riscv-tdep.c: Fix common/ includes.
14880         * remote.c: Fix common/ includes.
14881         * remote-notif.h: Fix common/ includes.
14882         * remote-fileio.h: Fix common/ includes.
14883         * remote-fileio.c: Fix common/ includes.
14884         * regcache.h: Fix common/ includes.
14885         * regcache.c: Fix common/ includes.
14886         * record-btrace.c: Fix common/ includes.
14887         * python/python.c: Fix common/ includes.
14888         * python/py-type.c: Fix common/ includes.
14889         * python/py-inferior.c: Fix common/ includes.
14890         * progspace.h: Fix common/ includes.
14891         * producer.c: Fix common/ includes.
14892         * procfs.c: Fix common/ includes.
14893         * proc-api.c: Fix common/ includes.
14894         * printcmd.c: Fix common/ includes.
14895         * ppc-linux-nat.c: Fix common/ includes.
14896         * parser-defs.h: Fix common/ includes.
14897         * osdata.c: Fix common/ includes.
14898         * obsd-nat.c: Fix common/ includes.
14899         * nat/x86-linux.c: Fix common/ includes.
14900         * nat/x86-linux-dregs.c: Fix common/ includes.
14901         * nat/x86-dregs.h: Fix common/ includes.
14902         * nat/x86-dregs.c: Fix common/ includes.
14903         * nat/ppc-linux.c: Fix common/ includes.
14904         * nat/mips-linux-watch.h: Fix common/ includes.
14905         * nat/mips-linux-watch.c: Fix common/ includes.
14906         * nat/linux-waitpid.c: Fix common/ includes.
14907         * nat/linux-ptrace.h: Fix common/ includes.
14908         * nat/linux-ptrace.c: Fix common/ includes.
14909         * nat/linux-procfs.c: Fix common/ includes.
14910         * nat/linux-personality.c: Fix common/ includes.
14911         * nat/linux-osdata.c: Fix common/ includes.
14912         * nat/linux-namespaces.c: Fix common/ includes.
14913         * nat/linux-btrace.h: Fix common/ includes.
14914         * nat/linux-btrace.c: Fix common/ includes.
14915         * nat/fork-inferior.c: Fix common/ includes.
14916         * nat/amd64-linux-siginfo.c: Fix common/ includes.
14917         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14918         * nat/aarch64-linux.c: Fix common/ includes.
14919         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14920         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14921         * namespace.h: Fix common/ includes.
14922         * mips-linux-tdep.c: Fix common/ includes.
14923         * minsyms.c: Fix common/ includes.
14924         * mi/mi-parse.h: Fix common/ includes.
14925         * mi/mi-main.c: Fix common/ includes.
14926         * mi/mi-cmd-env.c: Fix common/ includes.
14927         * memrange.h: Fix common/ includes.
14928         * memattr.c: Fix common/ includes.
14929         * maint.h: Fix common/ includes.
14930         * maint.c: Fix common/ includes.
14931         * main.c: Fix common/ includes.
14932         * machoread.c: Fix common/ includes.
14933         * location.c: Fix common/ includes.
14934         * linux-thread-db.c: Fix common/ includes.
14935         * linux-nat.c: Fix common/ includes.
14936         * linux-fork.c: Fix common/ includes.
14937         * inline-frame.c: Fix common/ includes.
14938         * infrun.c: Fix common/ includes.
14939         * inflow.c: Fix common/ includes.
14940         * inferior.h: Fix common/ includes.
14941         * inferior.c: Fix common/ includes.
14942         * infcmd.c: Fix common/ includes.
14943         * inf-ptrace.c: Fix common/ includes.
14944         * inf-child.c: Fix common/ includes.
14945         * ia64-linux-nat.c: Fix common/ includes.
14946         * i387-tdep.c: Fix common/ includes.
14947         * i386-tdep.c: Fix common/ includes.
14948         * i386-linux-tdep.c: Fix common/ includes.
14949         * i386-linux-nat.c: Fix common/ includes.
14950         * i386-go32-tdep.c: Fix common/ includes.
14951         * i386-fbsd-tdep.c: Fix common/ includes.
14952         * i386-fbsd-nat.c: Fix common/ includes.
14953         * guile/scm-type.c: Fix common/ includes.
14954         * guile/guile.c: Fix common/ includes.
14955         * go32-nat.c: Fix common/ includes.
14956         * gnu-nat.c: Fix common/ includes.
14957         * gdbthread.h: Fix common/ includes.
14958         * gdbarch-selftests.c: Fix common/ includes.
14959         * gdb_usleep.c: Fix common/ includes.
14960         * gdb_select.h: Fix common/ includes.
14961         * gdb_bfd.c: Fix common/ includes.
14962         * gcore.c: Fix common/ includes.
14963         * fork-child.c: Fix common/ includes.
14964         * findvar.c: Fix common/ includes.
14965         * fbsd-nat.c: Fix common/ includes.
14966         * event-top.c: Fix common/ includes.
14967         * event-loop.c: Fix common/ includes.
14968         * dwarf2read.c: Fix common/ includes.
14969         * dwarf2loc.c: Fix common/ includes.
14970         * dwarf2-frame.c: Fix common/ includes.
14971         * dwarf-index-cache.c: Fix common/ includes.
14972         * dtrace-probe.c: Fix common/ includes.
14973         * disasm-selftests.c: Fix common/ includes.
14974         * defs.h: Fix common/ includes.
14975         * csky-tdep.c: Fix common/ includes.
14976         * cp-valprint.c: Fix common/ includes.
14977         * cp-support.h: Fix common/ includes.
14978         * cp-support.c: Fix common/ includes.
14979         * corelow.c: Fix common/ includes.
14980         * completer.h: Fix common/ includes.
14981         * completer.c: Fix common/ includes.
14982         * compile/compile.c: Fix common/ includes.
14983         * compile/compile-loc2c.c: Fix common/ includes.
14984         * compile/compile-cplus-types.c: Fix common/ includes.
14985         * compile/compile-cplus-symbols.c: Fix common/ includes.
14986         * command.h: Fix common/ includes.
14987         * cli/cli-dump.c: Fix common/ includes.
14988         * cli/cli-cmds.c: Fix common/ includes.
14989         * charset.c: Fix common/ includes.
14990         * build-id.c: Fix common/ includes.
14991         * btrace.h: Fix common/ includes.
14992         * btrace.c: Fix common/ includes.
14993         * breakpoint.h: Fix common/ includes.
14994         * breakpoint.c: Fix common/ includes.
14995         * ax.h:
14996         (enum agent_op): Fix common/ includes.
14997         * ax-general.c (struct aop_map): Fix common/ includes.
14998         * ax-gdb.c: Fix common/ includes.
14999         * auxv.c: Fix common/ includes.
15000         * auto-load.c: Fix common/ includes.
15001         * arm-tdep.c: Fix common/ includes.
15002         * arch/riscv.c: Fix common/ includes.
15003         * arch/ppc-linux-common.c: Fix common/ includes.
15004         * arch/i386.c: Fix common/ includes.
15005         * arch/arm.c: Fix common/ includes.
15006         * arch/arm-linux.c: Fix common/ includes.
15007         * arch/arm-get-next-pcs.c: Fix common/ includes.
15008         * arch/amd64.c: Fix common/ includes.
15009         * arch/aarch64.c: Fix common/ includes.
15010         * arch/aarch64-insn.c: Fix common/ includes.
15011         * arch-utils.c: Fix common/ includes.
15012         * amd64-windows-tdep.c: Fix common/ includes.
15013         * amd64-tdep.c: Fix common/ includes.
15014         * amd64-sol2-tdep.c: Fix common/ includes.
15015         * amd64-obsd-tdep.c: Fix common/ includes.
15016         * amd64-nbsd-tdep.c: Fix common/ includes.
15017         * amd64-linux-tdep.c: Fix common/ includes.
15018         * amd64-linux-nat.c: Fix common/ includes.
15019         * amd64-fbsd-tdep.c: Fix common/ includes.
15020         * amd64-fbsd-nat.c: Fix common/ includes.
15021         * amd64-dicos-tdep.c: Fix common/ includes.
15022         * amd64-darwin-tdep.c: Fix common/ includes.
15023         * agent.c: Fix common/ includes.
15024         * ada-lang.h: Fix common/ includes.
15025         * ada-lang.c: Fix common/ includes.
15026         * aarch64-tdep.c: Fix common/ includes.
15027
15028 2019-01-25  Tom Tromey  <tom@tromey.com>
15029
15030         * common/create-version.sh: Use common/version.h.
15031
15032 2019-01-24  Pedro Alves  <palves@redhat.com>
15033
15034         * infrun.c (signal_stop, signal_print, signal_program)
15035         (signal_catch, signal_pass): Now arrays instead of pointers.
15036         (update_signals_program_target, do_target_resume)
15037         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15038         * linux-nat.c (linux_nat_target::pass_signals)
15039         (linux_nat_target::create_inferior, linux_nat_target::attach):
15040         Adjust.
15041         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15042         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15043         * procfs.c (procfs_target::pass_signals): Adjust.
15044         * record-full.c (record_full_target::resume): Adjust.
15045         * remote.c (remote_target::pass_signals)
15046         (remote_target::program_signals): Adjust.
15047         * target-debug.h (target_debug_print_signals): Now takes a
15048         gdb::array_view as parameter.  Adjust.
15049         * target.h (target_ops) <pass_signals, program_signals>: Replace
15050         pointer and length parameters with gdb::array_view.
15051         (target_pass_signals, target_program_signals): Likewise.
15052         * target-delegates.c: Regenerate.
15053
15054 2019-01-24  Pedro Alves  <palves@redhat.com>
15055
15056         * common/forward-scope-exit.h
15057         (forward_scope_exit::forward_scope_exit): Pass arguments to
15058         m_bind_function directly, instead of creating a std::bind and
15059         copying that.
15060
15061 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15062
15063         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15064         for static members.
15065         (pass_in_v_vfp_candidate): Likewise.
15066
15067 2019-01-23  Tom Tromey  <tom@tromey.com>
15068             Pedro Alves  <palves@redhat.com>
15069
15070         * regcache.c (class regcache_invalidator): Remove.
15071         (regcache::raw_write): Use make_scope_exit.
15072
15073 2019-01-23  Tom Tromey  <tom@tromey.com>
15074
15075         * ui-out.h (class ui_out_emit_type): Update comment.
15076
15077 2019-01-23  Tom Tromey  <tom@tromey.com>
15078
15079         * infrun.c (fetch_inferior_event): Update comment.
15080
15081 2019-01-23  Tom Tromey  <tom@tromey.com>
15082             Pedro Alves  <palves@redhat.com>
15083
15084         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15085         parameter.
15086         (fetch_inferior_event): Use SCOPE_EXIT.
15087
15088
15089 2019-01-23  Tom Tromey  <tom@tromey.com>
15090             Pedro Alves  <palves@redhat.com>
15091
15092         * infrun.c (disable_thread_events): Delete.
15093         (stop_all_threads): Use SCOPE_EXIT.
15094
15095 2019-01-23  Tom Tromey  <tom@tromey.com>
15096             Pedro Alves  <palves@redhat.com>
15097
15098         * symfile.c: Include forward-scope-exit.h.
15099         (clear_symtab_users_cleanup): Replace forward declaration with
15100         a FORWARD_SCOPE_EXIT.
15101         (syms_from_objfile_1): Use the forward_scope_exit and
15102         gdb::optional instead of cleanup_function.
15103         (reread_symbols): Use the forward_scope_exit instead of
15104         cleanup_function.
15105         (clear_symtab_users_cleanup): Remove function.
15106
15107 2019-01-23  Tom Tromey  <tom@tromey.com>
15108             Pedro Alves  <palves@redhat.com>
15109
15110         * linux-nat.c: Include scope-exit.h.
15111         (cleanup_target_stop): Remove.
15112         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15113         SCOPE_EXIT.
15114
15115 2019-01-23  Tom Tromey  <tom@tromey.com>
15116             Pedro Alves  <palves@redhat.com>
15117
15118         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15119         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15120
15121 2019-01-23  Tom Tromey  <tom@tromey.com>
15122             Andrew Burgess  <andrew.burgess@embecosm.com>
15123             Pedro Alves  <palves@redhat.com>
15124
15125         * infrun.c (fetch_inferior_event): Use scope_exit.
15126         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15127         * top.c (execute_command): Use scope_exit.
15128         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15129         * utils.c (do_bpstat_clear_actions_cleanup)
15130         (make_bpstat_clear_actions_cleanup): Remove.
15131
15132 2019-01-23  Tom Tromey  <tom@tromey.com>
15133             Pedro Alves  <palves@redhat.com>
15134
15135         * infrun.c: Include "common/scope-exit.h"
15136         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15137         (wait_for_inferior): Use SCOPE_EXIT.
15138         (fetch_inferior_event): Use scope_exit.
15139
15140 2019-01-23  Tom Tromey  <tom@tromey.com>
15141             Pedro Alves  <palves@redhat.com>
15142
15143         * breakpoint.c (create_breakpoint): Remove cleanup.
15144
15145 2019-01-23  Tom Tromey  <tom@tromey.com>
15146             Andrew Burgess  <andrew.burgess@embecosm.com>
15147             Pedro Alves  <palves@redhat.com>
15148
15149 2019-01-23  Pedro Alves  <palves@redhat.com>
15150
15151         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15152
15153 2019-01-23  Pedro Alves  <palves@redhat.com>
15154             Andrew Burgess  <andrew.burgess@embecosm.com>
15155
15156         * gdbthread.h: Include "common/forward-scope-exit.h".
15157         (scoped_finish_thread_state): Redefine custom class in terms of
15158         forward_scope_exit.
15159
15160 2019-01-23  Pedro Alves  <palves@redhat.com>
15161             Andrew Burgess  <andrew.burgess@embecosm.com>
15162
15163         * common/forward-scope-exit.h: New file.
15164
15165 2019-01-23  Pedro Alves  <palves@redhat.com>
15166             Andrew Burgess  <andrew.burgess@embecosm.com>
15167             Tom Tromey  <tom@tromey.com>
15168
15169         * common/scope-exit.h: New file.
15170
15171 2019-01-23  Pedro Alves  <palves@redhat.com>
15172
15173         * common/preprocessor.h (ESC): Rename to ...
15174         (ESC_PARENS): ... this.
15175         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15176         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15177
15178 2019-01-23  Tom Tromey  <tom@tromey.com>
15179
15180         * language.h (class scoped_switch_to_sym_language_if_auto):
15181         Initialize m_lang in both cases.
15182
15183 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
15184
15185         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15186         with XCNEW.
15187
15188 2019-01-22  Tom Tromey  <tom@tromey.com>
15189
15190         * corelow.c: Do not include sys/file.h.
15191
15192 2019-01-22  Tom Tromey  <tom@tromey.com>
15193
15194         * tui/tui-wingeneral.h: Include gdb_curses.h.
15195
15196 2019-01-22  Tom Tromey  <tom@tromey.com>
15197
15198         * source-cache.h (class source_cache) <get_source_lines,
15199         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15200
15201 2019-01-22  Tom Tromey  <tom@tromey.com>
15202
15203         * remote-fileio.h (struct remote_target): Declare.
15204
15205 2019-01-22  Tom Tromey  <tom@tromey.com>
15206
15207         * python/py-arch.c: Do not include py-ref.h.
15208         * python/py-bpevent.c: Do not include py-ref.h.
15209         * python/py-cmd.c: Do not include py-ref.h.
15210         * python/py-continueevent.c: Do not include py-ref.h.
15211         * python/py-event.h: Do not include py-ref.h.
15212         * python/py-evtregistry.c: Do not include py-ref.h.
15213         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15214         * python/py-frame.c: Do not include py-ref.h.
15215         * python/py-framefilter.c: Do not include py-ref.h.
15216         * python/py-function.c: Do not include py-ref.h.
15217         * python/py-infevents.c: Do not include py-ref.h.
15218         * python/py-linetable.c: Do not include py-ref.h.
15219         * python/py-objfile.c: Do not include py-ref.h.
15220         * python/py-param.c: Do not include py-ref.h.
15221         * python/py-prettyprint.c: Do not include py-ref.h.
15222         * python/py-progspace.c: Do not include py-ref.h.
15223         * python/py-symbol.c: Do not include py-ref.h.
15224         * python/py-symtab.c: Do not include py-ref.h.
15225         * python/py-type.c: Do not include py-ref.h.
15226         * python/py-unwind.c: Do not include py-ref.h.
15227         * python/py-utils.c: Do not include py-ref.h.
15228         * python/py-value.c: Do not include py-ref.h.
15229         * python/py-varobj.c: Do not include py-ref.h.
15230         * python/py-xmethods.c: Do not include py-ref.h.
15231         * python/python.c: Do not include py-ref.h.
15232         * varobj.c: Do not include py-ref.h.
15233
15234 2019-01-22  Tom Tromey  <tom@tromey.com>
15235
15236         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15237         keyword for bcache.
15238
15239 2019-01-22  Tom Tromey  <tom@tromey.com>
15240
15241         * compile/compile-cplus-types.c: Remove a comment by #include.
15242
15243 2019-01-22  Tom Tromey  <tom@tromey.com>
15244
15245         * compile/gcc-c-plugin.h: Include compile-internal.h.
15246
15247 2019-01-22  Tom Tromey  <tom@tromey.com>
15248
15249         * stabsread.c (EXTERN): Do not define.
15250         (symnum, next_symbol_text_func, processing_gcc_compilation)
15251         (within_function, global_sym_chain, global_stabs)
15252         (previous_stab_code, this_object_header_files)
15253         (n_this_object_header_files)
15254         (n_allocated_this_object_header_files): Define.
15255         * stabsread.h (EXTERN): Never define.  Use "extern".
15256
15257 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15258
15259         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15260         history_value.
15261
15262 2019-01-21  Tom Tromey  <tom@tromey.com>
15263
15264         * ui-out.c: Fix includes.
15265         * tui/tui-source.c: Fix includes.
15266         * target.c: Fix includes.
15267         * remote.c: Fix includes.
15268         * regcache.c: Fix includes.
15269         * python/py-block.c: Fix includes.
15270         * printcmd.c: Fix includes.
15271         * or1k-tdep.c: Fix includes.
15272         * mi/mi-main.c: Fix includes.
15273         * m32r-tdep.c: Fix includes.
15274         * csky-tdep.c: Fix includes.
15275         * compile/compile-cplus-types.c: Fix includes.
15276         * cli/cli-interp.c: Fix includes.
15277
15278 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
15279
15280         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15281         for padding.
15282
15283 2019-01-16  Tom Tromey  <tom@tromey.com>
15284
15285         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
15286         earlier.
15287         (struct objfile) <msymbols_range>: Move from top level.
15288         <msymbols>: New method.
15289         (class objfile_msymbols): Remove.
15290         * symtab.c (default_collect_symbol_completion_matches_break_on):
15291         Update.
15292         * symmisc.c (dump_msymbols): Update.
15293         * stabsread.c (scan_file_globals): Update.
15294         * objc-lang.c (info_selectors_command, info_classes_command)
15295         (find_methods): Update.
15296         * minsyms.c (find_solib_trampoline_target): Update.
15297         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15298         * coffread.c (coff_symfile_read): Update.
15299         * ada-lang.c (ada_lookup_simple_minsym)
15300         (ada_collect_symbol_completion_matches): Update.
15301
15302 2019-01-16  Tom Tromey  <tom@tromey.com>
15303
15304         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15305         type.  Remove no-argument constructor.
15306         <iterator::operator++>: Simplify.
15307         <begin>: Update.
15308         <end>: Use minimal_symbol_count.
15309
15310 2019-01-16  Tom Tromey  <tom@tromey.com>
15311
15312         * objfiles.h (struct objfile) <psymtabs>: New method.
15313         (class objfile_psymtabs): Remove.
15314         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15315         typedef.
15316         <range>: New method.
15317         (require_partial_symbols): Change return type.
15318         * psymtab.c (require_partial_symbols)
15319         (psym_expand_symtabs_matching): Update.
15320         * mdebugread.c (parse_partial_symbols): Update.
15321         * dbxread.c (dbx_end_psymtab): Update.
15322
15323 2019-01-15  Tom Tromey  <tom@tromey.com>
15324
15325         * symtab.c (lookup_objfile_from_block)
15326         (lookup_symbol_in_objfile_symtabs)
15327         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15328         (find_line_symtab, info_sources_command)
15329         (default_collect_symbol_completion_matches_break_on)
15330         (make_source_files_completion_list): Update.
15331         * symmisc.c (print_objfile_statistics, dump_objfile)
15332         (maintenance_print_symbols, maintenance_info_symtabs)
15333         (maintenance_check_symtabs, maintenance_info_line_tables):
15334         Update.
15335         * source.c (select_source_symtab)
15336         (forget_cached_source_info_for_objfile): Update.
15337         * objfiles.h (class objfile_compunits): Remove.
15338         (struct objfile) <compunits_range>: New typedef.
15339         (compunits): New method.
15340         * objfiles.c (objfile_relocate1): Update.
15341         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15342         * maint.c (count_symtabs_and_blocks): Update.
15343         * linespec.c (iterate_over_all_matching_symtabs): Update.
15344         * cp-support.c (add_symbol_overload_list_qualified): Update.
15345         * coffread.c (coff_symtab_read): Update.
15346         * ada-lang.c (add_nonlocal_symbols)
15347         (ada_collect_symbol_completion_matches)
15348         (ada_add_global_exceptions): Update.
15349
15350 2019-01-15  Tom Tromey  <tom@tromey.com>
15351
15352         * progspace.h (program_space) <objfiles_safe_range>: New
15353         typedef.
15354         <objfiles_safe>: New method.
15355         * objfiles.h (class all_objfiles_safe): Remove.
15356         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15357         * jit.c (jit_inferior_exit_hook): Update.
15358
15359 2019-01-17  Tom Tromey  <tom@tromey.com>
15360
15361         * progspace.h (program_space) <objfiles_range>: New typedef.
15362         <objfiles>: New method.
15363         <objfiles_head>: Rename from objfiles.
15364         (object_files): Update.
15365         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15366         * guile/scm-pretty-print.c
15367         (ppscm_find_pretty_printer_from_objfiles): Update.
15368         * guile/scm-objfile.c (gdbscm_objfiles): Update.
15369         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15370         Update.
15371         * python/py-progspace.c (pspy_get_objfiles): Update.
15372         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15373         Update.
15374         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15375         (objfpy_lookup_objfile_by_build_id): Update.
15376         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15377         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15378         Update.
15379         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15380         (expand_symtab_containing_pc, lookup_objfile_from_block)
15381         (lookup_static_symbol, basic_lookup_transparent_type)
15382         (find_pc_sect_compunit_symtab, find_symbol_at_address)
15383         (find_line_symtab, info_sources_command)
15384         (default_collect_symbol_completion_matches_break_on)
15385         (make_source_files_completion_list, find_main_name): Update.
15386         * symmisc.c (print_symbol_bcache_statistics)
15387         (print_objfile_statistics, maintenance_print_symbols)
15388         (maintenance_print_msymbols, maintenance_print_objfiles)
15389         (maintenance_info_symtabs, maintenance_check_symtabs)
15390         (maintenance_expand_symtabs, maintenance_info_line_tables):
15391         Update.
15392         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15393         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15394         (map_overlay_command, unmap_overlay_command)
15395         (simple_overlay_update, expand_symtabs_matching)
15396         (map_symbol_filenames): Update.
15397         * symfile-debug.c (set_debug_symfile): Update.
15398         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15399         Update.
15400         * source.c (select_source_symtab, forget_cached_source_info):
15401         Update.
15402         * solib.c (solib_read_symbols): Update.
15403         * solib-spu.c (append_ocl_sos): Update.
15404         * psymtab.c (maintenance_print_psymbols)
15405         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15406         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15407         * printcmd.c (info_symbol_command): Update.
15408         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15409         Update.
15410         * objfiles.h (class all_objfiles): Remove.
15411         * objfiles.c (have_partial_symbols, have_full_symbols)
15412         (have_minimal_symbols, qsort_cmp, update_section_map)
15413         (shared_objfile_contains_address_p)
15414         (default_iterate_over_objfiles_in_search_order): Update.
15415         * objc-lang.c (info_selectors_command, info_classes_command)
15416         (find_methods): Update.
15417         * minsyms.c (find_solib_trampoline_target): Update.
15418         * maint.c (maintenance_info_sections)
15419         (maintenance_translate_address, count_symtabs_and_blocks):
15420         Update.
15421         * main.c (captured_main_1): Update.
15422         * linux-thread-db.c (try_thread_db_load_from_pdir)
15423         (has_libpthread): Update.
15424         * linespec.c (iterate_over_all_matching_symtabs)
15425         (search_minsyms_for_name): Update.
15426         * jit.c (jit_find_objf_with_entry_addr): Update.
15427         * hppa-tdep.c (find_unwind_entry)
15428         (hppa_lookup_stub_minimal_symbol): Update.
15429         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15430         Update.
15431         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15432         (elf_gnu_ifunc_resolve_by_got): Update.
15433         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15434         * dwarf-index-write.c (save_gdb_index_command): Update.
15435         * cp-support.c (add_symbol_overload_list_qualified): Update.
15436         * breakpoint.c (create_overlay_event_breakpoint)
15437         (create_longjmp_master_breakpoint)
15438         (create_std_terminate_master_breakpoint)
15439         (create_exception_master_breakpoint): Update.
15440         * blockframe.c (find_pc_partial_function): Update.
15441         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15442         (ada_collect_symbol_completion_matches)
15443         (ada_add_global_exceptions): Update.
15444
15445 2019-01-17  Tom Tromey  <tom@tromey.com>
15446
15447         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
15448         declare VEC.
15449         (solib_target_parse_libraries): Change return type.
15450         (library_list_start_segment, library_list_start_section)
15451         (library_list_end_library, library_list_start_library); Update.
15452         (solib_target_free_library_list): Remove.
15453         (solib_target_parse_libraries): Remove cleanup.  Change return
15454         type.
15455         (solib_target_current_sos): Update.
15456
15457 2019-01-17  Tom Tromey  <tromey@bapiya>
15458
15459         * valprint.c: Replace "the the" with "the".
15460         * symtab.c: Replace "the the" with "the".
15461         * solib.c: Replace "the the" with "the".
15462         * solib-dsbt.c: Replace "the the" with "the".
15463         * linespec.c: Replace "the the" with "the".
15464         * dwarf2loc.h: Replace "the the" with "the".
15465         * amd64-windows-tdep.c: Replace "the the" with "the".
15466         * aarch64-tdep.c: Replace "the the" with "the".
15467
15468 2019-01-16  Keith Seitz  <keiths@redhat.com>
15469
15470         PR gdb/23773
15471         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15472         <builder>: Rename to ..
15473         <m_builder>: ... this and make private.
15474         (dwarf2_cu::get_builder): New method.  Change all users of
15475         `builder' to use this method.
15476         (dwarf2_start_symtab): Move to ...
15477         (dwarf2_cu::start_symtab): ... here.  Update all callers
15478         (setup_type_unit_groups): Move to ...
15479         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
15480         callers.
15481         (dwarf2_cu::reset_builder): New method.
15482         (process_full_compunit, process_full_type_unit): Use
15483         dwarf2_cu::reset_builder.
15484         (follow_die_offset): Record the ancestor CU if it is different
15485         from the followed DIE's CU.
15486         (follow_die_sig_1): Likewise.
15487
15488 2019-01-15  Tom Tromey  <tom@tromey.com>
15489
15490         * remote.c (class remote_state) <buf>: Now a char_vector.
15491         <buf_size>: Remove.
15492         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
15493         parameter.
15494         (remote_target::getpkt_or_notif_sane_1)
15495         (remote_target::getpkt_sane)
15496         (remote_target::getpkt_or_notif_sane): Likewise.
15497         (class remote_target) <putpkt>: New overload.
15498         (remote_target::read_frame): Change type of "buf_p".  Remove
15499         sizeof_p parameter.
15500         (packet_ok): New overload.
15501         (packet_check_result): New overload.
15502         Update all uses.
15503
15504 2019-01-14  Tom Tromey  <tom@tromey.com>
15505
15506         * remote-notif.c (handle_notification, remote_notif_ack)
15507         (remote_notif_parse): Make "buf" const.
15508         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15509         const.
15510         (remote_notif_parse, remote_notif_ack, handle_notification):
15511         Likewise.
15512         * remote.c (remote_notif_stop_parse): Make "buf" const.
15513         (remote_target::remote_parse_stop_reply): Make "buf" const.
15514         (remote_notif_stop_ack): Make "buf" const.
15515
15516 2019-01-14  Tom Tromey  <tom@tromey.com>
15517
15518         * remote.c (remote_console_output): Make parameter const.
15519
15520 2019-01-14  Tom Tromey  <tom@tromey.com>
15521
15522         * target-debug.h (target_debug_print_signals): Constify.
15523         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15524         * procfs.c (procfs_target::pass_signals): Update.
15525         * linux-nat.c (linux_nat_target::pass_signals): Update.
15526         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15527         * target-delegates.c: Rebuild.
15528         * remote.c (remote_target::program_signals): Update.
15529         (remote_target::pass_signals): Update.
15530         * target.c (target_pass_signals): Constify argument.
15531         (target_program_signals): Likewise.
15532         * target.h (struct target_ops) <pass_signals, program_signals>:
15533         Constify argument.
15534         (target_pass_signals, target_program_signals): Constify argument.
15535
15536 2019-01-14  Tom Tromey  <tom@tromey.com>
15537
15538         PR tui/28819:
15539         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15540
15541 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
15542
15543         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15544         field.
15545         * rs6000-tdep.c: Include reggroups.h.
15546         (IS_V_ALIAS_PSEUDOREG): Define.
15547         (rs6000_register_name): Return names for the "vX" aliases.
15548         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15549         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
15550         aliases.  Call default_register_reggroup_p for all other
15551         pseudo-registers.
15552         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15553         New functions.
15554         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15555         Handle "vX" aliases.
15556         (v_alias_pseudo_register_collect): New function.
15557         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15558         (rs6000_gdbarch_init): Initialize "vX" aliases as
15559         pseudo-registers.  Restore registration of
15560         rs6000_pseudo_register_reggroup_p with
15561         set_tdesc_pseudo_register_reggroup_p.
15562
15563 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
15564
15565         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15566         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15567         set_gdbarch_num_pseudo_regs.
15568
15569 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15570
15571         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15572         Remove arg prefixname, add do_set and do_show.
15573         Add member functions set_list and show_list.
15574         * cli/cli-style.c (class cli_style_option): Update accordingly.
15575         (style_set_list): Move to file scope.
15576         (style_show_list): Likewise.
15577         (set_style): Call help_list.
15578         (show_style): Call cmd_show_list.
15579         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15580         Update to use the new macro.
15581
15582 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
15583
15584         * ada-lang.c (_initialize_ada_language): Expand the help text
15585         for the "catch exception" command.
15586
15587 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15588
15589         * symtab.c (matching_obj_sections): Initialize obj,
15590         declare it closer to its usage.
15591
15592 2019-01-10  Tom Tromey  <tom@tromey.com>
15593
15594         * thread-iter.h (inf_threads_iterator): Use next_iterator.
15595         (basic_inf_threads_range): Remove.
15596         (inf_threads_range, inf_non_exited_threads_range)
15597         (safe_inf_threads_range): Use next_adapter.
15598
15599 2019-01-10  Keith Seitz  <keiths@redhat.com>
15600
15601         PR gdb/23712
15602         PR symtab/23010
15603         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15604         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15605
15606 2019-01-10  Keith Seitz  <keiths@redhat.com>
15607
15608         PR gdb/23712
15609         PR symtab/23010
15610         * dictionary.c (pending_to_vector): Remove.
15611         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15612         Remove _1 suffix, replacing functions of the same name.  Update
15613         all callers.
15614         (dict_create_hashed, dict_create_hashed_expandable)
15615         (dict_create_linear, dict_create_linear_expandable, dict_free)
15616         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15617         Make functions static.
15618
15619 2019-01-10  Keith Seitz  <keiths@redhat.com>
15620
15621         PR gdb/23712
15622         PR symtab/23010
15623         * dictionary.h (struct dictionary): Replace declaration with
15624         multidictionary.
15625         (dict_create_hashed, dict_create_hashed_expandable)
15626         (dict_create_linear, dict_create_linear_expandable)
15627         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15628         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15629         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15630         taking multidictionary argument.
15631         [ALL_DICT_SYMBOLS]: Update for multidictionary.
15632         * block.h (struct block) <dict>: Change to multidictionary
15633         and rename `multidict'.
15634         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15635         symmisc.c: Update all dictionary references to multidictionary.
15636
15637 2019-01-10  Keith Seitz  <keiths@redhat.com>
15638
15639         PR gdb/23712
15640         PR symtab/23010
15641         * dictionary.c: Include unordered_map.
15642         (pending_to_vector): New function.
15643         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15644         Rewrite the non-"_1" functions to take vector instead
15645         of linked list.
15646         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15647         "new" _1 versions of the same name.
15648         (multidictionary): Define.
15649         (std::hash<enum language): New definition.
15650         (collate_pending_symbols_by_language, mdict_create_hashed)
15651         (mdict_create_hashed_expandable, mdict_create_linear)
15652         (mdict_create_linear_expandable, mdict_free)
15653         (find_language_dictionary, create_new_language_dictionary)
15654         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15655         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15656         (mdict_size, mdict_empty): New functions.
15657         * dictionary.h (mdict_iterator): Define.
15658
15659 2019-01-10  Pedro Alves  <palves@redhat.com>
15660
15661         * breakpoint.c (read_uploaded_action)
15662         (create_tracepoint_from_upload): Adjust to use
15663         gdb::unique_xmalloc_ptr.
15664         * ctf.c (ctf_write_uploaded_tp):
15665         (SET_ARRAY_FIELD): Use emplace_back.
15666         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15667         * tracefile-tfile.c (tfile_write_uploaded_tp):
15668         * tracepoint.c (parse_tracepoint_definition): Adjust to use
15669         gdb::unique_xmalloc_ptr.
15670         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15671         at_string, cond_string, cmd_strings>: Replace char pointers
15672         with gdb::unique_xmalloc_ptr.
15673
15674 2019-01-10  Pedro Alves  <palves@redhat.com>
15675
15676         * solib-target.c (library_list_start_library): Don't xstrdup name.
15677
15678 2019-01-10  Pedro Alves  <palves@redhat.com>
15679
15680         * mdebugread.c (parse_partial_symbols): Use
15681         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15682
15683 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15684
15685         * linux-fork.c (scoped_switch_fork_info)
15686         <~scoped_switch_fork_info>: Fix incorrect variable name.
15687
15688 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15689
15690         * linux-fork.c (scoped_switch_fork_info)
15691         <scoped_switch_fork_info>: Make explicit.
15692         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15693
15694 2019-01-10  Tom Tromey  <tom@tromey.com>
15695
15696         * objfiles.h (objfile::reset_psymtabs): Update.
15697         * objfiles.c (objfile::objfile): Update.
15698         * psymtab.h (psymtab_storage::obstack): Update.
15699         (psymtab_storage::m_obstack): Use gdb::optional.
15700         (class psymtab_storage): Update comment.  Remove objfile
15701         parameter.
15702         * psymtab.c (psymtab_storage::psymtab_storage): Update.
15703
15704 2019-01-10  Tom Tromey  <tom@tromey.com>
15705
15706         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15707         <free_psymtabs>: Now private.
15708         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15709         (allocate_psymtab): Use new method.
15710
15711 2019-01-10  Tom Tromey  <tom@tromey.com>
15712
15713         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15714         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15715         * mdebugread.c (parse_partial_symbols): Use
15716         allocate_dependencies.
15717         * dwarf2read.c (dwarf2_create_include_psymtab): Use
15718         allocate_dependencies.
15719         (process_psymtab_comp_unit_reader)
15720         (build_type_psymtab_dependencies): Likewise.
15721         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15722
15723 2019-01-10  Tom Tromey  <tom@tromey.com>
15724
15725         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15726         PSYMBOL_SET_LANGUAGE.
15727         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15728
15729 2019-01-10  Tom Tromey  <tom@tromey.com>
15730
15731         * psymtab.h (psymtab_storage::obstack): New method.
15732         <m_obstack>: Rename from obstack; now private.
15733         * psymtab.c (psymtab_storage): Update.
15734         * dwarf2read.c (create_addrmap_from_index)
15735         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15736         Update.
15737
15738 2019-01-10  Tom Tromey  <tom@tromey.com>
15739
15740         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15741         * objfiles.h (objfile::reset_psymtabs): New method.
15742
15743 2019-01-10  Tom Tromey  <tom@tromey.com>
15744
15745         * symmisc.c (print_symbol_bcache_statistics): Update.
15746         (print_objfile_statistics): Update.
15747         * symfile.c (reread_symbols): Update.
15748         * psymtab.h (class psymtab_storage): New.
15749         * psymtab.c (psymtab_storage): New constructor.
15750         (~psymtab_storage): New destructor.
15751         (require_partial_symbols): Update.
15752         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15753         (find_pc_sect_psymtab, find_pc_sect_psymbol)
15754         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15755         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15756         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15757         (start_psymtab_common, end_psymtab_common)
15758         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15759         (allocate_psymtab): Update.
15760         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15761         Update.
15762         (dump_psymtab_addrmap, maintenance_print_psymbols)
15763         (maintenance_check_psymtabs): Update.
15764         (class objfile_psymtabs): Move to objfiles.h.
15765         * psympriv.h (discard_psymtab): Now inline.
15766         (psymtab_discarder::psymtab_discarder): Update.
15767         (psymtab_discarder::~psymtab_discarder): Update.
15768         (ALL_OBJFILE_PSYMTABS): Rewrite.
15769         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15770         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15771         Remove fields.
15772         <partial_symtabs>: New field.
15773         (class objfile_psymtabs): Move from psymtab.h.  Update.
15774         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15775         psymbol_cache.
15776         (objfile::~objfile): Don't destroy psymbol_cache.
15777         * mdebugread.c (parse_partial_symbols): Update.
15778         * dwarf2read.c (create_addrmap_from_index)
15779         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15780         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15781         (add_partial_subprogram, dwarf2_ranges_read): Update.
15782         * dwarf-index-write.c (write_address_map)
15783         (write_one_signatured_type, recursively_write_psymbols)
15784         (class debug_names, class debug_names, write_psymtabs_to_index):
15785         Update.
15786
15787 2019-01-10  Tom Tromey  <tom@tromey.com>
15788
15789         * symtab.h (SYMBOL_SET_NAMES): Update.
15790         (symbol_set_names): Update.
15791         (MSYMBOL_SET_NAMES): Update.
15792         * symtab.c (symbol_set_names): Change argument to be an
15793         objfile_per_bfd_storage.
15794         * psymtab.c (add_psymbol_to_bcache): Update.
15795         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15796
15797 2019-01-10  Tom Tromey  <tom@tromey.com>
15798
15799         * symtab.c (create_demangled_names_hash): Change argument to be an
15800         objfile_per_bfd_storage.
15801         (symbol_set_names): Update.
15802
15803 2019-01-10  Tom Tromey  <tom@tromey.com>
15804
15805         * xcoffread.c (xcoff_initial_scan): Unconditionally call
15806         init_psymbol_list.
15807         * psymtab.c (init_psymbol_list): Do nothing if already called.
15808         * psympriv.h (init_psymbol_list): Add comment.
15809         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15810         init_psymbol_list.
15811         * dbxread.c (dbx_symfile_read): Unconditionally call
15812         init_psymbol_list.
15813
15814 2019-01-10  Tom Tromey  <tom@tromey.com>
15815
15816         * xcoffread.c (scan_xcoff_symtab): Update.
15817         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15818         "where".
15819         * mdebugread.c (parse_partial_symbols)
15820         (handle_psymbol_enumerators): Update.
15821         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15822         * dbxread.c (read_dbx_symtab): Update.
15823         * psympriv.h (psymbol_placement): New enum.
15824         (add_psymbol_to_list): Update.
15825
15826 2019-01-10  Tom Tromey  <tom@tromey.com>
15827
15828         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15829         static_psymbols parameters.
15830         (scan_xcoff_symtab): Update.
15831         * psymtab.c (start_psymtab_common): Remove global_psymbols and
15832         static_psymbols parameters.
15833         * psympriv.h (start_psymtab_common): Update.
15834         * mdebugread.c (parse_partial_symbols): Update.
15835         * dwarf2read.c (create_partial_symtab): Update.
15836         * dbxread.c (read_dbx_symtab): Update.
15837         (start_psymtab): Remove global_psymbols and static_psymbols
15838         parameters.
15839
15840 2019-01-10  Tom Tromey  <tom@tromey.com>
15841
15842         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15843         * psymtab.c (allocate_psymtab): Add comment.
15844         * psympriv.h (allocate_psymtab): Add comment.
15845         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15846         initializations.
15847         * dbxread.c (dbx_end_psymtab): Remove some initializations.
15848
15849 2019-01-10  Tom Tromey  <tom@tromey.com>
15850
15851         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15852         Don't declare.
15853         * mipsread.c: Include mdebugread.h.
15854         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15855         Declare.
15856         * elfread.c: Include mdebugread.h.
15857
15858 2019-01-09  Tom Tromey  <tom@tromey.com>
15859
15860         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15861         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15862         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15863         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15864         (psym_lookup_symbol, psym_find_last_source_symtab)
15865         (psym_forget_cached_source_info, psym_print_stats)
15866         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15867         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15868         (psym_map_matching_symbols, psym_expand_symtabs_matching)
15869         (psym_find_compunit_symtab_by_address)
15870         (maintenance_print_psymbols, maintenance_info_psymtabs)
15871         (maintenance_check_psymtabs): Use ranged for.
15872         * psymtab.h (class objfile_psymtabs): New.
15873         (require_partial_symbols): Return objfile_psymtabs.
15874         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15875
15876 2019-01-09  Tom Tromey  <tom@tromey.com>
15877
15878         * symfile.c (overlay_invalidate_all, find_pc_overlay)
15879         (find_pc_mapped_section, list_overlays_command)
15880         (map_overlay_command, unmap_overlay_command)
15881         (simple_overlay_update): Use all_objfiles.
15882         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15883         * printcmd.c (info_symbol_command): Use all_objfiles.
15884         * objfiles.h (ALL_OBJSECTIONS): Remove.
15885         * maint.c (maintenance_translate_address): Use all_objfiles.
15886         * gcore.c (gcore_create_callback): Use all_objfiles.
15887         (objfile_find_memory_regions): Likewise.
15888
15889 2019-01-09  Tom Tromey  <tom@tromey.com>
15890
15891         * symtab.c (find_line_symtab, info_sources_command)
15892         (make_source_files_completion_list): Use objfile_compunits.
15893         * source.c (select_source_symtab): Use objfile_compunits.
15894         * objfiles.h (struct objfile): Update comment.
15895         (ALL_OBJFILES): Remove.
15896         (ALL_FILETABS): Remove.
15897         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15898         objfile_compunits.
15899
15900 2019-01-09  Tom Tromey  <tom@tromey.com>
15901
15902         * symmisc.c (print_objfile_statistics, dump_objfile)
15903         (maintenance_print_symbols): Use compunit_filetabs.
15904         * source.c (forget_cached_source_info_for_objfile): Use
15905         compunit_filetabs.
15906         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15907         (ALL_FILETABS): Use compunit_filetabs.
15908         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15909         * coffread.c (coff_symtab_read): Use compunit_filetabs.
15910
15911 2019-01-09  Tom Tromey  <tom@tromey.com>
15912
15913         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15914         (compunit_filetabs): New.
15915         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15916         compunit_filetabs.
15917         (info_sources_command, make_source_files_completion_list): Remove
15918         declaration.
15919         * symmisc.c (print_objfile_statistics, dump_objfile)
15920         (maintenance_print_symbols): Remove declaration.
15921         (maintenance_info_symtabs): Use compunit_filetabs.
15922         (maintenance_info_line_tables): Likewise.
15923         * source.c (select_source_symtab): Change local variable name.
15924         (forget_cached_source_info_for_objfile): Remove declaration.
15925         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
15926         * objfiles.c (objfile_relocate1): Remove declaration.
15927         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15928         declaration.
15929         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
15930         * coffread.c (coff_symtab_read): Remove declaration.
15931         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
15932         compunit_filetabs.
15933
15934 2019-01-09  Tom Tromey  <tom@tromey.com>
15935
15936         * symtab.c (lookup_objfile_from_block)
15937         (find_pc_sect_compunit_symtab, search_symbols)
15938         (default_collect_symbol_completion_matches_break_on): Use
15939         objfile_compunits.
15940         * objfiles.h (ALL_COMPUNITS): Remove.
15941         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
15942         * cp-support.c (add_symbol_overload_list_qualified): Use
15943         objfile_compunits.
15944         * ada-lang.c (ada_collect_symbol_completion_matches)
15945         (ada_add_global_exceptions): Use objfile_compunits.
15946
15947 2019-01-09  Tom Tromey  <tom@tromey.com>
15948
15949         * source.c (select_source_symtab)
15950         (forget_cached_source_info_for_objfile): Remove declaration.
15951         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15952         declaration.
15953         * maint.c (count_symtabs_and_blocks): Remove declaration.
15954         * cp-support.c (add_symbol_overload_list_qualified): Remove
15955         declaration.
15956         * coffread.c (coff_symtab_read): Remove declaration.
15957         * symtab.c (lookup_symbol_in_objfile_symtabs)
15958         (basic_lookup_transparent_type_1): Use objfile_compunits.
15959         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
15960         (info_sources_command, search_symbols)
15961         (default_collect_symbol_completion_matches_break_on)
15962         (make_source_files_completion_list): Remove declaration.
15963         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
15964         (ada_collect_symbol_completion_matches)
15965         (ada_add_global_exceptions): Remove declaration.
15966         * linespec.c (iterate_over_all_matching_symtabs): Use
15967         objfile_compunits.
15968         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
15969         (class objfile_compunits): New.
15970         (ALL_COMPUNITS): Use objfile_compunits.
15971         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
15972         (maintenance_check_symtabs, maintenance_info_line_tables): Use
15973         objfile_compunits.
15974         * objfiles.c (objfile_relocate1): Use objfile_compunits.
15975
15976 2019-01-09  Tom Tromey  <tom@tromey.com>
15977
15978         * symtab.c (search_symbols)
15979         (default_collect_symbol_completion_matches_break_on): Use
15980         objfile_msymbols.
15981         * ada-lang.c (ada_lookup_simple_minsym)
15982         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
15983         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
15984         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
15985         objfile_msymbols.
15986         * coffread.c (coff_symfile_read): Use objfile_msymbols.
15987         * symmisc.c (dump_msymbols): Use objfile_msymbols.
15988         * objc-lang.c (find_methods): Use objfile_msymbols.
15989         (info_selectors_command, info_classes_command): Likewise.
15990         * stabsread.c (scan_file_globals): Use objfile_msymbols.
15991         * objfiles.h (class objfile_msymbols): New.
15992         (ALL_OBJFILE_MSYMBOLS): Remove.
15993         (ALL_MSYMBOLS): Remove.
15994
15995 2019-01-09  Tom Tromey  <tom@tromey.com>
15996
15997         * common/next-iterator.h (next_adapter): Add Iterator template
15998         parameter.
15999         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16000         (class all_objfiles_safe): New.
16001         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16002         * objfiles.c (put_objfile_before): Update comment.
16003         (add_separate_debug_objfile): Likewise.
16004         (free_all_objfiles): Use all_objfiles_safe.
16005         (objfile_purge_solibs): Likewise.
16006
16007 2019-01-09  Tom Tromey  <tom@tromey.com>
16008
16009         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16010         (expand_symtab_containing_pc, lookup_static_symbol)
16011         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16012         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16013         all_objfiles.
16014         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16015         * breakpoint.c (create_overlay_event_breakpoint)
16016         (create_longjmp_master_breakpoint)
16017         (create_std_terminate_master_breakpoint)
16018         (create_exception_master_breakpoint): Use all_objfiles.
16019         * linux-thread-db.c (try_thread_db_load_from_pdir)
16020         (has_libpthread): Use all_objfiles.
16021         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16022         * linespec.c (iterate_over_all_matching_symtabs)
16023         (search_minsyms_for_name): Use all_objfiles.
16024         * maint.c (maintenance_info_sections): Use all_objfiles.
16025         * main.c (captured_main_1): Use all_objfiles.
16026         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16027         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16028         * guile/scm-pretty-print.c
16029         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16030         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16031         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16032         (maintenance_print_msymbols): Use all_objfiles.
16033         * source.c (select_source_symtab): Use all_objfiles.
16034         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16035         * symfile.c (remove_symbol_file_command)
16036         (expand_symtabs_matching, map_symbol_filenames): Use
16037         all_objfiles.
16038         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16039         all_objfiles.
16040         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16041         * objc-lang.c (find_methods): Use all_objfiles.
16042         * objfiles.c (have_partial_symbols, have_full_symbols)
16043         (have_minimal_symbols, qsort_cmp)
16044         (default_iterate_over_objfiles_in_search_order): Use
16045         all_objfiles.
16046         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16047         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16048         (maintenance_check_psymtabs): Use all_objfiles.
16049         (ALL_PSYMTABS): Remove.
16050         * compile/compile-object-run.c (do_module_cleanup): Use
16051         all_objfiles.
16052         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16053         * cp-support.c (add_symbol_overload_list_qualified): Use
16054         all_objfiles.
16055         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16056         Use all_objfiles.
16057         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16058         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16059         all_objfiles.
16060         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16061         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16062         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16063         Uses all_objfiles.
16064         * solib.c (solib_read_symbols): Use all_objfiles
16065
16066 2019-01-09  Tom Tromey  <tom@tromey.com>
16067
16068         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16069         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16070         all_objfiles.
16071         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16072         * symmisc.c (print_symbol_bcache_statistics)
16073         (print_objfile_statistics, maintenance_print_objfiles)
16074         (maintenance_info_symtabs, maintenance_check_symtabs)
16075         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16076         all_objfiles.
16077         * source.c (forget_cached_source_info): Use all_objfiles.
16078         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16079         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16080         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16081         * objfiles.c (update_section_map): Use all_objfiles.
16082         (shared_objfile_contains_address_p): Likewise.
16083         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16084         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16085
16086 2019-01-09  Tom Tromey  <tom@tromey.com>
16087
16088         * common/next-iterator.h: New file.
16089         * objfiles.h (class all_objfiles): New.
16090         (struct objfile_iterator): New.
16091
16092 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16093
16094         * NEWS: Move the description of the changed "frame", "select-frame",
16095          and "info frame" commands to the Changed commands section.
16096
16097 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16098
16099         * gdbtypes.c (check_stub_method_group): Remove handling of old
16100         mangling schemes.
16101         * linespec.c (find_methods): Likewise.
16102         * stabsread.c (read_member_functions): Likewise.
16103         * valops.c (search_struct_method): Likewise.
16104         (value_struct_elt_for_reference): Likewise.
16105         * NEWS: Mention this change.
16106
16107 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16108
16109         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16110         print_source_lines.
16111         * source.c (print_source_lines_base): Update line number check.
16112         (print_source_lines): New function.
16113         (source_lines_range::source_lines_range): New function.
16114         * source.h (class source_lines_range): New class.
16115         (print_source_lines): New declaration.
16116
16117 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16118
16119         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16120
16121 2019-01-08  Tom Tromey  <tom@tromey.com>
16122             Simon Marchi  <simon.marchi@ericsson.com>
16123
16124         PR gdb/24060
16125         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16126         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16127         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16128         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16129         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16130         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16131
16132 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16133
16134         * source.c (select_source_symtab): Move header comment to
16135         declaration in source.h.
16136         (forget_cached_source_info_for_objfile): Likewise.
16137         (forget_cached_source_info): Likewise.
16138         (identify_source_line): Likewise.
16139         * source.h (identify_source_line): Move declaration from symtab.h
16140         and add comment from source.c
16141         (print_source_lines): Likewise.
16142         (forget_cached_source_info_for_objfile): Likewise.
16143         (forget_cached_source_info): Likewise.
16144         (select_source_symtab): Likewise.
16145         (enum print_source_lines_flag): Move definition from symtab.h.
16146         * symtab.h (identify_source_line): Move declaration to source.h.
16147         (print_source_lines): Likewise.
16148         (forget_cached_source_info_for_objfile): Likewise.
16149         (forget_cached_source_info): Likewise.
16150         (select_source_symtab): Likewise.
16151         (enum print_source_lines_flag): Move definition to source.h.
16152         * tui/tui-hooks.c: Add 'source.h' include.
16153
16154 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16155
16156         * source.c (print_source_lines_base): Handle requests to print
16157         reverse line number sequences, and guard against empty lines
16158         string.
16159
16160 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16161
16162         * source.c (print_source_lines_base): Fix skip of '\r' if next
16163         character is '\n'.
16164
16165 2019-01-06  Tom Tromey  <tom@tromey.com>
16166
16167         * c-exp.y (struct c_parse_state) <macro_original_text,
16168         expansion_obstack>: New member.
16169         (macro_original_text, expansion_obstack): Remove globals.
16170         (scan_macro_expansion, scanning_macro_expansion)
16171         (finished_macro_expansion): Update.
16172         (scan_macro_cleanup): Remove.
16173         (yylex, c_parse): Update.
16174
16175 2019-01-06  Tom Tromey  <tom@tromey.com>
16176
16177         * c-exp.y (struct c_parse_state) <strings>: New member.
16178         (operator_stoken): Update.
16179
16180 2019-01-06  Tom Tromey  <tom@tromey.com>
16181
16182         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16183         (union type_stack_elt) <typelist_val>: Now a pointer to
16184         std::vector.
16185         (type_stack_cleanup): Don't declare.
16186         (push_typelist): Update.
16187         * parse.c (pop_typelist): Return a std::vector.
16188         (push_typelist): Take a std::vector.
16189         (follow_types): Update.  Do not free args.
16190         (type_stack_cleanup): Remove.
16191         * c-exp.y (struct c_parse_state): New.
16192         (cpstate): New global.
16193         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16194         (nonempty_typelist): Update.
16195         (func_mod): Create a new vector.
16196         (c_parse): Create a c_parse_state.
16197         (check_parameter_typelist): Do not delete params.
16198         (function_method): Update.  Do not delete type_list.
16199
16200 2019-01-06  Tom Tromey  <tom@tromey.com>
16201
16202         PR gdb/28155:
16203         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16204         check_typedef.
16205         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16206         (print_return_value): Likewise.
16207
16208 2019-01-05  Tom Tromey  <tom@tromey.com>
16209
16210         * contrib/cleanup_check.py: Remove.
16211         * contrib/gcc-with-excheck: Remove.
16212         * contrib/exsummary.py: Remove.
16213         * contrib/excheck.py: Remove.
16214
16215 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
16216
16217         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16218         NULL. Initialize tpprev to NULL instead of assigning it
16219         to NULL on the next statement.
16220         * windows-nat.c (windows_delete_thread): Remove check for
16221         main_thread_id before printing thread exit notifications.
16222         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16223         Remove thread ID check against main_thread_id.
16224         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16225         windows_delete_thread.
16226         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16227
16228 2019-01-04  Tom Tromey  <tom@tromey.com>
16229
16230         * compile/compile.c (_initialize_compile): Use upper case for
16231         metasyntactic variables.
16232         * symmisc.c (_initialize_symmisc): Use upper case for
16233         metasyntactic variables.
16234         * psymtab.c (_initialize_psymtab): Use upper case for
16235         metasyntactic variables.
16236         * demangle.c (demangle_command): Use upper case for metasyntactic
16237         variables.
16238         (_initialize_demangler): Likewise.
16239         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16240         variables.
16241
16242 2019-01-03  Tom Tromey  <tom@tromey.com>
16243
16244         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16245
16246 2019-01-03  Tom Tromey  <tom@tromey.com>
16247
16248         * python/py-symtab.c (salpy_str): Update.
16249         (struct salpy_sal_object) <symtab>: Now a PyObject.
16250         (salpy_dealloc): Update.
16251         (del_objfile_sal): Use gdbpy_ref.
16252
16253 2019-01-03  Tom Tromey  <tom@tromey.com>
16254
16255         * python/py-type.c (convert_field): Use new_reference.  Return
16256         gdbpy_ref.
16257         (make_fielditem): Return gdbpy_ref.
16258         (typy_fields): Update.
16259         (typy_getitem): Update.
16260         (field_name): Return gdbpy_ref.  Use new_reference.
16261         (typy_iterator_iternext): Update.
16262
16263 2019-01-03  Tom Tromey  <tom@tromey.com>
16264
16265         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16266
16267 2019-01-03  Tom Tromey  <tom@tromey.com>
16268
16269         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16270         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16271         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16272         (pspy_set_frame_filters, pspy_set_frame_unwinders)
16273         (pspy_set_type_printers): Likewise.
16274         * python/py-function.c (fnpy_init): Use gdbpy_ref.
16275         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16276         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16277         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16278         (objfpy_set_type_printers): Likewise.
16279
16280 2019-01-03  Tom Tromey  <tom@tromey.com>
16281
16282         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16283         (gdbpy_print_stack): Use gdbpy_err_fetch.
16284         * python/python-internal.h (class gdbpy_err_fetch): New class.
16285         (class gdbpy_enter) <m_error_type, m_error_value,
16286         m_error_traceback>: Remove.
16287         <m_error>: New member.
16288         (gdbpy_exception_to_string): Don't declare.
16289         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16290         * python/py-value.c (convert_value_from_python): Use
16291         gdbpy_err_fetch.
16292         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16293         gdbpy_exception_to_string.
16294         (gdbpy_handle_exception): Use gdbpy_err_fetch.
16295         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16296         gdbpy_err_fetch.
16297
16298 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16299
16300         * linux-nat.c (delete_lwp_cleanup): Delete.
16301         (struct lwp_deleter): New struct.
16302         (lwp_info_up): New typedef.
16303         (linux_nat_target::follow_fork): Delete cleanup, and make use of
16304         lwp_info_up.
16305
16306 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16307
16308         * linux-fork.c (class scoped_switch_fork_info): New class.
16309         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16310
16311 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16312
16313         * valops.c (find_overload_match): Remove use of null_cleanup, and
16314         calls to do_cleanups.
16315
16316 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16317
16318         * compile/compile-cplus-types.c
16319         (compile_cplus_instance::decl_name): Handle changes to
16320         cp_func_name.
16321         * cp-support.c (cp_func_name): Update header comment, update
16322         return type.
16323         * cp-support.h (cp_func_name): Update return type in declaration.
16324         * valops.c (find_overload_match): Move temp_func local to top
16325         level of function and change its type.  Use temp_func to hold and
16326         delete temporary string obtained from cp_func_name.
16327
16328 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16329
16330         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16331         gdb::char_vector, remove cleanup, and update uses of `msg`.
16332
16333 2019-01-03  Jim Wilson  <jimw@sifive.com>
16334
16335         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16336
16337 2019-01-02  Tom Tromey  <tom@tromey.com>
16338
16339         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16340         (tdesc_parse_xml): Remove cleanups.
16341         * target-descriptions.h (make_cleanup_free_target_description):
16342         Don't declare.
16343         (target_desc_deleter): New struct.
16344         (target_desc_up): New typedef.
16345         * target-descriptions.c (target_desc_deleter::operator()): Rename
16346         from free_target_description.
16347         (make_cleanup_free_target_description): Remove.
16348
16349 2019-01-02  Tom Tromey  <tom@tromey.com>
16350
16351         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
16352         constructor, destructor.
16353         (linespec_parser): Remove typedef.
16354         (~linespec_parser): Rename from linespec_parser_delete.
16355         (linespec_lex_to_end, linespec_complete_label)
16356         (linespec_complete): Update.
16357         (decode_line_full): Remove cleanups.
16358         (decode_line_1): Update.
16359
16360 2019-01-02  Tom Tromey  <tom@tromey.com>
16361
16362         * python/python-internal.h (inferior_to_inferior_object): Change
16363         return type.
16364         * python/py-exitedevent.c (create_exited_event_object): Update.
16365         * python/py-inferior.c (inferior_to_inferior_object): Return
16366         gdbpy_ref.
16367         (python_new_inferior, python_inferior_deleted)
16368         (thread_to_thread_object, delete_thread_object)
16369         (build_inferior_list, gdbpy_selected_inferior): Update.
16370         * python/py-infthread.c (create_thread_object): Update.  Also fail
16371         if inferior_to_inferior_object fails.
16372
16373 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
16374
16375         * inferior.h (class inferior) <displaced_step_state>: New field.
16376         * infrun.h (struct displaced_step_state): Move here from
16377         infrun.c.  Initialize fields, add constructor.
16378         <inf>: Remove field.
16379         <reset>: New method.
16380         * infrun.c (struct displaced_step_inferior_state): Move to
16381         infrun.h.
16382         (displaced_step_inferior_states): Remove.
16383         (get_displaced_stepping_state): Adust.
16384         (displaced_step_in_progress_any_inferior): Adjust.
16385         (displaced_step_in_progress_thread): Adjust.
16386         (displaced_step_in_progress): Adjust.
16387         (add_displaced_stepping_state): Remove.
16388         (get_displaced_step_closure_by_addr): Adjust.
16389         (remove_displaced_stepping_state): Remove.
16390         (infrun_inferior_exit): Call displaced_step_state.reset.
16391         (use_displaced_stepping): Don't check for NULL.
16392         (displaced_step_prepare_throw): Call
16393         get_displaced_stepping_state.
16394         (displaced_step_fixup): Don't check for NULL.
16395         (prepare_for_detach): Don't check for NULL.
16396
16397 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16398
16399         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16400          in case of call that did not complete.
16401
16402 2019-01-02  Andrey Utkin  <autkin@undo.io>
16403
16404         * symfile.c (find_separate_debug_file): Fix search of debug files for
16405         remote debuggee.
16406
16407 2019-01-02  Tom Tromey  <tom@tromey.com>
16408
16409         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16410         indentation.
16411         * python/py-frame.c (frapy_older): Remove cast.
16412         (frapy_newer): Likewise.
16413         * python/py-breakpoint.c (local_setattro): Remove cast.
16414         * python/py-arch.c (archpy_name): Remove local variable.
16415         * python/py-type.c (gdbpy_lookup_type): Remove cast.
16416
16417 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
16418
16419         * unittests/basic_string_view/element_access/char/empty.cc:
16420         Fix year range in copyright header.
16421
16422 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
16423
16424         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16425         Delete.
16426         <operator==>: Update with for removed field.
16427         <hash>: Likewise.
16428         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16429         <isa_features>: ...this.
16430         <abi_features>: New field.
16431         (riscv_isa_flen): Update comment.
16432         (riscv_abi_xlen): New declaration.
16433         (riscv_abi_flen): New declaration.
16434         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16435         isa_features.
16436         (riscv_abi_xlen): New function.
16437         (riscv_isa_flen): Update to get answer from isa_features.
16438         (riscv_abi_flen): New function.
16439         (riscv_has_fp_abi): Update to get answer from abi_features.
16440         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16441         xlen and flen.
16442         (riscv_call_info) <xlen, flen>: Update comment.
16443         (riscv_call_arg_struct): Remove invalid assertions
16444         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16445         is removed.
16446         (riscv_gdbarch_init): Gather isa features and abi features
16447         separately, ensure both match on the gdbarch when reusing an old
16448         gdbarch.  Relax an error check to allow 32-bit abi float to run on
16449         a target with 64-bit float hardware.
16450
16451 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16452
16453         * source.c (search_command_helper): Stop reverse search
16454         when line 1 has been searched.
16455
16456 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16457
16458         * record-full.c (record_full_base_target::close): Rewrite
16459         record_full_core_buf_list free logic.
16460
16461 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16462
16463         * break-catch-syscall.c (print_one_catch_syscall): xfree
16464         the last text.
16465
16466 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16467
16468         * top.c (print_gdb_version): Update Copyright year in version
16469         message.
16470
16471 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16472
16473         Update copyright year range in all GDB files.
16474
16475 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
16476
16477         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16478
16479 For older changes see ChangeLog-2018.
16480 \f
16481 Local Variables:
16482 mode: change-log
16483 left-margin: 8
16484 fill-column: 74
16485 version-control: never
16486 coding: utf-8
16487 End:
16488