gdb/ChangeLog

   1 2019-06-19  Tom Tromey  <tromey@adacore.com>
   2
   3         * source-cache.c (highlighter): New global.
   4         (source_cache::get_source_lines): Create a highlighter on demand.
   5
   6 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
   7
   8         * defs.h (deprecated_interactive_hook): Delete declaration.
   9         * interps.c (clear_interpreter_hooks): Remove use of
  10         deprecated_interactive_hook.
  11         * top.c (deprecated_interactive_hook): Delete definition.
  12         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
  13
  14 2019-06-18  Tom de Vries  <tdevries@suse.de>
  15
  16         PR gdb/24515
  17         * dwarf2read.h (abstract_to_concrete): Change type from
  18         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
  19         std::unordered_map<sect_offset, std::vector<sect_offset>>.
  20         * dwarf2read.c (read_variable): Update.
  21         (dwarf2_fetch_die_loc_sect_off): Update.
  22
  23 2019-06-17  Tom de Vries  <tdevries@suse.de>
  24
  25         PR gdb/24617
  26         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
  27         accessing parent[parent_len - 1].
  28
  29 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
  30
  31         PR gdb/24364
  32         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
  33         call dtrace_process_dof with NULL dof.
  34
  35 2019-06-16  Tom de Vries  <tdevries@suse.de>
  36
  37         PR gdb/24445
  38         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
  39
  40 2019-06-16  Tom Tromey  <tom@tromey.com>
  41
  42         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
  43         (make_all_visible): Use address of member.
  44
  45 2019-06-16  Tom Tromey  <tom@tromey.com>
  46
  47         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
  48         (tui_free_window, free_content, free_content_elements): Remove
  49         unnecessary cast.
  50         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
  51         cast.
  52         * tui/tui-regs.c (tui_show_register_group)
  53         (tui_display_registers_from, tui_display_reg_element_at_line):
  54         Remove unnecessary cast.
  55
  56 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
  57
  58         * linux-nat.c (normal_mask): Delete.
  59         (_initialize_linux_nat): Don't initialise normal_mask.
  60
  61 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
  62
  63         PR gdb/24445
  64         * dwarf-index-write.h (write_psymtabs_to_index): Add
  65         dwz_basename parameter.
  66         * dwarf-index-write.c (write_gdbindex): Move file writing to
  67         write_gdbindex_1.  Change return type void.
  68         (assert_file_size): Move up, remove filename parameter.
  69         (write_gdbindex_1): New function.
  70         (write_debug_names): Change return type to void, call
  71         assert_file_size.
  72         (struct index_wip_file): New struct.
  73         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
  74         file logic to index_wip_file.  Write index for dwz file if
  75         needed.
  76         (save_gdb_index_command): Pass basename of dwz file, if present.
  77         * dwarf-index-cache.c (index_cache::store): Obtain and pass
  78         build-id of dwz file, if present.
  79         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
  80         (dwarf2_get_dwz_file): Likewise.
  81         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
  82         (dwarf2_get_dwz_file): Likewise.
  83
  84 2019-06-16  Tom Tromey  <tom@tromey.com>
  85
  86         * coffread.c (process_coff_symbol): Use xstrdup.
  87         * value.c (create_internalvar): Use xstrdup.
  88
  89 2019-06-16  Tom Tromey  <tom@tromey.com>
  90
  91         * valops.c (value_cast, value_slice): Remove unnecessary cast.
  92         * breakpoint.c (stopin_command, stopat_command)
  93         (until_break_command, decode_location_default): Remove unnecessary
  94         cast.
  95         * utils.c (subset_compare): Remove unnecessary cast.
  96         * ada-lang.c (ada_update_initial_language): Remove unnecessary
  97         cast.
  98         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
  99         cast.
 100         * infcmd.c (path_command): Remove unnecessary cast.
 101         * coffread.c (decode_type): Remove unnecessary cast.
 102         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 103         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 104         * tui/tui-stack.c (tui_show_locator_content)
 105         (tui_show_frame_info): Remove unnecessary cast.
 106         * tui/tui-win.c (tui_scroll_forward_command)
 107         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 108         (parse_scrolling_args): Remove unnecessary cast.
 109         * tui/tui-data.c (init_win_info, tui_del_window)
 110         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 111         (free_content_elements): Remove unnecessary cast.
 112         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 113         unnecessary cast.
 114         * tui/tui-source.c (tui_set_source_content)
 115         (tui_vertical_source_scroll): Remove unnecessary cast.
 116         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 117         cast.
 118         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 119         * tui/tui-regs.c (tui_display_registers_from)
 120         (tui_display_register): Remove unnecessary cast.
 121         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 122         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 123         (make_visible): Remove unnecessary cast.
 124         * tui/tui-winsource.c (tui_erase_source_content)
 125         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 126         unnecessary cast.
 127         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 128         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 129         * stabsread.c (read_type, read_array_type, read_range_type):
 130         Remove unnecessary cast.
 131         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 132         (parse_symbol, parse_type, upgrade_type, parse_external)
 133         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 134         unnecessary cast.
 135         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 136
 137 2019-06-16  Tom Tromey  <tom@tromey.com>
 138
 139         * tui/tui-data.c (tui_alloc_generic_win_info)
 140         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 141         checks.
 142
 143 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 144             Andrew Burgess  <andrew.burgess@embecosm.com>
 145
 146         * f-typeprint.c (f_print_type): Don't return early for not
 147         associated or not allocated types.
 148         (f_type_print_varspec_suffix): Add print_rank parameter and print
 149         ranks of array types in case they dangling.
 150         (f_type_print_base): Add print_rank parameter.
 151
 152 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 153
 154         * NEWS: Mention new MI commands.
 155         * break-catch-throw.c (enum exception_event_kind): Move to
 156         breakpoint.h.
 157         (print_mention_exception_catchpoint): Output text as a single
 158         message.
 159         (catch_exception_command_1): Rename to...
 160         (catch_exception_event): ...this, make non-static, update header
 161         command, and change some parameter types.
 162         (catch_catch_command): Update for changes to
 163         catch_exception_command_1.
 164         (catch_throw_command): Likewise.
 165         (catch_rethrow_command): Likewise.
 166         * breakpoint.c (enum exception_event_kind): Delete.
 167         * breakpoint.h (enum exception_event_kind): Moved here from
 168         break-catch-throw.c.
 169         (catch_exception_event): Declare.
 170         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 171         (mi_cmd_catch_throw): New function.
 172         (mi_cmd_catch_rethrow): New function.
 173         (mi_cmd_catch_catch): New function.
 174         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 175         'catch-catch' entries.
 176         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 177         (mi_cmd_catch_rethrow): Declare.
 178         (mi_cmd_catch_catch): Declare.
 179
 180 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 181
 182         * annotate.c (annotate_source_line): Change return type to void,
 183         update implementation to match.
 184         * annotate.h (annotate_source_line): Change return type to void,
 185         update header comment.
 186         * stack.c (print_frame_info): Don't change what frame information
 187         is printed based on whether annotations are on or not.
 188
 189 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 190
 191         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 192         (annotate_source): Make static.
 193         (annotate_source_line): Moved from source.c and renamed from
 194         identify_source_line.  Update the return type.
 195         * annotate.h (annotate_source): Delete declaration.
 196         (annotate_source_line): Declaration moved from source.h, and
 197         renamed from identify_source_line.  Return type updated.
 198         * source.c (identify_source_line): Moved to annotate.c and renamed
 199         to annotate_source_line.
 200         (info_line_command): Remove check of annotation_level.
 201         * source.h (identify_source_line): Move declaration to annotate.h
 202         and rename to annotate_source_line.
 203         * stack.c: Add 'annotate.h' include.
 204         (print_frame_info): Remove check of annotation_level before
 205         calling annotate_source_line.
 206
 207 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 208
 209         * source-cache.c (source_cache::get_plain_source_lines): Use
 210         open_source_file_with_line_charpos instead of just
 211         open_source_file, remove call to find_source_lines.
 212         (source_cache::get_source_lines): Likewise.
 213         * source.c (find_source_lines): Make static.
 214         (get_filename_and_charpos): Renamed into...
 215         (open_source_file_with_line_charpos): ..this along with changes to
 216         return a scoped_fd, and some other minor clean ups.
 217         (identify_source_line): Use open_source_file_with_line_charpos.
 218         (search_command_helper): Use open_source_file_with_line_charpos
 219         instead of just open_source_file, remove call to
 220         find_source_lines.
 221         * source.h (open_source_file_with_line_charpos): Declare new
 222         function.
 223         (find_source_lines): Delete declaration.
 224
 225 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 226
 227         * source.c (get_filename_and_charpos): Remove fullname
 228         parameter.
 229         (identify_source_line): Update call to get_filename_and_charpos.
 230
 231 2019-06-14  Tom Tromey  <tromey@adacore.com>
 232
 233         PR gdb/24502:
 234         * ui-style.h (skip_ansi_escape): Update comment.
 235         * ui-file.h (class no_terminal_escape_file): New class.
 236         * ui-file.c (no_terminal_escape_file::write)
 237         (no_terminal_escape_file::puts): New methods.
 238         * cli/cli-logging.c (handle_redirections): Use
 239         no_terminal_escape_file.
 240
 241 2019-06-14  Tom Tromey  <tromey@adacore.com>
 242
 243         * NEWS: Move convenience variable news above Python news.
 244
 245 2019-06-14  Tom Tromey  <tom@tromey.com>
 246
 247         * gnulib: Move directory to top-level.
 248         * configure.ac: Don't configure gnulib.
 249         * configure: Rebuild.
 250         * common/common-defs.h: Use new path to gnulib.
 251         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 252         (GNULIB_H): Remove.
 253         (INCGNU): Look in new gnulib location.
 254         (HFILES_NO_SRCDIR): Remove gnulib files.
 255         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 256         (generated_files): Remove GNULIB_H.
 257         ($(LIBGNU), all-lib): Remove targets.
 258         (distclean): Don't mention GNULIB_BUILDDIR.
 259         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 260
 261 2019-06-14  Tom Tromey  <tromey@adacore.com>
 262
 263         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 264         Warn if symbol file does not provide any symbols.
 265
 266 2019-06-14  Tom Tromey  <tromey@adacore.com>
 267
 268         * source.c (find_and_open_source): Respect basenames_may_differ.
 269
 270 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 271
 272         * annotate.c (annotate_breakpoints_invalid): Make use of
 273         scoped_restore_terminal_state.
 274         (annotate_frames_invalid): Likewise.
 275
 276 2019-06-14  Tom Tromey  <tromey@adacore.com>
 277
 278         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 279         allow assignment to an internalvar.
 280
 281 2019-06-14  Tom Tromey  <tromey@adacore.com>
 282
 283         * ada-lex.l: Allow "_" in attribute names.
 284
 285 2019-06-14  Tom Tromey  <tromey@adacore.com>
 286
 287         PR gdb/24653:
 288         * regcache.c (registers_changed): Don't call alloca.
 289         * top.c (execute_command): Don't call alloca.
 290
 291 2019-06-13  Pedro Alves  <palves@redhat.com>
 292
 293         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 294         'expression'.  When parsing an expression, error out if there's
 295         junk after "unlimited".
 296         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 297         (do_set_command): Adjust calls to is_unlimited_literal.
 298
 299 2019-06-13  Pedro Alves  <palves@redhat.com>
 300
 301         * compile/compile.c (make_compile_options_def_group): Add braces
 302         around array_view initializer.
 303         * thread.c (make_thread_apply_all_options_def_group)
 304         (make_thread_apply_all_options_def_group): Likewise.
 305
 306 2019-06-13  Pedro Alves  <palves@redhat.com>
 307
 308         * NEWS (New commands): Mention "maint test-options
 309         require-delimiter", "maint test-options unknown-is-error", "maint
 310         test-options unknown-is-operand" and "maint show
 311         test-options-completion-result".
 312         (New command options, command completion): New section.
 313         (Completion improvements): New section.
 314         Mention that you can abbreviate "unlimited".
 315
 316 2019-06-13  Pedro Alves  <palves@redhat.com>
 317
 318         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 319         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 320         * unittests/cli-utils-selftests.c (test_parse_flags)
 321         (test_parse_flags_qcs): Delete.
 322         (test_cli_utils): Don't call deleted functions.
 323
 324 2019-06-13  Pedro Alves  <palves@redhat.com>
 325
 326         * thread.c: Include "cli/cli-option.h".
 327         (tp_array_compar_ascending): Global.
 328         (tp_array_compar): Delete function.
 329         (tp_array_compar_ascending, tp_array_compar_descending): New
 330         functions.
 331         (ascending_option_def, qcs_flag_option_def)
 332         (thr_qcs_flags_option_defs)
 333         (make_thread_apply_all_options_def_group)
 334         (make_thread_apply_options_def_group): New.
 335         (thread_apply_all_command): Use gdb::option::process_options.
 336         (thread_apply_command_completer)
 337         (thread_apply_all_command_completer): New.
 338         (thread_apply_command): Use gdb::option::process_options.
 339         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 340         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 341         to generate help text of "thread apply".  Adjust "taas"'s help.
 342         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 343         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 344
 345 2019-06-13  Pedro Alves  <palves@redhat.com>
 346
 347         * thread.c (thread_apply_command): Check for invalid TID with
 348         isdigit instead of !isalpha.
 349
 350 2019-06-13  Pedro Alves  <palves@redhat.com>
 351
 352         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 353         (validate_flags_qcs): New.
 354         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 355         (validate_flags_qcs): Declare.
 356         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 357         (make_frame_apply_options_def_group): New.
 358         (frame_apply_command_count): Process options with
 359         gdb::option::process_options.
 360         (frame_apply_completer): New.
 361         (frame_apply_level_completer, frame_apply_all_completer)
 362         (frame_apply_completer): New.
 363         (_initialize_stack): Update help of "frame apply", "frame apply
 364         level", "frame apply all" and "faas" to mention supported options
 365         and install command completers.
 366         * stack.h (frame_apply_all_completer): Declare.
 367         * thread.c: Include "stack.h".
 368         (tfaas_command): Add "--".
 369         (_initialize_thread): Update help "tfaas" to mention supported
 370         options and install command completer.
 371
 372 2019-06-13  Pedro Alves  <palves@redhat.com>
 373
 374         * completer.c (complete_nested_command_line): New.
 375         (gdb_completion_word_break_characters_throw): Add assertion.
 376         * completer.h (complete_nested_command_line): Declare.
 377
 378 2019-06-13  Pedro Alves  <palves@redhat.com>
 379
 380         * stack.c (parse_backtrace_qualifiers): New.
 381         (backtrace_command): Use it.
 382         (backtrace_command_completer): Complete on qualifiers.
 383
 384 2019-06-13  Pedro Alves  <palves@redhat.com>
 385
 386         * frame.c: Include "cli/cli-option.h.
 387         (user_set_backtrace_options): New.
 388         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 389         Delete.
 390         (get_prev_frame): Adjust.
 391         (boolean_option_def, uinteger_option_def)
 392         (set_backtrace_option_defs): New.
 393         (_initialize_frame): Adjust and use
 394         gdb::option::add_setshow_cmds_for_options to install "set
 395         backtrace past-main" and "set backtrace past-entry".
 396         * frame.h: Include "cli/cli-option.h".
 397         (struct frame_print_options): Forward declare.
 398         (print_frame_arguments_all, print_frame_arguments_scalars)
 399         (print_frame_arguments_none): Declare.
 400         (print_entry_values): Delete declaration.
 401         (struct frame_print_options, user_frame_print_options): New.
 402         (struct set_backtrace_options): New.
 403         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 404         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 405         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 406         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 407         (list_args_or_locals): Add frame_print_options parameter.
 408         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 409         * python/py-framefilter.c (enumerate_args): Pass down
 410         USER_FRAME_PRINT_OPTIONS.
 411         * stack.c: Include "cli/cli-option.h".
 412         (print_frame_arguments_all, print_frame_arguments_scalars)
 413         (print_frame_arguments_none): Declare.
 414         (print_raw_frame_arguments, print_entry_values): Delete.
 415         (user_frame_print_options): New.
 416         (boolean_option_def, enum_option_def, frame_print_option_defs):
 417         New.
 418         (struct backtrace_cmd_options): New.
 419         (bt_flag_option_def): New.
 420         (backtrace_command_option_defs): New.
 421         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 422         (print_frame_arg, read_frame_arg, print_frame_args)
 423         (print_frame_info, print_frame): Add frame_print_options parameter
 424         and use it.
 425         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 426         (backtrace_command_1): Add frame_print_options and
 427         backtrace_cmd_options parameters and use them.
 428         (make_backtrace_options_def_group): New.
 429         (backtrace_command): Process command options with
 430         gdb::option::process_options.
 431         (backtrace_command_completer): New.
 432         (_initialize_stack): Extend "backtrace"'s help to mention
 433         supported options.  Install completer for "backtrace".
 434         Install some settings commands with add_setshow_cmds_for_options.
 435
 436 2019-06-13  Pedro Alves  <palves@redhat.com>
 437
 438         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 439         and that "set/show print raw frame-arguments" are now deprecated.
 440
 441         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 442         command.
 443         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 444         * stack.c (_initialize_stack): Install "set/show print
 445         raw-frame-arguments", and deprecate "set/show print raw
 446         frame-arguments".
 447         * valprint.c (_initialize_valprint): Deprecate "set/show print
 448         raw".
 449
 450 2019-06-13  Pedro Alves  <palves@redhat.com>
 451
 452         * compile/compile.c (struct compile_options): New.
 453         (compile_flag_option_def, compile_command_option_defs)
 454         (make_compile_options_def_group): New.
 455         (compile_file_command): Handle options with
 456         gdb::option::process_options.
 457         (compile_file_command_completer): New function.
 458         (compile_code_command): Handle options with
 459         gdb::option::process_options.
 460         (compile_code_command_completer): New function.
 461         (_initialize_compiler): Install completers for "compile code" and
 462         "compile file".  Mention available options in "compile code" and
 463         "compile code"'s help.
 464         * completer.c (advance_to_completion_word): New, factored out from
 465         ...
 466         (advance_to_expression_complete_word_point): ... this.
 467         (advance_to_filename_complete_word_point): New.
 468         * completer.h (advance_to_filename_complete_word_point): New
 469         declaration.
 470
 471 2019-06-13  Pedro Alves  <palves@redhat.com>
 472
 473         * compile/compile.c: Include "cli/cli-option.h".
 474         (compile_print_value): Scope data pointer is now a
 475         value_print_options pointer; adjust.
 476         (compile_print_command): Process options.  Scope data pointer is
 477         now a value_print_options pointer; adjust.
 478         (_initialize_compile): Update "compile print"'s help to include
 479         supported options.  Install a completer for "compile print".
 480         * cp-valprint.c (show_vtblprint, show_objectprint)
 481         (show_static_field_print): Delete.
 482         (_initialize_cp_valprint): Don't install "set print
 483         static-members", "set print vtbl", "set print object" here.
 484         * printcmd.c: Include "cli/cli-option.h" and
 485         "common/gdb_optional.h".
 486         (print_command_parse_format): Rework to fill in a
 487         value_print_options instead of a format_data.
 488         (print_value): Change parameter type from format_data pointer to
 489         value_print_options reference.  Adjust.
 490         (print_command_1): Process options.  Adjust to pass down a
 491         value_print_options.
 492         (print_command_completer): New.
 493         (_initialize_printcmd): Install print_command_completer as
 494         handle_brkchars completer for the "print" command.  Update
 495         "print"'s help to include supported options.
 496         * valprint.c: Include "cli/cli-option.h".
 497         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 498         here from cp-valprint.c.
 499         (boolean_option_def, uinteger_option_def)
 500         (value_print_option_defs, make_value_print_options_def_group):
 501         New.  Use gdb::option::add_setshow_cmds_for_options to install
 502         "set print elements", "set print null-stop", "set print repeats",
 503         "set print pretty", "set print union", "set print array", "set
 504         print address", "set print symbol", "set print array-indexes".
 505         * valprint.h: Include <string> and "cli/cli-option.h".
 506         (make_value_print_options_def_group): Declare.
 507         (print_value): Change parameter type from format_data pointer to
 508         value_print_options reference.
 509         (print_command_completer): Declare.
 510
 511 2019-06-13  Pedro Alves  <palves@redhat.com>
 512
 513         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 514         (COMMON_SFILES): Add maint-test-settings.c.
 515         * cli/cli-decode.c (boolean_enums): New global, factored out from
 516         ...
 517         (add_setshow_boolean_cmd): ... here.
 518         * cli/cli-decode.h (boolean_enums): Declare.
 519         * cli/cli-option.c: New file.
 520         * cli/cli-option.h: New file.
 521         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 522         factored out from ...
 523         (parse_cli_boolean_value(const char *)): ... this.
 524         (is_unlimited_literal): Change parameter type to pointer to
 525         pointer.  Adjust and advance ARG pointer.
 526         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 527         (parse_cli_var_enum): New, factored out from ...
 528         (do_set_command): ... this.  Adjust.
 529         * cli/cli-setshow.h (parse_cli_boolean_value)
 530         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 531         (parse_cli_var_enum): Declare.
 532         * cli/cli-utils.c: Include "cli/cli-option.h".
 533         (get_ulongest): New.
 534         * cli/cli-utils.h (get_ulongest): Declare.
 535         (check_for_argument): New overloads.
 536         * maint-test-options.c: New file.
 537
 538 2019-06-13  Pedro Alves  <palves@redhat.com>
 539
 540         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 541         parse a range if "-" is at the end of the string.
 542
 543 2019-06-13  Pedro Alves  <palves@redhat.com>
 544
 545         * cli/cli-setshow.c (parse_auto_binary_operation)
 546         (parse_cli_boolean_value): Don't allow "o".
 547
 548 2019-06-13  Pedro Alves  <palves@redhat.com>
 549
 550         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 551         * NEWS: Mention maint test-settings KIND.
 552         * maint-test-settings.c: New file.
 553
 554 2019-06-13  Pedro Alves  <palves@redhat.com>
 555
 556         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 557         completer.
 558         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 559         "set" completers.
 560
 561 2019-06-13  Pedro Alves  <palves@redhat.com>
 562
 563         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 564         after item.
 565
 566 2019-06-13  Pedro Alves  <palves@redhat.com>
 567
 568         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 569
 570 2019-06-13  Pedro Alves <palves@redhat.com>
 571
 572         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 573         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 574         call.
 575         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 576         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 577         calls.
 578         (check_for_argument): Skip spaces after argument.
 579
 580 2019-06-13  Pedro Alves  <palves@redhat.com>
 581
 582         * thread.c (thread_apply_command): Adjust TID parsing.
 583         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 584         detected before end of string.
 585         (tid_is_in_list): Error out if LIST is invalid.
 586
 587 2019-06-13  Pedro Alves  <palves@redhat.com>
 588
 589         * completer.c (complete_line_internal_1): Rewind completion word
 590         point.
 591         (completion_tracker::advance_custom_word_point_by): Change
 592         parameter type to int.
 593         * completer.h (completion_tracker::advance_custom_word_point_by):
 594         Likewise.
 595
 596 2019-06-13  Pedro Alves  <palves@redhat.com>
 597
 598         * completer.c (advance_to_completion_word): Handle delimiters.
 599
 600 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 601
 602         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 603
 604 2019-06-11  Tom Tromey  <tom@tromey.com>
 605
 606         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 607         (xmalloc_failed): Move to alloc.c.
 608         * alloc.c: New file.
 609         * Makefile.in (COMMON_SFILES): Add alloc.c.
 610
 611 2019-06-11  Tom Tromey  <tom@tromey.com>
 612
 613         * nat/linux-waitpid.c: Don't include server.h.
 614         (linux_debug): Remove.
 615         (my_waitpid): Update.
 616
 617 2019-06-11  Tom Tromey  <tromey@adacore.com>
 618
 619         * infcall.c (_initialize_infcall): Remove trailing newline from
 620         help.
 621         * user-regs.c (_initialize_user_regs): Remove trailing newline
 622         from help.
 623         * typeprint.c (_initialize_typeprint): Remove trailing newline
 624         from help.
 625         * reverse.c (_initialize_reverse): Remove trailing newlines from
 626         help.
 627         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 628         from help.
 629         * language.c (add_set_language_command): Remove trailing newline
 630         from help.
 631         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 632         help.
 633         * disasm.c (_initialize_disasm): Remove trailing newline from
 634         help.
 635         * top.c (init_main): Remove trailing newline from help.
 636         * interps.c (_initialize_interpreter): Remove trailing newline
 637         from help.
 638         * btrace.c (_initialize_btrace): Remove trailing newlines from
 639         help.
 640         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 641         from help.
 642         * python/python.c (_initialize_python): Remove trailing newline
 643         from help.
 644         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 645         help.
 646         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 647         from help.  Reformat some text.
 648         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 649         from help.
 650         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 651         newline from help.
 652
 653 2019-06-11  Tom Tromey  <tromey@adacore.com>
 654
 655         * darwin-nat.c (darwin_decode_exception_message)
 656         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 657
 658 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 659
 660         * valops.c (value_slice): Check for not allocated or not
 661         associated values.
 662
 663 2019-06-10  Tom de Vries  <tdevries@suse.de>
 664
 665         PR gdb/24618
 666         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 667         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 668         invalid.
 669
 670 2019-06-10  Tom de Vries  <tdevries@suse.de>
 671
 672         PR gdb/24611
 673         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 674         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 675
 676 2019-06-10  Tom de Vries  <tdevries@suse.de>
 677
 678         PR symtab/24545
 679         * symtab.c (struct demangled_name_entry): Add language field.
 680         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 681         static minimal symbol".  Set and use language field.
 682
 683 2019-06-10  Tom Tromey  <tromey@adacore.com>
 684
 685         * ada-lang.c (_initialize_ada_language): Update help text.
 686
 687 2019-06-10  Tom Tromey  <tromey@adacore.com>
 688
 689         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 690         with a newline.
 691         * guile/guile.c (handle_boot_error): Don't end warning with a
 692         newline.
 693         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 694         warning with a newline.
 695         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 696         newline.
 697         (s12z_frame_cache): Likewise.
 698         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 699         a newline.
 700         * solib-svr4.c (disable_probes_interface): Don't end warning with
 701         a newline.
 702         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 703         newline.
 704         * python/python.c (do_finish_initialization): Don't end warning
 705         with a newline.
 706
 707 2019-06-10  Tom Tromey  <tom@tromey.com>
 708
 709         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 710         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 711         gdbpy_enter.
 712
 713 2019-06-10  Tom Tromey  <tromey@adacore.com>
 714
 715         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 716         data.
 717         (elf_new_init): Don't call stabsread_new_init.
 718         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 719         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 720         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 721
 722 2019-06-10  Tom de Vries  <tdevries@suse.de>
 723
 724         PR symtab/16264
 725         PR symtab/24517
 726         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 727
 728 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 729
 730         * source.c (find_and_open_source): Also rewrite relative file
 731         names.
 732
 733 2019-04-26  Amos Bird  <amosbird@gmail.com>
 734
 735         * annotate.c (annotate_thread_exited): Add "thread-exited"
 736         annotation.
 737
 738 2019-06-06  Tom Tromey  <tromey@adacore.com>
 739
 740         * maint.h (class scoped_command_stats): Use
 741         DISABLE_COPY_AND_ASSIGN.
 742         <print_time>: New method.
 743         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 744         print_time.
 745         (scoped_command_stats::print_time): New method.
 746
 747 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 748
 749         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 750         instructions of lengths 6 or 8 bytes.
 751
 752 2019-06-04  Pedro Alves  <palves@redhat.com>
 753
 754         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 755
 756         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 757         * breakpoint.c (condition_completer): Likewise.
 758         * cli/cli-dump.c (scan_expression): Likewise.
 759         * common/filestuff.c (mkdir_recursive): Likewise.
 760         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 761         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 762         (gdb_abspath): Likewise.
 763         * compile/compile-cplus-types.c
 764         (compile_cplus_instance::decl_name): Likewise.
 765         * completer.c (complete_explicit_location):
 766         (signal_completer, reg_or_group_completer_1): Likewise.
 767         * cp-support.c (cp_remove_params_if_any): Likewise.
 768         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 769         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 770         * infcmd.c (strip_bg_char): Likewise.
 771         * linespec.c (copy_token_string): Likewise.
 772         * mi/mi-main.c (output_cores): Likewise.
 773         * psymtab.c (psymtab_search_name):
 774         * symfile.c (test_set_ext_lang_command): Likewise.
 775         * target.c (target_fileio_read_stralloc): Likewise.
 776         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 777         * value.c (complete_internalvar): Likewise.
 778
 779 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 780
 781         Add objfile property to gdb.Type.
 782         * NEWS: Mention Python API addition.
 783         * python/py-type.c (typy_get_objfile): New method.
 784
 785 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 786
 787         * NEWS: Mention the new set|show style [title|highlight].
 788         Mention changes to "show style", "help" and "apropos".
 789
 790 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 791
 792         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 793         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 794         instead of print_help_for_command.
 795         (print_doc_of_command): New function.
 796         (help_list): Add 'apropos -v word' suggestion.
 797         (print_help_for_command): Style the command name using title style.
 798         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 799         (_initialize_cli_cmds): Describe -v in apropos_command help.
 800
 801 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 802
 803         * cli/cli-style.h (cli_style_option): Add name in constructor,
 804         add m_name class member, add constructor with intensity,
 805         add name class function.
 806         (cli_style_option::add_setshow_commands): Remove name argument.
 807         (highlight_style, title_style): New styles.
 808         * cli/cli-style.c (do_show): New function that shows a style
 809         characteristic styling the style name with itself.
 810         (set_style_name): New function.
 811         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 812         Update all callers according to the changes in cli/cli-style.h.
 813         * utils.h (fputs_highlighted): New function.
 814         * utils.c (fputs_highlighted): Likewise.
 815
 816 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 817
 818         * NEWS: Mention new pipe command and new convenience variables.
 819
 820 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 821
 822         * cli/cli-cmds.c (pipe_command): New function.
 823         (_initialize_cli_cmds): Call add_com for pipe_command.
 824         Define | as an alias for pipe.
 825         (exit_status_set_internal_vars): New function.
 826         (shell_escape): Call exit_status_set_internal_vars.
 827         cli/cli-decode.c (find_command_name_length): Recognize | as
 828         a single character command.
 829
 830 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 831
 832         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 833         top.c (execute_command_to_ui_file): New function, mostly a copy
 834         of execute_command_to_string.
 835         (execute_command_to_string): Implement by calling
 836         execute_command_to_ui_file.
 837
 838 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 839
 840         * top.h (saved_command_line): Remove declaration.
 841         * top.c (previous_saved_command_line, previous_repeat_arguments):
 842         New variables.
 843         (saved_command_line): Make static, define together with other
 844         'repeat variables'.
 845         (dont_repeat): Clear repeat_arguments.
 846         (repeat_previous, get_saved_command_line, save_command_line):
 847         New functions.
 848         (gdb_init): Initialize saved_command_line
 849         and previous_saved_command_line.
 850         * main.c (captured_main_1): Remove saved_command_line initialization.
 851         * event-top.c (handle_line_of_input): Update to use
 852         the new 'repeat' related functions instead of direct access to
 853         saved_command_line.
 854         * command.h (repeat_previous, get_saved_command_line,
 855         save_command_line): New declarations.
 856         (dont_repeat): Add comment.
 857
 858 2019-05-30  Tom Tromey  <tromey@adacore.com>
 859
 860         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 861         Fix comment.
 862         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 863
 864 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 865
 866         PR cli/24587
 867         * completer.c (complete): Initialize variable word.
 868
 869 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 870
 871         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 872         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 873         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 874         'body' is NULL to the outter 'if', protecting the '!is_define'
 875         situation as well.
 876
 877 2019-05-29  Tom Tromey  <tromey@adacore.com>
 878
 879         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 880         (dwarf_unknown): New function.
 881         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 882         (dwarf_type_encoding_name): Use dwarf_unknown.
 883
 884 2019-05-29  Tom Tromey  <tromey@adacore.com>
 885
 886         PR c++/20020:
 887         * cp-valprint.c (cp_print_value_fields): Call
 888         cp_print_static_field inside "try".
 889
 890 2019-05-29  Tom Tromey  <tromey@adacore.com>
 891
 892         * inflow.c (struct terminal_info): Add default operator=.
 893         * configure: Rebuild.
 894         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 895         -Wdeprecated-copy-dtor, -Wredundant-move.
 896
 897 2019-05-29  Tom Tromey  <tromey@adacore.com>
 898
 899         * NEWS: Add entry.
 900         * infcmd.c (print_return_value_1): Handle finish_print
 901         option.
 902         (show_print_finish): New function.
 903         (_initialize_infcmd): Add "set/show print finish" commands.
 904         * valprint.c (user_print_options): Initialize new member.
 905         * valprint.h (struct value_print_options) <finish_print>: New
 906         member.
 907
 908 2019-05-28  Tom Tromey  <tromey@adacore.com>
 909
 910         * ada-lang.c (ada_remove_Xbn_suffix)
 911         (find_old_style_renaming_symbol)
 912         (parse_old_style_renaming): Remove.
 913         (ada_find_renaming_symbol): Don't call
 914         find_old_style_renaming_symbol.
 915         (ada_is_renaming_symbol): Rename from
 916         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 917         bool.  Now static.
 918         (ada_read_var_value): Update and simplify.
 919         * ada-exp.y (write_var_or_type): Remove old code.
 920
 921 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 922
 923         * event-top.c: Remove include comment.
 924         * inflow.c (class scoped_ignore_sigttou): Move from here...
 925         * inflow.h (class scoped_ignore_sigttou): ...to here.
 926         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 927         * top.c:  Remove include comment.
 928
 929 2019-05-27  Tom Tromey  <tom@tromey.com>
 930
 931         * NEWS: Fix typo.
 932
 933 2019-05-22  Tom Tromey  <tromey@adacore.com>
 934
 935         * target.c (target_follow_exec): Constify parameter.
 936         * target-delegates.c: Rebuild.
 937         * remote.c (remote_target::follow_exec): Constify parameter.
 938         * infrun.c (follow_exec): Constify parameter.
 939         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 940         (target_follow_exec): Likewise.
 941
 942 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 943
 944         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 945         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 946
 947 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 948
 949         * NEWS: Add debugredirect and testsuite sections.
 950
 951 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 952
 953         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 954         target descriptions using exclusively floating point register name
 955         aliases.
 956
 957 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 958
 959         PR gdb/18644:
 960         * f-lang.c (build_fortran_types): Handle the case where
 961         gdbarch_floatformat_for_type returns a nullptr.
 962
 963 2019-05-21  Tom de Vries  <tdevries@suse.de>
 964
 965         PR cli/24587
 966         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 967
 968 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 969
 970         PR gdb/18644:
 971         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 972         16-byte floats.
 973         * i386-tdep.c (i386_floatformat_for_type): Use
 974         floatformats_ia64_quad for the 16-byte floating point component
 975         within a fortran 32-byte complex number.
 976
 977 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 978
 979         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 980         delete default constructor.
 981         (find_partial_die): Update to return const struct.
 982         (partial_die_parent_scope): Move variable declaration into scope
 983         of its use and change its type to auto.
 984         (guess_partial_die_structure_name): Likewise.
 985         (partial_die_info::fixup): Likewise.
 986
 987 2019-05-17  Tom Tromey  <tromey@adacore.com>
 988
 989         * source.c (find_and_open_source): Remove cast.
 990
 991 2019-05-17  Tom Tromey  <tromey@adacore.com>
 992
 993         * annotate.c (annotate_source): Make "filename" const.
 994         * annotate.h (annotate_source): Use const.
 995
 996 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 997
 998         * disasm.c (set_disassembler_options): Send errors to stderr.
 999
1000 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1001
1002         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1003         (cli_interp_base::set_logging): Check debug_redirect.
1004         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1005         * cli/cli-logging.c (debug_redirect): Add static variable.
1006         (pop_output_files): Add default param.
1007         (handle_redirections): Print debug setting.
1008         (show_logging_command): Likewise.
1009         (_initialize_cli_logging): Add debugredirect command.
1010         * interps.c (current_interp_set_logging): Add debug_redirect
1011         parameter.
1012         * interps.h (set_logging): Add debug_redirect parameter.
1013         (current_interp_set_logging): Likewise.
1014         * mi/mi-common.h: Likewise.
1015         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1016
1017 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1018             Tom Tromey  <tromey@adacore.com>
1019
1020         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1021         directly.
1022         * cli/cli-interp.h (make_logging_output): Remove declaration.
1023         * cli/cli-logging.c (make_logging_output): Remove function.
1024         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1025         directly.
1026         * ui-file.c (tee_file::tee_file): Remove bools.
1027         (tee_file::~tee_file): Remove deletes.
1028         * ui-file.h (tee_file): Remove bools.
1029
1030 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1031
1032         * mi/mi-cmds.h (mi_cmd_complete): New function.
1033         * mi/mi-main.c (mi_cmd_complete): Likewise.
1034         * mi/mi-cmds.c: Define new MI command -complete.
1035         * NEWS: Mention new -complete command.
1036
1037 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1038
1039         * completer.h (complete): New function.
1040         * completer.c (complete): Likewise.
1041         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1042         function defined in completer.h.
1043
1044 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1045
1046         * MAINTAINERS (Write After Approval): Add myself.
1047
1048 2019-05-17  Tom de Vries  <tdevries@suse.de>
1049
1050         PR gdb/24094
1051         * dwarf2read.c (struct cu_partial_die_info): New struct.
1052         (find_partial_die): Return cu_partial_die_info.
1053         (partial_die_parent_scope, guess_partial_die_structure_name)
1054         (partial_die_info::fixup): Handle new return type of find_partial_die.
1055
1056 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1057
1058         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1059         "std::string", simplifying the algorithm.
1060
1061 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1062
1063         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1064         (stap_static_probe_ops::get_probes): Likewise.
1065
1066 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1067
1068         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1069         '-')" and "else if".
1070         (stap_parse_single_operand): Join checks for
1071         "gdbarch_stap_parse_special_token_p" and
1072         "gdbarch_stap_parse_special_token" in the same "if" statement.
1073         Invert check when verifying for operation on register
1074         displacement.
1075
1076 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1077
1078         * stap-probe.c (stap_get_opcode): Update comment.
1079         (stap_get_expected_argument_type): Likewise.
1080         (handle_stap_probe): Likewise.
1081
1082 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1083
1084         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1085         return type to 'bool'.  Adjust comment.  Use 'bool' when
1086         appropriate.
1087         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1088         * stap-probe.c (stap_parse_argument_1): Likewise.
1089         (stap_is_operator): Likewise.
1090         (stap_is_generic_prefix): Likewise.
1091         (stap_is_register_prefix): Likewise.
1092         (stap_is_register_indirection_prefix): Likewise.
1093         (stap_is_integer_prefix): Likewise.
1094         (stap_generic_check_suffix): Likewise.
1095         (stap_check_integer_suffix): Likewise.
1096         (stap_check_register_suffix): Likewise.
1097         (stap_check_register_indirection_suffix): Likewise.
1098         (stap_parse_register_operand): Likewise.
1099         (stap_parse_single_operand): Likewise.
1100         (stap_parse_argument_1): Likewise.
1101         (stap_probe::get_argument_count): Likewise.
1102         (stap_is_operator): Likewise.
1103
1104 2019-05-16  Tom Tromey  <tromey@adacore.com>
1105
1106         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1107         keyword to foreach.
1108
1109 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1110
1111         * linux-thread-db.c (try_thread_db_load_1): Change return type
1112         to bool.
1113         (try_thread_db_load): Likewise.
1114         (try_thread_db_load_from_pdir_1): Likewise.
1115         (try_thread_db_load_from_pdir): Likewise.
1116         (try_thread_db_load_from_sdir): Likewise.
1117         (try_thread_db_load_from_dir): Likewise.
1118         (thread_db_load_search): Likewise.
1119         (has_libpthread): Likewise.
1120         (thread_db_load): Likewise.
1121
1122 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1123
1124         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1125         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1126         NULL, and complain/return if that's the case.
1127
1128 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1129
1130         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1131         (advance, posn, abstract_read_memory): New functions.
1132         [struct mem_read_abstraction]: New struct.
1133         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1134
1135 2019-05-14  Tom Tromey  <tromey@adacore.com>
1136
1137         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1138         value is not lval_memory.
1139
1140 2019-05-14  Tom Tromey  <tromey@adacore.com>
1141
1142         * solib.c (info_sharedlibrary_command): Style the file name.
1143
1144 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1145
1146         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1147         (aarch64_vnv_type): Likewise.
1148         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1149         * common/tdesc.c: Likewise.
1150         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1151         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1152         * features/aarch64-fpu.xml: Add ieee half view.
1153         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1154         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1155         * gdbtypes.h (struct builtin_type): Likewise.
1156         (struct objfile_type): Likewise.
1157
1158 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1159
1160         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1161         typo.
1162         * location.h (string_to_event_location): Likewise.
1163
1164 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1165
1166         GDB 8.3 released.
1167
1168 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1169
1170         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1171         New variable declaration.
1172         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1173         New variable.
1174         (print_one_breakpoint): Use ui_out::test_flags and new global
1175         variable to compute use_fixed_output.
1176         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1177         Remove.
1178         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1179         (mi_multi_location_breakpoint_output_fixed): Remove.
1180         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1181         new variable.
1182         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1183         fix_multi_location_breakpoint_output flag if version >= 3.
1184         * ui-out.h (enum ui_out_flag)
1185         <fix_multi_location_breakpoint_output>: New enumerator.
1186
1187 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1188
1189         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1190
1191 2019-05-10  Tom Tromey  <tromey@adacore.com>
1192
1193         * ada-lang.c (catch_ada_completer): New function.
1194         (_initialize_ada_language): Use it.
1195
1196 2019-05-10  Tom Tromey  <tromey@adacore.com>
1197
1198         * thread.c (print_thread_info): Make "requested_threads" const.
1199         * gdbthread.h (print_thread_info): Make "requested_threads"
1200         const.
1201         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1202         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1203
1204 2019-05-08  Tom Tromey  <tom@tromey.com>
1205
1206         * gdbtypes.c (objfile_type_data): Change type.
1207         (objfile_type, _initialize_gdbtypes): Update.
1208
1209 2019-05-08  Tom Tromey  <tom@tromey.com>
1210
1211         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1212         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1213         (_initialize_dwarf2_frame): Update.
1214
1215 2019-05-08  Tom Tromey  <tom@tromey.com>
1216
1217         * objc-lang.c (objc_objfile_data): Change type.
1218         (find_methods): Update.
1219         (_initialize_objc_lang): Remove.
1220
1221 2019-05-08  Tom Tromey  <tom@tromey.com>
1222
1223         * stabsread.c (rs6000_builtin_type_data): Change type.
1224         (rs6000_builtin_type, _initialize_stabsread): Update.
1225
1226 2019-05-08  Tom Tromey  <tom@tromey.com>
1227
1228         * mips-tdep.c (mips_pdr_data): Remove.
1229         (_initialize_mips_tdep): Update.
1230
1231 2019-05-08  Tom Tromey  <tom@tromey.com>
1232
1233         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1234         (hppa_init_objfile_priv_data, read_unwind_info)
1235         (find_unwind_entry, _initialize_hppa_tdep): Update.
1236
1237 2019-05-08  Tom Tromey  <tom@tromey.com>
1238
1239         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1240         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1241         on obstack.
1242         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1243
1244 2019-05-08  Tom Tromey  <tom@tromey.com>
1245
1246         * mdebugread.c (basic_type_data): Change type.
1247         (basic_type, _initialize_mdebugread): Update.
1248
1249 2019-05-08  Tom Tromey  <tom@tromey.com>
1250
1251         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1252
1253 2019-05-08  Tom Tromey  <tom@tromey.com>
1254
1255         * nto-tdep.c (nto_inferior_data_reg): Change type.
1256         (nto_inferior_data): Update.
1257         (nto_inferior_data_cleanup, nto_new_inferior_data)
1258         (_initialize_nto_tdep): Remove.
1259         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1260
1261 2019-05-08  Tom Tromey  <tom@tromey.com>
1262
1263         * ada-lang.c (struct ada_inferior_data): Add initializers.
1264         (ada_inferior_data): Change type.
1265         (ada_inferior_data_cleanup): Remove.
1266         (get_ada_inferior_data, ada_inferior_exit)
1267         (struct ada_pspace_data): Add initializers, destructor.
1268         (ada_pspace_data_handle): Change type.
1269         (get_ada_pspace_data): Update.
1270         (ada_pspace_data_cleanup): Remove.
1271
1272 2019-05-08  Tom Tromey  <tom@tromey.com>
1273
1274         * coffread.c (struct coff_symfile_info): Add initializers.
1275         (coff_objfile_data_key): Move lower.  Change type.
1276         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1277         Update.
1278         (coff_free_info): Remove.
1279
1280 2019-05-08  Tom Tromey  <tom@tromey.com>
1281
1282         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1283         (fbsd_pspace_data_handle): Move lower.  Change type.
1284         (get_fbsd_pspace_data): Update.
1285         (fbsd_pspace_data_cleanup): Remove.
1286         (_initialize_fbsd_tdep): Update.
1287
1288 2019-05-08  Tom Tromey  <tom@tromey.com>
1289
1290         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1291         (get_ada_tasks_pspace_data): Update.
1292         (ada_tasks_pspace_data_cleanup): Remove.
1293         (_initialize_tasks): Update.
1294         (ada_tasks_inferior_data_handle): Change type.
1295         (get_ada_tasks_inferior_data): Update.
1296         (ada_tasks_inferior_data_cleanup): Remove.
1297         (struct ada_tasks_pspace_data): Add initializers.
1298
1299 2019-05-08  Tom Tromey  <tom@tromey.com>
1300
1301         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1302         * symfile-debug.c (debug_sym_get_probes): Change type.
1303         * stap-probe.c (handle_stap_probe):
1304         (stap_static_probe_ops::get_probes): Change type.
1305         * probe.h (class static_probe_ops) <get_probes>: Change type.
1306         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1307         (parse_probes_in_pspace): Update.
1308         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1309         Update.
1310         (any_static_probe_ops::get_probes): Change type.
1311         * elfread.c (elfread_data): New typedef.
1312         (probe_key): Change type.
1313         (elf_get_probes): Likewise.  Update.
1314         (probe_key_free): Remove.
1315         (_initialize_elfread): Update.
1316         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1317         Change type.
1318         (dtrace_process_dof_probe, dtrace_process_dof)
1319         (dtrace_static_probe_ops::get_probe): Change type.
1320
1321 2019-05-08  Tom Tromey  <tom@tromey.com>
1322
1323         * xcoffread.c (struct xcoff_symfile_info): Rename from
1324         coff_symfile_info.  Add initializers.
1325         (xcoff_objfile_data_key): Move lower.  Change type.
1326         (XCOFF_DATA): Rewrite.
1327         (xcoff_free_info): Remove.
1328         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1329         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1330         (xcoff_initial_scan): Update.
1331
1332 2019-05-08  Tom Tromey  <tom@tromey.com>
1333
1334         * solib-svr4.c (struct svr4_info): Add initializers and
1335         destructor.
1336         <probes_table>: Now an htab_up.
1337         (solib_svr4_pspace_data): Change type.
1338         (free_probes_table): Simplify.
1339         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1340         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1341         (probes_table_remove_objfile_probes, register_solib_event_probe)
1342         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1343         (_initialize_svr4_solib): Update.
1344
1345 2019-05-08  Tom Tromey  <tom@tromey.com>
1346
1347         * remote.c (remote_pspace_data): Change type.
1348         (remote_pspace_data_cleanup): Remove.
1349         (get_remote_exec_file, set_pspace_remote_exec_file)
1350         (_initialize_remote): Update.
1351
1352 2019-05-08  Tom Tromey  <tom@tromey.com>
1353
1354         * breakpoint.c (breakpoint_objfile_key): Change type.
1355         (get_breakpoint_objfile_data): Update.
1356         (free_breakpoint_objfile_data): Remove.
1357         (_initialize_breakpoint): Update.
1358
1359 2019-05-08  Tom Tromey  <tom@tromey.com>
1360
1361         * linux-tdep.c (struct linux_info): Add initializers.
1362         (linux_inferior_data): Move.  Change type.
1363         (invalidate_linux_cache_inf): Update.
1364         (linux_inferior_data_cleanup): Remove.
1365         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1366
1367 2019-05-08  Tom Tromey  <tom@tromey.com>
1368
1369         * auxv.c (auxv_inferior_data): Move.  Change type.
1370         (auxv_inferior_data_cleanup): Remove.
1371         (invalidate_auxv_cache_inf): Rewrite.
1372         (get_auxv_inferior_data, _initialize_auxv): Update.
1373
1374 2019-05-08  Tom Tromey  <tom@tromey.com>
1375
1376         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1377         (symfile_debug_objfile_data_key): Change type.
1378         (symfile_debug_installed, debug_qf_has_symbols)
1379         (debug_qf_find_last_source_symtab)
1380         (debug_qf_forget_cached_source_info)
1381         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1382         (debug_qf_print_stats, debug_qf_dump)
1383         (debug_qf_expand_symtabs_for_function)
1384         (debug_qf_expand_all_symtabs)
1385         (debug_qf_expand_symtabs_with_fullname)
1386         (debug_qf_map_matching_symbols)
1387         (debug_qf_expand_symtabs_matching)
1388         (debug_qf_find_pc_sect_compunit_symtab)
1389         (debug_qf_map_symbol_filenames)
1390         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1391         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1392         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1393         (debug_sym_read_linetable, debug_sym_relocate): Update.
1394         (symfile_debug_free_objfile): Remove.
1395         (install_symfile_debug_logging, _initialize_symfile_debug):
1396         Update.
1397
1398 2019-05-08  Tom Tromey  <tom@tromey.com>
1399
1400         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1401         allocate_on_obstack.
1402         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1403         (get_dwarf2_per_objfile): Update.
1404         (set_dwarf2_per_objfile): Remove.
1405         (dwarf2_has_info, dwarf2_get_section_info): Update.
1406         (dwarf2_free_objfile): Remove.
1407         (_initialize_dwarf2_read): Update.
1408
1409 2019-05-08  Tom Tromey  <tom@tromey.com>
1410
1411         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1412         initializers.
1413         <unsupported_script_warning_printed,
1414         script_not_found_warning_printed>: Now bool.
1415         (auto_load_pspace_data): Change type.
1416         (~auto_load_pspace_info): Rename from
1417         auto_load_pspace_data_cleanup.
1418         (get_auto_load_pspace_data, init_loaded_scripts_info)
1419         (clear_section_scripts, maybe_print_unsupported_script_warning)
1420         (maybe_print_script_not_found_warning, _initialize_auto_load):
1421         Update.
1422
1423 2019-05-08  Tom Tromey  <tom@tromey.com>
1424
1425         * objfiles.c (objfile_pspace_info): Add destructor and
1426         initializers.
1427         (objfiles_pspace_data): Change type.
1428         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1429         (get_objfile_pspace_data): Update.
1430         (objfiles_bfd_data): Change type.
1431         (get_objfile_bfd_data): Update.
1432         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1433
1434 2019-05-08  Tom Tromey  <tom@tromey.com>
1435
1436         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1437         Change type.
1438         (get_catch_syscall_inferior_data): Update.
1439         (catch_syscall_inferior_data_cleanup): Remove.
1440         (_initialize_break_catch_syscall): Update.
1441
1442 2019-05-08  Tom Tromey  <tom@tromey.com>
1443
1444         * inflow.c (struct terminal_info): Add destructor and
1445         initializers.
1446         (inflow_inferior_data): Change type.
1447         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1448         (get_inflow_inferior_data, inflow_inferior_exit)
1449         (swap_terminal_info, _initialize_inflow): Update.
1450
1451 2019-05-08  Tom Tromey  <tom@tromey.com>
1452
1453         * target-dcache.c (target_dcache_cleanup): Remove.
1454         (target_dcache_aspace_key): Change type.
1455         (target_dcache_init_p, target_dcache_invalidate)
1456         (target_dcache_get, target_dcache_get_or_init)
1457         (_initialize_target_dcache): Update.
1458         * dcache.h (struct dcache_deleter): New.
1459
1460 2019-05-08  Tom Tromey  <tom@tromey.com>
1461
1462         * symtab.c (struct symbol_cache): Add destructor and
1463         initializers.
1464         (symbol_cache_key): Move.  Change type.
1465         (make_symbol_cache, free_symbol_cache): Remove.
1466         (get_symbol_cache): Update.
1467         (symbol_cache_cleanup): Remove.
1468         (ALL_PSPACES, symbol_cache_flush)
1469         (maintenance_print_symbol_cache)
1470         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1471         Update.
1472
1473 2019-05-08  Tom Tromey  <tom@tromey.com>
1474
1475         * symtab.c (struct main_info): Add destructor and initializers.
1476         (main_progspace_key): Move.  Change type.
1477         (get_main_info): Update.
1478         (main_info_cleanup): Remove.
1479         (_initialize_symtab): Update.
1480
1481 2019-05-08  Tom Tromey  <tom@tromey.com>
1482
1483         * registry.h (DECLARE_REGISTRY): Define the _key class.
1484
1485 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1486
1487         * NEWS: Merge two 'New commands' sections.
1488
1489 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1490
1491         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1492         parameter and use Ada language definition instead.
1493         (ada_val_print_ptr): Remove unused language parameter.
1494         (ada_val_print_num): Remove language parameter and use Ada language
1495         definition instead.
1496         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1497         parameter.
1498         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1499         parameter and use Ada language definition instead.
1500         (ada_val_print_1): Update all ada_val_print_xxx calls.
1501         Remove language parameter.
1502         (ada_val_print): Update ada_val_print_1 call.
1503
1504 2019-05-08  Tom Tromey  <tromey@adacore.com>
1505
1506         * remote.c (remote_hw_watchpoint_limit)
1507         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1508         Now static.
1509
1510 2019-05-08  Tom Tromey  <tromey@adacore.com>
1511
1512         * maint.c (_initialize_maint_cmds): Move initialization code to
1513         remote.c.
1514         (watchdog, show_watchdog): Move to remote.c.
1515         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1516         "watchdog" static.
1517         (_initialize_remote): Move initialization code from maint.c.
1518         * defs.h (watchdog): Don't declare.
1519
1520 2019-05-08  Tom Tromey  <tromey@adacore.com>
1521
1522         * tui/tui-interp.c: Include main.h.
1523         * interps.c: Include main.h.
1524         * main.h (interpreter_p): Declare.
1525         * defs.h (interpreter_p): Don't declare.
1526
1527 2019-05-08  Tom Tromey  <tromey@adacore.com>
1528
1529         * dwarf2loc.c: Include dwarf2read.h.
1530         * defs.h (read_unsigned_leb128): Don't declare.
1531         * dwarf2read.h (read_unsigned_leb128): Declare.
1532
1533 2019-05-08  Tom Tromey  <tromey@adacore.com>
1534
1535         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1536         method.
1537
1538 2019-05-08  Tom Tromey  <tromey@adacore.com>
1539
1540         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1541         when no wrap column is set.
1542
1543 2019-05-08  Tom Tromey  <tromey@adacore.com>
1544
1545         * c-lang.c (c_get_string): Handle non-C-style arrays.
1546
1547 2019-05-08  Tom Tromey  <tromey@adacore.com>
1548
1549         * typeprint.c (print_offset_data::update): Print the bit offset,
1550         not the number of bits remaining.
1551
1552 2019-05-08  Tom Tromey  <tromey@adacore.com>
1553
1554         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1555         padding at end of comment.
1556
1557 2019-05-08  Tom Tromey  <tromey@adacore.com>
1558
1559         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1560         Compare main types.
1561
1562 2019-05-06  Tom Tromey  <tom@tromey.com>
1563
1564         * common/scoped_mmap.c: Include common-defs.h.
1565         * common/scoped_mmap.h: Don't include config.h.
1566
1567 2019-05-04  Tom Tromey  <tom@tromey.com>
1568
1569         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1570         (struct aarch64_call_info): Add initializers.
1571         <si>: Now a std::vector.
1572         (pass_on_stack, aarch64_push_dummy_call): Update.
1573
1574 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1575             Tom Tromey  <tom@tromey.com>
1576
1577         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1578         (ppc_threads): Now a std::vector.  Now static.
1579         (hwdebug_find_thread_points_by_tid)
1580         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1581         Update.
1582
1583 2019-05-04  Tom Tromey  <tom@tromey.com>
1584
1585         * arc-tdep.c (arc_tdesc_init): Return bool.
1586
1587 2019-05-04  Tom Tromey  <tom@tromey.com>
1588
1589         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1590         Use gdb_assert_not_reached.
1591
1592 2019-05-04  Tom Tromey  <tom@tromey.com>
1593
1594         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1595         "false".
1596
1597 2019-05-04  Tom Tromey  <tom@tromey.com>
1598
1599         * arc-tdep.c (arc_tdesc_init): Use bool.
1600
1601 2019-05-04  Tom Tromey  <tom@tromey.com>
1602
1603         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1604
1605 2019-05-04  Tom Tromey  <tom@tromey.com>
1606
1607         * cli/cli-cmds.c (valid_command_p): Return bool.
1608
1609 2019-05-04  Tom Tromey  <tom@tromey.com>
1610
1611         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1612         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1613
1614 2019-05-04  Raul Tambre  <raul@tambre.ee>
1615
1616         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1617         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1618         operator for comparison.
1619
1620 2019-05-04  Tom Tromey  <tom@tromey.com>
1621
1622         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1623         (lookup_partial_symbol, print_partial_symbols)
1624         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1625         (psymbol_compare): Update.
1626         (add_psymbol_to_bcache): Clear the entire psymbol.
1627         (maintenance_check_psymtabs): Update.
1628         * psympriv.h (struct partial_symbol): Don't derive from
1629         general_symbol_info.
1630         <obj_section, unrelocated_address, address,
1631         set_unrelocated_address>: Update.
1632         <ginfo>: New member.
1633         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1634         (debug_names::write_psymbols): Update.
1635
1636 2019-05-04  Tom de Vries  <tdevries@suse.de>
1637
1638         * contrib/cc-with-tweaks.sh: Support -n arg.
1639
1640 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1641
1642         * corelow.c (core_target::detach): Ensure frame cache and
1643         register caches are cleared.
1644         inferior.c (exit_inferior_1): Likewise.
1645
1646 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1647             Tom Tromey  <tom@tromey.com>
1648
1649         * dictionary.c (collate_pending_symbols_by_language): Remove
1650         "struct" from foreach.
1651         * symtab.c (lookup_global_symbol_from_objfile)
1652         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1653         foreach.
1654         * ser-tcp.c (net_open): Remove "struct" from foreach.
1655         * objfiles.c (objfile_relocate, objfile_rebase)
1656         (objfile_has_symbols): Remove "struct" from foreach.
1657         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1658         from foreach.
1659         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1660         foreach.
1661         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1662         "struct" from foreach.
1663         * ada-lang.c (create_excep_cond_exprs)
1664         (ada_exception_catchpoint_cond_string): Remove "struct" from
1665         foreach.
1666
1667 2019-05-03  Tom Tromey  <tromey@adacore.com>
1668
1669         * ada-exp.y (convert_char_literal): Check suffix of each
1670         enumerator.
1671
1672 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1673
1674         PR ada/21406:
1675         * ada-exp.y (yywrap): Don't define.
1676         * ada-lex.l (%option): Add noyywrap
1677         (yywrap): Remove.
1678
1679 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1680
1681         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1682         _WIN32_WINNT to the XP level, unless already defined to a higher
1683         level.
1684
1685         * unittests/parse-connection-spec-selftests.c:
1686         * ser-tcp.c:
1687         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1688         override.
1689
1690         * symfile.c (find_separate_debug_file): Remove colon from the
1691         drive spec of DOS/Windows file names of the target, so that the
1692         file name produced from DEBUGDIR and the target's directory will
1693         be valid on DOS/Windows systems.
1694
1695 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1696
1697         * rust-lang.c (val_print_struct): Handle printing structures
1698         containing strings.
1699
1700 2019-05-02  Tom Tromey  <tromey@adacore.com>
1701
1702         * valarith.c (_initialize_valarith): Remove.
1703
1704 2019-05-01  Tom Tromey  <tromey@adacore.com>
1705
1706         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1707         bitfields.
1708
1709 2019-05-01  Tom Tromey  <tromey@adacore.com>
1710
1711         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1712         for big-endian copies.
1713
1714 2019-04-30  Ali Tamur  <tamur@google.com>
1715         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1716         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1717         (read_3_bytes): New function.
1718
1719 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1720
1721         * windows-nat.c (main_thread_id): Delete.
1722         (handle_output_debug_string): Replace main_thread_id by
1723         current_event.dwThreadId.
1724         (fake_create_process): Likewise.
1725         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1726         Do not set main_thread_id.
1727         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1728         current_event.dwThreadId.
1729         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1730
1731 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1732
1733         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1734         Use current_event.dwThreadId instead of main_thread_id.
1735
1736 2019-04-30  Tom Tromey  <tromey@adacore.com>
1737
1738         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1739         (create_excep_cond_exprs): Iterate over program spaces.
1740         (ada_exception_catchpoint_cond_string): Examine all minimal
1741         symbols for exception types.
1742
1743 2019-04-30  Tom Tromey  <tromey@adacore.com>
1744
1745         PR c++/24470:
1746         * dwarf2read.c (process_structure_scope): Handle case where type
1747         has template parameters but no symbol was created.
1748
1749 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1750             Chris January  <chris.january@arm.com>
1751
1752         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1753         qualifier.
1754         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1755
1756 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1757
1758         * f-typeprint.c (f_print_type): Update rules for printing
1759         whitespace.
1760         (f_type_print_varspec_suffix): Likewise.
1761
1762 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1763             Chris January  <chris.january@arm.com>
1764
1765         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1766         function arguments.
1767
1768 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1769
1770         * f-lang.c (build_fortran_types): Change name of void type to
1771         lower case.
1772         * f-typeprint.c (f_type_print_base): Print the name of the void
1773         type, rather than a fixed string.
1774         * f-valprint.c (f_decorations): Use lower case void string.
1775
1776 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1777             Chris January  <chris.january@arm.com>
1778
1779         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1780         types for Fortran.
1781
1782 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1783             Chris January  <chris.january@arm.com>
1784             David Lecomber  <david.lecomber@arm.com>
1785
1786         * f-exp.y (BINOP_INTRINSIC): New token.
1787         (exp): New parser rule handling BINOP_INTRINSIC.
1788         (f77_keywords): Add new builtin procedures.
1789         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1790         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1791         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1792         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1793         (print_unop_subexp_f): New function.
1794         (print_binop_subexp_f): New function.
1795         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1796         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1797         (dump_subexp_body_f): Likewise.
1798         (operator_check_f): Likewise.
1799         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1800         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1801
1802 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1803
1804         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1805         UNOP_KIND.
1806         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1807         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1808         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1809         (operator_length_f): New fuction.
1810         (print_subexp_f): New function.
1811         (op_name_f): New function.
1812         (dump_subexp_body_f): New function.
1813         (operator_check_f): New function.
1814         (exp_descriptor_f): Replace standard expression handling functions
1815         with new functions.
1816         * gdb/fortran-operator.def: New file.
1817         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1818         * gdb/std-operator.def: Remove UNOP_KIND.
1819
1820 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1821
1822         * std-operator.def: Remove unbalanced, stray double quote
1823         character.
1824
1825 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1826             Chris January  <chris.january@arm.com>
1827             Daniel Everett  <daniel.everett@arm.com>
1828             Nick Forrington  <nick.forrington@arm.com>
1829             Richard Bunt  <richard.bunt@arm.com>
1830
1831         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1832         of depth when printing anonymous structs or unions.
1833         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1834         Don't print either the top-level value, or the children if the
1835         max-depth is exceeded.
1836         (ppscm_print_children): When printing the key of a map, allow one
1837         extra level of depth.
1838         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1839         print either the top-level value, or the children if the max-depth
1840         is exceeded.
1841         (print_children): When printing the key of a map, allow one extra
1842         level of depth.
1843         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1844         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1845         (user_print_options): Initialise max_depth field.
1846         (val_print_scalar_or_string_type_p): New function.
1847         (val_print): Check to see if the max depth has been reached.
1848         (val_print_check_max_depth): Define new function.
1849         (show_print_max_depth): New function.
1850         (_initialize_valprint): Add 'print max-depth' option.
1851         * valprint.h (struct value_print_options) <max_depth>: New field.
1852         (val_print_check_max_depth): Declare new function.
1853         * NEWS: Document new feature.
1854
1855 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1856
1857         * ada-lang.c (ada_language_defn): Initialise new field.
1858         * c-lang.c (c_is_string_type_p): New function.
1859         (c_language_defn): Initialise new field.
1860         (cplus_language_defn): Initialise new field.
1861         (asm_language_defn): Initialise new field.
1862         (minimal_language_defn): Initialise new field.
1863         * c-lang.h (c_is_string_type_p): Declare new function.
1864         * d-lang.c (d_language_defn): Initialise new field.
1865         * f-lang.c (f_is_string_type_p): New function.
1866         (f_language_defn): Initialise new field.
1867         * go-lang.c (go_is_string_type_p): New function.
1868         (go_language_defn): Initialise new field.
1869         * language.c (default_is_string_type_p): New function.
1870         (unknown_language_defn): Initialise new field.
1871         (auto_language_defn): Initialise new field.
1872         * language.h (struct language_defn) <la_is_string_type_p>: New
1873         member variable.
1874         (default_is_string_type_p): Declare new function.
1875         * m2-lang.c (m2_language_defn): Initialise new field.
1876         * objc-lang.c (objc_language_defn): Initialise new field.
1877         * opencl-lang.c (opencl_language_defn): Initialise new field.
1878         * p-lang.c (pascal_is_string_type_p): New function.
1879         (pascal_language_defn): Initialise new field.
1880         * rust-lang.c (rust_is_string_type_p): New function.
1881         (rust_language_defn): Initialise new field.
1882
1883 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1884
1885         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1886         New field.
1887         * ada-lang.c (ada_language_defn): Initialise new field.
1888         * c-lang.c (c_language_defn): Likewise.
1889         (cplus_language_defn): Likewise.
1890         (asm_language_defn): Likewise.
1891         (minimal_language_defn): Likewise.
1892         * d-lang.c (d_language_defn): Likewise.
1893         * f-lang.c (f_language_defn): Likewise.
1894         * go-lang.c (go_language_defn): Likewise.
1895         * language.c (unknown_language_defn): Likewise.
1896         (auto_language_defn): Likewise.
1897         * m2-lang.c (m2_language_defn): Likewise.
1898         * objc-lang.c (objc_language_defn): Likewise.
1899         * opencl-lang.c (opencl_language_defn): Likewise.
1900         * p-lang.c (pascal_language_defn): Likewise.
1901         * rust-lang.c (rust_language_defn): Likewise.
1902
1903 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1904
1905         * ada-lang.c (ada_is_character_type): Change return type to bool.
1906         (ada_is_string_type): Likewise.
1907         * ada-lang.h (ada_is_character_type): Update declaration
1908         (ada_is_string_type): Likewise.
1909
1910 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1911
1912         Support style in 'frame|thread apply'
1913
1914         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1915         * record.c (record_start, record_stop): Update callers of
1916         execute_command_to_string with false.
1917         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1918         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1919         methods.
1920         (class string_file): New constructor with term_out parameter.
1921         Override methods term_out and can_emit_style_escape.  New member
1922         term_out.
1923         (class stdio_file): Override can_emit_style_escape.
1924         (class tee_file): Override term_out and can_emit_style_escape.
1925         * utils.h (can_emit_style_escape): Remove.
1926         * utils.c (can_emit_style_escape): Likewise.
1927         Update all callers of can_emit_style_escape (SOMESTREAM) to
1928         SOMESTREAM->can_emit_style_escape.
1929         * source-cache.c (source_cache::get_source_lines): Likewise.
1930         * stack.c (frame_apply_command_count): Call execute_command_to_string
1931         passing the term_out characteristic of the current gdb_stdout.
1932         * thread.c (thr_try_catch_cmd): Likewise.
1933         * top.c (execute_command_to_string): pass term_out parameter
1934         to construct the string_file for the command output.
1935         * ui-file.c (term_cli_styling): New function (most code moved
1936         from utils.c can_emit_style_escape).
1937         (string_file::string_file, string_file::can_emit_style_escape,
1938         stdio_file::can_emit_style_escape, tee_file::term_out,
1939         tee_file::can_emit_style_escape): New functions.
1940
1941 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1942
1943         * NEWS: Mention the new set|show may-call-functions.
1944         * infcall.c (may_call_functions_p): New variable.
1945         (show_may_call_functions_p): New function.
1946         (call_function_by_hand_dummy): Throws an error if not
1947         may-call-functions.
1948         (_initialize_infcall): Call add_setshow_boolean_cmd for
1949         may-call-functions.
1950
1951 2019-04-25  Keith Seitz  <keiths@redhat.com>
1952
1953         PR c++/24367
1954         * cp-support.c (inspect_type): Don't attempt substitutions
1955         of symbol with the same name.
1956
1957 2019-04-25  Tom Tromey  <tromey@adacore.com>
1958
1959         PR gdb/24475:
1960         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1961         static.
1962
1963 2019-04-25  Tom Tromey  <tromey@adacore.com>
1964
1965         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1966         rvalue reference.
1967         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1968         (gdb_xml_parser::parse): Use std::move.
1969         * python/python-internal.h (gdbpy_convert_exception): Take a const
1970         reference.
1971         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1972         std::move.
1973         * python/py-utils.c (gdbpy_convert_exception): Take a const
1974         reference.
1975         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1976         Use std::move.
1977         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1978         Use std::move.
1979         * mi/mi-main.c (mi_print_exception): Take a const reference.
1980         * main.c (handle_command_errors): Take a const reference.
1981         * linespec.c (parse_linespec): Use std::move.
1982         * infcall.c (run_inferior_call): Use std::move.
1983         (call_function_by_hand_dummy): Use std::move.
1984         * exec.c (try_open_exec_file): Use std::move.
1985         * exceptions.h (exception_print, exception_fprintf)
1986         (exception_print_same): Update.
1987         * exceptions.c (print_exception, exception_print)
1988         (exception_fprintf, exception_print_same): Change parameters to
1989         const reference.
1990         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1991         * common/new-op.c: Use std::move.
1992         * common/common-exceptions.h (struct gdb_exception): Add move
1993         constructor.
1994         (struct gdb_exception_error, struct gdb_exception_quit, struct
1995         gdb_quit_bad_alloc): Change constructor to move constructor.
1996         (throw_exception): Change parameter to rvalue reference.
1997         * common/common-exceptions.c (throw_exception): Take rvalue
1998         reference.
1999         * cli/cli-interp.c (safe_execute_command): Use std::move.
2000         * breakpoint.c (insert_bp_location, location_to_sals): Use
2001         std::move.
2002
2003 2019-04-25  Tom Tromey  <tromey@adacore.com>
2004
2005         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2006         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2007         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2008         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2009         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2010         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2011         guile/scm-value.c: Use unpack.
2012         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2013         gdbscm_gdb_exception.
2014         (gdbscm_throw_gdb_exception): Likewise.
2015         (struct gdbscm_gdb_exception): New.
2016         (unpack): New function.
2017         (gdbscm_wrap): Use unpack.
2018
2019 2019-04-25  Tom Tromey  <tromey@adacore.com>
2020
2021         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2022         (gdb_rl_callback_handler): Use std::move.
2023         * common/common-exceptions.h (struct gdb_exception): Add move
2024         assignment operator.
2025         (throw_exception_sjlj): Change "exception" to const reference.
2026         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2027         (throw_exception_sjlj): Change "exception" to const reference.
2028
2029 2019-04-25  Tom Tromey  <tromey@adacore.com>
2030
2031         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2032         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2033         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2034         Update.
2035         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2036         Update.
2037         * mi/mi-interp.c (mi_interp::exec): Update.
2038         * linespec.c (parse_linespec): Update.
2039         * infcall.c (run_inferior_call): Update.
2040         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2041         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2042         (gdbscm_lookup_global_symbol): Update.
2043         * guile/scm-param.c (gdbscm_parameter_value): Update.
2044         * guile/scm-frame.c (gdbscm_frame_read_register)
2045         (gdbscm_frame_read_var): Update.
2046         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2047         * exec.c (try_open_exec_file): Update.
2048         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2049         (gdb_rl_callback_handler): Update.
2050         * common/common-exceptions.h (exception_none): Don't declare.
2051         * common/common-exceptions.c (exception_none): Don't define.
2052         (struct catcher) <exception>: Update.
2053         * cli/cli-interp.c (safe_execute_command): Update.
2054         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2055
2056 2019-04-25  Ali Tamur  <tamur@google.com>
2057
2058         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2059         (read_attribute_value): Likewise.
2060         (dwarf2_read_addr_index): Update comment.
2061         (read_str_index): Add DW_FORM_strx.
2062         (dwarf2_string_attr): Likewise.
2063         (dwarf2_const_value_attr): Likewise.
2064         (dump_die_shallow): Likewise.
2065         (dwarf2_fetch_constant_bytes): Likewise.
2066         (skip_form_bytes): Likewise.
2067         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2068
2069 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2070
2071         PR corefiles/11608
2072         PR corefiles/18187
2073         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2074         OFFSET.  Verify if current mapping contains an ELF header.
2075         (linux_find_memory_regions_full): Adjust call to
2076         dump_mapping_p.
2077
2078 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2079             Kang Li <kanglictf@gmail.com>
2080
2081         PR gdb/21600
2082
2083         * dwarf2-frame.c (read_initial_length): Be consistent about using
2084         unsigned representation of length.
2085         (decode_frame_entry_1): Likewise.  Check for wraparound of
2086         end pointer as well as buffer overflow.
2087
2088 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2089
2090         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2091         "vq".
2092
2093 2019-04-24  Tom Tromey  <tromey@adacore.com>
2094
2095         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2096
2097 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2098
2099         * s12z-tdep.c (s12z_unwind_pc): Delete.
2100         (s12z_unwind_sp): Delete.
2101         (s12z_gdbarch_init): Don't register deleted functions with
2102         gdbarch.
2103
2104 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2105
2106         * rl78-tdep.c (rl78_unwind_sp): Delete.
2107         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2108
2109 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2110
2111         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2112         (xstormy16_unwind_pc): Delete.
2113         (xstormy16_dummy_id): Delete.
2114         (xstormy16_gdbarch_init): Don't register deleted functions with
2115         gdbarch.
2116
2117 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2118
2119         * vax-tdep.c (vax_unwind_pc): Delete.
2120         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2121
2122 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2123
2124         * v850-tdep.c (v850_unwind_sp): Delete.
2125         (v850_unwind_pc): Delete.
2126         (v850_dummy_id): Delete.
2127         (v850_gdbarch_init): Don't register deleted functions with
2128         gdbarch.
2129
2130 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2131
2132         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2133         (tilegx_unwind_pc): Delete.
2134         (tilegx_unwind_dummy_id): Delete.
2135         (tilegx_gdbarch_init): Don't register deleted functions with
2136         gdbarch.
2137
2138 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2139
2140         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2141         (tic6x_dummy_id): Delete.
2142         (tic6x_gdbarch_init): Don't register deleted functions with
2143         gdbarch.
2144
2145 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2146
2147         * sparc-tdep.c (sparc_unwind_pc): Delete.
2148         (sparc32_gdbarch_init): Don't register deleted function with
2149         gdbarch.
2150
2151 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2152
2153         * sh-tdep.c (sh_unwind_sp): Delete.
2154         (sh_unwind_pc): Delete.
2155         (sh_dummy_id): Delete.
2156         (sh_gdbarch_init): Don't register deleted functions with
2157         gdbarch.
2158
2159 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2160
2161         * score-tdep.c (score_unwind_sp): Delete.
2162         (score_unwind_pc): Delete.
2163         (score_dummy_id): Delete.
2164         (score_gdbarch_init): Don't register deleted functions with
2165         gdbarch.
2166
2167 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2168
2169         * rx-tdep.c (rx_unwind_pc): Delete.
2170         (rx_unwind_sp): Delete.
2171         (rx_dummy_id): Delete.
2172         (rx_gdbarch_init): Don't register deleted functions with
2173         gdbarch.  Update comment.
2174
2175 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2176
2177         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2178         (rs6000_dummy_id): Delete.
2179         (rs6000_gdbarch_init): Don't register deleted functions with
2180         gdbarch.
2181
2182 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2183
2184         * or1k-tdep.c (or1k_dummy_id): Delete.
2185         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2186
2187 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2188
2189         * nios2-tdep.c (nios2_dummy_id): Delete.
2190         (nios2_unwind_sp): Delete.
2191         (nios2_gdbarch_init): Don't register deleted functions with
2192         gdbarch.
2193
2194 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2195
2196         * nds32-tdep.c (nds32_dummy_id): Delete.
2197         (nds32_unwind_pc): Delete.
2198         (nds32_unwind_sp): Delete.
2199         (nds32_gdbarch_init): Don't register deleted functions with
2200         gdbarch.
2201
2202 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2203
2204         * msp430-tdep.c (msp430_unwind_pc): Delete.
2205         (msp430_unwind_sp): Delete.
2206         (msp430_dummy_id): Delete.
2207         (msp430_gdbarch_init): Don't register deleted functions with
2208         gdbarch.
2209
2210 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2211
2212         * moxie-tdep.c (moxie_unwind_sp): Delete.
2213         (moxie_unwind_pc): Delete.
2214         (moxie_dummy_id): Delete.
2215         (moxie_gdbarch_init): Don't register deleted functions with
2216         gdbarch.
2217
2218 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2219
2220         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2221         (mn10300_unwind_pc): Delete.
2222         (mn10300_unwind_sp): Delete.
2223         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2224         mn10300_unwind_sp.
2225         (mn10300_frame_unwind_init): Don't register deleted functions with
2226         gdbarch.
2227
2228 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2229
2230         * mep-tdep.c (mep_unwind_pc): Delete.
2231         (mep_unwind_sp): Delete.
2232         (mep_dummy_id): Delete.
2233         (mep_gdbarch_init): Don't register deleted functions with
2234         gdbarch.
2235
2236 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2237
2238         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2239         (m68hc11_unwind_sp): Delete.
2240         (m68hc11_gdbarch_init): Don't register deleted functions with
2241         gdbarch.
2242
2243 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2244
2245         * m32r-tdep.c (m32r_unwind_sp): Delete.
2246         (m32r_unwind_pc): Delete.
2247         (m32r_dummy_id): Delete.
2248         (m32r_gdbarch_init): Don't register deleted functions with
2249         gdbarch.
2250
2251 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2252
2253         * m32c-tdep.c (m32c_unwind_pc): Delete.
2254         (m32c_unwind_sp): Delete.
2255         (m32c_dummy_id): Delete.
2256         (m32c_gdbarch_init): Don't register deleted functions with
2257         gdbarch.
2258
2259 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2260
2261         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2262         (lm32_unwind_pc): Delete.
2263         (lm32_dummy_id): Delete.
2264         (lm32_gdbarch_init): Don't register deleted functions with
2265         gdbarch.
2266
2267 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2268
2269         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2270         (iq2000_unwind_pc): Delete.
2271         (iq2000_dummy_id): Delete.
2272         (iq2000_gdbarch_init): Don't register deleted functions with
2273         gdbarch.
2274
2275 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2276
2277         * nds32-tdep.c (nds32_type_align): Delete.
2278         (nds32_push_dummy_call): Use type_align instead.
2279
2280 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2281
2282         * arm-tdep.c (arm_type_align): Only handle vector override case.
2283         (arm_push_dummy_call): Use type_align.
2284         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2285
2286 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2287
2288         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2289         case.
2290         (pass_on_stack): Use type_align.
2291         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2292         function.
2293
2294 2019-04-23  Tom Tromey  <tromey@adacore.com>
2295
2296         * dwarf2read.c (line_header::file_name_at): Remove unused
2297         overload.
2298
2299 2019-04-23  Tom de Vries  <tdevries@suse.de>
2300
2301         PR gdb/24438
2302         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2303         invocation.
2304
2305
2306 2019-03-27  Ali Tamur  <tamur@google.com>
2307
2308         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2309         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2310         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2311         (dwarf_expr_context::get_addr_index): Likewise
2312         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2313         (symbol_needs_eval_context::get_addr_index): Likewise
2314         (disassemble_dwarf_expression): Add DW_OP_addrx
2315         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2316         (read_cutu_die_from_dwo): Update comment
2317         (skip_one_die): Add DW_FORM_addrx
2318         (read_attribute_value): Likewise
2319         (var_decode_location): Add DW_OP_addrx
2320         (dwarf2_const_value_attr): Add DW_FORM_addrx
2321         (dump_die_shallow): Likewise
2322         (dwarf2_fetch_constant_bytes): Likewise
2323         (decode_locdesc): Add DW_OP_addrx
2324         (skip_form_bytes): Add DW_FORM_addrx
2325
2326 2019-04-22  Ali Tamur  <tamur@google.com>
2327
2328         * MAINTAINERS (Write After Approval): Add self.
2329
2330 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2331
2332         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2333         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2334         (open_symbol_file_object): Likewise.
2335         (svr4_default_sos): Add info parameter.
2336         (svr4_read_so_list): Likewise.
2337         (svr4_current_sos_direct): Adjust functions calls to pass down
2338         info.
2339         (svr4_current_sos_1): Add info parameter.
2340         (svr4_current_sos): Call get_svr4_info, pass info down to
2341         svr4_current_sos_1.
2342         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2343         get_svr4_info.
2344         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2345         get_svr4_info.
2346         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2347         to get_svr4_info.
2348         (probes_table_remove_objfile_probes): Likewise.
2349         (register_solib_event_probe): Add info parameter.
2350         (solist_update_incremental): Pass info parameter down to
2351         svr4_read_so_list.
2352         (disable_probes_interface): Add info parameter.
2353         (svr4_handle_solib_event): Pass current_program_space to
2354         get_svr4_info.  Adjust disable_probes_interface cleanup.
2355         (svr4_create_probe_breakpoints): Add info parameter, pass it
2356         down to register_solib_event_probe.
2357         (svr4_create_solib_event_breakpoints): Add info parameter,
2358         pass it down to svr4_create_probe_breakpoints.
2359         (enable_break): Pass info down to
2360         svr4_create_solib_event_breakpoints.
2361         (svr4_solib_create_inferior_hook): Pass current_program_space to
2362         get_svr4_info.
2363         (svr4_clear_solib): Likewise.
2364
2365 2019-04-22  Pedro Alves  <palves@redhat.com>
2366
2367         * solib-svr4.c (svr4_free_objfile_observer): New.
2368         (probe_and_action::objfile): New field.
2369         (probes_table_htab_remove_objfile_probes)
2370         (probes_table_remove_objfile_probes): New functions.
2371         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2372         in the new probe_and_action.  Don't store the probe in 'lookup'.
2373         (svr4_create_probe_breakpoints): Pass objfile to
2374         register_solib_event_probe.
2375         (_initialize_svr4_solib): Register a free_objfile observer.
2376
2377 2019-04-19  Tom Tromey  <tom@tromey.com>
2378
2379         * common/queue.h: Remove.
2380
2381 2019-04-19  Tom Tromey  <tom@tromey.com>
2382
2383         * event-loop.c: Don't include "common/queue.h".
2384
2385 2019-04-19  Tom Tromey  <tom@tromey.com>
2386
2387         * remote.c (remote_target): Use delete.
2388         * remote-notif.h: Include <list>, not "common/queue.h".
2389         (notif_client_p): Remove typedef.
2390         (remote_notif_state): Add constructor, destructor, initializer.
2391         <notif_queue>: Now a std::list.
2392         (remote_notif_state_xfree): Don't declare.
2393         * remote-notif.c (remote_notif_process, handle_notification)
2394         (remote_notif_state_allocate): Update.
2395         (~remote_notif_state): Rename from remote_notif_state_xfree.
2396
2397 2019-04-19  Tom Tromey  <tom@tromey.com>
2398
2399         * symfile.c (reread_symbols): Update.
2400         * objfiles.c (objfile_register_static_link)
2401         (objfile_lookup_static_link): Update
2402         (~objfile) Don't delete static_links.
2403         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2404
2405 2019-04-19  Tom Tromey  <tom@tromey.com>
2406
2407         * type-stack.h (struct type_stack) <insert>: Constify string.
2408         * type-stack.c (type_stack::insert): Constify string.
2409         * gdbtypes.h (lookup_template_type): Update.
2410         (address_space_name_to_int): Update.
2411         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2412         const.
2413         (lookup_template_type): Make name const.
2414         * c-exp.y: Update rules.
2415         (lex_one_token, classify_name, classify_inner_name)
2416         (c_print_token): Update.
2417         * p-exp.y: Update rules.
2418         (yylex): Update.
2419         * f-exp.y: Update rules.
2420         (yylex): Update.
2421         * d-exp.y: Update rules.
2422         (lex_one_token, classify_name, classify_inner_name): Update.
2423         * parse.c (write_dollar_variable, copy_name): Return std::string.
2424         * parser-defs.h (copy_name): Change return type.
2425         * m2-exp.y: Update rules.
2426         (yylex): Update.
2427         * go-exp.y (lex_one_token): Update.
2428         Update rules.
2429         (classify_unsafe_function, classify_packaged_name)
2430         (classify_name, yylex): Update.
2431
2432 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2433
2434         * configure.ac: add --enable-source-highlight switch.
2435         * configure: Regenerate.
2436         * top.c (print_gdb_version): plumb --enable-source-highlight
2437         status to "show configuration".
2438
2439 2019-04-19  Tom Tromey  <tromey@adacore.com>
2440
2441         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2442         Check ADA_TYPE_P.
2443         (empty_record, ada_template_to_fixed_record_type_1)
2444         (template_to_static_fixed_type)
2445         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2446         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2447         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2448         macros.
2449
2450 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2451
2452         PR symtab/24423:
2453         * source.c (print_source_lines_base): Advance "iter" when a
2454         control character is seen.
2455
2456 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2457
2458         * inferior.h (struct infcall_suspend_state_deleter):
2459         Catch exception in destructor to avoid crash.
2460
2461 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2462
2463         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2464         close to the add_com "shell".
2465
2466 2019-04-18  Tom Tromey  <tromey@adacore.com>
2467
2468         * process-stratum-target.h (class process_stratum_target)
2469         <stratum>: Add "final".
2470
2471 2019-04-17  Tom Tromey  <tromey@adacore.com>
2472
2473         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2474         against nullptr before use.
2475
2476 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2477
2478         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2479
2480 2019-04-17  Jim Wilson  <jimw@sifive.com>
2481             Andrew Burgess  <andrew.burgess@embecosm.com>
2482
2483         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2484         code read might fail, assume 4-byte breakpoint in that case.
2485
2486 2019-04-15  Leszek Swirski  <leszeks@google.com>
2487
2488         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2489         rather than a hand-rolled POD check when checking for forced MEMORY
2490         classification.
2491
2492 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2493
2494         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2495         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2496         function.
2497         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2498         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2499         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2500         declaration.
2501
2502 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2503
2504         * aarch64-linux-nat.c
2505         (aarch64_linux_nat_target::thread_architecture): Add override.
2506         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2507         each VQ.
2508
2509 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2510
2511         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2512
2513 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2514
2515         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2516         target types of size 96-bits, add some additional comments, and
2517         check that the builtin type we found was the correct size.
2518
2519 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2520
2521         * utils.c (prompt_for_continue): Don't restore the styling at the
2522         end, as applied_style has the wrong value.  This fixes styling in
2523         long lists of file names that are interrupted by the "Continue?"
2524         prompt.
2525
2526 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2527
2528         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2529         * c-lang.c (c_language_defn): Likewise.
2530         (cplus_language_defn): Likewise.
2531         (asm_language_defn): Likewise.
2532         (minimal_language_defn): Likewise.
2533         * d-lang.c (d_language_defn): Likewise.
2534         * f-lang.c (f_language_defn): Likewise.
2535         * go-lang.c (go_language_defn): Likewise.
2536         * language.c (unknown_language_defn): Likewise.
2537         (auto_language_defn): Likewise.
2538         * language.h (struct language_defn): Remove la_magic field.
2539         (LANG_MAGIC): Delete.
2540         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2541         * objc-lang.c (objc_language_defn): Likewise.
2542         * opencl-lang.c (opencl_language_defn): Likewise.
2543         * p-lang.c (pascal_language_defn): Likewise.
2544         * rust-lang.c (rust_language_defn): Likewise.
2545
2546 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2547
2548         * riscv-tdep.c (riscv_type_align): New function.
2549         (riscv_type_alignment): Delete.
2550         (riscv_arg_location): Use 'type_align'.
2551         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2552
2553 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2554
2555         * gdbtypes.c (type_align): A struct with no non-static fields also
2556         has alignment of 1.
2557
2558 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2559
2560         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2561         component to 0.
2562         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2563         member.
2564         (riscv_struct_info::analyse): New implementation using new
2565         analyse_inner member function.
2566         (riscv_struct_info::field_offset): New member function.
2567         (riscv_struct_info::m_offsets): New member variable.
2568         (riscv_struct_info::analyse_inner): New private member function,
2569         takes the old implementation of riscv_struct_info::analyse but
2570         extended to track field offsets.
2571         (riscv_call_arg_struct): Update the struct folding special cases
2572         to handle cases where empty C++ structs, which are non-zero
2573         length, are found.
2574         (riscv_arg_location): Initialise the length of each location, a
2575         non-zero length now indicates the location is in use.
2576         (riscv_push_dummy_call): Allow for the first location having a
2577         non-zero offset when setting up arguments.
2578         (riscv_return_value): Likewise, but for return values.
2579
2580 2019-04-11  Tom Tromey  <tromey@adacore.com>
2581
2582         * utils.c (internal_vproblem): Make "msg" const.
2583
2584 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2585
2586         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2587         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2588         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2589         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2590
2591 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2592
2593         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2594         function.
2595         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2596         of amd64_collect_native_gregset.
2597         (amd64_linux_nat_target::store_registers): Likewise.
2598
2599 2019-04-10  Tom Tromey  <tom@tromey.com>
2600
2601         * symtab.c (lookup_global_symbol_from_objfile)
2602         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2603         * objfiles.h (class separate_debug_iterator): New.
2604         (class separate_debug_range): New.
2605         (struct objfile) <separate_debug_objfiles>: New method.
2606         (objfile_separate_debug_iterate): Don't declare.
2607         * objfiles.c (separate_debug_iterator::operator++): Rename from
2608         objfile_separate_debug_iterate.
2609         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2610         iterator.
2611         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2612         iterator.
2613
2614 2019-04-10  Tom Tromey  <tom@tromey.com>
2615
2616         * symfile.c (reread_symbols): Remove old comment.
2617         * objfiles.c (free_all_objfiles): Fix a typo.
2618
2619 2019-04-10  Tom Tromey  <tom@tromey.com>
2620
2621         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2622         * minsyms.c (lookup_minimal_symbol): Use foreach.
2623         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2624         (lookup_minimal_symbol_solib_trampoline): Likewise.
2625         * symfile.c (reread_symbols): Use foreach.
2626
2627 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2628             Tom Tromey  <tromey@adacore.com>
2629
2630         PR rust/24414:
2631         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2632         (rust_lex_int_test): Change "value" to be LONGEST.
2633         (rust_lex_tests): Add test for long integer literal.
2634
2635 2019-04-09  Tom Tromey  <tromey@adacore.com>
2636
2637         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2638         to bool.
2639         (extended_remote_target::attach): Update.
2640         (remote_target::remote_notice_new_inferior): Update.
2641         (remote_target::add_current_inferior_and_thread): Update.
2642         * inferior.c (exit_inferior_1): Use "false".
2643         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2644
2645 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2646
2647         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2648         the "start" command.
2649
2650 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2651
2652         * python/py-inferior.c (infpy_thread_from_thread_handle):
2653         Adjust comments to reflect renaming of thread_from_thread_handle
2654         to thread_from_handle.  Adjust keywords.  Fix type error message.
2655         (inferior_object_methods): Add thread_from_handle.  Retain
2656         thread_from_thread_handle, but mark it as deprecated.
2657
2658 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2659
2660         * gdbthread.h (find_thread_by_handle): Revise declaration.
2661         * thread.c (find_thread_by_handle): Likewise.  Adjust
2662         implementation too.
2663         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2664         support for buffer objects as handles.
2665
2666 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2667
2668         * python/py-infthread.c (thpy_thread_handle): New function.
2669         (thread_object_methods): Register thpy_thread_handle.
2670
2671 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2672
2673         * gdbthread.h (thread_to_thread_handle): Declare.
2674         * thread.c (gdbtypes.h): Include.
2675         (thread_to_thread_handle): New function.
2676
2677         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2678         (target_thread_info_to_thread_handle): Declare.
2679         * target.c (target_thread_info_to_thread_handle): New function.
2680         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2681         * target-delegates.c: Regenerate.
2682
2683         * linux-thread-db.c (class thread_db_target): Add method
2684         thread_info_to_thread_handle.
2685         (thread_db_target::thread_info_to_thread_handle): Define.
2686         * remote.c (class remote_target): Add new method
2687         thread_info_to_thread_handle.
2688         (remote_target::thread_info_to_thread_handle): Define.
2689
2690 2019-04-08  Pedro Alves  <palves@redhat.com>
2691
2692         * common/common-exceptions.c (throw_exception): Don't create
2693         named object to throw; throw directly.
2694         (throw_it): Likewise.  Don't initialize gdb_exception::message
2695         here, with new; pass FMT and AP to the ctor instead.
2696         * common/common-exceptions.h: Include <string>.
2697         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2698         const char *, va_list)): New ctor.  Use std::make_shared.
2699         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2700         errors)): Delete.
2701         (gdb_exception_error::gdb_exception_error(enum errors, const char
2702         *, va_list)): New.
2703         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2704         Add assertion.
2705         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2706         errors)): Delete.
2707         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2708         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2709         Add assertion.
2710
2711 2019-04-08  Tom Tromey  <tom@tromey.com>
2712
2713         * valops.c (value_rtti_indirect_type): Replace throw_exception
2714         with throw.
2715         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2716         with throw.
2717         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2718         throw.
2719         * target.c (target_translate_tls_address): Replace throw_exception
2720         with throw.
2721         * stack.c (frame_apply_command_count): Replace throw_exception
2722         with throw.
2723         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2724         throw.
2725         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2726         with throw.
2727         * rs6000-tdep.c (rs6000_frame_cache)
2728         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2729         * remote.c: Replace throw_exception with throw.
2730         * record-full.c (record_full_message, record_full_wait_1)
2731         (record_full_restore): Replace throw_exception with throw.
2732         * record-btrace.c:
2733         (get_thread_current_frame_id, record_btrace_start_replaying)
2734         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2735         (cmd_record_btrace_start): Replace throw_exception with throw.
2736         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2737         throw.
2738         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2739         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2740         * linespec.c:
2741         (find_linespec_symbols): Replace throw_exception with throw.
2742         * infrun.c (displaced_step_prepare, resume): Replace
2743         throw_exception with throw.
2744         * infcmd.c (post_create_inferior): Replace throw_exception with
2745         throw.
2746         * inf-loop.c (inferior_event_handler): Replace throw_exception
2747         with throw.
2748         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2749         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2750         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2751         (get_prev_frame_always, get_frame_pc_if_available)
2752         (get_frame_address_in_block_if_available, get_frame_language):
2753         Replace throw_exception with throw.
2754         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2755         throw_exception with throw.
2756         * eval.c (fetch_subexp_value, evaluate_var_value)
2757         (evaluate_funcall, evaluate_subexp_standard): Replace
2758         throw_exception with throw.
2759         * dwarf2loc.c (call_site_find_chain)
2760         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2761         Replace throw_exception with throw.
2762         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2763         with throw.
2764         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2765         throw.
2766         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2767         * completer.c (complete_line_internal): Replace throw_exception
2768         with throw.
2769         * compile/compile-object-run.c (compile_object_run): Replace
2770         throw_exception with throw.
2771         * cli/cli-script.c (process_next_line): Replace throw_exception
2772         with throw.
2773         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2774         (btrace_enable, btrace_maint_update_pt_packets): Replace
2775         throw_exception with throw.
2776         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2777         throw_exception with throw.
2778         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2779         throw_exception with throw.
2780         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2781         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2782         * aarch64-tdep.c (aarch64_make_prologue_cache)
2783         (aarch64_make_stub_cache): Replace throw_exception with throw.
2784
2785 2019-04-08  Tom Tromey  <tom@tromey.com>
2786
2787         * common/common-exceptions.c (throw_exception): Rename from
2788         throw_exception_cxx.  Remove old copy.  Make argument const.
2789         (throw_it): Create and throw exception objects directly.
2790         * common/common-exceptions.h (throw_exception): Make argument
2791         const.
2792         (struct gdb_exception_error): Add constructor.
2793         (struct gdb_exception_quit): Add constructor.
2794
2795 2019-04-08  Tom Tromey  <tom@tromey.com>
2796
2797         * common/common-exceptions.h (exception_rethrow): Don't declare.
2798         (TRY_SJLJ): Update comment.
2799         (TRY, CATCH, END_CATCH): Remove.
2800         * common/common-exceptions.c (exception_rethrow): Remove.
2801
2802 2019-04-08  Tom Tromey  <tom@tromey.com>
2803
2804         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2805         Remove.
2806         (gdb_exception_error): Rename from
2807         gdb_exception_RETURN_MASK_ERROR.
2808         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2809         (gdb_quit_bad_alloc): Update.
2810         * aarch64-tdep.c: Update.
2811         * ada-lang.c: Update.
2812         * ada-typeprint.c: Update.
2813         * ada-valprint.c: Update.
2814         * amd64-tdep.c: Update.
2815         * arch-utils.c: Update.
2816         * break-catch-throw.c: Update.
2817         * breakpoint.c: Update.
2818         * btrace.c: Update.
2819         * c-varobj.c: Update.
2820         * cli/cli-cmds.c: Update.
2821         * cli/cli-interp.c: Update.
2822         * cli/cli-script.c: Update.
2823         * common/common-exceptions.c: Update.
2824         * common/new-op.c: Update.
2825         * common/selftest.c: Update.
2826         * compile/compile-c-symbols.c: Update.
2827         * compile/compile-cplus-symbols.c: Update.
2828         * compile/compile-object-load.c: Update.
2829         * compile/compile-object-run.c: Update.
2830         * completer.c: Update.
2831         * corelow.c: Update.
2832         * cp-abi.c: Update.
2833         * cp-support.c: Update.
2834         * cp-valprint.c: Update.
2835         * darwin-nat.c: Update.
2836         * disasm-selftests.c: Update.
2837         * dtrace-probe.c: Update.
2838         * dwarf-index-cache.c: Update.
2839         * dwarf-index-write.c: Update.
2840         * dwarf2-frame-tailcall.c: Update.
2841         * dwarf2-frame.c: Update.
2842         * dwarf2loc.c: Update.
2843         * dwarf2read.c: Update.
2844         * eval.c: Update.
2845         * event-loop.c: Update.
2846         * event-top.c: Update.
2847         * exec.c: Update.
2848         * f-valprint.c: Update.
2849         * fbsd-tdep.c: Update.
2850         * frame-unwind.c: Update.
2851         * frame.c: Update.
2852         * gdbtypes.c: Update.
2853         * gnu-v3-abi.c: Update.
2854         * guile/guile-internal.h: Update.
2855         * guile/scm-block.c: Update.
2856         * guile/scm-breakpoint.c: Update.
2857         * guile/scm-cmd.c: Update.
2858         * guile/scm-disasm.c: Update.
2859         * guile/scm-frame.c: Update.
2860         * guile/scm-lazy-string.c: Update.
2861         * guile/scm-math.c: Update.
2862         * guile/scm-param.c: Update.
2863         * guile/scm-ports.c: Update.
2864         * guile/scm-pretty-print.c: Update.
2865         * guile/scm-symbol.c: Update.
2866         * guile/scm-symtab.c: Update.
2867         * guile/scm-type.c: Update.
2868         * guile/scm-value.c: Update.
2869         * i386-linux-tdep.c: Update.
2870         * i386-tdep.c: Update.
2871         * inf-loop.c: Update.
2872         * infcall.c: Update.
2873         * infcmd.c: Update.
2874         * infrun.c: Update.
2875         * jit.c: Update.
2876         * language.c: Update.
2877         * linespec.c: Update.
2878         * linux-fork.c: Update.
2879         * linux-nat.c: Update.
2880         * linux-tdep.c: Update.
2881         * linux-thread-db.c: Update.
2882         * main.c: Update.
2883         * mi/mi-cmd-break.c: Update.
2884         * mi/mi-cmd-stack.c: Update.
2885         * mi/mi-interp.c: Update.
2886         * mi/mi-main.c: Update.
2887         * objc-lang.c: Update.
2888         * p-valprint.c: Update.
2889         * parse.c: Update.
2890         * ppc-linux-tdep.c: Update.
2891         * printcmd.c: Update.
2892         * python/py-arch.c: Update.
2893         * python/py-breakpoint.c: Update.
2894         * python/py-cmd.c: Update.
2895         * python/py-finishbreakpoint.c: Update.
2896         * python/py-frame.c: Update.
2897         * python/py-framefilter.c: Update.
2898         * python/py-gdb-readline.c: Update.
2899         * python/py-inferior.c: Update.
2900         * python/py-infthread.c: Update.
2901         * python/py-lazy-string.c: Update.
2902         * python/py-linetable.c: Update.
2903         * python/py-objfile.c: Update.
2904         * python/py-param.c: Update.
2905         * python/py-prettyprint.c: Update.
2906         * python/py-progspace.c: Update.
2907         * python/py-record-btrace.c: Update.
2908         * python/py-record.c: Update.
2909         * python/py-symbol.c: Update.
2910         * python/py-type.c: Update.
2911         * python/py-unwind.c: Update.
2912         * python/py-utils.c: Update.
2913         * python/py-value.c: Update.
2914         * python/python.c: Update.
2915         * record-btrace.c: Update.
2916         * record-full.c: Update.
2917         * remote-fileio.c: Update.
2918         * remote.c: Update.
2919         * riscv-tdep.c: Update.
2920         * rs6000-aix-tdep.c: Update.
2921         * rs6000-tdep.c: Update.
2922         * rust-exp.y: Update.
2923         * rust-lang.c: Update.
2924         * s390-tdep.c: Update.
2925         * selftest-arch.c: Update.
2926         * solib-dsbt.c: Update.
2927         * solib-frv.c: Update.
2928         * solib-spu.c: Update.
2929         * solib-svr4.c: Update.
2930         * solib.c: Update.
2931         * sparc64-linux-tdep.c: Update.
2932         * stack.c: Update.
2933         * symfile-mem.c: Update.
2934         * symmisc.c: Update.
2935         * target.c: Update.
2936         * thread.c: Update.
2937         * top.c: Update.
2938         * tracefile-tfile.c: Update.
2939         * tui/tui.c: Update.
2940         * typeprint.c: Update.
2941         * unittests/cli-utils-selftests.c: Update.
2942         * unittests/parse-connection-spec-selftests.c: Update.
2943         * valops.c: Update.
2944         * valprint.c: Update.
2945         * value.c: Update.
2946         * varobj.c: Update.
2947         * windows-nat.c: Update.
2948         * x86-linux-nat.c: Update.
2949         * xml-support.c: Update.
2950
2951 2019-04-08  Tom Tromey  <tom@tromey.com>
2952
2953         * xml-support.c: Use C++ exception handling.
2954         * x86-linux-nat.c: Use C++ exception handling.
2955         * windows-nat.c: Use C++ exception handling.
2956         * varobj.c: Use C++ exception handling.
2957         * value.c: Use C++ exception handling.
2958         * valprint.c: Use C++ exception handling.
2959         * valops.c: Use C++ exception handling.
2960         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2961         handling.
2962         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2963         * typeprint.c: Use C++ exception handling.
2964         * tui/tui.c: Use C++ exception handling.
2965         * tracefile-tfile.c: Use C++ exception handling.
2966         * top.c: Use C++ exception handling.
2967         * thread.c: Use C++ exception handling.
2968         * target.c: Use C++ exception handling.
2969         * symmisc.c: Use C++ exception handling.
2970         * symfile-mem.c: Use C++ exception handling.
2971         * stack.c: Use C++ exception handling.
2972         * sparc64-linux-tdep.c: Use C++ exception handling.
2973         * solib.c: Use C++ exception handling.
2974         * solib-svr4.c: Use C++ exception handling.
2975         * solib-spu.c: Use C++ exception handling.
2976         * solib-frv.c: Use C++ exception handling.
2977         * solib-dsbt.c: Use C++ exception handling.
2978         * selftest-arch.c: Use C++ exception handling.
2979         * s390-tdep.c: Use C++ exception handling.
2980         * rust-lang.c: Use C++ exception handling.
2981         * rust-exp.y: Use C++ exception handling.
2982         * rs6000-tdep.c: Use C++ exception handling.
2983         * rs6000-aix-tdep.c: Use C++ exception handling.
2984         * riscv-tdep.c: Use C++ exception handling.
2985         * remote.c: Use C++ exception handling.
2986         * remote-fileio.c: Use C++ exception handling.
2987         * record-full.c: Use C++ exception handling.
2988         * record-btrace.c: Use C++ exception handling.
2989         * python/python.c: Use C++ exception handling.
2990         * python/py-value.c: Use C++ exception handling.
2991         * python/py-utils.c: Use C++ exception handling.
2992         * python/py-unwind.c: Use C++ exception handling.
2993         * python/py-type.c: Use C++ exception handling.
2994         * python/py-symbol.c: Use C++ exception handling.
2995         * python/py-record.c: Use C++ exception handling.
2996         * python/py-record-btrace.c: Use C++ exception handling.
2997         * python/py-progspace.c: Use C++ exception handling.
2998         * python/py-prettyprint.c: Use C++ exception handling.
2999         * python/py-param.c: Use C++ exception handling.
3000         * python/py-objfile.c: Use C++ exception handling.
3001         * python/py-linetable.c: Use C++ exception handling.
3002         * python/py-lazy-string.c: Use C++ exception handling.
3003         * python/py-infthread.c: Use C++ exception handling.
3004         * python/py-inferior.c: Use C++ exception handling.
3005         * python/py-gdb-readline.c: Use C++ exception handling.
3006         * python/py-framefilter.c: Use C++ exception handling.
3007         * python/py-frame.c: Use C++ exception handling.
3008         * python/py-finishbreakpoint.c: Use C++ exception handling.
3009         * python/py-cmd.c: Use C++ exception handling.
3010         * python/py-breakpoint.c: Use C++ exception handling.
3011         * python/py-arch.c: Use C++ exception handling.
3012         * printcmd.c: Use C++ exception handling.
3013         * ppc-linux-tdep.c: Use C++ exception handling.
3014         * parse.c: Use C++ exception handling.
3015         * p-valprint.c: Use C++ exception handling.
3016         * objc-lang.c: Use C++ exception handling.
3017         * mi/mi-main.c: Use C++ exception handling.
3018         * mi/mi-interp.c: Use C++ exception handling.
3019         * mi/mi-cmd-stack.c: Use C++ exception handling.
3020         * mi/mi-cmd-break.c: Use C++ exception handling.
3021         * main.c: Use C++ exception handling.
3022         * linux-thread-db.c: Use C++ exception handling.
3023         * linux-tdep.c: Use C++ exception handling.
3024         * linux-nat.c: Use C++ exception handling.
3025         * linux-fork.c: Use C++ exception handling.
3026         * linespec.c: Use C++ exception handling.
3027         * language.c: Use C++ exception handling.
3028         * jit.c: Use C++ exception handling.
3029         * infrun.c: Use C++ exception handling.
3030         * infcmd.c: Use C++ exception handling.
3031         * infcall.c: Use C++ exception handling.
3032         * inf-loop.c: Use C++ exception handling.
3033         * i386-tdep.c: Use C++ exception handling.
3034         * i386-linux-tdep.c: Use C++ exception handling.
3035         * guile/scm-value.c: Use C++ exception handling.
3036         * guile/scm-type.c: Use C++ exception handling.
3037         * guile/scm-symtab.c: Use C++ exception handling.
3038         * guile/scm-symbol.c: Use C++ exception handling.
3039         * guile/scm-pretty-print.c: Use C++ exception handling.
3040         * guile/scm-ports.c: Use C++ exception handling.
3041         * guile/scm-param.c: Use C++ exception handling.
3042         * guile/scm-math.c: Use C++ exception handling.
3043         * guile/scm-lazy-string.c: Use C++ exception handling.
3044         * guile/scm-frame.c: Use C++ exception handling.
3045         * guile/scm-disasm.c: Use C++ exception handling.
3046         * guile/scm-cmd.c: Use C++ exception handling.
3047         * guile/scm-breakpoint.c: Use C++ exception handling.
3048         * guile/scm-block.c: Use C++ exception handling.
3049         * guile/guile-internal.h: Use C++ exception handling.
3050         * gnu-v3-abi.c: Use C++ exception handling.
3051         * gdbtypes.c: Use C++ exception handling.
3052         * frame.c: Use C++ exception handling.
3053         * frame-unwind.c: Use C++ exception handling.
3054         * fbsd-tdep.c: Use C++ exception handling.
3055         * f-valprint.c: Use C++ exception handling.
3056         * exec.c: Use C++ exception handling.
3057         * event-top.c: Use C++ exception handling.
3058         * event-loop.c: Use C++ exception handling.
3059         * eval.c: Use C++ exception handling.
3060         * dwarf2read.c: Use C++ exception handling.
3061         * dwarf2loc.c: Use C++ exception handling.
3062         * dwarf2-frame.c: Use C++ exception handling.
3063         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3064         * dwarf-index-write.c: Use C++ exception handling.
3065         * dwarf-index-cache.c: Use C++ exception handling.
3066         * dtrace-probe.c: Use C++ exception handling.
3067         * disasm-selftests.c: Use C++ exception handling.
3068         * darwin-nat.c: Use C++ exception handling.
3069         * cp-valprint.c: Use C++ exception handling.
3070         * cp-support.c: Use C++ exception handling.
3071         * cp-abi.c: Use C++ exception handling.
3072         * corelow.c: Use C++ exception handling.
3073         * completer.c: Use C++ exception handling.
3074         * compile/compile-object-run.c: Use C++ exception handling.
3075         * compile/compile-object-load.c: Use C++ exception handling.
3076         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3077         * compile/compile-c-symbols.c: Use C++ exception handling.
3078         * common/selftest.c: Use C++ exception handling.
3079         * common/new-op.c: Use C++ exception handling.
3080         * cli/cli-script.c: Use C++ exception handling.
3081         * cli/cli-interp.c: Use C++ exception handling.
3082         * cli/cli-cmds.c: Use C++ exception handling.
3083         * c-varobj.c: Use C++ exception handling.
3084         * btrace.c: Use C++ exception handling.
3085         * breakpoint.c: Use C++ exception handling.
3086         * break-catch-throw.c: Use C++ exception handling.
3087         * arch-utils.c: Use C++ exception handling.
3088         * amd64-tdep.c: Use C++ exception handling.
3089         * ada-valprint.c: Use C++ exception handling.
3090         * ada-typeprint.c: Use C++ exception handling.
3091         * ada-lang.c: Use C++ exception handling.
3092         * aarch64-tdep.c: Use C++ exception handling.
3093
3094 2019-04-08  Tom Tromey  <tom@tromey.com>
3095
3096         * xml-support.c (gdb_xml_parser::parse): Update.
3097         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3098         * value.c (show_convenience): Update.
3099         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3100         (test_parse_flags_qcs): Update.
3101         * thread.c (thr_try_catch_cmd): Update.
3102         * target.c (target_translate_tls_address): Update.
3103         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3104         (info_frame_command_core, frame_apply_command_count): Update.
3105         * rust-exp.y (rust_lex_exception_test): Update.
3106         * riscv-tdep.c (riscv_print_one_register_info): Update.
3107         * remote.c (remote_target::enable_btrace): Update.
3108         * record-btrace.c (record_btrace_enable_warn): Update.
3109         * python/py-utils.c (gdbpy_convert_exception): Update.
3110         * printcmd.c (do_one_display, print_variable_and_value): Update.
3111         * mi/mi-main.c (mi_print_exception): Update.
3112         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3113         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3114         * linux-nat.c (linux_nat_target::attach): Update.
3115         * linux-fork.c (class scoped_switch_fork_info): Update.
3116         * infrun.c (displaced_step_prepare): Update.
3117         * infcall.c (call_function_by_hand_dummy): Update.
3118         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3119         * gnu-v3-abi.c (print_one_vtable): Update.
3120         * frame.c (get_prev_frame_always): Update.
3121         * f-valprint.c (info_common_command_for_block): Update.
3122         * exec.c (try_open_exec_file): Update.
3123         * exceptions.c (print_exception, exception_print)
3124         (exception_fprintf, exception_print_same): Update.
3125         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3126         * dwarf-index-cache.c (index_cache::store)
3127         (index_cache::lookup_gdb_index): Update.
3128         * darwin-nat.c (maybe_cache_shell): Update.
3129         * cp-valprint.c (cp_print_value_fields): Update.
3130         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3131         (gcc_cplus_symbol_address): Update.
3132         * compile/compile-c-symbols.c (gcc_convert_symbol)
3133         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3134         * common/selftest.c: Update.
3135         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3136         a std::string.
3137         (exception_try_scope_entry, exception_try_scope_exit): Don't
3138         declare.
3139         (struct exception_try_scope): Remove.
3140         (TRY): Don't use exception_try_scope.
3141         (struct gdb_exception): Add constructor, operator=.
3142         <what>: New method.
3143         (struct gdb_exception_RETURN_MASK_ALL)
3144         (struct gdb_exception_RETURN_MASK_ERROR)
3145         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3146         (struct gdb_quit_bad_alloc): Update.
3147         * common/common-exceptions.c (exception_none): Change
3148         initializer.
3149         (struct catcher) <state, exception>: Initialize inline.
3150         <prev>: Remove member.
3151         (current_catcher): Remove.
3152         (catchers): New global.
3153         (exceptions_state_mc_init): Simplify.
3154         (catcher_pop): Remove.
3155         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3156         (try_scope_depth, exception_try_scope_entry)
3157         (exception_try_scope_exit): Remove.
3158         (throw_exception_sjlj): Update.
3159         (exception_messages, exception_messages_size): Remove.
3160         (throw_it): Simplify.
3161         (gdb_exception_sliced_copy): Remove.
3162         (throw_exception_cxx): Update.
3163         * cli/cli-script.c (script_from_file): Update.
3164         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3165         Update.
3166         * ada-valprint.c (ada_val_print): Update.
3167         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3168         (create_excep_cond_exprs): Update.
3169
3170 2019-04-08  Tom Tromey  <tom@tromey.com>
3171
3172         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3173         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3174         (TRY, CATCH, END_CATCH): Remove some definitions.
3175         * common/common-exceptions.c: Don't use GDB_XCPT.
3176         (catcher_list_size): Remove.
3177         (throw_exception, throw_it): Simplify.
3178
3179 2019-04-05  Tom Tromey  <tom@tromey.com>
3180
3181         Revert the header-sorting patch.
3182         * ft32-tdep.c: Revert.
3183         * frv-tdep.c: Revert.
3184         * frv-linux-tdep.c: Revert.
3185         * frame.c: Revert.
3186         * frame-unwind.c: Revert.
3187         * frame-base.c: Revert.
3188         * fork-child.c: Revert.
3189         * findvar.c: Revert.
3190         * findcmd.c: Revert.
3191         * filesystem.c: Revert.
3192         * filename-seen-cache.h: Revert.
3193         * filename-seen-cache.c: Revert.
3194         * fbsd-tdep.c: Revert.
3195         * fbsd-nat.h: Revert.
3196         * fbsd-nat.c: Revert.
3197         * f-valprint.c: Revert.
3198         * f-typeprint.c: Revert.
3199         * f-lang.c: Revert.
3200         * extension.h: Revert.
3201         * extension.c: Revert.
3202         * extension-priv.h: Revert.
3203         * expprint.c: Revert.
3204         * exec.h: Revert.
3205         * exec.c: Revert.
3206         * exceptions.c: Revert.
3207         * event-top.c: Revert.
3208         * event-loop.c: Revert.
3209         * eval.c: Revert.
3210         * elfread.c: Revert.
3211         * dwarf2read.h: Revert.
3212         * dwarf2read.c: Revert.
3213         * dwarf2loc.c: Revert.
3214         * dwarf2expr.h: Revert.
3215         * dwarf2expr.c: Revert.
3216         * dwarf2-frame.c: Revert.
3217         * dwarf2-frame-tailcall.c: Revert.
3218         * dwarf-index-write.h: Revert.
3219         * dwarf-index-write.c: Revert.
3220         * dwarf-index-common.c: Revert.
3221         * dwarf-index-cache.h: Revert.
3222         * dwarf-index-cache.c: Revert.
3223         * dummy-frame.c: Revert.
3224         * dtrace-probe.c: Revert.
3225         * disasm.h: Revert.
3226         * disasm.c: Revert.
3227         * disasm-selftests.c: Revert.
3228         * dictionary.c: Revert.
3229         * dicos-tdep.c: Revert.
3230         * demangle.c: Revert.
3231         * dcache.h: Revert.
3232         * dcache.c: Revert.
3233         * darwin-nat.h: Revert.
3234         * darwin-nat.c: Revert.
3235         * darwin-nat-info.c: Revert.
3236         * d-valprint.c: Revert.
3237         * d-namespace.c: Revert.
3238         * d-lang.c: Revert.
3239         * ctf.c: Revert.
3240         * csky-tdep.c: Revert.
3241         * csky-linux-tdep.c: Revert.
3242         * cris-tdep.c: Revert.
3243         * cris-linux-tdep.c: Revert.
3244         * cp-valprint.c: Revert.
3245         * cp-support.c: Revert.
3246         * cp-namespace.c: Revert.
3247         * cp-abi.c: Revert.
3248         * corelow.c: Revert.
3249         * corefile.c: Revert.
3250         * continuations.c: Revert.
3251         * completer.h: Revert.
3252         * completer.c: Revert.
3253         * complaints.c: Revert.
3254         * coffread.c: Revert.
3255         * coff-pe-read.c: Revert.
3256         * cli-out.h: Revert.
3257         * cli-out.c: Revert.
3258         * charset.c: Revert.
3259         * c-varobj.c: Revert.
3260         * c-valprint.c: Revert.
3261         * c-typeprint.c: Revert.
3262         * c-lang.c: Revert.
3263         * buildsym.c: Revert.
3264         * buildsym-legacy.c: Revert.
3265         * build-id.h: Revert.
3266         * build-id.c: Revert.
3267         * btrace.c: Revert.
3268         * bsd-uthread.c: Revert.
3269         * breakpoint.h: Revert.
3270         * breakpoint.c: Revert.
3271         * break-catch-throw.c: Revert.
3272         * break-catch-syscall.c: Revert.
3273         * break-catch-sig.c: Revert.
3274         * blockframe.c: Revert.
3275         * block.c: Revert.
3276         * bfin-tdep.c: Revert.
3277         * bfin-linux-tdep.c: Revert.
3278         * bfd-target.c: Revert.
3279         * bcache.c: Revert.
3280         * ax-general.c: Revert.
3281         * ax-gdb.h: Revert.
3282         * ax-gdb.c: Revert.
3283         * avr-tdep.c: Revert.
3284         * auxv.c: Revert.
3285         * auto-load.c: Revert.
3286         * arm-wince-tdep.c: Revert.
3287         * arm-tdep.c: Revert.
3288         * arm-symbian-tdep.c: Revert.
3289         * arm-pikeos-tdep.c: Revert.
3290         * arm-obsd-tdep.c: Revert.
3291         * arm-nbsd-tdep.c: Revert.
3292         * arm-nbsd-nat.c: Revert.
3293         * arm-linux-tdep.c: Revert.
3294         * arm-linux-nat.c: Revert.
3295         * arm-fbsd-tdep.c: Revert.
3296         * arm-fbsd-nat.c: Revert.
3297         * arm-bsd-tdep.c: Revert.
3298         * arch-utils.c: Revert.
3299         * arc-tdep.c: Revert.
3300         * arc-newlib-tdep.c: Revert.
3301         * annotate.h: Revert.
3302         * annotate.c: Revert.
3303         * amd64-windows-tdep.c: Revert.
3304         * amd64-windows-nat.c: Revert.
3305         * amd64-tdep.c: Revert.
3306         * amd64-sol2-tdep.c: Revert.
3307         * amd64-obsd-tdep.c: Revert.
3308         * amd64-obsd-nat.c: Revert.
3309         * amd64-nbsd-tdep.c: Revert.
3310         * amd64-nbsd-nat.c: Revert.
3311         * amd64-nat.c: Revert.
3312         * amd64-linux-tdep.c: Revert.
3313         * amd64-linux-nat.c: Revert.
3314         * amd64-fbsd-tdep.c: Revert.
3315         * amd64-fbsd-nat.c: Revert.
3316         * amd64-dicos-tdep.c: Revert.
3317         * amd64-darwin-tdep.c: Revert.
3318         * amd64-bsd-nat.c: Revert.
3319         * alpha-tdep.c: Revert.
3320         * alpha-obsd-tdep.c: Revert.
3321         * alpha-nbsd-tdep.c: Revert.
3322         * alpha-mdebug-tdep.c: Revert.
3323         * alpha-linux-tdep.c: Revert.
3324         * alpha-linux-nat.c: Revert.
3325         * alpha-bsd-tdep.c: Revert.
3326         * alpha-bsd-nat.c: Revert.
3327         * aix-thread.c: Revert.
3328         * agent.c: Revert.
3329         * addrmap.c: Revert.
3330         * ada-varobj.c: Revert.
3331         * ada-valprint.c: Revert.
3332         * ada-typeprint.c: Revert.
3333         * ada-tasks.c: Revert.
3334         * ada-lang.c: Revert.
3335         * aarch64-tdep.c: Revert.
3336         * aarch64-ravenscar-thread.c: Revert.
3337         * aarch64-newlib-tdep.c: Revert.
3338         * aarch64-linux-tdep.c: Revert.
3339         * aarch64-linux-nat.c: Revert.
3340         * aarch64-fbsd-tdep.c: Revert.
3341         * aarch64-fbsd-nat.c: Revert.
3342         * aarch32-linux-nat.c: Revert.
3343
3344 2019-04-05  Tom Tromey  <tom@tromey.com>
3345
3346         * ft32-tdep.c: Sort headers.
3347         * frv-tdep.c: Sort headers.
3348         * frv-linux-tdep.c: Sort headers.
3349         * frame.c: Sort headers.
3350         * frame-unwind.c: Sort headers.
3351         * frame-base.c: Sort headers.
3352         * fork-child.c: Sort headers.
3353         * findvar.c: Sort headers.
3354         * findcmd.c: Sort headers.
3355         * filesystem.c: Sort headers.
3356         * filename-seen-cache.h: Sort headers.
3357         * filename-seen-cache.c: Sort headers.
3358         * fbsd-tdep.c: Sort headers.
3359         * fbsd-nat.h: Sort headers.
3360         * fbsd-nat.c: Sort headers.
3361         * f-valprint.c: Sort headers.
3362         * f-typeprint.c: Sort headers.
3363         * f-lang.c: Sort headers.
3364         * extension.h: Sort headers.
3365         * extension.c: Sort headers.
3366         * extension-priv.h: Sort headers.
3367         * expprint.c: Sort headers.
3368         * exec.h: Sort headers.
3369         * exec.c: Sort headers.
3370         * exceptions.c: Sort headers.
3371         * event-top.c: Sort headers.
3372         * event-loop.c: Sort headers.
3373         * eval.c: Sort headers.
3374         * elfread.c: Sort headers.
3375         * dwarf2read.h: Sort headers.
3376         * dwarf2read.c: Sort headers.
3377         * dwarf2loc.c: Sort headers.
3378         * dwarf2expr.h: Sort headers.
3379         * dwarf2expr.c: Sort headers.
3380         * dwarf2-frame.c: Sort headers.
3381         * dwarf2-frame-tailcall.c: Sort headers.
3382         * dwarf-index-write.h: Sort headers.
3383         * dwarf-index-write.c: Sort headers.
3384         * dwarf-index-common.c: Sort headers.
3385         * dwarf-index-cache.h: Sort headers.
3386         * dwarf-index-cache.c: Sort headers.
3387         * dummy-frame.c: Sort headers.
3388         * dtrace-probe.c: Sort headers.
3389         * disasm.h: Sort headers.
3390         * disasm.c: Sort headers.
3391         * disasm-selftests.c: Sort headers.
3392         * dictionary.c: Sort headers.
3393         * dicos-tdep.c: Sort headers.
3394         * demangle.c: Sort headers.
3395         * dcache.h: Sort headers.
3396         * dcache.c: Sort headers.
3397         * darwin-nat.h: Sort headers.
3398         * darwin-nat.c: Sort headers.
3399         * darwin-nat-info.c: Sort headers.
3400         * d-valprint.c: Sort headers.
3401         * d-namespace.c: Sort headers.
3402         * d-lang.c: Sort headers.
3403         * ctf.c: Sort headers.
3404         * csky-tdep.c: Sort headers.
3405         * csky-linux-tdep.c: Sort headers.
3406         * cris-tdep.c: Sort headers.
3407         * cris-linux-tdep.c: Sort headers.
3408         * cp-valprint.c: Sort headers.
3409         * cp-support.c: Sort headers.
3410         * cp-namespace.c: Sort headers.
3411         * cp-abi.c: Sort headers.
3412         * corelow.c: Sort headers.
3413         * corefile.c: Sort headers.
3414         * continuations.c: Sort headers.
3415         * completer.h: Sort headers.
3416         * completer.c: Sort headers.
3417         * complaints.c: Sort headers.
3418         * coffread.c: Sort headers.
3419         * coff-pe-read.c: Sort headers.
3420         * cli-out.h: Sort headers.
3421         * cli-out.c: Sort headers.
3422         * charset.c: Sort headers.
3423         * c-varobj.c: Sort headers.
3424         * c-valprint.c: Sort headers.
3425         * c-typeprint.c: Sort headers.
3426         * c-lang.c: Sort headers.
3427         * buildsym.c: Sort headers.
3428         * buildsym-legacy.c: Sort headers.
3429         * build-id.h: Sort headers.
3430         * build-id.c: Sort headers.
3431         * btrace.c: Sort headers.
3432         * bsd-uthread.c: Sort headers.
3433         * breakpoint.h: Sort headers.
3434         * breakpoint.c: Sort headers.
3435         * break-catch-throw.c: Sort headers.
3436         * break-catch-syscall.c: Sort headers.
3437         * break-catch-sig.c: Sort headers.
3438         * blockframe.c: Sort headers.
3439         * block.c: Sort headers.
3440         * bfin-tdep.c: Sort headers.
3441         * bfin-linux-tdep.c: Sort headers.
3442         * bfd-target.c: Sort headers.
3443         * bcache.c: Sort headers.
3444         * ax-general.c: Sort headers.
3445         * ax-gdb.h: Sort headers.
3446         * ax-gdb.c: Sort headers.
3447         * avr-tdep.c: Sort headers.
3448         * auxv.c: Sort headers.
3449         * auto-load.c: Sort headers.
3450         * arm-wince-tdep.c: Sort headers.
3451         * arm-tdep.c: Sort headers.
3452         * arm-symbian-tdep.c: Sort headers.
3453         * arm-pikeos-tdep.c: Sort headers.
3454         * arm-obsd-tdep.c: Sort headers.
3455         * arm-nbsd-tdep.c: Sort headers.
3456         * arm-nbsd-nat.c: Sort headers.
3457         * arm-linux-tdep.c: Sort headers.
3458         * arm-linux-nat.c: Sort headers.
3459         * arm-fbsd-tdep.c: Sort headers.
3460         * arm-fbsd-nat.c: Sort headers.
3461         * arm-bsd-tdep.c: Sort headers.
3462         * arch-utils.c: Sort headers.
3463         * arc-tdep.c: Sort headers.
3464         * arc-newlib-tdep.c: Sort headers.
3465         * annotate.h: Sort headers.
3466         * annotate.c: Sort headers.
3467         * amd64-windows-tdep.c: Sort headers.
3468         * amd64-windows-nat.c: Sort headers.
3469         * amd64-tdep.c: Sort headers.
3470         * amd64-sol2-tdep.c: Sort headers.
3471         * amd64-obsd-tdep.c: Sort headers.
3472         * amd64-obsd-nat.c: Sort headers.
3473         * amd64-nbsd-tdep.c: Sort headers.
3474         * amd64-nbsd-nat.c: Sort headers.
3475         * amd64-nat.c: Sort headers.
3476         * amd64-linux-tdep.c: Sort headers.
3477         * amd64-linux-nat.c: Sort headers.
3478         * amd64-fbsd-tdep.c: Sort headers.
3479         * amd64-fbsd-nat.c: Sort headers.
3480         * amd64-dicos-tdep.c: Sort headers.
3481         * amd64-darwin-tdep.c: Sort headers.
3482         * amd64-bsd-nat.c: Sort headers.
3483         * alpha-tdep.c: Sort headers.
3484         * alpha-obsd-tdep.c: Sort headers.
3485         * alpha-nbsd-tdep.c: Sort headers.
3486         * alpha-mdebug-tdep.c: Sort headers.
3487         * alpha-linux-tdep.c: Sort headers.
3488         * alpha-linux-nat.c: Sort headers.
3489         * alpha-bsd-tdep.c: Sort headers.
3490         * alpha-bsd-nat.c: Sort headers.
3491         * aix-thread.c: Sort headers.
3492         * agent.c: Sort headers.
3493         * addrmap.c: Sort headers.
3494         * ada-varobj.c: Sort headers.
3495         * ada-valprint.c: Sort headers.
3496         * ada-typeprint.c: Sort headers.
3497         * ada-tasks.c: Sort headers.
3498         * ada-lang.c: Sort headers.
3499         * aarch64-tdep.c: Sort headers.
3500         * aarch64-ravenscar-thread.c: Sort headers.
3501         * aarch64-newlib-tdep.c: Sort headers.
3502         * aarch64-linux-tdep.c: Sort headers.
3503         * aarch64-linux-nat.c: Sort headers.
3504         * aarch64-fbsd-tdep.c: Sort headers.
3505         * aarch64-fbsd-nat.c: Sort headers.
3506         * aarch32-linux-nat.c: Sort headers.
3507
3508 2019-04-04  Tom Tromey  <tom@tromey.com>
3509
3510         * varobj.c (varobj_create): Update.
3511         * rust-exp.y (struct rust_parser) <update_innermost_block,
3512         lookup_symbol>: New methods.
3513         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3514         Rename.
3515         (rust_parser::rust_lookup_type)
3516         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3517         * printcmd.c (display_command, do_one_display): Update.
3518         * parser-defs.h (struct parser_state) <parser_state>: Add
3519         "tracker" parameter.
3520         (block_tracker): New member.
3521         (class innermost_block_tracker) <innermost_block_tracker>: Add
3522         "types" parameter.
3523         <reset>: Remove method.
3524         (innermost_block): Don't declare.
3525         (null_post_parser): Update.
3526         * parse.c (innermost_block): Remove global.
3527         (write_dollar_variable): Update.
3528         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3529         Remove "tracker_types" parameter.
3530         (parse_expression): Add "tracker" parameter.
3531         (parse_expression_for_completion): Update.
3532         (null_post_parser): Add "tracker" parameter.
3533         * p-exp.y: Update rules.
3534         * m2-exp.y: Update rules.
3535         * language.h (struct language_defn) <la_post_parser>: Add
3536         "tracker" parameter.
3537         * go-exp.y: Update rules.
3538         * f-exp.y: Update rules.
3539         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3540         parameter.
3541         * d-exp.y: Update rules.
3542         * c-exp.y: Update rules.
3543         * breakpoint.c (set_breakpoint_condition): Create an
3544         innermost_block_tracker.
3545         (watch_command_1): Likewise.
3546         * ada-lang.c (resolve): Add "tracker" parameter.
3547         (resolve_subexp): Likewise.
3548         * ada-exp.y (write_var_from_sym): Update.
3549
3550 2019-04-04  Tom Tromey  <tom@tromey.com>
3551
3552         * type-stack.h: New file.
3553         * type-stack.c: New file.
3554         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3555         type-stack.h.
3556         (insert_into_type_stack, insert_type, push_type, push_type_int)
3557         (insert_type_address_space, pop_type, pop_type_int)
3558         (pop_typelist, pop_type_stack, append_type_stack)
3559         (push_type_stack, get_type_stack, push_typelist)
3560         (follow_type_instance_flags, follow_types): Don't declare.
3561         * parse.c (type_stack): Remove global.
3562         (parse_exp_in_context): Update.
3563         (insert_into_type_stack, insert_type, push_type, push_type_int)
3564         (insert_type_address_space, pop_type, pop_type_int)
3565         (pop_typelist, pop_type_stack, append_type_stack)
3566         (push_type_stack, get_type_stack, push_typelist)
3567         (follow_type_instance_flags, follow_types): Remove (moved to
3568         type-stack.c).
3569         * f-exp.y (type_stack): New global.
3570         Update rules.
3571         (push_kind_type, f_parse): Update.
3572         * d-exp.y (type_stack): New global.
3573         Update rules.
3574         (d_parse): Update.
3575         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3576         Update rules.
3577         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3578         (HFILES_NO_SRCDIR): Add type-stack.h.
3579
3580 2019-04-04  Tom Tromey  <tom@tromey.com>
3581
3582         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3583         (rust_parser::convert_ast_to_expression, rust_parse)
3584         (rust_lex_test_completion, rust_lex_tests): Update.
3585         * parser-defs.h (struct expr_completion_state): New.
3586         (struct parser_state) <parser_state>: Add completion parameter.
3587         <mark_struct_expression, mark_completion_tag>: New methods.
3588         <parse_completion, m_completion_state>: New members.
3589         (prefixify_expression, null_post_parser): Update.
3590         (mark_struct_expression, mark_completion_tag): Don't declare.
3591         * parse.c (parse_completion, expout_last_struct)
3592         (expout_tag_completion_type, expout_completion_name): Remove
3593         globals.
3594         (parser_state::mark_struct_expression)
3595         (parser_state::mark_completion_tag): Now methods.
3596         (prefixify_expression): Add last_struct parameter.
3597         (prefixify_subexp): Likewise.
3598         (parse_exp_1): Update.
3599         (parse_exp_in_context): Add cstate parameter.  Update.
3600         (parse_expression_for_completion): Create an
3601         expr_completion_state.
3602         (null_post_parser): Add "completion" parameter.
3603         * p-exp.y: Update rules.
3604         (yylex): Update.
3605         * language.h (struct language_defn) <la_post_parser>: Add
3606         "completing" parameter.
3607         * go-exp.y: Update rules.
3608         (lex_one_token): Update.
3609         * expression.h (parse_completion): Don't declare.
3610         * d-exp.y: Update rules.
3611         (lex_one_token): Update rules.
3612         * c-exp.y: Update rules.
3613         (lex_one_token): Update.
3614         * ada-lang.c (resolve): Add "parse_completion" parameter.
3615         (resolve_subexp): Likewise.
3616         (ada_resolve_function): Likewise.
3617
3618 2019-04-04  Tom Tromey  <tom@tromey.com>
3619
3620         * parser-defs.h (struct parser_state) <start_arglist,
3621         end_arglist>: New methods.
3622         <arglist_len, m_funcall_chain>: New members.
3623         (arglist_len, start_arglist, end_arglist): Don't declare.
3624         * parse.c (arglist_len, funcall_chain): Remove global.
3625         (start_arglist, end_arglist): Remove functions.
3626         (parse_exp_in_context): Update.
3627         * p-exp.y: Update rules.
3628         * m2-exp.y: Update rules.
3629         * go-exp.y: Update rules.
3630         * f-exp.y: Update rules.
3631         * d-exp.y: Update rules.
3632         * c-exp.y: Update rules.
3633
3634 2019-04-04  Tom Tromey  <tom@tromey.com>
3635
3636         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3637         lex_operator, push_back>: New methods.
3638         Update all rules.
3639         (rust_parser::lex_hex, lex_escape): Rename and update.
3640         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3641         (rust_parser::lex_operator): Rename and update.
3642         (rust_parser::lex_number, rustyylex, rustyyerror)
3643         (rust_lex_test_init, rust_lex_test_sequence)
3644         (rust_lex_test_push_back, rust_lex_tests): Update.
3645         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3646         parameter.
3647         <lexptr, prev_lexptr>: New members.
3648         (lexptr, prev_lexptr): Don't declare.
3649         * parse.c (lexptr, prev_lexptr): Remove globals.
3650         (parse_exp_in_context): Update.
3651         * p-exp.y (yylex, yyerror): Update.
3652         * m2-exp.y (parse_number, yylex, yyerror): Update.
3653         * go-exp.y (lex_one_token, yyerror): Update.
3654         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3655         * d-exp.y (lex_one_token, yyerror): Update.
3656         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3657         (lex_one_token, yyerror): Update.
3658         * ada-lex.l (YY_INPUT): Update.
3659         (rewind_to_char): Update.
3660         * ada-exp.y (yyerror): Update.
3661
3662 2019-04-04  Tom Tromey  <tom@tromey.com>
3663
3664         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3665         * parser-defs.h (struct parser_state) <parser_state>: Add new
3666         parameter.
3667         <comma_terminates>: New member.
3668         (comma_terminates): Don't declare global.
3669         * parse.c (comma_terminates): Remove global.
3670         (parse_exp_in_context): Update.
3671         * p-exp.y (yylex): Update.
3672         * m2-exp.y (yylex): Update.
3673         * go-exp.y (lex_one_token): Update.
3674         * f-exp.y (yylex): Update.
3675         * d-exp.y (lex_one_token): Update.
3676         * c-exp.y (lex_one_token): Update.
3677         * ada-lex.l: Update.
3678
3679 2019-04-04  Tom Tromey  <tom@tromey.com>
3680
3681         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3682         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3683         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3684         * parser-defs.h (paren_depth): Don't declare.
3685         * parse.c (paren_depth): Remove global.
3686         (parse_exp_in_context): Update.
3687         * p-exp.y (paren_depth): New global.
3688         (pascal_parse): Initialize it.
3689         * m2-exp.y (paren_depth): New global.
3690         (m2_parse): Initialize it.
3691         * go-exp.y (paren_depth): New global.
3692         (go_parse): Initialize it.
3693         * f-exp.y (paren_depth): New global.
3694         (f_parse): Initialize it.
3695         * d-exp.y (paren_depth): New global.
3696         (d_parse): Initialize it.
3697         * c-exp.y (paren_depth): New global.
3698         (c_parse): Initialize it.
3699         * ada-lex.l (paren_depth): New global.
3700         (lexer_init): Initialize it.
3701
3702 2019-04-04  Tom Tromey  <tom@tromey.com>
3703
3704         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3705         (rust_parser::convert_ast_to_type)
3706         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3707         * parser-defs.h (struct parser_state) <parser_state>: Add
3708         parameters.  Initialize new members.
3709         <expression_context_block, expression_context_pc>: New members.
3710         * parse.c (expression_context_block, expression_context_pc):
3711         Remove globals.
3712         (parse_exp_in_context): Update.
3713         * p-exp.y: Update all rules.
3714         (yylex): Update.
3715         * m2-exp.y: Update all rules.
3716         (yylex): Update.
3717         * go-exp.y (yylex): Update.
3718         * f-exp.y (yylex): Update.
3719         * d-exp.y: Update all rules.
3720         (yylex): Update.
3721         * c-exp.y: Update all rules.
3722         (lex_one_token, classify_name, yylex, c_parse): Update.
3723         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3724
3725 2019-04-04  Tom Tromey  <tom@tromey.com>
3726
3727         * gdbarch.h, gdbarch.c: Rebuild.
3728         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3729         * stap-probe.h:
3730         (struct stap_parse_info): Replace "parser_state" with
3731         "expr_builder".
3732         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3733         (parser_state): New class.
3734         * parse.c (expr_builder): Rename.
3735         (expr_builder::release): Rename.
3736         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3737         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3738         (write_exp_elt_longcst, write_exp_elt_floatcst)
3739         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3740         (write_exp_string_vector, write_exp_bitstring)
3741         (write_exp_msymbol, mark_struct_expression)
3742         (write_dollar_variable)
3743         (insert_type_address_space, increase_expout_size): Replace
3744         "parser_state" with "expr_builder".
3745         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3746         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3747         "parser_state" with "expr_builder".
3748
3749 2019-04-04  Tom Tromey  <tom@tromey.com>
3750
3751         * rust-exp.y: Replace "parse_language" with method call.
3752         * p-exp.y:
3753         (yylex): Replace "parse_language" with method call.
3754         * m2-exp.y:
3755         (yylex): Replace "parse_language" with method call.
3756         * go-exp.y (classify_name): Replace "parse_language" with method
3757         call.
3758         * f-exp.y (yylex): Replace "parse_language" with method call.
3759         * d-exp.y (lex_one_token): Replace "parse_language" with method
3760         call.
3761         * c-exp.y:
3762         (lex_one_token, classify_name, yylex): Replace "parse_language"
3763         with method call.
3764         * ada-exp.y (find_primitive_type, type_char)
3765         (type_system_address): Replace "parse_language" with method call.
3766
3767 2019-04-04  Tom Tromey  <tom@tromey.com>
3768
3769         * rust-exp.y: Replace "parse_gdbarch" with method call.
3770         * parse.c (write_dollar_variable, insert_type_address_space):
3771         Replace "parse_gdbarch" with method call.
3772         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3773         call.
3774         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3775         call.
3776         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3777         "parse_gdbarch" with method call.
3778         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3779         with method call.
3780         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3781         "parse_gdbarch" with method call.
3782         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3783         "parse_gdbarch" with method call.
3784         * c-exp.y (parse_type, parse_number, classify_name): Replace
3785         "parse_gdbarch" with method call.
3786         * ada-lex.l: Replace "parse_gdbarch" with method call.
3787         * ada-exp.y (parse_type, find_primitive_type, type_char)
3788         (type_system_address): Replace "parse_gdbarch" with method call.
3789
3790 2019-04-04  Tom Tromey  <tom@tromey.com>
3791
3792         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3793         * stap-probe.c (stap_parse_argument): Update.
3794         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3795         initial_size parameter.
3796         * rust-exp.y (rust_lex_tests): Update.
3797         * parse.c (parser_state): Update.
3798         (parse_exp_in_context): Update.
3799         * parser-defs.h (struct parser_state) <parser_state>: Remove
3800         "initial_size" parameter.
3801
3802 2019-04-04  Tom Tromey  <tom@tromey.com>
3803
3804         * parser-defs.h (increase_expout_size): Don't declare.
3805         * parse.c (increase_expout_size): Now static.
3806
3807 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3808
3809         * gnu-nat.c (gnu_nat_target::wait): Fix
3810         target_waitstatus_to_string call.
3811
3812 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3813
3814         * eval.c (evaluate_subexp_standard): Handle internal functions
3815         during Fortran function call handling.
3816
3817 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3818
3819         * NEWS: Mention new internal functions.
3820         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3821         (read_base_type): Use dwarf2_init_complex_target_type.
3822         * value.c (creal_internal_fn): New function.
3823         (cimag_internal_fn): New function.
3824         (_initialize_values): Register new internal functions.
3825
3826 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3827
3828         * infrun.c (stop_all_threads): If debug_infrun, always
3829         trace the wait status after wait_one, using
3830         target_waitstatus_to_string and target_pid_to_str.
3831         (handle_inferior_event): Replace various trace of
3832         wait status kind by a single trace.
3833         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3834         wait status kind image by target_waitstatus_to_string.
3835         * target/waitstatus.c (target_waitstatus_to_string): Fix
3836         obsolete comment.
3837
3838 2019-04-01  Tom Tromey  <tromey@adacore.com>
3839
3840         PR symtab/23331:
3841         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3842
3843 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3844             Pedro Alves  <palves@redhat.com>
3845
3846         * top.c (quit_force): Call 'finalize_values'.
3847         * value.c (finalize_values): New function.
3848         * value.h (finalize_values): Declare.
3849
3850 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3851
3852         * NEWS: Announce $_gdb_major and $_gdb_minor.
3853
3854         * top.c (init_gdb_version_vars): New function.
3855         (gdb_init): Call init_gdb_version_vars.
3856
3857 2019-03-29  Tom Tromey  <tromey@adacore.com>
3858
3859         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3860         help text.  Remove dead code.
3861
3862 2019-03-29  Keith Seitz  <keiths@redhat.com>
3863
3864         From Siddhesh Poyarekar:
3865         * f-lang.h (f77_get_upperbound): Return LONGEST.
3866         (f77_get_lowerbound): Likewise.
3867         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3868         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3869         print them.
3870         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3871         plongest to format print it.
3872         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3873         (f77_get_upperbound): Likewise.
3874         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3875         LOWER_BOUND to LONGEST.
3876         (f77_create_arrayprint_offset_tbl): Likewise.
3877
3878 2019-03-29  Keith Seitz  <keiths@redhat.com>
3879
3880         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3881         %s/pulongest for TYPE_LENGTH instead of %d in format
3882         strings.
3883         * ada-typerint.c (ada_print_type): Likewise.
3884         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3885         * compile/compile-c-support.c (generate_register_struct): Likewise.
3886         * gdbtypes.c (recursive_dump_type): Likewise.
3887         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3888         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3889         instead of %d in format strings.
3890         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3891         to std::min to ULONGEST.
3892         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3893         instead of %d in format strings.
3894         * tracepoint.c (info_scope_command): Likewise.
3895         * typeprint.c (print_offset_data::update)
3896         (print_offset_data::finish): Likewise.
3897         * xtensa-tdep.c (xtensa_store_return_value)
3898         (xtensa_push_dummy_call): Likewise.
3899
3900 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3901
3902         * windows-nat.c (display_selector): Fixed format specifications
3903         for 64-bit Cygwin.
3904
3905 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3906
3907         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3908
3909 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3910
3911         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3912         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3913         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3914         (nios2_linux_init_abi): Install it.
3915
3916 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3917
3918         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3919
3920 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3921
3922         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3923
3924 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3925             Tom Tromey  <tromey@adacore.com>
3926
3927         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3928
3929 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3930
3931         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3932         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3933         method to compute the bounds of range types. Also print "[evaluated]"
3934         if the bounds' values come from a dynamic evaluation.
3935
3936 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3937
3938         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3939         whitespace when pretty printing is on.
3940
3941 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3942
3943         * ppc-linux-nat.c: Add include.
3944
3945 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3946
3947         * NEWS: Mention AArch64 Pointer Authentication.
3948
3949 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3950
3951         * arm-linux-nat.c: Add include.
3952
3953 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3954
3955         * source-cache.c (source_cache::get_source_lines): Re-read
3956         fullname after calling open_source_file.
3957
3958 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3959
3960         * NEWS: Mention TLS support for FreeBSD.
3961
3962 2019-03-25  Tom Tromey  <tromey@adacore.com>
3963
3964         * minsyms.c (BUNCH_SIZE): Update comment.
3965         (~minimal_symbol_reader): Remove old comment.
3966         (compact_minimal_symbols): Update comment.
3967         (minimal_symbol_reader::install): Remove old comment.  Update
3968         other comments.
3969
3970 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3971
3972         * s390-linux-nat.c: Add include.
3973
3974 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3975
3976         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3977         Call linux_get_hwcap.
3978         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3979         Likewise.
3980         (aarch64_linux_get_hwcap): Remove function.
3981         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3982         declaration.
3983         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3984         linux_get_hwcap.
3985         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3986         * linux-tdep.c (linux_get_hwcap): Add function.
3987         (linux_get_hwcap2): Likewise.
3988         * linux-tdep.h (linux_get_hwcap): Add declaration.
3989         (linux_get_hwcap2): Likewise.
3990         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3991         (ppc_linux_get_hwcap2): Likewise.
3992         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3993         linux_get_hwcap.
3994         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3995         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3996         (ppc_linux_nat_target::read_description): Likewise.
3997         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3998         * s390-linux-nat.c: Likewise.
3999         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4000
4001 2019-03-24  Tom Tromey  <tom@tromey.com>
4002
4003         * ada-lang.c (standard_lookup): Simplify initialization.
4004         (ada_lookup_symbol_nonlocal): Simplify return.
4005         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4006         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4007         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4008         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4009         initialization.
4010         * solib.c (solib_global_lookup): Simplify.
4011         * symtab.c (null_block_symbol): Remove.
4012         (symbol_cache_lookup): Simplify returns.
4013         (lookup_language_this): Simplify returns.
4014         (lookup_symbol_aux): Simplify return.
4015         (lookup_local_symbol): Simplify returns.
4016         (lookup_global_symbol_from_objfile): Simplify return.
4017         (lookup_symbol_in_objfile_symtabs)
4018         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4019         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4020         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4021         * cp-namespace.c (cp_lookup_bare_symbol)
4022         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4023         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4024         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4025         (cp_lookup_symbol_via_imports): Simplify initialization.
4026         (find_symbol_in_baseclass): Likewise.
4027         * symtab.h (null_block_symbol): Remove.
4028         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4029         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4030         (d_lookup_symbol_module): Likewise.
4031         (find_symbol_in_baseclass): Simplify initialization.
4032
4033 2019-03-24  Tom Tromey  <tom@tromey.com>
4034
4035         * expression.h: Don't include symtab.h.
4036         (struct block): Forward declare.
4037
4038 2019-03-24  Tom Tromey  <tom@tromey.com>
4039
4040         * c-exp.y (typebase): Remove casts.
4041         * gdbtypes.c (lookup_unsigned_typename, )
4042         (lookup_signed_typename): Remove cast.
4043         * eval.c (parse_to_comma_and_eval): Remove cast.
4044         * parse.c (write_dollar_variable): Remove cast.
4045         * block.h (struct block) <superblock>: Now const.
4046         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4047         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4048         (map_block): Make "block" const.
4049         * symfile.h (struct quick_symbol_functions)
4050         <map_matching_symbols>: Constify block argument to "callback".
4051         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4052         const.
4053         (find_pc_sect_compunit_symtab): Make "b" const.
4054         (find_symbol_at_address): Likewise.
4055         (search_symbols): Likewise.
4056         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4057         (dw2_debug_names_lookup_symbol): Likewise.
4058         (dw2_map_matching_symbols): Update.
4059         * p-valprint.c (pascal_val_print): Remove "block".
4060         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4061         (aux_add_nonlocal_symbols): Make "block" const.
4062         (resolve_subexp): Remove cast.
4063         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4064         const.
4065         (iterate_over_file_blocks): Likewise.
4066         * f-exp.y (%union) <bval>: Remove.
4067         * coffread.c (patch_opaque_types): Make "b" const.
4068         * spu-tdep.c (spu_catch_start): Make "block" const.
4069         * c-valprint.c (print_unpacked_pointer): Remove "block".
4070         * symmisc.c (dump_symtab_1): Make "b" const.
4071         (block_depth): Make "block" const.
4072         * d-exp.y (%union) <bval>: Remove.
4073         * cp-support.h (cp_lookup_rtti_type): Update.
4074         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4075         * psymtab.c (psym_lookup_symbol): Make "block" const.
4076         (maintenance_check_psymtabs): Make "b" const.
4077         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4078         (enumerate_locals, enumerate_args): Update.
4079         * python/py-symtab.c (stpy_global_block): Make "block" const.
4080         (stpy_static_block): Likewise.
4081         * inline-frame.c (block_starting_point_at): Make "new_block"
4082         const.
4083         * block.c (find_block_in_blockvector): Make return type const.
4084         (blockvector_for_pc_sect): Make "b" const.
4085         (find_block_in_blockvector): Make "b" const.
4086
4087 2019-03-23  Tom Tromey  <tom@tromey.com>
4088
4089         * varobj.c (varobj_create): Update.
4090         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4091         * printcmd.c (display_command, do_one_display): Don't reset
4092         innermost_block.
4093         * parser-defs.h (enum innermost_block_tracker_type): Move to
4094         expression.h.
4095         (innermost_block): Update comment.
4096         * parse.c (parse_exp_1): Add tracker_types parameter.
4097         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4098         tracker_types parameter.  Reset innermost_block.
4099         (parse_exp_in_context): Remove.
4100         (parse_expression_for_completion): Update.
4101         * objfiles.c (~objfile): Don't reset expression_context_block or
4102         innermost_block.
4103         * expression.h (enum innermost_block_tracker_type): Move from
4104         parser-defs.h.
4105         (parse_exp_1): Add tracker_types parameter.
4106         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4107         reset innermost_block.
4108
4109 2019-03-23  Tom Tromey  <tom@tromey.com>
4110
4111         * objfiles.h: Include bcache.h.
4112
4113 2019-03-23  Tom Tromey  <tom@tromey.com>
4114
4115         * linespec.c (get_current_search_block): Use
4116         scoped_restore_current_language.
4117         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4118
4119 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4120             Jiong Wang  <jiong.wang@arm.com>
4121
4122         * aarch64-linux-tdep.c
4123         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4124         section.
4125         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4126
4127 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4128             Jiong Wang  <jiong.wang@arm.com>
4129
4130         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4131         instructions.
4132         (aarch64_analyze_prologue_test): Add PACIASP test.
4133         (aarch64_prologue_prev_register): Unmask PC value.
4134
4135 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4136             Jiong Wang  <jiong.wang@arm.com>
4137
4138         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4139         (aarch64_dwarf2_prev_register): Unmask PC value.
4140         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4141         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4142         DW_CFA_AARCH64_negate_ra_state.
4143         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4144
4145 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4146             Jiong Wang  <jiong.wang@arm.com>
4147
4148         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4149         registers.
4150         (aarch64_pseudo_register_name): Likewise.
4151         (aarch64_pseudo_register_type): Likewise.
4152         (aarch64_pseudo_register_reggroup_p): Likewise.
4153         (aarch64_gdbarch_init): Add pauth registers.
4154         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4155         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4156         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4157         (struct gdbarch_tdep): Add regnum for ra_state.
4158
4159 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4160             Jiong Wang  <jiong.wang@arm.com>
4161
4162         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4163
4164 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4165             Jiong Wang  <jiong.wang@arm.com>
4166
4167         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4168         function.
4169         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4170         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4171         (aarch64_gdbarch_init): Add puth registers.
4172         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4173         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4174         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4175
4176 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4177             Jiong Wang  <jiong.wang@arm.com>
4178
4179         * aarch64-linux-nat.c
4180         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4181         * aarch64-linux-tdep.c
4182         (aarch64_linux_core_read_description): Likewise.
4183         (aarch64_linux_get_hwcap): New function.
4184         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4185         (aarch64_linux_get_hwcap): New declaration.
4186
4187 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4188             Jiong Wang  <jiong.wang@arm.com>
4189
4190         * aarch64-linux-nat.c
4191         (aarch64_linux_nat_target::read_description): Add pauth param.
4192         * aarch64-linux-tdep.c
4193         (aarch64_linux_core_read_description): Likewise.
4194         * aarch64-tdep.c (struct target_desc): Add in pauth.
4195         (aarch64_read_description): Add pauth param.
4196         (aarch64_gdbarch_init): Likewise.
4197         * aarch64-tdep.h (aarch64_read_description): Likewise.
4198         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4199         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4200         * features/Makefile: Add new files.
4201         * features/aarch64-pauth.c: New file.
4202         * features/aarch64-pauth.xml: New file.
4203
4204 2019-03-20  Tom Tromey  <tromey@adacore.com>
4205
4206         * infrun.c (handle_inferior_event): Rename from
4207         handle_inferior_event_1.  Create a scoped_value_mark.
4208         (handle_inferior_event): Remove.
4209
4210 2019-03-19  Tom Tromey  <tromey@adacore.com>
4211
4212         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4213         * infrun.h (print_stop_event): Add "displays" parameter.
4214         * infrun.c (print_stop_event): Add "displays" parameter.
4215
4216 2019-03-19  Pedro Alves  <palves@redhat.com>
4217
4218         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4219         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4220         to -1.  Fix TABs vs spaces.
4221         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4222         * tui/tui-out.h (tui_ui_out) Add intro comments.
4223         <m_line, m_start_of_line>: In-class initialize, and add describing
4224         comment.
4225
4226 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4227
4228         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4229         variable names.
4230         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4231
4232 2019-03-18  Pedro Alves  <palves@redhat.com>
4233             Eli Zaretskii <eliz@gnu.org>
4234
4235         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4236         m_line and m_start_of_line.
4237
4238 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4239
4240         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4241         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4242         it returns a newline.  This fixes a regression in TU mode, whereby
4243         the next line is output on the same screen line as the user input.
4244
4245 2019-03-18  Tom Tromey  <tromey@adacore.com>
4246
4247         * minsyms.c (minimal_symbol_reader::install): Remove call to
4248         obstack_blank.
4249
4250 2019-03-18  Pedro Alves  <palves@redhat.com>
4251
4252         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4253         New globals.
4254         (apply_style): New, factored out from ...
4255         (apply_ansi_escape): ... this.  Handle reverse video mode.
4256         (tui_set_reverse_mode): New function.
4257         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4258         * tui/tui-winsource.c (tui_show_source_line): Use
4259         tui_set_reverse_mode instead of setting A_STANDOUT.
4260         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4261         New setter methods.
4262
4263 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4264
4265         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4266         Handle tabs.
4267
4268 2019-03-18  Tom Tromey  <tromey@adacore.com>
4269
4270         * ada-lang.c (empty_array): Add "high" parameter.
4271         (ada_evaluate_subexp): Update.
4272
4273 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4274
4275         * unittests/string_view-selftests.c: Define
4276         _initialize_string_view_selftests unconditionally.
4277
4278 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4279
4280         PR gdb/24350
4281         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4282
4283 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4284
4285         PR gdb/24351
4286         * windows-nat.c (display_selector): Fix format specifiers.
4287
4288 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4289
4290         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4291         tui_refill_source_window instead of tui_refresh_win, to update the
4292         current execution line.  This fixes redisplay of the current line
4293         when stepping through the code with "next" or "step".
4294
4295 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4296
4297         * source-cache.c (source_cache::get_source_lines): Call
4298         find_source_lines to initialize s->nlines.  This fixes vertical
4299         scrolling of TUI source window when the DOWN arrow is pressed.
4300
4301 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4302
4303         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4304         linux-thread-db.c (_initialize_thread_db): Likewise.
4305
4306 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4307
4308         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4309         wclrtoeol in tui_show_source_line".  This reverts changes made in
4310         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4311
4312 2019-03-15  Tom Tromey  <tom@tromey.com>
4313
4314         * symtab.h (struct minimal_symbol): Derive from
4315         general_symbol_info.
4316         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4317         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4318         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4319         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4320         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4321         (MSYMBOL_SEARCH_NAME): Update.
4322         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4323         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4324         * minsyms.c (minimal_symbol_reader::record_full): Update.
4325
4326 2019-03-15  Tom Tromey  <tom@tromey.com>
4327
4328         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4329
4330 2019-03-15  Tom Tromey  <tom@tromey.com>
4331
4332         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4333         unique_xmalloc_ptr.
4334         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4335         Update.
4336         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4337         (build_minimal_symbol_hash_tables)
4338         (minimal_symbol_reader::install): Update.
4339
4340 2019-03-15  Tom Tromey  <tom@tromey.com>
4341
4342         * symtab.c (create_demangled_names_hash): Update.
4343         (symbol_set_names): Update.
4344         * objfiles.h (struct objfile_per_bfd_storage)
4345         <demangled_names_hash>: Now an htab_up.
4346         * objfiles.c (objfile_per_bfd_storage): Simplify.
4347
4348 2019-03-15  Tom Tromey  <tom@tromey.com>
4349
4350         * objfiles.h (struct objfile_per_bfd_storage): Declare
4351         destructor.
4352         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4353         New.
4354         (get_objfile_bfd_data): Use new.  Don't initialize
4355         language_of_main.
4356         (free_objfile_per_bfd_storage): Remove.
4357         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4358
4359 2019-03-15  Tom Tromey  <tom@tromey.com>
4360
4361         * symfile.c (reread_symbols): Update.
4362         * objfiles.c (objfile::objfile): Update.
4363         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4364         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4365         comment.
4366         (minimal_symbol_reader::install): Update.
4367         (terminate_minimal_symbol_table): Remove.
4368         * jit.c (jit_object_close_impl): Update.
4369
4370 2019-03-15  Tom Tromey  <tom@tromey.com>
4371
4372         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4373         initializations.
4374
4375 2019-03-15  Tom Tromey  <tom@tromey.com>
4376
4377         * objfiles.h (struct objfile_per_bfd_storage)
4378         <demangled_hash_languages>: Now a bitset.
4379         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4380         (lookup_minimal_symbol): Update.
4381
4382 2019-03-15  Tom Tromey  <tom@tromey.com>
4383
4384         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4385         Don't return the symbol.
4386         * coffread.c (record_minimal_symbol): Use record_full.
4387
4388 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4389
4390         The MS-Windows port of ncurses fails to switch to a color pair if
4391         one or both of the colors are the implicit default colors.  This
4392         change records the default colors when TUI is initialized, and
4393         then specifies them explicitly when a color pair uses the default
4394         colors.  This allows color styling in TUI mode on MS-Windows.
4395
4396         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4397         ncurses_norm_attr.
4398         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4399         colors in ncurses_norm_attr.
4400         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4401         "none", replace it with the default color recorded in
4402         ncurses_norm_attr.
4403
4404 2019-03-14  Tom Tromey  <tromey@adacore.com>
4405
4406         * source-cache.h (class source_cache) <get_source_lines>: Return
4407         std::string.
4408         * source-cache.c (source_cache::extract_lines): Handle case where
4409         first_pos==npos.  Return std::string.
4410         (source_cache::get_source_lines): Update.
4411
4412 2019-03-14  Tom Tromey  <tromey@adacore.com>
4413
4414         * NEWS: Add item for "style sources" commands.
4415         * source-cache.c (source_cache::get_source_lines): Check
4416         source_styling.
4417         * cli/cli-style.c (source_styling): New global.
4418         (_initialize_cli_style): Add "style sources" commands.
4419         (show_style_sources): New function.
4420         * cli/cli-style.h (source_styling): Declare.
4421
4422 2019-03-14  Pedro Alves  <palves@redhat.com>
4423             Tom Tromey  <tromey@adacore.com>
4424
4425         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4426         * tui/tui-winsource.c (tui_refill_source_window): New function,
4427         from...
4428         (tui_horizontal_source_scroll): ... here.  Move some logic.
4429         * cli/cli-style.c (set_style_enabled): Notify new observable.
4430         * tui/tui-hooks.c (tui_redisplay_source): New function.
4431         (tui_attach_detach_observers): Attach or detach
4432         tui_redisplay_source.
4433         * observable.h (source_styling_changed): New observable.
4434         * observable.c: Define source_styling_changed observable.
4435
4436 2019-03-13  Tom Tromey  <tromey@adacore.com>
4437
4438         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4439         (i386_gnu_nat_target::store_registers): Update.
4440         * target-debug.h (target_debug_print_std_string): New macro.
4441         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4442         * windows-tdep.c (display_one_tib): Update.
4443         * tui/tui-stack.c (tui_make_status_line): Update.
4444         * top.c (print_inferior_quit_action): Update.
4445         * thread.c (thr_try_catch_cmd): Update.
4446         (add_thread_with_info): Update.
4447         (thread_target_id_str): Update.
4448         (thr_try_catch_cmd): Update.
4449         (thread_command): Update.
4450         (thread_find_command): Update.
4451         * record-btrace.c (record_btrace_target::info_record)
4452         (record_btrace_resume_thread, record_btrace_target::resume)
4453         (record_btrace_cancel_resume, record_btrace_step_thread)
4454         (record_btrace_target::wait, record_btrace_target::wait)
4455         (record_btrace_target::wait, record_btrace_target::stop): Update.
4456         * progspace.c (print_program_space): Update.
4457         * process-stratum-target.c
4458         (process_stratum_target::thread_address_space): Update.
4459         * linux-fork.c (linux_fork_mourn_inferior)
4460         (detach_checkpoint_command, info_checkpoints_command)
4461         (linux_fork_context): Update.
4462         (linux_fork_detach): Update.
4463         (class scoped_switch_fork_info): Update.
4464         (delete_checkpoint_command): Update.
4465         * infrun.c (follow_fork_inferior): Update.
4466         (follow_fork_inferior): Update.
4467         (proceed_after_vfork_done): Update.
4468         (handle_vfork_child_exec_or_exit): Update.
4469         (follow_exec): Update.
4470         (displaced_step_prepare_throw): Update.
4471         (displaced_step_restore): Update.
4472         (start_step_over): Update.
4473         (resume_1): Update.
4474         (clear_proceed_status_thread): Update.
4475         (proceed): Update.
4476         (print_target_wait_results): Update.
4477         (do_target_wait): Update.
4478         (context_switch): Update.
4479         (stop_all_threads): Update.
4480         (restart_threads): Update.
4481         (finish_step_over): Update.
4482         (handle_signal_stop): Update.
4483         (switch_back_to_stepped_thread): Update.
4484         (keep_going_pass_signal): Update.
4485         (print_exited_reason): Update.
4486         (normal_stop): Update.
4487         * inferior.c (inferior_pid_to_str): Change return type.
4488         (print_selected_inferior): Update.
4489         (add_inferior): Update.
4490         (detach_inferior): Update.
4491         * dummy-frame.c (fprint_dummy_frames): Update.
4492         * dcache.c (dcache_info_1): Update.
4493         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4494         (btrace_fetch, btrace_clear): Update.
4495         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4496         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4497         type.
4498         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4499         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4500         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4501         * gdbarch.c, gdbarch.h: Rebuild.
4502         * gdbarch.sh (core_pid_to_str): Change return type.
4503         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4504         return type.
4505         (windows_nat_target::pid_to_str): Change return type.
4506         (windows_delete_thread): Update.
4507         (windows_nat_target::attach): Update.
4508         (windows_nat_target::files_info): Update.
4509         * target-delegates.c: Rebuild.
4510         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4511         return type.
4512         (sol_thread_target::pid_to_str): Change return type.
4513         * remote.c (class remote_target) <pid_to_str>: Change return
4514         type.
4515         (remote_target::pid_to_str): Change return type.
4516         (extended_remote_target::attach, remote_target::remote_stop_ns)
4517         (remote_target::remote_notif_remove_queued_reply)
4518         (remote_target::push_stop_reply, remote_target::disable_btrace):
4519         Update.
4520         (extended_remote_target::attach): Update.
4521         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4522         type.
4523         (gdbsim_target::pid_to_str): Change return type.
4524         * ravenscar-thread.c (struct ravenscar_thread_target)
4525         <pid_to_str>: Change return type.
4526         (ravenscar_thread_target::pid_to_str): Change return type.
4527         * procfs.c (class procfs_target) <pid_to_str>: Change return
4528         type.
4529         (procfs_target::pid_to_str): Change return type.
4530         (procfs_target::attach): Update.
4531         (procfs_target::detach): Update.
4532         (procfs_target::fetch_registers): Update.
4533         (procfs_target::store_registers): Update.
4534         (procfs_target::wait): Update.
4535         (procfs_target::files_info): Update.
4536         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4537         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4538         return type.
4539         (nto_procfs_target::pid_to_str): Change return type.
4540         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4541         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4542         return type.
4543         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4544         (exit_lwp): Update.
4545         (attach_proc_task_lwp_callback, get_detach_signal)
4546         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4547         (linux_nat_target::resume, wait_lwp, stop_callback)
4548         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4549         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4550         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4551         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4552         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4553         type.
4554         (inf_ptrace_target::attach): Update.
4555         (inf_ptrace_target::files_info): Update.
4556         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4557         type.
4558         (go32_nat_target::pid_to_str): Change return type.
4559         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4560         (gnu_nat_target::wait): Update.
4561         (gnu_nat_target::wait): Update.
4562         (gnu_nat_target::resume): Update.
4563         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4564         (fbsd_nat_target::wait): Update.
4565         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4566         type.
4567         (darwin_nat_target::attach): Update.
4568         * corelow.c (class core_target) <pid_to_str>: Change return type.
4569         (core_target::pid_to_str): Change return type.
4570         * target.c (normal_pid_to_str): Change return type.
4571         (default_pid_to_str): Likewise.
4572         (target_pid_to_str): Change return type.
4573         (target_translate_tls_address): Update.
4574         (target_announce_detach): Update.
4575         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4576         return type.
4577         (bsd_uthread_target::pid_to_str): Change return type.
4578         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4579         type.
4580         (bsd_kvm_target::pid_to_str): Change return type.
4581         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4582         return type.
4583         (aix_thread_target::pid_to_str): Change return type.
4584         * target.h (struct target_ops) <pid_to_str>: Change return type.
4585         (target_pid_to_str, normal_pid_to_str): Likewise.
4586         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4587         type.
4588         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4589         type.
4590         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4591         return type.
4592         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4593         type.
4594         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4595         type.
4596         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4597         return type.
4598
4599 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4600
4601         * NEWS: Mention that the new default MI version is 3.  Mention
4602         changes to the output of commands and events that deal with
4603         multi-location breakpoints.
4604         * breakpoint.c: Include "mi/mi-out.h".
4605         (print_one_breakpoint): Change output syntax if using MI version
4606         >= 3.
4607         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4608         New.
4609         (mi_multi_location_breakpoint_output_fixed): New.
4610         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4611         (mi_cmd_fix_multi_location_breakpoint_output): New.
4612         (mi_multi_location_breakpoint_output_fixed): New.
4613         * mi/mi-cmds.c (mi_cmds): Register command
4614         -fix-multi-location-breakpoint-output.
4615         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4616         interpreter "mi".
4617
4618 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4619
4620         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4621         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4622         instantiate mi_ui_out based on interpreter name.
4623         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4624         * mi/mi-main.c (mi_load_progress): Likewise.
4625
4626 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4627
4628         * NEWS: Combine separate "New targets" sections for 8.3.
4629
4630 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4631
4632         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4633         (ppcfbsd_init_abi): Install gdbarch
4634         "fetch_tls_load_module_address" and "get_thread_local_address"
4635         methods.
4636
4637 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4638
4639         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4640         (riscv_fbsd_init_abi): Install gdbarch
4641         "fetch_tls_load_module_address" and "get_thread_local_address"
4642         methods.
4643
4644 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4645
4646         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4647         (i386fbsd_init_abi): Install gdbarch
4648         "fetch_tls_load_module_address" and "get_thread_local_address"
4649         methods.
4650
4651 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4652
4653         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4654         (amd64fbsd_init_abi): Install gdbarch
4655         "fetch_tls_load_module_address" and "get_thread_local_address"
4656         methods.
4657
4658 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4659
4660         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4661         (struct fbsd_pspace_data): New type.
4662         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4663         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4664         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4665         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4666         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4667
4668 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4669
4670         * gdbtypes.c (lookup_struct_elt): New function.
4671         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4672         * gdbtypes.h (struct struct_elt): New type.
4673         (lookup_struct_elt): New prototype.
4674
4675 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4676
4677         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4678         remove disabled code block.
4679
4680 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4681
4682         * gdbarch.sh (get_thread_local_address): New method.
4683         * gdbarch.h, gdbarch.c: Regenerate.
4684         * target.c (target_translate_tls_address): Use
4685         gdbarch_get_thread_local_address if present instead of
4686         target::get_thread_local_address.
4687
4688 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4689
4690         * target.h (target::get_thread_local_address): Update comment.
4691
4692 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4693
4694         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4695         objfile->separate_debug_objfile_backlink if not NULL.
4696
4697 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4698
4699         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4700         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4701         (amd64bsd_store_inferior_registers): Likewise.
4702         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4703         Enable segment base registers.
4704         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4705         PT_GETFSBASE and PT_GETGSBASE.
4706         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4707         PT_SETGSBASE.
4708         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4709         segment base registers.
4710         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4711
4712 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4713
4714         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4715         Update calls to i386_target_description to add 'segments'
4716         parameter.
4717         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4718         add segment base registers.
4719         * arch/i386.c (i386_create_target_description): Add 'segments'
4720         parameter to enable segment base registers.
4721         * arch/i386.h (i386_create_target_description): Likewise.
4722         * features/i386/32bit-segments.xml: New file.
4723         * features/i386/32bit-segments.c: Generate.
4724         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4725         call to i386_target_description to add 'segments' parameter.
4726         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4727         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4728         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4729         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4730         if feature is present.
4731         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4732         Add 'segments' parameter to call to i386_target_description.
4733         (i386_target_description): Add 'segments' parameter to enable
4734         segment base registers.
4735         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4736         to call to i386_target_description.
4737         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4738         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4739         Define I386_NUM_REGS.
4740         (i386_target_description): Add 'segments' parameter to enable
4741         segment base registers.
4742
4743 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4744
4745         PR/24325
4746         * source-cache.c: #undef open and close, to avoid unresolved
4747         externals during linking.
4748
4749 2019-03-12  Tom Tromey  <tromey@adacore.com>
4750
4751         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4752         const.  Add initializers.
4753         (_initialize_remote): Don't initialize ptid globals.
4754
4755 2019-03-12  Pedro Alves  <palves@redhat.com>
4756
4757         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4758
4759 2019-03-12  Pedro Alves  <palves@redhat.com>
4760
4761         * cp-name-parser.y (main): Remove unused 'len' variable.
4762
4763 2019-03-12  Tom Tromey  <tromey@adacore.com>
4764
4765         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4766         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4767
4768 2019-03-12  Tom Tromey  <tromey@adacore.com>
4769
4770         * linux-nat.c (iterate_over_lwps): Update.
4771         (stop_callback): Remove parameter.
4772         (stop_wait_callback, detach_callback, resume_set_callback)
4773         (select_singlestep_lwp_callback, set_ignore_sigint)
4774         (status_callback, resumed_callback, resume_clear_callback)
4775         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4776         data parameter.
4777         (linux_nat_target::detach, linux_nat_target::resume)
4778         (linux_stop_and_wait_all_lwps, select_event_lwp)
4779         (linux_nat_filter_event, linux_nat_wait_1)
4780         (linux_nat_target::kill, linux_nat_target::stop)
4781         (linux_nat_target::stop): Update.
4782         (linux_nat_resume_callback): Change type.
4783         (resume_stopped_resumed_lwps, count_events_callback)
4784         (select_event_lwp_callback): Likewise.
4785         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4786         * arm-linux-nat.c (struct update_registers_data): Remove.
4787         (update_registers_callback): Change type.
4788         (arm_linux_insert_hw_breakpoint1): Update.
4789         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4790         parameter.
4791         (x86_linux_dr_set_addr): Update.
4792         (x86_linux_dr_set_control): Update.
4793         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4794         (iterate_over_lwps): Use gdb::function_view.
4795         * nat/aarch64-linux-hw-point.c (struct
4796         aarch64_dr_update_callback_param): Remove.
4797         (debug_reg_change_callback): Change type.
4798         (aarch64_notify_debug_reg_change): Update.
4799         * s390-linux-nat.c (s390_refresh_per_info): Update.
4800
4801 2019-03-11  Tom Tromey  <tromey@adacore.com>
4802
4803         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4804         redundant assignment to "this_cu".
4805
4806 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4807
4808         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4809
4810 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4811
4812         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4813         from...
4814         (rank_one_type): ... this.
4815
4816 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4817
4818         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4819         from...
4820         (rank_one_type): ... this.
4821
4822 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4823
4824         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4825         from...
4826         (rank_one_type): ... this.
4827
4828 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4829
4830         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4831         from...
4832         (rank_one_type): ... this.
4833
4834 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4835
4836         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4837         from...
4838         (rank_one_type): ... this.
4839
4840 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4841
4842         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4843         from...
4844         (rank_one_type): ... this.
4845
4846 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4847
4848         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4849         from...
4850         (rank_one_type): ... this.
4851
4852 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4853
4854         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4855         from...
4856         (rank_one_type): ... this.
4857
4858 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4859
4860         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4861         from...
4862         (rank_one_type): ... this.
4863
4864 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4865
4866         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4867         from...
4868         (rank_one_type): ... this.
4869
4870 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4871
4872         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4873         from...
4874         (rank_one_type): ... this.
4875
4876 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4877
4878         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4879         from...
4880         (rank_one_type): ... this.
4881
4882 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4883
4884         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4885         inferior-events' shows the example events.
4886
4887 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4888
4889         Support styling on native MS-Windows console
4890
4891         PR/24315
4892         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4893         on MS-Windows if $TERM is not defined.
4894
4895         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4896
4897         * posix-hdep.c (gdb_console_fputs):
4898         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4899         functions.
4900         * ui-file.h (gdb_console_fputs): Add prototype.
4901
4902         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4903         back to fputs only if the former returns zero.
4904
4905 2019-03-07  Tom Tromey  <tom@tromey.com>
4906
4907         * symmisc.c (print_symbol_bcache_statistics): Update.
4908         (print_objfile_statistics): Update.
4909         * symfile.c (allocate_symtab): Update.
4910         * stabsread.c: Don't include bcache.h.
4911         * psymtab.h (struct psymbol_bcache): Don't declare.
4912         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4913         (psymbol_bcache_init, psymbol_bcache_free)
4914         (psymbol_bcache_get_bcache): Don't declare.
4915         * psymtab.c (struct psymbol_bcache): Remove.
4916         (psymtab_storage::psymtab_storage): Update.
4917         (psymtab_storage::~psymtab_storage): Update.
4918         (psymbol_bcache_init, psymbol_bcache_free)
4919         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4920         (add_psymbol_to_bcache): Update.
4921         (allocate_psymtab): Update.
4922         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4923         macro_cache>: No longer pointers.
4924         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4925         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4926         * macrotab.c (macro_bcache): Update.
4927         * macroexp.c: Don't include bcache.h.
4928         * gdbtypes.c (check_types_worklist): Update.
4929         (types_deeply_equal): Remove TRY/CATCH.  Update.
4930         * elfread.c (elf_symtab_read): Update.
4931         * dwarf2read.c: Don't include bcache.h.
4932         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4933         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4934         (print_bcache_statistics, bcache_memory_used): Don't declare.
4935         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4936         methods.  Rename all data members.
4937         * bcache.c (struct bcache): Move to bcache.h.
4938         (bcache::expand_hash_table): Rename from expand_hash_table.
4939         (bcache): Remove.
4940         (bcache::insert): Rename from bcache_full.
4941         (bcache::compare): Rename from bcache_compare.
4942         (bcache_xmalloc): Remove.
4943         (bcache::~bcache): Rename from bcache_xfree.
4944         (bcache::print_statistics): Rename from print_bcache_statistics.
4945         (bcache::memory_used): Rename from bcache_memory_used.
4946
4947 2019-03-07  Pedro Alves  <palves@redhat.com>
4948
4949         * infrun.c (normal_stop): Also check for
4950         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4951
4952 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4953
4954         * f-lang.c (value_from_host_double): Moved to...
4955         * value.c (value_from_host_double): ...here.
4956         * value.h (value_from_host_double): Declare.
4957         * guile/scm-math.c (vlscm_convert_typed_number): Use
4958         value_from_host_double.
4959         (vlscm_convert_number): Likewise.
4960         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4961         * python/py-value.c (convert_value_from_python): Likewise.
4962
4963 2019-03-06  Tom Tromey  <tom@tromey.com>
4964
4965         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4966
4967 2019-03-06  Tom Tromey  <tom@tromey.com>
4968
4969         * utils.h (free_current_contents): Don't declare.
4970         * utils.c (free_current_contents): Remove.
4971
4972 2019-03-06  Tom Tromey  <tom@tromey.com>
4973
4974         * top.c (quit_force): Update.
4975         * main.c (captured_command_loop): Update.
4976         * common/new-op.c (operator new): Update.
4977         * common/common-exceptions.c (struct catcher)
4978         <save_cleanup_chain>: Remove member.
4979         (exceptions_state_mc_init): Update.
4980         (exception_try_scope_entry): Return nullptr.
4981         (exception_try_scope_exit, exception_rethrow)
4982         (throw_exception_sjlj, throw_exception_cxx): Update.
4983         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4984         (all_cleanups, do_cleanups, discard_cleanups)
4985         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4986         (restore_cleanups, restore_final_cleanups): Don't declare.
4987         (do_final_cleanups): Remove parameter.
4988         * common/cleanups.c (cleanup_chain, make_cleanup)
4989         (make_cleanup_dtor, all_cleanups, do_cleanups)
4990         (discard_my_cleanups, discard_cleanups)
4991         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4992         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4993         (null_cleanup): Remove.
4994         (do_final_cleanups): Remove parameter.
4995
4996 2019-03-06  Tom Tromey  <tom@tromey.com>
4997
4998         * remote.c (remote_target::remote_parse_stop_reply): Use
4999         unique_xmalloc_ptr.
5000
5001 2019-03-06  Tom Tromey  <tom@tromey.com>
5002
5003         * stabsread.c (struct stabs_field_info): Rename from field_info.
5004         <list, fnlist>: Add initializers.
5005         <obstack>: New member.
5006         (read_member_functions, read_struct_fields, read_baseclasses):
5007         Allocate on obstack.  Don't use cleanups.
5008         (read_one_struct_field, read_member_functions, read_struct_fields)
5009         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5010         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5011         (read_struct_type): Update.
5012
5013 2019-03-06  Tom Tromey  <tom@tromey.com>
5014
5015         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5016         * common/filestuff.h (make_cleanup_close): Don't declare.
5017         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5018         Remove.
5019
5020 2019-03-06  Tom Tromey  <tom@tromey.com>
5021
5022         * solib-aix.c: Use make_scope_exit.
5023
5024 2019-03-06  Tom Tromey  <tom@tromey.com>
5025
5026         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5027         Use make_scope_exit.
5028
5029 2019-03-06  Tom Tromey  <tom@tromey.com>
5030
5031         * solib-svr4.c (disable_probes_interface): Remove parameter.
5032         (svr4_handle_solib_event): Use make_scope_exit.
5033
5034 2019-03-06  Tom Tromey  <tom@tromey.com>
5035
5036         * remote.c (struct stop_reply_deleter): Remove.
5037         (stop_reply_up): Update.
5038         (struct stop_reply): Derive from notif_event.  Don't typedef.
5039         <regcache>: Now a std::vector.
5040         (stop_reply_xfree): Remove.
5041         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5042         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5043         (remote_target::discard_pending_stop_replies): Use delete.
5044         (remote_target::remote_parse_stop_reply): Update.
5045         (remote_target::process_stop_reply): Update.
5046         * remote-notif.h (struct notif_event): Add virtual destructor.
5047         Remove "dtr" member.
5048         (struct notif_client) <alloc_event>: Return a unique_ptr.
5049         (notif_event_xfree): Don't declare.
5050         (notif_event_up): New typedef.
5051         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5052         (notif_event_xfree, do_notif_event_xfree): Remove.
5053         (remote_notif_state_xfree): Update.
5054
5055 2019-03-06  Tom Tromey  <tom@tromey.com>
5056
5057         * infrun.c (displaced_step_clear_cleanup): Now a
5058         forward_scope_exit type.
5059         (displaced_step_prepare_throw): Update.
5060         (displaced_step_fixup): Update.
5061
5062 2019-03-06  Tom Tromey  <tom@tromey.com>
5063
5064         * inferior.h (class inferior): Update comment.
5065         * gdbthread.h (class thread_info): Update comment.
5066
5067 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5068             Tom Tromey  <tom@tromey.com>
5069
5070         * stabsread.h (struct stab_section_list): Remove.
5071         (coffstab_build_psymtabs): Update.
5072         * dbxread.c (symbuf_sections): Now a std::vector.
5073         (sect_idx): New global.
5074         (fill_symbuf): Update.
5075         (coffstab_build_psymtabs): Change type of stabsects parameter.
5076         Update.
5077         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5078         std::vector.
5079         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5080         (coff_locate_sections): Update.
5081         (coff_symfile_read): Remove cleanups.  Update.
5082         (init_stringtab): Add storage parameter.
5083         (free_stringtab, free_stringtab_cleanup): Remove.
5084         (init_lineno): Add storage parameter.
5085         (free_linetab, free_linetab_cleanup): Remove.
5086
5087 2019-03-06  Pedro Alves  <palves@redhat.com>
5088
5089         * linux-fork.c (fork_info::clobber_regs): Delete.
5090         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5091         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5092         comment.  Adjust.
5093         (scoped_switch_fork_info::scoped_switch_fork_info)
5094         (checkpoint_command, linux_fork_context): Adjust
5095         fork_save_infrun_state calls.
5096
5097 2019-03-06  Pedro Alves  <palves@redhat.com>
5098
5099         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5100         (inf_has_multiple_threads): Return 'bool' and rewrite using
5101         inferior_info::threads().
5102
5103 2019-03-06  Pedro Alves  <palves@redhat.com>
5104
5105         * linux-fork.c: Include <list>.
5106         (fork_list): Now a std::list instance.
5107         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5108         (forks_exist_p, find_last_fork): Adjust.
5109         (new_fork): Delete.
5110         (one_fork_p): New.
5111         (add_fork): Adjust.
5112         (free_fork): Delete, folded into fork_info::~fork_info().
5113         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5114         Adjust.
5115         (init_fork_list): Delete.
5116         (linux_fork_killall, linux_fork_mourn_inferior)
5117         (linux_fork_detach, info_checkpoints_command): Adjust.
5118         (_initialize_linux_fork): No longer call init_fork_list.
5119
5120 2019-03-06  Pedro Alves  <palves@redhat.com>
5121
5122         * linux-fork.c (new_fork): New, split out of ...
5123         (add_fork): ... this.  Return void.  Move "first fork" special
5124         case from here, to ...
5125         (checkpoint_command): ... here.
5126         * linux-linux.h (add_fork): Return void.
5127
5128 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5129
5130         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5131
5132 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5133             Chris January  <chris.january@arm.com>
5134             David Lecomber  <david.lecomber@arm.com>
5135
5136         * f-exp.y: New token, UNOP_INTRINSIC.
5137         (exp): New pattern using UNOP_INTRINSIC token.
5138         (f77_keywords): Add 'abs' keyword.
5139         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5140         (value_from_host_double): New function.
5141         (evaluate_subexp_f): Support UNOP_ABS.
5142
5143 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5144
5145         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5146         types.
5147
5148 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5149
5150         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5151         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5152         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5153
5154 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5155
5156         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5157
5158 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5159             Chris January  <chris.january@arm.com>
5160
5161         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5162         * f-exp.y: Define 'KIND' token.
5163         (exp): New pattern for KIND expressions.
5164         (ptype): Handle types with a kind extension.
5165         (direct_abs_decl): Extend to spot kind extensions.
5166         (f77_keywords): Add 'kind' to the list.
5167         (push_kind_type): New function.
5168         (convert_to_kind_type): New function.
5169         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5170         * parse.c (operator_length_standard): Likewise.
5171         * parser-defs.h (enum type_pieces): Add tp_kind.
5172         * std-operator.def: Add UNOP_KIND.
5173
5174 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5175
5176         * f-exp.y (f_parse): Set yydebug.
5177
5178 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5179
5180         * f-lang.c (evaluate_subexp_f): New function.
5181         (exp_descriptor_f): New global.
5182         (f_language_defn): Use exp_descriptor_f instead of
5183         exp_descriptor_standard.
5184
5185 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5186
5187         * f-exp.y (struct token): Add comments.
5188         (dot_ops): Remove uppercase versions and the end marker.
5189         (f77_keywords): Likewise.
5190         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5191         entries in the dot_ops array are case insensitive, and use
5192         strncasecmp to compare strings.  Also some whitespace cleanup in
5193         this area.  Similar for the f77_keywords array, except entries in
5194         this list might be case sensitive.
5195
5196 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5197
5198         * f-exp.y (struct f77_boolean_val): Add comments.
5199         (boolean_values): Remove uppercase versions, and end marker.
5200         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5201         and use strncasecmp to achieve case insensitivity.  Additionally,
5202         perform whitespace cleanup around this code.
5203
5204 2019-03-06  Tom Tromey  <tromey@adacore.com>
5205
5206         * remote-sim.c (gdbsim_target_open): Use result of
5207         gdb_argv::release.
5208
5209 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5210         Dirk Schubert  <dirk.schubert@arm.com>
5211         Chris January  <chris.january@arm.com>
5212
5213         * eval.c (evaluate_subexp_standard): Call Fortran argument
5214         wrapping logic.
5215         * f-lang.c (struct value): A value which can be passed into a
5216         Fortran function call.
5217         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5218         where appropriate.
5219         (struct type): Value ready for a Fortran function call.
5220         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5221         is needed.
5222         * f-lang.h (fortran_argument_convert): Declaration.
5223         (fortran_preserve_arg_pointer): Declaration.
5224         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5225
5226 2019-03-05  Tom Tromey  <tromey@adacore.com>
5227
5228         * python/py-prettyprint.c (print_string_repr): Remove #if.
5229         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5230
5231 2019-03-05  Tom Tromey  <tromey@adacore.com>
5232
5233         * target.c (the_dummy_target): Move later.  Change type to
5234         "dummy_target".
5235         (initialize_targets): Don't initialize the_dummy_target.
5236
5237 2019-03-05  Tom Tromey  <tromey@adacore.com>
5238
5239         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5240         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5241
5242 2019-03-05  Tom Tromey  <tromey@adacore.com>
5243
5244         * windows-nat.c (windows_nat_target::attach)
5245         (windows_nat_target::detach): Don't call gdb_flush.
5246         * valprint.c (generic_val_print, val_print, val_print_string):
5247         Don't call gdb_flush.
5248         * utils.c (defaulted_query): Don't call gdb_flush.
5249         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5250         * target.c (target_announce_detach): Don't call gdb_flush.
5251         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5252         * remote.c (extended_remote_target::attach): Don't call
5253         gdb_flush.
5254         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5255         * printcmd.c (do_examine): Don't call gdb_flush.
5256         (info_display_command): Don't call gdb_flush.
5257         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5258         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5259         * memattr.c (info_mem_command): Don't call gdb_flush.
5260         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5261         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5262         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5263         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5264         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5265         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5266         (gnu_nat_target::detach): Don't call gdb_flush.
5267         * f-valprint.c (f_val_print): Don't call gdb_flush.
5268         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5269         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5270         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5271         gdb_flush.
5272         * c-valprint.c (c_val_print): Don't call gdb_flush.
5273         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5274
5275 2019-03-05  Tom Tromey  <tromey@adacore.com>
5276
5277         * varobj.c (update_dynamic_varobj_children): Update.
5278         (install_default_visualizer): Use reset, not release.
5279         * value.c (set_internalvar): Update.
5280         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5281         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5282         ATTRIBUTE_UNUSED_RESULT.
5283
5284 2019-03-05  Tom Tromey  <tromey@adacore.com>
5285
5286         * remote.c (class scoped_remote_fd) <release>: Add
5287         ATTRIBUTE_UNUSED_RESULT.
5288
5289 2019-03-05  Tom Tromey  <tromey@adacore.com>
5290
5291         * macroexp.c (struct macro_buffer) <release>: Add
5292         ATTRIBUTE_UNUSED_RESULT.
5293
5294 2019-03-05  Tom Tromey  <tromey@adacore.com>
5295
5296         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5297         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5298         ATTRIBUTE_UNUSED_RESULT.
5299
5300 2019-03-05  Tom Tromey  <tromey@adacore.com>
5301
5302         * common/scoped_fd.h (class scoped_fd) <release>: Add
5303         ATTRIBUTE_UNUSED_RESULT.
5304
5305 2019-03-05  Tom Tromey  <tromey@adacore.com>
5306
5307         * parser-defs.h (struct parser_state) <release>: Add
5308         ATTRIBUTE_UNUSED_RESULT.
5309
5310 2019-03-05  Tom Tromey  <tromey@adacore.com>
5311
5312         * utils.h (class gdb_argv) <release>: Add
5313         ATTRIBUTE_UNUSED_RESULT.
5314         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5315
5316 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5317
5318         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5319         for-loop range, to avoid compiler warnings.
5320
5321         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5322         avoid compiler warnings about unused variables.
5323
5324         * NEWS: Mention end of support for native debugging on MS-Windows
5325         before XP.
5326
5327         PR gdb/24292
5328         * common/netstuff.c:
5329         * gdbserver/gdbreplay.c
5330         * gdbserver/remote-utils.c:
5331         * ser-tcp.c:
5332         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5333         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5334         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5335         'getaddrinfo' and 'freeaddrinfo' were not available before
5336         Windows XP, and mingw.org's MinGW headers by default define
5337         _WIN32_WINNT to 0x500.
5338
5339 2019-03-01  Gary Benson <gbenson@redhat.com>
5340
5341         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5342
5343 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5344             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5345
5346         PR gdb/8527
5347         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5348         set_sigint_trap, clear_sigint_trap.
5349
5350 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5351
5352         * target.c (target_detach): Clear the regcache and the
5353         frame cache.
5354
5355 2019-02-27  Pedro Alves  <palves@redhat.com>
5356
5357         * utils.c (set_screen_size): When we cap the height/width sizes,
5358         tweak the corresponding command variable to show "unlimited":
5359
5360 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5361             Pedro Alves  <palves@redhat.com>
5362
5363         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5364         before calling rl_set_screen_size.
5365
5366 2019-02-27  Tom Tromey  <tromey@adacore.com>
5367
5368         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5369         define.
5370         * python/py-value.c: Remove Python 2.4 workaround.
5371         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5372         workaround.
5373         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5374         Python 2.4 workaround.
5375         * python/python-internal.h: Remove Python 2.4 comment.
5376         (Py_ssize_t): Don't define.
5377         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5378         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5379         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5380         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5381         * python/python.c (do_start_initialization): Remove Python 2.4
5382         workaround.
5383         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5384         (print_children): Remove Python 2.4 workaround.
5385         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5386         workaround.
5387         (CHARBUFFERPROC_NAME): Remove.
5388         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5389         Python 2.4 workaround.
5390
5391 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5392
5393         * NEWS: Note minimum Python version.
5394
5395 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5396
5397         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5398         code from these functions.  Remove corresponding ifdefs.  Use
5399         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5400         Remove gotos and target of gotos.
5401         (infpy_search_memory): Likewise.
5402
5403 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5404
5405         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5406         (hppa_gdbarch_init): Don't register deleted functions with
5407         gdbarch.
5408
5409 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5410
5411         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5412         (h8300_unwind_sp): Delete.
5413         (h8300_dummy_id): Delete.
5414         (h8300_gdbarch_init): Don't register deleted functions with
5415         gdbarch.
5416
5417 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5418
5419         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5420         (ft32_unwind_pc): Delete.
5421         (ft32_unwind_sp): Delete.
5422         (ft32_gdbarch_init): Don't register deleted functions with
5423         gdbarch.
5424
5425 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5426
5427         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5428         (frv_unwind_pc): Delete.
5429         (frv_unwind_sp): Delete.
5430         (frv_gdbarch_init): Don't register deleted functions with
5431         gdbarch.
5432
5433 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5434
5435         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5436         (riscv_unwind_pc): Delete.
5437         (riscv_unwind_sp): Delete.
5438         (riscv_gdbarch_init): Don't register deleted functions with
5439         gdbarch.
5440
5441 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5442
5443         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5444         (csky_unwind_pc): Delete.
5445         (csky_unwind_sp): Delete.
5446         (csky_gdbarch_init): Don't register deleted functions with
5447         gdbarch.
5448
5449 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5450
5451         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5452         (cris_unwind_pc): Delete.
5453         (cris_unwind_sp): Delete.
5454         (cris_gdbarch_init): Don't register deleted functions with
5455         gdbarch.
5456
5457 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5458
5459         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5460         (bfin_unwind_pc): Delete.
5461         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5462
5463 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5464
5465         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5466         (arm_unwind_pc): Delete.
5467         (arm_unwind_sp): Delete.
5468         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5469
5470 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5471
5472         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5473         (arc_unwind_pc): Delete.
5474         (arc_unwind_sp): Delete.
5475         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5476
5477 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5478
5479         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5480         (alpha_unwind_pc): Delete.
5481         (alpha_gdbarch_init): Don't register deleted functions with
5482         gdbarch.
5483
5484 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5485
5486         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5487         (aarch64_unwind_pc): Delete.
5488         (aarch64_unwind_sp): Delete.
5489         (aarch64_gdbarch_init): Don't register deleted functions with
5490         gdbarch.
5491
5492 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5493
5494         * gdbtypes.c (type_align): Don't consider static members when
5495         computing structure alignment.
5496
5497 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5498
5499         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5500         return 0 for other types.
5501         * arch-utils.c (default_type_align): Always return 0.
5502         * gdbarch.h: Regenerate.
5503         * gdbarch.sh (type_align): Extend comment.
5504         * gdbtypes.c (type_align): Add additional comments, always call
5505         gdbarch_type_align before applying the default rules.
5506         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5507         generic code will then apply a suitable default.
5508         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5509         types, return 0 for other types.
5510
5511 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5512
5513         * NEWS: Create a new section for the next release branch.
5514         Rename the section of the current branch, now that it has
5515         been cut.
5516
5517 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5518
5519         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5520         * version.in: Bump version to 8.3.50.DATE-git.
5521
5522 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5523
5524         * aix-thread.c (ptid_cmp): Remove unused variable.
5525         (get_signaled_thread): Likewise.
5526         (store_regs_user_thread): Likewise.
5527         (store_regs_kernel_thread): Likewise.
5528         (fetch_regs_kernel_thread): Remove shadowed variable.
5529
5530 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5531
5532         * features/riscv/32bit-cpu.xml: Add register numbers.
5533         * features/riscv/32bit-fpu.c: Regenerate.
5534         * features/riscv/32bit-fpu.xml: Add register numbers.
5535         * features/riscv/64bit-cpu.xml: Add register numbers.
5536         * features/riscv/64bit-fpu.c: Regenerate.
5537         * features/riscv/64bit-fpu.xml: Add register numbers.
5538
5539 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5540
5541         * NEWS: Mention two argument form of gdb.Value constructor.
5542         * python/py-value.c (convert_buffer_and_type_to_value): New
5543         function.
5544         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5545         Add support for handling an optional second argument.  Call
5546         convert_buffer_and_type_to_value as appropriate.
5547         * python/python-internal.h (Py_buffer_deleter): New struct.
5548         (Py_buffer_up): New typedef.
5549
5550 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5551
5552         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5553         instead of releasing ownership.
5554
5555 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5556
5557         * dwarf2read.c (open_and_init_dwp_file): Call
5558         elf_numsections instead of bfd_count_sections to initialize
5559         dwp_file->num_sections.
5560
5561 2019-02-25  Tom Tromey  <tromey@adacore.com>
5562
5563         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5564
5565 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5566
5567         * gcore.in: Add '--readnever' option when invoking GDB.
5568
5569 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5570
5571         * MAINTAINERS: Update my email address.
5572
5573 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5574
5575         * build-id.c (build_id_to_debug_bfd_1): New function.
5576         (build_id_to_debug_bfd): Look for separate debug file in
5577         sysroot.
5578
5579 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5580
5581         * gdbarch.sh: Update the copyright year range that is placed into
5582         generated files.
5583
5584 2019-02-22  Keith Seitz  <keiths@redhat.com>
5585
5586         PR symtab/23853
5587         * linespec.c (create_sals_line_offset): Search for the default
5588         symtab's filename instead of its fullname.
5589
5590 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5591
5592         * NEWS: Update style defaults.
5593
5594 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5595
5596         * main.c (captured_main_1): Disable styling in batch mode.
5597
5598 2019-02-20  Tom Tromey  <tom@tromey.com>
5599
5600         * symtab.c (symtab_symbol_info): Fix typos.
5601
5602 2019-02-20  Tom Tromey  <tromey@adacore.com>
5603
5604         * findcmd.c (_initialize_mem_search): Use upper case for
5605         metasyntactic variables.
5606
5607 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5608
5609         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5610         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5611
5612 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5613
5614         * top.h (source_file_name): Change to std::string.
5615         * top.c (source_file_name): Likewise.
5616         (command_line_input): Adjust.
5617         * cli/cli-script.c (script_from_file): Adjust.
5618
5619 2019-02-19  Tom Tromey  <tromey@adacore.com>
5620
5621         * ravenscar-thread.c
5622         (ravenscar_thread_target::update_thread_list): Don't call
5623         ada_build_task_list.
5624         * ada-lang.h (ada_build_task_list): Don't declare.
5625         * ada-tasks.c (struct ada_tasks_inferior_data)
5626         <task_list_valid_p>: Now bool.
5627         (read_known_tasks, ada_task_list_changed)
5628         (ada_tasks_invalidate_inferior_data): Update.
5629         (read_known_tasks_array): Return bool.
5630         (read_known_tasks_list): Likewise.
5631         (read_known_tasks): Return void.
5632         (ada_build_task_list): Now static.
5633
5634 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5635
5636         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5637         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5638
5639 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5640
5641         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5642         variant for ada_tasks_pspace_data_handle and
5643         ada_tasks_inferior_data_handle.
5644         (ada_tasks_pspace_data_cleanup): New function.
5645         (ada_tasks_inferior_data_cleanup): New function.
5646
5647 2019-02-17  Tom Tromey  <tom@tromey.com>
5648
5649         * macrotab.h (macro_source_fullname): Return a std::string.
5650         * macrotab.c (macro_include, check_for_redefinition)
5651         (macro_undef, macro_lookup_definition, foreach_macro)
5652         (foreach_macro_in_scope): Update.
5653         (macro_source_fullname): Return a std::string.
5654         * macrocmd.c (show_pp_source_pos): Update.
5655
5656 2019-02-17  Tom Tromey  <tom@tromey.com>
5657
5658         * macrocmd.c (show_pp_source_pos): Style the file names.
5659
5660 2019-02-17  Tom Tromey  <tom@tromey.com>
5661
5662         PR tui/24197:
5663         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5664
5665 2019-02-17  Tom Tromey  <tom@tromey.com>
5666
5667         * ada-lang.c (user_select_syms): Use filtered printing.
5668         * utils.c (wrap_style): New global.
5669         (desired_style): Remove.
5670         (emit_style_escape): Add stream parameter.
5671         (set_output_style, reset_terminal_style, prompt_for_continue):
5672         Update.
5673         (flush_wrap_buffer): Only flush gdb_stdout.
5674         (wrap_here): Set wrap_style.
5675         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5676         treat escape sequences as a character.  Change when wrap buffer is
5677         flushed.
5678         (fputs_styled): Do not set the output style when the default is
5679         requested.
5680         * ui-style.h (struct ui_file_style) <is_default>: New method.
5681         * source.c (print_source_lines_base): Emit escape sequences in one
5682         piece.
5683
5684 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5685
5686         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5687         integers and enumeration types.
5688
5689 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5690
5691         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5692         instead of lookup_symbol_in_language
5693         (do_exact_match): New function.
5694         (ada_get_symbol_name_matcher): Return do_exact_match when
5695         doing a verbatim match.
5696
5697 2019-02-15  Tom Tromey  <tromey@adacore.com>
5698
5699         * ravenscar-thread.c (ravenscar_thread_target::resume)
5700         (ravenscar_thread_target::wait): Special case wildcard requests.
5701
5702 2019-02-15  Tom Tromey  <tromey@adacore.com>
5703
5704         * ravenscar-thread.c (base_ptid): Remove.
5705         (struct ravenscar_thread_target) <close>: New method.
5706         <m_base_ptid>: New member.
5707         <update_inferior_ptid, active_task, task_is_currently_active,
5708         runtime_initialized>: Declare methods.
5709         <ravenscar_thread_target>: Add constructor.
5710         (ravenscar_thread_target::task_is_currently_active)
5711         (ravenscar_thread_target::update_inferior_ptid)
5712         (ravenscar_runtime_initialized): Rename.  Now methods.
5713         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5714         (ravenscar_thread_target::update_thread_list): Update.
5715         (ravenscar_thread_target::active_task): Now method.
5716         (ravenscar_thread_target::store_registers)
5717         (ravenscar_thread_target::prepare_to_store)
5718         (ravenscar_thread_target::prepare_to_store)
5719         (ravenscar_thread_target::mourn_inferior): Update.
5720         (ravenscar_inferior_created): Use "new" to create target.
5721         (ravenscar_thread_target::get_ada_task_ptid): Update.
5722         (_initialize_ravenscar): Don't initialize base_ptid.
5723         (ravenscar_ops): Remove global.
5724
5725 2019-02-15  Tom Tromey  <tromey@adacore.com>
5726
5727         * target.h (push_target): Declare new overload.
5728         * target.c (push_target): New overload, taking an rvalue reference.
5729         * remote.c (remote_target::open_1): Use push_target overload.
5730         * corelow.c (core_target_open): Use push_target overload.
5731
5732 2019-02-15  Tom Tromey  <tromey@adacore.com>
5733
5734         * ravenscar-thread.c (is_ravenscar_task)
5735         (ravenscar_task_is_currently_active): Return bool.
5736         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5737         (_initialize_ravenscar): Remove "(void)".
5738         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5739         Return bool.
5740
5741 2019-02-15  Tom Tromey  <tromey@adacore.com>
5742
5743         * ravenscar-thread.c (ravenscar_runtime_initializer)
5744         (has_ravenscar_runtime, get_running_thread_id)
5745         (ravenscar_thread_target::resume): Fix indentation.
5746
5747 2019-02-15  Tom Tromey  <tromey@adacore.com>
5748
5749         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5750         from ravenscar_arch_ops.
5751         (sparc_ravenscar_ops::fetch_registers)
5752         (sparc_ravenscar_ops::store_registers): Now methods.
5753         (sparc_ravenscar_prepare_to_store): Remove.
5754         (sparc_ravenscar_ops): Redefine.
5755         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5756         methods and destructor.  Remove members.
5757         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5758         (ravenscar_thread_target::store_registers)
5759         (ravenscar_thread_target::prepare_to_store): Update.
5760         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5761         Remove.
5762         (struct ppc_ravenscar_powerpc_ops): Derive from
5763         ravenscar_arch_ops.
5764         (ppc_ravenscar_powerpc_ops::fetch_registers)
5765         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5766         (ppc_ravenscar_powerpc_ops): Redefine.
5767         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5768         (ppc_ravenscar_e500_ops::fetch_registers)
5769         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5770         (ppc_ravenscar_e500_ops): Redefine.
5771         * aarch64-ravenscar-thread.c
5772         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5773         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5774         (aarch64_ravenscar_fetch_registers)
5775         (aarch64_ravenscar_store_registers): Now methods.
5776         (aarch64_ravenscar_ops): Redefine.
5777
5778 2019-02-15  Tom Tromey  <tromey@adacore.com>
5779
5780         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5781         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5782         (ravenscar_thread_target::stopped_by_watchpoint)
5783         (ravenscar_thread_target::stopped_data_address)
5784         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5785
5786 2019-02-15  Tom Tromey  <tromey@adacore.com>
5787
5788         * ravenscar-thread.c: Fix some typos.
5789
5790 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5791             Tom Tromey  <tromey@adacore.com>
5792
5793         * ada-lang.c (ada_exception_sal): Change addr_string to a
5794         std::string.
5795         (create_ada_exception_catchpoint): Update.
5796
5797 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5798             Tom Tromey  <tromey@adacore.com>
5799
5800         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5801         (bp_location_ops): Remove.
5802         (base_breakpoint_allocate_location): Update.
5803         (free_bp_location): Update.
5804         * ada-lang.c (class ada_catchpoint_location)
5805         <ada_catchpoint_location>: Remove ops parameter.
5806         (ada_catchpoint_location_dtor): Remove.
5807         (ada_catchpoint_location_ops): Remove.
5808         (allocate_location_exception): Update.
5809         * breakpoint.h (struct bp_location_ops): Remove.
5810         (class bp_location) <bp_location>: Remove bp_location_ops
5811         parameter.
5812         <~bp_location>: Add destructor.
5813         <ops>: Remove.
5814
5815 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5816             Pedro Alves  <palves@redhat.com>
5817
5818         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5819         'PATH_MAX'.
5820
5821 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5822             Samuel Thibault  <samuel.thibault@gnu.org>
5823             Thomas Schwinge  <thomas@codesourcery.com>
5824
5825         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5826         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5827
5828 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5829
5830         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5831         (check_empty): Use "const char *".
5832
5833         * gnu-nat.c (gnu_nat_target::detach): Instead of
5834         'detach_inferior (pid)' call
5835         'detach_inferior (find_inferior_pid (pid))'.
5836
5837         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5838         'nat/fork-inferior.o'.
5839         * gnu-nat.c: #include "nat/fork-inferior.h".
5840
5841         * gnu-nat.c (gnu_nat_target::detach): Instead of
5842         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5843         * gnu-nat.h: #include "inf-child.h".
5844         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5845         'i386_gnu_nat_target::fetch_registers'.
5846         (gnu_store_registers): Rename/move to
5847         'i386_gnu_nat_target::store_registers'.
5848
5849         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5850         * gnu-nat.h (mach_thread_info): New function.
5851         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5852
5853         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5854
5855 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5856
5857         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5858
5859 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5860
5861         * windows-nat.c (windows_add_thread): Add new parameter
5862         "main_thread_p" with default value set to false.  Update
5863         function documentation as well as all callers.
5864         (windows_delete_thread): Likewise.
5865         (fake_create_process): Update call to windows_add_thread.
5866         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5867         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5868         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5869         call to windows_delete_thread.
5870
5871 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5872
5873         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5874
5875 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5876
5877         * symfile.c (find_separate_debug_file): Use canonical path of
5878         sysroot with child_path instead of gdb_sysroot if it is valid.
5879
5880 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5881
5882         * symfile.c (find_separate_debug_file): Use child_path to
5883         determine if an object file is under a sysroot.
5884
5885 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5886
5887         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5888         unittests/child-path-selftests.c.
5889         * common/pathstuff.c (child_path): New function.
5890         * common/pathstuff.h (child_path): New prototype.
5891         * unittests/child-path-selftests.c: New file.
5892
5893 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5894
5895         * symfile.c (find_separate_debug_file): Look for separate debug
5896         files in debug directories under the sysroot.
5897
5898 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5899
5900         * symtab.h (struct minimal_symbol data_p): New const method.
5901         (struct minimal_symbol text_p): Likewise.
5902         * symtab.c (output_source_filename): Use file name style
5903         to print file name.
5904         (print_symbol_info): Likewise.
5905         (print_msymbol_info): Use address style to print addresses.
5906         Use function name style to print executable text symbols.
5907         (expand_symtab_containing_pc): Use data_p.
5908         (find_pc_sect_compunit_symtab): Likewise.
5909
5910 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5911
5912         * breakpoint.c (describe_other_breakpoints): Use address style
5913         to print addresses.
5914         (say_where): Likewise.
5915
5916 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5917
5918         * ada-typeprint.c (print_func_type): Print function name
5919         style to print function name.
5920         * c-typeprint.c (c_print_type_1): Likewise.
5921
5922 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5923
5924         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5925         for execve.
5926
5927 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5928
5929         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5930         type_stack.
5931
5932 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5933
5934         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5935         TYPE_CODE_REF types.
5936
5937 2019-02-08  Jim Wilson  <jimw@sifive.com>
5938
5939         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5940         (riscv_linux_fregset): New.
5941         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5942
5943 2019-02-07  Tom Tromey  <tom@tromey.com>
5944
5945         * thread.c (thread_cancel_execution_command): Update.
5946         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5947         methods.
5948         (struct thread_fsm_ops): Remove.
5949         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5950         (thread_fsm_should_stop, thread_fsm_return_value)
5951         (thread_fsm_set_finished, thread_fsm_finished_p)
5952         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5953         Don't declare.
5954         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5955         * infrun.c (clear_proceed_status_thread)
5956         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5957         (print_stop_event): Update.
5958         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5959         Add constructor.
5960         (step_command_fsm_ops): Remove.
5961         (new_step_command_fsm): Remove.
5962         (step_1): Update.
5963         (step_command_fsm::should_stop): Rename from
5964         step_command_fsm_should_stop.
5965         (step_command_fsm::clean_up): Rename from
5966         step_command_fsm_clean_up.
5967         (step_command_fsm::do_async_reply_reason): Rename from
5968         step_command_fsm_async_reply_reason.
5969         (struct until_next_fsm): Inherit from thread_fsm.  Add
5970         constructor.
5971         (until_next_fsm_ops): Remove.
5972         (new_until_next_fsm): Remove.
5973         (until_next_fsm::should_stop): Rename from
5974         until_next_fsm_should_stop.
5975         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5976         (until_next_fsm::do_async_reply_reason): Rename from
5977         until_next_fsm_async_reply_reason.
5978         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5979         constructor.  Change type of breakpoint.
5980         (finish_command_fsm_ops): Remove.
5981         (new_finish_command_fsm): Remove.
5982         (finish_command_fsm::should_stop): Rename from
5983         finish_command_fsm_should_stop.
5984         (finish_command_fsm::clean_up): Rename from
5985         finish_command_fsm_clean_up.
5986         (finish_command_fsm::return_value): Rename from
5987         finish_command_fsm_return_value.
5988         (finish_command_fsm::do_async_reply_reason): Rename from
5989         finish_command_fsm_async_reply_reason.
5990         (finish_command): Update.
5991         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5992         Add constructor.
5993         (call_thread_fsm_ops): Remove.
5994         (call_thread_fsm::call_thread_fsm): Rename from
5995         new_call_thread_fsm.
5996         (call_thread_fsm::should_stop): Rename from
5997         call_thread_fsm_should_stop.
5998         (call_thread_fsm::should_notify_stop): Rename from
5999         call_thread_fsm_should_notify_stop.
6000         (run_inferior_call, call_function_by_hand_dummy): Update.
6001         * cli/cli-interp.c (should_print_stop_to_console): Update.
6002         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6003         Add constructor.  Change type of location_breakpoint,
6004         caller_breakpoint.
6005         (until_break_fsm_ops): Remove.
6006         (new_until_break_fsm): Remove.
6007         (until_break_fsm::should_stop): Rename from
6008         until_break_fsm_should_stop.
6009         (until_break_fsm::clean_up): Rename from
6010         until_break_fsm_clean_up.
6011         (until_break_fsm::do_async_reply_reason): Rename from
6012         until_break_fsm_async_reply_reason.
6013         (until_break_command): Update.
6014         * thread-fsm.c: Remove.
6015         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6016
6017 2019-02-07  Tom Tromey  <tom@tromey.com>
6018
6019         * yy-remap.h: Add include guard.
6020         * xtensa-tdep.h: Add include guard.
6021         * xcoffread.h: Rename include guard.
6022         * varobj-iter.h: Add include guard.
6023         * tui/tui.h: Rename include guard.
6024         * tui/tui-winsource.h: Rename include guard.
6025         * tui/tui-wingeneral.h: Rename include guard.
6026         * tui/tui-windata.h: Rename include guard.
6027         * tui/tui-win.h: Rename include guard.
6028         * tui/tui-stack.h: Rename include guard.
6029         * tui/tui-source.h: Rename include guard.
6030         * tui/tui-regs.h: Rename include guard.
6031         * tui/tui-out.h: Rename include guard.
6032         * tui/tui-layout.h: Rename include guard.
6033         * tui/tui-io.h: Rename include guard.
6034         * tui/tui-hooks.h: Rename include guard.
6035         * tui/tui-file.h: Rename include guard.
6036         * tui/tui-disasm.h: Rename include guard.
6037         * tui/tui-data.h: Rename include guard.
6038         * tui/tui-command.h: Rename include guard.
6039         * tic6x-tdep.h: Add include guard.
6040         * target/waitstatus.h: Rename include guard.
6041         * target/wait.h: Rename include guard.
6042         * target/target.h: Rename include guard.
6043         * target/resume.h: Rename include guard.
6044         * target-float.h: Rename include guard.
6045         * stabsread.h: Add include guard.
6046         * rs6000-tdep.h: Add include guard.
6047         * riscv-fbsd-tdep.h: Add include guard.
6048         * regformats/regdef.h: Rename include guard.
6049         * record.h: Rename include guard.
6050         * python/python.h: Rename include guard.
6051         * python/python-internal.h: Rename include guard.
6052         * python/py-stopevent.h: Rename include guard.
6053         * python/py-ref.h: Rename include guard.
6054         * python/py-record.h: Rename include guard.
6055         * python/py-record-full.h: Rename include guard.
6056         * python/py-record-btrace.h: Rename include guard.
6057         * python/py-instruction.h: Rename include guard.
6058         * python/py-events.h: Rename include guard.
6059         * python/py-event.h: Rename include guard.
6060         * procfs.h: Add include guard.
6061         * proc-utils.h: Add include guard.
6062         * p-lang.h: Add include guard.
6063         * or1k-tdep.h: Rename include guard.
6064         * observable.h: Rename include guard.
6065         * nto-tdep.h: Rename include guard.
6066         * nat/x86-linux.h: Rename include guard.
6067         * nat/x86-linux-dregs.h: Rename include guard.
6068         * nat/x86-gcc-cpuid.h: Add include guard.
6069         * nat/x86-dregs.h: Rename include guard.
6070         * nat/x86-cpuid.h: Rename include guard.
6071         * nat/ppc-linux.h: Rename include guard.
6072         * nat/mips-linux-watch.h: Rename include guard.
6073         * nat/linux-waitpid.h: Rename include guard.
6074         * nat/linux-ptrace.h: Rename include guard.
6075         * nat/linux-procfs.h: Rename include guard.
6076         * nat/linux-osdata.h: Rename include guard.
6077         * nat/linux-nat.h: Rename include guard.
6078         * nat/linux-namespaces.h: Rename include guard.
6079         * nat/linux-btrace.h: Rename include guard.
6080         * nat/glibc_thread_db.h: Rename include guard.
6081         * nat/gdb_thread_db.h: Rename include guard.
6082         * nat/gdb_ptrace.h: Rename include guard.
6083         * nat/fork-inferior.h: Rename include guard.
6084         * nat/amd64-linux-siginfo.h: Rename include guard.
6085         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6086         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6087         * nat/aarch64-linux.h: Rename include guard.
6088         * nat/aarch64-linux-hw-point.h: Rename include guard.
6089         * mn10300-tdep.h: Add include guard.
6090         * mips-linux-tdep.h: Add include guard.
6091         * mi/mi-parse.h: Rename include guard.
6092         * mi/mi-out.h: Rename include guard.
6093         * mi/mi-main.h: Rename include guard.
6094         * mi/mi-interp.h: Rename include guard.
6095         * mi/mi-getopt.h: Rename include guard.
6096         * mi/mi-console.h: Rename include guard.
6097         * mi/mi-common.h: Rename include guard.
6098         * mi/mi-cmds.h: Rename include guard.
6099         * mi/mi-cmd-break.h: Rename include guard.
6100         * m2-lang.h: Add include guard.
6101         * location.h: Rename include guard.
6102         * linux-record.h: Rename include guard.
6103         * linux-nat.h: Add include guard.
6104         * linux-fork.h: Add include guard.
6105         * i386-darwin-tdep.h: Rename include guard.
6106         * hppa-linux-offsets.h: Add include guard.
6107         * guile/guile.h: Rename include guard.
6108         * guile/guile-internal.h: Rename include guard.
6109         * gnu-nat.h: Rename include guard.
6110         * gdb-stabs.h: Rename include guard.
6111         * frv-tdep.h: Add include guard.
6112         * f-lang.h: Add include guard.
6113         * event-loop.h: Add include guard.
6114         * darwin-nat.h: Rename include guard.
6115         * cp-abi.h: Rename include guard.
6116         * config/sparc/nm-sol2.h: Rename include guard.
6117         * config/nm-nto.h: Rename include guard.
6118         * config/nm-linux.h: Add include guard.
6119         * config/i386/nm-i386gnu.h: Rename include guard.
6120         * config/djgpp/nl_types.h: Rename include guard.
6121         * config/djgpp/langinfo.h: Rename include guard.
6122         * compile/gcc-cp-plugin.h: Add include guard.
6123         * compile/gcc-c-plugin.h: Add include guard.
6124         * compile/compile.h: Rename include guard.
6125         * compile/compile-object-run.h: Rename include guard.
6126         * compile/compile-object-load.h: Rename include guard.
6127         * compile/compile-internal.h: Rename include guard.
6128         * compile/compile-cplus.h: Rename include guard.
6129         * compile/compile-c.h: Rename include guard.
6130         * common/xml-utils.h: Rename include guard.
6131         * common/x86-xstate.h: Rename include guard.
6132         * common/version.h: Rename include guard.
6133         * common/vec.h: Rename include guard.
6134         * common/tdesc.h: Rename include guard.
6135         * common/selftest.h: Rename include guard.
6136         * common/scoped_restore.h: Rename include guard.
6137         * common/scoped_mmap.h: Rename include guard.
6138         * common/scoped_fd.h: Rename include guard.
6139         * common/safe-iterator.h: Rename include guard.
6140         * common/run-time-clock.h: Rename include guard.
6141         * common/refcounted-object.h: Rename include guard.
6142         * common/queue.h: Rename include guard.
6143         * common/ptid.h: Rename include guard.
6144         * common/print-utils.h: Rename include guard.
6145         * common/preprocessor.h: Rename include guard.
6146         * common/pathstuff.h: Rename include guard.
6147         * common/observable.h: Rename include guard.
6148         * common/netstuff.h: Rename include guard.
6149         * common/job-control.h: Rename include guard.
6150         * common/host-defs.h: Rename include guard.
6151         * common/gdb_wait.h: Rename include guard.
6152         * common/gdb_vecs.h: Rename include guard.
6153         * common/gdb_unlinker.h: Rename include guard.
6154         * common/gdb_unique_ptr.h: Rename include guard.
6155         * common/gdb_tilde_expand.h: Rename include guard.
6156         * common/gdb_sys_time.h: Rename include guard.
6157         * common/gdb_string_view.h: Rename include guard.
6158         * common/gdb_splay_tree.h: Rename include guard.
6159         * common/gdb_setjmp.h: Rename include guard.
6160         * common/gdb_ref_ptr.h: Rename include guard.
6161         * common/gdb_optional.h: Rename include guard.
6162         * common/gdb_locale.h: Rename include guard.
6163         * common/gdb_assert.h: Rename include guard.
6164         * common/filtered-iterator.h: Rename include guard.
6165         * common/filestuff.h: Rename include guard.
6166         * common/fileio.h: Rename include guard.
6167         * common/environ.h: Rename include guard.
6168         * common/common-utils.h: Rename include guard.
6169         * common/common-types.h: Rename include guard.
6170         * common/common-regcache.h: Rename include guard.
6171         * common/common-inferior.h: Rename include guard.
6172         * common/common-gdbthread.h: Rename include guard.
6173         * common/common-exceptions.h: Rename include guard.
6174         * common/common-defs.h: Rename include guard.
6175         * common/common-debug.h: Rename include guard.
6176         * common/cleanups.h: Rename include guard.
6177         * common/buffer.h: Rename include guard.
6178         * common/btrace-common.h: Rename include guard.
6179         * common/break-common.h: Rename include guard.
6180         * cli/cli-utils.h: Rename include guard.
6181         * cli/cli-style.h: Rename include guard.
6182         * cli/cli-setshow.h: Rename include guard.
6183         * cli/cli-script.h: Rename include guard.
6184         * cli/cli-interp.h: Rename include guard.
6185         * cli/cli-decode.h: Rename include guard.
6186         * cli/cli-cmds.h: Rename include guard.
6187         * charset-list.h: Add include guard.
6188         * buildsym-legacy.h: Rename include guard.
6189         * bfin-tdep.h: Add include guard.
6190         * ax.h: Rename include guard.
6191         * arm-linux-tdep.h: Add include guard.
6192         * arm-fbsd-tdep.h: Add include guard.
6193         * arch/xtensa.h: Rename include guard.
6194         * arch/tic6x.h: Add include guard.
6195         * arch/i386.h: Add include guard.
6196         * arch/arm.h: Rename include guard.
6197         * arch/arm-linux.h: Rename include guard.
6198         * arch/arm-get-next-pcs.h: Rename include guard.
6199         * arch/amd64.h: Add include guard.
6200         * arch/aarch64-insn.h: Rename include guard.
6201         * arch-utils.h: Rename include guard.
6202         * annotate.h: Add include guard.
6203         * amd64-darwin-tdep.h: Rename include guard.
6204         * aarch64-linux-tdep.h: Add include guard.
6205         * aarch64-fbsd-tdep.h: Add include guard.
6206         * aarch32-linux-nat.h: Add include guard.
6207
6208 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6209
6210         * macrotab.c (macro_define_internal): New function that
6211         factorizes macro_define_object_internal and macro_define_function
6212         code.
6213         (macro_define_object_internal): Use macro_define_internal.
6214         (macro_define_function): Likewise.
6215
6216 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6217
6218         * macrocmd.c (extract_identifier): Return
6219         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6220         callers.
6221
6222 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6223
6224         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6225
6226 2019-02-05  Tom Tromey  <tom@tromey.com>
6227
6228         * target.c (target_stack::unpush): Move assertion earlier.
6229
6230 2019-01-30  Tom Tromey  <tom@tromey.com>
6231
6232         PR python/23615:
6233         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6234         (gdbpy_parse_and_eval): Likewise.
6235         * python/python-internal.h (gdbpy_allow_threads): New class.
6236
6237 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6238
6239         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6240         (aarch64_fbsd_fpregmap): Move earlier.
6241         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6242         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6243         instead of individual calls to trad_frame_set_reg_addr.
6244         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6245         earlier.
6246         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6247         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6248         instead of individual calls to trad_frame_set_reg_addr.
6249
6250 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6251
6252         * CONTRIBUTE: Replace contribution list with wiki link.
6253
6254 2019-01-25  Tom Tromey  <tom@tromey.com>
6255
6256         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6257
6258 2019-01-25  Tom Tromey  <tom@tromey.com>
6259
6260         * xtensa-linux-nat.c: Fix common/ includes.
6261         * xml-support.h: Fix common/ includes.
6262         * xml-support.c: Fix common/ includes.
6263         * x86-linux-nat.c: Fix common/ includes.
6264         * windows-nat.c: Fix common/ includes.
6265         * varobj.h: Fix common/ includes.
6266         * varobj.c: Fix common/ includes.
6267         * value.c: Fix common/ includes.
6268         * valops.c: Fix common/ includes.
6269         * utils.c: Fix common/ includes.
6270         * unittests/xml-utils-selftests.c: Fix common/ includes.
6271         * unittests/utils-selftests.c: Fix common/ includes.
6272         * unittests/unpack-selftests.c: Fix common/ includes.
6273         * unittests/tracepoint-selftests.c: Fix common/ includes.
6274         * unittests/style-selftests.c: Fix common/ includes.
6275         * unittests/string_view-selftests.c: Fix common/ includes.
6276         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6277         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6278         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6279         * unittests/rsp-low-selftests.c: Fix common/ includes.
6280         * unittests/parse-connection-spec-selftests.c: Fix common/
6281         includes.
6282         * unittests/optional-selftests.c: Fix common/ includes.
6283         * unittests/offset-type-selftests.c: Fix common/ includes.
6284         * unittests/observable-selftests.c: Fix common/ includes.
6285         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6286         * unittests/memrange-selftests.c: Fix common/ includes.
6287         * unittests/memory-map-selftests.c: Fix common/ includes.
6288         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6289         * unittests/function-view-selftests.c: Fix common/ includes.
6290         * unittests/environ-selftests.c: Fix common/ includes.
6291         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6292         * unittests/common-utils-selftests.c: Fix common/ includes.
6293         * unittests/cli-utils-selftests.c: Fix common/ includes.
6294         * unittests/array-view-selftests.c: Fix common/ includes.
6295         * ui-file.c: Fix common/ includes.
6296         * tui/tui-io.c: Fix common/ includes.
6297         * tracepoint.h: Fix common/ includes.
6298         * tracepoint.c: Fix common/ includes.
6299         * tracefile-tfile.c: Fix common/ includes.
6300         * top.h: Fix common/ includes.
6301         * top.c: Fix common/ includes.
6302         * thread.c: Fix common/ includes.
6303         * target/waitstatus.h: Fix common/ includes.
6304         * target/waitstatus.c: Fix common/ includes.
6305         * target.h: Fix common/ includes.
6306         * target.c: Fix common/ includes.
6307         * target-memory.c: Fix common/ includes.
6308         * target-descriptions.c: Fix common/ includes.
6309         * symtab.h: Fix common/ includes.
6310         * symfile.c: Fix common/ includes.
6311         * stap-probe.c: Fix common/ includes.
6312         * spu-linux-nat.c: Fix common/ includes.
6313         * sparc-nat.c: Fix common/ includes.
6314         * source.c: Fix common/ includes.
6315         * solib.c: Fix common/ includes.
6316         * solib-target.c: Fix common/ includes.
6317         * ser-unix.c: Fix common/ includes.
6318         * ser-tcp.c: Fix common/ includes.
6319         * ser-pipe.c: Fix common/ includes.
6320         * ser-base.c: Fix common/ includes.
6321         * selftest-arch.c: Fix common/ includes.
6322         * s12z-tdep.c: Fix common/ includes.
6323         * rust-exp.y: Fix common/ includes.
6324         * rs6000-aix-tdep.c: Fix common/ includes.
6325         * riscv-tdep.c: Fix common/ includes.
6326         * remote.c: Fix common/ includes.
6327         * remote-notif.h: Fix common/ includes.
6328         * remote-fileio.h: Fix common/ includes.
6329         * remote-fileio.c: Fix common/ includes.
6330         * regcache.h: Fix common/ includes.
6331         * regcache.c: Fix common/ includes.
6332         * record-btrace.c: Fix common/ includes.
6333         * python/python.c: Fix common/ includes.
6334         * python/py-type.c: Fix common/ includes.
6335         * python/py-inferior.c: Fix common/ includes.
6336         * progspace.h: Fix common/ includes.
6337         * producer.c: Fix common/ includes.
6338         * procfs.c: Fix common/ includes.
6339         * proc-api.c: Fix common/ includes.
6340         * printcmd.c: Fix common/ includes.
6341         * ppc-linux-nat.c: Fix common/ includes.
6342         * parser-defs.h: Fix common/ includes.
6343         * osdata.c: Fix common/ includes.
6344         * obsd-nat.c: Fix common/ includes.
6345         * nat/x86-linux.c: Fix common/ includes.
6346         * nat/x86-linux-dregs.c: Fix common/ includes.
6347         * nat/x86-dregs.h: Fix common/ includes.
6348         * nat/x86-dregs.c: Fix common/ includes.
6349         * nat/ppc-linux.c: Fix common/ includes.
6350         * nat/mips-linux-watch.h: Fix common/ includes.
6351         * nat/mips-linux-watch.c: Fix common/ includes.
6352         * nat/linux-waitpid.c: Fix common/ includes.
6353         * nat/linux-ptrace.h: Fix common/ includes.
6354         * nat/linux-ptrace.c: Fix common/ includes.
6355         * nat/linux-procfs.c: Fix common/ includes.
6356         * nat/linux-personality.c: Fix common/ includes.
6357         * nat/linux-osdata.c: Fix common/ includes.
6358         * nat/linux-namespaces.c: Fix common/ includes.
6359         * nat/linux-btrace.h: Fix common/ includes.
6360         * nat/linux-btrace.c: Fix common/ includes.
6361         * nat/fork-inferior.c: Fix common/ includes.
6362         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6363         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6364         * nat/aarch64-linux.c: Fix common/ includes.
6365         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6366         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6367         * namespace.h: Fix common/ includes.
6368         * mips-linux-tdep.c: Fix common/ includes.
6369         * minsyms.c: Fix common/ includes.
6370         * mi/mi-parse.h: Fix common/ includes.
6371         * mi/mi-main.c: Fix common/ includes.
6372         * mi/mi-cmd-env.c: Fix common/ includes.
6373         * memrange.h: Fix common/ includes.
6374         * memattr.c: Fix common/ includes.
6375         * maint.h: Fix common/ includes.
6376         * maint.c: Fix common/ includes.
6377         * main.c: Fix common/ includes.
6378         * machoread.c: Fix common/ includes.
6379         * location.c: Fix common/ includes.
6380         * linux-thread-db.c: Fix common/ includes.
6381         * linux-nat.c: Fix common/ includes.
6382         * linux-fork.c: Fix common/ includes.
6383         * inline-frame.c: Fix common/ includes.
6384         * infrun.c: Fix common/ includes.
6385         * inflow.c: Fix common/ includes.
6386         * inferior.h: Fix common/ includes.
6387         * inferior.c: Fix common/ includes.
6388         * infcmd.c: Fix common/ includes.
6389         * inf-ptrace.c: Fix common/ includes.
6390         * inf-child.c: Fix common/ includes.
6391         * ia64-linux-nat.c: Fix common/ includes.
6392         * i387-tdep.c: Fix common/ includes.
6393         * i386-tdep.c: Fix common/ includes.
6394         * i386-linux-tdep.c: Fix common/ includes.
6395         * i386-linux-nat.c: Fix common/ includes.
6396         * i386-go32-tdep.c: Fix common/ includes.
6397         * i386-fbsd-tdep.c: Fix common/ includes.
6398         * i386-fbsd-nat.c: Fix common/ includes.
6399         * guile/scm-type.c: Fix common/ includes.
6400         * guile/guile.c: Fix common/ includes.
6401         * go32-nat.c: Fix common/ includes.
6402         * gnu-nat.c: Fix common/ includes.
6403         * gdbthread.h: Fix common/ includes.
6404         * gdbarch-selftests.c: Fix common/ includes.
6405         * gdb_usleep.c: Fix common/ includes.
6406         * gdb_select.h: Fix common/ includes.
6407         * gdb_bfd.c: Fix common/ includes.
6408         * gcore.c: Fix common/ includes.
6409         * fork-child.c: Fix common/ includes.
6410         * findvar.c: Fix common/ includes.
6411         * fbsd-nat.c: Fix common/ includes.
6412         * event-top.c: Fix common/ includes.
6413         * event-loop.c: Fix common/ includes.
6414         * dwarf2read.c: Fix common/ includes.
6415         * dwarf2loc.c: Fix common/ includes.
6416         * dwarf2-frame.c: Fix common/ includes.
6417         * dwarf-index-cache.c: Fix common/ includes.
6418         * dtrace-probe.c: Fix common/ includes.
6419         * disasm-selftests.c: Fix common/ includes.
6420         * defs.h: Fix common/ includes.
6421         * csky-tdep.c: Fix common/ includes.
6422         * cp-valprint.c: Fix common/ includes.
6423         * cp-support.h: Fix common/ includes.
6424         * cp-support.c: Fix common/ includes.
6425         * corelow.c: Fix common/ includes.
6426         * completer.h: Fix common/ includes.
6427         * completer.c: Fix common/ includes.
6428         * compile/compile.c: Fix common/ includes.
6429         * compile/compile-loc2c.c: Fix common/ includes.
6430         * compile/compile-cplus-types.c: Fix common/ includes.
6431         * compile/compile-cplus-symbols.c: Fix common/ includes.
6432         * command.h: Fix common/ includes.
6433         * cli/cli-dump.c: Fix common/ includes.
6434         * cli/cli-cmds.c: Fix common/ includes.
6435         * charset.c: Fix common/ includes.
6436         * build-id.c: Fix common/ includes.
6437         * btrace.h: Fix common/ includes.
6438         * btrace.c: Fix common/ includes.
6439         * breakpoint.h: Fix common/ includes.
6440         * breakpoint.c: Fix common/ includes.
6441         * ax.h:
6442         (enum agent_op): Fix common/ includes.
6443         * ax-general.c (struct aop_map): Fix common/ includes.
6444         * ax-gdb.c: Fix common/ includes.
6445         * auxv.c: Fix common/ includes.
6446         * auto-load.c: Fix common/ includes.
6447         * arm-tdep.c: Fix common/ includes.
6448         * arch/riscv.c: Fix common/ includes.
6449         * arch/ppc-linux-common.c: Fix common/ includes.
6450         * arch/i386.c: Fix common/ includes.
6451         * arch/arm.c: Fix common/ includes.
6452         * arch/arm-linux.c: Fix common/ includes.
6453         * arch/arm-get-next-pcs.c: Fix common/ includes.
6454         * arch/amd64.c: Fix common/ includes.
6455         * arch/aarch64.c: Fix common/ includes.
6456         * arch/aarch64-insn.c: Fix common/ includes.
6457         * arch-utils.c: Fix common/ includes.
6458         * amd64-windows-tdep.c: Fix common/ includes.
6459         * amd64-tdep.c: Fix common/ includes.
6460         * amd64-sol2-tdep.c: Fix common/ includes.
6461         * amd64-obsd-tdep.c: Fix common/ includes.
6462         * amd64-nbsd-tdep.c: Fix common/ includes.
6463         * amd64-linux-tdep.c: Fix common/ includes.
6464         * amd64-linux-nat.c: Fix common/ includes.
6465         * amd64-fbsd-tdep.c: Fix common/ includes.
6466         * amd64-fbsd-nat.c: Fix common/ includes.
6467         * amd64-dicos-tdep.c: Fix common/ includes.
6468         * amd64-darwin-tdep.c: Fix common/ includes.
6469         * agent.c: Fix common/ includes.
6470         * ada-lang.h: Fix common/ includes.
6471         * ada-lang.c: Fix common/ includes.
6472         * aarch64-tdep.c: Fix common/ includes.
6473
6474 2019-01-25  Tom Tromey  <tom@tromey.com>
6475
6476         * common/create-version.sh: Use common/version.h.
6477
6478 2019-01-24  Pedro Alves  <palves@redhat.com>
6479
6480         * infrun.c (signal_stop, signal_print, signal_program)
6481         (signal_catch, signal_pass): Now arrays instead of pointers.
6482         (update_signals_program_target, do_target_resume)
6483         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6484         * linux-nat.c (linux_nat_target::pass_signals)
6485         (linux_nat_target::create_inferior, linux_nat_target::attach):
6486         Adjust.
6487         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6488         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6489         * procfs.c (procfs_target::pass_signals): Adjust.
6490         * record-full.c (record_full_target::resume): Adjust.
6491         * remote.c (remote_target::pass_signals)
6492         (remote_target::program_signals): Adjust.
6493         * target-debug.h (target_debug_print_signals): Now takes a
6494         gdb::array_view as parameter.  Adjust.
6495         * target.h (target_ops) <pass_signals, program_signals>: Replace
6496         pointer and length parameters with gdb::array_view.
6497         (target_pass_signals, target_program_signals): Likewise.
6498         * target-delegates.c: Regenerate.
6499
6500 2019-01-24  Pedro Alves  <palves@redhat.com>
6501
6502         * common/forward-scope-exit.h
6503         (forward_scope_exit::forward_scope_exit): Pass arguments to
6504         m_bind_function directly, instead of creating a std::bind and
6505         copying that.
6506
6507 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6508
6509         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6510         for static members.
6511         (pass_in_v_vfp_candidate): Likewise.
6512
6513 2019-01-23  Tom Tromey  <tom@tromey.com>
6514             Pedro Alves  <palves@redhat.com>
6515
6516         * regcache.c (class regcache_invalidator): Remove.
6517         (regcache::raw_write): Use make_scope_exit.
6518
6519 2019-01-23  Tom Tromey  <tom@tromey.com>
6520
6521         * ui-out.h (class ui_out_emit_type): Update comment.
6522
6523 2019-01-23  Tom Tromey  <tom@tromey.com>
6524
6525         * infrun.c (fetch_inferior_event): Update comment.
6526
6527 2019-01-23  Tom Tromey  <tom@tromey.com>
6528             Pedro Alves  <palves@redhat.com>
6529
6530         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6531         parameter.
6532         (fetch_inferior_event): Use SCOPE_EXIT.
6533
6534
6535 2019-01-23  Tom Tromey  <tom@tromey.com>
6536             Pedro Alves  <palves@redhat.com>
6537
6538         * infrun.c (disable_thread_events): Delete.
6539         (stop_all_threads): Use SCOPE_EXIT.
6540
6541 2019-01-23  Tom Tromey  <tom@tromey.com>
6542             Pedro Alves  <palves@redhat.com>
6543
6544         * symfile.c: Include forward-scope-exit.h.
6545         (clear_symtab_users_cleanup): Replace forward declaration with
6546         a FORWARD_SCOPE_EXIT.
6547         (syms_from_objfile_1): Use the forward_scope_exit and
6548         gdb::optional instead of cleanup_function.
6549         (reread_symbols): Use the forward_scope_exit instead of
6550         cleanup_function.
6551         (clear_symtab_users_cleanup): Remove function.
6552
6553 2019-01-23  Tom Tromey  <tom@tromey.com>
6554             Pedro Alves  <palves@redhat.com>
6555
6556         * linux-nat.c: Include scope-exit.h.
6557         (cleanup_target_stop): Remove.
6558         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6559         SCOPE_EXIT.
6560
6561 2019-01-23  Tom Tromey  <tom@tromey.com>
6562             Pedro Alves  <palves@redhat.com>
6563
6564         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6565         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6566
6567 2019-01-23  Tom Tromey  <tom@tromey.com>
6568             Andrew Burgess  <andrew.burgess@embecosm.com>
6569             Pedro Alves  <palves@redhat.com>
6570
6571         * infrun.c (fetch_inferior_event): Use scope_exit.
6572         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6573         * top.c (execute_command): Use scope_exit.
6574         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6575         * utils.c (do_bpstat_clear_actions_cleanup)
6576         (make_bpstat_clear_actions_cleanup): Remove.
6577
6578 2019-01-23  Tom Tromey  <tom@tromey.com>
6579             Pedro Alves  <palves@redhat.com>
6580
6581         * infrun.c: Include "common/scope-exit.h"
6582         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6583         (wait_for_inferior): Use SCOPE_EXIT.
6584         (fetch_inferior_event): Use scope_exit.
6585
6586 2019-01-23  Tom Tromey  <tom@tromey.com>
6587             Pedro Alves  <palves@redhat.com>
6588
6589         * breakpoint.c (create_breakpoint): Remove cleanup.
6590
6591 2019-01-23  Tom Tromey  <tom@tromey.com>
6592             Andrew Burgess  <andrew.burgess@embecosm.com>
6593             Pedro Alves  <palves@redhat.com>
6594
6595 2019-01-23  Pedro Alves  <palves@redhat.com>
6596
6597         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6598
6599 2019-01-23  Pedro Alves  <palves@redhat.com>
6600             Andrew Burgess  <andrew.burgess@embecosm.com>
6601
6602         * gdbthread.h: Include "common/forward-scope-exit.h".
6603         (scoped_finish_thread_state): Redefine custom class in terms of
6604         forward_scope_exit.
6605
6606 2019-01-23  Pedro Alves  <palves@redhat.com>
6607             Andrew Burgess  <andrew.burgess@embecosm.com>
6608
6609         * common/forward-scope-exit.h: New file.
6610
6611 2019-01-23  Pedro Alves  <palves@redhat.com>
6612             Andrew Burgess  <andrew.burgess@embecosm.com>
6613             Tom Tromey  <tom@tromey.com>
6614
6615         * common/scope-exit.h: New file.
6616
6617 2019-01-23  Pedro Alves  <palves@redhat.com>
6618
6619         * common/preprocessor.h (ESC): Rename to ...
6620         (ESC_PARENS): ... this.
6621         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6622         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6623
6624 2019-01-23  Tom Tromey  <tom@tromey.com>
6625
6626         * language.h (class scoped_switch_to_sym_language_if_auto):
6627         Initialize m_lang in both cases.
6628
6629 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6630
6631         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6632         with XCNEW.
6633
6634 2019-01-22  Tom Tromey  <tom@tromey.com>
6635
6636         * corelow.c: Do not include sys/file.h.
6637
6638 2019-01-22  Tom Tromey  <tom@tromey.com>
6639
6640         * tui/tui-wingeneral.h: Include gdb_curses.h.
6641
6642 2019-01-22  Tom Tromey  <tom@tromey.com>
6643
6644         * source-cache.h (class source_cache) <get_source_lines,
6645         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6646
6647 2019-01-22  Tom Tromey  <tom@tromey.com>
6648
6649         * remote-fileio.h (struct remote_target): Declare.
6650
6651 2019-01-22  Tom Tromey  <tom@tromey.com>
6652
6653         * python/py-arch.c: Do not include py-ref.h.
6654         * python/py-bpevent.c: Do not include py-ref.h.
6655         * python/py-cmd.c: Do not include py-ref.h.
6656         * python/py-continueevent.c: Do not include py-ref.h.
6657         * python/py-event.h: Do not include py-ref.h.
6658         * python/py-evtregistry.c: Do not include py-ref.h.
6659         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6660         * python/py-frame.c: Do not include py-ref.h.
6661         * python/py-framefilter.c: Do not include py-ref.h.
6662         * python/py-function.c: Do not include py-ref.h.
6663         * python/py-infevents.c: Do not include py-ref.h.
6664         * python/py-linetable.c: Do not include py-ref.h.
6665         * python/py-objfile.c: Do not include py-ref.h.
6666         * python/py-param.c: Do not include py-ref.h.
6667         * python/py-prettyprint.c: Do not include py-ref.h.
6668         * python/py-progspace.c: Do not include py-ref.h.
6669         * python/py-symbol.c: Do not include py-ref.h.
6670         * python/py-symtab.c: Do not include py-ref.h.
6671         * python/py-type.c: Do not include py-ref.h.
6672         * python/py-unwind.c: Do not include py-ref.h.
6673         * python/py-utils.c: Do not include py-ref.h.
6674         * python/py-value.c: Do not include py-ref.h.
6675         * python/py-varobj.c: Do not include py-ref.h.
6676         * python/py-xmethods.c: Do not include py-ref.h.
6677         * python/python.c: Do not include py-ref.h.
6678         * varobj.c: Do not include py-ref.h.
6679
6680 2019-01-22  Tom Tromey  <tom@tromey.com>
6681
6682         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6683         keyword for bcache.
6684
6685 2019-01-22  Tom Tromey  <tom@tromey.com>
6686
6687         * compile/compile-cplus-types.c: Remove a comment by #include.
6688
6689 2019-01-22  Tom Tromey  <tom@tromey.com>
6690
6691         * compile/gcc-c-plugin.h: Include compile-internal.h.
6692
6693 2019-01-22  Tom Tromey  <tom@tromey.com>
6694
6695         * stabsread.c (EXTERN): Do not define.
6696         (symnum, next_symbol_text_func, processing_gcc_compilation)
6697         (within_function, global_sym_chain, global_stabs)
6698         (previous_stab_code, this_object_header_files)
6699         (n_this_object_header_files)
6700         (n_allocated_this_object_header_files): Define.
6701         * stabsread.h (EXTERN): Never define.  Use "extern".
6702
6703 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6704
6705         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6706         history_value.
6707
6708 2019-01-21  Tom Tromey  <tom@tromey.com>
6709
6710         * ui-out.c: Fix includes.
6711         * tui/tui-source.c: Fix includes.
6712         * target.c: Fix includes.
6713         * remote.c: Fix includes.
6714         * regcache.c: Fix includes.
6715         * python/py-block.c: Fix includes.
6716         * printcmd.c: Fix includes.
6717         * or1k-tdep.c: Fix includes.
6718         * mi/mi-main.c: Fix includes.
6719         * m32r-tdep.c: Fix includes.
6720         * csky-tdep.c: Fix includes.
6721         * compile/compile-cplus-types.c: Fix includes.
6722         * cli/cli-interp.c: Fix includes.
6723
6724 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6725
6726         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6727         for padding.
6728
6729 2019-01-16  Tom Tromey  <tom@tromey.com>
6730
6731         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6732         earlier.
6733         (struct objfile) <msymbols_range>: Move from top level.
6734         <msymbols>: New method.
6735         (class objfile_msymbols): Remove.
6736         * symtab.c (default_collect_symbol_completion_matches_break_on):
6737         Update.
6738         * symmisc.c (dump_msymbols): Update.
6739         * stabsread.c (scan_file_globals): Update.
6740         * objc-lang.c (info_selectors_command, info_classes_command)
6741         (find_methods): Update.
6742         * minsyms.c (find_solib_trampoline_target): Update.
6743         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6744         * coffread.c (coff_symfile_read): Update.
6745         * ada-lang.c (ada_lookup_simple_minsym)
6746         (ada_collect_symbol_completion_matches): Update.
6747
6748 2019-01-16  Tom Tromey  <tom@tromey.com>
6749
6750         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6751         type.  Remove no-argument constructor.
6752         <iterator::operator++>: Simplify.
6753         <begin>: Update.
6754         <end>: Use minimal_symbol_count.
6755
6756 2019-01-16  Tom Tromey  <tom@tromey.com>
6757
6758         * objfiles.h (struct objfile) <psymtabs>: New method.
6759         (class objfile_psymtabs): Remove.
6760         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6761         typedef.
6762         <range>: New method.
6763         (require_partial_symbols): Change return type.
6764         * psymtab.c (require_partial_symbols)
6765         (psym_expand_symtabs_matching): Update.
6766         * mdebugread.c (parse_partial_symbols): Update.
6767         * dbxread.c (dbx_end_psymtab): Update.
6768
6769 2019-01-15  Tom Tromey  <tom@tromey.com>
6770
6771         * symtab.c (lookup_objfile_from_block)
6772         (lookup_symbol_in_objfile_symtabs)
6773         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6774         (find_line_symtab, info_sources_command)
6775         (default_collect_symbol_completion_matches_break_on)
6776         (make_source_files_completion_list): Update.
6777         * symmisc.c (print_objfile_statistics, dump_objfile)
6778         (maintenance_print_symbols, maintenance_info_symtabs)
6779         (maintenance_check_symtabs, maintenance_info_line_tables):
6780         Update.
6781         * source.c (select_source_symtab)
6782         (forget_cached_source_info_for_objfile): Update.
6783         * objfiles.h (class objfile_compunits): Remove.
6784         (struct objfile) <compunits_range>: New typedef.
6785         (compunits): New method.
6786         * objfiles.c (objfile_relocate1): Update.
6787         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6788         * maint.c (count_symtabs_and_blocks): Update.
6789         * linespec.c (iterate_over_all_matching_symtabs): Update.
6790         * cp-support.c (add_symbol_overload_list_qualified): Update.
6791         * coffread.c (coff_symtab_read): Update.
6792         * ada-lang.c (add_nonlocal_symbols)
6793         (ada_collect_symbol_completion_matches)
6794         (ada_add_global_exceptions): Update.
6795
6796 2019-01-15  Tom Tromey  <tom@tromey.com>
6797
6798         * progspace.h (program_space) <objfiles_safe_range>: New
6799         typedef.
6800         <objfiles_safe>: New method.
6801         * objfiles.h (class all_objfiles_safe): Remove.
6802         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6803         * jit.c (jit_inferior_exit_hook): Update.
6804
6805 2019-01-17  Tom Tromey  <tom@tromey.com>
6806
6807         * progspace.h (program_space) <objfiles_range>: New typedef.
6808         <objfiles>: New method.
6809         <objfiles_head>: Rename from objfiles.
6810         (object_files): Update.
6811         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6812         * guile/scm-pretty-print.c
6813         (ppscm_find_pretty_printer_from_objfiles): Update.
6814         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6815         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6816         Update.
6817         * python/py-progspace.c (pspy_get_objfiles): Update.
6818         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6819         Update.
6820         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6821         (objfpy_lookup_objfile_by_build_id): Update.
6822         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6823         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6824         Update.
6825         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6826         (expand_symtab_containing_pc, lookup_objfile_from_block)
6827         (lookup_static_symbol, basic_lookup_transparent_type)
6828         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6829         (find_line_symtab, info_sources_command)
6830         (default_collect_symbol_completion_matches_break_on)
6831         (make_source_files_completion_list, find_main_name): Update.
6832         * symmisc.c (print_symbol_bcache_statistics)
6833         (print_objfile_statistics, maintenance_print_symbols)
6834         (maintenance_print_msymbols, maintenance_print_objfiles)
6835         (maintenance_info_symtabs, maintenance_check_symtabs)
6836         (maintenance_expand_symtabs, maintenance_info_line_tables):
6837         Update.
6838         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6839         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6840         (map_overlay_command, unmap_overlay_command)
6841         (simple_overlay_update, expand_symtabs_matching)
6842         (map_symbol_filenames): Update.
6843         * symfile-debug.c (set_debug_symfile): Update.
6844         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6845         Update.
6846         * source.c (select_source_symtab, forget_cached_source_info):
6847         Update.
6848         * solib.c (solib_read_symbols): Update.
6849         * solib-spu.c (append_ocl_sos): Update.
6850         * psymtab.c (maintenance_print_psymbols)
6851         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6852         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6853         * printcmd.c (info_symbol_command): Update.
6854         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6855         Update.
6856         * objfiles.h (class all_objfiles): Remove.
6857         * objfiles.c (have_partial_symbols, have_full_symbols)
6858         (have_minimal_symbols, qsort_cmp, update_section_map)
6859         (shared_objfile_contains_address_p)
6860         (default_iterate_over_objfiles_in_search_order): Update.
6861         * objc-lang.c (info_selectors_command, info_classes_command)
6862         (find_methods): Update.
6863         * minsyms.c (find_solib_trampoline_target): Update.
6864         * maint.c (maintenance_info_sections)
6865         (maintenance_translate_address, count_symtabs_and_blocks):
6866         Update.
6867         * main.c (captured_main_1): Update.
6868         * linux-thread-db.c (try_thread_db_load_from_pdir)
6869         (has_libpthread): Update.
6870         * linespec.c (iterate_over_all_matching_symtabs)
6871         (search_minsyms_for_name): Update.
6872         * jit.c (jit_find_objf_with_entry_addr): Update.
6873         * hppa-tdep.c (find_unwind_entry)
6874         (hppa_lookup_stub_minimal_symbol): Update.
6875         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6876         Update.
6877         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6878         (elf_gnu_ifunc_resolve_by_got): Update.
6879         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6880         * dwarf-index-write.c (save_gdb_index_command): Update.
6881         * cp-support.c (add_symbol_overload_list_qualified): Update.
6882         * breakpoint.c (create_overlay_event_breakpoint)
6883         (create_longjmp_master_breakpoint)
6884         (create_std_terminate_master_breakpoint)
6885         (create_exception_master_breakpoint): Update.
6886         * blockframe.c (find_pc_partial_function): Update.
6887         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6888         (ada_collect_symbol_completion_matches)
6889         (ada_add_global_exceptions): Update.
6890
6891 2019-01-17  Tom Tromey  <tom@tromey.com>
6892
6893         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6894         declare VEC.
6895         (solib_target_parse_libraries): Change return type.
6896         (library_list_start_segment, library_list_start_section)
6897         (library_list_end_library, library_list_start_library); Update.
6898         (solib_target_free_library_list): Remove.
6899         (solib_target_parse_libraries): Remove cleanup.  Change return
6900         type.
6901         (solib_target_current_sos): Update.
6902
6903 2019-01-17  Tom Tromey  <tromey@bapiya>
6904
6905         * valprint.c: Replace "the the" with "the".
6906         * symtab.c: Replace "the the" with "the".
6907         * solib.c: Replace "the the" with "the".
6908         * solib-dsbt.c: Replace "the the" with "the".
6909         * linespec.c: Replace "the the" with "the".
6910         * dwarf2loc.h: Replace "the the" with "the".
6911         * amd64-windows-tdep.c: Replace "the the" with "the".
6912         * aarch64-tdep.c: Replace "the the" with "the".
6913
6914 2019-01-16  Keith Seitz  <keiths@redhat.com>
6915
6916         PR gdb/23773
6917         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6918         <builder>: Rename to ..
6919         <m_builder>: ... this and make private.
6920         (dwarf2_cu::get_builder): New method.  Change all users of
6921         `builder' to use this method.
6922         (dwarf2_start_symtab): Move to ...
6923         (dwarf2_cu::start_symtab): ... here.  Update all callers
6924         (setup_type_unit_groups): Move to ...
6925         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6926         callers.
6927         (dwarf2_cu::reset_builder): New method.
6928         (process_full_compunit, process_full_type_unit): Use
6929         dwarf2_cu::reset_builder.
6930         (follow_die_offset): Record the ancestor CU if it is different
6931         from the followed DIE's CU.
6932         (follow_die_sig_1): Likewise.
6933
6934 2019-01-15  Tom Tromey  <tom@tromey.com>
6935
6936         * remote.c (class remote_state) <buf>: Now a char_vector.
6937         <buf_size>: Remove.
6938         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6939         parameter.
6940         (remote_target::getpkt_or_notif_sane_1)
6941         (remote_target::getpkt_sane)
6942         (remote_target::getpkt_or_notif_sane): Likewise.
6943         (class remote_target) <putpkt>: New overload.
6944         (remote_target::read_frame): Change type of "buf_p".  Remove
6945         sizeof_p parameter.
6946         (packet_ok): New overload.
6947         (packet_check_result): New overload.
6948         Update all uses.
6949
6950 2019-01-14  Tom Tromey  <tom@tromey.com>
6951
6952         * remote-notif.c (handle_notification, remote_notif_ack)
6953         (remote_notif_parse): Make "buf" const.
6954         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6955         const.
6956         (remote_notif_parse, remote_notif_ack, handle_notification):
6957         Likewise.
6958         * remote.c (remote_notif_stop_parse): Make "buf" const.
6959         (remote_target::remote_parse_stop_reply): Make "buf" const.
6960         (remote_notif_stop_ack): Make "buf" const.
6961
6962 2019-01-14  Tom Tromey  <tom@tromey.com>
6963
6964         * remote.c (remote_console_output): Make parameter const.
6965
6966 2019-01-14  Tom Tromey  <tom@tromey.com>
6967
6968         * target-debug.h (target_debug_print_signals): Constify.
6969         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6970         * procfs.c (procfs_target::pass_signals): Update.
6971         * linux-nat.c (linux_nat_target::pass_signals): Update.
6972         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6973         * target-delegates.c: Rebuild.
6974         * remote.c (remote_target::program_signals): Update.
6975         (remote_target::pass_signals): Update.
6976         * target.c (target_pass_signals): Constify argument.
6977         (target_program_signals): Likewise.
6978         * target.h (struct target_ops) <pass_signals, program_signals>:
6979         Constify argument.
6980         (target_pass_signals, target_program_signals): Constify argument.
6981
6982 2019-01-14  Tom Tromey  <tom@tromey.com>
6983
6984         PR tui/28819:
6985         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6986
6987 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6988
6989         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6990         field.
6991         * rs6000-tdep.c: Include reggroups.h.
6992         (IS_V_ALIAS_PSEUDOREG): Define.
6993         (rs6000_register_name): Return names for the "vX" aliases.
6994         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6995         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6996         aliases.  Call default_register_reggroup_p for all other
6997         pseudo-registers.
6998         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6999         New functions.
7000         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7001         Handle "vX" aliases.
7002         (v_alias_pseudo_register_collect): New function.
7003         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7004         (rs6000_gdbarch_init): Initialize "vX" aliases as
7005         pseudo-registers.  Restore registration of
7006         rs6000_pseudo_register_reggroup_p with
7007         set_tdesc_pseudo_register_reggroup_p.
7008
7009 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7010
7011         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7012         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7013         set_gdbarch_num_pseudo_regs.
7014
7015 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7016
7017         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7018         Remove arg prefixname, add do_set and do_show.
7019         Add member functions set_list and show_list.
7020         * cli/cli-style.c (class cli_style_option): Update accordingly.
7021         (style_set_list): Move to file scope.
7022         (style_show_list): Likewise.
7023         (set_style): Call help_list.
7024         (show_style): Call cmd_show_list.
7025         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7026         Update to use the new macro.
7027
7028 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7029
7030         * ada-lang.c (_initialize_ada_language): Expand the help text
7031         for the "catch exception" command.
7032
7033 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7034
7035         * symtab.c (matching_obj_sections): Initialize obj,
7036         declare it closer to its usage.
7037
7038 2019-01-10  Tom Tromey  <tom@tromey.com>
7039
7040         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7041         (basic_inf_threads_range): Remove.
7042         (inf_threads_range, inf_non_exited_threads_range)
7043         (safe_inf_threads_range): Use next_adapter.
7044
7045 2019-01-10  Keith Seitz  <keiths@redhat.com>
7046
7047         PR gdb/23712
7048         PR symtab/23010
7049         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7050         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7051
7052 2019-01-10  Keith Seitz  <keiths@redhat.com>
7053
7054         PR gdb/23712
7055         PR symtab/23010
7056         * dictionary.c (pending_to_vector): Remove.
7057         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7058         Remove _1 suffix, replacing functions of the same name.  Update
7059         all callers.
7060         (dict_create_hashed, dict_create_hashed_expandable)
7061         (dict_create_linear, dict_create_linear_expandable, dict_free)
7062         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7063         Make functions static.
7064
7065 2019-01-10  Keith Seitz  <keiths@redhat.com>
7066
7067         PR gdb/23712
7068         PR symtab/23010
7069         * dictionary.h (struct dictionary): Replace declaration with
7070         multidictionary.
7071         (dict_create_hashed, dict_create_hashed_expandable)
7072         (dict_create_linear, dict_create_linear_expandable)
7073         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7074         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7075         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7076         taking multidictionary argument.
7077         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7078         * block.h (struct block) <dict>: Change to multidictionary
7079         and rename `multidict'.
7080         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7081         symmisc.c: Update all dictionary references to multidictionary.
7082
7083 2019-01-10  Keith Seitz  <keiths@redhat.com>
7084
7085         PR gdb/23712
7086         PR symtab/23010
7087         * dictionary.c: Include unordered_map.
7088         (pending_to_vector): New function.
7089         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7090         Rewrite the non-"_1" functions to take vector instead
7091         of linked list.
7092         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7093         "new" _1 versions of the same name.
7094         (multidictionary): Define.
7095         (std::hash<enum language): New definition.
7096         (collate_pending_symbols_by_language, mdict_create_hashed)
7097         (mdict_create_hashed_expandable, mdict_create_linear)
7098         (mdict_create_linear_expandable, mdict_free)
7099         (find_language_dictionary, create_new_language_dictionary)
7100         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7101         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7102         (mdict_size, mdict_empty): New functions.
7103         * dictionary.h (mdict_iterator): Define.
7104
7105 2019-01-10  Pedro Alves  <palves@redhat.com>
7106
7107         * breakpoint.c (read_uploaded_action)
7108         (create_tracepoint_from_upload): Adjust to use
7109         gdb::unique_xmalloc_ptr.
7110         * ctf.c (ctf_write_uploaded_tp):
7111         (SET_ARRAY_FIELD): Use emplace_back.
7112         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7113         * tracefile-tfile.c (tfile_write_uploaded_tp):
7114         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7115         gdb::unique_xmalloc_ptr.
7116         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7117         at_string, cond_string, cmd_strings>: Replace char pointers
7118         with gdb::unique_xmalloc_ptr.
7119
7120 2019-01-10  Pedro Alves  <palves@redhat.com>
7121
7122         * solib-target.c (library_list_start_library): Don't xstrdup name.
7123
7124 2019-01-10  Pedro Alves  <palves@redhat.com>
7125
7126         * mdebugread.c (parse_partial_symbols): Use
7127         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7128
7129 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7130
7131         * linux-fork.c (scoped_switch_fork_info)
7132         <~scoped_switch_fork_info>: Fix incorrect variable name.
7133
7134 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7135
7136         * linux-fork.c (scoped_switch_fork_info)
7137         <scoped_switch_fork_info>: Make explicit.
7138         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7139
7140 2019-01-10  Tom Tromey  <tom@tromey.com>
7141
7142         * objfiles.h (objfile::reset_psymtabs): Update.
7143         * objfiles.c (objfile::objfile): Update.
7144         * psymtab.h (psymtab_storage::obstack): Update.
7145         (psymtab_storage::m_obstack): Use gdb::optional.
7146         (class psymtab_storage): Update comment.  Remove objfile
7147         parameter.
7148         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7149
7150 2019-01-10  Tom Tromey  <tom@tromey.com>
7151
7152         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7153         <free_psymtabs>: Now private.
7154         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7155         (allocate_psymtab): Use new method.
7156
7157 2019-01-10  Tom Tromey  <tom@tromey.com>
7158
7159         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7160         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7161         * mdebugread.c (parse_partial_symbols): Use
7162         allocate_dependencies.
7163         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7164         allocate_dependencies.
7165         (process_psymtab_comp_unit_reader)
7166         (build_type_psymtab_dependencies): Likewise.
7167         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7168
7169 2019-01-10  Tom Tromey  <tom@tromey.com>
7170
7171         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7172         PSYMBOL_SET_LANGUAGE.
7173         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7174
7175 2019-01-10  Tom Tromey  <tom@tromey.com>
7176
7177         * psymtab.h (psymtab_storage::obstack): New method.
7178         <m_obstack>: Rename from obstack; now private.
7179         * psymtab.c (psymtab_storage): Update.
7180         * dwarf2read.c (create_addrmap_from_index)
7181         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7182         Update.
7183
7184 2019-01-10  Tom Tromey  <tom@tromey.com>
7185
7186         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7187         * objfiles.h (objfile::reset_psymtabs): New method.
7188
7189 2019-01-10  Tom Tromey  <tom@tromey.com>
7190
7191         * symmisc.c (print_symbol_bcache_statistics): Update.
7192         (print_objfile_statistics): Update.
7193         * symfile.c (reread_symbols): Update.
7194         * psymtab.h (class psymtab_storage): New.
7195         * psymtab.c (psymtab_storage): New constructor.
7196         (~psymtab_storage): New destructor.
7197         (require_partial_symbols): Update.
7198         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7199         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7200         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7201         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7202         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7203         (start_psymtab_common, end_psymtab_common)
7204         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7205         (allocate_psymtab): Update.
7206         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7207         Update.
7208         (dump_psymtab_addrmap, maintenance_print_psymbols)
7209         (maintenance_check_psymtabs): Update.
7210         (class objfile_psymtabs): Move to objfiles.h.
7211         * psympriv.h (discard_psymtab): Now inline.
7212         (psymtab_discarder::psymtab_discarder): Update.
7213         (psymtab_discarder::~psymtab_discarder): Update.
7214         (ALL_OBJFILE_PSYMTABS): Rewrite.
7215         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7216         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7217         Remove fields.
7218         <partial_symtabs>: New field.
7219         (class objfile_psymtabs): Move from psymtab.h.  Update.
7220         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7221         psymbol_cache.
7222         (objfile::~objfile): Don't destroy psymbol_cache.
7223         * mdebugread.c (parse_partial_symbols): Update.
7224         * dwarf2read.c (create_addrmap_from_index)
7225         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7226         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7227         (add_partial_subprogram, dwarf2_ranges_read): Update.
7228         * dwarf-index-write.c (write_address_map)
7229         (write_one_signatured_type, recursively_write_psymbols)
7230         (class debug_names, class debug_names, write_psymtabs_to_index):
7231         Update.
7232
7233 2019-01-10  Tom Tromey  <tom@tromey.com>
7234
7235         * symtab.h (SYMBOL_SET_NAMES): Update.
7236         (symbol_set_names): Update.
7237         (MSYMBOL_SET_NAMES): Update.
7238         * symtab.c (symbol_set_names): Change argument to be an
7239         objfile_per_bfd_storage.
7240         * psymtab.c (add_psymbol_to_bcache): Update.
7241         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7242
7243 2019-01-10  Tom Tromey  <tom@tromey.com>
7244
7245         * symtab.c (create_demangled_names_hash): Change argument to be an
7246         objfile_per_bfd_storage.
7247         (symbol_set_names): Update.
7248
7249 2019-01-10  Tom Tromey  <tom@tromey.com>
7250
7251         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7252         init_psymbol_list.
7253         * psymtab.c (init_psymbol_list): Do nothing if already called.
7254         * psympriv.h (init_psymbol_list): Add comment.
7255         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7256         init_psymbol_list.
7257         * dbxread.c (dbx_symfile_read): Unconditionally call
7258         init_psymbol_list.
7259
7260 2019-01-10  Tom Tromey  <tom@tromey.com>
7261
7262         * xcoffread.c (scan_xcoff_symtab): Update.
7263         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7264         "where".
7265         * mdebugread.c (parse_partial_symbols)
7266         (handle_psymbol_enumerators): Update.
7267         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7268         * dbxread.c (read_dbx_symtab): Update.
7269         * psympriv.h (psymbol_placement): New enum.
7270         (add_psymbol_to_list): Update.
7271
7272 2019-01-10  Tom Tromey  <tom@tromey.com>
7273
7274         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7275         static_psymbols parameters.
7276         (scan_xcoff_symtab): Update.
7277         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7278         static_psymbols parameters.
7279         * psympriv.h (start_psymtab_common): Update.
7280         * mdebugread.c (parse_partial_symbols): Update.
7281         * dwarf2read.c (create_partial_symtab): Update.
7282         * dbxread.c (read_dbx_symtab): Update.
7283         (start_psymtab): Remove global_psymbols and static_psymbols
7284         parameters.
7285
7286 2019-01-10  Tom Tromey  <tom@tromey.com>
7287
7288         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7289         * psymtab.c (allocate_psymtab): Add comment.
7290         * psympriv.h (allocate_psymtab): Add comment.
7291         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7292         initializations.
7293         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7294
7295 2019-01-10  Tom Tromey  <tom@tromey.com>
7296
7297         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7298         Don't declare.
7299         * mipsread.c: Include mdebugread.h.
7300         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7301         Declare.
7302         * elfread.c: Include mdebugread.h.
7303
7304 2019-01-09  Tom Tromey  <tom@tromey.com>
7305
7306         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7307         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7308         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7309         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7310         (psym_lookup_symbol, psym_find_last_source_symtab)
7311         (psym_forget_cached_source_info, psym_print_stats)
7312         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7313         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7314         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7315         (psym_find_compunit_symtab_by_address)
7316         (maintenance_print_psymbols, maintenance_info_psymtabs)
7317         (maintenance_check_psymtabs): Use ranged for.
7318         * psymtab.h (class objfile_psymtabs): New.
7319         (require_partial_symbols): Return objfile_psymtabs.
7320         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7321
7322 2019-01-09  Tom Tromey  <tom@tromey.com>
7323
7324         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7325         (find_pc_mapped_section, list_overlays_command)
7326         (map_overlay_command, unmap_overlay_command)
7327         (simple_overlay_update): Use all_objfiles.
7328         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7329         * printcmd.c (info_symbol_command): Use all_objfiles.
7330         * objfiles.h (ALL_OBJSECTIONS): Remove.
7331         * maint.c (maintenance_translate_address): Use all_objfiles.
7332         * gcore.c (gcore_create_callback): Use all_objfiles.
7333         (objfile_find_memory_regions): Likewise.
7334
7335 2019-01-09  Tom Tromey  <tom@tromey.com>
7336
7337         * symtab.c (find_line_symtab, info_sources_command)
7338         (make_source_files_completion_list): Use objfile_compunits.
7339         * source.c (select_source_symtab): Use objfile_compunits.
7340         * objfiles.h (struct objfile): Update comment.
7341         (ALL_OBJFILES): Remove.
7342         (ALL_FILETABS): Remove.
7343         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7344         objfile_compunits.
7345
7346 2019-01-09  Tom Tromey  <tom@tromey.com>
7347
7348         * symmisc.c (print_objfile_statistics, dump_objfile)
7349         (maintenance_print_symbols): Use compunit_filetabs.
7350         * source.c (forget_cached_source_info_for_objfile): Use
7351         compunit_filetabs.
7352         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7353         (ALL_FILETABS): Use compunit_filetabs.
7354         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7355         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7356
7357 2019-01-09  Tom Tromey  <tom@tromey.com>
7358
7359         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7360         (compunit_filetabs): New.
7361         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7362         compunit_filetabs.
7363         (info_sources_command, make_source_files_completion_list): Remove
7364         declaration.
7365         * symmisc.c (print_objfile_statistics, dump_objfile)
7366         (maintenance_print_symbols): Remove declaration.
7367         (maintenance_info_symtabs): Use compunit_filetabs.
7368         (maintenance_info_line_tables): Likewise.
7369         * source.c (select_source_symtab): Change local variable name.
7370         (forget_cached_source_info_for_objfile): Remove declaration.
7371         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7372         * objfiles.c (objfile_relocate1): Remove declaration.
7373         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7374         declaration.
7375         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7376         * coffread.c (coff_symtab_read): Remove declaration.
7377         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7378         compunit_filetabs.
7379
7380 2019-01-09  Tom Tromey  <tom@tromey.com>
7381
7382         * symtab.c (lookup_objfile_from_block)
7383         (find_pc_sect_compunit_symtab, search_symbols)
7384         (default_collect_symbol_completion_matches_break_on): Use
7385         objfile_compunits.
7386         * objfiles.h (ALL_COMPUNITS): Remove.
7387         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7388         * cp-support.c (add_symbol_overload_list_qualified): Use
7389         objfile_compunits.
7390         * ada-lang.c (ada_collect_symbol_completion_matches)
7391         (ada_add_global_exceptions): Use objfile_compunits.
7392
7393 2019-01-09  Tom Tromey  <tom@tromey.com>
7394
7395         * source.c (select_source_symtab)
7396         (forget_cached_source_info_for_objfile): Remove declaration.
7397         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7398         declaration.
7399         * maint.c (count_symtabs_and_blocks): Remove declaration.
7400         * cp-support.c (add_symbol_overload_list_qualified): Remove
7401         declaration.
7402         * coffread.c (coff_symtab_read): Remove declaration.
7403         * symtab.c (lookup_symbol_in_objfile_symtabs)
7404         (basic_lookup_transparent_type_1): Use objfile_compunits.
7405         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7406         (info_sources_command, search_symbols)
7407         (default_collect_symbol_completion_matches_break_on)
7408         (make_source_files_completion_list): Remove declaration.
7409         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7410         (ada_collect_symbol_completion_matches)
7411         (ada_add_global_exceptions): Remove declaration.
7412         * linespec.c (iterate_over_all_matching_symtabs): Use
7413         objfile_compunits.
7414         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7415         (class objfile_compunits): New.
7416         (ALL_COMPUNITS): Use objfile_compunits.
7417         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7418         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7419         objfile_compunits.
7420         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7421
7422 2019-01-09  Tom Tromey  <tom@tromey.com>
7423
7424         * symtab.c (search_symbols)
7425         (default_collect_symbol_completion_matches_break_on): Use
7426         objfile_msymbols.
7427         * ada-lang.c (ada_lookup_simple_minsym)
7428         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7429         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7430         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7431         objfile_msymbols.
7432         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7433         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7434         * objc-lang.c (find_methods): Use objfile_msymbols.
7435         (info_selectors_command, info_classes_command): Likewise.
7436         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7437         * objfiles.h (class objfile_msymbols): New.
7438         (ALL_OBJFILE_MSYMBOLS): Remove.
7439         (ALL_MSYMBOLS): Remove.
7440
7441 2019-01-09  Tom Tromey  <tom@tromey.com>
7442
7443         * common/next-iterator.h (next_adapter): Add Iterator template
7444         parameter.
7445         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7446         (class all_objfiles_safe): New.
7447         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7448         * objfiles.c (put_objfile_before): Update comment.
7449         (add_separate_debug_objfile): Likewise.
7450         (free_all_objfiles): Use all_objfiles_safe.
7451         (objfile_purge_solibs): Likewise.
7452
7453 2019-01-09  Tom Tromey  <tom@tromey.com>
7454
7455         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7456         (expand_symtab_containing_pc, lookup_static_symbol)
7457         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7458         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7459         all_objfiles.
7460         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7461         * breakpoint.c (create_overlay_event_breakpoint)
7462         (create_longjmp_master_breakpoint)
7463         (create_std_terminate_master_breakpoint)
7464         (create_exception_master_breakpoint): Use all_objfiles.
7465         * linux-thread-db.c (try_thread_db_load_from_pdir)
7466         (has_libpthread): Use all_objfiles.
7467         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7468         * linespec.c (iterate_over_all_matching_symtabs)
7469         (search_minsyms_for_name): Use all_objfiles.
7470         * maint.c (maintenance_info_sections): Use all_objfiles.
7471         * main.c (captured_main_1): Use all_objfiles.
7472         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7473         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7474         * guile/scm-pretty-print.c
7475         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7476         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7477         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7478         (maintenance_print_msymbols): Use all_objfiles.
7479         * source.c (select_source_symtab): Use all_objfiles.
7480         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7481         * symfile.c (remove_symbol_file_command)
7482         (expand_symtabs_matching, map_symbol_filenames): Use
7483         all_objfiles.
7484         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7485         all_objfiles.
7486         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7487         * objc-lang.c (find_methods): Use all_objfiles.
7488         * objfiles.c (have_partial_symbols, have_full_symbols)
7489         (have_minimal_symbols, qsort_cmp)
7490         (default_iterate_over_objfiles_in_search_order): Use
7491         all_objfiles.
7492         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7493         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7494         (maintenance_check_psymtabs): Use all_objfiles.
7495         (ALL_PSYMTABS): Remove.
7496         * compile/compile-object-run.c (do_module_cleanup): Use
7497         all_objfiles.
7498         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7499         * cp-support.c (add_symbol_overload_list_qualified): Use
7500         all_objfiles.
7501         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7502         Use all_objfiles.
7503         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7504         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7505         all_objfiles.
7506         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7507         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7508         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7509         Uses all_objfiles.
7510         * solib.c (solib_read_symbols): Use all_objfiles
7511
7512 2019-01-09  Tom Tromey  <tom@tromey.com>
7513
7514         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7515         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7516         all_objfiles.
7517         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7518         * symmisc.c (print_symbol_bcache_statistics)
7519         (print_objfile_statistics, maintenance_print_objfiles)
7520         (maintenance_info_symtabs, maintenance_check_symtabs)
7521         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7522         all_objfiles.
7523         * source.c (forget_cached_source_info): Use all_objfiles.
7524         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7525         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7526         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7527         * objfiles.c (update_section_map): Use all_objfiles.
7528         (shared_objfile_contains_address_p): Likewise.
7529         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7530         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7531
7532 2019-01-09  Tom Tromey  <tom@tromey.com>
7533
7534         * common/next-iterator.h: New file.
7535         * objfiles.h (class all_objfiles): New.
7536         (struct objfile_iterator): New.
7537
7538 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7539
7540         * NEWS: Move the description of the changed "frame", "select-frame",
7541          and "info frame" commands to the Changed commands section.
7542
7543 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7544
7545         * gdbtypes.c (check_stub_method_group): Remove handling of old
7546         mangling schemes.
7547         * linespec.c (find_methods): Likewise.
7548         * stabsread.c (read_member_functions): Likewise.
7549         * valops.c (search_struct_method): Likewise.
7550         (value_struct_elt_for_reference): Likewise.
7551         * NEWS: Mention this change.
7552
7553 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7554
7555         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7556         print_source_lines.
7557         * source.c (print_source_lines_base): Update line number check.
7558         (print_source_lines): New function.
7559         (source_lines_range::source_lines_range): New function.
7560         * source.h (class source_lines_range): New class.
7561         (print_source_lines): New declaration.
7562
7563 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7564
7565         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7566
7567 2019-01-08  Tom Tromey  <tom@tromey.com>
7568             Simon Marchi  <simon.marchi@ericsson.com>
7569
7570         PR gdb/24060
7571         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7572         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7573         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7574         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7575         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7576         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7577
7578 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7579
7580         * source.c (select_source_symtab): Move header comment to
7581         declaration in source.h.
7582         (forget_cached_source_info_for_objfile): Likewise.
7583         (forget_cached_source_info): Likewise.
7584         (identify_source_line): Likewise.
7585         * source.h (identify_source_line): Move declaration from symtab.h
7586         and add comment from source.c
7587         (print_source_lines): Likewise.
7588         (forget_cached_source_info_for_objfile): Likewise.
7589         (forget_cached_source_info): Likewise.
7590         (select_source_symtab): Likewise.
7591         (enum print_source_lines_flag): Move definition from symtab.h.
7592         * symtab.h (identify_source_line): Move declaration to source.h.
7593         (print_source_lines): Likewise.
7594         (forget_cached_source_info_for_objfile): Likewise.
7595         (forget_cached_source_info): Likewise.
7596         (select_source_symtab): Likewise.
7597         (enum print_source_lines_flag): Move definition to source.h.
7598         * tui/tui-hooks.c: Add 'source.h' include.
7599
7600 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7601
7602         * source.c (print_source_lines_base): Handle requests to print
7603         reverse line number sequences, and guard against empty lines
7604         string.
7605
7606 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7607
7608         * source.c (print_source_lines_base): Fix skip of '\r' if next
7609         character is '\n'.
7610
7611 2019-01-06  Tom Tromey  <tom@tromey.com>
7612
7613         * c-exp.y (struct c_parse_state) <macro_original_text,
7614         expansion_obstack>: New member.
7615         (macro_original_text, expansion_obstack): Remove globals.
7616         (scan_macro_expansion, scanning_macro_expansion)
7617         (finished_macro_expansion): Update.
7618         (scan_macro_cleanup): Remove.
7619         (yylex, c_parse): Update.
7620
7621 2019-01-06  Tom Tromey  <tom@tromey.com>
7622
7623         * c-exp.y (struct c_parse_state) <strings>: New member.
7624         (operator_stoken): Update.
7625
7626 2019-01-06  Tom Tromey  <tom@tromey.com>
7627
7628         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7629         (union type_stack_elt) <typelist_val>: Now a pointer to
7630         std::vector.
7631         (type_stack_cleanup): Don't declare.
7632         (push_typelist): Update.
7633         * parse.c (pop_typelist): Return a std::vector.
7634         (push_typelist): Take a std::vector.
7635         (follow_types): Update.  Do not free args.
7636         (type_stack_cleanup): Remove.
7637         * c-exp.y (struct c_parse_state): New.
7638         (cpstate): New global.
7639         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7640         (nonempty_typelist): Update.
7641         (func_mod): Create a new vector.
7642         (c_parse): Create a c_parse_state.
7643         (check_parameter_typelist): Do not delete params.
7644         (function_method): Update.  Do not delete type_list.
7645
7646 2019-01-06  Tom Tromey  <tom@tromey.com>
7647
7648         PR gdb/28155:
7649         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7650         check_typedef.
7651         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7652         (print_return_value): Likewise.
7653
7654 2019-01-05  Tom Tromey  <tom@tromey.com>
7655
7656         * contrib/cleanup_check.py: Remove.
7657         * contrib/gcc-with-excheck: Remove.
7658         * contrib/exsummary.py: Remove.
7659         * contrib/excheck.py: Remove.
7660
7661 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7662
7663         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7664         NULL. Initialize tpprev to NULL instead of assigning it
7665         to NULL on the next statement.
7666         * windows-nat.c (windows_delete_thread): Remove check for
7667         main_thread_id before printing thread exit notifications.
7668         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7669         Remove thread ID check against main_thread_id.
7670         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7671         windows_delete_thread.
7672         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7673
7674 2019-01-04  Tom Tromey  <tom@tromey.com>
7675
7676         * compile/compile.c (_initialize_compile): Use upper case for
7677         metasyntactic variables.
7678         * symmisc.c (_initialize_symmisc): Use upper case for
7679         metasyntactic variables.
7680         * psymtab.c (_initialize_psymtab): Use upper case for
7681         metasyntactic variables.
7682         * demangle.c (demangle_command): Use upper case for metasyntactic
7683         variables.
7684         (_initialize_demangler): Likewise.
7685         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7686         variables.
7687
7688 2019-01-03  Tom Tromey  <tom@tromey.com>
7689
7690         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7691
7692 2019-01-03  Tom Tromey  <tom@tromey.com>
7693
7694         * python/py-symtab.c (salpy_str): Update.
7695         (struct salpy_sal_object) <symtab>: Now a PyObject.
7696         (salpy_dealloc): Update.
7697         (del_objfile_sal): Use gdbpy_ref.
7698
7699 2019-01-03  Tom Tromey  <tom@tromey.com>
7700
7701         * python/py-type.c (convert_field): Use new_reference.  Return
7702         gdbpy_ref.
7703         (make_fielditem): Return gdbpy_ref.
7704         (typy_fields): Update.
7705         (typy_getitem): Update.
7706         (field_name): Return gdbpy_ref.  Use new_reference.
7707         (typy_iterator_iternext): Update.
7708
7709 2019-01-03  Tom Tromey  <tom@tromey.com>
7710
7711         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7712
7713 2019-01-03  Tom Tromey  <tom@tromey.com>
7714
7715         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7716         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7717         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7718         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7719         (pspy_set_type_printers): Likewise.
7720         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7721         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7722         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7723         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7724         (objfpy_set_type_printers): Likewise.
7725
7726 2019-01-03  Tom Tromey  <tom@tromey.com>
7727
7728         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7729         (gdbpy_print_stack): Use gdbpy_err_fetch.
7730         * python/python-internal.h (class gdbpy_err_fetch): New class.
7731         (class gdbpy_enter) <m_error_type, m_error_value,
7732         m_error_traceback>: Remove.
7733         <m_error>: New member.
7734         (gdbpy_exception_to_string): Don't declare.
7735         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7736         * python/py-value.c (convert_value_from_python): Use
7737         gdbpy_err_fetch.
7738         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7739         gdbpy_exception_to_string.
7740         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7741         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7742         gdbpy_err_fetch.
7743
7744 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7745
7746         * linux-nat.c (delete_lwp_cleanup): Delete.
7747         (struct lwp_deleter): New struct.
7748         (lwp_info_up): New typedef.
7749         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7750         lwp_info_up.
7751
7752 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7753
7754         * linux-fork.c (class scoped_switch_fork_info): New class.
7755         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7756
7757 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7758
7759         * valops.c (find_overload_match): Remove use of null_cleanup, and
7760         calls to do_cleanups.
7761
7762 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7763
7764         * compile/compile-cplus-types.c
7765         (compile_cplus_instance::decl_name): Handle changes to
7766         cp_func_name.
7767         * cp-support.c (cp_func_name): Update header comment, update
7768         return type.
7769         * cp-support.h (cp_func_name): Update return type in declaration.
7770         * valops.c (find_overload_match): Move temp_func local to top
7771         level of function and change its type.  Use temp_func to hold and
7772         delete temporary string obtained from cp_func_name.
7773
7774 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7775
7776         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7777         gdb::char_vector, remove cleanup, and update uses of `msg`.
7778
7779 2019-01-03  Jim Wilson  <jimw@sifive.com>
7780
7781         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7782
7783 2019-01-02  Tom Tromey  <tom@tromey.com>
7784
7785         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7786         (tdesc_parse_xml): Remove cleanups.
7787         * target-descriptions.h (make_cleanup_free_target_description):
7788         Don't declare.
7789         (target_desc_deleter): New struct.
7790         (target_desc_up): New typedef.
7791         * target-descriptions.c (target_desc_deleter::operator()): Rename
7792         from free_target_description.
7793         (make_cleanup_free_target_description): Remove.
7794
7795 2019-01-02  Tom Tromey  <tom@tromey.com>
7796
7797         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7798         constructor, destructor.
7799         (linespec_parser): Remove typedef.
7800         (~linespec_parser): Rename from linespec_parser_delete.
7801         (linespec_lex_to_end, linespec_complete_label)
7802         (linespec_complete): Update.
7803         (decode_line_full): Remove cleanups.
7804         (decode_line_1): Update.
7805
7806 2019-01-02  Tom Tromey  <tom@tromey.com>
7807
7808         * python/python-internal.h (inferior_to_inferior_object): Change
7809         return type.
7810         * python/py-exitedevent.c (create_exited_event_object): Update.
7811         * python/py-inferior.c (inferior_to_inferior_object): Return
7812         gdbpy_ref.
7813         (python_new_inferior, python_inferior_deleted)
7814         (thread_to_thread_object, delete_thread_object)
7815         (build_inferior_list, gdbpy_selected_inferior): Update.
7816         * python/py-infthread.c (create_thread_object): Update.  Also fail
7817         if inferior_to_inferior_object fails.
7818
7819 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7820
7821         * inferior.h (class inferior) <displaced_step_state>: New field.
7822         * infrun.h (struct displaced_step_state): Move here from
7823         infrun.c.  Initialize fields, add constructor.
7824         <inf>: Remove field.
7825         <reset>: New method.
7826         * infrun.c (struct displaced_step_inferior_state): Move to
7827         infrun.h.
7828         (displaced_step_inferior_states): Remove.
7829         (get_displaced_stepping_state): Adust.
7830         (displaced_step_in_progress_any_inferior): Adjust.
7831         (displaced_step_in_progress_thread): Adjust.
7832         (displaced_step_in_progress): Adjust.
7833         (add_displaced_stepping_state): Remove.
7834         (get_displaced_step_closure_by_addr): Adjust.
7835         (remove_displaced_stepping_state): Remove.
7836         (infrun_inferior_exit): Call displaced_step_state.reset.
7837         (use_displaced_stepping): Don't check for NULL.
7838         (displaced_step_prepare_throw): Call
7839         get_displaced_stepping_state.
7840         (displaced_step_fixup): Don't check for NULL.
7841         (prepare_for_detach): Don't check for NULL.
7842
7843 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7844
7845         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7846          in case of call that did not complete.
7847
7848 2019-01-02  Andrey Utkin  <autkin@undo.io>
7849
7850         * symfile.c (find_separate_debug_file): Fix search of debug files for
7851         remote debuggee.
7852
7853 2019-01-02  Tom Tromey  <tom@tromey.com>
7854
7855         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7856         indentation.
7857         * python/py-frame.c (frapy_older): Remove cast.
7858         (frapy_newer): Likewise.
7859         * python/py-breakpoint.c (local_setattro): Remove cast.
7860         * python/py-arch.c (archpy_name): Remove local variable.
7861         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7862
7863 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7864
7865         * unittests/basic_string_view/element_access/char/empty.cc:
7866         Fix year range in copyright header.
7867
7868 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7869
7870         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7871         Delete.
7872         <operator==>: Update with for removed field.
7873         <hash>: Likewise.
7874         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7875         <isa_features>: ...this.
7876         <abi_features>: New field.
7877         (riscv_isa_flen): Update comment.
7878         (riscv_abi_xlen): New declaration.
7879         (riscv_abi_flen): New declaration.
7880         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7881         isa_features.
7882         (riscv_abi_xlen): New function.
7883         (riscv_isa_flen): Update to get answer from isa_features.
7884         (riscv_abi_flen): New function.
7885         (riscv_has_fp_abi): Update to get answer from abi_features.
7886         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7887         xlen and flen.
7888         (riscv_call_info) <xlen, flen>: Update comment.
7889         (riscv_call_arg_struct): Remove invalid assertions
7890         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7891         is removed.
7892         (riscv_gdbarch_init): Gather isa features and abi features
7893         separately, ensure both match on the gdbarch when reusing an old
7894         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7895         a target with 64-bit float hardware.
7896
7897 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7898
7899         * source.c (search_command_helper): Stop reverse search
7900         when line 1 has been searched.
7901
7902 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7903
7904         * record-full.c (record_full_base_target::close): Rewrite
7905         record_full_core_buf_list free logic.
7906
7907 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7908
7909         * break-catch-syscall.c (print_one_catch_syscall): xfree
7910         the last text.
7911
7912 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7913
7914         * top.c (print_gdb_version): Update Copyright year in version
7915         message.
7916
7917 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7918
7919         Update copyright year range in all GDB files.
7920
7921 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7922
7923         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7924
7925 For older changes see ChangeLog-2018.
7926 \f
7927 Local Variables:
7928 mode: change-log
7929 left-margin: 8
7930 fill-column: 74
7931 version-control: never
7932 coding: utf-8
7933 End:
7934