gdb/ChangeLog

   1 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         PR gdb/25534
   4         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
   5         (riscv_regcache_cooked_write): New function.
   6         (riscv_push_dummy_call): Use new function.
   7         (riscv_return_value): Likewise.
   8
   9 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
  10
  11         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
  12         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
  13         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
  14         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
  15         * infrun.c (follow_fork): Likewise.
  16         (follow_fork_inferior): Likewise.
  17         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
  18         * linux-nat.h (class linux_nat_target): Likewise.
  19         * remote.c (class remote_target) <follow_fork>: Likewise.
  20         (remote_target::follow_fork): Likewise.
  21         * target-delegates.c: Re-generate.
  22         * target.c (default_follow_fork): Likewise.
  23         (target_follow_fork): Likewise.
  24         * target.h (struct target_ops) <follow_fork>: Likewise.
  25         (target_follow_fork): Likewise.
  26
  27 2020-03-24  Tom de Vries  <tdevries@suse.de>
  28
  29         * psymtab.c (maintenance_info_psymtabs): Print user field.
  30
  31 2020-03-20  Tom Tromey  <tromey@adacore.com>
  32
  33         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
  34         const.
  35         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
  36         const.
  37
  38 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
  39
  40         * ptrace.m4: Don't check for ptrace declaration.
  41         * config.in: Re-generate.
  42         * configure: Re-generate.
  43         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
  44         not defined.
  45
  46 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
  47
  48         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
  49         `PTRACE_TYPE_RET'.
  50         * i386-bsd-nat.c (gdb_ptrace): Likewise.
  51         * sparc-nat.c (gdb_ptrace): Likewise.
  52         * x86-bsd-nat.c (gdb_ptrace): Likewise.
  53
  54 2020-03-20  Tom Tromey  <tromey@adacore.com>
  55
  56         * c-exp.y (lex_one_token): Fix assert.
  57
  58 2020-03-20  Tom Tromey  <tromey@adacore.com>
  59
  60         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
  61         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
  62         strncpy call.
  63
  64 2020-03-20  Tom Tromey  <tromey@adacore.com>
  65
  66         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
  67
  68 2020-03-20  Tom Tromey  <tromey@adacore.com>
  69
  70         * ada-valprint.c (print_variant_part): Remove parameters; switch
  71         to value-based API.
  72         (print_field_values): Likewise.
  73         (ada_val_print_struct_union): Likewise.
  74         (ada_value_print_1): Update.
  75
  76 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
  77
  78         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
  79         nbsd_nat_target instead of inf_ptrace_target.
  80         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
  81         nbsd_nat_target.
  82
  83 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
  84
  85         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
  86         it to the ptrace call.
  87         * (store_registers): Likewise.
  88
  89 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
  90
  91         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
  92         it to the ptrace call.
  93         * (store_registers): Likewise.
  94
  95 2020-03-19  Luis Machado  <luis.machado@linaro.org>
  96
  97         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
  98         valid, fetch vg value from ptrace.
  99
 100 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
 101         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
 102         * inf-ptrace.c: Likewise.
 103         * (gdb_ptrace): Add.
 104         * (inf_ptrace_target::resume): Update.
 105         * (inf_ptrace_target::xfer_partial): Likewise.
 106         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
 107         * (inf_ptrace_peek_poke): Update.
 108
 109 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
 110
 111         * x86-bsd-nat.c (gdb_ptrace): New.
 112         * (x86bsd_dr_set): Add new argument `ptid'.
 113         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
 114         x86bsd_dr_set_addr): Update.
 115
 116 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 117
 118         * remote.c (remote_target::process_stop_reply): Handle events for
 119         all threads differently.
 120
 121 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 122
 123         * completer.c (completion_tracker::remove_completion): Define new
 124         function.
 125         * completer.h (completion_tracker::remove_completion): Declare new
 126         function.
 127         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
 128         when adding a C++ function symbol.
 129
 130 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 131
 132         * completer.c (completion_tracker::completion_hash_entry): Define
 133         new class.
 134         (advance_to_filename_complete_word_point): Call
 135         recompute_lowest_common_denominator.
 136         (completion_tracker::completion_tracker): Call discard_completions
 137         to setup the hash table.
 138         (completion_tracker::discard_completions): Allow for being called
 139         from the constructor, pass new equal function, and element deleter
 140         when constructing the hash table.  Initialise new class member
 141         variables.
 142         (completion_tracker::maybe_add_completion): Remove use of
 143         m_entries_vec, and store more information into m_entries_hash.
 144         (completion_tracker::recompute_lcd_visitor): New function, most
 145         content taken from...
 146         (completion_tracker::recompute_lowest_common_denominator):
 147         ...here, this now just visits each item in the hash calling the
 148         above visitor.
 149         (completion_tracker::build_completion_result): Remove use of
 150         m_entries_vec, call recompute_lowest_common_denominator.
 151         * completer.h (completion_tracker::have_completions): Remove use
 152         of m_entries_vec.
 153         (completion_tracker::completion_hash_entry): Declare new class.
 154         (completion_tracker::recompute_lowest_common_denominator): Change
 155         function signature.
 156         (completion_tracker::recompute_lcd_visitor): Declare new function.
 157         (completion_tracker::m_entries_vec): Delete.
 158         (completion_tracker::m_entries_hash): Initialize to NULL.
 159         (completion_tracker::m_lowest_common_denominator_valid): New
 160         member variable.
 161         (completion_tracker::m_lowest_common_denominator_max_length): New
 162         member variable.
 163
 164 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
 165
 166         * regformats/regdef.h: Put reg in gdb namespace.
 167
 168 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
 169
 170         * i386-bsd-nat.c (gdb_ptrace): New.
 171         * (i386bsd_fetch_inferior_registers,
 172         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
 173         * (i386bsd_fetch_inferior_registers,
 174         i386bsd_store_inferior_registers) Use gdb_ptrace.
 175
 176 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
 177
 178         * amd64-bsd-nat.c (gdb_ptrace): New.
 179         * (amd64bsd_fetch_inferior_registers,
 180         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
 181         * (amd64bsd_fetch_inferior_registers,
 182         amd64bsd_store_inferior_registers) Use gdb_ptrace.
 183
 184 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
 185
 186         * user-regs.c (user_reg::read): Rename to...
 187         (user_reg::xread): ...this.
 188         * (append_user_reg): Rename argument `read' to `xread'.
 189         * (user_reg_add_builtin): Likewise.
 190         * (user_reg_add): Likewise.
 191         * (value_of_user_reg): Likewise.
 192
 193 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
 194
 195         * sparc-nat.c (gdb_ptrace): New.
 196         * sparc-nat.c (sparc_fetch_inferior_registers)
 197         (sparc_store_inferior_registers) Remove obsolete comment.
 198         * sparc-nat.c (sparc_fetch_inferior_registers)
 199         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
 200         * sparc-nat.c (sparc_fetch_inferior_registers)
 201         (sparc_store_inferior_registers) Use gdb_ptrace.
 202
 203 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
 204
 205         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
 206         it to the ptrace call.
 207         * sh-nbsd-nat.c (store_registers): Likewise.
 208
 209 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
 210
 211         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
 212         nbsd_nat_target instead of inf_ptrace_target.
 213         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
 214         nbsd_nat_target.
 215
 216 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
 217
 218         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
 219
 220 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
 221
 222         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
 223         <sys/sysctl.h>.
 224         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
 225
 226 2020-03-17  Tom de Vries  <tdevries@suse.de>
 227
 228         PR gdb/23710
 229         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
 230         fields.
 231         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
 232         fields.
 233         (process_imported_unit_die): Skip import of c++ CUs.
 234
 235 2020-03-16  Tom Tromey  <tom@tromey.com>
 236
 237         * p-valprint.c (pascal_object_print_value): Initialize
 238         base_value.
 239
 240 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
 241             Shahab Vahedi  <shahab@synopsys.com>
 242
 243         * Makefile.in: Add arch/arc.o
 244         * configure.tgt: Likewise.
 245         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
 246         (_initialize_arc_tdep): Don't initialize old target descriptions.
 247         (arc_read_description): New function to cache target descriptions.
 248         * arc-tdep.h (arc_read_description): Add proto type.
 249         * arch/arc.c: New file.
 250         * arch/arc.h: Likewise.
 251         * features/Makefile: Replace old target descriptions with new.
 252         * features/arc-arcompact.c: Remove.
 253         * features/arc-arcompact.xml: Likewise.
 254         * features/arc-v2.c: Likewise
 255         * features/arc-v2.xml: Likewise
 256         * features/arc/aux-arcompact.xml: New file.
 257         * features/arc/aux-v2.xml: Likewise.
 258         * features/arc/core-arcompact.xml: Likewise.
 259         * features/arc/core-v2.xml: Likewise.
 260         * features/arc/aux-arcompact.c: Generate.
 261         * features/arc/aux-v2.c: Likewise.
 262         * features/arc/core-arcompact.c: Likewise.
 263         * features/arc/core-v2.c: Likewise.
 264         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
 265
 266 2020-03-16  Tom Tromey  <tromey@adacore.com>
 267
 268         PR gdb/25663:
 269         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
 270         putting value into bcache.
 271
 272 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
 273
 274         PR gdb/21500
 275         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
 276         to...
 277         (amd64_windows_init_abi_common): ... this.  Don't set size of
 278         long type.
 279         (amd64_windows_init_abi): New function.
 280         (amd64_cygwin_init_abi): New function.
 281         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
 282         the Cygwin OS ABI.
 283         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
 284         comment.
 285
 286 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
 287
 288         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
 289         * windows-tdep.c (CYGWIN_DLL_NAME): New.
 290         (pe_import_directory_entry): New struct type.
 291         (is_linked_with_cygwin_dll): New function.
 292         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
 293         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
 294         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
 295
 296 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
 297
 298         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
 299         i386_cygwin_core_osabi_sniffer.
 300
 301 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
 302
 303         * i386-cygwin-tdep.c: Rename to...
 304         * i386-windows-tdep.c: ... this.
 305         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
 306         i386-windows-tdep.c.
 307         * configure.tgt: Likewise.
 308
 309 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
 310
 311         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
 312         * osabi.c (gdb_osabi_names): Add "Windows".
 313         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
 314         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
 315         (i386_cygwin_core_osabi_sniffer): New function, extracted from
 316         i386_cygwin_osabi_sniffer.
 317         (_initialize_i386_cygwin_tdep): Register OS ABI
 318         GDB_OSABI_WINDOWS for i386.
 319         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
 320         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
 321         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
 322         for x86-64.
 323         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
 324         when the target matches '*-*-mingw*'.
 325
 326 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
 327
 328         * defs.h (enum gdb_osabi): Move to...
 329         * osabi.h (enum gdb_osabi): ... here.
 330         * gdbarch.sh: Include osabi.h in gdbarch.h.
 331         * gdbarch.h: Re-generate.
 332
 333 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
 334
 335         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
 336         function.
 337         (_initialize_amd64_windows_tdep): Register osabi sniffer.
 338
 339 2020-03-14  Tom Tromey  <tom@tromey.com>
 340
 341         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
 342         for C++.
 343         (c_type_print_modifier): Likewise.  Add "language" parameter.
 344         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
 345         (c_type_print_base_1): Update.
 346         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
 347         constants.
 348         * type-stack.c (type_stack::insert): Handle tp_atomic and
 349         tp_restrict.
 350         (type_stack::follow_type_instance_flags): Likewise.
 351         (type_stack::follow_types): Likewise.  Merge type-following code.
 352         * c-exp.y (RESTRICT, ATOMIC): New tokens.
 353         (space_identifier, cv_with_space_id)
 354         (const_or_volatile_or_space_identifier_noopt)
 355         (const_or_volatile_or_space_identifier): Remove.
 356         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
 357         rules.
 358         (ptr_operator, typebase): Update.
 359         (enum token_flag) <FLAG_C>: New constant.
 360         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
 361         "_Atomic".
 362         (lex_one_token): Handle FLAG_C.
 363
 364 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 365
 366         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
 367         it to the ptrace call.
 368         * m68k-bsd-nat.c (store_registers): Likewise.
 369
 370 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 371
 372         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
 373         gdb_byte *.
 374         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
 375         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
 376         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
 377
 378 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 379
 380         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
 381         nbsd_nat_target instead of inf_ptrace_target.
 382         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
 383         nbsd_nat_target.
 384
 385 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 386
 387         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
 388         register_t.
 389
 390 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 391
 392         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
 393         it to the ptrace call.
 394         * alpha-bsd-nat.c (store_registers): Likewise.
 395
 396 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 397
 398         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
 399         includes.
 400         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
 401         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
 402         fill_fpregset): Likewise.
 403
 404 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 405
 406         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
 407         nbsd_nat_target instead of inf_ptrace_target.
 408         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
 409         nbsd_nat_target.
 410
 411 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 412
 413         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
 414         register_t.
 415
 416 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 417
 418         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
 419         it to the ptrace call.
 420         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
 421         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
 422         * arm-nbsd-nat.c (store_register): Likewise.
 423         * arm-nbsd-nat.c (store_regs): Likewise.
 424         * arm-nbsd-nat.c (store_fp_register): Likewise.
 425         * arm-nbsd-nat.c (store_fp_regs): Likewise.
 426
 427 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 428
 429         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
 430         nbsd_nat_target instead of inf_ptrace_target.
 431         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
 432         nbsd_nat_target.
 433
 434 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 435
 436         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
 437         it to the ptrace call.
 438         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
 439
 440 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 441
 442         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
 443         it to the ptrace call.
 444         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
 445
 446 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 447
 448         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
 449         gdb_byte *.
 450         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
 451
 452 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 453
 454         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
 455         instead of inf_ptrace_target.
 456         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
 457         nbsd_nat_target.
 458
 459 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 460
 461         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
 462         register_t.
 463
 464 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 465
 466         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
 467         register_t.
 468
 469 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 470
 471         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
 472         register_t.
 473
 474 2020-03-13  Tom Tromey  <tom@tromey.com>
 475
 476         * value.h (val_print): Don't declare.
 477         * valprint.h (val_print_array_elements)
 478         (val_print_scalar_formatted, generic_val_print): Don't declare.
 479         * valprint.c (generic_val_print_array): Take a struct value.
 480         (generic_val_print_ptr, generic_val_print_memberptr)
 481         (generic_val_print_bool, generic_val_print_int)
 482         (generic_val_print_char, generic_val_print_complex)
 483         (generic_val_print): Remove.
 484         (generic_value_print): Update.
 485         (do_val_print): Remove unused parameters.  Don't call
 486         la_val_print.
 487         (val_print): Remove.
 488         (common_val_print): Update.  Don't call value_check_printable.
 489         (val_print_scalar_formatted, val_print_array_elements): Remove.
 490         * rust-lang.c (rust_val_print): Remove.
 491         (rust_language_defn): Update.
 492         * p-valprint.c (pascal_val_print): Remove.
 493         (pascal_value_print_inner): Update.
 494         (pascal_object_print_val_fields, pascal_object_print_val):
 495         Remove.
 496         (pascal_object_print_static_field): Update.
 497         * p-lang.h (pascal_val_print): Don't declare.
 498         * p-lang.c (pascal_language_defn): Update.
 499         * opencl-lang.c (opencl_language_defn): Update.
 500         * objc-lang.c (objc_language_defn): Update.
 501         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
 502         * m2-lang.h (m2_val_print): Don't declare.
 503         * m2-lang.c (m2_language_defn): Update.
 504         * language.h (struct language_defn) <la_val_print>: Remove.
 505         * language.c (unk_lang_value_print_inner): Rename.  Change
 506         argument types.
 507         (unknown_language_defn, auto_language_defn): Update.
 508         * go-valprint.c (go_val_print): Remove.
 509         * go-lang.h (go_val_print): Don't declare.
 510         * go-lang.c (go_language_defn): Update.
 511         * f-valprint.c (f_val_print): Remove.
 512         * f-lang.h (f_value_print): Don't declare.
 513         * f-lang.c (f_language_defn): Update.
 514         * d-valprint.c (d_val_print): Remove.
 515         * d-lang.h (d_value_print): Don't declare.
 516         * d-lang.c (d_language_defn): Update.
 517         * cp-valprint.c (cp_print_value_fields)
 518         (cp_print_value_fields_rtti, cp_print_value): Remove.
 519         (cp_print_static_field): Update.
 520         * c-valprint.c (c_val_print_array, c_val_print_ptr)
 521         (c_val_print_struct, c_val_print_union, c_val_print_int)
 522         (c_val_print_memberptr, c_val_print): Remove.
 523         * c-lang.h (c_val_print_array, cp_print_value_fields)
 524         (cp_print_value_fields_rtti): Don't declare.
 525         * c-lang.c (c_language_defn, cplus_language_defn)
 526         (asm_language_defn, minimal_language_defn): Update.
 527         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
 528         (ada_val_print_enum): Take a struct value.
 529         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
 530         (ada_val_print): Remove.
 531         (ada_value_print_1): Update.
 532         (printable_val_type): Remove.
 533         * ada-lang.h (ada_val_print): Don't declare.
 534         * ada-lang.c (ada_language_defn): Update.
 535
 536 2020-03-13  Tom Tromey  <tom@tromey.com>
 537
 538         * valprint.c (do_val_print): Update.
 539         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
 540         a struct value.
 541         (value_to_value_object_no_release): Declare.
 542         * python/py-value.c (value_to_value_object_no_release): New
 543         function.
 544         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
 545         struct value.
 546         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
 547         function.
 548         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
 549         a struct value.
 550         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
 551         Declare.
 552         (gdbscm_apply_val_pretty_printer): Take a struct value.
 553         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
 554         value.
 555         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
 556         value.
 557         * extension-priv.h (struct extension_language_ops)
 558         <apply_val_pretty_printer>: Take a struct value.
 559         * cp-valprint.c (cp_print_value): Create a struct value.
 560         (cp_print_value): Update.
 561
 562 2020-03-13  Tom Tromey  <tom@tromey.com>
 563
 564         * ada-valprint.c (print_field_values): Call common_val_print.
 565
 566 2020-03-13  Tom Tromey  <tom@tromey.com>
 567
 568         * ada-valprint.c (val_print_packed_array_elements): Remove
 569         bitoffset and val parameters.  Call common_val_print.
 570         (ada_val_print_string): Remove offset, address, and original_value
 571         parameters.
 572         (ada_val_print_array): Update.
 573         (ada_value_print_array): New function.
 574         (ada_value_print_1): Call it.
 575
 576 2020-03-13  Tom Tromey  <tom@tromey.com>
 577
 578         * ada-valprint.c (ada_value_print): Use common_val_print.
 579
 580 2020-03-13  Tom Tromey  <tom@tromey.com>
 581
 582         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
 583
 584 2020-03-13  Tom Tromey  <tom@tromey.com>
 585
 586         * ada-valprint.c (ada_value_print_num): New function.
 587         (ada_value_print_1): Use it.
 588
 589 2020-03-13  Tom Tromey  <tom@tromey.com>
 590
 591         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
 592
 593 2020-03-13  Tom Tromey  <tom@tromey.com>
 594
 595         * ada-valprint.c (ada_value_print_ptr): New function.
 596         (ada_value_print_1): Use it.
 597
 598 2020-03-13  Tom Tromey  <tom@tromey.com>
 599
 600         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
 601         call common_val_print.
 602         (ada_val_print_1): Update.
 603         (ada_value_print_1): New function.
 604         (ada_value_print_inner): Rewrite.
 605
 606 2020-03-13  Tom Tromey  <tom@tromey.com>
 607
 608         * cp-valprint.c (cp_print_value_fields): Update.
 609         (cp_print_value): New function.
 610
 611 2020-03-13  Tom Tromey  <tom@tromey.com>
 612
 613         * m2-valprint.c (m2_value_print_inner): Use
 614         cp_print_value_fields.
 615         * cp-valprint.c (cp_print_value_fields): New function.
 616         * c-valprint.c (c_value_print_struct): New function.
 617         (c_value_print_inner): Use c_value_print_struct.
 618         * c-lang.h (cp_print_value_fields): Declare.
 619
 620 2020-03-13  Tom Tromey  <tom@tromey.com>
 621
 622         * c-valprint.c (c_value_print_array): New function.
 623         (c_value_print_inner): Use it.
 624
 625 2020-03-13  Tom Tromey  <tom@tromey.com>
 626
 627         * c-valprint.c (c_value_print_memberptr): New function.
 628         (c_value_print_inner): Use it.
 629
 630 2020-03-13  Tom Tromey  <tom@tromey.com>
 631
 632         * c-valprint.c (c_value_print_int): New function.
 633         (c_value_print_inner): Use it.
 634
 635 2020-03-13  Tom Tromey  <tom@tromey.com>
 636
 637         * c-valprint.c (c_value_print_ptr): New function.
 638         (c_value_print_inner): Use it.
 639
 640 2020-03-13  Tom Tromey  <tom@tromey.com>
 641
 642         * c-valprint.c (c_value_print_inner): Rewrite.
 643
 644 2020-03-13  Tom Tromey  <tom@tromey.com>
 645
 646         * valprint.c (generic_value_print_complex): New function.
 647         (generic_value_print): Use it.
 648
 649 2020-03-13  Tom Tromey  <tom@tromey.com>
 650
 651         * valprint.c (generic_val_print_float): Don't call
 652         val_print_scalar_formatted.
 653         (generic_val_print, generic_value_print): Update.
 654
 655 2020-03-13  Tom Tromey  <tom@tromey.com>
 656
 657         * valprint.c (generic_value_print_char): New function
 658         (generic_value_print): Use it.
 659
 660 2020-03-13  Tom Tromey  <tom@tromey.com>
 661
 662         * valprint.c (generic_value_print_int): New function.
 663         (generic_value_print): Use it.
 664
 665 2020-03-13  Tom Tromey  <tom@tromey.com>
 666
 667         * valprint.c (generic_value_print_bool): New function.
 668         (generic_value_print): Use it.
 669
 670 2020-03-13  Tom Tromey  <tom@tromey.com>
 671
 672         * valprint.c (generic_val_print_func): Simplify.
 673         (generic_val_print, generic_value_print): Update.
 674
 675 2020-03-13  Tom Tromey  <tom@tromey.com>
 676
 677         * valprint.c (generic_val_print_flags): Remove.
 678         (generic_val_print, generic_value_print): Update.
 679         (val_print_type_code_flags): Add original_value parameter.
 680
 681 2020-03-13  Tom Tromey  <tom@tromey.com>
 682
 683         * valprint.c (generic_val_print): Update.
 684         (generic_value_print): Update.
 685         * valprint.c (generic_val_print_enum): Don't call
 686         val_print_scalar_formatted.
 687
 688 2020-03-13  Tom Tromey  <tom@tromey.com>
 689
 690         * valprint.c (generic_value_print): Call generic_value_print_ptr.
 691         * valprint.c (generic_value_print_ptr): New function.
 692
 693 2020-03-13  Tom Tromey  <tom@tromey.com>
 694
 695         * valprint.c (generic_value_print): Rewrite.
 696
 697 2020-03-13  Tom Tromey  <tom@tromey.com>
 698
 699         * p-valprint.c (pascal_object_print_value_fields)
 700         (pascal_object_print_value): New functions.
 701
 702 2020-03-13  Tom Tromey  <tom@tromey.com>
 703
 704         * p-valprint.c (pascal_value_print_inner): Rewrite.
 705
 706 2020-03-13  Tom Tromey  <tom@tromey.com>
 707
 708         * f-valprint.c (f_value_print_innner): Rewrite.
 709
 710 2020-03-13  Tom Tromey  <tom@tromey.com>
 711
 712         * m2-valprint.c (m2_print_unbounded_array): New overload.
 713         (m2_print_unbounded_array): Update.
 714         (m2_print_array_contents): Take a struct value.
 715         (m2_value_print_inner): Rewrite.
 716
 717 2020-03-13  Tom Tromey  <tom@tromey.com>
 718
 719         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
 720         (d_value_print_inner): New function.
 721         * d-lang.h (d_value_print_inner): Declare.
 722         * d-lang.c (d_language_defn): Use d_value_print_inner.
 723
 724 2020-03-13  Tom Tromey  <tom@tromey.com>
 725
 726         * go-valprint.c (go_value_print_inner): New function.
 727         * go-lang.h (go_value_print_inner): Declare.
 728         * go-lang.c (go_language_defn): Use go_value_print_inner.
 729
 730 2020-03-13  Tom Tromey  <tom@tromey.com>
 731
 732         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
 733         API.
 734         (rust_val_print): Rewrite.
 735         (rust_value_print_inner): New function, from rust_val_print.
 736         (rust_language_defn): Use rust_value_print_inner.
 737
 738 2020-03-13  Tom Tromey  <tom@tromey.com>
 739
 740         * ada-valprint.c (ada_value_print_inner): New function.
 741         * ada-lang.h (ada_value_print_inner): Declare.
 742         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
 743
 744 2020-03-13  Tom Tromey  <tom@tromey.com>
 745
 746         * f-valprint.c (f_value_print_innner): New function.
 747         * f-lang.h (f_value_print_innner): Declare.
 748         * f-lang.c (f_language_defn): Use f_value_print_innner.
 749
 750 2020-03-13  Tom Tromey  <tom@tromey.com>
 751
 752         * p-valprint.c (pascal_value_print_inner): New function.
 753         * p-lang.h (pascal_value_print_inner): Declare.
 754         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
 755
 756 2020-03-13  Tom Tromey  <tom@tromey.com>
 757
 758         * m2-valprint.c (m2_value_print_inner): New function.
 759         * m2-lang.h (m2_value_print_inner): Declare.
 760         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
 761
 762 2020-03-13  Tom Tromey  <tom@tromey.com>
 763
 764         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
 765         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
 766         * c-valprint.c (c_value_print_inner): New function.
 767         * c-lang.h (c_value_print_inner): Declare.
 768         * c-lang.c (c_language_defn, cplus_language_defn)
 769         (asm_language_defn, minimal_language_defn): Use
 770         c_value_print_inner.
 771
 772 2020-03-13  Tom Tromey  <tom@tromey.com>
 773
 774         * p-valprint.c (pascal_object_print_value_fields): Now static.
 775         * p-lang.h (pascal_object_print_value_fields): Don't declare.
 776
 777 2020-03-13  Tom Tromey  <tom@tromey.com>
 778
 779         * c-valprint.c (c_val_print_array): Simplify.
 780
 781 2020-03-13  Tom Tromey  <tom@tromey.com>
 782
 783         * valprint.c (value_print_array_elements): New function.
 784         * valprint.h (value_print_array_elements): Declare.
 785
 786 2020-03-13  Tom Tromey  <tom@tromey.com>
 787
 788         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
 789         * mips-tdep.c (mips_print_register): Use
 790         value_print_scalar_formatted.
 791
 792 2020-03-13  Tom Tromey  <tom@tromey.com>
 793
 794         * valprint.h (value_print_scalar_formatted): Declare.
 795         * valprint.c (value_print_scalar_formatted): New function.
 796
 797 2020-03-13  Tom Tromey  <tom@tromey.com>
 798
 799         * valprint.h (generic_value_print): Declare.
 800         * valprint.c (generic_value_print): New function.
 801
 802 2020-03-13  Tom Tromey  <tom@tromey.com>
 803
 804         * valprint.c (do_val_print): Call la_value_print_inner, if
 805         available.
 806         * rust-lang.c (rust_language_defn): Update.
 807         * p-lang.c (pascal_language_defn): Update.
 808         * opencl-lang.c (opencl_language_defn): Update.
 809         * objc-lang.c (objc_language_defn): Update.
 810         * m2-lang.c (m2_language_defn): Update.
 811         * language.h (struct language_defn) <la_value_print_inner>: New
 812         member.
 813         * language.c (unknown_language_defn, auto_language_defn): Update.
 814         * go-lang.c (go_language_defn): Update.
 815         * f-lang.c (f_language_defn): Update.
 816         * d-lang.c (d_language_defn): Update.
 817         * c-lang.c (c_language_defn, cplus_language_defn)
 818         (asm_language_defn, minimal_language_defn): Update.
 819         * ada-lang.c (ada_language_defn): Update.
 820
 821 2020-03-13  Tom Tromey  <tom@tromey.com>
 822
 823         * c-valprint.c (c_value_print): Use common_val_print.
 824
 825 2020-03-13  Tom Tromey  <tom@tromey.com>
 826
 827         * cp-valprint.c (cp_print_static_field): Use common_val_print.
 828
 829 2020-03-13  Tom Tromey  <tom@tromey.com>
 830
 831         * f-valprint.c (f77_print_array_1, f_val_print): Use
 832         common_val_print.
 833
 834 2020-03-13  Tom Tromey  <tom@tromey.com>
 835
 836         * riscv-tdep.c (riscv_print_one_register_info): Use
 837         common_val_print.
 838
 839 2020-03-13  Tom Tromey  <tom@tromey.com>
 840
 841         * mi/mi-main.c (output_register): Use common_val_print.
 842
 843 2020-03-13  Tom Tromey  <tom@tromey.com>
 844
 845         * infcmd.c (default_print_one_register_info): Use
 846         common_val_print.
 847
 848 2020-03-13  Tom Tromey  <tom@tromey.com>
 849
 850         * valprint.h (common_val_print_checked): Declare.
 851         * valprint.c (common_val_print_checked): New function.
 852         * stack.c (print_frame_arg): Use common_val_print_checked.
 853
 854 2020-03-13  Tom Tromey  <tom@tromey.com>
 855
 856         * valprint.c (do_val_print): New function, from val_print.
 857         (val_print): Use do_val_print.
 858         (common_val_print): Use do_val_print.
 859
 860 2020-03-13  Tom Tromey  <tom@tromey.com>
 861
 862         * valprint.c (value_print): Use scoped_value_mark.
 863
 864 2020-03-13  Tom de Vries  <tdevries@suse.de>
 865
 866         PR symtab/25646
 867         * psymtab.c (partial_symtab::partial_symtab): Don't set
 868         globals_offset and statics_offset.  Push element onto
 869         current_global_psymbols and current_static_psymbols stacks.
 870         (concat): New function.
 871         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
 872         element from current_global_psymbols and current_static_psymbols
 873         stacks.  Concat popped elements to global_psymbols and
 874         static_symbols.
 875         (add_psymbol_to_list): Use current_global_psymbols and
 876         current_static_psymbols stacks.
 877         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
 878         current_static_psymbols fields.
 879
 880 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
 881
 882         * corelow.c (sniff_core_bfd): Remove.
 883         (class core_target) <m_core_vec>: Remove.
 884         (core_target::core_target): Update.
 885         (core_file_fns): Remove.
 886         (deprecated_add_core_fns): Remove.
 887         (default_core_sniffer): Remove.
 888         (sniff_core_bfd): Remove.
 889         (default_check_format): Remove.
 890         (gdb_check_format): Remove.
 891         (core_target_open): Update.
 892         (core_target::get_core_register_section): Update.
 893         (get_core_registers_cb): Update.
 894         (core_target::fetch_registers): Update.
 895         * gdbcore.h (struct core_fns): Remove.
 896         (deprecated_add_core_fns): Remove.
 897         (default_core_sniffer): Remove.
 898         (default_check_format): Remove.
 899
 900 2020-03-12  Tom Tromey  <tom@tromey.com>
 901
 902         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
 903         CORE_ADDR.
 904         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
 905
 906 2020-03-12  Tom Tromey  <tom@tromey.com>
 907
 908         * remote.c (remote_target::download_tracepoint)
 909         (remote_target::enable_tracepoint)
 910         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
 911         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
 912         sprintf_vma.
 913
 914 2020-03-12  Tom Tromey  <tom@tromey.com>
 915
 916         * symfile-mem.c: Update CORE_ADDR size assert.
 917
 918 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
 919
 920         * selftest.m4: Move to gdbsupport/.
 921         * acinclude.m4: Update path to selftest.m4.
 922
 923 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
 924
 925         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
 926         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
 927         gdbarch-selfselftests.c and selftest-arch.c.
 928         (SUBDIR_UNITTESTS_OBS): Rename to...
 929         (SELFTESTS_OBS): ... this.
 930         (COMMON_SFILES): Remove disasm-selftests.c and
 931         gdbarch-selftests.c.
 932         * configure.ac: Don't add selftest-arch.{c,o} to
 933         CONFIG_{SRCS,OBS}.
 934         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
 935         preprocessor conditions.
 936
 937 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
 938
 939         * configure.ac: Don't source bfd/development.sh.
 940         * selftest.m4: Modify comment.
 941         * configure: Re-generate.
 942
 943 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
 944
 945         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
 946         not "true" or "false".
 947         * configure: Re-generate.
 948
 949 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
 950
 951         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
 952         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
 953         renamed to arm_nbsd_supply_gregset.
 954         (fetch_register): Update to call arm_nbsd_supply_gregset.
 955         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
 956         (arm_netbsd_nat_target::fetch_registers): Update.
 957         (fetch_elfcore_registers): Removed.
 958         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
 959         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
 960         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
 961         not require NetBSD system headers.
 962         (arm_nbsd_regset): New struct.
 963         (arm_nbsd_iterate_over_regset_sections): New function.
 964         (arm_netbsd_init_abi_common): Updated to call
 965         set_gdbarch_iterate_over_regset_sections.
 966         * arm-nbsd-tdep.h: New file.
 967
 968 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
 969
 970         * symtab.c (find_pc_sect_line): Add check which prevents infinite
 971         recursion.
 972
 973 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
 974
 975         * configure: Re-generate.
 976
 977 2020-03-11  Tom Tromey  <tromey@adacore.com>
 978
 979         * ada-typeprint.c (print_choices): Fix comment.
 980
 981 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 982
 983         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
 984         previous item in the list, when the list has no items.
 985
 986 2020-03-11  Tom de Vries  <tdevries@suse.de>
 987
 988         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
 989         PROP_LOCLIST handling code.
 990
 991 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 992
 993         * buildsym-legacy.c (record_line): Pass extra parameter to
 994         record_line.
 995         * buildsym.c (buildsym_compunit::record_line): Take an extra
 996         parameter, reduce duplication in the line table, and record the
 997         is_stmt flag in the line table.
 998         * buildsym.h (buildsym_compunit::record_line): Add extra
 999         parameter.
1000         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
1001         non-statement lines.
1002         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
1003         this to the symtab builder.
1004         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
1005         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
1006         through to dwarf_record_line_1.
1007         * infrun.c (process_event_stop_test): When stepping, don't stop at
1008         a non-statement instruction, and only refresh the step info when
1009         we land in the middle of a line's range.  Also add an extra
1010         comment.
1011         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
1012         field.
1013         * record-btrace.c (btrace_find_line_range): Only record lines
1014         marked as is-statement.
1015         * stack.c (frame_show_address): Show the frame address if we are
1016         in a non-statement sal.
1017         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
1018         (maintenance_print_one_line_table): Print a header for the is_stmt
1019         column, and include is_stmt information in the output.
1020         * symtab.c (find_pc_sect_line): Find lines marked as statements in
1021         preference to non-statements.
1022         (find_pcs_for_symtab_line): Prefer is-statement entries.
1023         (find_line_common): Likewise.
1024         * symtab.h (struct linetable_entry): Add is_stmt field.
1025         (struct symtab_and_line): Likewise.
1026         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
1027         arranging the line table.
1028
1029 2020-03-07  Tom de Vries  <tdevries@suse.de>
1030
1031         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
1032         DIE.
1033
1034 2020-03-07  Tom Tromey  <tom@tromey.com>
1035
1036         * valops.c (value_literal_complex): Remove obsolete comment.
1037         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
1038         comment.
1039
1040 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
1041
1042         * infrun.h: Forward-declare thread_info.
1043         (set_step_info): Add thread_info parameter, add doc.
1044         * infrun.c (set_step_info): Add thread_info parameter, move doc
1045         to header.
1046         * infrun.c (process_event_stop_test): Pass thread to
1047         set_step_info call.
1048         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
1049         set_step_info.
1050         (prepare_one_step): Add thread_info parameter, pass it to
1051         set_step_frame and prepare_one_step (recursive) call.
1052         (step_1): Pass thread to prepare_one_step call.
1053         (step_command_fsm::should_stop): Pass thread to
1054         prepare_one_step.
1055         (until_next_fsm): Pass thread to set_step_frame call.
1056         (finish_command): Pass thread to set_step_info call.
1057
1058 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
1059
1060         * windows-tdep.c (windows_solib_create_inferior_hook):
1061         Check if inferior is running.
1062
1063 2020-03-06  Tom de Vries  <tdevries@suse.de>
1064
1065         * NEWS: Fix "the the".
1066         * ctfread.c: Same.
1067
1068 2020-03-06  Tom de Vries  <tdevries@suse.de>
1069
1070         * psymtab.c (psymtab_to_symtab): Don't print "done.".
1071
1072 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1073
1074         * .dir-locals.el: Add a comment referencing the other copies of
1075         this file.
1076
1077 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
1078
1079         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
1080         psargs.
1081
1082 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1083
1084         * .gitattributes: New file.
1085
1086 2020-03-04  Tom Tromey  <tom@tromey.com>
1087
1088         * symmisc.c (print_symbol_bcache_statistics)
1089         (print_objfile_statistics): Update.
1090         * symfile.c (allocate_symtab): Use intern.
1091         * psymtab.c (partial_symtab::partial_symtab): Use intern.
1092         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1093         macro_cache>: Remove.
1094         <string_cache>: New member.
1095         (struct objfile) <intern>: New methods.
1096         * elfread.c (elf_symtab_read): Use intern.
1097         * dwarf2/read.c (fixup_go_packaging): Intern package name.
1098         (dwarf2_compute_name, dwarf2_physname)
1099         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
1100         names.
1101         (guess_partial_die_structure_name): Update.
1102         (partial_die_info::fixup): Intern name.
1103         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
1104         name.
1105         (dwarf2_name): Intern name.  Update.
1106         * buildsym.c (buildsym_compunit::get_macro_table): Use
1107         string_cache.
1108
1109 2020-03-04  Tom Tromey  <tom@tromey.com>
1110
1111         * jit.c (bfd_open_from_target_memory): Make "target" const.
1112         * corefile.c (gnutarget): Now const.
1113         * gdbcore.h (gnutarget): Now const.
1114
1115 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
1116
1117         * NEWS: Mention support for WOW64 processes.
1118         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
1119         (amd64_windows_segment_register_p): Remove static.
1120         (_initialize_amd64_windows_nat): Update.
1121         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
1122         * i386-windows-nat.c (context_offset): Update.
1123         (i386_mappings): Rename and remove static.
1124         (i386_windows_segment_register_p): Remove static.
1125         (_initialize_i386_windows_nat): Update.
1126         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
1127         (STATUS_WX86_SINGLE_STEP): New macro.
1128         (EnumProcessModulesEx): New macro.
1129         (Wow64SuspendThread): New macro.
1130         (Wow64GetThreadContext): New macro.
1131         (Wow64SetThreadContext): New macro.
1132         (Wow64GetThreadSelectorEntry): New macro.
1133         (windows_set_context_register_offsets): Add static.
1134         (windows_set_segment_register_p): Likewise.
1135         (windows_add_thread): Adapt for WOW64 processes.
1136         (windows_fetch_one_register): Likewise.
1137         (windows_nat_target::fetch_registers): Likewise.
1138         (windows_store_one_register): Likewise.
1139         (display_selector): Likewise.
1140         (display_selectors): Likewise.
1141         (handle_exception): Likewise.
1142         (windows_continue): Likewise.
1143         (windows_nat_target::resume): Likewise.
1144         (windows_add_all_dlls): Likewise.
1145         (do_initial_windows_stuff): Likewise.
1146         (windows_nat_target::attach): Likewise.
1147         (windows_get_exec_module_filename): Likewise.
1148         (windows_nat_target::create_inferior): Likewise.
1149         (windows_xfer_siginfo): Likewise.
1150         (_initialize_loadable): Initialize Wow64SuspendThread,
1151         Wow64GetThreadContext, Wow64SetThreadContext,
1152         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
1153         * windows-nat.h (windows_set_context_register_offsets):
1154         Remove declaration.
1155         (windows_set_segment_register_p): Likewise.
1156         (i386_windows_segment_register_p): Add declaration.
1157         (amd64_windows_segment_register_p): Likewise.
1158
1159 2020-03-04  Luis Machado  <luis.machado@linaro.org>
1160
1161         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
1162         in "info registers" for AArch64/ARM.
1163
1164         The change caused "info registers" to not print GPR's.
1165
1166         gdb/ChangeLog:
1167
1168         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
1169
1170         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
1171         when reg->group is empty and reggroup is not.
1172
1173 2020-03-03  Tom Tromey  <tromey@adacore.com>
1174
1175         * dwarf2/frame.c (struct dwarf2_frame_cache)
1176         <checked_tailcall_bottom, entry_cfa_sp_offset,
1177         entry_cfa_sp_offset_p>: Remove members.
1178         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
1179         (dwarf2_frame_prev_register): Don't call
1180         dwarf2_tailcall_sniffer_first.
1181         (dwarf2_append_unwinders): Don't append tailcall unwinder.
1182         * frame-unwind.c (add_unwinder): New fuction.
1183         (frame_unwind_init): Use it.  Add tailcall unwinder.
1184
1185 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1186             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
1187
1188         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
1189         value should be printed as true.
1190
1191 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
1192
1193         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
1194         (windows_init_abi): Set and use windows_so_ops.
1195
1196 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
1197
1198         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
1199         when verifying if dealing with a convenience variable.
1200
1201 2020-03-03  Luis Machado  <luis.machado@linaro.org>
1202
1203         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
1204
1205 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
1206
1207         * infrun.c (gdbarch_supports_displaced_stepping): New.
1208         (use_displaced_stepping): Break up conditions in smaller pieces.
1209         Use gdbarch_supports_displaced_stepping.
1210         (displaced_step_prepare_throw): Use
1211         gdbarch_supports_displaced_stepping.
1212
1213 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1214
1215         * NEWS: Mention new behaviour of the history filename.
1216         * top.c (write_history_p): Add comment.
1217         (show_write_history_p): Add header comment, give a different
1218         message when history writing is on, but the history filename is
1219         empty.
1220         (history_filename): Add comment.
1221         (history_filename_empty): New function.
1222         (show_history_filename): Add header comment, give a different
1223         message when the filename is empty.
1224         (init_history): Compare history_filename against nullptr, and only
1225         read history if the filename is not empty.
1226         (set_history_filename): Add header comment, and only make
1227         non-empty filenames absolute.
1228         (init_main): Make the filename argument to 'set history filename'
1229         optional.
1230
1231 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
1232
1233         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
1234         (arm_supply_vfpregset): ...this, and update to use VFP registers.
1235         (fetch_fp_register): Update.
1236         (fetch_fp_regs): Update.
1237         (store_fp_register): Update.
1238         (store_fp_regs): Update.
1239         (arm_netbsd_nat_target::read_description): New function.
1240         (fetch_elfcore_registers): Update.
1241
1242 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1243
1244         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
1245         general_thread if the stop reply is missing a thread-id.
1246         (remote_target::process_stop_reply): Use the first non-exited
1247         thread if the target didn't pass a thread-id.
1248         * infrun.c (do_target_wait): Move call to
1249         switch_to_inferior_no_thread to ....
1250         (do_target_wait_1): ... here.
1251
1252 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
1253
1254         * debuginfod-support.c: Include defs.h first.
1255
1256 2020-02-28  Tom de Vries  <tdevries@suse.de>
1257
1258         * symfile.c (set_initial_language): Use default language for lookup.
1259
1260 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
1261
1262         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
1263         reader variable, pass `this` to read_cutu_die_from_dwo.
1264
1265 2020-02-27  Aaron Merey  <amerey@redhat.com>
1266
1267         * source.c (open_source_file): Check for nullptr when computing
1268         srcpath.
1269
1270 2020-02-27  Tom Tromey  <tromey@adacore.com>
1271
1272         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
1273         member.
1274         (dwarf2_add_field): Don't update nfields.
1275         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
1276
1277 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1278
1279         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
1280         abs.
1281
1282 2020-02-26  Tom Tromey  <tom@tromey.com>
1283
1284         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
1285         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
1286         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
1287         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
1288         per_cu_data.
1289
1290 2020-02-26  Tom Tromey  <tom@tromey.com>
1291
1292         * dwarf2/index-write.c (psym_index_map): Change type.
1293         (add_address_entry_worker, write_one_signatured_type)
1294         (recursively_count_psymbols, recursively_write_psymbols)
1295         (class debug_names, psyms_seen_size, write_gdbindex)
1296         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
1297
1298 2020-02-26  Aaron Merey  <amerey@redhat.com>
1299
1300         * Makefile.in: Handle optional debuginfod support.
1301         * NEWS: Update.
1302         * README: Add --with-debuginfod summary.
1303         * config.in: Regenerate.
1304         * configure: Regenerate.
1305         * configure.ac: Handle optional debuginfod support.
1306         * debuginfod-support.c: debuginfod helper functions.
1307         * debuginfod-support.h: Ditto.
1308         * doc/gdb.texinfo: Add --with-debuginfod to configure options
1309         summary.
1310         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
1311         when a dwz file cannot be found.
1312         * elfread.c (elf_symfile_read): Query debuginfod servers when a
1313         debuginfo file cannot be found.
1314         * source.c (open_source_file): Query debuginfod servers when a
1315         source file cannot be found.
1316         * top.c (print_gdb_configuration): Include
1317         --{with,without}-debuginfod in the output.
1318
1319 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
1320
1321         * thread.c (thr_try_catch_cmd): Print thread name.
1322
1323 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
1324
1325         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
1326         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
1327         dwarf2_fetch_die_type_sect_off): Move to...
1328         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
1329         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
1330         dwarf2_fetch_die_type_sect_off): ... here.
1331         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
1332         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
1333         dwarf2_fetch_die_type_sect_off): Move doc to header file.
1334
1335 2020-02-26  Tom de Vries  <tdevries@suse.de>
1336
1337         PR gdb/25603
1338         * symfile.c (set_initial_language): Exit-early if
1339         language_mode == language_mode_manual.
1340
1341 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
1342
1343         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
1344         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
1345         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
1346
1347 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1348
1349         * gdbtypes.c (create_array_type_with_stride): Handle negative
1350         array strides.
1351         * valarith.c (value_subscripted_rvalue): Likewise.
1352
1353 2020-02-25  Luis Machado  <luis.machado@linaro.org>
1354
1355         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
1356
1357 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
1358
1359         * loc.h (dwarf2_get_die_type): Move to...
1360         * read.h (dwarf2_get_die_type): ... here.
1361         * read.c (dwarf2_get_die_type): Move doc to header.
1362
1363 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
1364
1365         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
1366         'gnulib/Makefile.in' to the list.
1367
1368 2020-02-24  Tom Tromey  <tom@tromey.com>
1369
1370         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
1371         Remove.
1372         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
1373         XOBNEWVEC.
1374
1375 2020-02-24  Tom Tromey  <tom@tromey.com>
1376
1377         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
1378         New method.
1379         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
1380         (dw2_do_instantiate_symtab, dw2_get_file_names)
1381         (build_type_psymtab_dependencies, load_full_type_unit): Update.
1382
1383 2020-02-24  Tom Tromey  <tom@tromey.com>
1384
1385         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
1386         make_scoped_restore.
1387         (dwarf2_psymtab::read_symtab): Don't clear
1388         reading_partial_symbols.
1389
1390 2020-02-24  Tom de Vries  <tdevries@suse.de>
1391
1392         PR gdb/25592
1393         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
1394
1395 2020-02-24  Tom de Vries  <tdevries@suse.de>
1396
1397         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
1398         commands layout next/prev/regs.
1399
1400 2020-02-22  Tom Tromey  <tom@tromey.com>
1401
1402         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
1403         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
1404
1405 2020-02-22  Tom Tromey  <tom@tromey.com>
1406
1407         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
1408
1409 2020-02-22  Tom Tromey  <tom@tromey.com>
1410
1411         * tui/tui-win.c (_initialize_tui_win): Add usage text.
1412         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
1413         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
1414         * tui/tui.c (_initialize_tui): Add usage text.
1415
1416 2020-02-22  Tom Tromey  <tom@tromey.com>
1417
1418         * tui/tui-win.c (tui_set_focus_command)
1419         (tui_set_win_height_command): Use error_no_arg.
1420         (_initialize_tui_win): Update help text.
1421         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
1422
1423 2020-02-22  Tom Tromey  <tom@tromey.com>
1424
1425         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
1426         * tui/tui-disasm.h (struct tui_disasm_window)
1427         <display_start_addr>: Declare.
1428         * tui/tui-source.h (struct tui_source_window)
1429         <display_start_addr>: Declare.
1430         * tui/tui-winsource.h (struct tui_source_window_base)
1431         <show_source_line, display_start_addr>: New methods.
1432         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
1433         Rename and move to protected section.
1434         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
1435         (tui_source_window_base::do_erase_source_content): Update.
1436         (tui_source_window_base::show_source_line): Now a method.
1437         (tui_source_window_base::show_source_content)
1438         (tui_source_window_base::tui_source_window_base)
1439         (tui_source_window_base::rerender)
1440         (tui_source_window_base::refill)
1441         (tui_source_window_base::do_scroll_horizontal)
1442         (tui_source_window_base::set_is_exec_point_at)
1443         (tui_source_window_base::update_breakpoint_info)
1444         (tui_source_window_base::update_exec_info): Update.
1445         * tui/tui-source.c (tui_source_window::set_contents)
1446         (tui_source_window::showing_source_p)
1447         (tui_source_window::do_scroll_vertical)
1448         (tui_source_window::location_matches_p)
1449         (tui_source_window::line_is_displayed): Update.
1450         (tui_source_window::display_start_addr): New method.
1451         * tui/tui-disasm.c (tui_disasm_window::set_contents)
1452         (tui_disasm_window::do_scroll_vertical)
1453         (tui_disasm_window::location_matches_p): Update.
1454         (tui_disasm_window::display_start_addr): New method.
1455
1456 2020-02-22  Tom Tromey  <tom@tromey.com>
1457
1458         * NEWS: Add entry for gdb.register_window_type.
1459         * tui/tui-layout.h (window_factory): New typedef.
1460         (tui_register_window): Declare.
1461         * tui/tui-layout.c (saved_tui_windows): New global.
1462         (tui_apply_current_layout): Use it.
1463         (tui_register_window): New function.
1464         * python/python.c (do_start_initialization): Call
1465         gdbpy_initialize_tui.
1466         (python_GdbMethods): Add "register_window_type" function.
1467         * python/python-internal.h (gdbpy_register_tui_window)
1468         (gdbpy_initialize_tui): Declare.
1469         * python/py-tui.c: New file.
1470         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
1471
1472 2020-02-22  Tom Tromey  <tom@tromey.com>
1473
1474         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
1475
1476 2020-02-22  Tom Tromey  <tom@tromey.com>
1477
1478         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
1479         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
1480         * tui/tui-data.c (tui_set_win_with_focus): Remove.
1481         (tui_set_win_focus_to): Move from tui-win.c.
1482
1483 2020-02-22  Tom Tromey  <tom@tromey.com>
1484
1485         * tui/tui-layout.c (make_standard_window, get_locator_window): New
1486         functions.
1487         (known_window_types): New global.
1488         (tui_get_window_by_name): Reimplement.
1489         (initialize_known_windows): New function.
1490         (validate_window_name): Rewrite.
1491         (_initialize_tui_layout): Call initialize_known_windows.
1492
1493 2020-02-22  Tom Tromey  <tom@tromey.com>
1494
1495         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
1496         Remove constants.
1497         * tui/tui-winsource.h (struct tui_source_window_base)
1498         <tui_source_window_base>: Remove parameter.
1499         * tui/tui-winsource.c
1500         (tui_source_window_base::tui_source_window_base): Remove
1501         parameter.
1502         (tui_source_window_base::refill): Update.
1503         * tui/tui-stack.h (struct tui_locator_window)
1504         <tui_locator_window>: Update.
1505         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
1506         Default the constructor.
1507         * tui/tui-regs.h (struct tui_data_item_window)
1508         <tui_data_item_window>: Default the constructor.
1509         (struct tui_data_window) <tui_data_window>: Likewise.
1510         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
1511         Default the constructor.
1512         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
1513         Default the constructor.
1514         <type>: Remove.
1515         (struct tui_win_info) <tui_win_info>: Default the constructor.
1516         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
1517         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1518         Default the constructor.
1519
1520 2020-02-22  Tom Tromey  <tom@tromey.com>
1521
1522         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
1523         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
1524         * tui/tui-win.c (tui_resize_all): Don't call
1525         tui_delete_invisible_windows.
1526         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
1527         done.
1528         (tui_set_layout): Update.
1529         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
1530         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
1531         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
1532
1533 2020-02-22  Tom Tromey  <tom@tromey.com>
1534
1535         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
1536         correctly.
1537
1538 2020-02-22  Tom Tromey  <tom@tromey.com>
1539
1540         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
1541
1542 2020-02-22  Tom Tromey  <tom@tromey.com>
1543
1544         * tui/tui-winsource.h (struct tui_source_window_iterator)
1545         <inner_iterator>: New etytypedef.
1546         <tui_source_window_iterator>: Take "end" parameter.
1547         <tui_source_window_iterator>: Take iterator.
1548         <operator*, advance>: Update.
1549         <m_iter>: Change type.
1550         <m_end>: New field.
1551         (struct tui_source_windows) <begin, end>: Update.
1552         * tui/tui-layout.c (tui_windows): New global.
1553         (tui_apply_current_layout): Clear tui_windows.
1554         (tui_layout_window::apply): Update tui_windows.
1555         * tui/tui-data.h (tui_windows): Declare.
1556         (all_tui_windows): Now inline function.
1557         (class tui_window_iterator, struct all_tui_windows): Remove.
1558
1559 2020-02-22  Tom Tromey  <tom@tromey.com>
1560
1561         PR tui/17850:
1562         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
1563         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
1564         "height" argument.
1565         (class tui_layout_window) <get_sizes>: Likewise.
1566         (class tui_layout_split) <tui_layout_split>: Add "vertical"
1567         argument.
1568         <get_sizes>: Add "height" argument.
1569         <m_vertical>: New field.
1570         * tui/tui-layout.c (tui_layout_split::clone): Update.
1571         (tui_layout_split::get_sizes): Add "height" argument.
1572         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
1573         (tui_new_layout_command): Parse "-horizontal".
1574         (_initialize_tui_layout): Update help string.
1575         (tui_layout_split::specification): Add "-horizontal" when needed.
1576         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
1577         argument.
1578         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
1579         New methods.
1580
1581 2020-02-22  Tom Tromey  <tom@tromey.com>
1582
1583         * tui/tui-layout.h (enum tui_adjust_result): New.
1584         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
1585         (class tui_layout_window) <adjust_size>: Return
1586         tui_adjust_result.  Rewrite.
1587         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
1588         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
1589
1590 2020-02-22  Tom Tromey  <tom@tromey.com>
1591
1592         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
1593         parameter and return types.
1594         (class tui_layout_base) <specification>: Add "depth".
1595         (class tui_layout_window) <specification>: Add "depth".
1596         (class tui_layout_split) <specification>: Add "depth".
1597         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
1598         and return types.
1599         (tui_new_layout_command): Parse sub-layouts.
1600         (_initialize_tui_layout): Update help string.
1601         (tui_layout_window::specification): Add "depth".
1602         (add_layout_command): Update.
1603
1604 2020-02-22  Tom Tromey  <tom@tromey.com>
1605
1606         * NEWS: Add "tui new-layout" item.
1607         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
1608         Add new-layout command to help text.
1609         (validate_window_name): New function.
1610         (tui_new_layout_command): New function.
1611         (_initialize_tui_layout): Register "new-layout".
1612         (tui_layout_window::specification): New method.
1613         (tui_layout_window::specification): New method.
1614         * tui/tui-layout.h (class tui_layout_base) <specification>: New
1615         method.
1616         (class tui_layout_window) <specification>: New method.
1617         (class tui_layout_split) <specification>: New method.
1618
1619 2020-02-22  Tom Tromey  <tom@tromey.com>
1620
1621         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
1622         * tui/tui-win.c (window_name_completer): Update comment.
1623         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
1624         Declare method.
1625         (class tui_layout_window) <replace_window>: Likewise.
1626         (class tui_layout_split) <replace_window>: Likewise.
1627         (tui_set_layout): Don't declare.
1628         (tui_set_initial_layout): Declare function.
1629         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
1630         (asm_regs_layout): New globals.
1631         (tui_current_layout, show_layout): Remove.
1632         (tui_set_layout, tui_add_win_to_layout): Rewrite.
1633         (find_layout, tui_apply_layout): New function.
1634         (layout_completer): Remove.
1635         (tui_next_layout): Reimplement.
1636         (tui_next_layout_command): New function.
1637         (tui_set_initial_layout, tui_prev_layout_command): New functions.
1638         (tui_regs_layout): Reimplement.
1639         (tui_regs_layout_command): New function.
1640         (extract_display_start_addr): Rewrite.
1641         (next_layout, prev_layout): Remove.
1642         (tui_layout_window::replace_window): New method.
1643         (tui_layout_split::replace_window): New method.
1644         (destroy_layout): New function.
1645         (layout_list): New global.
1646         (add_layout_command): New function.
1647         (initialize_layouts): Update.
1648         (tui_layout_command): New function.
1649         (_initialize_tui_layout): Install "layout" commands.
1650         * tui/tui-data.h (enum tui_layout_type): Remove.
1651         (tui_current_layout): Don't declare.
1652
1653 2020-02-22  Tom Tromey  <tom@tromey.com>
1654
1655         * tui/tui-regs.c (tui_reg_layout): Remove.
1656         (tui_reg_command): Use tui_regs_layout.
1657         * tui/tui-layout.h (tui_reg_command): Declare.
1658         * tui/tui-layout.c (tui_reg_command): New function.
1659
1660 2020-02-22  Tom Tromey  <tom@tromey.com>
1661
1662         * tui/tui.c (tui_rl_delete_other_windows): Call
1663         tui_remove_some_windows.
1664         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
1665         Declare method.
1666         (class tui_layout_window) <remove_windows>: New method.
1667         (class tui_layout_split) <remove_windows>: Declare.
1668         (tui_remove_some_windows): Declare.
1669         * tui/tui-layout.c (tui_remove_some_windows): New function.
1670         (tui_layout_split::remove_windows): New method.
1671
1672 2020-02-22  Tom Tromey  <tom@tromey.com>
1673
1674         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
1675         * tui/tui-layout.h (tui_next_layout): Declare.
1676         * tui/tui-layout.c (tui_next_layout): New function.
1677
1678 2020-02-22  Tom Tromey  <tom@tromey.com>
1679
1680         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
1681         correct coordinates.
1682
1683 2020-02-22  Tom Tromey  <tom@tromey.com>
1684
1685         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
1686         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
1687         DATA_WIN case.
1688
1689 2020-02-22  Tom Tromey  <tom@tromey.com>
1690
1691         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
1692         TUI_DISASM_WIN, not tui_win_list.
1693
1694 2020-02-22  Tom Tromey  <tom@tromey.com>
1695
1696         * valprint.c (generic_val_print_enum_1)
1697         (val_print_type_code_flags): Style member names.
1698         * rust-lang.c (val_print_struct, rust_print_enum)
1699         (rust_print_struct_def, rust_internal_print_type): Style member
1700         names.
1701         * p-valprint.c (pascal_object_print_value_fields): Style member
1702         names.  Only call fprintf_symbol_filtered for static members.
1703         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
1704         * f-valprint.c (f_val_print): Style member names.
1705         * f-typeprint.c (f_type_print_base): Style member names.
1706         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
1707         call fprintf_symbol_filtered for static members.
1708         (cp_print_class_member): Style member names.
1709         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
1710         member names.
1711         * ada-valprint.c (ada_print_scalar): Style enum names.
1712         (ada_val_print_enum): Likewise.
1713         * ada-typeprint.c (print_enum_type): Style enum names.
1714
1715 2020-02-21  Tom Tromey  <tom@tromey.com>
1716
1717         * psympriv.h (struct partial_symtab): Update comment.
1718
1719 2020-02-21  Tom Tromey  <tromey@adacore.com>
1720
1721         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
1722         type is CORE_ADDR.
1723
1724 2020-02-21  Tom de Vries  <tdevries@suse.de>
1725
1726         PR gdb/25534
1727         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
1728         if dependencies[i]->user != NULL.
1729
1730 2020-02-21  Ali Tamur  <tamur@google.com>
1731
1732         * dwarf2/read.c (dwarf2_name): Add null check.
1733
1734 2020-02-20  Tom Tromey  <tom@tromey.com>
1735
1736         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
1737         ">=", in binary search.
1738         (dwarf2_find_containing_comp_unit): New overload.
1739         (run_test): New self-test.
1740         (_initialize_dwarf2_read): Register new test.
1741
1742 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
1743
1744         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
1745         * riscv-tdep.h: Likewise.
1746         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
1747         rv32-only CSR.
1748         * features/riscv/64bit-csr.xml: Regenerated.
1749
1750 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
1751             Tom Tromey  <tom@tromey.com>
1752
1753         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
1754         of 'fputc_unfiltered'.
1755         (putchar_unfiltered): Call 'fputc_unfiltered'.
1756         (fputc_unfiltered): Call 'fputs_unfiltered'.
1757
1758 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
1759
1760         * config.in: Regenerate.
1761         * configure: Regenerate.
1762         * configure.ac: Add --with-python-libdir option.
1763         * main.c: Use WITH_PYTHON_LIBDIR.
1764
1765 2020-02-19  Tom Tromey  <tom@tromey.com>
1766
1767         * symtab.c (general_symbol_info::compute_and_set_names): Use
1768         obstack_strndup.  Simplify call to symbol_set_demangled_name.
1769
1770 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
1771
1772         * dwarf2/read.c (allocate_signatured_type_table,
1773         allocate_dwo_unit_table, allocate_type_unit_groups_table,
1774         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
1775         Remove objfile parameter, update all callers.
1776
1777 2020-02-19  Doug Evans  <dje@google.com>
1778
1779         PR rust/25535
1780         * rust-lang.c (rust_print_enum): Apply embedded_offset to
1781         rust_enum_variant calculation.
1782
1783 2020-02-19  Tom Tromey  <tromey@adacore.com>
1784
1785         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
1786
1787 2020-02-19  Tom Tromey  <tromey@adacore.com>
1788
1789         * ada-lang.c (cache_symbol): Use obstack_strdup.
1790
1791 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1792
1793         * configure: Regenerate.
1794
1795 2020-02-19  Tom Tromey  <tromey@adacore.com>
1796
1797         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
1798         NULL check.
1799
1800 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
1801
1802         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
1803
1804 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1805
1806         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
1807         if GDBSERVER is not defined.
1808         (riscv_tdesc_cache): Likewise, also store const target_desc.
1809         (STATIC_IN_GDB): Define.
1810         (riscv_create_target_description): Update declaration with
1811         STATIC_IN_GDB.
1812         (riscv_lookup_target_description): New function, only define if
1813         GDBSERVER is not defined.
1814         * arch/riscv.h (riscv_create_target_description): Declare only
1815         when GDBSERVER is defined.
1816         (riscv_lookup_target_description): New declaration when GDBSERVER
1817         is not defined.
1818         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
1819         (riscv_linux_read_features): ...this, and return
1820         riscv_gdbarch_features instead of target_desc.
1821         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
1822         (riscv_linux_read_description): Rename to...
1823         (riscv_linux_read_features): ...this.
1824         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
1825         Update to use riscv_gdbarch_features and
1826         riscv_lookup_target_description.
1827         * riscv-tdep.c (riscv_find_default_target_description): Use
1828         riscv_lookup_target_description instead of
1829         riscv_create_target_description.
1830
1831 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
1832
1833         * valprint.c (generic_val_print_enum_1): When printing a flag
1834         enum with value 0 and there is no enumerator with value 0, print
1835         just "0" instead of "(unknown: 0x0)".
1836
1837 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
1838
1839         * valprint.c (generic_val_print_enum_1): Print unknown part of
1840         flag enum in hex.
1841
1842 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
1843
1844         * dwarf2/read.c (update_enumeration_type_from_children): Allow
1845         flag enums to contain duplicate enumerators.
1846         * valprint.c (generic_val_print_enum_1): Update comment.
1847
1848 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
1849
1850         * dwarf2/read.c: Include "count-one-bits.h".
1851         (update_enumeration_type_from_children): If an enumerator has
1852         multiple bits set, don't treat the enumeration as a "flag enum".
1853         * valprint.c (generic_val_print_enum_1): Assert that enumerators
1854         of flag enums have 0 or 1 bit set.
1855
1856 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1857
1858         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
1859         conversion.
1860         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
1861         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
1862         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
1863         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
1864         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
1865
1866 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
1867
1868         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
1869
1870 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
1871
1872         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
1873         displaced_step_closure_up.
1874         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
1875         (struct displaced_step_closure_up):
1876         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
1877         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
1878         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
1879         Likewise.
1880         * gdbarch.sh (displaced_step_copy_insn): Likewise.
1881         * gdbarch.c, gdbarch.h: Re-generate.
1882         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
1883         displaced_step_closure_up.
1884         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
1885         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
1886         * infrun.h (displaced_step_closure_up): New type alias.
1887         (struct displaced_step_inferior_state) <step_closure>: Change
1888         type to displaced_step_closure_up.
1889         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
1890         displaced_step_closure_up.
1891         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
1892
1893 2020-02-14  Tom Tromey  <tom@tromey.com>
1894
1895         * minidebug.c (gnu_debug_key): New global.
1896         (find_separate_debug_file_in_section): Use it.
1897
1898 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
1899
1900         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
1901         std::unique_ptr.
1902         * gdbarch.c: Re-generate.
1903         * gdbarch.h: Re-generate.
1904         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
1905         change.
1906         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
1907         type to std::unique_ptr.
1908         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
1909         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
1910         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
1911         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
1912         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
1913         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
1914         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
1915         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
1916         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
1917
1918 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
1919
1920         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
1921         std::unique_ptr.
1922         (displaced_step_clear): Rename to...
1923         (displaced_step_reset): ... this.  Just call displaced->reset ().
1924         (displaced_step_clear_cleanup): Rename to...
1925         (displaced_step_reset_cleanup): ... this.
1926         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
1927         (displaced_step_fixup): Likewise.
1928         (resume_1): Likewise.
1929         (handle_inferior_event): Restore child's memory before calling
1930         displaced_step_fixup on the parent.
1931         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
1932         to std::unique_ptr.
1933         <step_closure>: Change type to std::unique_ptr.
1934
1935 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
1936
1937         * arm-tdep.c: Include count-one-bits.h.
1938         (cleanup_block_store_pc): Use count_one_bits.
1939         (cleanup_block_load_pc): Use count_one_bits.
1940         (arm_copy_block_xfer): Use count_one_bits.
1941         (thumb2_copy_block_xfer): Use count_one_bits.
1942         (thumb_copy_pop_pc_16bit): Use count_one_bits.
1943         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
1944         (thumb_get_next_pcs_raw): Use count_one_bits.
1945         (arm_get_next_pcs_raw): Use count_one_bits_l.
1946         * arch/arm.c (bitcount): Remove.
1947         * arch/arm.h (bitcount): Remove.
1948
1949 2020-02-14  Tom Tromey  <tromey@adacore.com>
1950
1951         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
1952         Update.
1953         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
1954         * dwarf2/loc.c (call_site_find_chain_1): Return
1955         unique_xmalloc_ptr.
1956         (call_site_find_chain): Likewise.
1957
1958 2020-02-14  Richard Biener  <rguenther@suse.de>
1959
1960         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
1961         on expression with division operators.
1962
1963 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
1964
1965         * MAINTAINERS (Write After Approval): Adding myself.
1966
1967 2020-02-12  Tom Tromey  <tom@tromey.com>
1968
1969         * event-loop.c (event_data, gdb_event, event_handler_func):
1970         Remove.
1971
1972 2020-02-12  Tom Tromey  <tom@tromey.com>
1973
1974         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
1975         (dwarf2_frame_objfile_data): Add comment.
1976         (find_comp_unit, set_comp_unit): New functions.
1977         (dwarf2_frame_find_fde): Use find_comp_unit.
1978         (dwarf2_build_frame_info): Use set_comp_unit.
1979
1980 2020-02-12  Tom Tromey  <tom@tromey.com>
1981
1982         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
1983         (comp_unit): Don't initialize objfile.
1984         (execute_cfa_program): Add text_offset parameter.
1985         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
1986         (dwarf2_frame_cache): Update.
1987         (dwarf2_build_frame_info): Don't set "objfile" member.
1988
1989 2020-02-12  Tom Tromey  <tom@tromey.com>
1990
1991         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
1992         (decode_frame_entry): Likewise.
1993         (dwarf2_build_frame_info): Update.
1994
1995 2020-02-12  Tom Tromey  <tom@tromey.com>
1996
1997         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
1998         (decode_frame_entry_1): Use the comp_unit obstack.
1999
2000 2020-02-12  Tom Tromey  <tom@tromey.com>
2001
2002         * dwarf2/frame.c (struct comp_unit): Add initializers and
2003         constructor.
2004         (dwarf2_frame_objfile_data): Store a comp_unit.
2005         (dwarf2_frame_find_fde): Update.
2006         (dwarf2_build_frame_info): Use "new".
2007
2008 2020-02-12  Tom Tromey  <tom@tromey.com>
2009
2010         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
2011         (dwarf2_fde_table): Typedef for std::vector.
2012         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
2013         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
2014         (decode_frame_entry): Update.
2015         (dwarf2_build_frame_info): Use "new".
2016
2017 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
2018
2019         * arm-tdep.c (arm_gdbarch_init): Update.
2020         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
2021         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
2022         have_neon, is_m>: Change to bool.
2023
2024 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
2025
2026         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
2027
2028 2020-02-12  Tom Tromey  <tom@tromey.com>
2029
2030         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
2031
2032 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
2033
2034         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
2035         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
2036
2037 2020-02-11  Tom Tromey  <tom@tromey.com>
2038
2039         * psymtab.h: Update comment.
2040
2041 2020-02-11  Tom Tromey  <tom@tromey.com>
2042
2043         * gdb_obstack.h (struct auto_obstack): Use
2044         DISABLE_COPY_AND_ASSIGN.
2045
2046 2020-02-11  Tom Tromey  <tom@tromey.com>
2047
2048         * dwarf2/frame.h (struct objfile): Don't forward declare.
2049
2050 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
2051
2052         * cris-tdep.c (cris_supply_gregset): Change signature to match
2053         what struct regset expects.
2054         (cris_regset): New struct.
2055         (fetch_core_registers): Remove.
2056         (cris_iterate_over_regset_sections): New function.
2057         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
2058         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
2059
2060 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
2061
2062         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
2063         registers.
2064
2065 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
2066
2067         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
2068
2069 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
2070
2071         * configure: Re-generate.
2072
2073 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
2074
2075         * configure: Re-generate.
2076
2077 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
2078
2079         * acinclude: Update warning.m4 path.
2080         * warning.m4: Move to gdbsupport.
2081
2082 2020-02-11  Tom Tromey  <tromey@adacore.com>
2083
2084         * remote.c (remote_console_output): Update.
2085         * printcmd.c (printf_command): Update.
2086         * event-loop.c (gdb_wait_for_event): Update.
2087         * linux-nat.c (sigchld_handler): Update.
2088         * remote-sim.c (gdb_os_write_stdout): Update.
2089         (gdb_os_flush_stdout): Update.
2090         (gdb_os_flush_stderr): Update.
2091         (gdb_os_write_stderr): Update.
2092         * exceptions.c (print_exception): Update.
2093         * remote-fileio.c (remote_fileio_func_read): Update.
2094         (remote_fileio_func_write): Update.
2095         * tui/tui.c (tui_enable): Update.
2096         * tui/tui-interp.c (tui_interp::init): Update.
2097         * utils.c (init_page_info): Update.
2098         (putchar_unfiltered, fputc_unfiltered): Update.
2099         (gdb_flush): Update.
2100         (emit_style_escape): Update.
2101         (flush_wrap_buffer, fputs_maybe_filtered): Update.
2102         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
2103         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
2104         (stderr_file::write): Update.
2105         (stderr_file::puts): Update.
2106         * ui-file.h (ui_file_isatty, ui_file_write)
2107         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
2108         (ui_file_puts): Don't declare.
2109
2110 2020-02-10  Tom de Vries  <tdevries@suse.de>
2111
2112         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
2113         sentinel to char *.
2114
2115 2020-02-09  Tom de Vries  <tdevries@suse.de>
2116
2117         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
2118         filename if it matches "<artificial>".
2119
2120 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
2121
2122         * windows-tdep.c (struct enum_value_name): New struct.
2123         (create_enum): New function.
2124         (windows_get_siginfo_type): Create and use enum types.
2125
2126 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
2127
2128         * NEWS: Mention $_siginfo support for Windows.
2129         * windows-nat.c (handle_exception): Set siginfo_er.
2130         (windows_nat_target::mourn_inferior): Reset siginfo_er.
2131         (windows_xfer_siginfo): New function.
2132         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
2133         * windows-tdep.c (struct windows_gdbarch_data): New struct.
2134         (init_windows_gdbarch_data): New function.
2135         (get_windows_gdbarch_data): New function.
2136         (windows_get_siginfo_type): New function.
2137         (windows_init_abi): Register windows_get_siginfo_type.
2138         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
2139
2140 2020-02-08  Tom Tromey  <tom@tromey.com>
2141
2142         * dwarf2/read.c (class cutu_reader) <cutu_reader,
2143         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
2144         <keep>: Declare method.
2145         <m_keep>: Remove member.
2146         <~cutu_reader>: Remove.
2147         (cutu_reader::init_tu_and_read_dwo_dies): Update.
2148         (cutu_reader::cutu_reader): Update.
2149         (cutu_reader::keep): Rename from ~cutu_reader.
2150         (process_psymtab_comp_unit, build_type_psymtabs_1)
2151         (process_skeletonless_type_unit, load_partial_comp_unit)
2152         (load_full_comp_unit, dwarf2_read_addr_index)
2153         (read_signatured_type): Update.
2154
2155 2020-02-08  Tom Tromey  <tom@tromey.com>
2156
2157         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
2158         "want_partial_unit" parameter.
2159         (process_psymtab_comp_unit): Change want_partial_unit to bool.
2160         Inline check for DW_TAG_partial_unit.
2161         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
2162
2163 2020-02-08  Tom Tromey  <tom@tromey.com>
2164
2165         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
2166         read.c.
2167         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
2168         read.c.
2169
2170 2020-02-08  Tom Tromey  <tom@tromey.com>
2171
2172         * dwarf2/read.c (read_address): Move to comp-unit.c.
2173         (dwarf2_rnglists_process, dwarf2_ranges_process)
2174         (read_attribute_value, dwarf_decode_lines_1)
2175         (var_decode_location, decode_locdesc): Update.
2176         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
2177         read.c.  Remove "cu" parameter.
2178         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
2179         method.
2180
2181 2020-02-08  Tom Tromey  <tom@tromey.com>
2182
2183         * dwarf2/read.c (read_attribute_value, read_indirect_string)
2184         (read_indirect_line_string): Update.
2185         * dwarf2/comp-unit.c (read_offset): Remove.
2186         (read_comp_unit_head): Update.
2187         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
2188         method.
2189         (read_offset): Don't declare.
2190
2191 2020-02-08  Tom Tromey  <tom@tromey.com>
2192
2193         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
2194         * dwarf2/read.c (struct comp_unit_head): Move to
2195         dwarf2/comp-unit.h.
2196         (enum class rcuh_kind): Move to comp-unit.h.
2197         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
2198         (read_comp_unit_head, error_check_comp_unit_head)
2199         (read_and_check_comp_unit_head): Move to comp-unit.c.
2200         (read_offset, dwarf_unit_type_name): Likewise.
2201         (create_debug_type_hash_table, read_cutu_die_from_dwo)
2202         (cutu_reader::cutu_reader, read_call_site_scope)
2203         (find_partial_die, follow_die_offset): Update.
2204         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
2205
2206 2020-02-08  Tom Tromey  <tom@tromey.com>
2207
2208         * dwarf2/read.c (read_offset_1): Move to leb.c.
2209         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
2210         (dwarf_decode_macro_bytes): Update.
2211         * dwarf2/leb.c (read_offset): Rename; move from read.c.
2212         * dwarf2/leb.h (read_offset): Declare.
2213
2214 2020-02-08  Tom Tromey  <tom@tromey.com>
2215
2216         * dwarf2/read.c (dwarf2_section_size): Remove.
2217         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
2218         Update.
2219         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
2220
2221 2020-02-08  Tom Tromey  <tom@tromey.com>
2222
2223         * dwarf2/read.c (read_initial_length): Move to leb.c.
2224         * dwarf2/leb.h (read_initial_length): Declare.
2225         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
2226         handle_nonstd parameter.
2227         * dwarf2/frame.c (read_initial_length): Remove.
2228         (decode_frame_entry_1): Update.
2229
2230 2020-02-08  Tom Tromey  <tom@tromey.com>
2231
2232         * dwarf2/loc.c (dwarf2_find_location_expression)
2233         (dwarf_evaluate_loc_desc::get_tls_address)
2234         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
2235         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
2236         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
2237         (dwarf2_compile_property_to_c)
2238         (dwarf2_loc_desc_get_symbol_read_needs)
2239         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
2240         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
2241         (loclist_describe_location, loclist_tracepoint_var_ref)
2242         (loclist_generate_c_location): Update.
2243         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
2244         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
2245         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
2246         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
2247         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
2248         (dwarf2_per_cu_data::addr_size)
2249         (dwarf2_per_cu_data::ref_addr_size)
2250         (dwarf2_per_cu_data::text_offset)
2251         (dwarf2_per_cu_data::addr_type): Now methods.
2252         (per_cu_header_read_in): Make per_cu "const".
2253         (dwarf2_version): Remove.
2254         (dwarf2_per_cu_data::int_type): Now a method.
2255         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
2256         (set_die_type, read_array_type, read_subrange_index_type)
2257         (read_tag_string_type, read_subrange_type): Update.
2258         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
2259         offset_size, ref_addr_size, text_offset, addr_type, version,
2260         objfile, int_type, addr_sized_int_type>: Declare methods.
2261
2262 2020-02-08  Tom Tromey  <tom@tromey.com>
2263
2264         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
2265         Move earlier.
2266
2267 2020-02-08  Tom Tromey  <tom@tromey.com>
2268
2269         * dwarf2/read.h (dwarf_line_debug): Declare.
2270         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
2271         * dwarf2/read.c: Move line_header code to new files.
2272         (dwarf_line_debug): No longer static.
2273         * dwarf2/line-header.c: New file.
2274         * dwarf2/line-header.h: New file.
2275
2276 2020-02-08  Tom Tromey  <tom@tromey.com>
2277
2278         * dwarf2/read.c (struct line_header) <file_full_name,
2279         file_file_name>: Return unique_xmalloc_ptr.
2280         (line_header::file_file_name): Update.
2281         (line_header::file_full_name): Update.
2282         (dw2_get_file_names_reader): Update.
2283         (macro_start_file): Update.
2284
2285 2020-02-08  Tom Tromey  <tom@tromey.com>
2286
2287         * dwarf2/read.c (struct line_header) <file_full_name,
2288         file_file_name>: Declare methods.
2289         (dw2_get_file_names_reader): Update.
2290         (file_file_name): Now a method.
2291         (file_full_name): Likewise.
2292         (macro_start_file): Update.
2293
2294 2020-02-08  Tom Tromey  <tom@tromey.com>
2295
2296         * dwarf2/read.c (dwarf_always_disassemble)
2297         (show_dwarf_always_disassemble): Move to loc.c.
2298         (_initialize_dwarf2_read): Move "always-disassemble" registration
2299         to loc.c.
2300         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
2301         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
2302         static.
2303         (show_dwarf_always_disassemble): Move from read.c.
2304         (_initialize_dwarf2loc): Move always-disassemble from read.c.
2305
2306 2020-02-08  Tom Tromey  <tom@tromey.com>
2307
2308         * dwarf2/read.c (~dwarf2_per_objfile): Update.
2309         (create_quick_file_names_table): Return htab_up.
2310         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
2311         Update.
2312         * dwarf2/read.h (struct dwarf2_per_objfile)
2313         <quick_file_names_table>: Now htab_up.
2314
2315 2020-02-08  Tom Tromey  <tom@tromey.com>
2316
2317         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
2318
2319 2020-02-08  Tom Tromey  <tom@tromey.com>
2320
2321         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
2322         Rewrite.
2323         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
2324         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
2325         (abbrev_table::abbrev_table): No longer inline.
2326         (ABBREV_HASH_SIZE): Remove.
2327         (abbrev_table::m_abbrevs): Now an htab_up.
2328
2329 2020-02-08  Tom Tromey  <tom@tromey.com>
2330
2331         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
2332         (cutu_reader): Update.
2333         (build_type_psymtabs_1): Update.
2334         * dwarf2/abbrev.c (abbrev_table::read): Rename.
2335         (abbrev_table::alloc_abbrev): Update.
2336         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
2337         (abbrev_table::read): New static method, renamed from
2338         abbrev_table_read_table.
2339         (abbrev_table::alloc_abbrev)
2340         (abbrev_table::add_abbrev): Now private.
2341         (abbrev_table::abbrev_table): Now private.
2342         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
2343
2344 2020-02-08  Tom Tromey  <tom@tromey.com>
2345
2346         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
2347         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
2348         htab_up.
2349
2350 2020-02-08  Tom Tromey  <tom@tromey.com>
2351
2352         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
2353         htab_up.
2354         (lookup_dwo_unit_in_dwp): Update.
2355         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
2356         on obstack.
2357
2358 2020-02-08  Tom Tromey  <tom@tromey.com>
2359
2360         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
2361         obstack.
2362
2363 2020-02-08  Tom Tromey  <tom@tromey.com>
2364
2365         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
2366         line_header_hash.
2367         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
2368         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
2369         Change type to htab_up.
2370
2371 2020-02-08  Tom Tromey  <tom@tromey.com>
2372
2373         * dwarf2/read.c (allocate_type_unit_groups_table): Return
2374         htab_up.  Don't allocate on obstack.
2375         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
2376         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
2377         Change type to htab_up.
2378
2379 2020-02-08  Tom Tromey  <tom@tromey.com>
2380
2381         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
2382         Change type to htab_up.
2383         * dwarf2/read.c (create_signatured_type_table_from_index)
2384         (create_signatured_type_table_from_debug_names)
2385         (create_all_type_units, add_type_unit)
2386         (lookup_dwo_signatured_type, lookup_signatured_type)
2387         (process_skeletonless_type_unit): Update.
2388         (create_debug_type_hash_table, create_debug_types_hash_table):
2389         Change type of types_htab.
2390         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
2391         htab_up.  Don't allocate on obstack.
2392         (create_cus_hash_table): Change type of cus_htab parameter.
2393         (struct dwo_file) <cus, tus>: Now htab_up.
2394         (lookup_dwo_signatured_type, lookup_dwo_cutu)
2395         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
2396         (queue_and_load_all_dwo_tus): Update.
2397         * dwarf2/index-write.c (write_gdbindex): Update.
2398         (write_debug_names): Update.
2399
2400 2020-02-08  Tom Tromey  <tom@tromey.com>
2401
2402         * dwarf2/read.h (struct dwarf2_queue_item): Move from
2403         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
2404         destructor.
2405         (struct dwarf2_per_objfile) <queue>: New member.
2406         * dwarf2/read.c (struct dwarf2_queue_item): Move to
2407         dwarf2/read.h.
2408         (dwarf2_queue, dwarf2_queue_tail): Remove.
2409         (class dwarf2_queue_guard): Add parameter to constructor.  Use
2410         DISABLE_COPY_AND_ASSIGN.
2411         <m_per_objfile>: New member.
2412         <~dwarf2_queue_guard>: Rewrite.
2413         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
2414         Update.
2415         (~dwarf2_queue_item): New.
2416
2417 2020-02-08  Tom Tromey  <tom@tromey.com>
2418
2419         * dwarf2/read.c (struct die_info) <has_children>: New member.
2420         (dw2_get_file_names_reader): Remove has_children.
2421         (dw2_get_file_names): Update.
2422         (read_cutu_die_from_dwo): Remove has_children.
2423         (cutu_reader::init_tu_and_read_dwo_dies)
2424         (cutu_reader::cutu_reader): Update.
2425         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
2426         Remove has_children.
2427         (build_type_psymtabs_1, process_skeletonless_type_unit)
2428         (load_partial_comp_unit, load_full_comp_unit): Update.
2429         (create_dwo_cu_reader): Remove has_children.
2430         (create_cus_hash_table, read_die_and_children): Update.
2431         (read_full_die_1,read_full_die): Remove has_children.
2432         (read_signatured_type): Update.
2433         (class cutu_reader) <has_children>: Remove.
2434
2435 2020-02-08  Tom Tromey  <tom@tromey.com>
2436
2437         * dwarf2/expr.c: Rename from dwarf2expr.c.
2438         * dwarf2/expr.h: Rename from dwarf2expr.h.
2439         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
2440         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
2441         * dwarf2/frame.c: Rename from dwarf2-frame.c.
2442         * dwarf2/frame.h: Rename from dwarf2-frame.h.
2443         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
2444         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
2445         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
2446         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
2447         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
2448         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
2449         * dwarf2/loc.c: Rename from dwarf2loc.c.
2450         * dwarf2/loc.h: Rename from dwarf2loc.h.
2451         * dwarf2/read.c: Rename from dwarf2read.c.
2452         * dwarf2/read.h: Rename from dwarf2read.h.
2453         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
2454         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
2455         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
2456         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
2457         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
2458         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
2459         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
2460         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
2461         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
2462         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
2463         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
2464         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
2465         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
2466         Update.
2467         * Makefile.in (COMMON_SFILES): Update.
2468         (HFILES_NO_SRCDIR): Update.
2469
2470 2020-02-08  Tom Tromey  <tom@tromey.com>
2471
2472         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
2473         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
2474
2475 2020-02-08  Tom Tromey  <tom@tromey.com>
2476
2477         * dwarf2read.h (struct die_info): Don't declare.
2478
2479 2020-02-08  Tom Tromey  <tom@tromey.com>
2480
2481         * dwarf2read.h (die_info_ptr): Remove typedef.
2482
2483 2020-02-08  Tom Tromey  <tom@tromey.com>
2484
2485         * dwarf2read.c (read_call_site_scope)
2486         (handle_data_member_location, dwarf2_add_member_fn)
2487         (mark_common_block_symbol_computed, read_common_block)
2488         (attr_to_dynamic_prop, partial_die_info::read)
2489         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
2490         (dwarf2_symbol_mark_computed, set_die_type): Update.
2491         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
2492         method.
2493         (attr_form_is_block): Don't declare.
2494         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
2495
2496 2020-02-08  Tom Tromey  <tom@tromey.com>
2497
2498         * dwarf2read.c (dwarf2_find_base_address, )
2499         (read_call_site_scope, rust_containing_type)
2500         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
2501         (handle_data_member_location, dwarf2_add_member_fn)
2502         (get_alignment, read_structure_type, process_structure_scope)
2503         (mark_common_block_symbol_computed, read_common_block)
2504         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
2505         (partial_die_info::read, read_attribute_value, new_symbol)
2506         (lookup_die_type, dwarf2_get_ref_die_offset)
2507         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
2508         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
2509         (dwarf2_symbol_mark_computed): Update.
2510         * dwarf2/attribute.h (struct attribute) <value_as_address,
2511         form_is_section_offset, form_is_constant, form_is_ref>: Declare
2512         methods.
2513         (value_as_address, attr_form_is_section_offset)
2514         (attr_form_is_constant, attr_form_is_ref): Don't declare.
2515         * dwarf2/attribute.c (attribute::value_as_address)
2516         (attribute::form_is_section_offset, attribute::form_is_constant)
2517         (attribute::form_is_ref): Now methods.
2518
2519 2020-02-08  Tom Tromey  <tom@tromey.com>
2520
2521         * dwarf2read.c (struct attribute, DW_STRING)
2522         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
2523         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
2524         (attr_form_is_block, attr_form_is_section_offset)
2525         (attr_form_is_constant, attr_form_is_ref): Move.
2526         * dwarf2/attribute.h: New file.
2527         * dwarf2/attribute.c: New file, from dwarf2read.c.
2528         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
2529
2530 2020-02-08  Tom Tromey  <tom@tromey.com>
2531
2532         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
2533         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
2534         Move.
2535         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
2536         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
2537         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
2538         abbrev.c.
2539         * dwarf2/abbrev.h: New file.
2540         * dwarf2/abbrev.c: New file, from dwarf2read.c.
2541         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
2542
2543 2020-02-08  Tom Tromey  <tom@tromey.com>
2544
2545         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
2546         (dwarf2_section_size, dwarf2_get_section_info)
2547         (create_signatured_type_table_from_debug_names)
2548         (create_addrmap_from_aranges, read_debug_names_from_section)
2549         (get_gdb_index_contents_from_section, read_comp_unit_head)
2550         (error_check_comp_unit_head, read_abbrev_offset)
2551         (create_debug_type_hash_table, init_cu_die_reader)
2552         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
2553         (read_comp_units_from_section, create_cus_hash_table)
2554         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
2555         (create_dwp_v2_section, dwarf2_rnglists_process)
2556         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
2557         (abbrev_table_read_table, read_indirect_string_at_offset_from)
2558         (read_indirect_string_from_dwz, read_addr_index_1)
2559         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
2560         (dwarf_decode_macro_bytes, dwarf_decode_macros)
2561         (fill_in_loclist_baton): Update.
2562         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
2563         get_containing_section, get_bfd_owner, get_bfd_section,
2564         get_file_name, get_id, get_flags, empty, read>: Declare methods.
2565         (dwarf2_read_section, get_section_name, get_section_file_name)
2566         (get_containing_section, get_section_bfd_owner)
2567         (get_section_bfd_section, get_section_name, get_section_file_name)
2568         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
2569         declare.
2570         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
2571         (dwarf2_section_info::get_bfd_owner)
2572         (dwarf2_section_info::get_bfd_section)
2573         (dwarf2_section_info::get_name)
2574         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
2575         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
2576         (dwarf2_section_info::read): Now methods.
2577         * dwarf-index-write.c (class debug_names): Update.
2578
2579 2020-02-08  Tom Tromey  <tom@tromey.com>
2580
2581         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
2582         Move to dwarf2/section.h.
2583         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
2584         (get_section_bfd_section, get_section_name)
2585         (get_section_file_name, get_section_id, get_section_flags)
2586         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
2587         dwarf2/section.c.
2588         * dwarf2/section.h: New file.
2589         * dwarf2/section.c: New file, from dwarf2read.c.
2590         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
2591
2592 2020-02-08  Tom Tromey  <tom@tromey.com>
2593
2594         * dwarf2read.h (read_unsigned_leb128): Don't declare.
2595         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
2596         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
2597         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
2598         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
2599         * dwarf2/leb.h: New file, from dwarf2read.c.
2600         * dwarf2/leb.c: New file, from dwarf2read.c.
2601         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
2602         Remove.
2603         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
2604         (COMMON_SFILES): Add dwarf2/leb.c.
2605
2606 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
2607
2608         GDB 9.1 released.
2609
2610 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
2611
2612         PR gdb/25190:
2613         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
2614         * gdb/remote.c (remote_console_output): Update.
2615         * gdb/ui-file.c (fputs_unfiltered): Rename to...
2616         (ui_file_puts): ...this.
2617         * gdb/ui-file.h (ui_file_puts): Add declaration.
2618         * gdb/utils.c (emit_style_escape): Update.
2619         (flush_wrap_buffer): Update.
2620         (fputs_maybe_filtered): Update.
2621         (fputs_unfiltered): Add function.
2622
2623 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
2624
2625         * gdb/event-loop.c (gdb_wait_for_event): Update.
2626         * gdb/printcmd.c (printf_command): Update.
2627         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
2628         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
2629         (gdb_os_flush_stderr): Update.
2630         * gdb/remote.c (remote_console_output): Update.
2631         * gdb/ui-file.c (gdb_flush): Rename to...
2632         (ui_file_flush): ...this.
2633         (stderr_file::write): Update.
2634         (stderr_file::puts): Update.
2635         * gdb/ui-file.h (gdb_flush): Rename to...
2636         (ui_file_flush): ...this.
2637         * gdb/utils.c (gdb_flush): Add function.
2638         * gdb/utils.h (gdb_flush): Add declaration.
2639
2640 2020-02-07  Tom Tromey  <tromey@adacore.com>
2641
2642         PR breakpoints/24915:
2643         * source.c (find_and_open_source): Do not check basenames_may_differ.
2644
2645 2020-02-07  Tom Tromey  <tom@tromey.com>
2646
2647         * README: Update gdbserver documentation.
2648         * gdbserver: Move to top level.
2649         * configure.tgt (build_gdbserver): Remove.
2650         * configure.ac: Remove --enable-gdbserver.
2651         * configure: Rebuild.
2652         * Makefile.in (distclean): Don't mention gdbserver.
2653
2654 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
2655
2656         * source-cache.c (source_cache::ensure): Surround
2657         get_plain_source_lines with a try/catch.
2658         (source_cache::get_line_charpos): Get rid of try/catch
2659         and only check for the return value of "ensure".
2660         * tui/tui-source.c (tui_source_window::set_contents):
2661         Simplify "nlines" calculation.
2662
2663 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
2664
2665         * MAINTAINERS (Write After Approval): Add myself.
2666
2667 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
2668
2669         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
2670         function call.
2671
2672 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
2673
2674         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
2675
2676 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
2677
2678         * nat/riscv-linux-tdesc.h: New file.
2679         * nat/riscv-linux-tdesc.c: New file, taking code from...
2680         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
2681         ... here.
2682         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
2683         NATDEPFILES.
2684
2685 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
2686
2687         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
2688         we don't set the fake simulator ptid to the null_ptid.
2689
2690 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
2691
2692         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
2693         * gdbthread.h (class thread_info) <resumed>: Likewise.
2694         * infrun.c (resume_1): Likewise.
2695         (proceed): Likewise.
2696         (infrun_thread_stop_requested): Likewise.
2697         (stop_all_threads): Likewise.
2698         (handle_inferior_event): Likewise.
2699         (restart_threads): Likewise.
2700         (finish_step_over): Likewise.
2701         (keep_going_stepped_thread): Likewise.
2702         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
2703         (linux_handle_extended_wait): Likewise.
2704         * record-btrace.c (get_thread_current_frame_id): Likewise.
2705         * record-full.c (record_full_wait_1): Likewise.
2706         * remote.c (remote_target::process_initial_stop_replies): Likewise.
2707         * target.c (target_resume): Likewise.
2708         * thread.c (set_running_thread): Likewise.
2709
2710 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
2711
2712         * f-valprint.c (f77_print_array_1): Changed datatype of index
2713         variable to LONGEST from int to enable it to contain bound
2714         values correctly.
2715
2716 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
2717
2718         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
2719         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
2720         offsets according to FLEN determined.
2721         (riscv_linux_nat_target::read_description): Determine FLEN
2722         dynamically.
2723         (riscv_linux_nat_target::fetch_registers): Size regset buffer
2724         according to FLEN determined.
2725         (riscv_linux_nat_target::store_registers): Likewise.
2726
2727 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
2728
2729         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
2730         when reg->group is empty and reggroup is not.
2731
2732 2020-01-31  Tom Tromey  <tromey@adacore.com>
2733
2734         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
2735         Call beneath target's mourn_inferior after unpushing.
2736
2737 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2738
2739         PR tui/9765
2740         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
2741         have enough lines to fill the screen, still return the lowest
2742         address we found.
2743
2744 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2745
2746         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
2747         '-', '<', and '>' commands.
2748
2749 2020-01-29  Pedro Alves  <palves@redhat.com>
2750             Sergio Durigan Junior  <sergiodj@redhat.com>
2751
2752         * infcmd.c (construct_inferior_arguments): Assert that
2753         'argc' is greater than 0.
2754
2755 2020-01-29  Luis Machado  <luis.machado@linaro.org>
2756
2757         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
2758         (BRK_INSN_MASK): Define to 0xd4200000.
2759         (aarch64_program_breakpoint_here_p): New function.
2760         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
2761         * arch-utils.c (default_program_breakpoint_here_p): Moved from
2762         breakpoint.c.
2763         * arch-utils.h (default_program_breakpoint_here_p): Moved from
2764         breakpoint.h
2765         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
2766         call gdbarch_program_breakpoint_here_p.
2767         (program_breakpoint_here): Moved to arch-utils.c, renamed to
2768         default_program_breakpoint_here_p, changed return type to bool and
2769         simplified.
2770         * breakpoint.h (program_breakpoint_here): Moved prototype to
2771         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
2772         return type to bool.
2773         * gdbarch.c: Regenerate.
2774         * gdbarch.h: Regenerate.
2775         * gdbarch.sh (program_breakpoint_here_p): New method.
2776         * infrun.c (handle_signal_stop): Call
2777         gdbarch_program_breakpoint_here_p.
2778
2779 2020-01-26  Tom Tromey  <tom@tromey.com>
2780
2781         * ctfread.c (struct ctf_fp_info): Reindent.
2782         (_initialize_ctfread): Remove.
2783
2784 2020-01-26  Tom Tromey  <tom@tromey.com>
2785
2786         * psymtab.c (partial_map_expand_apply)
2787         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
2788         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
2789         (psym_print_stats, psym_expand_symtabs_for_function)
2790         (psym_map_symbol_filenames, psym_map_matching_symbols)
2791         (psym_expand_symtabs_matching)
2792         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
2793         (maintenance_check_psymtabs): Use new methods.
2794         * psympriv.h (struct partial_symtab) <readin_p,
2795         get_compunit_symtab>: New methods.
2796         <readin, compunit_symtab>: Remove members.
2797         (struct standard_psymtab): New.
2798         (struct legacy_psymtab): Derive from standard_psymtab.
2799         * dwarf2read.h (struct dwarf2_psymtab): Derive from
2800         standard_psymtab.
2801         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
2802
2803 2020-01-26  Tom Tromey  <tom@tromey.com>
2804
2805         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
2806         read_dependencies.  Add assert.
2807         * psymtab.c (partial_symtab::read_dependencies): New method.
2808         * psympriv.h (struct partial_symtab) <read_dependencies>: New
2809         method.
2810         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
2811         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
2812         read_dependencies.
2813         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
2814         Add assert.
2815
2816 2020-01-26  Tom Tromey  <tom@tromey.com>
2817
2818         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
2819         Call expand_psymtab.
2820         (xcoff_read_symtab): Call expand_psymtab.
2821         (xcoff_start_psymtab, xcoff_end_psymtab): Set
2822         legacy_expand_psymtab.
2823         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
2824         method.
2825         (struct legacy_psymtab) <expand_psymtab>: Implement.
2826         <legacy_expand_psymtab>: New member.
2827         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
2828         (parse_partial_symbols): Set legacy_expand_psymtab.
2829         (psymtab_to_symtab_1): Change argument order.  Call
2830         expand_psymtab.
2831         (new_psymtab): Set legacy_expand_psymtab.
2832         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
2833         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
2834         expand_psymtab.
2835         (dwarf2_psymtab::expand_psymtab): Rename from
2836         psymtab_to_symtab_1.  Call expand_psymtab.
2837         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
2838         (dbx_end_psymtab): Likewise.
2839         (dbx_psymtab_to_symtab_1): Change argument order. Call
2840         expand_psymtab.
2841         (dbx_read_symtab): Call expand_psymtab.
2842         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
2843         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
2844         (ctf_psymtab::read_symtab): Call expand_psymtab.
2845
2846 2020-01-26  Tom Tromey  <tom@tromey.com>
2847
2848         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
2849         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
2850         messages.
2851         * mdebugread.c (mdebug_read_symtab): Remove prints.
2852         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
2853         assert.
2854         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
2855
2856 2020-01-26  Tom Tromey  <tom@tromey.com>
2857
2858         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
2859         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
2860         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
2861         legacy_symtab.
2862         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
2863         * psymtab.c (psymtab_to_symtab): Call method.
2864         (dump_psymtab): Update.
2865         * psympriv.h (struct partial_symtab): Add virtual destructor.
2866         <read_symtab>: New method.
2867         (struct legacy_symtab): New.
2868         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
2869         (struct pst_map) <pst>: Now a legacy_psymtab.
2870         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
2871         (new_psymtab): Use legacy_psymtab.
2872         * dwarf2read.h (struct dwarf2_psymtab): New.
2873         (struct dwarf2_per_cu_data) <psymtab>: Use it.
2874         * dwarf2read.c (dwarf2_create_include_psymtab)
2875         (dwarf2_build_include_psymtabs, create_type_unit_group)
2876         (create_partial_symtab, process_psymtab_comp_unit_reader)
2877         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
2878         (set_partial_user): Use dwarf2_psymtab.
2879         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
2880         (psymtab_to_symtab_1, process_full_comp_unit)
2881         (process_full_type_unit, dwarf2_ranges_read)
2882         (dwarf2_get_pc_bounds, psymtab_include_file_name)
2883         (dwarf_decode_lines): Use dwarf2_psymtab.
2884         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
2885         (add_address_entry_worker, write_one_signatured_type)
2886         (recursively_count_psymbols, recursively_write_psymbols)
2887         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
2888         (write_debug_names): Likewise.
2889         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
2890         <pst>: Now a legacy_psymtab.
2891         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
2892         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
2893         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
2894         * ctfread.c (struct ctf_psymtab): New.
2895         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
2896         ctf_psymtab.
2897         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
2898         (create_partial_symtab): Return a ctf_psymtab.
2899         (scan_partial_symbols): Update.
2900
2901 2020-01-26  Tom Tromey  <tom@tromey.com>
2902
2903         * xcoffread.c (xcoff_start_psymtab): Use new.
2904         * psymtab.c (partial_symtab::partial_symtab): New constructor,
2905         renamed from start_psymtab_common.
2906         * psympriv.h (struct partial_symtab): Add new constructor.
2907         (start_psymtab_common): Don't declare.
2908         * mdebugread.c (parse_partial_symbols): Use new.
2909         * dwarf2read.c (create_partial_symtab): Use new.
2910         * dbxread.c (start_psymtab): Use new.
2911         * ctfread.c (create_partial_symtab): Use new.
2912
2913 2020-01-26  Tom Tromey  <tom@tromey.com>
2914
2915         * xcoffread.c (xcoff_end_psymtab): Use new.
2916         * psymtab.c (start_psymtab_common): Use new.
2917         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
2918         Update.
2919         * psympriv.h (struct partial_symtab): Add parameters to
2920         constructor.  Don't inline.
2921         (allocate_psymtab): Don't declare.
2922         * mdebugread.c (new_psymtab): Use new.
2923         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
2924         * dbxread.c (dbx_end_psymtab): Use new.
2925
2926 2020-01-26  Tom Tromey  <tom@tromey.com>
2927
2928         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
2929         allocate_psymtab.  Update documentation.
2930         * psymtab.c (psymtab_storage::install_psymtab): Rename from
2931         allocate_psymtab.  Do not use new.
2932         (allocate_psymtab): Use new.  Update.
2933
2934 2020-01-26  Tom Tromey  <tom@tromey.com>
2935
2936         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
2937         * psymtab.c (psym_print_stats): Update.
2938         * psympriv.h (struct partial_symtab) <readin,
2939         psymtabs_addrmap_supported, anonymous>: Now bool.
2940         * mdebugread.c (psymtab_to_symtab_1): Update.
2941         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
2942         (build_type_psymtabs_reader, psymtab_to_symtab_1)
2943         (process_full_comp_unit, process_full_type_unit): Update.
2944         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
2945         * ctfread.c (psymtab_to_symtab): Update.
2946
2947 2020-01-26  Tom Tromey  <tom@tromey.com>
2948
2949         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
2950         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
2951         * psymtab.c (psymtab_storage): Delete psymtabs.
2952         (psymtab_storage::allocate_psymtab): Use new.
2953         (psymtab_storage::discard_psymtab): Use delete.
2954         * psympriv.h (struct partial_symtab): Add constructor and
2955         initializers.
2956
2957 2020-01-26  Tom Tromey  <tom@tromey.com>
2958
2959         * machoread.c: Do not include psympriv.h.
2960
2961 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2962
2963         * NEWS: Mention the new option and the set/show commands.
2964
2965 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2966
2967         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
2968         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
2969         (validate_exec_file): New variables, enums, functions.
2970         (exec_file_locate_attach, print_section_info): Style the filenames.
2971         (_initialize_exec): Install show_exec_file_mismatch_command and
2972          set_exec_file_mismatch_command.
2973         * gdbcore.h (validate_exec_file): Declare.
2974         * infcmd.c (attach_command): Call validate_exec_file.
2975         * remote.c ( remote_target::remote_add_inferior): Likewise.
2976
2977 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2978
2979         * frame.c (find_frame_sal): Move call to get_next_frame into more
2980         inner scope.
2981         * inline-frame.c (inilne_state) <inline_state>: Update argument
2982         types.
2983         (inilne_state) <skipped_symbol>: Rename to...
2984         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
2985         (skip_inline_frames): Build vector of skipped symbols and use this
2986         to reate the inline_state.
2987         (inline_skipped_symbol): Add a comment and some assertions, fetch
2988         skipped symbol from the list.
2989
2990 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2991
2992         * buildsym.c (lte_is_less_than): Delete.
2993         (buildsym_compunit::end_symtab_with_blockvector): Create local
2994         lambda function to sort line table entries, and use
2995         std::stable_sort instead of std::sort.
2996         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
2997         markers when looking for a previous line.
2998
2999 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3000
3001         * dwarf2read.c (lnp_state_machine::record_line): Include
3002         end_sequence parameter in debug print out.  Record the line if we
3003         are at an end_sequence marker even if it's not the start of a
3004         statement.
3005         * symmisc.c (maintenance_print_one_line_table): Print end of
3006         sequence markers with 'END' not '0'.
3007
3008 2020-01-24  Pedro Alves  <palves@redhat.com>
3009
3010         PR gdb/25410
3011         * thread.c (scoped_restore_current_thread::restore): Use
3012         switch_to_inferior_no_thread.
3013         * exec.c: Include "progspace-and-thread.h".
3014         (add_target_sections, remove_target_sections):
3015         scoped_restore_current_pspace_and_thread instead of
3016         scoped_restore_current_thread.
3017         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
3018         and aspace to the inferior before calling clone_program_space.
3019         Remove stale comment.
3020
3021 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
3022
3023         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
3024         (arm_netbsd_nat_target::fetch_registers): ...this.
3025         (arm_nbsd_nat_target::store_registers): Rename to...
3026         (arm_netbsd_nat_target::store_registers): ...this.
3027
3028 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
3029
3030         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
3031         register_t.
3032
3033 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
3034
3035         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
3036         Update comment.
3037         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
3038         Likewise.
3039         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
3040         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
3041         the correct replacement (iterate_over_regset_sections).
3042         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
3043         Update comment.
3044
3045 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
3046
3047         PR gdb/23718
3048         * gdb/python/python.c (execute_gdb_command): Call
3049         async_enable_stdin in catch block.
3050
3051 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3052
3053         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
3054         SWITCH_THRU_ALL_UIS.
3055
3056 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3057
3058         PR tui/9765
3059         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
3060         comment, add extra parameter, and update to store previous symbol
3061         when appropriate.
3062         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
3063         add extra parameter.
3064         * tui/tui-disasm.c (tui_disassemble): Update header comment,
3065         remove unneeded parameter, add try/catch around gdb_print_insn,
3066         rewrite to add items to asm_lines vector.
3067         (tui_find_backward_disassembly_start_address): New function.
3068         (tui_find_disassembly_address): Updated throughout.
3069         (tui_disasm_window::set_contents): Update for changes to
3070         tui_disassemble.
3071         (tui_disasm_window::do_scroll_vertical): No need to adjust the
3072         number of lines to scroll.
3073
3074 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
3075
3076         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
3077         (SECT_OFF_DATA): Likewise.
3078         (SECT_OFF_RODATA): Likewise.
3079         (SECT_OFF_TEXT): Likewise.
3080         (SECT_OFF_BSS): Likewise.
3081         (struct objfile) <text_section_offset, data_section_offset>: New
3082         methods.
3083         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
3084         objfile::text_section_offset.
3085         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
3086         * coffread.c (coff_symtab_read): Likewise.
3087         (enter_linenos): Likewise.
3088         (process_coff_symbol): Likewise.
3089         * ctfread.c (get_objfile_text_range): Likewise.
3090         * dtrace-probe.c (dtrace_probe::get_relocated_address):
3091         Use objfile::data_section_offset.
3092         * dwarf2-frame.c (execute_cfa_program): Use
3093         objfile::text_section_offset.
3094         (dwarf2_frame_find_fde): Likewise.
3095         * dwarf2read.c (create_addrmap_from_index): Likewise.
3096         (create_addrmap_from_aranges): Likewise.
3097         (dw2_find_pc_sect_compunit_symtab): Likewise.
3098         (process_psymtab_comp_unit_reader): Likewise.
3099         (add_partial_symbol): Likewise.
3100         (add_partial_subprogram): Likewise.
3101         (process_full_comp_unit): Likewise.
3102         (read_file_scope): Likewise.
3103         (read_func_scope): Likewise.
3104         (read_lexical_block_scope): Likewise.
3105         (read_call_site_scope): Likewise.
3106         (dwarf2_rnglists_process): Likewise.
3107         (dwarf2_ranges_process): Likewise.
3108         (dwarf2_ranges_read): Likewise.
3109         (dwarf_decode_lines_1): Likewise.
3110         (new_symbol): Likewise.
3111         (dwarf2_fetch_die_loc_sect_off): Likewise.
3112         (dwarf2_per_cu_text_offset): Likewise.
3113         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
3114         * hppa-tdep.c (read_unwind_info): Likewise.
3115         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
3116         * psympriv.h (struct partial_symtab): Likewise.
3117         * psymtab.c (find_pc_sect_psymtab): Likewise.
3118         * solib-svr4.c (enable_break): Likewise.
3119         * stap-probe.c (relocate_address): Use
3120         objfile::data_section_offset.
3121         * xcoffread.c (enter_line_range): Use
3122         objfile::text_section_offset.
3123         (read_xcoff_symtab): Likewise.
3124
3125 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
3126
3127         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
3128         declaration to narrower scopes.
3129
3130 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
3131
3132         * darwin-nat.h (struct darwin_exception_msg, enum
3133         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
3134         Move up.
3135         (class darwin_nat_target) <wait_1, check_new_threads,
3136         decode_exception_message, decode_message, stop_inferior,
3137         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
3138         * darwin-nat.c (darwin_check_new_threads): Rename to...
3139         (darwin_nat_target::check_new_threads): ... this.
3140         (darwin_suspend_inferior_it): Remove.
3141         (darwin_decode_exception_message): Rename to...
3142         (darwin_nat_target::decode_exception_message): ... this.
3143         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
3144         (darwin_decode_message): Rename to...
3145         (darwin_nat_target::decode_message): ... this.
3146         (cancel_breakpoint): Rename to...
3147         (darwin_nat_target::cancel_breakpoint): ... this.
3148         (darwin_wait): Rename to...
3149         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
3150         instead of iterate_over_inferiors.
3151         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
3152         (darwin_stop_inferior): Rename to...
3153         (darwin_nat_target::stop_inferior): ... this.
3154         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
3155         (darwin_init_thread_list): Rename to...
3156         (darwin_nat_target::init_thread_list): ... this.
3157         (darwin_ptrace_him): Rename to...
3158         (darwin_nat_target::ptrace_him): ... this.
3159         (darwin_nat_target::create_inferior): Pass lambda function to
3160         fork_inferior.
3161         (darwin_nat_target::detach): Call stop_inferior instead of
3162         darwin_stop_inferior.
3163         * fork-inferior.h (fork_inferior): Change init_trace_fun
3164         parameter to gdb::function_view.
3165         * fork-inferior.c (fork_inferior): Likewise.
3166
3167 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
3168
3169         * i386-cygwin-tdep.c (core_process_module_section): Update.
3170         * windows-nat.c (struct lm_info_windows): Add text_offset.
3171         (windows_xfer_shared_libraries): Update.
3172         * windows-tdep.c (windows_xfer_shared_library):
3173         Add text_offset_cached argument.
3174         * windows-tdep.h (windows_xfer_shared_library): Update.
3175
3176 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
3177
3178         * gdbarch.sh: Add declaration for _initialize_gdbarch.
3179
3180 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
3181
3182         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
3183         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
3184         replace with range-based for.
3185         (gdbsim_interrupt_inferior): Remove.
3186         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
3187         with a range-based for.  Inline code from
3188         gdbsim_interrupt_inferior.
3189
3190 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
3191
3192         * infrun.c (proceed): Fix indentation.
3193
3194 2020-01-21  Tom Tromey  <tromey@adacore.com>
3195
3196         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
3197         * python/python.c (python_extension_ops): Update.
3198         (gdbpy_colorize): New function.
3199         * python/lib/gdb/__init__.py (colorize): New function.
3200         * extension.h (ext_lang_colorize): Declare.
3201         * extension.c (ext_lang_colorize): New function.
3202         * extension-priv.h (struct extension_language_ops) <colorize>: New
3203         member.
3204         * cli/cli-style.c (_initialize_cli_style): Update help text.
3205
3206 2020-01-21  Luis Machado  <luis.machado@linaro.org>
3207
3208         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
3209         <cond>: Change type to bool.
3210         (aarch64_displaced_step_b_cond): Update cond to use bool type.
3211         (aarch64_displaced_step_cb): Likewise.
3212         (aarch64_displaced_step_tb): Likewise.
3213
3214 2020-01-21  Luis Machado  <luis.machado@linaro.org>
3215
3216         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
3217         output.
3218
3219 2020-01-21  Luis Machado  <luis.machado@linaro.org>
3220
3221         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
3222         <pc_adjust>: Adjust the documentation.
3223         (aarch64_displaced_step_fixup): Check if PC really moved before
3224         adjusting it.
3225
3226 2020-01-19  Tom Tromey  <tom@tromey.com>
3227
3228         * disasm.c (~gdb_disassembler): New destructor.
3229         (gdb_buffered_insn_length): Call disassemble_free_target.
3230         * disasm.h (class gdb_disassembler): Declare destructor.  Use
3231         DISABLE_COPY_AND_ASSIGN.
3232
3233 2020-01-19  Tom Tromey  <tom@tromey.com>
3234
3235         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
3236         (die_reader_func_ftype): Remove.
3237         (cutu_reader): New class.
3238         (dw2_get_file_names_reader): Remove "data" parameter.
3239         (dw2_get_file_names): Use cutu_reader.
3240         (create_debug_type_hash_table): Update.
3241         (read_cutu_die_from_dwo): Update comment.
3242         (lookup_dwo_unit): Add dwo_name parameter.
3243         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
3244         die_reader_func_ftype and data parameters.
3245         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
3246         Remove die_reader_func_ftype and data parameters.
3247         (~cutu_reader): New; from init_cutu_and_read_dies.
3248         (cutu_reader::cutu_reader): Rename from
3249         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
3250         and data parameters.
3251         (init_cutu_and_read_dies_simple): Remove.
3252         (struct process_psymtab_comp_unit_data): Remove.
3253         (process_psymtab_comp_unit_reader): Remove data parameter; add
3254         want_partial_unit and pretend_language parameters.
3255         (process_psymtab_comp_unit): Use cutu_reader.
3256         (build_type_psymtabs_reader): Remove data parameter.
3257         (build_type_psymtabs_1): Use cutu_reader.
3258         (process_skeletonless_type_unit): Likewise.
3259         (load_partial_comp_unit_reader): Remove.
3260         (load_partial_comp_unit): Use cutu_reader.
3261         (load_full_comp_unit_reader): Remove.
3262         (load_full_comp_unit): Use cutu_reader.
3263         (struct create_dwo_cu_data): Remove.
3264         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
3265         dwo_unit parameters.
3266         (create_cus_hash_table): Use cutu_reader.
3267         (struct dwarf2_read_addr_index_data): Remove.
3268         (dwarf2_read_addr_index_reader): Remove.
3269         (dwarf2_read_addr_index): Use cutu_reader.
3270         (read_signatured_type_reader): Remove.
3271         (read_signatured_type): Use cutu_reader.
3272
3273 2020-01-19  Tom Tromey  <tom@tromey.com>
3274
3275         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
3276         * tui/tui-wingeneral.h (class tui_suppress_output): New.
3277         (tui_wrefresh): Declare.
3278         * tui/tui-wingeneral.c (suppress_output): New global.
3279         (tui_suppress_output, ~tui_suppress_output): New constructor and
3280         destructor.
3281         (tui_wrefresh): New function.
3282         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
3283         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
3284         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
3285         method.
3286         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
3287         tui_wrefresh.
3288         (tui_data_window::no_refresh): New method.
3289         (tui_data_item_window::refresh_window): Call tui_wrefresh.
3290         (tui_reg_command): Use tui_suppress_output
3291         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
3292         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
3293         method.
3294         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
3295
3296 2020-01-19  Tom Tromey  <tom@tromey.com>
3297
3298         * tui/tui-winsource.c (tui_update_source_windows_with_line):
3299         Handle case where symtab is null.
3300
3301 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
3302
3303         * linux-fork.c (one_fork_p): Simplify.
3304
3305 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
3306
3307         * top.c (struct qt_args): Remove.
3308         (kill_or_detach): Change return type to void, replace `void *`
3309         parameter with a proper one.
3310         (print_inferior_quit_action):  Likewise.
3311         (quit_confirm): Use range-based for loop to iterate over inferiors.
3312         (quit_force): Likewise.
3313
3314 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
3315
3316         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
3317         `void *` parameter with proper parameters.
3318         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
3319         (print_one_inferior): Change return type to void, replace `void *`
3320         parameter with proper parameters.
3321         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
3322         inferiors.
3323         (get_other_inferior): Remove.
3324         (mi_cmd_remove_inferior): Use range-based loop to iterate over
3325         inferiors.
3326
3327 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
3328
3329         * mi/mi-interp.c (report_initial_inferior): Remove.
3330         (mi_interp::init): Use range-based for to iterate over inferiors.
3331
3332 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
3333
3334         * python/py-inferior.c (build_inferior_list): Remove.
3335         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
3336
3337 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
3338
3339         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
3340         (btrace_stitch_trace): Likewise.
3341         * charset.c (intermediate_encoding): Likewise (vaild).
3342         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
3343         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
3344         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
3345
3346 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
3347
3348         * windows-tdep.c (windows_get_tlb_type):
3349         Add rtl_user_process_parameters type.
3350
3351 2020-01-16  Pedro Alves  <palves@redhat.com>
3352             Norbert Lange  <nolange79@gmail.com>
3353
3354         PR build/24805
3355         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
3356         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
3357         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
3358         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
3359         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
3360         (ps_plog): Redeclare exported functions with default visibility.
3361
3362 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
3363
3364         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
3365         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
3366
3367 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
3368
3369         * infcmd.c (post_create_inferior): Use get_thread_regcache
3370         instead of get_current_regcache.
3371
3372 2020-01-14  Tom Tromey  <tom@tromey.com>
3373
3374         PR symtab/12535:
3375         * python/python.c (gdbpy_decode_line): Treat empty string the same
3376         as no argument.
3377
3378 2020-01-14  Tom Tromey  <tom@tromey.com>
3379
3380         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
3381
3382 2020-01-14  Tom Tromey  <tom@tromey.com>
3383
3384         * nat/linux-btrace.c: Don't include <config.h>.
3385         * nat/linux-ptrace.c: Don't include <config.h>.
3386         * nat/x86-linux-dregs.c: Don't include <config.h>.
3387
3388 2020-01-14  Tom Tromey  <tom@tromey.com>
3389
3390         * configure: Rebuild.
3391         * configure.ac: Move many checks to ../gdbsupport/common.m4.
3392
3393 2020-01-14  Tom Tromey  <tom@tromey.com>
3394
3395         * nat/x86-linux-dregs.c: Include configh.h.
3396         * nat/linux-ptrace.c: Include configh.h.
3397         * nat/linux-btrace.c: Include configh.h.
3398         * defs.h: Include config.h, bfd.h.
3399         * configure.ac: Don't source common.host.
3400         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
3401         * configure: Rebuild.
3402         * acinclude.m4: Update path.
3403         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
3404         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
3405         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
3406         (CLIBS): Add LIBSUPPORT.
3407         (CDEPS): Likewise.
3408         (COMMON_SFILES): Remove gdbsupport files.
3409         (HFILES_NO_SRCDIR): Likewise.
3410         (stamp-version): Update path to create-version.sh.
3411         (ALLDEPFILES): Remove gdbsupport files.
3412
3413 2020-01-14  Tom Tromey  <tom@tromey.com>
3414
3415         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
3416         USE_WIN32API when needed.
3417         * configure.ac (USE_WIN32API): Don't define.
3418         (WIN32LIBS): Use WIN32APILIBS.
3419         * configure: Rebuild.
3420
3421 2020-01-14  Tom Tromey  <tom@tromey.com>
3422
3423         * configure: Rebuild.
3424         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
3425
3426 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
3427
3428         * skip.c (skip_function_command): Make skip w/o arguments use the
3429         name of the inlined function if pc is inside any inlined function.
3430
3431 2020-01-14  Luis Machado  <luis.machado@linaro.org>
3432
3433         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
3434         * infrun.c (resume_1): Likewise.
3435         (handle_inferior_event): Remove stale comment.
3436         * linux-nat.c (linux_nat_target::resume): Update comments.
3437         (save_stop_reason): Likewise.
3438         (linux_nat_filter_event): Likewise.
3439         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
3440
3441 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3442
3443         * elfread.c (record_minimal_symbol): Set section index to 0 for
3444         non-allocatable sections.
3445
3446
3447 2020-01-13  Ali Tamur <tamur@google.com>
3448
3449         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
3450         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
3451         to gdb::optional.  Update comments.
3452         (dwo_file): Update comments.
3453         (read_attribute): Update API to take an additional out parameter,
3454         need_reprocess.  This is used to mark attributes that need other
3455         attributes (e.g. str_offsets_base) for correct computation which may not
3456         have been read yet.
3457         (read_attribute_reprocess): New function declaration.
3458         (read_addr_index): Likewise.
3459         (read_dwo_str_index): Likewise.
3460         (read_stub_str_index): Likewise.
3461         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
3462         (lookup_addr_base): New function definition.
3463         (lookup_ranges_base): Likewise.
3464         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
3465         lookup_ranges_base.
3466         (init_cutu_and_read_dies): Update comments.
3467         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
3468         unit.  This is used to inherit parent's str_offsets_base and addr_base.
3469         Update comments.
3470         (init_cutu_and_read_dies_simple): Reflect API changes.
3471         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
3472         (create_cus_hash_table): Change API to take parent compile unit.
3473         Reflect API changes.
3474         (open_and_init_dwo_file): Reflect API changes.
3475         (dwarf2_get_pc_bounds): Update comments.
3476         (dwarf2_record_block_ranges): Likewise.
3477         (read_full_die_1): Change implementation to reprocess attributes that
3478         need str_offsets_base and addr_base.
3479         (partial_die_info::read): Likewise.
3480         (read_attribute_reprocess): New function definition.
3481         (read_attribute_value): Change API to take an additional out parameter,
3482         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
3483         when a non-dwo compile unit has index based attributes.
3484         (read_attribute): Reflect API changes.
3485         (read_addr_index_1): Reflect API changes.  Update comments.
3486         (dwarf2_read_addr_index_data): Reflect API changes.
3487         (dwarf2_read_addr_index): Likewise.
3488         (read_str_index): Change API and implementation.  This becomes a helper
3489         to be used by the new string index related methods.  Update error
3490         message and comments.
3491         (read_dwo_str_index): New function definition.
3492         (read_stub_str_index): Likewise.
3493         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
3494         * symfile.h (dwarf2_debug_sections): Likewise.
3495         * xcoffread.c (dwarf2_debug_sections): Likewise.
3496
3497 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
3498
3499         * gdbcore.h (struct core_fns) <core_read_registers>: Change
3500         core_reg_sect type to gdb_byte *.
3501         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
3502         * cris-tdep.c (fetch_core_registers): Likewise.
3503         * corelow.c (core_target::get_core_register_section): Change
3504         type of `contents` to gdb::byte_vector.
3505
3506 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3507
3508         * tui/tui-wingeneral.c (box_win): Position the title in the center
3509         of the border.
3510
3511 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
3512
3513         * corelow.c (core_target::get_core_register_section): Use
3514           std::vector instead of alloca.
3515
3516 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
3517
3518         * warning.m4: Add -Wmissing-declarations to build_warnings.
3519         * configure: Re-generate.
3520
3521 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
3522
3523         * python/python.c (init__gdb_module): Add declaration.
3524
3525 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
3526
3527         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
3528         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
3529         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
3530         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
3531         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
3532         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
3533         * ada-exp.y (_initialize_ada_exp): Add declaration.
3534         * ada-lang.c (_initialize_ada_language): Add declaration.
3535         * ada-tasks.c (_initialize_tasks): Add declaration.
3536         * agent.c (_initialize_agent): Add declaration.
3537         * aix-thread.c (_initialize_aix_thread): Add declaration.
3538         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
3539         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
3540         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
3541         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
3542         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
3543         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
3544         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
3545         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
3546         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
3547         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
3548         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
3549         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
3550         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
3551         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
3552         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
3553         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
3554         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
3555         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
3556         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
3557         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
3558         * annotate.c (_initialize_annotate): Add declaration.
3559         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
3560         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
3561         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
3562         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
3563         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
3564         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
3565         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
3566         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
3567         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
3568         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
3569         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
3570         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
3571         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
3572         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
3573         * auto-load.c (_initialize_auto_load): Add declaration.
3574         * auxv.c (_initialize_auxv): Add declaration.
3575         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
3576         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
3577         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
3578         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
3579         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
3580         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
3581         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
3582         * breakpoint.c (_initialize_breakpoint): Add declaration.
3583         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
3584         * btrace.c (_initialize_btrace): Add declaration.
3585         * charset.c (_initialize_charset): Add declaration.
3586         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
3587         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
3588         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
3589         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
3590         * cli/cli-script.c (_initialize_cli_script): Add declaration.
3591         * cli/cli-style.c (_initialize_cli_style): Add declaration.
3592         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
3593         * coffread.c (_initialize_coffread): Add declaration.
3594         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
3595         * compile/compile.c (_initialize_compile): Add declaration.
3596         * complaints.c (_initialize_complaints): Add declaration.
3597         * completer.c (_initialize_completer): Add declaration.
3598         * copying.c (_initialize_copying): Add declaration.
3599         * corefile.c (_initialize_core): Add declaration.
3600         * corelow.c (_initialize_corelow): Add declaration.
3601         * cp-abi.c (_initialize_cp_abi): Add declaration.
3602         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
3603         * cp-support.c (_initialize_cp_support): Add declaration.
3604         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
3605         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
3606         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
3607         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
3608         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
3609         * ctfread.c (_initialize_ctfread): Add declaration.
3610         * d-lang.c (_initialize_d_language): Add declaration.
3611         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
3612         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
3613         * dbxread.c (_initialize_dbxread): Add declaration.
3614         * dcache.c (_initialize_dcache): Add declaration.
3615         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
3616         * disasm.c (_initialize_disasm): Add declaration.
3617         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
3618         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
3619         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
3620         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
3621         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
3622         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
3623         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
3624         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
3625         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
3626         * elfread.c (_initialize_elfread): Add declaration.
3627         * exec.c (_initialize_exec): Add declaration.
3628         * extension.c (_initialize_extension): Add declaration.
3629         * f-lang.c (_initialize_f_language): Add declaration.
3630         * f-valprint.c (_initialize_f_valprint): Add declaration.
3631         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
3632         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
3633         * filesystem.c (_initialize_filesystem): Add declaration.
3634         * findcmd.c (_initialize_mem_search): Add declaration.
3635         * findvar.c (_initialize_findvar): Add declaration.
3636         * fork-child.c (_initialize_fork_child): Add declaration.
3637         * frame-base.c (_initialize_frame_base): Add declaration.
3638         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
3639         * frame.c (_initialize_frame): Add declaration.
3640         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
3641         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
3642         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
3643         * gcore.c (_initialize_gcore): Add declaration.
3644         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
3645         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
3646         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
3647         * gdbarch.c (_initialize_gdbarch): Add declaration.
3648         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
3649         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
3650         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
3651         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
3652         * go-lang.c (_initialize_go_language): Add declaration.
3653         * go32-nat.c (_initialize_go32_nat): Add declaration.
3654         * guile/guile.c (_initialize_guile): Add declaration.
3655         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
3656         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
3657         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
3658         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
3659         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
3660         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
3661         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
3662         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
3663         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
3664         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
3665         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
3666         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
3667         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
3668         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
3669         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
3670         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
3671         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
3672         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
3673         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
3674         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
3675         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
3676         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
3677         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
3678         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
3679         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
3680         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
3681         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
3682         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
3683         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
3684         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
3685         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
3686         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
3687         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
3688         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
3689         * infcall.c (_initialize_infcall): Add declaration.
3690         * infcmd.c (_initialize_infcmd): Add declaration.
3691         * inflow.c (_initialize_inflow): Add declaration.
3692         * infrun.c (_initialize_infrun): Add declaration.
3693         * interps.c (_initialize_interpreter): Add declaration.
3694         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
3695         * jit.c (_initialize_jit): Add declaration.
3696         * language.c (_initialize_language): Add declaration.
3697         * linux-fork.c (_initialize_linux_fork): Add declaration.
3698         * linux-nat.c (_initialize_linux_nat): Add declaration.
3699         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
3700         * linux-thread-db.c (_initialize_thread_db): Add declaration.
3701         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
3702         * m2-lang.c (_initialize_m2_language): Add declaration.
3703         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
3704         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
3705         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
3706         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
3707         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
3708         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
3709         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
3710         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
3711         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
3712         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
3713         * machoread.c (_initialize_machoread): Add declaration.
3714         * macrocmd.c (_initialize_macrocmd): Add declaration.
3715         * macroscope.c (_initialize_macroscope): Add declaration.
3716         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
3717         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
3718         * maint.c (_initialize_maint_cmds): Add declaration.
3719         * mdebugread.c (_initialize_mdebugread): Add declaration.
3720         * memattr.c (_initialize_mem): Add declaration.
3721         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
3722         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
3723         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
3724         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
3725         * mi/mi-main.c (_initialize_mi_main): Add declaration.
3726         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
3727         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
3728         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
3729         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
3730         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
3731         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
3732         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
3733         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
3734         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
3735         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
3736         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
3737         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
3738         * mipsread.c (_initialize_mipsread): Add declaration.
3739         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
3740         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
3741         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
3742         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
3743         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
3744         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
3745         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
3746         * nto-procfs.c (_initialize_procfs): Add declaration.
3747         * objc-lang.c (_initialize_objc_language): Add declaration.
3748         * observable.c (_initialize_observer): Add declaration.
3749         * opencl-lang.c (_initialize_opencl_language): Add declaration.
3750         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
3751         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
3752         * osabi.c (_initialize_gdb_osabi): Add declaration.
3753         * osdata.c (_initialize_osdata): Add declaration.
3754         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
3755         * parse.c (_initialize_parse): Add declaration.
3756         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
3757         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
3758         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
3759         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
3760         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
3761         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
3762         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
3763         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
3764         * printcmd.c (_initialize_printcmd): Add declaration.
3765         * probe.c (_initialize_probe): Add declaration.
3766         * proc-api.c (_initialize_proc_api): Add declaration.
3767         * proc-events.c (_initialize_proc_events): Add declaration.
3768         * proc-service.c (_initialize_proc_service): Add declaration.
3769         * procfs.c (_initialize_procfs): Add declaration.
3770         * producer.c (_initialize_producer): Add declaration.
3771         * psymtab.c (_initialize_psymtab): Add declaration.
3772         * python/python.c (_initialize_python): Add declaration.
3773         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
3774         * record-btrace.c (_initialize_record_btrace): Add declaration.
3775         * record-full.c (_initialize_record_full): Add declaration.
3776         * record.c (_initialize_record): Add declaration.
3777         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
3778         * regcache.c (_initialize_regcache): Add declaration.
3779         * reggroups.c (_initialize_reggroup): Add declaration.
3780         * remote-notif.c (_initialize_notif): Add declaration.
3781         * remote-sim.c (_initialize_remote_sim): Add declaration.
3782         * remote.c (_initialize_remote): Add declaration.
3783         * reverse.c (_initialize_reverse): Add declaration.
3784         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
3785         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
3786         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
3787         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
3788         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
3789         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
3790         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
3791         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
3792         Add declaration.
3793         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
3794         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
3795         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
3796         * rust-exp.y (_initialize_rust_exp): Add declaration.
3797         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
3798         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
3799         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
3800         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
3801         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
3802         * score-tdep.c (_initialize_score_tdep): Add declaration.
3803         * ser-go32.c (_initialize_ser_dos): Add declaration.
3804         * ser-mingw.c (_initialize_ser_windows): Add declaration.
3805         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
3806         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
3807         * ser-uds.c (_initialize_ser_socket): Add declaration.
3808         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
3809         * serial.c (_initialize_serial): Add declaration.
3810         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
3811         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
3812         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
3813         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
3814         * skip.c (_initialize_step_skip): Add declaration.
3815         * sol-thread.c (_initialize_sol_thread): Add declaration.
3816         * solib-aix.c (_initialize_solib_aix): Add declaration.
3817         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
3818         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
3819         * solib-frv.c (_initialize_frv_solib): Add declaration.
3820         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
3821         * solib-target.c (_initialize_solib_target): Add declaration.
3822         * solib.c (_initialize_solib): Add declaration.
3823         * source-cache.c (_initialize_source_cache): Add declaration.
3824         * source.c (_initialize_source): Add declaration.
3825         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
3826         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
3827         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
3828         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
3829         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
3830         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
3831         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
3832         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
3833         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
3834         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
3835         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
3836         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
3837         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
3838         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
3839         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
3840         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
3841         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
3842         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
3843         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
3844         * stabsread.c (_initialize_stabsread): Add declaration.
3845         * stack.c (_initialize_stack): Add declaration.
3846         * stap-probe.c (_initialize_stap_probe): Add declaration.
3847         * std-regs.c (_initialize_frame_reg): Add declaration.
3848         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
3849         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
3850         * symfile.c (_initialize_symfile): Add declaration.
3851         * symmisc.c (_initialize_symmisc): Add declaration.
3852         * symtab.c (_initialize_symtab): Add declaration.
3853         * target.c (_initialize_target): Add declaration.
3854         * target-connection.c (_initialize_target_connection): Add
3855         declaration.
3856         * target-dcache.c (_initialize_target_dcache): Add declaration.
3857         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
3858         * thread.c (_initialize_thread): Add declaration.
3859         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
3860         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
3861         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
3862         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
3863         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
3864         * tracectf.c (_initialize_ctf): Add declaration.
3865         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
3866         * tracefile.c (_initialize_tracefile): Add declaration.
3867         * tracepoint.c (_initialize_tracepoint): Add declaration.
3868         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
3869         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
3870         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
3871         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
3872         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
3873         * tui/tui-win.c (_initialize_tui_win): Add declaration.
3874         * tui/tui.c (_initialize_tui): Add declaration.
3875         * typeprint.c (_initialize_typeprint): Add declaration.
3876         * ui-style.c (_initialize_ui_style): Add declaration.
3877         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
3878         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
3879         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
3880         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
3881         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
3882         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
3883         * unittests/filtered_iterator-selftests.c
3884         (_initialize_filtered_iterator_selftests): Add declaration.
3885         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
3886         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
3887         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
3888         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
3889         * unittests/main-thread-selftests.c
3890         (_initialize_main_thread_selftests): Add declaration.
3891         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
3892         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
3893         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
3894         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
3895         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
3896         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
3897         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
3898         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
3899         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
3900         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
3901         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
3902         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
3903         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
3904         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
3905         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
3906         declaration.
3907         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
3908         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
3909         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
3910         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
3911         * user-regs.c (_initialize_user_regs): Add declaration.
3912         * utils.c (_initialize_utils): Add declaration.
3913         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
3914         * valops.c (_initialize_valops): Add declaration.
3915         * valprint.c (_initialize_valprint): Add declaration.
3916         * value.c (_initialize_values): Add declaration.
3917         * varobj.c (_initialize_varobj): Add declaration.
3918         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
3919         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
3920         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
3921         * windows-nat.c (_initialize_windows_nat): Add declaration.
3922         (_initialize_check_for_gdb_ini): Add declaration.
3923         (_initialize_loadable): Add declaration.
3924         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
3925         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
3926         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
3927         * xcoffread.c (_initialize_xcoffread): Add declaration.
3928         * xml-support.c (_initialize_xml_support): Add declaration.
3929         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
3930         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
3931         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
3932         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
3933
3934 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
3935
3936         * regformats/regdat.sh: Generate declaration for init function.
3937
3938 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
3939
3940         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
3941         up.
3942         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
3943         close_one_inferior>: New methods.
3944         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
3945         pass down target to find_inferior_pid.
3946         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
3947         Pass down target to find_inferior_ptid.
3948         (gdbsim_target::create_inferior): Pass down target to
3949         add_thread_silent.
3950         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
3951         target down to find_inferior_ptid and switch_to_thread.
3952         (gdbsim_target::close): Update to call close_one_inferior.
3953         (struct resume_data): Remove.
3954         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
3955         directly, rather than through a void pointer.
3956         (gdbsim_target::resume): Update to call resume_one_inferior.
3957
3958 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
3959
3960         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
3961
3962 2020-01-12  Pedro Alves  <palves@redhat.com>
3963
3964         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
3965         directly for the current inferior instead of
3966         discard_all_inferiors.
3967         (discard_all_inferiors): Delete.
3968
3969 2020-01-11  Tom Tromey  <tom@tromey.com>
3970
3971         * tui/tui-wingeneral.c (box_win): Check cli_styling.
3972         * tui/tui-winsource.c (tui_source_window_base::refill): Use
3973         deprecated_safe_get_selected_frame.
3974
3975 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3976
3977         * inferior.c (print_inferior): Switch inferior before printing it.
3978
3979 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
3980             Pedro Alves  <palves@redhat.com>
3981
3982         * progspace-and-thread.c (switch_to_program_space_and_thread):
3983         Assert there's an inferior for PSPACE.  Use
3984         switch_to_inferior_no_thread to switch the inferior too.
3985         * progspace.c (program_space::~program_space): Call
3986         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
3987         (program_space::free_all_objfiles): Don't call clear_symtab_users
3988         here.
3989         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
3990
3991 2020-01-10  Pedro Alves  <palves@redhat.com>
3992
3993         * NEWS: Mention multi-target debugging, "info connections", and
3994         "add-inferior -no-connection".
3995
3996 2020-01-10  Pedro Alves  <palves@redhat.com>
3997
3998         * infrun.c: Include "target-connection.h".
3999         (check_multi_target_resumption): New.
4000         (proceed): Call it.
4001         * target-connection.c (make_target_connection_string): Make
4002         extern.
4003         * target-connection.h (make_target_connection_string): Declare.
4004
4005 2020-01-10  Pedro Alves  <palves@redhat.com>
4006
4007         * Makefile.in (COMMON_SFILES): Add target-connection.c.
4008         * inferior.c (uiout_field_connection): New function.
4009         (print_inferior): Add new "connection-id" column.
4010         (add_inferior_command): Show connection number/string of added
4011         inferior.
4012         * process-stratum-target.h
4013         (process_stratum_target::connection_string): New virtual method.
4014         (process_stratum_target::connection_number): New field.
4015         * remote.c (remote_target::connection_string): New override.
4016         * target-connection.c: New file.
4017         * target-connection.h: New file.
4018         * target.c (decref_target): Remove process_stratum targets from
4019         the connection list.
4020         (target_stack::push): Add process_stratum targets to the
4021         connection list.
4022
4023 2020-01-10  Pedro Alves  <palves@redhat.com>
4024
4025         Revert:
4026         2016-04-12  Pedro Alves  <palves@redhat.com>
4027         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
4028         Remove references to name.
4029         * serial.h (struct serial) <name>: Delete.
4030
4031 2020-01-10  Pedro Alves  <palves@redhat.com>
4032
4033         * gdbarch-selftests.c (register_to_value_test): Remove "target
4034         already pushed" check.
4035
4036 2020-01-10  Pedro Alves  <palves@redhat.com>
4037             John Baldwin  <jhb@FreeBSD.org>
4038
4039         * aarch64-linux-nat.c
4040         (aarch64_linux_nat_target::thread_architecture): Adjust.
4041         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
4042         (task_command_1): Likewise.
4043         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
4044         (aix_thread_target::wait, aix_thread_target::fetch_registers)
4045         (aix_thread_target::store_registers)
4046         (aix_thread_target::thread_alive): Adjust.
4047         * amd64-fbsd-tdep.c: Include "inferior.h".
4048         (amd64fbsd_get_thread_local_address): Pass down target.
4049         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
4050         thread's gdbarch instead of target_gdbarch.
4051         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
4052         get_last_target_status.
4053         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
4054         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
4055         inferiors.
4056         (update_inserted_breakpoint_locations): Skip if inferiors with no
4057         execution.
4058         (update_global_location_list): When handling moribund locations,
4059         find representative inferior for location's pspace, and use thread
4060         count of its process_stratum target.
4061         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
4062         * bsd-uthread.c (bsd_uthread_target::wait): Use
4063         as_process_stratum_target and adjust thread_change_ptid and
4064         add_thread calls.
4065         (bsd_uthread_target::update_thread_list): Use
4066         as_process_stratum_target and adjust find_thread_ptid,
4067         thread_change_ptid and add_thread calls.
4068         * btrace.c (maint_btrace_packet_history_cmd): Adjust
4069         find_thread_ptid call.
4070         * corelow.c (add_to_thread_list): Adjust add_thread call.
4071         (core_target_open): Adjust add_thread_silent and thread_count
4072         calls.
4073         (core_target::pid_to_str): Adjust find_inferior_ptid call.
4074         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
4075         * event-top.c (async_disconnect): Pop targets from all inferiors.
4076         * exec.c (add_target_sections): Push exec target on all inferiors
4077         sharing the program space.
4078         (remove_target_sections): Remove the exec target from all
4079         inferiors sharing the program space.
4080         (exec_on_vfork): New.
4081         * exec.h (exec_on_vfork): Declare.
4082         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
4083         Pass it down.
4084         (fbsd_nat_target::update_thread_list): Adjust.
4085         (fbsd_nat_target::resume): Adjust.
4086         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
4087         down.
4088         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
4089         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
4090         get_thread_arch_regcache call.
4091         * fork-child.c (gdb_startup_inferior): Pass target down to
4092         startup_inferior and set_executing.
4093         * gdbthread.h (struct process_stratum_target): Forward declare.
4094         (add_thread, add_thread_silent, add_thread_with_info)
4095         (in_thread_list): Add process_stratum_target parameter.
4096         (find_thread_ptid(inferior*, ptid_t)): New overload.
4097         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
4098         parameter.
4099         (all_threads()): Delete overload.
4100         (all_threads, all_non_exited_threads): Add process_stratum_target
4101         parameter.
4102         (all_threads_safe): Use brace initialization.
4103         (thread_count): Add process_stratum_target parameter.
4104         (set_resumed, set_running, set_stop_requested, set_executing)
4105         (threads_are_executing, finish_thread_state): Add
4106         process_stratum_target parameter.
4107         (switch_to_thread): Use is_current_thread.
4108         * i386-fbsd-tdep.c: Include "inferior.h".
4109         (i386fbsd_get_thread_local_address): Pass down target.
4110         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
4111         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
4112         have_inferiors check.
4113         * inf-ptrace.c (inf_ptrace_target::create_inferior)
4114         (inf_ptrace_target::attach): Adjust.
4115         * infcall.c (run_inferior_call): Adjust.
4116         * infcmd.c (run_command_1): Pass target to
4117         scoped_finish_thread_state.
4118         (proceed_thread_callback): Skip inferiors with no execution.
4119         (continue_command): Rename 'all_threads' local to avoid hiding
4120         'all_threads' function.  Adjust get_last_target_status call.
4121         (prepare_one_step): Adjust set_running call.
4122         (signal_command): Use user_visible_resume_target.  Compare thread
4123         pointers instead of inferior_ptid.
4124         (info_program_command): Adjust to pass down target.
4125         (attach_command): Mark target's 'thread_executing' flag.
4126         (stop_current_target_threads_ns): New, factored out from ...
4127         (interrupt_target_1): ... this.  Switch inferior before making
4128         target calls.
4129         * inferior-iter.h
4130         (struct all_inferiors_iterator, struct all_inferiors_range)
4131         (struct all_inferiors_safe_range)
4132         (struct all_non_exited_inferiors_range): Filter on
4133         process_stratum_target too.  Remove explicit.
4134         * inferior.c (inferior::inferior): Push dummy target on target
4135         stack.
4136         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
4137         Add process_stratum_target parameter, and pass it down.
4138         (have_live_inferiors): Adjust.
4139         (switch_to_inferior_and_push_target): New.
4140         (add_inferior_command, clone_inferior_command): Handle
4141         "-no-connection" parameter.  Use
4142         switch_to_inferior_and_push_target.
4143         (_initialize_inferior): Mention "-no-connection" option in
4144         the help of "add-inferior" and "clone-inferior" commands.
4145         * inferior.h: Include "process-stratum-target.h".
4146         (interrupt_target_1): Use bool.
4147         (struct inferior) <push_target, unpush_target, target_is_pushed,
4148         find_target_beneath, top_target, process_target, target_at,
4149         m_stack>: New.
4150         (discard_all_inferiors): Delete.
4151         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
4152         (all_inferiors, all_non_exited_inferiors): Add
4153         process_stratum_target parameter.
4154         * infrun.c: Include "gdb_select.h" and <unordered_map>.
4155         (target_last_proc_target): New global.
4156         (follow_fork_inferior): Push target on new inferior.  Pass target
4157         to add_thread_silent.  Call exec_on_vfork.  Handle target's
4158         reference count.
4159         (follow_fork): Adjust get_last_target_status call.  Also consider
4160         target.
4161         (follow_exec): Push target on new inferior.
4162         (struct execution_control_state) <target>: New field.
4163         (user_visible_resume_target): New.
4164         (do_target_resume): Call target_async.
4165         (resume_1): Set target's threads_executing flag.  Consider resume
4166         target.
4167         (commit_resume_all_targets): New.
4168         (proceed): Also consider resume target.  Skip threads of inferiors
4169         with no execution.  Commit resumtion in all targets.
4170         (start_remote): Pass current inferior to wait_for_inferior.
4171         (infrun_thread_stop_requested): Consider target as well.  Pass
4172         thread_info pointer to clear_inline_frame_state instead of ptid.
4173         (infrun_thread_thread_exit): Consider target as well.
4174         (random_pending_event_thread): New inferior parameter.  Use it.
4175         (do_target_wait): Rename to ...
4176         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
4177         down.
4178         (threads_are_resumed_pending_p, do_target_wait): New.
4179         (prepare_for_detach): Adjust calls.
4180         (wait_for_inferior): New inferior parameter.  Handle it.  Use
4181         do_target_wait_1 instead of do_target_wait.
4182         (fetch_inferior_event): Adjust.  Switch to representative
4183         inferior.  Pass target down.
4184         (set_last_target_status): Add process_stratum_target parameter.
4185         Save target in global.
4186         (get_last_target_status): Add process_stratum_target parameter and
4187         handle it.
4188         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
4189         (context_switch): Check inferior_ptid == null_ptid before calling
4190         inferior_thread().
4191         (get_inferior_stop_soon): Pass down target.
4192         (wait_one): Rename to ...
4193         (poll_one_curr_target): ... this.
4194         (struct wait_one_event): New.
4195         (wait_one): New.
4196         (stop_all_threads): Adjust.
4197         (handle_no_resumed, handle_inferior_event): Adjust to consider the
4198         event's target.
4199         (switch_back_to_stepped_thread): Also consider target.
4200         (print_stop_event): Update.
4201         (normal_stop): Update.  Also consider the resume target.
4202         * infrun.h (wait_for_inferior): Remove declaration.
4203         (user_visible_resume_target): New declaration.
4204         (get_last_target_status, set_last_target_status): New
4205         process_stratum_target parameter.
4206         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
4207         process_stratum_target parameter, and use it.
4208         (clear_inline_frame_state (thread_info*)): New.
4209         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
4210         process_stratum_target parameter.
4211         (clear_inline_frame_state (thread_info*)): Declare.
4212         * linux-fork.c (delete_checkpoint_command): Pass target down to
4213         find_thread_ptid.
4214         (checkpoint_command): Adjust.
4215         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
4216         instead of just tweaking inferior_ptid.
4217         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
4218         (exit_lwp): Pass target down to find_thread_ptid.
4219         (attach_proc_task_lwp_callback): Pass target down to
4220         add_thread/set_running/set_executing.
4221         (linux_nat_target::attach): Pass target down to
4222         thread_change_ptid.
4223         (get_detach_signal): Pass target down to find_thread_ptid.
4224         Consider last target status's target.
4225         (linux_resume_one_lwp_throw, resume_lwp)
4226         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
4227         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
4228         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
4229         (linux_nat_target::async_wait_fd): New.
4230         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
4231         target down.
4232         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
4233         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
4234         * linux-thread-db.c (struct thread_db_info::process_target): New
4235         field.
4236         (add_thread_db_info): Save target.
4237         (get_thread_db_info): New process_stratum_target parameter.  Also
4238         match target.
4239         (delete_thread_db_info): New process_stratum_target parameter.
4240         Also match target.
4241         (thread_from_lwp): Adjust to pass down target.
4242         (thread_db_notice_clone): Pass down target.
4243         (check_thread_db_callback): Pass down target.
4244         (try_thread_db_load_1): Always push the thread_db target.
4245         (try_thread_db_load, record_thread): Pass target down.
4246         (thread_db_target::detach): Pass target down.  Always unpush the
4247         thread_db target.
4248         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
4249         target down.  Always unpush the thread_db target.
4250         (find_new_threads_callback, thread_db_find_new_threads_2)
4251         (thread_db_target::update_thread_list): Pass target down.
4252         (thread_db_target::pid_to_str): Pass current inferior down.
4253         (thread_db_target::get_thread_local_address): Pass target down.
4254         (thread_db_target::resume, maintenance_check_libthread_db): Pass
4255         target down.
4256         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
4257         * procfs.c (procfs_target::procfs_init_inferior): Declare.
4258         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
4259         (procfs_init_inferior): Rename to ...
4260         (procfs_target::procfs_init_inferior): ... this and adjust.
4261         (procfs_target::create_inferior, procfs_notice_thread)
4262         (procfs_do_thread_registers): Adjust.
4263         * ppc-fbsd-tdep.c: Include "inferior.h".
4264         (ppcfbsd_get_thread_local_address): Pass down target.
4265         * proc-service.c (ps_xfer_memory): Switch current inferior and
4266         program space as well.
4267         (get_ps_regcache): Pass target down.
4268         * process-stratum-target.c
4269         (process_stratum_target::thread_address_space)
4270         (process_stratum_target::thread_architecture): Pass target down.
4271         * process-stratum-target.h
4272         (process_stratum_target::threads_executing): New field.
4273         (as_process_stratum_target): New.
4274         * ravenscar-thread.c
4275         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
4276         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
4277         down.
4278         * record-btrace.c (record_btrace_target::info_record): Adjust.
4279         (record_btrace_target::record_method)
4280         (record_btrace_target::record_is_replaying)
4281         (record_btrace_target::fetch_registers)
4282         (get_thread_current_frame_id, record_btrace_target::resume)
4283         (record_btrace_target::wait, record_btrace_target::stop): Pass
4284         target down.
4285         * record-full.c (record_full_wait_1): Switch to event thread.
4286         Pass target down.
4287         * regcache.c (regcache::regcache)
4288         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
4289         process_stratum_target parameter and handle it.
4290         (current_thread_target): New global.
4291         (get_thread_regcache): Add process_stratum_target parameter and
4292         handle it.  Switch inferior before calling target method.
4293         (get_thread_regcache): Pass target down.
4294         (get_thread_regcache_for_ptid): Pass target down.
4295         (registers_changed_ptid): Add process_stratum_target parameter and
4296         handle it.
4297         (registers_changed_thread, registers_changed): Pass target down.
4298         (test_get_thread_arch_aspace_regcache): New.
4299         (current_regcache_test): Define a couple local test_target_ops
4300         instances and use them for testing.
4301         (readwrite_regcache): Pass process_stratum_target parameter.
4302         (cooked_read_test, cooked_write_test): Pass mock_target down.
4303         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
4304         (get_thread_arch_aspace_regcache): Add process_stratum_target
4305         parameter.
4306         (regcache::target): New method.
4307         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
4308         (regcache::registers_changed_ptid): Add process_stratum_target
4309         parameter.
4310         (regcache::m_target): New field.
4311         (registers_changed_ptid): Add process_stratum_target parameter.
4312         * remote.c (remote_state::supports_vCont_probed): New field.
4313         (remote_target::async_wait_fd): New method.
4314         (remote_unpush_and_throw): Add remote_target parameter.
4315         (get_current_remote_target): Adjust.
4316         (remote_target::remote_add_inferior): Push target.
4317         (remote_target::remote_add_thread)
4318         (remote_target::remote_notice_new_inferior)
4319         (get_remote_thread_info): Pass target down.
4320         (remote_target::update_thread_list): Skip threads of inferiors
4321         bound to other targets.  (remote_target::close): Don't discard
4322         inferiors.  (remote_target::add_current_inferior_and_thread)
4323         (remote_target::process_initial_stop_replies)
4324         (remote_target::start_remote)
4325         (remote_target::remote_serial_quit_handler): Pass down target.
4326         (remote_target::remote_unpush_target): New remote_target
4327         parameter.  Unpush the target from all inferiors.
4328         (remote_target::remote_unpush_and_throw): New remote_target
4329         parameter.  Pass it down.
4330         (remote_target::open_1): Check whether the current inferior has
4331         execution instead of checking whether any inferior is live.  Pass
4332         target down.
4333         (remote_target::remote_detach_1): Pass down target.  Use
4334         remote_unpush_target.
4335         (extended_remote_target::attach): Pass down target.
4336         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
4337         (remote_target::append_resumption): Pass down target.
4338         (remote_target::append_pending_thread_resumptions)
4339         (remote_target::remote_resume_with_hc, remote_target::resume)
4340         (remote_target::commit_resume): Pass down target.
4341         (remote_target::remote_stop_ns): Check supports_vCont_probed.
4342         (remote_target::interrupt_query)
4343         (remote_target::remove_new_fork_children)
4344         (remote_target::check_pending_events_prevent_wildcard_vcont)
4345         (remote_target::remote_parse_stop_reply)
4346         (remote_target::process_stop_reply): Pass down target.
4347         (first_remote_resumed_thread): New remote_target parameter.  Pass
4348         it down.
4349         (remote_target::wait_as): Pass down target.
4350         (unpush_and_perror): New remote_target parameter.  Pass it down.
4351         (remote_target::readchar, remote_target::remote_serial_write)
4352         (remote_target::getpkt_or_notif_sane_1)
4353         (remote_target::kill_new_fork_children, remote_target::kill): Pass
4354         down target.
4355         (remote_target::mourn_inferior): Pass down target.  Use
4356         remote_unpush_target.
4357         (remote_target::core_of_thread)
4358         (remote_target::remote_btrace_maybe_reopen): Pass down target.
4359         (remote_target::pid_to_exec_file)
4360         (remote_target::thread_handle_to_thread_info): Pass down target.
4361         (remote_target::async_wait_fd): New.
4362         * riscv-fbsd-tdep.c: Include "inferior.h".
4363         (riscv_fbsd_get_thread_local_address): Pass down target.
4364         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
4365         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
4366         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
4367         Adjust.
4368         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
4369         * solib-svr4.c (enable_break): Pass down target.
4370         * spu-multiarch.c (parse_spufs_run): Pass down target.
4371         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
4372         * target-delegates.c: Regenerate.
4373         * target.c (g_target_stack): Delete.
4374         (current_top_target): Return the current inferior's top target.
4375         (target_has_execution_1): Refer to the passed-in inferior's top
4376         target.
4377         (target_supports_terminal_ours): Check whether the initial
4378         inferior was already created.
4379         (decref_target): New.
4380         (target_stack::push): Incref/decref the target.
4381         (push_target, push_target, unpush_target): Adjust.
4382         (target_stack::unpush): Defref target.
4383         (target_is_pushed): Return bool.  Adjust to refer to the current
4384         inferior's target stack.
4385         (dispose_inferior): Delete, and inline parts ...
4386         (target_preopen): ... here.  Only dispose of the current inferior.
4387         (target_detach): Hold strong target reference while detaching.
4388         Pass target down.
4389         (target_thread_name): Add assertion.
4390         (target_resume): Pass down target.
4391         (target_ops::beneath, find_target_at): Adjust to refer to the
4392         current inferior's target stack.
4393         (get_dummy_target): New.
4394         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
4395         has a thread running.
4396         (initialize_targets): Rename to ...
4397         (_initialize_target): ... this.
4398         * target.h: Include "gdbsupport/refcounted-object.h".
4399         (struct target_ops): Inherit refcounted_object.
4400         (target_ops::shortname, target_ops::longname): Make const.
4401         (target_ops::async_wait_fd): New method.
4402         (decref_target): Declare.
4403         (struct target_ops_ref_policy): New.
4404         (target_ops_ref): New typedef.
4405         (get_dummy_target): Declare function.
4406         (target_is_pushed): Return bool.
4407         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
4408         (all_matching_threads_iterator::all_matching_threads_iterator):
4409         Handle filter target.
4410         * thread-iter.h (struct all_matching_threads_iterator, struct
4411         all_matching_threads_range, class all_non_exited_threads_range):
4412         Filter by target too.  Remove explicit.
4413         * thread.c (threads_executing): Delete.
4414         (inferior_thread): Pass down current inferior.
4415         (clear_thread_inferior_resources): Pass down thread pointer
4416         instead of ptid_t.
4417         (add_thread_silent, add_thread_with_info, add_thread): Add
4418         process_stratum_target parameter.  Use it for thread and inferior
4419         searches.
4420         (is_current_thread): New.
4421         (thread_info::deletable): Use it.
4422         (find_thread_ptid, thread_count, in_thread_list)
4423         (thread_change_ptid, set_resumed, set_running): New
4424         process_stratum_target parameter.  Pass it down.
4425         (set_executing): New process_stratum_target parameter.  Pass it
4426         down.  Adjust reference to 'threads_executing'.
4427         (threads_are_executing): New process_stratum_target parameter.
4428         Adjust reference to 'threads_executing'.
4429         (set_stop_requested, finish_thread_state): New
4430         process_stratum_target parameter.  Pass it down.
4431         (switch_to_thread): Also match inferior.
4432         (switch_to_thread): New process_stratum_target parameter.  Pass it
4433         down.
4434         (update_threads_executing): Reimplement.
4435         * top.c (quit_force): Pop targets from all inferior.
4436         (gdb_init): Don't call initialize_targets.
4437         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
4438         Declare.
4439         (windows_add_thread, windows_delete_thread): Adjust.
4440         (get_windows_debug_event): Rename to ...
4441         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
4442         * tracefile-tfile.c (tfile_target_open): Pass down target.
4443         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
4444         Forward declare.
4445         (switch_to_thread): Add process_stratum_target parameter.
4446         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
4447         parameter.  Use it.
4448         (mi_on_resume): Pass target down.
4449         * nat/fork-inferior.c (startup_inferior): Add
4450         process_stratum_target parameter.  Pass it down.
4451         * nat/fork-inferior.h (startup_inferior): Add
4452         process_stratum_target parameter.
4453         * python/py-threadevent.c (py_get_event_thread): Pass target down.
4454
4455 2020-01-10  Pedro Alves  <palves@redhat.com>
4456
4457         * remote.c (remote_target::start_remote): Don't set inferior_ptid
4458         directly.  Instead find the first thread in the thread list and
4459         use switch_to_thread.
4460
4461 2020-01-10  Pedro Alves  <palves@redhat.com>
4462
4463         * remote.c (remote_target::remote_add_inferior): Don't bind a
4464         process to the current inferior if the current inferior is already
4465         bound to a process.
4466
4467 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4468             Pedro Alves  <palves@redhat.com>
4469
4470         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
4471         If no process is specified, return null_ptid instead of
4472         inferior_ptid.
4473         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
4474         TARGET_WAITKIND_SIGNALLED with no pid.
4475
4476 2020-01-10  Pedro Alves  <palves@redhat.com>
4477
4478         * remote.c (first_remote_resumed_thread): New.
4479         (remote_target::wait_as): Use it as default event_ptid instead of
4480         inferior_ptid.
4481
4482 2020-01-10  Pedro Alves  <palves@redhat.com>
4483
4484         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
4485
4486 2020-01-10  Pedro Alves  <palves@redhat.com>
4487
4488         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
4489         not -1.
4490
4491 2020-01-10  Pedro Alves  <palves@redhat.com>
4492
4493         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
4494         ptid to get_last_target_status.
4495         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
4496         ptid to get_last_target_status.
4497         * infcmd.c (continue_command): Don't pass a target_waitstatus to
4498         get_last_target_status.
4499         (info_program_command): Don't pass a target_waitstatus to
4500         get_last_target_status.
4501         * infrun.c (init_wait_for_inferior): Use
4502         nullify_last_target_wait_ptid.
4503         (get_last_target_status): Handle nullptr arguments.
4504         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
4505         (print_stop_event): Don't pass a ptid to get_last_target_status.
4506         (normal_stop): Don't pass a ptid to get_last_target_status.
4507         * infrun.h (get_last_target_status, set_last_target_status): Move
4508         comments here and update.
4509         (nullify_last_target_wait_ptid): Declare.
4510         * linux-fork.c (fork_load_infrun_state): Remove local extern
4511         declaration of nullify_last_target_wait_ptid.
4512         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
4513         to get_last_target_status.
4514
4515 2020-01-10  Pedro Alves  <palves@redhat.com>
4516
4517         * gdbthread.h (scoped_restore_current_thread)
4518         <dont_restore, restore, m_dont_restore>: Declare.
4519         * thread.c (thread_alive): Add assertion.  Return bool.
4520         (switch_to_thread_if_alive): New.
4521         (prune_threads): Switch inferior/thread.
4522         (print_thread_info_1): Switch thread before calling target methods.
4523         (scoped_restore_current_thread::restore): New, factored out from
4524         ...
4525         (scoped_restore_current_thread::~scoped_restore_current_thread):
4526         ... this.
4527         (scoped_restore_current_thread::scoped_restore_current_thread):
4528         Add assertion.
4529         (thread_apply_all_command, thread_select): Use
4530         switch_to_thread_if_alive.
4531         * infrun.c (proceed, restart_threads, handle_signal_stop)
4532         (switch_back_to_stepped_thread): Switch current thread before
4533         calling target methods.
4534
4535 2020-01-10  Pedro Alves <palves@redhat.com>
4536
4537         * inferior.c (switch_to_inferior_no_thread): New function,
4538         factored out from ...
4539         (inferior_command): ... here.
4540         * inferior.h (switch_to_inferior_no_thread): Declare.
4541         * mi/mi-main.c (run_one_inferior): Use
4542         switch_to_inferior_no_thread.
4543
4544 2020-01-10  Pedro Alves  <palves@redhat.com>
4545
4546         * infcmd.c (kill_command): Remove dead code.
4547
4548 2020-01-10  Pedro Alves  <palves@redhat.com>
4549
4550         * remote.c (remote_target::mourn_inferior): No longer check
4551         whether the target is running.
4552
4553 2020-01-10  Pedro Alves  <palves@redhat.com>
4554
4555         * corelow.c (core_target::has_execution): Change parameter type to
4556         inferior pointer.
4557         * inferior.c (number_of_live_inferiors): Use
4558         inferior::has_execution instead of target_has_execution_1.
4559         * inferior.h (inferior::has_execution): New.
4560         * linux-thread-db.c (thread_db_target::update_thread_list): Use
4561         inferior::has_execution instead of target_has_execution_1.
4562         * process-stratum-target.c
4563         (process_stratum_target::has_execution): Change parameter type to
4564         inferior pointer.  Check the inferior's PID instead of
4565         inferior_ptid.
4566         * process-stratum-target.h
4567         (process_stratum_target::has_execution): Change parameter type to
4568         inferior pointer.
4569         * record-full.c (record_full_core_target::has_execution): Change
4570         parameter type to inferior pointer.
4571         * target.c (target_has_execution_1): Change parameter type to
4572         inferior pointer.
4573         (target_has_execution_current): Adjust.
4574         * target.h (target_ops::has_execution): Change parameter type to
4575         inferior pointer.
4576         (target_has_execution_1): Change parameter type to inferior
4577         pointer.  Change return type to bool.
4578         * tracefile.h (tracefile_target::has_execution): Change parameter
4579         type to inferior pointer.
4580
4581 2020-01-10  Pedro Alves  <palves@redhat.com>
4582
4583         * exceptions.c (print_flush): Remove current_top_target() check.
4584
4585 2020-01-10  Pedro Alves  <palves@redhat.com>
4586
4587         * remote.c (show_remote_exec_file): Show the current inferior's
4588         exec-file instead of the command variable's value.
4589
4590 2020-01-10  Pedro Alves  <palves@redhat.com>
4591
4592         * record-full.c (record_full_resume_ptid): New global.
4593         (record_full_target::resume): Set it.
4594         (record_full_wait_1): Use record_full_resume_ptid instead of
4595         inferior_ptid.
4596
4597 2020-01-10  Pedro Alves  <palves@redhat.com>
4598
4599         * gdbthread.h (scoped_restore_current_thread)
4600         <dont_restore, restore, m_dont_restore>: Declare.
4601         * thread.c (thread_alive): Add assertion.  Return bool.
4602         (switch_to_thread_if_alive): New.
4603         (prune_threads): Switch inferior/thread.
4604         (print_thread_info_1): Switch thread before calling target methods.
4605         (scoped_restore_current_thread::restore): New, factored out from
4606         ...
4607         (scoped_restore_current_thread::~scoped_restore_current_thread):
4608         ... this.
4609         (scoped_restore_current_thread::scoped_restore_current_thread):
4610         Add assertion.
4611         (thread_apply_all_command, thread_select): Use
4612         switch_to_thread_if_alive.
4613
4614 2020-01-10  George Barrett  <bob@bob131.so>
4615
4616         * stap-probe.c (stap_modify_semaphore): Don't check for null
4617         semaphores.
4618         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
4619         for null semaphores.
4620
4621 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4622
4623         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
4624         all source windows, and maintain horizontal scroll status while
4625         doing so.
4626
4627 2020-01-09  Tom Tromey  <tom@tromey.com>
4628
4629         PR tui/18932:
4630         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
4631         update_source_window, not print_source_lines.
4632
4633 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4634
4635         * tui/tui.c (tui_enable): Register tui hooks after calling
4636         tui_display_main.
4637
4638 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
4639
4640         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
4641
4642 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
4643
4644         * thread.c (print_thread_info_1): Fix indentation.
4645
4646 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
4647
4648         * symtab.c (general_symbol_info::compute_and_set_names): Move the
4649         unique_xmalloc_ptr outside the if to always free the demangled name.
4650
4651 2020-01-08  Tom Tromey  <tromey@adacore.com>
4652
4653         * xcoffread.c (enter_line_range, read_xcoff_symtab)
4654         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
4655         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
4656         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
4657         Remove.
4658         (section_offsets): New typedef.
4659         * symtab.c (fixup_section, get_msymbol_address): Update.
4660         * symmisc.c (dump_msymbols): Update.
4661         * symfile.h (relative_addr_info_to_section_offsets)
4662         (symfile_map_offsets_to_segments): Update.
4663         * symfile.c (build_section_addr_info_from_objfile)
4664         (init_objfile_sect_indices): Update.
4665         (struct place_section_arg): Change type of "offsets".
4666         (place_section): Update.
4667         (relative_addr_info_to_section_offsets): Change type of
4668         "section_offsets".  Remove "num_sections" parameter.
4669         (default_symfile_offsets, syms_from_objfile_1)
4670         (set_objfile_default_section_offset): Update.
4671         (reread_symbols): No need to preserve section offsets by hand.
4672         (symfile_map_offsets_to_segments): Change type of "offsets".
4673         * stap-probe.c (relocate_address): Update.
4674         * stabsread.h (process_one_symbol): Update.
4675         * solib-target.c (struct lm_info_target) <offsets>: Change type.
4676         (solib_target_relocate_section_addresses): Update.
4677         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
4678         Update.
4679         * solib-frv.c (frv_relocate_main_executable): Update.
4680         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
4681         * solib-aix.c (solib_aix_get_section_offsets): Change return
4682         type.
4683         (solib_aix_solib_create_inferior_hook): Update.
4684         * remote.c (remote_target::get_offsets): Update.
4685         * psymtab.c (find_pc_sect_psymtab): Update.
4686         * psympriv.h (struct partial_symbol) <address, text_low,
4687         text_high>: Update.
4688         * objfiles.h (obj_section_offset): Update.
4689         (struct objfile) <section_offsets>: Change type.
4690         <num_sections>: Remove.
4691         (objfile_relocate): Update.
4692         * objfiles.c (entry_point_address_query): Update
4693         (relocate_one_symbol): Change type of "section_offsets".
4694         (objfile_relocate1, objfile_relocate1): Change type of
4695         "new_offsets".
4696         (objfile_rebase1): Update.
4697         * mipsread.c (mipscoff_symfile_read): Update.
4698         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
4699         parameter.
4700         * mdebugread.c (parse_symbol): Change type of "section_offsets".
4701         (parse_external, psymtab_to_symtab_1): Update.
4702         * machoread.c (macho_symfile_offsets): Update.
4703         * ia64-tdep.c (ia64_find_unwind_table): Update.
4704         * hppa-tdep.c (read_unwind_info): Update.
4705         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
4706         * dwarf2read.c (create_addrmap_from_index)
4707         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4708         (process_psymtab_comp_unit_reader, add_partial_symbol)
4709         (add_partial_subprogram, process_full_comp_unit)
4710         (read_file_scope, read_func_scope, read_lexical_block_scope)
4711         (read_call_site_scope, dwarf2_rnglists_process)
4712         (dwarf2_ranges_process, dwarf2_ranges_read)
4713         (dwarf_decode_lines_1, var_decode_location, new_symbol)
4714         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
4715         Update.
4716         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
4717         Update.
4718         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
4719         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
4720         (process_one_symbol): Change type of "section_offsets".
4721         * ctfread.c (get_objfile_text_range): Update.
4722         * coffread.c (coff_symtab_read, enter_linenos)
4723         (process_coff_symbol): Update.
4724         * coff-pe-read.c (add_pe_forwarded_sym): Update.
4725         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
4726
4727 2020-01-08  Tom Tromey  <tromey@adacore.com>
4728
4729         * dwarf2read.c (parse_macro_definition): Use std::string.
4730         (parse_macro_definition): Likewise.
4731
4732 2020-01-08  Tom Tromey  <tromey@adacore.com>
4733
4734         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
4735         (ATTR_ALLOC_CHUNK): Remove.
4736
4737 2020-01-08  Tom Tromey  <tromey@adacore.com>
4738
4739         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
4740
4741 2020-01-08  Tom Tromey  <tromey@adacore.com>
4742
4743         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
4744         (dwarf2_compute_name, open_dwo_file): Likewise.
4745         (process_enumeration_scope): Use std::vector.
4746         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
4747         (partial_die_info::fixup, dwarf2_start_subfile)
4748         (guess_full_die_structure_name, dwarf2_name): Likewise.
4749         (determine_prefix): Update.
4750         (guess_full_die_structure_name): Make return type const.
4751         (partial_die_full_name): Return unique_xmalloc_ptr.
4752         (DW_FIELD_ALLOC_CHUNK): Remove.
4753
4754 2020-01-07  Tom Tromey  <tromey@adacore.com>
4755
4756         PR build/24937:
4757         * stap-probe.c (class stap_static_probe_ops): Add constructor.
4758
4759 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
4760
4761         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
4762
4763 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4764
4765         * stack.c (print_frame_info): Move disassemble_next_line code
4766         inside source_print block.
4767
4768 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
4769
4770         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
4771         gdb/signals.h, as we are now using native signal symbols.
4772
4773 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
4774
4775         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
4776         overflow by an early check of content vs threshold.
4777         * tui/tui-source.c (tui_source_window::line_is_displayed):
4778         Likewise.
4779
4780 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
4781
4782         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
4783
4784 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
4785
4786         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
4787         export table if no section contains it's RVA.
4788
4789 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
4790
4791         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
4792
4793 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
4794
4795         * source.c (print_source_lines_base): Set last_line_listed.
4796
4797 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
4798
4799         * tui/tui-disasm.c: Remove trailing spaces.
4800
4801 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
4802             Pedro Alves  <palves@redhat.com>
4803
4804         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
4805         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
4806         (windows_gdb_signal_to_target): New function, uses the above
4807         enumeration to convert GDB internal signal codes to equivalent
4808         Windows codes.
4809         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
4810         * windows-nat.c: Include "gdb_wait.h".
4811         (get_windows_debug_event): Extract the fatal exception from the
4812         exit status and convert to the equivalent Posix signal number.
4813         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
4814         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
4815         * gdbsupport/gdb_wait.c: New file, implements
4816         windows_status_to_termsig.
4817         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
4818         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
4819
4820 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4821
4822         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
4823         show_layout.
4824
4825 2020-01-05  Luis Machado  <luis.machado@linaro.org>
4826
4827         * aarch64-linux-nat.c
4828         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
4829         and bfd_mach_aarch64.
4830
4831 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4832
4833         * ui-file.c (stdio_file::can_emit_style_escape)
4834         (tee_file::can_emit_style_escape): Ensure style is used also on
4835         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
4836         to gdb_stdout.
4837         * main.c (set_gdb_data_directory): Use file style to output the
4838         warning that the given pathname is not a directory.
4839         * top.c (show_history_filename, gdb_safe_append_history)
4840         (show_gdb_datadir): Use file style.
4841
4842 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
4843
4844         * solib-target.c (struct lm_info_target):
4845         Change offsets to be a unique_xmalloc_ptr.
4846         (solib_target_relocate_section_addresses): Update.
4847
4848 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
4849
4850         * windows-nat.c (windows_clear_solib): Free so_list linked list.
4851
4852 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4853
4854         * MAINTAINERS (Write After Approval): Add myself.
4855
4856 2020-01-02  Luis Machado  <luis.machado@linaro.org>
4857
4858         * proc-service.c (get_ps_regcache): Remove reference to obsolete
4859         Cell BE architecture.
4860         * target.h (struct target_ops) <thread_architecture>: Likewise.
4861
4862 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
4863
4864         * Makefile.in: Use INSTALL_PROGRAM_ENV.
4865
4866 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
4867
4868         * MAINTAINERS (Write After Approval): Add myself.
4869
4870 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4871
4872         * gdbarch.sh: Update copyright year range of generated files.
4873
4874 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4875
4876         Update copyright year range in all GDB files.
4877
4878 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4879
4880         * copyright.py: Convert to Python 3.
4881
4882 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4883
4884         * copyright.py: Adapt after move of gnulib directory from gdb
4885         directory to toplevel directory.
4886
4887 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4888
4889         * copyright.py (main): Exit if run from the wrong directory.
4890
4891 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4892
4893         * top.c (print_gdb_version): Change copyright year to 2020.
4894
4895 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4896
4897         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
4898
4899 For older changes see ChangeLog-2019.
4900 \f
4901 Local Variables:
4902 mode: change-log
4903 left-margin: 8
4904 fill-column: 74
4905 version-control: never
4906 coding: utf-8
4907 End: