gdb/ChangeLog

   1 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2
   3         * NEWS: Mention new pipe command and new convenience variables.
   4
   5 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   6
   7         * cli/cli-cmds.c (pipe_command): New function.
   8         (_initialize_cli_cmds): Call add_com for pipe_command.
   9         Define | as an alias for pipe.
  10         (exit_status_set_internal_vars): New function.
  11         (shell_escape): Call exit_status_set_internal_vars.
  12         cli/cli-decode.c (find_command_name_length): Recognize | as
  13         a single character command.
  14
  15 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  16
  17         * gdbcmd.h (execute_command_to_ui_file): New declaration.
  18         top.c (execute_command_to_ui_file): New function, mostly a copy
  19         of execute_command_to_string.
  20         (execute_command_to_string): Implement by calling
  21         execute_command_to_ui_file.
  22
  23 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  24
  25         * top.h (saved_command_line): Remove declaration.
  26         * top.c (previous_saved_command_line, previous_repeat_arguments):
  27         New variables.
  28         (saved_command_line): Make static, define together with other
  29         'repeat variables'.
  30         (dont_repeat): Clear repeat_arguments.
  31         (repeat_previous, get_saved_command_line, save_command_line):
  32         New functions.
  33         (gdb_init): Initialize saved_command_line
  34         and previous_saved_command_line.
  35         * main.c (captured_main_1): Remove saved_command_line initialization.
  36         * event-top.c (handle_line_of_input): Update to use
  37         the new 'repeat' related functions instead of direct access to
  38         saved_command_line.
  39         * command.h (repeat_previous, get_saved_command_line,
  40         save_command_line): New declarations.
  41         (dont_repeat): Add comment.
  42
  43 2019-05-30  Tom Tromey  <tromey@adacore.com>
  44
  45         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
  46         Fix comment.
  47         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
  48
  49 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
  50
  51         PR cli/24587
  52         * completer.c (complete): Initialize variable word.
  53
  54 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
  55
  56         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
  57         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
  58         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
  59         'body' is NULL to the outter 'if', protecting the '!is_define'
  60         situation as well.
  61
  62 2019-05-29  Tom Tromey  <tromey@adacore.com>
  63
  64         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
  65         (dwarf_unknown): New function.
  66         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
  67         (dwarf_type_encoding_name): Use dwarf_unknown.
  68
  69 2019-05-29  Tom Tromey  <tromey@adacore.com>
  70
  71         PR c++/20020:
  72         * cp-valprint.c (cp_print_value_fields): Call
  73         cp_print_static_field inside "try".
  74
  75 2019-05-29  Tom Tromey  <tromey@adacore.com>
  76
  77         * inflow.c (struct terminal_info): Add default operator=.
  78         * configure: Rebuild.
  79         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
  80         -Wdeprecated-copy-dtor, -Wredundant-move.
  81
  82 2019-05-29  Tom Tromey  <tromey@adacore.com>
  83
  84         * NEWS: Add entry.
  85         * infcmd.c (print_return_value_1): Handle finish_print
  86         option.
  87         (show_print_finish): New function.
  88         (_initialize_infcmd): Add "set/show print finish" commands.
  89         * valprint.c (user_print_options): Initialize new member.
  90         * valprint.h (struct value_print_options) <finish_print>: New
  91         member.
  92
  93 2019-05-28  Tom Tromey  <tromey@adacore.com>
  94
  95         * ada-lang.c (ada_remove_Xbn_suffix)
  96         (find_old_style_renaming_symbol)
  97         (parse_old_style_renaming): Remove.
  98         (ada_find_renaming_symbol): Don't call
  99         find_old_style_renaming_symbol.
 100         (ada_is_renaming_symbol): Rename from
 101         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 102         bool.  Now static.
 103         (ada_read_var_value): Update and simplify.
 104         * ada-exp.y (write_var_or_type): Remove old code.
 105
 106 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 107
 108         * event-top.c: Remove include comment.
 109         * inflow.c (class scoped_ignore_sigttou): Move from here...
 110         * inflow.h (class scoped_ignore_sigttou): ...to here.
 111         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 112         * top.c:  Remove include comment.
 113
 114 2019-05-27  Tom Tromey  <tom@tromey.com>
 115
 116         * NEWS: Fix typo.
 117
 118 2019-05-22  Tom Tromey  <tromey@adacore.com>
 119
 120         * target.c (target_follow_exec): Constify parameter.
 121         * target-delegates.c: Rebuild.
 122         * remote.c (remote_target::follow_exec): Constify parameter.
 123         * infrun.c (follow_exec): Constify parameter.
 124         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 125         (target_follow_exec): Likewise.
 126
 127 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 128
 129         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 130         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 131
 132 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 133
 134         * NEWS: Add debugredirect and testsuite sections.
 135
 136 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 137
 138         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 139         target descriptions using exclusively floating point register name
 140         aliases.
 141
 142 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 143
 144         PR gdb/18644:
 145         * f-lang.c (build_fortran_types): Handle the case where
 146         gdbarch_floatformat_for_type returns a nullptr.
 147
 148 2019-05-21  Tom de Vries  <tdevries@suse.de>
 149
 150         PR cli/24587
 151         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 152
 153 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 154
 155         PR gdb/18644:
 156         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 157         16-byte floats.
 158         * i386-tdep.c (i386_floatformat_for_type): Use
 159         floatformats_ia64_quad for the 16-byte floating point component
 160         within a fortran 32-byte complex number.
 161
 162 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 163
 164         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 165         delete default constructor.
 166         (find_partial_die): Update to return const struct.
 167         (partial_die_parent_scope): Move variable declaration into scope
 168         of its use and change its type to auto.
 169         (guess_partial_die_structure_name): Likewise.
 170         (partial_die_info::fixup): Likewise.
 171
 172 2019-05-17  Tom Tromey  <tromey@adacore.com>
 173
 174         * source.c (find_and_open_source): Remove cast.
 175
 176 2019-05-17  Tom Tromey  <tromey@adacore.com>
 177
 178         * annotate.c (annotate_source): Make "filename" const.
 179         * annotate.h (annotate_source): Use const.
 180
 181 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 182
 183         * disasm.c (set_disassembler_options): Send errors to stderr.
 184
 185 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 186
 187         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 188         (cli_interp_base::set_logging): Check debug_redirect.
 189         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 190         * cli/cli-logging.c (debug_redirect): Add static variable.
 191         (pop_output_files): Add default param.
 192         (handle_redirections): Print debug setting.
 193         (show_logging_command): Likewise.
 194         (_initialize_cli_logging): Add debugredirect command.
 195         * interps.c (current_interp_set_logging): Add debug_redirect
 196         parameter.
 197         * interps.h (set_logging): Add debug_redirect parameter.
 198         (current_interp_set_logging): Likewise.
 199         * mi/mi-common.h: Likewise.
 200         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 201
 202 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 203             Tom Tromey  <tromey@adacore.com>
 204
 205         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 206         directly.
 207         * cli/cli-interp.h (make_logging_output): Remove declaration.
 208         * cli/cli-logging.c (make_logging_output): Remove function.
 209         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 210         directly.
 211         * ui-file.c (tee_file::tee_file): Remove bools.
 212         (tee_file::~tee_file): Remove deletes.
 213         * ui-file.h (tee_file): Remove bools.
 214
 215 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 216
 217         * mi/mi-cmds.h (mi_cmd_complete): New function.
 218         * mi/mi-main.c (mi_cmd_complete): Likewise.
 219         * mi/mi-cmds.c: Define new MI command -complete.
 220         * NEWS: Mention new -complete command.
 221
 222 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 223
 224         * completer.h (complete): New function.
 225         * completer.c (complete): Likewise.
 226         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 227         function defined in completer.h.
 228
 229 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 230
 231        * MAINTAINERS (Write After Approval): Add myself.
 232
 233 2019-05-17  Tom de Vries  <tdevries@suse.de>
 234
 235         PR gdb/24094
 236         * dwarf2read.c (struct cu_partial_die_info): New struct.
 237         (find_partial_die): Return cu_partial_die_info.
 238         (partial_die_parent_scope, guess_partial_die_structure_name)
 239         (partial_die_info::fixup): Handle new return type of find_partial_die.
 240
 241 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 242
 243         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 244         "std::string", simplifying the algorithm.
 245
 246 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 247
 248         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 249         (stap_static_probe_ops::get_probes): Likewise.
 250
 251 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 252
 253         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 254         '-')" and "else if".
 255         (stap_parse_single_operand): Join checks for
 256         "gdbarch_stap_parse_special_token_p" and
 257         "gdbarch_stap_parse_special_token" in the same "if" statement.
 258         Invert check when verifying for operation on register
 259         displacement.
 260
 261 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 262
 263         * stap-probe.c (stap_get_opcode): Update comment.
 264         (stap_get_expected_argument_type): Likewise.
 265         (handle_stap_probe): Likewise.
 266
 267 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 268
 269         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 270         return type to 'bool'.  Adjust comment.  Use 'bool' when
 271         appropriate.
 272         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 273         * stap-probe.c (stap_parse_argument_1): Likewise.
 274         (stap_is_operator): Likewise.
 275         (stap_is_generic_prefix): Likewise.
 276         (stap_is_register_prefix): Likewise.
 277         (stap_is_register_indirection_prefix): Likewise.
 278         (stap_is_integer_prefix): Likewise.
 279         (stap_generic_check_suffix): Likewise.
 280         (stap_check_integer_suffix): Likewise.
 281         (stap_check_register_suffix): Likewise.
 282         (stap_check_register_indirection_suffix): Likewise.
 283         (stap_parse_register_operand): Likewise.
 284         (stap_parse_single_operand): Likewise.
 285         (stap_parse_argument_1): Likewise.
 286         (stap_probe::get_argument_count): Likewise.
 287         (stap_is_operator): Likewise.
 288
 289 2019-05-16  Tom Tromey  <tromey@adacore.com>
 290
 291         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 292         keyword to foreach.
 293
 294 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 295
 296         * linux-thread-db.c (try_thread_db_load_1): Change return type
 297         to bool.
 298         (try_thread_db_load): Likewise.
 299         (try_thread_db_load_from_pdir_1): Likewise.
 300         (try_thread_db_load_from_pdir): Likewise.
 301         (try_thread_db_load_from_sdir): Likewise.
 302         (try_thread_db_load_from_dir): Likewise.
 303         (thread_db_load_search): Likewise.
 304         (has_libpthread): Likewise.
 305         (thread_db_load): Likewise.
 306
 307 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 308
 309         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 310         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 311         NULL, and complain/return if that's the case.
 312
 313 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 314
 315         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 316         (advance, posn, abstract_read_memory): New functions.
 317         [struct mem_read_abstraction]: New struct.
 318         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 319
 320 2019-05-14  Tom Tromey  <tromey@adacore.com>
 321
 322         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 323         value is not lval_memory.
 324
 325 2019-05-14  Tom Tromey  <tromey@adacore.com>
 326
 327         * solib.c (info_sharedlibrary_command): Style the file name.
 328
 329 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 330
 331         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 332         (aarch64_vnv_type): Likewise.
 333         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 334         * common/tdesc.c: Likewise.
 335         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 336         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 337         * features/aarch64-fpu.xml: Add ieee half view.
 338         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 339         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 340         * gdbtypes.h (struct builtin_type): Likewise.
 341         (struct objfile_type): Likewise.
 342
 343 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 344
 345         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 346         typo.
 347         * location.h (string_to_event_location): Likewise.
 348
 349 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 350
 351         GDB 8.3 released.
 352
 353 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 354
 355         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 356         New variable declaration.
 357         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 358         New variable.
 359         (print_one_breakpoint): Use ui_out::test_flags and new global
 360         variable to compute use_fixed_output.
 361         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 362         Remove.
 363         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 364         (mi_multi_location_breakpoint_output_fixed): Remove.
 365         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 366         new variable.
 367         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 368         fix_multi_location_breakpoint_output flag if version >= 3.
 369         * ui-out.h (enum ui_out_flag)
 370         <fix_multi_location_breakpoint_output>: New enumerator.
 371
 372 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 373
 374         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 375
 376 2019-05-10  Tom Tromey  <tromey@adacore.com>
 377
 378         * ada-lang.c (catch_ada_completer): New function.
 379         (_initialize_ada_language): Use it.
 380
 381 2019-05-10  Tom Tromey  <tromey@adacore.com>
 382
 383         * thread.c (print_thread_info): Make "requested_threads" const.
 384         * gdbthread.h (print_thread_info): Make "requested_threads"
 385         const.
 386         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 387         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 388
 389 2019-05-08  Tom Tromey  <tom@tromey.com>
 390
 391         * gdbtypes.c (objfile_type_data): Change type.
 392         (objfile_type, _initialize_gdbtypes): Update.
 393
 394 2019-05-08  Tom Tromey  <tom@tromey.com>
 395
 396         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 397         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 398         (_initialize_dwarf2_frame): Update.
 399
 400 2019-05-08  Tom Tromey  <tom@tromey.com>
 401
 402         * objc-lang.c (objc_objfile_data): Change type.
 403         (find_methods): Update.
 404         (_initialize_objc_lang): Remove.
 405
 406 2019-05-08  Tom Tromey  <tom@tromey.com>
 407
 408         * stabsread.c (rs6000_builtin_type_data): Change type.
 409         (rs6000_builtin_type, _initialize_stabsread): Update.
 410
 411 2019-05-08  Tom Tromey  <tom@tromey.com>
 412
 413         * mips-tdep.c (mips_pdr_data): Remove.
 414         (_initialize_mips_tdep): Update.
 415
 416 2019-05-08  Tom Tromey  <tom@tromey.com>
 417
 418         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 419         (hppa_init_objfile_priv_data, read_unwind_info)
 420         (find_unwind_entry, _initialize_hppa_tdep): Update.
 421
 422 2019-05-08  Tom Tromey  <tom@tromey.com>
 423
 424         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 425         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 426         on obstack.
 427         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 428
 429 2019-05-08  Tom Tromey  <tom@tromey.com>
 430
 431         * mdebugread.c (basic_type_data): Change type.
 432         (basic_type, _initialize_mdebugread): Update.
 433
 434 2019-05-08  Tom Tromey  <tom@tromey.com>
 435
 436         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 437
 438 2019-05-08  Tom Tromey  <tom@tromey.com>
 439
 440         * nto-tdep.c (nto_inferior_data_reg): Change type.
 441         (nto_inferior_data): Update.
 442         (nto_inferior_data_cleanup, nto_new_inferior_data)
 443         (_initialize_nto_tdep): Remove.
 444         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 445
 446 2019-05-08  Tom Tromey  <tom@tromey.com>
 447
 448         * ada-lang.c (struct ada_inferior_data): Add initializers.
 449         (ada_inferior_data): Change type.
 450         (ada_inferior_data_cleanup): Remove.
 451         (get_ada_inferior_data, ada_inferior_exit)
 452         (struct ada_pspace_data): Add initializers, destructor.
 453         (ada_pspace_data_handle): Change type.
 454         (get_ada_pspace_data): Update.
 455         (ada_pspace_data_cleanup): Remove.
 456
 457 2019-05-08  Tom Tromey  <tom@tromey.com>
 458
 459         * coffread.c (struct coff_symfile_info): Add initializers.
 460         (coff_objfile_data_key): Move lower.  Change type.
 461         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 462         Update.
 463         (coff_free_info): Remove.
 464
 465 2019-05-08  Tom Tromey  <tom@tromey.com>
 466
 467         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 468         (fbsd_pspace_data_handle): Move lower.  Change type.
 469         (get_fbsd_pspace_data): Update.
 470         (fbsd_pspace_data_cleanup): Remove.
 471         (_initialize_fbsd_tdep): Update.
 472
 473 2019-05-08  Tom Tromey  <tom@tromey.com>
 474
 475         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 476         (get_ada_tasks_pspace_data): Update.
 477         (ada_tasks_pspace_data_cleanup): Remove.
 478         (_initialize_tasks): Update.
 479         (ada_tasks_inferior_data_handle): Change type.
 480         (get_ada_tasks_inferior_data): Update.
 481         (ada_tasks_inferior_data_cleanup): Remove.
 482         (struct ada_tasks_pspace_data): Add initializers.
 483
 484 2019-05-08  Tom Tromey  <tom@tromey.com>
 485
 486         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 487         * symfile-debug.c (debug_sym_get_probes): Change type.
 488         * stap-probe.c (handle_stap_probe):
 489         (stap_static_probe_ops::get_probes): Change type.
 490         * probe.h (class static_probe_ops) <get_probes>: Change type.
 491         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 492         (parse_probes_in_pspace): Update.
 493         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 494         Update.
 495         (any_static_probe_ops::get_probes): Change type.
 496         * elfread.c (elfread_data): New typedef.
 497         (probe_key): Change type.
 498         (elf_get_probes): Likewise.  Update.
 499         (probe_key_free): Remove.
 500         (_initialize_elfread): Update.
 501         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 502         Change type.
 503         (dtrace_process_dof_probe, dtrace_process_dof)
 504         (dtrace_static_probe_ops::get_probe): Change type.
 505
 506 2019-05-08  Tom Tromey  <tom@tromey.com>
 507
 508         * xcoffread.c (struct xcoff_symfile_info): Rename from
 509         coff_symfile_info.  Add initializers.
 510         (xcoff_objfile_data_key): Move lower.  Change type.
 511         (XCOFF_DATA): Rewrite.
 512         (xcoff_free_info): Remove.
 513         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 514         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 515         (xcoff_initial_scan): Update.
 516
 517 2019-05-08  Tom Tromey  <tom@tromey.com>
 518
 519         * solib-svr4.c (struct svr4_info): Add initializers and
 520         destructor.
 521         <probes_table>: Now an htab_up.
 522         (solib_svr4_pspace_data): Change type.
 523         (free_probes_table): Simplify.
 524         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 525         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 526         (probes_table_remove_objfile_probes, register_solib_event_probe)
 527         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 528         (_initialize_svr4_solib): Update.
 529
 530 2019-05-08  Tom Tromey  <tom@tromey.com>
 531
 532         * remote.c (remote_pspace_data): Change type.
 533         (remote_pspace_data_cleanup): Remove.
 534         (get_remote_exec_file, set_pspace_remote_exec_file)
 535         (_initialize_remote): Update.
 536
 537 2019-05-08  Tom Tromey  <tom@tromey.com>
 538
 539         * breakpoint.c (breakpoint_objfile_key): Change type.
 540         (get_breakpoint_objfile_data): Update.
 541         (free_breakpoint_objfile_data): Remove.
 542         (_initialize_breakpoint): Update.
 543
 544 2019-05-08  Tom Tromey  <tom@tromey.com>
 545
 546         * linux-tdep.c (struct linux_info): Add initializers.
 547         (linux_inferior_data): Move.  Change type.
 548         (invalidate_linux_cache_inf): Update.
 549         (linux_inferior_data_cleanup): Remove.
 550         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 551
 552 2019-05-08  Tom Tromey  <tom@tromey.com>
 553
 554         * auxv.c (auxv_inferior_data): Move.  Change type.
 555         (auxv_inferior_data_cleanup): Remove.
 556         (invalidate_auxv_cache_inf): Rewrite.
 557         (get_auxv_inferior_data, _initialize_auxv): Update.
 558
 559 2019-05-08  Tom Tromey  <tom@tromey.com>
 560
 561         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 562         (symfile_debug_objfile_data_key): Change type.
 563         (symfile_debug_installed, debug_qf_has_symbols)
 564         (debug_qf_find_last_source_symtab)
 565         (debug_qf_forget_cached_source_info)
 566         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 567         (debug_qf_print_stats, debug_qf_dump)
 568         (debug_qf_expand_symtabs_for_function)
 569         (debug_qf_expand_all_symtabs)
 570         (debug_qf_expand_symtabs_with_fullname)
 571         (debug_qf_map_matching_symbols)
 572         (debug_qf_expand_symtabs_matching)
 573         (debug_qf_find_pc_sect_compunit_symtab)
 574         (debug_qf_map_symbol_filenames)
 575         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 576         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 577         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 578         (debug_sym_read_linetable, debug_sym_relocate): Update.
 579         (symfile_debug_free_objfile): Remove.
 580         (install_symfile_debug_logging, _initialize_symfile_debug):
 581         Update.
 582
 583 2019-05-08  Tom Tromey  <tom@tromey.com>
 584
 585         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 586         allocate_on_obstack.
 587         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 588         (get_dwarf2_per_objfile): Update.
 589         (set_dwarf2_per_objfile): Remove.
 590         (dwarf2_has_info, dwarf2_get_section_info): Update.
 591         (dwarf2_free_objfile): Remove.
 592         (_initialize_dwarf2_read): Update.
 593
 594 2019-05-08  Tom Tromey  <tom@tromey.com>
 595
 596         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 597         initializers.
 598         <unsupported_script_warning_printed,
 599         script_not_found_warning_printed>: Now bool.
 600         (auto_load_pspace_data): Change type.
 601         (~auto_load_pspace_info): Rename from
 602         auto_load_pspace_data_cleanup.
 603         (get_auto_load_pspace_data, init_loaded_scripts_info)
 604         (clear_section_scripts, maybe_print_unsupported_script_warning)
 605         (maybe_print_script_not_found_warning, _initialize_auto_load):
 606         Update.
 607
 608 2019-05-08  Tom Tromey  <tom@tromey.com>
 609
 610         * objfiles.c (objfile_pspace_info): Add destructor and
 611         initializers.
 612         (objfiles_pspace_data): Change type.
 613         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 614         (get_objfile_pspace_data): Update.
 615         (objfiles_bfd_data): Change type.
 616         (get_objfile_bfd_data): Update.
 617         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 618
 619 2019-05-08  Tom Tromey  <tom@tromey.com>
 620
 621         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 622         Change type.
 623         (get_catch_syscall_inferior_data): Update.
 624         (catch_syscall_inferior_data_cleanup): Remove.
 625         (_initialize_break_catch_syscall): Update.
 626
 627 2019-05-08  Tom Tromey  <tom@tromey.com>
 628
 629         * inflow.c (struct terminal_info): Add destructor and
 630         initializers.
 631         (inflow_inferior_data): Change type.
 632         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 633         (get_inflow_inferior_data, inflow_inferior_exit)
 634         (swap_terminal_info, _initialize_inflow): Update.
 635
 636 2019-05-08  Tom Tromey  <tom@tromey.com>
 637
 638         * target-dcache.c (target_dcache_cleanup): Remove.
 639         (target_dcache_aspace_key): Change type.
 640         (target_dcache_init_p, target_dcache_invalidate)
 641         (target_dcache_get, target_dcache_get_or_init)
 642         (_initialize_target_dcache): Update.
 643         * dcache.h (struct dcache_deleter): New.
 644
 645 2019-05-08  Tom Tromey  <tom@tromey.com>
 646
 647         * symtab.c (struct symbol_cache): Add destructor and
 648         initializers.
 649         (symbol_cache_key): Move.  Change type.
 650         (make_symbol_cache, free_symbol_cache): Remove.
 651         (get_symbol_cache): Update.
 652         (symbol_cache_cleanup): Remove.
 653         (ALL_PSPACES, symbol_cache_flush)
 654         (maintenance_print_symbol_cache)
 655         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 656         Update.
 657
 658 2019-05-08  Tom Tromey  <tom@tromey.com>
 659
 660         * symtab.c (struct main_info): Add destructor and initializers.
 661         (main_progspace_key): Move.  Change type.
 662         (get_main_info): Update.
 663         (main_info_cleanup): Remove.
 664         (_initialize_symtab): Update.
 665
 666 2019-05-08  Tom Tromey  <tom@tromey.com>
 667
 668         * registry.h (DECLARE_REGISTRY): Define the _key class.
 669
 670 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 671
 672         * NEWS: Merge two 'New commands' sections.
 673
 674 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 675
 676         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 677         parameter and use Ada language definition instead.
 678         (ada_val_print_ptr): Remove unused language parameter.
 679         (ada_val_print_num): Remove language parameter and use Ada language
 680         definition instead.
 681         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 682         parameter.
 683         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 684         parameter and use Ada language definition instead.
 685         (ada_val_print_1): Update all ada_val_print_xxx calls.
 686         Remove language parameter.
 687         (ada_val_print): Update ada_val_print_1 call.
 688
 689 2019-05-08  Tom Tromey  <tromey@adacore.com>
 690
 691         * remote.c (remote_hw_watchpoint_limit)
 692         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 693         Now static.
 694
 695 2019-05-08  Tom Tromey  <tromey@adacore.com>
 696
 697         * maint.c (_initialize_maint_cmds): Move initialization code to
 698         remote.c.
 699         (watchdog, show_watchdog): Move to remote.c.
 700         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 701         "watchdog" static.
 702         (_initialize_remote): Move initialization code from maint.c.
 703         * defs.h (watchdog): Don't declare.
 704
 705 2019-05-08  Tom Tromey  <tromey@adacore.com>
 706
 707         * tui/tui-interp.c: Include main.h.
 708         * interps.c: Include main.h.
 709         * main.h (interpreter_p): Declare.
 710         * defs.h (interpreter_p): Don't declare.
 711
 712 2019-05-08  Tom Tromey  <tromey@adacore.com>
 713
 714         * dwarf2loc.c: Include dwarf2read.h.
 715         * defs.h (read_unsigned_leb128): Don't declare.
 716         * dwarf2read.h (read_unsigned_leb128): Declare.
 717
 718 2019-05-08  Tom Tromey  <tromey@adacore.com>
 719
 720         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 721         method.
 722
 723 2019-05-08  Tom Tromey  <tromey@adacore.com>
 724
 725         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 726         when no wrap column is set.
 727
 728 2019-05-08  Tom Tromey  <tromey@adacore.com>
 729
 730         * c-lang.c (c_get_string): Handle non-C-style arrays.
 731
 732 2019-05-08  Tom Tromey  <tromey@adacore.com>
 733
 734         * typeprint.c (print_offset_data::update): Print the bit offset,
 735         not the number of bits remaining.
 736
 737 2019-05-08  Tom Tromey  <tromey@adacore.com>
 738
 739         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 740         padding at end of comment.
 741
 742 2019-05-08  Tom Tromey  <tromey@adacore.com>
 743
 744         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 745         Compare main types.
 746
 747 2019-05-06  Tom Tromey  <tom@tromey.com>
 748
 749         * common/scoped_mmap.c: Include common-defs.h.
 750         * common/scoped_mmap.h: Don't include config.h.
 751
 752 2019-05-04  Tom Tromey  <tom@tromey.com>
 753
 754         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 755         (struct aarch64_call_info): Add initializers.
 756         <si>: Now a std::vector.
 757         (pass_on_stack, aarch64_push_dummy_call): Update.
 758
 759 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 760             Tom Tromey  <tom@tromey.com>
 761
 762         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 763         (ppc_threads): Now a std::vector.  Now static.
 764         (hwdebug_find_thread_points_by_tid)
 765         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 766         Update.
 767
 768 2019-05-04  Tom Tromey  <tom@tromey.com>
 769
 770         * arc-tdep.c (arc_tdesc_init): Return bool.
 771
 772 2019-05-04  Tom Tromey  <tom@tromey.com>
 773
 774         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 775         Use gdb_assert_not_reached.
 776
 777 2019-05-04  Tom Tromey  <tom@tromey.com>
 778
 779         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 780         "false".
 781
 782 2019-05-04  Tom Tromey  <tom@tromey.com>
 783
 784         * arc-tdep.c (arc_tdesc_init): Use bool.
 785
 786 2019-05-04  Tom Tromey  <tom@tromey.com>
 787
 788         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 789
 790 2019-05-04  Tom Tromey  <tom@tromey.com>
 791
 792         * cli/cli-cmds.c (valid_command_p): Return bool.
 793
 794 2019-05-04  Tom Tromey  <tom@tromey.com>
 795
 796         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 797         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 798
 799 2019-05-04  Raul Tambre  <raul@tambre.ee>
 800
 801         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 802         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 803         operator for comparison.
 804
 805 2019-05-04  Tom Tromey  <tom@tromey.com>
 806
 807         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 808         (lookup_partial_symbol, print_partial_symbols)
 809         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 810         (psymbol_compare): Update.
 811         (add_psymbol_to_bcache): Clear the entire psymbol.
 812         (maintenance_check_psymtabs): Update.
 813         * psympriv.h (struct partial_symbol): Don't derive from
 814         general_symbol_info.
 815         <obj_section, unrelocated_address, address,
 816         set_unrelocated_address>: Update.
 817         <ginfo>: New member.
 818         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 819         (debug_names::write_psymbols): Update.
 820
 821 2019-05-04  Tom de Vries  <tdevries@suse.de>
 822
 823         * contrib/cc-with-tweaks.sh: Support -n arg.
 824
 825 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 826
 827         * corelow.c (core_target::detach): Ensure frame cache and
 828         register caches are cleared.
 829         inferior.c (exit_inferior_1): Likewise.
 830
 831 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 832             Tom Tromey  <tom@tromey.com>
 833
 834         * dictionary.c (collate_pending_symbols_by_language): Remove
 835         "struct" from foreach.
 836         * symtab.c (lookup_global_symbol_from_objfile)
 837         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 838         foreach.
 839         * ser-tcp.c (net_open): Remove "struct" from foreach.
 840         * objfiles.c (objfile_relocate, objfile_rebase)
 841         (objfile_has_symbols): Remove "struct" from foreach.
 842         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 843         from foreach.
 844         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 845         foreach.
 846         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 847         "struct" from foreach.
 848         * ada-lang.c (create_excep_cond_exprs)
 849         (ada_exception_catchpoint_cond_string): Remove "struct" from
 850         foreach.
 851
 852 2019-05-03  Tom Tromey  <tromey@adacore.com>
 853
 854         * ada-exp.y (convert_char_literal): Check suffix of each
 855         enumerator.
 856
 857 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 858
 859         PR ada/21406:
 860         * ada-exp.y (yywrap): Don't define.
 861         * ada-lex.l (%option): Add noyywrap
 862         (yywrap): Remove.
 863
 864 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 865
 866         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 867         _WIN32_WINNT to the XP level, unless already defined to a higher
 868         level.
 869
 870         * unittests/parse-connection-spec-selftests.c:
 871         * ser-tcp.c:
 872         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 873         override.
 874
 875         * symfile.c (find_separate_debug_file): Remove colon from the
 876         drive spec of DOS/Windows file names of the target, so that the
 877         file name produced from DEBUGDIR and the target's directory will
 878         be valid on DOS/Windows systems.
 879
 880 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 881
 882         * rust-lang.c (val_print_struct): Handle printing structures
 883         containing strings.
 884
 885 2019-05-02  Tom Tromey  <tromey@adacore.com>
 886
 887         * valarith.c (_initialize_valarith): Remove.
 888
 889 2019-05-01  Tom Tromey  <tromey@adacore.com>
 890
 891         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 892         bitfields.
 893
 894 2019-05-01  Tom Tromey  <tromey@adacore.com>
 895
 896         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 897         for big-endian copies.
 898
 899 2019-04-30  Ali Tamur  <tamur@google.com>
 900         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 901         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 902         (read_3_bytes): New function.
 903
 904 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 905
 906         * windows-nat.c (main_thread_id): Delete.
 907         (handle_output_debug_string): Replace main_thread_id by
 908         current_event.dwThreadId.
 909         (fake_create_process): Likewise.
 910         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 911         Do not set main_thread_id.
 912         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 913         current_event.dwThreadId.
 914         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 915
 916 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 917
 918         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 919         Use current_event.dwThreadId instead of main_thread_id.
 920
 921 2019-04-30  Tom Tromey  <tromey@adacore.com>
 922
 923         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 924         (create_excep_cond_exprs): Iterate over program spaces.
 925         (ada_exception_catchpoint_cond_string): Examine all minimal
 926         symbols for exception types.
 927
 928 2019-04-30  Tom Tromey  <tromey@adacore.com>
 929
 930         PR c++/24470:
 931         * dwarf2read.c (process_structure_scope): Handle case where type
 932         has template parameters but no symbol was created.
 933
 934 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 935             Chris January  <chris.january@arm.com>
 936
 937         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 938         qualifier.
 939         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 940
 941 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 942
 943         * f-typeprint.c (f_print_type): Update rules for printing
 944         whitespace.
 945         (f_type_print_varspec_suffix): Likewise.
 946
 947 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 948             Chris January  <chris.january@arm.com>
 949
 950         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 951         function arguments.
 952
 953 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 954
 955         * f-lang.c (build_fortran_types): Change name of void type to
 956         lower case.
 957         * f-typeprint.c (f_type_print_base): Print the name of the void
 958         type, rather than a fixed string.
 959         * f-valprint.c (f_decorations): Use lower case void string.
 960
 961 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 962             Chris January  <chris.january@arm.com>
 963
 964         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 965         types for Fortran.
 966
 967 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 968             Chris January  <chris.january@arm.com>
 969             David Lecomber  <david.lecomber@arm.com>
 970
 971         * f-exp.y (BINOP_INTRINSIC): New token.
 972         (exp): New parser rule handling BINOP_INTRINSIC.
 973         (f77_keywords): Add new builtin procedures.
 974         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 975         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 976         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 977         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 978         (print_unop_subexp_f): New function.
 979         (print_binop_subexp_f): New function.
 980         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 981         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 982         (dump_subexp_body_f): Likewise.
 983         (operator_check_f): Likewise.
 984         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 985         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 986
 987 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 988
 989         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 990         UNOP_KIND.
 991         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 992         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 993         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 994         (operator_length_f): New fuction.
 995         (print_subexp_f): New function.
 996         (op_name_f): New function.
 997         (dump_subexp_body_f): New function.
 998         (operator_check_f): New function.
 999         (exp_descriptor_f): Replace standard expression handling functions
1000         with new functions.
1001         * gdb/fortran-operator.def: New file.
1002         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1003         * gdb/std-operator.def: Remove UNOP_KIND.
1004
1005 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1006
1007         * std-operator.def: Remove unbalanced, stray double quote
1008         character.
1009
1010 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1011             Chris January  <chris.january@arm.com>
1012             Daniel Everett  <daniel.everett@arm.com>
1013             Nick Forrington  <nick.forrington@arm.com>
1014             Richard Bunt  <richard.bunt@arm.com>
1015
1016         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1017         of depth when printing anonymous structs or unions.
1018         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1019         Don't print either the top-level value, or the children if the
1020         max-depth is exceeded.
1021         (ppscm_print_children): When printing the key of a map, allow one
1022         extra level of depth.
1023         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1024         print either the top-level value, or the children if the max-depth
1025         is exceeded.
1026         (print_children): When printing the key of a map, allow one extra
1027         level of depth.
1028         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1029         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1030         (user_print_options): Initialise max_depth field.
1031         (val_print_scalar_or_string_type_p): New function.
1032         (val_print): Check to see if the max depth has been reached.
1033         (val_print_check_max_depth): Define new function.
1034         (show_print_max_depth): New function.
1035         (_initialize_valprint): Add 'print max-depth' option.
1036         * valprint.h (struct value_print_options) <max_depth>: New field.
1037         (val_print_check_max_depth): Declare new function.
1038         * NEWS: Document new feature.
1039
1040 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1041
1042         * ada-lang.c (ada_language_defn): Initialise new field.
1043         * c-lang.c (c_is_string_type_p): New function.
1044         (c_language_defn): Initialise new field.
1045         (cplus_language_defn): Initialise new field.
1046         (asm_language_defn): Initialise new field.
1047         (minimal_language_defn): Initialise new field.
1048         * c-lang.h (c_is_string_type_p): Declare new function.
1049         * d-lang.c (d_language_defn): Initialise new field.
1050         * f-lang.c (f_is_string_type_p): New function.
1051         (f_language_defn): Initialise new field.
1052         * go-lang.c (go_is_string_type_p): New function.
1053         (go_language_defn): Initialise new field.
1054         * language.c (default_is_string_type_p): New function.
1055         (unknown_language_defn): Initialise new field.
1056         (auto_language_defn): Initialise new field.
1057         * language.h (struct language_defn) <la_is_string_type_p>: New
1058         member variable.
1059         (default_is_string_type_p): Declare new function.
1060         * m2-lang.c (m2_language_defn): Initialise new field.
1061         * objc-lang.c (objc_language_defn): Initialise new field.
1062         * opencl-lang.c (opencl_language_defn): Initialise new field.
1063         * p-lang.c (pascal_is_string_type_p): New function.
1064         (pascal_language_defn): Initialise new field.
1065         * rust-lang.c (rust_is_string_type_p): New function.
1066         (rust_language_defn): Initialise new field.
1067
1068 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1069
1070         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1071         New field.
1072         * ada-lang.c (ada_language_defn): Initialise new field.
1073         * c-lang.c (c_language_defn): Likewise.
1074         (cplus_language_defn): Likewise.
1075         (asm_language_defn): Likewise.
1076         (minimal_language_defn): Likewise.
1077         * d-lang.c (d_language_defn): Likewise.
1078         * f-lang.c (f_language_defn): Likewise.
1079         * go-lang.c (go_language_defn): Likewise.
1080         * language.c (unknown_language_defn): Likewise.
1081         (auto_language_defn): Likewise.
1082         * m2-lang.c (m2_language_defn): Likewise.
1083         * objc-lang.c (objc_language_defn): Likewise.
1084         * opencl-lang.c (opencl_language_defn): Likewise.
1085         * p-lang.c (pascal_language_defn): Likewise.
1086         * rust-lang.c (rust_language_defn): Likewise.
1087
1088 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1089
1090         * ada-lang.c (ada_is_character_type): Change return type to bool.
1091         (ada_is_string_type): Likewise.
1092         * ada-lang.h (ada_is_character_type): Update declaration
1093         (ada_is_string_type): Likewise.
1094
1095 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1096
1097         Support style in 'frame|thread apply'
1098
1099         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1100         * record.c (record_start, record_stop): Update callers of
1101         execute_command_to_string with false.
1102         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1103         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1104         methods.
1105         (class string_file): New constructor with term_out parameter.
1106         Override methods term_out and can_emit_style_escape.  New member
1107         term_out.
1108         (class stdio_file): Override can_emit_style_escape.
1109         (class tee_file): Override term_out and can_emit_style_escape.
1110         * utils.h (can_emit_style_escape): Remove.
1111         * utils.c (can_emit_style_escape): Likewise.
1112         Update all callers of can_emit_style_escape (SOMESTREAM) to
1113         SOMESTREAM->can_emit_style_escape.
1114         * source-cache.c (source_cache::get_source_lines): Likewise.
1115         * stack.c (frame_apply_command_count): Call execute_command_to_string
1116         passing the term_out characteristic of the current gdb_stdout.
1117         * thread.c (thr_try_catch_cmd): Likewise.
1118         * top.c (execute_command_to_string): pass term_out parameter
1119         to construct the string_file for the command output.
1120         * ui-file.c (term_cli_styling): New function (most code moved
1121         from utils.c can_emit_style_escape).
1122         (string_file::string_file, string_file::can_emit_style_escape,
1123         stdio_file::can_emit_style_escape, tee_file::term_out,
1124         tee_file::can_emit_style_escape): New functions.
1125
1126 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1127
1128         * NEWS: Mention the new set|show may-call-functions.
1129         * infcall.c (may_call_functions_p): New variable.
1130         (show_may_call_functions_p): New function.
1131         (call_function_by_hand_dummy): Throws an error if not
1132         may-call-functions.
1133         (_initialize_infcall): Call add_setshow_boolean_cmd for
1134         may-call-functions.
1135
1136 2019-04-25  Keith Seitz  <keiths@redhat.com>
1137
1138         PR c++/24367
1139         * cp-support.c (inspect_type): Don't attempt substitutions
1140         of symbol with the same name.
1141
1142 2019-04-25  Tom Tromey  <tromey@adacore.com>
1143
1144         PR gdb/24475:
1145         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1146         static.
1147
1148 2019-04-25  Tom Tromey  <tromey@adacore.com>
1149
1150         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1151         rvalue reference.
1152         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1153         (gdb_xml_parser::parse): Use std::move.
1154         * python/python-internal.h (gdbpy_convert_exception): Take a const
1155         reference.
1156         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1157         std::move.
1158         * python/py-utils.c (gdbpy_convert_exception): Take a const
1159         reference.
1160         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1161         Use std::move.
1162         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1163         Use std::move.
1164         * mi/mi-main.c (mi_print_exception): Take a const reference.
1165         * main.c (handle_command_errors): Take a const reference.
1166         * linespec.c (parse_linespec): Use std::move.
1167         * infcall.c (run_inferior_call): Use std::move.
1168         (call_function_by_hand_dummy): Use std::move.
1169         * exec.c (try_open_exec_file): Use std::move.
1170         * exceptions.h (exception_print, exception_fprintf)
1171         (exception_print_same): Update.
1172         * exceptions.c (print_exception, exception_print)
1173         (exception_fprintf, exception_print_same): Change parameters to
1174         const reference.
1175         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1176         * common/new-op.c: Use std::move.
1177         * common/common-exceptions.h (struct gdb_exception): Add move
1178         constructor.
1179         (struct gdb_exception_error, struct gdb_exception_quit, struct
1180         gdb_quit_bad_alloc): Change constructor to move constructor.
1181         (throw_exception): Change parameter to rvalue reference.
1182         * common/common-exceptions.c (throw_exception): Take rvalue
1183         reference.
1184         * cli/cli-interp.c (safe_execute_command): Use std::move.
1185         * breakpoint.c (insert_bp_location, location_to_sals): Use
1186         std::move.
1187
1188 2019-04-25  Tom Tromey  <tromey@adacore.com>
1189
1190         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1191         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1192         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1193         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1194         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1195         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1196         guile/scm-value.c: Use unpack.
1197         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1198         gdbscm_gdb_exception.
1199         (gdbscm_throw_gdb_exception): Likewise.
1200         (struct gdbscm_gdb_exception): New.
1201         (unpack): New function.
1202         (gdbscm_wrap): Use unpack.
1203
1204 2019-04-25  Tom Tromey  <tromey@adacore.com>
1205
1206         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1207         (gdb_rl_callback_handler): Use std::move.
1208         * common/common-exceptions.h (struct gdb_exception): Add move
1209         assignment operator.
1210         (throw_exception_sjlj): Change "exception" to const reference.
1211         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1212         (throw_exception_sjlj): Change "exception" to const reference.
1213
1214 2019-04-25  Tom Tromey  <tromey@adacore.com>
1215
1216         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1217         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1218         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1219         Update.
1220         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1221         Update.
1222         * mi/mi-interp.c (mi_interp::exec): Update.
1223         * linespec.c (parse_linespec): Update.
1224         * infcall.c (run_inferior_call): Update.
1225         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1226         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1227         (gdbscm_lookup_global_symbol): Update.
1228         * guile/scm-param.c (gdbscm_parameter_value): Update.
1229         * guile/scm-frame.c (gdbscm_frame_read_register)
1230         (gdbscm_frame_read_var): Update.
1231         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1232         * exec.c (try_open_exec_file): Update.
1233         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1234         (gdb_rl_callback_handler): Update.
1235         * common/common-exceptions.h (exception_none): Don't declare.
1236         * common/common-exceptions.c (exception_none): Don't define.
1237         (struct catcher) <exception>: Update.
1238         * cli/cli-interp.c (safe_execute_command): Update.
1239         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1240
1241 2019-04-25  Ali Tamur  <tamur@google.com>
1242
1243         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1244         (read_attribute_value): Likewise.
1245         (dwarf2_read_addr_index): Update comment.
1246         (read_str_index): Add DW_FORM_strx.
1247         (dwarf2_string_attr): Likewise.
1248         (dwarf2_const_value_attr): Likewise.
1249         (dump_die_shallow): Likewise.
1250         (dwarf2_fetch_constant_bytes): Likewise.
1251         (skip_form_bytes): Likewise.
1252         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1253
1254 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1255
1256         PR corefiles/11608
1257         PR corefiles/18187
1258         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1259         OFFSET.  Verify if current mapping contains an ELF header.
1260         (linux_find_memory_regions_full): Adjust call to
1261         dump_mapping_p.
1262
1263 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1264             Kang Li <kanglictf@gmail.com>
1265
1266         PR gdb/21600
1267
1268         * dwarf2-frame.c (read_initial_length): Be consistent about using
1269         unsigned representation of length.
1270         (decode_frame_entry_1): Likewise.  Check for wraparound of
1271         end pointer as well as buffer overflow.
1272
1273 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1274
1275         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1276         "vq".
1277
1278 2019-04-24  Tom Tromey  <tromey@adacore.com>
1279
1280         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1281
1282 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1283
1284         * s12z-tdep.c (s12z_unwind_pc): Delete.
1285         (s12z_unwind_sp): Delete.
1286         (s12z_gdbarch_init): Don't register deleted functions with
1287         gdbarch.
1288
1289 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1290
1291         * rl78-tdep.c (rl78_unwind_sp): Delete.
1292         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1293
1294 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1295
1296         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1297         (xstormy16_unwind_pc): Delete.
1298         (xstormy16_dummy_id): Delete.
1299         (xstormy16_gdbarch_init): Don't register deleted functions with
1300         gdbarch.
1301
1302 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1303
1304         * vax-tdep.c (vax_unwind_pc): Delete.
1305         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1306
1307 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1308
1309         * v850-tdep.c (v850_unwind_sp): Delete.
1310         (v850_unwind_pc): Delete.
1311         (v850_dummy_id): Delete.
1312         (v850_gdbarch_init): Don't register deleted functions with
1313         gdbarch.
1314
1315 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1316
1317         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1318         (tilegx_unwind_pc): Delete.
1319         (tilegx_unwind_dummy_id): Delete.
1320         (tilegx_gdbarch_init): Don't register deleted functions with
1321         gdbarch.
1322
1323 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1324
1325         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1326         (tic6x_dummy_id): Delete.
1327         (tic6x_gdbarch_init): Don't register deleted functions with
1328         gdbarch.
1329
1330 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1331
1332         * sparc-tdep.c (sparc_unwind_pc): Delete.
1333         (sparc32_gdbarch_init): Don't register deleted function with
1334         gdbarch.
1335
1336 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1337
1338         * sh-tdep.c (sh_unwind_sp): Delete.
1339         (sh_unwind_pc): Delete.
1340         (sh_dummy_id): Delete.
1341         (sh_gdbarch_init): Don't register deleted functions with
1342         gdbarch.
1343
1344 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1345
1346         * score-tdep.c (score_unwind_sp): Delete.
1347         (score_unwind_pc): Delete.
1348         (score_dummy_id): Delete.
1349         (score_gdbarch_init): Don't register deleted functions with
1350         gdbarch.
1351
1352 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1353
1354         * rx-tdep.c (rx_unwind_pc): Delete.
1355         (rx_unwind_sp): Delete.
1356         (rx_dummy_id): Delete.
1357         (rx_gdbarch_init): Don't register deleted functions with
1358         gdbarch.  Update comment.
1359
1360 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1361
1362         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1363         (rs6000_dummy_id): Delete.
1364         (rs6000_gdbarch_init): Don't register deleted functions with
1365         gdbarch.
1366
1367 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1368
1369         * or1k-tdep.c (or1k_dummy_id): Delete.
1370         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1371
1372 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1373
1374         * nios2-tdep.c (nios2_dummy_id): Delete.
1375         (nios2_unwind_sp): Delete.
1376         (nios2_gdbarch_init): Don't register deleted functions with
1377         gdbarch.
1378
1379 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1380
1381         * nds32-tdep.c (nds32_dummy_id): Delete.
1382         (nds32_unwind_pc): Delete.
1383         (nds32_unwind_sp): Delete.
1384         (nds32_gdbarch_init): Don't register deleted functions with
1385         gdbarch.
1386
1387 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1388
1389         * msp430-tdep.c (msp430_unwind_pc): Delete.
1390         (msp430_unwind_sp): Delete.
1391         (msp430_dummy_id): Delete.
1392         (msp430_gdbarch_init): Don't register deleted functions with
1393         gdbarch.
1394
1395 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1396
1397         * moxie-tdep.c (moxie_unwind_sp): Delete.
1398         (moxie_unwind_pc): Delete.
1399         (moxie_dummy_id): Delete.
1400         (moxie_gdbarch_init): Don't register deleted functions with
1401         gdbarch.
1402
1403 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1404
1405         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1406         (mn10300_unwind_pc): Delete.
1407         (mn10300_unwind_sp): Delete.
1408         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1409         mn10300_unwind_sp.
1410         (mn10300_frame_unwind_init): Don't register deleted functions with
1411         gdbarch.
1412
1413 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1414
1415         * mep-tdep.c (mep_unwind_pc): Delete.
1416         (mep_unwind_sp): Delete.
1417         (mep_dummy_id): Delete.
1418         (mep_gdbarch_init): Don't register deleted functions with
1419         gdbarch.
1420
1421 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1422
1423         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1424         (m68hc11_unwind_sp): Delete.
1425         (m68hc11_gdbarch_init): Don't register deleted functions with
1426         gdbarch.
1427
1428 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1429
1430         * m32r-tdep.c (m32r_unwind_sp): Delete.
1431         (m32r_unwind_pc): Delete.
1432         (m32r_dummy_id): Delete.
1433         (m32r_gdbarch_init): Don't register deleted functions with
1434         gdbarch.
1435
1436 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1437
1438         * m32c-tdep.c (m32c_unwind_pc): Delete.
1439         (m32c_unwind_sp): Delete.
1440         (m32c_dummy_id): Delete.
1441         (m32c_gdbarch_init): Don't register deleted functions with
1442         gdbarch.
1443
1444 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1445
1446         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1447         (lm32_unwind_pc): Delete.
1448         (lm32_dummy_id): Delete.
1449         (lm32_gdbarch_init): Don't register deleted functions with
1450         gdbarch.
1451
1452 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1453
1454         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1455         (iq2000_unwind_pc): Delete.
1456         (iq2000_dummy_id): Delete.
1457         (iq2000_gdbarch_init): Don't register deleted functions with
1458         gdbarch.
1459
1460 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1461
1462         * nds32-tdep.c (nds32_type_align): Delete.
1463         (nds32_push_dummy_call): Use type_align instead.
1464
1465 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1466
1467         * arm-tdep.c (arm_type_align): Only handle vector override case.
1468         (arm_push_dummy_call): Use type_align.
1469         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1470
1471 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1472
1473         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1474         case.
1475         (pass_on_stack): Use type_align.
1476         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1477         function.
1478
1479 2019-04-23  Tom Tromey  <tromey@adacore.com>
1480
1481         * dwarf2read.c (line_header::file_name_at): Remove unused
1482         overload.
1483
1484 2019-04-23  Tom de Vries  <tdevries@suse.de>
1485
1486         PR gdb/24438
1487         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1488         invocation.
1489
1490
1491 2019-03-27  Ali Tamur  <tamur@google.com>
1492
1493         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1494         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1495         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1496         (dwarf_expr_context::get_addr_index): Likewise
1497         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1498         (symbol_needs_eval_context::get_addr_index): Likewise
1499         (disassemble_dwarf_expression): Add DW_OP_addrx
1500         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1501         (read_cutu_die_from_dwo): Update comment
1502         (skip_one_die): Add DW_FORM_addrx
1503         (read_attribute_value): Likewise
1504         (var_decode_location): Add DW_OP_addrx
1505         (dwarf2_const_value_attr): Add DW_FORM_addrx
1506         (dump_die_shallow): Likewise
1507         (dwarf2_fetch_constant_bytes): Likewise
1508         (decode_locdesc): Add DW_OP_addrx
1509         (skip_form_bytes): Add DW_FORM_addrx
1510
1511 2019-04-22  Ali Tamur  <tamur@google.com>
1512
1513         * MAINTAINERS (Write After Approval): Add self.
1514
1515 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1516
1517         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1518         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1519         (open_symbol_file_object): Likewise.
1520         (svr4_default_sos): Add info parameter.
1521         (svr4_read_so_list): Likewise.
1522         (svr4_current_sos_direct): Adjust functions calls to pass down
1523         info.
1524         (svr4_current_sos_1): Add info parameter.
1525         (svr4_current_sos): Call get_svr4_info, pass info down to
1526         svr4_current_sos_1.
1527         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1528         get_svr4_info.
1529         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1530         get_svr4_info.
1531         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1532         to get_svr4_info.
1533         (probes_table_remove_objfile_probes): Likewise.
1534         (register_solib_event_probe): Add info parameter.
1535         (solist_update_incremental): Pass info parameter down to
1536         svr4_read_so_list.
1537         (disable_probes_interface): Add info parameter.
1538         (svr4_handle_solib_event): Pass current_program_space to
1539         get_svr4_info.  Adjust disable_probes_interface cleanup.
1540         (svr4_create_probe_breakpoints): Add info parameter, pass it
1541         down to register_solib_event_probe.
1542         (svr4_create_solib_event_breakpoints): Add info parameter,
1543         pass it down to svr4_create_probe_breakpoints.
1544         (enable_break): Pass info down to
1545         svr4_create_solib_event_breakpoints.
1546         (svr4_solib_create_inferior_hook): Pass current_program_space to
1547         get_svr4_info.
1548         (svr4_clear_solib): Likewise.
1549
1550 2019-04-22  Pedro Alves  <palves@redhat.com>
1551
1552         * solib-svr4.c (svr4_free_objfile_observer): New.
1553         (probe_and_action::objfile): New field.
1554         (probes_table_htab_remove_objfile_probes)
1555         (probes_table_remove_objfile_probes): New functions.
1556         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1557         in the new probe_and_action.  Don't store the probe in 'lookup'.
1558         (svr4_create_probe_breakpoints): Pass objfile to
1559         register_solib_event_probe.
1560         (_initialize_svr4_solib): Register a free_objfile observer.
1561
1562 2019-04-19  Tom Tromey  <tom@tromey.com>
1563
1564         * common/queue.h: Remove.
1565
1566 2019-04-19  Tom Tromey  <tom@tromey.com>
1567
1568         * event-loop.c: Don't include "common/queue.h".
1569
1570 2019-04-19  Tom Tromey  <tom@tromey.com>
1571
1572         * remote.c (remote_target): Use delete.
1573         * remote-notif.h: Include <list>, not "common/queue.h".
1574         (notif_client_p): Remove typedef.
1575         (remote_notif_state): Add constructor, destructor, initializer.
1576         <notif_queue>: Now a std::list.
1577         (remote_notif_state_xfree): Don't declare.
1578         * remote-notif.c (remote_notif_process, handle_notification)
1579         (remote_notif_state_allocate): Update.
1580         (~remote_notif_state): Rename from remote_notif_state_xfree.
1581
1582 2019-04-19  Tom Tromey  <tom@tromey.com>
1583
1584         * symfile.c (reread_symbols): Update.
1585         * objfiles.c (objfile_register_static_link)
1586         (objfile_lookup_static_link): Update
1587         (~objfile) Don't delete static_links.
1588         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1589
1590 2019-04-19  Tom Tromey  <tom@tromey.com>
1591
1592         * type-stack.h (struct type_stack) <insert>: Constify string.
1593         * type-stack.c (type_stack::insert): Constify string.
1594         * gdbtypes.h (lookup_template_type): Update.
1595         (address_space_name_to_int): Update.
1596         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1597         const.
1598         (lookup_template_type): Make name const.
1599         * c-exp.y: Update rules.
1600         (lex_one_token, classify_name, classify_inner_name)
1601         (c_print_token): Update.
1602         * p-exp.y: Update rules.
1603         (yylex): Update.
1604         * f-exp.y: Update rules.
1605         (yylex): Update.
1606         * d-exp.y: Update rules.
1607         (lex_one_token, classify_name, classify_inner_name): Update.
1608         * parse.c (write_dollar_variable, copy_name): Return std::string.
1609         * parser-defs.h (copy_name): Change return type.
1610         * m2-exp.y: Update rules.
1611         (yylex): Update.
1612         * go-exp.y (lex_one_token): Update.
1613         Update rules.
1614         (classify_unsafe_function, classify_packaged_name)
1615         (classify_name, yylex): Update.
1616
1617 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1618
1619         * configure.ac: add --enable-source-highlight switch.
1620         * configure: Regenerate.
1621         * top.c (print_gdb_version): plumb --enable-source-highlight
1622         status to "show configuration".
1623
1624 2019-04-19  Tom Tromey  <tromey@adacore.com>
1625
1626         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1627         Check ADA_TYPE_P.
1628         (empty_record, ada_template_to_fixed_record_type_1)
1629         (template_to_static_fixed_type)
1630         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1631         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1632         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1633         macros.
1634
1635 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1636
1637         PR symtab/24423:
1638         * source.c (print_source_lines_base): Advance "iter" when a
1639         control character is seen.
1640
1641 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1642
1643         * inferior.h (struct infcall_suspend_state_deleter):
1644         Catch exception in destructor to avoid crash.
1645
1646 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1647
1648         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1649         close to the add_com "shell".
1650
1651 2019-04-18  Tom Tromey  <tromey@adacore.com>
1652
1653         * process-stratum-target.h (class process_stratum_target)
1654         <stratum>: Add "final".
1655
1656 2019-04-17  Tom Tromey  <tromey@adacore.com>
1657
1658         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1659         against nullptr before use.
1660
1661 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1662
1663         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1664
1665 2019-04-17  Jim Wilson  <jimw@sifive.com>
1666             Andrew Burgess  <andrew.burgess@embecosm.com>
1667
1668         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1669         code read might fail, assume 4-byte breakpoint in that case.
1670
1671 2019-04-15  Leszek Swirski  <leszeks@google.com>
1672
1673         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1674         rather than a hand-rolled POD check when checking for forced MEMORY
1675         classification.
1676
1677 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1678
1679         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1680         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1681         function.
1682         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1683         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1684         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1685         declaration.
1686
1687 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1688
1689         * aarch64-linux-nat.c
1690         (aarch64_linux_nat_target::thread_architecture): Add override.
1691         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1692         each VQ.
1693
1694 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1695
1696         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1697
1698 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1699
1700         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1701         target types of size 96-bits, add some additional comments, and
1702         check that the builtin type we found was the correct size.
1703
1704 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1705
1706         * utils.c (prompt_for_continue): Don't restore the styling at the
1707         end, as applied_style has the wrong value.  This fixes styling in
1708         long lists of file names that are interrupted by the "Continue?"
1709         prompt.
1710
1711 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1712
1713         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1714         * c-lang.c (c_language_defn): Likewise.
1715         (cplus_language_defn): Likewise.
1716         (asm_language_defn): Likewise.
1717         (minimal_language_defn): Likewise.
1718         * d-lang.c (d_language_defn): Likewise.
1719         * f-lang.c (f_language_defn): Likewise.
1720         * go-lang.c (go_language_defn): Likewise.
1721         * language.c (unknown_language_defn): Likewise.
1722         (auto_language_defn): Likewise.
1723         * language.h (struct language_defn): Remove la_magic field.
1724         (LANG_MAGIC): Delete.
1725         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1726         * objc-lang.c (objc_language_defn): Likewise.
1727         * opencl-lang.c (opencl_language_defn): Likewise.
1728         * p-lang.c (pascal_language_defn): Likewise.
1729         * rust-lang.c (rust_language_defn): Likewise.
1730
1731 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1732
1733         * riscv-tdep.c (riscv_type_align): New function.
1734         (riscv_type_alignment): Delete.
1735         (riscv_arg_location): Use 'type_align'.
1736         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1737
1738 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1739
1740         * gdbtypes.c (type_align): A struct with no non-static fields also
1741         has alignment of 1.
1742
1743 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1744
1745         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1746         component to 0.
1747         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1748         member.
1749         (riscv_struct_info::analyse): New implementation using new
1750         analyse_inner member function.
1751         (riscv_struct_info::field_offset): New member function.
1752         (riscv_struct_info::m_offsets): New member variable.
1753         (riscv_struct_info::analyse_inner): New private member function,
1754         takes the old implementation of riscv_struct_info::analyse but
1755         extended to track field offsets.
1756         (riscv_call_arg_struct): Update the struct folding special cases
1757         to handle cases where empty C++ structs, which are non-zero
1758         length, are found.
1759         (riscv_arg_location): Initialise the length of each location, a
1760         non-zero length now indicates the location is in use.
1761         (riscv_push_dummy_call): Allow for the first location having a
1762         non-zero offset when setting up arguments.
1763         (riscv_return_value): Likewise, but for return values.
1764
1765 2019-04-11  Tom Tromey  <tromey@adacore.com>
1766
1767         * utils.c (internal_vproblem): Make "msg" const.
1768
1769 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1770
1771         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1772         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1773         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1774         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1775
1776 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1777
1778         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1779         function.
1780         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1781         of amd64_collect_native_gregset.
1782         (amd64_linux_nat_target::store_registers): Likewise.
1783
1784 2019-04-10  Tom Tromey  <tom@tromey.com>
1785
1786         * symtab.c (lookup_global_symbol_from_objfile)
1787         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1788         * objfiles.h (class separate_debug_iterator): New.
1789         (class separate_debug_range): New.
1790         (struct objfile) <separate_debug_objfiles>: New method.
1791         (objfile_separate_debug_iterate): Don't declare.
1792         * objfiles.c (separate_debug_iterator::operator++): Rename from
1793         objfile_separate_debug_iterate.
1794         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1795         iterator.
1796         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1797         iterator.
1798
1799 2019-04-10  Tom Tromey  <tom@tromey.com>
1800
1801         * symfile.c (reread_symbols): Remove old comment.
1802         * objfiles.c (free_all_objfiles): Fix a typo.
1803
1804 2019-04-10  Tom Tromey  <tom@tromey.com>
1805
1806         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1807         * minsyms.c (lookup_minimal_symbol): Use foreach.
1808         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1809         (lookup_minimal_symbol_solib_trampoline): Likewise.
1810         * symfile.c (reread_symbols): Use foreach.
1811
1812 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1813             Tom Tromey  <tromey@adacore.com>
1814
1815         PR rust/24414:
1816         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1817         (rust_lex_int_test): Change "value" to be LONGEST.
1818         (rust_lex_tests): Add test for long integer literal.
1819
1820 2019-04-09  Tom Tromey  <tromey@adacore.com>
1821
1822         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1823         to bool.
1824         (extended_remote_target::attach): Update.
1825         (remote_target::remote_notice_new_inferior): Update.
1826         (remote_target::add_current_inferior_and_thread): Update.
1827         * inferior.c (exit_inferior_1): Use "false".
1828         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1829
1830 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1831
1832         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1833         the "start" command.
1834
1835 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1836
1837         * python/py-inferior.c (infpy_thread_from_thread_handle):
1838         Adjust comments to reflect renaming of thread_from_thread_handle
1839         to thread_from_handle.  Adjust keywords.  Fix type error message.
1840         (inferior_object_methods): Add thread_from_handle.  Retain
1841         thread_from_thread_handle, but mark it as deprecated.
1842
1843 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1844
1845         * gdbthread.h (find_thread_by_handle): Revise declaration.
1846         * thread.c (find_thread_by_handle): Likewise.  Adjust
1847         implementation too.
1848         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1849         support for buffer objects as handles.
1850
1851 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1852
1853         * python/py-infthread.c (thpy_thread_handle): New function.
1854         (thread_object_methods): Register thpy_thread_handle.
1855
1856 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1857
1858         * gdbthread.h (thread_to_thread_handle): Declare.
1859         * thread.c (gdbtypes.h): Include.
1860         (thread_to_thread_handle): New function.
1861
1862         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1863         (target_thread_info_to_thread_handle): Declare.
1864         * target.c (target_thread_info_to_thread_handle): New function.
1865         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1866         * target-delegates.c: Regenerate.
1867
1868         * linux-thread-db.c (class thread_db_target): Add method
1869         thread_info_to_thread_handle.
1870         (thread_db_target::thread_info_to_thread_handle): Define.
1871         * remote.c (class remote_target): Add new method
1872         thread_info_to_thread_handle.
1873         (remote_target::thread_info_to_thread_handle): Define.
1874
1875 2019-04-08  Pedro Alves  <palves@redhat.com>
1876
1877         * common/common-exceptions.c (throw_exception): Don't create
1878         named object to throw; throw directly.
1879         (throw_it): Likewise.  Don't initialize gdb_exception::message
1880         here, with new; pass FMT and AP to the ctor instead.
1881         * common/common-exceptions.h: Include <string>.
1882         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1883         const char *, va_list)): New ctor.  Use std::make_shared.
1884         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1885         errors)): Delete.
1886         (gdb_exception_error::gdb_exception_error(enum errors, const char
1887         *, va_list)): New.
1888         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1889         Add assertion.
1890         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1891         errors)): Delete.
1892         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1893         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1894         Add assertion.
1895
1896 2019-04-08  Tom Tromey  <tom@tromey.com>
1897
1898         * valops.c (value_rtti_indirect_type): Replace throw_exception
1899         with throw.
1900         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1901         with throw.
1902         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1903         throw.
1904         * target.c (target_translate_tls_address): Replace throw_exception
1905         with throw.
1906         * stack.c (frame_apply_command_count): Replace throw_exception
1907         with throw.
1908         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1909         throw.
1910         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1911         with throw.
1912         * rs6000-tdep.c (rs6000_frame_cache)
1913         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1914         * remote.c: Replace throw_exception with throw.
1915         * record-full.c (record_full_message, record_full_wait_1)
1916         (record_full_restore): Replace throw_exception with throw.
1917         * record-btrace.c:
1918         (get_thread_current_frame_id, record_btrace_start_replaying)
1919         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1920         (cmd_record_btrace_start): Replace throw_exception with throw.
1921         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1922         throw.
1923         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1924         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1925         * linespec.c:
1926         (find_linespec_symbols): Replace throw_exception with throw.
1927         * infrun.c (displaced_step_prepare, resume): Replace
1928         throw_exception with throw.
1929         * infcmd.c (post_create_inferior): Replace throw_exception with
1930         throw.
1931         * inf-loop.c (inferior_event_handler): Replace throw_exception
1932         with throw.
1933         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1934         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1935         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1936         (get_prev_frame_always, get_frame_pc_if_available)
1937         (get_frame_address_in_block_if_available, get_frame_language):
1938         Replace throw_exception with throw.
1939         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1940         throw_exception with throw.
1941         * eval.c (fetch_subexp_value, evaluate_var_value)
1942         (evaluate_funcall, evaluate_subexp_standard): Replace
1943         throw_exception with throw.
1944         * dwarf2loc.c (call_site_find_chain)
1945         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1946         Replace throw_exception with throw.
1947         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1948         with throw.
1949         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1950         throw.
1951         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1952         * completer.c (complete_line_internal): Replace throw_exception
1953         with throw.
1954         * compile/compile-object-run.c (compile_object_run): Replace
1955         throw_exception with throw.
1956         * cli/cli-script.c (process_next_line): Replace throw_exception
1957         with throw.
1958         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1959         (btrace_enable, btrace_maint_update_pt_packets): Replace
1960         throw_exception with throw.
1961         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1962         throw_exception with throw.
1963         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1964         throw_exception with throw.
1965         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1966         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1967         * aarch64-tdep.c (aarch64_make_prologue_cache)
1968         (aarch64_make_stub_cache): Replace throw_exception with throw.
1969
1970 2019-04-08  Tom Tromey  <tom@tromey.com>
1971
1972         * common/common-exceptions.c (throw_exception): Rename from
1973         throw_exception_cxx.  Remove old copy.  Make argument const.
1974         (throw_it): Create and throw exception objects directly.
1975         * common/common-exceptions.h (throw_exception): Make argument
1976         const.
1977         (struct gdb_exception_error): Add constructor.
1978         (struct gdb_exception_quit): Add constructor.
1979
1980 2019-04-08  Tom Tromey  <tom@tromey.com>
1981
1982         * common/common-exceptions.h (exception_rethrow): Don't declare.
1983         (TRY_SJLJ): Update comment.
1984         (TRY, CATCH, END_CATCH): Remove.
1985         * common/common-exceptions.c (exception_rethrow): Remove.
1986
1987 2019-04-08  Tom Tromey  <tom@tromey.com>
1988
1989         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1990         Remove.
1991         (gdb_exception_error): Rename from
1992         gdb_exception_RETURN_MASK_ERROR.
1993         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1994         (gdb_quit_bad_alloc): Update.
1995         * aarch64-tdep.c: Update.
1996         * ada-lang.c: Update.
1997         * ada-typeprint.c: Update.
1998         * ada-valprint.c: Update.
1999         * amd64-tdep.c: Update.
2000         * arch-utils.c: Update.
2001         * break-catch-throw.c: Update.
2002         * breakpoint.c: Update.
2003         * btrace.c: Update.
2004         * c-varobj.c: Update.
2005         * cli/cli-cmds.c: Update.
2006         * cli/cli-interp.c: Update.
2007         * cli/cli-script.c: Update.
2008         * common/common-exceptions.c: Update.
2009         * common/new-op.c: Update.
2010         * common/selftest.c: Update.
2011         * compile/compile-c-symbols.c: Update.
2012         * compile/compile-cplus-symbols.c: Update.
2013         * compile/compile-object-load.c: Update.
2014         * compile/compile-object-run.c: Update.
2015         * completer.c: Update.
2016         * corelow.c: Update.
2017         * cp-abi.c: Update.
2018         * cp-support.c: Update.
2019         * cp-valprint.c: Update.
2020         * darwin-nat.c: Update.
2021         * disasm-selftests.c: Update.
2022         * dtrace-probe.c: Update.
2023         * dwarf-index-cache.c: Update.
2024         * dwarf-index-write.c: Update.
2025         * dwarf2-frame-tailcall.c: Update.
2026         * dwarf2-frame.c: Update.
2027         * dwarf2loc.c: Update.
2028         * dwarf2read.c: Update.
2029         * eval.c: Update.
2030         * event-loop.c: Update.
2031         * event-top.c: Update.
2032         * exec.c: Update.
2033         * f-valprint.c: Update.
2034         * fbsd-tdep.c: Update.
2035         * frame-unwind.c: Update.
2036         * frame.c: Update.
2037         * gdbtypes.c: Update.
2038         * gnu-v3-abi.c: Update.
2039         * guile/guile-internal.h: Update.
2040         * guile/scm-block.c: Update.
2041         * guile/scm-breakpoint.c: Update.
2042         * guile/scm-cmd.c: Update.
2043         * guile/scm-disasm.c: Update.
2044         * guile/scm-frame.c: Update.
2045         * guile/scm-lazy-string.c: Update.
2046         * guile/scm-math.c: Update.
2047         * guile/scm-param.c: Update.
2048         * guile/scm-ports.c: Update.
2049         * guile/scm-pretty-print.c: Update.
2050         * guile/scm-symbol.c: Update.
2051         * guile/scm-symtab.c: Update.
2052         * guile/scm-type.c: Update.
2053         * guile/scm-value.c: Update.
2054         * i386-linux-tdep.c: Update.
2055         * i386-tdep.c: Update.
2056         * inf-loop.c: Update.
2057         * infcall.c: Update.
2058         * infcmd.c: Update.
2059         * infrun.c: Update.
2060         * jit.c: Update.
2061         * language.c: Update.
2062         * linespec.c: Update.
2063         * linux-fork.c: Update.
2064         * linux-nat.c: Update.
2065         * linux-tdep.c: Update.
2066         * linux-thread-db.c: Update.
2067         * main.c: Update.
2068         * mi/mi-cmd-break.c: Update.
2069         * mi/mi-cmd-stack.c: Update.
2070         * mi/mi-interp.c: Update.
2071         * mi/mi-main.c: Update.
2072         * objc-lang.c: Update.
2073         * p-valprint.c: Update.
2074         * parse.c: Update.
2075         * ppc-linux-tdep.c: Update.
2076         * printcmd.c: Update.
2077         * python/py-arch.c: Update.
2078         * python/py-breakpoint.c: Update.
2079         * python/py-cmd.c: Update.
2080         * python/py-finishbreakpoint.c: Update.
2081         * python/py-frame.c: Update.
2082         * python/py-framefilter.c: Update.
2083         * python/py-gdb-readline.c: Update.
2084         * python/py-inferior.c: Update.
2085         * python/py-infthread.c: Update.
2086         * python/py-lazy-string.c: Update.
2087         * python/py-linetable.c: Update.
2088         * python/py-objfile.c: Update.
2089         * python/py-param.c: Update.
2090         * python/py-prettyprint.c: Update.
2091         * python/py-progspace.c: Update.
2092         * python/py-record-btrace.c: Update.
2093         * python/py-record.c: Update.
2094         * python/py-symbol.c: Update.
2095         * python/py-type.c: Update.
2096         * python/py-unwind.c: Update.
2097         * python/py-utils.c: Update.
2098         * python/py-value.c: Update.
2099         * python/python.c: Update.
2100         * record-btrace.c: Update.
2101         * record-full.c: Update.
2102         * remote-fileio.c: Update.
2103         * remote.c: Update.
2104         * riscv-tdep.c: Update.
2105         * rs6000-aix-tdep.c: Update.
2106         * rs6000-tdep.c: Update.
2107         * rust-exp.y: Update.
2108         * rust-lang.c: Update.
2109         * s390-tdep.c: Update.
2110         * selftest-arch.c: Update.
2111         * solib-dsbt.c: Update.
2112         * solib-frv.c: Update.
2113         * solib-spu.c: Update.
2114         * solib-svr4.c: Update.
2115         * solib.c: Update.
2116         * sparc64-linux-tdep.c: Update.
2117         * stack.c: Update.
2118         * symfile-mem.c: Update.
2119         * symmisc.c: Update.
2120         * target.c: Update.
2121         * thread.c: Update.
2122         * top.c: Update.
2123         * tracefile-tfile.c: Update.
2124         * tui/tui.c: Update.
2125         * typeprint.c: Update.
2126         * unittests/cli-utils-selftests.c: Update.
2127         * unittests/parse-connection-spec-selftests.c: Update.
2128         * valops.c: Update.
2129         * valprint.c: Update.
2130         * value.c: Update.
2131         * varobj.c: Update.
2132         * windows-nat.c: Update.
2133         * x86-linux-nat.c: Update.
2134         * xml-support.c: Update.
2135
2136 2019-04-08  Tom Tromey  <tom@tromey.com>
2137
2138         * xml-support.c: Use C++ exception handling.
2139         * x86-linux-nat.c: Use C++ exception handling.
2140         * windows-nat.c: Use C++ exception handling.
2141         * varobj.c: Use C++ exception handling.
2142         * value.c: Use C++ exception handling.
2143         * valprint.c: Use C++ exception handling.
2144         * valops.c: Use C++ exception handling.
2145         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2146         handling.
2147         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2148         * typeprint.c: Use C++ exception handling.
2149         * tui/tui.c: Use C++ exception handling.
2150         * tracefile-tfile.c: Use C++ exception handling.
2151         * top.c: Use C++ exception handling.
2152         * thread.c: Use C++ exception handling.
2153         * target.c: Use C++ exception handling.
2154         * symmisc.c: Use C++ exception handling.
2155         * symfile-mem.c: Use C++ exception handling.
2156         * stack.c: Use C++ exception handling.
2157         * sparc64-linux-tdep.c: Use C++ exception handling.
2158         * solib.c: Use C++ exception handling.
2159         * solib-svr4.c: Use C++ exception handling.
2160         * solib-spu.c: Use C++ exception handling.
2161         * solib-frv.c: Use C++ exception handling.
2162         * solib-dsbt.c: Use C++ exception handling.
2163         * selftest-arch.c: Use C++ exception handling.
2164         * s390-tdep.c: Use C++ exception handling.
2165         * rust-lang.c: Use C++ exception handling.
2166         * rust-exp.y: Use C++ exception handling.
2167         * rs6000-tdep.c: Use C++ exception handling.
2168         * rs6000-aix-tdep.c: Use C++ exception handling.
2169         * riscv-tdep.c: Use C++ exception handling.
2170         * remote.c: Use C++ exception handling.
2171         * remote-fileio.c: Use C++ exception handling.
2172         * record-full.c: Use C++ exception handling.
2173         * record-btrace.c: Use C++ exception handling.
2174         * python/python.c: Use C++ exception handling.
2175         * python/py-value.c: Use C++ exception handling.
2176         * python/py-utils.c: Use C++ exception handling.
2177         * python/py-unwind.c: Use C++ exception handling.
2178         * python/py-type.c: Use C++ exception handling.
2179         * python/py-symbol.c: Use C++ exception handling.
2180         * python/py-record.c: Use C++ exception handling.
2181         * python/py-record-btrace.c: Use C++ exception handling.
2182         * python/py-progspace.c: Use C++ exception handling.
2183         * python/py-prettyprint.c: Use C++ exception handling.
2184         * python/py-param.c: Use C++ exception handling.
2185         * python/py-objfile.c: Use C++ exception handling.
2186         * python/py-linetable.c: Use C++ exception handling.
2187         * python/py-lazy-string.c: Use C++ exception handling.
2188         * python/py-infthread.c: Use C++ exception handling.
2189         * python/py-inferior.c: Use C++ exception handling.
2190         * python/py-gdb-readline.c: Use C++ exception handling.
2191         * python/py-framefilter.c: Use C++ exception handling.
2192         * python/py-frame.c: Use C++ exception handling.
2193         * python/py-finishbreakpoint.c: Use C++ exception handling.
2194         * python/py-cmd.c: Use C++ exception handling.
2195         * python/py-breakpoint.c: Use C++ exception handling.
2196         * python/py-arch.c: Use C++ exception handling.
2197         * printcmd.c: Use C++ exception handling.
2198         * ppc-linux-tdep.c: Use C++ exception handling.
2199         * parse.c: Use C++ exception handling.
2200         * p-valprint.c: Use C++ exception handling.
2201         * objc-lang.c: Use C++ exception handling.
2202         * mi/mi-main.c: Use C++ exception handling.
2203         * mi/mi-interp.c: Use C++ exception handling.
2204         * mi/mi-cmd-stack.c: Use C++ exception handling.
2205         * mi/mi-cmd-break.c: Use C++ exception handling.
2206         * main.c: Use C++ exception handling.
2207         * linux-thread-db.c: Use C++ exception handling.
2208         * linux-tdep.c: Use C++ exception handling.
2209         * linux-nat.c: Use C++ exception handling.
2210         * linux-fork.c: Use C++ exception handling.
2211         * linespec.c: Use C++ exception handling.
2212         * language.c: Use C++ exception handling.
2213         * jit.c: Use C++ exception handling.
2214         * infrun.c: Use C++ exception handling.
2215         * infcmd.c: Use C++ exception handling.
2216         * infcall.c: Use C++ exception handling.
2217         * inf-loop.c: Use C++ exception handling.
2218         * i386-tdep.c: Use C++ exception handling.
2219         * i386-linux-tdep.c: Use C++ exception handling.
2220         * guile/scm-value.c: Use C++ exception handling.
2221         * guile/scm-type.c: Use C++ exception handling.
2222         * guile/scm-symtab.c: Use C++ exception handling.
2223         * guile/scm-symbol.c: Use C++ exception handling.
2224         * guile/scm-pretty-print.c: Use C++ exception handling.
2225         * guile/scm-ports.c: Use C++ exception handling.
2226         * guile/scm-param.c: Use C++ exception handling.
2227         * guile/scm-math.c: Use C++ exception handling.
2228         * guile/scm-lazy-string.c: Use C++ exception handling.
2229         * guile/scm-frame.c: Use C++ exception handling.
2230         * guile/scm-disasm.c: Use C++ exception handling.
2231         * guile/scm-cmd.c: Use C++ exception handling.
2232         * guile/scm-breakpoint.c: Use C++ exception handling.
2233         * guile/scm-block.c: Use C++ exception handling.
2234         * guile/guile-internal.h: Use C++ exception handling.
2235         * gnu-v3-abi.c: Use C++ exception handling.
2236         * gdbtypes.c: Use C++ exception handling.
2237         * frame.c: Use C++ exception handling.
2238         * frame-unwind.c: Use C++ exception handling.
2239         * fbsd-tdep.c: Use C++ exception handling.
2240         * f-valprint.c: Use C++ exception handling.
2241         * exec.c: Use C++ exception handling.
2242         * event-top.c: Use C++ exception handling.
2243         * event-loop.c: Use C++ exception handling.
2244         * eval.c: Use C++ exception handling.
2245         * dwarf2read.c: Use C++ exception handling.
2246         * dwarf2loc.c: Use C++ exception handling.
2247         * dwarf2-frame.c: Use C++ exception handling.
2248         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2249         * dwarf-index-write.c: Use C++ exception handling.
2250         * dwarf-index-cache.c: Use C++ exception handling.
2251         * dtrace-probe.c: Use C++ exception handling.
2252         * disasm-selftests.c: Use C++ exception handling.
2253         * darwin-nat.c: Use C++ exception handling.
2254         * cp-valprint.c: Use C++ exception handling.
2255         * cp-support.c: Use C++ exception handling.
2256         * cp-abi.c: Use C++ exception handling.
2257         * corelow.c: Use C++ exception handling.
2258         * completer.c: Use C++ exception handling.
2259         * compile/compile-object-run.c: Use C++ exception handling.
2260         * compile/compile-object-load.c: Use C++ exception handling.
2261         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2262         * compile/compile-c-symbols.c: Use C++ exception handling.
2263         * common/selftest.c: Use C++ exception handling.
2264         * common/new-op.c: Use C++ exception handling.
2265         * cli/cli-script.c: Use C++ exception handling.
2266         * cli/cli-interp.c: Use C++ exception handling.
2267         * cli/cli-cmds.c: Use C++ exception handling.
2268         * c-varobj.c: Use C++ exception handling.
2269         * btrace.c: Use C++ exception handling.
2270         * breakpoint.c: Use C++ exception handling.
2271         * break-catch-throw.c: Use C++ exception handling.
2272         * arch-utils.c: Use C++ exception handling.
2273         * amd64-tdep.c: Use C++ exception handling.
2274         * ada-valprint.c: Use C++ exception handling.
2275         * ada-typeprint.c: Use C++ exception handling.
2276         * ada-lang.c: Use C++ exception handling.
2277         * aarch64-tdep.c: Use C++ exception handling.
2278
2279 2019-04-08  Tom Tromey  <tom@tromey.com>
2280
2281         * xml-support.c (gdb_xml_parser::parse): Update.
2282         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2283         * value.c (show_convenience): Update.
2284         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2285         (test_parse_flags_qcs): Update.
2286         * thread.c (thr_try_catch_cmd): Update.
2287         * target.c (target_translate_tls_address): Update.
2288         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2289         (info_frame_command_core, frame_apply_command_count): Update.
2290         * rust-exp.y (rust_lex_exception_test): Update.
2291         * riscv-tdep.c (riscv_print_one_register_info): Update.
2292         * remote.c (remote_target::enable_btrace): Update.
2293         * record-btrace.c (record_btrace_enable_warn): Update.
2294         * python/py-utils.c (gdbpy_convert_exception): Update.
2295         * printcmd.c (do_one_display, print_variable_and_value): Update.
2296         * mi/mi-main.c (mi_print_exception): Update.
2297         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2298         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2299         * linux-nat.c (linux_nat_target::attach): Update.
2300         * linux-fork.c (class scoped_switch_fork_info): Update.
2301         * infrun.c (displaced_step_prepare): Update.
2302         * infcall.c (call_function_by_hand_dummy): Update.
2303         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2304         * gnu-v3-abi.c (print_one_vtable): Update.
2305         * frame.c (get_prev_frame_always): Update.
2306         * f-valprint.c (info_common_command_for_block): Update.
2307         * exec.c (try_open_exec_file): Update.
2308         * exceptions.c (print_exception, exception_print)
2309         (exception_fprintf, exception_print_same): Update.
2310         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2311         * dwarf-index-cache.c (index_cache::store)
2312         (index_cache::lookup_gdb_index): Update.
2313         * darwin-nat.c (maybe_cache_shell): Update.
2314         * cp-valprint.c (cp_print_value_fields): Update.
2315         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2316         (gcc_cplus_symbol_address): Update.
2317         * compile/compile-c-symbols.c (gcc_convert_symbol)
2318         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2319         * common/selftest.c: Update.
2320         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2321         a std::string.
2322         (exception_try_scope_entry, exception_try_scope_exit): Don't
2323         declare.
2324         (struct exception_try_scope): Remove.
2325         (TRY): Don't use exception_try_scope.
2326         (struct gdb_exception): Add constructor, operator=.
2327         <what>: New method.
2328         (struct gdb_exception_RETURN_MASK_ALL)
2329         (struct gdb_exception_RETURN_MASK_ERROR)
2330         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2331         (struct gdb_quit_bad_alloc): Update.
2332         * common/common-exceptions.c (exception_none): Change
2333         initializer.
2334         (struct catcher) <state, exception>: Initialize inline.
2335         <prev>: Remove member.
2336         (current_catcher): Remove.
2337         (catchers): New global.
2338         (exceptions_state_mc_init): Simplify.
2339         (catcher_pop): Remove.
2340         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2341         (try_scope_depth, exception_try_scope_entry)
2342         (exception_try_scope_exit): Remove.
2343         (throw_exception_sjlj): Update.
2344         (exception_messages, exception_messages_size): Remove.
2345         (throw_it): Simplify.
2346         (gdb_exception_sliced_copy): Remove.
2347         (throw_exception_cxx): Update.
2348         * cli/cli-script.c (script_from_file): Update.
2349         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2350         Update.
2351         * ada-valprint.c (ada_val_print): Update.
2352         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2353         (create_excep_cond_exprs): Update.
2354
2355 2019-04-08  Tom Tromey  <tom@tromey.com>
2356
2357         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2358         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2359         (TRY, CATCH, END_CATCH): Remove some definitions.
2360         * common/common-exceptions.c: Don't use GDB_XCPT.
2361         (catcher_list_size): Remove.
2362         (throw_exception, throw_it): Simplify.
2363
2364 2019-04-05  Tom Tromey  <tom@tromey.com>
2365
2366         Revert the header-sorting patch.
2367         * ft32-tdep.c: Revert.
2368         * frv-tdep.c: Revert.
2369         * frv-linux-tdep.c: Revert.
2370         * frame.c: Revert.
2371         * frame-unwind.c: Revert.
2372         * frame-base.c: Revert.
2373         * fork-child.c: Revert.
2374         * findvar.c: Revert.
2375         * findcmd.c: Revert.
2376         * filesystem.c: Revert.
2377         * filename-seen-cache.h: Revert.
2378         * filename-seen-cache.c: Revert.
2379         * fbsd-tdep.c: Revert.
2380         * fbsd-nat.h: Revert.
2381         * fbsd-nat.c: Revert.
2382         * f-valprint.c: Revert.
2383         * f-typeprint.c: Revert.
2384         * f-lang.c: Revert.
2385         * extension.h: Revert.
2386         * extension.c: Revert.
2387         * extension-priv.h: Revert.
2388         * expprint.c: Revert.
2389         * exec.h: Revert.
2390         * exec.c: Revert.
2391         * exceptions.c: Revert.
2392         * event-top.c: Revert.
2393         * event-loop.c: Revert.
2394         * eval.c: Revert.
2395         * elfread.c: Revert.
2396         * dwarf2read.h: Revert.
2397         * dwarf2read.c: Revert.
2398         * dwarf2loc.c: Revert.
2399         * dwarf2expr.h: Revert.
2400         * dwarf2expr.c: Revert.
2401         * dwarf2-frame.c: Revert.
2402         * dwarf2-frame-tailcall.c: Revert.
2403         * dwarf-index-write.h: Revert.
2404         * dwarf-index-write.c: Revert.
2405         * dwarf-index-common.c: Revert.
2406         * dwarf-index-cache.h: Revert.
2407         * dwarf-index-cache.c: Revert.
2408         * dummy-frame.c: Revert.
2409         * dtrace-probe.c: Revert.
2410         * disasm.h: Revert.
2411         * disasm.c: Revert.
2412         * disasm-selftests.c: Revert.
2413         * dictionary.c: Revert.
2414         * dicos-tdep.c: Revert.
2415         * demangle.c: Revert.
2416         * dcache.h: Revert.
2417         * dcache.c: Revert.
2418         * darwin-nat.h: Revert.
2419         * darwin-nat.c: Revert.
2420         * darwin-nat-info.c: Revert.
2421         * d-valprint.c: Revert.
2422         * d-namespace.c: Revert.
2423         * d-lang.c: Revert.
2424         * ctf.c: Revert.
2425         * csky-tdep.c: Revert.
2426         * csky-linux-tdep.c: Revert.
2427         * cris-tdep.c: Revert.
2428         * cris-linux-tdep.c: Revert.
2429         * cp-valprint.c: Revert.
2430         * cp-support.c: Revert.
2431         * cp-namespace.c: Revert.
2432         * cp-abi.c: Revert.
2433         * corelow.c: Revert.
2434         * corefile.c: Revert.
2435         * continuations.c: Revert.
2436         * completer.h: Revert.
2437         * completer.c: Revert.
2438         * complaints.c: Revert.
2439         * coffread.c: Revert.
2440         * coff-pe-read.c: Revert.
2441         * cli-out.h: Revert.
2442         * cli-out.c: Revert.
2443         * charset.c: Revert.
2444         * c-varobj.c: Revert.
2445         * c-valprint.c: Revert.
2446         * c-typeprint.c: Revert.
2447         * c-lang.c: Revert.
2448         * buildsym.c: Revert.
2449         * buildsym-legacy.c: Revert.
2450         * build-id.h: Revert.
2451         * build-id.c: Revert.
2452         * btrace.c: Revert.
2453         * bsd-uthread.c: Revert.
2454         * breakpoint.h: Revert.
2455         * breakpoint.c: Revert.
2456         * break-catch-throw.c: Revert.
2457         * break-catch-syscall.c: Revert.
2458         * break-catch-sig.c: Revert.
2459         * blockframe.c: Revert.
2460         * block.c: Revert.
2461         * bfin-tdep.c: Revert.
2462         * bfin-linux-tdep.c: Revert.
2463         * bfd-target.c: Revert.
2464         * bcache.c: Revert.
2465         * ax-general.c: Revert.
2466         * ax-gdb.h: Revert.
2467         * ax-gdb.c: Revert.
2468         * avr-tdep.c: Revert.
2469         * auxv.c: Revert.
2470         * auto-load.c: Revert.
2471         * arm-wince-tdep.c: Revert.
2472         * arm-tdep.c: Revert.
2473         * arm-symbian-tdep.c: Revert.
2474         * arm-pikeos-tdep.c: Revert.
2475         * arm-obsd-tdep.c: Revert.
2476         * arm-nbsd-tdep.c: Revert.
2477         * arm-nbsd-nat.c: Revert.
2478         * arm-linux-tdep.c: Revert.
2479         * arm-linux-nat.c: Revert.
2480         * arm-fbsd-tdep.c: Revert.
2481         * arm-fbsd-nat.c: Revert.
2482         * arm-bsd-tdep.c: Revert.
2483         * arch-utils.c: Revert.
2484         * arc-tdep.c: Revert.
2485         * arc-newlib-tdep.c: Revert.
2486         * annotate.h: Revert.
2487         * annotate.c: Revert.
2488         * amd64-windows-tdep.c: Revert.
2489         * amd64-windows-nat.c: Revert.
2490         * amd64-tdep.c: Revert.
2491         * amd64-sol2-tdep.c: Revert.
2492         * amd64-obsd-tdep.c: Revert.
2493         * amd64-obsd-nat.c: Revert.
2494         * amd64-nbsd-tdep.c: Revert.
2495         * amd64-nbsd-nat.c: Revert.
2496         * amd64-nat.c: Revert.
2497         * amd64-linux-tdep.c: Revert.
2498         * amd64-linux-nat.c: Revert.
2499         * amd64-fbsd-tdep.c: Revert.
2500         * amd64-fbsd-nat.c: Revert.
2501         * amd64-dicos-tdep.c: Revert.
2502         * amd64-darwin-tdep.c: Revert.
2503         * amd64-bsd-nat.c: Revert.
2504         * alpha-tdep.c: Revert.
2505         * alpha-obsd-tdep.c: Revert.
2506         * alpha-nbsd-tdep.c: Revert.
2507         * alpha-mdebug-tdep.c: Revert.
2508         * alpha-linux-tdep.c: Revert.
2509         * alpha-linux-nat.c: Revert.
2510         * alpha-bsd-tdep.c: Revert.
2511         * alpha-bsd-nat.c: Revert.
2512         * aix-thread.c: Revert.
2513         * agent.c: Revert.
2514         * addrmap.c: Revert.
2515         * ada-varobj.c: Revert.
2516         * ada-valprint.c: Revert.
2517         * ada-typeprint.c: Revert.
2518         * ada-tasks.c: Revert.
2519         * ada-lang.c: Revert.
2520         * aarch64-tdep.c: Revert.
2521         * aarch64-ravenscar-thread.c: Revert.
2522         * aarch64-newlib-tdep.c: Revert.
2523         * aarch64-linux-tdep.c: Revert.
2524         * aarch64-linux-nat.c: Revert.
2525         * aarch64-fbsd-tdep.c: Revert.
2526         * aarch64-fbsd-nat.c: Revert.
2527         * aarch32-linux-nat.c: Revert.
2528
2529 2019-04-05  Tom Tromey  <tom@tromey.com>
2530
2531         * ft32-tdep.c: Sort headers.
2532         * frv-tdep.c: Sort headers.
2533         * frv-linux-tdep.c: Sort headers.
2534         * frame.c: Sort headers.
2535         * frame-unwind.c: Sort headers.
2536         * frame-base.c: Sort headers.
2537         * fork-child.c: Sort headers.
2538         * findvar.c: Sort headers.
2539         * findcmd.c: Sort headers.
2540         * filesystem.c: Sort headers.
2541         * filename-seen-cache.h: Sort headers.
2542         * filename-seen-cache.c: Sort headers.
2543         * fbsd-tdep.c: Sort headers.
2544         * fbsd-nat.h: Sort headers.
2545         * fbsd-nat.c: Sort headers.
2546         * f-valprint.c: Sort headers.
2547         * f-typeprint.c: Sort headers.
2548         * f-lang.c: Sort headers.
2549         * extension.h: Sort headers.
2550         * extension.c: Sort headers.
2551         * extension-priv.h: Sort headers.
2552         * expprint.c: Sort headers.
2553         * exec.h: Sort headers.
2554         * exec.c: Sort headers.
2555         * exceptions.c: Sort headers.
2556         * event-top.c: Sort headers.
2557         * event-loop.c: Sort headers.
2558         * eval.c: Sort headers.
2559         * elfread.c: Sort headers.
2560         * dwarf2read.h: Sort headers.
2561         * dwarf2read.c: Sort headers.
2562         * dwarf2loc.c: Sort headers.
2563         * dwarf2expr.h: Sort headers.
2564         * dwarf2expr.c: Sort headers.
2565         * dwarf2-frame.c: Sort headers.
2566         * dwarf2-frame-tailcall.c: Sort headers.
2567         * dwarf-index-write.h: Sort headers.
2568         * dwarf-index-write.c: Sort headers.
2569         * dwarf-index-common.c: Sort headers.
2570         * dwarf-index-cache.h: Sort headers.
2571         * dwarf-index-cache.c: Sort headers.
2572         * dummy-frame.c: Sort headers.
2573         * dtrace-probe.c: Sort headers.
2574         * disasm.h: Sort headers.
2575         * disasm.c: Sort headers.
2576         * disasm-selftests.c: Sort headers.
2577         * dictionary.c: Sort headers.
2578         * dicos-tdep.c: Sort headers.
2579         * demangle.c: Sort headers.
2580         * dcache.h: Sort headers.
2581         * dcache.c: Sort headers.
2582         * darwin-nat.h: Sort headers.
2583         * darwin-nat.c: Sort headers.
2584         * darwin-nat-info.c: Sort headers.
2585         * d-valprint.c: Sort headers.
2586         * d-namespace.c: Sort headers.
2587         * d-lang.c: Sort headers.
2588         * ctf.c: Sort headers.
2589         * csky-tdep.c: Sort headers.
2590         * csky-linux-tdep.c: Sort headers.
2591         * cris-tdep.c: Sort headers.
2592         * cris-linux-tdep.c: Sort headers.
2593         * cp-valprint.c: Sort headers.
2594         * cp-support.c: Sort headers.
2595         * cp-namespace.c: Sort headers.
2596         * cp-abi.c: Sort headers.
2597         * corelow.c: Sort headers.
2598         * corefile.c: Sort headers.
2599         * continuations.c: Sort headers.
2600         * completer.h: Sort headers.
2601         * completer.c: Sort headers.
2602         * complaints.c: Sort headers.
2603         * coffread.c: Sort headers.
2604         * coff-pe-read.c: Sort headers.
2605         * cli-out.h: Sort headers.
2606         * cli-out.c: Sort headers.
2607         * charset.c: Sort headers.
2608         * c-varobj.c: Sort headers.
2609         * c-valprint.c: Sort headers.
2610         * c-typeprint.c: Sort headers.
2611         * c-lang.c: Sort headers.
2612         * buildsym.c: Sort headers.
2613         * buildsym-legacy.c: Sort headers.
2614         * build-id.h: Sort headers.
2615         * build-id.c: Sort headers.
2616         * btrace.c: Sort headers.
2617         * bsd-uthread.c: Sort headers.
2618         * breakpoint.h: Sort headers.
2619         * breakpoint.c: Sort headers.
2620         * break-catch-throw.c: Sort headers.
2621         * break-catch-syscall.c: Sort headers.
2622         * break-catch-sig.c: Sort headers.
2623         * blockframe.c: Sort headers.
2624         * block.c: Sort headers.
2625         * bfin-tdep.c: Sort headers.
2626         * bfin-linux-tdep.c: Sort headers.
2627         * bfd-target.c: Sort headers.
2628         * bcache.c: Sort headers.
2629         * ax-general.c: Sort headers.
2630         * ax-gdb.h: Sort headers.
2631         * ax-gdb.c: Sort headers.
2632         * avr-tdep.c: Sort headers.
2633         * auxv.c: Sort headers.
2634         * auto-load.c: Sort headers.
2635         * arm-wince-tdep.c: Sort headers.
2636         * arm-tdep.c: Sort headers.
2637         * arm-symbian-tdep.c: Sort headers.
2638         * arm-pikeos-tdep.c: Sort headers.
2639         * arm-obsd-tdep.c: Sort headers.
2640         * arm-nbsd-tdep.c: Sort headers.
2641         * arm-nbsd-nat.c: Sort headers.
2642         * arm-linux-tdep.c: Sort headers.
2643         * arm-linux-nat.c: Sort headers.
2644         * arm-fbsd-tdep.c: Sort headers.
2645         * arm-fbsd-nat.c: Sort headers.
2646         * arm-bsd-tdep.c: Sort headers.
2647         * arch-utils.c: Sort headers.
2648         * arc-tdep.c: Sort headers.
2649         * arc-newlib-tdep.c: Sort headers.
2650         * annotate.h: Sort headers.
2651         * annotate.c: Sort headers.
2652         * amd64-windows-tdep.c: Sort headers.
2653         * amd64-windows-nat.c: Sort headers.
2654         * amd64-tdep.c: Sort headers.
2655         * amd64-sol2-tdep.c: Sort headers.
2656         * amd64-obsd-tdep.c: Sort headers.
2657         * amd64-obsd-nat.c: Sort headers.
2658         * amd64-nbsd-tdep.c: Sort headers.
2659         * amd64-nbsd-nat.c: Sort headers.
2660         * amd64-nat.c: Sort headers.
2661         * amd64-linux-tdep.c: Sort headers.
2662         * amd64-linux-nat.c: Sort headers.
2663         * amd64-fbsd-tdep.c: Sort headers.
2664         * amd64-fbsd-nat.c: Sort headers.
2665         * amd64-dicos-tdep.c: Sort headers.
2666         * amd64-darwin-tdep.c: Sort headers.
2667         * amd64-bsd-nat.c: Sort headers.
2668         * alpha-tdep.c: Sort headers.
2669         * alpha-obsd-tdep.c: Sort headers.
2670         * alpha-nbsd-tdep.c: Sort headers.
2671         * alpha-mdebug-tdep.c: Sort headers.
2672         * alpha-linux-tdep.c: Sort headers.
2673         * alpha-linux-nat.c: Sort headers.
2674         * alpha-bsd-tdep.c: Sort headers.
2675         * alpha-bsd-nat.c: Sort headers.
2676         * aix-thread.c: Sort headers.
2677         * agent.c: Sort headers.
2678         * addrmap.c: Sort headers.
2679         * ada-varobj.c: Sort headers.
2680         * ada-valprint.c: Sort headers.
2681         * ada-typeprint.c: Sort headers.
2682         * ada-tasks.c: Sort headers.
2683         * ada-lang.c: Sort headers.
2684         * aarch64-tdep.c: Sort headers.
2685         * aarch64-ravenscar-thread.c: Sort headers.
2686         * aarch64-newlib-tdep.c: Sort headers.
2687         * aarch64-linux-tdep.c: Sort headers.
2688         * aarch64-linux-nat.c: Sort headers.
2689         * aarch64-fbsd-tdep.c: Sort headers.
2690         * aarch64-fbsd-nat.c: Sort headers.
2691         * aarch32-linux-nat.c: Sort headers.
2692
2693 2019-04-04  Tom Tromey  <tom@tromey.com>
2694
2695         * varobj.c (varobj_create): Update.
2696         * rust-exp.y (struct rust_parser) <update_innermost_block,
2697         lookup_symbol>: New methods.
2698         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2699         Rename.
2700         (rust_parser::rust_lookup_type)
2701         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2702         * printcmd.c (display_command, do_one_display): Update.
2703         * parser-defs.h (struct parser_state) <parser_state>: Add
2704         "tracker" parameter.
2705         (block_tracker): New member.
2706         (class innermost_block_tracker) <innermost_block_tracker>: Add
2707         "types" parameter.
2708         <reset>: Remove method.
2709         (innermost_block): Don't declare.
2710         (null_post_parser): Update.
2711         * parse.c (innermost_block): Remove global.
2712         (write_dollar_variable): Update.
2713         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2714         Remove "tracker_types" parameter.
2715         (parse_expression): Add "tracker" parameter.
2716         (parse_expression_for_completion): Update.
2717         (null_post_parser): Add "tracker" parameter.
2718         * p-exp.y: Update rules.
2719         * m2-exp.y: Update rules.
2720         * language.h (struct language_defn) <la_post_parser>: Add
2721         "tracker" parameter.
2722         * go-exp.y: Update rules.
2723         * f-exp.y: Update rules.
2724         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2725         parameter.
2726         * d-exp.y: Update rules.
2727         * c-exp.y: Update rules.
2728         * breakpoint.c (set_breakpoint_condition): Create an
2729         innermost_block_tracker.
2730         (watch_command_1): Likewise.
2731         * ada-lang.c (resolve): Add "tracker" parameter.
2732         (resolve_subexp): Likewise.
2733         * ada-exp.y (write_var_from_sym): Update.
2734
2735 2019-04-04  Tom Tromey  <tom@tromey.com>
2736
2737         * type-stack.h: New file.
2738         * type-stack.c: New file.
2739         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2740         type-stack.h.
2741         (insert_into_type_stack, insert_type, push_type, push_type_int)
2742         (insert_type_address_space, pop_type, pop_type_int)
2743         (pop_typelist, pop_type_stack, append_type_stack)
2744         (push_type_stack, get_type_stack, push_typelist)
2745         (follow_type_instance_flags, follow_types): Don't declare.
2746         * parse.c (type_stack): Remove global.
2747         (parse_exp_in_context): Update.
2748         (insert_into_type_stack, insert_type, push_type, push_type_int)
2749         (insert_type_address_space, pop_type, pop_type_int)
2750         (pop_typelist, pop_type_stack, append_type_stack)
2751         (push_type_stack, get_type_stack, push_typelist)
2752         (follow_type_instance_flags, follow_types): Remove (moved to
2753         type-stack.c).
2754         * f-exp.y (type_stack): New global.
2755         Update rules.
2756         (push_kind_type, f_parse): Update.
2757         * d-exp.y (type_stack): New global.
2758         Update rules.
2759         (d_parse): Update.
2760         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2761         Update rules.
2762         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2763         (HFILES_NO_SRCDIR): Add type-stack.h.
2764
2765 2019-04-04  Tom Tromey  <tom@tromey.com>
2766
2767         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2768         (rust_parser::convert_ast_to_expression, rust_parse)
2769         (rust_lex_test_completion, rust_lex_tests): Update.
2770         * parser-defs.h (struct expr_completion_state): New.
2771         (struct parser_state) <parser_state>: Add completion parameter.
2772         <mark_struct_expression, mark_completion_tag>: New methods.
2773         <parse_completion, m_completion_state>: New members.
2774         (prefixify_expression, null_post_parser): Update.
2775         (mark_struct_expression, mark_completion_tag): Don't declare.
2776         * parse.c (parse_completion, expout_last_struct)
2777         (expout_tag_completion_type, expout_completion_name): Remove
2778         globals.
2779         (parser_state::mark_struct_expression)
2780         (parser_state::mark_completion_tag): Now methods.
2781         (prefixify_expression): Add last_struct parameter.
2782         (prefixify_subexp): Likewise.
2783         (parse_exp_1): Update.
2784         (parse_exp_in_context): Add cstate parameter.  Update.
2785         (parse_expression_for_completion): Create an
2786         expr_completion_state.
2787         (null_post_parser): Add "completion" parameter.
2788         * p-exp.y: Update rules.
2789         (yylex): Update.
2790         * language.h (struct language_defn) <la_post_parser>: Add
2791         "completing" parameter.
2792         * go-exp.y: Update rules.
2793         (lex_one_token): Update.
2794         * expression.h (parse_completion): Don't declare.
2795         * d-exp.y: Update rules.
2796         (lex_one_token): Update rules.
2797         * c-exp.y: Update rules.
2798         (lex_one_token): Update.
2799         * ada-lang.c (resolve): Add "parse_completion" parameter.
2800         (resolve_subexp): Likewise.
2801         (ada_resolve_function): Likewise.
2802
2803 2019-04-04  Tom Tromey  <tom@tromey.com>
2804
2805         * parser-defs.h (struct parser_state) <start_arglist,
2806         end_arglist>: New methods.
2807         <arglist_len, m_funcall_chain>: New members.
2808         (arglist_len, start_arglist, end_arglist): Don't declare.
2809         * parse.c (arglist_len, funcall_chain): Remove global.
2810         (start_arglist, end_arglist): Remove functions.
2811         (parse_exp_in_context): Update.
2812         * p-exp.y: Update rules.
2813         * m2-exp.y: Update rules.
2814         * go-exp.y: Update rules.
2815         * f-exp.y: Update rules.
2816         * d-exp.y: Update rules.
2817         * c-exp.y: Update rules.
2818
2819 2019-04-04  Tom Tromey  <tom@tromey.com>
2820
2821         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2822         lex_operator, push_back>: New methods.
2823         Update all rules.
2824         (rust_parser::lex_hex, lex_escape): Rename and update.
2825         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2826         (rust_parser::lex_operator): Rename and update.
2827         (rust_parser::lex_number, rustyylex, rustyyerror)
2828         (rust_lex_test_init, rust_lex_test_sequence)
2829         (rust_lex_test_push_back, rust_lex_tests): Update.
2830         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2831         parameter.
2832         <lexptr, prev_lexptr>: New members.
2833         (lexptr, prev_lexptr): Don't declare.
2834         * parse.c (lexptr, prev_lexptr): Remove globals.
2835         (parse_exp_in_context): Update.
2836         * p-exp.y (yylex, yyerror): Update.
2837         * m2-exp.y (parse_number, yylex, yyerror): Update.
2838         * go-exp.y (lex_one_token, yyerror): Update.
2839         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2840         * d-exp.y (lex_one_token, yyerror): Update.
2841         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2842         (lex_one_token, yyerror): Update.
2843         * ada-lex.l (YY_INPUT): Update.
2844         (rewind_to_char): Update.
2845         * ada-exp.y (yyerror): Update.
2846
2847 2019-04-04  Tom Tromey  <tom@tromey.com>
2848
2849         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2850         * parser-defs.h (struct parser_state) <parser_state>: Add new
2851         parameter.
2852         <comma_terminates>: New member.
2853         (comma_terminates): Don't declare global.
2854         * parse.c (comma_terminates): Remove global.
2855         (parse_exp_in_context): Update.
2856         * p-exp.y (yylex): Update.
2857         * m2-exp.y (yylex): Update.
2858         * go-exp.y (lex_one_token): Update.
2859         * f-exp.y (yylex): Update.
2860         * d-exp.y (lex_one_token): Update.
2861         * c-exp.y (lex_one_token): Update.
2862         * ada-lex.l: Update.
2863
2864 2019-04-04  Tom Tromey  <tom@tromey.com>
2865
2866         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2867         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2868         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2869         * parser-defs.h (paren_depth): Don't declare.
2870         * parse.c (paren_depth): Remove global.
2871         (parse_exp_in_context): Update.
2872         * p-exp.y (paren_depth): New global.
2873         (pascal_parse): Initialize it.
2874         * m2-exp.y (paren_depth): New global.
2875         (m2_parse): Initialize it.
2876         * go-exp.y (paren_depth): New global.
2877         (go_parse): Initialize it.
2878         * f-exp.y (paren_depth): New global.
2879         (f_parse): Initialize it.
2880         * d-exp.y (paren_depth): New global.
2881         (d_parse): Initialize it.
2882         * c-exp.y (paren_depth): New global.
2883         (c_parse): Initialize it.
2884         * ada-lex.l (paren_depth): New global.
2885         (lexer_init): Initialize it.
2886
2887 2019-04-04  Tom Tromey  <tom@tromey.com>
2888
2889         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2890         (rust_parser::convert_ast_to_type)
2891         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2892         * parser-defs.h (struct parser_state) <parser_state>: Add
2893         parameters.  Initialize new members.
2894         <expression_context_block, expression_context_pc>: New members.
2895         * parse.c (expression_context_block, expression_context_pc):
2896         Remove globals.
2897         (parse_exp_in_context): Update.
2898         * p-exp.y: Update all rules.
2899         (yylex): Update.
2900         * m2-exp.y: Update all rules.
2901         (yylex): Update.
2902         * go-exp.y (yylex): Update.
2903         * f-exp.y (yylex): Update.
2904         * d-exp.y: Update all rules.
2905         (yylex): Update.
2906         * c-exp.y: Update all rules.
2907         (lex_one_token, classify_name, yylex, c_parse): Update.
2908         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2909
2910 2019-04-04  Tom Tromey  <tom@tromey.com>
2911
2912         * gdbarch.h, gdbarch.c: Rebuild.
2913         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2914         * stap-probe.h:
2915         (struct stap_parse_info): Replace "parser_state" with
2916         "expr_builder".
2917         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2918         (parser_state): New class.
2919         * parse.c (expr_builder): Rename.
2920         (expr_builder::release): Rename.
2921         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2922         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2923         (write_exp_elt_longcst, write_exp_elt_floatcst)
2924         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2925         (write_exp_string_vector, write_exp_bitstring)
2926         (write_exp_msymbol, mark_struct_expression)
2927         (write_dollar_variable)
2928         (insert_type_address_space, increase_expout_size): Replace
2929         "parser_state" with "expr_builder".
2930         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2931         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2932         "parser_state" with "expr_builder".
2933
2934 2019-04-04  Tom Tromey  <tom@tromey.com>
2935
2936         * rust-exp.y: Replace "parse_language" with method call.
2937         * p-exp.y:
2938         (yylex): Replace "parse_language" with method call.
2939         * m2-exp.y:
2940         (yylex): Replace "parse_language" with method call.
2941         * go-exp.y (classify_name): Replace "parse_language" with method
2942         call.
2943         * f-exp.y (yylex): Replace "parse_language" with method call.
2944         * d-exp.y (lex_one_token): Replace "parse_language" with method
2945         call.
2946         * c-exp.y:
2947         (lex_one_token, classify_name, yylex): Replace "parse_language"
2948         with method call.
2949         * ada-exp.y (find_primitive_type, type_char)
2950         (type_system_address): Replace "parse_language" with method call.
2951
2952 2019-04-04  Tom Tromey  <tom@tromey.com>
2953
2954         * rust-exp.y: Replace "parse_gdbarch" with method call.
2955         * parse.c (write_dollar_variable, insert_type_address_space):
2956         Replace "parse_gdbarch" with method call.
2957         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2958         call.
2959         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2960         call.
2961         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2962         "parse_gdbarch" with method call.
2963         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2964         with method call.
2965         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2966         "parse_gdbarch" with method call.
2967         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2968         "parse_gdbarch" with method call.
2969         * c-exp.y (parse_type, parse_number, classify_name): Replace
2970         "parse_gdbarch" with method call.
2971         * ada-lex.l: Replace "parse_gdbarch" with method call.
2972         * ada-exp.y (parse_type, find_primitive_type, type_char)
2973         (type_system_address): Replace "parse_gdbarch" with method call.
2974
2975 2019-04-04  Tom Tromey  <tom@tromey.com>
2976
2977         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2978         * stap-probe.c (stap_parse_argument): Update.
2979         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2980         initial_size parameter.
2981         * rust-exp.y (rust_lex_tests): Update.
2982         * parse.c (parser_state): Update.
2983         (parse_exp_in_context): Update.
2984         * parser-defs.h (struct parser_state) <parser_state>: Remove
2985         "initial_size" parameter.
2986
2987 2019-04-04  Tom Tromey  <tom@tromey.com>
2988
2989         * parser-defs.h (increase_expout_size): Don't declare.
2990         * parse.c (increase_expout_size): Now static.
2991
2992 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2993
2994         * gnu-nat.c (gnu_nat_target::wait): Fix
2995         target_waitstatus_to_string call.
2996
2997 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2998
2999         * eval.c (evaluate_subexp_standard): Handle internal functions
3000         during Fortran function call handling.
3001
3002 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3003
3004         * NEWS: Mention new internal functions.
3005         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3006         (read_base_type): Use dwarf2_init_complex_target_type.
3007         * value.c (creal_internal_fn): New function.
3008         (cimag_internal_fn): New function.
3009         (_initialize_values): Register new internal functions.
3010
3011 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3012
3013         * infrun.c (stop_all_threads): If debug_infrun, always
3014         trace the wait status after wait_one, using
3015         target_waitstatus_to_string and target_pid_to_str.
3016         (handle_inferior_event): Replace various trace of
3017         wait status kind by a single trace.
3018         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3019         wait status kind image by target_waitstatus_to_string.
3020         * target/waitstatus.c (target_waitstatus_to_string): Fix
3021         obsolete comment.
3022
3023 2019-04-01  Tom Tromey  <tromey@adacore.com>
3024
3025         PR symtab/23331:
3026         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3027
3028 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3029             Pedro Alves  <palves@redhat.com>
3030
3031         * top.c (quit_force): Call 'finalize_values'.
3032         * value.c (finalize_values): New function.
3033         * value.h (finalize_values): Declare.
3034
3035 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3036
3037         * NEWS: Announce $_gdb_major and $_gdb_minor.
3038
3039         * top.c (init_gdb_version_vars): New function.
3040         (gdb_init): Call init_gdb_version_vars.
3041
3042 2019-03-29  Tom Tromey  <tromey@adacore.com>
3043
3044         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3045         help text.  Remove dead code.
3046
3047 2019-03-29  Keith Seitz  <keiths@redhat.com>
3048
3049         From Siddhesh Poyarekar:
3050         * f-lang.h (f77_get_upperbound): Return LONGEST.
3051         (f77_get_lowerbound): Likewise.
3052         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3053         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3054         print them.
3055         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3056         plongest to format print it.
3057         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3058         (f77_get_upperbound): Likewise.
3059         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3060         LOWER_BOUND to LONGEST.
3061         (f77_create_arrayprint_offset_tbl): Likewise.
3062
3063 2019-03-29  Keith Seitz  <keiths@redhat.com>
3064
3065         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3066         %s/pulongest for TYPE_LENGTH instead of %d in format
3067         strings.
3068         * ada-typerint.c (ada_print_type): Likewise.
3069         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3070         * compile/compile-c-support.c (generate_register_struct): Likewise.
3071         * gdbtypes.c (recursive_dump_type): Likewise.
3072         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3073         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3074         instead of %d in format strings.
3075         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3076         to std::min to ULONGEST.
3077         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3078         instead of %d in format strings.
3079         * tracepoint.c (info_scope_command): Likewise.
3080         * typeprint.c (print_offset_data::update)
3081         (print_offset_data::finish): Likewise.
3082         * xtensa-tdep.c (xtensa_store_return_value)
3083         (xtensa_push_dummy_call): Likewise.
3084
3085 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3086
3087         * windows-nat.c (display_selector): Fixed format specifications
3088         for 64-bit Cygwin.
3089
3090 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3091
3092         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3093
3094 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3095
3096         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3097         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3098         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3099         (nios2_linux_init_abi): Install it.
3100
3101 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3102
3103         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3104
3105 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3106
3107         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3108
3109 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3110             Tom Tromey  <tromey@adacore.com>
3111
3112         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3113
3114 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3115
3116         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3117         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3118         method to compute the bounds of range types. Also print "[evaluated]"
3119         if the bounds' values come from a dynamic evaluation.
3120
3121 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3122
3123         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3124         whitespace when pretty printing is on.
3125
3126 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3127
3128         * ppc-linux-nat.c: Add include.
3129
3130 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3131
3132         * NEWS: Mention AArch64 Pointer Authentication.
3133
3134 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3135
3136         * arm-linux-nat.c: Add include.
3137
3138 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3139
3140         * source-cache.c (source_cache::get_source_lines): Re-read
3141         fullname after calling open_source_file.
3142
3143 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3144
3145         * NEWS: Mention TLS support for FreeBSD.
3146
3147 2019-03-25  Tom Tromey  <tromey@adacore.com>
3148
3149         * minsyms.c (BUNCH_SIZE): Update comment.
3150         (~minimal_symbol_reader): Remove old comment.
3151         (compact_minimal_symbols): Update comment.
3152         (minimal_symbol_reader::install): Remove old comment.  Update
3153         other comments.
3154
3155 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3156
3157         * s390-linux-nat.c: Add include.
3158
3159 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3160
3161         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3162         Call linux_get_hwcap.
3163         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3164         Likewise.
3165         (aarch64_linux_get_hwcap): Remove function.
3166         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3167         declaration.
3168         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3169         linux_get_hwcap.
3170         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3171         * linux-tdep.c (linux_get_hwcap): Add function.
3172         (linux_get_hwcap2): Likewise.
3173         * linux-tdep.h (linux_get_hwcap): Add declaration.
3174         (linux_get_hwcap2): Likewise.
3175         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3176         (ppc_linux_get_hwcap2): Likewise.
3177         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3178         linux_get_hwcap.
3179         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3180         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3181         (ppc_linux_nat_target::read_description): Likewise.
3182         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3183         * s390-linux-nat.c: Likewise.
3184         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3185
3186 2019-03-24  Tom Tromey  <tom@tromey.com>
3187
3188         * ada-lang.c (standard_lookup): Simplify initialization.
3189         (ada_lookup_symbol_nonlocal): Simplify return.
3190         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3191         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3192         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3193         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3194         initialization.
3195         * solib.c (solib_global_lookup): Simplify.
3196         * symtab.c (null_block_symbol): Remove.
3197         (symbol_cache_lookup): Simplify returns.
3198         (lookup_language_this): Simplify returns.
3199         (lookup_symbol_aux): Simplify return.
3200         (lookup_local_symbol): Simplify returns.
3201         (lookup_global_symbol_from_objfile): Simplify return.
3202         (lookup_symbol_in_objfile_symtabs)
3203         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3204         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3205         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3206         * cp-namespace.c (cp_lookup_bare_symbol)
3207         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3208         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3209         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3210         (cp_lookup_symbol_via_imports): Simplify initialization.
3211         (find_symbol_in_baseclass): Likewise.
3212         * symtab.h (null_block_symbol): Remove.
3213         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3214         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3215         (d_lookup_symbol_module): Likewise.
3216         (find_symbol_in_baseclass): Simplify initialization.
3217
3218 2019-03-24  Tom Tromey  <tom@tromey.com>
3219
3220         * expression.h: Don't include symtab.h.
3221         (struct block): Forward declare.
3222
3223 2019-03-24  Tom Tromey  <tom@tromey.com>
3224
3225         * c-exp.y (typebase): Remove casts.
3226         * gdbtypes.c (lookup_unsigned_typename, )
3227         (lookup_signed_typename): Remove cast.
3228         * eval.c (parse_to_comma_and_eval): Remove cast.
3229         * parse.c (write_dollar_variable): Remove cast.
3230         * block.h (struct block) <superblock>: Now const.
3231         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3232         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3233         (map_block): Make "block" const.
3234         * symfile.h (struct quick_symbol_functions)
3235         <map_matching_symbols>: Constify block argument to "callback".
3236         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3237         const.
3238         (find_pc_sect_compunit_symtab): Make "b" const.
3239         (find_symbol_at_address): Likewise.
3240         (search_symbols): Likewise.
3241         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3242         (dw2_debug_names_lookup_symbol): Likewise.
3243         (dw2_map_matching_symbols): Update.
3244         * p-valprint.c (pascal_val_print): Remove "block".
3245         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3246         (aux_add_nonlocal_symbols): Make "block" const.
3247         (resolve_subexp): Remove cast.
3248         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3249         const.
3250         (iterate_over_file_blocks): Likewise.
3251         * f-exp.y (%union) <bval>: Remove.
3252         * coffread.c (patch_opaque_types): Make "b" const.
3253         * spu-tdep.c (spu_catch_start): Make "block" const.
3254         * c-valprint.c (print_unpacked_pointer): Remove "block".
3255         * symmisc.c (dump_symtab_1): Make "b" const.
3256         (block_depth): Make "block" const.
3257         * d-exp.y (%union) <bval>: Remove.
3258         * cp-support.h (cp_lookup_rtti_type): Update.
3259         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3260         * psymtab.c (psym_lookup_symbol): Make "block" const.
3261         (maintenance_check_psymtabs): Make "b" const.
3262         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3263         (enumerate_locals, enumerate_args): Update.
3264         * python/py-symtab.c (stpy_global_block): Make "block" const.
3265         (stpy_static_block): Likewise.
3266         * inline-frame.c (block_starting_point_at): Make "new_block"
3267         const.
3268         * block.c (find_block_in_blockvector): Make return type const.
3269         (blockvector_for_pc_sect): Make "b" const.
3270         (find_block_in_blockvector): Make "b" const.
3271
3272 2019-03-23  Tom Tromey  <tom@tromey.com>
3273
3274         * varobj.c (varobj_create): Update.
3275         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3276         * printcmd.c (display_command, do_one_display): Don't reset
3277         innermost_block.
3278         * parser-defs.h (enum innermost_block_tracker_type): Move to
3279         expression.h.
3280         (innermost_block): Update comment.
3281         * parse.c (parse_exp_1): Add tracker_types parameter.
3282         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3283         tracker_types parameter.  Reset innermost_block.
3284         (parse_exp_in_context): Remove.
3285         (parse_expression_for_completion): Update.
3286         * objfiles.c (~objfile): Don't reset expression_context_block or
3287         innermost_block.
3288         * expression.h (enum innermost_block_tracker_type): Move from
3289         parser-defs.h.
3290         (parse_exp_1): Add tracker_types parameter.
3291         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3292         reset innermost_block.
3293
3294 2019-03-23  Tom Tromey  <tom@tromey.com>
3295
3296         * objfiles.h: Include bcache.h.
3297
3298 2019-03-23  Tom Tromey  <tom@tromey.com>
3299
3300         * linespec.c (get_current_search_block): Use
3301         scoped_restore_current_language.
3302         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3303
3304 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3305             Jiong Wang  <jiong.wang@arm.com>
3306
3307         * aarch64-linux-tdep.c
3308         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3309         section.
3310         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3311
3312 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3313             Jiong Wang  <jiong.wang@arm.com>
3314
3315         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3316         instructions.
3317         (aarch64_analyze_prologue_test): Add PACIASP test.
3318         (aarch64_prologue_prev_register): Unmask PC value.
3319
3320 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3321             Jiong Wang  <jiong.wang@arm.com>
3322
3323         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3324         (aarch64_dwarf2_prev_register): Unmask PC value.
3325         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3326         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3327         DW_CFA_AARCH64_negate_ra_state.
3328         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3329
3330 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3331             Jiong Wang  <jiong.wang@arm.com>
3332
3333         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3334         registers.
3335         (aarch64_pseudo_register_name): Likewise.
3336         (aarch64_pseudo_register_type): Likewise.
3337         (aarch64_pseudo_register_reggroup_p): Likewise.
3338         (aarch64_gdbarch_init): Add pauth registers.
3339         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3340         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3341         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3342         (struct gdbarch_tdep): Add regnum for ra_state.
3343
3344 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3345             Jiong Wang  <jiong.wang@arm.com>
3346
3347         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3348
3349 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3350             Jiong Wang  <jiong.wang@arm.com>
3351
3352         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3353         function.
3354         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3355         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3356         (aarch64_gdbarch_init): Add puth registers.
3357         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3358         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3359         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3360
3361 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3362             Jiong Wang  <jiong.wang@arm.com>
3363
3364         * aarch64-linux-nat.c
3365         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3366         * aarch64-linux-tdep.c
3367         (aarch64_linux_core_read_description): Likewise.
3368         (aarch64_linux_get_hwcap): New function.
3369         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3370         (aarch64_linux_get_hwcap): New declaration.
3371
3372 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3373             Jiong Wang  <jiong.wang@arm.com>
3374
3375         * aarch64-linux-nat.c
3376         (aarch64_linux_nat_target::read_description): Add pauth param.
3377         * aarch64-linux-tdep.c
3378         (aarch64_linux_core_read_description): Likewise.
3379         * aarch64-tdep.c (struct target_desc): Add in pauth.
3380         (aarch64_read_description): Add pauth param.
3381         (aarch64_gdbarch_init): Likewise.
3382         * aarch64-tdep.h (aarch64_read_description): Likewise.
3383         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3384         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3385         * features/Makefile: Add new files.
3386         * features/aarch64-pauth.c: New file.
3387         * features/aarch64-pauth.xml: New file.
3388
3389 2019-03-20  Tom Tromey  <tromey@adacore.com>
3390
3391         * infrun.c (handle_inferior_event): Rename from
3392         handle_inferior_event_1.  Create a scoped_value_mark.
3393         (handle_inferior_event): Remove.
3394
3395 2019-03-19  Tom Tromey  <tromey@adacore.com>
3396
3397         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3398         * infrun.h (print_stop_event): Add "displays" parameter.
3399         * infrun.c (print_stop_event): Add "displays" parameter.
3400
3401 2019-03-19  Pedro Alves  <palves@redhat.com>
3402
3403         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3404         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3405         to -1.  Fix TABs vs spaces.
3406         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3407         * tui/tui-out.h (tui_ui_out) Add intro comments.
3408         <m_line, m_start_of_line>: In-class initialize, and add describing
3409         comment.
3410
3411 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3412
3413         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3414         variable names.
3415         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3416
3417 2019-03-18  Pedro Alves  <palves@redhat.com>
3418             Eli Zaretskii <eliz@gnu.org>
3419
3420         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3421         m_line and m_start_of_line.
3422
3423 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3424
3425         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3426         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3427         it returns a newline.  This fixes a regression in TU mode, whereby
3428         the next line is output on the same screen line as the user input.
3429
3430 2019-03-18  Tom Tromey  <tromey@adacore.com>
3431
3432         * minsyms.c (minimal_symbol_reader::install): Remove call to
3433         obstack_blank.
3434
3435 2019-03-18  Pedro Alves  <palves@redhat.com>
3436
3437         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3438         New globals.
3439         (apply_style): New, factored out from ...
3440         (apply_ansi_escape): ... this.  Handle reverse video mode.
3441         (tui_set_reverse_mode): New function.
3442         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3443         * tui/tui-winsource.c (tui_show_source_line): Use
3444         tui_set_reverse_mode instead of setting A_STANDOUT.
3445         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3446         New setter methods.
3447
3448 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3449
3450         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3451         Handle tabs.
3452
3453 2019-03-18  Tom Tromey  <tromey@adacore.com>
3454
3455         * ada-lang.c (empty_array): Add "high" parameter.
3456         (ada_evaluate_subexp): Update.
3457
3458 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3459
3460         * unittests/string_view-selftests.c: Define
3461         _initialize_string_view_selftests unconditionally.
3462
3463 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3464
3465         PR gdb/24350
3466         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3467
3468 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3469
3470         PR gdb/24351
3471         * windows-nat.c (display_selector): Fix format specifiers.
3472
3473 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3474
3475         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3476         tui_refill_source_window instead of tui_refresh_win, to update the
3477         current execution line.  This fixes redisplay of the current line
3478         when stepping through the code with "next" or "step".
3479
3480 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3481
3482         * source-cache.c (source_cache::get_source_lines): Call
3483         find_source_lines to initialize s->nlines.  This fixes vertical
3484         scrolling of TUI source window when the DOWN arrow is pressed.
3485
3486 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3487
3488         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3489         linux-thread-db.c (_initialize_thread_db): Likewise.
3490
3491 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3492
3493         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3494         wclrtoeol in tui_show_source_line".  This reverts changes made in
3495         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3496
3497 2019-03-15  Tom Tromey  <tom@tromey.com>
3498
3499         * symtab.h (struct minimal_symbol): Derive from
3500         general_symbol_info.
3501         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3502         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3503         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3504         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3505         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3506         (MSYMBOL_SEARCH_NAME): Update.
3507         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3508         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3509         * minsyms.c (minimal_symbol_reader::record_full): Update.
3510
3511 2019-03-15  Tom Tromey  <tom@tromey.com>
3512
3513         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3514
3515 2019-03-15  Tom Tromey  <tom@tromey.com>
3516
3517         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3518         unique_xmalloc_ptr.
3519         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3520         Update.
3521         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3522         (build_minimal_symbol_hash_tables)
3523         (minimal_symbol_reader::install): Update.
3524
3525 2019-03-15  Tom Tromey  <tom@tromey.com>
3526
3527         * symtab.c (create_demangled_names_hash): Update.
3528         (symbol_set_names): Update.
3529         * objfiles.h (struct objfile_per_bfd_storage)
3530         <demangled_names_hash>: Now an htab_up.
3531         * objfiles.c (objfile_per_bfd_storage): Simplify.
3532
3533 2019-03-15  Tom Tromey  <tom@tromey.com>
3534
3535         * objfiles.h (struct objfile_per_bfd_storage): Declare
3536         destructor.
3537         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3538         New.
3539         (get_objfile_bfd_data): Use new.  Don't initialize
3540         language_of_main.
3541         (free_objfile_per_bfd_storage): Remove.
3542         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3543
3544 2019-03-15  Tom Tromey  <tom@tromey.com>
3545
3546         * symfile.c (reread_symbols): Update.
3547         * objfiles.c (objfile::objfile): Update.
3548         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3549         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3550         comment.
3551         (minimal_symbol_reader::install): Update.
3552         (terminate_minimal_symbol_table): Remove.
3553         * jit.c (jit_object_close_impl): Update.
3554
3555 2019-03-15  Tom Tromey  <tom@tromey.com>
3556
3557         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3558         initializations.
3559
3560 2019-03-15  Tom Tromey  <tom@tromey.com>
3561
3562         * objfiles.h (struct objfile_per_bfd_storage)
3563         <demangled_hash_languages>: Now a bitset.
3564         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3565         (lookup_minimal_symbol): Update.
3566
3567 2019-03-15  Tom Tromey  <tom@tromey.com>
3568
3569         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3570         Don't return the symbol.
3571         * coffread.c (record_minimal_symbol): Use record_full.
3572
3573 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3574
3575         The MS-Windows port of ncurses fails to switch to a color pair if
3576         one or both of the colors are the implicit default colors.  This
3577         change records the default colors when TUI is initialized, and
3578         then specifies them explicitly when a color pair uses the default
3579         colors.  This allows color styling in TUI mode on MS-Windows.
3580
3581         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3582         ncurses_norm_attr.
3583         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3584         colors in ncurses_norm_attr.
3585         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3586         "none", replace it with the default color recorded in
3587         ncurses_norm_attr.
3588
3589 2019-03-14  Tom Tromey  <tromey@adacore.com>
3590
3591         * source-cache.h (class source_cache) <get_source_lines>: Return
3592         std::string.
3593         * source-cache.c (source_cache::extract_lines): Handle case where
3594         first_pos==npos.  Return std::string.
3595         (source_cache::get_source_lines): Update.
3596
3597 2019-03-14  Tom Tromey  <tromey@adacore.com>
3598
3599         * NEWS: Add item for "style sources" commands.
3600         * source-cache.c (source_cache::get_source_lines): Check
3601         source_styling.
3602         * cli/cli-style.c (source_styling): New global.
3603         (_initialize_cli_style): Add "style sources" commands.
3604         (show_style_sources): New function.
3605         * cli/cli-style.h (source_styling): Declare.
3606
3607 2019-03-14  Pedro Alves  <palves@redhat.com>
3608             Tom Tromey  <tromey@adacore.com>
3609
3610         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3611         * tui/tui-winsource.c (tui_refill_source_window): New function,
3612         from...
3613         (tui_horizontal_source_scroll): ... here.  Move some logic.
3614         * cli/cli-style.c (set_style_enabled): Notify new observable.
3615         * tui/tui-hooks.c (tui_redisplay_source): New function.
3616         (tui_attach_detach_observers): Attach or detach
3617         tui_redisplay_source.
3618         * observable.h (source_styling_changed): New observable.
3619         * observable.c: Define source_styling_changed observable.
3620
3621 2019-03-13  Tom Tromey  <tromey@adacore.com>
3622
3623         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3624         (i386_gnu_nat_target::store_registers): Update.
3625         * target-debug.h (target_debug_print_std_string): New macro.
3626         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3627         * windows-tdep.c (display_one_tib): Update.
3628         * tui/tui-stack.c (tui_make_status_line): Update.
3629         * top.c (print_inferior_quit_action): Update.
3630         * thread.c (thr_try_catch_cmd): Update.
3631         (add_thread_with_info): Update.
3632         (thread_target_id_str): Update.
3633         (thr_try_catch_cmd): Update.
3634         (thread_command): Update.
3635         (thread_find_command): Update.
3636         * record-btrace.c (record_btrace_target::info_record)
3637         (record_btrace_resume_thread, record_btrace_target::resume)
3638         (record_btrace_cancel_resume, record_btrace_step_thread)
3639         (record_btrace_target::wait, record_btrace_target::wait)
3640         (record_btrace_target::wait, record_btrace_target::stop): Update.
3641         * progspace.c (print_program_space): Update.
3642         * process-stratum-target.c
3643         (process_stratum_target::thread_address_space): Update.
3644         * linux-fork.c (linux_fork_mourn_inferior)
3645         (detach_checkpoint_command, info_checkpoints_command)
3646         (linux_fork_context): Update.
3647         (linux_fork_detach): Update.
3648         (class scoped_switch_fork_info): Update.
3649         (delete_checkpoint_command): Update.
3650         * infrun.c (follow_fork_inferior): Update.
3651         (follow_fork_inferior): Update.
3652         (proceed_after_vfork_done): Update.
3653         (handle_vfork_child_exec_or_exit): Update.
3654         (follow_exec): Update.
3655         (displaced_step_prepare_throw): Update.
3656         (displaced_step_restore): Update.
3657         (start_step_over): Update.
3658         (resume_1): Update.
3659         (clear_proceed_status_thread): Update.
3660         (proceed): Update.
3661         (print_target_wait_results): Update.
3662         (do_target_wait): Update.
3663         (context_switch): Update.
3664         (stop_all_threads): Update.
3665         (restart_threads): Update.
3666         (finish_step_over): Update.
3667         (handle_signal_stop): Update.
3668         (switch_back_to_stepped_thread): Update.
3669         (keep_going_pass_signal): Update.
3670         (print_exited_reason): Update.
3671         (normal_stop): Update.
3672         * inferior.c (inferior_pid_to_str): Change return type.
3673         (print_selected_inferior): Update.
3674         (add_inferior): Update.
3675         (detach_inferior): Update.
3676         * dummy-frame.c (fprint_dummy_frames): Update.
3677         * dcache.c (dcache_info_1): Update.
3678         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3679         (btrace_fetch, btrace_clear): Update.
3680         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3681         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3682         type.
3683         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3684         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3685         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3686         * gdbarch.c, gdbarch.h: Rebuild.
3687         * gdbarch.sh (core_pid_to_str): Change return type.
3688         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3689         return type.
3690         (windows_nat_target::pid_to_str): Change return type.
3691         (windows_delete_thread): Update.
3692         (windows_nat_target::attach): Update.
3693         (windows_nat_target::files_info): Update.
3694         * target-delegates.c: Rebuild.
3695         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3696         return type.
3697         (sol_thread_target::pid_to_str): Change return type.
3698         * remote.c (class remote_target) <pid_to_str>: Change return
3699         type.
3700         (remote_target::pid_to_str): Change return type.
3701         (extended_remote_target::attach, remote_target::remote_stop_ns)
3702         (remote_target::remote_notif_remove_queued_reply)
3703         (remote_target::push_stop_reply, remote_target::disable_btrace):
3704         Update.
3705         (extended_remote_target::attach): Update.
3706         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3707         type.
3708         (gdbsim_target::pid_to_str): Change return type.
3709         * ravenscar-thread.c (struct ravenscar_thread_target)
3710         <pid_to_str>: Change return type.
3711         (ravenscar_thread_target::pid_to_str): Change return type.
3712         * procfs.c (class procfs_target) <pid_to_str>: Change return
3713         type.
3714         (procfs_target::pid_to_str): Change return type.
3715         (procfs_target::attach): Update.
3716         (procfs_target::detach): Update.
3717         (procfs_target::fetch_registers): Update.
3718         (procfs_target::store_registers): Update.
3719         (procfs_target::wait): Update.
3720         (procfs_target::files_info): Update.
3721         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3722         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3723         return type.
3724         (nto_procfs_target::pid_to_str): Change return type.
3725         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3726         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3727         return type.
3728         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3729         (exit_lwp): Update.
3730         (attach_proc_task_lwp_callback, get_detach_signal)
3731         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3732         (linux_nat_target::resume, wait_lwp, stop_callback)
3733         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3734         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3735         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3736         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3737         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3738         type.
3739         (inf_ptrace_target::attach): Update.
3740         (inf_ptrace_target::files_info): Update.
3741         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3742         type.
3743         (go32_nat_target::pid_to_str): Change return type.
3744         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3745         (gnu_nat_target::wait): Update.
3746         (gnu_nat_target::wait): Update.
3747         (gnu_nat_target::resume): Update.
3748         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3749         (fbsd_nat_target::wait): Update.
3750         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3751         type.
3752         (darwin_nat_target::attach): Update.
3753         * corelow.c (class core_target) <pid_to_str>: Change return type.
3754         (core_target::pid_to_str): Change return type.
3755         * target.c (normal_pid_to_str): Change return type.
3756         (default_pid_to_str): Likewise.
3757         (target_pid_to_str): Change return type.
3758         (target_translate_tls_address): Update.
3759         (target_announce_detach): Update.
3760         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3761         return type.
3762         (bsd_uthread_target::pid_to_str): Change return type.
3763         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3764         type.
3765         (bsd_kvm_target::pid_to_str): Change return type.
3766         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3767         return type.
3768         (aix_thread_target::pid_to_str): Change return type.
3769         * target.h (struct target_ops) <pid_to_str>: Change return type.
3770         (target_pid_to_str, normal_pid_to_str): Likewise.
3771         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3772         type.
3773         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3774         type.
3775         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3776         return type.
3777         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3778         type.
3779         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3780         type.
3781         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3782         return type.
3783
3784 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3785
3786         * NEWS: Mention that the new default MI version is 3.  Mention
3787         changes to the output of commands and events that deal with
3788         multi-location breakpoints.
3789         * breakpoint.c: Include "mi/mi-out.h".
3790         (print_one_breakpoint): Change output syntax if using MI version
3791         >= 3.
3792         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3793         New.
3794         (mi_multi_location_breakpoint_output_fixed): New.
3795         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3796         (mi_cmd_fix_multi_location_breakpoint_output): New.
3797         (mi_multi_location_breakpoint_output_fixed): New.
3798         * mi/mi-cmds.c (mi_cmds): Register command
3799         -fix-multi-location-breakpoint-output.
3800         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3801         interpreter "mi".
3802
3803 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3804
3805         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3806         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3807         instantiate mi_ui_out based on interpreter name.
3808         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3809         * mi/mi-main.c (mi_load_progress): Likewise.
3810
3811 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3812
3813         * NEWS: Combine separate "New targets" sections for 8.3.
3814
3815 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3816
3817         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3818         (ppcfbsd_init_abi): Install gdbarch
3819         "fetch_tls_load_module_address" and "get_thread_local_address"
3820         methods.
3821
3822 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3823
3824         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3825         (riscv_fbsd_init_abi): Install gdbarch
3826         "fetch_tls_load_module_address" and "get_thread_local_address"
3827         methods.
3828
3829 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3830
3831         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3832         (i386fbsd_init_abi): Install gdbarch
3833         "fetch_tls_load_module_address" and "get_thread_local_address"
3834         methods.
3835
3836 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3837
3838         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3839         (amd64fbsd_init_abi): Install gdbarch
3840         "fetch_tls_load_module_address" and "get_thread_local_address"
3841         methods.
3842
3843 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3844
3845         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3846         (struct fbsd_pspace_data): New type.
3847         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3848         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3849         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3850         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3851         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3852
3853 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3854
3855         * gdbtypes.c (lookup_struct_elt): New function.
3856         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3857         * gdbtypes.h (struct struct_elt): New type.
3858         (lookup_struct_elt): New prototype.
3859
3860 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3861
3862         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3863         remove disabled code block.
3864
3865 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3866
3867         * gdbarch.sh (get_thread_local_address): New method.
3868         * gdbarch.h, gdbarch.c: Regenerate.
3869         * target.c (target_translate_tls_address): Use
3870         gdbarch_get_thread_local_address if present instead of
3871         target::get_thread_local_address.
3872
3873 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3874
3875         * target.h (target::get_thread_local_address): Update comment.
3876
3877 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3878
3879         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3880         objfile->separate_debug_objfile_backlink if not NULL.
3881
3882 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3883
3884         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3885         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3886         (amd64bsd_store_inferior_registers): Likewise.
3887         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3888         Enable segment base registers.
3889         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3890         PT_GETFSBASE and PT_GETGSBASE.
3891         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3892         PT_SETGSBASE.
3893         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3894         segment base registers.
3895         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3896
3897 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3898
3899         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3900         Update calls to i386_target_description to add 'segments'
3901         parameter.
3902         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3903         add segment base registers.
3904         * arch/i386.c (i386_create_target_description): Add 'segments'
3905         parameter to enable segment base registers.
3906         * arch/i386.h (i386_create_target_description): Likewise.
3907         * features/i386/32bit-segments.xml: New file.
3908         * features/i386/32bit-segments.c: Generate.
3909         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3910         call to i386_target_description to add 'segments' parameter.
3911         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3912         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3913         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3914         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3915         if feature is present.
3916         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3917         Add 'segments' parameter to call to i386_target_description.
3918         (i386_target_description): Add 'segments' parameter to enable
3919         segment base registers.
3920         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3921         to call to i386_target_description.
3922         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3923         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3924         Define I386_NUM_REGS.
3925         (i386_target_description): Add 'segments' parameter to enable
3926         segment base registers.
3927
3928 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3929
3930         PR/24325
3931         * source-cache.c: #undef open and close, to avoid unresolved
3932         externals during linking.
3933
3934 2019-03-12  Tom Tromey  <tromey@adacore.com>
3935
3936         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3937         const.  Add initializers.
3938         (_initialize_remote): Don't initialize ptid globals.
3939
3940 2019-03-12  Pedro Alves  <palves@redhat.com>
3941
3942         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3943
3944 2019-03-12  Pedro Alves  <palves@redhat.com>
3945
3946         * cp-name-parser.y (main): Remove unused 'len' variable.
3947
3948 2019-03-12  Tom Tromey  <tromey@adacore.com>
3949
3950         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3951         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3952
3953 2019-03-12  Tom Tromey  <tromey@adacore.com>
3954
3955         * linux-nat.c (iterate_over_lwps): Update.
3956         (stop_callback): Remove parameter.
3957         (stop_wait_callback, detach_callback, resume_set_callback)
3958         (select_singlestep_lwp_callback, set_ignore_sigint)
3959         (status_callback, resumed_callback, resume_clear_callback)
3960         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3961         data parameter.
3962         (linux_nat_target::detach, linux_nat_target::resume)
3963         (linux_stop_and_wait_all_lwps, select_event_lwp)
3964         (linux_nat_filter_event, linux_nat_wait_1)
3965         (linux_nat_target::kill, linux_nat_target::stop)
3966         (linux_nat_target::stop): Update.
3967         (linux_nat_resume_callback): Change type.
3968         (resume_stopped_resumed_lwps, count_events_callback)
3969         (select_event_lwp_callback): Likewise.
3970         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3971         * arm-linux-nat.c (struct update_registers_data): Remove.
3972         (update_registers_callback): Change type.
3973         (arm_linux_insert_hw_breakpoint1): Update.
3974         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3975         parameter.
3976         (x86_linux_dr_set_addr): Update.
3977         (x86_linux_dr_set_control): Update.
3978         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3979         (iterate_over_lwps): Use gdb::function_view.
3980         * nat/aarch64-linux-hw-point.c (struct
3981         aarch64_dr_update_callback_param): Remove.
3982         (debug_reg_change_callback): Change type.
3983         (aarch64_notify_debug_reg_change): Update.
3984         * s390-linux-nat.c (s390_refresh_per_info): Update.
3985
3986 2019-03-11  Tom Tromey  <tromey@adacore.com>
3987
3988         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3989         redundant assignment to "this_cu".
3990
3991 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3992
3993         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3994
3995 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3996
3997         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3998         from...
3999         (rank_one_type): ... this.
4000
4001 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4002
4003         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4004         from...
4005         (rank_one_type): ... this.
4006
4007 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4008
4009         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4010         from...
4011         (rank_one_type): ... this.
4012
4013 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4014
4015         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4016         from...
4017         (rank_one_type): ... this.
4018
4019 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4020
4021         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4022         from...
4023         (rank_one_type): ... this.
4024
4025 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4026
4027         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4028         from...
4029         (rank_one_type): ... this.
4030
4031 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4032
4033         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4034         from...
4035         (rank_one_type): ... this.
4036
4037 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4038
4039         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4040         from...
4041         (rank_one_type): ... this.
4042
4043 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4044
4045         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4046         from...
4047         (rank_one_type): ... this.
4048
4049 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4050
4051         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4052         from...
4053         (rank_one_type): ... this.
4054
4055 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4056
4057         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4058         from...
4059         (rank_one_type): ... this.
4060
4061 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4062
4063         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4064         from...
4065         (rank_one_type): ... this.
4066
4067 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4068
4069         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4070         inferior-events' shows the example events.
4071
4072 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4073
4074         Support styling on native MS-Windows console
4075
4076         PR/24315
4077         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4078         on MS-Windows if $TERM is not defined.
4079
4080         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4081
4082         * posix-hdep.c (gdb_console_fputs):
4083         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4084         functions.
4085         * ui-file.h (gdb_console_fputs): Add prototype.
4086
4087         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4088         back to fputs only if the former returns zero.
4089
4090 2019-03-07  Tom Tromey  <tom@tromey.com>
4091
4092         * symmisc.c (print_symbol_bcache_statistics): Update.
4093         (print_objfile_statistics): Update.
4094         * symfile.c (allocate_symtab): Update.
4095         * stabsread.c: Don't include bcache.h.
4096         * psymtab.h (struct psymbol_bcache): Don't declare.
4097         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4098         (psymbol_bcache_init, psymbol_bcache_free)
4099         (psymbol_bcache_get_bcache): Don't declare.
4100         * psymtab.c (struct psymbol_bcache): Remove.
4101         (psymtab_storage::psymtab_storage): Update.
4102         (psymtab_storage::~psymtab_storage): Update.
4103         (psymbol_bcache_init, psymbol_bcache_free)
4104         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4105         (add_psymbol_to_bcache): Update.
4106         (allocate_psymtab): Update.
4107         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4108         macro_cache>: No longer pointers.
4109         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4110         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4111         * macrotab.c (macro_bcache): Update.
4112         * macroexp.c: Don't include bcache.h.
4113         * gdbtypes.c (check_types_worklist): Update.
4114         (types_deeply_equal): Remove TRY/CATCH.  Update.
4115         * elfread.c (elf_symtab_read): Update.
4116         * dwarf2read.c: Don't include bcache.h.
4117         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4118         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4119         (print_bcache_statistics, bcache_memory_used): Don't declare.
4120         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4121         methods.  Rename all data members.
4122         * bcache.c (struct bcache): Move to bcache.h.
4123         (bcache::expand_hash_table): Rename from expand_hash_table.
4124         (bcache): Remove.
4125         (bcache::insert): Rename from bcache_full.
4126         (bcache::compare): Rename from bcache_compare.
4127         (bcache_xmalloc): Remove.
4128         (bcache::~bcache): Rename from bcache_xfree.
4129         (bcache::print_statistics): Rename from print_bcache_statistics.
4130         (bcache::memory_used): Rename from bcache_memory_used.
4131
4132 2019-03-07  Pedro Alves  <palves@redhat.com>
4133
4134         * infrun.c (normal_stop): Also check for
4135         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4136
4137 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4138
4139         * f-lang.c (value_from_host_double): Moved to...
4140         * value.c (value_from_host_double): ...here.
4141         * value.h (value_from_host_double): Declare.
4142         * guile/scm-math.c (vlscm_convert_typed_number): Use
4143         value_from_host_double.
4144         (vlscm_convert_number): Likewise.
4145         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4146         * python/py-value.c (convert_value_from_python): Likewise.
4147
4148 2019-03-06  Tom Tromey  <tom@tromey.com>
4149
4150         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4151
4152 2019-03-06  Tom Tromey  <tom@tromey.com>
4153
4154         * utils.h (free_current_contents): Don't declare.
4155         * utils.c (free_current_contents): Remove.
4156
4157 2019-03-06  Tom Tromey  <tom@tromey.com>
4158
4159         * top.c (quit_force): Update.
4160         * main.c (captured_command_loop): Update.
4161         * common/new-op.c (operator new): Update.
4162         * common/common-exceptions.c (struct catcher)
4163         <save_cleanup_chain>: Remove member.
4164         (exceptions_state_mc_init): Update.
4165         (exception_try_scope_entry): Return nullptr.
4166         (exception_try_scope_exit, exception_rethrow)
4167         (throw_exception_sjlj, throw_exception_cxx): Update.
4168         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4169         (all_cleanups, do_cleanups, discard_cleanups)
4170         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4171         (restore_cleanups, restore_final_cleanups): Don't declare.
4172         (do_final_cleanups): Remove parameter.
4173         * common/cleanups.c (cleanup_chain, make_cleanup)
4174         (make_cleanup_dtor, all_cleanups, do_cleanups)
4175         (discard_my_cleanups, discard_cleanups)
4176         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4177         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4178         (null_cleanup): Remove.
4179         (do_final_cleanups): Remove parameter.
4180
4181 2019-03-06  Tom Tromey  <tom@tromey.com>
4182
4183         * remote.c (remote_target::remote_parse_stop_reply): Use
4184         unique_xmalloc_ptr.
4185
4186 2019-03-06  Tom Tromey  <tom@tromey.com>
4187
4188         * stabsread.c (struct stabs_field_info): Rename from field_info.
4189         <list, fnlist>: Add initializers.
4190         <obstack>: New member.
4191         (read_member_functions, read_struct_fields, read_baseclasses):
4192         Allocate on obstack.  Don't use cleanups.
4193         (read_one_struct_field, read_member_functions, read_struct_fields)
4194         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4195         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4196         (read_struct_type): Update.
4197
4198 2019-03-06  Tom Tromey  <tom@tromey.com>
4199
4200         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4201         * common/filestuff.h (make_cleanup_close): Don't declare.
4202         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4203         Remove.
4204
4205 2019-03-06  Tom Tromey  <tom@tromey.com>
4206
4207         * solib-aix.c: Use make_scope_exit.
4208
4209 2019-03-06  Tom Tromey  <tom@tromey.com>
4210
4211         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4212         Use make_scope_exit.
4213
4214 2019-03-06  Tom Tromey  <tom@tromey.com>
4215
4216         * solib-svr4.c (disable_probes_interface): Remove parameter.
4217         (svr4_handle_solib_event): Use make_scope_exit.
4218
4219 2019-03-06  Tom Tromey  <tom@tromey.com>
4220
4221         * remote.c (struct stop_reply_deleter): Remove.
4222         (stop_reply_up): Update.
4223         (struct stop_reply): Derive from notif_event.  Don't typedef.
4224         <regcache>: Now a std::vector.
4225         (stop_reply_xfree): Remove.
4226         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4227         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4228         (remote_target::discard_pending_stop_replies): Use delete.
4229         (remote_target::remote_parse_stop_reply): Update.
4230         (remote_target::process_stop_reply): Update.
4231         * remote-notif.h (struct notif_event): Add virtual destructor.
4232         Remove "dtr" member.
4233         (struct notif_client) <alloc_event>: Return a unique_ptr.
4234         (notif_event_xfree): Don't declare.
4235         (notif_event_up): New typedef.
4236         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4237         (notif_event_xfree, do_notif_event_xfree): Remove.
4238         (remote_notif_state_xfree): Update.
4239
4240 2019-03-06  Tom Tromey  <tom@tromey.com>
4241
4242         * infrun.c (displaced_step_clear_cleanup): Now a
4243         forward_scope_exit type.
4244         (displaced_step_prepare_throw): Update.
4245         (displaced_step_fixup): Update.
4246
4247 2019-03-06  Tom Tromey  <tom@tromey.com>
4248
4249         * inferior.h (class inferior): Update comment.
4250         * gdbthread.h (class thread_info): Update comment.
4251
4252 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4253             Tom Tromey  <tom@tromey.com>
4254
4255         * stabsread.h (struct stab_section_list): Remove.
4256         (coffstab_build_psymtabs): Update.
4257         * dbxread.c (symbuf_sections): Now a std::vector.
4258         (sect_idx): New global.
4259         (fill_symbuf): Update.
4260         (coffstab_build_psymtabs): Change type of stabsects parameter.
4261         Update.
4262         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4263         std::vector.
4264         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4265         (coff_locate_sections): Update.
4266         (coff_symfile_read): Remove cleanups.  Update.
4267         (init_stringtab): Add storage parameter.
4268         (free_stringtab, free_stringtab_cleanup): Remove.
4269         (init_lineno): Add storage parameter.
4270         (free_linetab, free_linetab_cleanup): Remove.
4271
4272 2019-03-06  Pedro Alves  <palves@redhat.com>
4273
4274         * linux-fork.c (fork_info::clobber_regs): Delete.
4275         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4276         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4277         comment.  Adjust.
4278         (scoped_switch_fork_info::scoped_switch_fork_info)
4279         (checkpoint_command, linux_fork_context): Adjust
4280         fork_save_infrun_state calls.
4281
4282 2019-03-06  Pedro Alves  <palves@redhat.com>
4283
4284         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4285         (inf_has_multiple_threads): Return 'bool' and rewrite using
4286         inferior_info::threads().
4287
4288 2019-03-06  Pedro Alves  <palves@redhat.com>
4289
4290         * linux-fork.c: Include <list>.
4291         (fork_list): Now a std::list instance.
4292         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4293         (forks_exist_p, find_last_fork): Adjust.
4294         (new_fork): Delete.
4295         (one_fork_p): New.
4296         (add_fork): Adjust.
4297         (free_fork): Delete, folded into fork_info::~fork_info().
4298         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4299         Adjust.
4300         (init_fork_list): Delete.
4301         (linux_fork_killall, linux_fork_mourn_inferior)
4302         (linux_fork_detach, info_checkpoints_command): Adjust.
4303         (_initialize_linux_fork): No longer call init_fork_list.
4304
4305 2019-03-06  Pedro Alves  <palves@redhat.com>
4306
4307         * linux-fork.c (new_fork): New, split out of ...
4308         (add_fork): ... this.  Return void.  Move "first fork" special
4309         case from here, to ...
4310         (checkpoint_command): ... here.
4311         * linux-linux.h (add_fork): Return void.
4312
4313 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4314
4315         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4316
4317 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4318             Chris January  <chris.january@arm.com>
4319             David Lecomber  <david.lecomber@arm.com>
4320
4321         * f-exp.y: New token, UNOP_INTRINSIC.
4322         (exp): New pattern using UNOP_INTRINSIC token.
4323         (f77_keywords): Add 'abs' keyword.
4324         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4325         (value_from_host_double): New function.
4326         (evaluate_subexp_f): Support UNOP_ABS.
4327
4328 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4329
4330         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4331         types.
4332
4333 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4334
4335         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4336         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4337         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4338
4339 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4340
4341         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4342
4343 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4344             Chris January  <chris.january@arm.com>
4345
4346         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4347         * f-exp.y: Define 'KIND' token.
4348         (exp): New pattern for KIND expressions.
4349         (ptype): Handle types with a kind extension.
4350         (direct_abs_decl): Extend to spot kind extensions.
4351         (f77_keywords): Add 'kind' to the list.
4352         (push_kind_type): New function.
4353         (convert_to_kind_type): New function.
4354         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4355         * parse.c (operator_length_standard): Likewise.
4356         * parser-defs.h (enum type_pieces): Add tp_kind.
4357         * std-operator.def: Add UNOP_KIND.
4358
4359 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4360
4361         * f-exp.y (f_parse): Set yydebug.
4362
4363 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4364
4365         * f-lang.c (evaluate_subexp_f): New function.
4366         (exp_descriptor_f): New global.
4367         (f_language_defn): Use exp_descriptor_f instead of
4368         exp_descriptor_standard.
4369
4370 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4371
4372         * f-exp.y (struct token): Add comments.
4373         (dot_ops): Remove uppercase versions and the end marker.
4374         (f77_keywords): Likewise.
4375         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4376         entries in the dot_ops array are case insensitive, and use
4377         strncasecmp to compare strings.  Also some whitespace cleanup in
4378         this area.  Similar for the f77_keywords array, except entries in
4379         this list might be case sensitive.
4380
4381 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4382
4383         * f-exp.y (struct f77_boolean_val): Add comments.
4384         (boolean_values): Remove uppercase versions, and end marker.
4385         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4386         and use strncasecmp to achieve case insensitivity.  Additionally,
4387         perform whitespace cleanup around this code.
4388
4389 2019-03-06  Tom Tromey  <tromey@adacore.com>
4390
4391         * remote-sim.c (gdbsim_target_open): Use result of
4392         gdb_argv::release.
4393
4394 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4395         Dirk Schubert  <dirk.schubert@arm.com>
4396         Chris January  <chris.january@arm.com>
4397
4398         * eval.c (evaluate_subexp_standard): Call Fortran argument
4399         wrapping logic.
4400         * f-lang.c (struct value): A value which can be passed into a
4401         Fortran function call.
4402         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4403         where appropriate.
4404         (struct type): Value ready for a Fortran function call.
4405         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4406         is needed.
4407         * f-lang.h (fortran_argument_convert): Declaration.
4408         (fortran_preserve_arg_pointer): Declaration.
4409         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4410
4411 2019-03-05  Tom Tromey  <tromey@adacore.com>
4412
4413         * python/py-prettyprint.c (print_string_repr): Remove #if.
4414         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4415
4416 2019-03-05  Tom Tromey  <tromey@adacore.com>
4417
4418         * target.c (the_dummy_target): Move later.  Change type to
4419         "dummy_target".
4420         (initialize_targets): Don't initialize the_dummy_target.
4421
4422 2019-03-05  Tom Tromey  <tromey@adacore.com>
4423
4424         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4425         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4426
4427 2019-03-05  Tom Tromey  <tromey@adacore.com>
4428
4429         * windows-nat.c (windows_nat_target::attach)
4430         (windows_nat_target::detach): Don't call gdb_flush.
4431         * valprint.c (generic_val_print, val_print, val_print_string):
4432         Don't call gdb_flush.
4433         * utils.c (defaulted_query): Don't call gdb_flush.
4434         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4435         * target.c (target_announce_detach): Don't call gdb_flush.
4436         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4437         * remote.c (extended_remote_target::attach): Don't call
4438         gdb_flush.
4439         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4440         * printcmd.c (do_examine): Don't call gdb_flush.
4441         (info_display_command): Don't call gdb_flush.
4442         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4443         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4444         * memattr.c (info_mem_command): Don't call gdb_flush.
4445         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4446         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4447         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4448         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4449         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4450         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4451         (gnu_nat_target::detach): Don't call gdb_flush.
4452         * f-valprint.c (f_val_print): Don't call gdb_flush.
4453         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4454         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4455         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4456         gdb_flush.
4457         * c-valprint.c (c_val_print): Don't call gdb_flush.
4458         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4459
4460 2019-03-05  Tom Tromey  <tromey@adacore.com>
4461
4462         * varobj.c (update_dynamic_varobj_children): Update.
4463         (install_default_visualizer): Use reset, not release.
4464         * value.c (set_internalvar): Update.
4465         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4466         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4467         ATTRIBUTE_UNUSED_RESULT.
4468
4469 2019-03-05  Tom Tromey  <tromey@adacore.com>
4470
4471         * remote.c (class scoped_remote_fd) <release>: Add
4472         ATTRIBUTE_UNUSED_RESULT.
4473
4474 2019-03-05  Tom Tromey  <tromey@adacore.com>
4475
4476         * macroexp.c (struct macro_buffer) <release>: Add
4477         ATTRIBUTE_UNUSED_RESULT.
4478
4479 2019-03-05  Tom Tromey  <tromey@adacore.com>
4480
4481         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4482         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4483         ATTRIBUTE_UNUSED_RESULT.
4484
4485 2019-03-05  Tom Tromey  <tromey@adacore.com>
4486
4487         * common/scoped_fd.h (class scoped_fd) <release>: Add
4488         ATTRIBUTE_UNUSED_RESULT.
4489
4490 2019-03-05  Tom Tromey  <tromey@adacore.com>
4491
4492         * parser-defs.h (struct parser_state) <release>: Add
4493         ATTRIBUTE_UNUSED_RESULT.
4494
4495 2019-03-05  Tom Tromey  <tromey@adacore.com>
4496
4497         * utils.h (class gdb_argv) <release>: Add
4498         ATTRIBUTE_UNUSED_RESULT.
4499         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4500
4501 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4502
4503         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4504         for-loop range, to avoid compiler warnings.
4505
4506         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4507         avoid compiler warnings about unused variables.
4508
4509         * NEWS: Mention end of support for native debugging on MS-Windows
4510         before XP.
4511
4512         PR gdb/24292
4513         * common/netstuff.c:
4514         * gdbserver/gdbreplay.c
4515         * gdbserver/remote-utils.c:
4516         * ser-tcp.c:
4517         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4518         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4519         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4520         'getaddrinfo' and 'freeaddrinfo' were not available before
4521         Windows XP, and mingw.org's MinGW headers by default define
4522         _WIN32_WINNT to 0x500.
4523
4524 2019-03-01  Gary Benson <gbenson@redhat.com>
4525
4526         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4527
4528 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4529             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4530
4531         PR gdb/8527
4532         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4533         set_sigint_trap, clear_sigint_trap.
4534
4535 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4536
4537         * target.c (target_detach): Clear the regcache and the
4538         frame cache.
4539
4540 2019-02-27  Pedro Alves  <palves@redhat.com>
4541
4542         * utils.c (set_screen_size): When we cap the height/width sizes,
4543         tweak the corresponding command variable to show "unlimited":
4544
4545 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4546             Pedro Alves  <palves@redhat.com>
4547
4548         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4549         before calling rl_set_screen_size.
4550
4551 2019-02-27  Tom Tromey  <tromey@adacore.com>
4552
4553         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4554         define.
4555         * python/py-value.c: Remove Python 2.4 workaround.
4556         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4557         workaround.
4558         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4559         Python 2.4 workaround.
4560         * python/python-internal.h: Remove Python 2.4 comment.
4561         (Py_ssize_t): Don't define.
4562         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4563         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4564         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4565         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4566         * python/python.c (do_start_initialization): Remove Python 2.4
4567         workaround.
4568         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4569         (print_children): Remove Python 2.4 workaround.
4570         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4571         workaround.
4572         (CHARBUFFERPROC_NAME): Remove.
4573         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4574         Python 2.4 workaround.
4575
4576 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4577
4578         * NEWS: Note minimum Python version.
4579
4580 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4581
4582         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4583         code from these functions.  Remove corresponding ifdefs.  Use
4584         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4585         Remove gotos and target of gotos.
4586         (infpy_search_memory): Likewise.
4587
4588 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4589
4590         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4591         (hppa_gdbarch_init): Don't register deleted functions with
4592         gdbarch.
4593
4594 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4595
4596         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4597         (h8300_unwind_sp): Delete.
4598         (h8300_dummy_id): Delete.
4599         (h8300_gdbarch_init): Don't register deleted functions with
4600         gdbarch.
4601
4602 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4603
4604         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4605         (ft32_unwind_pc): Delete.
4606         (ft32_unwind_sp): Delete.
4607         (ft32_gdbarch_init): Don't register deleted functions with
4608         gdbarch.
4609
4610 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4611
4612         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4613         (frv_unwind_pc): Delete.
4614         (frv_unwind_sp): Delete.
4615         (frv_gdbarch_init): Don't register deleted functions with
4616         gdbarch.
4617
4618 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4619
4620         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4621         (riscv_unwind_pc): Delete.
4622         (riscv_unwind_sp): Delete.
4623         (riscv_gdbarch_init): Don't register deleted functions with
4624         gdbarch.
4625
4626 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4627
4628         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4629         (csky_unwind_pc): Delete.
4630         (csky_unwind_sp): Delete.
4631         (csky_gdbarch_init): Don't register deleted functions with
4632         gdbarch.
4633
4634 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4635
4636         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4637         (cris_unwind_pc): Delete.
4638         (cris_unwind_sp): Delete.
4639         (cris_gdbarch_init): Don't register deleted functions with
4640         gdbarch.
4641
4642 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4643
4644         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4645         (bfin_unwind_pc): Delete.
4646         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4647
4648 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4649
4650         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4651         (arm_unwind_pc): Delete.
4652         (arm_unwind_sp): Delete.
4653         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4654
4655 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4656
4657         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4658         (arc_unwind_pc): Delete.
4659         (arc_unwind_sp): Delete.
4660         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4661
4662 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4663
4664         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4665         (alpha_unwind_pc): Delete.
4666         (alpha_gdbarch_init): Don't register deleted functions with
4667         gdbarch.
4668
4669 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4670
4671         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4672         (aarch64_unwind_pc): Delete.
4673         (aarch64_unwind_sp): Delete.
4674         (aarch64_gdbarch_init): Don't register deleted functions with
4675         gdbarch.
4676
4677 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4678
4679         * gdbtypes.c (type_align): Don't consider static members when
4680         computing structure alignment.
4681
4682 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4683
4684         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4685         return 0 for other types.
4686         * arch-utils.c (default_type_align): Always return 0.
4687         * gdbarch.h: Regenerate.
4688         * gdbarch.sh (type_align): Extend comment.
4689         * gdbtypes.c (type_align): Add additional comments, always call
4690         gdbarch_type_align before applying the default rules.
4691         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4692         generic code will then apply a suitable default.
4693         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4694         types, return 0 for other types.
4695
4696 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4697
4698         * NEWS: Create a new section for the next release branch.
4699         Rename the section of the current branch, now that it has
4700         been cut.
4701
4702 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4703
4704         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4705         * version.in: Bump version to 8.3.50.DATE-git.
4706
4707 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4708
4709         * aix-thread.c (ptid_cmp): Remove unused variable.
4710         (get_signaled_thread): Likewise.
4711         (store_regs_user_thread): Likewise.
4712         (store_regs_kernel_thread): Likewise.
4713         (fetch_regs_kernel_thread): Remove shadowed variable.
4714
4715 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4716
4717         * features/riscv/32bit-cpu.xml: Add register numbers.
4718         * features/riscv/32bit-fpu.c: Regenerate.
4719         * features/riscv/32bit-fpu.xml: Add register numbers.
4720         * features/riscv/64bit-cpu.xml: Add register numbers.
4721         * features/riscv/64bit-fpu.c: Regenerate.
4722         * features/riscv/64bit-fpu.xml: Add register numbers.
4723
4724 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4725
4726         * NEWS: Mention two argument form of gdb.Value constructor.
4727         * python/py-value.c (convert_buffer_and_type_to_value): New
4728         function.
4729         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4730         Add support for handling an optional second argument.  Call
4731         convert_buffer_and_type_to_value as appropriate.
4732         * python/python-internal.h (Py_buffer_deleter): New struct.
4733         (Py_buffer_up): New typedef.
4734
4735 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4736
4737         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4738         instead of releasing ownership.
4739
4740 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4741
4742         * dwarf2read.c (open_and_init_dwp_file): Call
4743         elf_numsections instead of bfd_count_sections to initialize
4744         dwp_file->num_sections.
4745
4746 2019-02-25  Tom Tromey  <tromey@adacore.com>
4747
4748         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4749
4750 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4751
4752         * gcore.in: Add '--readnever' option when invoking GDB.
4753
4754 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4755
4756         * MAINTAINERS: Update my email address.
4757
4758 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4759
4760         * build-id.c (build_id_to_debug_bfd_1): New function.
4761         (build_id_to_debug_bfd): Look for separate debug file in
4762         sysroot.
4763
4764 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4765
4766         * gdbarch.sh: Update the copyright year range that is placed into
4767         generated files.
4768
4769 2019-02-22  Keith Seitz  <keiths@redhat.com>
4770
4771         PR symtab/23853
4772         * linespec.c (create_sals_line_offset): Search for the default
4773         symtab's filename instead of its fullname.
4774
4775 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4776
4777         * NEWS: Update style defaults.
4778
4779 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4780
4781         * main.c (captured_main_1): Disable styling in batch mode.
4782
4783 2019-02-20  Tom Tromey  <tom@tromey.com>
4784
4785         * symtab.c (symtab_symbol_info): Fix typos.
4786
4787 2019-02-20  Tom Tromey  <tromey@adacore.com>
4788
4789         * findcmd.c (_initialize_mem_search): Use upper case for
4790         metasyntactic variables.
4791
4792 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4793
4794         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4795         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4796
4797 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4798
4799         * top.h (source_file_name): Change to std::string.
4800         * top.c (source_file_name): Likewise.
4801         (command_line_input): Adjust.
4802         * cli/cli-script.c (script_from_file): Adjust.
4803
4804 2019-02-19  Tom Tromey  <tromey@adacore.com>
4805
4806         * ravenscar-thread.c
4807         (ravenscar_thread_target::update_thread_list): Don't call
4808         ada_build_task_list.
4809         * ada-lang.h (ada_build_task_list): Don't declare.
4810         * ada-tasks.c (struct ada_tasks_inferior_data)
4811         <task_list_valid_p>: Now bool.
4812         (read_known_tasks, ada_task_list_changed)
4813         (ada_tasks_invalidate_inferior_data): Update.
4814         (read_known_tasks_array): Return bool.
4815         (read_known_tasks_list): Likewise.
4816         (read_known_tasks): Return void.
4817         (ada_build_task_list): Now static.
4818
4819 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4820
4821         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4822         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4823
4824 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4825
4826         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4827         variant for ada_tasks_pspace_data_handle and
4828         ada_tasks_inferior_data_handle.
4829         (ada_tasks_pspace_data_cleanup): New function.
4830         (ada_tasks_inferior_data_cleanup): New function.
4831
4832 2019-02-17  Tom Tromey  <tom@tromey.com>
4833
4834         * macrotab.h (macro_source_fullname): Return a std::string.
4835         * macrotab.c (macro_include, check_for_redefinition)
4836         (macro_undef, macro_lookup_definition, foreach_macro)
4837         (foreach_macro_in_scope): Update.
4838         (macro_source_fullname): Return a std::string.
4839         * macrocmd.c (show_pp_source_pos): Update.
4840
4841 2019-02-17  Tom Tromey  <tom@tromey.com>
4842
4843         * macrocmd.c (show_pp_source_pos): Style the file names.
4844
4845 2019-02-17  Tom Tromey  <tom@tromey.com>
4846
4847         PR tui/24197:
4848         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4849
4850 2019-02-17  Tom Tromey  <tom@tromey.com>
4851
4852         * ada-lang.c (user_select_syms): Use filtered printing.
4853         * utils.c (wrap_style): New global.
4854         (desired_style): Remove.
4855         (emit_style_escape): Add stream parameter.
4856         (set_output_style, reset_terminal_style, prompt_for_continue):
4857         Update.
4858         (flush_wrap_buffer): Only flush gdb_stdout.
4859         (wrap_here): Set wrap_style.
4860         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4861         treat escape sequences as a character.  Change when wrap buffer is
4862         flushed.
4863         (fputs_styled): Do not set the output style when the default is
4864         requested.
4865         * ui-style.h (struct ui_file_style) <is_default>: New method.
4866         * source.c (print_source_lines_base): Emit escape sequences in one
4867         piece.
4868
4869 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4870
4871         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4872         integers and enumeration types.
4873
4874 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4875
4876         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4877         instead of lookup_symbol_in_language
4878         (do_exact_match): New function.
4879         (ada_get_symbol_name_matcher): Return do_exact_match when
4880         doing a verbatim match.
4881
4882 2019-02-15  Tom Tromey  <tromey@adacore.com>
4883
4884         * ravenscar-thread.c (ravenscar_thread_target::resume)
4885         (ravenscar_thread_target::wait): Special case wildcard requests.
4886
4887 2019-02-15  Tom Tromey  <tromey@adacore.com>
4888
4889         * ravenscar-thread.c (base_ptid): Remove.
4890         (struct ravenscar_thread_target) <close>: New method.
4891         <m_base_ptid>: New member.
4892         <update_inferior_ptid, active_task, task_is_currently_active,
4893         runtime_initialized>: Declare methods.
4894         <ravenscar_thread_target>: Add constructor.
4895         (ravenscar_thread_target::task_is_currently_active)
4896         (ravenscar_thread_target::update_inferior_ptid)
4897         (ravenscar_runtime_initialized): Rename.  Now methods.
4898         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4899         (ravenscar_thread_target::update_thread_list): Update.
4900         (ravenscar_thread_target::active_task): Now method.
4901         (ravenscar_thread_target::store_registers)
4902         (ravenscar_thread_target::prepare_to_store)
4903         (ravenscar_thread_target::prepare_to_store)
4904         (ravenscar_thread_target::mourn_inferior): Update.
4905         (ravenscar_inferior_created): Use "new" to create target.
4906         (ravenscar_thread_target::get_ada_task_ptid): Update.
4907         (_initialize_ravenscar): Don't initialize base_ptid.
4908         (ravenscar_ops): Remove global.
4909
4910 2019-02-15  Tom Tromey  <tromey@adacore.com>
4911
4912         * target.h (push_target): Declare new overload.
4913         * target.c (push_target): New overload, taking an rvalue reference.
4914         * remote.c (remote_target::open_1): Use push_target overload.
4915         * corelow.c (core_target_open): Use push_target overload.
4916
4917 2019-02-15  Tom Tromey  <tromey@adacore.com>
4918
4919         * ravenscar-thread.c (is_ravenscar_task)
4920         (ravenscar_task_is_currently_active): Return bool.
4921         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4922         (_initialize_ravenscar): Remove "(void)".
4923         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4924         Return bool.
4925
4926 2019-02-15  Tom Tromey  <tromey@adacore.com>
4927
4928         * ravenscar-thread.c (ravenscar_runtime_initializer)
4929         (has_ravenscar_runtime, get_running_thread_id)
4930         (ravenscar_thread_target::resume): Fix indentation.
4931
4932 2019-02-15  Tom Tromey  <tromey@adacore.com>
4933
4934         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4935         from ravenscar_arch_ops.
4936         (sparc_ravenscar_ops::fetch_registers)
4937         (sparc_ravenscar_ops::store_registers): Now methods.
4938         (sparc_ravenscar_prepare_to_store): Remove.
4939         (sparc_ravenscar_ops): Redefine.
4940         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4941         methods and destructor.  Remove members.
4942         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4943         (ravenscar_thread_target::store_registers)
4944         (ravenscar_thread_target::prepare_to_store): Update.
4945         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4946         Remove.
4947         (struct ppc_ravenscar_powerpc_ops): Derive from
4948         ravenscar_arch_ops.
4949         (ppc_ravenscar_powerpc_ops::fetch_registers)
4950         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4951         (ppc_ravenscar_powerpc_ops): Redefine.
4952         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4953         (ppc_ravenscar_e500_ops::fetch_registers)
4954         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4955         (ppc_ravenscar_e500_ops): Redefine.
4956         * aarch64-ravenscar-thread.c
4957         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4958         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4959         (aarch64_ravenscar_fetch_registers)
4960         (aarch64_ravenscar_store_registers): Now methods.
4961         (aarch64_ravenscar_ops): Redefine.
4962
4963 2019-02-15  Tom Tromey  <tromey@adacore.com>
4964
4965         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4966         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4967         (ravenscar_thread_target::stopped_by_watchpoint)
4968         (ravenscar_thread_target::stopped_data_address)
4969         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4970
4971 2019-02-15  Tom Tromey  <tromey@adacore.com>
4972
4973         * ravenscar-thread.c: Fix some typos.
4974
4975 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4976             Tom Tromey  <tromey@adacore.com>
4977
4978         * ada-lang.c (ada_exception_sal): Change addr_string to a
4979         std::string.
4980         (create_ada_exception_catchpoint): Update.
4981
4982 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4983             Tom Tromey  <tromey@adacore.com>
4984
4985         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4986         (bp_location_ops): Remove.
4987         (base_breakpoint_allocate_location): Update.
4988         (free_bp_location): Update.
4989         * ada-lang.c (class ada_catchpoint_location)
4990         <ada_catchpoint_location>: Remove ops parameter.
4991         (ada_catchpoint_location_dtor): Remove.
4992         (ada_catchpoint_location_ops): Remove.
4993         (allocate_location_exception): Update.
4994         * breakpoint.h (struct bp_location_ops): Remove.
4995         (class bp_location) <bp_location>: Remove bp_location_ops
4996         parameter.
4997         <~bp_location>: Add destructor.
4998         <ops>: Remove.
4999
5000 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5001             Pedro Alves  <palves@redhat.com>
5002
5003         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5004         'PATH_MAX'.
5005
5006 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5007             Samuel Thibault  <samuel.thibault@gnu.org>
5008             Thomas Schwinge  <thomas@codesourcery.com>
5009
5010         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5011         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5012
5013 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5014
5015         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5016         (check_empty): Use "const char *".
5017
5018         * gnu-nat.c (gnu_nat_target::detach): Instead of
5019         'detach_inferior (pid)' call
5020         'detach_inferior (find_inferior_pid (pid))'.
5021
5022         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5023         'nat/fork-inferior.o'.
5024         * gnu-nat.c: #include "nat/fork-inferior.h".
5025
5026         * gnu-nat.c (gnu_nat_target::detach): Instead of
5027         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5028         * gnu-nat.h: #include "inf-child.h".
5029         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5030         'i386_gnu_nat_target::fetch_registers'.
5031         (gnu_store_registers): Rename/move to
5032         'i386_gnu_nat_target::store_registers'.
5033
5034         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5035         * gnu-nat.h (mach_thread_info): New function.
5036         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5037
5038         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5039
5040 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5041
5042         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5043
5044 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5045
5046         * windows-nat.c (windows_add_thread): Add new parameter
5047         "main_thread_p" with default value set to false.  Update
5048         function documentation as well as all callers.
5049         (windows_delete_thread): Likewise.
5050         (fake_create_process): Update call to windows_add_thread.
5051         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5052         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5053         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5054         call to windows_delete_thread.
5055
5056 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5057
5058         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5059
5060 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5061
5062         * symfile.c (find_separate_debug_file): Use canonical path of
5063         sysroot with child_path instead of gdb_sysroot if it is valid.
5064
5065 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5066
5067         * symfile.c (find_separate_debug_file): Use child_path to
5068         determine if an object file is under a sysroot.
5069
5070 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5071
5072         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5073         unittests/child-path-selftests.c.
5074         * common/pathstuff.c (child_path): New function.
5075         * common/pathstuff.h (child_path): New prototype.
5076         * unittests/child-path-selftests.c: New file.
5077
5078 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5079
5080         * symfile.c (find_separate_debug_file): Look for separate debug
5081         files in debug directories under the sysroot.
5082
5083 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5084
5085         * symtab.h (struct minimal_symbol data_p): New const method.
5086         (struct minimal_symbol text_p): Likewise.
5087         * symtab.c (output_source_filename): Use file name style
5088         to print file name.
5089         (print_symbol_info): Likewise.
5090         (print_msymbol_info): Use address style to print addresses.
5091         Use function name style to print executable text symbols.
5092         (expand_symtab_containing_pc): Use data_p.
5093         (find_pc_sect_compunit_symtab): Likewise.
5094
5095 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5096
5097         * breakpoint.c (describe_other_breakpoints): Use address style
5098         to print addresses.
5099         (say_where): Likewise.
5100
5101 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5102
5103         * ada-typeprint.c (print_func_type): Print function name
5104         style to print function name.
5105         * c-typeprint.c (c_print_type_1): Likewise.
5106
5107 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5108
5109         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5110         for execve.
5111
5112 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5113
5114         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5115         type_stack.
5116
5117 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5118
5119         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5120         TYPE_CODE_REF types.
5121
5122 2019-02-08  Jim Wilson  <jimw@sifive.com>
5123
5124         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5125         (riscv_linux_fregset): New.
5126         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5127
5128 2019-02-07  Tom Tromey  <tom@tromey.com>
5129
5130         * thread.c (thread_cancel_execution_command): Update.
5131         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5132         methods.
5133         (struct thread_fsm_ops): Remove.
5134         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5135         (thread_fsm_should_stop, thread_fsm_return_value)
5136         (thread_fsm_set_finished, thread_fsm_finished_p)
5137         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5138         Don't declare.
5139         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5140         * infrun.c (clear_proceed_status_thread)
5141         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5142         (print_stop_event): Update.
5143         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5144         Add constructor.
5145         (step_command_fsm_ops): Remove.
5146         (new_step_command_fsm): Remove.
5147         (step_1): Update.
5148         (step_command_fsm::should_stop): Rename from
5149         step_command_fsm_should_stop.
5150         (step_command_fsm::clean_up): Rename from
5151         step_command_fsm_clean_up.
5152         (step_command_fsm::do_async_reply_reason): Rename from
5153         step_command_fsm_async_reply_reason.
5154         (struct until_next_fsm): Inherit from thread_fsm.  Add
5155         constructor.
5156         (until_next_fsm_ops): Remove.
5157         (new_until_next_fsm): Remove.
5158         (until_next_fsm::should_stop): Rename from
5159         until_next_fsm_should_stop.
5160         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5161         (until_next_fsm::do_async_reply_reason): Rename from
5162         until_next_fsm_async_reply_reason.
5163         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5164         constructor.  Change type of breakpoint.
5165         (finish_command_fsm_ops): Remove.
5166         (new_finish_command_fsm): Remove.
5167         (finish_command_fsm::should_stop): Rename from
5168         finish_command_fsm_should_stop.
5169         (finish_command_fsm::clean_up): Rename from
5170         finish_command_fsm_clean_up.
5171         (finish_command_fsm::return_value): Rename from
5172         finish_command_fsm_return_value.
5173         (finish_command_fsm::do_async_reply_reason): Rename from
5174         finish_command_fsm_async_reply_reason.
5175         (finish_command): Update.
5176         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5177         Add constructor.
5178         (call_thread_fsm_ops): Remove.
5179         (call_thread_fsm::call_thread_fsm): Rename from
5180         new_call_thread_fsm.
5181         (call_thread_fsm::should_stop): Rename from
5182         call_thread_fsm_should_stop.
5183         (call_thread_fsm::should_notify_stop): Rename from
5184         call_thread_fsm_should_notify_stop.
5185         (run_inferior_call, call_function_by_hand_dummy): Update.
5186         * cli/cli-interp.c (should_print_stop_to_console): Update.
5187         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5188         Add constructor.  Change type of location_breakpoint,
5189         caller_breakpoint.
5190         (until_break_fsm_ops): Remove.
5191         (new_until_break_fsm): Remove.
5192         (until_break_fsm::should_stop): Rename from
5193         until_break_fsm_should_stop.
5194         (until_break_fsm::clean_up): Rename from
5195         until_break_fsm_clean_up.
5196         (until_break_fsm::do_async_reply_reason): Rename from
5197         until_break_fsm_async_reply_reason.
5198         (until_break_command): Update.
5199         * thread-fsm.c: Remove.
5200         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5201
5202 2019-02-07  Tom Tromey  <tom@tromey.com>
5203
5204         * yy-remap.h: Add include guard.
5205         * xtensa-tdep.h: Add include guard.
5206         * xcoffread.h: Rename include guard.
5207         * varobj-iter.h: Add include guard.
5208         * tui/tui.h: Rename include guard.
5209         * tui/tui-winsource.h: Rename include guard.
5210         * tui/tui-wingeneral.h: Rename include guard.
5211         * tui/tui-windata.h: Rename include guard.
5212         * tui/tui-win.h: Rename include guard.
5213         * tui/tui-stack.h: Rename include guard.
5214         * tui/tui-source.h: Rename include guard.
5215         * tui/tui-regs.h: Rename include guard.
5216         * tui/tui-out.h: Rename include guard.
5217         * tui/tui-layout.h: Rename include guard.
5218         * tui/tui-io.h: Rename include guard.
5219         * tui/tui-hooks.h: Rename include guard.
5220         * tui/tui-file.h: Rename include guard.
5221         * tui/tui-disasm.h: Rename include guard.
5222         * tui/tui-data.h: Rename include guard.
5223         * tui/tui-command.h: Rename include guard.
5224         * tic6x-tdep.h: Add include guard.
5225         * target/waitstatus.h: Rename include guard.
5226         * target/wait.h: Rename include guard.
5227         * target/target.h: Rename include guard.
5228         * target/resume.h: Rename include guard.
5229         * target-float.h: Rename include guard.
5230         * stabsread.h: Add include guard.
5231         * rs6000-tdep.h: Add include guard.
5232         * riscv-fbsd-tdep.h: Add include guard.
5233         * regformats/regdef.h: Rename include guard.
5234         * record.h: Rename include guard.
5235         * python/python.h: Rename include guard.
5236         * python/python-internal.h: Rename include guard.
5237         * python/py-stopevent.h: Rename include guard.
5238         * python/py-ref.h: Rename include guard.
5239         * python/py-record.h: Rename include guard.
5240         * python/py-record-full.h: Rename include guard.
5241         * python/py-record-btrace.h: Rename include guard.
5242         * python/py-instruction.h: Rename include guard.
5243         * python/py-events.h: Rename include guard.
5244         * python/py-event.h: Rename include guard.
5245         * procfs.h: Add include guard.
5246         * proc-utils.h: Add include guard.
5247         * p-lang.h: Add include guard.
5248         * or1k-tdep.h: Rename include guard.
5249         * observable.h: Rename include guard.
5250         * nto-tdep.h: Rename include guard.
5251         * nat/x86-linux.h: Rename include guard.
5252         * nat/x86-linux-dregs.h: Rename include guard.
5253         * nat/x86-gcc-cpuid.h: Add include guard.
5254         * nat/x86-dregs.h: Rename include guard.
5255         * nat/x86-cpuid.h: Rename include guard.
5256         * nat/ppc-linux.h: Rename include guard.
5257         * nat/mips-linux-watch.h: Rename include guard.
5258         * nat/linux-waitpid.h: Rename include guard.
5259         * nat/linux-ptrace.h: Rename include guard.
5260         * nat/linux-procfs.h: Rename include guard.
5261         * nat/linux-osdata.h: Rename include guard.
5262         * nat/linux-nat.h: Rename include guard.
5263         * nat/linux-namespaces.h: Rename include guard.
5264         * nat/linux-btrace.h: Rename include guard.
5265         * nat/glibc_thread_db.h: Rename include guard.
5266         * nat/gdb_thread_db.h: Rename include guard.
5267         * nat/gdb_ptrace.h: Rename include guard.
5268         * nat/fork-inferior.h: Rename include guard.
5269         * nat/amd64-linux-siginfo.h: Rename include guard.
5270         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5271         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5272         * nat/aarch64-linux.h: Rename include guard.
5273         * nat/aarch64-linux-hw-point.h: Rename include guard.
5274         * mn10300-tdep.h: Add include guard.
5275         * mips-linux-tdep.h: Add include guard.
5276         * mi/mi-parse.h: Rename include guard.
5277         * mi/mi-out.h: Rename include guard.
5278         * mi/mi-main.h: Rename include guard.
5279         * mi/mi-interp.h: Rename include guard.
5280         * mi/mi-getopt.h: Rename include guard.
5281         * mi/mi-console.h: Rename include guard.
5282         * mi/mi-common.h: Rename include guard.
5283         * mi/mi-cmds.h: Rename include guard.
5284         * mi/mi-cmd-break.h: Rename include guard.
5285         * m2-lang.h: Add include guard.
5286         * location.h: Rename include guard.
5287         * linux-record.h: Rename include guard.
5288         * linux-nat.h: Add include guard.
5289         * linux-fork.h: Add include guard.
5290         * i386-darwin-tdep.h: Rename include guard.
5291         * hppa-linux-offsets.h: Add include guard.
5292         * guile/guile.h: Rename include guard.
5293         * guile/guile-internal.h: Rename include guard.
5294         * gnu-nat.h: Rename include guard.
5295         * gdb-stabs.h: Rename include guard.
5296         * frv-tdep.h: Add include guard.
5297         * f-lang.h: Add include guard.
5298         * event-loop.h: Add include guard.
5299         * darwin-nat.h: Rename include guard.
5300         * cp-abi.h: Rename include guard.
5301         * config/sparc/nm-sol2.h: Rename include guard.
5302         * config/nm-nto.h: Rename include guard.
5303         * config/nm-linux.h: Add include guard.
5304         * config/i386/nm-i386gnu.h: Rename include guard.
5305         * config/djgpp/nl_types.h: Rename include guard.
5306         * config/djgpp/langinfo.h: Rename include guard.
5307         * compile/gcc-cp-plugin.h: Add include guard.
5308         * compile/gcc-c-plugin.h: Add include guard.
5309         * compile/compile.h: Rename include guard.
5310         * compile/compile-object-run.h: Rename include guard.
5311         * compile/compile-object-load.h: Rename include guard.
5312         * compile/compile-internal.h: Rename include guard.
5313         * compile/compile-cplus.h: Rename include guard.
5314         * compile/compile-c.h: Rename include guard.
5315         * common/xml-utils.h: Rename include guard.
5316         * common/x86-xstate.h: Rename include guard.
5317         * common/version.h: Rename include guard.
5318         * common/vec.h: Rename include guard.
5319         * common/tdesc.h: Rename include guard.
5320         * common/selftest.h: Rename include guard.
5321         * common/scoped_restore.h: Rename include guard.
5322         * common/scoped_mmap.h: Rename include guard.
5323         * common/scoped_fd.h: Rename include guard.
5324         * common/safe-iterator.h: Rename include guard.
5325         * common/run-time-clock.h: Rename include guard.
5326         * common/refcounted-object.h: Rename include guard.
5327         * common/queue.h: Rename include guard.
5328         * common/ptid.h: Rename include guard.
5329         * common/print-utils.h: Rename include guard.
5330         * common/preprocessor.h: Rename include guard.
5331         * common/pathstuff.h: Rename include guard.
5332         * common/observable.h: Rename include guard.
5333         * common/netstuff.h: Rename include guard.
5334         * common/job-control.h: Rename include guard.
5335         * common/host-defs.h: Rename include guard.
5336         * common/gdb_wait.h: Rename include guard.
5337         * common/gdb_vecs.h: Rename include guard.
5338         * common/gdb_unlinker.h: Rename include guard.
5339         * common/gdb_unique_ptr.h: Rename include guard.
5340         * common/gdb_tilde_expand.h: Rename include guard.
5341         * common/gdb_sys_time.h: Rename include guard.
5342         * common/gdb_string_view.h: Rename include guard.
5343         * common/gdb_splay_tree.h: Rename include guard.
5344         * common/gdb_setjmp.h: Rename include guard.
5345         * common/gdb_ref_ptr.h: Rename include guard.
5346         * common/gdb_optional.h: Rename include guard.
5347         * common/gdb_locale.h: Rename include guard.
5348         * common/gdb_assert.h: Rename include guard.
5349         * common/filtered-iterator.h: Rename include guard.
5350         * common/filestuff.h: Rename include guard.
5351         * common/fileio.h: Rename include guard.
5352         * common/environ.h: Rename include guard.
5353         * common/common-utils.h: Rename include guard.
5354         * common/common-types.h: Rename include guard.
5355         * common/common-regcache.h: Rename include guard.
5356         * common/common-inferior.h: Rename include guard.
5357         * common/common-gdbthread.h: Rename include guard.
5358         * common/common-exceptions.h: Rename include guard.
5359         * common/common-defs.h: Rename include guard.
5360         * common/common-debug.h: Rename include guard.
5361         * common/cleanups.h: Rename include guard.
5362         * common/buffer.h: Rename include guard.
5363         * common/btrace-common.h: Rename include guard.
5364         * common/break-common.h: Rename include guard.
5365         * cli/cli-utils.h: Rename include guard.
5366         * cli/cli-style.h: Rename include guard.
5367         * cli/cli-setshow.h: Rename include guard.
5368         * cli/cli-script.h: Rename include guard.
5369         * cli/cli-interp.h: Rename include guard.
5370         * cli/cli-decode.h: Rename include guard.
5371         * cli/cli-cmds.h: Rename include guard.
5372         * charset-list.h: Add include guard.
5373         * buildsym-legacy.h: Rename include guard.
5374         * bfin-tdep.h: Add include guard.
5375         * ax.h: Rename include guard.
5376         * arm-linux-tdep.h: Add include guard.
5377         * arm-fbsd-tdep.h: Add include guard.
5378         * arch/xtensa.h: Rename include guard.
5379         * arch/tic6x.h: Add include guard.
5380         * arch/i386.h: Add include guard.
5381         * arch/arm.h: Rename include guard.
5382         * arch/arm-linux.h: Rename include guard.
5383         * arch/arm-get-next-pcs.h: Rename include guard.
5384         * arch/amd64.h: Add include guard.
5385         * arch/aarch64-insn.h: Rename include guard.
5386         * arch-utils.h: Rename include guard.
5387         * annotate.h: Add include guard.
5388         * amd64-darwin-tdep.h: Rename include guard.
5389         * aarch64-linux-tdep.h: Add include guard.
5390         * aarch64-fbsd-tdep.h: Add include guard.
5391         * aarch32-linux-nat.h: Add include guard.
5392
5393 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5394
5395         * macrotab.c (macro_define_internal): New function that
5396         factorizes macro_define_object_internal and macro_define_function
5397         code.
5398         (macro_define_object_internal): Use macro_define_internal.
5399         (macro_define_function): Likewise.
5400
5401 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5402
5403         * macrocmd.c (extract_identifier): Return
5404         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5405         callers.
5406
5407 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5408
5409         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5410
5411 2019-02-05  Tom Tromey  <tom@tromey.com>
5412
5413         * target.c (target_stack::unpush): Move assertion earlier.
5414
5415 2019-01-30  Tom Tromey  <tom@tromey.com>
5416
5417         PR python/23615:
5418         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5419         (gdbpy_parse_and_eval): Likewise.
5420         * python/python-internal.h (gdbpy_allow_threads): New class.
5421
5422 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5423
5424         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5425         (aarch64_fbsd_fpregmap): Move earlier.
5426         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5427         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5428         instead of individual calls to trad_frame_set_reg_addr.
5429         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5430         earlier.
5431         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5432         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5433         instead of individual calls to trad_frame_set_reg_addr.
5434
5435 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5436
5437         * CONTRIBUTE: Replace contribution list with wiki link.
5438
5439 2019-01-25  Tom Tromey  <tom@tromey.com>
5440
5441         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5442
5443 2019-01-25  Tom Tromey  <tom@tromey.com>
5444
5445         * xtensa-linux-nat.c: Fix common/ includes.
5446         * xml-support.h: Fix common/ includes.
5447         * xml-support.c: Fix common/ includes.
5448         * x86-linux-nat.c: Fix common/ includes.
5449         * windows-nat.c: Fix common/ includes.
5450         * varobj.h: Fix common/ includes.
5451         * varobj.c: Fix common/ includes.
5452         * value.c: Fix common/ includes.
5453         * valops.c: Fix common/ includes.
5454         * utils.c: Fix common/ includes.
5455         * unittests/xml-utils-selftests.c: Fix common/ includes.
5456         * unittests/utils-selftests.c: Fix common/ includes.
5457         * unittests/unpack-selftests.c: Fix common/ includes.
5458         * unittests/tracepoint-selftests.c: Fix common/ includes.
5459         * unittests/style-selftests.c: Fix common/ includes.
5460         * unittests/string_view-selftests.c: Fix common/ includes.
5461         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5462         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5463         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5464         * unittests/rsp-low-selftests.c: Fix common/ includes.
5465         * unittests/parse-connection-spec-selftests.c: Fix common/
5466         includes.
5467         * unittests/optional-selftests.c: Fix common/ includes.
5468         * unittests/offset-type-selftests.c: Fix common/ includes.
5469         * unittests/observable-selftests.c: Fix common/ includes.
5470         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5471         * unittests/memrange-selftests.c: Fix common/ includes.
5472         * unittests/memory-map-selftests.c: Fix common/ includes.
5473         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5474         * unittests/function-view-selftests.c: Fix common/ includes.
5475         * unittests/environ-selftests.c: Fix common/ includes.
5476         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5477         * unittests/common-utils-selftests.c: Fix common/ includes.
5478         * unittests/cli-utils-selftests.c: Fix common/ includes.
5479         * unittests/array-view-selftests.c: Fix common/ includes.
5480         * ui-file.c: Fix common/ includes.
5481         * tui/tui-io.c: Fix common/ includes.
5482         * tracepoint.h: Fix common/ includes.
5483         * tracepoint.c: Fix common/ includes.
5484         * tracefile-tfile.c: Fix common/ includes.
5485         * top.h: Fix common/ includes.
5486         * top.c: Fix common/ includes.
5487         * thread.c: Fix common/ includes.
5488         * target/waitstatus.h: Fix common/ includes.
5489         * target/waitstatus.c: Fix common/ includes.
5490         * target.h: Fix common/ includes.
5491         * target.c: Fix common/ includes.
5492         * target-memory.c: Fix common/ includes.
5493         * target-descriptions.c: Fix common/ includes.
5494         * symtab.h: Fix common/ includes.
5495         * symfile.c: Fix common/ includes.
5496         * stap-probe.c: Fix common/ includes.
5497         * spu-linux-nat.c: Fix common/ includes.
5498         * sparc-nat.c: Fix common/ includes.
5499         * source.c: Fix common/ includes.
5500         * solib.c: Fix common/ includes.
5501         * solib-target.c: Fix common/ includes.
5502         * ser-unix.c: Fix common/ includes.
5503         * ser-tcp.c: Fix common/ includes.
5504         * ser-pipe.c: Fix common/ includes.
5505         * ser-base.c: Fix common/ includes.
5506         * selftest-arch.c: Fix common/ includes.
5507         * s12z-tdep.c: Fix common/ includes.
5508         * rust-exp.y: Fix common/ includes.
5509         * rs6000-aix-tdep.c: Fix common/ includes.
5510         * riscv-tdep.c: Fix common/ includes.
5511         * remote.c: Fix common/ includes.
5512         * remote-notif.h: Fix common/ includes.
5513         * remote-fileio.h: Fix common/ includes.
5514         * remote-fileio.c: Fix common/ includes.
5515         * regcache.h: Fix common/ includes.
5516         * regcache.c: Fix common/ includes.
5517         * record-btrace.c: Fix common/ includes.
5518         * python/python.c: Fix common/ includes.
5519         * python/py-type.c: Fix common/ includes.
5520         * python/py-inferior.c: Fix common/ includes.
5521         * progspace.h: Fix common/ includes.
5522         * producer.c: Fix common/ includes.
5523         * procfs.c: Fix common/ includes.
5524         * proc-api.c: Fix common/ includes.
5525         * printcmd.c: Fix common/ includes.
5526         * ppc-linux-nat.c: Fix common/ includes.
5527         * parser-defs.h: Fix common/ includes.
5528         * osdata.c: Fix common/ includes.
5529         * obsd-nat.c: Fix common/ includes.
5530         * nat/x86-linux.c: Fix common/ includes.
5531         * nat/x86-linux-dregs.c: Fix common/ includes.
5532         * nat/x86-dregs.h: Fix common/ includes.
5533         * nat/x86-dregs.c: Fix common/ includes.
5534         * nat/ppc-linux.c: Fix common/ includes.
5535         * nat/mips-linux-watch.h: Fix common/ includes.
5536         * nat/mips-linux-watch.c: Fix common/ includes.
5537         * nat/linux-waitpid.c: Fix common/ includes.
5538         * nat/linux-ptrace.h: Fix common/ includes.
5539         * nat/linux-ptrace.c: Fix common/ includes.
5540         * nat/linux-procfs.c: Fix common/ includes.
5541         * nat/linux-personality.c: Fix common/ includes.
5542         * nat/linux-osdata.c: Fix common/ includes.
5543         * nat/linux-namespaces.c: Fix common/ includes.
5544         * nat/linux-btrace.h: Fix common/ includes.
5545         * nat/linux-btrace.c: Fix common/ includes.
5546         * nat/fork-inferior.c: Fix common/ includes.
5547         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5548         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5549         * nat/aarch64-linux.c: Fix common/ includes.
5550         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5551         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5552         * namespace.h: Fix common/ includes.
5553         * mips-linux-tdep.c: Fix common/ includes.
5554         * minsyms.c: Fix common/ includes.
5555         * mi/mi-parse.h: Fix common/ includes.
5556         * mi/mi-main.c: Fix common/ includes.
5557         * mi/mi-cmd-env.c: Fix common/ includes.
5558         * memrange.h: Fix common/ includes.
5559         * memattr.c: Fix common/ includes.
5560         * maint.h: Fix common/ includes.
5561         * maint.c: Fix common/ includes.
5562         * main.c: Fix common/ includes.
5563         * machoread.c: Fix common/ includes.
5564         * location.c: Fix common/ includes.
5565         * linux-thread-db.c: Fix common/ includes.
5566         * linux-nat.c: Fix common/ includes.
5567         * linux-fork.c: Fix common/ includes.
5568         * inline-frame.c: Fix common/ includes.
5569         * infrun.c: Fix common/ includes.
5570         * inflow.c: Fix common/ includes.
5571         * inferior.h: Fix common/ includes.
5572         * inferior.c: Fix common/ includes.
5573         * infcmd.c: Fix common/ includes.
5574         * inf-ptrace.c: Fix common/ includes.
5575         * inf-child.c: Fix common/ includes.
5576         * ia64-linux-nat.c: Fix common/ includes.
5577         * i387-tdep.c: Fix common/ includes.
5578         * i386-tdep.c: Fix common/ includes.
5579         * i386-linux-tdep.c: Fix common/ includes.
5580         * i386-linux-nat.c: Fix common/ includes.
5581         * i386-go32-tdep.c: Fix common/ includes.
5582         * i386-fbsd-tdep.c: Fix common/ includes.
5583         * i386-fbsd-nat.c: Fix common/ includes.
5584         * guile/scm-type.c: Fix common/ includes.
5585         * guile/guile.c: Fix common/ includes.
5586         * go32-nat.c: Fix common/ includes.
5587         * gnu-nat.c: Fix common/ includes.
5588         * gdbthread.h: Fix common/ includes.
5589         * gdbarch-selftests.c: Fix common/ includes.
5590         * gdb_usleep.c: Fix common/ includes.
5591         * gdb_select.h: Fix common/ includes.
5592         * gdb_bfd.c: Fix common/ includes.
5593         * gcore.c: Fix common/ includes.
5594         * fork-child.c: Fix common/ includes.
5595         * findvar.c: Fix common/ includes.
5596         * fbsd-nat.c: Fix common/ includes.
5597         * event-top.c: Fix common/ includes.
5598         * event-loop.c: Fix common/ includes.
5599         * dwarf2read.c: Fix common/ includes.
5600         * dwarf2loc.c: Fix common/ includes.
5601         * dwarf2-frame.c: Fix common/ includes.
5602         * dwarf-index-cache.c: Fix common/ includes.
5603         * dtrace-probe.c: Fix common/ includes.
5604         * disasm-selftests.c: Fix common/ includes.
5605         * defs.h: Fix common/ includes.
5606         * csky-tdep.c: Fix common/ includes.
5607         * cp-valprint.c: Fix common/ includes.
5608         * cp-support.h: Fix common/ includes.
5609         * cp-support.c: Fix common/ includes.
5610         * corelow.c: Fix common/ includes.
5611         * completer.h: Fix common/ includes.
5612         * completer.c: Fix common/ includes.
5613         * compile/compile.c: Fix common/ includes.
5614         * compile/compile-loc2c.c: Fix common/ includes.
5615         * compile/compile-cplus-types.c: Fix common/ includes.
5616         * compile/compile-cplus-symbols.c: Fix common/ includes.
5617         * command.h: Fix common/ includes.
5618         * cli/cli-dump.c: Fix common/ includes.
5619         * cli/cli-cmds.c: Fix common/ includes.
5620         * charset.c: Fix common/ includes.
5621         * build-id.c: Fix common/ includes.
5622         * btrace.h: Fix common/ includes.
5623         * btrace.c: Fix common/ includes.
5624         * breakpoint.h: Fix common/ includes.
5625         * breakpoint.c: Fix common/ includes.
5626         * ax.h:
5627         (enum agent_op): Fix common/ includes.
5628         * ax-general.c (struct aop_map): Fix common/ includes.
5629         * ax-gdb.c: Fix common/ includes.
5630         * auxv.c: Fix common/ includes.
5631         * auto-load.c: Fix common/ includes.
5632         * arm-tdep.c: Fix common/ includes.
5633         * arch/riscv.c: Fix common/ includes.
5634         * arch/ppc-linux-common.c: Fix common/ includes.
5635         * arch/i386.c: Fix common/ includes.
5636         * arch/arm.c: Fix common/ includes.
5637         * arch/arm-linux.c: Fix common/ includes.
5638         * arch/arm-get-next-pcs.c: Fix common/ includes.
5639         * arch/amd64.c: Fix common/ includes.
5640         * arch/aarch64.c: Fix common/ includes.
5641         * arch/aarch64-insn.c: Fix common/ includes.
5642         * arch-utils.c: Fix common/ includes.
5643         * amd64-windows-tdep.c: Fix common/ includes.
5644         * amd64-tdep.c: Fix common/ includes.
5645         * amd64-sol2-tdep.c: Fix common/ includes.
5646         * amd64-obsd-tdep.c: Fix common/ includes.
5647         * amd64-nbsd-tdep.c: Fix common/ includes.
5648         * amd64-linux-tdep.c: Fix common/ includes.
5649         * amd64-linux-nat.c: Fix common/ includes.
5650         * amd64-fbsd-tdep.c: Fix common/ includes.
5651         * amd64-fbsd-nat.c: Fix common/ includes.
5652         * amd64-dicos-tdep.c: Fix common/ includes.
5653         * amd64-darwin-tdep.c: Fix common/ includes.
5654         * agent.c: Fix common/ includes.
5655         * ada-lang.h: Fix common/ includes.
5656         * ada-lang.c: Fix common/ includes.
5657         * aarch64-tdep.c: Fix common/ includes.
5658
5659 2019-01-25  Tom Tromey  <tom@tromey.com>
5660
5661         * common/create-version.sh: Use common/version.h.
5662
5663 2019-01-24  Pedro Alves  <palves@redhat.com>
5664
5665         * infrun.c (signal_stop, signal_print, signal_program)
5666         (signal_catch, signal_pass): Now arrays instead of pointers.
5667         (update_signals_program_target, do_target_resume)
5668         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5669         * linux-nat.c (linux_nat_target::pass_signals)
5670         (linux_nat_target::create_inferior, linux_nat_target::attach):
5671         Adjust.
5672         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5673         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5674         * procfs.c (procfs_target::pass_signals): Adjust.
5675         * record-full.c (record_full_target::resume): Adjust.
5676         * remote.c (remote_target::pass_signals)
5677         (remote_target::program_signals): Adjust.
5678         * target-debug.h (target_debug_print_signals): Now takes a
5679         gdb::array_view as parameter.  Adjust.
5680         * target.h (target_ops) <pass_signals, program_signals>: Replace
5681         pointer and length parameters with gdb::array_view.
5682         (target_pass_signals, target_program_signals): Likewise.
5683         * target-delegates.c: Regenerate.
5684
5685 2019-01-24  Pedro Alves  <palves@redhat.com>
5686
5687         * common/forward-scope-exit.h
5688         (forward_scope_exit::forward_scope_exit): Pass arguments to
5689         m_bind_function directly, instead of creating a std::bind and
5690         copying that.
5691
5692 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5693
5694         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5695         for static members.
5696         (pass_in_v_vfp_candidate): Likewise.
5697
5698 2019-01-23  Tom Tromey  <tom@tromey.com>
5699             Pedro Alves  <palves@redhat.com>
5700
5701         * regcache.c (class regcache_invalidator): Remove.
5702         (regcache::raw_write): Use make_scope_exit.
5703
5704 2019-01-23  Tom Tromey  <tom@tromey.com>
5705
5706         * ui-out.h (class ui_out_emit_type): Update comment.
5707
5708 2019-01-23  Tom Tromey  <tom@tromey.com>
5709
5710         * infrun.c (fetch_inferior_event): Update comment.
5711
5712 2019-01-23  Tom Tromey  <tom@tromey.com>
5713             Pedro Alves  <palves@redhat.com>
5714
5715         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5716         parameter.
5717         (fetch_inferior_event): Use SCOPE_EXIT.
5718
5719
5720 2019-01-23  Tom Tromey  <tom@tromey.com>
5721             Pedro Alves  <palves@redhat.com>
5722
5723         * infrun.c (disable_thread_events): Delete.
5724         (stop_all_threads): Use SCOPE_EXIT.
5725
5726 2019-01-23  Tom Tromey  <tom@tromey.com>
5727             Pedro Alves  <palves@redhat.com>
5728
5729         * symfile.c: Include forward-scope-exit.h.
5730         (clear_symtab_users_cleanup): Replace forward declaration with
5731         a FORWARD_SCOPE_EXIT.
5732         (syms_from_objfile_1): Use the forward_scope_exit and
5733         gdb::optional instead of cleanup_function.
5734         (reread_symbols): Use the forward_scope_exit instead of
5735         cleanup_function.
5736         (clear_symtab_users_cleanup): Remove function.
5737
5738 2019-01-23  Tom Tromey  <tom@tromey.com>
5739             Pedro Alves  <palves@redhat.com>
5740
5741         * linux-nat.c: Include scope-exit.h.
5742         (cleanup_target_stop): Remove.
5743         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5744         SCOPE_EXIT.
5745
5746 2019-01-23  Tom Tromey  <tom@tromey.com>
5747             Pedro Alves  <palves@redhat.com>
5748
5749         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5750         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5751
5752 2019-01-23  Tom Tromey  <tom@tromey.com>
5753             Andrew Burgess  <andrew.burgess@embecosm.com>
5754             Pedro Alves  <palves@redhat.com>
5755
5756         * infrun.c (fetch_inferior_event): Use scope_exit.
5757         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5758         * top.c (execute_command): Use scope_exit.
5759         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5760         * utils.c (do_bpstat_clear_actions_cleanup)
5761         (make_bpstat_clear_actions_cleanup): Remove.
5762
5763 2019-01-23  Tom Tromey  <tom@tromey.com>
5764             Pedro Alves  <palves@redhat.com>
5765
5766         * infrun.c: Include "common/scope-exit.h"
5767         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5768         (wait_for_inferior): Use SCOPE_EXIT.
5769         (fetch_inferior_event): Use scope_exit.
5770
5771 2019-01-23  Tom Tromey  <tom@tromey.com>
5772             Pedro Alves  <palves@redhat.com>
5773
5774         * breakpoint.c (create_breakpoint): Remove cleanup.
5775
5776 2019-01-23  Tom Tromey  <tom@tromey.com>
5777             Andrew Burgess  <andrew.burgess@embecosm.com>
5778             Pedro Alves  <palves@redhat.com>
5779
5780 2019-01-23  Pedro Alves  <palves@redhat.com>
5781
5782         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5783
5784 2019-01-23  Pedro Alves  <palves@redhat.com>
5785             Andrew Burgess  <andrew.burgess@embecosm.com>
5786
5787         * gdbthread.h: Include "common/forward-scope-exit.h".
5788         (scoped_finish_thread_state): Redefine custom class in terms of
5789         forward_scope_exit.
5790
5791 2019-01-23  Pedro Alves  <palves@redhat.com>
5792             Andrew Burgess  <andrew.burgess@embecosm.com>
5793
5794         * common/forward-scope-exit.h: New file.
5795
5796 2019-01-23  Pedro Alves  <palves@redhat.com>
5797             Andrew Burgess  <andrew.burgess@embecosm.com>
5798             Tom Tromey  <tom@tromey.com>
5799
5800         * common/scope-exit.h: New file.
5801
5802 2019-01-23  Pedro Alves  <palves@redhat.com>
5803
5804         * common/preprocessor.h (ESC): Rename to ...
5805         (ESC_PARENS): ... this.
5806         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5807         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5808
5809 2019-01-23  Tom Tromey  <tom@tromey.com>
5810
5811         * language.h (class scoped_switch_to_sym_language_if_auto):
5812         Initialize m_lang in both cases.
5813
5814 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5815
5816         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5817         with XCNEW.
5818
5819 2019-01-22  Tom Tromey  <tom@tromey.com>
5820
5821         * corelow.c: Do not include sys/file.h.
5822
5823 2019-01-22  Tom Tromey  <tom@tromey.com>
5824
5825         * tui/tui-wingeneral.h: Include gdb_curses.h.
5826
5827 2019-01-22  Tom Tromey  <tom@tromey.com>
5828
5829         * source-cache.h (class source_cache) <get_source_lines,
5830         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5831
5832 2019-01-22  Tom Tromey  <tom@tromey.com>
5833
5834         * remote-fileio.h (struct remote_target): Declare.
5835
5836 2019-01-22  Tom Tromey  <tom@tromey.com>
5837
5838         * python/py-arch.c: Do not include py-ref.h.
5839         * python/py-bpevent.c: Do not include py-ref.h.
5840         * python/py-cmd.c: Do not include py-ref.h.
5841         * python/py-continueevent.c: Do not include py-ref.h.
5842         * python/py-event.h: Do not include py-ref.h.
5843         * python/py-evtregistry.c: Do not include py-ref.h.
5844         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5845         * python/py-frame.c: Do not include py-ref.h.
5846         * python/py-framefilter.c: Do not include py-ref.h.
5847         * python/py-function.c: Do not include py-ref.h.
5848         * python/py-infevents.c: Do not include py-ref.h.
5849         * python/py-linetable.c: Do not include py-ref.h.
5850         * python/py-objfile.c: Do not include py-ref.h.
5851         * python/py-param.c: Do not include py-ref.h.
5852         * python/py-prettyprint.c: Do not include py-ref.h.
5853         * python/py-progspace.c: Do not include py-ref.h.
5854         * python/py-symbol.c: Do not include py-ref.h.
5855         * python/py-symtab.c: Do not include py-ref.h.
5856         * python/py-type.c: Do not include py-ref.h.
5857         * python/py-unwind.c: Do not include py-ref.h.
5858         * python/py-utils.c: Do not include py-ref.h.
5859         * python/py-value.c: Do not include py-ref.h.
5860         * python/py-varobj.c: Do not include py-ref.h.
5861         * python/py-xmethods.c: Do not include py-ref.h.
5862         * python/python.c: Do not include py-ref.h.
5863         * varobj.c: Do not include py-ref.h.
5864
5865 2019-01-22  Tom Tromey  <tom@tromey.com>
5866
5867         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5868         keyword for bcache.
5869
5870 2019-01-22  Tom Tromey  <tom@tromey.com>
5871
5872         * compile/compile-cplus-types.c: Remove a comment by #include.
5873
5874 2019-01-22  Tom Tromey  <tom@tromey.com>
5875
5876         * compile/gcc-c-plugin.h: Include compile-internal.h.
5877
5878 2019-01-22  Tom Tromey  <tom@tromey.com>
5879
5880         * stabsread.c (EXTERN): Do not define.
5881         (symnum, next_symbol_text_func, processing_gcc_compilation)
5882         (within_function, global_sym_chain, global_stabs)
5883         (previous_stab_code, this_object_header_files)
5884         (n_this_object_header_files)
5885         (n_allocated_this_object_header_files): Define.
5886         * stabsread.h (EXTERN): Never define.  Use "extern".
5887
5888 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5889
5890         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5891         history_value.
5892
5893 2019-01-21  Tom Tromey  <tom@tromey.com>
5894
5895         * ui-out.c: Fix includes.
5896         * tui/tui-source.c: Fix includes.
5897         * target.c: Fix includes.
5898         * remote.c: Fix includes.
5899         * regcache.c: Fix includes.
5900         * python/py-block.c: Fix includes.
5901         * printcmd.c: Fix includes.
5902         * or1k-tdep.c: Fix includes.
5903         * mi/mi-main.c: Fix includes.
5904         * m32r-tdep.c: Fix includes.
5905         * csky-tdep.c: Fix includes.
5906         * compile/compile-cplus-types.c: Fix includes.
5907         * cli/cli-interp.c: Fix includes.
5908
5909 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5910
5911         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5912         for padding.
5913
5914 2019-01-16  Tom Tromey  <tom@tromey.com>
5915
5916         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5917         earlier.
5918         (struct objfile) <msymbols_range>: Move from top level.
5919         <msymbols>: New method.
5920         (class objfile_msymbols): Remove.
5921         * symtab.c (default_collect_symbol_completion_matches_break_on):
5922         Update.
5923         * symmisc.c (dump_msymbols): Update.
5924         * stabsread.c (scan_file_globals): Update.
5925         * objc-lang.c (info_selectors_command, info_classes_command)
5926         (find_methods): Update.
5927         * minsyms.c (find_solib_trampoline_target): Update.
5928         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5929         * coffread.c (coff_symfile_read): Update.
5930         * ada-lang.c (ada_lookup_simple_minsym)
5931         (ada_collect_symbol_completion_matches): Update.
5932
5933 2019-01-16  Tom Tromey  <tom@tromey.com>
5934
5935         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5936         type.  Remove no-argument constructor.
5937         <iterator::operator++>: Simplify.
5938         <begin>: Update.
5939         <end>: Use minimal_symbol_count.
5940
5941 2019-01-16  Tom Tromey  <tom@tromey.com>
5942
5943         * objfiles.h (struct objfile) <psymtabs>: New method.
5944         (class objfile_psymtabs): Remove.
5945         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5946         typedef.
5947         <range>: New method.
5948         (require_partial_symbols): Change return type.
5949         * psymtab.c (require_partial_symbols)
5950         (psym_expand_symtabs_matching): Update.
5951         * mdebugread.c (parse_partial_symbols): Update.
5952         * dbxread.c (dbx_end_psymtab): Update.
5953
5954 2019-01-15  Tom Tromey  <tom@tromey.com>
5955
5956         * symtab.c (lookup_objfile_from_block)
5957         (lookup_symbol_in_objfile_symtabs)
5958         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5959         (find_line_symtab, info_sources_command)
5960         (default_collect_symbol_completion_matches_break_on)
5961         (make_source_files_completion_list): Update.
5962         * symmisc.c (print_objfile_statistics, dump_objfile)
5963         (maintenance_print_symbols, maintenance_info_symtabs)
5964         (maintenance_check_symtabs, maintenance_info_line_tables):
5965         Update.
5966         * source.c (select_source_symtab)
5967         (forget_cached_source_info_for_objfile): Update.
5968         * objfiles.h (class objfile_compunits): Remove.
5969         (struct objfile) <compunits_range>: New typedef.
5970         (compunits): New method.
5971         * objfiles.c (objfile_relocate1): Update.
5972         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5973         * maint.c (count_symtabs_and_blocks): Update.
5974         * linespec.c (iterate_over_all_matching_symtabs): Update.
5975         * cp-support.c (add_symbol_overload_list_qualified): Update.
5976         * coffread.c (coff_symtab_read): Update.
5977         * ada-lang.c (add_nonlocal_symbols)
5978         (ada_collect_symbol_completion_matches)
5979         (ada_add_global_exceptions): Update.
5980
5981 2019-01-15  Tom Tromey  <tom@tromey.com>
5982
5983         * progspace.h (program_space) <objfiles_safe_range>: New
5984         typedef.
5985         <objfiles_safe>: New method.
5986         * objfiles.h (class all_objfiles_safe): Remove.
5987         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5988         * jit.c (jit_inferior_exit_hook): Update.
5989
5990 2019-01-17  Tom Tromey  <tom@tromey.com>
5991
5992         * progspace.h (program_space) <objfiles_range>: New typedef.
5993         <objfiles>: New method.
5994         <objfiles_head>: Rename from objfiles.
5995         (object_files): Update.
5996         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5997         * guile/scm-pretty-print.c
5998         (ppscm_find_pretty_printer_from_objfiles): Update.
5999         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6000         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6001         Update.
6002         * python/py-progspace.c (pspy_get_objfiles): Update.
6003         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6004         Update.
6005         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6006         (objfpy_lookup_objfile_by_build_id): Update.
6007         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6008         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6009         Update.
6010         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6011         (expand_symtab_containing_pc, lookup_objfile_from_block)
6012         (lookup_static_symbol, basic_lookup_transparent_type)
6013         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6014         (find_line_symtab, info_sources_command)
6015         (default_collect_symbol_completion_matches_break_on)
6016         (make_source_files_completion_list, find_main_name): Update.
6017         * symmisc.c (print_symbol_bcache_statistics)
6018         (print_objfile_statistics, maintenance_print_symbols)
6019         (maintenance_print_msymbols, maintenance_print_objfiles)
6020         (maintenance_info_symtabs, maintenance_check_symtabs)
6021         (maintenance_expand_symtabs, maintenance_info_line_tables):
6022         Update.
6023         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6024         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6025         (map_overlay_command, unmap_overlay_command)
6026         (simple_overlay_update, expand_symtabs_matching)
6027         (map_symbol_filenames): Update.
6028         * symfile-debug.c (set_debug_symfile): Update.
6029         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6030         Update.
6031         * source.c (select_source_symtab, forget_cached_source_info):
6032         Update.
6033         * solib.c (solib_read_symbols): Update.
6034         * solib-spu.c (append_ocl_sos): Update.
6035         * psymtab.c (maintenance_print_psymbols)
6036         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6037         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6038         * printcmd.c (info_symbol_command): Update.
6039         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6040         Update.
6041         * objfiles.h (class all_objfiles): Remove.
6042         * objfiles.c (have_partial_symbols, have_full_symbols)
6043         (have_minimal_symbols, qsort_cmp, update_section_map)
6044         (shared_objfile_contains_address_p)
6045         (default_iterate_over_objfiles_in_search_order): Update.
6046         * objc-lang.c (info_selectors_command, info_classes_command)
6047         (find_methods): Update.
6048         * minsyms.c (find_solib_trampoline_target): Update.
6049         * maint.c (maintenance_info_sections)
6050         (maintenance_translate_address, count_symtabs_and_blocks):
6051         Update.
6052         * main.c (captured_main_1): Update.
6053         * linux-thread-db.c (try_thread_db_load_from_pdir)
6054         (has_libpthread): Update.
6055         * linespec.c (iterate_over_all_matching_symtabs)
6056         (search_minsyms_for_name): Update.
6057         * jit.c (jit_find_objf_with_entry_addr): Update.
6058         * hppa-tdep.c (find_unwind_entry)
6059         (hppa_lookup_stub_minimal_symbol): Update.
6060         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6061         Update.
6062         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6063         (elf_gnu_ifunc_resolve_by_got): Update.
6064         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6065         * dwarf-index-write.c (save_gdb_index_command): Update.
6066         * cp-support.c (add_symbol_overload_list_qualified): Update.
6067         * breakpoint.c (create_overlay_event_breakpoint)
6068         (create_longjmp_master_breakpoint)
6069         (create_std_terminate_master_breakpoint)
6070         (create_exception_master_breakpoint): Update.
6071         * blockframe.c (find_pc_partial_function): Update.
6072         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6073         (ada_collect_symbol_completion_matches)
6074         (ada_add_global_exceptions): Update.
6075
6076 2019-01-17  Tom Tromey  <tom@tromey.com>
6077
6078         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6079         declare VEC.
6080         (solib_target_parse_libraries): Change return type.
6081         (library_list_start_segment, library_list_start_section)
6082         (library_list_end_library, library_list_start_library); Update.
6083         (solib_target_free_library_list): Remove.
6084         (solib_target_parse_libraries): Remove cleanup.  Change return
6085         type.
6086         (solib_target_current_sos): Update.
6087
6088 2019-01-17  Tom Tromey  <tromey@bapiya>
6089
6090         * valprint.c: Replace "the the" with "the".
6091         * symtab.c: Replace "the the" with "the".
6092         * solib.c: Replace "the the" with "the".
6093         * solib-dsbt.c: Replace "the the" with "the".
6094         * linespec.c: Replace "the the" with "the".
6095         * dwarf2loc.h: Replace "the the" with "the".
6096         * amd64-windows-tdep.c: Replace "the the" with "the".
6097         * aarch64-tdep.c: Replace "the the" with "the".
6098
6099 2019-01-16  Keith Seitz  <keiths@redhat.com>
6100
6101         PR gdb/23773
6102         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6103         <builder>: Rename to ..
6104         <m_builder>: ... this and make private.
6105         (dwarf2_cu::get_builder): New method.  Change all users of
6106         `builder' to use this method.
6107         (dwarf2_start_symtab): Move to ...
6108         (dwarf2_cu::start_symtab): ... here.  Update all callers
6109         (setup_type_unit_groups): Move to ...
6110         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6111         callers.
6112         (dwarf2_cu::reset_builder): New method.
6113         (process_full_compunit, process_full_type_unit): Use
6114         dwarf2_cu::reset_builder.
6115         (follow_die_offset): Record the ancestor CU if it is different
6116         from the followed DIE's CU.
6117         (follow_die_sig_1): Likewise.
6118
6119 2019-01-15  Tom Tromey  <tom@tromey.com>
6120
6121         * remote.c (class remote_state) <buf>: Now a char_vector.
6122         <buf_size>: Remove.
6123         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6124         parameter.
6125         (remote_target::getpkt_or_notif_sane_1)
6126         (remote_target::getpkt_sane)
6127         (remote_target::getpkt_or_notif_sane): Likewise.
6128         (class remote_target) <putpkt>: New overload.
6129         (remote_target::read_frame): Change type of "buf_p".  Remove
6130         sizeof_p parameter.
6131         (packet_ok): New overload.
6132         (packet_check_result): New overload.
6133         Update all uses.
6134
6135 2019-01-14  Tom Tromey  <tom@tromey.com>
6136
6137         * remote-notif.c (handle_notification, remote_notif_ack)
6138         (remote_notif_parse): Make "buf" const.
6139         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6140         const.
6141         (remote_notif_parse, remote_notif_ack, handle_notification):
6142         Likewise.
6143         * remote.c (remote_notif_stop_parse): Make "buf" const.
6144         (remote_target::remote_parse_stop_reply): Make "buf" const.
6145         (remote_notif_stop_ack): Make "buf" const.
6146
6147 2019-01-14  Tom Tromey  <tom@tromey.com>
6148
6149         * remote.c (remote_console_output): Make parameter const.
6150
6151 2019-01-14  Tom Tromey  <tom@tromey.com>
6152
6153         * target-debug.h (target_debug_print_signals): Constify.
6154         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6155         * procfs.c (procfs_target::pass_signals): Update.
6156         * linux-nat.c (linux_nat_target::pass_signals): Update.
6157         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6158         * target-delegates.c: Rebuild.
6159         * remote.c (remote_target::program_signals): Update.
6160         (remote_target::pass_signals): Update.
6161         * target.c (target_pass_signals): Constify argument.
6162         (target_program_signals): Likewise.
6163         * target.h (struct target_ops) <pass_signals, program_signals>:
6164         Constify argument.
6165         (target_pass_signals, target_program_signals): Constify argument.
6166
6167 2019-01-14  Tom Tromey  <tom@tromey.com>
6168
6169         PR tui/28819:
6170         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6171
6172 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6173
6174         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6175         field.
6176         * rs6000-tdep.c: Include reggroups.h.
6177         (IS_V_ALIAS_PSEUDOREG): Define.
6178         (rs6000_register_name): Return names for the "vX" aliases.
6179         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6180         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6181         aliases.  Call default_register_reggroup_p for all other
6182         pseudo-registers.
6183         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6184         New functions.
6185         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6186         Handle "vX" aliases.
6187         (v_alias_pseudo_register_collect): New function.
6188         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6189         (rs6000_gdbarch_init): Initialize "vX" aliases as
6190         pseudo-registers.  Restore registration of
6191         rs6000_pseudo_register_reggroup_p with
6192         set_tdesc_pseudo_register_reggroup_p.
6193
6194 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6195
6196         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6197         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6198         set_gdbarch_num_pseudo_regs.
6199
6200 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6201
6202         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6203         Remove arg prefixname, add do_set and do_show.
6204         Add member functions set_list and show_list.
6205         * cli/cli-style.c (class cli_style_option): Update accordingly.
6206         (style_set_list): Move to file scope.
6207         (style_show_list): Likewise.
6208         (set_style): Call help_list.
6209         (show_style): Call cmd_show_list.
6210         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6211         Update to use the new macro.
6212
6213 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6214
6215         * ada-lang.c (_initialize_ada_language): Expand the help text
6216         for the "catch exception" command.
6217
6218 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6219
6220         * symtab.c (matching_obj_sections): Initialize obj,
6221         declare it closer to its usage.
6222
6223 2019-01-10  Tom Tromey  <tom@tromey.com>
6224
6225         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6226         (basic_inf_threads_range): Remove.
6227         (inf_threads_range, inf_non_exited_threads_range)
6228         (safe_inf_threads_range): Use next_adapter.
6229
6230 2019-01-10  Keith Seitz  <keiths@redhat.com>
6231
6232         PR gdb/23712
6233         PR symtab/23010
6234         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6235         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6236
6237 2019-01-10  Keith Seitz  <keiths@redhat.com>
6238
6239         PR gdb/23712
6240         PR symtab/23010
6241         * dictionary.c (pending_to_vector): Remove.
6242         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6243         Remove _1 suffix, replacing functions of the same name.  Update
6244         all callers.
6245         (dict_create_hashed, dict_create_hashed_expandable)
6246         (dict_create_linear, dict_create_linear_expandable, dict_free)
6247         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6248         Make functions static.
6249
6250 2019-01-10  Keith Seitz  <keiths@redhat.com>
6251
6252         PR gdb/23712
6253         PR symtab/23010
6254         * dictionary.h (struct dictionary): Replace declaration with
6255         multidictionary.
6256         (dict_create_hashed, dict_create_hashed_expandable)
6257         (dict_create_linear, dict_create_linear_expandable)
6258         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6259         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6260         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6261         taking multidictionary argument.
6262         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6263         * block.h (struct block) <dict>: Change to multidictionary
6264         and rename `multidict'.
6265         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6266         symmisc.c: Update all dictionary references to multidictionary.
6267
6268 2019-01-10  Keith Seitz  <keiths@redhat.com>
6269
6270         PR gdb/23712
6271         PR symtab/23010
6272         * dictionary.c: Include unordered_map.
6273         (pending_to_vector): New function.
6274         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6275         Rewrite the non-"_1" functions to take vector instead
6276         of linked list.
6277         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6278         "new" _1 versions of the same name.
6279         (multidictionary): Define.
6280         (std::hash<enum language): New definition.
6281         (collate_pending_symbols_by_language, mdict_create_hashed)
6282         (mdict_create_hashed_expandable, mdict_create_linear)
6283         (mdict_create_linear_expandable, mdict_free)
6284         (find_language_dictionary, create_new_language_dictionary)
6285         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6286         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6287         (mdict_size, mdict_empty): New functions.
6288         * dictionary.h (mdict_iterator): Define.
6289
6290 2019-01-10  Pedro Alves  <palves@redhat.com>
6291
6292         * breakpoint.c (read_uploaded_action)
6293         (create_tracepoint_from_upload): Adjust to use
6294         gdb::unique_xmalloc_ptr.
6295         * ctf.c (ctf_write_uploaded_tp):
6296         (SET_ARRAY_FIELD): Use emplace_back.
6297         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6298         * tracefile-tfile.c (tfile_write_uploaded_tp):
6299         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6300         gdb::unique_xmalloc_ptr.
6301         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6302         at_string, cond_string, cmd_strings>: Replace char pointers
6303         with gdb::unique_xmalloc_ptr.
6304
6305 2019-01-10  Pedro Alves  <palves@redhat.com>
6306
6307         * solib-target.c (library_list_start_library): Don't xstrdup name.
6308
6309 2019-01-10  Pedro Alves  <palves@redhat.com>
6310
6311         * mdebugread.c (parse_partial_symbols): Use
6312         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6313
6314 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6315
6316         * linux-fork.c (scoped_switch_fork_info)
6317         <~scoped_switch_fork_info>: Fix incorrect variable name.
6318
6319 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6320
6321         * linux-fork.c (scoped_switch_fork_info)
6322         <scoped_switch_fork_info>: Make explicit.
6323         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6324
6325 2019-01-10  Tom Tromey  <tom@tromey.com>
6326
6327         * objfiles.h (objfile::reset_psymtabs): Update.
6328         * objfiles.c (objfile::objfile): Update.
6329         * psymtab.h (psymtab_storage::obstack): Update.
6330         (psymtab_storage::m_obstack): Use gdb::optional.
6331         (class psymtab_storage): Update comment.  Remove objfile
6332         parameter.
6333         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6334
6335 2019-01-10  Tom Tromey  <tom@tromey.com>
6336
6337         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6338         <free_psymtabs>: Now private.
6339         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6340         (allocate_psymtab): Use new method.
6341
6342 2019-01-10  Tom Tromey  <tom@tromey.com>
6343
6344         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6345         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6346         * mdebugread.c (parse_partial_symbols): Use
6347         allocate_dependencies.
6348         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6349         allocate_dependencies.
6350         (process_psymtab_comp_unit_reader)
6351         (build_type_psymtab_dependencies): Likewise.
6352         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6353
6354 2019-01-10  Tom Tromey  <tom@tromey.com>
6355
6356         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6357         PSYMBOL_SET_LANGUAGE.
6358         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6359
6360 2019-01-10  Tom Tromey  <tom@tromey.com>
6361
6362         * psymtab.h (psymtab_storage::obstack): New method.
6363         <m_obstack>: Rename from obstack; now private.
6364         * psymtab.c (psymtab_storage): Update.
6365         * dwarf2read.c (create_addrmap_from_index)
6366         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6367         Update.
6368
6369 2019-01-10  Tom Tromey  <tom@tromey.com>
6370
6371         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6372         * objfiles.h (objfile::reset_psymtabs): New method.
6373
6374 2019-01-10  Tom Tromey  <tom@tromey.com>
6375
6376         * symmisc.c (print_symbol_bcache_statistics): Update.
6377         (print_objfile_statistics): Update.
6378         * symfile.c (reread_symbols): Update.
6379         * psymtab.h (class psymtab_storage): New.
6380         * psymtab.c (psymtab_storage): New constructor.
6381         (~psymtab_storage): New destructor.
6382         (require_partial_symbols): Update.
6383         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6384         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6385         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6386         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6387         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6388         (start_psymtab_common, end_psymtab_common)
6389         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6390         (allocate_psymtab): Update.
6391         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6392         Update.
6393         (dump_psymtab_addrmap, maintenance_print_psymbols)
6394         (maintenance_check_psymtabs): Update.
6395         (class objfile_psymtabs): Move to objfiles.h.
6396         * psympriv.h (discard_psymtab): Now inline.
6397         (psymtab_discarder::psymtab_discarder): Update.
6398         (psymtab_discarder::~psymtab_discarder): Update.
6399         (ALL_OBJFILE_PSYMTABS): Rewrite.
6400         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6401         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6402         Remove fields.
6403         <partial_symtabs>: New field.
6404         (class objfile_psymtabs): Move from psymtab.h.  Update.
6405         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6406         psymbol_cache.
6407         (objfile::~objfile): Don't destroy psymbol_cache.
6408         * mdebugread.c (parse_partial_symbols): Update.
6409         * dwarf2read.c (create_addrmap_from_index)
6410         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6411         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6412         (add_partial_subprogram, dwarf2_ranges_read): Update.
6413         * dwarf-index-write.c (write_address_map)
6414         (write_one_signatured_type, recursively_write_psymbols)
6415         (class debug_names, class debug_names, write_psymtabs_to_index):
6416         Update.
6417
6418 2019-01-10  Tom Tromey  <tom@tromey.com>
6419
6420         * symtab.h (SYMBOL_SET_NAMES): Update.
6421         (symbol_set_names): Update.
6422         (MSYMBOL_SET_NAMES): Update.
6423         * symtab.c (symbol_set_names): Change argument to be an
6424         objfile_per_bfd_storage.
6425         * psymtab.c (add_psymbol_to_bcache): Update.
6426         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6427
6428 2019-01-10  Tom Tromey  <tom@tromey.com>
6429
6430         * symtab.c (create_demangled_names_hash): Change argument to be an
6431         objfile_per_bfd_storage.
6432         (symbol_set_names): Update.
6433
6434 2019-01-10  Tom Tromey  <tom@tromey.com>
6435
6436         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6437         init_psymbol_list.
6438         * psymtab.c (init_psymbol_list): Do nothing if already called.
6439         * psympriv.h (init_psymbol_list): Add comment.
6440         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6441         init_psymbol_list.
6442         * dbxread.c (dbx_symfile_read): Unconditionally call
6443         init_psymbol_list.
6444
6445 2019-01-10  Tom Tromey  <tom@tromey.com>
6446
6447         * xcoffread.c (scan_xcoff_symtab): Update.
6448         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6449         "where".
6450         * mdebugread.c (parse_partial_symbols)
6451         (handle_psymbol_enumerators): Update.
6452         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6453         * dbxread.c (read_dbx_symtab): Update.
6454         * psympriv.h (psymbol_placement): New enum.
6455         (add_psymbol_to_list): Update.
6456
6457 2019-01-10  Tom Tromey  <tom@tromey.com>
6458
6459         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6460         static_psymbols parameters.
6461         (scan_xcoff_symtab): Update.
6462         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6463         static_psymbols parameters.
6464         * psympriv.h (start_psymtab_common): Update.
6465         * mdebugread.c (parse_partial_symbols): Update.
6466         * dwarf2read.c (create_partial_symtab): Update.
6467         * dbxread.c (read_dbx_symtab): Update.
6468         (start_psymtab): Remove global_psymbols and static_psymbols
6469         parameters.
6470
6471 2019-01-10  Tom Tromey  <tom@tromey.com>
6472
6473         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6474         * psymtab.c (allocate_psymtab): Add comment.
6475         * psympriv.h (allocate_psymtab): Add comment.
6476         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6477         initializations.
6478         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6479
6480 2019-01-10  Tom Tromey  <tom@tromey.com>
6481
6482         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6483         Don't declare.
6484         * mipsread.c: Include mdebugread.h.
6485         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6486         Declare.
6487         * elfread.c: Include mdebugread.h.
6488
6489 2019-01-09  Tom Tromey  <tom@tromey.com>
6490
6491         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6492         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6493         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6494         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6495         (psym_lookup_symbol, psym_find_last_source_symtab)
6496         (psym_forget_cached_source_info, psym_print_stats)
6497         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6498         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6499         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6500         (psym_find_compunit_symtab_by_address)
6501         (maintenance_print_psymbols, maintenance_info_psymtabs)
6502         (maintenance_check_psymtabs): Use ranged for.
6503         * psymtab.h (class objfile_psymtabs): New.
6504         (require_partial_symbols): Return objfile_psymtabs.
6505         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6506
6507 2019-01-09  Tom Tromey  <tom@tromey.com>
6508
6509         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6510         (find_pc_mapped_section, list_overlays_command)
6511         (map_overlay_command, unmap_overlay_command)
6512         (simple_overlay_update): Use all_objfiles.
6513         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6514         * printcmd.c (info_symbol_command): Use all_objfiles.
6515         * objfiles.h (ALL_OBJSECTIONS): Remove.
6516         * maint.c (maintenance_translate_address): Use all_objfiles.
6517         * gcore.c (gcore_create_callback): Use all_objfiles.
6518         (objfile_find_memory_regions): Likewise.
6519
6520 2019-01-09  Tom Tromey  <tom@tromey.com>
6521
6522         * symtab.c (find_line_symtab, info_sources_command)
6523         (make_source_files_completion_list): Use objfile_compunits.
6524         * source.c (select_source_symtab): Use objfile_compunits.
6525         * objfiles.h (struct objfile): Update comment.
6526         (ALL_OBJFILES): Remove.
6527         (ALL_FILETABS): Remove.
6528         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6529         objfile_compunits.
6530
6531 2019-01-09  Tom Tromey  <tom@tromey.com>
6532
6533         * symmisc.c (print_objfile_statistics, dump_objfile)
6534         (maintenance_print_symbols): Use compunit_filetabs.
6535         * source.c (forget_cached_source_info_for_objfile): Use
6536         compunit_filetabs.
6537         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6538         (ALL_FILETABS): Use compunit_filetabs.
6539         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6540         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6541
6542 2019-01-09  Tom Tromey  <tom@tromey.com>
6543
6544         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6545         (compunit_filetabs): New.
6546         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6547         compunit_filetabs.
6548         (info_sources_command, make_source_files_completion_list): Remove
6549         declaration.
6550         * symmisc.c (print_objfile_statistics, dump_objfile)
6551         (maintenance_print_symbols): Remove declaration.
6552         (maintenance_info_symtabs): Use compunit_filetabs.
6553         (maintenance_info_line_tables): Likewise.
6554         * source.c (select_source_symtab): Change local variable name.
6555         (forget_cached_source_info_for_objfile): Remove declaration.
6556         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6557         * objfiles.c (objfile_relocate1): Remove declaration.
6558         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6559         declaration.
6560         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6561         * coffread.c (coff_symtab_read): Remove declaration.
6562         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6563         compunit_filetabs.
6564
6565 2019-01-09  Tom Tromey  <tom@tromey.com>
6566
6567         * symtab.c (lookup_objfile_from_block)
6568         (find_pc_sect_compunit_symtab, search_symbols)
6569         (default_collect_symbol_completion_matches_break_on): Use
6570         objfile_compunits.
6571         * objfiles.h (ALL_COMPUNITS): Remove.
6572         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6573         * cp-support.c (add_symbol_overload_list_qualified): Use
6574         objfile_compunits.
6575         * ada-lang.c (ada_collect_symbol_completion_matches)
6576         (ada_add_global_exceptions): Use objfile_compunits.
6577
6578 2019-01-09  Tom Tromey  <tom@tromey.com>
6579
6580         * source.c (select_source_symtab)
6581         (forget_cached_source_info_for_objfile): Remove declaration.
6582         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6583         declaration.
6584         * maint.c (count_symtabs_and_blocks): Remove declaration.
6585         * cp-support.c (add_symbol_overload_list_qualified): Remove
6586         declaration.
6587         * coffread.c (coff_symtab_read): Remove declaration.
6588         * symtab.c (lookup_symbol_in_objfile_symtabs)
6589         (basic_lookup_transparent_type_1): Use objfile_compunits.
6590         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6591         (info_sources_command, search_symbols)
6592         (default_collect_symbol_completion_matches_break_on)
6593         (make_source_files_completion_list): Remove declaration.
6594         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6595         (ada_collect_symbol_completion_matches)
6596         (ada_add_global_exceptions): Remove declaration.
6597         * linespec.c (iterate_over_all_matching_symtabs): Use
6598         objfile_compunits.
6599         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6600         (class objfile_compunits): New.
6601         (ALL_COMPUNITS): Use objfile_compunits.
6602         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6603         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6604         objfile_compunits.
6605         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6606
6607 2019-01-09  Tom Tromey  <tom@tromey.com>
6608
6609         * symtab.c (search_symbols)
6610         (default_collect_symbol_completion_matches_break_on): Use
6611         objfile_msymbols.
6612         * ada-lang.c (ada_lookup_simple_minsym)
6613         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6614         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6615         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6616         objfile_msymbols.
6617         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6618         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6619         * objc-lang.c (find_methods): Use objfile_msymbols.
6620         (info_selectors_command, info_classes_command): Likewise.
6621         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6622         * objfiles.h (class objfile_msymbols): New.
6623         (ALL_OBJFILE_MSYMBOLS): Remove.
6624         (ALL_MSYMBOLS): Remove.
6625
6626 2019-01-09  Tom Tromey  <tom@tromey.com>
6627
6628         * common/next-iterator.h (next_adapter): Add Iterator template
6629         parameter.
6630         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6631         (class all_objfiles_safe): New.
6632         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6633         * objfiles.c (put_objfile_before): Update comment.
6634         (add_separate_debug_objfile): Likewise.
6635         (free_all_objfiles): Use all_objfiles_safe.
6636         (objfile_purge_solibs): Likewise.
6637
6638 2019-01-09  Tom Tromey  <tom@tromey.com>
6639
6640         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6641         (expand_symtab_containing_pc, lookup_static_symbol)
6642         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6643         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6644         all_objfiles.
6645         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6646         * breakpoint.c (create_overlay_event_breakpoint)
6647         (create_longjmp_master_breakpoint)
6648         (create_std_terminate_master_breakpoint)
6649         (create_exception_master_breakpoint): Use all_objfiles.
6650         * linux-thread-db.c (try_thread_db_load_from_pdir)
6651         (has_libpthread): Use all_objfiles.
6652         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6653         * linespec.c (iterate_over_all_matching_symtabs)
6654         (search_minsyms_for_name): Use all_objfiles.
6655         * maint.c (maintenance_info_sections): Use all_objfiles.
6656         * main.c (captured_main_1): Use all_objfiles.
6657         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6658         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6659         * guile/scm-pretty-print.c
6660         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6661         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6662         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6663         (maintenance_print_msymbols): Use all_objfiles.
6664         * source.c (select_source_symtab): Use all_objfiles.
6665         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6666         * symfile.c (remove_symbol_file_command)
6667         (expand_symtabs_matching, map_symbol_filenames): Use
6668         all_objfiles.
6669         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6670         all_objfiles.
6671         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6672         * objc-lang.c (find_methods): Use all_objfiles.
6673         * objfiles.c (have_partial_symbols, have_full_symbols)
6674         (have_minimal_symbols, qsort_cmp)
6675         (default_iterate_over_objfiles_in_search_order): Use
6676         all_objfiles.
6677         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6678         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6679         (maintenance_check_psymtabs): Use all_objfiles.
6680         (ALL_PSYMTABS): Remove.
6681         * compile/compile-object-run.c (do_module_cleanup): Use
6682         all_objfiles.
6683         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6684         * cp-support.c (add_symbol_overload_list_qualified): Use
6685         all_objfiles.
6686         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6687         Use all_objfiles.
6688         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6689         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6690         all_objfiles.
6691         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6692         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6693         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6694         Uses all_objfiles.
6695         * solib.c (solib_read_symbols): Use all_objfiles
6696
6697 2019-01-09  Tom Tromey  <tom@tromey.com>
6698
6699         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6700         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6701         all_objfiles.
6702         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6703         * symmisc.c (print_symbol_bcache_statistics)
6704         (print_objfile_statistics, maintenance_print_objfiles)
6705         (maintenance_info_symtabs, maintenance_check_symtabs)
6706         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6707         all_objfiles.
6708         * source.c (forget_cached_source_info): Use all_objfiles.
6709         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6710         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6711         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6712         * objfiles.c (update_section_map): Use all_objfiles.
6713         (shared_objfile_contains_address_p): Likewise.
6714         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6715         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6716
6717 2019-01-09  Tom Tromey  <tom@tromey.com>
6718
6719         * common/next-iterator.h: New file.
6720         * objfiles.h (class all_objfiles): New.
6721         (struct objfile_iterator): New.
6722
6723 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6724
6725         * NEWS: Move the description of the changed "frame", "select-frame",
6726          and "info frame" commands to the Changed commands section.
6727
6728 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6729
6730         * gdbtypes.c (check_stub_method_group): Remove handling of old
6731         mangling schemes.
6732         * linespec.c (find_methods): Likewise.
6733         * stabsread.c (read_member_functions): Likewise.
6734         * valops.c (search_struct_method): Likewise.
6735         (value_struct_elt_for_reference): Likewise.
6736         * NEWS: Mention this change.
6737
6738 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6739
6740         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6741         print_source_lines.
6742         * source.c (print_source_lines_base): Update line number check.
6743         (print_source_lines): New function.
6744         (source_lines_range::source_lines_range): New function.
6745         * source.h (class source_lines_range): New class.
6746         (print_source_lines): New declaration.
6747
6748 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6749
6750         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6751
6752 2019-01-08  Tom Tromey  <tom@tromey.com>
6753             Simon Marchi  <simon.marchi@ericsson.com>
6754
6755         PR gdb/24060
6756         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6757         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6758         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6759         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6760         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6761         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6762
6763 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6764
6765         * source.c (select_source_symtab): Move header comment to
6766         declaration in source.h.
6767         (forget_cached_source_info_for_objfile): Likewise.
6768         (forget_cached_source_info): Likewise.
6769         (identify_source_line): Likewise.
6770         * source.h (identify_source_line): Move declaration from symtab.h
6771         and add comment from source.c
6772         (print_source_lines): Likewise.
6773         (forget_cached_source_info_for_objfile): Likewise.
6774         (forget_cached_source_info): Likewise.
6775         (select_source_symtab): Likewise.
6776         (enum print_source_lines_flag): Move definition from symtab.h.
6777         * symtab.h (identify_source_line): Move declaration to source.h.
6778         (print_source_lines): Likewise.
6779         (forget_cached_source_info_for_objfile): Likewise.
6780         (forget_cached_source_info): Likewise.
6781         (select_source_symtab): Likewise.
6782         (enum print_source_lines_flag): Move definition to source.h.
6783         * tui/tui-hooks.c: Add 'source.h' include.
6784
6785 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6786
6787         * source.c (print_source_lines_base): Handle requests to print
6788         reverse line number sequences, and guard against empty lines
6789         string.
6790
6791 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6792
6793         * source.c (print_source_lines_base): Fix skip of '\r' if next
6794         character is '\n'.
6795
6796 2019-01-06  Tom Tromey  <tom@tromey.com>
6797
6798         * c-exp.y (struct c_parse_state) <macro_original_text,
6799         expansion_obstack>: New member.
6800         (macro_original_text, expansion_obstack): Remove globals.
6801         (scan_macro_expansion, scanning_macro_expansion)
6802         (finished_macro_expansion): Update.
6803         (scan_macro_cleanup): Remove.
6804         (yylex, c_parse): Update.
6805
6806 2019-01-06  Tom Tromey  <tom@tromey.com>
6807
6808         * c-exp.y (struct c_parse_state) <strings>: New member.
6809         (operator_stoken): Update.
6810
6811 2019-01-06  Tom Tromey  <tom@tromey.com>
6812
6813         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6814         (union type_stack_elt) <typelist_val>: Now a pointer to
6815         std::vector.
6816         (type_stack_cleanup): Don't declare.
6817         (push_typelist): Update.
6818         * parse.c (pop_typelist): Return a std::vector.
6819         (push_typelist): Take a std::vector.
6820         (follow_types): Update.  Do not free args.
6821         (type_stack_cleanup): Remove.
6822         * c-exp.y (struct c_parse_state): New.
6823         (cpstate): New global.
6824         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6825         (nonempty_typelist): Update.
6826         (func_mod): Create a new vector.
6827         (c_parse): Create a c_parse_state.
6828         (check_parameter_typelist): Do not delete params.
6829         (function_method): Update.  Do not delete type_list.
6830
6831 2019-01-06  Tom Tromey  <tom@tromey.com>
6832
6833         PR gdb/28155:
6834         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6835         check_typedef.
6836         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6837         (print_return_value): Likewise.
6838
6839 2019-01-05  Tom Tromey  <tom@tromey.com>
6840
6841         * contrib/cleanup_check.py: Remove.
6842         * contrib/gcc-with-excheck: Remove.
6843         * contrib/exsummary.py: Remove.
6844         * contrib/excheck.py: Remove.
6845
6846 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6847
6848         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6849         NULL. Initialize tpprev to NULL instead of assigning it
6850         to NULL on the next statement.
6851         * windows-nat.c (windows_delete_thread): Remove check for
6852         main_thread_id before printing thread exit notifications.
6853         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6854         Remove thread ID check against main_thread_id.
6855         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6856         windows_delete_thread.
6857         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6858
6859 2019-01-04  Tom Tromey  <tom@tromey.com>
6860
6861         * compile/compile.c (_initialize_compile): Use upper case for
6862         metasyntactic variables.
6863         * symmisc.c (_initialize_symmisc): Use upper case for
6864         metasyntactic variables.
6865         * psymtab.c (_initialize_psymtab): Use upper case for
6866         metasyntactic variables.
6867         * demangle.c (demangle_command): Use upper case for metasyntactic
6868         variables.
6869         (_initialize_demangler): Likewise.
6870         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6871         variables.
6872
6873 2019-01-03  Tom Tromey  <tom@tromey.com>
6874
6875         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6876
6877 2019-01-03  Tom Tromey  <tom@tromey.com>
6878
6879         * python/py-symtab.c (salpy_str): Update.
6880         (struct salpy_sal_object) <symtab>: Now a PyObject.
6881         (salpy_dealloc): Update.
6882         (del_objfile_sal): Use gdbpy_ref.
6883
6884 2019-01-03  Tom Tromey  <tom@tromey.com>
6885
6886         * python/py-type.c (convert_field): Use new_reference.  Return
6887         gdbpy_ref.
6888         (make_fielditem): Return gdbpy_ref.
6889         (typy_fields): Update.
6890         (typy_getitem): Update.
6891         (field_name): Return gdbpy_ref.  Use new_reference.
6892         (typy_iterator_iternext): Update.
6893
6894 2019-01-03  Tom Tromey  <tom@tromey.com>
6895
6896         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6897
6898 2019-01-03  Tom Tromey  <tom@tromey.com>
6899
6900         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6901         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6902         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6903         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6904         (pspy_set_type_printers): Likewise.
6905         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6906         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6907         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6908         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6909         (objfpy_set_type_printers): Likewise.
6910
6911 2019-01-03  Tom Tromey  <tom@tromey.com>
6912
6913         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6914         (gdbpy_print_stack): Use gdbpy_err_fetch.
6915         * python/python-internal.h (class gdbpy_err_fetch): New class.
6916         (class gdbpy_enter) <m_error_type, m_error_value,
6917         m_error_traceback>: Remove.
6918         <m_error>: New member.
6919         (gdbpy_exception_to_string): Don't declare.
6920         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6921         * python/py-value.c (convert_value_from_python): Use
6922         gdbpy_err_fetch.
6923         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6924         gdbpy_exception_to_string.
6925         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6926         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6927         gdbpy_err_fetch.
6928
6929 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6930
6931         * linux-nat.c (delete_lwp_cleanup): Delete.
6932         (struct lwp_deleter): New struct.
6933         (lwp_info_up): New typedef.
6934         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6935         lwp_info_up.
6936
6937 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6938
6939         * linux-fork.c (class scoped_switch_fork_info): New class.
6940         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6941
6942 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6943
6944         * valops.c (find_overload_match): Remove use of null_cleanup, and
6945         calls to do_cleanups.
6946
6947 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6948
6949         * compile/compile-cplus-types.c
6950         (compile_cplus_instance::decl_name): Handle changes to
6951         cp_func_name.
6952         * cp-support.c (cp_func_name): Update header comment, update
6953         return type.
6954         * cp-support.h (cp_func_name): Update return type in declaration.
6955         * valops.c (find_overload_match): Move temp_func local to top
6956         level of function and change its type.  Use temp_func to hold and
6957         delete temporary string obtained from cp_func_name.
6958
6959 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6960
6961         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6962         gdb::char_vector, remove cleanup, and update uses of `msg`.
6963
6964 2019-01-03  Jim Wilson  <jimw@sifive.com>
6965
6966         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6967
6968 2019-01-02  Tom Tromey  <tom@tromey.com>
6969
6970         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6971         (tdesc_parse_xml): Remove cleanups.
6972         * target-descriptions.h (make_cleanup_free_target_description):
6973         Don't declare.
6974         (target_desc_deleter): New struct.
6975         (target_desc_up): New typedef.
6976         * target-descriptions.c (target_desc_deleter::operator()): Rename
6977         from free_target_description.
6978         (make_cleanup_free_target_description): Remove.
6979
6980 2019-01-02  Tom Tromey  <tom@tromey.com>
6981
6982         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6983         constructor, destructor.
6984         (linespec_parser): Remove typedef.
6985         (~linespec_parser): Rename from linespec_parser_delete.
6986         (linespec_lex_to_end, linespec_complete_label)
6987         (linespec_complete): Update.
6988         (decode_line_full): Remove cleanups.
6989         (decode_line_1): Update.
6990
6991 2019-01-02  Tom Tromey  <tom@tromey.com>
6992
6993         * python/python-internal.h (inferior_to_inferior_object): Change
6994         return type.
6995         * python/py-exitedevent.c (create_exited_event_object): Update.
6996         * python/py-inferior.c (inferior_to_inferior_object): Return
6997         gdbpy_ref.
6998         (python_new_inferior, python_inferior_deleted)
6999         (thread_to_thread_object, delete_thread_object)
7000         (build_inferior_list, gdbpy_selected_inferior): Update.
7001         * python/py-infthread.c (create_thread_object): Update.  Also fail
7002         if inferior_to_inferior_object fails.
7003
7004 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7005
7006         * inferior.h (class inferior) <displaced_step_state>: New field.
7007         * infrun.h (struct displaced_step_state): Move here from
7008         infrun.c.  Initialize fields, add constructor.
7009         <inf>: Remove field.
7010         <reset>: New method.
7011         * infrun.c (struct displaced_step_inferior_state): Move to
7012         infrun.h.
7013         (displaced_step_inferior_states): Remove.
7014         (get_displaced_stepping_state): Adust.
7015         (displaced_step_in_progress_any_inferior): Adjust.
7016         (displaced_step_in_progress_thread): Adjust.
7017         (displaced_step_in_progress): Adjust.
7018         (add_displaced_stepping_state): Remove.
7019         (get_displaced_step_closure_by_addr): Adjust.
7020         (remove_displaced_stepping_state): Remove.
7021         (infrun_inferior_exit): Call displaced_step_state.reset.
7022         (use_displaced_stepping): Don't check for NULL.
7023         (displaced_step_prepare_throw): Call
7024         get_displaced_stepping_state.
7025         (displaced_step_fixup): Don't check for NULL.
7026         (prepare_for_detach): Don't check for NULL.
7027
7028 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7029
7030         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7031          in case of call that did not complete.
7032
7033 2019-01-02  Andrey Utkin  <autkin@undo.io>
7034
7035         * symfile.c (find_separate_debug_file): Fix search of debug files for
7036         remote debuggee.
7037
7038 2019-01-02  Tom Tromey  <tom@tromey.com>
7039
7040         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7041         indentation.
7042         * python/py-frame.c (frapy_older): Remove cast.
7043         (frapy_newer): Likewise.
7044         * python/py-breakpoint.c (local_setattro): Remove cast.
7045         * python/py-arch.c (archpy_name): Remove local variable.
7046         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7047
7048 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7049
7050         * unittests/basic_string_view/element_access/char/empty.cc:
7051         Fix year range in copyright header.
7052
7053 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7054
7055         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7056         Delete.
7057         <operator==>: Update with for removed field.
7058         <hash>: Likewise.
7059         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7060         <isa_features>: ...this.
7061         <abi_features>: New field.
7062         (riscv_isa_flen): Update comment.
7063         (riscv_abi_xlen): New declaration.
7064         (riscv_abi_flen): New declaration.
7065         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7066         isa_features.
7067         (riscv_abi_xlen): New function.
7068         (riscv_isa_flen): Update to get answer from isa_features.
7069         (riscv_abi_flen): New function.
7070         (riscv_has_fp_abi): Update to get answer from abi_features.
7071         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7072         xlen and flen.
7073         (riscv_call_info) <xlen, flen>: Update comment.
7074         (riscv_call_arg_struct): Remove invalid assertions
7075         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7076         is removed.
7077         (riscv_gdbarch_init): Gather isa features and abi features
7078         separately, ensure both match on the gdbarch when reusing an old
7079         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7080         a target with 64-bit float hardware.
7081
7082 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7083
7084         * source.c (search_command_helper): Stop reverse search
7085         when line 1 has been searched.
7086
7087 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7088
7089         * record-full.c (record_full_base_target::close): Rewrite
7090         record_full_core_buf_list free logic.
7091
7092 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7093
7094         * break-catch-syscall.c (print_one_catch_syscall): xfree
7095         the last text.
7096
7097 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7098
7099         * top.c (print_gdb_version): Update Copyright year in version
7100         message.
7101
7102 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7103
7104         Update copyright year range in all GDB files.
7105
7106 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7107
7108         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7109
7110 For older changes see ChangeLog-2018.
7111 \f
7112 Local Variables:
7113 mode: change-log
7114 left-margin: 8
7115 fill-column: 74
7116 version-control: never
7117 coding: utf-8
7118 End:
7119