gdb/ChangeLog

   1 2019-05-04  Tom Tromey  <tom@tromey.com>
   2
   3         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
   4
   5 2019-05-04  Tom Tromey  <tom@tromey.com>
   6
   7         * cli/cli-cmds.c (valid_command_p): Return bool.
   8
   9 2019-05-04  Tom Tromey  <tom@tromey.com>
  10
  11         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
  12         * command.h (valid_user_defined_cmd_name_p): Channge return type.
  13
  14 2019-05-04  Raul Tambre  <raul@tambre.ee>
  15
  16         * python/lib/gdb/prompt.py (_ExtendedPrompt)
  17         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
  18         operator for comparison.
  19
  20 2019-05-04  Tom Tromey  <tom@tromey.com>
  21
  22         * psymtab.c (psymbol_name_matches, match_partial_symbol)
  23         (lookup_partial_symbol, print_partial_symbols)
  24         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
  25         (psymbol_compare): Update.
  26         (add_psymbol_to_bcache): Clear the entire psymbol.
  27         (maintenance_check_psymtabs): Update.
  28         * psympriv.h (struct partial_symbol): Don't derive from
  29         general_symbol_info.
  30         <obj_section, unrelocated_address, address,
  31         set_unrelocated_address>: Update.
  32         <ginfo>: New member.
  33         * dwarf-index-write.c (write_psymbols, debug_names::insert)
  34         (debug_names::write_psymbols): Update.
  35
  36 2019-05-04  Tom de Vries  <tdevries@suse.de>
  37
  38         * contrib/cc-with-tweaks.sh: Support -n arg.
  39
  40 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  41
  42         * corelow.c (core_target::detach): Ensure frame cache and
  43         register caches are cleared.
  44         inferior.c (exit_inferior_1): Likewise.
  45
  46 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
  47             Tom Tromey  <tom@tromey.com>
  48
  49         * dictionary.c (collate_pending_symbols_by_language): Remove
  50         "struct" from foreach.
  51         * symtab.c (lookup_global_symbol_from_objfile)
  52         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
  53         foreach.
  54         * ser-tcp.c (net_open): Remove "struct" from foreach.
  55         * objfiles.c (objfile_relocate, objfile_rebase)
  56         (objfile_has_symbols): Remove "struct" from foreach.
  57         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
  58         from foreach.
  59         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
  60         foreach.
  61         * darwin-nat.c (thread_info_from_private_thread_info): Remove
  62         "struct" from foreach.
  63         * ada-lang.c (create_excep_cond_exprs)
  64         (ada_exception_catchpoint_cond_string): Remove "struct" from
  65         foreach.
  66
  67 2019-05-03  Tom Tromey  <tromey@adacore.com>
  68
  69         * ada-exp.y (convert_char_literal): Check suffix of each
  70         enumerator.
  71
  72 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
  73
  74         PR ada/21406:
  75         * ada-exp.y (yywrap): Don't define.
  76         * ada-lex.l (%option): Add noyywrap
  77         (yywrap): Remove.
  78
  79 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
  80
  81         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
  82         _WIN32_WINNT to the XP level, unless already defined to a higher
  83         level.
  84
  85         * unittests/parse-connection-spec-selftests.c:
  86         * ser-tcp.c:
  87         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
  88         override.
  89
  90         * symfile.c (find_separate_debug_file): Remove colon from the
  91         drive spec of DOS/Windows file names of the target, so that the
  92         file name produced from DEBUGDIR and the target's directory will
  93         be valid on DOS/Windows systems.
  94
  95 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
  96
  97         * rust-lang.c (val_print_struct): Handle printing structures
  98         containing strings.
  99
 100 2019-05-02  Tom Tromey  <tromey@adacore.com>
 101
 102         * valarith.c (_initialize_valarith): Remove.
 103
 104 2019-05-01  Tom Tromey  <tromey@adacore.com>
 105
 106         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 107         bitfields.
 108
 109 2019-05-01  Tom Tromey  <tromey@adacore.com>
 110
 111         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 112         for big-endian copies.
 113
 114 2019-04-30  Ali Tamur  <tamur@google.com>
 115         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 116         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 117         (read_3_bytes): New function.
 118
 119 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 120
 121         * windows-nat.c (main_thread_id): Delete.
 122         (handle_output_debug_string): Replace main_thread_id by
 123         current_event.dwThreadId.
 124         (fake_create_process): Likewise.
 125         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 126         Do not set main_thread_id.
 127         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 128         current_event.dwThreadId.
 129         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 130
 131 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 132
 133         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 134         Use current_event.dwThreadId instead of main_thread_id.
 135
 136 2019-04-30  Tom Tromey  <tromey@adacore.com>
 137
 138         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 139         (create_excep_cond_exprs): Iterate over program spaces.
 140         (ada_exception_catchpoint_cond_string): Examine all minimal
 141         symbols for exception types.
 142
 143 2019-04-30  Tom Tromey  <tromey@adacore.com>
 144
 145         PR c++/24470:
 146         * dwarf2read.c (process_structure_scope): Handle case where type
 147         has template parameters but no symbol was created.
 148
 149 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 150             Chris January  <chris.january@arm.com>
 151
 152         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 153         qualifier.
 154         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 155
 156 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 157
 158         * f-typeprint.c (f_print_type): Update rules for printing
 159         whitespace.
 160         (f_type_print_varspec_suffix): Likewise.
 161
 162 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 163             Chris January  <chris.january@arm.com>
 164
 165         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 166         function arguments.
 167
 168 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 169
 170         * f-lang.c (build_fortran_types): Change name of void type to
 171         lower case.
 172         * f-typeprint.c (f_type_print_base): Print the name of the void
 173         type, rather than a fixed string.
 174         * f-valprint.c (f_decorations): Use lower case void string.
 175
 176 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 177             Chris January  <chris.january@arm.com>
 178
 179         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 180         types for Fortran.
 181
 182 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 183             Chris January  <chris.january@arm.com>
 184             David Lecomber  <david.lecomber@arm.com>
 185
 186         * f-exp.y (BINOP_INTRINSIC): New token.
 187         (exp): New parser rule handling BINOP_INTRINSIC.
 188         (f77_keywords): Add new builtin procedures.
 189         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 190         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 191         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 192         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 193         (print_unop_subexp_f): New function.
 194         (print_binop_subexp_f): New function.
 195         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 196         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 197         (dump_subexp_body_f): Likewise.
 198         (operator_check_f): Likewise.
 199         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 200         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 201
 202 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 203
 204         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 205         UNOP_KIND.
 206         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 207         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 208         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 209         (operator_length_f): New fuction.
 210         (print_subexp_f): New function.
 211         (op_name_f): New function.
 212         (dump_subexp_body_f): New function.
 213         (operator_check_f): New function.
 214         (exp_descriptor_f): Replace standard expression handling functions
 215         with new functions.
 216         * gdb/fortran-operator.def: New file.
 217         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 218         * gdb/std-operator.def: Remove UNOP_KIND.
 219
 220 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 221
 222         * std-operator.def: Remove unbalanced, stray double quote
 223         character.
 224
 225 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 226             Chris January  <chris.january@arm.com>
 227             Daniel Everett  <daniel.everett@arm.com>
 228             Nick Forrington  <nick.forrington@arm.com>
 229             Richard Bunt  <richard.bunt@arm.com>
 230
 231         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 232         of depth when printing anonymous structs or unions.
 233         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 234         Don't print either the top-level value, or the children if the
 235         max-depth is exceeded.
 236         (ppscm_print_children): When printing the key of a map, allow one
 237         extra level of depth.
 238         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 239         print either the top-level value, or the children if the max-depth
 240         is exceeded.
 241         (print_children): When printing the key of a map, allow one extra
 242         level of depth.
 243         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 244         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 245         (user_print_options): Initialise max_depth field.
 246         (val_print_scalar_or_string_type_p): New function.
 247         (val_print): Check to see if the max depth has been reached.
 248         (val_print_check_max_depth): Define new function.
 249         (show_print_max_depth): New function.
 250         (_initialize_valprint): Add 'print max-depth' option.
 251         * valprint.h (struct value_print_options) <max_depth>: New field.
 252         (val_print_check_max_depth): Declare new function.
 253         * NEWS: Document new feature.
 254
 255 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 256
 257         * ada-lang.c (ada_language_defn): Initialise new field.
 258         * c-lang.c (c_is_string_type_p): New function.
 259         (c_language_defn): Initialise new field.
 260         (cplus_language_defn): Initialise new field.
 261         (asm_language_defn): Initialise new field.
 262         (minimal_language_defn): Initialise new field.
 263         * c-lang.h (c_is_string_type_p): Declare new function.
 264         * d-lang.c (d_language_defn): Initialise new field.
 265         * f-lang.c (f_is_string_type_p): New function.
 266         (f_language_defn): Initialise new field.
 267         * go-lang.c (go_is_string_type_p): New function.
 268         (go_language_defn): Initialise new field.
 269         * language.c (default_is_string_type_p): New function.
 270         (unknown_language_defn): Initialise new field.
 271         (auto_language_defn): Initialise new field.
 272         * language.h (struct language_defn) <la_is_string_type_p>: New
 273         member variable.
 274         (default_is_string_type_p): Declare new function.
 275         * m2-lang.c (m2_language_defn): Initialise new field.
 276         * objc-lang.c (objc_language_defn): Initialise new field.
 277         * opencl-lang.c (opencl_language_defn): Initialise new field.
 278         * p-lang.c (pascal_is_string_type_p): New function.
 279         (pascal_language_defn): Initialise new field.
 280         * rust-lang.c (rust_is_string_type_p): New function.
 281         (rust_language_defn): Initialise new field.
 282
 283 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 284
 285         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 286         New field.
 287         * ada-lang.c (ada_language_defn): Initialise new field.
 288         * c-lang.c (c_language_defn): Likewise.
 289         (cplus_language_defn): Likewise.
 290         (asm_language_defn): Likewise.
 291         (minimal_language_defn): Likewise.
 292         * d-lang.c (d_language_defn): Likewise.
 293         * f-lang.c (f_language_defn): Likewise.
 294         * go-lang.c (go_language_defn): Likewise.
 295         * language.c (unknown_language_defn): Likewise.
 296         (auto_language_defn): Likewise.
 297         * m2-lang.c (m2_language_defn): Likewise.
 298         * objc-lang.c (objc_language_defn): Likewise.
 299         * opencl-lang.c (opencl_language_defn): Likewise.
 300         * p-lang.c (pascal_language_defn): Likewise.
 301         * rust-lang.c (rust_language_defn): Likewise.
 302
 303 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 304
 305         * ada-lang.c (ada_is_character_type): Change return type to bool.
 306         (ada_is_string_type): Likewise.
 307         * ada-lang.h (ada_is_character_type): Update declaration
 308         (ada_is_string_type): Likewise.
 309
 310 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 311
 312         Support style in 'frame|thread apply'
 313
 314         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 315         * record.c (record_start, record_stop): Update callers of
 316         execute_command_to_string with false.
 317         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 318         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 319         methods.
 320         (class string_file): New constructor with term_out parameter.
 321         Override methods term_out and can_emit_style_escape.  New member
 322         term_out.
 323         (class stdio_file): Override can_emit_style_escape.
 324         (class tee_file): Override term_out and can_emit_style_escape.
 325         * utils.h (can_emit_style_escape): Remove.
 326         * utils.c (can_emit_style_escape): Likewise.
 327         Update all callers of can_emit_style_escape (SOMESTREAM) to
 328         SOMESTREAM->can_emit_style_escape.
 329         * source-cache.c (source_cache::get_source_lines): Likewise.
 330         * stack.c (frame_apply_command_count): Call execute_command_to_string
 331         passing the term_out characteristic of the current gdb_stdout.
 332         * thread.c (thr_try_catch_cmd): Likewise.
 333         * top.c (execute_command_to_string): pass term_out parameter
 334         to construct the string_file for the command output.
 335         * ui-file.c (term_cli_styling): New function (most code moved
 336         from utils.c can_emit_style_escape).
 337         (string_file::string_file, string_file::can_emit_style_escape,
 338         stdio_file::can_emit_style_escape, tee_file::term_out,
 339         tee_file::can_emit_style_escape): New functions.
 340
 341 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 342
 343         * NEWS: Mention the new set|show may-call-functions.
 344         * infcall.c (may_call_functions_p): New variable.
 345         (show_may_call_functions_p): New function.
 346         (call_function_by_hand_dummy): Throws an error if not
 347         may-call-functions.
 348         (_initialize_infcall): Call add_setshow_boolean_cmd for
 349         may-call-functions.
 350
 351 2019-04-25  Keith Seitz  <keiths@redhat.com>
 352
 353         PR c++/24367
 354         * cp-support.c (inspect_type): Don't attempt substitutions
 355         of symbol with the same name.
 356
 357 2019-04-25  Tom Tromey  <tromey@adacore.com>
 358
 359         PR gdb/24475:
 360         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 361         static.
 362
 363 2019-04-25  Tom Tromey  <tromey@adacore.com>
 364
 365         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 366         rvalue reference.
 367         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 368         (gdb_xml_parser::parse): Use std::move.
 369         * python/python-internal.h (gdbpy_convert_exception): Take a const
 370         reference.
 371         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 372         std::move.
 373         * python/py-utils.c (gdbpy_convert_exception): Take a const
 374         reference.
 375         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 376         Use std::move.
 377         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 378         Use std::move.
 379         * mi/mi-main.c (mi_print_exception): Take a const reference.
 380         * main.c (handle_command_errors): Take a const reference.
 381         * linespec.c (parse_linespec): Use std::move.
 382         * infcall.c (run_inferior_call): Use std::move.
 383         (call_function_by_hand_dummy): Use std::move.
 384         * exec.c (try_open_exec_file): Use std::move.
 385         * exceptions.h (exception_print, exception_fprintf)
 386         (exception_print_same): Update.
 387         * exceptions.c (print_exception, exception_print)
 388         (exception_fprintf, exception_print_same): Change parameters to
 389         const reference.
 390         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 391         * common/new-op.c: Use std::move.
 392         * common/common-exceptions.h (struct gdb_exception): Add move
 393         constructor.
 394         (struct gdb_exception_error, struct gdb_exception_quit, struct
 395         gdb_quit_bad_alloc): Change constructor to move constructor.
 396         (throw_exception): Change parameter to rvalue reference.
 397         * common/common-exceptions.c (throw_exception): Take rvalue
 398         reference.
 399         * cli/cli-interp.c (safe_execute_command): Use std::move.
 400         * breakpoint.c (insert_bp_location, location_to_sals): Use
 401         std::move.
 402
 403 2019-04-25  Tom Tromey  <tromey@adacore.com>
 404
 405         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 406         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 407         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 408         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 409         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 410         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 411         guile/scm-value.c: Use unpack.
 412         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 413         gdbscm_gdb_exception.
 414         (gdbscm_throw_gdb_exception): Likewise.
 415         (struct gdbscm_gdb_exception): New.
 416         (unpack): New function.
 417         (gdbscm_wrap): Use unpack.
 418
 419 2019-04-25  Tom Tromey  <tromey@adacore.com>
 420
 421         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 422         (gdb_rl_callback_handler): Use std::move.
 423         * common/common-exceptions.h (struct gdb_exception): Add move
 424         assignment operator.
 425         (throw_exception_sjlj): Change "exception" to const reference.
 426         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 427         (throw_exception_sjlj): Change "exception" to const reference.
 428
 429 2019-04-25  Tom Tromey  <tromey@adacore.com>
 430
 431         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 432         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 433         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 434         Update.
 435         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 436         Update.
 437         * mi/mi-interp.c (mi_interp::exec): Update.
 438         * linespec.c (parse_linespec): Update.
 439         * infcall.c (run_inferior_call): Update.
 440         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 441         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 442         (gdbscm_lookup_global_symbol): Update.
 443         * guile/scm-param.c (gdbscm_parameter_value): Update.
 444         * guile/scm-frame.c (gdbscm_frame_read_register)
 445         (gdbscm_frame_read_var): Update.
 446         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 447         * exec.c (try_open_exec_file): Update.
 448         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 449         (gdb_rl_callback_handler): Update.
 450         * common/common-exceptions.h (exception_none): Don't declare.
 451         * common/common-exceptions.c (exception_none): Don't define.
 452         (struct catcher) <exception>: Update.
 453         * cli/cli-interp.c (safe_execute_command): Update.
 454         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 455
 456 2019-04-25  Ali Tamur  <tamur@google.com>
 457
 458         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 459         (read_attribute_value): Likewise.
 460         (dwarf2_read_addr_index): Update comment.
 461         (read_str_index): Add DW_FORM_strx.
 462         (dwarf2_string_attr): Likewise.
 463         (dwarf2_const_value_attr): Likewise.
 464         (dump_die_shallow): Likewise.
 465         (dwarf2_fetch_constant_bytes): Likewise.
 466         (skip_form_bytes): Likewise.
 467         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 468
 469 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 470
 471         PR corefiles/11608
 472         PR corefiles/18187
 473         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 474         OFFSET.  Verify if current mapping contains an ELF header.
 475         (linux_find_memory_regions_full): Adjust call to
 476         dump_mapping_p.
 477
 478 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 479             Kang Li <kanglictf@gmail.com>
 480
 481         PR gdb/21600
 482
 483         * dwarf2-frame.c (read_initial_length): Be consistent about using
 484         unsigned representation of length.
 485         (decode_frame_entry_1): Likewise.  Check for wraparound of
 486         end pointer as well as buffer overflow.
 487
 488 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 489
 490         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 491         "vq".
 492
 493 2019-04-24  Tom Tromey  <tromey@adacore.com>
 494
 495         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 496
 497 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 498
 499         * s12z-tdep.c (s12z_unwind_pc): Delete.
 500         (s12z_unwind_sp): Delete.
 501         (s12z_gdbarch_init): Don't register deleted functions with
 502         gdbarch.
 503
 504 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 505
 506         * rl78-tdep.c (rl78_unwind_sp): Delete.
 507         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 508
 509 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 510
 511         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 512         (xstormy16_unwind_pc): Delete.
 513         (xstormy16_dummy_id): Delete.
 514         (xstormy16_gdbarch_init): Don't register deleted functions with
 515         gdbarch.
 516
 517 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 518
 519         * vax-tdep.c (vax_unwind_pc): Delete.
 520         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 521
 522 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 523
 524         * v850-tdep.c (v850_unwind_sp): Delete.
 525         (v850_unwind_pc): Delete.
 526         (v850_dummy_id): Delete.
 527         (v850_gdbarch_init): Don't register deleted functions with
 528         gdbarch.
 529
 530 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 531
 532         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 533         (tilegx_unwind_pc): Delete.
 534         (tilegx_unwind_dummy_id): Delete.
 535         (tilegx_gdbarch_init): Don't register deleted functions with
 536         gdbarch.
 537
 538 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 539
 540         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 541         (tic6x_dummy_id): Delete.
 542         (tic6x_gdbarch_init): Don't register deleted functions with
 543         gdbarch.
 544
 545 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 546
 547         * sparc-tdep.c (sparc_unwind_pc): Delete.
 548         (sparc32_gdbarch_init): Don't register deleted function with
 549         gdbarch.
 550
 551 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 552
 553         * sh-tdep.c (sh_unwind_sp): Delete.
 554         (sh_unwind_pc): Delete.
 555         (sh_dummy_id): Delete.
 556         (sh_gdbarch_init): Don't register deleted functions with
 557         gdbarch.
 558
 559 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 560
 561         * score-tdep.c (score_unwind_sp): Delete.
 562         (score_unwind_pc): Delete.
 563         (score_dummy_id): Delete.
 564         (score_gdbarch_init): Don't register deleted functions with
 565         gdbarch.
 566
 567 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 568
 569         * rx-tdep.c (rx_unwind_pc): Delete.
 570         (rx_unwind_sp): Delete.
 571         (rx_dummy_id): Delete.
 572         (rx_gdbarch_init): Don't register deleted functions with
 573         gdbarch.  Update comment.
 574
 575 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 576
 577         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 578         (rs6000_dummy_id): Delete.
 579         (rs6000_gdbarch_init): Don't register deleted functions with
 580         gdbarch.
 581
 582 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 583
 584         * or1k-tdep.c (or1k_dummy_id): Delete.
 585         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 586
 587 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 588
 589         * nios2-tdep.c (nios2_dummy_id): Delete.
 590         (nios2_unwind_sp): Delete.
 591         (nios2_gdbarch_init): Don't register deleted functions with
 592         gdbarch.
 593
 594 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 595
 596         * nds32-tdep.c (nds32_dummy_id): Delete.
 597         (nds32_unwind_pc): Delete.
 598         (nds32_unwind_sp): Delete.
 599         (nds32_gdbarch_init): Don't register deleted functions with
 600         gdbarch.
 601
 602 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 603
 604         * msp430-tdep.c (msp430_unwind_pc): Delete.
 605         (msp430_unwind_sp): Delete.
 606         (msp430_dummy_id): Delete.
 607         (msp430_gdbarch_init): Don't register deleted functions with
 608         gdbarch.
 609
 610 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 611
 612         * moxie-tdep.c (moxie_unwind_sp): Delete.
 613         (moxie_unwind_pc): Delete.
 614         (moxie_dummy_id): Delete.
 615         (moxie_gdbarch_init): Don't register deleted functions with
 616         gdbarch.
 617
 618 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 619
 620         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 621         (mn10300_unwind_pc): Delete.
 622         (mn10300_unwind_sp): Delete.
 623         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 624         mn10300_unwind_sp.
 625         (mn10300_frame_unwind_init): Don't register deleted functions with
 626         gdbarch.
 627
 628 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 629
 630         * mep-tdep.c (mep_unwind_pc): Delete.
 631         (mep_unwind_sp): Delete.
 632         (mep_dummy_id): Delete.
 633         (mep_gdbarch_init): Don't register deleted functions with
 634         gdbarch.
 635
 636 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 637
 638         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 639         (m68hc11_unwind_sp): Delete.
 640         (m68hc11_gdbarch_init): Don't register deleted functions with
 641         gdbarch.
 642
 643 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 644
 645         * m32r-tdep.c (m32r_unwind_sp): Delete.
 646         (m32r_unwind_pc): Delete.
 647         (m32r_dummy_id): Delete.
 648         (m32r_gdbarch_init): Don't register deleted functions with
 649         gdbarch.
 650
 651 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 652
 653         * m32c-tdep.c (m32c_unwind_pc): Delete.
 654         (m32c_unwind_sp): Delete.
 655         (m32c_dummy_id): Delete.
 656         (m32c_gdbarch_init): Don't register deleted functions with
 657         gdbarch.
 658
 659 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 660
 661         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 662         (lm32_unwind_pc): Delete.
 663         (lm32_dummy_id): Delete.
 664         (lm32_gdbarch_init): Don't register deleted functions with
 665         gdbarch.
 666
 667 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 668
 669         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 670         (iq2000_unwind_pc): Delete.
 671         (iq2000_dummy_id): Delete.
 672         (iq2000_gdbarch_init): Don't register deleted functions with
 673         gdbarch.
 674
 675 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 676
 677         * nds32-tdep.c (nds32_type_align): Delete.
 678         (nds32_push_dummy_call): Use type_align instead.
 679
 680 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 681
 682         * arm-tdep.c (arm_type_align): Only handle vector override case.
 683         (arm_push_dummy_call): Use type_align.
 684         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 685
 686 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 687
 688         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 689         case.
 690         (pass_on_stack): Use type_align.
 691         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 692         function.
 693
 694 2019-04-23  Tom Tromey  <tromey@adacore.com>
 695
 696         * dwarf2read.c (line_header::file_name_at): Remove unused
 697         overload.
 698
 699 2019-04-23  Tom de Vries  <tdevries@suse.de>
 700
 701         PR gdb/24438
 702         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 703         invocation.
 704
 705
 706 2019-03-27  Ali Tamur  <tamur@google.com>
 707
 708         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 709         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 710         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 711         (dwarf_expr_context::get_addr_index): Likewise
 712         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 713         (symbol_needs_eval_context::get_addr_index): Likewise
 714         (disassemble_dwarf_expression): Add DW_OP_addrx
 715         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 716         (read_cutu_die_from_dwo): Update comment
 717         (skip_one_die): Add DW_FORM_addrx
 718         (read_attribute_value): Likewise
 719         (var_decode_location): Add DW_OP_addrx
 720         (dwarf2_const_value_attr): Add DW_FORM_addrx
 721         (dump_die_shallow): Likewise
 722         (dwarf2_fetch_constant_bytes): Likewise
 723         (decode_locdesc): Add DW_OP_addrx
 724         (skip_form_bytes): Add DW_FORM_addrx
 725
 726 2019-04-22  Ali Tamur  <tamur@google.com>
 727
 728         * MAINTAINERS (Write After Approval): Add self.
 729
 730 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 731
 732         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 733         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 734         (open_symbol_file_object): Likewise.
 735         (svr4_default_sos): Add info parameter.
 736         (svr4_read_so_list): Likewise.
 737         (svr4_current_sos_direct): Adjust functions calls to pass down
 738         info.
 739         (svr4_current_sos_1): Add info parameter.
 740         (svr4_current_sos): Call get_svr4_info, pass info down to
 741         svr4_current_sos_1.
 742         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 743         get_svr4_info.
 744         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 745         get_svr4_info.
 746         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 747         to get_svr4_info.
 748         (probes_table_remove_objfile_probes): Likewise.
 749         (register_solib_event_probe): Add info parameter.
 750         (solist_update_incremental): Pass info parameter down to
 751         svr4_read_so_list.
 752         (disable_probes_interface): Add info parameter.
 753         (svr4_handle_solib_event): Pass current_program_space to
 754         get_svr4_info.  Adjust disable_probes_interface cleanup.
 755         (svr4_create_probe_breakpoints): Add info parameter, pass it
 756         down to register_solib_event_probe.
 757         (svr4_create_solib_event_breakpoints): Add info parameter,
 758         pass it down to svr4_create_probe_breakpoints.
 759         (enable_break): Pass info down to
 760         svr4_create_solib_event_breakpoints.
 761         (svr4_solib_create_inferior_hook): Pass current_program_space to
 762         get_svr4_info.
 763         (svr4_clear_solib): Likewise.
 764
 765 2019-04-22  Pedro Alves  <palves@redhat.com>
 766
 767         * solib-svr4.c (svr4_free_objfile_observer): New.
 768         (probe_and_action::objfile): New field.
 769         (probes_table_htab_remove_objfile_probes)
 770         (probes_table_remove_objfile_probes): New functions.
 771         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 772         in the new probe_and_action.  Don't store the probe in 'lookup'.
 773         (svr4_create_probe_breakpoints): Pass objfile to
 774         register_solib_event_probe.
 775         (_initialize_svr4_solib): Register a free_objfile observer.
 776
 777 2019-04-19  Tom Tromey  <tom@tromey.com>
 778
 779         * common/queue.h: Remove.
 780
 781 2019-04-19  Tom Tromey  <tom@tromey.com>
 782
 783         * event-loop.c: Don't include "common/queue.h".
 784
 785 2019-04-19  Tom Tromey  <tom@tromey.com>
 786
 787         * remote.c (remote_target): Use delete.
 788         * remote-notif.h: Include <list>, not "common/queue.h".
 789         (notif_client_p): Remove typedef.
 790         (remote_notif_state): Add constructor, destructor, initializer.
 791         <notif_queue>: Now a std::list.
 792         (remote_notif_state_xfree): Don't declare.
 793         * remote-notif.c (remote_notif_process, handle_notification)
 794         (remote_notif_state_allocate): Update.
 795         (~remote_notif_state): Rename from remote_notif_state_xfree.
 796
 797 2019-04-19  Tom Tromey  <tom@tromey.com>
 798
 799         * symfile.c (reread_symbols): Update.
 800         * objfiles.c (objfile_register_static_link)
 801         (objfile_lookup_static_link): Update
 802         (~objfile) Don't delete static_links.
 803         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 804
 805 2019-04-19  Tom Tromey  <tom@tromey.com>
 806
 807         * type-stack.h (struct type_stack) <insert>: Constify string.
 808         * type-stack.c (type_stack::insert): Constify string.
 809         * gdbtypes.h (lookup_template_type): Update.
 810         (address_space_name_to_int): Update.
 811         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 812         const.
 813         (lookup_template_type): Make name const.
 814         * c-exp.y: Update rules.
 815         (lex_one_token, classify_name, classify_inner_name)
 816         (c_print_token): Update.
 817         * p-exp.y: Update rules.
 818         (yylex): Update.
 819         * f-exp.y: Update rules.
 820         (yylex): Update.
 821         * d-exp.y: Update rules.
 822         (lex_one_token, classify_name, classify_inner_name): Update.
 823         * parse.c (write_dollar_variable, copy_name): Return std::string.
 824         * parser-defs.h (copy_name): Change return type.
 825         * m2-exp.y: Update rules.
 826         (yylex): Update.
 827         * go-exp.y (lex_one_token): Update.
 828         Update rules.
 829         (classify_unsafe_function, classify_packaged_name)
 830         (classify_name, yylex): Update.
 831
 832 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 833
 834         * configure.ac: add --enable-source-highlight switch.
 835         * configure: Regenerate.
 836         * top.c (print_gdb_version): plumb --enable-source-highlight
 837         status to "show configuration".
 838
 839 2019-04-19  Tom Tromey  <tromey@adacore.com>
 840
 841         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 842         Check ADA_TYPE_P.
 843         (empty_record, ada_template_to_fixed_record_type_1)
 844         (template_to_static_fixed_type)
 845         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 846         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 847         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 848         macros.
 849
 850 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 851
 852         PR symtab/24423:
 853         * source.c (print_source_lines_base): Advance "iter" when a
 854         control character is seen.
 855
 856 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 857
 858         * inferior.h (struct infcall_suspend_state_deleter):
 859         Catch exception in destructor to avoid crash.
 860
 861 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 862
 863         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 864         close to the add_com "shell".
 865
 866 2019-04-18  Tom Tromey  <tromey@adacore.com>
 867
 868         * process-stratum-target.h (class process_stratum_target)
 869         <stratum>: Add "final".
 870
 871 2019-04-17  Tom Tromey  <tromey@adacore.com>
 872
 873         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 874         against nullptr before use.
 875
 876 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 877
 878         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 879
 880 2019-04-17  Jim Wilson  <jimw@sifive.com>
 881             Andrew Burgess  <andrew.burgess@embecosm.com>
 882
 883         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 884         code read might fail, assume 4-byte breakpoint in that case.
 885
 886 2019-04-15  Leszek Swirski  <leszeks@google.com>
 887
 888         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 889         rather than a hand-rolled POD check when checking for forced MEMORY
 890         classification.
 891
 892 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 893
 894         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 895         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 896         function.
 897         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 898         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 899         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 900         declaration.
 901
 902 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 903
 904         * aarch64-linux-nat.c
 905         (aarch64_linux_nat_target::thread_architecture): Add override.
 906         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 907         each VQ.
 908
 909 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 910
 911         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 912
 913 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 914
 915         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 916         target types of size 96-bits, add some additional comments, and
 917         check that the builtin type we found was the correct size.
 918
 919 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 920
 921         * utils.c (prompt_for_continue): Don't restore the styling at the
 922         end, as applied_style has the wrong value.  This fixes styling in
 923         long lists of file names that are interrupted by the "Continue?"
 924         prompt.
 925
 926 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 927
 928         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 929         * c-lang.c (c_language_defn): Likewise.
 930         (cplus_language_defn): Likewise.
 931         (asm_language_defn): Likewise.
 932         (minimal_language_defn): Likewise.
 933         * d-lang.c (d_language_defn): Likewise.
 934         * f-lang.c (f_language_defn): Likewise.
 935         * go-lang.c (go_language_defn): Likewise.
 936         * language.c (unknown_language_defn): Likewise.
 937         (auto_language_defn): Likewise.
 938         * language.h (struct language_defn): Remove la_magic field.
 939         (LANG_MAGIC): Delete.
 940         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 941         * objc-lang.c (objc_language_defn): Likewise.
 942         * opencl-lang.c (opencl_language_defn): Likewise.
 943         * p-lang.c (pascal_language_defn): Likewise.
 944         * rust-lang.c (rust_language_defn): Likewise.
 945
 946 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 947
 948         * riscv-tdep.c (riscv_type_align): New function.
 949         (riscv_type_alignment): Delete.
 950         (riscv_arg_location): Use 'type_align'.
 951         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 952
 953 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 954
 955         * gdbtypes.c (type_align): A struct with no non-static fields also
 956         has alignment of 1.
 957
 958 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 959
 960         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 961         component to 0.
 962         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 963         member.
 964         (riscv_struct_info::analyse): New implementation using new
 965         analyse_inner member function.
 966         (riscv_struct_info::field_offset): New member function.
 967         (riscv_struct_info::m_offsets): New member variable.
 968         (riscv_struct_info::analyse_inner): New private member function,
 969         takes the old implementation of riscv_struct_info::analyse but
 970         extended to track field offsets.
 971         (riscv_call_arg_struct): Update the struct folding special cases
 972         to handle cases where empty C++ structs, which are non-zero
 973         length, are found.
 974         (riscv_arg_location): Initialise the length of each location, a
 975         non-zero length now indicates the location is in use.
 976         (riscv_push_dummy_call): Allow for the first location having a
 977         non-zero offset when setting up arguments.
 978         (riscv_return_value): Likewise, but for return values.
 979
 980 2019-04-11  Tom Tromey  <tromey@adacore.com>
 981
 982         * utils.c (internal_vproblem): Make "msg" const.
 983
 984 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 985
 986         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
 987         * trad-frame.c (trad_frame_reset_saved_regs): New function.
 988         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
 989         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
 990
 991 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
 992
 993         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
 994         function.
 995         (fill_gregset): Call amd64_linux_collect_native_gregset instead
 996         of amd64_collect_native_gregset.
 997         (amd64_linux_nat_target::store_registers): Likewise.
 998
 999 2019-04-10  Tom Tromey  <tom@tromey.com>
1000
1001         * symtab.c (lookup_global_symbol_from_objfile)
1002         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1003         * objfiles.h (class separate_debug_iterator): New.
1004         (class separate_debug_range): New.
1005         (struct objfile) <separate_debug_objfiles>: New method.
1006         (objfile_separate_debug_iterate): Don't declare.
1007         * objfiles.c (separate_debug_iterator::operator++): Rename from
1008         objfile_separate_debug_iterate.
1009         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1010         iterator.
1011         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1012         iterator.
1013
1014 2019-04-10  Tom Tromey  <tom@tromey.com>
1015
1016         * symfile.c (reread_symbols): Remove old comment.
1017         * objfiles.c (free_all_objfiles): Fix a typo.
1018
1019 2019-04-10  Tom Tromey  <tom@tromey.com>
1020
1021         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1022         * minsyms.c (lookup_minimal_symbol): Use foreach.
1023         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1024         (lookup_minimal_symbol_solib_trampoline): Likewise.
1025         * symfile.c (reread_symbols): Use foreach.
1026
1027 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1028             Tom Tromey  <tromey@adacore.com>
1029
1030         PR rust/24414:
1031         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1032         (rust_lex_int_test): Change "value" to be LONGEST.
1033         (rust_lex_tests): Add test for long integer literal.
1034
1035 2019-04-09  Tom Tromey  <tromey@adacore.com>
1036
1037         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1038         to bool.
1039         (extended_remote_target::attach): Update.
1040         (remote_target::remote_notice_new_inferior): Update.
1041         (remote_target::add_current_inferior_and_thread): Update.
1042         * inferior.c (exit_inferior_1): Use "false".
1043         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1044
1045 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1046
1047         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1048         the "start" command.
1049
1050 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1051
1052         * python/py-inferior.c (infpy_thread_from_thread_handle):
1053         Adjust comments to reflect renaming of thread_from_thread_handle
1054         to thread_from_handle.  Adjust keywords.  Fix type error message.
1055         (inferior_object_methods): Add thread_from_handle.  Retain
1056         thread_from_thread_handle, but mark it as deprecated.
1057
1058 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1059
1060         * gdbthread.h (find_thread_by_handle): Revise declaration.
1061         * thread.c (find_thread_by_handle): Likewise.  Adjust
1062         implementation too.
1063         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1064         support for buffer objects as handles.
1065
1066 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1067
1068         * python/py-infthread.c (thpy_thread_handle): New function.
1069         (thread_object_methods): Register thpy_thread_handle.
1070
1071 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1072
1073         * gdbthread.h (thread_to_thread_handle): Declare.
1074         * thread.c (gdbtypes.h): Include.
1075         (thread_to_thread_handle): New function.
1076
1077         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1078         (target_thread_info_to_thread_handle): Declare.
1079         * target.c (target_thread_info_to_thread_handle): New function.
1080         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1081         * target-delegates.c: Regenerate.
1082
1083         * linux-thread-db.c (class thread_db_target): Add method
1084         thread_info_to_thread_handle.
1085         (thread_db_target::thread_info_to_thread_handle): Define.
1086         * remote.c (class remote_target): Add new method
1087         thread_info_to_thread_handle.
1088         (remote_target::thread_info_to_thread_handle): Define.
1089
1090 2019-04-08  Pedro Alves  <palves@redhat.com>
1091
1092         * common/common-exceptions.c (throw_exception): Don't create
1093         named object to throw; throw directly.
1094         (throw_it): Likewise.  Don't initialize gdb_exception::message
1095         here, with new; pass FMT and AP to the ctor instead.
1096         * common/common-exceptions.h: Include <string>.
1097         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1098         const char *, va_list)): New ctor.  Use std::make_shared.
1099         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1100         errors)): Delete.
1101         (gdb_exception_error::gdb_exception_error(enum errors, const char
1102         *, va_list)): New.
1103         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1104         Add assertion.
1105         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1106         errors)): Delete.
1107         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1108         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1109         Add assertion.
1110
1111 2019-04-08  Tom Tromey  <tom@tromey.com>
1112
1113         * valops.c (value_rtti_indirect_type): Replace throw_exception
1114         with throw.
1115         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1116         with throw.
1117         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1118         throw.
1119         * target.c (target_translate_tls_address): Replace throw_exception
1120         with throw.
1121         * stack.c (frame_apply_command_count): Replace throw_exception
1122         with throw.
1123         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1124         throw.
1125         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1126         with throw.
1127         * rs6000-tdep.c (rs6000_frame_cache)
1128         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1129         * remote.c: Replace throw_exception with throw.
1130         * record-full.c (record_full_message, record_full_wait_1)
1131         (record_full_restore): Replace throw_exception with throw.
1132         * record-btrace.c:
1133         (get_thread_current_frame_id, record_btrace_start_replaying)
1134         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1135         (cmd_record_btrace_start): Replace throw_exception with throw.
1136         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1137         throw.
1138         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1139         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1140         * linespec.c:
1141         (find_linespec_symbols): Replace throw_exception with throw.
1142         * infrun.c (displaced_step_prepare, resume): Replace
1143         throw_exception with throw.
1144         * infcmd.c (post_create_inferior): Replace throw_exception with
1145         throw.
1146         * inf-loop.c (inferior_event_handler): Replace throw_exception
1147         with throw.
1148         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1149         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1150         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1151         (get_prev_frame_always, get_frame_pc_if_available)
1152         (get_frame_address_in_block_if_available, get_frame_language):
1153         Replace throw_exception with throw.
1154         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1155         throw_exception with throw.
1156         * eval.c (fetch_subexp_value, evaluate_var_value)
1157         (evaluate_funcall, evaluate_subexp_standard): Replace
1158         throw_exception with throw.
1159         * dwarf2loc.c (call_site_find_chain)
1160         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1161         Replace throw_exception with throw.
1162         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1163         with throw.
1164         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1165         throw.
1166         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1167         * completer.c (complete_line_internal): Replace throw_exception
1168         with throw.
1169         * compile/compile-object-run.c (compile_object_run): Replace
1170         throw_exception with throw.
1171         * cli/cli-script.c (process_next_line): Replace throw_exception
1172         with throw.
1173         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1174         (btrace_enable, btrace_maint_update_pt_packets): Replace
1175         throw_exception with throw.
1176         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1177         throw_exception with throw.
1178         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1179         throw_exception with throw.
1180         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1181         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1182         * aarch64-tdep.c (aarch64_make_prologue_cache)
1183         (aarch64_make_stub_cache): Replace throw_exception with throw.
1184
1185 2019-04-08  Tom Tromey  <tom@tromey.com>
1186
1187         * common/common-exceptions.c (throw_exception): Rename from
1188         throw_exception_cxx.  Remove old copy.  Make argument const.
1189         (throw_it): Create and throw exception objects directly.
1190         * common/common-exceptions.h (throw_exception): Make argument
1191         const.
1192         (struct gdb_exception_error): Add constructor.
1193         (struct gdb_exception_quit): Add constructor.
1194
1195 2019-04-08  Tom Tromey  <tom@tromey.com>
1196
1197         * common/common-exceptions.h (exception_rethrow): Don't declare.
1198         (TRY_SJLJ): Update comment.
1199         (TRY, CATCH, END_CATCH): Remove.
1200         * common/common-exceptions.c (exception_rethrow): Remove.
1201
1202 2019-04-08  Tom Tromey  <tom@tromey.com>
1203
1204         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1205         Remove.
1206         (gdb_exception_error): Rename from
1207         gdb_exception_RETURN_MASK_ERROR.
1208         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1209         (gdb_quit_bad_alloc): Update.
1210         * aarch64-tdep.c: Update.
1211         * ada-lang.c: Update.
1212         * ada-typeprint.c: Update.
1213         * ada-valprint.c: Update.
1214         * amd64-tdep.c: Update.
1215         * arch-utils.c: Update.
1216         * break-catch-throw.c: Update.
1217         * breakpoint.c: Update.
1218         * btrace.c: Update.
1219         * c-varobj.c: Update.
1220         * cli/cli-cmds.c: Update.
1221         * cli/cli-interp.c: Update.
1222         * cli/cli-script.c: Update.
1223         * common/common-exceptions.c: Update.
1224         * common/new-op.c: Update.
1225         * common/selftest.c: Update.
1226         * compile/compile-c-symbols.c: Update.
1227         * compile/compile-cplus-symbols.c: Update.
1228         * compile/compile-object-load.c: Update.
1229         * compile/compile-object-run.c: Update.
1230         * completer.c: Update.
1231         * corelow.c: Update.
1232         * cp-abi.c: Update.
1233         * cp-support.c: Update.
1234         * cp-valprint.c: Update.
1235         * darwin-nat.c: Update.
1236         * disasm-selftests.c: Update.
1237         * dtrace-probe.c: Update.
1238         * dwarf-index-cache.c: Update.
1239         * dwarf-index-write.c: Update.
1240         * dwarf2-frame-tailcall.c: Update.
1241         * dwarf2-frame.c: Update.
1242         * dwarf2loc.c: Update.
1243         * dwarf2read.c: Update.
1244         * eval.c: Update.
1245         * event-loop.c: Update.
1246         * event-top.c: Update.
1247         * exec.c: Update.
1248         * f-valprint.c: Update.
1249         * fbsd-tdep.c: Update.
1250         * frame-unwind.c: Update.
1251         * frame.c: Update.
1252         * gdbtypes.c: Update.
1253         * gnu-v3-abi.c: Update.
1254         * guile/guile-internal.h: Update.
1255         * guile/scm-block.c: Update.
1256         * guile/scm-breakpoint.c: Update.
1257         * guile/scm-cmd.c: Update.
1258         * guile/scm-disasm.c: Update.
1259         * guile/scm-frame.c: Update.
1260         * guile/scm-lazy-string.c: Update.
1261         * guile/scm-math.c: Update.
1262         * guile/scm-param.c: Update.
1263         * guile/scm-ports.c: Update.
1264         * guile/scm-pretty-print.c: Update.
1265         * guile/scm-symbol.c: Update.
1266         * guile/scm-symtab.c: Update.
1267         * guile/scm-type.c: Update.
1268         * guile/scm-value.c: Update.
1269         * i386-linux-tdep.c: Update.
1270         * i386-tdep.c: Update.
1271         * inf-loop.c: Update.
1272         * infcall.c: Update.
1273         * infcmd.c: Update.
1274         * infrun.c: Update.
1275         * jit.c: Update.
1276         * language.c: Update.
1277         * linespec.c: Update.
1278         * linux-fork.c: Update.
1279         * linux-nat.c: Update.
1280         * linux-tdep.c: Update.
1281         * linux-thread-db.c: Update.
1282         * main.c: Update.
1283         * mi/mi-cmd-break.c: Update.
1284         * mi/mi-cmd-stack.c: Update.
1285         * mi/mi-interp.c: Update.
1286         * mi/mi-main.c: Update.
1287         * objc-lang.c: Update.
1288         * p-valprint.c: Update.
1289         * parse.c: Update.
1290         * ppc-linux-tdep.c: Update.
1291         * printcmd.c: Update.
1292         * python/py-arch.c: Update.
1293         * python/py-breakpoint.c: Update.
1294         * python/py-cmd.c: Update.
1295         * python/py-finishbreakpoint.c: Update.
1296         * python/py-frame.c: Update.
1297         * python/py-framefilter.c: Update.
1298         * python/py-gdb-readline.c: Update.
1299         * python/py-inferior.c: Update.
1300         * python/py-infthread.c: Update.
1301         * python/py-lazy-string.c: Update.
1302         * python/py-linetable.c: Update.
1303         * python/py-objfile.c: Update.
1304         * python/py-param.c: Update.
1305         * python/py-prettyprint.c: Update.
1306         * python/py-progspace.c: Update.
1307         * python/py-record-btrace.c: Update.
1308         * python/py-record.c: Update.
1309         * python/py-symbol.c: Update.
1310         * python/py-type.c: Update.
1311         * python/py-unwind.c: Update.
1312         * python/py-utils.c: Update.
1313         * python/py-value.c: Update.
1314         * python/python.c: Update.
1315         * record-btrace.c: Update.
1316         * record-full.c: Update.
1317         * remote-fileio.c: Update.
1318         * remote.c: Update.
1319         * riscv-tdep.c: Update.
1320         * rs6000-aix-tdep.c: Update.
1321         * rs6000-tdep.c: Update.
1322         * rust-exp.y: Update.
1323         * rust-lang.c: Update.
1324         * s390-tdep.c: Update.
1325         * selftest-arch.c: Update.
1326         * solib-dsbt.c: Update.
1327         * solib-frv.c: Update.
1328         * solib-spu.c: Update.
1329         * solib-svr4.c: Update.
1330         * solib.c: Update.
1331         * sparc64-linux-tdep.c: Update.
1332         * stack.c: Update.
1333         * symfile-mem.c: Update.
1334         * symmisc.c: Update.
1335         * target.c: Update.
1336         * thread.c: Update.
1337         * top.c: Update.
1338         * tracefile-tfile.c: Update.
1339         * tui/tui.c: Update.
1340         * typeprint.c: Update.
1341         * unittests/cli-utils-selftests.c: Update.
1342         * unittests/parse-connection-spec-selftests.c: Update.
1343         * valops.c: Update.
1344         * valprint.c: Update.
1345         * value.c: Update.
1346         * varobj.c: Update.
1347         * windows-nat.c: Update.
1348         * x86-linux-nat.c: Update.
1349         * xml-support.c: Update.
1350
1351 2019-04-08  Tom Tromey  <tom@tromey.com>
1352
1353         * xml-support.c: Use C++ exception handling.
1354         * x86-linux-nat.c: Use C++ exception handling.
1355         * windows-nat.c: Use C++ exception handling.
1356         * varobj.c: Use C++ exception handling.
1357         * value.c: Use C++ exception handling.
1358         * valprint.c: Use C++ exception handling.
1359         * valops.c: Use C++ exception handling.
1360         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1361         handling.
1362         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1363         * typeprint.c: Use C++ exception handling.
1364         * tui/tui.c: Use C++ exception handling.
1365         * tracefile-tfile.c: Use C++ exception handling.
1366         * top.c: Use C++ exception handling.
1367         * thread.c: Use C++ exception handling.
1368         * target.c: Use C++ exception handling.
1369         * symmisc.c: Use C++ exception handling.
1370         * symfile-mem.c: Use C++ exception handling.
1371         * stack.c: Use C++ exception handling.
1372         * sparc64-linux-tdep.c: Use C++ exception handling.
1373         * solib.c: Use C++ exception handling.
1374         * solib-svr4.c: Use C++ exception handling.
1375         * solib-spu.c: Use C++ exception handling.
1376         * solib-frv.c: Use C++ exception handling.
1377         * solib-dsbt.c: Use C++ exception handling.
1378         * selftest-arch.c: Use C++ exception handling.
1379         * s390-tdep.c: Use C++ exception handling.
1380         * rust-lang.c: Use C++ exception handling.
1381         * rust-exp.y: Use C++ exception handling.
1382         * rs6000-tdep.c: Use C++ exception handling.
1383         * rs6000-aix-tdep.c: Use C++ exception handling.
1384         * riscv-tdep.c: Use C++ exception handling.
1385         * remote.c: Use C++ exception handling.
1386         * remote-fileio.c: Use C++ exception handling.
1387         * record-full.c: Use C++ exception handling.
1388         * record-btrace.c: Use C++ exception handling.
1389         * python/python.c: Use C++ exception handling.
1390         * python/py-value.c: Use C++ exception handling.
1391         * python/py-utils.c: Use C++ exception handling.
1392         * python/py-unwind.c: Use C++ exception handling.
1393         * python/py-type.c: Use C++ exception handling.
1394         * python/py-symbol.c: Use C++ exception handling.
1395         * python/py-record.c: Use C++ exception handling.
1396         * python/py-record-btrace.c: Use C++ exception handling.
1397         * python/py-progspace.c: Use C++ exception handling.
1398         * python/py-prettyprint.c: Use C++ exception handling.
1399         * python/py-param.c: Use C++ exception handling.
1400         * python/py-objfile.c: Use C++ exception handling.
1401         * python/py-linetable.c: Use C++ exception handling.
1402         * python/py-lazy-string.c: Use C++ exception handling.
1403         * python/py-infthread.c: Use C++ exception handling.
1404         * python/py-inferior.c: Use C++ exception handling.
1405         * python/py-gdb-readline.c: Use C++ exception handling.
1406         * python/py-framefilter.c: Use C++ exception handling.
1407         * python/py-frame.c: Use C++ exception handling.
1408         * python/py-finishbreakpoint.c: Use C++ exception handling.
1409         * python/py-cmd.c: Use C++ exception handling.
1410         * python/py-breakpoint.c: Use C++ exception handling.
1411         * python/py-arch.c: Use C++ exception handling.
1412         * printcmd.c: Use C++ exception handling.
1413         * ppc-linux-tdep.c: Use C++ exception handling.
1414         * parse.c: Use C++ exception handling.
1415         * p-valprint.c: Use C++ exception handling.
1416         * objc-lang.c: Use C++ exception handling.
1417         * mi/mi-main.c: Use C++ exception handling.
1418         * mi/mi-interp.c: Use C++ exception handling.
1419         * mi/mi-cmd-stack.c: Use C++ exception handling.
1420         * mi/mi-cmd-break.c: Use C++ exception handling.
1421         * main.c: Use C++ exception handling.
1422         * linux-thread-db.c: Use C++ exception handling.
1423         * linux-tdep.c: Use C++ exception handling.
1424         * linux-nat.c: Use C++ exception handling.
1425         * linux-fork.c: Use C++ exception handling.
1426         * linespec.c: Use C++ exception handling.
1427         * language.c: Use C++ exception handling.
1428         * jit.c: Use C++ exception handling.
1429         * infrun.c: Use C++ exception handling.
1430         * infcmd.c: Use C++ exception handling.
1431         * infcall.c: Use C++ exception handling.
1432         * inf-loop.c: Use C++ exception handling.
1433         * i386-tdep.c: Use C++ exception handling.
1434         * i386-linux-tdep.c: Use C++ exception handling.
1435         * guile/scm-value.c: Use C++ exception handling.
1436         * guile/scm-type.c: Use C++ exception handling.
1437         * guile/scm-symtab.c: Use C++ exception handling.
1438         * guile/scm-symbol.c: Use C++ exception handling.
1439         * guile/scm-pretty-print.c: Use C++ exception handling.
1440         * guile/scm-ports.c: Use C++ exception handling.
1441         * guile/scm-param.c: Use C++ exception handling.
1442         * guile/scm-math.c: Use C++ exception handling.
1443         * guile/scm-lazy-string.c: Use C++ exception handling.
1444         * guile/scm-frame.c: Use C++ exception handling.
1445         * guile/scm-disasm.c: Use C++ exception handling.
1446         * guile/scm-cmd.c: Use C++ exception handling.
1447         * guile/scm-breakpoint.c: Use C++ exception handling.
1448         * guile/scm-block.c: Use C++ exception handling.
1449         * guile/guile-internal.h: Use C++ exception handling.
1450         * gnu-v3-abi.c: Use C++ exception handling.
1451         * gdbtypes.c: Use C++ exception handling.
1452         * frame.c: Use C++ exception handling.
1453         * frame-unwind.c: Use C++ exception handling.
1454         * fbsd-tdep.c: Use C++ exception handling.
1455         * f-valprint.c: Use C++ exception handling.
1456         * exec.c: Use C++ exception handling.
1457         * event-top.c: Use C++ exception handling.
1458         * event-loop.c: Use C++ exception handling.
1459         * eval.c: Use C++ exception handling.
1460         * dwarf2read.c: Use C++ exception handling.
1461         * dwarf2loc.c: Use C++ exception handling.
1462         * dwarf2-frame.c: Use C++ exception handling.
1463         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1464         * dwarf-index-write.c: Use C++ exception handling.
1465         * dwarf-index-cache.c: Use C++ exception handling.
1466         * dtrace-probe.c: Use C++ exception handling.
1467         * disasm-selftests.c: Use C++ exception handling.
1468         * darwin-nat.c: Use C++ exception handling.
1469         * cp-valprint.c: Use C++ exception handling.
1470         * cp-support.c: Use C++ exception handling.
1471         * cp-abi.c: Use C++ exception handling.
1472         * corelow.c: Use C++ exception handling.
1473         * completer.c: Use C++ exception handling.
1474         * compile/compile-object-run.c: Use C++ exception handling.
1475         * compile/compile-object-load.c: Use C++ exception handling.
1476         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1477         * compile/compile-c-symbols.c: Use C++ exception handling.
1478         * common/selftest.c: Use C++ exception handling.
1479         * common/new-op.c: Use C++ exception handling.
1480         * cli/cli-script.c: Use C++ exception handling.
1481         * cli/cli-interp.c: Use C++ exception handling.
1482         * cli/cli-cmds.c: Use C++ exception handling.
1483         * c-varobj.c: Use C++ exception handling.
1484         * btrace.c: Use C++ exception handling.
1485         * breakpoint.c: Use C++ exception handling.
1486         * break-catch-throw.c: Use C++ exception handling.
1487         * arch-utils.c: Use C++ exception handling.
1488         * amd64-tdep.c: Use C++ exception handling.
1489         * ada-valprint.c: Use C++ exception handling.
1490         * ada-typeprint.c: Use C++ exception handling.
1491         * ada-lang.c: Use C++ exception handling.
1492         * aarch64-tdep.c: Use C++ exception handling.
1493
1494 2019-04-08  Tom Tromey  <tom@tromey.com>
1495
1496         * xml-support.c (gdb_xml_parser::parse): Update.
1497         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1498         * value.c (show_convenience): Update.
1499         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1500         (test_parse_flags_qcs): Update.
1501         * thread.c (thr_try_catch_cmd): Update.
1502         * target.c (target_translate_tls_address): Update.
1503         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1504         (info_frame_command_core, frame_apply_command_count): Update.
1505         * rust-exp.y (rust_lex_exception_test): Update.
1506         * riscv-tdep.c (riscv_print_one_register_info): Update.
1507         * remote.c (remote_target::enable_btrace): Update.
1508         * record-btrace.c (record_btrace_enable_warn): Update.
1509         * python/py-utils.c (gdbpy_convert_exception): Update.
1510         * printcmd.c (do_one_display, print_variable_and_value): Update.
1511         * mi/mi-main.c (mi_print_exception): Update.
1512         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1513         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1514         * linux-nat.c (linux_nat_target::attach): Update.
1515         * linux-fork.c (class scoped_switch_fork_info): Update.
1516         * infrun.c (displaced_step_prepare): Update.
1517         * infcall.c (call_function_by_hand_dummy): Update.
1518         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1519         * gnu-v3-abi.c (print_one_vtable): Update.
1520         * frame.c (get_prev_frame_always): Update.
1521         * f-valprint.c (info_common_command_for_block): Update.
1522         * exec.c (try_open_exec_file): Update.
1523         * exceptions.c (print_exception, exception_print)
1524         (exception_fprintf, exception_print_same): Update.
1525         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1526         * dwarf-index-cache.c (index_cache::store)
1527         (index_cache::lookup_gdb_index): Update.
1528         * darwin-nat.c (maybe_cache_shell): Update.
1529         * cp-valprint.c (cp_print_value_fields): Update.
1530         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1531         (gcc_cplus_symbol_address): Update.
1532         * compile/compile-c-symbols.c (gcc_convert_symbol)
1533         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1534         * common/selftest.c: Update.
1535         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1536         a std::string.
1537         (exception_try_scope_entry, exception_try_scope_exit): Don't
1538         declare.
1539         (struct exception_try_scope): Remove.
1540         (TRY): Don't use exception_try_scope.
1541         (struct gdb_exception): Add constructor, operator=.
1542         <what>: New method.
1543         (struct gdb_exception_RETURN_MASK_ALL)
1544         (struct gdb_exception_RETURN_MASK_ERROR)
1545         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1546         (struct gdb_quit_bad_alloc): Update.
1547         * common/common-exceptions.c (exception_none): Change
1548         initializer.
1549         (struct catcher) <state, exception>: Initialize inline.
1550         <prev>: Remove member.
1551         (current_catcher): Remove.
1552         (catchers): New global.
1553         (exceptions_state_mc_init): Simplify.
1554         (catcher_pop): Remove.
1555         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1556         (try_scope_depth, exception_try_scope_entry)
1557         (exception_try_scope_exit): Remove.
1558         (throw_exception_sjlj): Update.
1559         (exception_messages, exception_messages_size): Remove.
1560         (throw_it): Simplify.
1561         (gdb_exception_sliced_copy): Remove.
1562         (throw_exception_cxx): Update.
1563         * cli/cli-script.c (script_from_file): Update.
1564         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1565         Update.
1566         * ada-valprint.c (ada_val_print): Update.
1567         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1568         (create_excep_cond_exprs): Update.
1569
1570 2019-04-08  Tom Tromey  <tom@tromey.com>
1571
1572         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1573         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1574         (TRY, CATCH, END_CATCH): Remove some definitions.
1575         * common/common-exceptions.c: Don't use GDB_XCPT.
1576         (catcher_list_size): Remove.
1577         (throw_exception, throw_it): Simplify.
1578
1579 2019-04-05  Tom Tromey  <tom@tromey.com>
1580
1581         Revert the header-sorting patch.
1582         * ft32-tdep.c: Revert.
1583         * frv-tdep.c: Revert.
1584         * frv-linux-tdep.c: Revert.
1585         * frame.c: Revert.
1586         * frame-unwind.c: Revert.
1587         * frame-base.c: Revert.
1588         * fork-child.c: Revert.
1589         * findvar.c: Revert.
1590         * findcmd.c: Revert.
1591         * filesystem.c: Revert.
1592         * filename-seen-cache.h: Revert.
1593         * filename-seen-cache.c: Revert.
1594         * fbsd-tdep.c: Revert.
1595         * fbsd-nat.h: Revert.
1596         * fbsd-nat.c: Revert.
1597         * f-valprint.c: Revert.
1598         * f-typeprint.c: Revert.
1599         * f-lang.c: Revert.
1600         * extension.h: Revert.
1601         * extension.c: Revert.
1602         * extension-priv.h: Revert.
1603         * expprint.c: Revert.
1604         * exec.h: Revert.
1605         * exec.c: Revert.
1606         * exceptions.c: Revert.
1607         * event-top.c: Revert.
1608         * event-loop.c: Revert.
1609         * eval.c: Revert.
1610         * elfread.c: Revert.
1611         * dwarf2read.h: Revert.
1612         * dwarf2read.c: Revert.
1613         * dwarf2loc.c: Revert.
1614         * dwarf2expr.h: Revert.
1615         * dwarf2expr.c: Revert.
1616         * dwarf2-frame.c: Revert.
1617         * dwarf2-frame-tailcall.c: Revert.
1618         * dwarf-index-write.h: Revert.
1619         * dwarf-index-write.c: Revert.
1620         * dwarf-index-common.c: Revert.
1621         * dwarf-index-cache.h: Revert.
1622         * dwarf-index-cache.c: Revert.
1623         * dummy-frame.c: Revert.
1624         * dtrace-probe.c: Revert.
1625         * disasm.h: Revert.
1626         * disasm.c: Revert.
1627         * disasm-selftests.c: Revert.
1628         * dictionary.c: Revert.
1629         * dicos-tdep.c: Revert.
1630         * demangle.c: Revert.
1631         * dcache.h: Revert.
1632         * dcache.c: Revert.
1633         * darwin-nat.h: Revert.
1634         * darwin-nat.c: Revert.
1635         * darwin-nat-info.c: Revert.
1636         * d-valprint.c: Revert.
1637         * d-namespace.c: Revert.
1638         * d-lang.c: Revert.
1639         * ctf.c: Revert.
1640         * csky-tdep.c: Revert.
1641         * csky-linux-tdep.c: Revert.
1642         * cris-tdep.c: Revert.
1643         * cris-linux-tdep.c: Revert.
1644         * cp-valprint.c: Revert.
1645         * cp-support.c: Revert.
1646         * cp-namespace.c: Revert.
1647         * cp-abi.c: Revert.
1648         * corelow.c: Revert.
1649         * corefile.c: Revert.
1650         * continuations.c: Revert.
1651         * completer.h: Revert.
1652         * completer.c: Revert.
1653         * complaints.c: Revert.
1654         * coffread.c: Revert.
1655         * coff-pe-read.c: Revert.
1656         * cli-out.h: Revert.
1657         * cli-out.c: Revert.
1658         * charset.c: Revert.
1659         * c-varobj.c: Revert.
1660         * c-valprint.c: Revert.
1661         * c-typeprint.c: Revert.
1662         * c-lang.c: Revert.
1663         * buildsym.c: Revert.
1664         * buildsym-legacy.c: Revert.
1665         * build-id.h: Revert.
1666         * build-id.c: Revert.
1667         * btrace.c: Revert.
1668         * bsd-uthread.c: Revert.
1669         * breakpoint.h: Revert.
1670         * breakpoint.c: Revert.
1671         * break-catch-throw.c: Revert.
1672         * break-catch-syscall.c: Revert.
1673         * break-catch-sig.c: Revert.
1674         * blockframe.c: Revert.
1675         * block.c: Revert.
1676         * bfin-tdep.c: Revert.
1677         * bfin-linux-tdep.c: Revert.
1678         * bfd-target.c: Revert.
1679         * bcache.c: Revert.
1680         * ax-general.c: Revert.
1681         * ax-gdb.h: Revert.
1682         * ax-gdb.c: Revert.
1683         * avr-tdep.c: Revert.
1684         * auxv.c: Revert.
1685         * auto-load.c: Revert.
1686         * arm-wince-tdep.c: Revert.
1687         * arm-tdep.c: Revert.
1688         * arm-symbian-tdep.c: Revert.
1689         * arm-pikeos-tdep.c: Revert.
1690         * arm-obsd-tdep.c: Revert.
1691         * arm-nbsd-tdep.c: Revert.
1692         * arm-nbsd-nat.c: Revert.
1693         * arm-linux-tdep.c: Revert.
1694         * arm-linux-nat.c: Revert.
1695         * arm-fbsd-tdep.c: Revert.
1696         * arm-fbsd-nat.c: Revert.
1697         * arm-bsd-tdep.c: Revert.
1698         * arch-utils.c: Revert.
1699         * arc-tdep.c: Revert.
1700         * arc-newlib-tdep.c: Revert.
1701         * annotate.h: Revert.
1702         * annotate.c: Revert.
1703         * amd64-windows-tdep.c: Revert.
1704         * amd64-windows-nat.c: Revert.
1705         * amd64-tdep.c: Revert.
1706         * amd64-sol2-tdep.c: Revert.
1707         * amd64-obsd-tdep.c: Revert.
1708         * amd64-obsd-nat.c: Revert.
1709         * amd64-nbsd-tdep.c: Revert.
1710         * amd64-nbsd-nat.c: Revert.
1711         * amd64-nat.c: Revert.
1712         * amd64-linux-tdep.c: Revert.
1713         * amd64-linux-nat.c: Revert.
1714         * amd64-fbsd-tdep.c: Revert.
1715         * amd64-fbsd-nat.c: Revert.
1716         * amd64-dicos-tdep.c: Revert.
1717         * amd64-darwin-tdep.c: Revert.
1718         * amd64-bsd-nat.c: Revert.
1719         * alpha-tdep.c: Revert.
1720         * alpha-obsd-tdep.c: Revert.
1721         * alpha-nbsd-tdep.c: Revert.
1722         * alpha-mdebug-tdep.c: Revert.
1723         * alpha-linux-tdep.c: Revert.
1724         * alpha-linux-nat.c: Revert.
1725         * alpha-bsd-tdep.c: Revert.
1726         * alpha-bsd-nat.c: Revert.
1727         * aix-thread.c: Revert.
1728         * agent.c: Revert.
1729         * addrmap.c: Revert.
1730         * ada-varobj.c: Revert.
1731         * ada-valprint.c: Revert.
1732         * ada-typeprint.c: Revert.
1733         * ada-tasks.c: Revert.
1734         * ada-lang.c: Revert.
1735         * aarch64-tdep.c: Revert.
1736         * aarch64-ravenscar-thread.c: Revert.
1737         * aarch64-newlib-tdep.c: Revert.
1738         * aarch64-linux-tdep.c: Revert.
1739         * aarch64-linux-nat.c: Revert.
1740         * aarch64-fbsd-tdep.c: Revert.
1741         * aarch64-fbsd-nat.c: Revert.
1742         * aarch32-linux-nat.c: Revert.
1743
1744 2019-04-05  Tom Tromey  <tom@tromey.com>
1745
1746         * ft32-tdep.c: Sort headers.
1747         * frv-tdep.c: Sort headers.
1748         * frv-linux-tdep.c: Sort headers.
1749         * frame.c: Sort headers.
1750         * frame-unwind.c: Sort headers.
1751         * frame-base.c: Sort headers.
1752         * fork-child.c: Sort headers.
1753         * findvar.c: Sort headers.
1754         * findcmd.c: Sort headers.
1755         * filesystem.c: Sort headers.
1756         * filename-seen-cache.h: Sort headers.
1757         * filename-seen-cache.c: Sort headers.
1758         * fbsd-tdep.c: Sort headers.
1759         * fbsd-nat.h: Sort headers.
1760         * fbsd-nat.c: Sort headers.
1761         * f-valprint.c: Sort headers.
1762         * f-typeprint.c: Sort headers.
1763         * f-lang.c: Sort headers.
1764         * extension.h: Sort headers.
1765         * extension.c: Sort headers.
1766         * extension-priv.h: Sort headers.
1767         * expprint.c: Sort headers.
1768         * exec.h: Sort headers.
1769         * exec.c: Sort headers.
1770         * exceptions.c: Sort headers.
1771         * event-top.c: Sort headers.
1772         * event-loop.c: Sort headers.
1773         * eval.c: Sort headers.
1774         * elfread.c: Sort headers.
1775         * dwarf2read.h: Sort headers.
1776         * dwarf2read.c: Sort headers.
1777         * dwarf2loc.c: Sort headers.
1778         * dwarf2expr.h: Sort headers.
1779         * dwarf2expr.c: Sort headers.
1780         * dwarf2-frame.c: Sort headers.
1781         * dwarf2-frame-tailcall.c: Sort headers.
1782         * dwarf-index-write.h: Sort headers.
1783         * dwarf-index-write.c: Sort headers.
1784         * dwarf-index-common.c: Sort headers.
1785         * dwarf-index-cache.h: Sort headers.
1786         * dwarf-index-cache.c: Sort headers.
1787         * dummy-frame.c: Sort headers.
1788         * dtrace-probe.c: Sort headers.
1789         * disasm.h: Sort headers.
1790         * disasm.c: Sort headers.
1791         * disasm-selftests.c: Sort headers.
1792         * dictionary.c: Sort headers.
1793         * dicos-tdep.c: Sort headers.
1794         * demangle.c: Sort headers.
1795         * dcache.h: Sort headers.
1796         * dcache.c: Sort headers.
1797         * darwin-nat.h: Sort headers.
1798         * darwin-nat.c: Sort headers.
1799         * darwin-nat-info.c: Sort headers.
1800         * d-valprint.c: Sort headers.
1801         * d-namespace.c: Sort headers.
1802         * d-lang.c: Sort headers.
1803         * ctf.c: Sort headers.
1804         * csky-tdep.c: Sort headers.
1805         * csky-linux-tdep.c: Sort headers.
1806         * cris-tdep.c: Sort headers.
1807         * cris-linux-tdep.c: Sort headers.
1808         * cp-valprint.c: Sort headers.
1809         * cp-support.c: Sort headers.
1810         * cp-namespace.c: Sort headers.
1811         * cp-abi.c: Sort headers.
1812         * corelow.c: Sort headers.
1813         * corefile.c: Sort headers.
1814         * continuations.c: Sort headers.
1815         * completer.h: Sort headers.
1816         * completer.c: Sort headers.
1817         * complaints.c: Sort headers.
1818         * coffread.c: Sort headers.
1819         * coff-pe-read.c: Sort headers.
1820         * cli-out.h: Sort headers.
1821         * cli-out.c: Sort headers.
1822         * charset.c: Sort headers.
1823         * c-varobj.c: Sort headers.
1824         * c-valprint.c: Sort headers.
1825         * c-typeprint.c: Sort headers.
1826         * c-lang.c: Sort headers.
1827         * buildsym.c: Sort headers.
1828         * buildsym-legacy.c: Sort headers.
1829         * build-id.h: Sort headers.
1830         * build-id.c: Sort headers.
1831         * btrace.c: Sort headers.
1832         * bsd-uthread.c: Sort headers.
1833         * breakpoint.h: Sort headers.
1834         * breakpoint.c: Sort headers.
1835         * break-catch-throw.c: Sort headers.
1836         * break-catch-syscall.c: Sort headers.
1837         * break-catch-sig.c: Sort headers.
1838         * blockframe.c: Sort headers.
1839         * block.c: Sort headers.
1840         * bfin-tdep.c: Sort headers.
1841         * bfin-linux-tdep.c: Sort headers.
1842         * bfd-target.c: Sort headers.
1843         * bcache.c: Sort headers.
1844         * ax-general.c: Sort headers.
1845         * ax-gdb.h: Sort headers.
1846         * ax-gdb.c: Sort headers.
1847         * avr-tdep.c: Sort headers.
1848         * auxv.c: Sort headers.
1849         * auto-load.c: Sort headers.
1850         * arm-wince-tdep.c: Sort headers.
1851         * arm-tdep.c: Sort headers.
1852         * arm-symbian-tdep.c: Sort headers.
1853         * arm-pikeos-tdep.c: Sort headers.
1854         * arm-obsd-tdep.c: Sort headers.
1855         * arm-nbsd-tdep.c: Sort headers.
1856         * arm-nbsd-nat.c: Sort headers.
1857         * arm-linux-tdep.c: Sort headers.
1858         * arm-linux-nat.c: Sort headers.
1859         * arm-fbsd-tdep.c: Sort headers.
1860         * arm-fbsd-nat.c: Sort headers.
1861         * arm-bsd-tdep.c: Sort headers.
1862         * arch-utils.c: Sort headers.
1863         * arc-tdep.c: Sort headers.
1864         * arc-newlib-tdep.c: Sort headers.
1865         * annotate.h: Sort headers.
1866         * annotate.c: Sort headers.
1867         * amd64-windows-tdep.c: Sort headers.
1868         * amd64-windows-nat.c: Sort headers.
1869         * amd64-tdep.c: Sort headers.
1870         * amd64-sol2-tdep.c: Sort headers.
1871         * amd64-obsd-tdep.c: Sort headers.
1872         * amd64-obsd-nat.c: Sort headers.
1873         * amd64-nbsd-tdep.c: Sort headers.
1874         * amd64-nbsd-nat.c: Sort headers.
1875         * amd64-nat.c: Sort headers.
1876         * amd64-linux-tdep.c: Sort headers.
1877         * amd64-linux-nat.c: Sort headers.
1878         * amd64-fbsd-tdep.c: Sort headers.
1879         * amd64-fbsd-nat.c: Sort headers.
1880         * amd64-dicos-tdep.c: Sort headers.
1881         * amd64-darwin-tdep.c: Sort headers.
1882         * amd64-bsd-nat.c: Sort headers.
1883         * alpha-tdep.c: Sort headers.
1884         * alpha-obsd-tdep.c: Sort headers.
1885         * alpha-nbsd-tdep.c: Sort headers.
1886         * alpha-mdebug-tdep.c: Sort headers.
1887         * alpha-linux-tdep.c: Sort headers.
1888         * alpha-linux-nat.c: Sort headers.
1889         * alpha-bsd-tdep.c: Sort headers.
1890         * alpha-bsd-nat.c: Sort headers.
1891         * aix-thread.c: Sort headers.
1892         * agent.c: Sort headers.
1893         * addrmap.c: Sort headers.
1894         * ada-varobj.c: Sort headers.
1895         * ada-valprint.c: Sort headers.
1896         * ada-typeprint.c: Sort headers.
1897         * ada-tasks.c: Sort headers.
1898         * ada-lang.c: Sort headers.
1899         * aarch64-tdep.c: Sort headers.
1900         * aarch64-ravenscar-thread.c: Sort headers.
1901         * aarch64-newlib-tdep.c: Sort headers.
1902         * aarch64-linux-tdep.c: Sort headers.
1903         * aarch64-linux-nat.c: Sort headers.
1904         * aarch64-fbsd-tdep.c: Sort headers.
1905         * aarch64-fbsd-nat.c: Sort headers.
1906         * aarch32-linux-nat.c: Sort headers.
1907
1908 2019-04-04  Tom Tromey  <tom@tromey.com>
1909
1910         * varobj.c (varobj_create): Update.
1911         * rust-exp.y (struct rust_parser) <update_innermost_block,
1912         lookup_symbol>: New methods.
1913         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1914         Rename.
1915         (rust_parser::rust_lookup_type)
1916         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1917         * printcmd.c (display_command, do_one_display): Update.
1918         * parser-defs.h (struct parser_state) <parser_state>: Add
1919         "tracker" parameter.
1920         (block_tracker): New member.
1921         (class innermost_block_tracker) <innermost_block_tracker>: Add
1922         "types" parameter.
1923         <reset>: Remove method.
1924         (innermost_block): Don't declare.
1925         (null_post_parser): Update.
1926         * parse.c (innermost_block): Remove global.
1927         (write_dollar_variable): Update.
1928         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1929         Remove "tracker_types" parameter.
1930         (parse_expression): Add "tracker" parameter.
1931         (parse_expression_for_completion): Update.
1932         (null_post_parser): Add "tracker" parameter.
1933         * p-exp.y: Update rules.
1934         * m2-exp.y: Update rules.
1935         * language.h (struct language_defn) <la_post_parser>: Add
1936         "tracker" parameter.
1937         * go-exp.y: Update rules.
1938         * f-exp.y: Update rules.
1939         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1940         parameter.
1941         * d-exp.y: Update rules.
1942         * c-exp.y: Update rules.
1943         * breakpoint.c (set_breakpoint_condition): Create an
1944         innermost_block_tracker.
1945         (watch_command_1): Likewise.
1946         * ada-lang.c (resolve): Add "tracker" parameter.
1947         (resolve_subexp): Likewise.
1948         * ada-exp.y (write_var_from_sym): Update.
1949
1950 2019-04-04  Tom Tromey  <tom@tromey.com>
1951
1952         * type-stack.h: New file.
1953         * type-stack.c: New file.
1954         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1955         type-stack.h.
1956         (insert_into_type_stack, insert_type, push_type, push_type_int)
1957         (insert_type_address_space, pop_type, pop_type_int)
1958         (pop_typelist, pop_type_stack, append_type_stack)
1959         (push_type_stack, get_type_stack, push_typelist)
1960         (follow_type_instance_flags, follow_types): Don't declare.
1961         * parse.c (type_stack): Remove global.
1962         (parse_exp_in_context): Update.
1963         (insert_into_type_stack, insert_type, push_type, push_type_int)
1964         (insert_type_address_space, pop_type, pop_type_int)
1965         (pop_typelist, pop_type_stack, append_type_stack)
1966         (push_type_stack, get_type_stack, push_typelist)
1967         (follow_type_instance_flags, follow_types): Remove (moved to
1968         type-stack.c).
1969         * f-exp.y (type_stack): New global.
1970         Update rules.
1971         (push_kind_type, f_parse): Update.
1972         * d-exp.y (type_stack): New global.
1973         Update rules.
1974         (d_parse): Update.
1975         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1976         Update rules.
1977         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1978         (HFILES_NO_SRCDIR): Add type-stack.h.
1979
1980 2019-04-04  Tom Tromey  <tom@tromey.com>
1981
1982         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1983         (rust_parser::convert_ast_to_expression, rust_parse)
1984         (rust_lex_test_completion, rust_lex_tests): Update.
1985         * parser-defs.h (struct expr_completion_state): New.
1986         (struct parser_state) <parser_state>: Add completion parameter.
1987         <mark_struct_expression, mark_completion_tag>: New methods.
1988         <parse_completion, m_completion_state>: New members.
1989         (prefixify_expression, null_post_parser): Update.
1990         (mark_struct_expression, mark_completion_tag): Don't declare.
1991         * parse.c (parse_completion, expout_last_struct)
1992         (expout_tag_completion_type, expout_completion_name): Remove
1993         globals.
1994         (parser_state::mark_struct_expression)
1995         (parser_state::mark_completion_tag): Now methods.
1996         (prefixify_expression): Add last_struct parameter.
1997         (prefixify_subexp): Likewise.
1998         (parse_exp_1): Update.
1999         (parse_exp_in_context): Add cstate parameter.  Update.
2000         (parse_expression_for_completion): Create an
2001         expr_completion_state.
2002         (null_post_parser): Add "completion" parameter.
2003         * p-exp.y: Update rules.
2004         (yylex): Update.
2005         * language.h (struct language_defn) <la_post_parser>: Add
2006         "completing" parameter.
2007         * go-exp.y: Update rules.
2008         (lex_one_token): Update.
2009         * expression.h (parse_completion): Don't declare.
2010         * d-exp.y: Update rules.
2011         (lex_one_token): Update rules.
2012         * c-exp.y: Update rules.
2013         (lex_one_token): Update.
2014         * ada-lang.c (resolve): Add "parse_completion" parameter.
2015         (resolve_subexp): Likewise.
2016         (ada_resolve_function): Likewise.
2017
2018 2019-04-04  Tom Tromey  <tom@tromey.com>
2019
2020         * parser-defs.h (struct parser_state) <start_arglist,
2021         end_arglist>: New methods.
2022         <arglist_len, m_funcall_chain>: New members.
2023         (arglist_len, start_arglist, end_arglist): Don't declare.
2024         * parse.c (arglist_len, funcall_chain): Remove global.
2025         (start_arglist, end_arglist): Remove functions.
2026         (parse_exp_in_context): Update.
2027         * p-exp.y: Update rules.
2028         * m2-exp.y: Update rules.
2029         * go-exp.y: Update rules.
2030         * f-exp.y: Update rules.
2031         * d-exp.y: Update rules.
2032         * c-exp.y: Update rules.
2033
2034 2019-04-04  Tom Tromey  <tom@tromey.com>
2035
2036         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2037         lex_operator, push_back>: New methods.
2038         Update all rules.
2039         (rust_parser::lex_hex, lex_escape): Rename and update.
2040         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2041         (rust_parser::lex_operator): Rename and update.
2042         (rust_parser::lex_number, rustyylex, rustyyerror)
2043         (rust_lex_test_init, rust_lex_test_sequence)
2044         (rust_lex_test_push_back, rust_lex_tests): Update.
2045         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2046         parameter.
2047         <lexptr, prev_lexptr>: New members.
2048         (lexptr, prev_lexptr): Don't declare.
2049         * parse.c (lexptr, prev_lexptr): Remove globals.
2050         (parse_exp_in_context): Update.
2051         * p-exp.y (yylex, yyerror): Update.
2052         * m2-exp.y (parse_number, yylex, yyerror): Update.
2053         * go-exp.y (lex_one_token, yyerror): Update.
2054         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2055         * d-exp.y (lex_one_token, yyerror): Update.
2056         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2057         (lex_one_token, yyerror): Update.
2058         * ada-lex.l (YY_INPUT): Update.
2059         (rewind_to_char): Update.
2060         * ada-exp.y (yyerror): Update.
2061
2062 2019-04-04  Tom Tromey  <tom@tromey.com>
2063
2064         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2065         * parser-defs.h (struct parser_state) <parser_state>: Add new
2066         parameter.
2067         <comma_terminates>: New member.
2068         (comma_terminates): Don't declare global.
2069         * parse.c (comma_terminates): Remove global.
2070         (parse_exp_in_context): Update.
2071         * p-exp.y (yylex): Update.
2072         * m2-exp.y (yylex): Update.
2073         * go-exp.y (lex_one_token): Update.
2074         * f-exp.y (yylex): Update.
2075         * d-exp.y (lex_one_token): Update.
2076         * c-exp.y (lex_one_token): Update.
2077         * ada-lex.l: Update.
2078
2079 2019-04-04  Tom Tromey  <tom@tromey.com>
2080
2081         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2082         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2083         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2084         * parser-defs.h (paren_depth): Don't declare.
2085         * parse.c (paren_depth): Remove global.
2086         (parse_exp_in_context): Update.
2087         * p-exp.y (paren_depth): New global.
2088         (pascal_parse): Initialize it.
2089         * m2-exp.y (paren_depth): New global.
2090         (m2_parse): Initialize it.
2091         * go-exp.y (paren_depth): New global.
2092         (go_parse): Initialize it.
2093         * f-exp.y (paren_depth): New global.
2094         (f_parse): Initialize it.
2095         * d-exp.y (paren_depth): New global.
2096         (d_parse): Initialize it.
2097         * c-exp.y (paren_depth): New global.
2098         (c_parse): Initialize it.
2099         * ada-lex.l (paren_depth): New global.
2100         (lexer_init): Initialize it.
2101
2102 2019-04-04  Tom Tromey  <tom@tromey.com>
2103
2104         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2105         (rust_parser::convert_ast_to_type)
2106         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2107         * parser-defs.h (struct parser_state) <parser_state>: Add
2108         parameters.  Initialize new members.
2109         <expression_context_block, expression_context_pc>: New members.
2110         * parse.c (expression_context_block, expression_context_pc):
2111         Remove globals.
2112         (parse_exp_in_context): Update.
2113         * p-exp.y: Update all rules.
2114         (yylex): Update.
2115         * m2-exp.y: Update all rules.
2116         (yylex): Update.
2117         * go-exp.y (yylex): Update.
2118         * f-exp.y (yylex): Update.
2119         * d-exp.y: Update all rules.
2120         (yylex): Update.
2121         * c-exp.y: Update all rules.
2122         (lex_one_token, classify_name, yylex, c_parse): Update.
2123         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2124
2125 2019-04-04  Tom Tromey  <tom@tromey.com>
2126
2127         * gdbarch.h, gdbarch.c: Rebuild.
2128         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2129         * stap-probe.h:
2130         (struct stap_parse_info): Replace "parser_state" with
2131         "expr_builder".
2132         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2133         (parser_state): New class.
2134         * parse.c (expr_builder): Rename.
2135         (expr_builder::release): Rename.
2136         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2137         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2138         (write_exp_elt_longcst, write_exp_elt_floatcst)
2139         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2140         (write_exp_string_vector, write_exp_bitstring)
2141         (write_exp_msymbol, mark_struct_expression)
2142         (write_dollar_variable)
2143         (insert_type_address_space, increase_expout_size): Replace
2144         "parser_state" with "expr_builder".
2145         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2146         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2147         "parser_state" with "expr_builder".
2148
2149 2019-04-04  Tom Tromey  <tom@tromey.com>
2150
2151         * rust-exp.y: Replace "parse_language" with method call.
2152         * p-exp.y:
2153         (yylex): Replace "parse_language" with method call.
2154         * m2-exp.y:
2155         (yylex): Replace "parse_language" with method call.
2156         * go-exp.y (classify_name): Replace "parse_language" with method
2157         call.
2158         * f-exp.y (yylex): Replace "parse_language" with method call.
2159         * d-exp.y (lex_one_token): Replace "parse_language" with method
2160         call.
2161         * c-exp.y:
2162         (lex_one_token, classify_name, yylex): Replace "parse_language"
2163         with method call.
2164         * ada-exp.y (find_primitive_type, type_char)
2165         (type_system_address): Replace "parse_language" with method call.
2166
2167 2019-04-04  Tom Tromey  <tom@tromey.com>
2168
2169         * rust-exp.y: Replace "parse_gdbarch" with method call.
2170         * parse.c (write_dollar_variable, insert_type_address_space):
2171         Replace "parse_gdbarch" with method call.
2172         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2173         call.
2174         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2175         call.
2176         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2177         "parse_gdbarch" with method call.
2178         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2179         with method call.
2180         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2181         "parse_gdbarch" with method call.
2182         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2183         "parse_gdbarch" with method call.
2184         * c-exp.y (parse_type, parse_number, classify_name): Replace
2185         "parse_gdbarch" with method call.
2186         * ada-lex.l: Replace "parse_gdbarch" with method call.
2187         * ada-exp.y (parse_type, find_primitive_type, type_char)
2188         (type_system_address): Replace "parse_gdbarch" with method call.
2189
2190 2019-04-04  Tom Tromey  <tom@tromey.com>
2191
2192         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2193         * stap-probe.c (stap_parse_argument): Update.
2194         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2195         initial_size parameter.
2196         * rust-exp.y (rust_lex_tests): Update.
2197         * parse.c (parser_state): Update.
2198         (parse_exp_in_context): Update.
2199         * parser-defs.h (struct parser_state) <parser_state>: Remove
2200         "initial_size" parameter.
2201
2202 2019-04-04  Tom Tromey  <tom@tromey.com>
2203
2204         * parser-defs.h (increase_expout_size): Don't declare.
2205         * parse.c (increase_expout_size): Now static.
2206
2207 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2208
2209         * gnu-nat.c (gnu_nat_target::wait): Fix
2210         target_waitstatus_to_string call.
2211
2212 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2213
2214         * eval.c (evaluate_subexp_standard): Handle internal functions
2215         during Fortran function call handling.
2216
2217 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2218
2219         * NEWS: Mention new internal functions.
2220         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2221         (read_base_type): Use dwarf2_init_complex_target_type.
2222         * value.c (creal_internal_fn): New function.
2223         (cimag_internal_fn): New function.
2224         (_initialize_values): Register new internal functions.
2225
2226 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2227
2228         * infrun.c (stop_all_threads): If debug_infrun, always
2229         trace the wait status after wait_one, using
2230         target_waitstatus_to_string and target_pid_to_str.
2231         (handle_inferior_event): Replace various trace of
2232         wait status kind by a single trace.
2233         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2234         wait status kind image by target_waitstatus_to_string.
2235         * target/waitstatus.c (target_waitstatus_to_string): Fix
2236         obsolete comment.
2237
2238 2019-04-01  Tom Tromey  <tromey@adacore.com>
2239
2240         PR symtab/23331:
2241         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2242
2243 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2244             Pedro Alves  <palves@redhat.com>
2245
2246         * top.c (quit_force): Call 'finalize_values'.
2247         * value.c (finalize_values): New function.
2248         * value.h (finalize_values): Declare.
2249
2250 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2251
2252         * NEWS: Announce $_gdb_major and $_gdb_minor.
2253
2254         * top.c (init_gdb_version_vars): New function.
2255         (gdb_init): Call init_gdb_version_vars.
2256
2257 2019-03-29  Tom Tromey  <tromey@adacore.com>
2258
2259         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2260         help text.  Remove dead code.
2261
2262 2019-03-29  Keith Seitz  <keiths@redhat.com>
2263
2264         From Siddhesh Poyarekar:
2265         * f-lang.h (f77_get_upperbound): Return LONGEST.
2266         (f77_get_lowerbound): Likewise.
2267         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2268         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2269         print them.
2270         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2271         plongest to format print it.
2272         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2273         (f77_get_upperbound): Likewise.
2274         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2275         LOWER_BOUND to LONGEST.
2276         (f77_create_arrayprint_offset_tbl): Likewise.
2277
2278 2019-03-29  Keith Seitz  <keiths@redhat.com>
2279
2280         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2281         %s/pulongest for TYPE_LENGTH instead of %d in format
2282         strings.
2283         * ada-typerint.c (ada_print_type): Likewise.
2284         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2285         * compile/compile-c-support.c (generate_register_struct): Likewise.
2286         * gdbtypes.c (recursive_dump_type): Likewise.
2287         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2288         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2289         instead of %d in format strings.
2290         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2291         to std::min to ULONGEST.
2292         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2293         instead of %d in format strings.
2294         * tracepoint.c (info_scope_command): Likewise.
2295         * typeprint.c (print_offset_data::update)
2296         (print_offset_data::finish): Likewise.
2297         * xtensa-tdep.c (xtensa_store_return_value)
2298         (xtensa_push_dummy_call): Likewise.
2299
2300 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2301
2302         * windows-nat.c (display_selector): Fixed format specifications
2303         for 64-bit Cygwin.
2304
2305 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2306
2307         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2308
2309 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2310
2311         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2312         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2313         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2314         (nios2_linux_init_abi): Install it.
2315
2316 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2317
2318         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2319
2320 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2321
2322         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2323
2324 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2325             Tom Tromey  <tromey@adacore.com>
2326
2327         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2328
2329 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2330
2331         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2332         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2333         method to compute the bounds of range types. Also print "[evaluated]"
2334         if the bounds' values come from a dynamic evaluation.
2335
2336 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2337
2338         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2339         whitespace when pretty printing is on.
2340
2341 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2342
2343         * ppc-linux-nat.c: Add include.
2344
2345 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2346
2347         * NEWS: Mention AArch64 Pointer Authentication.
2348
2349 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2350
2351         * arm-linux-nat.c: Add include.
2352
2353 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2354
2355         * source-cache.c (source_cache::get_source_lines): Re-read
2356         fullname after calling open_source_file.
2357
2358 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2359
2360         * NEWS: Mention TLS support for FreeBSD.
2361
2362 2019-03-25  Tom Tromey  <tromey@adacore.com>
2363
2364         * minsyms.c (BUNCH_SIZE): Update comment.
2365         (~minimal_symbol_reader): Remove old comment.
2366         (compact_minimal_symbols): Update comment.
2367         (minimal_symbol_reader::install): Remove old comment.  Update
2368         other comments.
2369
2370 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2371
2372         * s390-linux-nat.c: Add include.
2373
2374 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2375
2376         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2377         Call linux_get_hwcap.
2378         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2379         Likewise.
2380         (aarch64_linux_get_hwcap): Remove function.
2381         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2382         declaration.
2383         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2384         linux_get_hwcap.
2385         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2386         * linux-tdep.c (linux_get_hwcap): Add function.
2387         (linux_get_hwcap2): Likewise.
2388         * linux-tdep.h (linux_get_hwcap): Add declaration.
2389         (linux_get_hwcap2): Likewise.
2390         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2391         (ppc_linux_get_hwcap2): Likewise.
2392         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2393         linux_get_hwcap.
2394         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2395         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2396         (ppc_linux_nat_target::read_description): Likewise.
2397         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2398         * s390-linux-nat.c: Likewise.
2399         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2400
2401 2019-03-24  Tom Tromey  <tom@tromey.com>
2402
2403         * ada-lang.c (standard_lookup): Simplify initialization.
2404         (ada_lookup_symbol_nonlocal): Simplify return.
2405         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2406         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2407         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2408         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2409         initialization.
2410         * solib.c (solib_global_lookup): Simplify.
2411         * symtab.c (null_block_symbol): Remove.
2412         (symbol_cache_lookup): Simplify returns.
2413         (lookup_language_this): Simplify returns.
2414         (lookup_symbol_aux): Simplify return.
2415         (lookup_local_symbol): Simplify returns.
2416         (lookup_global_symbol_from_objfile): Simplify return.
2417         (lookup_symbol_in_objfile_symtabs)
2418         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2419         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2420         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2421         * cp-namespace.c (cp_lookup_bare_symbol)
2422         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2423         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2424         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2425         (cp_lookup_symbol_via_imports): Simplify initialization.
2426         (find_symbol_in_baseclass): Likewise.
2427         * symtab.h (null_block_symbol): Remove.
2428         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2429         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2430         (d_lookup_symbol_module): Likewise.
2431         (find_symbol_in_baseclass): Simplify initialization.
2432
2433 2019-03-24  Tom Tromey  <tom@tromey.com>
2434
2435         * expression.h: Don't include symtab.h.
2436         (struct block): Forward declare.
2437
2438 2019-03-24  Tom Tromey  <tom@tromey.com>
2439
2440         * c-exp.y (typebase): Remove casts.
2441         * gdbtypes.c (lookup_unsigned_typename, )
2442         (lookup_signed_typename): Remove cast.
2443         * eval.c (parse_to_comma_and_eval): Remove cast.
2444         * parse.c (write_dollar_variable): Remove cast.
2445         * block.h (struct block) <superblock>: Now const.
2446         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2447         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2448         (map_block): Make "block" const.
2449         * symfile.h (struct quick_symbol_functions)
2450         <map_matching_symbols>: Constify block argument to "callback".
2451         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2452         const.
2453         (find_pc_sect_compunit_symtab): Make "b" const.
2454         (find_symbol_at_address): Likewise.
2455         (search_symbols): Likewise.
2456         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2457         (dw2_debug_names_lookup_symbol): Likewise.
2458         (dw2_map_matching_symbols): Update.
2459         * p-valprint.c (pascal_val_print): Remove "block".
2460         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2461         (aux_add_nonlocal_symbols): Make "block" const.
2462         (resolve_subexp): Remove cast.
2463         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2464         const.
2465         (iterate_over_file_blocks): Likewise.
2466         * f-exp.y (%union) <bval>: Remove.
2467         * coffread.c (patch_opaque_types): Make "b" const.
2468         * spu-tdep.c (spu_catch_start): Make "block" const.
2469         * c-valprint.c (print_unpacked_pointer): Remove "block".
2470         * symmisc.c (dump_symtab_1): Make "b" const.
2471         (block_depth): Make "block" const.
2472         * d-exp.y (%union) <bval>: Remove.
2473         * cp-support.h (cp_lookup_rtti_type): Update.
2474         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2475         * psymtab.c (psym_lookup_symbol): Make "block" const.
2476         (maintenance_check_psymtabs): Make "b" const.
2477         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2478         (enumerate_locals, enumerate_args): Update.
2479         * python/py-symtab.c (stpy_global_block): Make "block" const.
2480         (stpy_static_block): Likewise.
2481         * inline-frame.c (block_starting_point_at): Make "new_block"
2482         const.
2483         * block.c (find_block_in_blockvector): Make return type const.
2484         (blockvector_for_pc_sect): Make "b" const.
2485         (find_block_in_blockvector): Make "b" const.
2486
2487 2019-03-23  Tom Tromey  <tom@tromey.com>
2488
2489         * varobj.c (varobj_create): Update.
2490         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2491         * printcmd.c (display_command, do_one_display): Don't reset
2492         innermost_block.
2493         * parser-defs.h (enum innermost_block_tracker_type): Move to
2494         expression.h.
2495         (innermost_block): Update comment.
2496         * parse.c (parse_exp_1): Add tracker_types parameter.
2497         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2498         tracker_types parameter.  Reset innermost_block.
2499         (parse_exp_in_context): Remove.
2500         (parse_expression_for_completion): Update.
2501         * objfiles.c (~objfile): Don't reset expression_context_block or
2502         innermost_block.
2503         * expression.h (enum innermost_block_tracker_type): Move from
2504         parser-defs.h.
2505         (parse_exp_1): Add tracker_types parameter.
2506         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2507         reset innermost_block.
2508
2509 2019-03-23  Tom Tromey  <tom@tromey.com>
2510
2511         * objfiles.h: Include bcache.h.
2512
2513 2019-03-23  Tom Tromey  <tom@tromey.com>
2514
2515         * linespec.c (get_current_search_block): Use
2516         scoped_restore_current_language.
2517         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2518
2519 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2520             Jiong Wang  <jiong.wang@arm.com>
2521
2522         * aarch64-linux-tdep.c
2523         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2524         section.
2525         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2526
2527 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2528             Jiong Wang  <jiong.wang@arm.com>
2529
2530         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2531         instructions.
2532         (aarch64_analyze_prologue_test): Add PACIASP test.
2533         (aarch64_prologue_prev_register): Unmask PC value.
2534
2535 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2536             Jiong Wang  <jiong.wang@arm.com>
2537
2538         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2539         (aarch64_dwarf2_prev_register): Unmask PC value.
2540         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2541         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2542         DW_CFA_AARCH64_negate_ra_state.
2543         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2544
2545 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2546             Jiong Wang  <jiong.wang@arm.com>
2547
2548         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2549         registers.
2550         (aarch64_pseudo_register_name): Likewise.
2551         (aarch64_pseudo_register_type): Likewise.
2552         (aarch64_pseudo_register_reggroup_p): Likewise.
2553         (aarch64_gdbarch_init): Add pauth registers.
2554         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2555         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2556         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2557         (struct gdbarch_tdep): Add regnum for ra_state.
2558
2559 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2560             Jiong Wang  <jiong.wang@arm.com>
2561
2562         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2563
2564 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2565             Jiong Wang  <jiong.wang@arm.com>
2566
2567         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2568         function.
2569         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2570         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2571         (aarch64_gdbarch_init): Add puth registers.
2572         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2573         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2574         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2575
2576 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2577             Jiong Wang  <jiong.wang@arm.com>
2578
2579         * aarch64-linux-nat.c
2580         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2581         * aarch64-linux-tdep.c
2582         (aarch64_linux_core_read_description): Likewise.
2583         (aarch64_linux_get_hwcap): New function.
2584         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2585         (aarch64_linux_get_hwcap): New declaration.
2586
2587 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2588             Jiong Wang  <jiong.wang@arm.com>
2589
2590         * aarch64-linux-nat.c
2591         (aarch64_linux_nat_target::read_description): Add pauth param.
2592         * aarch64-linux-tdep.c
2593         (aarch64_linux_core_read_description): Likewise.
2594         * aarch64-tdep.c (struct target_desc): Add in pauth.
2595         (aarch64_read_description): Add pauth param.
2596         (aarch64_gdbarch_init): Likewise.
2597         * aarch64-tdep.h (aarch64_read_description): Likewise.
2598         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2599         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2600         * features/Makefile: Add new files.
2601         * features/aarch64-pauth.c: New file.
2602         * features/aarch64-pauth.xml: New file.
2603
2604 2019-03-20  Tom Tromey  <tromey@adacore.com>
2605
2606         * infrun.c (handle_inferior_event): Rename from
2607         handle_inferior_event_1.  Create a scoped_value_mark.
2608         (handle_inferior_event): Remove.
2609
2610 2019-03-19  Tom Tromey  <tromey@adacore.com>
2611
2612         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2613         * infrun.h (print_stop_event): Add "displays" parameter.
2614         * infrun.c (print_stop_event): Add "displays" parameter.
2615
2616 2019-03-19  Pedro Alves  <palves@redhat.com>
2617
2618         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2619         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2620         to -1.  Fix TABs vs spaces.
2621         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2622         * tui/tui-out.h (tui_ui_out) Add intro comments.
2623         <m_line, m_start_of_line>: In-class initialize, and add describing
2624         comment.
2625
2626 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2627
2628         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2629         variable names.
2630         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2631
2632 2019-03-18  Pedro Alves  <palves@redhat.com>
2633             Eli Zaretskii <eliz@gnu.org>
2634
2635         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2636         m_line and m_start_of_line.
2637
2638 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2639
2640         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2641         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2642         it returns a newline.  This fixes a regression in TU mode, whereby
2643         the next line is output on the same screen line as the user input.
2644
2645 2019-03-18  Tom Tromey  <tromey@adacore.com>
2646
2647         * minsyms.c (minimal_symbol_reader::install): Remove call to
2648         obstack_blank.
2649
2650 2019-03-18  Pedro Alves  <palves@redhat.com>
2651
2652         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2653         New globals.
2654         (apply_style): New, factored out from ...
2655         (apply_ansi_escape): ... this.  Handle reverse video mode.
2656         (tui_set_reverse_mode): New function.
2657         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2658         * tui/tui-winsource.c (tui_show_source_line): Use
2659         tui_set_reverse_mode instead of setting A_STANDOUT.
2660         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2661         New setter methods.
2662
2663 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2664
2665         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2666         Handle tabs.
2667
2668 2019-03-18  Tom Tromey  <tromey@adacore.com>
2669
2670         * ada-lang.c (empty_array): Add "high" parameter.
2671         (ada_evaluate_subexp): Update.
2672
2673 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2674
2675         * unittests/string_view-selftests.c: Define
2676         _initialize_string_view_selftests unconditionally.
2677
2678 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2679
2680         PR gdb/24350
2681         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2682
2683 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2684
2685         PR gdb/24351
2686         * windows-nat.c (display_selector): Fix format specifiers.
2687
2688 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2689
2690         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2691         tui_refill_source_window instead of tui_refresh_win, to update the
2692         current execution line.  This fixes redisplay of the current line
2693         when stepping through the code with "next" or "step".
2694
2695 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2696
2697         * source-cache.c (source_cache::get_source_lines): Call
2698         find_source_lines to initialize s->nlines.  This fixes vertical
2699         scrolling of TUI source window when the DOWN arrow is pressed.
2700
2701 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2702
2703         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2704         linux-thread-db.c (_initialize_thread_db): Likewise.
2705
2706 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2707
2708         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2709         wclrtoeol in tui_show_source_line".  This reverts changes made in
2710         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2711
2712 2019-03-15  Tom Tromey  <tom@tromey.com>
2713
2714         * symtab.h (struct minimal_symbol): Derive from
2715         general_symbol_info.
2716         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2717         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2718         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2719         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2720         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2721         (MSYMBOL_SEARCH_NAME): Update.
2722         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2723         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2724         * minsyms.c (minimal_symbol_reader::record_full): Update.
2725
2726 2019-03-15  Tom Tromey  <tom@tromey.com>
2727
2728         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2729
2730 2019-03-15  Tom Tromey  <tom@tromey.com>
2731
2732         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2733         unique_xmalloc_ptr.
2734         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2735         Update.
2736         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2737         (build_minimal_symbol_hash_tables)
2738         (minimal_symbol_reader::install): Update.
2739
2740 2019-03-15  Tom Tromey  <tom@tromey.com>
2741
2742         * symtab.c (create_demangled_names_hash): Update.
2743         (symbol_set_names): Update.
2744         * objfiles.h (struct objfile_per_bfd_storage)
2745         <demangled_names_hash>: Now an htab_up.
2746         * objfiles.c (objfile_per_bfd_storage): Simplify.
2747
2748 2019-03-15  Tom Tromey  <tom@tromey.com>
2749
2750         * objfiles.h (struct objfile_per_bfd_storage): Declare
2751         destructor.
2752         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2753         New.
2754         (get_objfile_bfd_data): Use new.  Don't initialize
2755         language_of_main.
2756         (free_objfile_per_bfd_storage): Remove.
2757         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2758
2759 2019-03-15  Tom Tromey  <tom@tromey.com>
2760
2761         * symfile.c (reread_symbols): Update.
2762         * objfiles.c (objfile::objfile): Update.
2763         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2764         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2765         comment.
2766         (minimal_symbol_reader::install): Update.
2767         (terminate_minimal_symbol_table): Remove.
2768         * jit.c (jit_object_close_impl): Update.
2769
2770 2019-03-15  Tom Tromey  <tom@tromey.com>
2771
2772         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2773         initializations.
2774
2775 2019-03-15  Tom Tromey  <tom@tromey.com>
2776
2777         * objfiles.h (struct objfile_per_bfd_storage)
2778         <demangled_hash_languages>: Now a bitset.
2779         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2780         (lookup_minimal_symbol): Update.
2781
2782 2019-03-15  Tom Tromey  <tom@tromey.com>
2783
2784         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2785         Don't return the symbol.
2786         * coffread.c (record_minimal_symbol): Use record_full.
2787
2788 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2789
2790         The MS-Windows port of ncurses fails to switch to a color pair if
2791         one or both of the colors are the implicit default colors.  This
2792         change records the default colors when TUI is initialized, and
2793         then specifies them explicitly when a color pair uses the default
2794         colors.  This allows color styling in TUI mode on MS-Windows.
2795
2796         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2797         ncurses_norm_attr.
2798         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2799         colors in ncurses_norm_attr.
2800         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2801         "none", replace it with the default color recorded in
2802         ncurses_norm_attr.
2803
2804 2019-03-14  Tom Tromey  <tromey@adacore.com>
2805
2806         * source-cache.h (class source_cache) <get_source_lines>: Return
2807         std::string.
2808         * source-cache.c (source_cache::extract_lines): Handle case where
2809         first_pos==npos.  Return std::string.
2810         (source_cache::get_source_lines): Update.
2811
2812 2019-03-14  Tom Tromey  <tromey@adacore.com>
2813
2814         * NEWS: Add item for "style sources" commands.
2815         * source-cache.c (source_cache::get_source_lines): Check
2816         source_styling.
2817         * cli/cli-style.c (source_styling): New global.
2818         (_initialize_cli_style): Add "style sources" commands.
2819         (show_style_sources): New function.
2820         * cli/cli-style.h (source_styling): Declare.
2821
2822 2019-03-14  Pedro Alves  <palves@redhat.com>
2823             Tom Tromey  <tromey@adacore.com>
2824
2825         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2826         * tui/tui-winsource.c (tui_refill_source_window): New function,
2827         from...
2828         (tui_horizontal_source_scroll): ... here.  Move some logic.
2829         * cli/cli-style.c (set_style_enabled): Notify new observable.
2830         * tui/tui-hooks.c (tui_redisplay_source): New function.
2831         (tui_attach_detach_observers): Attach or detach
2832         tui_redisplay_source.
2833         * observable.h (source_styling_changed): New observable.
2834         * observable.c: Define source_styling_changed observable.
2835
2836 2019-03-13  Tom Tromey  <tromey@adacore.com>
2837
2838         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2839         (i386_gnu_nat_target::store_registers): Update.
2840         * target-debug.h (target_debug_print_std_string): New macro.
2841         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2842         * windows-tdep.c (display_one_tib): Update.
2843         * tui/tui-stack.c (tui_make_status_line): Update.
2844         * top.c (print_inferior_quit_action): Update.
2845         * thread.c (thr_try_catch_cmd): Update.
2846         (add_thread_with_info): Update.
2847         (thread_target_id_str): Update.
2848         (thr_try_catch_cmd): Update.
2849         (thread_command): Update.
2850         (thread_find_command): Update.
2851         * record-btrace.c (record_btrace_target::info_record)
2852         (record_btrace_resume_thread, record_btrace_target::resume)
2853         (record_btrace_cancel_resume, record_btrace_step_thread)
2854         (record_btrace_target::wait, record_btrace_target::wait)
2855         (record_btrace_target::wait, record_btrace_target::stop): Update.
2856         * progspace.c (print_program_space): Update.
2857         * process-stratum-target.c
2858         (process_stratum_target::thread_address_space): Update.
2859         * linux-fork.c (linux_fork_mourn_inferior)
2860         (detach_checkpoint_command, info_checkpoints_command)
2861         (linux_fork_context): Update.
2862         (linux_fork_detach): Update.
2863         (class scoped_switch_fork_info): Update.
2864         (delete_checkpoint_command): Update.
2865         * infrun.c (follow_fork_inferior): Update.
2866         (follow_fork_inferior): Update.
2867         (proceed_after_vfork_done): Update.
2868         (handle_vfork_child_exec_or_exit): Update.
2869         (follow_exec): Update.
2870         (displaced_step_prepare_throw): Update.
2871         (displaced_step_restore): Update.
2872         (start_step_over): Update.
2873         (resume_1): Update.
2874         (clear_proceed_status_thread): Update.
2875         (proceed): Update.
2876         (print_target_wait_results): Update.
2877         (do_target_wait): Update.
2878         (context_switch): Update.
2879         (stop_all_threads): Update.
2880         (restart_threads): Update.
2881         (finish_step_over): Update.
2882         (handle_signal_stop): Update.
2883         (switch_back_to_stepped_thread): Update.
2884         (keep_going_pass_signal): Update.
2885         (print_exited_reason): Update.
2886         (normal_stop): Update.
2887         * inferior.c (inferior_pid_to_str): Change return type.
2888         (print_selected_inferior): Update.
2889         (add_inferior): Update.
2890         (detach_inferior): Update.
2891         * dummy-frame.c (fprint_dummy_frames): Update.
2892         * dcache.c (dcache_info_1): Update.
2893         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2894         (btrace_fetch, btrace_clear): Update.
2895         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2896         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2897         type.
2898         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2899         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2900         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2901         * gdbarch.c, gdbarch.h: Rebuild.
2902         * gdbarch.sh (core_pid_to_str): Change return type.
2903         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2904         return type.
2905         (windows_nat_target::pid_to_str): Change return type.
2906         (windows_delete_thread): Update.
2907         (windows_nat_target::attach): Update.
2908         (windows_nat_target::files_info): Update.
2909         * target-delegates.c: Rebuild.
2910         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2911         return type.
2912         (sol_thread_target::pid_to_str): Change return type.
2913         * remote.c (class remote_target) <pid_to_str>: Change return
2914         type.
2915         (remote_target::pid_to_str): Change return type.
2916         (extended_remote_target::attach, remote_target::remote_stop_ns)
2917         (remote_target::remote_notif_remove_queued_reply)
2918         (remote_target::push_stop_reply, remote_target::disable_btrace):
2919         Update.
2920         (extended_remote_target::attach): Update.
2921         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2922         type.
2923         (gdbsim_target::pid_to_str): Change return type.
2924         * ravenscar-thread.c (struct ravenscar_thread_target)
2925         <pid_to_str>: Change return type.
2926         (ravenscar_thread_target::pid_to_str): Change return type.
2927         * procfs.c (class procfs_target) <pid_to_str>: Change return
2928         type.
2929         (procfs_target::pid_to_str): Change return type.
2930         (procfs_target::attach): Update.
2931         (procfs_target::detach): Update.
2932         (procfs_target::fetch_registers): Update.
2933         (procfs_target::store_registers): Update.
2934         (procfs_target::wait): Update.
2935         (procfs_target::files_info): Update.
2936         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2937         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2938         return type.
2939         (nto_procfs_target::pid_to_str): Change return type.
2940         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2941         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2942         return type.
2943         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2944         (exit_lwp): Update.
2945         (attach_proc_task_lwp_callback, get_detach_signal)
2946         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2947         (linux_nat_target::resume, wait_lwp, stop_callback)
2948         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2949         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2950         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2951         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2952         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2953         type.
2954         (inf_ptrace_target::attach): Update.
2955         (inf_ptrace_target::files_info): Update.
2956         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2957         type.
2958         (go32_nat_target::pid_to_str): Change return type.
2959         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2960         (gnu_nat_target::wait): Update.
2961         (gnu_nat_target::wait): Update.
2962         (gnu_nat_target::resume): Update.
2963         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2964         (fbsd_nat_target::wait): Update.
2965         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2966         type.
2967         (darwin_nat_target::attach): Update.
2968         * corelow.c (class core_target) <pid_to_str>: Change return type.
2969         (core_target::pid_to_str): Change return type.
2970         * target.c (normal_pid_to_str): Change return type.
2971         (default_pid_to_str): Likewise.
2972         (target_pid_to_str): Change return type.
2973         (target_translate_tls_address): Update.
2974         (target_announce_detach): Update.
2975         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2976         return type.
2977         (bsd_uthread_target::pid_to_str): Change return type.
2978         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2979         type.
2980         (bsd_kvm_target::pid_to_str): Change return type.
2981         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2982         return type.
2983         (aix_thread_target::pid_to_str): Change return type.
2984         * target.h (struct target_ops) <pid_to_str>: Change return type.
2985         (target_pid_to_str, normal_pid_to_str): Likewise.
2986         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2987         type.
2988         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2989         type.
2990         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2991         return type.
2992         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2993         type.
2994         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2995         type.
2996         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2997         return type.
2998
2999 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3000
3001         * NEWS: Mention that the new default MI version is 3.  Mention
3002         changes to the output of commands and events that deal with
3003         multi-location breakpoints.
3004         * breakpoint.c: Include "mi/mi-out.h".
3005         (print_one_breakpoint): Change output syntax if using MI version
3006         >= 3.
3007         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3008         New.
3009         (mi_multi_location_breakpoint_output_fixed): New.
3010         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3011         (mi_cmd_fix_multi_location_breakpoint_output): New.
3012         (mi_multi_location_breakpoint_output_fixed): New.
3013         * mi/mi-cmds.c (mi_cmds): Register command
3014         -fix-multi-location-breakpoint-output.
3015         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3016         interpreter "mi".
3017
3018 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3019
3020         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3021         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3022         instantiate mi_ui_out based on interpreter name.
3023         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3024         * mi/mi-main.c (mi_load_progress): Likewise.
3025
3026 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3027
3028         * NEWS: Combine separate "New targets" sections for 8.3.
3029
3030 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3031
3032         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3033         (ppcfbsd_init_abi): Install gdbarch
3034         "fetch_tls_load_module_address" and "get_thread_local_address"
3035         methods.
3036
3037 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3038
3039         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3040         (riscv_fbsd_init_abi): Install gdbarch
3041         "fetch_tls_load_module_address" and "get_thread_local_address"
3042         methods.
3043
3044 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3045
3046         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3047         (i386fbsd_init_abi): Install gdbarch
3048         "fetch_tls_load_module_address" and "get_thread_local_address"
3049         methods.
3050
3051 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3052
3053         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3054         (amd64fbsd_init_abi): Install gdbarch
3055         "fetch_tls_load_module_address" and "get_thread_local_address"
3056         methods.
3057
3058 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3059
3060         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3061         (struct fbsd_pspace_data): New type.
3062         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3063         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3064         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3065         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3066         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3067
3068 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3069
3070         * gdbtypes.c (lookup_struct_elt): New function.
3071         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3072         * gdbtypes.h (struct struct_elt): New type.
3073         (lookup_struct_elt): New prototype.
3074
3075 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3076
3077         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3078         remove disabled code block.
3079
3080 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3081
3082         * gdbarch.sh (get_thread_local_address): New method.
3083         * gdbarch.h, gdbarch.c: Regenerate.
3084         * target.c (target_translate_tls_address): Use
3085         gdbarch_get_thread_local_address if present instead of
3086         target::get_thread_local_address.
3087
3088 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3089
3090         * target.h (target::get_thread_local_address): Update comment.
3091
3092 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3093
3094         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3095         objfile->separate_debug_objfile_backlink if not NULL.
3096
3097 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3098
3099         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3100         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3101         (amd64bsd_store_inferior_registers): Likewise.
3102         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3103         Enable segment base registers.
3104         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3105         PT_GETFSBASE and PT_GETGSBASE.
3106         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3107         PT_SETGSBASE.
3108         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3109         segment base registers.
3110         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3111
3112 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3113
3114         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3115         Update calls to i386_target_description to add 'segments'
3116         parameter.
3117         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3118         add segment base registers.
3119         * arch/i386.c (i386_create_target_description): Add 'segments'
3120         parameter to enable segment base registers.
3121         * arch/i386.h (i386_create_target_description): Likewise.
3122         * features/i386/32bit-segments.xml: New file.
3123         * features/i386/32bit-segments.c: Generate.
3124         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3125         call to i386_target_description to add 'segments' parameter.
3126         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3127         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3128         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3129         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3130         if feature is present.
3131         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3132         Add 'segments' parameter to call to i386_target_description.
3133         (i386_target_description): Add 'segments' parameter to enable
3134         segment base registers.
3135         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3136         to call to i386_target_description.
3137         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3138         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3139         Define I386_NUM_REGS.
3140         (i386_target_description): Add 'segments' parameter to enable
3141         segment base registers.
3142
3143 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3144
3145         PR/24325
3146         * source-cache.c: #undef open and close, to avoid unresolved
3147         externals during linking.
3148
3149 2019-03-12  Tom Tromey  <tromey@adacore.com>
3150
3151         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3152         const.  Add initializers.
3153         (_initialize_remote): Don't initialize ptid globals.
3154
3155 2019-03-12  Pedro Alves  <palves@redhat.com>
3156
3157         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3158
3159 2019-03-12  Pedro Alves  <palves@redhat.com>
3160
3161         * cp-name-parser.y (main): Remove unused 'len' variable.
3162
3163 2019-03-12  Tom Tromey  <tromey@adacore.com>
3164
3165         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3166         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3167
3168 2019-03-12  Tom Tromey  <tromey@adacore.com>
3169
3170         * linux-nat.c (iterate_over_lwps): Update.
3171         (stop_callback): Remove parameter.
3172         (stop_wait_callback, detach_callback, resume_set_callback)
3173         (select_singlestep_lwp_callback, set_ignore_sigint)
3174         (status_callback, resumed_callback, resume_clear_callback)
3175         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3176         data parameter.
3177         (linux_nat_target::detach, linux_nat_target::resume)
3178         (linux_stop_and_wait_all_lwps, select_event_lwp)
3179         (linux_nat_filter_event, linux_nat_wait_1)
3180         (linux_nat_target::kill, linux_nat_target::stop)
3181         (linux_nat_target::stop): Update.
3182         (linux_nat_resume_callback): Change type.
3183         (resume_stopped_resumed_lwps, count_events_callback)
3184         (select_event_lwp_callback): Likewise.
3185         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3186         * arm-linux-nat.c (struct update_registers_data): Remove.
3187         (update_registers_callback): Change type.
3188         (arm_linux_insert_hw_breakpoint1): Update.
3189         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3190         parameter.
3191         (x86_linux_dr_set_addr): Update.
3192         (x86_linux_dr_set_control): Update.
3193         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3194         (iterate_over_lwps): Use gdb::function_view.
3195         * nat/aarch64-linux-hw-point.c (struct
3196         aarch64_dr_update_callback_param): Remove.
3197         (debug_reg_change_callback): Change type.
3198         (aarch64_notify_debug_reg_change): Update.
3199         * s390-linux-nat.c (s390_refresh_per_info): Update.
3200
3201 2019-03-11  Tom Tromey  <tromey@adacore.com>
3202
3203         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3204         redundant assignment to "this_cu".
3205
3206 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3207
3208         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3209
3210 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3211
3212         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3213         from...
3214         (rank_one_type): ... this.
3215
3216 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3217
3218         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3219         from...
3220         (rank_one_type): ... this.
3221
3222 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3223
3224         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3225         from...
3226         (rank_one_type): ... this.
3227
3228 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3229
3230         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3231         from...
3232         (rank_one_type): ... this.
3233
3234 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3235
3236         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3237         from...
3238         (rank_one_type): ... this.
3239
3240 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3241
3242         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3243         from...
3244         (rank_one_type): ... this.
3245
3246 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3247
3248         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3249         from...
3250         (rank_one_type): ... this.
3251
3252 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3253
3254         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3255         from...
3256         (rank_one_type): ... this.
3257
3258 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3259
3260         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3261         from...
3262         (rank_one_type): ... this.
3263
3264 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3265
3266         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3267         from...
3268         (rank_one_type): ... this.
3269
3270 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3271
3272         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3273         from...
3274         (rank_one_type): ... this.
3275
3276 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3277
3278         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3279         from...
3280         (rank_one_type): ... this.
3281
3282 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3283
3284         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3285         inferior-events' shows the example events.
3286
3287 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3288
3289         Support styling on native MS-Windows console
3290
3291         PR/24315
3292         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3293         on MS-Windows if $TERM is not defined.
3294
3295         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3296
3297         * posix-hdep.c (gdb_console_fputs):
3298         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3299         functions.
3300         * ui-file.h (gdb_console_fputs): Add prototype.
3301
3302         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3303         back to fputs only if the former returns zero.
3304
3305 2019-03-07  Tom Tromey  <tom@tromey.com>
3306
3307         * symmisc.c (print_symbol_bcache_statistics): Update.
3308         (print_objfile_statistics): Update.
3309         * symfile.c (allocate_symtab): Update.
3310         * stabsread.c: Don't include bcache.h.
3311         * psymtab.h (struct psymbol_bcache): Don't declare.
3312         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3313         (psymbol_bcache_init, psymbol_bcache_free)
3314         (psymbol_bcache_get_bcache): Don't declare.
3315         * psymtab.c (struct psymbol_bcache): Remove.
3316         (psymtab_storage::psymtab_storage): Update.
3317         (psymtab_storage::~psymtab_storage): Update.
3318         (psymbol_bcache_init, psymbol_bcache_free)
3319         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3320         (add_psymbol_to_bcache): Update.
3321         (allocate_psymtab): Update.
3322         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3323         macro_cache>: No longer pointers.
3324         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3325         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3326         * macrotab.c (macro_bcache): Update.
3327         * macroexp.c: Don't include bcache.h.
3328         * gdbtypes.c (check_types_worklist): Update.
3329         (types_deeply_equal): Remove TRY/CATCH.  Update.
3330         * elfread.c (elf_symtab_read): Update.
3331         * dwarf2read.c: Don't include bcache.h.
3332         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3333         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3334         (print_bcache_statistics, bcache_memory_used): Don't declare.
3335         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3336         methods.  Rename all data members.
3337         * bcache.c (struct bcache): Move to bcache.h.
3338         (bcache::expand_hash_table): Rename from expand_hash_table.
3339         (bcache): Remove.
3340         (bcache::insert): Rename from bcache_full.
3341         (bcache::compare): Rename from bcache_compare.
3342         (bcache_xmalloc): Remove.
3343         (bcache::~bcache): Rename from bcache_xfree.
3344         (bcache::print_statistics): Rename from print_bcache_statistics.
3345         (bcache::memory_used): Rename from bcache_memory_used.
3346
3347 2019-03-07  Pedro Alves  <palves@redhat.com>
3348
3349         * infrun.c (normal_stop): Also check for
3350         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3351
3352 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3353
3354         * f-lang.c (value_from_host_double): Moved to...
3355         * value.c (value_from_host_double): ...here.
3356         * value.h (value_from_host_double): Declare.
3357         * guile/scm-math.c (vlscm_convert_typed_number): Use
3358         value_from_host_double.
3359         (vlscm_convert_number): Likewise.
3360         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3361         * python/py-value.c (convert_value_from_python): Likewise.
3362
3363 2019-03-06  Tom Tromey  <tom@tromey.com>
3364
3365         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3366
3367 2019-03-06  Tom Tromey  <tom@tromey.com>
3368
3369         * utils.h (free_current_contents): Don't declare.
3370         * utils.c (free_current_contents): Remove.
3371
3372 2019-03-06  Tom Tromey  <tom@tromey.com>
3373
3374         * top.c (quit_force): Update.
3375         * main.c (captured_command_loop): Update.
3376         * common/new-op.c (operator new): Update.
3377         * common/common-exceptions.c (struct catcher)
3378         <save_cleanup_chain>: Remove member.
3379         (exceptions_state_mc_init): Update.
3380         (exception_try_scope_entry): Return nullptr.
3381         (exception_try_scope_exit, exception_rethrow)
3382         (throw_exception_sjlj, throw_exception_cxx): Update.
3383         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3384         (all_cleanups, do_cleanups, discard_cleanups)
3385         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3386         (restore_cleanups, restore_final_cleanups): Don't declare.
3387         (do_final_cleanups): Remove parameter.
3388         * common/cleanups.c (cleanup_chain, make_cleanup)
3389         (make_cleanup_dtor, all_cleanups, do_cleanups)
3390         (discard_my_cleanups, discard_cleanups)
3391         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3392         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3393         (null_cleanup): Remove.
3394         (do_final_cleanups): Remove parameter.
3395
3396 2019-03-06  Tom Tromey  <tom@tromey.com>
3397
3398         * remote.c (remote_target::remote_parse_stop_reply): Use
3399         unique_xmalloc_ptr.
3400
3401 2019-03-06  Tom Tromey  <tom@tromey.com>
3402
3403         * stabsread.c (struct stabs_field_info): Rename from field_info.
3404         <list, fnlist>: Add initializers.
3405         <obstack>: New member.
3406         (read_member_functions, read_struct_fields, read_baseclasses):
3407         Allocate on obstack.  Don't use cleanups.
3408         (read_one_struct_field, read_member_functions, read_struct_fields)
3409         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3410         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3411         (read_struct_type): Update.
3412
3413 2019-03-06  Tom Tromey  <tom@tromey.com>
3414
3415         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3416         * common/filestuff.h (make_cleanup_close): Don't declare.
3417         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3418         Remove.
3419
3420 2019-03-06  Tom Tromey  <tom@tromey.com>
3421
3422         * solib-aix.c: Use make_scope_exit.
3423
3424 2019-03-06  Tom Tromey  <tom@tromey.com>
3425
3426         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3427         Use make_scope_exit.
3428
3429 2019-03-06  Tom Tromey  <tom@tromey.com>
3430
3431         * solib-svr4.c (disable_probes_interface): Remove parameter.
3432         (svr4_handle_solib_event): Use make_scope_exit.
3433
3434 2019-03-06  Tom Tromey  <tom@tromey.com>
3435
3436         * remote.c (struct stop_reply_deleter): Remove.
3437         (stop_reply_up): Update.
3438         (struct stop_reply): Derive from notif_event.  Don't typedef.
3439         <regcache>: Now a std::vector.
3440         (stop_reply_xfree): Remove.
3441         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3442         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3443         (remote_target::discard_pending_stop_replies): Use delete.
3444         (remote_target::remote_parse_stop_reply): Update.
3445         (remote_target::process_stop_reply): Update.
3446         * remote-notif.h (struct notif_event): Add virtual destructor.
3447         Remove "dtr" member.
3448         (struct notif_client) <alloc_event>: Return a unique_ptr.
3449         (notif_event_xfree): Don't declare.
3450         (notif_event_up): New typedef.
3451         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3452         (notif_event_xfree, do_notif_event_xfree): Remove.
3453         (remote_notif_state_xfree): Update.
3454
3455 2019-03-06  Tom Tromey  <tom@tromey.com>
3456
3457         * infrun.c (displaced_step_clear_cleanup): Now a
3458         forward_scope_exit type.
3459         (displaced_step_prepare_throw): Update.
3460         (displaced_step_fixup): Update.
3461
3462 2019-03-06  Tom Tromey  <tom@tromey.com>
3463
3464         * inferior.h (class inferior): Update comment.
3465         * gdbthread.h (class thread_info): Update comment.
3466
3467 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3468             Tom Tromey  <tom@tromey.com>
3469
3470         * stabsread.h (struct stab_section_list): Remove.
3471         (coffstab_build_psymtabs): Update.
3472         * dbxread.c (symbuf_sections): Now a std::vector.
3473         (sect_idx): New global.
3474         (fill_symbuf): Update.
3475         (coffstab_build_psymtabs): Change type of stabsects parameter.
3476         Update.
3477         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3478         std::vector.
3479         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3480         (coff_locate_sections): Update.
3481         (coff_symfile_read): Remove cleanups.  Update.
3482         (init_stringtab): Add storage parameter.
3483         (free_stringtab, free_stringtab_cleanup): Remove.
3484         (init_lineno): Add storage parameter.
3485         (free_linetab, free_linetab_cleanup): Remove.
3486
3487 2019-03-06  Pedro Alves  <palves@redhat.com>
3488
3489         * linux-fork.c (fork_info::clobber_regs): Delete.
3490         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3491         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3492         comment.  Adjust.
3493         (scoped_switch_fork_info::scoped_switch_fork_info)
3494         (checkpoint_command, linux_fork_context): Adjust
3495         fork_save_infrun_state calls.
3496
3497 2019-03-06  Pedro Alves  <palves@redhat.com>
3498
3499         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3500         (inf_has_multiple_threads): Return 'bool' and rewrite using
3501         inferior_info::threads().
3502
3503 2019-03-06  Pedro Alves  <palves@redhat.com>
3504
3505         * linux-fork.c: Include <list>.
3506         (fork_list): Now a std::list instance.
3507         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3508         (forks_exist_p, find_last_fork): Adjust.
3509         (new_fork): Delete.
3510         (one_fork_p): New.
3511         (add_fork): Adjust.
3512         (free_fork): Delete, folded into fork_info::~fork_info().
3513         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3514         Adjust.
3515         (init_fork_list): Delete.
3516         (linux_fork_killall, linux_fork_mourn_inferior)
3517         (linux_fork_detach, info_checkpoints_command): Adjust.
3518         (_initialize_linux_fork): No longer call init_fork_list.
3519
3520 2019-03-06  Pedro Alves  <palves@redhat.com>
3521
3522         * linux-fork.c (new_fork): New, split out of ...
3523         (add_fork): ... this.  Return void.  Move "first fork" special
3524         case from here, to ...
3525         (checkpoint_command): ... here.
3526         * linux-linux.h (add_fork): Return void.
3527
3528 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3529
3530         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3531
3532 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3533             Chris January  <chris.january@arm.com>
3534             David Lecomber  <david.lecomber@arm.com>
3535
3536         * f-exp.y: New token, UNOP_INTRINSIC.
3537         (exp): New pattern using UNOP_INTRINSIC token.
3538         (f77_keywords): Add 'abs' keyword.
3539         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3540         (value_from_host_double): New function.
3541         (evaluate_subexp_f): Support UNOP_ABS.
3542
3543 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3544
3545         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3546         types.
3547
3548 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3549
3550         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3551         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3552         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3553
3554 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3555
3556         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3557
3558 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3559             Chris January  <chris.january@arm.com>
3560
3561         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3562         * f-exp.y: Define 'KIND' token.
3563         (exp): New pattern for KIND expressions.
3564         (ptype): Handle types with a kind extension.
3565         (direct_abs_decl): Extend to spot kind extensions.
3566         (f77_keywords): Add 'kind' to the list.
3567         (push_kind_type): New function.
3568         (convert_to_kind_type): New function.
3569         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3570         * parse.c (operator_length_standard): Likewise.
3571         * parser-defs.h (enum type_pieces): Add tp_kind.
3572         * std-operator.def: Add UNOP_KIND.
3573
3574 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3575
3576         * f-exp.y (f_parse): Set yydebug.
3577
3578 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3579
3580         * f-lang.c (evaluate_subexp_f): New function.
3581         (exp_descriptor_f): New global.
3582         (f_language_defn): Use exp_descriptor_f instead of
3583         exp_descriptor_standard.
3584
3585 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3586
3587         * f-exp.y (struct token): Add comments.
3588         (dot_ops): Remove uppercase versions and the end marker.
3589         (f77_keywords): Likewise.
3590         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3591         entries in the dot_ops array are case insensitive, and use
3592         strncasecmp to compare strings.  Also some whitespace cleanup in
3593         this area.  Similar for the f77_keywords array, except entries in
3594         this list might be case sensitive.
3595
3596 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3597
3598         * f-exp.y (struct f77_boolean_val): Add comments.
3599         (boolean_values): Remove uppercase versions, and end marker.
3600         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3601         and use strncasecmp to achieve case insensitivity.  Additionally,
3602         perform whitespace cleanup around this code.
3603
3604 2019-03-06  Tom Tromey  <tromey@adacore.com>
3605
3606         * remote-sim.c (gdbsim_target_open): Use result of
3607         gdb_argv::release.
3608
3609 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3610         Dirk Schubert  <dirk.schubert@arm.com>
3611         Chris January  <chris.january@arm.com>
3612
3613         * eval.c (evaluate_subexp_standard): Call Fortran argument
3614         wrapping logic.
3615         * f-lang.c (struct value): A value which can be passed into a
3616         Fortran function call.
3617         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3618         where appropriate.
3619         (struct type): Value ready for a Fortran function call.
3620         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3621         is needed.
3622         * f-lang.h (fortran_argument_convert): Declaration.
3623         (fortran_preserve_arg_pointer): Declaration.
3624         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3625
3626 2019-03-05  Tom Tromey  <tromey@adacore.com>
3627
3628         * python/py-prettyprint.c (print_string_repr): Remove #if.
3629         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3630
3631 2019-03-05  Tom Tromey  <tromey@adacore.com>
3632
3633         * target.c (the_dummy_target): Move later.  Change type to
3634         "dummy_target".
3635         (initialize_targets): Don't initialize the_dummy_target.
3636
3637 2019-03-05  Tom Tromey  <tromey@adacore.com>
3638
3639         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3640         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3641
3642 2019-03-05  Tom Tromey  <tromey@adacore.com>
3643
3644         * windows-nat.c (windows_nat_target::attach)
3645         (windows_nat_target::detach): Don't call gdb_flush.
3646         * valprint.c (generic_val_print, val_print, val_print_string):
3647         Don't call gdb_flush.
3648         * utils.c (defaulted_query): Don't call gdb_flush.
3649         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3650         * target.c (target_announce_detach): Don't call gdb_flush.
3651         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3652         * remote.c (extended_remote_target::attach): Don't call
3653         gdb_flush.
3654         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3655         * printcmd.c (do_examine): Don't call gdb_flush.
3656         (info_display_command): Don't call gdb_flush.
3657         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3658         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3659         * memattr.c (info_mem_command): Don't call gdb_flush.
3660         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3661         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3662         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3663         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3664         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3665         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3666         (gnu_nat_target::detach): Don't call gdb_flush.
3667         * f-valprint.c (f_val_print): Don't call gdb_flush.
3668         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3669         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3670         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3671         gdb_flush.
3672         * c-valprint.c (c_val_print): Don't call gdb_flush.
3673         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3674
3675 2019-03-05  Tom Tromey  <tromey@adacore.com>
3676
3677         * varobj.c (update_dynamic_varobj_children): Update.
3678         (install_default_visualizer): Use reset, not release.
3679         * value.c (set_internalvar): Update.
3680         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3681         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3682         ATTRIBUTE_UNUSED_RESULT.
3683
3684 2019-03-05  Tom Tromey  <tromey@adacore.com>
3685
3686         * remote.c (class scoped_remote_fd) <release>: Add
3687         ATTRIBUTE_UNUSED_RESULT.
3688
3689 2019-03-05  Tom Tromey  <tromey@adacore.com>
3690
3691         * macroexp.c (struct macro_buffer) <release>: Add
3692         ATTRIBUTE_UNUSED_RESULT.
3693
3694 2019-03-05  Tom Tromey  <tromey@adacore.com>
3695
3696         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3697         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3698         ATTRIBUTE_UNUSED_RESULT.
3699
3700 2019-03-05  Tom Tromey  <tromey@adacore.com>
3701
3702         * common/scoped_fd.h (class scoped_fd) <release>: Add
3703         ATTRIBUTE_UNUSED_RESULT.
3704
3705 2019-03-05  Tom Tromey  <tromey@adacore.com>
3706
3707         * parser-defs.h (struct parser_state) <release>: Add
3708         ATTRIBUTE_UNUSED_RESULT.
3709
3710 2019-03-05  Tom Tromey  <tromey@adacore.com>
3711
3712         * utils.h (class gdb_argv) <release>: Add
3713         ATTRIBUTE_UNUSED_RESULT.
3714         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3715
3716 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3717
3718         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3719         for-loop range, to avoid compiler warnings.
3720
3721         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3722         avoid compiler warnings about unused variables.
3723
3724         * NEWS: Mention end of support for native debugging on MS-Windows
3725         before XP.
3726
3727         PR gdb/24292
3728         * common/netstuff.c:
3729         * gdbserver/gdbreplay.c
3730         * gdbserver/remote-utils.c:
3731         * ser-tcp.c:
3732         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3733         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3734         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3735         'getaddrinfo' and 'freeaddrinfo' were not available before
3736         Windows XP, and mingw.org's MinGW headers by default define
3737         _WIN32_WINNT to 0x500.
3738
3739 2019-03-01  Gary Benson <gbenson@redhat.com>
3740
3741         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3742
3743 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3744             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3745
3746         PR gdb/8527
3747         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3748         set_sigint_trap, clear_sigint_trap.
3749
3750 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3751
3752         * target.c (target_detach): Clear the regcache and the
3753         frame cache.
3754
3755 2019-02-27  Pedro Alves  <palves@redhat.com>
3756
3757         * utils.c (set_screen_size): When we cap the height/width sizes,
3758         tweak the corresponding command variable to show "unlimited":
3759
3760 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3761             Pedro Alves  <palves@redhat.com>
3762
3763         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3764         before calling rl_set_screen_size.
3765
3766 2019-02-27  Tom Tromey  <tromey@adacore.com>
3767
3768         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3769         define.
3770         * python/py-value.c: Remove Python 2.4 workaround.
3771         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3772         workaround.
3773         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3774         Python 2.4 workaround.
3775         * python/python-internal.h: Remove Python 2.4 comment.
3776         (Py_ssize_t): Don't define.
3777         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3778         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3779         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3780         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3781         * python/python.c (do_start_initialization): Remove Python 2.4
3782         workaround.
3783         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3784         (print_children): Remove Python 2.4 workaround.
3785         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3786         workaround.
3787         (CHARBUFFERPROC_NAME): Remove.
3788         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3789         Python 2.4 workaround.
3790
3791 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3792
3793         * NEWS: Note minimum Python version.
3794
3795 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3796
3797         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3798         code from these functions.  Remove corresponding ifdefs.  Use
3799         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3800         Remove gotos and target of gotos.
3801         (infpy_search_memory): Likewise.
3802
3803 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3804
3805         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3806         (hppa_gdbarch_init): Don't register deleted functions with
3807         gdbarch.
3808
3809 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3810
3811         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3812         (h8300_unwind_sp): Delete.
3813         (h8300_dummy_id): Delete.
3814         (h8300_gdbarch_init): Don't register deleted functions with
3815         gdbarch.
3816
3817 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3818
3819         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3820         (ft32_unwind_pc): Delete.
3821         (ft32_unwind_sp): Delete.
3822         (ft32_gdbarch_init): Don't register deleted functions with
3823         gdbarch.
3824
3825 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3826
3827         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3828         (frv_unwind_pc): Delete.
3829         (frv_unwind_sp): Delete.
3830         (frv_gdbarch_init): Don't register deleted functions with
3831         gdbarch.
3832
3833 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3834
3835         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3836         (riscv_unwind_pc): Delete.
3837         (riscv_unwind_sp): Delete.
3838         (riscv_gdbarch_init): Don't register deleted functions with
3839         gdbarch.
3840
3841 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3842
3843         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3844         (csky_unwind_pc): Delete.
3845         (csky_unwind_sp): Delete.
3846         (csky_gdbarch_init): Don't register deleted functions with
3847         gdbarch.
3848
3849 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3850
3851         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3852         (cris_unwind_pc): Delete.
3853         (cris_unwind_sp): Delete.
3854         (cris_gdbarch_init): Don't register deleted functions with
3855         gdbarch.
3856
3857 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3858
3859         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3860         (bfin_unwind_pc): Delete.
3861         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3862
3863 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3864
3865         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3866         (arm_unwind_pc): Delete.
3867         (arm_unwind_sp): Delete.
3868         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3869
3870 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3871
3872         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3873         (arc_unwind_pc): Delete.
3874         (arc_unwind_sp): Delete.
3875         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3876
3877 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3878
3879         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3880         (alpha_unwind_pc): Delete.
3881         (alpha_gdbarch_init): Don't register deleted functions with
3882         gdbarch.
3883
3884 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3885
3886         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3887         (aarch64_unwind_pc): Delete.
3888         (aarch64_unwind_sp): Delete.
3889         (aarch64_gdbarch_init): Don't register deleted functions with
3890         gdbarch.
3891
3892 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3893
3894         * gdbtypes.c (type_align): Don't consider static members when
3895         computing structure alignment.
3896
3897 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3898
3899         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3900         return 0 for other types.
3901         * arch-utils.c (default_type_align): Always return 0.
3902         * gdbarch.h: Regenerate.
3903         * gdbarch.sh (type_align): Extend comment.
3904         * gdbtypes.c (type_align): Add additional comments, always call
3905         gdbarch_type_align before applying the default rules.
3906         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3907         generic code will then apply a suitable default.
3908         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3909         types, return 0 for other types.
3910
3911 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3912
3913         * NEWS: Create a new section for the next release branch.
3914         Rename the section of the current branch, now that it has
3915         been cut.
3916
3917 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3918
3919         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3920         * version.in: Bump version to 8.3.50.DATE-git.
3921
3922 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3923
3924         * aix-thread.c (ptid_cmp): Remove unused variable.
3925         (get_signaled_thread): Likewise.
3926         (store_regs_user_thread): Likewise.
3927         (store_regs_kernel_thread): Likewise.
3928         (fetch_regs_kernel_thread): Remove shadowed variable.
3929
3930 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3931
3932         * features/riscv/32bit-cpu.xml: Add register numbers.
3933         * features/riscv/32bit-fpu.c: Regenerate.
3934         * features/riscv/32bit-fpu.xml: Add register numbers.
3935         * features/riscv/64bit-cpu.xml: Add register numbers.
3936         * features/riscv/64bit-fpu.c: Regenerate.
3937         * features/riscv/64bit-fpu.xml: Add register numbers.
3938
3939 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3940
3941         * NEWS: Mention two argument form of gdb.Value constructor.
3942         * python/py-value.c (convert_buffer_and_type_to_value): New
3943         function.
3944         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3945         Add support for handling an optional second argument.  Call
3946         convert_buffer_and_type_to_value as appropriate.
3947         * python/python-internal.h (Py_buffer_deleter): New struct.
3948         (Py_buffer_up): New typedef.
3949
3950 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3951
3952         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3953         instead of releasing ownership.
3954
3955 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3956
3957         * dwarf2read.c (open_and_init_dwp_file): Call
3958         elf_numsections instead of bfd_count_sections to initialize
3959         dwp_file->num_sections.
3960
3961 2019-02-25  Tom Tromey  <tromey@adacore.com>
3962
3963         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3964
3965 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3966
3967         * gcore.in: Add '--readnever' option when invoking GDB.
3968
3969 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3970
3971         * MAINTAINERS: Update my email address.
3972
3973 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3974
3975         * build-id.c (build_id_to_debug_bfd_1): New function.
3976         (build_id_to_debug_bfd): Look for separate debug file in
3977         sysroot.
3978
3979 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3980
3981         * gdbarch.sh: Update the copyright year range that is placed into
3982         generated files.
3983
3984 2019-02-22  Keith Seitz  <keiths@redhat.com>
3985
3986         PR symtab/23853
3987         * linespec.c (create_sals_line_offset): Search for the default
3988         symtab's filename instead of its fullname.
3989
3990 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3991
3992         * NEWS: Update style defaults.
3993
3994 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3995
3996         * main.c (captured_main_1): Disable styling in batch mode.
3997
3998 2019-02-20  Tom Tromey  <tom@tromey.com>
3999
4000         * symtab.c (symtab_symbol_info): Fix typos.
4001
4002 2019-02-20  Tom Tromey  <tromey@adacore.com>
4003
4004         * findcmd.c (_initialize_mem_search): Use upper case for
4005         metasyntactic variables.
4006
4007 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4008
4009         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4010         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4011
4012 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4013
4014         * top.h (source_file_name): Change to std::string.
4015         * top.c (source_file_name): Likewise.
4016         (command_line_input): Adjust.
4017         * cli/cli-script.c (script_from_file): Adjust.
4018
4019 2019-02-19  Tom Tromey  <tromey@adacore.com>
4020
4021         * ravenscar-thread.c
4022         (ravenscar_thread_target::update_thread_list): Don't call
4023         ada_build_task_list.
4024         * ada-lang.h (ada_build_task_list): Don't declare.
4025         * ada-tasks.c (struct ada_tasks_inferior_data)
4026         <task_list_valid_p>: Now bool.
4027         (read_known_tasks, ada_task_list_changed)
4028         (ada_tasks_invalidate_inferior_data): Update.
4029         (read_known_tasks_array): Return bool.
4030         (read_known_tasks_list): Likewise.
4031         (read_known_tasks): Return void.
4032         (ada_build_task_list): Now static.
4033
4034 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4035
4036         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4037         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4038
4039 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4040
4041         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4042         variant for ada_tasks_pspace_data_handle and
4043         ada_tasks_inferior_data_handle.
4044         (ada_tasks_pspace_data_cleanup): New function.
4045         (ada_tasks_inferior_data_cleanup): New function.
4046
4047 2019-02-17  Tom Tromey  <tom@tromey.com>
4048
4049         * macrotab.h (macro_source_fullname): Return a std::string.
4050         * macrotab.c (macro_include, check_for_redefinition)
4051         (macro_undef, macro_lookup_definition, foreach_macro)
4052         (foreach_macro_in_scope): Update.
4053         (macro_source_fullname): Return a std::string.
4054         * macrocmd.c (show_pp_source_pos): Update.
4055
4056 2019-02-17  Tom Tromey  <tom@tromey.com>
4057
4058         * macrocmd.c (show_pp_source_pos): Style the file names.
4059
4060 2019-02-17  Tom Tromey  <tom@tromey.com>
4061
4062         PR tui/24197:
4063         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4064
4065 2019-02-17  Tom Tromey  <tom@tromey.com>
4066
4067         * ada-lang.c (user_select_syms): Use filtered printing.
4068         * utils.c (wrap_style): New global.
4069         (desired_style): Remove.
4070         (emit_style_escape): Add stream parameter.
4071         (set_output_style, reset_terminal_style, prompt_for_continue):
4072         Update.
4073         (flush_wrap_buffer): Only flush gdb_stdout.
4074         (wrap_here): Set wrap_style.
4075         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4076         treat escape sequences as a character.  Change when wrap buffer is
4077         flushed.
4078         (fputs_styled): Do not set the output style when the default is
4079         requested.
4080         * ui-style.h (struct ui_file_style) <is_default>: New method.
4081         * source.c (print_source_lines_base): Emit escape sequences in one
4082         piece.
4083
4084 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4085
4086         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4087         integers and enumeration types.
4088
4089 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4090
4091         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4092         instead of lookup_symbol_in_language
4093         (do_exact_match): New function.
4094         (ada_get_symbol_name_matcher): Return do_exact_match when
4095         doing a verbatim match.
4096
4097 2019-02-15  Tom Tromey  <tromey@adacore.com>
4098
4099         * ravenscar-thread.c (ravenscar_thread_target::resume)
4100         (ravenscar_thread_target::wait): Special case wildcard requests.
4101
4102 2019-02-15  Tom Tromey  <tromey@adacore.com>
4103
4104         * ravenscar-thread.c (base_ptid): Remove.
4105         (struct ravenscar_thread_target) <close>: New method.
4106         <m_base_ptid>: New member.
4107         <update_inferior_ptid, active_task, task_is_currently_active,
4108         runtime_initialized>: Declare methods.
4109         <ravenscar_thread_target>: Add constructor.
4110         (ravenscar_thread_target::task_is_currently_active)
4111         (ravenscar_thread_target::update_inferior_ptid)
4112         (ravenscar_runtime_initialized): Rename.  Now methods.
4113         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4114         (ravenscar_thread_target::update_thread_list): Update.
4115         (ravenscar_thread_target::active_task): Now method.
4116         (ravenscar_thread_target::store_registers)
4117         (ravenscar_thread_target::prepare_to_store)
4118         (ravenscar_thread_target::prepare_to_store)
4119         (ravenscar_thread_target::mourn_inferior): Update.
4120         (ravenscar_inferior_created): Use "new" to create target.
4121         (ravenscar_thread_target::get_ada_task_ptid): Update.
4122         (_initialize_ravenscar): Don't initialize base_ptid.
4123         (ravenscar_ops): Remove global.
4124
4125 2019-02-15  Tom Tromey  <tromey@adacore.com>
4126
4127         * target.h (push_target): Declare new overload.
4128         * target.c (push_target): New overload, taking an rvalue reference.
4129         * remote.c (remote_target::open_1): Use push_target overload.
4130         * corelow.c (core_target_open): Use push_target overload.
4131
4132 2019-02-15  Tom Tromey  <tromey@adacore.com>
4133
4134         * ravenscar-thread.c (is_ravenscar_task)
4135         (ravenscar_task_is_currently_active): Return bool.
4136         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4137         (_initialize_ravenscar): Remove "(void)".
4138         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4139         Return bool.
4140
4141 2019-02-15  Tom Tromey  <tromey@adacore.com>
4142
4143         * ravenscar-thread.c (ravenscar_runtime_initializer)
4144         (has_ravenscar_runtime, get_running_thread_id)
4145         (ravenscar_thread_target::resume): Fix indentation.
4146
4147 2019-02-15  Tom Tromey  <tromey@adacore.com>
4148
4149         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4150         from ravenscar_arch_ops.
4151         (sparc_ravenscar_ops::fetch_registers)
4152         (sparc_ravenscar_ops::store_registers): Now methods.
4153         (sparc_ravenscar_prepare_to_store): Remove.
4154         (sparc_ravenscar_ops): Redefine.
4155         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4156         methods and destructor.  Remove members.
4157         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4158         (ravenscar_thread_target::store_registers)
4159         (ravenscar_thread_target::prepare_to_store): Update.
4160         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4161         Remove.
4162         (struct ppc_ravenscar_powerpc_ops): Derive from
4163         ravenscar_arch_ops.
4164         (ppc_ravenscar_powerpc_ops::fetch_registers)
4165         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4166         (ppc_ravenscar_powerpc_ops): Redefine.
4167         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4168         (ppc_ravenscar_e500_ops::fetch_registers)
4169         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4170         (ppc_ravenscar_e500_ops): Redefine.
4171         * aarch64-ravenscar-thread.c
4172         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4173         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4174         (aarch64_ravenscar_fetch_registers)
4175         (aarch64_ravenscar_store_registers): Now methods.
4176         (aarch64_ravenscar_ops): Redefine.
4177
4178 2019-02-15  Tom Tromey  <tromey@adacore.com>
4179
4180         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4181         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4182         (ravenscar_thread_target::stopped_by_watchpoint)
4183         (ravenscar_thread_target::stopped_data_address)
4184         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4185
4186 2019-02-15  Tom Tromey  <tromey@adacore.com>
4187
4188         * ravenscar-thread.c: Fix some typos.
4189
4190 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4191             Tom Tromey  <tromey@adacore.com>
4192
4193         * ada-lang.c (ada_exception_sal): Change addr_string to a
4194         std::string.
4195         (create_ada_exception_catchpoint): Update.
4196
4197 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4198             Tom Tromey  <tromey@adacore.com>
4199
4200         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4201         (bp_location_ops): Remove.
4202         (base_breakpoint_allocate_location): Update.
4203         (free_bp_location): Update.
4204         * ada-lang.c (class ada_catchpoint_location)
4205         <ada_catchpoint_location>: Remove ops parameter.
4206         (ada_catchpoint_location_dtor): Remove.
4207         (ada_catchpoint_location_ops): Remove.
4208         (allocate_location_exception): Update.
4209         * breakpoint.h (struct bp_location_ops): Remove.
4210         (class bp_location) <bp_location>: Remove bp_location_ops
4211         parameter.
4212         <~bp_location>: Add destructor.
4213         <ops>: Remove.
4214
4215 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4216             Pedro Alves  <palves@redhat.com>
4217
4218         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4219         'PATH_MAX'.
4220
4221 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4222             Samuel Thibault  <samuel.thibault@gnu.org>
4223             Thomas Schwinge  <thomas@codesourcery.com>
4224
4225         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4226         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4227
4228 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4229
4230         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4231         (check_empty): Use "const char *".
4232
4233         * gnu-nat.c (gnu_nat_target::detach): Instead of
4234         'detach_inferior (pid)' call
4235         'detach_inferior (find_inferior_pid (pid))'.
4236
4237         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4238         'nat/fork-inferior.o'.
4239         * gnu-nat.c: #include "nat/fork-inferior.h".
4240
4241         * gnu-nat.c (gnu_nat_target::detach): Instead of
4242         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4243         * gnu-nat.h: #include "inf-child.h".
4244         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4245         'i386_gnu_nat_target::fetch_registers'.
4246         (gnu_store_registers): Rename/move to
4247         'i386_gnu_nat_target::store_registers'.
4248
4249         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4250         * gnu-nat.h (mach_thread_info): New function.
4251         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4252
4253         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4254
4255 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4256
4257         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4258
4259 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4260
4261         * windows-nat.c (windows_add_thread): Add new parameter
4262         "main_thread_p" with default value set to false.  Update
4263         function documentation as well as all callers.
4264         (windows_delete_thread): Likewise.
4265         (fake_create_process): Update call to windows_add_thread.
4266         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4267         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4268         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4269         call to windows_delete_thread.
4270
4271 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4272
4273         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4274
4275 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4276
4277         * symfile.c (find_separate_debug_file): Use canonical path of
4278         sysroot with child_path instead of gdb_sysroot if it is valid.
4279
4280 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4281
4282         * symfile.c (find_separate_debug_file): Use child_path to
4283         determine if an object file is under a sysroot.
4284
4285 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4286
4287         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4288         unittests/child-path-selftests.c.
4289         * common/pathstuff.c (child_path): New function.
4290         * common/pathstuff.h (child_path): New prototype.
4291         * unittests/child-path-selftests.c: New file.
4292
4293 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4294
4295         * symfile.c (find_separate_debug_file): Look for separate debug
4296         files in debug directories under the sysroot.
4297
4298 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4299
4300         * symtab.h (struct minimal_symbol data_p): New const method.
4301         (struct minimal_symbol text_p): Likewise.
4302         * symtab.c (output_source_filename): Use file name style
4303         to print file name.
4304         (print_symbol_info): Likewise.
4305         (print_msymbol_info): Use address style to print addresses.
4306         Use function name style to print executable text symbols.
4307         (expand_symtab_containing_pc): Use data_p.
4308         (find_pc_sect_compunit_symtab): Likewise.
4309
4310 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4311
4312         * breakpoint.c (describe_other_breakpoints): Use address style
4313         to print addresses.
4314         (say_where): Likewise.
4315
4316 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4317
4318         * ada-typeprint.c (print_func_type): Print function name
4319         style to print function name.
4320         * c-typeprint.c (c_print_type_1): Likewise.
4321
4322 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4323
4324         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4325         for execve.
4326
4327 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4328
4329         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4330         type_stack.
4331
4332 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4333
4334         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4335         TYPE_CODE_REF types.
4336
4337 2019-02-08  Jim Wilson  <jimw@sifive.com>
4338
4339         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4340         (riscv_linux_fregset): New.
4341         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4342
4343 2019-02-07  Tom Tromey  <tom@tromey.com>
4344
4345         * thread.c (thread_cancel_execution_command): Update.
4346         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4347         methods.
4348         (struct thread_fsm_ops): Remove.
4349         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4350         (thread_fsm_should_stop, thread_fsm_return_value)
4351         (thread_fsm_set_finished, thread_fsm_finished_p)
4352         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4353         Don't declare.
4354         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4355         * infrun.c (clear_proceed_status_thread)
4356         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4357         (print_stop_event): Update.
4358         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4359         Add constructor.
4360         (step_command_fsm_ops): Remove.
4361         (new_step_command_fsm): Remove.
4362         (step_1): Update.
4363         (step_command_fsm::should_stop): Rename from
4364         step_command_fsm_should_stop.
4365         (step_command_fsm::clean_up): Rename from
4366         step_command_fsm_clean_up.
4367         (step_command_fsm::do_async_reply_reason): Rename from
4368         step_command_fsm_async_reply_reason.
4369         (struct until_next_fsm): Inherit from thread_fsm.  Add
4370         constructor.
4371         (until_next_fsm_ops): Remove.
4372         (new_until_next_fsm): Remove.
4373         (until_next_fsm::should_stop): Rename from
4374         until_next_fsm_should_stop.
4375         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4376         (until_next_fsm::do_async_reply_reason): Rename from
4377         until_next_fsm_async_reply_reason.
4378         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4379         constructor.  Change type of breakpoint.
4380         (finish_command_fsm_ops): Remove.
4381         (new_finish_command_fsm): Remove.
4382         (finish_command_fsm::should_stop): Rename from
4383         finish_command_fsm_should_stop.
4384         (finish_command_fsm::clean_up): Rename from
4385         finish_command_fsm_clean_up.
4386         (finish_command_fsm::return_value): Rename from
4387         finish_command_fsm_return_value.
4388         (finish_command_fsm::do_async_reply_reason): Rename from
4389         finish_command_fsm_async_reply_reason.
4390         (finish_command): Update.
4391         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4392         Add constructor.
4393         (call_thread_fsm_ops): Remove.
4394         (call_thread_fsm::call_thread_fsm): Rename from
4395         new_call_thread_fsm.
4396         (call_thread_fsm::should_stop): Rename from
4397         call_thread_fsm_should_stop.
4398         (call_thread_fsm::should_notify_stop): Rename from
4399         call_thread_fsm_should_notify_stop.
4400         (run_inferior_call, call_function_by_hand_dummy): Update.
4401         * cli/cli-interp.c (should_print_stop_to_console): Update.
4402         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4403         Add constructor.  Change type of location_breakpoint,
4404         caller_breakpoint.
4405         (until_break_fsm_ops): Remove.
4406         (new_until_break_fsm): Remove.
4407         (until_break_fsm::should_stop): Rename from
4408         until_break_fsm_should_stop.
4409         (until_break_fsm::clean_up): Rename from
4410         until_break_fsm_clean_up.
4411         (until_break_fsm::do_async_reply_reason): Rename from
4412         until_break_fsm_async_reply_reason.
4413         (until_break_command): Update.
4414         * thread-fsm.c: Remove.
4415         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4416
4417 2019-02-07  Tom Tromey  <tom@tromey.com>
4418
4419         * yy-remap.h: Add include guard.
4420         * xtensa-tdep.h: Add include guard.
4421         * xcoffread.h: Rename include guard.
4422         * varobj-iter.h: Add include guard.
4423         * tui/tui.h: Rename include guard.
4424         * tui/tui-winsource.h: Rename include guard.
4425         * tui/tui-wingeneral.h: Rename include guard.
4426         * tui/tui-windata.h: Rename include guard.
4427         * tui/tui-win.h: Rename include guard.
4428         * tui/tui-stack.h: Rename include guard.
4429         * tui/tui-source.h: Rename include guard.
4430         * tui/tui-regs.h: Rename include guard.
4431         * tui/tui-out.h: Rename include guard.
4432         * tui/tui-layout.h: Rename include guard.
4433         * tui/tui-io.h: Rename include guard.
4434         * tui/tui-hooks.h: Rename include guard.
4435         * tui/tui-file.h: Rename include guard.
4436         * tui/tui-disasm.h: Rename include guard.
4437         * tui/tui-data.h: Rename include guard.
4438         * tui/tui-command.h: Rename include guard.
4439         * tic6x-tdep.h: Add include guard.
4440         * target/waitstatus.h: Rename include guard.
4441         * target/wait.h: Rename include guard.
4442         * target/target.h: Rename include guard.
4443         * target/resume.h: Rename include guard.
4444         * target-float.h: Rename include guard.
4445         * stabsread.h: Add include guard.
4446         * rs6000-tdep.h: Add include guard.
4447         * riscv-fbsd-tdep.h: Add include guard.
4448         * regformats/regdef.h: Rename include guard.
4449         * record.h: Rename include guard.
4450         * python/python.h: Rename include guard.
4451         * python/python-internal.h: Rename include guard.
4452         * python/py-stopevent.h: Rename include guard.
4453         * python/py-ref.h: Rename include guard.
4454         * python/py-record.h: Rename include guard.
4455         * python/py-record-full.h: Rename include guard.
4456         * python/py-record-btrace.h: Rename include guard.
4457         * python/py-instruction.h: Rename include guard.
4458         * python/py-events.h: Rename include guard.
4459         * python/py-event.h: Rename include guard.
4460         * procfs.h: Add include guard.
4461         * proc-utils.h: Add include guard.
4462         * p-lang.h: Add include guard.
4463         * or1k-tdep.h: Rename include guard.
4464         * observable.h: Rename include guard.
4465         * nto-tdep.h: Rename include guard.
4466         * nat/x86-linux.h: Rename include guard.
4467         * nat/x86-linux-dregs.h: Rename include guard.
4468         * nat/x86-gcc-cpuid.h: Add include guard.
4469         * nat/x86-dregs.h: Rename include guard.
4470         * nat/x86-cpuid.h: Rename include guard.
4471         * nat/ppc-linux.h: Rename include guard.
4472         * nat/mips-linux-watch.h: Rename include guard.
4473         * nat/linux-waitpid.h: Rename include guard.
4474         * nat/linux-ptrace.h: Rename include guard.
4475         * nat/linux-procfs.h: Rename include guard.
4476         * nat/linux-osdata.h: Rename include guard.
4477         * nat/linux-nat.h: Rename include guard.
4478         * nat/linux-namespaces.h: Rename include guard.
4479         * nat/linux-btrace.h: Rename include guard.
4480         * nat/glibc_thread_db.h: Rename include guard.
4481         * nat/gdb_thread_db.h: Rename include guard.
4482         * nat/gdb_ptrace.h: Rename include guard.
4483         * nat/fork-inferior.h: Rename include guard.
4484         * nat/amd64-linux-siginfo.h: Rename include guard.
4485         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4486         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4487         * nat/aarch64-linux.h: Rename include guard.
4488         * nat/aarch64-linux-hw-point.h: Rename include guard.
4489         * mn10300-tdep.h: Add include guard.
4490         * mips-linux-tdep.h: Add include guard.
4491         * mi/mi-parse.h: Rename include guard.
4492         * mi/mi-out.h: Rename include guard.
4493         * mi/mi-main.h: Rename include guard.
4494         * mi/mi-interp.h: Rename include guard.
4495         * mi/mi-getopt.h: Rename include guard.
4496         * mi/mi-console.h: Rename include guard.
4497         * mi/mi-common.h: Rename include guard.
4498         * mi/mi-cmds.h: Rename include guard.
4499         * mi/mi-cmd-break.h: Rename include guard.
4500         * m2-lang.h: Add include guard.
4501         * location.h: Rename include guard.
4502         * linux-record.h: Rename include guard.
4503         * linux-nat.h: Add include guard.
4504         * linux-fork.h: Add include guard.
4505         * i386-darwin-tdep.h: Rename include guard.
4506         * hppa-linux-offsets.h: Add include guard.
4507         * guile/guile.h: Rename include guard.
4508         * guile/guile-internal.h: Rename include guard.
4509         * gnu-nat.h: Rename include guard.
4510         * gdb-stabs.h: Rename include guard.
4511         * frv-tdep.h: Add include guard.
4512         * f-lang.h: Add include guard.
4513         * event-loop.h: Add include guard.
4514         * darwin-nat.h: Rename include guard.
4515         * cp-abi.h: Rename include guard.
4516         * config/sparc/nm-sol2.h: Rename include guard.
4517         * config/nm-nto.h: Rename include guard.
4518         * config/nm-linux.h: Add include guard.
4519         * config/i386/nm-i386gnu.h: Rename include guard.
4520         * config/djgpp/nl_types.h: Rename include guard.
4521         * config/djgpp/langinfo.h: Rename include guard.
4522         * compile/gcc-cp-plugin.h: Add include guard.
4523         * compile/gcc-c-plugin.h: Add include guard.
4524         * compile/compile.h: Rename include guard.
4525         * compile/compile-object-run.h: Rename include guard.
4526         * compile/compile-object-load.h: Rename include guard.
4527         * compile/compile-internal.h: Rename include guard.
4528         * compile/compile-cplus.h: Rename include guard.
4529         * compile/compile-c.h: Rename include guard.
4530         * common/xml-utils.h: Rename include guard.
4531         * common/x86-xstate.h: Rename include guard.
4532         * common/version.h: Rename include guard.
4533         * common/vec.h: Rename include guard.
4534         * common/tdesc.h: Rename include guard.
4535         * common/selftest.h: Rename include guard.
4536         * common/scoped_restore.h: Rename include guard.
4537         * common/scoped_mmap.h: Rename include guard.
4538         * common/scoped_fd.h: Rename include guard.
4539         * common/safe-iterator.h: Rename include guard.
4540         * common/run-time-clock.h: Rename include guard.
4541         * common/refcounted-object.h: Rename include guard.
4542         * common/queue.h: Rename include guard.
4543         * common/ptid.h: Rename include guard.
4544         * common/print-utils.h: Rename include guard.
4545         * common/preprocessor.h: Rename include guard.
4546         * common/pathstuff.h: Rename include guard.
4547         * common/observable.h: Rename include guard.
4548         * common/netstuff.h: Rename include guard.
4549         * common/job-control.h: Rename include guard.
4550         * common/host-defs.h: Rename include guard.
4551         * common/gdb_wait.h: Rename include guard.
4552         * common/gdb_vecs.h: Rename include guard.
4553         * common/gdb_unlinker.h: Rename include guard.
4554         * common/gdb_unique_ptr.h: Rename include guard.
4555         * common/gdb_tilde_expand.h: Rename include guard.
4556         * common/gdb_sys_time.h: Rename include guard.
4557         * common/gdb_string_view.h: Rename include guard.
4558         * common/gdb_splay_tree.h: Rename include guard.
4559         * common/gdb_setjmp.h: Rename include guard.
4560         * common/gdb_ref_ptr.h: Rename include guard.
4561         * common/gdb_optional.h: Rename include guard.
4562         * common/gdb_locale.h: Rename include guard.
4563         * common/gdb_assert.h: Rename include guard.
4564         * common/filtered-iterator.h: Rename include guard.
4565         * common/filestuff.h: Rename include guard.
4566         * common/fileio.h: Rename include guard.
4567         * common/environ.h: Rename include guard.
4568         * common/common-utils.h: Rename include guard.
4569         * common/common-types.h: Rename include guard.
4570         * common/common-regcache.h: Rename include guard.
4571         * common/common-inferior.h: Rename include guard.
4572         * common/common-gdbthread.h: Rename include guard.
4573         * common/common-exceptions.h: Rename include guard.
4574         * common/common-defs.h: Rename include guard.
4575         * common/common-debug.h: Rename include guard.
4576         * common/cleanups.h: Rename include guard.
4577         * common/buffer.h: Rename include guard.
4578         * common/btrace-common.h: Rename include guard.
4579         * common/break-common.h: Rename include guard.
4580         * cli/cli-utils.h: Rename include guard.
4581         * cli/cli-style.h: Rename include guard.
4582         * cli/cli-setshow.h: Rename include guard.
4583         * cli/cli-script.h: Rename include guard.
4584         * cli/cli-interp.h: Rename include guard.
4585         * cli/cli-decode.h: Rename include guard.
4586         * cli/cli-cmds.h: Rename include guard.
4587         * charset-list.h: Add include guard.
4588         * buildsym-legacy.h: Rename include guard.
4589         * bfin-tdep.h: Add include guard.
4590         * ax.h: Rename include guard.
4591         * arm-linux-tdep.h: Add include guard.
4592         * arm-fbsd-tdep.h: Add include guard.
4593         * arch/xtensa.h: Rename include guard.
4594         * arch/tic6x.h: Add include guard.
4595         * arch/i386.h: Add include guard.
4596         * arch/arm.h: Rename include guard.
4597         * arch/arm-linux.h: Rename include guard.
4598         * arch/arm-get-next-pcs.h: Rename include guard.
4599         * arch/amd64.h: Add include guard.
4600         * arch/aarch64-insn.h: Rename include guard.
4601         * arch-utils.h: Rename include guard.
4602         * annotate.h: Add include guard.
4603         * amd64-darwin-tdep.h: Rename include guard.
4604         * aarch64-linux-tdep.h: Add include guard.
4605         * aarch64-fbsd-tdep.h: Add include guard.
4606         * aarch32-linux-nat.h: Add include guard.
4607
4608 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4609
4610         * macrotab.c (macro_define_internal): New function that
4611         factorizes macro_define_object_internal and macro_define_function
4612         code.
4613         (macro_define_object_internal): Use macro_define_internal.
4614         (macro_define_function): Likewise.
4615
4616 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4617
4618         * macrocmd.c (extract_identifier): Return
4619         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4620         callers.
4621
4622 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4623
4624         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4625
4626 2019-02-05  Tom Tromey  <tom@tromey.com>
4627
4628         * target.c (target_stack::unpush): Move assertion earlier.
4629
4630 2019-01-30  Tom Tromey  <tom@tromey.com>
4631
4632         PR python/23615:
4633         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4634         (gdbpy_parse_and_eval): Likewise.
4635         * python/python-internal.h (gdbpy_allow_threads): New class.
4636
4637 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4638
4639         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4640         (aarch64_fbsd_fpregmap): Move earlier.
4641         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4642         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4643         instead of individual calls to trad_frame_set_reg_addr.
4644         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4645         earlier.
4646         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4647         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4648         instead of individual calls to trad_frame_set_reg_addr.
4649
4650 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4651
4652         * CONTRIBUTE: Replace contribution list with wiki link.
4653
4654 2019-01-25  Tom Tromey  <tom@tromey.com>
4655
4656         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4657
4658 2019-01-25  Tom Tromey  <tom@tromey.com>
4659
4660         * xtensa-linux-nat.c: Fix common/ includes.
4661         * xml-support.h: Fix common/ includes.
4662         * xml-support.c: Fix common/ includes.
4663         * x86-linux-nat.c: Fix common/ includes.
4664         * windows-nat.c: Fix common/ includes.
4665         * varobj.h: Fix common/ includes.
4666         * varobj.c: Fix common/ includes.
4667         * value.c: Fix common/ includes.
4668         * valops.c: Fix common/ includes.
4669         * utils.c: Fix common/ includes.
4670         * unittests/xml-utils-selftests.c: Fix common/ includes.
4671         * unittests/utils-selftests.c: Fix common/ includes.
4672         * unittests/unpack-selftests.c: Fix common/ includes.
4673         * unittests/tracepoint-selftests.c: Fix common/ includes.
4674         * unittests/style-selftests.c: Fix common/ includes.
4675         * unittests/string_view-selftests.c: Fix common/ includes.
4676         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4677         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4678         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4679         * unittests/rsp-low-selftests.c: Fix common/ includes.
4680         * unittests/parse-connection-spec-selftests.c: Fix common/
4681         includes.
4682         * unittests/optional-selftests.c: Fix common/ includes.
4683         * unittests/offset-type-selftests.c: Fix common/ includes.
4684         * unittests/observable-selftests.c: Fix common/ includes.
4685         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4686         * unittests/memrange-selftests.c: Fix common/ includes.
4687         * unittests/memory-map-selftests.c: Fix common/ includes.
4688         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4689         * unittests/function-view-selftests.c: Fix common/ includes.
4690         * unittests/environ-selftests.c: Fix common/ includes.
4691         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4692         * unittests/common-utils-selftests.c: Fix common/ includes.
4693         * unittests/cli-utils-selftests.c: Fix common/ includes.
4694         * unittests/array-view-selftests.c: Fix common/ includes.
4695         * ui-file.c: Fix common/ includes.
4696         * tui/tui-io.c: Fix common/ includes.
4697         * tracepoint.h: Fix common/ includes.
4698         * tracepoint.c: Fix common/ includes.
4699         * tracefile-tfile.c: Fix common/ includes.
4700         * top.h: Fix common/ includes.
4701         * top.c: Fix common/ includes.
4702         * thread.c: Fix common/ includes.
4703         * target/waitstatus.h: Fix common/ includes.
4704         * target/waitstatus.c: Fix common/ includes.
4705         * target.h: Fix common/ includes.
4706         * target.c: Fix common/ includes.
4707         * target-memory.c: Fix common/ includes.
4708         * target-descriptions.c: Fix common/ includes.
4709         * symtab.h: Fix common/ includes.
4710         * symfile.c: Fix common/ includes.
4711         * stap-probe.c: Fix common/ includes.
4712         * spu-linux-nat.c: Fix common/ includes.
4713         * sparc-nat.c: Fix common/ includes.
4714         * source.c: Fix common/ includes.
4715         * solib.c: Fix common/ includes.
4716         * solib-target.c: Fix common/ includes.
4717         * ser-unix.c: Fix common/ includes.
4718         * ser-tcp.c: Fix common/ includes.
4719         * ser-pipe.c: Fix common/ includes.
4720         * ser-base.c: Fix common/ includes.
4721         * selftest-arch.c: Fix common/ includes.
4722         * s12z-tdep.c: Fix common/ includes.
4723         * rust-exp.y: Fix common/ includes.
4724         * rs6000-aix-tdep.c: Fix common/ includes.
4725         * riscv-tdep.c: Fix common/ includes.
4726         * remote.c: Fix common/ includes.
4727         * remote-notif.h: Fix common/ includes.
4728         * remote-fileio.h: Fix common/ includes.
4729         * remote-fileio.c: Fix common/ includes.
4730         * regcache.h: Fix common/ includes.
4731         * regcache.c: Fix common/ includes.
4732         * record-btrace.c: Fix common/ includes.
4733         * python/python.c: Fix common/ includes.
4734         * python/py-type.c: Fix common/ includes.
4735         * python/py-inferior.c: Fix common/ includes.
4736         * progspace.h: Fix common/ includes.
4737         * producer.c: Fix common/ includes.
4738         * procfs.c: Fix common/ includes.
4739         * proc-api.c: Fix common/ includes.
4740         * printcmd.c: Fix common/ includes.
4741         * ppc-linux-nat.c: Fix common/ includes.
4742         * parser-defs.h: Fix common/ includes.
4743         * osdata.c: Fix common/ includes.
4744         * obsd-nat.c: Fix common/ includes.
4745         * nat/x86-linux.c: Fix common/ includes.
4746         * nat/x86-linux-dregs.c: Fix common/ includes.
4747         * nat/x86-dregs.h: Fix common/ includes.
4748         * nat/x86-dregs.c: Fix common/ includes.
4749         * nat/ppc-linux.c: Fix common/ includes.
4750         * nat/mips-linux-watch.h: Fix common/ includes.
4751         * nat/mips-linux-watch.c: Fix common/ includes.
4752         * nat/linux-waitpid.c: Fix common/ includes.
4753         * nat/linux-ptrace.h: Fix common/ includes.
4754         * nat/linux-ptrace.c: Fix common/ includes.
4755         * nat/linux-procfs.c: Fix common/ includes.
4756         * nat/linux-personality.c: Fix common/ includes.
4757         * nat/linux-osdata.c: Fix common/ includes.
4758         * nat/linux-namespaces.c: Fix common/ includes.
4759         * nat/linux-btrace.h: Fix common/ includes.
4760         * nat/linux-btrace.c: Fix common/ includes.
4761         * nat/fork-inferior.c: Fix common/ includes.
4762         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4763         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4764         * nat/aarch64-linux.c: Fix common/ includes.
4765         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4766         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4767         * namespace.h: Fix common/ includes.
4768         * mips-linux-tdep.c: Fix common/ includes.
4769         * minsyms.c: Fix common/ includes.
4770         * mi/mi-parse.h: Fix common/ includes.
4771         * mi/mi-main.c: Fix common/ includes.
4772         * mi/mi-cmd-env.c: Fix common/ includes.
4773         * memrange.h: Fix common/ includes.
4774         * memattr.c: Fix common/ includes.
4775         * maint.h: Fix common/ includes.
4776         * maint.c: Fix common/ includes.
4777         * main.c: Fix common/ includes.
4778         * machoread.c: Fix common/ includes.
4779         * location.c: Fix common/ includes.
4780         * linux-thread-db.c: Fix common/ includes.
4781         * linux-nat.c: Fix common/ includes.
4782         * linux-fork.c: Fix common/ includes.
4783         * inline-frame.c: Fix common/ includes.
4784         * infrun.c: Fix common/ includes.
4785         * inflow.c: Fix common/ includes.
4786         * inferior.h: Fix common/ includes.
4787         * inferior.c: Fix common/ includes.
4788         * infcmd.c: Fix common/ includes.
4789         * inf-ptrace.c: Fix common/ includes.
4790         * inf-child.c: Fix common/ includes.
4791         * ia64-linux-nat.c: Fix common/ includes.
4792         * i387-tdep.c: Fix common/ includes.
4793         * i386-tdep.c: Fix common/ includes.
4794         * i386-linux-tdep.c: Fix common/ includes.
4795         * i386-linux-nat.c: Fix common/ includes.
4796         * i386-go32-tdep.c: Fix common/ includes.
4797         * i386-fbsd-tdep.c: Fix common/ includes.
4798         * i386-fbsd-nat.c: Fix common/ includes.
4799         * guile/scm-type.c: Fix common/ includes.
4800         * guile/guile.c: Fix common/ includes.
4801         * go32-nat.c: Fix common/ includes.
4802         * gnu-nat.c: Fix common/ includes.
4803         * gdbthread.h: Fix common/ includes.
4804         * gdbarch-selftests.c: Fix common/ includes.
4805         * gdb_usleep.c: Fix common/ includes.
4806         * gdb_select.h: Fix common/ includes.
4807         * gdb_bfd.c: Fix common/ includes.
4808         * gcore.c: Fix common/ includes.
4809         * fork-child.c: Fix common/ includes.
4810         * findvar.c: Fix common/ includes.
4811         * fbsd-nat.c: Fix common/ includes.
4812         * event-top.c: Fix common/ includes.
4813         * event-loop.c: Fix common/ includes.
4814         * dwarf2read.c: Fix common/ includes.
4815         * dwarf2loc.c: Fix common/ includes.
4816         * dwarf2-frame.c: Fix common/ includes.
4817         * dwarf-index-cache.c: Fix common/ includes.
4818         * dtrace-probe.c: Fix common/ includes.
4819         * disasm-selftests.c: Fix common/ includes.
4820         * defs.h: Fix common/ includes.
4821         * csky-tdep.c: Fix common/ includes.
4822         * cp-valprint.c: Fix common/ includes.
4823         * cp-support.h: Fix common/ includes.
4824         * cp-support.c: Fix common/ includes.
4825         * corelow.c: Fix common/ includes.
4826         * completer.h: Fix common/ includes.
4827         * completer.c: Fix common/ includes.
4828         * compile/compile.c: Fix common/ includes.
4829         * compile/compile-loc2c.c: Fix common/ includes.
4830         * compile/compile-cplus-types.c: Fix common/ includes.
4831         * compile/compile-cplus-symbols.c: Fix common/ includes.
4832         * command.h: Fix common/ includes.
4833         * cli/cli-dump.c: Fix common/ includes.
4834         * cli/cli-cmds.c: Fix common/ includes.
4835         * charset.c: Fix common/ includes.
4836         * build-id.c: Fix common/ includes.
4837         * btrace.h: Fix common/ includes.
4838         * btrace.c: Fix common/ includes.
4839         * breakpoint.h: Fix common/ includes.
4840         * breakpoint.c: Fix common/ includes.
4841         * ax.h:
4842         (enum agent_op): Fix common/ includes.
4843         * ax-general.c (struct aop_map): Fix common/ includes.
4844         * ax-gdb.c: Fix common/ includes.
4845         * auxv.c: Fix common/ includes.
4846         * auto-load.c: Fix common/ includes.
4847         * arm-tdep.c: Fix common/ includes.
4848         * arch/riscv.c: Fix common/ includes.
4849         * arch/ppc-linux-common.c: Fix common/ includes.
4850         * arch/i386.c: Fix common/ includes.
4851         * arch/arm.c: Fix common/ includes.
4852         * arch/arm-linux.c: Fix common/ includes.
4853         * arch/arm-get-next-pcs.c: Fix common/ includes.
4854         * arch/amd64.c: Fix common/ includes.
4855         * arch/aarch64.c: Fix common/ includes.
4856         * arch/aarch64-insn.c: Fix common/ includes.
4857         * arch-utils.c: Fix common/ includes.
4858         * amd64-windows-tdep.c: Fix common/ includes.
4859         * amd64-tdep.c: Fix common/ includes.
4860         * amd64-sol2-tdep.c: Fix common/ includes.
4861         * amd64-obsd-tdep.c: Fix common/ includes.
4862         * amd64-nbsd-tdep.c: Fix common/ includes.
4863         * amd64-linux-tdep.c: Fix common/ includes.
4864         * amd64-linux-nat.c: Fix common/ includes.
4865         * amd64-fbsd-tdep.c: Fix common/ includes.
4866         * amd64-fbsd-nat.c: Fix common/ includes.
4867         * amd64-dicos-tdep.c: Fix common/ includes.
4868         * amd64-darwin-tdep.c: Fix common/ includes.
4869         * agent.c: Fix common/ includes.
4870         * ada-lang.h: Fix common/ includes.
4871         * ada-lang.c: Fix common/ includes.
4872         * aarch64-tdep.c: Fix common/ includes.
4873
4874 2019-01-25  Tom Tromey  <tom@tromey.com>
4875
4876         * common/create-version.sh: Use common/version.h.
4877
4878 2019-01-24  Pedro Alves  <palves@redhat.com>
4879
4880         * infrun.c (signal_stop, signal_print, signal_program)
4881         (signal_catch, signal_pass): Now arrays instead of pointers.
4882         (update_signals_program_target, do_target_resume)
4883         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4884         * linux-nat.c (linux_nat_target::pass_signals)
4885         (linux_nat_target::create_inferior, linux_nat_target::attach):
4886         Adjust.
4887         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4888         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4889         * procfs.c (procfs_target::pass_signals): Adjust.
4890         * record-full.c (record_full_target::resume): Adjust.
4891         * remote.c (remote_target::pass_signals)
4892         (remote_target::program_signals): Adjust.
4893         * target-debug.h (target_debug_print_signals): Now takes a
4894         gdb::array_view as parameter.  Adjust.
4895         * target.h (target_ops) <pass_signals, program_signals>: Replace
4896         pointer and length parameters with gdb::array_view.
4897         (target_pass_signals, target_program_signals): Likewise.
4898         * target-delegates.c: Regenerate.
4899
4900 2019-01-24  Pedro Alves  <palves@redhat.com>
4901
4902         * common/forward-scope-exit.h
4903         (forward_scope_exit::forward_scope_exit): Pass arguments to
4904         m_bind_function directly, instead of creating a std::bind and
4905         copying that.
4906
4907 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4908
4909         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4910         for static members.
4911         (pass_in_v_vfp_candidate): Likewise.
4912
4913 2019-01-23  Tom Tromey  <tom@tromey.com>
4914             Pedro Alves  <palves@redhat.com>
4915
4916         * regcache.c (class regcache_invalidator): Remove.
4917         (regcache::raw_write): Use make_scope_exit.
4918
4919 2019-01-23  Tom Tromey  <tom@tromey.com>
4920
4921         * ui-out.h (class ui_out_emit_type): Update comment.
4922
4923 2019-01-23  Tom Tromey  <tom@tromey.com>
4924
4925         * infrun.c (fetch_inferior_event): Update comment.
4926
4927 2019-01-23  Tom Tromey  <tom@tromey.com>
4928             Pedro Alves  <palves@redhat.com>
4929
4930         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4931         parameter.
4932         (fetch_inferior_event): Use SCOPE_EXIT.
4933
4934
4935 2019-01-23  Tom Tromey  <tom@tromey.com>
4936             Pedro Alves  <palves@redhat.com>
4937
4938         * infrun.c (disable_thread_events): Delete.
4939         (stop_all_threads): Use SCOPE_EXIT.
4940
4941 2019-01-23  Tom Tromey  <tom@tromey.com>
4942             Pedro Alves  <palves@redhat.com>
4943
4944         * symfile.c: Include forward-scope-exit.h.
4945         (clear_symtab_users_cleanup): Replace forward declaration with
4946         a FORWARD_SCOPE_EXIT.
4947         (syms_from_objfile_1): Use the forward_scope_exit and
4948         gdb::optional instead of cleanup_function.
4949         (reread_symbols): Use the forward_scope_exit instead of
4950         cleanup_function.
4951         (clear_symtab_users_cleanup): Remove function.
4952
4953 2019-01-23  Tom Tromey  <tom@tromey.com>
4954             Pedro Alves  <palves@redhat.com>
4955
4956         * linux-nat.c: Include scope-exit.h.
4957         (cleanup_target_stop): Remove.
4958         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4959         SCOPE_EXIT.
4960
4961 2019-01-23  Tom Tromey  <tom@tromey.com>
4962             Pedro Alves  <palves@redhat.com>
4963
4964         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4965         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4966
4967 2019-01-23  Tom Tromey  <tom@tromey.com>
4968             Andrew Burgess  <andrew.burgess@embecosm.com>
4969             Pedro Alves  <palves@redhat.com>
4970
4971         * infrun.c (fetch_inferior_event): Use scope_exit.
4972         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4973         * top.c (execute_command): Use scope_exit.
4974         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4975         * utils.c (do_bpstat_clear_actions_cleanup)
4976         (make_bpstat_clear_actions_cleanup): Remove.
4977
4978 2019-01-23  Tom Tromey  <tom@tromey.com>
4979             Pedro Alves  <palves@redhat.com>
4980
4981         * infrun.c: Include "common/scope-exit.h"
4982         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4983         (wait_for_inferior): Use SCOPE_EXIT.
4984         (fetch_inferior_event): Use scope_exit.
4985
4986 2019-01-23  Tom Tromey  <tom@tromey.com>
4987             Pedro Alves  <palves@redhat.com>
4988
4989         * breakpoint.c (create_breakpoint): Remove cleanup.
4990
4991 2019-01-23  Tom Tromey  <tom@tromey.com>
4992             Andrew Burgess  <andrew.burgess@embecosm.com>
4993             Pedro Alves  <palves@redhat.com>
4994
4995 2019-01-23  Pedro Alves  <palves@redhat.com>
4996
4997         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4998
4999 2019-01-23  Pedro Alves  <palves@redhat.com>
5000             Andrew Burgess  <andrew.burgess@embecosm.com>
5001
5002         * gdbthread.h: Include "common/forward-scope-exit.h".
5003         (scoped_finish_thread_state): Redefine custom class in terms of
5004         forward_scope_exit.
5005
5006 2019-01-23  Pedro Alves  <palves@redhat.com>
5007             Andrew Burgess  <andrew.burgess@embecosm.com>
5008
5009         * common/forward-scope-exit.h: New file.
5010
5011 2019-01-23  Pedro Alves  <palves@redhat.com>
5012             Andrew Burgess  <andrew.burgess@embecosm.com>
5013             Tom Tromey  <tom@tromey.com>
5014
5015         * common/scope-exit.h: New file.
5016
5017 2019-01-23  Pedro Alves  <palves@redhat.com>
5018
5019         * common/preprocessor.h (ESC): Rename to ...
5020         (ESC_PARENS): ... this.
5021         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5022         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5023
5024 2019-01-23  Tom Tromey  <tom@tromey.com>
5025
5026         * language.h (class scoped_switch_to_sym_language_if_auto):
5027         Initialize m_lang in both cases.
5028
5029 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5030
5031         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5032         with XCNEW.
5033
5034 2019-01-22  Tom Tromey  <tom@tromey.com>
5035
5036         * corelow.c: Do not include sys/file.h.
5037
5038 2019-01-22  Tom Tromey  <tom@tromey.com>
5039
5040         * tui/tui-wingeneral.h: Include gdb_curses.h.
5041
5042 2019-01-22  Tom Tromey  <tom@tromey.com>
5043
5044         * source-cache.h (class source_cache) <get_source_lines,
5045         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5046
5047 2019-01-22  Tom Tromey  <tom@tromey.com>
5048
5049         * remote-fileio.h (struct remote_target): Declare.
5050
5051 2019-01-22  Tom Tromey  <tom@tromey.com>
5052
5053         * python/py-arch.c: Do not include py-ref.h.
5054         * python/py-bpevent.c: Do not include py-ref.h.
5055         * python/py-cmd.c: Do not include py-ref.h.
5056         * python/py-continueevent.c: Do not include py-ref.h.
5057         * python/py-event.h: Do not include py-ref.h.
5058         * python/py-evtregistry.c: Do not include py-ref.h.
5059         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5060         * python/py-frame.c: Do not include py-ref.h.
5061         * python/py-framefilter.c: Do not include py-ref.h.
5062         * python/py-function.c: Do not include py-ref.h.
5063         * python/py-infevents.c: Do not include py-ref.h.
5064         * python/py-linetable.c: Do not include py-ref.h.
5065         * python/py-objfile.c: Do not include py-ref.h.
5066         * python/py-param.c: Do not include py-ref.h.
5067         * python/py-prettyprint.c: Do not include py-ref.h.
5068         * python/py-progspace.c: Do not include py-ref.h.
5069         * python/py-symbol.c: Do not include py-ref.h.
5070         * python/py-symtab.c: Do not include py-ref.h.
5071         * python/py-type.c: Do not include py-ref.h.
5072         * python/py-unwind.c: Do not include py-ref.h.
5073         * python/py-utils.c: Do not include py-ref.h.
5074         * python/py-value.c: Do not include py-ref.h.
5075         * python/py-varobj.c: Do not include py-ref.h.
5076         * python/py-xmethods.c: Do not include py-ref.h.
5077         * python/python.c: Do not include py-ref.h.
5078         * varobj.c: Do not include py-ref.h.
5079
5080 2019-01-22  Tom Tromey  <tom@tromey.com>
5081
5082         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5083         keyword for bcache.
5084
5085 2019-01-22  Tom Tromey  <tom@tromey.com>
5086
5087         * compile/compile-cplus-types.c: Remove a comment by #include.
5088
5089 2019-01-22  Tom Tromey  <tom@tromey.com>
5090
5091         * compile/gcc-c-plugin.h: Include compile-internal.h.
5092
5093 2019-01-22  Tom Tromey  <tom@tromey.com>
5094
5095         * stabsread.c (EXTERN): Do not define.
5096         (symnum, next_symbol_text_func, processing_gcc_compilation)
5097         (within_function, global_sym_chain, global_stabs)
5098         (previous_stab_code, this_object_header_files)
5099         (n_this_object_header_files)
5100         (n_allocated_this_object_header_files): Define.
5101         * stabsread.h (EXTERN): Never define.  Use "extern".
5102
5103 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5104
5105         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5106         history_value.
5107
5108 2019-01-21  Tom Tromey  <tom@tromey.com>
5109
5110         * ui-out.c: Fix includes.
5111         * tui/tui-source.c: Fix includes.
5112         * target.c: Fix includes.
5113         * remote.c: Fix includes.
5114         * regcache.c: Fix includes.
5115         * python/py-block.c: Fix includes.
5116         * printcmd.c: Fix includes.
5117         * or1k-tdep.c: Fix includes.
5118         * mi/mi-main.c: Fix includes.
5119         * m32r-tdep.c: Fix includes.
5120         * csky-tdep.c: Fix includes.
5121         * compile/compile-cplus-types.c: Fix includes.
5122         * cli/cli-interp.c: Fix includes.
5123
5124 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5125
5126         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5127         for padding.
5128
5129 2019-01-16  Tom Tromey  <tom@tromey.com>
5130
5131         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5132         earlier.
5133         (struct objfile) <msymbols_range>: Move from top level.
5134         <msymbols>: New method.
5135         (class objfile_msymbols): Remove.
5136         * symtab.c (default_collect_symbol_completion_matches_break_on):
5137         Update.
5138         * symmisc.c (dump_msymbols): Update.
5139         * stabsread.c (scan_file_globals): Update.
5140         * objc-lang.c (info_selectors_command, info_classes_command)
5141         (find_methods): Update.
5142         * minsyms.c (find_solib_trampoline_target): Update.
5143         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5144         * coffread.c (coff_symfile_read): Update.
5145         * ada-lang.c (ada_lookup_simple_minsym)
5146         (ada_collect_symbol_completion_matches): Update.
5147
5148 2019-01-16  Tom Tromey  <tom@tromey.com>
5149
5150         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5151         type.  Remove no-argument constructor.
5152         <iterator::operator++>: Simplify.
5153         <begin>: Update.
5154         <end>: Use minimal_symbol_count.
5155
5156 2019-01-16  Tom Tromey  <tom@tromey.com>
5157
5158         * objfiles.h (struct objfile) <psymtabs>: New method.
5159         (class objfile_psymtabs): Remove.
5160         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5161         typedef.
5162         <range>: New method.
5163         (require_partial_symbols): Change return type.
5164         * psymtab.c (require_partial_symbols)
5165         (psym_expand_symtabs_matching): Update.
5166         * mdebugread.c (parse_partial_symbols): Update.
5167         * dbxread.c (dbx_end_psymtab): Update.
5168
5169 2019-01-15  Tom Tromey  <tom@tromey.com>
5170
5171         * symtab.c (lookup_objfile_from_block)
5172         (lookup_symbol_in_objfile_symtabs)
5173         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5174         (find_line_symtab, info_sources_command)
5175         (default_collect_symbol_completion_matches_break_on)
5176         (make_source_files_completion_list): Update.
5177         * symmisc.c (print_objfile_statistics, dump_objfile)
5178         (maintenance_print_symbols, maintenance_info_symtabs)
5179         (maintenance_check_symtabs, maintenance_info_line_tables):
5180         Update.
5181         * source.c (select_source_symtab)
5182         (forget_cached_source_info_for_objfile): Update.
5183         * objfiles.h (class objfile_compunits): Remove.
5184         (struct objfile) <compunits_range>: New typedef.
5185         (compunits): New method.
5186         * objfiles.c (objfile_relocate1): Update.
5187         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5188         * maint.c (count_symtabs_and_blocks): Update.
5189         * linespec.c (iterate_over_all_matching_symtabs): Update.
5190         * cp-support.c (add_symbol_overload_list_qualified): Update.
5191         * coffread.c (coff_symtab_read): Update.
5192         * ada-lang.c (add_nonlocal_symbols)
5193         (ada_collect_symbol_completion_matches)
5194         (ada_add_global_exceptions): Update.
5195
5196 2019-01-15  Tom Tromey  <tom@tromey.com>
5197
5198         * progspace.h (program_space) <objfiles_safe_range>: New
5199         typedef.
5200         <objfiles_safe>: New method.
5201         * objfiles.h (class all_objfiles_safe): Remove.
5202         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5203         * jit.c (jit_inferior_exit_hook): Update.
5204
5205 2019-01-17  Tom Tromey  <tom@tromey.com>
5206
5207         * progspace.h (program_space) <objfiles_range>: New typedef.
5208         <objfiles>: New method.
5209         <objfiles_head>: Rename from objfiles.
5210         (object_files): Update.
5211         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5212         * guile/scm-pretty-print.c
5213         (ppscm_find_pretty_printer_from_objfiles): Update.
5214         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5215         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5216         Update.
5217         * python/py-progspace.c (pspy_get_objfiles): Update.
5218         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5219         Update.
5220         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5221         (objfpy_lookup_objfile_by_build_id): Update.
5222         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5223         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5224         Update.
5225         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5226         (expand_symtab_containing_pc, lookup_objfile_from_block)
5227         (lookup_static_symbol, basic_lookup_transparent_type)
5228         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5229         (find_line_symtab, info_sources_command)
5230         (default_collect_symbol_completion_matches_break_on)
5231         (make_source_files_completion_list, find_main_name): Update.
5232         * symmisc.c (print_symbol_bcache_statistics)
5233         (print_objfile_statistics, maintenance_print_symbols)
5234         (maintenance_print_msymbols, maintenance_print_objfiles)
5235         (maintenance_info_symtabs, maintenance_check_symtabs)
5236         (maintenance_expand_symtabs, maintenance_info_line_tables):
5237         Update.
5238         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5239         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5240         (map_overlay_command, unmap_overlay_command)
5241         (simple_overlay_update, expand_symtabs_matching)
5242         (map_symbol_filenames): Update.
5243         * symfile-debug.c (set_debug_symfile): Update.
5244         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5245         Update.
5246         * source.c (select_source_symtab, forget_cached_source_info):
5247         Update.
5248         * solib.c (solib_read_symbols): Update.
5249         * solib-spu.c (append_ocl_sos): Update.
5250         * psymtab.c (maintenance_print_psymbols)
5251         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5252         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5253         * printcmd.c (info_symbol_command): Update.
5254         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5255         Update.
5256         * objfiles.h (class all_objfiles): Remove.
5257         * objfiles.c (have_partial_symbols, have_full_symbols)
5258         (have_minimal_symbols, qsort_cmp, update_section_map)
5259         (shared_objfile_contains_address_p)
5260         (default_iterate_over_objfiles_in_search_order): Update.
5261         * objc-lang.c (info_selectors_command, info_classes_command)
5262         (find_methods): Update.
5263         * minsyms.c (find_solib_trampoline_target): Update.
5264         * maint.c (maintenance_info_sections)
5265         (maintenance_translate_address, count_symtabs_and_blocks):
5266         Update.
5267         * main.c (captured_main_1): Update.
5268         * linux-thread-db.c (try_thread_db_load_from_pdir)
5269         (has_libpthread): Update.
5270         * linespec.c (iterate_over_all_matching_symtabs)
5271         (search_minsyms_for_name): Update.
5272         * jit.c (jit_find_objf_with_entry_addr): Update.
5273         * hppa-tdep.c (find_unwind_entry)
5274         (hppa_lookup_stub_minimal_symbol): Update.
5275         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5276         Update.
5277         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5278         (elf_gnu_ifunc_resolve_by_got): Update.
5279         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5280         * dwarf-index-write.c (save_gdb_index_command): Update.
5281         * cp-support.c (add_symbol_overload_list_qualified): Update.
5282         * breakpoint.c (create_overlay_event_breakpoint)
5283         (create_longjmp_master_breakpoint)
5284         (create_std_terminate_master_breakpoint)
5285         (create_exception_master_breakpoint): Update.
5286         * blockframe.c (find_pc_partial_function): Update.
5287         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5288         (ada_collect_symbol_completion_matches)
5289         (ada_add_global_exceptions): Update.
5290
5291 2019-01-17  Tom Tromey  <tom@tromey.com>
5292
5293         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5294         declare VEC.
5295         (solib_target_parse_libraries): Change return type.
5296         (library_list_start_segment, library_list_start_section)
5297         (library_list_end_library, library_list_start_library); Update.
5298         (solib_target_free_library_list): Remove.
5299         (solib_target_parse_libraries): Remove cleanup.  Change return
5300         type.
5301         (solib_target_current_sos): Update.
5302
5303 2019-01-17  Tom Tromey  <tromey@bapiya>
5304
5305         * valprint.c: Replace "the the" with "the".
5306         * symtab.c: Replace "the the" with "the".
5307         * solib.c: Replace "the the" with "the".
5308         * solib-dsbt.c: Replace "the the" with "the".
5309         * linespec.c: Replace "the the" with "the".
5310         * dwarf2loc.h: Replace "the the" with "the".
5311         * amd64-windows-tdep.c: Replace "the the" with "the".
5312         * aarch64-tdep.c: Replace "the the" with "the".
5313
5314 2019-01-16  Keith Seitz  <keiths@redhat.com>
5315
5316         PR gdb/23773
5317         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5318         <builder>: Rename to ..
5319         <m_builder>: ... this and make private.
5320         (dwarf2_cu::get_builder): New method.  Change all users of
5321         `builder' to use this method.
5322         (dwarf2_start_symtab): Move to ...
5323         (dwarf2_cu::start_symtab): ... here.  Update all callers
5324         (setup_type_unit_groups): Move to ...
5325         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5326         callers.
5327         (dwarf2_cu::reset_builder): New method.
5328         (process_full_compunit, process_full_type_unit): Use
5329         dwarf2_cu::reset_builder.
5330         (follow_die_offset): Record the ancestor CU if it is different
5331         from the followed DIE's CU.
5332         (follow_die_sig_1): Likewise.
5333
5334 2019-01-15  Tom Tromey  <tom@tromey.com>
5335
5336         * remote.c (class remote_state) <buf>: Now a char_vector.
5337         <buf_size>: Remove.
5338         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5339         parameter.
5340         (remote_target::getpkt_or_notif_sane_1)
5341         (remote_target::getpkt_sane)
5342         (remote_target::getpkt_or_notif_sane): Likewise.
5343         (class remote_target) <putpkt>: New overload.
5344         (remote_target::read_frame): Change type of "buf_p".  Remove
5345         sizeof_p parameter.
5346         (packet_ok): New overload.
5347         (packet_check_result): New overload.
5348         Update all uses.
5349
5350 2019-01-14  Tom Tromey  <tom@tromey.com>
5351
5352         * remote-notif.c (handle_notification, remote_notif_ack)
5353         (remote_notif_parse): Make "buf" const.
5354         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5355         const.
5356         (remote_notif_parse, remote_notif_ack, handle_notification):
5357         Likewise.
5358         * remote.c (remote_notif_stop_parse): Make "buf" const.
5359         (remote_target::remote_parse_stop_reply): Make "buf" const.
5360         (remote_notif_stop_ack): Make "buf" const.
5361
5362 2019-01-14  Tom Tromey  <tom@tromey.com>
5363
5364         * remote.c (remote_console_output): Make parameter const.
5365
5366 2019-01-14  Tom Tromey  <tom@tromey.com>
5367
5368         * target-debug.h (target_debug_print_signals): Constify.
5369         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5370         * procfs.c (procfs_target::pass_signals): Update.
5371         * linux-nat.c (linux_nat_target::pass_signals): Update.
5372         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5373         * target-delegates.c: Rebuild.
5374         * remote.c (remote_target::program_signals): Update.
5375         (remote_target::pass_signals): Update.
5376         * target.c (target_pass_signals): Constify argument.
5377         (target_program_signals): Likewise.
5378         * target.h (struct target_ops) <pass_signals, program_signals>:
5379         Constify argument.
5380         (target_pass_signals, target_program_signals): Constify argument.
5381
5382 2019-01-14  Tom Tromey  <tom@tromey.com>
5383
5384         PR tui/28819:
5385         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5386
5387 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5388
5389         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5390         field.
5391         * rs6000-tdep.c: Include reggroups.h.
5392         (IS_V_ALIAS_PSEUDOREG): Define.
5393         (rs6000_register_name): Return names for the "vX" aliases.
5394         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5395         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5396         aliases.  Call default_register_reggroup_p for all other
5397         pseudo-registers.
5398         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5399         New functions.
5400         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5401         Handle "vX" aliases.
5402         (v_alias_pseudo_register_collect): New function.
5403         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5404         (rs6000_gdbarch_init): Initialize "vX" aliases as
5405         pseudo-registers.  Restore registration of
5406         rs6000_pseudo_register_reggroup_p with
5407         set_tdesc_pseudo_register_reggroup_p.
5408
5409 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5410
5411         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5412         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5413         set_gdbarch_num_pseudo_regs.
5414
5415 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5416
5417         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5418         Remove arg prefixname, add do_set and do_show.
5419         Add member functions set_list and show_list.
5420         * cli/cli-style.c (class cli_style_option): Update accordingly.
5421         (style_set_list): Move to file scope.
5422         (style_show_list): Likewise.
5423         (set_style): Call help_list.
5424         (show_style): Call cmd_show_list.
5425         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5426         Update to use the new macro.
5427
5428 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5429
5430         * ada-lang.c (_initialize_ada_language): Expand the help text
5431         for the "catch exception" command.
5432
5433 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5434
5435         * symtab.c (matching_obj_sections): Initialize obj,
5436         declare it closer to its usage.
5437
5438 2019-01-10  Tom Tromey  <tom@tromey.com>
5439
5440         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5441         (basic_inf_threads_range): Remove.
5442         (inf_threads_range, inf_non_exited_threads_range)
5443         (safe_inf_threads_range): Use next_adapter.
5444
5445 2019-01-10  Keith Seitz  <keiths@redhat.com>
5446
5447         PR gdb/23712
5448         PR symtab/23010
5449         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5450         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5451
5452 2019-01-10  Keith Seitz  <keiths@redhat.com>
5453
5454         PR gdb/23712
5455         PR symtab/23010
5456         * dictionary.c (pending_to_vector): Remove.
5457         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5458         Remove _1 suffix, replacing functions of the same name.  Update
5459         all callers.
5460         (dict_create_hashed, dict_create_hashed_expandable)
5461         (dict_create_linear, dict_create_linear_expandable, dict_free)
5462         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5463         Make functions static.
5464
5465 2019-01-10  Keith Seitz  <keiths@redhat.com>
5466
5467         PR gdb/23712
5468         PR symtab/23010
5469         * dictionary.h (struct dictionary): Replace declaration with
5470         multidictionary.
5471         (dict_create_hashed, dict_create_hashed_expandable)
5472         (dict_create_linear, dict_create_linear_expandable)
5473         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5474         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5475         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5476         taking multidictionary argument.
5477         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5478         * block.h (struct block) <dict>: Change to multidictionary
5479         and rename `multidict'.
5480         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5481         symmisc.c: Update all dictionary references to multidictionary.
5482
5483 2019-01-10  Keith Seitz  <keiths@redhat.com>
5484
5485         PR gdb/23712
5486         PR symtab/23010
5487         * dictionary.c: Include unordered_map.
5488         (pending_to_vector): New function.
5489         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5490         Rewrite the non-"_1" functions to take vector instead
5491         of linked list.
5492         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5493         "new" _1 versions of the same name.
5494         (multidictionary): Define.
5495         (std::hash<enum language): New definition.
5496         (collate_pending_symbols_by_language, mdict_create_hashed)
5497         (mdict_create_hashed_expandable, mdict_create_linear)
5498         (mdict_create_linear_expandable, mdict_free)
5499         (find_language_dictionary, create_new_language_dictionary)
5500         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5501         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5502         (mdict_size, mdict_empty): New functions.
5503         * dictionary.h (mdict_iterator): Define.
5504
5505 2019-01-10  Pedro Alves  <palves@redhat.com>
5506
5507         * breakpoint.c (read_uploaded_action)
5508         (create_tracepoint_from_upload): Adjust to use
5509         gdb::unique_xmalloc_ptr.
5510         * ctf.c (ctf_write_uploaded_tp):
5511         (SET_ARRAY_FIELD): Use emplace_back.
5512         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5513         * tracefile-tfile.c (tfile_write_uploaded_tp):
5514         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5515         gdb::unique_xmalloc_ptr.
5516         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5517         at_string, cond_string, cmd_strings>: Replace char pointers
5518         with gdb::unique_xmalloc_ptr.
5519
5520 2019-01-10  Pedro Alves  <palves@redhat.com>
5521
5522         * solib-target.c (library_list_start_library): Don't xstrdup name.
5523
5524 2019-01-10  Pedro Alves  <palves@redhat.com>
5525
5526         * mdebugread.c (parse_partial_symbols): Use
5527         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5528
5529 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5530
5531         * linux-fork.c (scoped_switch_fork_info)
5532         <~scoped_switch_fork_info>: Fix incorrect variable name.
5533
5534 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5535
5536         * linux-fork.c (scoped_switch_fork_info)
5537         <scoped_switch_fork_info>: Make explicit.
5538         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5539
5540 2019-01-10  Tom Tromey  <tom@tromey.com>
5541
5542         * objfiles.h (objfile::reset_psymtabs): Update.
5543         * objfiles.c (objfile::objfile): Update.
5544         * psymtab.h (psymtab_storage::obstack): Update.
5545         (psymtab_storage::m_obstack): Use gdb::optional.
5546         (class psymtab_storage): Update comment.  Remove objfile
5547         parameter.
5548         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5549
5550 2019-01-10  Tom Tromey  <tom@tromey.com>
5551
5552         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5553         <free_psymtabs>: Now private.
5554         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5555         (allocate_psymtab): Use new method.
5556
5557 2019-01-10  Tom Tromey  <tom@tromey.com>
5558
5559         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5560         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5561         * mdebugread.c (parse_partial_symbols): Use
5562         allocate_dependencies.
5563         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5564         allocate_dependencies.
5565         (process_psymtab_comp_unit_reader)
5566         (build_type_psymtab_dependencies): Likewise.
5567         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5568
5569 2019-01-10  Tom Tromey  <tom@tromey.com>
5570
5571         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5572         PSYMBOL_SET_LANGUAGE.
5573         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5574
5575 2019-01-10  Tom Tromey  <tom@tromey.com>
5576
5577         * psymtab.h (psymtab_storage::obstack): New method.
5578         <m_obstack>: Rename from obstack; now private.
5579         * psymtab.c (psymtab_storage): Update.
5580         * dwarf2read.c (create_addrmap_from_index)
5581         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5582         Update.
5583
5584 2019-01-10  Tom Tromey  <tom@tromey.com>
5585
5586         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5587         * objfiles.h (objfile::reset_psymtabs): New method.
5588
5589 2019-01-10  Tom Tromey  <tom@tromey.com>
5590
5591         * symmisc.c (print_symbol_bcache_statistics): Update.
5592         (print_objfile_statistics): Update.
5593         * symfile.c (reread_symbols): Update.
5594         * psymtab.h (class psymtab_storage): New.
5595         * psymtab.c (psymtab_storage): New constructor.
5596         (~psymtab_storage): New destructor.
5597         (require_partial_symbols): Update.
5598         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5599         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5600         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5601         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5602         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5603         (start_psymtab_common, end_psymtab_common)
5604         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5605         (allocate_psymtab): Update.
5606         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5607         Update.
5608         (dump_psymtab_addrmap, maintenance_print_psymbols)
5609         (maintenance_check_psymtabs): Update.
5610         (class objfile_psymtabs): Move to objfiles.h.
5611         * psympriv.h (discard_psymtab): Now inline.
5612         (psymtab_discarder::psymtab_discarder): Update.
5613         (psymtab_discarder::~psymtab_discarder): Update.
5614         (ALL_OBJFILE_PSYMTABS): Rewrite.
5615         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5616         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5617         Remove fields.
5618         <partial_symtabs>: New field.
5619         (class objfile_psymtabs): Move from psymtab.h.  Update.
5620         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5621         psymbol_cache.
5622         (objfile::~objfile): Don't destroy psymbol_cache.
5623         * mdebugread.c (parse_partial_symbols): Update.
5624         * dwarf2read.c (create_addrmap_from_index)
5625         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5626         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5627         (add_partial_subprogram, dwarf2_ranges_read): Update.
5628         * dwarf-index-write.c (write_address_map)
5629         (write_one_signatured_type, recursively_write_psymbols)
5630         (class debug_names, class debug_names, write_psymtabs_to_index):
5631         Update.
5632
5633 2019-01-10  Tom Tromey  <tom@tromey.com>
5634
5635         * symtab.h (SYMBOL_SET_NAMES): Update.
5636         (symbol_set_names): Update.
5637         (MSYMBOL_SET_NAMES): Update.
5638         * symtab.c (symbol_set_names): Change argument to be an
5639         objfile_per_bfd_storage.
5640         * psymtab.c (add_psymbol_to_bcache): Update.
5641         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5642
5643 2019-01-10  Tom Tromey  <tom@tromey.com>
5644
5645         * symtab.c (create_demangled_names_hash): Change argument to be an
5646         objfile_per_bfd_storage.
5647         (symbol_set_names): Update.
5648
5649 2019-01-10  Tom Tromey  <tom@tromey.com>
5650
5651         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5652         init_psymbol_list.
5653         * psymtab.c (init_psymbol_list): Do nothing if already called.
5654         * psympriv.h (init_psymbol_list): Add comment.
5655         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5656         init_psymbol_list.
5657         * dbxread.c (dbx_symfile_read): Unconditionally call
5658         init_psymbol_list.
5659
5660 2019-01-10  Tom Tromey  <tom@tromey.com>
5661
5662         * xcoffread.c (scan_xcoff_symtab): Update.
5663         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5664         "where".
5665         * mdebugread.c (parse_partial_symbols)
5666         (handle_psymbol_enumerators): Update.
5667         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5668         * dbxread.c (read_dbx_symtab): Update.
5669         * psympriv.h (psymbol_placement): New enum.
5670         (add_psymbol_to_list): Update.
5671
5672 2019-01-10  Tom Tromey  <tom@tromey.com>
5673
5674         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5675         static_psymbols parameters.
5676         (scan_xcoff_symtab): Update.
5677         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5678         static_psymbols parameters.
5679         * psympriv.h (start_psymtab_common): Update.
5680         * mdebugread.c (parse_partial_symbols): Update.
5681         * dwarf2read.c (create_partial_symtab): Update.
5682         * dbxread.c (read_dbx_symtab): Update.
5683         (start_psymtab): Remove global_psymbols and static_psymbols
5684         parameters.
5685
5686 2019-01-10  Tom Tromey  <tom@tromey.com>
5687
5688         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5689         * psymtab.c (allocate_psymtab): Add comment.
5690         * psympriv.h (allocate_psymtab): Add comment.
5691         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5692         initializations.
5693         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5694
5695 2019-01-10  Tom Tromey  <tom@tromey.com>
5696
5697         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5698         Don't declare.
5699         * mipsread.c: Include mdebugread.h.
5700         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5701         Declare.
5702         * elfread.c: Include mdebugread.h.
5703
5704 2019-01-09  Tom Tromey  <tom@tromey.com>
5705
5706         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5707         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5708         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5709         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5710         (psym_lookup_symbol, psym_find_last_source_symtab)
5711         (psym_forget_cached_source_info, psym_print_stats)
5712         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5713         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5714         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5715         (psym_find_compunit_symtab_by_address)
5716         (maintenance_print_psymbols, maintenance_info_psymtabs)
5717         (maintenance_check_psymtabs): Use ranged for.
5718         * psymtab.h (class objfile_psymtabs): New.
5719         (require_partial_symbols): Return objfile_psymtabs.
5720         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5721
5722 2019-01-09  Tom Tromey  <tom@tromey.com>
5723
5724         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5725         (find_pc_mapped_section, list_overlays_command)
5726         (map_overlay_command, unmap_overlay_command)
5727         (simple_overlay_update): Use all_objfiles.
5728         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5729         * printcmd.c (info_symbol_command): Use all_objfiles.
5730         * objfiles.h (ALL_OBJSECTIONS): Remove.
5731         * maint.c (maintenance_translate_address): Use all_objfiles.
5732         * gcore.c (gcore_create_callback): Use all_objfiles.
5733         (objfile_find_memory_regions): Likewise.
5734
5735 2019-01-09  Tom Tromey  <tom@tromey.com>
5736
5737         * symtab.c (find_line_symtab, info_sources_command)
5738         (make_source_files_completion_list): Use objfile_compunits.
5739         * source.c (select_source_symtab): Use objfile_compunits.
5740         * objfiles.h (struct objfile): Update comment.
5741         (ALL_OBJFILES): Remove.
5742         (ALL_FILETABS): Remove.
5743         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5744         objfile_compunits.
5745
5746 2019-01-09  Tom Tromey  <tom@tromey.com>
5747
5748         * symmisc.c (print_objfile_statistics, dump_objfile)
5749         (maintenance_print_symbols): Use compunit_filetabs.
5750         * source.c (forget_cached_source_info_for_objfile): Use
5751         compunit_filetabs.
5752         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5753         (ALL_FILETABS): Use compunit_filetabs.
5754         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5755         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5756
5757 2019-01-09  Tom Tromey  <tom@tromey.com>
5758
5759         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5760         (compunit_filetabs): New.
5761         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5762         compunit_filetabs.
5763         (info_sources_command, make_source_files_completion_list): Remove
5764         declaration.
5765         * symmisc.c (print_objfile_statistics, dump_objfile)
5766         (maintenance_print_symbols): Remove declaration.
5767         (maintenance_info_symtabs): Use compunit_filetabs.
5768         (maintenance_info_line_tables): Likewise.
5769         * source.c (select_source_symtab): Change local variable name.
5770         (forget_cached_source_info_for_objfile): Remove declaration.
5771         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5772         * objfiles.c (objfile_relocate1): Remove declaration.
5773         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5774         declaration.
5775         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5776         * coffread.c (coff_symtab_read): Remove declaration.
5777         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5778         compunit_filetabs.
5779
5780 2019-01-09  Tom Tromey  <tom@tromey.com>
5781
5782         * symtab.c (lookup_objfile_from_block)
5783         (find_pc_sect_compunit_symtab, search_symbols)
5784         (default_collect_symbol_completion_matches_break_on): Use
5785         objfile_compunits.
5786         * objfiles.h (ALL_COMPUNITS): Remove.
5787         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5788         * cp-support.c (add_symbol_overload_list_qualified): Use
5789         objfile_compunits.
5790         * ada-lang.c (ada_collect_symbol_completion_matches)
5791         (ada_add_global_exceptions): Use objfile_compunits.
5792
5793 2019-01-09  Tom Tromey  <tom@tromey.com>
5794
5795         * source.c (select_source_symtab)
5796         (forget_cached_source_info_for_objfile): Remove declaration.
5797         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5798         declaration.
5799         * maint.c (count_symtabs_and_blocks): Remove declaration.
5800         * cp-support.c (add_symbol_overload_list_qualified): Remove
5801         declaration.
5802         * coffread.c (coff_symtab_read): Remove declaration.
5803         * symtab.c (lookup_symbol_in_objfile_symtabs)
5804         (basic_lookup_transparent_type_1): Use objfile_compunits.
5805         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5806         (info_sources_command, search_symbols)
5807         (default_collect_symbol_completion_matches_break_on)
5808         (make_source_files_completion_list): Remove declaration.
5809         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5810         (ada_collect_symbol_completion_matches)
5811         (ada_add_global_exceptions): Remove declaration.
5812         * linespec.c (iterate_over_all_matching_symtabs): Use
5813         objfile_compunits.
5814         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5815         (class objfile_compunits): New.
5816         (ALL_COMPUNITS): Use objfile_compunits.
5817         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5818         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5819         objfile_compunits.
5820         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5821
5822 2019-01-09  Tom Tromey  <tom@tromey.com>
5823
5824         * symtab.c (search_symbols)
5825         (default_collect_symbol_completion_matches_break_on): Use
5826         objfile_msymbols.
5827         * ada-lang.c (ada_lookup_simple_minsym)
5828         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5829         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5830         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5831         objfile_msymbols.
5832         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5833         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5834         * objc-lang.c (find_methods): Use objfile_msymbols.
5835         (info_selectors_command, info_classes_command): Likewise.
5836         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5837         * objfiles.h (class objfile_msymbols): New.
5838         (ALL_OBJFILE_MSYMBOLS): Remove.
5839         (ALL_MSYMBOLS): Remove.
5840
5841 2019-01-09  Tom Tromey  <tom@tromey.com>
5842
5843         * common/next-iterator.h (next_adapter): Add Iterator template
5844         parameter.
5845         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5846         (class all_objfiles_safe): New.
5847         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5848         * objfiles.c (put_objfile_before): Update comment.
5849         (add_separate_debug_objfile): Likewise.
5850         (free_all_objfiles): Use all_objfiles_safe.
5851         (objfile_purge_solibs): Likewise.
5852
5853 2019-01-09  Tom Tromey  <tom@tromey.com>
5854
5855         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5856         (expand_symtab_containing_pc, lookup_static_symbol)
5857         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5858         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5859         all_objfiles.
5860         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5861         * breakpoint.c (create_overlay_event_breakpoint)
5862         (create_longjmp_master_breakpoint)
5863         (create_std_terminate_master_breakpoint)
5864         (create_exception_master_breakpoint): Use all_objfiles.
5865         * linux-thread-db.c (try_thread_db_load_from_pdir)
5866         (has_libpthread): Use all_objfiles.
5867         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5868         * linespec.c (iterate_over_all_matching_symtabs)
5869         (search_minsyms_for_name): Use all_objfiles.
5870         * maint.c (maintenance_info_sections): Use all_objfiles.
5871         * main.c (captured_main_1): Use all_objfiles.
5872         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5873         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5874         * guile/scm-pretty-print.c
5875         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5876         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5877         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5878         (maintenance_print_msymbols): Use all_objfiles.
5879         * source.c (select_source_symtab): Use all_objfiles.
5880         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5881         * symfile.c (remove_symbol_file_command)
5882         (expand_symtabs_matching, map_symbol_filenames): Use
5883         all_objfiles.
5884         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5885         all_objfiles.
5886         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5887         * objc-lang.c (find_methods): Use all_objfiles.
5888         * objfiles.c (have_partial_symbols, have_full_symbols)
5889         (have_minimal_symbols, qsort_cmp)
5890         (default_iterate_over_objfiles_in_search_order): Use
5891         all_objfiles.
5892         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5893         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5894         (maintenance_check_psymtabs): Use all_objfiles.
5895         (ALL_PSYMTABS): Remove.
5896         * compile/compile-object-run.c (do_module_cleanup): Use
5897         all_objfiles.
5898         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5899         * cp-support.c (add_symbol_overload_list_qualified): Use
5900         all_objfiles.
5901         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5902         Use all_objfiles.
5903         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5904         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5905         all_objfiles.
5906         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5907         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5908         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5909         Uses all_objfiles.
5910         * solib.c (solib_read_symbols): Use all_objfiles
5911
5912 2019-01-09  Tom Tromey  <tom@tromey.com>
5913
5914         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5915         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5916         all_objfiles.
5917         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5918         * symmisc.c (print_symbol_bcache_statistics)
5919         (print_objfile_statistics, maintenance_print_objfiles)
5920         (maintenance_info_symtabs, maintenance_check_symtabs)
5921         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5922         all_objfiles.
5923         * source.c (forget_cached_source_info): Use all_objfiles.
5924         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5925         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5926         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5927         * objfiles.c (update_section_map): Use all_objfiles.
5928         (shared_objfile_contains_address_p): Likewise.
5929         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5930         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5931
5932 2019-01-09  Tom Tromey  <tom@tromey.com>
5933
5934         * common/next-iterator.h: New file.
5935         * objfiles.h (class all_objfiles): New.
5936         (struct objfile_iterator): New.
5937
5938 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5939
5940         * NEWS: Move the description of the changed "frame", "select-frame",
5941          and "info frame" commands to the Changed commands section.
5942
5943 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5944
5945         * gdbtypes.c (check_stub_method_group): Remove handling of old
5946         mangling schemes.
5947         * linespec.c (find_methods): Likewise.
5948         * stabsread.c (read_member_functions): Likewise.
5949         * valops.c (search_struct_method): Likewise.
5950         (value_struct_elt_for_reference): Likewise.
5951         * NEWS: Mention this change.
5952
5953 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5954
5955         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5956         print_source_lines.
5957         * source.c (print_source_lines_base): Update line number check.
5958         (print_source_lines): New function.
5959         (source_lines_range::source_lines_range): New function.
5960         * source.h (class source_lines_range): New class.
5961         (print_source_lines): New declaration.
5962
5963 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5964
5965         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5966
5967 2019-01-08  Tom Tromey  <tom@tromey.com>
5968             Simon Marchi  <simon.marchi@ericsson.com>
5969
5970         PR gdb/24060
5971         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5972         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5973         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5974         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5975         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5976         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5977
5978 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5979
5980         * source.c (select_source_symtab): Move header comment to
5981         declaration in source.h.
5982         (forget_cached_source_info_for_objfile): Likewise.
5983         (forget_cached_source_info): Likewise.
5984         (identify_source_line): Likewise.
5985         * source.h (identify_source_line): Move declaration from symtab.h
5986         and add comment from source.c
5987         (print_source_lines): Likewise.
5988         (forget_cached_source_info_for_objfile): Likewise.
5989         (forget_cached_source_info): Likewise.
5990         (select_source_symtab): Likewise.
5991         (enum print_source_lines_flag): Move definition from symtab.h.
5992         * symtab.h (identify_source_line): Move declaration to source.h.
5993         (print_source_lines): Likewise.
5994         (forget_cached_source_info_for_objfile): Likewise.
5995         (forget_cached_source_info): Likewise.
5996         (select_source_symtab): Likewise.
5997         (enum print_source_lines_flag): Move definition to source.h.
5998         * tui/tui-hooks.c: Add 'source.h' include.
5999
6000 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6001
6002         * source.c (print_source_lines_base): Handle requests to print
6003         reverse line number sequences, and guard against empty lines
6004         string.
6005
6006 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6007
6008         * source.c (print_source_lines_base): Fix skip of '\r' if next
6009         character is '\n'.
6010
6011 2019-01-06  Tom Tromey  <tom@tromey.com>
6012
6013         * c-exp.y (struct c_parse_state) <macro_original_text,
6014         expansion_obstack>: New member.
6015         (macro_original_text, expansion_obstack): Remove globals.
6016         (scan_macro_expansion, scanning_macro_expansion)
6017         (finished_macro_expansion): Update.
6018         (scan_macro_cleanup): Remove.
6019         (yylex, c_parse): Update.
6020
6021 2019-01-06  Tom Tromey  <tom@tromey.com>
6022
6023         * c-exp.y (struct c_parse_state) <strings>: New member.
6024         (operator_stoken): Update.
6025
6026 2019-01-06  Tom Tromey  <tom@tromey.com>
6027
6028         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6029         (union type_stack_elt) <typelist_val>: Now a pointer to
6030         std::vector.
6031         (type_stack_cleanup): Don't declare.
6032         (push_typelist): Update.
6033         * parse.c (pop_typelist): Return a std::vector.
6034         (push_typelist): Take a std::vector.
6035         (follow_types): Update.  Do not free args.
6036         (type_stack_cleanup): Remove.
6037         * c-exp.y (struct c_parse_state): New.
6038         (cpstate): New global.
6039         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6040         (nonempty_typelist): Update.
6041         (func_mod): Create a new vector.
6042         (c_parse): Create a c_parse_state.
6043         (check_parameter_typelist): Do not delete params.
6044         (function_method): Update.  Do not delete type_list.
6045
6046 2019-01-06  Tom Tromey  <tom@tromey.com>
6047
6048         PR gdb/28155:
6049         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6050         check_typedef.
6051         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6052         (print_return_value): Likewise.
6053
6054 2019-01-05  Tom Tromey  <tom@tromey.com>
6055
6056         * contrib/cleanup_check.py: Remove.
6057         * contrib/gcc-with-excheck: Remove.
6058         * contrib/exsummary.py: Remove.
6059         * contrib/excheck.py: Remove.
6060
6061 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6062
6063         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6064         NULL. Initialize tpprev to NULL instead of assigning it
6065         to NULL on the next statement.
6066         * windows-nat.c (windows_delete_thread): Remove check for
6067         main_thread_id before printing thread exit notifications.
6068         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6069         Remove thread ID check against main_thread_id.
6070         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6071         windows_delete_thread.
6072         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6073
6074 2019-01-04  Tom Tromey  <tom@tromey.com>
6075
6076         * compile/compile.c (_initialize_compile): Use upper case for
6077         metasyntactic variables.
6078         * symmisc.c (_initialize_symmisc): Use upper case for
6079         metasyntactic variables.
6080         * psymtab.c (_initialize_psymtab): Use upper case for
6081         metasyntactic variables.
6082         * demangle.c (demangle_command): Use upper case for metasyntactic
6083         variables.
6084         (_initialize_demangler): Likewise.
6085         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6086         variables.
6087
6088 2019-01-03  Tom Tromey  <tom@tromey.com>
6089
6090         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6091
6092 2019-01-03  Tom Tromey  <tom@tromey.com>
6093
6094         * python/py-symtab.c (salpy_str): Update.
6095         (struct salpy_sal_object) <symtab>: Now a PyObject.
6096         (salpy_dealloc): Update.
6097         (del_objfile_sal): Use gdbpy_ref.
6098
6099 2019-01-03  Tom Tromey  <tom@tromey.com>
6100
6101         * python/py-type.c (convert_field): Use new_reference.  Return
6102         gdbpy_ref.
6103         (make_fielditem): Return gdbpy_ref.
6104         (typy_fields): Update.
6105         (typy_getitem): Update.
6106         (field_name): Return gdbpy_ref.  Use new_reference.
6107         (typy_iterator_iternext): Update.
6108
6109 2019-01-03  Tom Tromey  <tom@tromey.com>
6110
6111         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6112
6113 2019-01-03  Tom Tromey  <tom@tromey.com>
6114
6115         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6116         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6117         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6118         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6119         (pspy_set_type_printers): Likewise.
6120         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6121         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6122         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6123         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6124         (objfpy_set_type_printers): Likewise.
6125
6126 2019-01-03  Tom Tromey  <tom@tromey.com>
6127
6128         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6129         (gdbpy_print_stack): Use gdbpy_err_fetch.
6130         * python/python-internal.h (class gdbpy_err_fetch): New class.
6131         (class gdbpy_enter) <m_error_type, m_error_value,
6132         m_error_traceback>: Remove.
6133         <m_error>: New member.
6134         (gdbpy_exception_to_string): Don't declare.
6135         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6136         * python/py-value.c (convert_value_from_python): Use
6137         gdbpy_err_fetch.
6138         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6139         gdbpy_exception_to_string.
6140         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6141         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6142         gdbpy_err_fetch.
6143
6144 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6145
6146         * linux-nat.c (delete_lwp_cleanup): Delete.
6147         (struct lwp_deleter): New struct.
6148         (lwp_info_up): New typedef.
6149         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6150         lwp_info_up.
6151
6152 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6153
6154         * linux-fork.c (class scoped_switch_fork_info): New class.
6155         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6156
6157 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6158
6159         * valops.c (find_overload_match): Remove use of null_cleanup, and
6160         calls to do_cleanups.
6161
6162 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6163
6164         * compile/compile-cplus-types.c
6165         (compile_cplus_instance::decl_name): Handle changes to
6166         cp_func_name.
6167         * cp-support.c (cp_func_name): Update header comment, update
6168         return type.
6169         * cp-support.h (cp_func_name): Update return type in declaration.
6170         * valops.c (find_overload_match): Move temp_func local to top
6171         level of function and change its type.  Use temp_func to hold and
6172         delete temporary string obtained from cp_func_name.
6173
6174 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6175
6176         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6177         gdb::char_vector, remove cleanup, and update uses of `msg`.
6178
6179 2019-01-03  Jim Wilson  <jimw@sifive.com>
6180
6181         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6182
6183 2019-01-02  Tom Tromey  <tom@tromey.com>
6184
6185         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6186         (tdesc_parse_xml): Remove cleanups.
6187         * target-descriptions.h (make_cleanup_free_target_description):
6188         Don't declare.
6189         (target_desc_deleter): New struct.
6190         (target_desc_up): New typedef.
6191         * target-descriptions.c (target_desc_deleter::operator()): Rename
6192         from free_target_description.
6193         (make_cleanup_free_target_description): Remove.
6194
6195 2019-01-02  Tom Tromey  <tom@tromey.com>
6196
6197         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6198         constructor, destructor.
6199         (linespec_parser): Remove typedef.
6200         (~linespec_parser): Rename from linespec_parser_delete.
6201         (linespec_lex_to_end, linespec_complete_label)
6202         (linespec_complete): Update.
6203         (decode_line_full): Remove cleanups.
6204         (decode_line_1): Update.
6205
6206 2019-01-02  Tom Tromey  <tom@tromey.com>
6207
6208         * python/python-internal.h (inferior_to_inferior_object): Change
6209         return type.
6210         * python/py-exitedevent.c (create_exited_event_object): Update.
6211         * python/py-inferior.c (inferior_to_inferior_object): Return
6212         gdbpy_ref.
6213         (python_new_inferior, python_inferior_deleted)
6214         (thread_to_thread_object, delete_thread_object)
6215         (build_inferior_list, gdbpy_selected_inferior): Update.
6216         * python/py-infthread.c (create_thread_object): Update.  Also fail
6217         if inferior_to_inferior_object fails.
6218
6219 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6220
6221         * inferior.h (class inferior) <displaced_step_state>: New field.
6222         * infrun.h (struct displaced_step_state): Move here from
6223         infrun.c.  Initialize fields, add constructor.
6224         <inf>: Remove field.
6225         <reset>: New method.
6226         * infrun.c (struct displaced_step_inferior_state): Move to
6227         infrun.h.
6228         (displaced_step_inferior_states): Remove.
6229         (get_displaced_stepping_state): Adust.
6230         (displaced_step_in_progress_any_inferior): Adjust.
6231         (displaced_step_in_progress_thread): Adjust.
6232         (displaced_step_in_progress): Adjust.
6233         (add_displaced_stepping_state): Remove.
6234         (get_displaced_step_closure_by_addr): Adjust.
6235         (remove_displaced_stepping_state): Remove.
6236         (infrun_inferior_exit): Call displaced_step_state.reset.
6237         (use_displaced_stepping): Don't check for NULL.
6238         (displaced_step_prepare_throw): Call
6239         get_displaced_stepping_state.
6240         (displaced_step_fixup): Don't check for NULL.
6241         (prepare_for_detach): Don't check for NULL.
6242
6243 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6244
6245         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6246          in case of call that did not complete.
6247
6248 2019-01-02  Andrey Utkin  <autkin@undo.io>
6249
6250         * symfile.c (find_separate_debug_file): Fix search of debug files for
6251         remote debuggee.
6252
6253 2019-01-02  Tom Tromey  <tom@tromey.com>
6254
6255         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6256         indentation.
6257         * python/py-frame.c (frapy_older): Remove cast.
6258         (frapy_newer): Likewise.
6259         * python/py-breakpoint.c (local_setattro): Remove cast.
6260         * python/py-arch.c (archpy_name): Remove local variable.
6261         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6262
6263 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6264
6265         * unittests/basic_string_view/element_access/char/empty.cc:
6266         Fix year range in copyright header.
6267
6268 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6269
6270         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6271         Delete.
6272         <operator==>: Update with for removed field.
6273         <hash>: Likewise.
6274         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6275         <isa_features>: ...this.
6276         <abi_features>: New field.
6277         (riscv_isa_flen): Update comment.
6278         (riscv_abi_xlen): New declaration.
6279         (riscv_abi_flen): New declaration.
6280         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6281         isa_features.
6282         (riscv_abi_xlen): New function.
6283         (riscv_isa_flen): Update to get answer from isa_features.
6284         (riscv_abi_flen): New function.
6285         (riscv_has_fp_abi): Update to get answer from abi_features.
6286         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6287         xlen and flen.
6288         (riscv_call_info) <xlen, flen>: Update comment.
6289         (riscv_call_arg_struct): Remove invalid assertions
6290         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6291         is removed.
6292         (riscv_gdbarch_init): Gather isa features and abi features
6293         separately, ensure both match on the gdbarch when reusing an old
6294         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6295         a target with 64-bit float hardware.
6296
6297 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6298
6299         * source.c (search_command_helper): Stop reverse search
6300         when line 1 has been searched.
6301
6302 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6303
6304         * record-full.c (record_full_base_target::close): Rewrite
6305         record_full_core_buf_list free logic.
6306
6307 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6308
6309         * break-catch-syscall.c (print_one_catch_syscall): xfree
6310         the last text.
6311
6312 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6313
6314         * top.c (print_gdb_version): Update Copyright year in version
6315         message.
6316
6317 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6318
6319         Update copyright year range in all GDB files.
6320
6321 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6322
6323         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6324
6325 For older changes see ChangeLog-2018.
6326 \f
6327 Local Variables:
6328 mode: change-log
6329 left-margin: 8
6330 fill-column: 74
6331 version-control: never
6332 coding: utf-8
6333 End:
6334