gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-regs.c (tui_show_registers): Update.
   4         (tui_show_register_group): Add win_info parameter.
   5
   6 2019-07-17  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
   9         Rename from tui_display_reg_element_at_line.
  10         (tui_data_window::display_registers_from_line): Update.
  11         * tui/tui-data.h (struct tui_data_window)
  12         <display_reg_element_at_line>: New method.
  13
  14 2019-07-17  Tom Tromey  <tom@tromey.com>
  15
  16         * tui/tui-regs.h (tui_display_registers_from)
  17         (tui_display_registers_from_line): Don't declare.
  18         * tui/tui-windata.c (tui_data_window::display_all_data)
  19         (tui_data_window::refresh_all)
  20         (tui_data_window::do_scroll_vertical): Update.
  21         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
  22         from tui_display_registers_from.
  23         (tui_display_reg_element_at_line): Update.
  24         (tui_data_window::display_registers_from_line): Rename from
  25         tui_display_registers_from_line.
  26         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
  27         display_registers_from_line>: New methods.
  28
  29 2019-07-17  Tom Tromey  <tom@tromey.com>
  30
  31         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
  32         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
  33         from tui_erase_data_content.
  34         (tui_data_window::display_all_data)
  35         (tui_data_window::refresh_all)
  36         (tui_data_window::do_scroll_vertical): Update.
  37         * tui/tui-regs.c (tui_show_registers): Update.
  38         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
  39         New method.
  40
  41 2019-07-17  Tom Tromey  <tom@tromey.com>
  42
  43         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
  44         declare.
  45         * tui/tui-windata.c
  46         (tui_data_window::delete_data_content_windows): Rename from
  47         tui_delete_data_content_windows.
  48         (tui_data_window::display_all_data)
  49         (tui_data_window::do_scroll_vertical): Update.
  50         * tui/tui-data.h (struct tui_data_window)
  51         <delete_data_content_windows>: New method.
  52
  53 2019-07-17  Tom Tromey  <tom@tromey.com>
  54
  55         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
  56         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
  57
  58 2019-07-17  Tom Tromey  <tom@tromey.com>
  59
  60         * tui/tui-windata.h (tui_display_all_data): Don't declare.
  61         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
  62         from tui_display_all_data.
  63         * tui/tui-win.c
  64         (tui_data_window::do_make_visible_with_new_height): Update.
  65         * tui/tui-regs.c (tui_show_registers): Update.
  66         * tui/tui-layout.c (tui_set_layout): Update.
  67         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
  68         method.
  69
  70 2019-07-17  Tom Tromey  <tom@tromey.com>
  71
  72         * tui/tui-windata.h (tui_display_data_from): Don't declare.
  73         * tui/tui-windata.c (tui_display_data_from): Remove.
  74         (tui_data_window::refresh_all): Update.
  75
  76 2019-07-17  Tom Tromey  <tom@tromey.com>
  77
  78         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
  79         * tui/tui-windata.c (tui_display_data_from_line): Remove.
  80         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
  81         tui_display_registers_from_line.
  82         * tui/tui-regs.h (tui_display_registers_from_line): Update.
  83         * tui/tui-regs.c (tui_display_registers_from_line): Remove
  84         "force_display" parameter.
  85
  86 2019-07-17  Tom Tromey  <tom@tromey.com>
  87
  88         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
  89         declare.
  90         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
  91         Rename from tui_first_reg_element_no_inline.
  92         (tui_display_reg_element_at_line)
  93         (tui_display_registers_from_line): Update.
  94         * tui/tui-data.h (struct tui_data_window)
  95         <first_reg_element_no_inline>: New method.
  96
  97 2019-07-17  Tom Tromey  <tom@tromey.com>
  98
  99         * tui/tui-windata.c (tui_display_data_from)
 100         (tui_data_window::do_scroll_vertical): Update.
 101         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 102         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 103         Rename from tui_line_from_reg_element_no.
 104         (tui_display_registers_from_line): Update.
 105         * tui/tui-data.h (struct tui_data_window)
 106         <line_from_reg_element_no>: New method.
 107
 108 2019-07-17  Tom Tromey  <tom@tromey.com>
 109
 110         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 111         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 112         tui_last_regs_line_no.
 113         (tui_display_reg_element_at_line)
 114         (tui_display_registers_from_line): Update.
 115         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 116         method.
 117
 118 2019-07-17  Tom Tromey  <tom@tromey.com>
 119
 120         PR tui/24722:
 121         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 122         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 123         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 124         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 125         (tui_update_breakpoint_info): Likewise.
 126         * tui/tui-hooks.c (tui_event_create_breakpoint)
 127         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 128         Update.
 129
 130 2019-07-17  Tom Tromey  <tom@tromey.com>
 131
 132         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 133
 134 2019-07-17  Tom Tromey  <tom@tromey.com>
 135
 136         * tui/tui-winsource.c (tui_update_source_window_as_is)
 137         (tui_update_source_windows_with_addr): Update.
 138         * tui/tui-source.h (tui_set_source_content)
 139         (tui_show_symtab_source): Add "win_info" parameter.
 140         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 141         parameter.
 142         (tui_show_symtab_source): Likewise.
 143
 144 2019-07-17  Tom Tromey  <tom@tromey.com>
 145
 146         * tui/tui-wingeneral.c
 147         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 148
 149 2019-07-17  Tom Tromey  <tom@tromey.com>
 150
 151         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 152         (struct tui_cmd_window) <can_scroll>: New method.
 153         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 154         method.
 155
 156 2019-07-17  Tom Tromey  <tromey@adacore.com>
 157
 158         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 159         do_field_signed>: Rename.  Change type of "value".
 160         * ui-out.c (ui_out::field_signed): Rename from field_int.
 161         Change type of "value".
 162         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 163         type of "value".
 164         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 165         do_field_int.  Change type of "value".
 166         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 167         do_field_int.  Change type of "value".
 168         * tracepoint.c (trace_status_mi, tfind_1)
 169         (print_one_static_tracepoint_marker): Update.
 170         * thread.c (print_thread_info_1, print_selected_thread_frame):
 171         Update.
 172         * stack.c (print_frame, print_frame_info): Update.
 173         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 174         Update.
 175         * source.c (print_source_lines_base): Update.
 176         * skip.c (info_skip_command): Update.
 177         * record-btrace.c (btrace_ui_out_decode_error)
 178         (btrace_call_history_src_line): Update.
 179         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 180         Update.
 181         * progspace.c (print_program_space): Update.
 182         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 183         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 184         do_field_int.  Change type of "value".
 185         * mi/mi-out.c (mi_ui_out::do_table_begin)
 186         (mi_ui_out::do_table_header): Update.
 187         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 188         type of "value".
 189         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 190         (mi_cmd_data_list_changed_registers, output_register)
 191         (mi_cmd_data_read_memory, mi_load_progress)
 192         (mi_cmd_trace_frame_collected): Update.
 193         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 194         Update.
 195         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 196         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 197         (mi_cmd_var_list_children, varobj_update_one): Update.
 198         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 199         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 200         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 201         * inferior.c (print_inferior): Update.
 202         * gdb_bfd.c (print_one_bfd): Update.
 203         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 204         Update.
 205         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 206         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 207         do_field_int.  Change type of "value".
 208         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 209         do_field_int.  Change type of "value".
 210         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 211         (print_one_breakpoint_location, print_it_catch_fork)
 212         (print_one_catch_fork, print_it_catch_vfork)
 213         (print_one_catch_vfork, print_it_catch_solib)
 214         (print_it_catch_exec, print_it_ranged_breakpoint)
 215         (print_mention_watchpoint, print_mention_masked_watchpoint)
 216         (bkpt_print_it, update_static_tracepoint): Update.
 217         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 218         * break-catch-syscall.c (print_it_catch_syscall): Update.
 219         * ada-tasks.c (print_ada_task_info): Update.
 220         * ada-lang.c (print_it_exception, print_mention_exception):
 221         Update.
 222
 223 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 224
 225         PR breakpoints/24541
 226         * gdbarch.c: Regenerate.
 227         * gdbarch.h: Regenerate.
 228         * gdbarch.sh: Adjust return type and parameter types for
 229         'stap_adjust_register'.
 230         (i386_stap_adjust_register): Adjust signature and return new
 231         register name.
 232         * stap-probe.c (stap_parse_register_operand): Adjust use of
 233         'gdbarch_stap_adjust_register'.
 234
 235 2019-07-17  Tom Tromey  <tromey@adacore.com>
 236
 237         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 238         declare VEC.
 239         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 240         std::vector.
 241         (struct s390_process_info): Add initializers.
 242         (s390_add_process): Use new.
 243         (s390_linux_nat_target::low_forget_process): Use delete.
 244         (s390_linux_nat_target::low_new_fork)
 245         (s390_linux_nat_target::stopped_by_watchpoint)
 246         (s390_linux_nat_target::low_prepare_to_resume)
 247         (s390_linux_nat_target::insert_watchpoint)
 248         (s390_linux_nat_target::insert_hw_breakpoint)
 249         (s390_linux_nat_target::remove_watchpoint)
 250         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 251
 252 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 253
 254         * aarch64-fbsd-nat.c: Include regcache.h.
 255         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 256         argument.
 257         (aarch64_fbsd_nat_target::fetch_registers)
 258         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 259         variable.
 260         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 261
 262 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 263
 264         * fbsd-nat.c: Include gdbarch.h.
 265
 266 2019-07-15  Tom Tromey  <tromey@adacore.com>
 267
 268         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 269
 270 2019-07-15  Tom Tromey  <tromey@adacore.com>
 271
 272         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 273         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 274         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 275         * cli-out.c (cli_ui_out::do_field_int): New method.
 276         * ui-out.c (ui_out::field_unsigned): New method.
 277         * symfile.c (generic_load): Use field_unsigned.
 278         (print_transfer_performance): Likewise.
 279         * record-btrace.c (ui_out_field_uint): Remove.
 280         (btrace_call_history_insn_range, btrace_call_history): Use
 281         field_unsigned.
 282         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 283         field_unsigned.
 284         * ui-out.h (class ui_out) <field_unsigned>: New method.
 285         <do_field_unsigned>: Likewise.
 286
 287 2019-07-15  Tom Tromey  <tromey@adacore.com>
 288
 289         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 290         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 291         * target.c (flash_erase_command): Use field_string.
 292         * infrun.c (print_signal_received_reason): Use field_string.
 293         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 294         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 295         field_string.
 296         * ada-tasks.c (print_ada_task_info): Use field_string.
 297
 298 2019-07-15  Tom Tromey  <tromey@adacore.com>
 299
 300         * target.c (flash_erase_command): Use field_core_addr.
 301         * symfile.c (generic_load): Use field_core_addr.
 302         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 303         Use field_core_addr.
 304         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 305         field_core_addr.
 306
 307 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 308
 309         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 310         value if its desired type is smaller than a CORE_ADDR and signed.
 311
 312 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 313
 314         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 315         of changes to field names, and use new is_reference field to
 316         decide if a property is a reference or not.
 317         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 318         field.
 319         (struct dwarf2_property_baton): Update header comment, rename
 320         'referenced_type' to 'property_type' and update comments.
 321         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 322         default property type, store in property baton, update to take
 323         accound of renamed field.
 324         (read_func_scope): Update call to attr_to_dynamic_prop.
 325         (read_array_type): Likewise.
 326         (dwarf2_per_cu_addr_sized_int_type): New function.
 327         (read_subrange_index_type): Move type finding code to
 328         dwarf2_per_cu_addr_sized_int_type.
 329         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 330         (dwarf2_per_cu_addr_type): New function.
 331         (set_die_type): Update calls to attr_to_dynamic_prop.
 332
 333 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 334
 335         * dwarf2read.c (read_subrange_index_type): New function.
 336         (read_subrange_type): Move code into new function and call it.
 337         * gdbtypes.c (create_range_type): Add some asserts.
 338
 339 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 340
 341         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 342         update return statements.
 343         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 344         declaration, and update comment to match.
 345         * gdbtypes.c (resolve_dynamic_array): Update call to
 346         dwarf2_evaluate_property to match new return type.
 347
 348 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 349
 350         * valarith.c (value_subscripted_rvalue): Change lowerbound
 351         parameter type from int to LONGEST.
 352         * value.h (value_subscripted_rvalue): Likewise in declaration.
 353
 354 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 355
 356         * cli/cli-utils.c (info_print_command_completer): New function.
 357         * cli/cli-utils.h: Add 'completer.h' include, and forward
 358         declaration for 'struct cmd_list_element'.
 359         (info_print_command_completer): Declare.
 360         * stack.c (_initialize_stack): Add completer for 'info locals' and
 361         'info args'.
 362         * symtab.c (_initialize_symtab): Add completer for 'info
 363         variables' and 'info functions'.
 364         * NEWS: Mention completion for additional info commands.
 365
 366 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 367
 368         * cli/cli-utils.c (extract_info_print_args): Delete.
 369         (extract_arg_maybe_quoted): Delete.
 370         (info_print_options_defs): New variable.
 371         (make_info_print_options_def_group): New function.
 372         (extract_info_print_options): Define new function.
 373         * cli/cli-utils.h (extract_info_print_args): Delete.
 374         (struct info_print_options): New structure.
 375         (extract_info_print_options): Declare new function.
 376         * stack.c (info_locals_command): Update to use new
 377         extract_info_print_options, also add a header comment.
 378         (info_args_command): Likewise.
 379         * symtab.c (info_variables_command): Likewise.
 380         (info_functions_command): Likewise.
 381
 382 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 383
 384         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 385         to extract string arguments.
 386         * common/common-utils.c (extract_string_maybe_quoted): New function.
 387         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 388
 389 2019-07-11  Tom Tromey  <tromey@adacore.com>
 390
 391         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 392         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 393         * top.h (gdbinit): Don't declare.
 394         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 395         into...
 396         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 397         * top.c (gdb_init): Don't call init_cli_cmds.
 398         (gdbinit): Remove.
 399         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 400
 401 2019-07-11  Tom Tromey  <tromey@adacore.com>
 402
 403         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 404         after it has been moved.
 405
 406 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 407
 408         * valops.c (value_must_coerce_to_target): Change return type to
 409         bool.
 410         * value.h (value_must_coerce_to_target): Likewise.
 411
 412 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 413
 414         * breakpoint.c (is_hardware_watchpoint): Remove
 415         forward-declaration.
 416         (is_masked_watchpoint): Change return type to bool.
 417         (is_tracepoint): Likewise.
 418         (is_breakpoint): Likewise.
 419         (is_hardware_watchpoint): Likewise.
 420         (is_watchpoint): Likewise.
 421         (is_no_memory_software_watchpoint): Likewise.
 422         (is_catchpoint): Likewise.
 423         (breakpoint_1): Make FILTER parameter's return type bool.
 424         is_masked_watchpoint): Change return type to bool.
 425         (save_breakpoints): Make FILTER parameter's return type bool.
 426         * breakpoint.h (is_breakpoint): Change return type to bool.
 427         (is_watchpoint): Likewise.
 428         (is_catchpoint): Likewise.
 429         (is_tracepoint): Likewise.
 430
 431 2019-07-10  Tom Tromey  <tom@tromey.com>
 432
 433         * defs.h: Don't include gdbarch.h.
 434         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 435         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 436         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 437         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 438         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 439         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 440         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 441         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 442         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 443         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 444         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 445         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 446         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 447         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 448         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 449         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 450         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 451         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 452         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 453         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 454         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 455         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 456         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 457         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 458         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 459         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 460         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 461
 462 2019-07-10  Tom Tromey  <tromey@adacore.com>
 463
 464         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 465         * breakpoint.c (init_ada_exception_breakpoint): Register as
 466         bp_catchpoint.
 467         (print_one_breakpoint_location, print_one_breakpoint): Use
 468         is_ada_exception_catchpoint.
 469         * ada-lang.c (class ada_catchpoint_location): Pass
 470         bp_loc_software_breakpoint to bp_location constructor.
 471         (is_ada_exception_catchpoint): New function.
 472
 473 2019-07-10  Tom Tromey  <tromey@adacore.com>
 474
 475         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 476         VEC.
 477         (struct arm_exidx_entry): New method operator<.
 478         (struct arm_exidx_data) <section_maps>: Change type.
 479         (arm_exidx_data_free): Remove.
 480         (arm_exidx_data_key): Change type.  Move lower.
 481         (arm_exidx_new_objfile): Update.
 482         (arm_compare_exidx_entries): Remove.
 483         (arm_find_exidx_entry, _initialize_arm_tdep)
 484
 485 2019-07-10  Tom Tromey  <tromey@adacore.com>
 486
 487         * solib-spu.c (ocl_program_data_key): Change type.
 488         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 489         Update.
 490
 491 2019-07-10  Tom Tromey  <tromey@adacore.com>
 492
 493         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 494         (struct solib_aix_inferior_data) <library_list>: Change type.
 495         (solib_aix_inferior_data_handle): Change type.
 496         (get_solib_aix_inferior_data): Update.
 497         (solib_aix_free_library_list): Remove.
 498         (library_list_start_library): Update.
 499         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 500         return type.
 501         (solib_aix_get_library_list)
 502         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 503         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 504
 505 2019-07-10  Tom Tromey  <tromey@adacore.com>
 506
 507         * solib-dsbt.c (struct dsbt_info): Add initializers.
 508         (solib_dsbt_pspace_data): Change type.
 509         (dsbt_pspace_data_cleanup): Remove.
 510         (get_dsbt_info, _initialize_dsbt_solib): Update.
 511
 512 2019-07-10  Tom Tromey  <tromey@adacore.com>
 513
 514         * spu-tdep.c (spu_overlay_data): Change type.
 515         (spu_get_overlay_table, spu_overlay_new_objfile)
 516         (_initialize_spu_tdep): Update.
 517
 518 2019-07-10  Tom Tromey  <tromey@adacore.com>
 519
 520         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 521         destructor.
 522         (dbx_objfile_data_key): Change type and declare later.
 523         (DBX_SYMFILE_INFO): Rewrite.
 524         * dbxread.c (dbx_objfile_data_key): Change type.
 525         (dbx_symfile_init): Update.
 526         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 527         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 528         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 529
 530 2019-07-10  Tom Tromey  <tromey@adacore.com>
 531
 532         * jit.c (jit_program_space_key): Change type.  Move lower.
 533         (get_jit_program_space_data): Update.
 534         (jit_program_space_data_cleanup): Remove.
 535         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 536         Update.
 537         (struct jit_program_space_data): Add initializers.
 538
 539 2019-07-10  Tom Tromey  <tromey@adacore.com>
 540
 541         * solib-darwin.c (struct darwin_info): Add initializers.
 542         (solib_darwin_pspace_data): Change type.
 543         (darwin_pspace_data_cleanup): Remove.
 544         (get_darwin_info, _initialize_darwin_solib): Update.
 545
 546 2019-07-10  Tom Tromey  <tromey@adacore.com>
 547
 548         * remote-sim.c (struct sim_inferior_data): Add initializers,
 549         constructor, and destructor.
 550         (sim_inferior_data_key): Change type.  Move lower.
 551         (check_for_duplicate_sim_descriptor): Update.
 552         (get_sim_inferior_data): Use new.  Update.
 553         (~sim_inferior_data_cleanup): Rename from
 554         sim_inferior_data_cleanup.  Simplify.
 555         (gdbsim_close_inferior, simulator_command)
 556         (sim_command_completer, _initialize_remote_sim): Update.
 557         (next_pid, INITIAL_PID): Move earlier.
 558
 559 2019-07-10  Tom Tromey  <tromey@adacore.com>
 560
 561         * python/python-internal.h (create_thread_object): Return
 562         gdbpy_ref.
 563         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 564         * python/py-inferior.c (struct threadlist_entry): Add
 565         constructor.
 566         <thread_obj>: Now a gdbpy_ref.
 567         (thread_to_thread_object): Update.
 568         (add_thread_object): Use new.
 569         (delete_thread_object): Use delete.
 570         (infpy_threads): Update.
 571         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 572         GIL.
 573
 574 2019-07-10  Tom Tromey  <tromey@adacore.com>
 575
 576         * valops.c (value_cast): Specialize error message for Ada.
 577
 578 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 579
 580         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 581
 582 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 583
 584         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 585         bpstat_should_step): Return bool, adjust comments.
 586         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 587         bpstat_should_step): Likewise.
 588
 589 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 590
 591         * features/Makefile: Use feature target descriptions for Arm.
 592         * features/arm/arm-core.c: Generate new file.
 593         * features/arm/arm-fpa.c: Likewise.
 594         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 595         * features/arm/arm-m-profile.c: Likewise.
 596         * features/arm/arm-vfpv2.c: Likewise.
 597         * features/arm/arm-vfpv3.c: Likewise.
 598         * features/arm/xscale-iwmmxt.c: Likewise.
 599         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 600
 601 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 602
 603         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 604         ptrace earlier.
 605
 606 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 607
 608         * features/aarch64-pauth.c: Regenerate.
 609
 610 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 611
 612         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 613         bool.
 614         (bpstat_what): Use false instead of 0.
 615
 616 2019-07-09  Pedro Alves  <palves@redhat.com>
 617
 618         * break-catch-throw.c (is_exception_catchpoint): New.
 619         * breakpoint.c (print_one_breakpoint_location): New parameter
 620         'raw_loc'.  Handle it.  Use
 621         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 622         looking at the breakpoint's type.
 623         (print_one_breakpoint): If handling "maint info breakpoints", also
 624         print locations of exception catchpoints.
 625         * breakpoint.h (is_exception_catchpoint): Declare.
 626
 627 2019-07-09  Pedro Alves  <palves@redhat.com>
 628
 629         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 630         "addr" field.
 631         (allocate_location_exception_catchpoint): New.
 632         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 633         (initialize_throw_catchpoint_ops): Install
 634         allocate_location_exception_catchpoint as allocate_location
 635         method.
 636         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 637         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 638         bp_loc_other.
 639         (breakpoint_address_is_meaningful): Delete.
 640         (bl_address_is_meaningful): New.
 641         (breakpoint_locations_match): Adjust comment.
 642         (bp_location_from_bp_type): New, factored out of...
 643         (bp_location::bp_location(breakpoint *)): ... this.
 644         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 645         factored out of...
 646         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 647         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 648         breakpoint_address_is_meaningful.
 649         (bp_locations_compare): Adjust comment.
 650         (update_global_location_list): Use bl_address_is_meaningful
 651         instead of breakpoint_address_is_meaningful.
 652         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 653         explicit.
 654         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 655         * python/py-breakpoint.c (bppy_get_location): No longer check
 656         whether location is null.
 657
 658 2019-07-09  Pedro Alves  <palves@redhat.com>
 659
 660         PR c++/15468
 661         * breakpoint.c (print_one_breakpoint_location): Remove
 662         single-location assert.
 663
 664 2019-07-09  Tom Tromey  <tom@tromey.com>
 665
 666         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 667         * configure: Rebuild.
 668         * configure.ac: Change common to gdbsupport.
 669         * gdbsupport: Rename from common.
 670         * acinclude.m4: Change common to gdbsupport.
 671         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 672         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 673         gdbsupport.
 674         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 675         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 676         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 677         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 678         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 679         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 680         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 681         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 682         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 683         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 684         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 685         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 686         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 687         coff-pe-read.c, command.h, compile/compile-c-support.c,
 688         compile/compile-c.h, compile/compile-cplus-symbols.c,
 689         compile/compile-cplus-types.c, compile/compile-cplus.h,
 690         compile/compile-loc2c.c, compile/compile.c, completer.c,
 691         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 692         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 693         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 694         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 695         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 696         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 697         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 698         features/aarch64-core.c, features/aarch64-fpu.c,
 699         features/aarch64-pauth.c, features/aarch64-sve.c,
 700         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 701         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 702         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 703         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 704         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 705         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 706         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 707         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 708         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 709         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 710         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 711         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 712         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 713         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 714         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 715         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 716         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 717         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 718         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 719         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 720         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 721         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 722         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 723         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 724         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 725         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 726         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 727         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 728         minsyms.c, mips-linux-tdep.c, namespace.h,
 729         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 730         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 731         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 732         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 733         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 734         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 735         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 736         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 737         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 738         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 739         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 740         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 741         procfs.c, producer.c, progspace.h, psymtab.h,
 742         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 743         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 744         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 745         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 746         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 747         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 748         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 749         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 750         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 751         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 752         target-memory.c, target.c, target.h, target/waitstatus.c,
 753         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 754         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 755         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 756         unittests/array-view-selftests.c,
 757         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 758         unittests/common-utils-selftests.c,
 759         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 760         unittests/format_pieces-selftests.c,
 761         unittests/function-view-selftests.c,
 762         unittests/lookup_name_info-selftests.c,
 763         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 764         unittests/mkdir-recursive-selftests.c,
 765         unittests/observable-selftests.c,
 766         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 767         unittests/parse-connection-spec-selftests.c,
 768         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 769         unittests/scoped_fd-selftests.c,
 770         unittests/scoped_mmap-selftests.c,
 771         unittests/scoped_restore-selftests.c,
 772         unittests/string_view-selftests.c, unittests/style-selftests.c,
 773         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 774         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 775         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 776         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 777         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 778         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 779
 780 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 781
 782         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 783         bool value.
 784         (decode_digits_ordinary): Set explicit_line field in sal.
 785         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 786         symtab_and_line that was set on an explicit line number in
 787         assembler code.  Do always update the recorded symtab and line if
 788         we do skip the prologue.
 789
 790 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 791
 792         * breakpoint.c (set_breakpoint_location_function): Remove
 793         explicit_loc parameter.
 794         (momentary_breakpoint_from_master): Update call to
 795         set_breakpoint_location_function.
 796         (add_location_to_breakpoint): Likewise.
 797
 798 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 799
 800         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 801         required features based on default bfd type when no specific bfd
 802         is present.
 803
 804 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 805
 806         * NEWS: Mention that GDB printf and eval commands can now print
 807         C-style and Ada-style convenience var strings without
 808         calling the inferior.
 809         * printcmd.c (printf_c_string): Locally print GDB internal var
 810         instead of transiting via the inferior.
 811         (printf_wide_c_string): Likewise.
 812
 813 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 814
 815         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 816
 817 2019-07-04  Tom Tromey  <tom@tromey.com>
 818
 819         PR tui/24724:
 820         * tui/tui-winsource.c (tui_clear_source_content): Update.
 821         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 822         (tui_update_breakpoint_info): Update.
 823         (tui_set_exec_info_content): Update.
 824         * tui/tui-source.c (tui_set_source_content_nil): Update.
 825         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 826         has_break.
 827         * tui/tui-data.h (enum tui_bp_flag): New.
 828         (tui_bp_flags): New enum flags type.
 829         (struct tui_source_element) <break_mode>: Change type.  Rename
 830         from has_break.
 831         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 832         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 833         constants.
 834         * tui/tui-winsource.h: Fix comment.
 835
 836 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 837
 838         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 839         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 840         (store_fpregs_to_thread)
 841         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 842         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 843         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 844         (IWMMXT_REGS_SIZE): Add define.
 845         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 846         (fetch_vfp_regs, store_vfp_regs)
 847         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 848         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 849
 850 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 851
 852         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 853         defines.
 854         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 855         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 856         (ARM_INT_REGISTER_SIZE): ...to this.
 857         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 858         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 859         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 860         (arm_linux_collect_gregset, supply_nwfpe_register)
 861         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 862         defines.
 863         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 864         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 865         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 866         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 867         (arm_return_in_memory, arm_store_return_value)
 868         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 869         (arm_record_ld_st_multiple): Likewise.
 870         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 871         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 872
 873 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 874
 875         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 876         AARCH64_DISPLACED_MODIFIED_INSNS.
 877         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 878         (aarch64_displaced_step_copy_insn): Likewise.
 879         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 880         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 881         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 882         ARM_DISPLACED_MODIFIED_INSNS.
 883         * arm-tdep.c (arm_gdbarch_init): Likewise.
 884         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 885         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 886         (struct arm_displaced_step_closure): Use
 887         ARM_DISPLACED_MODIFIED_INSNS.
 888
 889 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 890
 891         * features/Makefile: Remove unused xml files.
 892         * features/aarch64.xml: Remove.
 893         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 894         * features/i386/amd64-avx-avx512.xml: Remove.
 895         * features/i386/amd64-avx-linux.xml: Remove.
 896         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 897         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 898         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 899         * features/i386/amd64-avx-mpx.xml: Remove.
 900         * features/i386/amd64-avx.xml: Remove.
 901         * features/i386/amd64-linux.xml: Remove.
 902         * features/i386/amd64-mpx-linux.xml: Remove.
 903         * features/i386/amd64-mpx.xml: Remove.
 904         * features/i386/amd64.xml: Remove.
 905         * features/i386/i386-avx-avx512-linux.xml: Remove.
 906         * features/i386/i386-avx-avx512.xml: Remove.
 907         * features/i386/i386-avx-linux.xml: Remove.
 908         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 909         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 910         * features/i386/i386-avx-mpx-linux.xml: Remove.
 911         * features/i386/i386-avx-mpx.xml: Remove.
 912         * features/i386/i386-avx.xml: Remove.
 913         * features/i386/i386-linux.xml: Remove.
 914         * features/i386/i386-mmx-linux.xml: Remove.
 915         * features/i386/i386-mmx.xml: Remove.
 916         * features/i386/i386-mpx-linux.xml: Remove.
 917         * features/i386/i386-mpx.xml: Remove.
 918         * features/i386/i386.xml: Remove.
 919         * features/i386/x32-avx-avx512-linux.xml: Remove.
 920         * features/i386/x32-avx-linux.xml: Remove.
 921         * features/i386/x32-linux.xml: Remove.
 922
 923 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 924
 925         * regformats/aarch64.dat: Remove.
 926         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 927         * regformats/i386/amd64-avx-linux.dat: Remove.
 928         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 929         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 930         * regformats/i386/amd64-linux.dat: Remove.
 931         * regformats/i386/amd64-mpx-linux.dat: Remove.
 932         * regformats/i386/amd64.dat: Remove.
 933         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 934         * regformats/i386/i386-avx-linux.dat: Remove.
 935         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 936         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 937         * regformats/i386/i386-linux.dat: Remove.
 938         * regformats/i386/i386-mmx-linux.dat: Remove.
 939         * regformats/i386/i386-mpx-linux.dat: Remove.
 940         * regformats/i386/i386.dat: Remove.
 941         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 942         * regformats/i386/x32-avx-linux.dat: Remove.
 943         * regformats/i386/x32-linux.dat: Remove.
 944
 945 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 946
 947         * aarch64-tdep.c: Remove xml self tests.
 948         * amd64-linux-tdep.c: Likewise.
 949         * amd64-tdep.c: Likewise.
 950         * i386-linux-tdep.c: Likewise.
 951         * i386-tdep.c: Likewise.
 952
 953 2019-07-03  Pedro Alves  <palves@redhat.com>
 954
 955         PR cli/24732
 956         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 957         (pipe_cmd_option_defs): New.
 958         (make_pipe_cmd_options_def_group): New.
 959         (pipe_command): Use gdb::option::process_options.
 960         (pipe_command_completer): New function.
 961         (_initialize_cli_cmds): Install completer for "pipe" command.
 962
 963 2019-07-03  Pedro Alves  <palves@redhat.com>
 964
 965         * cli/cli-option.c (union option_value) <string>: New field.
 966         (struct option_def_and_value): Add ctor, move ctor, dtor and
 967         use DISABLE_COPY_AND_ASSIGN.
 968         (option_def_and_value::clear_value): New.
 969         (parse_option, save_option_value_in_ctx, get_val_type_str)
 970         (add_setshow_cmds_for_options): Handle var_string.
 971         * cli-option.h (union option_def::var_address) <string>: New
 972         field.
 973         (struct string_option_def): New.
 974         * maint-test-options.c (struct test_options_opts): Add default
 975         ctor and use DISABLE_COPY_AND_ASSIGN.
 976         <string_opt>: New field.
 977         (test_options_opts::~test_options_opts): New.
 978         (test_options_opts::dump): Also dump "-string".
 979         (test_options_option_defs): Install "string.
 980
 981 2019-07-03  Pedro Alves  <palves@redhat.com>
 982
 983         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 984         option_value with a null enumeration.
 985         (complete_options): Save the option values in the context.
 986         (save_option_value_in_ctx): New, factored out from ...
 987         (process_options): ... here.
 988         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 989         of the function.
 990         * maint-test-options.c (test_options_opts::dump): New, factored
 991         out from ...
 992         (maintenance_test_options_command_mode): ... here.
 993         (maintenance_test_options_command_completion_result): Delete.
 994         (maintenance_test_options_command_completion_text): Update
 995         comment.
 996         (maintenance_show_test_options_completion_result): Change
 997         prototype.  Just print
 998         maintenance_test_options_command_completion_text.
 999         (save_completion_result): New.
1000         (maintenance_test_options_completer_mode): Pass options context to
1001         complete_options, and then save a dump.
1002         (_initialize_maint_test_options): Use add_cmd to install "maint
1003         show test-options-completion-result".
1004
1005 2019-07-03  Pedro Alves  <palves@redhat.com>
1006
1007         * NEWS (New commands): Mention "with" and "maint with".
1008         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1009         (with_command, with_command_completer): New.
1010         (pipe_command): Adjust to new repeat_previous
1011         interface.
1012         (_initialize_cli_cmds): Install the "with" command and its "w"
1013         alias.
1014         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1015         declarations.
1016         * cli/cli-setshow.c (parse_cli_var_uinteger)
1017         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1018         argument strings for all var_types.
1019         (get_setshow_command_value_string): New, factored out from ...
1020         (do_show_command): ... this.
1021         * cli/cli-setshow.h: Include <string>.
1022         (get_setshow_command_value_string): Declare.
1023         * command.h (repeat_previous): Now returns const char *.  Adjust
1024         comment.
1025         * maint.c: Include "cli/cli-cmds.h".
1026         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1027         (_initialize_maint_cmds): Register the "maintenance with" command.
1028         * top.c (repeat_previous): Move bits from pipe_command here:
1029         Return the saved command line, if any; error out if there's no
1030         command to relaunch.
1031
1032 2019-07-03  Pedro Alves  <palves@redhat.com>
1033
1034         * NEWS (New commands): Mention "maint set/show test-settings"
1035         instead of "maint test-settings".
1036         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1037         (maintenance_test_settings_set_list): Rename to ...
1038         (maintenance_set_test_settings_list): ... this.
1039         (maintenance_test_settings_show_list): Rename to  ...
1040         (maintenance_show_test_settings_list): ... this.
1041         (maintenance_test_settings_cmd): Delete.
1042         (maintenance_test_settings_set_cmd): ...
1043         (maintenance_set_test_settings_cmd): ... this.
1044         (maintenance_test_settings_show_cmd): ...
1045         (maintenance_show_test_settings_cmd): ... this.
1046         (maintenance_test_settings_show_value_cmd):
1047         (maintenance_show_test_settings_value_cmd): ... this.
1048         (_initialize_maint_test_settings): No longer install the "maint
1049         test-settings" prefix command.  Rename "maint test-settings set"
1050         to "maint set test-settings", and "maint test-settings show" to
1051         "maint show test-settings".  Adjust all subcommands.
1052
1053 2019-07-03  Pedro Alves  <palves@redhat.com>
1054
1055         * maint-test-settings.c: Fix file's intro comment.  Replace all
1056         references to "test-options" with references to "test-settings",
1057         in comments.
1058
1059 2019-07-03  Pedro Alves  <palves@redhat.com>
1060
1061         * maint-test-settings.c (maintenance_test_settings_xxx)
1062         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1063         New.
1064         (maintenance_test_settings_enums): Use them.
1065         (maintenance_test_settings_enum): Default to
1066         maintenance_test_settings_xxx.
1067         (_initialize_maint_test_settings): Initialize
1068         MAINTENANCE_TEST_SETTINGS_FILENAME.
1069
1070 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1071
1072         * breakpoint.h (remove_breakpoints_inf): Change return type to
1073         void, move function documentation here.
1074         * breakpoint.c (remove_breakpoints_inf): Change return type to
1075         void, move function documentation to header.
1076
1077 2019-07-02  Pedro Alves  <palves@redhat.com>
1078
1079         * NEWS (Completion improvements): Mention "info threads".
1080         * thread.c (struct info_threads_opts, info_threads_option_defs)
1081         (make_info_threads_options_def_group): New.
1082         (info_threads_command): Use gdb::option::process_options.
1083         (info_threads_command_completer): New.
1084         (_initialize_thread): Use gdb::option::build_help to build the
1085         help text for "info threads".
1086
1087 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1088
1089         * defs.h (generic_load): Move from here...
1090         * symfile.h (generic_load): ... to here.  Rename name parameter
1091         to args.
1092         * symfile.c (generic_load): Add comment.
1093
1094 2019-07-01  Tom Tromey  <tromey@adacore.com>
1095
1096         * dwarf2read.c
1097         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1098         declaration of without_params.  Fix formatting.
1099
1100 2019-07-01  Tom Tromey  <tromey@adacore.com>
1101
1102         * ada-exp.y (find_primitive_type): Update.
1103         * ada-lang.h (ada_lookup_symbol): Update.
1104         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1105         parameter.
1106         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1107
1108 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1109
1110         PR breakpoints/24541
1111         * gdbarch.c: Regenerate.
1112         * gdbarch.h: Regenerate.
1113         * gdbarch.sh: Add 'stap_adjust_register'.
1114         * i386-tdep.c: Include '<unordered_set>'.
1115         (i386_stap_adjust_register): New function.
1116         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1117         * stap-probe.c (stap_parse_register_operand): Call
1118         'gdbarch_stap_adjust_register'.
1119
1120 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1121
1122         PR python/24742
1123         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1124         * python/python.c (do_start_initialization): Use 'xmalloc'
1125         instead of 'PyMem_Malloc'.
1126
1127 2019-06-28  Tom Tromey  <tromey@adacore.com>
1128
1129         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1130         for Ada.
1131
1132 2019-06-27  Tom Tromey  <tromey@adacore.com>
1133
1134         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1135         objfile_key.
1136         (arm_find_mapping_symbol, arm_record_special_symbol)
1137         (_initialize_arm_tdep): Update.
1138         (arm_objfile_data_free): Remove.
1139
1140 2019-06-27  Tom Tromey  <tromey@adacore.com>
1141
1142         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1143         to cp_print_static_field.
1144
1145 2019-06-26  Tom Tromey  <tromey@adacore.com>
1146
1147         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1148         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1149         declare.
1150
1151 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1152
1153         * features/aarch64-core.c (create_feature_aarch64_core):
1154         Regenerate.
1155         * features/aarch64-core.xml: Add cpsr flags.
1156
1157 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1158
1159         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1160         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1161
1162 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1163
1164         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1165         field.
1166         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1167         use.
1168         (arm_record_special_symbol): Don't insert new symbol in sorted
1169         position, push it at the end.
1170
1171 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1172
1173         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1174         (arm_mapping_symbol_s): Remove.
1175         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1176         (arm_mapping_symbol_vec): New typedef.
1177         (struct arm_per_objfile): Add constructor.
1178         <section_maps>: Change type to
1179         std::unique_ptr<arm_mapping_symbol_vec[]>.
1180         (arm_compare_mapping_symbols): Remove.
1181         (arm_find_mapping_symbol): Adjust to section_maps type change.
1182         (arm_objfile_data_free): Call delete on arm_per_objfile.
1183         (arm_record_special_symbol): Adjust to section_maps type change.
1184         Allocate arm_per_objfile with new.
1185
1186 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1187
1188         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1189         with the command prefix.
1190
1191 2019-06-25  Tom Tromey  <tom@tromey.com>
1192
1193         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1194         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1195
1196 2019-06-25  Tom Tromey  <tom@tromey.com>
1197
1198         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1199         type.
1200         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1201         protected.
1202
1203 2019-06-25  Tom Tromey  <tom@tromey.com>
1204
1205         * tui/tui-winsource.c
1206         (tui_source_window_base::set_is_exec_point_at): Add check against
1207         LOA_ADDRESS.
1208
1209 2019-06-25  Tom Tromey  <tom@tromey.com>
1210
1211         * tui/tui-source.c (tui_set_source_content): Don't check before
1212         xfree.
1213         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1214
1215 2019-06-25  Tom Tromey  <tom@tromey.com>
1216
1217         * tui/tui-winsource.h (tui_update_source_window_as_is)
1218         (tui_alloc_source_buffer, tui_line_is_displayed)
1219         (tui_addr_is_displayed): Change type of win_info.
1220         * tui/tui-winsource.c (tui_update_source_window_as_is)
1221         (tui_clear_source_content, tui_show_source_line)
1222         (tui_show_source_content, tui_source_window_base::refill)
1223         (tui_source_window_base::set_is_exec_point_at)
1224         (tui_source_window_base::set_is_exec_point_at)
1225         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1226         (tui_alloc_source_buffer, tui_line_is_displayed)
1227         (tui_addr_is_displayed): Change type of win_info.  Update.
1228         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1229         (tui_source_window_base::do_make_visible_with_new_height):
1230         Update.
1231         * tui/tui-source.c (tui_set_source_content)
1232         (tui_set_source_content_nil)
1233         (tui_source_window::do_scroll_vertical): Update.
1234         * tui/tui-layout.c (show_layout): Update.
1235         * tui/tui-disasm.c (tui_set_disassem_content)
1236         (tui_disasm_window::do_scroll_vertical): Update.
1237         * tui/tui-data.h (tui_win_content): Remove.
1238         (struct tui_gen_win_info) <content, content_size>: Remove.
1239         (struct tui_source_element): Add initializers and destructor.
1240         (union tui_which_element, struct tui_win_element): Remove.
1241         (struct tui_source_window_base) <content>: New field.
1242         (struct tui_data_window): Remove destructor.
1243         (tui_alloc_content, tui_free_win_content)
1244         (tui_free_all_source_wins_content): Don't declare.
1245         * tui/tui-data.c (tui_initialize_static_data): Update.
1246         (init_content_element, tui_alloc_content): Remove.
1247         (~tui_gen_win_info): Update.
1248         (~tui_data_window, tui_free_all_source_wins_content)
1249         (tui_free_win_content, free_content, free_content_elements):
1250         Remove.
1251
1252 2019-06-25  Tom Tromey  <tom@tromey.com>
1253
1254         * tui/tui-winsource.h (tui_clear_source_content)
1255         (tui_erase_source_content, tui_show_source_content): Change type
1256         of win_info.
1257         * tui/tui-winsource.c (tui_clear_source_content)
1258         (tui_erase_source_content, tui_show_source_content): Change type
1259         of win_info.
1260         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1261         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1262         win_info.
1263         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1264         win_info.
1265         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1266
1267 2019-06-25  Tom Tromey  <tom@tromey.com>
1268
1269         * tui/tui-winsource.c (tui_clear_source_content)
1270         (tui_source_window_base::set_is_exec_point_at): Update.
1271         * tui/tui-source.c (tui_set_source_content_nil): Update.
1272         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1273         a bool.
1274         * tui/tui-data.c (init_content_element): Update.
1275
1276 2019-06-25  Tom Tromey  <tom@tromey.com>
1277
1278         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1279         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1280         * tui/tui-layout.c (init_and_make_win): Update.
1281         * tui/tui.h (enum tui_win_type): Update.
1282         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1283         tui_win_is_auxillary.
1284         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1285         tui_win_is_auxillary.
1286
1287 2019-06-25  Tom Tromey  <tom@tromey.com>
1288
1289         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1290         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1291         (tui_delete_data_content_windows, tui_display_all_data)
1292         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1293         Update.
1294         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1295         * tui/tui-regs.c (tui_last_regs_line_no)
1296         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1297         (tui_show_registers): Update.
1298         (tui_show_register_group): Return void.  Update.
1299         (tui_display_registers_from, tui_display_reg_element_at_line)
1300         (tui_display_registers_from_line, tui_check_register_values):
1301         Update.
1302         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1303         member.
1304         (struct tui_data_window) <regs_content>: Now a std::vector.
1305         <regs_content_count>: Remove.
1306         (tui_add_content_elements, tui_free_data_content): Don't declare.
1307         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1308         (init_content_element): Remove DATA_WIN case.  Add assert.
1309         (tui_add_content_elements): Remove.
1310         (tui_data_window): Update.
1311         (tui_free_data_content): Remove.
1312         (free_content_elements): Remove DATA_WIN case.
1313
1314 2019-06-25  Tom Tromey  <tom@tromey.com>
1315
1316         * tui/tui-data.c (tui_data_item_window): Update.
1317         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1318         * tui/tui-windata.c (tui_display_all_data)
1319         (tui_display_data_from_line): Update.
1320         (tui_check_data_values): Remove.
1321         * tui/tui-regs.c (tui_show_register_group)
1322         (tui_display_reg_element_at_line): Update.
1323         * tui/tui-hooks.c (tui_register_changed)
1324         (tui_refresh_frame_and_register_information): Call
1325         tui_check_register_values.
1326         * tui/tui-data.h (struct tui_data_window) <data_content,
1327         data_content_count, data_type>: Remove.
1328         (enum tui_data_type): Remove.
1329
1330         * tui/tui-data.c (tui_data_window::clear_detail)
1331         (~tui_data_window): Update.
1332
1333 2019-06-25  Tom Tromey  <tom@tromey.com>
1334
1335         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1336         declare.
1337         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1338         Rename from tui_first_data_item_displayed.  Update.
1339         (tui_data_window::refresh_all)
1340         (tui_data_window::do_scroll_vertical): Update.
1341         * tui/tui-data.h (struct tui_data_window)
1342         <first_data_item_displayed>: Declare new method.
1343
1344 2019-06-25  Tom Tromey  <tom@tromey.com>
1345
1346         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1347         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1348         contents...
1349         (tui_initialize_static_data): ...here.
1350
1351 2019-06-25  Tom Tromey  <tom@tromey.com>
1352
1353         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1354         (tui_display_registers_from, tui_check_register_values): Update.
1355         (tui_display_register): Remove win_info parameter; update.
1356         (tui_get_register): Change type of parameters.
1357         * tui/tui-data.h (struct tui_data_element): Remove.
1358         (union tui_which_element) <data>: Remove.
1359         <data_window>: Change type.
1360         (struct tui_data_item_window): New.
1361         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1362         case.  Add assert.
1363         (~tui_data_item_window): New destructor.
1364         (free_content_elements): Remove DATA_ITEM_WIN case.
1365
1366 2019-06-25  Tom Tromey  <tom@tromey.com>
1367
1368         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1369         Remove.
1370
1371 2019-06-25  Tom Tromey  <tom@tromey.com>
1372
1373         * tui/tui-data.h (struct tui_command_element): Remove.
1374         (union tui_which_element) <command>: Remove.
1375         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1376         assert.
1377         (free_content_elements): Remove CMD_WIN case.
1378
1379 2019-06-25  Tom Tromey  <tom@tromey.com>
1380
1381         * tui/tui-layout.c (tui_set_layout): Update.
1382         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1383         * tui/tui-data.c (layout_def): Update.
1384
1385 2019-06-25  Tom Tromey  <tom@tromey.com>
1386
1387         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1388         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1389         (tui_source_window_base::set_new_height): Update.
1390         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1391         Update.
1392         (tui_set_locator_fullname, tui_set_locator_info)
1393         (tui_show_frame_info): Update.
1394         * tui/tui-source.c (tui_set_source_content)
1395         (tui_source_is_displayed): Update.
1396         * tui/tui-layout.c (show_source_disasm_command, show_data)
1397         (show_source_or_disasm_and_command): Update.
1398         * tui/tui-disasm.c (tui_set_disassem_content)
1399         (tui_get_begin_asm_address): Update.
1400         * tui/tui-data.h (struct tui_locator_element): Remove.
1401         (union tui_which_element) <locator>: Remove.
1402         (struct tui_locator_window): New.
1403         (tui_locator_win_info_ptr): Change return type.
1404         * tui/tui-data.c (_locator): Change type.
1405         (tui_locator_win_info_ptr): Change return type.
1406         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1407         (tui_alloc_content): Add assert.
1408
1409 2019-06-25  Tom Tromey  <tom@tromey.com>
1410
1411         * tui/tui-winsource.c
1412         (tui_exec_info_window::maybe_allocate_content): New method.
1413         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1414         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1415         (make_source_or_disasm_window): Add cast.
1416         * tui/tui-data.h (union tui_which_element) <simple_string>:
1417         Remove.
1418         (struct tui_source_info): New.
1419         (struct tui_source_window_base) <execution_info>: Change type.
1420         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1421         case, and add assert.
1422         (tui_alloc_content): Add assert.
1423
1424 2019-06-25  Tom Tromey  <tom@tromey.com>
1425
1426         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1427         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1428         * tui/tui-data.c (tui_alloc_win_info): Remove.
1429
1430 2019-06-25  Tom Tromey  <tom@tromey.com>
1431
1432         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1433         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1434         can_highlight.
1435
1436 2019-06-25  Tom Tromey  <tom@tromey.com>
1437
1438         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1439         make_visible_with_new_height method.
1440         (tui_win_info::make_visible_with_new_height): New method.
1441         (tui_source_window_base::do_make_visible_with_new_height)
1442         (tui_data_window::do_make_visible_with_new_height)
1443         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1444         (make_visible_with_new_height): Remove.
1445         (tui_resize_all, tui_adjust_win_heights): Use
1446         make_visible_with_new_height method.
1447         * tui/tui-data.h (struct tui_win_info)
1448         <do_make_visible_with_new_height, make_visible_with_new_height>:
1449         New methods.
1450         (struct tui_source_window_base, struct tui_data_window)
1451         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1452         methods.
1453
1454 2019-06-25  Tom Tromey  <tom@tromey.com>
1455
1456         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1457         method.
1458         (update_tab_width): Call update_tab_width method.
1459         * tui/tui-data.h (struct tui_win_info)
1460         (struct tui_source_window_base) <update_tab_width>: New methods.
1461
1462 2019-06-25  Tom Tromey  <tom@tromey.com>
1463
1464         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1465         parameter.
1466         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1467         parameter.
1468         (tui_gen_win_info::make_visible): Update.
1469         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1470         parameter.
1471         * tui/tui-data.h (enum tui_box): New enum.
1472         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1473
1474 2019-06-25  Tom Tromey  <tom@tromey.com>
1475
1476         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1477         init_and_make_win for EXEC_INFO_WIN.
1478         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1479         longer inline.
1480         (struct tui_win_info) <~tui_win_info>: Inline.
1481         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1482         Don't declare.
1483         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1484         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1485         Remove.
1486         (tui_initialize_static_data): Update.
1487         (~tui_gen_win_info): Handle more cleanup here.
1488         (~tui_source_window_base): Delete "execution_info".
1489         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1490
1491 2019-06-25  Tom Tromey  <tom@tromey.com>
1492
1493         * tui/tui-layout.c (make_command_window): Don't set
1494         can_highlight.
1495         (show_source_disasm_command): Call the reset method.
1496         (show_data): Don't set can_highlight.  Call the reset method.
1497         (tui_gen_win_info::reset): Rename from init_gen_win_info
1498         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1499         (show_source_or_disasm_and_command): Call the reset method.
1500         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1501         (struct tui_cmd_window): Set can_highlight.
1502
1503 2019-06-25  Tom Tromey  <tom@tromey.com>
1504
1505         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1506         from make_visible.
1507         (tui_make_visible, tui_make_invisible): Rewrite.
1508         (tui_win_info::make_visible): Remove.
1509         (tui_source_window_base::make_visible): Update.
1510         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1511         method.  Moved from...
1512         (struct tui_win_info) <make_visible>: ...here.
1513
1514 2019-06-25  Tom Tromey  <tom@tromey.com>
1515
1516         * tui/tui-winsource.c
1517         (tui_source_window_base::do_scroll_horizontal): Remove direction
1518         parameter.
1519         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1520         direction parameter.
1521         * tui/tui-win.c (tui_win_info::forward_scroll)
1522         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1523         (tui_win_info::right_scroll): Update.
1524         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1525         direction parameter.
1526         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1527         direction parameter.
1528         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1529         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1530         Remove direction parameter.
1531         (struct tui_source_window_base, struct tui_source_window)
1532         (struct tui_disasm_window, struct tui_data_window)
1533         (struct tui_cmd_window): Update.
1534
1535 2019-06-25  Tom Tromey  <tom@tromey.com>
1536
1537         * tui/tui-winsource.h (tui_set_exec_info_content)
1538         (tui_show_exec_info_content, tui_erase_exec_info_content)
1539         (tui_clear_exec_info_content, tui_update_exec_info): Change
1540         argument to tui_source_window_base.
1541         * tui/tui-winsource.c (tui_set_exec_info_content)
1542         (tui_show_exec_info_content, tui_erase_exec_info_content)
1543         (tui_clear_exec_info_content, tui_update_exec_info): Change
1544         argument to tui_source_window_base.
1545
1546 2019-06-25  Tom Tromey  <tom@tromey.com>
1547
1548         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1549         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1550
1551 2019-06-25  Tom Tromey  <tom@tromey.com>
1552
1553         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1554         check.
1555
1556 2019-06-25  Tom Tromey  <tom@tromey.com>
1557
1558         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1559         type to void.
1560         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1561         type to void.
1562         * tui/tui-source.c (tui_set_source_content): Update.
1563         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1564
1565 2019-06-25  Tom Tromey  <tom@tromey.com>
1566
1567         * tui/tui-win.c (window_name_completer, tui_set_focus)
1568         (tui_all_windows_info): Use name method.
1569         * tui/tui-data.h (struct tui_gen_win_info)
1570         (struct tui_source_window, struct tui_disasm_window)
1571         (struct tui_data_window, struct tui_cmd_window) <name>: New
1572         method.
1573         (tui_win_name): Don't declare.
1574         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1575         (tui_win_name): Remove.
1576
1577 2019-06-25  Tom Tromey  <tom@tromey.com>
1578
1579         * tui/tui-winsource.h (tui_update_source_window)
1580         (tui_update_source_window_as_is): Change parameter type.
1581         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1582         to be a tui_source_window_base.
1583         (tui_update_source_window_as_is): Likewise.
1584         * tui/tui-win.c (make_visible_with_new_height): Update.
1585
1586 2019-06-25  Tom Tromey  <tom@tromey.com>
1587
1588         * tui/tui-winsource.c (tui_erase_source_content)
1589         (tui_show_source_content, tui_show_exec_info_content)
1590         (tui_erase_exec_info_content): Use refresh_window method.
1591         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1592         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1593         from tui_refresh_win.
1594         (tui_data_window::refresh_window): New method.
1595         (tui_win_info::refresh, tui_source_window_base::refresh)
1596         (tui_refresh_all): Use refresh_window method.
1597         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1598         method.
1599         * tui/tui-regs.c (tui_display_register): Call refresh_window
1600         method.
1601         * tui/tui-layout.c (show_source_disasm_command)
1602         (show_source_or_disasm_and_command): Call refresh_window method.
1603         * tui/tui-data.h (struct tui_gen_win_info)
1604         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1605         New method.
1606
1607 2019-06-25  Tom Tromey  <tom@tromey.com>
1608
1609         * tui/tui.c (tui_rl_other_window, tui_enable)
1610         (tui_is_window_visible, tui_get_command_dimension): Update.
1611         * tui/tui-winsource.c (tui_update_source_window_as_is)
1612         (tui_clear_source_content, tui_erase_source_content)
1613         (tui_show_source_line, tui_source_window_base::refill)
1614         (tui_source_window_base::do_scroll_horizontal)
1615         (tui_source_window_base::set_is_exec_point_at)
1616         (tui_update_breakpoint_info, tui_set_exec_info_content)
1617         (tui_alloc_source_buffer, tui_line_is_displayed)
1618         (tui_addr_is_displayed): Update.
1619         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1620         (tui_check_and_display_highlight_if_needed)
1621         (tui_win_info::make_visible, tui_win_info::refresh)
1622         (tui_refresh_all): Update.
1623         * tui/tui-windata.c (tui_first_data_item_displayed)
1624         (tui_delete_data_content_windows, tui_erase_data_content)
1625         (tui_display_all_data, tui_data_window::refresh_all)
1626         (tui_check_data_values): Update.
1627         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1628         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1629         (tui_win_info::backward_scroll, tui_refresh_all_win)
1630         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1631         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1632         (tui_source_window_base::set_new_height)
1633         (tui_data_window::set_new_height)
1634         (make_invisible_and_set_new_height)
1635         (make_visible_with_new_height, new_height_ok)
1636         (parse_scrolling_args): Update.
1637         * tui/tui-stack.c (tui_show_frame_info): Update.
1638         * tui/tui-source.c (tui_set_source_content)
1639         (tui_set_source_content_nil, tui_source_is_displayed)
1640         (tui_source_window::do_scroll_vertical): Update.
1641         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1642         (tui_display_registers_from, tui_display_reg_element_at_line)
1643         (tui_check_register_values, tui_reg_command): Update.
1644         * tui/tui-layout.c (tui_default_win_height)
1645         (show_source_disasm_command, show_data, init_and_make_win)
1646         (show_source_or_disasm_and_command): Update.
1647         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1648         (tui_redisplay_readline, tui_mld_flush)
1649         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1650         (tui_getc): Update.
1651         * tui/tui-disasm.c (tui_set_disassem_content)
1652         (tui_disasm_window::do_scroll_vertical): Update.
1653         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1654         Now virtual.
1655         (struct tui_win_info): Derive from tui_gen_win_info.
1656         <~tui_win_info>: Mark as override.
1657         <generic>: Remove member.
1658         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1659         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1660         (~tui_data_window, ~tui_win_info)
1661         (tui_free_all_source_wins_content): Update.
1662         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1663
1664 2019-06-25  Tom Tromey  <tom@tromey.com>
1665
1666         * tui/tui-layout.c (init_and_make_win): Use new.
1667         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1668         destructor, initializers.
1669         (tui_alloc_generic_win_info): Don't declare.
1670         * tui/tui-data.c (_locator): Add argument to constructor.
1671         (source_win, disasm_win): New globals.
1672         (exec_info): Remove.
1673         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1674         Update.
1675         (tui_alloc_generic_win_info): Remove.
1676         (init_content_element): Use new.
1677         (tui_win_info::tui_win_info): Update.
1678         (free_content_elements) <case DATA_WIN>: Use delete.
1679
1680 2019-06-25  Tom Tromey  <tom@tromey.com>
1681
1682         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1683         * tui/tui-windata.c (tui_first_data_item_displayed)
1684         (tui_delete_data_content_windows): Update.
1685         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1686         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1687         (tui_display_registers_from, tui_check_register_values): Update.
1688         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1689         pointer.
1690         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1691         window.
1692         (tui_free_data_content): Update.
1693         (free_content_elements) <case DATA_WIN>: Free the window.
1694
1695 2019-06-25  Tom Tromey  <tom@tromey.com>
1696
1697         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1698         Update.
1699         * tui/tui-layout.c (make_command_window)
1700         (show_source_disasm_command, show_data, init_and_make_win)
1701         (show_source_or_disasm_and_command): Update.
1702         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1703         method.
1704         <can_highight, is_highlighted>: Now bool.
1705         (tui_set_win_highlight): Don't declare.
1706         * tui/tui-data.c (tui_set_win_highlight): Remove.
1707
1708 2019-06-25  Tom Tromey  <tom@tromey.com>
1709
1710         * tui/tui-wingeneral.c (make_visible): Remove check of window
1711         type.
1712
1713 2019-06-25  Tom Tromey  <tom@tromey.com>
1714
1715         * tui/tui-win.c (tui_win_info::max_height)
1716         (tui_cmd_window::max_height): New methods.
1717         (new_height_ok): Call max_height.
1718         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1719         <max_height>: New method.
1720
1721 2019-06-25  Tom Tromey  <tom@tromey.com>
1722
1723         * tui/tui-win.c (tui_source_window_base::set_new_height)
1724         (tui_data_window::set_new_height): New methods.
1725         (make_invisible_and_set_new_height): Call set_new_height method.
1726         * tui/tui-data.h (struct tui_win_info)
1727         (struct tui_source_window_base, struct tui_data_window)
1728         <set_new_height>: New method.
1729
1730 2019-06-25  Tom Tromey  <tom@tromey.com>
1731
1732         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1733         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1734         tui_refresh_data_win.
1735         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1736         method.
1737         (tui_refresh_all_win): Call the refresh_all method.
1738         (tui_set_focus): Likewise.
1739         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1740         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1741         Likewise.
1742
1743 2019-06-25  Tom Tromey  <tom@tromey.com>
1744
1745         * tui/tui-winsource.h (tui_refill_source_window)
1746         (tui_set_is_exec_point_at): Don't declare.
1747         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1748         (tui_source_window_base::refill): Rename from
1749         tui_refill_source_window.
1750         (tui_source_window_base::do_scroll_horizontal): Update.
1751         (tui_source_window_base::set_is_exec_point_at): Rename from
1752         tui_set_is_exec_point_at.
1753         (tui_update_all_breakpoint_info): Update.
1754         * tui/tui-stack.c (tui_show_frame_info): Update.
1755         * tui/tui-layout.c (show_data): Add cast.
1756         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1757         * tui/tui-data.h (struct tui_source_window_base) <refill,
1758         set_is_exec_point_at>: New methods.
1759         (tui_source_windows, tui_add_to_source_windows): Update types.
1760         (tui_add_to_source_windows): Remove redundant declaration.
1761         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1762         (tui_source_windows): Change return type.
1763         (tui_clear_source_windows_detail): Update.
1764         (tui_add_to_source_windows): Change type of parameter.
1765         (tui_free_all_source_wins_content): Update.
1766
1767 2019-06-25  Tom Tromey  <tom@tromey.com>
1768
1769         * tui/tui-wingeneral.c (tui_win_info::refresh)
1770         (tui_source_window_base::refresh): New methods.
1771         (tui_refresh_all): Call the refresh method.
1772         * tui/tui-data.h (struct tui_win_info)
1773         (struct tui_source_window_base) <refresh>: New method.
1774
1775 2019-06-25  Tom Tromey  <tom@tromey.com>
1776
1777         * tui/tui.h (tui_is_window_visible): Return bool.
1778         * tui/tui.c (tui_is_window_visible): Return bool.
1779         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1780         (tui_make_visible, tui_make_invisible)
1781         (tui_win_info::make_visible)
1782         (tui_source_window_base::make_visible, make_all_visible)
1783         (tui_make_all_visible, tui_make_all_invisible): Update.
1784         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1785         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1786         bool.
1787         (struct tui_win_info, struct tui_source_window_base)
1788         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1789         * tui/tui-data.c (tui_init_generic_part): Update.
1790
1791 2019-06-25  Tom Tromey  <tom@tromey.com>
1792
1793         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1794         (tui_source_window_base::make_visible): New methods.
1795         (make_all_visible): Make method call.
1796         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1797         (struct tui_source_window_base, struct tui_cmd_window): Override
1798         make_visible.
1799         (tui_win_is_source_type): Don't declare.
1800         * tui/tui-data.c (tui_win_is_source_type): Remove.
1801
1802 2019-06-25  Tom Tromey  <tom@tromey.com>
1803
1804         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1805         NULL check.
1806
1807 2019-06-25  Tom Tromey  <tom@tromey.com>
1808
1809         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1810         Inline constructor.  Add initializers for members.
1811         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1812         constructors; now inline in class.
1813
1814 2019-06-25  Tom Tromey  <tom@tromey.com>
1815
1816         * tui/tui-regs.c (tui_show_registers): Update.
1817         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1818         bool.
1819         * tui/tui-data.c (tui_data_window::clear_detail)
1820         (tui_data_window): Update.
1821
1822 2019-06-25  Tom Tromey  <tom@tromey.com>
1823
1824         * tui/tui-windata.c (tui_display_all_data)
1825         (tui_display_data_from_line, tui_display_data_from)
1826         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1827         Update.
1828         * tui/tui-regs.c (tui_last_regs_line_no)
1829         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1830         (tui_show_registers, tui_show_register_group)
1831         (tui_display_registers_from, tui_display_reg_element_at_line)
1832         (tui_display_registers_from_line, tui_check_register_values)
1833         (tui_reg_next, tui_reg_prev): Update.
1834         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1835         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1836         tui_data_window.
1837         (struct tui_win_info) <detail>: Remove.  Add new fields from
1838         tui_data_info.
1839         (TUI_DATA_WIN): Add cast.
1840         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1841         (~tui_data_window): Simplify.
1842
1843 2019-06-25  Tom Tromey  <tom@tromey.com>
1844
1845         * tui/tui-layout.c (show_source_disasm_command)
1846         (show_source_or_disasm_and_command): Update.
1847         * tui/tui-io.c (update_cmdwin_start_line)
1848         (tui_redisplay_readline): Update.
1849         * tui/tui-data.h (struct tui_command_info): Remove.
1850         (struct tui_win_info) <detail>: Remove command_info member.
1851         (struct tui_data_window) <start_line>: New member, from
1852         tui_command_info.
1853         (TUI_CMD_WIN): Add casts.
1854
1855 2019-06-25  Tom Tromey  <tom@tromey.com>
1856
1857         * tui/tui-winsource.c (tui_update_source_window)
1858         (tui_refill_source_window)
1859         (tui_source_window_base::do_scroll_horizontal)
1860         (tui_update_breakpoint_info, tui_set_exec_info_content)
1861         (tui_show_exec_info_content, tui_erase_exec_info_content)
1862         (tui_clear_exec_info_content): Update.
1863         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1864         Update.
1865         * tui/tui-win.c (make_invisible_and_set_new_height)
1866         (make_visible_with_new_height): Update.
1867         * tui/tui-source.c (tui_set_source_content)
1868         (tui_show_symtab_source): Update.
1869         * tui/tui-layout.c (extract_display_start_addr)
1870         (show_source_disasm_command, show_data)
1871         (make_source_or_disasm_window)
1872         (show_source_or_disasm_and_command): Update.
1873         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1874         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1875         "gdbarch".
1876         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1877         to tui_source_window_base.
1878         (struct tui_win_info) <detail>: Remove source_info member.
1879         (struct tui_source_window_base) <has_locator>: Inline.
1880         Move contents from tui_source_info; rename has_locator member to
1881         m_has_locator.
1882         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1883         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1884         header file.
1885         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1886         Simplify.
1887         (tui_free_all_source_wins_content): Cast to
1888         tui_source_window_base.
1889
1890 2019-06-25  Tom Tromey  <tom@tromey.com>
1891
1892         * tui/tui-win.c (make_invisible_and_set_new_height)
1893         (make_visible_with_new_height): Call has_locator method.
1894         * tui/tui-layout.c (show_source_disasm_command, show_data)
1895         (show_source_or_disasm_and_command): Update for bool change.
1896         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1897         (tui_win_info) <has_locator>: New method.
1898         (struct tui_source_window_base) <has_locator>: New method.
1899         (tui_win_has_locator): Don't declare.
1900         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1901         from tui_win_has_locator.
1902         (tui_source_window_base): Use false, not FALSE.
1903
1904 2019-06-25  Tom Tromey  <tom@tromey.com>
1905
1906         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1907         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1908         clear_detail method directly.
1909         (tui_clear_win_detail): Remove.
1910
1911 2019-06-25  Tom Tromey  <tom@tromey.com>
1912
1913         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1914         "this", not TUI_DISASM_WIN.
1915
1916 2019-06-25  Tom Tromey  <tom@tromey.com>
1917
1918         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1919         declare.
1920         * tui/tui-winsource.c
1921         (tui_source_window_base::do_scroll_horizontal): Rename from
1922         tui_horizontal_source_scroll.
1923         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1924         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1925         from tui_vertical_data_scroll.
1926         * tui/tui-win.h (tui_scroll): Don't declare.
1927         * tui/tui-win.c (tui_win_info::forward_scroll)
1928         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1929         (tui_win_info::right_scroll): Rename and update.
1930         (tui_scroll_forward_command, tui_scroll_backward_command)
1931         (tui_scroll_left_command, tui_scroll_right_command): Update.
1932         (tui_scroll): Remove.
1933         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1934         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1935         from tui_vertical_source_scroll.
1936         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1937         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1938         from tui_vertical_disassem_scroll.
1939         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1940         do_scroll_horizontal>: New methods.
1941         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1942         Likewise.
1943         (struct tui_source_window_base): Add do_scroll_horizontal.
1944         (struct tui_source_window, struct tui_disasm_window): Add
1945         do_scroll_vertical.
1946         (struct tui_data_window, struct tui_cmd_window): Add
1947         do_scroll_horizontal and do_scroll_vertical.
1948         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1949
1950 2019-06-25  Tom Tromey  <tom@tromey.com>
1951
1952         * tui/tui-data.h (struct tui_source_window_base): New struct.
1953         (struct tui_source_window): Derive from tui_source_window_base.
1954         (struct tui_disasm_window): New struct.
1955         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1956         from tui_source_window::clear_detail.
1957         (tui_source_window_base): Rename from tui_source_window.
1958         (~tui_source_window_base): Rename from ~tui_source_window.
1959         (tui_alloc_win_info): Create a tui_disasm_window.
1960
1961 2019-06-25  Tom Tromey  <tom@tromey.com>
1962
1963         * tui/tui-data.h (struct tui_source_window)
1964         (struct tui_data_window): Declare destructors.
1965         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1966         destructors.
1967         (tui_win_info): Simplify.
1968
1969 2019-06-25  Tom Tromey  <tom@tromey.com>
1970
1971         * tui/tui-winsource.c (tui_display_main)
1972         (tui_update_source_windows_with_addr)
1973         (tui_update_all_breakpoint_info): Update.
1974         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1975         (new_height_ok, parse_scrolling_args): Update.
1976         * tui/tui-stack.c (tui_show_frame_info): Update.
1977         * tui/tui-data.h (struct tui_list): Remove.
1978         (tui_source_windows): Return a reference to a std::vector.
1979         * tui/tui-data.c (source_windows): Now a std::vector.
1980         (tui_source_windows): Change return type.
1981         (tui_clear_source_windows): Rewrite.
1982         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1983         (tui_free_all_source_wins_content): Rewrite.
1984
1985 2019-06-25  Tom Tromey  <tom@tromey.com>
1986
1987         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1988         (struct tui_data_window, struct tui_cmd_window): Declare
1989         clear_detail method.
1990         * tui/tui-data.c (tui_source_window::clear_detail)
1991         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1992         methods.
1993         (tui_clear_win_detail): Simplify.
1994
1995 2019-06-25  Tom Tromey  <tom@tromey.com>
1996
1997         * tui/tui-layout.c (make_source_window, make_disasm_window)
1998         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1999         Return the new window.
2000         (show_source_disasm_command, show_data)
2001         (show_source_or_disasm_and_command): Update.
2002
2003 2019-06-25  Tom Tromey  <tom@tromey.com>
2004
2005         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2006         parameter.  Return the new window.
2007         (show_source_disasm_command): Update and remove NULL check.
2008         (show_source_or_disasm_and_command): Update.
2009
2010 2019-06-25  Tom Tromey  <tom@tromey.com>
2011
2012         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2013
2014 2019-06-25  Tom Tromey  <tom@tromey.com>
2015
2016         * tui/tui-data.h (struct tui_win_info): Make constructor
2017         protected.  Make destructor virtual.  Add initializers.
2018         (tui_source_window, tui_data_window, tui_cmd_window): New
2019         classes.
2020         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2021         constructor.  Add "type" parameter.
2022         (tui_source_window, tui_data_window, tui_cmd_window): New
2023         constructors.
2024         (tui_alloc_win_info): Instantiate the appropriate subclass.
2025
2026 2019-06-25  Tom Tromey  <tom@tromey.com>
2027
2028         * tui/tui-win.c (tui_resize_all): Use delete.
2029         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2030         destructor.
2031         (tui_free_window): Don't declare.
2032         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2033         Update.
2034
2035 2019-06-25  Tom Tromey  <tom@tromey.com>
2036
2037         * tui/tui-data.h (struct tui_win_info): Add constructor.
2038         * tui/tui-data.c (tui_alloc_win_info): Use new.
2039         (tui_free_window): Use delete.
2040
2041 2019-06-22  Tom Tromey  <tom@tromey.com>
2042
2043         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2044         declare.
2045         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2046
2047 2019-06-22  Tom Tromey  <tom@tromey.com>
2048
2049         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2050         declare.
2051         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2052
2053 2019-06-22  Tom de Vries  <tdevries@suse.de>
2054
2055         * dwarf2read.c (create_addrmap_from_aranges)
2056         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2057         instead of '%zu'.
2058
2059 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2060
2061         * dwarf2read.h (dwarf2_section_info_def): Remove.
2062         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2063         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2064         std::vector<dwarf2_section_info>.
2065         (struct dwo_file) <~dwo_file>: Remove.
2066         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2067         types field.
2068         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2069         (dwarf2_read_debug_names): Likewise.
2070         (create_debug_types_hash_table): Change parameter type to
2071         array_view, adjust code accordingly.
2072         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2073         (partial_die_info::fixup): Likewise.
2074         (determine_prefix): Likewise.
2075         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2076
2077 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2078
2079         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2080         gdb_bfd_ref_ptr.
2081         <~dwo_file>: Remove call to gdb_bfd_unref.
2082         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2083         gdb_bfd_ref_ptr::get.
2084
2085 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2086
2087         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2088         type to htab_up.
2089         * dwarf2read.c (struct dwo_file): Initialize fields.
2090         <~dwo_file>: New.
2091         (free_dwo_file): Remove, move content to ~dwo_file.
2092         (struct dwo_file_deleter): Remove.
2093         (dwo_file_up>: Remove custom deleter.
2094         (free_dwo_files): Remove.
2095         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2096         dwo_files.
2097         (process_skeletonless_type_units): Call unique_ptr::get.
2098         (allocate_dwo_file_hash_table): Add deleter to created hash
2099         table.  Change return type to htab_up.
2100         (lookup_dwo_file_slot): Don't memset dwo_file, call
2101         unique_ptr::get.
2102         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2103         (create_dwo_unit_in_dwp_v2): Likewise.
2104         (open_and_init_dwo_file): Likewise.
2105         (free_dwo_file_from_slot): Remove.
2106
2107 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2108
2109         * dwarf2read.h (struct dwarf2_section_info) <readin,
2110         is_virtual>: Change type to bool.
2111         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2112         true instead of 1.
2113
2114 2019-06-19  Tom Tromey  <tom@tromey.com>
2115
2116         * tui/tui-data.h (tui_init_content_element): Don't declare.
2117
2118 2019-06-19  Tom Tromey  <tom@tromey.com>
2119
2120         * tui/tui-data.h (tui_init_win_info): Don't declare.
2121
2122 2019-06-19  Tom de Vries  <tdevries@suse.de>
2123
2124         * dwarf2read.h (abstract_to_concrete): Change type to
2125         std::unordered_map<sect_offset, std::vector<sect_offset>,
2126         gdb::hash_enum<sect_offset>>.
2127
2128 2019-06-19  Tom Tromey  <tromey@adacore.com>
2129
2130         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2131         EVAL_AVOID_SIDE_EFFECTS specially.
2132
2133 2019-06-19  Tom Tromey  <tromey@adacore.com>
2134
2135         * source-cache.c (highlighter): New global.
2136         (source_cache::get_source_lines): Create a highlighter on demand.
2137
2138 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2139
2140         * defs.h (deprecated_interactive_hook): Delete declaration.
2141         * interps.c (clear_interpreter_hooks): Remove use of
2142         deprecated_interactive_hook.
2143         * top.c (deprecated_interactive_hook): Delete definition.
2144         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2145
2146 2019-06-18  Tom de Vries  <tdevries@suse.de>
2147
2148         PR gdb/24515
2149         * dwarf2read.h (abstract_to_concrete): Change type from
2150         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2151         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2152         * dwarf2read.c (read_variable): Update.
2153         (dwarf2_fetch_die_loc_sect_off): Update.
2154
2155 2019-06-17  Tom de Vries  <tdevries@suse.de>
2156
2157         PR gdb/24617
2158         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2159         accessing parent[parent_len - 1].
2160
2161 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2162
2163         PR gdb/24364
2164         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2165         call dtrace_process_dof with NULL dof.
2166
2167 2019-06-16  Tom de Vries  <tdevries@suse.de>
2168
2169         PR gdb/24445
2170         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2171
2172 2019-06-16  Tom Tromey  <tom@tromey.com>
2173
2174         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2175         (make_all_visible): Use address of member.
2176
2177 2019-06-16  Tom Tromey  <tom@tromey.com>
2178
2179         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2180         (tui_free_window, free_content, free_content_elements): Remove
2181         unnecessary cast.
2182         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2183         cast.
2184         * tui/tui-regs.c (tui_show_register_group)
2185         (tui_display_registers_from, tui_display_reg_element_at_line):
2186         Remove unnecessary cast.
2187
2188 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2189
2190         * linux-nat.c (normal_mask): Delete.
2191         (_initialize_linux_nat): Don't initialise normal_mask.
2192
2193 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2194
2195         PR gdb/24445
2196         * dwarf-index-write.h (write_psymtabs_to_index): Add
2197         dwz_basename parameter.
2198         * dwarf-index-write.c (write_gdbindex): Move file writing to
2199         write_gdbindex_1.  Change return type void.
2200         (assert_file_size): Move up, remove filename parameter.
2201         (write_gdbindex_1): New function.
2202         (write_debug_names): Change return type to void, call
2203         assert_file_size.
2204         (struct index_wip_file): New struct.
2205         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2206         file logic to index_wip_file.  Write index for dwz file if
2207         needed.
2208         (save_gdb_index_command): Pass basename of dwz file, if present.
2209         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2210         build-id of dwz file, if present.
2211         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2212         (dwarf2_get_dwz_file): Likewise.
2213         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2214         (dwarf2_get_dwz_file): Likewise.
2215
2216 2019-06-16  Tom Tromey  <tom@tromey.com>
2217
2218         * coffread.c (process_coff_symbol): Use xstrdup.
2219         * value.c (create_internalvar): Use xstrdup.
2220
2221 2019-06-16  Tom Tromey  <tom@tromey.com>
2222
2223         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2224         * breakpoint.c (stopin_command, stopat_command)
2225         (until_break_command, decode_location_default): Remove unnecessary
2226         cast.
2227         * utils.c (subset_compare): Remove unnecessary cast.
2228         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2229         cast.
2230         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2231         cast.
2232         * infcmd.c (path_command): Remove unnecessary cast.
2233         * coffread.c (decode_type): Remove unnecessary cast.
2234         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2235         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2236         * tui/tui-stack.c (tui_show_locator_content)
2237         (tui_show_frame_info): Remove unnecessary cast.
2238         * tui/tui-win.c (tui_scroll_forward_command)
2239         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2240         (parse_scrolling_args): Remove unnecessary cast.
2241         * tui/tui-data.c (init_win_info, tui_del_window)
2242         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2243         (free_content_elements): Remove unnecessary cast.
2244         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2245         unnecessary cast.
2246         * tui/tui-source.c (tui_set_source_content)
2247         (tui_vertical_source_scroll): Remove unnecessary cast.
2248         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2249         cast.
2250         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2251         * tui/tui-regs.c (tui_display_registers_from)
2252         (tui_display_register): Remove unnecessary cast.
2253         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2254         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2255         (make_visible): Remove unnecessary cast.
2256         * tui/tui-winsource.c (tui_erase_source_content)
2257         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2258         unnecessary cast.
2259         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2260         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2261         * stabsread.c (read_type, read_array_type, read_range_type):
2262         Remove unnecessary cast.
2263         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2264         (parse_symbol, parse_type, upgrade_type, parse_external)
2265         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2266         unnecessary cast.
2267         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2268
2269 2019-06-16  Tom Tromey  <tom@tromey.com>
2270
2271         * tui/tui-data.c (tui_alloc_generic_win_info)
2272         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2273         checks.
2274
2275 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2276             Andrew Burgess  <andrew.burgess@embecosm.com>
2277
2278         * f-typeprint.c (f_print_type): Don't return early for not
2279         associated or not allocated types.
2280         (f_type_print_varspec_suffix): Add print_rank parameter and print
2281         ranks of array types in case they dangling.
2282         (f_type_print_base): Add print_rank parameter.
2283
2284 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2285
2286         * NEWS: Mention new MI commands.
2287         * break-catch-throw.c (enum exception_event_kind): Move to
2288         breakpoint.h.
2289         (print_mention_exception_catchpoint): Output text as a single
2290         message.
2291         (catch_exception_command_1): Rename to...
2292         (catch_exception_event): ...this, make non-static, update header
2293         command, and change some parameter types.
2294         (catch_catch_command): Update for changes to
2295         catch_exception_command_1.
2296         (catch_throw_command): Likewise.
2297         (catch_rethrow_command): Likewise.
2298         * breakpoint.c (enum exception_event_kind): Delete.
2299         * breakpoint.h (enum exception_event_kind): Moved here from
2300         break-catch-throw.c.
2301         (catch_exception_event): Declare.
2302         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2303         (mi_cmd_catch_throw): New function.
2304         (mi_cmd_catch_rethrow): New function.
2305         (mi_cmd_catch_catch): New function.
2306         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2307         'catch-catch' entries.
2308         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2309         (mi_cmd_catch_rethrow): Declare.
2310         (mi_cmd_catch_catch): Declare.
2311
2312 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2313
2314         * annotate.c (annotate_source_line): Change return type to void,
2315         update implementation to match.
2316         * annotate.h (annotate_source_line): Change return type to void,
2317         update header comment.
2318         * stack.c (print_frame_info): Don't change what frame information
2319         is printed based on whether annotations are on or not.
2320
2321 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2322
2323         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2324         (annotate_source): Make static.
2325         (annotate_source_line): Moved from source.c and renamed from
2326         identify_source_line.  Update the return type.
2327         * annotate.h (annotate_source): Delete declaration.
2328         (annotate_source_line): Declaration moved from source.h, and
2329         renamed from identify_source_line.  Return type updated.
2330         * source.c (identify_source_line): Moved to annotate.c and renamed
2331         to annotate_source_line.
2332         (info_line_command): Remove check of annotation_level.
2333         * source.h (identify_source_line): Move declaration to annotate.h
2334         and rename to annotate_source_line.
2335         * stack.c: Add 'annotate.h' include.
2336         (print_frame_info): Remove check of annotation_level before
2337         calling annotate_source_line.
2338
2339 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2340
2341         * source-cache.c (source_cache::get_plain_source_lines): Use
2342         open_source_file_with_line_charpos instead of just
2343         open_source_file, remove call to find_source_lines.
2344         (source_cache::get_source_lines): Likewise.
2345         * source.c (find_source_lines): Make static.
2346         (get_filename_and_charpos): Renamed into...
2347         (open_source_file_with_line_charpos): ..this along with changes to
2348         return a scoped_fd, and some other minor clean ups.
2349         (identify_source_line): Use open_source_file_with_line_charpos.
2350         (search_command_helper): Use open_source_file_with_line_charpos
2351         instead of just open_source_file, remove call to
2352         find_source_lines.
2353         * source.h (open_source_file_with_line_charpos): Declare new
2354         function.
2355         (find_source_lines): Delete declaration.
2356
2357 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2358
2359         * source.c (get_filename_and_charpos): Remove fullname
2360         parameter.
2361         (identify_source_line): Update call to get_filename_and_charpos.
2362
2363 2019-06-14  Tom Tromey  <tromey@adacore.com>
2364
2365         PR gdb/24502:
2366         * ui-style.h (skip_ansi_escape): Update comment.
2367         * ui-file.h (class no_terminal_escape_file): New class.
2368         * ui-file.c (no_terminal_escape_file::write)
2369         (no_terminal_escape_file::puts): New methods.
2370         * cli/cli-logging.c (handle_redirections): Use
2371         no_terminal_escape_file.
2372
2373 2019-06-14  Tom Tromey  <tromey@adacore.com>
2374
2375         * NEWS: Move convenience variable news above Python news.
2376
2377 2019-06-14  Tom Tromey  <tom@tromey.com>
2378
2379         * gnulib: Move directory to top-level.
2380         * configure.ac: Don't configure gnulib.
2381         * configure: Rebuild.
2382         * common/common-defs.h: Use new path to gnulib.
2383         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2384         (GNULIB_H): Remove.
2385         (INCGNU): Look in new gnulib location.
2386         (HFILES_NO_SRCDIR): Remove gnulib files.
2387         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2388         (generated_files): Remove GNULIB_H.
2389         ($(LIBGNU), all-lib): Remove targets.
2390         (distclean): Don't mention GNULIB_BUILDDIR.
2391         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2392
2393 2019-06-14  Tom Tromey  <tromey@adacore.com>
2394
2395         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2396         Warn if symbol file does not provide any symbols.
2397
2398 2019-06-14  Tom Tromey  <tromey@adacore.com>
2399
2400         * source.c (find_and_open_source): Respect basenames_may_differ.
2401
2402 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2403
2404         * annotate.c (annotate_breakpoints_invalid): Make use of
2405         scoped_restore_terminal_state.
2406         (annotate_frames_invalid): Likewise.
2407
2408 2019-06-14  Tom Tromey  <tromey@adacore.com>
2409
2410         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2411         allow assignment to an internalvar.
2412
2413 2019-06-14  Tom Tromey  <tromey@adacore.com>
2414
2415         * ada-lex.l: Allow "_" in attribute names.
2416
2417 2019-06-14  Tom Tromey  <tromey@adacore.com>
2418
2419         PR gdb/24653:
2420         * regcache.c (registers_changed): Don't call alloca.
2421         * top.c (execute_command): Don't call alloca.
2422
2423 2019-06-13  Pedro Alves  <palves@redhat.com>
2424
2425         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2426         'expression'.  When parsing an expression, error out if there's
2427         junk after "unlimited".
2428         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2429         (do_set_command): Adjust calls to is_unlimited_literal.
2430
2431 2019-06-13  Pedro Alves  <palves@redhat.com>
2432
2433         * compile/compile.c (make_compile_options_def_group): Add braces
2434         around array_view initializer.
2435         * thread.c (make_thread_apply_all_options_def_group)
2436         (make_thread_apply_all_options_def_group): Likewise.
2437
2438 2019-06-13  Pedro Alves  <palves@redhat.com>
2439
2440         * NEWS (New commands): Mention "maint test-options
2441         require-delimiter", "maint test-options unknown-is-error", "maint
2442         test-options unknown-is-operand" and "maint show
2443         test-options-completion-result".
2444         (New command options, command completion): New section.
2445         (Completion improvements): New section.
2446         Mention that you can abbreviate "unlimited".
2447
2448 2019-06-13  Pedro Alves  <palves@redhat.com>
2449
2450         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2451         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2452         * unittests/cli-utils-selftests.c (test_parse_flags)
2453         (test_parse_flags_qcs): Delete.
2454         (test_cli_utils): Don't call deleted functions.
2455
2456 2019-06-13  Pedro Alves  <palves@redhat.com>
2457
2458         * thread.c: Include "cli/cli-option.h".
2459         (tp_array_compar_ascending): Global.
2460         (tp_array_compar): Delete function.
2461         (tp_array_compar_ascending, tp_array_compar_descending): New
2462         functions.
2463         (ascending_option_def, qcs_flag_option_def)
2464         (thr_qcs_flags_option_defs)
2465         (make_thread_apply_all_options_def_group)
2466         (make_thread_apply_options_def_group): New.
2467         (thread_apply_all_command): Use gdb::option::process_options.
2468         (thread_apply_command_completer)
2469         (thread_apply_all_command_completer): New.
2470         (thread_apply_command): Use gdb::option::process_options.
2471         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2472         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2473         to generate help text of "thread apply".  Adjust "taas"'s help.
2474         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2475         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2476
2477 2019-06-13  Pedro Alves  <palves@redhat.com>
2478
2479         * thread.c (thread_apply_command): Check for invalid TID with
2480         isdigit instead of !isalpha.
2481
2482 2019-06-13  Pedro Alves  <palves@redhat.com>
2483
2484         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2485         (validate_flags_qcs): New.
2486         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2487         (validate_flags_qcs): Declare.
2488         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2489         (make_frame_apply_options_def_group): New.
2490         (frame_apply_command_count): Process options with
2491         gdb::option::process_options.
2492         (frame_apply_completer): New.
2493         (frame_apply_level_completer, frame_apply_all_completer)
2494         (frame_apply_completer): New.
2495         (_initialize_stack): Update help of "frame apply", "frame apply
2496         level", "frame apply all" and "faas" to mention supported options
2497         and install command completers.
2498         * stack.h (frame_apply_all_completer): Declare.
2499         * thread.c: Include "stack.h".
2500         (tfaas_command): Add "--".
2501         (_initialize_thread): Update help "tfaas" to mention supported
2502         options and install command completer.
2503
2504 2019-06-13  Pedro Alves  <palves@redhat.com>
2505
2506         * completer.c (complete_nested_command_line): New.
2507         (gdb_completion_word_break_characters_throw): Add assertion.
2508         * completer.h (complete_nested_command_line): Declare.
2509
2510 2019-06-13  Pedro Alves  <palves@redhat.com>
2511
2512         * stack.c (parse_backtrace_qualifiers): New.
2513         (backtrace_command): Use it.
2514         (backtrace_command_completer): Complete on qualifiers.
2515
2516 2019-06-13  Pedro Alves  <palves@redhat.com>
2517
2518         * frame.c: Include "cli/cli-option.h.
2519         (user_set_backtrace_options): New.
2520         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2521         Delete.
2522         (get_prev_frame): Adjust.
2523         (boolean_option_def, uinteger_option_def)
2524         (set_backtrace_option_defs): New.
2525         (_initialize_frame): Adjust and use
2526         gdb::option::add_setshow_cmds_for_options to install "set
2527         backtrace past-main" and "set backtrace past-entry".
2528         * frame.h: Include "cli/cli-option.h".
2529         (struct frame_print_options): Forward declare.
2530         (print_frame_arguments_all, print_frame_arguments_scalars)
2531         (print_frame_arguments_none): Declare.
2532         (print_entry_values): Delete declaration.
2533         (struct frame_print_options, user_frame_print_options): New.
2534         (struct set_backtrace_options): New.
2535         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2536         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2537         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2538         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2539         (list_args_or_locals): Add frame_print_options parameter.
2540         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2541         * python/py-framefilter.c (enumerate_args): Pass down
2542         USER_FRAME_PRINT_OPTIONS.
2543         * stack.c: Include "cli/cli-option.h".
2544         (print_frame_arguments_all, print_frame_arguments_scalars)
2545         (print_frame_arguments_none): Declare.
2546         (print_raw_frame_arguments, print_entry_values): Delete.
2547         (user_frame_print_options): New.
2548         (boolean_option_def, enum_option_def, frame_print_option_defs):
2549         New.
2550         (struct backtrace_cmd_options): New.
2551         (bt_flag_option_def): New.
2552         (backtrace_command_option_defs): New.
2553         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2554         (print_frame_arg, read_frame_arg, print_frame_args)
2555         (print_frame_info, print_frame): Add frame_print_options parameter
2556         and use it.
2557         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2558         (backtrace_command_1): Add frame_print_options and
2559         backtrace_cmd_options parameters and use them.
2560         (make_backtrace_options_def_group): New.
2561         (backtrace_command): Process command options with
2562         gdb::option::process_options.
2563         (backtrace_command_completer): New.
2564         (_initialize_stack): Extend "backtrace"'s help to mention
2565         supported options.  Install completer for "backtrace".
2566         Install some settings commands with add_setshow_cmds_for_options.
2567
2568 2019-06-13  Pedro Alves  <palves@redhat.com>
2569
2570         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2571         and that "set/show print raw frame-arguments" are now deprecated.
2572
2573         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2574         command.
2575         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2576         * stack.c (_initialize_stack): Install "set/show print
2577         raw-frame-arguments", and deprecate "set/show print raw
2578         frame-arguments".
2579         * valprint.c (_initialize_valprint): Deprecate "set/show print
2580         raw".
2581
2582 2019-06-13  Pedro Alves  <palves@redhat.com>
2583
2584         * compile/compile.c (struct compile_options): New.
2585         (compile_flag_option_def, compile_command_option_defs)
2586         (make_compile_options_def_group): New.
2587         (compile_file_command): Handle options with
2588         gdb::option::process_options.
2589         (compile_file_command_completer): New function.
2590         (compile_code_command): Handle options with
2591         gdb::option::process_options.
2592         (compile_code_command_completer): New function.
2593         (_initialize_compiler): Install completers for "compile code" and
2594         "compile file".  Mention available options in "compile code" and
2595         "compile code"'s help.
2596         * completer.c (advance_to_completion_word): New, factored out from
2597         ...
2598         (advance_to_expression_complete_word_point): ... this.
2599         (advance_to_filename_complete_word_point): New.
2600         * completer.h (advance_to_filename_complete_word_point): New
2601         declaration.
2602
2603 2019-06-13  Pedro Alves  <palves@redhat.com>
2604
2605         * compile/compile.c: Include "cli/cli-option.h".
2606         (compile_print_value): Scope data pointer is now a
2607         value_print_options pointer; adjust.
2608         (compile_print_command): Process options.  Scope data pointer is
2609         now a value_print_options pointer; adjust.
2610         (_initialize_compile): Update "compile print"'s help to include
2611         supported options.  Install a completer for "compile print".
2612         * cp-valprint.c (show_vtblprint, show_objectprint)
2613         (show_static_field_print): Delete.
2614         (_initialize_cp_valprint): Don't install "set print
2615         static-members", "set print vtbl", "set print object" here.
2616         * printcmd.c: Include "cli/cli-option.h" and
2617         "common/gdb_optional.h".
2618         (print_command_parse_format): Rework to fill in a
2619         value_print_options instead of a format_data.
2620         (print_value): Change parameter type from format_data pointer to
2621         value_print_options reference.  Adjust.
2622         (print_command_1): Process options.  Adjust to pass down a
2623         value_print_options.
2624         (print_command_completer): New.
2625         (_initialize_printcmd): Install print_command_completer as
2626         handle_brkchars completer for the "print" command.  Update
2627         "print"'s help to include supported options.
2628         * valprint.c: Include "cli/cli-option.h".
2629         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2630         here from cp-valprint.c.
2631         (boolean_option_def, uinteger_option_def)
2632         (value_print_option_defs, make_value_print_options_def_group):
2633         New.  Use gdb::option::add_setshow_cmds_for_options to install
2634         "set print elements", "set print null-stop", "set print repeats",
2635         "set print pretty", "set print union", "set print array", "set
2636         print address", "set print symbol", "set print array-indexes".
2637         * valprint.h: Include <string> and "cli/cli-option.h".
2638         (make_value_print_options_def_group): Declare.
2639         (print_value): Change parameter type from format_data pointer to
2640         value_print_options reference.
2641         (print_command_completer): Declare.
2642
2643 2019-06-13  Pedro Alves  <palves@redhat.com>
2644
2645         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2646         (COMMON_SFILES): Add maint-test-settings.c.
2647         * cli/cli-decode.c (boolean_enums): New global, factored out from
2648         ...
2649         (add_setshow_boolean_cmd): ... here.
2650         * cli/cli-decode.h (boolean_enums): Declare.
2651         * cli/cli-option.c: New file.
2652         * cli/cli-option.h: New file.
2653         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2654         factored out from ...
2655         (parse_cli_boolean_value(const char *)): ... this.
2656         (is_unlimited_literal): Change parameter type to pointer to
2657         pointer.  Adjust and advance ARG pointer.
2658         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2659         (parse_cli_var_enum): New, factored out from ...
2660         (do_set_command): ... this.  Adjust.
2661         * cli/cli-setshow.h (parse_cli_boolean_value)
2662         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2663         (parse_cli_var_enum): Declare.
2664         * cli/cli-utils.c: Include "cli/cli-option.h".
2665         (get_ulongest): New.
2666         * cli/cli-utils.h (get_ulongest): Declare.
2667         (check_for_argument): New overloads.
2668         * maint-test-options.c: New file.
2669
2670 2019-06-13  Pedro Alves  <palves@redhat.com>
2671
2672         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2673         parse a range if "-" is at the end of the string.
2674
2675 2019-06-13  Pedro Alves  <palves@redhat.com>
2676
2677         * cli/cli-setshow.c (parse_auto_binary_operation)
2678         (parse_cli_boolean_value): Don't allow "o".
2679
2680 2019-06-13  Pedro Alves  <palves@redhat.com>
2681
2682         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2683         * NEWS: Mention maint test-settings KIND.
2684         * maint-test-settings.c: New file.
2685
2686 2019-06-13  Pedro Alves  <palves@redhat.com>
2687
2688         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2689         completer.
2690         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2691         "set" completers.
2692
2693 2019-06-13  Pedro Alves  <palves@redhat.com>
2694
2695         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2696         after item.
2697
2698 2019-06-13  Pedro Alves  <palves@redhat.com>
2699
2700         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2701
2702 2019-06-13  Pedro Alves <palves@redhat.com>
2703
2704         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2705         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2706         call.
2707         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2708         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2709         calls.
2710         (check_for_argument): Skip spaces after argument.
2711
2712 2019-06-13  Pedro Alves  <palves@redhat.com>
2713
2714         * thread.c (thread_apply_command): Adjust TID parsing.
2715         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2716         detected before end of string.
2717         (tid_is_in_list): Error out if LIST is invalid.
2718
2719 2019-06-13  Pedro Alves  <palves@redhat.com>
2720
2721         * completer.c (complete_line_internal_1): Rewind completion word
2722         point.
2723         (completion_tracker::advance_custom_word_point_by): Change
2724         parameter type to int.
2725         * completer.h (completion_tracker::advance_custom_word_point_by):
2726         Likewise.
2727
2728 2019-06-13  Pedro Alves  <palves@redhat.com>
2729
2730         * completer.c (advance_to_completion_word): Handle delimiters.
2731
2732 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2733
2734         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2735
2736 2019-06-11  Tom Tromey  <tom@tromey.com>
2737
2738         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2739         (xmalloc_failed): Move to alloc.c.
2740         * alloc.c: New file.
2741         * Makefile.in (COMMON_SFILES): Add alloc.c.
2742
2743 2019-06-11  Tom Tromey  <tom@tromey.com>
2744
2745         * nat/linux-waitpid.c: Don't include server.h.
2746         (linux_debug): Remove.
2747         (my_waitpid): Update.
2748
2749 2019-06-11  Tom Tromey  <tromey@adacore.com>
2750
2751         * infcall.c (_initialize_infcall): Remove trailing newline from
2752         help.
2753         * user-regs.c (_initialize_user_regs): Remove trailing newline
2754         from help.
2755         * typeprint.c (_initialize_typeprint): Remove trailing newline
2756         from help.
2757         * reverse.c (_initialize_reverse): Remove trailing newlines from
2758         help.
2759         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2760         from help.
2761         * language.c (add_set_language_command): Remove trailing newline
2762         from help.
2763         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2764         help.
2765         * disasm.c (_initialize_disasm): Remove trailing newline from
2766         help.
2767         * top.c (init_main): Remove trailing newline from help.
2768         * interps.c (_initialize_interpreter): Remove trailing newline
2769         from help.
2770         * btrace.c (_initialize_btrace): Remove trailing newlines from
2771         help.
2772         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2773         from help.
2774         * python/python.c (_initialize_python): Remove trailing newline
2775         from help.
2776         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2777         help.
2778         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2779         from help.  Reformat some text.
2780         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2781         from help.
2782         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2783         newline from help.
2784
2785 2019-06-11  Tom Tromey  <tromey@adacore.com>
2786
2787         * darwin-nat.c (darwin_decode_exception_message)
2788         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2789
2790 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2791
2792         * valops.c (value_slice): Check for not allocated or not
2793         associated values.
2794
2795 2019-06-10  Tom de Vries  <tdevries@suse.de>
2796
2797         PR gdb/24618
2798         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2799         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2800         invalid.
2801
2802 2019-06-10  Tom de Vries  <tdevries@suse.de>
2803
2804         PR gdb/24611
2805         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2806         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2807
2808 2019-06-10  Tom de Vries  <tdevries@suse.de>
2809
2810         PR symtab/24545
2811         * symtab.c (struct demangled_name_entry): Add language field.
2812         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2813         static minimal symbol".  Set and use language field.
2814
2815 2019-06-10  Tom Tromey  <tromey@adacore.com>
2816
2817         * ada-lang.c (_initialize_ada_language): Update help text.
2818
2819 2019-06-10  Tom Tromey  <tromey@adacore.com>
2820
2821         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2822         with a newline.
2823         * guile/guile.c (handle_boot_error): Don't end warning with a
2824         newline.
2825         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2826         warning with a newline.
2827         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2828         newline.
2829         (s12z_frame_cache): Likewise.
2830         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2831         a newline.
2832         * solib-svr4.c (disable_probes_interface): Don't end warning with
2833         a newline.
2834         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2835         newline.
2836         * python/python.c (do_finish_initialization): Don't end warning
2837         with a newline.
2838
2839 2019-06-10  Tom Tromey  <tom@tromey.com>
2840
2841         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2842         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2843         gdbpy_enter.
2844
2845 2019-06-10  Tom Tromey  <tromey@adacore.com>
2846
2847         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2848         data.
2849         (elf_new_init): Don't call stabsread_new_init.
2850         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2851         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2852         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2853
2854 2019-06-10  Tom de Vries  <tdevries@suse.de>
2855
2856         PR symtab/16264
2857         PR symtab/24517
2858         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2859
2860 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2861
2862         * source.c (find_and_open_source): Also rewrite relative file
2863         names.
2864
2865 2019-04-26  Amos Bird  <amosbird@gmail.com>
2866
2867         * annotate.c (annotate_thread_exited): Add "thread-exited"
2868         annotation.
2869
2870 2019-06-06  Tom Tromey  <tromey@adacore.com>
2871
2872         * maint.h (class scoped_command_stats): Use
2873         DISABLE_COPY_AND_ASSIGN.
2874         <print_time>: New method.
2875         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2876         print_time.
2877         (scoped_command_stats::print_time): New method.
2878
2879 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2880
2881         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2882         instructions of lengths 6 or 8 bytes.
2883
2884 2019-06-04  Pedro Alves  <palves@redhat.com>
2885
2886         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2887
2888         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2889         * breakpoint.c (condition_completer): Likewise.
2890         * cli/cli-dump.c (scan_expression): Likewise.
2891         * common/filestuff.c (mkdir_recursive): Likewise.
2892         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2893         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2894         (gdb_abspath): Likewise.
2895         * compile/compile-cplus-types.c
2896         (compile_cplus_instance::decl_name): Likewise.
2897         * completer.c (complete_explicit_location):
2898         (signal_completer, reg_or_group_completer_1): Likewise.
2899         * cp-support.c (cp_remove_params_if_any): Likewise.
2900         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2901         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2902         * infcmd.c (strip_bg_char): Likewise.
2903         * linespec.c (copy_token_string): Likewise.
2904         * mi/mi-main.c (output_cores): Likewise.
2905         * psymtab.c (psymtab_search_name):
2906         * symfile.c (test_set_ext_lang_command): Likewise.
2907         * target.c (target_fileio_read_stralloc): Likewise.
2908         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2909         * value.c (complete_internalvar): Likewise.
2910
2911 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2912
2913         Add objfile property to gdb.Type.
2914         * NEWS: Mention Python API addition.
2915         * python/py-type.c (typy_get_objfile): New method.
2916
2917 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2918
2919         * NEWS: Mention the new set|show style [title|highlight].
2920         Mention changes to "show style", "help" and "apropos".
2921
2922 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2923
2924         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2925         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2926         instead of print_help_for_command.
2927         (print_doc_of_command): New function.
2928         (help_list): Add 'apropos -v word' suggestion.
2929         (print_help_for_command): Style the command name using title style.
2930         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2931         (_initialize_cli_cmds): Describe -v in apropos_command help.
2932
2933 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2934
2935         * cli/cli-style.h (cli_style_option): Add name in constructor,
2936         add m_name class member, add constructor with intensity,
2937         add name class function.
2938         (cli_style_option::add_setshow_commands): Remove name argument.
2939         (highlight_style, title_style): New styles.
2940         * cli/cli-style.c (do_show): New function that shows a style
2941         characteristic styling the style name with itself.
2942         (set_style_name): New function.
2943         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2944         Update all callers according to the changes in cli/cli-style.h.
2945         * utils.h (fputs_highlighted): New function.
2946         * utils.c (fputs_highlighted): Likewise.
2947
2948 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2949
2950         * NEWS: Mention new pipe command and new convenience variables.
2951
2952 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2953
2954         * cli/cli-cmds.c (pipe_command): New function.
2955         (_initialize_cli_cmds): Call add_com for pipe_command.
2956         Define | as an alias for pipe.
2957         (exit_status_set_internal_vars): New function.
2958         (shell_escape): Call exit_status_set_internal_vars.
2959         cli/cli-decode.c (find_command_name_length): Recognize | as
2960         a single character command.
2961
2962 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2963
2964         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2965         top.c (execute_command_to_ui_file): New function, mostly a copy
2966         of execute_command_to_string.
2967         (execute_command_to_string): Implement by calling
2968         execute_command_to_ui_file.
2969
2970 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2971
2972         * top.h (saved_command_line): Remove declaration.
2973         * top.c (previous_saved_command_line, previous_repeat_arguments):
2974         New variables.
2975         (saved_command_line): Make static, define together with other
2976         'repeat variables'.
2977         (dont_repeat): Clear repeat_arguments.
2978         (repeat_previous, get_saved_command_line, save_command_line):
2979         New functions.
2980         (gdb_init): Initialize saved_command_line
2981         and previous_saved_command_line.
2982         * main.c (captured_main_1): Remove saved_command_line initialization.
2983         * event-top.c (handle_line_of_input): Update to use
2984         the new 'repeat' related functions instead of direct access to
2985         saved_command_line.
2986         * command.h (repeat_previous, get_saved_command_line,
2987         save_command_line): New declarations.
2988         (dont_repeat): Add comment.
2989
2990 2019-05-30  Tom Tromey  <tromey@adacore.com>
2991
2992         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2993         Fix comment.
2994         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2995
2996 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2997
2998         PR cli/24587
2999         * completer.c (complete): Initialize variable word.
3000
3001 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3002
3003         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3004         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3005         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3006         'body' is NULL to the outter 'if', protecting the '!is_define'
3007         situation as well.
3008
3009 2019-05-29  Tom Tromey  <tromey@adacore.com>
3010
3011         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3012         (dwarf_unknown): New function.
3013         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3014         (dwarf_type_encoding_name): Use dwarf_unknown.
3015
3016 2019-05-29  Tom Tromey  <tromey@adacore.com>
3017
3018         PR c++/20020:
3019         * cp-valprint.c (cp_print_value_fields): Call
3020         cp_print_static_field inside "try".
3021
3022 2019-05-29  Tom Tromey  <tromey@adacore.com>
3023
3024         * inflow.c (struct terminal_info): Add default operator=.
3025         * configure: Rebuild.
3026         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3027         -Wdeprecated-copy-dtor, -Wredundant-move.
3028
3029 2019-05-29  Tom Tromey  <tromey@adacore.com>
3030
3031         * NEWS: Add entry.
3032         * infcmd.c (print_return_value_1): Handle finish_print
3033         option.
3034         (show_print_finish): New function.
3035         (_initialize_infcmd): Add "set/show print finish" commands.
3036         * valprint.c (user_print_options): Initialize new member.
3037         * valprint.h (struct value_print_options) <finish_print>: New
3038         member.
3039
3040 2019-05-28  Tom Tromey  <tromey@adacore.com>
3041
3042         * ada-lang.c (ada_remove_Xbn_suffix)
3043         (find_old_style_renaming_symbol)
3044         (parse_old_style_renaming): Remove.
3045         (ada_find_renaming_symbol): Don't call
3046         find_old_style_renaming_symbol.
3047         (ada_is_renaming_symbol): Rename from
3048         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3049         bool.  Now static.
3050         (ada_read_var_value): Update and simplify.
3051         * ada-exp.y (write_var_or_type): Remove old code.
3052
3053 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3054
3055         * event-top.c: Remove include comment.
3056         * inflow.c (class scoped_ignore_sigttou): Move from here...
3057         * inflow.h (class scoped_ignore_sigttou): ...to here.
3058         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3059         * top.c:  Remove include comment.
3060
3061 2019-05-27  Tom Tromey  <tom@tromey.com>
3062
3063         * NEWS: Fix typo.
3064
3065 2019-05-22  Tom Tromey  <tromey@adacore.com>
3066
3067         * target.c (target_follow_exec): Constify parameter.
3068         * target-delegates.c: Rebuild.
3069         * remote.c (remote_target::follow_exec): Constify parameter.
3070         * infrun.c (follow_exec): Constify parameter.
3071         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3072         (target_follow_exec): Likewise.
3073
3074 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3075
3076         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3077         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3078
3079 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3080
3081         * NEWS: Add debugredirect and testsuite sections.
3082
3083 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3084
3085         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3086         target descriptions using exclusively floating point register name
3087         aliases.
3088
3089 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3090
3091         PR gdb/18644:
3092         * f-lang.c (build_fortran_types): Handle the case where
3093         gdbarch_floatformat_for_type returns a nullptr.
3094
3095 2019-05-21  Tom de Vries  <tdevries@suse.de>
3096
3097         PR cli/24587
3098         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3099
3100 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3101
3102         PR gdb/18644:
3103         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3104         16-byte floats.
3105         * i386-tdep.c (i386_floatformat_for_type): Use
3106         floatformats_ia64_quad for the 16-byte floating point component
3107         within a fortran 32-byte complex number.
3108
3109 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3110
3111         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3112         delete default constructor.
3113         (find_partial_die): Update to return const struct.
3114         (partial_die_parent_scope): Move variable declaration into scope
3115         of its use and change its type to auto.
3116         (guess_partial_die_structure_name): Likewise.
3117         (partial_die_info::fixup): Likewise.
3118
3119 2019-05-17  Tom Tromey  <tromey@adacore.com>
3120
3121         * source.c (find_and_open_source): Remove cast.
3122
3123 2019-05-17  Tom Tromey  <tromey@adacore.com>
3124
3125         * annotate.c (annotate_source): Make "filename" const.
3126         * annotate.h (annotate_source): Use const.
3127
3128 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3129
3130         * disasm.c (set_disassembler_options): Send errors to stderr.
3131
3132 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3133
3134         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3135         (cli_interp_base::set_logging): Check debug_redirect.
3136         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3137         * cli/cli-logging.c (debug_redirect): Add static variable.
3138         (pop_output_files): Add default param.
3139         (handle_redirections): Print debug setting.
3140         (show_logging_command): Likewise.
3141         (_initialize_cli_logging): Add debugredirect command.
3142         * interps.c (current_interp_set_logging): Add debug_redirect
3143         parameter.
3144         * interps.h (set_logging): Add debug_redirect parameter.
3145         (current_interp_set_logging): Likewise.
3146         * mi/mi-common.h: Likewise.
3147         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3148
3149 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3150             Tom Tromey  <tromey@adacore.com>
3151
3152         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3153         directly.
3154         * cli/cli-interp.h (make_logging_output): Remove declaration.
3155         * cli/cli-logging.c (make_logging_output): Remove function.
3156         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3157         directly.
3158         * ui-file.c (tee_file::tee_file): Remove bools.
3159         (tee_file::~tee_file): Remove deletes.
3160         * ui-file.h (tee_file): Remove bools.
3161
3162 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3163
3164         * mi/mi-cmds.h (mi_cmd_complete): New function.
3165         * mi/mi-main.c (mi_cmd_complete): Likewise.
3166         * mi/mi-cmds.c: Define new MI command -complete.
3167         * NEWS: Mention new -complete command.
3168
3169 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3170
3171         * completer.h (complete): New function.
3172         * completer.c (complete): Likewise.
3173         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3174         function defined in completer.h.
3175
3176 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3177
3178         * MAINTAINERS (Write After Approval): Add myself.
3179
3180 2019-05-17  Tom de Vries  <tdevries@suse.de>
3181
3182         PR gdb/24094
3183         * dwarf2read.c (struct cu_partial_die_info): New struct.
3184         (find_partial_die): Return cu_partial_die_info.
3185         (partial_die_parent_scope, guess_partial_die_structure_name)
3186         (partial_die_info::fixup): Handle new return type of find_partial_die.
3187
3188 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3189
3190         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3191         "std::string", simplifying the algorithm.
3192
3193 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3194
3195         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3196         (stap_static_probe_ops::get_probes): Likewise.
3197
3198 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3199
3200         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3201         '-')" and "else if".
3202         (stap_parse_single_operand): Join checks for
3203         "gdbarch_stap_parse_special_token_p" and
3204         "gdbarch_stap_parse_special_token" in the same "if" statement.
3205         Invert check when verifying for operation on register
3206         displacement.
3207
3208 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3209
3210         * stap-probe.c (stap_get_opcode): Update comment.
3211         (stap_get_expected_argument_type): Likewise.
3212         (handle_stap_probe): Likewise.
3213
3214 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3215
3216         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3217         return type to 'bool'.  Adjust comment.  Use 'bool' when
3218         appropriate.
3219         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3220         * stap-probe.c (stap_parse_argument_1): Likewise.
3221         (stap_is_operator): Likewise.
3222         (stap_is_generic_prefix): Likewise.
3223         (stap_is_register_prefix): Likewise.
3224         (stap_is_register_indirection_prefix): Likewise.
3225         (stap_is_integer_prefix): Likewise.
3226         (stap_generic_check_suffix): Likewise.
3227         (stap_check_integer_suffix): Likewise.
3228         (stap_check_register_suffix): Likewise.
3229         (stap_check_register_indirection_suffix): Likewise.
3230         (stap_parse_register_operand): Likewise.
3231         (stap_parse_single_operand): Likewise.
3232         (stap_parse_argument_1): Likewise.
3233         (stap_probe::get_argument_count): Likewise.
3234         (stap_is_operator): Likewise.
3235
3236 2019-05-16  Tom Tromey  <tromey@adacore.com>
3237
3238         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3239         keyword to foreach.
3240
3241 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3242
3243         * linux-thread-db.c (try_thread_db_load_1): Change return type
3244         to bool.
3245         (try_thread_db_load): Likewise.
3246         (try_thread_db_load_from_pdir_1): Likewise.
3247         (try_thread_db_load_from_pdir): Likewise.
3248         (try_thread_db_load_from_sdir): Likewise.
3249         (try_thread_db_load_from_dir): Likewise.
3250         (thread_db_load_search): Likewise.
3251         (has_libpthread): Likewise.
3252         (thread_db_load): Likewise.
3253
3254 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3255
3256         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3257         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3258         NULL, and complain/return if that's the case.
3259
3260 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3261
3262         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3263         (advance, posn, abstract_read_memory): New functions.
3264         [struct mem_read_abstraction]: New struct.
3265         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3266
3267 2019-05-14  Tom Tromey  <tromey@adacore.com>
3268
3269         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3270         value is not lval_memory.
3271
3272 2019-05-14  Tom Tromey  <tromey@adacore.com>
3273
3274         * solib.c (info_sharedlibrary_command): Style the file name.
3275
3276 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3277
3278         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3279         (aarch64_vnv_type): Likewise.
3280         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3281         * common/tdesc.c: Likewise.
3282         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3283         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3284         * features/aarch64-fpu.xml: Add ieee half view.
3285         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3286         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3287         * gdbtypes.h (struct builtin_type): Likewise.
3288         (struct objfile_type): Likewise.
3289
3290 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3291
3292         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3293         typo.
3294         * location.h (string_to_event_location): Likewise.
3295
3296 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3297
3298         GDB 8.3 released.
3299
3300 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3301
3302         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3303         New variable declaration.
3304         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3305         New variable.
3306         (print_one_breakpoint): Use ui_out::test_flags and new global
3307         variable to compute use_fixed_output.
3308         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3309         Remove.
3310         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3311         (mi_multi_location_breakpoint_output_fixed): Remove.
3312         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3313         new variable.
3314         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3315         fix_multi_location_breakpoint_output flag if version >= 3.
3316         * ui-out.h (enum ui_out_flag)
3317         <fix_multi_location_breakpoint_output>: New enumerator.
3318
3319 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3320
3321         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3322
3323 2019-05-10  Tom Tromey  <tromey@adacore.com>
3324
3325         * ada-lang.c (catch_ada_completer): New function.
3326         (_initialize_ada_language): Use it.
3327
3328 2019-05-10  Tom Tromey  <tromey@adacore.com>
3329
3330         * thread.c (print_thread_info): Make "requested_threads" const.
3331         * gdbthread.h (print_thread_info): Make "requested_threads"
3332         const.
3333         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3334         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3335
3336 2019-05-08  Tom Tromey  <tom@tromey.com>
3337
3338         * gdbtypes.c (objfile_type_data): Change type.
3339         (objfile_type, _initialize_gdbtypes): Update.
3340
3341 2019-05-08  Tom Tromey  <tom@tromey.com>
3342
3343         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3344         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3345         (_initialize_dwarf2_frame): Update.
3346
3347 2019-05-08  Tom Tromey  <tom@tromey.com>
3348
3349         * objc-lang.c (objc_objfile_data): Change type.
3350         (find_methods): Update.
3351         (_initialize_objc_lang): Remove.
3352
3353 2019-05-08  Tom Tromey  <tom@tromey.com>
3354
3355         * stabsread.c (rs6000_builtin_type_data): Change type.
3356         (rs6000_builtin_type, _initialize_stabsread): Update.
3357
3358 2019-05-08  Tom Tromey  <tom@tromey.com>
3359
3360         * mips-tdep.c (mips_pdr_data): Remove.
3361         (_initialize_mips_tdep): Update.
3362
3363 2019-05-08  Tom Tromey  <tom@tromey.com>
3364
3365         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3366         (hppa_init_objfile_priv_data, read_unwind_info)
3367         (find_unwind_entry, _initialize_hppa_tdep): Update.
3368
3369 2019-05-08  Tom Tromey  <tom@tromey.com>
3370
3371         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3372         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3373         on obstack.
3374         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3375
3376 2019-05-08  Tom Tromey  <tom@tromey.com>
3377
3378         * mdebugread.c (basic_type_data): Change type.
3379         (basic_type, _initialize_mdebugread): Update.
3380
3381 2019-05-08  Tom Tromey  <tom@tromey.com>
3382
3383         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3384
3385 2019-05-08  Tom Tromey  <tom@tromey.com>
3386
3387         * nto-tdep.c (nto_inferior_data_reg): Change type.
3388         (nto_inferior_data): Update.
3389         (nto_inferior_data_cleanup, nto_new_inferior_data)
3390         (_initialize_nto_tdep): Remove.
3391         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3392
3393 2019-05-08  Tom Tromey  <tom@tromey.com>
3394
3395         * ada-lang.c (struct ada_inferior_data): Add initializers.
3396         (ada_inferior_data): Change type.
3397         (ada_inferior_data_cleanup): Remove.
3398         (get_ada_inferior_data, ada_inferior_exit)
3399         (struct ada_pspace_data): Add initializers, destructor.
3400         (ada_pspace_data_handle): Change type.
3401         (get_ada_pspace_data): Update.
3402         (ada_pspace_data_cleanup): Remove.
3403
3404 2019-05-08  Tom Tromey  <tom@tromey.com>
3405
3406         * coffread.c (struct coff_symfile_info): Add initializers.
3407         (coff_objfile_data_key): Move lower.  Change type.
3408         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3409         Update.
3410         (coff_free_info): Remove.
3411
3412 2019-05-08  Tom Tromey  <tom@tromey.com>
3413
3414         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3415         (fbsd_pspace_data_handle): Move lower.  Change type.
3416         (get_fbsd_pspace_data): Update.
3417         (fbsd_pspace_data_cleanup): Remove.
3418         (_initialize_fbsd_tdep): Update.
3419
3420 2019-05-08  Tom Tromey  <tom@tromey.com>
3421
3422         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3423         (get_ada_tasks_pspace_data): Update.
3424         (ada_tasks_pspace_data_cleanup): Remove.
3425         (_initialize_tasks): Update.
3426         (ada_tasks_inferior_data_handle): Change type.
3427         (get_ada_tasks_inferior_data): Update.
3428         (ada_tasks_inferior_data_cleanup): Remove.
3429         (struct ada_tasks_pspace_data): Add initializers.
3430
3431 2019-05-08  Tom Tromey  <tom@tromey.com>
3432
3433         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3434         * symfile-debug.c (debug_sym_get_probes): Change type.
3435         * stap-probe.c (handle_stap_probe):
3436         (stap_static_probe_ops::get_probes): Change type.
3437         * probe.h (class static_probe_ops) <get_probes>: Change type.
3438         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3439         (parse_probes_in_pspace): Update.
3440         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3441         Update.
3442         (any_static_probe_ops::get_probes): Change type.
3443         * elfread.c (elfread_data): New typedef.
3444         (probe_key): Change type.
3445         (elf_get_probes): Likewise.  Update.
3446         (probe_key_free): Remove.
3447         (_initialize_elfread): Update.
3448         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3449         Change type.
3450         (dtrace_process_dof_probe, dtrace_process_dof)
3451         (dtrace_static_probe_ops::get_probe): Change type.
3452
3453 2019-05-08  Tom Tromey  <tom@tromey.com>
3454
3455         * xcoffread.c (struct xcoff_symfile_info): Rename from
3456         coff_symfile_info.  Add initializers.
3457         (xcoff_objfile_data_key): Move lower.  Change type.
3458         (XCOFF_DATA): Rewrite.
3459         (xcoff_free_info): Remove.
3460         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3461         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3462         (xcoff_initial_scan): Update.
3463
3464 2019-05-08  Tom Tromey  <tom@tromey.com>
3465
3466         * solib-svr4.c (struct svr4_info): Add initializers and
3467         destructor.
3468         <probes_table>: Now an htab_up.
3469         (solib_svr4_pspace_data): Change type.
3470         (free_probes_table): Simplify.
3471         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3472         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3473         (probes_table_remove_objfile_probes, register_solib_event_probe)
3474         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3475         (_initialize_svr4_solib): Update.
3476
3477 2019-05-08  Tom Tromey  <tom@tromey.com>
3478
3479         * remote.c (remote_pspace_data): Change type.
3480         (remote_pspace_data_cleanup): Remove.
3481         (get_remote_exec_file, set_pspace_remote_exec_file)
3482         (_initialize_remote): Update.
3483
3484 2019-05-08  Tom Tromey  <tom@tromey.com>
3485
3486         * breakpoint.c (breakpoint_objfile_key): Change type.
3487         (get_breakpoint_objfile_data): Update.
3488         (free_breakpoint_objfile_data): Remove.
3489         (_initialize_breakpoint): Update.
3490
3491 2019-05-08  Tom Tromey  <tom@tromey.com>
3492
3493         * linux-tdep.c (struct linux_info): Add initializers.
3494         (linux_inferior_data): Move.  Change type.
3495         (invalidate_linux_cache_inf): Update.
3496         (linux_inferior_data_cleanup): Remove.
3497         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3498
3499 2019-05-08  Tom Tromey  <tom@tromey.com>
3500
3501         * auxv.c (auxv_inferior_data): Move.  Change type.
3502         (auxv_inferior_data_cleanup): Remove.
3503         (invalidate_auxv_cache_inf): Rewrite.
3504         (get_auxv_inferior_data, _initialize_auxv): Update.
3505
3506 2019-05-08  Tom Tromey  <tom@tromey.com>
3507
3508         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3509         (symfile_debug_objfile_data_key): Change type.
3510         (symfile_debug_installed, debug_qf_has_symbols)
3511         (debug_qf_find_last_source_symtab)
3512         (debug_qf_forget_cached_source_info)
3513         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3514         (debug_qf_print_stats, debug_qf_dump)
3515         (debug_qf_expand_symtabs_for_function)
3516         (debug_qf_expand_all_symtabs)
3517         (debug_qf_expand_symtabs_with_fullname)
3518         (debug_qf_map_matching_symbols)
3519         (debug_qf_expand_symtabs_matching)
3520         (debug_qf_find_pc_sect_compunit_symtab)
3521         (debug_qf_map_symbol_filenames)
3522         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3523         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3524         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3525         (debug_sym_read_linetable, debug_sym_relocate): Update.
3526         (symfile_debug_free_objfile): Remove.
3527         (install_symfile_debug_logging, _initialize_symfile_debug):
3528         Update.
3529
3530 2019-05-08  Tom Tromey  <tom@tromey.com>
3531
3532         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3533         allocate_on_obstack.
3534         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3535         (get_dwarf2_per_objfile): Update.
3536         (set_dwarf2_per_objfile): Remove.
3537         (dwarf2_has_info, dwarf2_get_section_info): Update.
3538         (dwarf2_free_objfile): Remove.
3539         (_initialize_dwarf2_read): Update.
3540
3541 2019-05-08  Tom Tromey  <tom@tromey.com>
3542
3543         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3544         initializers.
3545         <unsupported_script_warning_printed,
3546         script_not_found_warning_printed>: Now bool.
3547         (auto_load_pspace_data): Change type.
3548         (~auto_load_pspace_info): Rename from
3549         auto_load_pspace_data_cleanup.
3550         (get_auto_load_pspace_data, init_loaded_scripts_info)
3551         (clear_section_scripts, maybe_print_unsupported_script_warning)
3552         (maybe_print_script_not_found_warning, _initialize_auto_load):
3553         Update.
3554
3555 2019-05-08  Tom Tromey  <tom@tromey.com>
3556
3557         * objfiles.c (objfile_pspace_info): Add destructor and
3558         initializers.
3559         (objfiles_pspace_data): Change type.
3560         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3561         (get_objfile_pspace_data): Update.
3562         (objfiles_bfd_data): Change type.
3563         (get_objfile_bfd_data): Update.
3564         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3565
3566 2019-05-08  Tom Tromey  <tom@tromey.com>
3567
3568         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3569         Change type.
3570         (get_catch_syscall_inferior_data): Update.
3571         (catch_syscall_inferior_data_cleanup): Remove.
3572         (_initialize_break_catch_syscall): Update.
3573
3574 2019-05-08  Tom Tromey  <tom@tromey.com>
3575
3576         * inflow.c (struct terminal_info): Add destructor and
3577         initializers.
3578         (inflow_inferior_data): Change type.
3579         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3580         (get_inflow_inferior_data, inflow_inferior_exit)
3581         (swap_terminal_info, _initialize_inflow): Update.
3582
3583 2019-05-08  Tom Tromey  <tom@tromey.com>
3584
3585         * target-dcache.c (target_dcache_cleanup): Remove.
3586         (target_dcache_aspace_key): Change type.
3587         (target_dcache_init_p, target_dcache_invalidate)
3588         (target_dcache_get, target_dcache_get_or_init)
3589         (_initialize_target_dcache): Update.
3590         * dcache.h (struct dcache_deleter): New.
3591
3592 2019-05-08  Tom Tromey  <tom@tromey.com>
3593
3594         * symtab.c (struct symbol_cache): Add destructor and
3595         initializers.
3596         (symbol_cache_key): Move.  Change type.
3597         (make_symbol_cache, free_symbol_cache): Remove.
3598         (get_symbol_cache): Update.
3599         (symbol_cache_cleanup): Remove.
3600         (ALL_PSPACES, symbol_cache_flush)
3601         (maintenance_print_symbol_cache)
3602         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3603         Update.
3604
3605 2019-05-08  Tom Tromey  <tom@tromey.com>
3606
3607         * symtab.c (struct main_info): Add destructor and initializers.
3608         (main_progspace_key): Move.  Change type.
3609         (get_main_info): Update.
3610         (main_info_cleanup): Remove.
3611         (_initialize_symtab): Update.
3612
3613 2019-05-08  Tom Tromey  <tom@tromey.com>
3614
3615         * registry.h (DECLARE_REGISTRY): Define the _key class.
3616
3617 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3618
3619         * NEWS: Merge two 'New commands' sections.
3620
3621 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3622
3623         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3624         parameter and use Ada language definition instead.
3625         (ada_val_print_ptr): Remove unused language parameter.
3626         (ada_val_print_num): Remove language parameter and use Ada language
3627         definition instead.
3628         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3629         parameter.
3630         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3631         parameter and use Ada language definition instead.
3632         (ada_val_print_1): Update all ada_val_print_xxx calls.
3633         Remove language parameter.
3634         (ada_val_print): Update ada_val_print_1 call.
3635
3636 2019-05-08  Tom Tromey  <tromey@adacore.com>
3637
3638         * remote.c (remote_hw_watchpoint_limit)
3639         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3640         Now static.
3641
3642 2019-05-08  Tom Tromey  <tromey@adacore.com>
3643
3644         * maint.c (_initialize_maint_cmds): Move initialization code to
3645         remote.c.
3646         (watchdog, show_watchdog): Move to remote.c.
3647         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3648         "watchdog" static.
3649         (_initialize_remote): Move initialization code from maint.c.
3650         * defs.h (watchdog): Don't declare.
3651
3652 2019-05-08  Tom Tromey  <tromey@adacore.com>
3653
3654         * tui/tui-interp.c: Include main.h.
3655         * interps.c: Include main.h.
3656         * main.h (interpreter_p): Declare.
3657         * defs.h (interpreter_p): Don't declare.
3658
3659 2019-05-08  Tom Tromey  <tromey@adacore.com>
3660
3661         * dwarf2loc.c: Include dwarf2read.h.
3662         * defs.h (read_unsigned_leb128): Don't declare.
3663         * dwarf2read.h (read_unsigned_leb128): Declare.
3664
3665 2019-05-08  Tom Tromey  <tromey@adacore.com>
3666
3667         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3668         method.
3669
3670 2019-05-08  Tom Tromey  <tromey@adacore.com>
3671
3672         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3673         when no wrap column is set.
3674
3675 2019-05-08  Tom Tromey  <tromey@adacore.com>
3676
3677         * c-lang.c (c_get_string): Handle non-C-style arrays.
3678
3679 2019-05-08  Tom Tromey  <tromey@adacore.com>
3680
3681         * typeprint.c (print_offset_data::update): Print the bit offset,
3682         not the number of bits remaining.
3683
3684 2019-05-08  Tom Tromey  <tromey@adacore.com>
3685
3686         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3687         padding at end of comment.
3688
3689 2019-05-08  Tom Tromey  <tromey@adacore.com>
3690
3691         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3692         Compare main types.
3693
3694 2019-05-06  Tom Tromey  <tom@tromey.com>
3695
3696         * common/scoped_mmap.c: Include common-defs.h.
3697         * common/scoped_mmap.h: Don't include config.h.
3698
3699 2019-05-04  Tom Tromey  <tom@tromey.com>
3700
3701         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3702         (struct aarch64_call_info): Add initializers.
3703         <si>: Now a std::vector.
3704         (pass_on_stack, aarch64_push_dummy_call): Update.
3705
3706 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3707             Tom Tromey  <tom@tromey.com>
3708
3709         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3710         (ppc_threads): Now a std::vector.  Now static.
3711         (hwdebug_find_thread_points_by_tid)
3712         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3713         Update.
3714
3715 2019-05-04  Tom Tromey  <tom@tromey.com>
3716
3717         * arc-tdep.c (arc_tdesc_init): Return bool.
3718
3719 2019-05-04  Tom Tromey  <tom@tromey.com>
3720
3721         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3722         Use gdb_assert_not_reached.
3723
3724 2019-05-04  Tom Tromey  <tom@tromey.com>
3725
3726         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3727         "false".
3728
3729 2019-05-04  Tom Tromey  <tom@tromey.com>
3730
3731         * arc-tdep.c (arc_tdesc_init): Use bool.
3732
3733 2019-05-04  Tom Tromey  <tom@tromey.com>
3734
3735         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3736
3737 2019-05-04  Tom Tromey  <tom@tromey.com>
3738
3739         * cli/cli-cmds.c (valid_command_p): Return bool.
3740
3741 2019-05-04  Tom Tromey  <tom@tromey.com>
3742
3743         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3744         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3745
3746 2019-05-04  Raul Tambre  <raul@tambre.ee>
3747
3748         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3749         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3750         operator for comparison.
3751
3752 2019-05-04  Tom Tromey  <tom@tromey.com>
3753
3754         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3755         (lookup_partial_symbol, print_partial_symbols)
3756         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3757         (psymbol_compare): Update.
3758         (add_psymbol_to_bcache): Clear the entire psymbol.
3759         (maintenance_check_psymtabs): Update.
3760         * psympriv.h (struct partial_symbol): Don't derive from
3761         general_symbol_info.
3762         <obj_section, unrelocated_address, address,
3763         set_unrelocated_address>: Update.
3764         <ginfo>: New member.
3765         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3766         (debug_names::write_psymbols): Update.
3767
3768 2019-05-04  Tom de Vries  <tdevries@suse.de>
3769
3770         * contrib/cc-with-tweaks.sh: Support -n arg.
3771
3772 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3773
3774         * corelow.c (core_target::detach): Ensure frame cache and
3775         register caches are cleared.
3776         inferior.c (exit_inferior_1): Likewise.
3777
3778 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3779             Tom Tromey  <tom@tromey.com>
3780
3781         * dictionary.c (collate_pending_symbols_by_language): Remove
3782         "struct" from foreach.
3783         * symtab.c (lookup_global_symbol_from_objfile)
3784         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3785         foreach.
3786         * ser-tcp.c (net_open): Remove "struct" from foreach.
3787         * objfiles.c (objfile_relocate, objfile_rebase)
3788         (objfile_has_symbols): Remove "struct" from foreach.
3789         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3790         from foreach.
3791         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3792         foreach.
3793         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3794         "struct" from foreach.
3795         * ada-lang.c (create_excep_cond_exprs)
3796         (ada_exception_catchpoint_cond_string): Remove "struct" from
3797         foreach.
3798
3799 2019-05-03  Tom Tromey  <tromey@adacore.com>
3800
3801         * ada-exp.y (convert_char_literal): Check suffix of each
3802         enumerator.
3803
3804 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3805
3806         PR ada/21406:
3807         * ada-exp.y (yywrap): Don't define.
3808         * ada-lex.l (%option): Add noyywrap
3809         (yywrap): Remove.
3810
3811 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3812
3813         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3814         _WIN32_WINNT to the XP level, unless already defined to a higher
3815         level.
3816
3817         * unittests/parse-connection-spec-selftests.c:
3818         * ser-tcp.c:
3819         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3820         override.
3821
3822         * symfile.c (find_separate_debug_file): Remove colon from the
3823         drive spec of DOS/Windows file names of the target, so that the
3824         file name produced from DEBUGDIR and the target's directory will
3825         be valid on DOS/Windows systems.
3826
3827 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3828
3829         * rust-lang.c (val_print_struct): Handle printing structures
3830         containing strings.
3831
3832 2019-05-02  Tom Tromey  <tromey@adacore.com>
3833
3834         * valarith.c (_initialize_valarith): Remove.
3835
3836 2019-05-01  Tom Tromey  <tromey@adacore.com>
3837
3838         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3839         bitfields.
3840
3841 2019-05-01  Tom Tromey  <tromey@adacore.com>
3842
3843         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3844         for big-endian copies.
3845
3846 2019-04-30  Ali Tamur  <tamur@google.com>
3847         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3848         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3849         (read_3_bytes): New function.
3850
3851 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3852
3853         * windows-nat.c (main_thread_id): Delete.
3854         (handle_output_debug_string): Replace main_thread_id by
3855         current_event.dwThreadId.
3856         (fake_create_process): Likewise.
3857         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3858         Do not set main_thread_id.
3859         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3860         current_event.dwThreadId.
3861         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3862
3863 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3864
3865         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3866         Use current_event.dwThreadId instead of main_thread_id.
3867
3868 2019-04-30  Tom Tromey  <tromey@adacore.com>
3869
3870         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3871         (create_excep_cond_exprs): Iterate over program spaces.
3872         (ada_exception_catchpoint_cond_string): Examine all minimal
3873         symbols for exception types.
3874
3875 2019-04-30  Tom Tromey  <tromey@adacore.com>
3876
3877         PR c++/24470:
3878         * dwarf2read.c (process_structure_scope): Handle case where type
3879         has template parameters but no symbol was created.
3880
3881 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3882             Chris January  <chris.january@arm.com>
3883
3884         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3885         qualifier.
3886         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3887
3888 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3889
3890         * f-typeprint.c (f_print_type): Update rules for printing
3891         whitespace.
3892         (f_type_print_varspec_suffix): Likewise.
3893
3894 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3895             Chris January  <chris.january@arm.com>
3896
3897         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3898         function arguments.
3899
3900 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3901
3902         * f-lang.c (build_fortran_types): Change name of void type to
3903         lower case.
3904         * f-typeprint.c (f_type_print_base): Print the name of the void
3905         type, rather than a fixed string.
3906         * f-valprint.c (f_decorations): Use lower case void string.
3907
3908 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3909             Chris January  <chris.january@arm.com>
3910
3911         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3912         types for Fortran.
3913
3914 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3915             Chris January  <chris.january@arm.com>
3916             David Lecomber  <david.lecomber@arm.com>
3917
3918         * f-exp.y (BINOP_INTRINSIC): New token.
3919         (exp): New parser rule handling BINOP_INTRINSIC.
3920         (f77_keywords): Add new builtin procedures.
3921         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3922         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3923         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3924         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3925         (print_unop_subexp_f): New function.
3926         (print_binop_subexp_f): New function.
3927         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3928         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3929         (dump_subexp_body_f): Likewise.
3930         (operator_check_f): Likewise.
3931         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3932         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3933
3934 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3935
3936         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3937         UNOP_KIND.
3938         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3939         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3940         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3941         (operator_length_f): New fuction.
3942         (print_subexp_f): New function.
3943         (op_name_f): New function.
3944         (dump_subexp_body_f): New function.
3945         (operator_check_f): New function.
3946         (exp_descriptor_f): Replace standard expression handling functions
3947         with new functions.
3948         * gdb/fortran-operator.def: New file.
3949         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3950         * gdb/std-operator.def: Remove UNOP_KIND.
3951
3952 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3953
3954         * std-operator.def: Remove unbalanced, stray double quote
3955         character.
3956
3957 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3958             Chris January  <chris.january@arm.com>
3959             Daniel Everett  <daniel.everett@arm.com>
3960             Nick Forrington  <nick.forrington@arm.com>
3961             Richard Bunt  <richard.bunt@arm.com>
3962
3963         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3964         of depth when printing anonymous structs or unions.
3965         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3966         Don't print either the top-level value, or the children if the
3967         max-depth is exceeded.
3968         (ppscm_print_children): When printing the key of a map, allow one
3969         extra level of depth.
3970         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3971         print either the top-level value, or the children if the max-depth
3972         is exceeded.
3973         (print_children): When printing the key of a map, allow one extra
3974         level of depth.
3975         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3976         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3977         (user_print_options): Initialise max_depth field.
3978         (val_print_scalar_or_string_type_p): New function.
3979         (val_print): Check to see if the max depth has been reached.
3980         (val_print_check_max_depth): Define new function.
3981         (show_print_max_depth): New function.
3982         (_initialize_valprint): Add 'print max-depth' option.
3983         * valprint.h (struct value_print_options) <max_depth>: New field.
3984         (val_print_check_max_depth): Declare new function.
3985         * NEWS: Document new feature.
3986
3987 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3988
3989         * ada-lang.c (ada_language_defn): Initialise new field.
3990         * c-lang.c (c_is_string_type_p): New function.
3991         (c_language_defn): Initialise new field.
3992         (cplus_language_defn): Initialise new field.
3993         (asm_language_defn): Initialise new field.
3994         (minimal_language_defn): Initialise new field.
3995         * c-lang.h (c_is_string_type_p): Declare new function.
3996         * d-lang.c (d_language_defn): Initialise new field.
3997         * f-lang.c (f_is_string_type_p): New function.
3998         (f_language_defn): Initialise new field.
3999         * go-lang.c (go_is_string_type_p): New function.
4000         (go_language_defn): Initialise new field.
4001         * language.c (default_is_string_type_p): New function.
4002         (unknown_language_defn): Initialise new field.
4003         (auto_language_defn): Initialise new field.
4004         * language.h (struct language_defn) <la_is_string_type_p>: New
4005         member variable.
4006         (default_is_string_type_p): Declare new function.
4007         * m2-lang.c (m2_language_defn): Initialise new field.
4008         * objc-lang.c (objc_language_defn): Initialise new field.
4009         * opencl-lang.c (opencl_language_defn): Initialise new field.
4010         * p-lang.c (pascal_is_string_type_p): New function.
4011         (pascal_language_defn): Initialise new field.
4012         * rust-lang.c (rust_is_string_type_p): New function.
4013         (rust_language_defn): Initialise new field.
4014
4015 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4016
4017         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4018         New field.
4019         * ada-lang.c (ada_language_defn): Initialise new field.
4020         * c-lang.c (c_language_defn): Likewise.
4021         (cplus_language_defn): Likewise.
4022         (asm_language_defn): Likewise.
4023         (minimal_language_defn): Likewise.
4024         * d-lang.c (d_language_defn): Likewise.
4025         * f-lang.c (f_language_defn): Likewise.
4026         * go-lang.c (go_language_defn): Likewise.
4027         * language.c (unknown_language_defn): Likewise.
4028         (auto_language_defn): Likewise.
4029         * m2-lang.c (m2_language_defn): Likewise.
4030         * objc-lang.c (objc_language_defn): Likewise.
4031         * opencl-lang.c (opencl_language_defn): Likewise.
4032         * p-lang.c (pascal_language_defn): Likewise.
4033         * rust-lang.c (rust_language_defn): Likewise.
4034
4035 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4036
4037         * ada-lang.c (ada_is_character_type): Change return type to bool.
4038         (ada_is_string_type): Likewise.
4039         * ada-lang.h (ada_is_character_type): Update declaration
4040         (ada_is_string_type): Likewise.
4041
4042 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4043
4044         Support style in 'frame|thread apply'
4045
4046         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4047         * record.c (record_start, record_stop): Update callers of
4048         execute_command_to_string with false.
4049         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4050         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4051         methods.
4052         (class string_file): New constructor with term_out parameter.
4053         Override methods term_out and can_emit_style_escape.  New member
4054         term_out.
4055         (class stdio_file): Override can_emit_style_escape.
4056         (class tee_file): Override term_out and can_emit_style_escape.
4057         * utils.h (can_emit_style_escape): Remove.
4058         * utils.c (can_emit_style_escape): Likewise.
4059         Update all callers of can_emit_style_escape (SOMESTREAM) to
4060         SOMESTREAM->can_emit_style_escape.
4061         * source-cache.c (source_cache::get_source_lines): Likewise.
4062         * stack.c (frame_apply_command_count): Call execute_command_to_string
4063         passing the term_out characteristic of the current gdb_stdout.
4064         * thread.c (thr_try_catch_cmd): Likewise.
4065         * top.c (execute_command_to_string): pass term_out parameter
4066         to construct the string_file for the command output.
4067         * ui-file.c (term_cli_styling): New function (most code moved
4068         from utils.c can_emit_style_escape).
4069         (string_file::string_file, string_file::can_emit_style_escape,
4070         stdio_file::can_emit_style_escape, tee_file::term_out,
4071         tee_file::can_emit_style_escape): New functions.
4072
4073 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4074
4075         * NEWS: Mention the new set|show may-call-functions.
4076         * infcall.c (may_call_functions_p): New variable.
4077         (show_may_call_functions_p): New function.
4078         (call_function_by_hand_dummy): Throws an error if not
4079         may-call-functions.
4080         (_initialize_infcall): Call add_setshow_boolean_cmd for
4081         may-call-functions.
4082
4083 2019-04-25  Keith Seitz  <keiths@redhat.com>
4084
4085         PR c++/24367
4086         * cp-support.c (inspect_type): Don't attempt substitutions
4087         of symbol with the same name.
4088
4089 2019-04-25  Tom Tromey  <tromey@adacore.com>
4090
4091         PR gdb/24475:
4092         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4093         static.
4094
4095 2019-04-25  Tom Tromey  <tromey@adacore.com>
4096
4097         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4098         rvalue reference.
4099         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4100         (gdb_xml_parser::parse): Use std::move.
4101         * python/python-internal.h (gdbpy_convert_exception): Take a const
4102         reference.
4103         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4104         std::move.
4105         * python/py-utils.c (gdbpy_convert_exception): Take a const
4106         reference.
4107         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4108         Use std::move.
4109         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4110         Use std::move.
4111         * mi/mi-main.c (mi_print_exception): Take a const reference.
4112         * main.c (handle_command_errors): Take a const reference.
4113         * linespec.c (parse_linespec): Use std::move.
4114         * infcall.c (run_inferior_call): Use std::move.
4115         (call_function_by_hand_dummy): Use std::move.
4116         * exec.c (try_open_exec_file): Use std::move.
4117         * exceptions.h (exception_print, exception_fprintf)
4118         (exception_print_same): Update.
4119         * exceptions.c (print_exception, exception_print)
4120         (exception_fprintf, exception_print_same): Change parameters to
4121         const reference.
4122         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4123         * common/new-op.c: Use std::move.
4124         * common/common-exceptions.h (struct gdb_exception): Add move
4125         constructor.
4126         (struct gdb_exception_error, struct gdb_exception_quit, struct
4127         gdb_quit_bad_alloc): Change constructor to move constructor.
4128         (throw_exception): Change parameter to rvalue reference.
4129         * common/common-exceptions.c (throw_exception): Take rvalue
4130         reference.
4131         * cli/cli-interp.c (safe_execute_command): Use std::move.
4132         * breakpoint.c (insert_bp_location, location_to_sals): Use
4133         std::move.
4134
4135 2019-04-25  Tom Tromey  <tromey@adacore.com>
4136
4137         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4138         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4139         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4140         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4141         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4142         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4143         guile/scm-value.c: Use unpack.
4144         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4145         gdbscm_gdb_exception.
4146         (gdbscm_throw_gdb_exception): Likewise.
4147         (struct gdbscm_gdb_exception): New.
4148         (unpack): New function.
4149         (gdbscm_wrap): Use unpack.
4150
4151 2019-04-25  Tom Tromey  <tromey@adacore.com>
4152
4153         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4154         (gdb_rl_callback_handler): Use std::move.
4155         * common/common-exceptions.h (struct gdb_exception): Add move
4156         assignment operator.
4157         (throw_exception_sjlj): Change "exception" to const reference.
4158         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4159         (throw_exception_sjlj): Change "exception" to const reference.
4160
4161 2019-04-25  Tom Tromey  <tromey@adacore.com>
4162
4163         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4164         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4165         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4166         Update.
4167         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4168         Update.
4169         * mi/mi-interp.c (mi_interp::exec): Update.
4170         * linespec.c (parse_linespec): Update.
4171         * infcall.c (run_inferior_call): Update.
4172         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4173         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4174         (gdbscm_lookup_global_symbol): Update.
4175         * guile/scm-param.c (gdbscm_parameter_value): Update.
4176         * guile/scm-frame.c (gdbscm_frame_read_register)
4177         (gdbscm_frame_read_var): Update.
4178         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4179         * exec.c (try_open_exec_file): Update.
4180         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4181         (gdb_rl_callback_handler): Update.
4182         * common/common-exceptions.h (exception_none): Don't declare.
4183         * common/common-exceptions.c (exception_none): Don't define.
4184         (struct catcher) <exception>: Update.
4185         * cli/cli-interp.c (safe_execute_command): Update.
4186         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4187
4188 2019-04-25  Ali Tamur  <tamur@google.com>
4189
4190         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4191         (read_attribute_value): Likewise.
4192         (dwarf2_read_addr_index): Update comment.
4193         (read_str_index): Add DW_FORM_strx.
4194         (dwarf2_string_attr): Likewise.
4195         (dwarf2_const_value_attr): Likewise.
4196         (dump_die_shallow): Likewise.
4197         (dwarf2_fetch_constant_bytes): Likewise.
4198         (skip_form_bytes): Likewise.
4199         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4200
4201 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4202
4203         PR corefiles/11608
4204         PR corefiles/18187
4205         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4206         OFFSET.  Verify if current mapping contains an ELF header.
4207         (linux_find_memory_regions_full): Adjust call to
4208         dump_mapping_p.
4209
4210 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4211             Kang Li <kanglictf@gmail.com>
4212
4213         PR gdb/21600
4214
4215         * dwarf2-frame.c (read_initial_length): Be consistent about using
4216         unsigned representation of length.
4217         (decode_frame_entry_1): Likewise.  Check for wraparound of
4218         end pointer as well as buffer overflow.
4219
4220 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4221
4222         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4223         "vq".
4224
4225 2019-04-24  Tom Tromey  <tromey@adacore.com>
4226
4227         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4228
4229 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4230
4231         * s12z-tdep.c (s12z_unwind_pc): Delete.
4232         (s12z_unwind_sp): Delete.
4233         (s12z_gdbarch_init): Don't register deleted functions with
4234         gdbarch.
4235
4236 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4237
4238         * rl78-tdep.c (rl78_unwind_sp): Delete.
4239         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4240
4241 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4242
4243         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4244         (xstormy16_unwind_pc): Delete.
4245         (xstormy16_dummy_id): Delete.
4246         (xstormy16_gdbarch_init): Don't register deleted functions with
4247         gdbarch.
4248
4249 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4250
4251         * vax-tdep.c (vax_unwind_pc): Delete.
4252         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4253
4254 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4255
4256         * v850-tdep.c (v850_unwind_sp): Delete.
4257         (v850_unwind_pc): Delete.
4258         (v850_dummy_id): Delete.
4259         (v850_gdbarch_init): Don't register deleted functions with
4260         gdbarch.
4261
4262 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4263
4264         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4265         (tilegx_unwind_pc): Delete.
4266         (tilegx_unwind_dummy_id): Delete.
4267         (tilegx_gdbarch_init): Don't register deleted functions with
4268         gdbarch.
4269
4270 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4271
4272         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4273         (tic6x_dummy_id): Delete.
4274         (tic6x_gdbarch_init): Don't register deleted functions with
4275         gdbarch.
4276
4277 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4278
4279         * sparc-tdep.c (sparc_unwind_pc): Delete.
4280         (sparc32_gdbarch_init): Don't register deleted function with
4281         gdbarch.
4282
4283 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4284
4285         * sh-tdep.c (sh_unwind_sp): Delete.
4286         (sh_unwind_pc): Delete.
4287         (sh_dummy_id): Delete.
4288         (sh_gdbarch_init): Don't register deleted functions with
4289         gdbarch.
4290
4291 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4292
4293         * score-tdep.c (score_unwind_sp): Delete.
4294         (score_unwind_pc): Delete.
4295         (score_dummy_id): Delete.
4296         (score_gdbarch_init): Don't register deleted functions with
4297         gdbarch.
4298
4299 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4300
4301         * rx-tdep.c (rx_unwind_pc): Delete.
4302         (rx_unwind_sp): Delete.
4303         (rx_dummy_id): Delete.
4304         (rx_gdbarch_init): Don't register deleted functions with
4305         gdbarch.  Update comment.
4306
4307 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4308
4309         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4310         (rs6000_dummy_id): Delete.
4311         (rs6000_gdbarch_init): Don't register deleted functions with
4312         gdbarch.
4313
4314 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4315
4316         * or1k-tdep.c (or1k_dummy_id): Delete.
4317         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4318
4319 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4320
4321         * nios2-tdep.c (nios2_dummy_id): Delete.
4322         (nios2_unwind_sp): Delete.
4323         (nios2_gdbarch_init): Don't register deleted functions with
4324         gdbarch.
4325
4326 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4327
4328         * nds32-tdep.c (nds32_dummy_id): Delete.
4329         (nds32_unwind_pc): Delete.
4330         (nds32_unwind_sp): Delete.
4331         (nds32_gdbarch_init): Don't register deleted functions with
4332         gdbarch.
4333
4334 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4335
4336         * msp430-tdep.c (msp430_unwind_pc): Delete.
4337         (msp430_unwind_sp): Delete.
4338         (msp430_dummy_id): Delete.
4339         (msp430_gdbarch_init): Don't register deleted functions with
4340         gdbarch.
4341
4342 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4343
4344         * moxie-tdep.c (moxie_unwind_sp): Delete.
4345         (moxie_unwind_pc): Delete.
4346         (moxie_dummy_id): Delete.
4347         (moxie_gdbarch_init): Don't register deleted functions with
4348         gdbarch.
4349
4350 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4351
4352         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4353         (mn10300_unwind_pc): Delete.
4354         (mn10300_unwind_sp): Delete.
4355         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4356         mn10300_unwind_sp.
4357         (mn10300_frame_unwind_init): Don't register deleted functions with
4358         gdbarch.
4359
4360 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4361
4362         * mep-tdep.c (mep_unwind_pc): Delete.
4363         (mep_unwind_sp): Delete.
4364         (mep_dummy_id): Delete.
4365         (mep_gdbarch_init): Don't register deleted functions with
4366         gdbarch.
4367
4368 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4369
4370         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4371         (m68hc11_unwind_sp): Delete.
4372         (m68hc11_gdbarch_init): Don't register deleted functions with
4373         gdbarch.
4374
4375 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4376
4377         * m32r-tdep.c (m32r_unwind_sp): Delete.
4378         (m32r_unwind_pc): Delete.
4379         (m32r_dummy_id): Delete.
4380         (m32r_gdbarch_init): Don't register deleted functions with
4381         gdbarch.
4382
4383 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4384
4385         * m32c-tdep.c (m32c_unwind_pc): Delete.
4386         (m32c_unwind_sp): Delete.
4387         (m32c_dummy_id): Delete.
4388         (m32c_gdbarch_init): Don't register deleted functions with
4389         gdbarch.
4390
4391 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4392
4393         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4394         (lm32_unwind_pc): Delete.
4395         (lm32_dummy_id): Delete.
4396         (lm32_gdbarch_init): Don't register deleted functions with
4397         gdbarch.
4398
4399 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4400
4401         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4402         (iq2000_unwind_pc): Delete.
4403         (iq2000_dummy_id): Delete.
4404         (iq2000_gdbarch_init): Don't register deleted functions with
4405         gdbarch.
4406
4407 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4408
4409         * nds32-tdep.c (nds32_type_align): Delete.
4410         (nds32_push_dummy_call): Use type_align instead.
4411
4412 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4413
4414         * arm-tdep.c (arm_type_align): Only handle vector override case.
4415         (arm_push_dummy_call): Use type_align.
4416         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4417
4418 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4419
4420         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4421         case.
4422         (pass_on_stack): Use type_align.
4423         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4424         function.
4425
4426 2019-04-23  Tom Tromey  <tromey@adacore.com>
4427
4428         * dwarf2read.c (line_header::file_name_at): Remove unused
4429         overload.
4430
4431 2019-04-23  Tom de Vries  <tdevries@suse.de>
4432
4433         PR gdb/24438
4434         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4435         invocation.
4436
4437
4438 2019-03-27  Ali Tamur  <tamur@google.com>
4439
4440         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4441         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4442         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4443         (dwarf_expr_context::get_addr_index): Likewise
4444         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4445         (symbol_needs_eval_context::get_addr_index): Likewise
4446         (disassemble_dwarf_expression): Add DW_OP_addrx
4447         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4448         (read_cutu_die_from_dwo): Update comment
4449         (skip_one_die): Add DW_FORM_addrx
4450         (read_attribute_value): Likewise
4451         (var_decode_location): Add DW_OP_addrx
4452         (dwarf2_const_value_attr): Add DW_FORM_addrx
4453         (dump_die_shallow): Likewise
4454         (dwarf2_fetch_constant_bytes): Likewise
4455         (decode_locdesc): Add DW_OP_addrx
4456         (skip_form_bytes): Add DW_FORM_addrx
4457
4458 2019-04-22  Ali Tamur  <tamur@google.com>
4459
4460         * MAINTAINERS (Write After Approval): Add self.
4461
4462 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4463
4464         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4465         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4466         (open_symbol_file_object): Likewise.
4467         (svr4_default_sos): Add info parameter.
4468         (svr4_read_so_list): Likewise.
4469         (svr4_current_sos_direct): Adjust functions calls to pass down
4470         info.
4471         (svr4_current_sos_1): Add info parameter.
4472         (svr4_current_sos): Call get_svr4_info, pass info down to
4473         svr4_current_sos_1.
4474         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4475         get_svr4_info.
4476         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4477         get_svr4_info.
4478         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4479         to get_svr4_info.
4480         (probes_table_remove_objfile_probes): Likewise.
4481         (register_solib_event_probe): Add info parameter.
4482         (solist_update_incremental): Pass info parameter down to
4483         svr4_read_so_list.
4484         (disable_probes_interface): Add info parameter.
4485         (svr4_handle_solib_event): Pass current_program_space to
4486         get_svr4_info.  Adjust disable_probes_interface cleanup.
4487         (svr4_create_probe_breakpoints): Add info parameter, pass it
4488         down to register_solib_event_probe.
4489         (svr4_create_solib_event_breakpoints): Add info parameter,
4490         pass it down to svr4_create_probe_breakpoints.
4491         (enable_break): Pass info down to
4492         svr4_create_solib_event_breakpoints.
4493         (svr4_solib_create_inferior_hook): Pass current_program_space to
4494         get_svr4_info.
4495         (svr4_clear_solib): Likewise.
4496
4497 2019-04-22  Pedro Alves  <palves@redhat.com>
4498
4499         * solib-svr4.c (svr4_free_objfile_observer): New.
4500         (probe_and_action::objfile): New field.
4501         (probes_table_htab_remove_objfile_probes)
4502         (probes_table_remove_objfile_probes): New functions.
4503         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4504         in the new probe_and_action.  Don't store the probe in 'lookup'.
4505         (svr4_create_probe_breakpoints): Pass objfile to
4506         register_solib_event_probe.
4507         (_initialize_svr4_solib): Register a free_objfile observer.
4508
4509 2019-04-19  Tom Tromey  <tom@tromey.com>
4510
4511         * common/queue.h: Remove.
4512
4513 2019-04-19  Tom Tromey  <tom@tromey.com>
4514
4515         * event-loop.c: Don't include "common/queue.h".
4516
4517 2019-04-19  Tom Tromey  <tom@tromey.com>
4518
4519         * remote.c (remote_target): Use delete.
4520         * remote-notif.h: Include <list>, not "common/queue.h".
4521         (notif_client_p): Remove typedef.
4522         (remote_notif_state): Add constructor, destructor, initializer.
4523         <notif_queue>: Now a std::list.
4524         (remote_notif_state_xfree): Don't declare.
4525         * remote-notif.c (remote_notif_process, handle_notification)
4526         (remote_notif_state_allocate): Update.
4527         (~remote_notif_state): Rename from remote_notif_state_xfree.
4528
4529 2019-04-19  Tom Tromey  <tom@tromey.com>
4530
4531         * symfile.c (reread_symbols): Update.
4532         * objfiles.c (objfile_register_static_link)
4533         (objfile_lookup_static_link): Update
4534         (~objfile) Don't delete static_links.
4535         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4536
4537 2019-04-19  Tom Tromey  <tom@tromey.com>
4538
4539         * type-stack.h (struct type_stack) <insert>: Constify string.
4540         * type-stack.c (type_stack::insert): Constify string.
4541         * gdbtypes.h (lookup_template_type): Update.
4542         (address_space_name_to_int): Update.
4543         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4544         const.
4545         (lookup_template_type): Make name const.
4546         * c-exp.y: Update rules.
4547         (lex_one_token, classify_name, classify_inner_name)
4548         (c_print_token): Update.
4549         * p-exp.y: Update rules.
4550         (yylex): Update.
4551         * f-exp.y: Update rules.
4552         (yylex): Update.
4553         * d-exp.y: Update rules.
4554         (lex_one_token, classify_name, classify_inner_name): Update.
4555         * parse.c (write_dollar_variable, copy_name): Return std::string.
4556         * parser-defs.h (copy_name): Change return type.
4557         * m2-exp.y: Update rules.
4558         (yylex): Update.
4559         * go-exp.y (lex_one_token): Update.
4560         Update rules.
4561         (classify_unsafe_function, classify_packaged_name)
4562         (classify_name, yylex): Update.
4563
4564 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4565
4566         * configure.ac: add --enable-source-highlight switch.
4567         * configure: Regenerate.
4568         * top.c (print_gdb_version): plumb --enable-source-highlight
4569         status to "show configuration".
4570
4571 2019-04-19  Tom Tromey  <tromey@adacore.com>
4572
4573         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4574         Check ADA_TYPE_P.
4575         (empty_record, ada_template_to_fixed_record_type_1)
4576         (template_to_static_fixed_type)
4577         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4578         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4579         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4580         macros.
4581
4582 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4583
4584         PR symtab/24423:
4585         * source.c (print_source_lines_base): Advance "iter" when a
4586         control character is seen.
4587
4588 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4589
4590         * inferior.h (struct infcall_suspend_state_deleter):
4591         Catch exception in destructor to avoid crash.
4592
4593 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4594
4595         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4596         close to the add_com "shell".
4597
4598 2019-04-18  Tom Tromey  <tromey@adacore.com>
4599
4600         * process-stratum-target.h (class process_stratum_target)
4601         <stratum>: Add "final".
4602
4603 2019-04-17  Tom Tromey  <tromey@adacore.com>
4604
4605         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4606         against nullptr before use.
4607
4608 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4609
4610         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4611
4612 2019-04-17  Jim Wilson  <jimw@sifive.com>
4613             Andrew Burgess  <andrew.burgess@embecosm.com>
4614
4615         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4616         code read might fail, assume 4-byte breakpoint in that case.
4617
4618 2019-04-15  Leszek Swirski  <leszeks@google.com>
4619
4620         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4621         rather than a hand-rolled POD check when checking for forced MEMORY
4622         classification.
4623
4624 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4625
4626         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4627         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4628         function.
4629         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4630         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4631         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4632         declaration.
4633
4634 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4635
4636         * aarch64-linux-nat.c
4637         (aarch64_linux_nat_target::thread_architecture): Add override.
4638         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4639         each VQ.
4640
4641 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4642
4643         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4644
4645 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4646
4647         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4648         target types of size 96-bits, add some additional comments, and
4649         check that the builtin type we found was the correct size.
4650
4651 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4652
4653         * utils.c (prompt_for_continue): Don't restore the styling at the
4654         end, as applied_style has the wrong value.  This fixes styling in
4655         long lists of file names that are interrupted by the "Continue?"
4656         prompt.
4657
4658 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4659
4660         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4661         * c-lang.c (c_language_defn): Likewise.
4662         (cplus_language_defn): Likewise.
4663         (asm_language_defn): Likewise.
4664         (minimal_language_defn): Likewise.
4665         * d-lang.c (d_language_defn): Likewise.
4666         * f-lang.c (f_language_defn): Likewise.
4667         * go-lang.c (go_language_defn): Likewise.
4668         * language.c (unknown_language_defn): Likewise.
4669         (auto_language_defn): Likewise.
4670         * language.h (struct language_defn): Remove la_magic field.
4671         (LANG_MAGIC): Delete.
4672         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4673         * objc-lang.c (objc_language_defn): Likewise.
4674         * opencl-lang.c (opencl_language_defn): Likewise.
4675         * p-lang.c (pascal_language_defn): Likewise.
4676         * rust-lang.c (rust_language_defn): Likewise.
4677
4678 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4679
4680         * riscv-tdep.c (riscv_type_align): New function.
4681         (riscv_type_alignment): Delete.
4682         (riscv_arg_location): Use 'type_align'.
4683         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4684
4685 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4686
4687         * gdbtypes.c (type_align): A struct with no non-static fields also
4688         has alignment of 1.
4689
4690 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4691
4692         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4693         component to 0.
4694         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4695         member.
4696         (riscv_struct_info::analyse): New implementation using new
4697         analyse_inner member function.
4698         (riscv_struct_info::field_offset): New member function.
4699         (riscv_struct_info::m_offsets): New member variable.
4700         (riscv_struct_info::analyse_inner): New private member function,
4701         takes the old implementation of riscv_struct_info::analyse but
4702         extended to track field offsets.
4703         (riscv_call_arg_struct): Update the struct folding special cases
4704         to handle cases where empty C++ structs, which are non-zero
4705         length, are found.
4706         (riscv_arg_location): Initialise the length of each location, a
4707         non-zero length now indicates the location is in use.
4708         (riscv_push_dummy_call): Allow for the first location having a
4709         non-zero offset when setting up arguments.
4710         (riscv_return_value): Likewise, but for return values.
4711
4712 2019-04-11  Tom Tromey  <tromey@adacore.com>
4713
4714         * utils.c (internal_vproblem): Make "msg" const.
4715
4716 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4717
4718         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4719         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4720         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4721         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4722
4723 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4724
4725         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4726         function.
4727         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4728         of amd64_collect_native_gregset.
4729         (amd64_linux_nat_target::store_registers): Likewise.
4730
4731 2019-04-10  Tom Tromey  <tom@tromey.com>
4732
4733         * symtab.c (lookup_global_symbol_from_objfile)
4734         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4735         * objfiles.h (class separate_debug_iterator): New.
4736         (class separate_debug_range): New.
4737         (struct objfile) <separate_debug_objfiles>: New method.
4738         (objfile_separate_debug_iterate): Don't declare.
4739         * objfiles.c (separate_debug_iterator::operator++): Rename from
4740         objfile_separate_debug_iterate.
4741         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4742         iterator.
4743         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4744         iterator.
4745
4746 2019-04-10  Tom Tromey  <tom@tromey.com>
4747
4748         * symfile.c (reread_symbols): Remove old comment.
4749         * objfiles.c (free_all_objfiles): Fix a typo.
4750
4751 2019-04-10  Tom Tromey  <tom@tromey.com>
4752
4753         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4754         * minsyms.c (lookup_minimal_symbol): Use foreach.
4755         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4756         (lookup_minimal_symbol_solib_trampoline): Likewise.
4757         * symfile.c (reread_symbols): Use foreach.
4758
4759 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4760             Tom Tromey  <tromey@adacore.com>
4761
4762         PR rust/24414:
4763         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4764         (rust_lex_int_test): Change "value" to be LONGEST.
4765         (rust_lex_tests): Add test for long integer literal.
4766
4767 2019-04-09  Tom Tromey  <tromey@adacore.com>
4768
4769         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4770         to bool.
4771         (extended_remote_target::attach): Update.
4772         (remote_target::remote_notice_new_inferior): Update.
4773         (remote_target::add_current_inferior_and_thread): Update.
4774         * inferior.c (exit_inferior_1): Use "false".
4775         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4776
4777 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4778
4779         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4780         the "start" command.
4781
4782 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4783
4784         * python/py-inferior.c (infpy_thread_from_thread_handle):
4785         Adjust comments to reflect renaming of thread_from_thread_handle
4786         to thread_from_handle.  Adjust keywords.  Fix type error message.
4787         (inferior_object_methods): Add thread_from_handle.  Retain
4788         thread_from_thread_handle, but mark it as deprecated.
4789
4790 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4791
4792         * gdbthread.h (find_thread_by_handle): Revise declaration.
4793         * thread.c (find_thread_by_handle): Likewise.  Adjust
4794         implementation too.
4795         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4796         support for buffer objects as handles.
4797
4798 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4799
4800         * python/py-infthread.c (thpy_thread_handle): New function.
4801         (thread_object_methods): Register thpy_thread_handle.
4802
4803 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4804
4805         * gdbthread.h (thread_to_thread_handle): Declare.
4806         * thread.c (gdbtypes.h): Include.
4807         (thread_to_thread_handle): New function.
4808
4809         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4810         (target_thread_info_to_thread_handle): Declare.
4811         * target.c (target_thread_info_to_thread_handle): New function.
4812         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4813         * target-delegates.c: Regenerate.
4814
4815         * linux-thread-db.c (class thread_db_target): Add method
4816         thread_info_to_thread_handle.
4817         (thread_db_target::thread_info_to_thread_handle): Define.
4818         * remote.c (class remote_target): Add new method
4819         thread_info_to_thread_handle.
4820         (remote_target::thread_info_to_thread_handle): Define.
4821
4822 2019-04-08  Pedro Alves  <palves@redhat.com>
4823
4824         * common/common-exceptions.c (throw_exception): Don't create
4825         named object to throw; throw directly.
4826         (throw_it): Likewise.  Don't initialize gdb_exception::message
4827         here, with new; pass FMT and AP to the ctor instead.
4828         * common/common-exceptions.h: Include <string>.
4829         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4830         const char *, va_list)): New ctor.  Use std::make_shared.
4831         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4832         errors)): Delete.
4833         (gdb_exception_error::gdb_exception_error(enum errors, const char
4834         *, va_list)): New.
4835         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4836         Add assertion.
4837         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4838         errors)): Delete.
4839         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4840         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4841         Add assertion.
4842
4843 2019-04-08  Tom Tromey  <tom@tromey.com>
4844
4845         * valops.c (value_rtti_indirect_type): Replace throw_exception
4846         with throw.
4847         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4848         with throw.
4849         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4850         throw.
4851         * target.c (target_translate_tls_address): Replace throw_exception
4852         with throw.
4853         * stack.c (frame_apply_command_count): Replace throw_exception
4854         with throw.
4855         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4856         throw.
4857         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4858         with throw.
4859         * rs6000-tdep.c (rs6000_frame_cache)
4860         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4861         * remote.c: Replace throw_exception with throw.
4862         * record-full.c (record_full_message, record_full_wait_1)
4863         (record_full_restore): Replace throw_exception with throw.
4864         * record-btrace.c:
4865         (get_thread_current_frame_id, record_btrace_start_replaying)
4866         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4867         (cmd_record_btrace_start): Replace throw_exception with throw.
4868         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4869         throw.
4870         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4871         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4872         * linespec.c:
4873         (find_linespec_symbols): Replace throw_exception with throw.
4874         * infrun.c (displaced_step_prepare, resume): Replace
4875         throw_exception with throw.
4876         * infcmd.c (post_create_inferior): Replace throw_exception with
4877         throw.
4878         * inf-loop.c (inferior_event_handler): Replace throw_exception
4879         with throw.
4880         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4881         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4882         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4883         (get_prev_frame_always, get_frame_pc_if_available)
4884         (get_frame_address_in_block_if_available, get_frame_language):
4885         Replace throw_exception with throw.
4886         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4887         throw_exception with throw.
4888         * eval.c (fetch_subexp_value, evaluate_var_value)
4889         (evaluate_funcall, evaluate_subexp_standard): Replace
4890         throw_exception with throw.
4891         * dwarf2loc.c (call_site_find_chain)
4892         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4893         Replace throw_exception with throw.
4894         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4895         with throw.
4896         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4897         throw.
4898         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4899         * completer.c (complete_line_internal): Replace throw_exception
4900         with throw.
4901         * compile/compile-object-run.c (compile_object_run): Replace
4902         throw_exception with throw.
4903         * cli/cli-script.c (process_next_line): Replace throw_exception
4904         with throw.
4905         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4906         (btrace_enable, btrace_maint_update_pt_packets): Replace
4907         throw_exception with throw.
4908         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4909         throw_exception with throw.
4910         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4911         throw_exception with throw.
4912         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4913         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4914         * aarch64-tdep.c (aarch64_make_prologue_cache)
4915         (aarch64_make_stub_cache): Replace throw_exception with throw.
4916
4917 2019-04-08  Tom Tromey  <tom@tromey.com>
4918
4919         * common/common-exceptions.c (throw_exception): Rename from
4920         throw_exception_cxx.  Remove old copy.  Make argument const.
4921         (throw_it): Create and throw exception objects directly.
4922         * common/common-exceptions.h (throw_exception): Make argument
4923         const.
4924         (struct gdb_exception_error): Add constructor.
4925         (struct gdb_exception_quit): Add constructor.
4926
4927 2019-04-08  Tom Tromey  <tom@tromey.com>
4928
4929         * common/common-exceptions.h (exception_rethrow): Don't declare.
4930         (TRY_SJLJ): Update comment.
4931         (TRY, CATCH, END_CATCH): Remove.
4932         * common/common-exceptions.c (exception_rethrow): Remove.
4933
4934 2019-04-08  Tom Tromey  <tom@tromey.com>
4935
4936         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4937         Remove.
4938         (gdb_exception_error): Rename from
4939         gdb_exception_RETURN_MASK_ERROR.
4940         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4941         (gdb_quit_bad_alloc): Update.
4942         * aarch64-tdep.c: Update.
4943         * ada-lang.c: Update.
4944         * ada-typeprint.c: Update.
4945         * ada-valprint.c: Update.
4946         * amd64-tdep.c: Update.
4947         * arch-utils.c: Update.
4948         * break-catch-throw.c: Update.
4949         * breakpoint.c: Update.
4950         * btrace.c: Update.
4951         * c-varobj.c: Update.
4952         * cli/cli-cmds.c: Update.
4953         * cli/cli-interp.c: Update.
4954         * cli/cli-script.c: Update.
4955         * common/common-exceptions.c: Update.
4956         * common/new-op.c: Update.
4957         * common/selftest.c: Update.
4958         * compile/compile-c-symbols.c: Update.
4959         * compile/compile-cplus-symbols.c: Update.
4960         * compile/compile-object-load.c: Update.
4961         * compile/compile-object-run.c: Update.
4962         * completer.c: Update.
4963         * corelow.c: Update.
4964         * cp-abi.c: Update.
4965         * cp-support.c: Update.
4966         * cp-valprint.c: Update.
4967         * darwin-nat.c: Update.
4968         * disasm-selftests.c: Update.
4969         * dtrace-probe.c: Update.
4970         * dwarf-index-cache.c: Update.
4971         * dwarf-index-write.c: Update.
4972         * dwarf2-frame-tailcall.c: Update.
4973         * dwarf2-frame.c: Update.
4974         * dwarf2loc.c: Update.
4975         * dwarf2read.c: Update.
4976         * eval.c: Update.
4977         * event-loop.c: Update.
4978         * event-top.c: Update.
4979         * exec.c: Update.
4980         * f-valprint.c: Update.
4981         * fbsd-tdep.c: Update.
4982         * frame-unwind.c: Update.
4983         * frame.c: Update.
4984         * gdbtypes.c: Update.
4985         * gnu-v3-abi.c: Update.
4986         * guile/guile-internal.h: Update.
4987         * guile/scm-block.c: Update.
4988         * guile/scm-breakpoint.c: Update.
4989         * guile/scm-cmd.c: Update.
4990         * guile/scm-disasm.c: Update.
4991         * guile/scm-frame.c: Update.
4992         * guile/scm-lazy-string.c: Update.
4993         * guile/scm-math.c: Update.
4994         * guile/scm-param.c: Update.
4995         * guile/scm-ports.c: Update.
4996         * guile/scm-pretty-print.c: Update.
4997         * guile/scm-symbol.c: Update.
4998         * guile/scm-symtab.c: Update.
4999         * guile/scm-type.c: Update.
5000         * guile/scm-value.c: Update.
5001         * i386-linux-tdep.c: Update.
5002         * i386-tdep.c: Update.
5003         * inf-loop.c: Update.
5004         * infcall.c: Update.
5005         * infcmd.c: Update.
5006         * infrun.c: Update.
5007         * jit.c: Update.
5008         * language.c: Update.
5009         * linespec.c: Update.
5010         * linux-fork.c: Update.
5011         * linux-nat.c: Update.
5012         * linux-tdep.c: Update.
5013         * linux-thread-db.c: Update.
5014         * main.c: Update.
5015         * mi/mi-cmd-break.c: Update.
5016         * mi/mi-cmd-stack.c: Update.
5017         * mi/mi-interp.c: Update.
5018         * mi/mi-main.c: Update.
5019         * objc-lang.c: Update.
5020         * p-valprint.c: Update.
5021         * parse.c: Update.
5022         * ppc-linux-tdep.c: Update.
5023         * printcmd.c: Update.
5024         * python/py-arch.c: Update.
5025         * python/py-breakpoint.c: Update.
5026         * python/py-cmd.c: Update.
5027         * python/py-finishbreakpoint.c: Update.
5028         * python/py-frame.c: Update.
5029         * python/py-framefilter.c: Update.
5030         * python/py-gdb-readline.c: Update.
5031         * python/py-inferior.c: Update.
5032         * python/py-infthread.c: Update.
5033         * python/py-lazy-string.c: Update.
5034         * python/py-linetable.c: Update.
5035         * python/py-objfile.c: Update.
5036         * python/py-param.c: Update.
5037         * python/py-prettyprint.c: Update.
5038         * python/py-progspace.c: Update.
5039         * python/py-record-btrace.c: Update.
5040         * python/py-record.c: Update.
5041         * python/py-symbol.c: Update.
5042         * python/py-type.c: Update.
5043         * python/py-unwind.c: Update.
5044         * python/py-utils.c: Update.
5045         * python/py-value.c: Update.
5046         * python/python.c: Update.
5047         * record-btrace.c: Update.
5048         * record-full.c: Update.
5049         * remote-fileio.c: Update.
5050         * remote.c: Update.
5051         * riscv-tdep.c: Update.
5052         * rs6000-aix-tdep.c: Update.
5053         * rs6000-tdep.c: Update.
5054         * rust-exp.y: Update.
5055         * rust-lang.c: Update.
5056         * s390-tdep.c: Update.
5057         * selftest-arch.c: Update.
5058         * solib-dsbt.c: Update.
5059         * solib-frv.c: Update.
5060         * solib-spu.c: Update.
5061         * solib-svr4.c: Update.
5062         * solib.c: Update.
5063         * sparc64-linux-tdep.c: Update.
5064         * stack.c: Update.
5065         * symfile-mem.c: Update.
5066         * symmisc.c: Update.
5067         * target.c: Update.
5068         * thread.c: Update.
5069         * top.c: Update.
5070         * tracefile-tfile.c: Update.
5071         * tui/tui.c: Update.
5072         * typeprint.c: Update.
5073         * unittests/cli-utils-selftests.c: Update.
5074         * unittests/parse-connection-spec-selftests.c: Update.
5075         * valops.c: Update.
5076         * valprint.c: Update.
5077         * value.c: Update.
5078         * varobj.c: Update.
5079         * windows-nat.c: Update.
5080         * x86-linux-nat.c: Update.
5081         * xml-support.c: Update.
5082
5083 2019-04-08  Tom Tromey  <tom@tromey.com>
5084
5085         * xml-support.c: Use C++ exception handling.
5086         * x86-linux-nat.c: Use C++ exception handling.
5087         * windows-nat.c: Use C++ exception handling.
5088         * varobj.c: Use C++ exception handling.
5089         * value.c: Use C++ exception handling.
5090         * valprint.c: Use C++ exception handling.
5091         * valops.c: Use C++ exception handling.
5092         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5093         handling.
5094         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5095         * typeprint.c: Use C++ exception handling.
5096         * tui/tui.c: Use C++ exception handling.
5097         * tracefile-tfile.c: Use C++ exception handling.
5098         * top.c: Use C++ exception handling.
5099         * thread.c: Use C++ exception handling.
5100         * target.c: Use C++ exception handling.
5101         * symmisc.c: Use C++ exception handling.
5102         * symfile-mem.c: Use C++ exception handling.
5103         * stack.c: Use C++ exception handling.
5104         * sparc64-linux-tdep.c: Use C++ exception handling.
5105         * solib.c: Use C++ exception handling.
5106         * solib-svr4.c: Use C++ exception handling.
5107         * solib-spu.c: Use C++ exception handling.
5108         * solib-frv.c: Use C++ exception handling.
5109         * solib-dsbt.c: Use C++ exception handling.
5110         * selftest-arch.c: Use C++ exception handling.
5111         * s390-tdep.c: Use C++ exception handling.
5112         * rust-lang.c: Use C++ exception handling.
5113         * rust-exp.y: Use C++ exception handling.
5114         * rs6000-tdep.c: Use C++ exception handling.
5115         * rs6000-aix-tdep.c: Use C++ exception handling.
5116         * riscv-tdep.c: Use C++ exception handling.
5117         * remote.c: Use C++ exception handling.
5118         * remote-fileio.c: Use C++ exception handling.
5119         * record-full.c: Use C++ exception handling.
5120         * record-btrace.c: Use C++ exception handling.
5121         * python/python.c: Use C++ exception handling.
5122         * python/py-value.c: Use C++ exception handling.
5123         * python/py-utils.c: Use C++ exception handling.
5124         * python/py-unwind.c: Use C++ exception handling.
5125         * python/py-type.c: Use C++ exception handling.
5126         * python/py-symbol.c: Use C++ exception handling.
5127         * python/py-record.c: Use C++ exception handling.
5128         * python/py-record-btrace.c: Use C++ exception handling.
5129         * python/py-progspace.c: Use C++ exception handling.
5130         * python/py-prettyprint.c: Use C++ exception handling.
5131         * python/py-param.c: Use C++ exception handling.
5132         * python/py-objfile.c: Use C++ exception handling.
5133         * python/py-linetable.c: Use C++ exception handling.
5134         * python/py-lazy-string.c: Use C++ exception handling.
5135         * python/py-infthread.c: Use C++ exception handling.
5136         * python/py-inferior.c: Use C++ exception handling.
5137         * python/py-gdb-readline.c: Use C++ exception handling.
5138         * python/py-framefilter.c: Use C++ exception handling.
5139         * python/py-frame.c: Use C++ exception handling.
5140         * python/py-finishbreakpoint.c: Use C++ exception handling.
5141         * python/py-cmd.c: Use C++ exception handling.
5142         * python/py-breakpoint.c: Use C++ exception handling.
5143         * python/py-arch.c: Use C++ exception handling.
5144         * printcmd.c: Use C++ exception handling.
5145         * ppc-linux-tdep.c: Use C++ exception handling.
5146         * parse.c: Use C++ exception handling.
5147         * p-valprint.c: Use C++ exception handling.
5148         * objc-lang.c: Use C++ exception handling.
5149         * mi/mi-main.c: Use C++ exception handling.
5150         * mi/mi-interp.c: Use C++ exception handling.
5151         * mi/mi-cmd-stack.c: Use C++ exception handling.
5152         * mi/mi-cmd-break.c: Use C++ exception handling.
5153         * main.c: Use C++ exception handling.
5154         * linux-thread-db.c: Use C++ exception handling.
5155         * linux-tdep.c: Use C++ exception handling.
5156         * linux-nat.c: Use C++ exception handling.
5157         * linux-fork.c: Use C++ exception handling.
5158         * linespec.c: Use C++ exception handling.
5159         * language.c: Use C++ exception handling.
5160         * jit.c: Use C++ exception handling.
5161         * infrun.c: Use C++ exception handling.
5162         * infcmd.c: Use C++ exception handling.
5163         * infcall.c: Use C++ exception handling.
5164         * inf-loop.c: Use C++ exception handling.
5165         * i386-tdep.c: Use C++ exception handling.
5166         * i386-linux-tdep.c: Use C++ exception handling.
5167         * guile/scm-value.c: Use C++ exception handling.
5168         * guile/scm-type.c: Use C++ exception handling.
5169         * guile/scm-symtab.c: Use C++ exception handling.
5170         * guile/scm-symbol.c: Use C++ exception handling.
5171         * guile/scm-pretty-print.c: Use C++ exception handling.
5172         * guile/scm-ports.c: Use C++ exception handling.
5173         * guile/scm-param.c: Use C++ exception handling.
5174         * guile/scm-math.c: Use C++ exception handling.
5175         * guile/scm-lazy-string.c: Use C++ exception handling.
5176         * guile/scm-frame.c: Use C++ exception handling.
5177         * guile/scm-disasm.c: Use C++ exception handling.
5178         * guile/scm-cmd.c: Use C++ exception handling.
5179         * guile/scm-breakpoint.c: Use C++ exception handling.
5180         * guile/scm-block.c: Use C++ exception handling.
5181         * guile/guile-internal.h: Use C++ exception handling.
5182         * gnu-v3-abi.c: Use C++ exception handling.
5183         * gdbtypes.c: Use C++ exception handling.
5184         * frame.c: Use C++ exception handling.
5185         * frame-unwind.c: Use C++ exception handling.
5186         * fbsd-tdep.c: Use C++ exception handling.
5187         * f-valprint.c: Use C++ exception handling.
5188         * exec.c: Use C++ exception handling.
5189         * event-top.c: Use C++ exception handling.
5190         * event-loop.c: Use C++ exception handling.
5191         * eval.c: Use C++ exception handling.
5192         * dwarf2read.c: Use C++ exception handling.
5193         * dwarf2loc.c: Use C++ exception handling.
5194         * dwarf2-frame.c: Use C++ exception handling.
5195         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5196         * dwarf-index-write.c: Use C++ exception handling.
5197         * dwarf-index-cache.c: Use C++ exception handling.
5198         * dtrace-probe.c: Use C++ exception handling.
5199         * disasm-selftests.c: Use C++ exception handling.
5200         * darwin-nat.c: Use C++ exception handling.
5201         * cp-valprint.c: Use C++ exception handling.
5202         * cp-support.c: Use C++ exception handling.
5203         * cp-abi.c: Use C++ exception handling.
5204         * corelow.c: Use C++ exception handling.
5205         * completer.c: Use C++ exception handling.
5206         * compile/compile-object-run.c: Use C++ exception handling.
5207         * compile/compile-object-load.c: Use C++ exception handling.
5208         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5209         * compile/compile-c-symbols.c: Use C++ exception handling.
5210         * common/selftest.c: Use C++ exception handling.
5211         * common/new-op.c: Use C++ exception handling.
5212         * cli/cli-script.c: Use C++ exception handling.
5213         * cli/cli-interp.c: Use C++ exception handling.
5214         * cli/cli-cmds.c: Use C++ exception handling.
5215         * c-varobj.c: Use C++ exception handling.
5216         * btrace.c: Use C++ exception handling.
5217         * breakpoint.c: Use C++ exception handling.
5218         * break-catch-throw.c: Use C++ exception handling.
5219         * arch-utils.c: Use C++ exception handling.
5220         * amd64-tdep.c: Use C++ exception handling.
5221         * ada-valprint.c: Use C++ exception handling.
5222         * ada-typeprint.c: Use C++ exception handling.
5223         * ada-lang.c: Use C++ exception handling.
5224         * aarch64-tdep.c: Use C++ exception handling.
5225
5226 2019-04-08  Tom Tromey  <tom@tromey.com>
5227
5228         * xml-support.c (gdb_xml_parser::parse): Update.
5229         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5230         * value.c (show_convenience): Update.
5231         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5232         (test_parse_flags_qcs): Update.
5233         * thread.c (thr_try_catch_cmd): Update.
5234         * target.c (target_translate_tls_address): Update.
5235         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5236         (info_frame_command_core, frame_apply_command_count): Update.
5237         * rust-exp.y (rust_lex_exception_test): Update.
5238         * riscv-tdep.c (riscv_print_one_register_info): Update.
5239         * remote.c (remote_target::enable_btrace): Update.
5240         * record-btrace.c (record_btrace_enable_warn): Update.
5241         * python/py-utils.c (gdbpy_convert_exception): Update.
5242         * printcmd.c (do_one_display, print_variable_and_value): Update.
5243         * mi/mi-main.c (mi_print_exception): Update.
5244         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5245         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5246         * linux-nat.c (linux_nat_target::attach): Update.
5247         * linux-fork.c (class scoped_switch_fork_info): Update.
5248         * infrun.c (displaced_step_prepare): Update.
5249         * infcall.c (call_function_by_hand_dummy): Update.
5250         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5251         * gnu-v3-abi.c (print_one_vtable): Update.
5252         * frame.c (get_prev_frame_always): Update.
5253         * f-valprint.c (info_common_command_for_block): Update.
5254         * exec.c (try_open_exec_file): Update.
5255         * exceptions.c (print_exception, exception_print)
5256         (exception_fprintf, exception_print_same): Update.
5257         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5258         * dwarf-index-cache.c (index_cache::store)
5259         (index_cache::lookup_gdb_index): Update.
5260         * darwin-nat.c (maybe_cache_shell): Update.
5261         * cp-valprint.c (cp_print_value_fields): Update.
5262         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5263         (gcc_cplus_symbol_address): Update.
5264         * compile/compile-c-symbols.c (gcc_convert_symbol)
5265         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5266         * common/selftest.c: Update.
5267         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5268         a std::string.
5269         (exception_try_scope_entry, exception_try_scope_exit): Don't
5270         declare.
5271         (struct exception_try_scope): Remove.
5272         (TRY): Don't use exception_try_scope.
5273         (struct gdb_exception): Add constructor, operator=.
5274         <what>: New method.
5275         (struct gdb_exception_RETURN_MASK_ALL)
5276         (struct gdb_exception_RETURN_MASK_ERROR)
5277         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5278         (struct gdb_quit_bad_alloc): Update.
5279         * common/common-exceptions.c (exception_none): Change
5280         initializer.
5281         (struct catcher) <state, exception>: Initialize inline.
5282         <prev>: Remove member.
5283         (current_catcher): Remove.
5284         (catchers): New global.
5285         (exceptions_state_mc_init): Simplify.
5286         (catcher_pop): Remove.
5287         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5288         (try_scope_depth, exception_try_scope_entry)
5289         (exception_try_scope_exit): Remove.
5290         (throw_exception_sjlj): Update.
5291         (exception_messages, exception_messages_size): Remove.
5292         (throw_it): Simplify.
5293         (gdb_exception_sliced_copy): Remove.
5294         (throw_exception_cxx): Update.
5295         * cli/cli-script.c (script_from_file): Update.
5296         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5297         Update.
5298         * ada-valprint.c (ada_val_print): Update.
5299         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5300         (create_excep_cond_exprs): Update.
5301
5302 2019-04-08  Tom Tromey  <tom@tromey.com>
5303
5304         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5305         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5306         (TRY, CATCH, END_CATCH): Remove some definitions.
5307         * common/common-exceptions.c: Don't use GDB_XCPT.
5308         (catcher_list_size): Remove.
5309         (throw_exception, throw_it): Simplify.
5310
5311 2019-04-05  Tom Tromey  <tom@tromey.com>
5312
5313         Revert the header-sorting patch.
5314         * ft32-tdep.c: Revert.
5315         * frv-tdep.c: Revert.
5316         * frv-linux-tdep.c: Revert.
5317         * frame.c: Revert.
5318         * frame-unwind.c: Revert.
5319         * frame-base.c: Revert.
5320         * fork-child.c: Revert.
5321         * findvar.c: Revert.
5322         * findcmd.c: Revert.
5323         * filesystem.c: Revert.
5324         * filename-seen-cache.h: Revert.
5325         * filename-seen-cache.c: Revert.
5326         * fbsd-tdep.c: Revert.
5327         * fbsd-nat.h: Revert.
5328         * fbsd-nat.c: Revert.
5329         * f-valprint.c: Revert.
5330         * f-typeprint.c: Revert.
5331         * f-lang.c: Revert.
5332         * extension.h: Revert.
5333         * extension.c: Revert.
5334         * extension-priv.h: Revert.
5335         * expprint.c: Revert.
5336         * exec.h: Revert.
5337         * exec.c: Revert.
5338         * exceptions.c: Revert.
5339         * event-top.c: Revert.
5340         * event-loop.c: Revert.
5341         * eval.c: Revert.
5342         * elfread.c: Revert.
5343         * dwarf2read.h: Revert.
5344         * dwarf2read.c: Revert.
5345         * dwarf2loc.c: Revert.
5346         * dwarf2expr.h: Revert.
5347         * dwarf2expr.c: Revert.
5348         * dwarf2-frame.c: Revert.
5349         * dwarf2-frame-tailcall.c: Revert.
5350         * dwarf-index-write.h: Revert.
5351         * dwarf-index-write.c: Revert.
5352         * dwarf-index-common.c: Revert.
5353         * dwarf-index-cache.h: Revert.
5354         * dwarf-index-cache.c: Revert.
5355         * dummy-frame.c: Revert.
5356         * dtrace-probe.c: Revert.
5357         * disasm.h: Revert.
5358         * disasm.c: Revert.
5359         * disasm-selftests.c: Revert.
5360         * dictionary.c: Revert.
5361         * dicos-tdep.c: Revert.
5362         * demangle.c: Revert.
5363         * dcache.h: Revert.
5364         * dcache.c: Revert.
5365         * darwin-nat.h: Revert.
5366         * darwin-nat.c: Revert.
5367         * darwin-nat-info.c: Revert.
5368         * d-valprint.c: Revert.
5369         * d-namespace.c: Revert.
5370         * d-lang.c: Revert.
5371         * ctf.c: Revert.
5372         * csky-tdep.c: Revert.
5373         * csky-linux-tdep.c: Revert.
5374         * cris-tdep.c: Revert.
5375         * cris-linux-tdep.c: Revert.
5376         * cp-valprint.c: Revert.
5377         * cp-support.c: Revert.
5378         * cp-namespace.c: Revert.
5379         * cp-abi.c: Revert.
5380         * corelow.c: Revert.
5381         * corefile.c: Revert.
5382         * continuations.c: Revert.
5383         * completer.h: Revert.
5384         * completer.c: Revert.
5385         * complaints.c: Revert.
5386         * coffread.c: Revert.
5387         * coff-pe-read.c: Revert.
5388         * cli-out.h: Revert.
5389         * cli-out.c: Revert.
5390         * charset.c: Revert.
5391         * c-varobj.c: Revert.
5392         * c-valprint.c: Revert.
5393         * c-typeprint.c: Revert.
5394         * c-lang.c: Revert.
5395         * buildsym.c: Revert.
5396         * buildsym-legacy.c: Revert.
5397         * build-id.h: Revert.
5398         * build-id.c: Revert.
5399         * btrace.c: Revert.
5400         * bsd-uthread.c: Revert.
5401         * breakpoint.h: Revert.
5402         * breakpoint.c: Revert.
5403         * break-catch-throw.c: Revert.
5404         * break-catch-syscall.c: Revert.
5405         * break-catch-sig.c: Revert.
5406         * blockframe.c: Revert.
5407         * block.c: Revert.
5408         * bfin-tdep.c: Revert.
5409         * bfin-linux-tdep.c: Revert.
5410         * bfd-target.c: Revert.
5411         * bcache.c: Revert.
5412         * ax-general.c: Revert.
5413         * ax-gdb.h: Revert.
5414         * ax-gdb.c: Revert.
5415         * avr-tdep.c: Revert.
5416         * auxv.c: Revert.
5417         * auto-load.c: Revert.
5418         * arm-wince-tdep.c: Revert.
5419         * arm-tdep.c: Revert.
5420         * arm-symbian-tdep.c: Revert.
5421         * arm-pikeos-tdep.c: Revert.
5422         * arm-obsd-tdep.c: Revert.
5423         * arm-nbsd-tdep.c: Revert.
5424         * arm-nbsd-nat.c: Revert.
5425         * arm-linux-tdep.c: Revert.
5426         * arm-linux-nat.c: Revert.
5427         * arm-fbsd-tdep.c: Revert.
5428         * arm-fbsd-nat.c: Revert.
5429         * arm-bsd-tdep.c: Revert.
5430         * arch-utils.c: Revert.
5431         * arc-tdep.c: Revert.
5432         * arc-newlib-tdep.c: Revert.
5433         * annotate.h: Revert.
5434         * annotate.c: Revert.
5435         * amd64-windows-tdep.c: Revert.
5436         * amd64-windows-nat.c: Revert.
5437         * amd64-tdep.c: Revert.
5438         * amd64-sol2-tdep.c: Revert.
5439         * amd64-obsd-tdep.c: Revert.
5440         * amd64-obsd-nat.c: Revert.
5441         * amd64-nbsd-tdep.c: Revert.
5442         * amd64-nbsd-nat.c: Revert.
5443         * amd64-nat.c: Revert.
5444         * amd64-linux-tdep.c: Revert.
5445         * amd64-linux-nat.c: Revert.
5446         * amd64-fbsd-tdep.c: Revert.
5447         * amd64-fbsd-nat.c: Revert.
5448         * amd64-dicos-tdep.c: Revert.
5449         * amd64-darwin-tdep.c: Revert.
5450         * amd64-bsd-nat.c: Revert.
5451         * alpha-tdep.c: Revert.
5452         * alpha-obsd-tdep.c: Revert.
5453         * alpha-nbsd-tdep.c: Revert.
5454         * alpha-mdebug-tdep.c: Revert.
5455         * alpha-linux-tdep.c: Revert.
5456         * alpha-linux-nat.c: Revert.
5457         * alpha-bsd-tdep.c: Revert.
5458         * alpha-bsd-nat.c: Revert.
5459         * aix-thread.c: Revert.
5460         * agent.c: Revert.
5461         * addrmap.c: Revert.
5462         * ada-varobj.c: Revert.
5463         * ada-valprint.c: Revert.
5464         * ada-typeprint.c: Revert.
5465         * ada-tasks.c: Revert.
5466         * ada-lang.c: Revert.
5467         * aarch64-tdep.c: Revert.
5468         * aarch64-ravenscar-thread.c: Revert.
5469         * aarch64-newlib-tdep.c: Revert.
5470         * aarch64-linux-tdep.c: Revert.
5471         * aarch64-linux-nat.c: Revert.
5472         * aarch64-fbsd-tdep.c: Revert.
5473         * aarch64-fbsd-nat.c: Revert.
5474         * aarch32-linux-nat.c: Revert.
5475
5476 2019-04-05  Tom Tromey  <tom@tromey.com>
5477
5478         * ft32-tdep.c: Sort headers.
5479         * frv-tdep.c: Sort headers.
5480         * frv-linux-tdep.c: Sort headers.
5481         * frame.c: Sort headers.
5482         * frame-unwind.c: Sort headers.
5483         * frame-base.c: Sort headers.
5484         * fork-child.c: Sort headers.
5485         * findvar.c: Sort headers.
5486         * findcmd.c: Sort headers.
5487         * filesystem.c: Sort headers.
5488         * filename-seen-cache.h: Sort headers.
5489         * filename-seen-cache.c: Sort headers.
5490         * fbsd-tdep.c: Sort headers.
5491         * fbsd-nat.h: Sort headers.
5492         * fbsd-nat.c: Sort headers.
5493         * f-valprint.c: Sort headers.
5494         * f-typeprint.c: Sort headers.
5495         * f-lang.c: Sort headers.
5496         * extension.h: Sort headers.
5497         * extension.c: Sort headers.
5498         * extension-priv.h: Sort headers.
5499         * expprint.c: Sort headers.
5500         * exec.h: Sort headers.
5501         * exec.c: Sort headers.
5502         * exceptions.c: Sort headers.
5503         * event-top.c: Sort headers.
5504         * event-loop.c: Sort headers.
5505         * eval.c: Sort headers.
5506         * elfread.c: Sort headers.
5507         * dwarf2read.h: Sort headers.
5508         * dwarf2read.c: Sort headers.
5509         * dwarf2loc.c: Sort headers.
5510         * dwarf2expr.h: Sort headers.
5511         * dwarf2expr.c: Sort headers.
5512         * dwarf2-frame.c: Sort headers.
5513         * dwarf2-frame-tailcall.c: Sort headers.
5514         * dwarf-index-write.h: Sort headers.
5515         * dwarf-index-write.c: Sort headers.
5516         * dwarf-index-common.c: Sort headers.
5517         * dwarf-index-cache.h: Sort headers.
5518         * dwarf-index-cache.c: Sort headers.
5519         * dummy-frame.c: Sort headers.
5520         * dtrace-probe.c: Sort headers.
5521         * disasm.h: Sort headers.
5522         * disasm.c: Sort headers.
5523         * disasm-selftests.c: Sort headers.
5524         * dictionary.c: Sort headers.
5525         * dicos-tdep.c: Sort headers.
5526         * demangle.c: Sort headers.
5527         * dcache.h: Sort headers.
5528         * dcache.c: Sort headers.
5529         * darwin-nat.h: Sort headers.
5530         * darwin-nat.c: Sort headers.
5531         * darwin-nat-info.c: Sort headers.
5532         * d-valprint.c: Sort headers.
5533         * d-namespace.c: Sort headers.
5534         * d-lang.c: Sort headers.
5535         * ctf.c: Sort headers.
5536         * csky-tdep.c: Sort headers.
5537         * csky-linux-tdep.c: Sort headers.
5538         * cris-tdep.c: Sort headers.
5539         * cris-linux-tdep.c: Sort headers.
5540         * cp-valprint.c: Sort headers.
5541         * cp-support.c: Sort headers.
5542         * cp-namespace.c: Sort headers.
5543         * cp-abi.c: Sort headers.
5544         * corelow.c: Sort headers.
5545         * corefile.c: Sort headers.
5546         * continuations.c: Sort headers.
5547         * completer.h: Sort headers.
5548         * completer.c: Sort headers.
5549         * complaints.c: Sort headers.
5550         * coffread.c: Sort headers.
5551         * coff-pe-read.c: Sort headers.
5552         * cli-out.h: Sort headers.
5553         * cli-out.c: Sort headers.
5554         * charset.c: Sort headers.
5555         * c-varobj.c: Sort headers.
5556         * c-valprint.c: Sort headers.
5557         * c-typeprint.c: Sort headers.
5558         * c-lang.c: Sort headers.
5559         * buildsym.c: Sort headers.
5560         * buildsym-legacy.c: Sort headers.
5561         * build-id.h: Sort headers.
5562         * build-id.c: Sort headers.
5563         * btrace.c: Sort headers.
5564         * bsd-uthread.c: Sort headers.
5565         * breakpoint.h: Sort headers.
5566         * breakpoint.c: Sort headers.
5567         * break-catch-throw.c: Sort headers.
5568         * break-catch-syscall.c: Sort headers.
5569         * break-catch-sig.c: Sort headers.
5570         * blockframe.c: Sort headers.
5571         * block.c: Sort headers.
5572         * bfin-tdep.c: Sort headers.
5573         * bfin-linux-tdep.c: Sort headers.
5574         * bfd-target.c: Sort headers.
5575         * bcache.c: Sort headers.
5576         * ax-general.c: Sort headers.
5577         * ax-gdb.h: Sort headers.
5578         * ax-gdb.c: Sort headers.
5579         * avr-tdep.c: Sort headers.
5580         * auxv.c: Sort headers.
5581         * auto-load.c: Sort headers.
5582         * arm-wince-tdep.c: Sort headers.
5583         * arm-tdep.c: Sort headers.
5584         * arm-symbian-tdep.c: Sort headers.
5585         * arm-pikeos-tdep.c: Sort headers.
5586         * arm-obsd-tdep.c: Sort headers.
5587         * arm-nbsd-tdep.c: Sort headers.
5588         * arm-nbsd-nat.c: Sort headers.
5589         * arm-linux-tdep.c: Sort headers.
5590         * arm-linux-nat.c: Sort headers.
5591         * arm-fbsd-tdep.c: Sort headers.
5592         * arm-fbsd-nat.c: Sort headers.
5593         * arm-bsd-tdep.c: Sort headers.
5594         * arch-utils.c: Sort headers.
5595         * arc-tdep.c: Sort headers.
5596         * arc-newlib-tdep.c: Sort headers.
5597         * annotate.h: Sort headers.
5598         * annotate.c: Sort headers.
5599         * amd64-windows-tdep.c: Sort headers.
5600         * amd64-windows-nat.c: Sort headers.
5601         * amd64-tdep.c: Sort headers.
5602         * amd64-sol2-tdep.c: Sort headers.
5603         * amd64-obsd-tdep.c: Sort headers.
5604         * amd64-obsd-nat.c: Sort headers.
5605         * amd64-nbsd-tdep.c: Sort headers.
5606         * amd64-nbsd-nat.c: Sort headers.
5607         * amd64-nat.c: Sort headers.
5608         * amd64-linux-tdep.c: Sort headers.
5609         * amd64-linux-nat.c: Sort headers.
5610         * amd64-fbsd-tdep.c: Sort headers.
5611         * amd64-fbsd-nat.c: Sort headers.
5612         * amd64-dicos-tdep.c: Sort headers.
5613         * amd64-darwin-tdep.c: Sort headers.
5614         * amd64-bsd-nat.c: Sort headers.
5615         * alpha-tdep.c: Sort headers.
5616         * alpha-obsd-tdep.c: Sort headers.
5617         * alpha-nbsd-tdep.c: Sort headers.
5618         * alpha-mdebug-tdep.c: Sort headers.
5619         * alpha-linux-tdep.c: Sort headers.
5620         * alpha-linux-nat.c: Sort headers.
5621         * alpha-bsd-tdep.c: Sort headers.
5622         * alpha-bsd-nat.c: Sort headers.
5623         * aix-thread.c: Sort headers.
5624         * agent.c: Sort headers.
5625         * addrmap.c: Sort headers.
5626         * ada-varobj.c: Sort headers.
5627         * ada-valprint.c: Sort headers.
5628         * ada-typeprint.c: Sort headers.
5629         * ada-tasks.c: Sort headers.
5630         * ada-lang.c: Sort headers.
5631         * aarch64-tdep.c: Sort headers.
5632         * aarch64-ravenscar-thread.c: Sort headers.
5633         * aarch64-newlib-tdep.c: Sort headers.
5634         * aarch64-linux-tdep.c: Sort headers.
5635         * aarch64-linux-nat.c: Sort headers.
5636         * aarch64-fbsd-tdep.c: Sort headers.
5637         * aarch64-fbsd-nat.c: Sort headers.
5638         * aarch32-linux-nat.c: Sort headers.
5639
5640 2019-04-04  Tom Tromey  <tom@tromey.com>
5641
5642         * varobj.c (varobj_create): Update.
5643         * rust-exp.y (struct rust_parser) <update_innermost_block,
5644         lookup_symbol>: New methods.
5645         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5646         Rename.
5647         (rust_parser::rust_lookup_type)
5648         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5649         * printcmd.c (display_command, do_one_display): Update.
5650         * parser-defs.h (struct parser_state) <parser_state>: Add
5651         "tracker" parameter.
5652         (block_tracker): New member.
5653         (class innermost_block_tracker) <innermost_block_tracker>: Add
5654         "types" parameter.
5655         <reset>: Remove method.
5656         (innermost_block): Don't declare.
5657         (null_post_parser): Update.
5658         * parse.c (innermost_block): Remove global.
5659         (write_dollar_variable): Update.
5660         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5661         Remove "tracker_types" parameter.
5662         (parse_expression): Add "tracker" parameter.
5663         (parse_expression_for_completion): Update.
5664         (null_post_parser): Add "tracker" parameter.
5665         * p-exp.y: Update rules.
5666         * m2-exp.y: Update rules.
5667         * language.h (struct language_defn) <la_post_parser>: Add
5668         "tracker" parameter.
5669         * go-exp.y: Update rules.
5670         * f-exp.y: Update rules.
5671         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5672         parameter.
5673         * d-exp.y: Update rules.
5674         * c-exp.y: Update rules.
5675         * breakpoint.c (set_breakpoint_condition): Create an
5676         innermost_block_tracker.
5677         (watch_command_1): Likewise.
5678         * ada-lang.c (resolve): Add "tracker" parameter.
5679         (resolve_subexp): Likewise.
5680         * ada-exp.y (write_var_from_sym): Update.
5681
5682 2019-04-04  Tom Tromey  <tom@tromey.com>
5683
5684         * type-stack.h: New file.
5685         * type-stack.c: New file.
5686         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5687         type-stack.h.
5688         (insert_into_type_stack, insert_type, push_type, push_type_int)
5689         (insert_type_address_space, pop_type, pop_type_int)
5690         (pop_typelist, pop_type_stack, append_type_stack)
5691         (push_type_stack, get_type_stack, push_typelist)
5692         (follow_type_instance_flags, follow_types): Don't declare.
5693         * parse.c (type_stack): Remove global.
5694         (parse_exp_in_context): Update.
5695         (insert_into_type_stack, insert_type, push_type, push_type_int)
5696         (insert_type_address_space, pop_type, pop_type_int)
5697         (pop_typelist, pop_type_stack, append_type_stack)
5698         (push_type_stack, get_type_stack, push_typelist)
5699         (follow_type_instance_flags, follow_types): Remove (moved to
5700         type-stack.c).
5701         * f-exp.y (type_stack): New global.
5702         Update rules.
5703         (push_kind_type, f_parse): Update.
5704         * d-exp.y (type_stack): New global.
5705         Update rules.
5706         (d_parse): Update.
5707         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5708         Update rules.
5709         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5710         (HFILES_NO_SRCDIR): Add type-stack.h.
5711
5712 2019-04-04  Tom Tromey  <tom@tromey.com>
5713
5714         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5715         (rust_parser::convert_ast_to_expression, rust_parse)
5716         (rust_lex_test_completion, rust_lex_tests): Update.
5717         * parser-defs.h (struct expr_completion_state): New.
5718         (struct parser_state) <parser_state>: Add completion parameter.
5719         <mark_struct_expression, mark_completion_tag>: New methods.
5720         <parse_completion, m_completion_state>: New members.
5721         (prefixify_expression, null_post_parser): Update.
5722         (mark_struct_expression, mark_completion_tag): Don't declare.
5723         * parse.c (parse_completion, expout_last_struct)
5724         (expout_tag_completion_type, expout_completion_name): Remove
5725         globals.
5726         (parser_state::mark_struct_expression)
5727         (parser_state::mark_completion_tag): Now methods.
5728         (prefixify_expression): Add last_struct parameter.
5729         (prefixify_subexp): Likewise.
5730         (parse_exp_1): Update.
5731         (parse_exp_in_context): Add cstate parameter.  Update.
5732         (parse_expression_for_completion): Create an
5733         expr_completion_state.
5734         (null_post_parser): Add "completion" parameter.
5735         * p-exp.y: Update rules.
5736         (yylex): Update.
5737         * language.h (struct language_defn) <la_post_parser>: Add
5738         "completing" parameter.
5739         * go-exp.y: Update rules.
5740         (lex_one_token): Update.
5741         * expression.h (parse_completion): Don't declare.
5742         * d-exp.y: Update rules.
5743         (lex_one_token): Update rules.
5744         * c-exp.y: Update rules.
5745         (lex_one_token): Update.
5746         * ada-lang.c (resolve): Add "parse_completion" parameter.
5747         (resolve_subexp): Likewise.
5748         (ada_resolve_function): Likewise.
5749
5750 2019-04-04  Tom Tromey  <tom@tromey.com>
5751
5752         * parser-defs.h (struct parser_state) <start_arglist,
5753         end_arglist>: New methods.
5754         <arglist_len, m_funcall_chain>: New members.
5755         (arglist_len, start_arglist, end_arglist): Don't declare.
5756         * parse.c (arglist_len, funcall_chain): Remove global.
5757         (start_arglist, end_arglist): Remove functions.
5758         (parse_exp_in_context): Update.
5759         * p-exp.y: Update rules.
5760         * m2-exp.y: Update rules.
5761         * go-exp.y: Update rules.
5762         * f-exp.y: Update rules.
5763         * d-exp.y: Update rules.
5764         * c-exp.y: Update rules.
5765
5766 2019-04-04  Tom Tromey  <tom@tromey.com>
5767
5768         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5769         lex_operator, push_back>: New methods.
5770         Update all rules.
5771         (rust_parser::lex_hex, lex_escape): Rename and update.
5772         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5773         (rust_parser::lex_operator): Rename and update.
5774         (rust_parser::lex_number, rustyylex, rustyyerror)
5775         (rust_lex_test_init, rust_lex_test_sequence)
5776         (rust_lex_test_push_back, rust_lex_tests): Update.
5777         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5778         parameter.
5779         <lexptr, prev_lexptr>: New members.
5780         (lexptr, prev_lexptr): Don't declare.
5781         * parse.c (lexptr, prev_lexptr): Remove globals.
5782         (parse_exp_in_context): Update.
5783         * p-exp.y (yylex, yyerror): Update.
5784         * m2-exp.y (parse_number, yylex, yyerror): Update.
5785         * go-exp.y (lex_one_token, yyerror): Update.
5786         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5787         * d-exp.y (lex_one_token, yyerror): Update.
5788         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5789         (lex_one_token, yyerror): Update.
5790         * ada-lex.l (YY_INPUT): Update.
5791         (rewind_to_char): Update.
5792         * ada-exp.y (yyerror): Update.
5793
5794 2019-04-04  Tom Tromey  <tom@tromey.com>
5795
5796         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5797         * parser-defs.h (struct parser_state) <parser_state>: Add new
5798         parameter.
5799         <comma_terminates>: New member.
5800         (comma_terminates): Don't declare global.
5801         * parse.c (comma_terminates): Remove global.
5802         (parse_exp_in_context): Update.
5803         * p-exp.y (yylex): Update.
5804         * m2-exp.y (yylex): Update.
5805         * go-exp.y (lex_one_token): Update.
5806         * f-exp.y (yylex): Update.
5807         * d-exp.y (lex_one_token): Update.
5808         * c-exp.y (lex_one_token): Update.
5809         * ada-lex.l: Update.
5810
5811 2019-04-04  Tom Tromey  <tom@tromey.com>
5812
5813         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5814         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5815         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5816         * parser-defs.h (paren_depth): Don't declare.
5817         * parse.c (paren_depth): Remove global.
5818         (parse_exp_in_context): Update.
5819         * p-exp.y (paren_depth): New global.
5820         (pascal_parse): Initialize it.
5821         * m2-exp.y (paren_depth): New global.
5822         (m2_parse): Initialize it.
5823         * go-exp.y (paren_depth): New global.
5824         (go_parse): Initialize it.
5825         * f-exp.y (paren_depth): New global.
5826         (f_parse): Initialize it.
5827         * d-exp.y (paren_depth): New global.
5828         (d_parse): Initialize it.
5829         * c-exp.y (paren_depth): New global.
5830         (c_parse): Initialize it.
5831         * ada-lex.l (paren_depth): New global.
5832         (lexer_init): Initialize it.
5833
5834 2019-04-04  Tom Tromey  <tom@tromey.com>
5835
5836         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5837         (rust_parser::convert_ast_to_type)
5838         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5839         * parser-defs.h (struct parser_state) <parser_state>: Add
5840         parameters.  Initialize new members.
5841         <expression_context_block, expression_context_pc>: New members.
5842         * parse.c (expression_context_block, expression_context_pc):
5843         Remove globals.
5844         (parse_exp_in_context): Update.
5845         * p-exp.y: Update all rules.
5846         (yylex): Update.
5847         * m2-exp.y: Update all rules.
5848         (yylex): Update.
5849         * go-exp.y (yylex): Update.
5850         * f-exp.y (yylex): Update.
5851         * d-exp.y: Update all rules.
5852         (yylex): Update.
5853         * c-exp.y: Update all rules.
5854         (lex_one_token, classify_name, yylex, c_parse): Update.
5855         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5856
5857 2019-04-04  Tom Tromey  <tom@tromey.com>
5858
5859         * gdbarch.h, gdbarch.c: Rebuild.
5860         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5861         * stap-probe.h:
5862         (struct stap_parse_info): Replace "parser_state" with
5863         "expr_builder".
5864         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5865         (parser_state): New class.
5866         * parse.c (expr_builder): Rename.
5867         (expr_builder::release): Rename.
5868         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5869         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5870         (write_exp_elt_longcst, write_exp_elt_floatcst)
5871         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5872         (write_exp_string_vector, write_exp_bitstring)
5873         (write_exp_msymbol, mark_struct_expression)
5874         (write_dollar_variable)
5875         (insert_type_address_space, increase_expout_size): Replace
5876         "parser_state" with "expr_builder".
5877         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5878         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5879         "parser_state" with "expr_builder".
5880
5881 2019-04-04  Tom Tromey  <tom@tromey.com>
5882
5883         * rust-exp.y: Replace "parse_language" with method call.
5884         * p-exp.y:
5885         (yylex): Replace "parse_language" with method call.
5886         * m2-exp.y:
5887         (yylex): Replace "parse_language" with method call.
5888         * go-exp.y (classify_name): Replace "parse_language" with method
5889         call.
5890         * f-exp.y (yylex): Replace "parse_language" with method call.
5891         * d-exp.y (lex_one_token): Replace "parse_language" with method
5892         call.
5893         * c-exp.y:
5894         (lex_one_token, classify_name, yylex): Replace "parse_language"
5895         with method call.
5896         * ada-exp.y (find_primitive_type, type_char)
5897         (type_system_address): Replace "parse_language" with method call.
5898
5899 2019-04-04  Tom Tromey  <tom@tromey.com>
5900
5901         * rust-exp.y: Replace "parse_gdbarch" with method call.
5902         * parse.c (write_dollar_variable, insert_type_address_space):
5903         Replace "parse_gdbarch" with method call.
5904         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5905         call.
5906         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5907         call.
5908         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5909         "parse_gdbarch" with method call.
5910         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5911         with method call.
5912         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5913         "parse_gdbarch" with method call.
5914         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5915         "parse_gdbarch" with method call.
5916         * c-exp.y (parse_type, parse_number, classify_name): Replace
5917         "parse_gdbarch" with method call.
5918         * ada-lex.l: Replace "parse_gdbarch" with method call.
5919         * ada-exp.y (parse_type, find_primitive_type, type_char)
5920         (type_system_address): Replace "parse_gdbarch" with method call.
5921
5922 2019-04-04  Tom Tromey  <tom@tromey.com>
5923
5924         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5925         * stap-probe.c (stap_parse_argument): Update.
5926         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5927         initial_size parameter.
5928         * rust-exp.y (rust_lex_tests): Update.
5929         * parse.c (parser_state): Update.
5930         (parse_exp_in_context): Update.
5931         * parser-defs.h (struct parser_state) <parser_state>: Remove
5932         "initial_size" parameter.
5933
5934 2019-04-04  Tom Tromey  <tom@tromey.com>
5935
5936         * parser-defs.h (increase_expout_size): Don't declare.
5937         * parse.c (increase_expout_size): Now static.
5938
5939 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5940
5941         * gnu-nat.c (gnu_nat_target::wait): Fix
5942         target_waitstatus_to_string call.
5943
5944 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5945
5946         * eval.c (evaluate_subexp_standard): Handle internal functions
5947         during Fortran function call handling.
5948
5949 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5950
5951         * NEWS: Mention new internal functions.
5952         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5953         (read_base_type): Use dwarf2_init_complex_target_type.
5954         * value.c (creal_internal_fn): New function.
5955         (cimag_internal_fn): New function.
5956         (_initialize_values): Register new internal functions.
5957
5958 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5959
5960         * infrun.c (stop_all_threads): If debug_infrun, always
5961         trace the wait status after wait_one, using
5962         target_waitstatus_to_string and target_pid_to_str.
5963         (handle_inferior_event): Replace various trace of
5964         wait status kind by a single trace.
5965         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5966         wait status kind image by target_waitstatus_to_string.
5967         * target/waitstatus.c (target_waitstatus_to_string): Fix
5968         obsolete comment.
5969
5970 2019-04-01  Tom Tromey  <tromey@adacore.com>
5971
5972         PR symtab/23331:
5973         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5974
5975 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5976             Pedro Alves  <palves@redhat.com>
5977
5978         * top.c (quit_force): Call 'finalize_values'.
5979         * value.c (finalize_values): New function.
5980         * value.h (finalize_values): Declare.
5981
5982 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5983
5984         * NEWS: Announce $_gdb_major and $_gdb_minor.
5985
5986         * top.c (init_gdb_version_vars): New function.
5987         (gdb_init): Call init_gdb_version_vars.
5988
5989 2019-03-29  Tom Tromey  <tromey@adacore.com>
5990
5991         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5992         help text.  Remove dead code.
5993
5994 2019-03-29  Keith Seitz  <keiths@redhat.com>
5995
5996         From Siddhesh Poyarekar:
5997         * f-lang.h (f77_get_upperbound): Return LONGEST.
5998         (f77_get_lowerbound): Likewise.
5999         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6000         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6001         print them.
6002         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6003         plongest to format print it.
6004         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6005         (f77_get_upperbound): Likewise.
6006         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6007         LOWER_BOUND to LONGEST.
6008         (f77_create_arrayprint_offset_tbl): Likewise.
6009
6010 2019-03-29  Keith Seitz  <keiths@redhat.com>
6011
6012         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6013         %s/pulongest for TYPE_LENGTH instead of %d in format
6014         strings.
6015         * ada-typerint.c (ada_print_type): Likewise.
6016         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6017         * compile/compile-c-support.c (generate_register_struct): Likewise.
6018         * gdbtypes.c (recursive_dump_type): Likewise.
6019         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6020         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6021         instead of %d in format strings.
6022         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6023         to std::min to ULONGEST.
6024         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6025         instead of %d in format strings.
6026         * tracepoint.c (info_scope_command): Likewise.
6027         * typeprint.c (print_offset_data::update)
6028         (print_offset_data::finish): Likewise.
6029         * xtensa-tdep.c (xtensa_store_return_value)
6030         (xtensa_push_dummy_call): Likewise.
6031
6032 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6033
6034         * windows-nat.c (display_selector): Fixed format specifications
6035         for 64-bit Cygwin.
6036
6037 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6038
6039         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6040
6041 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6042
6043         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6044         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6045         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6046         (nios2_linux_init_abi): Install it.
6047
6048 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6049
6050         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6051
6052 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6053
6054         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6055
6056 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6057             Tom Tromey  <tromey@adacore.com>
6058
6059         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6060
6061 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6062
6063         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6064         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6065         method to compute the bounds of range types. Also print "[evaluated]"
6066         if the bounds' values come from a dynamic evaluation.
6067
6068 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6069
6070         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6071         whitespace when pretty printing is on.
6072
6073 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6074
6075         * ppc-linux-nat.c: Add include.
6076
6077 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6078
6079         * NEWS: Mention AArch64 Pointer Authentication.
6080
6081 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6082
6083         * arm-linux-nat.c: Add include.
6084
6085 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6086
6087         * source-cache.c (source_cache::get_source_lines): Re-read
6088         fullname after calling open_source_file.
6089
6090 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6091
6092         * NEWS: Mention TLS support for FreeBSD.
6093
6094 2019-03-25  Tom Tromey  <tromey@adacore.com>
6095
6096         * minsyms.c (BUNCH_SIZE): Update comment.
6097         (~minimal_symbol_reader): Remove old comment.
6098         (compact_minimal_symbols): Update comment.
6099         (minimal_symbol_reader::install): Remove old comment.  Update
6100         other comments.
6101
6102 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6103
6104         * s390-linux-nat.c: Add include.
6105
6106 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6107
6108         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6109         Call linux_get_hwcap.
6110         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6111         Likewise.
6112         (aarch64_linux_get_hwcap): Remove function.
6113         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6114         declaration.
6115         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6116         linux_get_hwcap.
6117         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6118         * linux-tdep.c (linux_get_hwcap): Add function.
6119         (linux_get_hwcap2): Likewise.
6120         * linux-tdep.h (linux_get_hwcap): Add declaration.
6121         (linux_get_hwcap2): Likewise.
6122         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6123         (ppc_linux_get_hwcap2): Likewise.
6124         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6125         linux_get_hwcap.
6126         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6127         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6128         (ppc_linux_nat_target::read_description): Likewise.
6129         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6130         * s390-linux-nat.c: Likewise.
6131         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6132
6133 2019-03-24  Tom Tromey  <tom@tromey.com>
6134
6135         * ada-lang.c (standard_lookup): Simplify initialization.
6136         (ada_lookup_symbol_nonlocal): Simplify return.
6137         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6138         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6139         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6140         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6141         initialization.
6142         * solib.c (solib_global_lookup): Simplify.
6143         * symtab.c (null_block_symbol): Remove.
6144         (symbol_cache_lookup): Simplify returns.
6145         (lookup_language_this): Simplify returns.
6146         (lookup_symbol_aux): Simplify return.
6147         (lookup_local_symbol): Simplify returns.
6148         (lookup_global_symbol_from_objfile): Simplify return.
6149         (lookup_symbol_in_objfile_symtabs)
6150         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6151         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6152         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6153         * cp-namespace.c (cp_lookup_bare_symbol)
6154         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6155         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6156         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6157         (cp_lookup_symbol_via_imports): Simplify initialization.
6158         (find_symbol_in_baseclass): Likewise.
6159         * symtab.h (null_block_symbol): Remove.
6160         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6161         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6162         (d_lookup_symbol_module): Likewise.
6163         (find_symbol_in_baseclass): Simplify initialization.
6164
6165 2019-03-24  Tom Tromey  <tom@tromey.com>
6166
6167         * expression.h: Don't include symtab.h.
6168         (struct block): Forward declare.
6169
6170 2019-03-24  Tom Tromey  <tom@tromey.com>
6171
6172         * c-exp.y (typebase): Remove casts.
6173         * gdbtypes.c (lookup_unsigned_typename, )
6174         (lookup_signed_typename): Remove cast.
6175         * eval.c (parse_to_comma_and_eval): Remove cast.
6176         * parse.c (write_dollar_variable): Remove cast.
6177         * block.h (struct block) <superblock>: Now const.
6178         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6179         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6180         (map_block): Make "block" const.
6181         * symfile.h (struct quick_symbol_functions)
6182         <map_matching_symbols>: Constify block argument to "callback".
6183         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6184         const.
6185         (find_pc_sect_compunit_symtab): Make "b" const.
6186         (find_symbol_at_address): Likewise.
6187         (search_symbols): Likewise.
6188         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6189         (dw2_debug_names_lookup_symbol): Likewise.
6190         (dw2_map_matching_symbols): Update.
6191         * p-valprint.c (pascal_val_print): Remove "block".
6192         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6193         (aux_add_nonlocal_symbols): Make "block" const.
6194         (resolve_subexp): Remove cast.
6195         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6196         const.
6197         (iterate_over_file_blocks): Likewise.
6198         * f-exp.y (%union) <bval>: Remove.
6199         * coffread.c (patch_opaque_types): Make "b" const.
6200         * spu-tdep.c (spu_catch_start): Make "block" const.
6201         * c-valprint.c (print_unpacked_pointer): Remove "block".
6202         * symmisc.c (dump_symtab_1): Make "b" const.
6203         (block_depth): Make "block" const.
6204         * d-exp.y (%union) <bval>: Remove.
6205         * cp-support.h (cp_lookup_rtti_type): Update.
6206         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6207         * psymtab.c (psym_lookup_symbol): Make "block" const.
6208         (maintenance_check_psymtabs): Make "b" const.
6209         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6210         (enumerate_locals, enumerate_args): Update.
6211         * python/py-symtab.c (stpy_global_block): Make "block" const.
6212         (stpy_static_block): Likewise.
6213         * inline-frame.c (block_starting_point_at): Make "new_block"
6214         const.
6215         * block.c (find_block_in_blockvector): Make return type const.
6216         (blockvector_for_pc_sect): Make "b" const.
6217         (find_block_in_blockvector): Make "b" const.
6218
6219 2019-03-23  Tom Tromey  <tom@tromey.com>
6220
6221         * varobj.c (varobj_create): Update.
6222         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6223         * printcmd.c (display_command, do_one_display): Don't reset
6224         innermost_block.
6225         * parser-defs.h (enum innermost_block_tracker_type): Move to
6226         expression.h.
6227         (innermost_block): Update comment.
6228         * parse.c (parse_exp_1): Add tracker_types parameter.
6229         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6230         tracker_types parameter.  Reset innermost_block.
6231         (parse_exp_in_context): Remove.
6232         (parse_expression_for_completion): Update.
6233         * objfiles.c (~objfile): Don't reset expression_context_block or
6234         innermost_block.
6235         * expression.h (enum innermost_block_tracker_type): Move from
6236         parser-defs.h.
6237         (parse_exp_1): Add tracker_types parameter.
6238         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6239         reset innermost_block.
6240
6241 2019-03-23  Tom Tromey  <tom@tromey.com>
6242
6243         * objfiles.h: Include bcache.h.
6244
6245 2019-03-23  Tom Tromey  <tom@tromey.com>
6246
6247         * linespec.c (get_current_search_block): Use
6248         scoped_restore_current_language.
6249         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6250
6251 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6252             Jiong Wang  <jiong.wang@arm.com>
6253
6254         * aarch64-linux-tdep.c
6255         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6256         section.
6257         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6258
6259 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6260             Jiong Wang  <jiong.wang@arm.com>
6261
6262         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6263         instructions.
6264         (aarch64_analyze_prologue_test): Add PACIASP test.
6265         (aarch64_prologue_prev_register): Unmask PC value.
6266
6267 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6268             Jiong Wang  <jiong.wang@arm.com>
6269
6270         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6271         (aarch64_dwarf2_prev_register): Unmask PC value.
6272         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6273         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6274         DW_CFA_AARCH64_negate_ra_state.
6275         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6276
6277 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6278             Jiong Wang  <jiong.wang@arm.com>
6279
6280         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6281         registers.
6282         (aarch64_pseudo_register_name): Likewise.
6283         (aarch64_pseudo_register_type): Likewise.
6284         (aarch64_pseudo_register_reggroup_p): Likewise.
6285         (aarch64_gdbarch_init): Add pauth registers.
6286         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6287         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6288         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6289         (struct gdbarch_tdep): Add regnum for ra_state.
6290
6291 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6292             Jiong Wang  <jiong.wang@arm.com>
6293
6294         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6295
6296 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6297             Jiong Wang  <jiong.wang@arm.com>
6298
6299         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6300         function.
6301         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6302         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6303         (aarch64_gdbarch_init): Add puth registers.
6304         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6305         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6306         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6307
6308 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6309             Jiong Wang  <jiong.wang@arm.com>
6310
6311         * aarch64-linux-nat.c
6312         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6313         * aarch64-linux-tdep.c
6314         (aarch64_linux_core_read_description): Likewise.
6315         (aarch64_linux_get_hwcap): New function.
6316         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6317         (aarch64_linux_get_hwcap): New declaration.
6318
6319 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6320             Jiong Wang  <jiong.wang@arm.com>
6321
6322         * aarch64-linux-nat.c
6323         (aarch64_linux_nat_target::read_description): Add pauth param.
6324         * aarch64-linux-tdep.c
6325         (aarch64_linux_core_read_description): Likewise.
6326         * aarch64-tdep.c (struct target_desc): Add in pauth.
6327         (aarch64_read_description): Add pauth param.
6328         (aarch64_gdbarch_init): Likewise.
6329         * aarch64-tdep.h (aarch64_read_description): Likewise.
6330         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6331         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6332         * features/Makefile: Add new files.
6333         * features/aarch64-pauth.c: New file.
6334         * features/aarch64-pauth.xml: New file.
6335
6336 2019-03-20  Tom Tromey  <tromey@adacore.com>
6337
6338         * infrun.c (handle_inferior_event): Rename from
6339         handle_inferior_event_1.  Create a scoped_value_mark.
6340         (handle_inferior_event): Remove.
6341
6342 2019-03-19  Tom Tromey  <tromey@adacore.com>
6343
6344         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6345         * infrun.h (print_stop_event): Add "displays" parameter.
6346         * infrun.c (print_stop_event): Add "displays" parameter.
6347
6348 2019-03-19  Pedro Alves  <palves@redhat.com>
6349
6350         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6351         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6352         to -1.  Fix TABs vs spaces.
6353         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6354         * tui/tui-out.h (tui_ui_out) Add intro comments.
6355         <m_line, m_start_of_line>: In-class initialize, and add describing
6356         comment.
6357
6358 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6359
6360         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6361         variable names.
6362         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6363
6364 2019-03-18  Pedro Alves  <palves@redhat.com>
6365             Eli Zaretskii <eliz@gnu.org>
6366
6367         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6368         m_line and m_start_of_line.
6369
6370 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6371
6372         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6373         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6374         it returns a newline.  This fixes a regression in TU mode, whereby
6375         the next line is output on the same screen line as the user input.
6376
6377 2019-03-18  Tom Tromey  <tromey@adacore.com>
6378
6379         * minsyms.c (minimal_symbol_reader::install): Remove call to
6380         obstack_blank.
6381
6382 2019-03-18  Pedro Alves  <palves@redhat.com>
6383
6384         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6385         New globals.
6386         (apply_style): New, factored out from ...
6387         (apply_ansi_escape): ... this.  Handle reverse video mode.
6388         (tui_set_reverse_mode): New function.
6389         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6390         * tui/tui-winsource.c (tui_show_source_line): Use
6391         tui_set_reverse_mode instead of setting A_STANDOUT.
6392         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6393         New setter methods.
6394
6395 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6396
6397         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6398         Handle tabs.
6399
6400 2019-03-18  Tom Tromey  <tromey@adacore.com>
6401
6402         * ada-lang.c (empty_array): Add "high" parameter.
6403         (ada_evaluate_subexp): Update.
6404
6405 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6406
6407         * unittests/string_view-selftests.c: Define
6408         _initialize_string_view_selftests unconditionally.
6409
6410 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6411
6412         PR gdb/24350
6413         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6414
6415 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6416
6417         PR gdb/24351
6418         * windows-nat.c (display_selector): Fix format specifiers.
6419
6420 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6421
6422         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6423         tui_refill_source_window instead of tui_refresh_win, to update the
6424         current execution line.  This fixes redisplay of the current line
6425         when stepping through the code with "next" or "step".
6426
6427 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6428
6429         * source-cache.c (source_cache::get_source_lines): Call
6430         find_source_lines to initialize s->nlines.  This fixes vertical
6431         scrolling of TUI source window when the DOWN arrow is pressed.
6432
6433 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6434
6435         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6436         linux-thread-db.c (_initialize_thread_db): Likewise.
6437
6438 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6439
6440         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6441         wclrtoeol in tui_show_source_line".  This reverts changes made in
6442         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6443
6444 2019-03-15  Tom Tromey  <tom@tromey.com>
6445
6446         * symtab.h (struct minimal_symbol): Derive from
6447         general_symbol_info.
6448         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6449         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6450         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6451         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6452         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6453         (MSYMBOL_SEARCH_NAME): Update.
6454         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6455         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6456         * minsyms.c (minimal_symbol_reader::record_full): Update.
6457
6458 2019-03-15  Tom Tromey  <tom@tromey.com>
6459
6460         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6461
6462 2019-03-15  Tom Tromey  <tom@tromey.com>
6463
6464         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6465         unique_xmalloc_ptr.
6466         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6467         Update.
6468         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6469         (build_minimal_symbol_hash_tables)
6470         (minimal_symbol_reader::install): Update.
6471
6472 2019-03-15  Tom Tromey  <tom@tromey.com>
6473
6474         * symtab.c (create_demangled_names_hash): Update.
6475         (symbol_set_names): Update.
6476         * objfiles.h (struct objfile_per_bfd_storage)
6477         <demangled_names_hash>: Now an htab_up.
6478         * objfiles.c (objfile_per_bfd_storage): Simplify.
6479
6480 2019-03-15  Tom Tromey  <tom@tromey.com>
6481
6482         * objfiles.h (struct objfile_per_bfd_storage): Declare
6483         destructor.
6484         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6485         New.
6486         (get_objfile_bfd_data): Use new.  Don't initialize
6487         language_of_main.
6488         (free_objfile_per_bfd_storage): Remove.
6489         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6490
6491 2019-03-15  Tom Tromey  <tom@tromey.com>
6492
6493         * symfile.c (reread_symbols): Update.
6494         * objfiles.c (objfile::objfile): Update.
6495         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6496         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6497         comment.
6498         (minimal_symbol_reader::install): Update.
6499         (terminate_minimal_symbol_table): Remove.
6500         * jit.c (jit_object_close_impl): Update.
6501
6502 2019-03-15  Tom Tromey  <tom@tromey.com>
6503
6504         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6505         initializations.
6506
6507 2019-03-15  Tom Tromey  <tom@tromey.com>
6508
6509         * objfiles.h (struct objfile_per_bfd_storage)
6510         <demangled_hash_languages>: Now a bitset.
6511         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6512         (lookup_minimal_symbol): Update.
6513
6514 2019-03-15  Tom Tromey  <tom@tromey.com>
6515
6516         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6517         Don't return the symbol.
6518         * coffread.c (record_minimal_symbol): Use record_full.
6519
6520 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6521
6522         The MS-Windows port of ncurses fails to switch to a color pair if
6523         one or both of the colors are the implicit default colors.  This
6524         change records the default colors when TUI is initialized, and
6525         then specifies them explicitly when a color pair uses the default
6526         colors.  This allows color styling in TUI mode on MS-Windows.
6527
6528         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6529         ncurses_norm_attr.
6530         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6531         colors in ncurses_norm_attr.
6532         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6533         "none", replace it with the default color recorded in
6534         ncurses_norm_attr.
6535
6536 2019-03-14  Tom Tromey  <tromey@adacore.com>
6537
6538         * source-cache.h (class source_cache) <get_source_lines>: Return
6539         std::string.
6540         * source-cache.c (source_cache::extract_lines): Handle case where
6541         first_pos==npos.  Return std::string.
6542         (source_cache::get_source_lines): Update.
6543
6544 2019-03-14  Tom Tromey  <tromey@adacore.com>
6545
6546         * NEWS: Add item for "style sources" commands.
6547         * source-cache.c (source_cache::get_source_lines): Check
6548         source_styling.
6549         * cli/cli-style.c (source_styling): New global.
6550         (_initialize_cli_style): Add "style sources" commands.
6551         (show_style_sources): New function.
6552         * cli/cli-style.h (source_styling): Declare.
6553
6554 2019-03-14  Pedro Alves  <palves@redhat.com>
6555             Tom Tromey  <tromey@adacore.com>
6556
6557         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6558         * tui/tui-winsource.c (tui_refill_source_window): New function,
6559         from...
6560         (tui_horizontal_source_scroll): ... here.  Move some logic.
6561         * cli/cli-style.c (set_style_enabled): Notify new observable.
6562         * tui/tui-hooks.c (tui_redisplay_source): New function.
6563         (tui_attach_detach_observers): Attach or detach
6564         tui_redisplay_source.
6565         * observable.h (source_styling_changed): New observable.
6566         * observable.c: Define source_styling_changed observable.
6567
6568 2019-03-13  Tom Tromey  <tromey@adacore.com>
6569
6570         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6571         (i386_gnu_nat_target::store_registers): Update.
6572         * target-debug.h (target_debug_print_std_string): New macro.
6573         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6574         * windows-tdep.c (display_one_tib): Update.
6575         * tui/tui-stack.c (tui_make_status_line): Update.
6576         * top.c (print_inferior_quit_action): Update.
6577         * thread.c (thr_try_catch_cmd): Update.
6578         (add_thread_with_info): Update.
6579         (thread_target_id_str): Update.
6580         (thr_try_catch_cmd): Update.
6581         (thread_command): Update.
6582         (thread_find_command): Update.
6583         * record-btrace.c (record_btrace_target::info_record)
6584         (record_btrace_resume_thread, record_btrace_target::resume)
6585         (record_btrace_cancel_resume, record_btrace_step_thread)
6586         (record_btrace_target::wait, record_btrace_target::wait)
6587         (record_btrace_target::wait, record_btrace_target::stop): Update.
6588         * progspace.c (print_program_space): Update.
6589         * process-stratum-target.c
6590         (process_stratum_target::thread_address_space): Update.
6591         * linux-fork.c (linux_fork_mourn_inferior)
6592         (detach_checkpoint_command, info_checkpoints_command)
6593         (linux_fork_context): Update.
6594         (linux_fork_detach): Update.
6595         (class scoped_switch_fork_info): Update.
6596         (delete_checkpoint_command): Update.
6597         * infrun.c (follow_fork_inferior): Update.
6598         (follow_fork_inferior): Update.
6599         (proceed_after_vfork_done): Update.
6600         (handle_vfork_child_exec_or_exit): Update.
6601         (follow_exec): Update.
6602         (displaced_step_prepare_throw): Update.
6603         (displaced_step_restore): Update.
6604         (start_step_over): Update.
6605         (resume_1): Update.
6606         (clear_proceed_status_thread): Update.
6607         (proceed): Update.
6608         (print_target_wait_results): Update.
6609         (do_target_wait): Update.
6610         (context_switch): Update.
6611         (stop_all_threads): Update.
6612         (restart_threads): Update.
6613         (finish_step_over): Update.
6614         (handle_signal_stop): Update.
6615         (switch_back_to_stepped_thread): Update.
6616         (keep_going_pass_signal): Update.
6617         (print_exited_reason): Update.
6618         (normal_stop): Update.
6619         * inferior.c (inferior_pid_to_str): Change return type.
6620         (print_selected_inferior): Update.
6621         (add_inferior): Update.
6622         (detach_inferior): Update.
6623         * dummy-frame.c (fprint_dummy_frames): Update.
6624         * dcache.c (dcache_info_1): Update.
6625         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6626         (btrace_fetch, btrace_clear): Update.
6627         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6628         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6629         type.
6630         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6631         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6632         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6633         * gdbarch.c, gdbarch.h: Rebuild.
6634         * gdbarch.sh (core_pid_to_str): Change return type.
6635         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6636         return type.
6637         (windows_nat_target::pid_to_str): Change return type.
6638         (windows_delete_thread): Update.
6639         (windows_nat_target::attach): Update.
6640         (windows_nat_target::files_info): Update.
6641         * target-delegates.c: Rebuild.
6642         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6643         return type.
6644         (sol_thread_target::pid_to_str): Change return type.
6645         * remote.c (class remote_target) <pid_to_str>: Change return
6646         type.
6647         (remote_target::pid_to_str): Change return type.
6648         (extended_remote_target::attach, remote_target::remote_stop_ns)
6649         (remote_target::remote_notif_remove_queued_reply)
6650         (remote_target::push_stop_reply, remote_target::disable_btrace):
6651         Update.
6652         (extended_remote_target::attach): Update.
6653         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6654         type.
6655         (gdbsim_target::pid_to_str): Change return type.
6656         * ravenscar-thread.c (struct ravenscar_thread_target)
6657         <pid_to_str>: Change return type.
6658         (ravenscar_thread_target::pid_to_str): Change return type.
6659         * procfs.c (class procfs_target) <pid_to_str>: Change return
6660         type.
6661         (procfs_target::pid_to_str): Change return type.
6662         (procfs_target::attach): Update.
6663         (procfs_target::detach): Update.
6664         (procfs_target::fetch_registers): Update.
6665         (procfs_target::store_registers): Update.
6666         (procfs_target::wait): Update.
6667         (procfs_target::files_info): Update.
6668         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6669         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6670         return type.
6671         (nto_procfs_target::pid_to_str): Change return type.
6672         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6673         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6674         return type.
6675         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6676         (exit_lwp): Update.
6677         (attach_proc_task_lwp_callback, get_detach_signal)
6678         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6679         (linux_nat_target::resume, wait_lwp, stop_callback)
6680         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6681         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6682         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6683         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6684         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6685         type.
6686         (inf_ptrace_target::attach): Update.
6687         (inf_ptrace_target::files_info): Update.
6688         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6689         type.
6690         (go32_nat_target::pid_to_str): Change return type.
6691         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6692         (gnu_nat_target::wait): Update.
6693         (gnu_nat_target::wait): Update.
6694         (gnu_nat_target::resume): Update.
6695         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6696         (fbsd_nat_target::wait): Update.
6697         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6698         type.
6699         (darwin_nat_target::attach): Update.
6700         * corelow.c (class core_target) <pid_to_str>: Change return type.
6701         (core_target::pid_to_str): Change return type.
6702         * target.c (normal_pid_to_str): Change return type.
6703         (default_pid_to_str): Likewise.
6704         (target_pid_to_str): Change return type.
6705         (target_translate_tls_address): Update.
6706         (target_announce_detach): Update.
6707         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6708         return type.
6709         (bsd_uthread_target::pid_to_str): Change return type.
6710         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6711         type.
6712         (bsd_kvm_target::pid_to_str): Change return type.
6713         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6714         return type.
6715         (aix_thread_target::pid_to_str): Change return type.
6716         * target.h (struct target_ops) <pid_to_str>: Change return type.
6717         (target_pid_to_str, normal_pid_to_str): Likewise.
6718         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6719         type.
6720         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6721         type.
6722         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6723         return type.
6724         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6725         type.
6726         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6727         type.
6728         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6729         return type.
6730
6731 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6732
6733         * NEWS: Mention that the new default MI version is 3.  Mention
6734         changes to the output of commands and events that deal with
6735         multi-location breakpoints.
6736         * breakpoint.c: Include "mi/mi-out.h".
6737         (print_one_breakpoint): Change output syntax if using MI version
6738         >= 3.
6739         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6740         New.
6741         (mi_multi_location_breakpoint_output_fixed): New.
6742         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6743         (mi_cmd_fix_multi_location_breakpoint_output): New.
6744         (mi_multi_location_breakpoint_output_fixed): New.
6745         * mi/mi-cmds.c (mi_cmds): Register command
6746         -fix-multi-location-breakpoint-output.
6747         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6748         interpreter "mi".
6749
6750 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6751
6752         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6753         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6754         instantiate mi_ui_out based on interpreter name.
6755         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6756         * mi/mi-main.c (mi_load_progress): Likewise.
6757
6758 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6759
6760         * NEWS: Combine separate "New targets" sections for 8.3.
6761
6762 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6763
6764         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6765         (ppcfbsd_init_abi): Install gdbarch
6766         "fetch_tls_load_module_address" and "get_thread_local_address"
6767         methods.
6768
6769 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6770
6771         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6772         (riscv_fbsd_init_abi): Install gdbarch
6773         "fetch_tls_load_module_address" and "get_thread_local_address"
6774         methods.
6775
6776 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6777
6778         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6779         (i386fbsd_init_abi): Install gdbarch
6780         "fetch_tls_load_module_address" and "get_thread_local_address"
6781         methods.
6782
6783 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6784
6785         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6786         (amd64fbsd_init_abi): Install gdbarch
6787         "fetch_tls_load_module_address" and "get_thread_local_address"
6788         methods.
6789
6790 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6791
6792         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6793         (struct fbsd_pspace_data): New type.
6794         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6795         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6796         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6797         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6798         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6799
6800 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6801
6802         * gdbtypes.c (lookup_struct_elt): New function.
6803         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6804         * gdbtypes.h (struct struct_elt): New type.
6805         (lookup_struct_elt): New prototype.
6806
6807 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6808
6809         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6810         remove disabled code block.
6811
6812 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6813
6814         * gdbarch.sh (get_thread_local_address): New method.
6815         * gdbarch.h, gdbarch.c: Regenerate.
6816         * target.c (target_translate_tls_address): Use
6817         gdbarch_get_thread_local_address if present instead of
6818         target::get_thread_local_address.
6819
6820 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6821
6822         * target.h (target::get_thread_local_address): Update comment.
6823
6824 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6825
6826         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6827         objfile->separate_debug_objfile_backlink if not NULL.
6828
6829 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6830
6831         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6832         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6833         (amd64bsd_store_inferior_registers): Likewise.
6834         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6835         Enable segment base registers.
6836         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6837         PT_GETFSBASE and PT_GETGSBASE.
6838         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6839         PT_SETGSBASE.
6840         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6841         segment base registers.
6842         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6843
6844 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6845
6846         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6847         Update calls to i386_target_description to add 'segments'
6848         parameter.
6849         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6850         add segment base registers.
6851         * arch/i386.c (i386_create_target_description): Add 'segments'
6852         parameter to enable segment base registers.
6853         * arch/i386.h (i386_create_target_description): Likewise.
6854         * features/i386/32bit-segments.xml: New file.
6855         * features/i386/32bit-segments.c: Generate.
6856         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6857         call to i386_target_description to add 'segments' parameter.
6858         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6859         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6860         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6861         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6862         if feature is present.
6863         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6864         Add 'segments' parameter to call to i386_target_description.
6865         (i386_target_description): Add 'segments' parameter to enable
6866         segment base registers.
6867         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6868         to call to i386_target_description.
6869         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6870         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6871         Define I386_NUM_REGS.
6872         (i386_target_description): Add 'segments' parameter to enable
6873         segment base registers.
6874
6875 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6876
6877         PR/24325
6878         * source-cache.c: #undef open and close, to avoid unresolved
6879         externals during linking.
6880
6881 2019-03-12  Tom Tromey  <tromey@adacore.com>
6882
6883         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6884         const.  Add initializers.
6885         (_initialize_remote): Don't initialize ptid globals.
6886
6887 2019-03-12  Pedro Alves  <palves@redhat.com>
6888
6889         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6890
6891 2019-03-12  Pedro Alves  <palves@redhat.com>
6892
6893         * cp-name-parser.y (main): Remove unused 'len' variable.
6894
6895 2019-03-12  Tom Tromey  <tromey@adacore.com>
6896
6897         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6898         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6899
6900 2019-03-12  Tom Tromey  <tromey@adacore.com>
6901
6902         * linux-nat.c (iterate_over_lwps): Update.
6903         (stop_callback): Remove parameter.
6904         (stop_wait_callback, detach_callback, resume_set_callback)
6905         (select_singlestep_lwp_callback, set_ignore_sigint)
6906         (status_callback, resumed_callback, resume_clear_callback)
6907         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6908         data parameter.
6909         (linux_nat_target::detach, linux_nat_target::resume)
6910         (linux_stop_and_wait_all_lwps, select_event_lwp)
6911         (linux_nat_filter_event, linux_nat_wait_1)
6912         (linux_nat_target::kill, linux_nat_target::stop)
6913         (linux_nat_target::stop): Update.
6914         (linux_nat_resume_callback): Change type.
6915         (resume_stopped_resumed_lwps, count_events_callback)
6916         (select_event_lwp_callback): Likewise.
6917         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6918         * arm-linux-nat.c (struct update_registers_data): Remove.
6919         (update_registers_callback): Change type.
6920         (arm_linux_insert_hw_breakpoint1): Update.
6921         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6922         parameter.
6923         (x86_linux_dr_set_addr): Update.
6924         (x86_linux_dr_set_control): Update.
6925         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6926         (iterate_over_lwps): Use gdb::function_view.
6927         * nat/aarch64-linux-hw-point.c (struct
6928         aarch64_dr_update_callback_param): Remove.
6929         (debug_reg_change_callback): Change type.
6930         (aarch64_notify_debug_reg_change): Update.
6931         * s390-linux-nat.c (s390_refresh_per_info): Update.
6932
6933 2019-03-11  Tom Tromey  <tromey@adacore.com>
6934
6935         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6936         redundant assignment to "this_cu".
6937
6938 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6939
6940         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6941
6942 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6943
6944         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6945         from...
6946         (rank_one_type): ... this.
6947
6948 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6949
6950         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6951         from...
6952         (rank_one_type): ... this.
6953
6954 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6955
6956         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6957         from...
6958         (rank_one_type): ... this.
6959
6960 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6961
6962         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6963         from...
6964         (rank_one_type): ... this.
6965
6966 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6967
6968         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6969         from...
6970         (rank_one_type): ... this.
6971
6972 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6973
6974         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6975         from...
6976         (rank_one_type): ... this.
6977
6978 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6979
6980         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6981         from...
6982         (rank_one_type): ... this.
6983
6984 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6985
6986         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6987         from...
6988         (rank_one_type): ... this.
6989
6990 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6991
6992         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6993         from...
6994         (rank_one_type): ... this.
6995
6996 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6997
6998         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6999         from...
7000         (rank_one_type): ... this.
7001
7002 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7003
7004         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7005         from...
7006         (rank_one_type): ... this.
7007
7008 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7009
7010         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7011         from...
7012         (rank_one_type): ... this.
7013
7014 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7015
7016         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7017         inferior-events' shows the example events.
7018
7019 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7020
7021         Support styling on native MS-Windows console
7022
7023         PR/24315
7024         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7025         on MS-Windows if $TERM is not defined.
7026
7027         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7028
7029         * posix-hdep.c (gdb_console_fputs):
7030         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7031         functions.
7032         * ui-file.h (gdb_console_fputs): Add prototype.
7033
7034         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7035         back to fputs only if the former returns zero.
7036
7037 2019-03-07  Tom Tromey  <tom@tromey.com>
7038
7039         * symmisc.c (print_symbol_bcache_statistics): Update.
7040         (print_objfile_statistics): Update.
7041         * symfile.c (allocate_symtab): Update.
7042         * stabsread.c: Don't include bcache.h.
7043         * psymtab.h (struct psymbol_bcache): Don't declare.
7044         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7045         (psymbol_bcache_init, psymbol_bcache_free)
7046         (psymbol_bcache_get_bcache): Don't declare.
7047         * psymtab.c (struct psymbol_bcache): Remove.
7048         (psymtab_storage::psymtab_storage): Update.
7049         (psymtab_storage::~psymtab_storage): Update.
7050         (psymbol_bcache_init, psymbol_bcache_free)
7051         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7052         (add_psymbol_to_bcache): Update.
7053         (allocate_psymtab): Update.
7054         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7055         macro_cache>: No longer pointers.
7056         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7057         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7058         * macrotab.c (macro_bcache): Update.
7059         * macroexp.c: Don't include bcache.h.
7060         * gdbtypes.c (check_types_worklist): Update.
7061         (types_deeply_equal): Remove TRY/CATCH.  Update.
7062         * elfread.c (elf_symtab_read): Update.
7063         * dwarf2read.c: Don't include bcache.h.
7064         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7065         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7066         (print_bcache_statistics, bcache_memory_used): Don't declare.
7067         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7068         methods.  Rename all data members.
7069         * bcache.c (struct bcache): Move to bcache.h.
7070         (bcache::expand_hash_table): Rename from expand_hash_table.
7071         (bcache): Remove.
7072         (bcache::insert): Rename from bcache_full.
7073         (bcache::compare): Rename from bcache_compare.
7074         (bcache_xmalloc): Remove.
7075         (bcache::~bcache): Rename from bcache_xfree.
7076         (bcache::print_statistics): Rename from print_bcache_statistics.
7077         (bcache::memory_used): Rename from bcache_memory_used.
7078
7079 2019-03-07  Pedro Alves  <palves@redhat.com>
7080
7081         * infrun.c (normal_stop): Also check for
7082         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7083
7084 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7085
7086         * f-lang.c (value_from_host_double): Moved to...
7087         * value.c (value_from_host_double): ...here.
7088         * value.h (value_from_host_double): Declare.
7089         * guile/scm-math.c (vlscm_convert_typed_number): Use
7090         value_from_host_double.
7091         (vlscm_convert_number): Likewise.
7092         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7093         * python/py-value.c (convert_value_from_python): Likewise.
7094
7095 2019-03-06  Tom Tromey  <tom@tromey.com>
7096
7097         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7098
7099 2019-03-06  Tom Tromey  <tom@tromey.com>
7100
7101         * utils.h (free_current_contents): Don't declare.
7102         * utils.c (free_current_contents): Remove.
7103
7104 2019-03-06  Tom Tromey  <tom@tromey.com>
7105
7106         * top.c (quit_force): Update.
7107         * main.c (captured_command_loop): Update.
7108         * common/new-op.c (operator new): Update.
7109         * common/common-exceptions.c (struct catcher)
7110         <save_cleanup_chain>: Remove member.
7111         (exceptions_state_mc_init): Update.
7112         (exception_try_scope_entry): Return nullptr.
7113         (exception_try_scope_exit, exception_rethrow)
7114         (throw_exception_sjlj, throw_exception_cxx): Update.
7115         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7116         (all_cleanups, do_cleanups, discard_cleanups)
7117         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7118         (restore_cleanups, restore_final_cleanups): Don't declare.
7119         (do_final_cleanups): Remove parameter.
7120         * common/cleanups.c (cleanup_chain, make_cleanup)
7121         (make_cleanup_dtor, all_cleanups, do_cleanups)
7122         (discard_my_cleanups, discard_cleanups)
7123         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7124         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7125         (null_cleanup): Remove.
7126         (do_final_cleanups): Remove parameter.
7127
7128 2019-03-06  Tom Tromey  <tom@tromey.com>
7129
7130         * remote.c (remote_target::remote_parse_stop_reply): Use
7131         unique_xmalloc_ptr.
7132
7133 2019-03-06  Tom Tromey  <tom@tromey.com>
7134
7135         * stabsread.c (struct stabs_field_info): Rename from field_info.
7136         <list, fnlist>: Add initializers.
7137         <obstack>: New member.
7138         (read_member_functions, read_struct_fields, read_baseclasses):
7139         Allocate on obstack.  Don't use cleanups.
7140         (read_one_struct_field, read_member_functions, read_struct_fields)
7141         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7142         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7143         (read_struct_type): Update.
7144
7145 2019-03-06  Tom Tromey  <tom@tromey.com>
7146
7147         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7148         * common/filestuff.h (make_cleanup_close): Don't declare.
7149         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7150         Remove.
7151
7152 2019-03-06  Tom Tromey  <tom@tromey.com>
7153
7154         * solib-aix.c: Use make_scope_exit.
7155
7156 2019-03-06  Tom Tromey  <tom@tromey.com>
7157
7158         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7159         Use make_scope_exit.
7160
7161 2019-03-06  Tom Tromey  <tom@tromey.com>
7162
7163         * solib-svr4.c (disable_probes_interface): Remove parameter.
7164         (svr4_handle_solib_event): Use make_scope_exit.
7165
7166 2019-03-06  Tom Tromey  <tom@tromey.com>
7167
7168         * remote.c (struct stop_reply_deleter): Remove.
7169         (stop_reply_up): Update.
7170         (struct stop_reply): Derive from notif_event.  Don't typedef.
7171         <regcache>: Now a std::vector.
7172         (stop_reply_xfree): Remove.
7173         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7174         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7175         (remote_target::discard_pending_stop_replies): Use delete.
7176         (remote_target::remote_parse_stop_reply): Update.
7177         (remote_target::process_stop_reply): Update.
7178         * remote-notif.h (struct notif_event): Add virtual destructor.
7179         Remove "dtr" member.
7180         (struct notif_client) <alloc_event>: Return a unique_ptr.
7181         (notif_event_xfree): Don't declare.
7182         (notif_event_up): New typedef.
7183         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7184         (notif_event_xfree, do_notif_event_xfree): Remove.
7185         (remote_notif_state_xfree): Update.
7186
7187 2019-03-06  Tom Tromey  <tom@tromey.com>
7188
7189         * infrun.c (displaced_step_clear_cleanup): Now a
7190         forward_scope_exit type.
7191         (displaced_step_prepare_throw): Update.
7192         (displaced_step_fixup): Update.
7193
7194 2019-03-06  Tom Tromey  <tom@tromey.com>
7195
7196         * inferior.h (class inferior): Update comment.
7197         * gdbthread.h (class thread_info): Update comment.
7198
7199 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7200             Tom Tromey  <tom@tromey.com>
7201
7202         * stabsread.h (struct stab_section_list): Remove.
7203         (coffstab_build_psymtabs): Update.
7204         * dbxread.c (symbuf_sections): Now a std::vector.
7205         (sect_idx): New global.
7206         (fill_symbuf): Update.
7207         (coffstab_build_psymtabs): Change type of stabsects parameter.
7208         Update.
7209         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7210         std::vector.
7211         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7212         (coff_locate_sections): Update.
7213         (coff_symfile_read): Remove cleanups.  Update.
7214         (init_stringtab): Add storage parameter.
7215         (free_stringtab, free_stringtab_cleanup): Remove.
7216         (init_lineno): Add storage parameter.
7217         (free_linetab, free_linetab_cleanup): Remove.
7218
7219 2019-03-06  Pedro Alves  <palves@redhat.com>
7220
7221         * linux-fork.c (fork_info::clobber_regs): Delete.
7222         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7223         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7224         comment.  Adjust.
7225         (scoped_switch_fork_info::scoped_switch_fork_info)
7226         (checkpoint_command, linux_fork_context): Adjust
7227         fork_save_infrun_state calls.
7228
7229 2019-03-06  Pedro Alves  <palves@redhat.com>
7230
7231         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7232         (inf_has_multiple_threads): Return 'bool' and rewrite using
7233         inferior_info::threads().
7234
7235 2019-03-06  Pedro Alves  <palves@redhat.com>
7236
7237         * linux-fork.c: Include <list>.
7238         (fork_list): Now a std::list instance.
7239         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7240         (forks_exist_p, find_last_fork): Adjust.
7241         (new_fork): Delete.
7242         (one_fork_p): New.
7243         (add_fork): Adjust.
7244         (free_fork): Delete, folded into fork_info::~fork_info().
7245         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7246         Adjust.
7247         (init_fork_list): Delete.
7248         (linux_fork_killall, linux_fork_mourn_inferior)
7249         (linux_fork_detach, info_checkpoints_command): Adjust.
7250         (_initialize_linux_fork): No longer call init_fork_list.
7251
7252 2019-03-06  Pedro Alves  <palves@redhat.com>
7253
7254         * linux-fork.c (new_fork): New, split out of ...
7255         (add_fork): ... this.  Return void.  Move "first fork" special
7256         case from here, to ...
7257         (checkpoint_command): ... here.
7258         * linux-linux.h (add_fork): Return void.
7259
7260 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7261
7262         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7263
7264 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7265             Chris January  <chris.january@arm.com>
7266             David Lecomber  <david.lecomber@arm.com>
7267
7268         * f-exp.y: New token, UNOP_INTRINSIC.
7269         (exp): New pattern using UNOP_INTRINSIC token.
7270         (f77_keywords): Add 'abs' keyword.
7271         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7272         (value_from_host_double): New function.
7273         (evaluate_subexp_f): Support UNOP_ABS.
7274
7275 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7276
7277         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7278         types.
7279
7280 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7281
7282         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7283         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7284         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7285
7286 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7287
7288         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7289
7290 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7291             Chris January  <chris.january@arm.com>
7292
7293         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7294         * f-exp.y: Define 'KIND' token.
7295         (exp): New pattern for KIND expressions.
7296         (ptype): Handle types with a kind extension.
7297         (direct_abs_decl): Extend to spot kind extensions.
7298         (f77_keywords): Add 'kind' to the list.
7299         (push_kind_type): New function.
7300         (convert_to_kind_type): New function.
7301         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7302         * parse.c (operator_length_standard): Likewise.
7303         * parser-defs.h (enum type_pieces): Add tp_kind.
7304         * std-operator.def: Add UNOP_KIND.
7305
7306 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7307
7308         * f-exp.y (f_parse): Set yydebug.
7309
7310 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7311
7312         * f-lang.c (evaluate_subexp_f): New function.
7313         (exp_descriptor_f): New global.
7314         (f_language_defn): Use exp_descriptor_f instead of
7315         exp_descriptor_standard.
7316
7317 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7318
7319         * f-exp.y (struct token): Add comments.
7320         (dot_ops): Remove uppercase versions and the end marker.
7321         (f77_keywords): Likewise.
7322         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7323         entries in the dot_ops array are case insensitive, and use
7324         strncasecmp to compare strings.  Also some whitespace cleanup in
7325         this area.  Similar for the f77_keywords array, except entries in
7326         this list might be case sensitive.
7327
7328 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7329
7330         * f-exp.y (struct f77_boolean_val): Add comments.
7331         (boolean_values): Remove uppercase versions, and end marker.
7332         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7333         and use strncasecmp to achieve case insensitivity.  Additionally,
7334         perform whitespace cleanup around this code.
7335
7336 2019-03-06  Tom Tromey  <tromey@adacore.com>
7337
7338         * remote-sim.c (gdbsim_target_open): Use result of
7339         gdb_argv::release.
7340
7341 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7342         Dirk Schubert  <dirk.schubert@arm.com>
7343         Chris January  <chris.january@arm.com>
7344
7345         * eval.c (evaluate_subexp_standard): Call Fortran argument
7346         wrapping logic.
7347         * f-lang.c (struct value): A value which can be passed into a
7348         Fortran function call.
7349         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7350         where appropriate.
7351         (struct type): Value ready for a Fortran function call.
7352         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7353         is needed.
7354         * f-lang.h (fortran_argument_convert): Declaration.
7355         (fortran_preserve_arg_pointer): Declaration.
7356         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7357
7358 2019-03-05  Tom Tromey  <tromey@adacore.com>
7359
7360         * python/py-prettyprint.c (print_string_repr): Remove #if.
7361         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7362
7363 2019-03-05  Tom Tromey  <tromey@adacore.com>
7364
7365         * target.c (the_dummy_target): Move later.  Change type to
7366         "dummy_target".
7367         (initialize_targets): Don't initialize the_dummy_target.
7368
7369 2019-03-05  Tom Tromey  <tromey@adacore.com>
7370
7371         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7372         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7373
7374 2019-03-05  Tom Tromey  <tromey@adacore.com>
7375
7376         * windows-nat.c (windows_nat_target::attach)
7377         (windows_nat_target::detach): Don't call gdb_flush.
7378         * valprint.c (generic_val_print, val_print, val_print_string):
7379         Don't call gdb_flush.
7380         * utils.c (defaulted_query): Don't call gdb_flush.
7381         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7382         * target.c (target_announce_detach): Don't call gdb_flush.
7383         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7384         * remote.c (extended_remote_target::attach): Don't call
7385         gdb_flush.
7386         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7387         * printcmd.c (do_examine): Don't call gdb_flush.
7388         (info_display_command): Don't call gdb_flush.
7389         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7390         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7391         * memattr.c (info_mem_command): Don't call gdb_flush.
7392         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7393         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7394         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7395         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7396         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7397         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7398         (gnu_nat_target::detach): Don't call gdb_flush.
7399         * f-valprint.c (f_val_print): Don't call gdb_flush.
7400         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7401         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7402         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7403         gdb_flush.
7404         * c-valprint.c (c_val_print): Don't call gdb_flush.
7405         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7406
7407 2019-03-05  Tom Tromey  <tromey@adacore.com>
7408
7409         * varobj.c (update_dynamic_varobj_children): Update.
7410         (install_default_visualizer): Use reset, not release.
7411         * value.c (set_internalvar): Update.
7412         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7413         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7414         ATTRIBUTE_UNUSED_RESULT.
7415
7416 2019-03-05  Tom Tromey  <tromey@adacore.com>
7417
7418         * remote.c (class scoped_remote_fd) <release>: Add
7419         ATTRIBUTE_UNUSED_RESULT.
7420
7421 2019-03-05  Tom Tromey  <tromey@adacore.com>
7422
7423         * macroexp.c (struct macro_buffer) <release>: Add
7424         ATTRIBUTE_UNUSED_RESULT.
7425
7426 2019-03-05  Tom Tromey  <tromey@adacore.com>
7427
7428         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7429         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7430         ATTRIBUTE_UNUSED_RESULT.
7431
7432 2019-03-05  Tom Tromey  <tromey@adacore.com>
7433
7434         * common/scoped_fd.h (class scoped_fd) <release>: Add
7435         ATTRIBUTE_UNUSED_RESULT.
7436
7437 2019-03-05  Tom Tromey  <tromey@adacore.com>
7438
7439         * parser-defs.h (struct parser_state) <release>: Add
7440         ATTRIBUTE_UNUSED_RESULT.
7441
7442 2019-03-05  Tom Tromey  <tromey@adacore.com>
7443
7444         * utils.h (class gdb_argv) <release>: Add
7445         ATTRIBUTE_UNUSED_RESULT.
7446         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7447
7448 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7449
7450         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7451         for-loop range, to avoid compiler warnings.
7452
7453         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7454         avoid compiler warnings about unused variables.
7455
7456         * NEWS: Mention end of support for native debugging on MS-Windows
7457         before XP.
7458
7459         PR gdb/24292
7460         * common/netstuff.c:
7461         * gdbserver/gdbreplay.c
7462         * gdbserver/remote-utils.c:
7463         * ser-tcp.c:
7464         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7465         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7466         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7467         'getaddrinfo' and 'freeaddrinfo' were not available before
7468         Windows XP, and mingw.org's MinGW headers by default define
7469         _WIN32_WINNT to 0x500.
7470
7471 2019-03-01  Gary Benson <gbenson@redhat.com>
7472
7473         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7474
7475 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7476             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7477
7478         PR gdb/8527
7479         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7480         set_sigint_trap, clear_sigint_trap.
7481
7482 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7483
7484         * target.c (target_detach): Clear the regcache and the
7485         frame cache.
7486
7487 2019-02-27  Pedro Alves  <palves@redhat.com>
7488
7489         * utils.c (set_screen_size): When we cap the height/width sizes,
7490         tweak the corresponding command variable to show "unlimited":
7491
7492 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7493             Pedro Alves  <palves@redhat.com>
7494
7495         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7496         before calling rl_set_screen_size.
7497
7498 2019-02-27  Tom Tromey  <tromey@adacore.com>
7499
7500         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7501         define.
7502         * python/py-value.c: Remove Python 2.4 workaround.
7503         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7504         workaround.
7505         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7506         Python 2.4 workaround.
7507         * python/python-internal.h: Remove Python 2.4 comment.
7508         (Py_ssize_t): Don't define.
7509         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7510         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7511         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7512         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7513         * python/python.c (do_start_initialization): Remove Python 2.4
7514         workaround.
7515         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7516         (print_children): Remove Python 2.4 workaround.
7517         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7518         workaround.
7519         (CHARBUFFERPROC_NAME): Remove.
7520         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7521         Python 2.4 workaround.
7522
7523 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7524
7525         * NEWS: Note minimum Python version.
7526
7527 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7528
7529         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7530         code from these functions.  Remove corresponding ifdefs.  Use
7531         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7532         Remove gotos and target of gotos.
7533         (infpy_search_memory): Likewise.
7534
7535 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7536
7537         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7538         (hppa_gdbarch_init): Don't register deleted functions with
7539         gdbarch.
7540
7541 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7542
7543         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7544         (h8300_unwind_sp): Delete.
7545         (h8300_dummy_id): Delete.
7546         (h8300_gdbarch_init): Don't register deleted functions with
7547         gdbarch.
7548
7549 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7550
7551         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7552         (ft32_unwind_pc): Delete.
7553         (ft32_unwind_sp): Delete.
7554         (ft32_gdbarch_init): Don't register deleted functions with
7555         gdbarch.
7556
7557 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7558
7559         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7560         (frv_unwind_pc): Delete.
7561         (frv_unwind_sp): Delete.
7562         (frv_gdbarch_init): Don't register deleted functions with
7563         gdbarch.
7564
7565 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7566
7567         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7568         (riscv_unwind_pc): Delete.
7569         (riscv_unwind_sp): Delete.
7570         (riscv_gdbarch_init): Don't register deleted functions with
7571         gdbarch.
7572
7573 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7574
7575         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7576         (csky_unwind_pc): Delete.
7577         (csky_unwind_sp): Delete.
7578         (csky_gdbarch_init): Don't register deleted functions with
7579         gdbarch.
7580
7581 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7582
7583         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7584         (cris_unwind_pc): Delete.
7585         (cris_unwind_sp): Delete.
7586         (cris_gdbarch_init): Don't register deleted functions with
7587         gdbarch.
7588
7589 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7590
7591         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7592         (bfin_unwind_pc): Delete.
7593         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7594
7595 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7596
7597         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7598         (arm_unwind_pc): Delete.
7599         (arm_unwind_sp): Delete.
7600         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7601
7602 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7603
7604         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7605         (arc_unwind_pc): Delete.
7606         (arc_unwind_sp): Delete.
7607         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7608
7609 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7610
7611         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7612         (alpha_unwind_pc): Delete.
7613         (alpha_gdbarch_init): Don't register deleted functions with
7614         gdbarch.
7615
7616 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7617
7618         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7619         (aarch64_unwind_pc): Delete.
7620         (aarch64_unwind_sp): Delete.
7621         (aarch64_gdbarch_init): Don't register deleted functions with
7622         gdbarch.
7623
7624 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7625
7626         * gdbtypes.c (type_align): Don't consider static members when
7627         computing structure alignment.
7628
7629 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7630
7631         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7632         return 0 for other types.
7633         * arch-utils.c (default_type_align): Always return 0.
7634         * gdbarch.h: Regenerate.
7635         * gdbarch.sh (type_align): Extend comment.
7636         * gdbtypes.c (type_align): Add additional comments, always call
7637         gdbarch_type_align before applying the default rules.
7638         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7639         generic code will then apply a suitable default.
7640         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7641         types, return 0 for other types.
7642
7643 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7644
7645         * NEWS: Create a new section for the next release branch.
7646         Rename the section of the current branch, now that it has
7647         been cut.
7648
7649 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7650
7651         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7652         * version.in: Bump version to 8.3.50.DATE-git.
7653
7654 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7655
7656         * aix-thread.c (ptid_cmp): Remove unused variable.
7657         (get_signaled_thread): Likewise.
7658         (store_regs_user_thread): Likewise.
7659         (store_regs_kernel_thread): Likewise.
7660         (fetch_regs_kernel_thread): Remove shadowed variable.
7661
7662 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7663
7664         * features/riscv/32bit-cpu.xml: Add register numbers.
7665         * features/riscv/32bit-fpu.c: Regenerate.
7666         * features/riscv/32bit-fpu.xml: Add register numbers.
7667         * features/riscv/64bit-cpu.xml: Add register numbers.
7668         * features/riscv/64bit-fpu.c: Regenerate.
7669         * features/riscv/64bit-fpu.xml: Add register numbers.
7670
7671 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7672
7673         * NEWS: Mention two argument form of gdb.Value constructor.
7674         * python/py-value.c (convert_buffer_and_type_to_value): New
7675         function.
7676         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7677         Add support for handling an optional second argument.  Call
7678         convert_buffer_and_type_to_value as appropriate.
7679         * python/python-internal.h (Py_buffer_deleter): New struct.
7680         (Py_buffer_up): New typedef.
7681
7682 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7683
7684         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7685         instead of releasing ownership.
7686
7687 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7688
7689         * dwarf2read.c (open_and_init_dwp_file): Call
7690         elf_numsections instead of bfd_count_sections to initialize
7691         dwp_file->num_sections.
7692
7693 2019-02-25  Tom Tromey  <tromey@adacore.com>
7694
7695         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7696
7697 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7698
7699         * gcore.in: Add '--readnever' option when invoking GDB.
7700
7701 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7702
7703         * MAINTAINERS: Update my email address.
7704
7705 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7706
7707         * build-id.c (build_id_to_debug_bfd_1): New function.
7708         (build_id_to_debug_bfd): Look for separate debug file in
7709         sysroot.
7710
7711 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7712
7713         * gdbarch.sh: Update the copyright year range that is placed into
7714         generated files.
7715
7716 2019-02-22  Keith Seitz  <keiths@redhat.com>
7717
7718         PR symtab/23853
7719         * linespec.c (create_sals_line_offset): Search for the default
7720         symtab's filename instead of its fullname.
7721
7722 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7723
7724         * NEWS: Update style defaults.
7725
7726 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7727
7728         * main.c (captured_main_1): Disable styling in batch mode.
7729
7730 2019-02-20  Tom Tromey  <tom@tromey.com>
7731
7732         * symtab.c (symtab_symbol_info): Fix typos.
7733
7734 2019-02-20  Tom Tromey  <tromey@adacore.com>
7735
7736         * findcmd.c (_initialize_mem_search): Use upper case for
7737         metasyntactic variables.
7738
7739 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7740
7741         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7742         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7743
7744 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7745
7746         * top.h (source_file_name): Change to std::string.
7747         * top.c (source_file_name): Likewise.
7748         (command_line_input): Adjust.
7749         * cli/cli-script.c (script_from_file): Adjust.
7750
7751 2019-02-19  Tom Tromey  <tromey@adacore.com>
7752
7753         * ravenscar-thread.c
7754         (ravenscar_thread_target::update_thread_list): Don't call
7755         ada_build_task_list.
7756         * ada-lang.h (ada_build_task_list): Don't declare.
7757         * ada-tasks.c (struct ada_tasks_inferior_data)
7758         <task_list_valid_p>: Now bool.
7759         (read_known_tasks, ada_task_list_changed)
7760         (ada_tasks_invalidate_inferior_data): Update.
7761         (read_known_tasks_array): Return bool.
7762         (read_known_tasks_list): Likewise.
7763         (read_known_tasks): Return void.
7764         (ada_build_task_list): Now static.
7765
7766 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7767
7768         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7769         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7770
7771 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7772
7773         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7774         variant for ada_tasks_pspace_data_handle and
7775         ada_tasks_inferior_data_handle.
7776         (ada_tasks_pspace_data_cleanup): New function.
7777         (ada_tasks_inferior_data_cleanup): New function.
7778
7779 2019-02-17  Tom Tromey  <tom@tromey.com>
7780
7781         * macrotab.h (macro_source_fullname): Return a std::string.
7782         * macrotab.c (macro_include, check_for_redefinition)
7783         (macro_undef, macro_lookup_definition, foreach_macro)
7784         (foreach_macro_in_scope): Update.
7785         (macro_source_fullname): Return a std::string.
7786         * macrocmd.c (show_pp_source_pos): Update.
7787
7788 2019-02-17  Tom Tromey  <tom@tromey.com>
7789
7790         * macrocmd.c (show_pp_source_pos): Style the file names.
7791
7792 2019-02-17  Tom Tromey  <tom@tromey.com>
7793
7794         PR tui/24197:
7795         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7796
7797 2019-02-17  Tom Tromey  <tom@tromey.com>
7798
7799         * ada-lang.c (user_select_syms): Use filtered printing.
7800         * utils.c (wrap_style): New global.
7801         (desired_style): Remove.
7802         (emit_style_escape): Add stream parameter.
7803         (set_output_style, reset_terminal_style, prompt_for_continue):
7804         Update.
7805         (flush_wrap_buffer): Only flush gdb_stdout.
7806         (wrap_here): Set wrap_style.
7807         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7808         treat escape sequences as a character.  Change when wrap buffer is
7809         flushed.
7810         (fputs_styled): Do not set the output style when the default is
7811         requested.
7812         * ui-style.h (struct ui_file_style) <is_default>: New method.
7813         * source.c (print_source_lines_base): Emit escape sequences in one
7814         piece.
7815
7816 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7817
7818         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7819         integers and enumeration types.
7820
7821 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7822
7823         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7824         instead of lookup_symbol_in_language
7825         (do_exact_match): New function.
7826         (ada_get_symbol_name_matcher): Return do_exact_match when
7827         doing a verbatim match.
7828
7829 2019-02-15  Tom Tromey  <tromey@adacore.com>
7830
7831         * ravenscar-thread.c (ravenscar_thread_target::resume)
7832         (ravenscar_thread_target::wait): Special case wildcard requests.
7833
7834 2019-02-15  Tom Tromey  <tromey@adacore.com>
7835
7836         * ravenscar-thread.c (base_ptid): Remove.
7837         (struct ravenscar_thread_target) <close>: New method.
7838         <m_base_ptid>: New member.
7839         <update_inferior_ptid, active_task, task_is_currently_active,
7840         runtime_initialized>: Declare methods.
7841         <ravenscar_thread_target>: Add constructor.
7842         (ravenscar_thread_target::task_is_currently_active)
7843         (ravenscar_thread_target::update_inferior_ptid)
7844         (ravenscar_runtime_initialized): Rename.  Now methods.
7845         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7846         (ravenscar_thread_target::update_thread_list): Update.
7847         (ravenscar_thread_target::active_task): Now method.
7848         (ravenscar_thread_target::store_registers)
7849         (ravenscar_thread_target::prepare_to_store)
7850         (ravenscar_thread_target::prepare_to_store)
7851         (ravenscar_thread_target::mourn_inferior): Update.
7852         (ravenscar_inferior_created): Use "new" to create target.
7853         (ravenscar_thread_target::get_ada_task_ptid): Update.
7854         (_initialize_ravenscar): Don't initialize base_ptid.
7855         (ravenscar_ops): Remove global.
7856
7857 2019-02-15  Tom Tromey  <tromey@adacore.com>
7858
7859         * target.h (push_target): Declare new overload.
7860         * target.c (push_target): New overload, taking an rvalue reference.
7861         * remote.c (remote_target::open_1): Use push_target overload.
7862         * corelow.c (core_target_open): Use push_target overload.
7863
7864 2019-02-15  Tom Tromey  <tromey@adacore.com>
7865
7866         * ravenscar-thread.c (is_ravenscar_task)
7867         (ravenscar_task_is_currently_active): Return bool.
7868         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7869         (_initialize_ravenscar): Remove "(void)".
7870         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7871         Return bool.
7872
7873 2019-02-15  Tom Tromey  <tromey@adacore.com>
7874
7875         * ravenscar-thread.c (ravenscar_runtime_initializer)
7876         (has_ravenscar_runtime, get_running_thread_id)
7877         (ravenscar_thread_target::resume): Fix indentation.
7878
7879 2019-02-15  Tom Tromey  <tromey@adacore.com>
7880
7881         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7882         from ravenscar_arch_ops.
7883         (sparc_ravenscar_ops::fetch_registers)
7884         (sparc_ravenscar_ops::store_registers): Now methods.
7885         (sparc_ravenscar_prepare_to_store): Remove.
7886         (sparc_ravenscar_ops): Redefine.
7887         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7888         methods and destructor.  Remove members.
7889         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7890         (ravenscar_thread_target::store_registers)
7891         (ravenscar_thread_target::prepare_to_store): Update.
7892         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7893         Remove.
7894         (struct ppc_ravenscar_powerpc_ops): Derive from
7895         ravenscar_arch_ops.
7896         (ppc_ravenscar_powerpc_ops::fetch_registers)
7897         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7898         (ppc_ravenscar_powerpc_ops): Redefine.
7899         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7900         (ppc_ravenscar_e500_ops::fetch_registers)
7901         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7902         (ppc_ravenscar_e500_ops): Redefine.
7903         * aarch64-ravenscar-thread.c
7904         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7905         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7906         (aarch64_ravenscar_fetch_registers)
7907         (aarch64_ravenscar_store_registers): Now methods.
7908         (aarch64_ravenscar_ops): Redefine.
7909
7910 2019-02-15  Tom Tromey  <tromey@adacore.com>
7911
7912         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7913         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7914         (ravenscar_thread_target::stopped_by_watchpoint)
7915         (ravenscar_thread_target::stopped_data_address)
7916         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7917
7918 2019-02-15  Tom Tromey  <tromey@adacore.com>
7919
7920         * ravenscar-thread.c: Fix some typos.
7921
7922 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7923             Tom Tromey  <tromey@adacore.com>
7924
7925         * ada-lang.c (ada_exception_sal): Change addr_string to a
7926         std::string.
7927         (create_ada_exception_catchpoint): Update.
7928
7929 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7930             Tom Tromey  <tromey@adacore.com>
7931
7932         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7933         (bp_location_ops): Remove.
7934         (base_breakpoint_allocate_location): Update.
7935         (free_bp_location): Update.
7936         * ada-lang.c (class ada_catchpoint_location)
7937         <ada_catchpoint_location>: Remove ops parameter.
7938         (ada_catchpoint_location_dtor): Remove.
7939         (ada_catchpoint_location_ops): Remove.
7940         (allocate_location_exception): Update.
7941         * breakpoint.h (struct bp_location_ops): Remove.
7942         (class bp_location) <bp_location>: Remove bp_location_ops
7943         parameter.
7944         <~bp_location>: Add destructor.
7945         <ops>: Remove.
7946
7947 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7948             Pedro Alves  <palves@redhat.com>
7949
7950         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7951         'PATH_MAX'.
7952
7953 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7954             Samuel Thibault  <samuel.thibault@gnu.org>
7955             Thomas Schwinge  <thomas@codesourcery.com>
7956
7957         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7958         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7959
7960 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7961
7962         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7963         (check_empty): Use "const char *".
7964
7965         * gnu-nat.c (gnu_nat_target::detach): Instead of
7966         'detach_inferior (pid)' call
7967         'detach_inferior (find_inferior_pid (pid))'.
7968
7969         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7970         'nat/fork-inferior.o'.
7971         * gnu-nat.c: #include "nat/fork-inferior.h".
7972
7973         * gnu-nat.c (gnu_nat_target::detach): Instead of
7974         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7975         * gnu-nat.h: #include "inf-child.h".
7976         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7977         'i386_gnu_nat_target::fetch_registers'.
7978         (gnu_store_registers): Rename/move to
7979         'i386_gnu_nat_target::store_registers'.
7980
7981         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7982         * gnu-nat.h (mach_thread_info): New function.
7983         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7984
7985         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7986
7987 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7988
7989         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7990
7991 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7992
7993         * windows-nat.c (windows_add_thread): Add new parameter
7994         "main_thread_p" with default value set to false.  Update
7995         function documentation as well as all callers.
7996         (windows_delete_thread): Likewise.
7997         (fake_create_process): Update call to windows_add_thread.
7998         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7999         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8000         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8001         call to windows_delete_thread.
8002
8003 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8004
8005         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8006
8007 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8008
8009         * symfile.c (find_separate_debug_file): Use canonical path of
8010         sysroot with child_path instead of gdb_sysroot if it is valid.
8011
8012 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8013
8014         * symfile.c (find_separate_debug_file): Use child_path to
8015         determine if an object file is under a sysroot.
8016
8017 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8018
8019         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8020         unittests/child-path-selftests.c.
8021         * common/pathstuff.c (child_path): New function.
8022         * common/pathstuff.h (child_path): New prototype.
8023         * unittests/child-path-selftests.c: New file.
8024
8025 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8026
8027         * symfile.c (find_separate_debug_file): Look for separate debug
8028         files in debug directories under the sysroot.
8029
8030 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8031
8032         * symtab.h (struct minimal_symbol data_p): New const method.
8033         (struct minimal_symbol text_p): Likewise.
8034         * symtab.c (output_source_filename): Use file name style
8035         to print file name.
8036         (print_symbol_info): Likewise.
8037         (print_msymbol_info): Use address style to print addresses.
8038         Use function name style to print executable text symbols.
8039         (expand_symtab_containing_pc): Use data_p.
8040         (find_pc_sect_compunit_symtab): Likewise.
8041
8042 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8043
8044         * breakpoint.c (describe_other_breakpoints): Use address style
8045         to print addresses.
8046         (say_where): Likewise.
8047
8048 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8049
8050         * ada-typeprint.c (print_func_type): Print function name
8051         style to print function name.
8052         * c-typeprint.c (c_print_type_1): Likewise.
8053
8054 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8055
8056         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8057         for execve.
8058
8059 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8060
8061         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8062         type_stack.
8063
8064 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8065
8066         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8067         TYPE_CODE_REF types.
8068
8069 2019-02-08  Jim Wilson  <jimw@sifive.com>
8070
8071         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8072         (riscv_linux_fregset): New.
8073         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8074
8075 2019-02-07  Tom Tromey  <tom@tromey.com>
8076
8077         * thread.c (thread_cancel_execution_command): Update.
8078         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8079         methods.
8080         (struct thread_fsm_ops): Remove.
8081         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8082         (thread_fsm_should_stop, thread_fsm_return_value)
8083         (thread_fsm_set_finished, thread_fsm_finished_p)
8084         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8085         Don't declare.
8086         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8087         * infrun.c (clear_proceed_status_thread)
8088         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8089         (print_stop_event): Update.
8090         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8091         Add constructor.
8092         (step_command_fsm_ops): Remove.
8093         (new_step_command_fsm): Remove.
8094         (step_1): Update.
8095         (step_command_fsm::should_stop): Rename from
8096         step_command_fsm_should_stop.
8097         (step_command_fsm::clean_up): Rename from
8098         step_command_fsm_clean_up.
8099         (step_command_fsm::do_async_reply_reason): Rename from
8100         step_command_fsm_async_reply_reason.
8101         (struct until_next_fsm): Inherit from thread_fsm.  Add
8102         constructor.
8103         (until_next_fsm_ops): Remove.
8104         (new_until_next_fsm): Remove.
8105         (until_next_fsm::should_stop): Rename from
8106         until_next_fsm_should_stop.
8107         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8108         (until_next_fsm::do_async_reply_reason): Rename from
8109         until_next_fsm_async_reply_reason.
8110         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8111         constructor.  Change type of breakpoint.
8112         (finish_command_fsm_ops): Remove.
8113         (new_finish_command_fsm): Remove.
8114         (finish_command_fsm::should_stop): Rename from
8115         finish_command_fsm_should_stop.
8116         (finish_command_fsm::clean_up): Rename from
8117         finish_command_fsm_clean_up.
8118         (finish_command_fsm::return_value): Rename from
8119         finish_command_fsm_return_value.
8120         (finish_command_fsm::do_async_reply_reason): Rename from
8121         finish_command_fsm_async_reply_reason.
8122         (finish_command): Update.
8123         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8124         Add constructor.
8125         (call_thread_fsm_ops): Remove.
8126         (call_thread_fsm::call_thread_fsm): Rename from
8127         new_call_thread_fsm.
8128         (call_thread_fsm::should_stop): Rename from
8129         call_thread_fsm_should_stop.
8130         (call_thread_fsm::should_notify_stop): Rename from
8131         call_thread_fsm_should_notify_stop.
8132         (run_inferior_call, call_function_by_hand_dummy): Update.
8133         * cli/cli-interp.c (should_print_stop_to_console): Update.
8134         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8135         Add constructor.  Change type of location_breakpoint,
8136         caller_breakpoint.
8137         (until_break_fsm_ops): Remove.
8138         (new_until_break_fsm): Remove.
8139         (until_break_fsm::should_stop): Rename from
8140         until_break_fsm_should_stop.
8141         (until_break_fsm::clean_up): Rename from
8142         until_break_fsm_clean_up.
8143         (until_break_fsm::do_async_reply_reason): Rename from
8144         until_break_fsm_async_reply_reason.
8145         (until_break_command): Update.
8146         * thread-fsm.c: Remove.
8147         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8148
8149 2019-02-07  Tom Tromey  <tom@tromey.com>
8150
8151         * yy-remap.h: Add include guard.
8152         * xtensa-tdep.h: Add include guard.
8153         * xcoffread.h: Rename include guard.
8154         * varobj-iter.h: Add include guard.
8155         * tui/tui.h: Rename include guard.
8156         * tui/tui-winsource.h: Rename include guard.
8157         * tui/tui-wingeneral.h: Rename include guard.
8158         * tui/tui-windata.h: Rename include guard.
8159         * tui/tui-win.h: Rename include guard.
8160         * tui/tui-stack.h: Rename include guard.
8161         * tui/tui-source.h: Rename include guard.
8162         * tui/tui-regs.h: Rename include guard.
8163         * tui/tui-out.h: Rename include guard.
8164         * tui/tui-layout.h: Rename include guard.
8165         * tui/tui-io.h: Rename include guard.
8166         * tui/tui-hooks.h: Rename include guard.
8167         * tui/tui-file.h: Rename include guard.
8168         * tui/tui-disasm.h: Rename include guard.
8169         * tui/tui-data.h: Rename include guard.
8170         * tui/tui-command.h: Rename include guard.
8171         * tic6x-tdep.h: Add include guard.
8172         * target/waitstatus.h: Rename include guard.
8173         * target/wait.h: Rename include guard.
8174         * target/target.h: Rename include guard.
8175         * target/resume.h: Rename include guard.
8176         * target-float.h: Rename include guard.
8177         * stabsread.h: Add include guard.
8178         * rs6000-tdep.h: Add include guard.
8179         * riscv-fbsd-tdep.h: Add include guard.
8180         * regformats/regdef.h: Rename include guard.
8181         * record.h: Rename include guard.
8182         * python/python.h: Rename include guard.
8183         * python/python-internal.h: Rename include guard.
8184         * python/py-stopevent.h: Rename include guard.
8185         * python/py-ref.h: Rename include guard.
8186         * python/py-record.h: Rename include guard.
8187         * python/py-record-full.h: Rename include guard.
8188         * python/py-record-btrace.h: Rename include guard.
8189         * python/py-instruction.h: Rename include guard.
8190         * python/py-events.h: Rename include guard.
8191         * python/py-event.h: Rename include guard.
8192         * procfs.h: Add include guard.
8193         * proc-utils.h: Add include guard.
8194         * p-lang.h: Add include guard.
8195         * or1k-tdep.h: Rename include guard.
8196         * observable.h: Rename include guard.
8197         * nto-tdep.h: Rename include guard.
8198         * nat/x86-linux.h: Rename include guard.
8199         * nat/x86-linux-dregs.h: Rename include guard.
8200         * nat/x86-gcc-cpuid.h: Add include guard.
8201         * nat/x86-dregs.h: Rename include guard.
8202         * nat/x86-cpuid.h: Rename include guard.
8203         * nat/ppc-linux.h: Rename include guard.
8204         * nat/mips-linux-watch.h: Rename include guard.
8205         * nat/linux-waitpid.h: Rename include guard.
8206         * nat/linux-ptrace.h: Rename include guard.
8207         * nat/linux-procfs.h: Rename include guard.
8208         * nat/linux-osdata.h: Rename include guard.
8209         * nat/linux-nat.h: Rename include guard.
8210         * nat/linux-namespaces.h: Rename include guard.
8211         * nat/linux-btrace.h: Rename include guard.
8212         * nat/glibc_thread_db.h: Rename include guard.
8213         * nat/gdb_thread_db.h: Rename include guard.
8214         * nat/gdb_ptrace.h: Rename include guard.
8215         * nat/fork-inferior.h: Rename include guard.
8216         * nat/amd64-linux-siginfo.h: Rename include guard.
8217         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8218         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8219         * nat/aarch64-linux.h: Rename include guard.
8220         * nat/aarch64-linux-hw-point.h: Rename include guard.
8221         * mn10300-tdep.h: Add include guard.
8222         * mips-linux-tdep.h: Add include guard.
8223         * mi/mi-parse.h: Rename include guard.
8224         * mi/mi-out.h: Rename include guard.
8225         * mi/mi-main.h: Rename include guard.
8226         * mi/mi-interp.h: Rename include guard.
8227         * mi/mi-getopt.h: Rename include guard.
8228         * mi/mi-console.h: Rename include guard.
8229         * mi/mi-common.h: Rename include guard.
8230         * mi/mi-cmds.h: Rename include guard.
8231         * mi/mi-cmd-break.h: Rename include guard.
8232         * m2-lang.h: Add include guard.
8233         * location.h: Rename include guard.
8234         * linux-record.h: Rename include guard.
8235         * linux-nat.h: Add include guard.
8236         * linux-fork.h: Add include guard.
8237         * i386-darwin-tdep.h: Rename include guard.
8238         * hppa-linux-offsets.h: Add include guard.
8239         * guile/guile.h: Rename include guard.
8240         * guile/guile-internal.h: Rename include guard.
8241         * gnu-nat.h: Rename include guard.
8242         * gdb-stabs.h: Rename include guard.
8243         * frv-tdep.h: Add include guard.
8244         * f-lang.h: Add include guard.
8245         * event-loop.h: Add include guard.
8246         * darwin-nat.h: Rename include guard.
8247         * cp-abi.h: Rename include guard.
8248         * config/sparc/nm-sol2.h: Rename include guard.
8249         * config/nm-nto.h: Rename include guard.
8250         * config/nm-linux.h: Add include guard.
8251         * config/i386/nm-i386gnu.h: Rename include guard.
8252         * config/djgpp/nl_types.h: Rename include guard.
8253         * config/djgpp/langinfo.h: Rename include guard.
8254         * compile/gcc-cp-plugin.h: Add include guard.
8255         * compile/gcc-c-plugin.h: Add include guard.
8256         * compile/compile.h: Rename include guard.
8257         * compile/compile-object-run.h: Rename include guard.
8258         * compile/compile-object-load.h: Rename include guard.
8259         * compile/compile-internal.h: Rename include guard.
8260         * compile/compile-cplus.h: Rename include guard.
8261         * compile/compile-c.h: Rename include guard.
8262         * common/xml-utils.h: Rename include guard.
8263         * common/x86-xstate.h: Rename include guard.
8264         * common/version.h: Rename include guard.
8265         * common/vec.h: Rename include guard.
8266         * common/tdesc.h: Rename include guard.
8267         * common/selftest.h: Rename include guard.
8268         * common/scoped_restore.h: Rename include guard.
8269         * common/scoped_mmap.h: Rename include guard.
8270         * common/scoped_fd.h: Rename include guard.
8271         * common/safe-iterator.h: Rename include guard.
8272         * common/run-time-clock.h: Rename include guard.
8273         * common/refcounted-object.h: Rename include guard.
8274         * common/queue.h: Rename include guard.
8275         * common/ptid.h: Rename include guard.
8276         * common/print-utils.h: Rename include guard.
8277         * common/preprocessor.h: Rename include guard.
8278         * common/pathstuff.h: Rename include guard.
8279         * common/observable.h: Rename include guard.
8280         * common/netstuff.h: Rename include guard.
8281         * common/job-control.h: Rename include guard.
8282         * common/host-defs.h: Rename include guard.
8283         * common/gdb_wait.h: Rename include guard.
8284         * common/gdb_vecs.h: Rename include guard.
8285         * common/gdb_unlinker.h: Rename include guard.
8286         * common/gdb_unique_ptr.h: Rename include guard.
8287         * common/gdb_tilde_expand.h: Rename include guard.
8288         * common/gdb_sys_time.h: Rename include guard.
8289         * common/gdb_string_view.h: Rename include guard.
8290         * common/gdb_splay_tree.h: Rename include guard.
8291         * common/gdb_setjmp.h: Rename include guard.
8292         * common/gdb_ref_ptr.h: Rename include guard.
8293         * common/gdb_optional.h: Rename include guard.
8294         * common/gdb_locale.h: Rename include guard.
8295         * common/gdb_assert.h: Rename include guard.
8296         * common/filtered-iterator.h: Rename include guard.
8297         * common/filestuff.h: Rename include guard.
8298         * common/fileio.h: Rename include guard.
8299         * common/environ.h: Rename include guard.
8300         * common/common-utils.h: Rename include guard.
8301         * common/common-types.h: Rename include guard.
8302         * common/common-regcache.h: Rename include guard.
8303         * common/common-inferior.h: Rename include guard.
8304         * common/common-gdbthread.h: Rename include guard.
8305         * common/common-exceptions.h: Rename include guard.
8306         * common/common-defs.h: Rename include guard.
8307         * common/common-debug.h: Rename include guard.
8308         * common/cleanups.h: Rename include guard.
8309         * common/buffer.h: Rename include guard.
8310         * common/btrace-common.h: Rename include guard.
8311         * common/break-common.h: Rename include guard.
8312         * cli/cli-utils.h: Rename include guard.
8313         * cli/cli-style.h: Rename include guard.
8314         * cli/cli-setshow.h: Rename include guard.
8315         * cli/cli-script.h: Rename include guard.
8316         * cli/cli-interp.h: Rename include guard.
8317         * cli/cli-decode.h: Rename include guard.
8318         * cli/cli-cmds.h: Rename include guard.
8319         * charset-list.h: Add include guard.
8320         * buildsym-legacy.h: Rename include guard.
8321         * bfin-tdep.h: Add include guard.
8322         * ax.h: Rename include guard.
8323         * arm-linux-tdep.h: Add include guard.
8324         * arm-fbsd-tdep.h: Add include guard.
8325         * arch/xtensa.h: Rename include guard.
8326         * arch/tic6x.h: Add include guard.
8327         * arch/i386.h: Add include guard.
8328         * arch/arm.h: Rename include guard.
8329         * arch/arm-linux.h: Rename include guard.
8330         * arch/arm-get-next-pcs.h: Rename include guard.
8331         * arch/amd64.h: Add include guard.
8332         * arch/aarch64-insn.h: Rename include guard.
8333         * arch-utils.h: Rename include guard.
8334         * annotate.h: Add include guard.
8335         * amd64-darwin-tdep.h: Rename include guard.
8336         * aarch64-linux-tdep.h: Add include guard.
8337         * aarch64-fbsd-tdep.h: Add include guard.
8338         * aarch32-linux-nat.h: Add include guard.
8339
8340 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8341
8342         * macrotab.c (macro_define_internal): New function that
8343         factorizes macro_define_object_internal and macro_define_function
8344         code.
8345         (macro_define_object_internal): Use macro_define_internal.
8346         (macro_define_function): Likewise.
8347
8348 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8349
8350         * macrocmd.c (extract_identifier): Return
8351         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8352         callers.
8353
8354 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8355
8356         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8357
8358 2019-02-05  Tom Tromey  <tom@tromey.com>
8359
8360         * target.c (target_stack::unpush): Move assertion earlier.
8361
8362 2019-01-30  Tom Tromey  <tom@tromey.com>
8363
8364         PR python/23615:
8365         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8366         (gdbpy_parse_and_eval): Likewise.
8367         * python/python-internal.h (gdbpy_allow_threads): New class.
8368
8369 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8370
8371         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8372         (aarch64_fbsd_fpregmap): Move earlier.
8373         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8374         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8375         instead of individual calls to trad_frame_set_reg_addr.
8376         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8377         earlier.
8378         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8379         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8380         instead of individual calls to trad_frame_set_reg_addr.
8381
8382 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8383
8384         * CONTRIBUTE: Replace contribution list with wiki link.
8385
8386 2019-01-25  Tom Tromey  <tom@tromey.com>
8387
8388         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8389
8390 2019-01-25  Tom Tromey  <tom@tromey.com>
8391
8392         * xtensa-linux-nat.c: Fix common/ includes.
8393         * xml-support.h: Fix common/ includes.
8394         * xml-support.c: Fix common/ includes.
8395         * x86-linux-nat.c: Fix common/ includes.
8396         * windows-nat.c: Fix common/ includes.
8397         * varobj.h: Fix common/ includes.
8398         * varobj.c: Fix common/ includes.
8399         * value.c: Fix common/ includes.
8400         * valops.c: Fix common/ includes.
8401         * utils.c: Fix common/ includes.
8402         * unittests/xml-utils-selftests.c: Fix common/ includes.
8403         * unittests/utils-selftests.c: Fix common/ includes.
8404         * unittests/unpack-selftests.c: Fix common/ includes.
8405         * unittests/tracepoint-selftests.c: Fix common/ includes.
8406         * unittests/style-selftests.c: Fix common/ includes.
8407         * unittests/string_view-selftests.c: Fix common/ includes.
8408         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8409         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8410         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8411         * unittests/rsp-low-selftests.c: Fix common/ includes.
8412         * unittests/parse-connection-spec-selftests.c: Fix common/
8413         includes.
8414         * unittests/optional-selftests.c: Fix common/ includes.
8415         * unittests/offset-type-selftests.c: Fix common/ includes.
8416         * unittests/observable-selftests.c: Fix common/ includes.
8417         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8418         * unittests/memrange-selftests.c: Fix common/ includes.
8419         * unittests/memory-map-selftests.c: Fix common/ includes.
8420         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8421         * unittests/function-view-selftests.c: Fix common/ includes.
8422         * unittests/environ-selftests.c: Fix common/ includes.
8423         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8424         * unittests/common-utils-selftests.c: Fix common/ includes.
8425         * unittests/cli-utils-selftests.c: Fix common/ includes.
8426         * unittests/array-view-selftests.c: Fix common/ includes.
8427         * ui-file.c: Fix common/ includes.
8428         * tui/tui-io.c: Fix common/ includes.
8429         * tracepoint.h: Fix common/ includes.
8430         * tracepoint.c: Fix common/ includes.
8431         * tracefile-tfile.c: Fix common/ includes.
8432         * top.h: Fix common/ includes.
8433         * top.c: Fix common/ includes.
8434         * thread.c: Fix common/ includes.
8435         * target/waitstatus.h: Fix common/ includes.
8436         * target/waitstatus.c: Fix common/ includes.
8437         * target.h: Fix common/ includes.
8438         * target.c: Fix common/ includes.
8439         * target-memory.c: Fix common/ includes.
8440         * target-descriptions.c: Fix common/ includes.
8441         * symtab.h: Fix common/ includes.
8442         * symfile.c: Fix common/ includes.
8443         * stap-probe.c: Fix common/ includes.
8444         * spu-linux-nat.c: Fix common/ includes.
8445         * sparc-nat.c: Fix common/ includes.
8446         * source.c: Fix common/ includes.
8447         * solib.c: Fix common/ includes.
8448         * solib-target.c: Fix common/ includes.
8449         * ser-unix.c: Fix common/ includes.
8450         * ser-tcp.c: Fix common/ includes.
8451         * ser-pipe.c: Fix common/ includes.
8452         * ser-base.c: Fix common/ includes.
8453         * selftest-arch.c: Fix common/ includes.
8454         * s12z-tdep.c: Fix common/ includes.
8455         * rust-exp.y: Fix common/ includes.
8456         * rs6000-aix-tdep.c: Fix common/ includes.
8457         * riscv-tdep.c: Fix common/ includes.
8458         * remote.c: Fix common/ includes.
8459         * remote-notif.h: Fix common/ includes.
8460         * remote-fileio.h: Fix common/ includes.
8461         * remote-fileio.c: Fix common/ includes.
8462         * regcache.h: Fix common/ includes.
8463         * regcache.c: Fix common/ includes.
8464         * record-btrace.c: Fix common/ includes.
8465         * python/python.c: Fix common/ includes.
8466         * python/py-type.c: Fix common/ includes.
8467         * python/py-inferior.c: Fix common/ includes.
8468         * progspace.h: Fix common/ includes.
8469         * producer.c: Fix common/ includes.
8470         * procfs.c: Fix common/ includes.
8471         * proc-api.c: Fix common/ includes.
8472         * printcmd.c: Fix common/ includes.
8473         * ppc-linux-nat.c: Fix common/ includes.
8474         * parser-defs.h: Fix common/ includes.
8475         * osdata.c: Fix common/ includes.
8476         * obsd-nat.c: Fix common/ includes.
8477         * nat/x86-linux.c: Fix common/ includes.
8478         * nat/x86-linux-dregs.c: Fix common/ includes.
8479         * nat/x86-dregs.h: Fix common/ includes.
8480         * nat/x86-dregs.c: Fix common/ includes.
8481         * nat/ppc-linux.c: Fix common/ includes.
8482         * nat/mips-linux-watch.h: Fix common/ includes.
8483         * nat/mips-linux-watch.c: Fix common/ includes.
8484         * nat/linux-waitpid.c: Fix common/ includes.
8485         * nat/linux-ptrace.h: Fix common/ includes.
8486         * nat/linux-ptrace.c: Fix common/ includes.
8487         * nat/linux-procfs.c: Fix common/ includes.
8488         * nat/linux-personality.c: Fix common/ includes.
8489         * nat/linux-osdata.c: Fix common/ includes.
8490         * nat/linux-namespaces.c: Fix common/ includes.
8491         * nat/linux-btrace.h: Fix common/ includes.
8492         * nat/linux-btrace.c: Fix common/ includes.
8493         * nat/fork-inferior.c: Fix common/ includes.
8494         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8495         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8496         * nat/aarch64-linux.c: Fix common/ includes.
8497         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8498         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8499         * namespace.h: Fix common/ includes.
8500         * mips-linux-tdep.c: Fix common/ includes.
8501         * minsyms.c: Fix common/ includes.
8502         * mi/mi-parse.h: Fix common/ includes.
8503         * mi/mi-main.c: Fix common/ includes.
8504         * mi/mi-cmd-env.c: Fix common/ includes.
8505         * memrange.h: Fix common/ includes.
8506         * memattr.c: Fix common/ includes.
8507         * maint.h: Fix common/ includes.
8508         * maint.c: Fix common/ includes.
8509         * main.c: Fix common/ includes.
8510         * machoread.c: Fix common/ includes.
8511         * location.c: Fix common/ includes.
8512         * linux-thread-db.c: Fix common/ includes.
8513         * linux-nat.c: Fix common/ includes.
8514         * linux-fork.c: Fix common/ includes.
8515         * inline-frame.c: Fix common/ includes.
8516         * infrun.c: Fix common/ includes.
8517         * inflow.c: Fix common/ includes.
8518         * inferior.h: Fix common/ includes.
8519         * inferior.c: Fix common/ includes.
8520         * infcmd.c: Fix common/ includes.
8521         * inf-ptrace.c: Fix common/ includes.
8522         * inf-child.c: Fix common/ includes.
8523         * ia64-linux-nat.c: Fix common/ includes.
8524         * i387-tdep.c: Fix common/ includes.
8525         * i386-tdep.c: Fix common/ includes.
8526         * i386-linux-tdep.c: Fix common/ includes.
8527         * i386-linux-nat.c: Fix common/ includes.
8528         * i386-go32-tdep.c: Fix common/ includes.
8529         * i386-fbsd-tdep.c: Fix common/ includes.
8530         * i386-fbsd-nat.c: Fix common/ includes.
8531         * guile/scm-type.c: Fix common/ includes.
8532         * guile/guile.c: Fix common/ includes.
8533         * go32-nat.c: Fix common/ includes.
8534         * gnu-nat.c: Fix common/ includes.
8535         * gdbthread.h: Fix common/ includes.
8536         * gdbarch-selftests.c: Fix common/ includes.
8537         * gdb_usleep.c: Fix common/ includes.
8538         * gdb_select.h: Fix common/ includes.
8539         * gdb_bfd.c: Fix common/ includes.
8540         * gcore.c: Fix common/ includes.
8541         * fork-child.c: Fix common/ includes.
8542         * findvar.c: Fix common/ includes.
8543         * fbsd-nat.c: Fix common/ includes.
8544         * event-top.c: Fix common/ includes.
8545         * event-loop.c: Fix common/ includes.
8546         * dwarf2read.c: Fix common/ includes.
8547         * dwarf2loc.c: Fix common/ includes.
8548         * dwarf2-frame.c: Fix common/ includes.
8549         * dwarf-index-cache.c: Fix common/ includes.
8550         * dtrace-probe.c: Fix common/ includes.
8551         * disasm-selftests.c: Fix common/ includes.
8552         * defs.h: Fix common/ includes.
8553         * csky-tdep.c: Fix common/ includes.
8554         * cp-valprint.c: Fix common/ includes.
8555         * cp-support.h: Fix common/ includes.
8556         * cp-support.c: Fix common/ includes.
8557         * corelow.c: Fix common/ includes.
8558         * completer.h: Fix common/ includes.
8559         * completer.c: Fix common/ includes.
8560         * compile/compile.c: Fix common/ includes.
8561         * compile/compile-loc2c.c: Fix common/ includes.
8562         * compile/compile-cplus-types.c: Fix common/ includes.
8563         * compile/compile-cplus-symbols.c: Fix common/ includes.
8564         * command.h: Fix common/ includes.
8565         * cli/cli-dump.c: Fix common/ includes.
8566         * cli/cli-cmds.c: Fix common/ includes.
8567         * charset.c: Fix common/ includes.
8568         * build-id.c: Fix common/ includes.
8569         * btrace.h: Fix common/ includes.
8570         * btrace.c: Fix common/ includes.
8571         * breakpoint.h: Fix common/ includes.
8572         * breakpoint.c: Fix common/ includes.
8573         * ax.h:
8574         (enum agent_op): Fix common/ includes.
8575         * ax-general.c (struct aop_map): Fix common/ includes.
8576         * ax-gdb.c: Fix common/ includes.
8577         * auxv.c: Fix common/ includes.
8578         * auto-load.c: Fix common/ includes.
8579         * arm-tdep.c: Fix common/ includes.
8580         * arch/riscv.c: Fix common/ includes.
8581         * arch/ppc-linux-common.c: Fix common/ includes.
8582         * arch/i386.c: Fix common/ includes.
8583         * arch/arm.c: Fix common/ includes.
8584         * arch/arm-linux.c: Fix common/ includes.
8585         * arch/arm-get-next-pcs.c: Fix common/ includes.
8586         * arch/amd64.c: Fix common/ includes.
8587         * arch/aarch64.c: Fix common/ includes.
8588         * arch/aarch64-insn.c: Fix common/ includes.
8589         * arch-utils.c: Fix common/ includes.
8590         * amd64-windows-tdep.c: Fix common/ includes.
8591         * amd64-tdep.c: Fix common/ includes.
8592         * amd64-sol2-tdep.c: Fix common/ includes.
8593         * amd64-obsd-tdep.c: Fix common/ includes.
8594         * amd64-nbsd-tdep.c: Fix common/ includes.
8595         * amd64-linux-tdep.c: Fix common/ includes.
8596         * amd64-linux-nat.c: Fix common/ includes.
8597         * amd64-fbsd-tdep.c: Fix common/ includes.
8598         * amd64-fbsd-nat.c: Fix common/ includes.
8599         * amd64-dicos-tdep.c: Fix common/ includes.
8600         * amd64-darwin-tdep.c: Fix common/ includes.
8601         * agent.c: Fix common/ includes.
8602         * ada-lang.h: Fix common/ includes.
8603         * ada-lang.c: Fix common/ includes.
8604         * aarch64-tdep.c: Fix common/ includes.
8605
8606 2019-01-25  Tom Tromey  <tom@tromey.com>
8607
8608         * common/create-version.sh: Use common/version.h.
8609
8610 2019-01-24  Pedro Alves  <palves@redhat.com>
8611
8612         * infrun.c (signal_stop, signal_print, signal_program)
8613         (signal_catch, signal_pass): Now arrays instead of pointers.
8614         (update_signals_program_target, do_target_resume)
8615         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8616         * linux-nat.c (linux_nat_target::pass_signals)
8617         (linux_nat_target::create_inferior, linux_nat_target::attach):
8618         Adjust.
8619         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8620         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8621         * procfs.c (procfs_target::pass_signals): Adjust.
8622         * record-full.c (record_full_target::resume): Adjust.
8623         * remote.c (remote_target::pass_signals)
8624         (remote_target::program_signals): Adjust.
8625         * target-debug.h (target_debug_print_signals): Now takes a
8626         gdb::array_view as parameter.  Adjust.
8627         * target.h (target_ops) <pass_signals, program_signals>: Replace
8628         pointer and length parameters with gdb::array_view.
8629         (target_pass_signals, target_program_signals): Likewise.
8630         * target-delegates.c: Regenerate.
8631
8632 2019-01-24  Pedro Alves  <palves@redhat.com>
8633
8634         * common/forward-scope-exit.h
8635         (forward_scope_exit::forward_scope_exit): Pass arguments to
8636         m_bind_function directly, instead of creating a std::bind and
8637         copying that.
8638
8639 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8640
8641         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8642         for static members.
8643         (pass_in_v_vfp_candidate): Likewise.
8644
8645 2019-01-23  Tom Tromey  <tom@tromey.com>
8646             Pedro Alves  <palves@redhat.com>
8647
8648         * regcache.c (class regcache_invalidator): Remove.
8649         (regcache::raw_write): Use make_scope_exit.
8650
8651 2019-01-23  Tom Tromey  <tom@tromey.com>
8652
8653         * ui-out.h (class ui_out_emit_type): Update comment.
8654
8655 2019-01-23  Tom Tromey  <tom@tromey.com>
8656
8657         * infrun.c (fetch_inferior_event): Update comment.
8658
8659 2019-01-23  Tom Tromey  <tom@tromey.com>
8660             Pedro Alves  <palves@redhat.com>
8661
8662         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8663         parameter.
8664         (fetch_inferior_event): Use SCOPE_EXIT.
8665
8666
8667 2019-01-23  Tom Tromey  <tom@tromey.com>
8668             Pedro Alves  <palves@redhat.com>
8669
8670         * infrun.c (disable_thread_events): Delete.
8671         (stop_all_threads): Use SCOPE_EXIT.
8672
8673 2019-01-23  Tom Tromey  <tom@tromey.com>
8674             Pedro Alves  <palves@redhat.com>
8675
8676         * symfile.c: Include forward-scope-exit.h.
8677         (clear_symtab_users_cleanup): Replace forward declaration with
8678         a FORWARD_SCOPE_EXIT.
8679         (syms_from_objfile_1): Use the forward_scope_exit and
8680         gdb::optional instead of cleanup_function.
8681         (reread_symbols): Use the forward_scope_exit instead of
8682         cleanup_function.
8683         (clear_symtab_users_cleanup): Remove function.
8684
8685 2019-01-23  Tom Tromey  <tom@tromey.com>
8686             Pedro Alves  <palves@redhat.com>
8687
8688         * linux-nat.c: Include scope-exit.h.
8689         (cleanup_target_stop): Remove.
8690         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8691         SCOPE_EXIT.
8692
8693 2019-01-23  Tom Tromey  <tom@tromey.com>
8694             Pedro Alves  <palves@redhat.com>
8695
8696         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8697         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8698
8699 2019-01-23  Tom Tromey  <tom@tromey.com>
8700             Andrew Burgess  <andrew.burgess@embecosm.com>
8701             Pedro Alves  <palves@redhat.com>
8702
8703         * infrun.c (fetch_inferior_event): Use scope_exit.
8704         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8705         * top.c (execute_command): Use scope_exit.
8706         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8707         * utils.c (do_bpstat_clear_actions_cleanup)
8708         (make_bpstat_clear_actions_cleanup): Remove.
8709
8710 2019-01-23  Tom Tromey  <tom@tromey.com>
8711             Pedro Alves  <palves@redhat.com>
8712
8713         * infrun.c: Include "common/scope-exit.h"
8714         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8715         (wait_for_inferior): Use SCOPE_EXIT.
8716         (fetch_inferior_event): Use scope_exit.
8717
8718 2019-01-23  Tom Tromey  <tom@tromey.com>
8719             Pedro Alves  <palves@redhat.com>
8720
8721         * breakpoint.c (create_breakpoint): Remove cleanup.
8722
8723 2019-01-23  Tom Tromey  <tom@tromey.com>
8724             Andrew Burgess  <andrew.burgess@embecosm.com>
8725             Pedro Alves  <palves@redhat.com>
8726
8727 2019-01-23  Pedro Alves  <palves@redhat.com>
8728
8729         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8730
8731 2019-01-23  Pedro Alves  <palves@redhat.com>
8732             Andrew Burgess  <andrew.burgess@embecosm.com>
8733
8734         * gdbthread.h: Include "common/forward-scope-exit.h".
8735         (scoped_finish_thread_state): Redefine custom class in terms of
8736         forward_scope_exit.
8737
8738 2019-01-23  Pedro Alves  <palves@redhat.com>
8739             Andrew Burgess  <andrew.burgess@embecosm.com>
8740
8741         * common/forward-scope-exit.h: New file.
8742
8743 2019-01-23  Pedro Alves  <palves@redhat.com>
8744             Andrew Burgess  <andrew.burgess@embecosm.com>
8745             Tom Tromey  <tom@tromey.com>
8746
8747         * common/scope-exit.h: New file.
8748
8749 2019-01-23  Pedro Alves  <palves@redhat.com>
8750
8751         * common/preprocessor.h (ESC): Rename to ...
8752         (ESC_PARENS): ... this.
8753         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8754         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8755
8756 2019-01-23  Tom Tromey  <tom@tromey.com>
8757
8758         * language.h (class scoped_switch_to_sym_language_if_auto):
8759         Initialize m_lang in both cases.
8760
8761 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8762
8763         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8764         with XCNEW.
8765
8766 2019-01-22  Tom Tromey  <tom@tromey.com>
8767
8768         * corelow.c: Do not include sys/file.h.
8769
8770 2019-01-22  Tom Tromey  <tom@tromey.com>
8771
8772         * tui/tui-wingeneral.h: Include gdb_curses.h.
8773
8774 2019-01-22  Tom Tromey  <tom@tromey.com>
8775
8776         * source-cache.h (class source_cache) <get_source_lines,
8777         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8778
8779 2019-01-22  Tom Tromey  <tom@tromey.com>
8780
8781         * remote-fileio.h (struct remote_target): Declare.
8782
8783 2019-01-22  Tom Tromey  <tom@tromey.com>
8784
8785         * python/py-arch.c: Do not include py-ref.h.
8786         * python/py-bpevent.c: Do not include py-ref.h.
8787         * python/py-cmd.c: Do not include py-ref.h.
8788         * python/py-continueevent.c: Do not include py-ref.h.
8789         * python/py-event.h: Do not include py-ref.h.
8790         * python/py-evtregistry.c: Do not include py-ref.h.
8791         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8792         * python/py-frame.c: Do not include py-ref.h.
8793         * python/py-framefilter.c: Do not include py-ref.h.
8794         * python/py-function.c: Do not include py-ref.h.
8795         * python/py-infevents.c: Do not include py-ref.h.
8796         * python/py-linetable.c: Do not include py-ref.h.
8797         * python/py-objfile.c: Do not include py-ref.h.
8798         * python/py-param.c: Do not include py-ref.h.
8799         * python/py-prettyprint.c: Do not include py-ref.h.
8800         * python/py-progspace.c: Do not include py-ref.h.
8801         * python/py-symbol.c: Do not include py-ref.h.
8802         * python/py-symtab.c: Do not include py-ref.h.
8803         * python/py-type.c: Do not include py-ref.h.
8804         * python/py-unwind.c: Do not include py-ref.h.
8805         * python/py-utils.c: Do not include py-ref.h.
8806         * python/py-value.c: Do not include py-ref.h.
8807         * python/py-varobj.c: Do not include py-ref.h.
8808         * python/py-xmethods.c: Do not include py-ref.h.
8809         * python/python.c: Do not include py-ref.h.
8810         * varobj.c: Do not include py-ref.h.
8811
8812 2019-01-22  Tom Tromey  <tom@tromey.com>
8813
8814         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8815         keyword for bcache.
8816
8817 2019-01-22  Tom Tromey  <tom@tromey.com>
8818
8819         * compile/compile-cplus-types.c: Remove a comment by #include.
8820
8821 2019-01-22  Tom Tromey  <tom@tromey.com>
8822
8823         * compile/gcc-c-plugin.h: Include compile-internal.h.
8824
8825 2019-01-22  Tom Tromey  <tom@tromey.com>
8826
8827         * stabsread.c (EXTERN): Do not define.
8828         (symnum, next_symbol_text_func, processing_gcc_compilation)
8829         (within_function, global_sym_chain, global_stabs)
8830         (previous_stab_code, this_object_header_files)
8831         (n_this_object_header_files)
8832         (n_allocated_this_object_header_files): Define.
8833         * stabsread.h (EXTERN): Never define.  Use "extern".
8834
8835 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8836
8837         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8838         history_value.
8839
8840 2019-01-21  Tom Tromey  <tom@tromey.com>
8841
8842         * ui-out.c: Fix includes.
8843         * tui/tui-source.c: Fix includes.
8844         * target.c: Fix includes.
8845         * remote.c: Fix includes.
8846         * regcache.c: Fix includes.
8847         * python/py-block.c: Fix includes.
8848         * printcmd.c: Fix includes.
8849         * or1k-tdep.c: Fix includes.
8850         * mi/mi-main.c: Fix includes.
8851         * m32r-tdep.c: Fix includes.
8852         * csky-tdep.c: Fix includes.
8853         * compile/compile-cplus-types.c: Fix includes.
8854         * cli/cli-interp.c: Fix includes.
8855
8856 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8857
8858         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8859         for padding.
8860
8861 2019-01-16  Tom Tromey  <tom@tromey.com>
8862
8863         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8864         earlier.
8865         (struct objfile) <msymbols_range>: Move from top level.
8866         <msymbols>: New method.
8867         (class objfile_msymbols): Remove.
8868         * symtab.c (default_collect_symbol_completion_matches_break_on):
8869         Update.
8870         * symmisc.c (dump_msymbols): Update.
8871         * stabsread.c (scan_file_globals): Update.
8872         * objc-lang.c (info_selectors_command, info_classes_command)
8873         (find_methods): Update.
8874         * minsyms.c (find_solib_trampoline_target): Update.
8875         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8876         * coffread.c (coff_symfile_read): Update.
8877         * ada-lang.c (ada_lookup_simple_minsym)
8878         (ada_collect_symbol_completion_matches): Update.
8879
8880 2019-01-16  Tom Tromey  <tom@tromey.com>
8881
8882         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8883         type.  Remove no-argument constructor.
8884         <iterator::operator++>: Simplify.
8885         <begin>: Update.
8886         <end>: Use minimal_symbol_count.
8887
8888 2019-01-16  Tom Tromey  <tom@tromey.com>
8889
8890         * objfiles.h (struct objfile) <psymtabs>: New method.
8891         (class objfile_psymtabs): Remove.
8892         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8893         typedef.
8894         <range>: New method.
8895         (require_partial_symbols): Change return type.
8896         * psymtab.c (require_partial_symbols)
8897         (psym_expand_symtabs_matching): Update.
8898         * mdebugread.c (parse_partial_symbols): Update.
8899         * dbxread.c (dbx_end_psymtab): Update.
8900
8901 2019-01-15  Tom Tromey  <tom@tromey.com>
8902
8903         * symtab.c (lookup_objfile_from_block)
8904         (lookup_symbol_in_objfile_symtabs)
8905         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8906         (find_line_symtab, info_sources_command)
8907         (default_collect_symbol_completion_matches_break_on)
8908         (make_source_files_completion_list): Update.
8909         * symmisc.c (print_objfile_statistics, dump_objfile)
8910         (maintenance_print_symbols, maintenance_info_symtabs)
8911         (maintenance_check_symtabs, maintenance_info_line_tables):
8912         Update.
8913         * source.c (select_source_symtab)
8914         (forget_cached_source_info_for_objfile): Update.
8915         * objfiles.h (class objfile_compunits): Remove.
8916         (struct objfile) <compunits_range>: New typedef.
8917         (compunits): New method.
8918         * objfiles.c (objfile_relocate1): Update.
8919         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8920         * maint.c (count_symtabs_and_blocks): Update.
8921         * linespec.c (iterate_over_all_matching_symtabs): Update.
8922         * cp-support.c (add_symbol_overload_list_qualified): Update.
8923         * coffread.c (coff_symtab_read): Update.
8924         * ada-lang.c (add_nonlocal_symbols)
8925         (ada_collect_symbol_completion_matches)
8926         (ada_add_global_exceptions): Update.
8927
8928 2019-01-15  Tom Tromey  <tom@tromey.com>
8929
8930         * progspace.h (program_space) <objfiles_safe_range>: New
8931         typedef.
8932         <objfiles_safe>: New method.
8933         * objfiles.h (class all_objfiles_safe): Remove.
8934         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8935         * jit.c (jit_inferior_exit_hook): Update.
8936
8937 2019-01-17  Tom Tromey  <tom@tromey.com>
8938
8939         * progspace.h (program_space) <objfiles_range>: New typedef.
8940         <objfiles>: New method.
8941         <objfiles_head>: Rename from objfiles.
8942         (object_files): Update.
8943         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8944         * guile/scm-pretty-print.c
8945         (ppscm_find_pretty_printer_from_objfiles): Update.
8946         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8947         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8948         Update.
8949         * python/py-progspace.c (pspy_get_objfiles): Update.
8950         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8951         Update.
8952         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8953         (objfpy_lookup_objfile_by_build_id): Update.
8954         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8955         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8956         Update.
8957         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8958         (expand_symtab_containing_pc, lookup_objfile_from_block)
8959         (lookup_static_symbol, basic_lookup_transparent_type)
8960         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8961         (find_line_symtab, info_sources_command)
8962         (default_collect_symbol_completion_matches_break_on)
8963         (make_source_files_completion_list, find_main_name): Update.
8964         * symmisc.c (print_symbol_bcache_statistics)
8965         (print_objfile_statistics, maintenance_print_symbols)
8966         (maintenance_print_msymbols, maintenance_print_objfiles)
8967         (maintenance_info_symtabs, maintenance_check_symtabs)
8968         (maintenance_expand_symtabs, maintenance_info_line_tables):
8969         Update.
8970         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8971         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8972         (map_overlay_command, unmap_overlay_command)
8973         (simple_overlay_update, expand_symtabs_matching)
8974         (map_symbol_filenames): Update.
8975         * symfile-debug.c (set_debug_symfile): Update.
8976         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8977         Update.
8978         * source.c (select_source_symtab, forget_cached_source_info):
8979         Update.
8980         * solib.c (solib_read_symbols): Update.
8981         * solib-spu.c (append_ocl_sos): Update.
8982         * psymtab.c (maintenance_print_psymbols)
8983         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8984         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8985         * printcmd.c (info_symbol_command): Update.
8986         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8987         Update.
8988         * objfiles.h (class all_objfiles): Remove.
8989         * objfiles.c (have_partial_symbols, have_full_symbols)
8990         (have_minimal_symbols, qsort_cmp, update_section_map)
8991         (shared_objfile_contains_address_p)
8992         (default_iterate_over_objfiles_in_search_order): Update.
8993         * objc-lang.c (info_selectors_command, info_classes_command)
8994         (find_methods): Update.
8995         * minsyms.c (find_solib_trampoline_target): Update.
8996         * maint.c (maintenance_info_sections)
8997         (maintenance_translate_address, count_symtabs_and_blocks):
8998         Update.
8999         * main.c (captured_main_1): Update.
9000         * linux-thread-db.c (try_thread_db_load_from_pdir)
9001         (has_libpthread): Update.
9002         * linespec.c (iterate_over_all_matching_symtabs)
9003         (search_minsyms_for_name): Update.
9004         * jit.c (jit_find_objf_with_entry_addr): Update.
9005         * hppa-tdep.c (find_unwind_entry)
9006         (hppa_lookup_stub_minimal_symbol): Update.
9007         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9008         Update.
9009         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9010         (elf_gnu_ifunc_resolve_by_got): Update.
9011         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9012         * dwarf-index-write.c (save_gdb_index_command): Update.
9013         * cp-support.c (add_symbol_overload_list_qualified): Update.
9014         * breakpoint.c (create_overlay_event_breakpoint)
9015         (create_longjmp_master_breakpoint)
9016         (create_std_terminate_master_breakpoint)
9017         (create_exception_master_breakpoint): Update.
9018         * blockframe.c (find_pc_partial_function): Update.
9019         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9020         (ada_collect_symbol_completion_matches)
9021         (ada_add_global_exceptions): Update.
9022
9023 2019-01-17  Tom Tromey  <tom@tromey.com>
9024
9025         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9026         declare VEC.
9027         (solib_target_parse_libraries): Change return type.
9028         (library_list_start_segment, library_list_start_section)
9029         (library_list_end_library, library_list_start_library); Update.
9030         (solib_target_free_library_list): Remove.
9031         (solib_target_parse_libraries): Remove cleanup.  Change return
9032         type.
9033         (solib_target_current_sos): Update.
9034
9035 2019-01-17  Tom Tromey  <tromey@bapiya>
9036
9037         * valprint.c: Replace "the the" with "the".
9038         * symtab.c: Replace "the the" with "the".
9039         * solib.c: Replace "the the" with "the".
9040         * solib-dsbt.c: Replace "the the" with "the".
9041         * linespec.c: Replace "the the" with "the".
9042         * dwarf2loc.h: Replace "the the" with "the".
9043         * amd64-windows-tdep.c: Replace "the the" with "the".
9044         * aarch64-tdep.c: Replace "the the" with "the".
9045
9046 2019-01-16  Keith Seitz  <keiths@redhat.com>
9047
9048         PR gdb/23773
9049         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9050         <builder>: Rename to ..
9051         <m_builder>: ... this and make private.
9052         (dwarf2_cu::get_builder): New method.  Change all users of
9053         `builder' to use this method.
9054         (dwarf2_start_symtab): Move to ...
9055         (dwarf2_cu::start_symtab): ... here.  Update all callers
9056         (setup_type_unit_groups): Move to ...
9057         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9058         callers.
9059         (dwarf2_cu::reset_builder): New method.
9060         (process_full_compunit, process_full_type_unit): Use
9061         dwarf2_cu::reset_builder.
9062         (follow_die_offset): Record the ancestor CU if it is different
9063         from the followed DIE's CU.
9064         (follow_die_sig_1): Likewise.
9065
9066 2019-01-15  Tom Tromey  <tom@tromey.com>
9067
9068         * remote.c (class remote_state) <buf>: Now a char_vector.
9069         <buf_size>: Remove.
9070         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9071         parameter.
9072         (remote_target::getpkt_or_notif_sane_1)
9073         (remote_target::getpkt_sane)
9074         (remote_target::getpkt_or_notif_sane): Likewise.
9075         (class remote_target) <putpkt>: New overload.
9076         (remote_target::read_frame): Change type of "buf_p".  Remove
9077         sizeof_p parameter.
9078         (packet_ok): New overload.
9079         (packet_check_result): New overload.
9080         Update all uses.
9081
9082 2019-01-14  Tom Tromey  <tom@tromey.com>
9083
9084         * remote-notif.c (handle_notification, remote_notif_ack)
9085         (remote_notif_parse): Make "buf" const.
9086         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9087         const.
9088         (remote_notif_parse, remote_notif_ack, handle_notification):
9089         Likewise.
9090         * remote.c (remote_notif_stop_parse): Make "buf" const.
9091         (remote_target::remote_parse_stop_reply): Make "buf" const.
9092         (remote_notif_stop_ack): Make "buf" const.
9093
9094 2019-01-14  Tom Tromey  <tom@tromey.com>
9095
9096         * remote.c (remote_console_output): Make parameter const.
9097
9098 2019-01-14  Tom Tromey  <tom@tromey.com>
9099
9100         * target-debug.h (target_debug_print_signals): Constify.
9101         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9102         * procfs.c (procfs_target::pass_signals): Update.
9103         * linux-nat.c (linux_nat_target::pass_signals): Update.
9104         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9105         * target-delegates.c: Rebuild.
9106         * remote.c (remote_target::program_signals): Update.
9107         (remote_target::pass_signals): Update.
9108         * target.c (target_pass_signals): Constify argument.
9109         (target_program_signals): Likewise.
9110         * target.h (struct target_ops) <pass_signals, program_signals>:
9111         Constify argument.
9112         (target_pass_signals, target_program_signals): Constify argument.
9113
9114 2019-01-14  Tom Tromey  <tom@tromey.com>
9115
9116         PR tui/28819:
9117         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9118
9119 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9120
9121         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9122         field.
9123         * rs6000-tdep.c: Include reggroups.h.
9124         (IS_V_ALIAS_PSEUDOREG): Define.
9125         (rs6000_register_name): Return names for the "vX" aliases.
9126         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9127         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9128         aliases.  Call default_register_reggroup_p for all other
9129         pseudo-registers.
9130         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9131         New functions.
9132         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9133         Handle "vX" aliases.
9134         (v_alias_pseudo_register_collect): New function.
9135         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9136         (rs6000_gdbarch_init): Initialize "vX" aliases as
9137         pseudo-registers.  Restore registration of
9138         rs6000_pseudo_register_reggroup_p with
9139         set_tdesc_pseudo_register_reggroup_p.
9140
9141 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9142
9143         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9144         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9145         set_gdbarch_num_pseudo_regs.
9146
9147 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9148
9149         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9150         Remove arg prefixname, add do_set and do_show.
9151         Add member functions set_list and show_list.
9152         * cli/cli-style.c (class cli_style_option): Update accordingly.
9153         (style_set_list): Move to file scope.
9154         (style_show_list): Likewise.
9155         (set_style): Call help_list.
9156         (show_style): Call cmd_show_list.
9157         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9158         Update to use the new macro.
9159
9160 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9161
9162         * ada-lang.c (_initialize_ada_language): Expand the help text
9163         for the "catch exception" command.
9164
9165 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9166
9167         * symtab.c (matching_obj_sections): Initialize obj,
9168         declare it closer to its usage.
9169
9170 2019-01-10  Tom Tromey  <tom@tromey.com>
9171
9172         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9173         (basic_inf_threads_range): Remove.
9174         (inf_threads_range, inf_non_exited_threads_range)
9175         (safe_inf_threads_range): Use next_adapter.
9176
9177 2019-01-10  Keith Seitz  <keiths@redhat.com>
9178
9179         PR gdb/23712
9180         PR symtab/23010
9181         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9182         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9183
9184 2019-01-10  Keith Seitz  <keiths@redhat.com>
9185
9186         PR gdb/23712
9187         PR symtab/23010
9188         * dictionary.c (pending_to_vector): Remove.
9189         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9190         Remove _1 suffix, replacing functions of the same name.  Update
9191         all callers.
9192         (dict_create_hashed, dict_create_hashed_expandable)
9193         (dict_create_linear, dict_create_linear_expandable, dict_free)
9194         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9195         Make functions static.
9196
9197 2019-01-10  Keith Seitz  <keiths@redhat.com>
9198
9199         PR gdb/23712
9200         PR symtab/23010
9201         * dictionary.h (struct dictionary): Replace declaration with
9202         multidictionary.
9203         (dict_create_hashed, dict_create_hashed_expandable)
9204         (dict_create_linear, dict_create_linear_expandable)
9205         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9206         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9207         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9208         taking multidictionary argument.
9209         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9210         * block.h (struct block) <dict>: Change to multidictionary
9211         and rename `multidict'.
9212         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9213         symmisc.c: Update all dictionary references to multidictionary.
9214
9215 2019-01-10  Keith Seitz  <keiths@redhat.com>
9216
9217         PR gdb/23712
9218         PR symtab/23010
9219         * dictionary.c: Include unordered_map.
9220         (pending_to_vector): New function.
9221         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9222         Rewrite the non-"_1" functions to take vector instead
9223         of linked list.
9224         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9225         "new" _1 versions of the same name.
9226         (multidictionary): Define.
9227         (std::hash<enum language): New definition.
9228         (collate_pending_symbols_by_language, mdict_create_hashed)
9229         (mdict_create_hashed_expandable, mdict_create_linear)
9230         (mdict_create_linear_expandable, mdict_free)
9231         (find_language_dictionary, create_new_language_dictionary)
9232         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9233         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9234         (mdict_size, mdict_empty): New functions.
9235         * dictionary.h (mdict_iterator): Define.
9236
9237 2019-01-10  Pedro Alves  <palves@redhat.com>
9238
9239         * breakpoint.c (read_uploaded_action)
9240         (create_tracepoint_from_upload): Adjust to use
9241         gdb::unique_xmalloc_ptr.
9242         * ctf.c (ctf_write_uploaded_tp):
9243         (SET_ARRAY_FIELD): Use emplace_back.
9244         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9245         * tracefile-tfile.c (tfile_write_uploaded_tp):
9246         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9247         gdb::unique_xmalloc_ptr.
9248         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9249         at_string, cond_string, cmd_strings>: Replace char pointers
9250         with gdb::unique_xmalloc_ptr.
9251
9252 2019-01-10  Pedro Alves  <palves@redhat.com>
9253
9254         * solib-target.c (library_list_start_library): Don't xstrdup name.
9255
9256 2019-01-10  Pedro Alves  <palves@redhat.com>
9257
9258         * mdebugread.c (parse_partial_symbols): Use
9259         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9260
9261 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9262
9263         * linux-fork.c (scoped_switch_fork_info)
9264         <~scoped_switch_fork_info>: Fix incorrect variable name.
9265
9266 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9267
9268         * linux-fork.c (scoped_switch_fork_info)
9269         <scoped_switch_fork_info>: Make explicit.
9270         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9271
9272 2019-01-10  Tom Tromey  <tom@tromey.com>
9273
9274         * objfiles.h (objfile::reset_psymtabs): Update.
9275         * objfiles.c (objfile::objfile): Update.
9276         * psymtab.h (psymtab_storage::obstack): Update.
9277         (psymtab_storage::m_obstack): Use gdb::optional.
9278         (class psymtab_storage): Update comment.  Remove objfile
9279         parameter.
9280         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9281
9282 2019-01-10  Tom Tromey  <tom@tromey.com>
9283
9284         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9285         <free_psymtabs>: Now private.
9286         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9287         (allocate_psymtab): Use new method.
9288
9289 2019-01-10  Tom Tromey  <tom@tromey.com>
9290
9291         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9292         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9293         * mdebugread.c (parse_partial_symbols): Use
9294         allocate_dependencies.
9295         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9296         allocate_dependencies.
9297         (process_psymtab_comp_unit_reader)
9298         (build_type_psymtab_dependencies): Likewise.
9299         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9300
9301 2019-01-10  Tom Tromey  <tom@tromey.com>
9302
9303         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9304         PSYMBOL_SET_LANGUAGE.
9305         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9306
9307 2019-01-10  Tom Tromey  <tom@tromey.com>
9308
9309         * psymtab.h (psymtab_storage::obstack): New method.
9310         <m_obstack>: Rename from obstack; now private.
9311         * psymtab.c (psymtab_storage): Update.
9312         * dwarf2read.c (create_addrmap_from_index)
9313         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9314         Update.
9315
9316 2019-01-10  Tom Tromey  <tom@tromey.com>
9317
9318         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9319         * objfiles.h (objfile::reset_psymtabs): New method.
9320
9321 2019-01-10  Tom Tromey  <tom@tromey.com>
9322
9323         * symmisc.c (print_symbol_bcache_statistics): Update.
9324         (print_objfile_statistics): Update.
9325         * symfile.c (reread_symbols): Update.
9326         * psymtab.h (class psymtab_storage): New.
9327         * psymtab.c (psymtab_storage): New constructor.
9328         (~psymtab_storage): New destructor.
9329         (require_partial_symbols): Update.
9330         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9331         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9332         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9333         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9334         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9335         (start_psymtab_common, end_psymtab_common)
9336         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9337         (allocate_psymtab): Update.
9338         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9339         Update.
9340         (dump_psymtab_addrmap, maintenance_print_psymbols)
9341         (maintenance_check_psymtabs): Update.
9342         (class objfile_psymtabs): Move to objfiles.h.
9343         * psympriv.h (discard_psymtab): Now inline.
9344         (psymtab_discarder::psymtab_discarder): Update.
9345         (psymtab_discarder::~psymtab_discarder): Update.
9346         (ALL_OBJFILE_PSYMTABS): Rewrite.
9347         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9348         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9349         Remove fields.
9350         <partial_symtabs>: New field.
9351         (class objfile_psymtabs): Move from psymtab.h.  Update.
9352         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9353         psymbol_cache.
9354         (objfile::~objfile): Don't destroy psymbol_cache.
9355         * mdebugread.c (parse_partial_symbols): Update.
9356         * dwarf2read.c (create_addrmap_from_index)
9357         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9358         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9359         (add_partial_subprogram, dwarf2_ranges_read): Update.
9360         * dwarf-index-write.c (write_address_map)
9361         (write_one_signatured_type, recursively_write_psymbols)
9362         (class debug_names, class debug_names, write_psymtabs_to_index):
9363         Update.
9364
9365 2019-01-10  Tom Tromey  <tom@tromey.com>
9366
9367         * symtab.h (SYMBOL_SET_NAMES): Update.
9368         (symbol_set_names): Update.
9369         (MSYMBOL_SET_NAMES): Update.
9370         * symtab.c (symbol_set_names): Change argument to be an
9371         objfile_per_bfd_storage.
9372         * psymtab.c (add_psymbol_to_bcache): Update.
9373         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9374
9375 2019-01-10  Tom Tromey  <tom@tromey.com>
9376
9377         * symtab.c (create_demangled_names_hash): Change argument to be an
9378         objfile_per_bfd_storage.
9379         (symbol_set_names): Update.
9380
9381 2019-01-10  Tom Tromey  <tom@tromey.com>
9382
9383         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9384         init_psymbol_list.
9385         * psymtab.c (init_psymbol_list): Do nothing if already called.
9386         * psympriv.h (init_psymbol_list): Add comment.
9387         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9388         init_psymbol_list.
9389         * dbxread.c (dbx_symfile_read): Unconditionally call
9390         init_psymbol_list.
9391
9392 2019-01-10  Tom Tromey  <tom@tromey.com>
9393
9394         * xcoffread.c (scan_xcoff_symtab): Update.
9395         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9396         "where".
9397         * mdebugread.c (parse_partial_symbols)
9398         (handle_psymbol_enumerators): Update.
9399         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9400         * dbxread.c (read_dbx_symtab): Update.
9401         * psympriv.h (psymbol_placement): New enum.
9402         (add_psymbol_to_list): Update.
9403
9404 2019-01-10  Tom Tromey  <tom@tromey.com>
9405
9406         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9407         static_psymbols parameters.
9408         (scan_xcoff_symtab): Update.
9409         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9410         static_psymbols parameters.
9411         * psympriv.h (start_psymtab_common): Update.
9412         * mdebugread.c (parse_partial_symbols): Update.
9413         * dwarf2read.c (create_partial_symtab): Update.
9414         * dbxread.c (read_dbx_symtab): Update.
9415         (start_psymtab): Remove global_psymbols and static_psymbols
9416         parameters.
9417
9418 2019-01-10  Tom Tromey  <tom@tromey.com>
9419
9420         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9421         * psymtab.c (allocate_psymtab): Add comment.
9422         * psympriv.h (allocate_psymtab): Add comment.
9423         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9424         initializations.
9425         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9426
9427 2019-01-10  Tom Tromey  <tom@tromey.com>
9428
9429         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9430         Don't declare.
9431         * mipsread.c: Include mdebugread.h.
9432         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9433         Declare.
9434         * elfread.c: Include mdebugread.h.
9435
9436 2019-01-09  Tom Tromey  <tom@tromey.com>
9437
9438         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9439         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9440         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9441         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9442         (psym_lookup_symbol, psym_find_last_source_symtab)
9443         (psym_forget_cached_source_info, psym_print_stats)
9444         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9445         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9446         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9447         (psym_find_compunit_symtab_by_address)
9448         (maintenance_print_psymbols, maintenance_info_psymtabs)
9449         (maintenance_check_psymtabs): Use ranged for.
9450         * psymtab.h (class objfile_psymtabs): New.
9451         (require_partial_symbols): Return objfile_psymtabs.
9452         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9453
9454 2019-01-09  Tom Tromey  <tom@tromey.com>
9455
9456         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9457         (find_pc_mapped_section, list_overlays_command)
9458         (map_overlay_command, unmap_overlay_command)
9459         (simple_overlay_update): Use all_objfiles.
9460         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9461         * printcmd.c (info_symbol_command): Use all_objfiles.
9462         * objfiles.h (ALL_OBJSECTIONS): Remove.
9463         * maint.c (maintenance_translate_address): Use all_objfiles.
9464         * gcore.c (gcore_create_callback): Use all_objfiles.
9465         (objfile_find_memory_regions): Likewise.
9466
9467 2019-01-09  Tom Tromey  <tom@tromey.com>
9468
9469         * symtab.c (find_line_symtab, info_sources_command)
9470         (make_source_files_completion_list): Use objfile_compunits.
9471         * source.c (select_source_symtab): Use objfile_compunits.
9472         * objfiles.h (struct objfile): Update comment.
9473         (ALL_OBJFILES): Remove.
9474         (ALL_FILETABS): Remove.
9475         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9476         objfile_compunits.
9477
9478 2019-01-09  Tom Tromey  <tom@tromey.com>
9479
9480         * symmisc.c (print_objfile_statistics, dump_objfile)
9481         (maintenance_print_symbols): Use compunit_filetabs.
9482         * source.c (forget_cached_source_info_for_objfile): Use
9483         compunit_filetabs.
9484         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9485         (ALL_FILETABS): Use compunit_filetabs.
9486         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9487         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9488
9489 2019-01-09  Tom Tromey  <tom@tromey.com>
9490
9491         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9492         (compunit_filetabs): New.
9493         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9494         compunit_filetabs.
9495         (info_sources_command, make_source_files_completion_list): Remove
9496         declaration.
9497         * symmisc.c (print_objfile_statistics, dump_objfile)
9498         (maintenance_print_symbols): Remove declaration.
9499         (maintenance_info_symtabs): Use compunit_filetabs.
9500         (maintenance_info_line_tables): Likewise.
9501         * source.c (select_source_symtab): Change local variable name.
9502         (forget_cached_source_info_for_objfile): Remove declaration.
9503         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9504         * objfiles.c (objfile_relocate1): Remove declaration.
9505         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9506         declaration.
9507         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9508         * coffread.c (coff_symtab_read): Remove declaration.
9509         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9510         compunit_filetabs.
9511
9512 2019-01-09  Tom Tromey  <tom@tromey.com>
9513
9514         * symtab.c (lookup_objfile_from_block)
9515         (find_pc_sect_compunit_symtab, search_symbols)
9516         (default_collect_symbol_completion_matches_break_on): Use
9517         objfile_compunits.
9518         * objfiles.h (ALL_COMPUNITS): Remove.
9519         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9520         * cp-support.c (add_symbol_overload_list_qualified): Use
9521         objfile_compunits.
9522         * ada-lang.c (ada_collect_symbol_completion_matches)
9523         (ada_add_global_exceptions): Use objfile_compunits.
9524
9525 2019-01-09  Tom Tromey  <tom@tromey.com>
9526
9527         * source.c (select_source_symtab)
9528         (forget_cached_source_info_for_objfile): Remove declaration.
9529         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9530         declaration.
9531         * maint.c (count_symtabs_and_blocks): Remove declaration.
9532         * cp-support.c (add_symbol_overload_list_qualified): Remove
9533         declaration.
9534         * coffread.c (coff_symtab_read): Remove declaration.
9535         * symtab.c (lookup_symbol_in_objfile_symtabs)
9536         (basic_lookup_transparent_type_1): Use objfile_compunits.
9537         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9538         (info_sources_command, search_symbols)
9539         (default_collect_symbol_completion_matches_break_on)
9540         (make_source_files_completion_list): Remove declaration.
9541         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9542         (ada_collect_symbol_completion_matches)
9543         (ada_add_global_exceptions): Remove declaration.
9544         * linespec.c (iterate_over_all_matching_symtabs): Use
9545         objfile_compunits.
9546         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9547         (class objfile_compunits): New.
9548         (ALL_COMPUNITS): Use objfile_compunits.
9549         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9550         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9551         objfile_compunits.
9552         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9553
9554 2019-01-09  Tom Tromey  <tom@tromey.com>
9555
9556         * symtab.c (search_symbols)
9557         (default_collect_symbol_completion_matches_break_on): Use
9558         objfile_msymbols.
9559         * ada-lang.c (ada_lookup_simple_minsym)
9560         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9561         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9562         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9563         objfile_msymbols.
9564         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9565         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9566         * objc-lang.c (find_methods): Use objfile_msymbols.
9567         (info_selectors_command, info_classes_command): Likewise.
9568         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9569         * objfiles.h (class objfile_msymbols): New.
9570         (ALL_OBJFILE_MSYMBOLS): Remove.
9571         (ALL_MSYMBOLS): Remove.
9572
9573 2019-01-09  Tom Tromey  <tom@tromey.com>
9574
9575         * common/next-iterator.h (next_adapter): Add Iterator template
9576         parameter.
9577         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9578         (class all_objfiles_safe): New.
9579         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9580         * objfiles.c (put_objfile_before): Update comment.
9581         (add_separate_debug_objfile): Likewise.
9582         (free_all_objfiles): Use all_objfiles_safe.
9583         (objfile_purge_solibs): Likewise.
9584
9585 2019-01-09  Tom Tromey  <tom@tromey.com>
9586
9587         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9588         (expand_symtab_containing_pc, lookup_static_symbol)
9589         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9590         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9591         all_objfiles.
9592         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9593         * breakpoint.c (create_overlay_event_breakpoint)
9594         (create_longjmp_master_breakpoint)
9595         (create_std_terminate_master_breakpoint)
9596         (create_exception_master_breakpoint): Use all_objfiles.
9597         * linux-thread-db.c (try_thread_db_load_from_pdir)
9598         (has_libpthread): Use all_objfiles.
9599         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9600         * linespec.c (iterate_over_all_matching_symtabs)
9601         (search_minsyms_for_name): Use all_objfiles.
9602         * maint.c (maintenance_info_sections): Use all_objfiles.
9603         * main.c (captured_main_1): Use all_objfiles.
9604         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9605         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9606         * guile/scm-pretty-print.c
9607         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9608         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9609         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9610         (maintenance_print_msymbols): Use all_objfiles.
9611         * source.c (select_source_symtab): Use all_objfiles.
9612         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9613         * symfile.c (remove_symbol_file_command)
9614         (expand_symtabs_matching, map_symbol_filenames): Use
9615         all_objfiles.
9616         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9617         all_objfiles.
9618         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9619         * objc-lang.c (find_methods): Use all_objfiles.
9620         * objfiles.c (have_partial_symbols, have_full_symbols)
9621         (have_minimal_symbols, qsort_cmp)
9622         (default_iterate_over_objfiles_in_search_order): Use
9623         all_objfiles.
9624         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9625         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9626         (maintenance_check_psymtabs): Use all_objfiles.
9627         (ALL_PSYMTABS): Remove.
9628         * compile/compile-object-run.c (do_module_cleanup): Use
9629         all_objfiles.
9630         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9631         * cp-support.c (add_symbol_overload_list_qualified): Use
9632         all_objfiles.
9633         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9634         Use all_objfiles.
9635         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9636         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9637         all_objfiles.
9638         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9639         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9640         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9641         Uses all_objfiles.
9642         * solib.c (solib_read_symbols): Use all_objfiles
9643
9644 2019-01-09  Tom Tromey  <tom@tromey.com>
9645
9646         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9647         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9648         all_objfiles.
9649         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9650         * symmisc.c (print_symbol_bcache_statistics)
9651         (print_objfile_statistics, maintenance_print_objfiles)
9652         (maintenance_info_symtabs, maintenance_check_symtabs)
9653         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9654         all_objfiles.
9655         * source.c (forget_cached_source_info): Use all_objfiles.
9656         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9657         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9658         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9659         * objfiles.c (update_section_map): Use all_objfiles.
9660         (shared_objfile_contains_address_p): Likewise.
9661         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9662         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9663
9664 2019-01-09  Tom Tromey  <tom@tromey.com>
9665
9666         * common/next-iterator.h: New file.
9667         * objfiles.h (class all_objfiles): New.
9668         (struct objfile_iterator): New.
9669
9670 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9671
9672         * NEWS: Move the description of the changed "frame", "select-frame",
9673          and "info frame" commands to the Changed commands section.
9674
9675 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9676
9677         * gdbtypes.c (check_stub_method_group): Remove handling of old
9678         mangling schemes.
9679         * linespec.c (find_methods): Likewise.
9680         * stabsread.c (read_member_functions): Likewise.
9681         * valops.c (search_struct_method): Likewise.
9682         (value_struct_elt_for_reference): Likewise.
9683         * NEWS: Mention this change.
9684
9685 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9686
9687         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9688         print_source_lines.
9689         * source.c (print_source_lines_base): Update line number check.
9690         (print_source_lines): New function.
9691         (source_lines_range::source_lines_range): New function.
9692         * source.h (class source_lines_range): New class.
9693         (print_source_lines): New declaration.
9694
9695 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9696
9697         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9698
9699 2019-01-08  Tom Tromey  <tom@tromey.com>
9700             Simon Marchi  <simon.marchi@ericsson.com>
9701
9702         PR gdb/24060
9703         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9704         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9705         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9706         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9707         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9708         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9709
9710 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9711
9712         * source.c (select_source_symtab): Move header comment to
9713         declaration in source.h.
9714         (forget_cached_source_info_for_objfile): Likewise.
9715         (forget_cached_source_info): Likewise.
9716         (identify_source_line): Likewise.
9717         * source.h (identify_source_line): Move declaration from symtab.h
9718         and add comment from source.c
9719         (print_source_lines): Likewise.
9720         (forget_cached_source_info_for_objfile): Likewise.
9721         (forget_cached_source_info): Likewise.
9722         (select_source_symtab): Likewise.
9723         (enum print_source_lines_flag): Move definition from symtab.h.
9724         * symtab.h (identify_source_line): Move declaration to source.h.
9725         (print_source_lines): Likewise.
9726         (forget_cached_source_info_for_objfile): Likewise.
9727         (forget_cached_source_info): Likewise.
9728         (select_source_symtab): Likewise.
9729         (enum print_source_lines_flag): Move definition to source.h.
9730         * tui/tui-hooks.c: Add 'source.h' include.
9731
9732 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9733
9734         * source.c (print_source_lines_base): Handle requests to print
9735         reverse line number sequences, and guard against empty lines
9736         string.
9737
9738 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9739
9740         * source.c (print_source_lines_base): Fix skip of '\r' if next
9741         character is '\n'.
9742
9743 2019-01-06  Tom Tromey  <tom@tromey.com>
9744
9745         * c-exp.y (struct c_parse_state) <macro_original_text,
9746         expansion_obstack>: New member.
9747         (macro_original_text, expansion_obstack): Remove globals.
9748         (scan_macro_expansion, scanning_macro_expansion)
9749         (finished_macro_expansion): Update.
9750         (scan_macro_cleanup): Remove.
9751         (yylex, c_parse): Update.
9752
9753 2019-01-06  Tom Tromey  <tom@tromey.com>
9754
9755         * c-exp.y (struct c_parse_state) <strings>: New member.
9756         (operator_stoken): Update.
9757
9758 2019-01-06  Tom Tromey  <tom@tromey.com>
9759
9760         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9761         (union type_stack_elt) <typelist_val>: Now a pointer to
9762         std::vector.
9763         (type_stack_cleanup): Don't declare.
9764         (push_typelist): Update.
9765         * parse.c (pop_typelist): Return a std::vector.
9766         (push_typelist): Take a std::vector.
9767         (follow_types): Update.  Do not free args.
9768         (type_stack_cleanup): Remove.
9769         * c-exp.y (struct c_parse_state): New.
9770         (cpstate): New global.
9771         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9772         (nonempty_typelist): Update.
9773         (func_mod): Create a new vector.
9774         (c_parse): Create a c_parse_state.
9775         (check_parameter_typelist): Do not delete params.
9776         (function_method): Update.  Do not delete type_list.
9777
9778 2019-01-06  Tom Tromey  <tom@tromey.com>
9779
9780         PR gdb/28155:
9781         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9782         check_typedef.
9783         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9784         (print_return_value): Likewise.
9785
9786 2019-01-05  Tom Tromey  <tom@tromey.com>
9787
9788         * contrib/cleanup_check.py: Remove.
9789         * contrib/gcc-with-excheck: Remove.
9790         * contrib/exsummary.py: Remove.
9791         * contrib/excheck.py: Remove.
9792
9793 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9794
9795         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9796         NULL. Initialize tpprev to NULL instead of assigning it
9797         to NULL on the next statement.
9798         * windows-nat.c (windows_delete_thread): Remove check for
9799         main_thread_id before printing thread exit notifications.
9800         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9801         Remove thread ID check against main_thread_id.
9802         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9803         windows_delete_thread.
9804         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9805
9806 2019-01-04  Tom Tromey  <tom@tromey.com>
9807
9808         * compile/compile.c (_initialize_compile): Use upper case for
9809         metasyntactic variables.
9810         * symmisc.c (_initialize_symmisc): Use upper case for
9811         metasyntactic variables.
9812         * psymtab.c (_initialize_psymtab): Use upper case for
9813         metasyntactic variables.
9814         * demangle.c (demangle_command): Use upper case for metasyntactic
9815         variables.
9816         (_initialize_demangler): Likewise.
9817         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9818         variables.
9819
9820 2019-01-03  Tom Tromey  <tom@tromey.com>
9821
9822         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9823
9824 2019-01-03  Tom Tromey  <tom@tromey.com>
9825
9826         * python/py-symtab.c (salpy_str): Update.
9827         (struct salpy_sal_object) <symtab>: Now a PyObject.
9828         (salpy_dealloc): Update.
9829         (del_objfile_sal): Use gdbpy_ref.
9830
9831 2019-01-03  Tom Tromey  <tom@tromey.com>
9832
9833         * python/py-type.c (convert_field): Use new_reference.  Return
9834         gdbpy_ref.
9835         (make_fielditem): Return gdbpy_ref.
9836         (typy_fields): Update.
9837         (typy_getitem): Update.
9838         (field_name): Return gdbpy_ref.  Use new_reference.
9839         (typy_iterator_iternext): Update.
9840
9841 2019-01-03  Tom Tromey  <tom@tromey.com>
9842
9843         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9844
9845 2019-01-03  Tom Tromey  <tom@tromey.com>
9846
9847         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9848         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9849         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9850         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9851         (pspy_set_type_printers): Likewise.
9852         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9853         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9854         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9855         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9856         (objfpy_set_type_printers): Likewise.
9857
9858 2019-01-03  Tom Tromey  <tom@tromey.com>
9859
9860         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9861         (gdbpy_print_stack): Use gdbpy_err_fetch.
9862         * python/python-internal.h (class gdbpy_err_fetch): New class.
9863         (class gdbpy_enter) <m_error_type, m_error_value,
9864         m_error_traceback>: Remove.
9865         <m_error>: New member.
9866         (gdbpy_exception_to_string): Don't declare.
9867         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9868         * python/py-value.c (convert_value_from_python): Use
9869         gdbpy_err_fetch.
9870         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9871         gdbpy_exception_to_string.
9872         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9873         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9874         gdbpy_err_fetch.
9875
9876 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9877
9878         * linux-nat.c (delete_lwp_cleanup): Delete.
9879         (struct lwp_deleter): New struct.
9880         (lwp_info_up): New typedef.
9881         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9882         lwp_info_up.
9883
9884 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9885
9886         * linux-fork.c (class scoped_switch_fork_info): New class.
9887         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9888
9889 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9890
9891         * valops.c (find_overload_match): Remove use of null_cleanup, and
9892         calls to do_cleanups.
9893
9894 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9895
9896         * compile/compile-cplus-types.c
9897         (compile_cplus_instance::decl_name): Handle changes to
9898         cp_func_name.
9899         * cp-support.c (cp_func_name): Update header comment, update
9900         return type.
9901         * cp-support.h (cp_func_name): Update return type in declaration.
9902         * valops.c (find_overload_match): Move temp_func local to top
9903         level of function and change its type.  Use temp_func to hold and
9904         delete temporary string obtained from cp_func_name.
9905
9906 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9907
9908         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9909         gdb::char_vector, remove cleanup, and update uses of `msg`.
9910
9911 2019-01-03  Jim Wilson  <jimw@sifive.com>
9912
9913         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9914
9915 2019-01-02  Tom Tromey  <tom@tromey.com>
9916
9917         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9918         (tdesc_parse_xml): Remove cleanups.
9919         * target-descriptions.h (make_cleanup_free_target_description):
9920         Don't declare.
9921         (target_desc_deleter): New struct.
9922         (target_desc_up): New typedef.
9923         * target-descriptions.c (target_desc_deleter::operator()): Rename
9924         from free_target_description.
9925         (make_cleanup_free_target_description): Remove.
9926
9927 2019-01-02  Tom Tromey  <tom@tromey.com>
9928
9929         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9930         constructor, destructor.
9931         (linespec_parser): Remove typedef.
9932         (~linespec_parser): Rename from linespec_parser_delete.
9933         (linespec_lex_to_end, linespec_complete_label)
9934         (linespec_complete): Update.
9935         (decode_line_full): Remove cleanups.
9936         (decode_line_1): Update.
9937
9938 2019-01-02  Tom Tromey  <tom@tromey.com>
9939
9940         * python/python-internal.h (inferior_to_inferior_object): Change
9941         return type.
9942         * python/py-exitedevent.c (create_exited_event_object): Update.
9943         * python/py-inferior.c (inferior_to_inferior_object): Return
9944         gdbpy_ref.
9945         (python_new_inferior, python_inferior_deleted)
9946         (thread_to_thread_object, delete_thread_object)
9947         (build_inferior_list, gdbpy_selected_inferior): Update.
9948         * python/py-infthread.c (create_thread_object): Update.  Also fail
9949         if inferior_to_inferior_object fails.
9950
9951 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9952
9953         * inferior.h (class inferior) <displaced_step_state>: New field.
9954         * infrun.h (struct displaced_step_state): Move here from
9955         infrun.c.  Initialize fields, add constructor.
9956         <inf>: Remove field.
9957         <reset>: New method.
9958         * infrun.c (struct displaced_step_inferior_state): Move to
9959         infrun.h.
9960         (displaced_step_inferior_states): Remove.
9961         (get_displaced_stepping_state): Adust.
9962         (displaced_step_in_progress_any_inferior): Adjust.
9963         (displaced_step_in_progress_thread): Adjust.
9964         (displaced_step_in_progress): Adjust.
9965         (add_displaced_stepping_state): Remove.
9966         (get_displaced_step_closure_by_addr): Adjust.
9967         (remove_displaced_stepping_state): Remove.
9968         (infrun_inferior_exit): Call displaced_step_state.reset.
9969         (use_displaced_stepping): Don't check for NULL.
9970         (displaced_step_prepare_throw): Call
9971         get_displaced_stepping_state.
9972         (displaced_step_fixup): Don't check for NULL.
9973         (prepare_for_detach): Don't check for NULL.
9974
9975 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9976
9977         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9978          in case of call that did not complete.
9979
9980 2019-01-02  Andrey Utkin  <autkin@undo.io>
9981
9982         * symfile.c (find_separate_debug_file): Fix search of debug files for
9983         remote debuggee.
9984
9985 2019-01-02  Tom Tromey  <tom@tromey.com>
9986
9987         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9988         indentation.
9989         * python/py-frame.c (frapy_older): Remove cast.
9990         (frapy_newer): Likewise.
9991         * python/py-breakpoint.c (local_setattro): Remove cast.
9992         * python/py-arch.c (archpy_name): Remove local variable.
9993         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9994
9995 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9996
9997         * unittests/basic_string_view/element_access/char/empty.cc:
9998         Fix year range in copyright header.
9999
10000 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10001
10002         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10003         Delete.
10004         <operator==>: Update with for removed field.
10005         <hash>: Likewise.
10006         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10007         <isa_features>: ...this.
10008         <abi_features>: New field.
10009         (riscv_isa_flen): Update comment.
10010         (riscv_abi_xlen): New declaration.
10011         (riscv_abi_flen): New declaration.
10012         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10013         isa_features.
10014         (riscv_abi_xlen): New function.
10015         (riscv_isa_flen): Update to get answer from isa_features.
10016         (riscv_abi_flen): New function.
10017         (riscv_has_fp_abi): Update to get answer from abi_features.
10018         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10019         xlen and flen.
10020         (riscv_call_info) <xlen, flen>: Update comment.
10021         (riscv_call_arg_struct): Remove invalid assertions
10022         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10023         is removed.
10024         (riscv_gdbarch_init): Gather isa features and abi features
10025         separately, ensure both match on the gdbarch when reusing an old
10026         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10027         a target with 64-bit float hardware.
10028
10029 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10030
10031         * source.c (search_command_helper): Stop reverse search
10032         when line 1 has been searched.
10033
10034 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10035
10036         * record-full.c (record_full_base_target::close): Rewrite
10037         record_full_core_buf_list free logic.
10038
10039 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10040
10041         * break-catch-syscall.c (print_one_catch_syscall): xfree
10042         the last text.
10043
10044 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10045
10046         * top.c (print_gdb_version): Update Copyright year in version
10047         message.
10048
10049 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10050
10051         Update copyright year range in all GDB files.
10052
10053 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10054
10055         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10056
10057 For older changes see ChangeLog-2018.
10058 \f
10059 Local Variables:
10060 mode: change-log
10061 left-margin: 8
10062 fill-column: 74
10063 version-control: never
10064 coding: utf-8
10065 End:
10066