gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
   4         declare.
   5         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
   6         Rename from tui_first_data_item_displayed.  Update.
   7         (tui_data_window::refresh_all)
   8         (tui_data_window::do_scroll_vertical): Update.
   9         * tui/tui-data.h (struct tui_data_window)
  10         <first_data_item_displayed>: Declare new method.
  11
  12 2019-06-25  Tom Tromey  <tom@tromey.com>
  13
  14         * tui/tui-data.h (tui_init_generic_part): Don't declare.
  15         * tui/tui-data.c (tui_init_generic_part): Remove, moving
  16         contents...
  17         (tui_initialize_static_data): ...here.
  18
  19 2019-06-25  Tom Tromey  <tom@tromey.com>
  20
  21         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
  22         (tui_display_registers_from, tui_check_register_values): Update.
  23         (tui_display_register): Remove win_info parameter; update.
  24         (tui_get_register): Change type of parameters.
  25         * tui/tui-data.h (struct tui_data_element): Remove.
  26         (union tui_which_element) <data>: Remove.
  27         <data_window>: Change type.
  28         (struct tui_data_item_window): New.
  29         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
  30         case.  Add assert.
  31         (~tui_data_item_window): New destructor.
  32         (free_content_elements): Remove DATA_ITEM_WIN case.
  33
  34 2019-06-25  Tom Tromey  <tom@tromey.com>
  35
  36         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
  37         Remove.
  38
  39 2019-06-25  Tom Tromey  <tom@tromey.com>
  40
  41         * tui/tui-data.h (struct tui_command_element): Remove.
  42         (union tui_which_element) <command>: Remove.
  43         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
  44         assert.
  45         (free_content_elements): Remove CMD_WIN case.
  46
  47 2019-06-25  Tom Tromey  <tom@tromey.com>
  48
  49         * tui/tui-layout.c (tui_set_layout): Update.
  50         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
  51         * tui/tui-data.c (layout_def): Update.
  52
  53 2019-06-25  Tom Tromey  <tom@tromey.com>
  54
  55         * tui/tui-wingeneral.c (tui_refresh_all): Update.
  56         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
  57         (tui_source_window_base::set_new_height): Update.
  58         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
  59         Update.
  60         (tui_set_locator_fullname, tui_set_locator_info)
  61         (tui_show_frame_info): Update.
  62         * tui/tui-source.c (tui_set_source_content)
  63         (tui_source_is_displayed): Update.
  64         * tui/tui-layout.c (show_source_disasm_command, show_data)
  65         (show_source_or_disasm_and_command): Update.
  66         * tui/tui-disasm.c (tui_set_disassem_content)
  67         (tui_get_begin_asm_address): Update.
  68         * tui/tui-data.h (struct tui_locator_element): Remove.
  69         (union tui_which_element) <locator>: Remove.
  70         (struct tui_locator_window): New.
  71         (tui_locator_win_info_ptr): Change return type.
  72         * tui/tui-data.c (_locator): Change type.
  73         (tui_locator_win_info_ptr): Change return type.
  74         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
  75         (tui_alloc_content): Add assert.
  76
  77 2019-06-25  Tom Tromey  <tom@tromey.com>
  78
  79         * tui/tui-winsource.c
  80         (tui_exec_info_window::maybe_allocate_content): New method.
  81         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
  82         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
  83         (make_source_or_disasm_window): Add cast.
  84         * tui/tui-data.h (union tui_which_element) <simple_string>:
  85         Remove.
  86         (struct tui_source_info): New.
  87         (struct tui_source_window_base) <execution_info>: Change type.
  88         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
  89         case, and add assert.
  90         (tui_alloc_content): Add assert.
  91
  92 2019-06-25  Tom Tromey  <tom@tromey.com>
  93
  94         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
  95         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
  96         * tui/tui-data.c (tui_alloc_win_info): Remove.
  97
  98 2019-06-25  Tom Tromey  <tom@tromey.com>
  99
 100         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 101         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 102         can_highlight.
 103
 104 2019-06-25  Tom Tromey  <tom@tromey.com>
 105
 106         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 107         make_visible_with_new_height method.
 108         (tui_win_info::make_visible_with_new_height): New method.
 109         (tui_source_window_base::do_make_visible_with_new_height)
 110         (tui_data_window::do_make_visible_with_new_height)
 111         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 112         (make_visible_with_new_height): Remove.
 113         (tui_resize_all, tui_adjust_win_heights): Use
 114         make_visible_with_new_height method.
 115         * tui/tui-data.h (struct tui_win_info)
 116         <do_make_visible_with_new_height, make_visible_with_new_height>:
 117         New methods.
 118         (struct tui_source_window_base, struct tui_data_window)
 119         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 120         methods.
 121
 122 2019-06-25  Tom Tromey  <tom@tromey.com>
 123
 124         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 125         method.
 126         (update_tab_width): Call update_tab_width method.
 127         * tui/tui-data.h (struct tui_win_info)
 128         (struct tui_source_window_base) <update_tab_width>: New methods.
 129
 130 2019-06-25  Tom Tromey  <tom@tromey.com>
 131
 132         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 133         parameter.
 134         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 135         parameter.
 136         (tui_gen_win_info::make_visible): Update.
 137         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 138         parameter.
 139         * tui/tui-data.h (enum tui_box): New enum.
 140         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 141
 142 2019-06-25  Tom Tromey  <tom@tromey.com>
 143
 144         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 145         init_and_make_win for EXEC_INFO_WIN.
 146         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 147         longer inline.
 148         (struct tui_win_info) <~tui_win_info>: Inline.
 149         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 150         Don't declare.
 151         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 152         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 153         Remove.
 154         (tui_initialize_static_data): Update.
 155         (~tui_gen_win_info): Handle more cleanup here.
 156         (~tui_source_window_base): Delete "execution_info".
 157         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 158
 159 2019-06-25  Tom Tromey  <tom@tromey.com>
 160
 161         * tui/tui-layout.c (make_command_window): Don't set
 162         can_highlight.
 163         (show_source_disasm_command): Call the reset method.
 164         (show_data): Don't set can_highlight.  Call the reset method.
 165         (tui_gen_win_info::reset): Rename from init_gen_win_info
 166         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 167         (show_source_or_disasm_and_command): Call the reset method.
 168         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 169         (struct tui_cmd_window): Set can_highlight.
 170
 171 2019-06-25  Tom Tromey  <tom@tromey.com>
 172
 173         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 174         from make_visible.
 175         (tui_make_visible, tui_make_invisible): Rewrite.
 176         (tui_win_info::make_visible): Remove.
 177         (tui_source_window_base::make_visible): Update.
 178         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 179         method.  Moved from...
 180         (struct tui_win_info) <make_visible>: ...here.
 181
 182 2019-06-25  Tom Tromey  <tom@tromey.com>
 183
 184         * tui/tui-winsource.c
 185         (tui_source_window_base::do_scroll_horizontal): Remove direction
 186         parameter.
 187         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 188         direction parameter.
 189         * tui/tui-win.c (tui_win_info::forward_scroll)
 190         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 191         (tui_win_info::right_scroll): Update.
 192         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 193         direction parameter.
 194         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 195         direction parameter.
 196         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 197         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 198         Remove direction parameter.
 199         (struct tui_source_window_base, struct tui_source_window)
 200         (struct tui_disasm_window, struct tui_data_window)
 201         (struct tui_cmd_window): Update.
 202
 203 2019-06-25  Tom Tromey  <tom@tromey.com>
 204
 205         * tui/tui-winsource.h (tui_set_exec_info_content)
 206         (tui_show_exec_info_content, tui_erase_exec_info_content)
 207         (tui_clear_exec_info_content, tui_update_exec_info): Change
 208         argument to tui_source_window_base.
 209         * tui/tui-winsource.c (tui_set_exec_info_content)
 210         (tui_show_exec_info_content, tui_erase_exec_info_content)
 211         (tui_clear_exec_info_content, tui_update_exec_info): Change
 212         argument to tui_source_window_base.
 213
 214 2019-06-25  Tom Tromey  <tom@tromey.com>
 215
 216         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 217         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 218
 219 2019-06-25  Tom Tromey  <tom@tromey.com>
 220
 221         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 222         check.
 223
 224 2019-06-25  Tom Tromey  <tom@tromey.com>
 225
 226         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 227         type to void.
 228         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 229         type to void.
 230         * tui/tui-source.c (tui_set_source_content): Update.
 231         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 232
 233 2019-06-25  Tom Tromey  <tom@tromey.com>
 234
 235         * tui/tui-win.c (window_name_completer, tui_set_focus)
 236         (tui_all_windows_info): Use name method.
 237         * tui/tui-data.h (struct tui_gen_win_info)
 238         (struct tui_source_window, struct tui_disasm_window)
 239         (struct tui_data_window, struct tui_cmd_window) <name>: New
 240         method.
 241         (tui_win_name): Don't declare.
 242         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 243         (tui_win_name): Remove.
 244
 245 2019-06-25  Tom Tromey  <tom@tromey.com>
 246
 247         * tui/tui-winsource.h (tui_update_source_window)
 248         (tui_update_source_window_as_is): Change parameter type.
 249         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 250         to be a tui_source_window_base.
 251         (tui_update_source_window_as_is): Likewise.
 252         * tui/tui-win.c (make_visible_with_new_height): Update.
 253
 254 2019-06-25  Tom Tromey  <tom@tromey.com>
 255
 256         * tui/tui-winsource.c (tui_erase_source_content)
 257         (tui_show_source_content, tui_show_exec_info_content)
 258         (tui_erase_exec_info_content): Use refresh_window method.
 259         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 260         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 261         from tui_refresh_win.
 262         (tui_data_window::refresh_window): New method.
 263         (tui_win_info::refresh, tui_source_window_base::refresh)
 264         (tui_refresh_all): Use refresh_window method.
 265         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 266         method.
 267         * tui/tui-regs.c (tui_display_register): Call refresh_window
 268         method.
 269         * tui/tui-layout.c (show_source_disasm_command)
 270         (show_source_or_disasm_and_command): Call refresh_window method.
 271         * tui/tui-data.h (struct tui_gen_win_info)
 272         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 273         New method.
 274
 275 2019-06-25  Tom Tromey  <tom@tromey.com>
 276
 277         * tui/tui.c (tui_rl_other_window, tui_enable)
 278         (tui_is_window_visible, tui_get_command_dimension): Update.
 279         * tui/tui-winsource.c (tui_update_source_window_as_is)
 280         (tui_clear_source_content, tui_erase_source_content)
 281         (tui_show_source_line, tui_source_window_base::refill)
 282         (tui_source_window_base::do_scroll_horizontal)
 283         (tui_source_window_base::set_is_exec_point_at)
 284         (tui_update_breakpoint_info, tui_set_exec_info_content)
 285         (tui_alloc_source_buffer, tui_line_is_displayed)
 286         (tui_addr_is_displayed): Update.
 287         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 288         (tui_check_and_display_highlight_if_needed)
 289         (tui_win_info::make_visible, tui_win_info::refresh)
 290         (tui_refresh_all): Update.
 291         * tui/tui-windata.c (tui_first_data_item_displayed)
 292         (tui_delete_data_content_windows, tui_erase_data_content)
 293         (tui_display_all_data, tui_data_window::refresh_all)
 294         (tui_check_data_values): Update.
 295         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 296         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 297         (tui_win_info::backward_scroll, tui_refresh_all_win)
 298         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 299         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 300         (tui_source_window_base::set_new_height)
 301         (tui_data_window::set_new_height)
 302         (make_invisible_and_set_new_height)
 303         (make_visible_with_new_height, new_height_ok)
 304         (parse_scrolling_args): Update.
 305         * tui/tui-stack.c (tui_show_frame_info): Update.
 306         * tui/tui-source.c (tui_set_source_content)
 307         (tui_set_source_content_nil, tui_source_is_displayed)
 308         (tui_source_window::do_scroll_vertical): Update.
 309         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 310         (tui_display_registers_from, tui_display_reg_element_at_line)
 311         (tui_check_register_values, tui_reg_command): Update.
 312         * tui/tui-layout.c (tui_default_win_height)
 313         (show_source_disasm_command, show_data, init_and_make_win)
 314         (show_source_or_disasm_and_command): Update.
 315         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 316         (tui_redisplay_readline, tui_mld_flush)
 317         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 318         (tui_getc): Update.
 319         * tui/tui-disasm.c (tui_set_disassem_content)
 320         (tui_disasm_window::do_scroll_vertical): Update.
 321         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 322         Now virtual.
 323         (struct tui_win_info): Derive from tui_gen_win_info.
 324         <~tui_win_info>: Mark as override.
 325         <generic>: Remove member.
 326         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 327         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 328         (~tui_data_window, ~tui_win_info)
 329         (tui_free_all_source_wins_content): Update.
 330         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 331
 332 2019-06-25  Tom Tromey  <tom@tromey.com>
 333
 334         * tui/tui-layout.c (init_and_make_win): Use new.
 335         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 336         destructor, initializers.
 337         (tui_alloc_generic_win_info): Don't declare.
 338         * tui/tui-data.c (_locator): Add argument to constructor.
 339         (source_win, disasm_win): New globals.
 340         (exec_info): Remove.
 341         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 342         Update.
 343         (tui_alloc_generic_win_info): Remove.
 344         (init_content_element): Use new.
 345         (tui_win_info::tui_win_info): Update.
 346         (free_content_elements) <case DATA_WIN>: Use delete.
 347
 348 2019-06-25  Tom Tromey  <tom@tromey.com>
 349
 350         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 351         * tui/tui-windata.c (tui_first_data_item_displayed)
 352         (tui_delete_data_content_windows): Update.
 353         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 354         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 355         (tui_display_registers_from, tui_check_register_values): Update.
 356         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 357         pointer.
 358         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 359         window.
 360         (tui_free_data_content): Update.
 361         (free_content_elements) <case DATA_WIN>: Free the window.
 362
 363 2019-06-25  Tom Tromey  <tom@tromey.com>
 364
 365         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 366         Update.
 367         * tui/tui-layout.c (make_command_window)
 368         (show_source_disasm_command, show_data, init_and_make_win)
 369         (show_source_or_disasm_and_command): Update.
 370         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 371         method.
 372         <can_highight, is_highlighted>: Now bool.
 373         (tui_set_win_highlight): Don't declare.
 374         * tui/tui-data.c (tui_set_win_highlight): Remove.
 375
 376 2019-06-25  Tom Tromey  <tom@tromey.com>
 377
 378         * tui/tui-wingeneral.c (make_visible): Remove check of window
 379         type.
 380
 381 2019-06-25  Tom Tromey  <tom@tromey.com>
 382
 383         * tui/tui-win.c (tui_win_info::max_height)
 384         (tui_cmd_window::max_height): New methods.
 385         (new_height_ok): Call max_height.
 386         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 387         <max_height>: New method.
 388
 389 2019-06-25  Tom Tromey  <tom@tromey.com>
 390
 391         * tui/tui-win.c (tui_source_window_base::set_new_height)
 392         (tui_data_window::set_new_height): New methods.
 393         (make_invisible_and_set_new_height): Call set_new_height method.
 394         * tui/tui-data.h (struct tui_win_info)
 395         (struct tui_source_window_base, struct tui_data_window)
 396         <set_new_height>: New method.
 397
 398 2019-06-25  Tom Tromey  <tom@tromey.com>
 399
 400         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 401         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 402         tui_refresh_data_win.
 403         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 404         method.
 405         (tui_refresh_all_win): Call the refresh_all method.
 406         (tui_set_focus): Likewise.
 407         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 408         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 409         Likewise.
 410
 411 2019-06-25  Tom Tromey  <tom@tromey.com>
 412
 413         * tui/tui-winsource.h (tui_refill_source_window)
 414         (tui_set_is_exec_point_at): Don't declare.
 415         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 416         (tui_source_window_base::refill): Rename from
 417         tui_refill_source_window.
 418         (tui_source_window_base::do_scroll_horizontal): Update.
 419         (tui_source_window_base::set_is_exec_point_at): Rename from
 420         tui_set_is_exec_point_at.
 421         (tui_update_all_breakpoint_info): Update.
 422         * tui/tui-stack.c (tui_show_frame_info): Update.
 423         * tui/tui-layout.c (show_data): Add cast.
 424         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 425         * tui/tui-data.h (struct tui_source_window_base) <refill,
 426         set_is_exec_point_at>: New methods.
 427         (tui_source_windows, tui_add_to_source_windows): Update types.
 428         (tui_add_to_source_windows): Remove redundant declaration.
 429         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 430         (tui_source_windows): Change return type.
 431         (tui_clear_source_windows_detail): Update.
 432         (tui_add_to_source_windows): Change type of parameter.
 433         (tui_free_all_source_wins_content): Update.
 434
 435 2019-06-25  Tom Tromey  <tom@tromey.com>
 436
 437         * tui/tui-wingeneral.c (tui_win_info::refresh)
 438         (tui_source_window_base::refresh): New methods.
 439         (tui_refresh_all): Call the refresh method.
 440         * tui/tui-data.h (struct tui_win_info)
 441         (struct tui_source_window_base) <refresh>: New method.
 442
 443 2019-06-25  Tom Tromey  <tom@tromey.com>
 444
 445         * tui/tui.h (tui_is_window_visible): Return bool.
 446         * tui/tui.c (tui_is_window_visible): Return bool.
 447         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 448         (tui_make_visible, tui_make_invisible)
 449         (tui_win_info::make_visible)
 450         (tui_source_window_base::make_visible, make_all_visible)
 451         (tui_make_all_visible, tui_make_all_invisible): Update.
 452         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 453         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 454         bool.
 455         (struct tui_win_info, struct tui_source_window_base)
 456         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 457         * tui/tui-data.c (tui_init_generic_part): Update.
 458
 459 2019-06-25  Tom Tromey  <tom@tromey.com>
 460
 461         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 462         (tui_source_window_base::make_visible): New methods.
 463         (make_all_visible): Make method call.
 464         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 465         (struct tui_source_window_base, struct tui_cmd_window): Override
 466         make_visible.
 467         (tui_win_is_source_type): Don't declare.
 468         * tui/tui-data.c (tui_win_is_source_type): Remove.
 469
 470 2019-06-25  Tom Tromey  <tom@tromey.com>
 471
 472         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 473         NULL check.
 474
 475 2019-06-25  Tom Tromey  <tom@tromey.com>
 476
 477         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 478         Inline constructor.  Add initializers for members.
 479         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 480         constructors; now inline in class.
 481
 482 2019-06-25  Tom Tromey  <tom@tromey.com>
 483
 484         * tui/tui-regs.c (tui_show_registers): Update.
 485         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 486         bool.
 487         * tui/tui-data.c (tui_data_window::clear_detail)
 488         (tui_data_window): Update.
 489
 490 2019-06-25  Tom Tromey  <tom@tromey.com>
 491
 492         * tui/tui-windata.c (tui_display_all_data)
 493         (tui_display_data_from_line, tui_display_data_from)
 494         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 495         Update.
 496         * tui/tui-regs.c (tui_last_regs_line_no)
 497         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 498         (tui_show_registers, tui_show_register_group)
 499         (tui_display_registers_from, tui_display_reg_element_at_line)
 500         (tui_display_registers_from_line, tui_check_register_values)
 501         (tui_reg_next, tui_reg_prev): Update.
 502         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 503         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 504         tui_data_window.
 505         (struct tui_win_info) <detail>: Remove.  Add new fields from
 506         tui_data_info.
 507         (TUI_DATA_WIN): Add cast.
 508         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 509         (~tui_data_window): Simplify.
 510
 511 2019-06-25  Tom Tromey  <tom@tromey.com>
 512
 513         * tui/tui-layout.c (show_source_disasm_command)
 514         (show_source_or_disasm_and_command): Update.
 515         * tui/tui-io.c (update_cmdwin_start_line)
 516         (tui_redisplay_readline): Update.
 517         * tui/tui-data.h (struct tui_command_info): Remove.
 518         (struct tui_win_info) <detail>: Remove command_info member.
 519         (struct tui_data_window) <start_line>: New member, from
 520         tui_command_info.
 521         (TUI_CMD_WIN): Add casts.
 522
 523 2019-06-25  Tom Tromey  <tom@tromey.com>
 524
 525         * tui/tui-winsource.c (tui_update_source_window)
 526         (tui_refill_source_window)
 527         (tui_source_window_base::do_scroll_horizontal)
 528         (tui_update_breakpoint_info, tui_set_exec_info_content)
 529         (tui_show_exec_info_content, tui_erase_exec_info_content)
 530         (tui_clear_exec_info_content): Update.
 531         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 532         Update.
 533         * tui/tui-win.c (make_invisible_and_set_new_height)
 534         (make_visible_with_new_height): Update.
 535         * tui/tui-source.c (tui_set_source_content)
 536         (tui_show_symtab_source): Update.
 537         * tui/tui-layout.c (extract_display_start_addr)
 538         (show_source_disasm_command, show_data)
 539         (make_source_or_disasm_window)
 540         (show_source_or_disasm_and_command): Update.
 541         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 542         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 543         "gdbarch".
 544         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 545         to tui_source_window_base.
 546         (struct tui_win_info) <detail>: Remove source_info member.
 547         (struct tui_source_window_base) <has_locator>: Inline.
 548         Move contents from tui_source_info; rename has_locator member to
 549         m_has_locator.
 550         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 551         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 552         header file.
 553         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 554         Simplify.
 555         (tui_free_all_source_wins_content): Cast to
 556         tui_source_window_base.
 557
 558 2019-06-25  Tom Tromey  <tom@tromey.com>
 559
 560         * tui/tui-win.c (make_invisible_and_set_new_height)
 561         (make_visible_with_new_height): Call has_locator method.
 562         * tui/tui-layout.c (show_source_disasm_command, show_data)
 563         (show_source_or_disasm_and_command): Update for bool change.
 564         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 565         (tui_win_info) <has_locator>: New method.
 566         (struct tui_source_window_base) <has_locator>: New method.
 567         (tui_win_has_locator): Don't declare.
 568         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 569         from tui_win_has_locator.
 570         (tui_source_window_base): Use false, not FALSE.
 571
 572 2019-06-25  Tom Tromey  <tom@tromey.com>
 573
 574         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 575         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 576         clear_detail method directly.
 577         (tui_clear_win_detail): Remove.
 578
 579 2019-06-25  Tom Tromey  <tom@tromey.com>
 580
 581         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 582         "this", not TUI_DISASM_WIN.
 583
 584 2019-06-25  Tom Tromey  <tom@tromey.com>
 585
 586         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 587         declare.
 588         * tui/tui-winsource.c
 589         (tui_source_window_base::do_scroll_horizontal): Rename from
 590         tui_horizontal_source_scroll.
 591         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 592         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 593         from tui_vertical_data_scroll.
 594         * tui/tui-win.h (tui_scroll): Don't declare.
 595         * tui/tui-win.c (tui_win_info::forward_scroll)
 596         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 597         (tui_win_info::right_scroll): Rename and update.
 598         (tui_scroll_forward_command, tui_scroll_backward_command)
 599         (tui_scroll_left_command, tui_scroll_right_command): Update.
 600         (tui_scroll): Remove.
 601         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 602         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 603         from tui_vertical_source_scroll.
 604         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 605         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 606         from tui_vertical_disassem_scroll.
 607         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 608         do_scroll_horizontal>: New methods.
 609         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 610         Likewise.
 611         (struct tui_source_window_base): Add do_scroll_horizontal.
 612         (struct tui_source_window, struct tui_disasm_window): Add
 613         do_scroll_vertical.
 614         (struct tui_data_window, struct tui_cmd_window): Add
 615         do_scroll_horizontal and do_scroll_vertical.
 616         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 617
 618 2019-06-25  Tom Tromey  <tom@tromey.com>
 619
 620         * tui/tui-data.h (struct tui_source_window_base): New struct.
 621         (struct tui_source_window): Derive from tui_source_window_base.
 622         (struct tui_disasm_window): New struct.
 623         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 624         from tui_source_window::clear_detail.
 625         (tui_source_window_base): Rename from tui_source_window.
 626         (~tui_source_window_base): Rename from ~tui_source_window.
 627         (tui_alloc_win_info): Create a tui_disasm_window.
 628
 629 2019-06-25  Tom Tromey  <tom@tromey.com>
 630
 631         * tui/tui-data.h (struct tui_source_window)
 632         (struct tui_data_window): Declare destructors.
 633         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 634         destructors.
 635         (tui_win_info): Simplify.
 636
 637 2019-06-25  Tom Tromey  <tom@tromey.com>
 638
 639         * tui/tui-winsource.c (tui_display_main)
 640         (tui_update_source_windows_with_addr)
 641         (tui_update_all_breakpoint_info): Update.
 642         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 643         (new_height_ok, parse_scrolling_args): Update.
 644         * tui/tui-stack.c (tui_show_frame_info): Update.
 645         * tui/tui-data.h (struct tui_list): Remove.
 646         (tui_source_windows): Return a reference to a std::vector.
 647         * tui/tui-data.c (source_windows): Now a std::vector.
 648         (tui_source_windows): Change return type.
 649         (tui_clear_source_windows): Rewrite.
 650         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 651         (tui_free_all_source_wins_content): Rewrite.
 652
 653 2019-06-25  Tom Tromey  <tom@tromey.com>
 654
 655         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 656         (struct tui_data_window, struct tui_cmd_window): Declare
 657         clear_detail method.
 658         * tui/tui-data.c (tui_source_window::clear_detail)
 659         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 660         methods.
 661         (tui_clear_win_detail): Simplify.
 662
 663 2019-06-25  Tom Tromey  <tom@tromey.com>
 664
 665         * tui/tui-layout.c (make_source_window, make_disasm_window)
 666         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 667         Return the new window.
 668         (show_source_disasm_command, show_data)
 669         (show_source_or_disasm_and_command): Update.
 670
 671 2019-06-25  Tom Tromey  <tom@tromey.com>
 672
 673         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 674         parameter.  Return the new window.
 675         (show_source_disasm_command): Update and remove NULL check.
 676         (show_source_or_disasm_and_command): Update.
 677
 678 2019-06-25  Tom Tromey  <tom@tromey.com>
 679
 680         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 681
 682 2019-06-25  Tom Tromey  <tom@tromey.com>
 683
 684         * tui/tui-data.h (struct tui_win_info): Make constructor
 685         protected.  Make destructor virtual.  Add initializers.
 686         (tui_source_window, tui_data_window, tui_cmd_window): New
 687         classes.
 688         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 689         constructor.  Add "type" parameter.
 690         (tui_source_window, tui_data_window, tui_cmd_window): New
 691         constructors.
 692         (tui_alloc_win_info): Instantiate the appropriate subclass.
 693
 694 2019-06-25  Tom Tromey  <tom@tromey.com>
 695
 696         * tui/tui-win.c (tui_resize_all): Use delete.
 697         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 698         destructor.
 699         (tui_free_window): Don't declare.
 700         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 701         Update.
 702
 703 2019-06-25  Tom Tromey  <tom@tromey.com>
 704
 705         * tui/tui-data.h (struct tui_win_info): Add constructor.
 706         * tui/tui-data.c (tui_alloc_win_info): Use new.
 707         (tui_free_window): Use delete.
 708
 709 2019-06-22  Tom Tromey  <tom@tromey.com>
 710
 711         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 712         declare.
 713         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 714
 715 2019-06-22  Tom Tromey  <tom@tromey.com>
 716
 717         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 718         declare.
 719         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 720
 721 2019-06-22  Tom de Vries  <tdevries@suse.de>
 722
 723         * dwarf2read.c (create_addrmap_from_aranges)
 724         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 725         instead of '%zu'.
 726
 727 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 728
 729         * dwarf2read.h (dwarf2_section_info_def): Remove.
 730         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 731         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 732         std::vector<dwarf2_section_info>.
 733         (struct dwo_file) <~dwo_file>: Remove.
 734         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 735         types field.
 736         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 737         (dwarf2_read_debug_names): Likewise.
 738         (create_debug_types_hash_table): Change parameter type to
 739         array_view, adjust code accordingly.
 740         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 741         (partial_die_info::fixup): Likewise.
 742         (determine_prefix): Likewise.
 743         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 744
 745 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 746
 747         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 748         gdb_bfd_ref_ptr.
 749         <~dwo_file>: Remove call to gdb_bfd_unref.
 750         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 751         gdb_bfd_ref_ptr::get.
 752
 753 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 754
 755         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 756         type to htab_up.
 757         * dwarf2read.c (struct dwo_file): Initialize fields.
 758         <~dwo_file>: New.
 759         (free_dwo_file): Remove, move content to ~dwo_file.
 760         (struct dwo_file_deleter): Remove.
 761         (dwo_file_up>: Remove custom deleter.
 762         (free_dwo_files): Remove.
 763         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 764         dwo_files.
 765         (process_skeletonless_type_units): Call unique_ptr::get.
 766         (allocate_dwo_file_hash_table): Add deleter to created hash
 767         table.  Change return type to htab_up.
 768         (lookup_dwo_file_slot): Don't memset dwo_file, call
 769         unique_ptr::get.
 770         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 771         (create_dwo_unit_in_dwp_v2): Likewise.
 772         (open_and_init_dwo_file): Likewise.
 773         (free_dwo_file_from_slot): Remove.
 774
 775 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 776
 777         * dwarf2read.h (struct dwarf2_section_info) <readin,
 778         is_virtual>: Change type to bool.
 779         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 780         true instead of 1.
 781
 782 2019-06-19  Tom Tromey  <tom@tromey.com>
 783
 784         * tui/tui-data.h (tui_init_content_element): Don't declare.
 785
 786 2019-06-19  Tom Tromey  <tom@tromey.com>
 787
 788         * tui/tui-data.h (tui_init_win_info): Don't declare.
 789
 790 2019-06-19  Tom de Vries  <tdevries@suse.de>
 791
 792         * dwarf2read.h (abstract_to_concrete): Change type to
 793         std::unordered_map<sect_offset, std::vector<sect_offset>,
 794         gdb::hash_enum<sect_offset>>.
 795
 796 2019-06-19  Tom Tromey  <tromey@adacore.com>
 797
 798         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 799         EVAL_AVOID_SIDE_EFFECTS specially.
 800
 801 2019-06-19  Tom Tromey  <tromey@adacore.com>
 802
 803         * source-cache.c (highlighter): New global.
 804         (source_cache::get_source_lines): Create a highlighter on demand.
 805
 806 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 807
 808         * defs.h (deprecated_interactive_hook): Delete declaration.
 809         * interps.c (clear_interpreter_hooks): Remove use of
 810         deprecated_interactive_hook.
 811         * top.c (deprecated_interactive_hook): Delete definition.
 812         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 813
 814 2019-06-18  Tom de Vries  <tdevries@suse.de>
 815
 816         PR gdb/24515
 817         * dwarf2read.h (abstract_to_concrete): Change type from
 818         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 819         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 820         * dwarf2read.c (read_variable): Update.
 821         (dwarf2_fetch_die_loc_sect_off): Update.
 822
 823 2019-06-17  Tom de Vries  <tdevries@suse.de>
 824
 825         PR gdb/24617
 826         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 827         accessing parent[parent_len - 1].
 828
 829 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 830
 831         PR gdb/24364
 832         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 833         call dtrace_process_dof with NULL dof.
 834
 835 2019-06-16  Tom de Vries  <tdevries@suse.de>
 836
 837         PR gdb/24445
 838         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 839
 840 2019-06-16  Tom Tromey  <tom@tromey.com>
 841
 842         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 843         (make_all_visible): Use address of member.
 844
 845 2019-06-16  Tom Tromey  <tom@tromey.com>
 846
 847         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 848         (tui_free_window, free_content, free_content_elements): Remove
 849         unnecessary cast.
 850         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 851         cast.
 852         * tui/tui-regs.c (tui_show_register_group)
 853         (tui_display_registers_from, tui_display_reg_element_at_line):
 854         Remove unnecessary cast.
 855
 856 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 857
 858         * linux-nat.c (normal_mask): Delete.
 859         (_initialize_linux_nat): Don't initialise normal_mask.
 860
 861 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 862
 863         PR gdb/24445
 864         * dwarf-index-write.h (write_psymtabs_to_index): Add
 865         dwz_basename parameter.
 866         * dwarf-index-write.c (write_gdbindex): Move file writing to
 867         write_gdbindex_1.  Change return type void.
 868         (assert_file_size): Move up, remove filename parameter.
 869         (write_gdbindex_1): New function.
 870         (write_debug_names): Change return type to void, call
 871         assert_file_size.
 872         (struct index_wip_file): New struct.
 873         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 874         file logic to index_wip_file.  Write index for dwz file if
 875         needed.
 876         (save_gdb_index_command): Pass basename of dwz file, if present.
 877         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 878         build-id of dwz file, if present.
 879         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 880         (dwarf2_get_dwz_file): Likewise.
 881         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 882         (dwarf2_get_dwz_file): Likewise.
 883
 884 2019-06-16  Tom Tromey  <tom@tromey.com>
 885
 886         * coffread.c (process_coff_symbol): Use xstrdup.
 887         * value.c (create_internalvar): Use xstrdup.
 888
 889 2019-06-16  Tom Tromey  <tom@tromey.com>
 890
 891         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 892         * breakpoint.c (stopin_command, stopat_command)
 893         (until_break_command, decode_location_default): Remove unnecessary
 894         cast.
 895         * utils.c (subset_compare): Remove unnecessary cast.
 896         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 897         cast.
 898         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 899         cast.
 900         * infcmd.c (path_command): Remove unnecessary cast.
 901         * coffread.c (decode_type): Remove unnecessary cast.
 902         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 903         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 904         * tui/tui-stack.c (tui_show_locator_content)
 905         (tui_show_frame_info): Remove unnecessary cast.
 906         * tui/tui-win.c (tui_scroll_forward_command)
 907         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 908         (parse_scrolling_args): Remove unnecessary cast.
 909         * tui/tui-data.c (init_win_info, tui_del_window)
 910         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 911         (free_content_elements): Remove unnecessary cast.
 912         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 913         unnecessary cast.
 914         * tui/tui-source.c (tui_set_source_content)
 915         (tui_vertical_source_scroll): Remove unnecessary cast.
 916         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 917         cast.
 918         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 919         * tui/tui-regs.c (tui_display_registers_from)
 920         (tui_display_register): Remove unnecessary cast.
 921         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 922         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 923         (make_visible): Remove unnecessary cast.
 924         * tui/tui-winsource.c (tui_erase_source_content)
 925         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 926         unnecessary cast.
 927         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 928         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 929         * stabsread.c (read_type, read_array_type, read_range_type):
 930         Remove unnecessary cast.
 931         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 932         (parse_symbol, parse_type, upgrade_type, parse_external)
 933         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 934         unnecessary cast.
 935         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 936
 937 2019-06-16  Tom Tromey  <tom@tromey.com>
 938
 939         * tui/tui-data.c (tui_alloc_generic_win_info)
 940         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 941         checks.
 942
 943 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 944             Andrew Burgess  <andrew.burgess@embecosm.com>
 945
 946         * f-typeprint.c (f_print_type): Don't return early for not
 947         associated or not allocated types.
 948         (f_type_print_varspec_suffix): Add print_rank parameter and print
 949         ranks of array types in case they dangling.
 950         (f_type_print_base): Add print_rank parameter.
 951
 952 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 953
 954         * NEWS: Mention new MI commands.
 955         * break-catch-throw.c (enum exception_event_kind): Move to
 956         breakpoint.h.
 957         (print_mention_exception_catchpoint): Output text as a single
 958         message.
 959         (catch_exception_command_1): Rename to...
 960         (catch_exception_event): ...this, make non-static, update header
 961         command, and change some parameter types.
 962         (catch_catch_command): Update for changes to
 963         catch_exception_command_1.
 964         (catch_throw_command): Likewise.
 965         (catch_rethrow_command): Likewise.
 966         * breakpoint.c (enum exception_event_kind): Delete.
 967         * breakpoint.h (enum exception_event_kind): Moved here from
 968         break-catch-throw.c.
 969         (catch_exception_event): Declare.
 970         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 971         (mi_cmd_catch_throw): New function.
 972         (mi_cmd_catch_rethrow): New function.
 973         (mi_cmd_catch_catch): New function.
 974         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 975         'catch-catch' entries.
 976         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 977         (mi_cmd_catch_rethrow): Declare.
 978         (mi_cmd_catch_catch): Declare.
 979
 980 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 981
 982         * annotate.c (annotate_source_line): Change return type to void,
 983         update implementation to match.
 984         * annotate.h (annotate_source_line): Change return type to void,
 985         update header comment.
 986         * stack.c (print_frame_info): Don't change what frame information
 987         is printed based on whether annotations are on or not.
 988
 989 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 990
 991         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 992         (annotate_source): Make static.
 993         (annotate_source_line): Moved from source.c and renamed from
 994         identify_source_line.  Update the return type.
 995         * annotate.h (annotate_source): Delete declaration.
 996         (annotate_source_line): Declaration moved from source.h, and
 997         renamed from identify_source_line.  Return type updated.
 998         * source.c (identify_source_line): Moved to annotate.c and renamed
 999         to annotate_source_line.
1000         (info_line_command): Remove check of annotation_level.
1001         * source.h (identify_source_line): Move declaration to annotate.h
1002         and rename to annotate_source_line.
1003         * stack.c: Add 'annotate.h' include.
1004         (print_frame_info): Remove check of annotation_level before
1005         calling annotate_source_line.
1006
1007 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1008
1009         * source-cache.c (source_cache::get_plain_source_lines): Use
1010         open_source_file_with_line_charpos instead of just
1011         open_source_file, remove call to find_source_lines.
1012         (source_cache::get_source_lines): Likewise.
1013         * source.c (find_source_lines): Make static.
1014         (get_filename_and_charpos): Renamed into...
1015         (open_source_file_with_line_charpos): ..this along with changes to
1016         return a scoped_fd, and some other minor clean ups.
1017         (identify_source_line): Use open_source_file_with_line_charpos.
1018         (search_command_helper): Use open_source_file_with_line_charpos
1019         instead of just open_source_file, remove call to
1020         find_source_lines.
1021         * source.h (open_source_file_with_line_charpos): Declare new
1022         function.
1023         (find_source_lines): Delete declaration.
1024
1025 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1026
1027         * source.c (get_filename_and_charpos): Remove fullname
1028         parameter.
1029         (identify_source_line): Update call to get_filename_and_charpos.
1030
1031 2019-06-14  Tom Tromey  <tromey@adacore.com>
1032
1033         PR gdb/24502:
1034         * ui-style.h (skip_ansi_escape): Update comment.
1035         * ui-file.h (class no_terminal_escape_file): New class.
1036         * ui-file.c (no_terminal_escape_file::write)
1037         (no_terminal_escape_file::puts): New methods.
1038         * cli/cli-logging.c (handle_redirections): Use
1039         no_terminal_escape_file.
1040
1041 2019-06-14  Tom Tromey  <tromey@adacore.com>
1042
1043         * NEWS: Move convenience variable news above Python news.
1044
1045 2019-06-14  Tom Tromey  <tom@tromey.com>
1046
1047         * gnulib: Move directory to top-level.
1048         * configure.ac: Don't configure gnulib.
1049         * configure: Rebuild.
1050         * common/common-defs.h: Use new path to gnulib.
1051         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1052         (GNULIB_H): Remove.
1053         (INCGNU): Look in new gnulib location.
1054         (HFILES_NO_SRCDIR): Remove gnulib files.
1055         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1056         (generated_files): Remove GNULIB_H.
1057         ($(LIBGNU), all-lib): Remove targets.
1058         (distclean): Don't mention GNULIB_BUILDDIR.
1059         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1060
1061 2019-06-14  Tom Tromey  <tromey@adacore.com>
1062
1063         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1064         Warn if symbol file does not provide any symbols.
1065
1066 2019-06-14  Tom Tromey  <tromey@adacore.com>
1067
1068         * source.c (find_and_open_source): Respect basenames_may_differ.
1069
1070 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1071
1072         * annotate.c (annotate_breakpoints_invalid): Make use of
1073         scoped_restore_terminal_state.
1074         (annotate_frames_invalid): Likewise.
1075
1076 2019-06-14  Tom Tromey  <tromey@adacore.com>
1077
1078         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1079         allow assignment to an internalvar.
1080
1081 2019-06-14  Tom Tromey  <tromey@adacore.com>
1082
1083         * ada-lex.l: Allow "_" in attribute names.
1084
1085 2019-06-14  Tom Tromey  <tromey@adacore.com>
1086
1087         PR gdb/24653:
1088         * regcache.c (registers_changed): Don't call alloca.
1089         * top.c (execute_command): Don't call alloca.
1090
1091 2019-06-13  Pedro Alves  <palves@redhat.com>
1092
1093         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1094         'expression'.  When parsing an expression, error out if there's
1095         junk after "unlimited".
1096         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1097         (do_set_command): Adjust calls to is_unlimited_literal.
1098
1099 2019-06-13  Pedro Alves  <palves@redhat.com>
1100
1101         * compile/compile.c (make_compile_options_def_group): Add braces
1102         around array_view initializer.
1103         * thread.c (make_thread_apply_all_options_def_group)
1104         (make_thread_apply_all_options_def_group): Likewise.
1105
1106 2019-06-13  Pedro Alves  <palves@redhat.com>
1107
1108         * NEWS (New commands): Mention "maint test-options
1109         require-delimiter", "maint test-options unknown-is-error", "maint
1110         test-options unknown-is-operand" and "maint show
1111         test-options-completion-result".
1112         (New command options, command completion): New section.
1113         (Completion improvements): New section.
1114         Mention that you can abbreviate "unlimited".
1115
1116 2019-06-13  Pedro Alves  <palves@redhat.com>
1117
1118         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1119         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1120         * unittests/cli-utils-selftests.c (test_parse_flags)
1121         (test_parse_flags_qcs): Delete.
1122         (test_cli_utils): Don't call deleted functions.
1123
1124 2019-06-13  Pedro Alves  <palves@redhat.com>
1125
1126         * thread.c: Include "cli/cli-option.h".
1127         (tp_array_compar_ascending): Global.
1128         (tp_array_compar): Delete function.
1129         (tp_array_compar_ascending, tp_array_compar_descending): New
1130         functions.
1131         (ascending_option_def, qcs_flag_option_def)
1132         (thr_qcs_flags_option_defs)
1133         (make_thread_apply_all_options_def_group)
1134         (make_thread_apply_options_def_group): New.
1135         (thread_apply_all_command): Use gdb::option::process_options.
1136         (thread_apply_command_completer)
1137         (thread_apply_all_command_completer): New.
1138         (thread_apply_command): Use gdb::option::process_options.
1139         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1140         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1141         to generate help text of "thread apply".  Adjust "taas"'s help.
1142         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1143         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1144
1145 2019-06-13  Pedro Alves  <palves@redhat.com>
1146
1147         * thread.c (thread_apply_command): Check for invalid TID with
1148         isdigit instead of !isalpha.
1149
1150 2019-06-13  Pedro Alves  <palves@redhat.com>
1151
1152         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1153         (validate_flags_qcs): New.
1154         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1155         (validate_flags_qcs): Declare.
1156         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1157         (make_frame_apply_options_def_group): New.
1158         (frame_apply_command_count): Process options with
1159         gdb::option::process_options.
1160         (frame_apply_completer): New.
1161         (frame_apply_level_completer, frame_apply_all_completer)
1162         (frame_apply_completer): New.
1163         (_initialize_stack): Update help of "frame apply", "frame apply
1164         level", "frame apply all" and "faas" to mention supported options
1165         and install command completers.
1166         * stack.h (frame_apply_all_completer): Declare.
1167         * thread.c: Include "stack.h".
1168         (tfaas_command): Add "--".
1169         (_initialize_thread): Update help "tfaas" to mention supported
1170         options and install command completer.
1171
1172 2019-06-13  Pedro Alves  <palves@redhat.com>
1173
1174         * completer.c (complete_nested_command_line): New.
1175         (gdb_completion_word_break_characters_throw): Add assertion.
1176         * completer.h (complete_nested_command_line): Declare.
1177
1178 2019-06-13  Pedro Alves  <palves@redhat.com>
1179
1180         * stack.c (parse_backtrace_qualifiers): New.
1181         (backtrace_command): Use it.
1182         (backtrace_command_completer): Complete on qualifiers.
1183
1184 2019-06-13  Pedro Alves  <palves@redhat.com>
1185
1186         * frame.c: Include "cli/cli-option.h.
1187         (user_set_backtrace_options): New.
1188         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1189         Delete.
1190         (get_prev_frame): Adjust.
1191         (boolean_option_def, uinteger_option_def)
1192         (set_backtrace_option_defs): New.
1193         (_initialize_frame): Adjust and use
1194         gdb::option::add_setshow_cmds_for_options to install "set
1195         backtrace past-main" and "set backtrace past-entry".
1196         * frame.h: Include "cli/cli-option.h".
1197         (struct frame_print_options): Forward declare.
1198         (print_frame_arguments_all, print_frame_arguments_scalars)
1199         (print_frame_arguments_none): Declare.
1200         (print_entry_values): Delete declaration.
1201         (struct frame_print_options, user_frame_print_options): New.
1202         (struct set_backtrace_options): New.
1203         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1204         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1205         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1206         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1207         (list_args_or_locals): Add frame_print_options parameter.
1208         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1209         * python/py-framefilter.c (enumerate_args): Pass down
1210         USER_FRAME_PRINT_OPTIONS.
1211         * stack.c: Include "cli/cli-option.h".
1212         (print_frame_arguments_all, print_frame_arguments_scalars)
1213         (print_frame_arguments_none): Declare.
1214         (print_raw_frame_arguments, print_entry_values): Delete.
1215         (user_frame_print_options): New.
1216         (boolean_option_def, enum_option_def, frame_print_option_defs):
1217         New.
1218         (struct backtrace_cmd_options): New.
1219         (bt_flag_option_def): New.
1220         (backtrace_command_option_defs): New.
1221         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1222         (print_frame_arg, read_frame_arg, print_frame_args)
1223         (print_frame_info, print_frame): Add frame_print_options parameter
1224         and use it.
1225         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1226         (backtrace_command_1): Add frame_print_options and
1227         backtrace_cmd_options parameters and use them.
1228         (make_backtrace_options_def_group): New.
1229         (backtrace_command): Process command options with
1230         gdb::option::process_options.
1231         (backtrace_command_completer): New.
1232         (_initialize_stack): Extend "backtrace"'s help to mention
1233         supported options.  Install completer for "backtrace".
1234         Install some settings commands with add_setshow_cmds_for_options.
1235
1236 2019-06-13  Pedro Alves  <palves@redhat.com>
1237
1238         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1239         and that "set/show print raw frame-arguments" are now deprecated.
1240
1241         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1242         command.
1243         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1244         * stack.c (_initialize_stack): Install "set/show print
1245         raw-frame-arguments", and deprecate "set/show print raw
1246         frame-arguments".
1247         * valprint.c (_initialize_valprint): Deprecate "set/show print
1248         raw".
1249
1250 2019-06-13  Pedro Alves  <palves@redhat.com>
1251
1252         * compile/compile.c (struct compile_options): New.
1253         (compile_flag_option_def, compile_command_option_defs)
1254         (make_compile_options_def_group): New.
1255         (compile_file_command): Handle options with
1256         gdb::option::process_options.
1257         (compile_file_command_completer): New function.
1258         (compile_code_command): Handle options with
1259         gdb::option::process_options.
1260         (compile_code_command_completer): New function.
1261         (_initialize_compiler): Install completers for "compile code" and
1262         "compile file".  Mention available options in "compile code" and
1263         "compile code"'s help.
1264         * completer.c (advance_to_completion_word): New, factored out from
1265         ...
1266         (advance_to_expression_complete_word_point): ... this.
1267         (advance_to_filename_complete_word_point): New.
1268         * completer.h (advance_to_filename_complete_word_point): New
1269         declaration.
1270
1271 2019-06-13  Pedro Alves  <palves@redhat.com>
1272
1273         * compile/compile.c: Include "cli/cli-option.h".
1274         (compile_print_value): Scope data pointer is now a
1275         value_print_options pointer; adjust.
1276         (compile_print_command): Process options.  Scope data pointer is
1277         now a value_print_options pointer; adjust.
1278         (_initialize_compile): Update "compile print"'s help to include
1279         supported options.  Install a completer for "compile print".
1280         * cp-valprint.c (show_vtblprint, show_objectprint)
1281         (show_static_field_print): Delete.
1282         (_initialize_cp_valprint): Don't install "set print
1283         static-members", "set print vtbl", "set print object" here.
1284         * printcmd.c: Include "cli/cli-option.h" and
1285         "common/gdb_optional.h".
1286         (print_command_parse_format): Rework to fill in a
1287         value_print_options instead of a format_data.
1288         (print_value): Change parameter type from format_data pointer to
1289         value_print_options reference.  Adjust.
1290         (print_command_1): Process options.  Adjust to pass down a
1291         value_print_options.
1292         (print_command_completer): New.
1293         (_initialize_printcmd): Install print_command_completer as
1294         handle_brkchars completer for the "print" command.  Update
1295         "print"'s help to include supported options.
1296         * valprint.c: Include "cli/cli-option.h".
1297         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1298         here from cp-valprint.c.
1299         (boolean_option_def, uinteger_option_def)
1300         (value_print_option_defs, make_value_print_options_def_group):
1301         New.  Use gdb::option::add_setshow_cmds_for_options to install
1302         "set print elements", "set print null-stop", "set print repeats",
1303         "set print pretty", "set print union", "set print array", "set
1304         print address", "set print symbol", "set print array-indexes".
1305         * valprint.h: Include <string> and "cli/cli-option.h".
1306         (make_value_print_options_def_group): Declare.
1307         (print_value): Change parameter type from format_data pointer to
1308         value_print_options reference.
1309         (print_command_completer): Declare.
1310
1311 2019-06-13  Pedro Alves  <palves@redhat.com>
1312
1313         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1314         (COMMON_SFILES): Add maint-test-settings.c.
1315         * cli/cli-decode.c (boolean_enums): New global, factored out from
1316         ...
1317         (add_setshow_boolean_cmd): ... here.
1318         * cli/cli-decode.h (boolean_enums): Declare.
1319         * cli/cli-option.c: New file.
1320         * cli/cli-option.h: New file.
1321         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1322         factored out from ...
1323         (parse_cli_boolean_value(const char *)): ... this.
1324         (is_unlimited_literal): Change parameter type to pointer to
1325         pointer.  Adjust and advance ARG pointer.
1326         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1327         (parse_cli_var_enum): New, factored out from ...
1328         (do_set_command): ... this.  Adjust.
1329         * cli/cli-setshow.h (parse_cli_boolean_value)
1330         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1331         (parse_cli_var_enum): Declare.
1332         * cli/cli-utils.c: Include "cli/cli-option.h".
1333         (get_ulongest): New.
1334         * cli/cli-utils.h (get_ulongest): Declare.
1335         (check_for_argument): New overloads.
1336         * maint-test-options.c: New file.
1337
1338 2019-06-13  Pedro Alves  <palves@redhat.com>
1339
1340         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1341         parse a range if "-" is at the end of the string.
1342
1343 2019-06-13  Pedro Alves  <palves@redhat.com>
1344
1345         * cli/cli-setshow.c (parse_auto_binary_operation)
1346         (parse_cli_boolean_value): Don't allow "o".
1347
1348 2019-06-13  Pedro Alves  <palves@redhat.com>
1349
1350         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1351         * NEWS: Mention maint test-settings KIND.
1352         * maint-test-settings.c: New file.
1353
1354 2019-06-13  Pedro Alves  <palves@redhat.com>
1355
1356         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1357         completer.
1358         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1359         "set" completers.
1360
1361 2019-06-13  Pedro Alves  <palves@redhat.com>
1362
1363         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1364         after item.
1365
1366 2019-06-13  Pedro Alves  <palves@redhat.com>
1367
1368         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1369
1370 2019-06-13  Pedro Alves <palves@redhat.com>
1371
1372         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1373         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1374         call.
1375         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1376         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1377         calls.
1378         (check_for_argument): Skip spaces after argument.
1379
1380 2019-06-13  Pedro Alves  <palves@redhat.com>
1381
1382         * thread.c (thread_apply_command): Adjust TID parsing.
1383         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1384         detected before end of string.
1385         (tid_is_in_list): Error out if LIST is invalid.
1386
1387 2019-06-13  Pedro Alves  <palves@redhat.com>
1388
1389         * completer.c (complete_line_internal_1): Rewind completion word
1390         point.
1391         (completion_tracker::advance_custom_word_point_by): Change
1392         parameter type to int.
1393         * completer.h (completion_tracker::advance_custom_word_point_by):
1394         Likewise.
1395
1396 2019-06-13  Pedro Alves  <palves@redhat.com>
1397
1398         * completer.c (advance_to_completion_word): Handle delimiters.
1399
1400 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1401
1402         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1403
1404 2019-06-11  Tom Tromey  <tom@tromey.com>
1405
1406         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1407         (xmalloc_failed): Move to alloc.c.
1408         * alloc.c: New file.
1409         * Makefile.in (COMMON_SFILES): Add alloc.c.
1410
1411 2019-06-11  Tom Tromey  <tom@tromey.com>
1412
1413         * nat/linux-waitpid.c: Don't include server.h.
1414         (linux_debug): Remove.
1415         (my_waitpid): Update.
1416
1417 2019-06-11  Tom Tromey  <tromey@adacore.com>
1418
1419         * infcall.c (_initialize_infcall): Remove trailing newline from
1420         help.
1421         * user-regs.c (_initialize_user_regs): Remove trailing newline
1422         from help.
1423         * typeprint.c (_initialize_typeprint): Remove trailing newline
1424         from help.
1425         * reverse.c (_initialize_reverse): Remove trailing newlines from
1426         help.
1427         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1428         from help.
1429         * language.c (add_set_language_command): Remove trailing newline
1430         from help.
1431         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1432         help.
1433         * disasm.c (_initialize_disasm): Remove trailing newline from
1434         help.
1435         * top.c (init_main): Remove trailing newline from help.
1436         * interps.c (_initialize_interpreter): Remove trailing newline
1437         from help.
1438         * btrace.c (_initialize_btrace): Remove trailing newlines from
1439         help.
1440         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1441         from help.
1442         * python/python.c (_initialize_python): Remove trailing newline
1443         from help.
1444         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1445         help.
1446         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1447         from help.  Reformat some text.
1448         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1449         from help.
1450         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1451         newline from help.
1452
1453 2019-06-11  Tom Tromey  <tromey@adacore.com>
1454
1455         * darwin-nat.c (darwin_decode_exception_message)
1456         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1457
1458 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1459
1460         * valops.c (value_slice): Check for not allocated or not
1461         associated values.
1462
1463 2019-06-10  Tom de Vries  <tdevries@suse.de>
1464
1465         PR gdb/24618
1466         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1467         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1468         invalid.
1469
1470 2019-06-10  Tom de Vries  <tdevries@suse.de>
1471
1472         PR gdb/24611
1473         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1474         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1475
1476 2019-06-10  Tom de Vries  <tdevries@suse.de>
1477
1478         PR symtab/24545
1479         * symtab.c (struct demangled_name_entry): Add language field.
1480         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1481         static minimal symbol".  Set and use language field.
1482
1483 2019-06-10  Tom Tromey  <tromey@adacore.com>
1484
1485         * ada-lang.c (_initialize_ada_language): Update help text.
1486
1487 2019-06-10  Tom Tromey  <tromey@adacore.com>
1488
1489         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1490         with a newline.
1491         * guile/guile.c (handle_boot_error): Don't end warning with a
1492         newline.
1493         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1494         warning with a newline.
1495         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1496         newline.
1497         (s12z_frame_cache): Likewise.
1498         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1499         a newline.
1500         * solib-svr4.c (disable_probes_interface): Don't end warning with
1501         a newline.
1502         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1503         newline.
1504         * python/python.c (do_finish_initialization): Don't end warning
1505         with a newline.
1506
1507 2019-06-10  Tom Tromey  <tom@tromey.com>
1508
1509         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1510         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1511         gdbpy_enter.
1512
1513 2019-06-10  Tom Tromey  <tromey@adacore.com>
1514
1515         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1516         data.
1517         (elf_new_init): Don't call stabsread_new_init.
1518         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1519         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1520         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1521
1522 2019-06-10  Tom de Vries  <tdevries@suse.de>
1523
1524         PR symtab/16264
1525         PR symtab/24517
1526         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1527
1528 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1529
1530         * source.c (find_and_open_source): Also rewrite relative file
1531         names.
1532
1533 2019-04-26  Amos Bird  <amosbird@gmail.com>
1534
1535         * annotate.c (annotate_thread_exited): Add "thread-exited"
1536         annotation.
1537
1538 2019-06-06  Tom Tromey  <tromey@adacore.com>
1539
1540         * maint.h (class scoped_command_stats): Use
1541         DISABLE_COPY_AND_ASSIGN.
1542         <print_time>: New method.
1543         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1544         print_time.
1545         (scoped_command_stats::print_time): New method.
1546
1547 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1548
1549         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1550         instructions of lengths 6 or 8 bytes.
1551
1552 2019-06-04  Pedro Alves  <palves@redhat.com>
1553
1554         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1555
1556         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1557         * breakpoint.c (condition_completer): Likewise.
1558         * cli/cli-dump.c (scan_expression): Likewise.
1559         * common/filestuff.c (mkdir_recursive): Likewise.
1560         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1561         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1562         (gdb_abspath): Likewise.
1563         * compile/compile-cplus-types.c
1564         (compile_cplus_instance::decl_name): Likewise.
1565         * completer.c (complete_explicit_location):
1566         (signal_completer, reg_or_group_completer_1): Likewise.
1567         * cp-support.c (cp_remove_params_if_any): Likewise.
1568         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1569         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1570         * infcmd.c (strip_bg_char): Likewise.
1571         * linespec.c (copy_token_string): Likewise.
1572         * mi/mi-main.c (output_cores): Likewise.
1573         * psymtab.c (psymtab_search_name):
1574         * symfile.c (test_set_ext_lang_command): Likewise.
1575         * target.c (target_fileio_read_stralloc): Likewise.
1576         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1577         * value.c (complete_internalvar): Likewise.
1578
1579 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1580
1581         Add objfile property to gdb.Type.
1582         * NEWS: Mention Python API addition.
1583         * python/py-type.c (typy_get_objfile): New method.
1584
1585 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1586
1587         * NEWS: Mention the new set|show style [title|highlight].
1588         Mention changes to "show style", "help" and "apropos".
1589
1590 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1591
1592         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1593         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1594         instead of print_help_for_command.
1595         (print_doc_of_command): New function.
1596         (help_list): Add 'apropos -v word' suggestion.
1597         (print_help_for_command): Style the command name using title style.
1598         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1599         (_initialize_cli_cmds): Describe -v in apropos_command help.
1600
1601 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1602
1603         * cli/cli-style.h (cli_style_option): Add name in constructor,
1604         add m_name class member, add constructor with intensity,
1605         add name class function.
1606         (cli_style_option::add_setshow_commands): Remove name argument.
1607         (highlight_style, title_style): New styles.
1608         * cli/cli-style.c (do_show): New function that shows a style
1609         characteristic styling the style name with itself.
1610         (set_style_name): New function.
1611         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1612         Update all callers according to the changes in cli/cli-style.h.
1613         * utils.h (fputs_highlighted): New function.
1614         * utils.c (fputs_highlighted): Likewise.
1615
1616 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1617
1618         * NEWS: Mention new pipe command and new convenience variables.
1619
1620 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1621
1622         * cli/cli-cmds.c (pipe_command): New function.
1623         (_initialize_cli_cmds): Call add_com for pipe_command.
1624         Define | as an alias for pipe.
1625         (exit_status_set_internal_vars): New function.
1626         (shell_escape): Call exit_status_set_internal_vars.
1627         cli/cli-decode.c (find_command_name_length): Recognize | as
1628         a single character command.
1629
1630 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1631
1632         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1633         top.c (execute_command_to_ui_file): New function, mostly a copy
1634         of execute_command_to_string.
1635         (execute_command_to_string): Implement by calling
1636         execute_command_to_ui_file.
1637
1638 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1639
1640         * top.h (saved_command_line): Remove declaration.
1641         * top.c (previous_saved_command_line, previous_repeat_arguments):
1642         New variables.
1643         (saved_command_line): Make static, define together with other
1644         'repeat variables'.
1645         (dont_repeat): Clear repeat_arguments.
1646         (repeat_previous, get_saved_command_line, save_command_line):
1647         New functions.
1648         (gdb_init): Initialize saved_command_line
1649         and previous_saved_command_line.
1650         * main.c (captured_main_1): Remove saved_command_line initialization.
1651         * event-top.c (handle_line_of_input): Update to use
1652         the new 'repeat' related functions instead of direct access to
1653         saved_command_line.
1654         * command.h (repeat_previous, get_saved_command_line,
1655         save_command_line): New declarations.
1656         (dont_repeat): Add comment.
1657
1658 2019-05-30  Tom Tromey  <tromey@adacore.com>
1659
1660         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1661         Fix comment.
1662         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1663
1664 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1665
1666         PR cli/24587
1667         * completer.c (complete): Initialize variable word.
1668
1669 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1670
1671         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1672         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1673         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1674         'body' is NULL to the outter 'if', protecting the '!is_define'
1675         situation as well.
1676
1677 2019-05-29  Tom Tromey  <tromey@adacore.com>
1678
1679         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1680         (dwarf_unknown): New function.
1681         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1682         (dwarf_type_encoding_name): Use dwarf_unknown.
1683
1684 2019-05-29  Tom Tromey  <tromey@adacore.com>
1685
1686         PR c++/20020:
1687         * cp-valprint.c (cp_print_value_fields): Call
1688         cp_print_static_field inside "try".
1689
1690 2019-05-29  Tom Tromey  <tromey@adacore.com>
1691
1692         * inflow.c (struct terminal_info): Add default operator=.
1693         * configure: Rebuild.
1694         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1695         -Wdeprecated-copy-dtor, -Wredundant-move.
1696
1697 2019-05-29  Tom Tromey  <tromey@adacore.com>
1698
1699         * NEWS: Add entry.
1700         * infcmd.c (print_return_value_1): Handle finish_print
1701         option.
1702         (show_print_finish): New function.
1703         (_initialize_infcmd): Add "set/show print finish" commands.
1704         * valprint.c (user_print_options): Initialize new member.
1705         * valprint.h (struct value_print_options) <finish_print>: New
1706         member.
1707
1708 2019-05-28  Tom Tromey  <tromey@adacore.com>
1709
1710         * ada-lang.c (ada_remove_Xbn_suffix)
1711         (find_old_style_renaming_symbol)
1712         (parse_old_style_renaming): Remove.
1713         (ada_find_renaming_symbol): Don't call
1714         find_old_style_renaming_symbol.
1715         (ada_is_renaming_symbol): Rename from
1716         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1717         bool.  Now static.
1718         (ada_read_var_value): Update and simplify.
1719         * ada-exp.y (write_var_or_type): Remove old code.
1720
1721 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1722
1723         * event-top.c: Remove include comment.
1724         * inflow.c (class scoped_ignore_sigttou): Move from here...
1725         * inflow.h (class scoped_ignore_sigttou): ...to here.
1726         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1727         * top.c:  Remove include comment.
1728
1729 2019-05-27  Tom Tromey  <tom@tromey.com>
1730
1731         * NEWS: Fix typo.
1732
1733 2019-05-22  Tom Tromey  <tromey@adacore.com>
1734
1735         * target.c (target_follow_exec): Constify parameter.
1736         * target-delegates.c: Rebuild.
1737         * remote.c (remote_target::follow_exec): Constify parameter.
1738         * infrun.c (follow_exec): Constify parameter.
1739         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1740         (target_follow_exec): Likewise.
1741
1742 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1743
1744         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1745         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1746
1747 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1748
1749         * NEWS: Add debugredirect and testsuite sections.
1750
1751 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1752
1753         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1754         target descriptions using exclusively floating point register name
1755         aliases.
1756
1757 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1758
1759         PR gdb/18644:
1760         * f-lang.c (build_fortran_types): Handle the case where
1761         gdbarch_floatformat_for_type returns a nullptr.
1762
1763 2019-05-21  Tom de Vries  <tdevries@suse.de>
1764
1765         PR cli/24587
1766         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1767
1768 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1769
1770         PR gdb/18644:
1771         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1772         16-byte floats.
1773         * i386-tdep.c (i386_floatformat_for_type): Use
1774         floatformats_ia64_quad for the 16-byte floating point component
1775         within a fortran 32-byte complex number.
1776
1777 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1778
1779         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1780         delete default constructor.
1781         (find_partial_die): Update to return const struct.
1782         (partial_die_parent_scope): Move variable declaration into scope
1783         of its use and change its type to auto.
1784         (guess_partial_die_structure_name): Likewise.
1785         (partial_die_info::fixup): Likewise.
1786
1787 2019-05-17  Tom Tromey  <tromey@adacore.com>
1788
1789         * source.c (find_and_open_source): Remove cast.
1790
1791 2019-05-17  Tom Tromey  <tromey@adacore.com>
1792
1793         * annotate.c (annotate_source): Make "filename" const.
1794         * annotate.h (annotate_source): Use const.
1795
1796 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1797
1798         * disasm.c (set_disassembler_options): Send errors to stderr.
1799
1800 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1801
1802         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1803         (cli_interp_base::set_logging): Check debug_redirect.
1804         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1805         * cli/cli-logging.c (debug_redirect): Add static variable.
1806         (pop_output_files): Add default param.
1807         (handle_redirections): Print debug setting.
1808         (show_logging_command): Likewise.
1809         (_initialize_cli_logging): Add debugredirect command.
1810         * interps.c (current_interp_set_logging): Add debug_redirect
1811         parameter.
1812         * interps.h (set_logging): Add debug_redirect parameter.
1813         (current_interp_set_logging): Likewise.
1814         * mi/mi-common.h: Likewise.
1815         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1816
1817 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1818             Tom Tromey  <tromey@adacore.com>
1819
1820         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1821         directly.
1822         * cli/cli-interp.h (make_logging_output): Remove declaration.
1823         * cli/cli-logging.c (make_logging_output): Remove function.
1824         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1825         directly.
1826         * ui-file.c (tee_file::tee_file): Remove bools.
1827         (tee_file::~tee_file): Remove deletes.
1828         * ui-file.h (tee_file): Remove bools.
1829
1830 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1831
1832         * mi/mi-cmds.h (mi_cmd_complete): New function.
1833         * mi/mi-main.c (mi_cmd_complete): Likewise.
1834         * mi/mi-cmds.c: Define new MI command -complete.
1835         * NEWS: Mention new -complete command.
1836
1837 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1838
1839         * completer.h (complete): New function.
1840         * completer.c (complete): Likewise.
1841         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1842         function defined in completer.h.
1843
1844 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1845
1846         * MAINTAINERS (Write After Approval): Add myself.
1847
1848 2019-05-17  Tom de Vries  <tdevries@suse.de>
1849
1850         PR gdb/24094
1851         * dwarf2read.c (struct cu_partial_die_info): New struct.
1852         (find_partial_die): Return cu_partial_die_info.
1853         (partial_die_parent_scope, guess_partial_die_structure_name)
1854         (partial_die_info::fixup): Handle new return type of find_partial_die.
1855
1856 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1857
1858         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1859         "std::string", simplifying the algorithm.
1860
1861 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1862
1863         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1864         (stap_static_probe_ops::get_probes): Likewise.
1865
1866 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1867
1868         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1869         '-')" and "else if".
1870         (stap_parse_single_operand): Join checks for
1871         "gdbarch_stap_parse_special_token_p" and
1872         "gdbarch_stap_parse_special_token" in the same "if" statement.
1873         Invert check when verifying for operation on register
1874         displacement.
1875
1876 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1877
1878         * stap-probe.c (stap_get_opcode): Update comment.
1879         (stap_get_expected_argument_type): Likewise.
1880         (handle_stap_probe): Likewise.
1881
1882 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1883
1884         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1885         return type to 'bool'.  Adjust comment.  Use 'bool' when
1886         appropriate.
1887         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1888         * stap-probe.c (stap_parse_argument_1): Likewise.
1889         (stap_is_operator): Likewise.
1890         (stap_is_generic_prefix): Likewise.
1891         (stap_is_register_prefix): Likewise.
1892         (stap_is_register_indirection_prefix): Likewise.
1893         (stap_is_integer_prefix): Likewise.
1894         (stap_generic_check_suffix): Likewise.
1895         (stap_check_integer_suffix): Likewise.
1896         (stap_check_register_suffix): Likewise.
1897         (stap_check_register_indirection_suffix): Likewise.
1898         (stap_parse_register_operand): Likewise.
1899         (stap_parse_single_operand): Likewise.
1900         (stap_parse_argument_1): Likewise.
1901         (stap_probe::get_argument_count): Likewise.
1902         (stap_is_operator): Likewise.
1903
1904 2019-05-16  Tom Tromey  <tromey@adacore.com>
1905
1906         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1907         keyword to foreach.
1908
1909 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1910
1911         * linux-thread-db.c (try_thread_db_load_1): Change return type
1912         to bool.
1913         (try_thread_db_load): Likewise.
1914         (try_thread_db_load_from_pdir_1): Likewise.
1915         (try_thread_db_load_from_pdir): Likewise.
1916         (try_thread_db_load_from_sdir): Likewise.
1917         (try_thread_db_load_from_dir): Likewise.
1918         (thread_db_load_search): Likewise.
1919         (has_libpthread): Likewise.
1920         (thread_db_load): Likewise.
1921
1922 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1923
1924         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1925         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1926         NULL, and complain/return if that's the case.
1927
1928 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1929
1930         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1931         (advance, posn, abstract_read_memory): New functions.
1932         [struct mem_read_abstraction]: New struct.
1933         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1934
1935 2019-05-14  Tom Tromey  <tromey@adacore.com>
1936
1937         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1938         value is not lval_memory.
1939
1940 2019-05-14  Tom Tromey  <tromey@adacore.com>
1941
1942         * solib.c (info_sharedlibrary_command): Style the file name.
1943
1944 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1945
1946         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1947         (aarch64_vnv_type): Likewise.
1948         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1949         * common/tdesc.c: Likewise.
1950         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1951         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1952         * features/aarch64-fpu.xml: Add ieee half view.
1953         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1954         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1955         * gdbtypes.h (struct builtin_type): Likewise.
1956         (struct objfile_type): Likewise.
1957
1958 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1959
1960         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1961         typo.
1962         * location.h (string_to_event_location): Likewise.
1963
1964 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1965
1966         GDB 8.3 released.
1967
1968 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1969
1970         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1971         New variable declaration.
1972         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1973         New variable.
1974         (print_one_breakpoint): Use ui_out::test_flags and new global
1975         variable to compute use_fixed_output.
1976         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1977         Remove.
1978         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1979         (mi_multi_location_breakpoint_output_fixed): Remove.
1980         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1981         new variable.
1982         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1983         fix_multi_location_breakpoint_output flag if version >= 3.
1984         * ui-out.h (enum ui_out_flag)
1985         <fix_multi_location_breakpoint_output>: New enumerator.
1986
1987 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1988
1989         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1990
1991 2019-05-10  Tom Tromey  <tromey@adacore.com>
1992
1993         * ada-lang.c (catch_ada_completer): New function.
1994         (_initialize_ada_language): Use it.
1995
1996 2019-05-10  Tom Tromey  <tromey@adacore.com>
1997
1998         * thread.c (print_thread_info): Make "requested_threads" const.
1999         * gdbthread.h (print_thread_info): Make "requested_threads"
2000         const.
2001         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2002         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2003
2004 2019-05-08  Tom Tromey  <tom@tromey.com>
2005
2006         * gdbtypes.c (objfile_type_data): Change type.
2007         (objfile_type, _initialize_gdbtypes): Update.
2008
2009 2019-05-08  Tom Tromey  <tom@tromey.com>
2010
2011         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2012         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2013         (_initialize_dwarf2_frame): Update.
2014
2015 2019-05-08  Tom Tromey  <tom@tromey.com>
2016
2017         * objc-lang.c (objc_objfile_data): Change type.
2018         (find_methods): Update.
2019         (_initialize_objc_lang): Remove.
2020
2021 2019-05-08  Tom Tromey  <tom@tromey.com>
2022
2023         * stabsread.c (rs6000_builtin_type_data): Change type.
2024         (rs6000_builtin_type, _initialize_stabsread): Update.
2025
2026 2019-05-08  Tom Tromey  <tom@tromey.com>
2027
2028         * mips-tdep.c (mips_pdr_data): Remove.
2029         (_initialize_mips_tdep): Update.
2030
2031 2019-05-08  Tom Tromey  <tom@tromey.com>
2032
2033         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2034         (hppa_init_objfile_priv_data, read_unwind_info)
2035         (find_unwind_entry, _initialize_hppa_tdep): Update.
2036
2037 2019-05-08  Tom Tromey  <tom@tromey.com>
2038
2039         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2040         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2041         on obstack.
2042         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2043
2044 2019-05-08  Tom Tromey  <tom@tromey.com>
2045
2046         * mdebugread.c (basic_type_data): Change type.
2047         (basic_type, _initialize_mdebugread): Update.
2048
2049 2019-05-08  Tom Tromey  <tom@tromey.com>
2050
2051         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2052
2053 2019-05-08  Tom Tromey  <tom@tromey.com>
2054
2055         * nto-tdep.c (nto_inferior_data_reg): Change type.
2056         (nto_inferior_data): Update.
2057         (nto_inferior_data_cleanup, nto_new_inferior_data)
2058         (_initialize_nto_tdep): Remove.
2059         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2060
2061 2019-05-08  Tom Tromey  <tom@tromey.com>
2062
2063         * ada-lang.c (struct ada_inferior_data): Add initializers.
2064         (ada_inferior_data): Change type.
2065         (ada_inferior_data_cleanup): Remove.
2066         (get_ada_inferior_data, ada_inferior_exit)
2067         (struct ada_pspace_data): Add initializers, destructor.
2068         (ada_pspace_data_handle): Change type.
2069         (get_ada_pspace_data): Update.
2070         (ada_pspace_data_cleanup): Remove.
2071
2072 2019-05-08  Tom Tromey  <tom@tromey.com>
2073
2074         * coffread.c (struct coff_symfile_info): Add initializers.
2075         (coff_objfile_data_key): Move lower.  Change type.
2076         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2077         Update.
2078         (coff_free_info): Remove.
2079
2080 2019-05-08  Tom Tromey  <tom@tromey.com>
2081
2082         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2083         (fbsd_pspace_data_handle): Move lower.  Change type.
2084         (get_fbsd_pspace_data): Update.
2085         (fbsd_pspace_data_cleanup): Remove.
2086         (_initialize_fbsd_tdep): Update.
2087
2088 2019-05-08  Tom Tromey  <tom@tromey.com>
2089
2090         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2091         (get_ada_tasks_pspace_data): Update.
2092         (ada_tasks_pspace_data_cleanup): Remove.
2093         (_initialize_tasks): Update.
2094         (ada_tasks_inferior_data_handle): Change type.
2095         (get_ada_tasks_inferior_data): Update.
2096         (ada_tasks_inferior_data_cleanup): Remove.
2097         (struct ada_tasks_pspace_data): Add initializers.
2098
2099 2019-05-08  Tom Tromey  <tom@tromey.com>
2100
2101         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2102         * symfile-debug.c (debug_sym_get_probes): Change type.
2103         * stap-probe.c (handle_stap_probe):
2104         (stap_static_probe_ops::get_probes): Change type.
2105         * probe.h (class static_probe_ops) <get_probes>: Change type.
2106         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2107         (parse_probes_in_pspace): Update.
2108         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2109         Update.
2110         (any_static_probe_ops::get_probes): Change type.
2111         * elfread.c (elfread_data): New typedef.
2112         (probe_key): Change type.
2113         (elf_get_probes): Likewise.  Update.
2114         (probe_key_free): Remove.
2115         (_initialize_elfread): Update.
2116         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2117         Change type.
2118         (dtrace_process_dof_probe, dtrace_process_dof)
2119         (dtrace_static_probe_ops::get_probe): Change type.
2120
2121 2019-05-08  Tom Tromey  <tom@tromey.com>
2122
2123         * xcoffread.c (struct xcoff_symfile_info): Rename from
2124         coff_symfile_info.  Add initializers.
2125         (xcoff_objfile_data_key): Move lower.  Change type.
2126         (XCOFF_DATA): Rewrite.
2127         (xcoff_free_info): Remove.
2128         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2129         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2130         (xcoff_initial_scan): Update.
2131
2132 2019-05-08  Tom Tromey  <tom@tromey.com>
2133
2134         * solib-svr4.c (struct svr4_info): Add initializers and
2135         destructor.
2136         <probes_table>: Now an htab_up.
2137         (solib_svr4_pspace_data): Change type.
2138         (free_probes_table): Simplify.
2139         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2140         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2141         (probes_table_remove_objfile_probes, register_solib_event_probe)
2142         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2143         (_initialize_svr4_solib): Update.
2144
2145 2019-05-08  Tom Tromey  <tom@tromey.com>
2146
2147         * remote.c (remote_pspace_data): Change type.
2148         (remote_pspace_data_cleanup): Remove.
2149         (get_remote_exec_file, set_pspace_remote_exec_file)
2150         (_initialize_remote): Update.
2151
2152 2019-05-08  Tom Tromey  <tom@tromey.com>
2153
2154         * breakpoint.c (breakpoint_objfile_key): Change type.
2155         (get_breakpoint_objfile_data): Update.
2156         (free_breakpoint_objfile_data): Remove.
2157         (_initialize_breakpoint): Update.
2158
2159 2019-05-08  Tom Tromey  <tom@tromey.com>
2160
2161         * linux-tdep.c (struct linux_info): Add initializers.
2162         (linux_inferior_data): Move.  Change type.
2163         (invalidate_linux_cache_inf): Update.
2164         (linux_inferior_data_cleanup): Remove.
2165         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2166
2167 2019-05-08  Tom Tromey  <tom@tromey.com>
2168
2169         * auxv.c (auxv_inferior_data): Move.  Change type.
2170         (auxv_inferior_data_cleanup): Remove.
2171         (invalidate_auxv_cache_inf): Rewrite.
2172         (get_auxv_inferior_data, _initialize_auxv): Update.
2173
2174 2019-05-08  Tom Tromey  <tom@tromey.com>
2175
2176         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2177         (symfile_debug_objfile_data_key): Change type.
2178         (symfile_debug_installed, debug_qf_has_symbols)
2179         (debug_qf_find_last_source_symtab)
2180         (debug_qf_forget_cached_source_info)
2181         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2182         (debug_qf_print_stats, debug_qf_dump)
2183         (debug_qf_expand_symtabs_for_function)
2184         (debug_qf_expand_all_symtabs)
2185         (debug_qf_expand_symtabs_with_fullname)
2186         (debug_qf_map_matching_symbols)
2187         (debug_qf_expand_symtabs_matching)
2188         (debug_qf_find_pc_sect_compunit_symtab)
2189         (debug_qf_map_symbol_filenames)
2190         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2191         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2192         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2193         (debug_sym_read_linetable, debug_sym_relocate): Update.
2194         (symfile_debug_free_objfile): Remove.
2195         (install_symfile_debug_logging, _initialize_symfile_debug):
2196         Update.
2197
2198 2019-05-08  Tom Tromey  <tom@tromey.com>
2199
2200         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2201         allocate_on_obstack.
2202         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2203         (get_dwarf2_per_objfile): Update.
2204         (set_dwarf2_per_objfile): Remove.
2205         (dwarf2_has_info, dwarf2_get_section_info): Update.
2206         (dwarf2_free_objfile): Remove.
2207         (_initialize_dwarf2_read): Update.
2208
2209 2019-05-08  Tom Tromey  <tom@tromey.com>
2210
2211         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2212         initializers.
2213         <unsupported_script_warning_printed,
2214         script_not_found_warning_printed>: Now bool.
2215         (auto_load_pspace_data): Change type.
2216         (~auto_load_pspace_info): Rename from
2217         auto_load_pspace_data_cleanup.
2218         (get_auto_load_pspace_data, init_loaded_scripts_info)
2219         (clear_section_scripts, maybe_print_unsupported_script_warning)
2220         (maybe_print_script_not_found_warning, _initialize_auto_load):
2221         Update.
2222
2223 2019-05-08  Tom Tromey  <tom@tromey.com>
2224
2225         * objfiles.c (objfile_pspace_info): Add destructor and
2226         initializers.
2227         (objfiles_pspace_data): Change type.
2228         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2229         (get_objfile_pspace_data): Update.
2230         (objfiles_bfd_data): Change type.
2231         (get_objfile_bfd_data): Update.
2232         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2233
2234 2019-05-08  Tom Tromey  <tom@tromey.com>
2235
2236         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2237         Change type.
2238         (get_catch_syscall_inferior_data): Update.
2239         (catch_syscall_inferior_data_cleanup): Remove.
2240         (_initialize_break_catch_syscall): Update.
2241
2242 2019-05-08  Tom Tromey  <tom@tromey.com>
2243
2244         * inflow.c (struct terminal_info): Add destructor and
2245         initializers.
2246         (inflow_inferior_data): Change type.
2247         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2248         (get_inflow_inferior_data, inflow_inferior_exit)
2249         (swap_terminal_info, _initialize_inflow): Update.
2250
2251 2019-05-08  Tom Tromey  <tom@tromey.com>
2252
2253         * target-dcache.c (target_dcache_cleanup): Remove.
2254         (target_dcache_aspace_key): Change type.
2255         (target_dcache_init_p, target_dcache_invalidate)
2256         (target_dcache_get, target_dcache_get_or_init)
2257         (_initialize_target_dcache): Update.
2258         * dcache.h (struct dcache_deleter): New.
2259
2260 2019-05-08  Tom Tromey  <tom@tromey.com>
2261
2262         * symtab.c (struct symbol_cache): Add destructor and
2263         initializers.
2264         (symbol_cache_key): Move.  Change type.
2265         (make_symbol_cache, free_symbol_cache): Remove.
2266         (get_symbol_cache): Update.
2267         (symbol_cache_cleanup): Remove.
2268         (ALL_PSPACES, symbol_cache_flush)
2269         (maintenance_print_symbol_cache)
2270         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2271         Update.
2272
2273 2019-05-08  Tom Tromey  <tom@tromey.com>
2274
2275         * symtab.c (struct main_info): Add destructor and initializers.
2276         (main_progspace_key): Move.  Change type.
2277         (get_main_info): Update.
2278         (main_info_cleanup): Remove.
2279         (_initialize_symtab): Update.
2280
2281 2019-05-08  Tom Tromey  <tom@tromey.com>
2282
2283         * registry.h (DECLARE_REGISTRY): Define the _key class.
2284
2285 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2286
2287         * NEWS: Merge two 'New commands' sections.
2288
2289 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2290
2291         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2292         parameter and use Ada language definition instead.
2293         (ada_val_print_ptr): Remove unused language parameter.
2294         (ada_val_print_num): Remove language parameter and use Ada language
2295         definition instead.
2296         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2297         parameter.
2298         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2299         parameter and use Ada language definition instead.
2300         (ada_val_print_1): Update all ada_val_print_xxx calls.
2301         Remove language parameter.
2302         (ada_val_print): Update ada_val_print_1 call.
2303
2304 2019-05-08  Tom Tromey  <tromey@adacore.com>
2305
2306         * remote.c (remote_hw_watchpoint_limit)
2307         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2308         Now static.
2309
2310 2019-05-08  Tom Tromey  <tromey@adacore.com>
2311
2312         * maint.c (_initialize_maint_cmds): Move initialization code to
2313         remote.c.
2314         (watchdog, show_watchdog): Move to remote.c.
2315         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2316         "watchdog" static.
2317         (_initialize_remote): Move initialization code from maint.c.
2318         * defs.h (watchdog): Don't declare.
2319
2320 2019-05-08  Tom Tromey  <tromey@adacore.com>
2321
2322         * tui/tui-interp.c: Include main.h.
2323         * interps.c: Include main.h.
2324         * main.h (interpreter_p): Declare.
2325         * defs.h (interpreter_p): Don't declare.
2326
2327 2019-05-08  Tom Tromey  <tromey@adacore.com>
2328
2329         * dwarf2loc.c: Include dwarf2read.h.
2330         * defs.h (read_unsigned_leb128): Don't declare.
2331         * dwarf2read.h (read_unsigned_leb128): Declare.
2332
2333 2019-05-08  Tom Tromey  <tromey@adacore.com>
2334
2335         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2336         method.
2337
2338 2019-05-08  Tom Tromey  <tromey@adacore.com>
2339
2340         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2341         when no wrap column is set.
2342
2343 2019-05-08  Tom Tromey  <tromey@adacore.com>
2344
2345         * c-lang.c (c_get_string): Handle non-C-style arrays.
2346
2347 2019-05-08  Tom Tromey  <tromey@adacore.com>
2348
2349         * typeprint.c (print_offset_data::update): Print the bit offset,
2350         not the number of bits remaining.
2351
2352 2019-05-08  Tom Tromey  <tromey@adacore.com>
2353
2354         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2355         padding at end of comment.
2356
2357 2019-05-08  Tom Tromey  <tromey@adacore.com>
2358
2359         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2360         Compare main types.
2361
2362 2019-05-06  Tom Tromey  <tom@tromey.com>
2363
2364         * common/scoped_mmap.c: Include common-defs.h.
2365         * common/scoped_mmap.h: Don't include config.h.
2366
2367 2019-05-04  Tom Tromey  <tom@tromey.com>
2368
2369         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2370         (struct aarch64_call_info): Add initializers.
2371         <si>: Now a std::vector.
2372         (pass_on_stack, aarch64_push_dummy_call): Update.
2373
2374 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2375             Tom Tromey  <tom@tromey.com>
2376
2377         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2378         (ppc_threads): Now a std::vector.  Now static.
2379         (hwdebug_find_thread_points_by_tid)
2380         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2381         Update.
2382
2383 2019-05-04  Tom Tromey  <tom@tromey.com>
2384
2385         * arc-tdep.c (arc_tdesc_init): Return bool.
2386
2387 2019-05-04  Tom Tromey  <tom@tromey.com>
2388
2389         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2390         Use gdb_assert_not_reached.
2391
2392 2019-05-04  Tom Tromey  <tom@tromey.com>
2393
2394         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2395         "false".
2396
2397 2019-05-04  Tom Tromey  <tom@tromey.com>
2398
2399         * arc-tdep.c (arc_tdesc_init): Use bool.
2400
2401 2019-05-04  Tom Tromey  <tom@tromey.com>
2402
2403         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2404
2405 2019-05-04  Tom Tromey  <tom@tromey.com>
2406
2407         * cli/cli-cmds.c (valid_command_p): Return bool.
2408
2409 2019-05-04  Tom Tromey  <tom@tromey.com>
2410
2411         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2412         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2413
2414 2019-05-04  Raul Tambre  <raul@tambre.ee>
2415
2416         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2417         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2418         operator for comparison.
2419
2420 2019-05-04  Tom Tromey  <tom@tromey.com>
2421
2422         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2423         (lookup_partial_symbol, print_partial_symbols)
2424         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2425         (psymbol_compare): Update.
2426         (add_psymbol_to_bcache): Clear the entire psymbol.
2427         (maintenance_check_psymtabs): Update.
2428         * psympriv.h (struct partial_symbol): Don't derive from
2429         general_symbol_info.
2430         <obj_section, unrelocated_address, address,
2431         set_unrelocated_address>: Update.
2432         <ginfo>: New member.
2433         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2434         (debug_names::write_psymbols): Update.
2435
2436 2019-05-04  Tom de Vries  <tdevries@suse.de>
2437
2438         * contrib/cc-with-tweaks.sh: Support -n arg.
2439
2440 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2441
2442         * corelow.c (core_target::detach): Ensure frame cache and
2443         register caches are cleared.
2444         inferior.c (exit_inferior_1): Likewise.
2445
2446 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2447             Tom Tromey  <tom@tromey.com>
2448
2449         * dictionary.c (collate_pending_symbols_by_language): Remove
2450         "struct" from foreach.
2451         * symtab.c (lookup_global_symbol_from_objfile)
2452         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2453         foreach.
2454         * ser-tcp.c (net_open): Remove "struct" from foreach.
2455         * objfiles.c (objfile_relocate, objfile_rebase)
2456         (objfile_has_symbols): Remove "struct" from foreach.
2457         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2458         from foreach.
2459         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2460         foreach.
2461         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2462         "struct" from foreach.
2463         * ada-lang.c (create_excep_cond_exprs)
2464         (ada_exception_catchpoint_cond_string): Remove "struct" from
2465         foreach.
2466
2467 2019-05-03  Tom Tromey  <tromey@adacore.com>
2468
2469         * ada-exp.y (convert_char_literal): Check suffix of each
2470         enumerator.
2471
2472 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2473
2474         PR ada/21406:
2475         * ada-exp.y (yywrap): Don't define.
2476         * ada-lex.l (%option): Add noyywrap
2477         (yywrap): Remove.
2478
2479 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2480
2481         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2482         _WIN32_WINNT to the XP level, unless already defined to a higher
2483         level.
2484
2485         * unittests/parse-connection-spec-selftests.c:
2486         * ser-tcp.c:
2487         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2488         override.
2489
2490         * symfile.c (find_separate_debug_file): Remove colon from the
2491         drive spec of DOS/Windows file names of the target, so that the
2492         file name produced from DEBUGDIR and the target's directory will
2493         be valid on DOS/Windows systems.
2494
2495 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2496
2497         * rust-lang.c (val_print_struct): Handle printing structures
2498         containing strings.
2499
2500 2019-05-02  Tom Tromey  <tromey@adacore.com>
2501
2502         * valarith.c (_initialize_valarith): Remove.
2503
2504 2019-05-01  Tom Tromey  <tromey@adacore.com>
2505
2506         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2507         bitfields.
2508
2509 2019-05-01  Tom Tromey  <tromey@adacore.com>
2510
2511         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2512         for big-endian copies.
2513
2514 2019-04-30  Ali Tamur  <tamur@google.com>
2515         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2516         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2517         (read_3_bytes): New function.
2518
2519 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2520
2521         * windows-nat.c (main_thread_id): Delete.
2522         (handle_output_debug_string): Replace main_thread_id by
2523         current_event.dwThreadId.
2524         (fake_create_process): Likewise.
2525         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2526         Do not set main_thread_id.
2527         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2528         current_event.dwThreadId.
2529         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2530
2531 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2532
2533         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2534         Use current_event.dwThreadId instead of main_thread_id.
2535
2536 2019-04-30  Tom Tromey  <tromey@adacore.com>
2537
2538         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2539         (create_excep_cond_exprs): Iterate over program spaces.
2540         (ada_exception_catchpoint_cond_string): Examine all minimal
2541         symbols for exception types.
2542
2543 2019-04-30  Tom Tromey  <tromey@adacore.com>
2544
2545         PR c++/24470:
2546         * dwarf2read.c (process_structure_scope): Handle case where type
2547         has template parameters but no symbol was created.
2548
2549 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2550             Chris January  <chris.january@arm.com>
2551
2552         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2553         qualifier.
2554         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2555
2556 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2557
2558         * f-typeprint.c (f_print_type): Update rules for printing
2559         whitespace.
2560         (f_type_print_varspec_suffix): Likewise.
2561
2562 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2563             Chris January  <chris.january@arm.com>
2564
2565         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2566         function arguments.
2567
2568 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2569
2570         * f-lang.c (build_fortran_types): Change name of void type to
2571         lower case.
2572         * f-typeprint.c (f_type_print_base): Print the name of the void
2573         type, rather than a fixed string.
2574         * f-valprint.c (f_decorations): Use lower case void string.
2575
2576 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2577             Chris January  <chris.january@arm.com>
2578
2579         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2580         types for Fortran.
2581
2582 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2583             Chris January  <chris.january@arm.com>
2584             David Lecomber  <david.lecomber@arm.com>
2585
2586         * f-exp.y (BINOP_INTRINSIC): New token.
2587         (exp): New parser rule handling BINOP_INTRINSIC.
2588         (f77_keywords): Add new builtin procedures.
2589         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2590         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2591         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2592         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2593         (print_unop_subexp_f): New function.
2594         (print_binop_subexp_f): New function.
2595         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2596         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2597         (dump_subexp_body_f): Likewise.
2598         (operator_check_f): Likewise.
2599         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2600         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2601
2602 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2603
2604         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2605         UNOP_KIND.
2606         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2607         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2608         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2609         (operator_length_f): New fuction.
2610         (print_subexp_f): New function.
2611         (op_name_f): New function.
2612         (dump_subexp_body_f): New function.
2613         (operator_check_f): New function.
2614         (exp_descriptor_f): Replace standard expression handling functions
2615         with new functions.
2616         * gdb/fortran-operator.def: New file.
2617         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2618         * gdb/std-operator.def: Remove UNOP_KIND.
2619
2620 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2621
2622         * std-operator.def: Remove unbalanced, stray double quote
2623         character.
2624
2625 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2626             Chris January  <chris.january@arm.com>
2627             Daniel Everett  <daniel.everett@arm.com>
2628             Nick Forrington  <nick.forrington@arm.com>
2629             Richard Bunt  <richard.bunt@arm.com>
2630
2631         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2632         of depth when printing anonymous structs or unions.
2633         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2634         Don't print either the top-level value, or the children if the
2635         max-depth is exceeded.
2636         (ppscm_print_children): When printing the key of a map, allow one
2637         extra level of depth.
2638         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2639         print either the top-level value, or the children if the max-depth
2640         is exceeded.
2641         (print_children): When printing the key of a map, allow one extra
2642         level of depth.
2643         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2644         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2645         (user_print_options): Initialise max_depth field.
2646         (val_print_scalar_or_string_type_p): New function.
2647         (val_print): Check to see if the max depth has been reached.
2648         (val_print_check_max_depth): Define new function.
2649         (show_print_max_depth): New function.
2650         (_initialize_valprint): Add 'print max-depth' option.
2651         * valprint.h (struct value_print_options) <max_depth>: New field.
2652         (val_print_check_max_depth): Declare new function.
2653         * NEWS: Document new feature.
2654
2655 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2656
2657         * ada-lang.c (ada_language_defn): Initialise new field.
2658         * c-lang.c (c_is_string_type_p): New function.
2659         (c_language_defn): Initialise new field.
2660         (cplus_language_defn): Initialise new field.
2661         (asm_language_defn): Initialise new field.
2662         (minimal_language_defn): Initialise new field.
2663         * c-lang.h (c_is_string_type_p): Declare new function.
2664         * d-lang.c (d_language_defn): Initialise new field.
2665         * f-lang.c (f_is_string_type_p): New function.
2666         (f_language_defn): Initialise new field.
2667         * go-lang.c (go_is_string_type_p): New function.
2668         (go_language_defn): Initialise new field.
2669         * language.c (default_is_string_type_p): New function.
2670         (unknown_language_defn): Initialise new field.
2671         (auto_language_defn): Initialise new field.
2672         * language.h (struct language_defn) <la_is_string_type_p>: New
2673         member variable.
2674         (default_is_string_type_p): Declare new function.
2675         * m2-lang.c (m2_language_defn): Initialise new field.
2676         * objc-lang.c (objc_language_defn): Initialise new field.
2677         * opencl-lang.c (opencl_language_defn): Initialise new field.
2678         * p-lang.c (pascal_is_string_type_p): New function.
2679         (pascal_language_defn): Initialise new field.
2680         * rust-lang.c (rust_is_string_type_p): New function.
2681         (rust_language_defn): Initialise new field.
2682
2683 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2684
2685         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2686         New field.
2687         * ada-lang.c (ada_language_defn): Initialise new field.
2688         * c-lang.c (c_language_defn): Likewise.
2689         (cplus_language_defn): Likewise.
2690         (asm_language_defn): Likewise.
2691         (minimal_language_defn): Likewise.
2692         * d-lang.c (d_language_defn): Likewise.
2693         * f-lang.c (f_language_defn): Likewise.
2694         * go-lang.c (go_language_defn): Likewise.
2695         * language.c (unknown_language_defn): Likewise.
2696         (auto_language_defn): Likewise.
2697         * m2-lang.c (m2_language_defn): Likewise.
2698         * objc-lang.c (objc_language_defn): Likewise.
2699         * opencl-lang.c (opencl_language_defn): Likewise.
2700         * p-lang.c (pascal_language_defn): Likewise.
2701         * rust-lang.c (rust_language_defn): Likewise.
2702
2703 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2704
2705         * ada-lang.c (ada_is_character_type): Change return type to bool.
2706         (ada_is_string_type): Likewise.
2707         * ada-lang.h (ada_is_character_type): Update declaration
2708         (ada_is_string_type): Likewise.
2709
2710 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2711
2712         Support style in 'frame|thread apply'
2713
2714         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2715         * record.c (record_start, record_stop): Update callers of
2716         execute_command_to_string with false.
2717         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2718         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2719         methods.
2720         (class string_file): New constructor with term_out parameter.
2721         Override methods term_out and can_emit_style_escape.  New member
2722         term_out.
2723         (class stdio_file): Override can_emit_style_escape.
2724         (class tee_file): Override term_out and can_emit_style_escape.
2725         * utils.h (can_emit_style_escape): Remove.
2726         * utils.c (can_emit_style_escape): Likewise.
2727         Update all callers of can_emit_style_escape (SOMESTREAM) to
2728         SOMESTREAM->can_emit_style_escape.
2729         * source-cache.c (source_cache::get_source_lines): Likewise.
2730         * stack.c (frame_apply_command_count): Call execute_command_to_string
2731         passing the term_out characteristic of the current gdb_stdout.
2732         * thread.c (thr_try_catch_cmd): Likewise.
2733         * top.c (execute_command_to_string): pass term_out parameter
2734         to construct the string_file for the command output.
2735         * ui-file.c (term_cli_styling): New function (most code moved
2736         from utils.c can_emit_style_escape).
2737         (string_file::string_file, string_file::can_emit_style_escape,
2738         stdio_file::can_emit_style_escape, tee_file::term_out,
2739         tee_file::can_emit_style_escape): New functions.
2740
2741 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2742
2743         * NEWS: Mention the new set|show may-call-functions.
2744         * infcall.c (may_call_functions_p): New variable.
2745         (show_may_call_functions_p): New function.
2746         (call_function_by_hand_dummy): Throws an error if not
2747         may-call-functions.
2748         (_initialize_infcall): Call add_setshow_boolean_cmd for
2749         may-call-functions.
2750
2751 2019-04-25  Keith Seitz  <keiths@redhat.com>
2752
2753         PR c++/24367
2754         * cp-support.c (inspect_type): Don't attempt substitutions
2755         of symbol with the same name.
2756
2757 2019-04-25  Tom Tromey  <tromey@adacore.com>
2758
2759         PR gdb/24475:
2760         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2761         static.
2762
2763 2019-04-25  Tom Tromey  <tromey@adacore.com>
2764
2765         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2766         rvalue reference.
2767         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2768         (gdb_xml_parser::parse): Use std::move.
2769         * python/python-internal.h (gdbpy_convert_exception): Take a const
2770         reference.
2771         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2772         std::move.
2773         * python/py-utils.c (gdbpy_convert_exception): Take a const
2774         reference.
2775         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2776         Use std::move.
2777         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2778         Use std::move.
2779         * mi/mi-main.c (mi_print_exception): Take a const reference.
2780         * main.c (handle_command_errors): Take a const reference.
2781         * linespec.c (parse_linespec): Use std::move.
2782         * infcall.c (run_inferior_call): Use std::move.
2783         (call_function_by_hand_dummy): Use std::move.
2784         * exec.c (try_open_exec_file): Use std::move.
2785         * exceptions.h (exception_print, exception_fprintf)
2786         (exception_print_same): Update.
2787         * exceptions.c (print_exception, exception_print)
2788         (exception_fprintf, exception_print_same): Change parameters to
2789         const reference.
2790         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2791         * common/new-op.c: Use std::move.
2792         * common/common-exceptions.h (struct gdb_exception): Add move
2793         constructor.
2794         (struct gdb_exception_error, struct gdb_exception_quit, struct
2795         gdb_quit_bad_alloc): Change constructor to move constructor.
2796         (throw_exception): Change parameter to rvalue reference.
2797         * common/common-exceptions.c (throw_exception): Take rvalue
2798         reference.
2799         * cli/cli-interp.c (safe_execute_command): Use std::move.
2800         * breakpoint.c (insert_bp_location, location_to_sals): Use
2801         std::move.
2802
2803 2019-04-25  Tom Tromey  <tromey@adacore.com>
2804
2805         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2806         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2807         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2808         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2809         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2810         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2811         guile/scm-value.c: Use unpack.
2812         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2813         gdbscm_gdb_exception.
2814         (gdbscm_throw_gdb_exception): Likewise.
2815         (struct gdbscm_gdb_exception): New.
2816         (unpack): New function.
2817         (gdbscm_wrap): Use unpack.
2818
2819 2019-04-25  Tom Tromey  <tromey@adacore.com>
2820
2821         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2822         (gdb_rl_callback_handler): Use std::move.
2823         * common/common-exceptions.h (struct gdb_exception): Add move
2824         assignment operator.
2825         (throw_exception_sjlj): Change "exception" to const reference.
2826         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2827         (throw_exception_sjlj): Change "exception" to const reference.
2828
2829 2019-04-25  Tom Tromey  <tromey@adacore.com>
2830
2831         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2832         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2833         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2834         Update.
2835         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2836         Update.
2837         * mi/mi-interp.c (mi_interp::exec): Update.
2838         * linespec.c (parse_linespec): Update.
2839         * infcall.c (run_inferior_call): Update.
2840         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2841         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2842         (gdbscm_lookup_global_symbol): Update.
2843         * guile/scm-param.c (gdbscm_parameter_value): Update.
2844         * guile/scm-frame.c (gdbscm_frame_read_register)
2845         (gdbscm_frame_read_var): Update.
2846         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2847         * exec.c (try_open_exec_file): Update.
2848         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2849         (gdb_rl_callback_handler): Update.
2850         * common/common-exceptions.h (exception_none): Don't declare.
2851         * common/common-exceptions.c (exception_none): Don't define.
2852         (struct catcher) <exception>: Update.
2853         * cli/cli-interp.c (safe_execute_command): Update.
2854         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2855
2856 2019-04-25  Ali Tamur  <tamur@google.com>
2857
2858         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2859         (read_attribute_value): Likewise.
2860         (dwarf2_read_addr_index): Update comment.
2861         (read_str_index): Add DW_FORM_strx.
2862         (dwarf2_string_attr): Likewise.
2863         (dwarf2_const_value_attr): Likewise.
2864         (dump_die_shallow): Likewise.
2865         (dwarf2_fetch_constant_bytes): Likewise.
2866         (skip_form_bytes): Likewise.
2867         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2868
2869 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2870
2871         PR corefiles/11608
2872         PR corefiles/18187
2873         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2874         OFFSET.  Verify if current mapping contains an ELF header.
2875         (linux_find_memory_regions_full): Adjust call to
2876         dump_mapping_p.
2877
2878 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2879             Kang Li <kanglictf@gmail.com>
2880
2881         PR gdb/21600
2882
2883         * dwarf2-frame.c (read_initial_length): Be consistent about using
2884         unsigned representation of length.
2885         (decode_frame_entry_1): Likewise.  Check for wraparound of
2886         end pointer as well as buffer overflow.
2887
2888 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2889
2890         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2891         "vq".
2892
2893 2019-04-24  Tom Tromey  <tromey@adacore.com>
2894
2895         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2896
2897 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2898
2899         * s12z-tdep.c (s12z_unwind_pc): Delete.
2900         (s12z_unwind_sp): Delete.
2901         (s12z_gdbarch_init): Don't register deleted functions with
2902         gdbarch.
2903
2904 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2905
2906         * rl78-tdep.c (rl78_unwind_sp): Delete.
2907         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2908
2909 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2910
2911         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2912         (xstormy16_unwind_pc): Delete.
2913         (xstormy16_dummy_id): Delete.
2914         (xstormy16_gdbarch_init): Don't register deleted functions with
2915         gdbarch.
2916
2917 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2918
2919         * vax-tdep.c (vax_unwind_pc): Delete.
2920         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2921
2922 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2923
2924         * v850-tdep.c (v850_unwind_sp): Delete.
2925         (v850_unwind_pc): Delete.
2926         (v850_dummy_id): Delete.
2927         (v850_gdbarch_init): Don't register deleted functions with
2928         gdbarch.
2929
2930 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2931
2932         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2933         (tilegx_unwind_pc): Delete.
2934         (tilegx_unwind_dummy_id): Delete.
2935         (tilegx_gdbarch_init): Don't register deleted functions with
2936         gdbarch.
2937
2938 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2939
2940         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2941         (tic6x_dummy_id): Delete.
2942         (tic6x_gdbarch_init): Don't register deleted functions with
2943         gdbarch.
2944
2945 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2946
2947         * sparc-tdep.c (sparc_unwind_pc): Delete.
2948         (sparc32_gdbarch_init): Don't register deleted function with
2949         gdbarch.
2950
2951 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2952
2953         * sh-tdep.c (sh_unwind_sp): Delete.
2954         (sh_unwind_pc): Delete.
2955         (sh_dummy_id): Delete.
2956         (sh_gdbarch_init): Don't register deleted functions with
2957         gdbarch.
2958
2959 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2960
2961         * score-tdep.c (score_unwind_sp): Delete.
2962         (score_unwind_pc): Delete.
2963         (score_dummy_id): Delete.
2964         (score_gdbarch_init): Don't register deleted functions with
2965         gdbarch.
2966
2967 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2968
2969         * rx-tdep.c (rx_unwind_pc): Delete.
2970         (rx_unwind_sp): Delete.
2971         (rx_dummy_id): Delete.
2972         (rx_gdbarch_init): Don't register deleted functions with
2973         gdbarch.  Update comment.
2974
2975 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2976
2977         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2978         (rs6000_dummy_id): Delete.
2979         (rs6000_gdbarch_init): Don't register deleted functions with
2980         gdbarch.
2981
2982 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2983
2984         * or1k-tdep.c (or1k_dummy_id): Delete.
2985         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2986
2987 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2988
2989         * nios2-tdep.c (nios2_dummy_id): Delete.
2990         (nios2_unwind_sp): Delete.
2991         (nios2_gdbarch_init): Don't register deleted functions with
2992         gdbarch.
2993
2994 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2995
2996         * nds32-tdep.c (nds32_dummy_id): Delete.
2997         (nds32_unwind_pc): Delete.
2998         (nds32_unwind_sp): Delete.
2999         (nds32_gdbarch_init): Don't register deleted functions with
3000         gdbarch.
3001
3002 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3003
3004         * msp430-tdep.c (msp430_unwind_pc): Delete.
3005         (msp430_unwind_sp): Delete.
3006         (msp430_dummy_id): Delete.
3007         (msp430_gdbarch_init): Don't register deleted functions with
3008         gdbarch.
3009
3010 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3011
3012         * moxie-tdep.c (moxie_unwind_sp): Delete.
3013         (moxie_unwind_pc): Delete.
3014         (moxie_dummy_id): Delete.
3015         (moxie_gdbarch_init): Don't register deleted functions with
3016         gdbarch.
3017
3018 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3019
3020         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3021         (mn10300_unwind_pc): Delete.
3022         (mn10300_unwind_sp): Delete.
3023         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3024         mn10300_unwind_sp.
3025         (mn10300_frame_unwind_init): Don't register deleted functions with
3026         gdbarch.
3027
3028 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3029
3030         * mep-tdep.c (mep_unwind_pc): Delete.
3031         (mep_unwind_sp): Delete.
3032         (mep_dummy_id): Delete.
3033         (mep_gdbarch_init): Don't register deleted functions with
3034         gdbarch.
3035
3036 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3037
3038         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3039         (m68hc11_unwind_sp): Delete.
3040         (m68hc11_gdbarch_init): Don't register deleted functions with
3041         gdbarch.
3042
3043 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3044
3045         * m32r-tdep.c (m32r_unwind_sp): Delete.
3046         (m32r_unwind_pc): Delete.
3047         (m32r_dummy_id): Delete.
3048         (m32r_gdbarch_init): Don't register deleted functions with
3049         gdbarch.
3050
3051 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3052
3053         * m32c-tdep.c (m32c_unwind_pc): Delete.
3054         (m32c_unwind_sp): Delete.
3055         (m32c_dummy_id): Delete.
3056         (m32c_gdbarch_init): Don't register deleted functions with
3057         gdbarch.
3058
3059 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3060
3061         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3062         (lm32_unwind_pc): Delete.
3063         (lm32_dummy_id): Delete.
3064         (lm32_gdbarch_init): Don't register deleted functions with
3065         gdbarch.
3066
3067 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3068
3069         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3070         (iq2000_unwind_pc): Delete.
3071         (iq2000_dummy_id): Delete.
3072         (iq2000_gdbarch_init): Don't register deleted functions with
3073         gdbarch.
3074
3075 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3076
3077         * nds32-tdep.c (nds32_type_align): Delete.
3078         (nds32_push_dummy_call): Use type_align instead.
3079
3080 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3081
3082         * arm-tdep.c (arm_type_align): Only handle vector override case.
3083         (arm_push_dummy_call): Use type_align.
3084         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3085
3086 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3087
3088         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3089         case.
3090         (pass_on_stack): Use type_align.
3091         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3092         function.
3093
3094 2019-04-23  Tom Tromey  <tromey@adacore.com>
3095
3096         * dwarf2read.c (line_header::file_name_at): Remove unused
3097         overload.
3098
3099 2019-04-23  Tom de Vries  <tdevries@suse.de>
3100
3101         PR gdb/24438
3102         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3103         invocation.
3104
3105
3106 2019-03-27  Ali Tamur  <tamur@google.com>
3107
3108         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3109         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3110         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3111         (dwarf_expr_context::get_addr_index): Likewise
3112         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3113         (symbol_needs_eval_context::get_addr_index): Likewise
3114         (disassemble_dwarf_expression): Add DW_OP_addrx
3115         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3116         (read_cutu_die_from_dwo): Update comment
3117         (skip_one_die): Add DW_FORM_addrx
3118         (read_attribute_value): Likewise
3119         (var_decode_location): Add DW_OP_addrx
3120         (dwarf2_const_value_attr): Add DW_FORM_addrx
3121         (dump_die_shallow): Likewise
3122         (dwarf2_fetch_constant_bytes): Likewise
3123         (decode_locdesc): Add DW_OP_addrx
3124         (skip_form_bytes): Add DW_FORM_addrx
3125
3126 2019-04-22  Ali Tamur  <tamur@google.com>
3127
3128         * MAINTAINERS (Write After Approval): Add self.
3129
3130 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3131
3132         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3133         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3134         (open_symbol_file_object): Likewise.
3135         (svr4_default_sos): Add info parameter.
3136         (svr4_read_so_list): Likewise.
3137         (svr4_current_sos_direct): Adjust functions calls to pass down
3138         info.
3139         (svr4_current_sos_1): Add info parameter.
3140         (svr4_current_sos): Call get_svr4_info, pass info down to
3141         svr4_current_sos_1.
3142         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3143         get_svr4_info.
3144         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3145         get_svr4_info.
3146         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3147         to get_svr4_info.
3148         (probes_table_remove_objfile_probes): Likewise.
3149         (register_solib_event_probe): Add info parameter.
3150         (solist_update_incremental): Pass info parameter down to
3151         svr4_read_so_list.
3152         (disable_probes_interface): Add info parameter.
3153         (svr4_handle_solib_event): Pass current_program_space to
3154         get_svr4_info.  Adjust disable_probes_interface cleanup.
3155         (svr4_create_probe_breakpoints): Add info parameter, pass it
3156         down to register_solib_event_probe.
3157         (svr4_create_solib_event_breakpoints): Add info parameter,
3158         pass it down to svr4_create_probe_breakpoints.
3159         (enable_break): Pass info down to
3160         svr4_create_solib_event_breakpoints.
3161         (svr4_solib_create_inferior_hook): Pass current_program_space to
3162         get_svr4_info.
3163         (svr4_clear_solib): Likewise.
3164
3165 2019-04-22  Pedro Alves  <palves@redhat.com>
3166
3167         * solib-svr4.c (svr4_free_objfile_observer): New.
3168         (probe_and_action::objfile): New field.
3169         (probes_table_htab_remove_objfile_probes)
3170         (probes_table_remove_objfile_probes): New functions.
3171         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3172         in the new probe_and_action.  Don't store the probe in 'lookup'.
3173         (svr4_create_probe_breakpoints): Pass objfile to
3174         register_solib_event_probe.
3175         (_initialize_svr4_solib): Register a free_objfile observer.
3176
3177 2019-04-19  Tom Tromey  <tom@tromey.com>
3178
3179         * common/queue.h: Remove.
3180
3181 2019-04-19  Tom Tromey  <tom@tromey.com>
3182
3183         * event-loop.c: Don't include "common/queue.h".
3184
3185 2019-04-19  Tom Tromey  <tom@tromey.com>
3186
3187         * remote.c (remote_target): Use delete.
3188         * remote-notif.h: Include <list>, not "common/queue.h".
3189         (notif_client_p): Remove typedef.
3190         (remote_notif_state): Add constructor, destructor, initializer.
3191         <notif_queue>: Now a std::list.
3192         (remote_notif_state_xfree): Don't declare.
3193         * remote-notif.c (remote_notif_process, handle_notification)
3194         (remote_notif_state_allocate): Update.
3195         (~remote_notif_state): Rename from remote_notif_state_xfree.
3196
3197 2019-04-19  Tom Tromey  <tom@tromey.com>
3198
3199         * symfile.c (reread_symbols): Update.
3200         * objfiles.c (objfile_register_static_link)
3201         (objfile_lookup_static_link): Update
3202         (~objfile) Don't delete static_links.
3203         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3204
3205 2019-04-19  Tom Tromey  <tom@tromey.com>
3206
3207         * type-stack.h (struct type_stack) <insert>: Constify string.
3208         * type-stack.c (type_stack::insert): Constify string.
3209         * gdbtypes.h (lookup_template_type): Update.
3210         (address_space_name_to_int): Update.
3211         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3212         const.
3213         (lookup_template_type): Make name const.
3214         * c-exp.y: Update rules.
3215         (lex_one_token, classify_name, classify_inner_name)
3216         (c_print_token): Update.
3217         * p-exp.y: Update rules.
3218         (yylex): Update.
3219         * f-exp.y: Update rules.
3220         (yylex): Update.
3221         * d-exp.y: Update rules.
3222         (lex_one_token, classify_name, classify_inner_name): Update.
3223         * parse.c (write_dollar_variable, copy_name): Return std::string.
3224         * parser-defs.h (copy_name): Change return type.
3225         * m2-exp.y: Update rules.
3226         (yylex): Update.
3227         * go-exp.y (lex_one_token): Update.
3228         Update rules.
3229         (classify_unsafe_function, classify_packaged_name)
3230         (classify_name, yylex): Update.
3231
3232 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3233
3234         * configure.ac: add --enable-source-highlight switch.
3235         * configure: Regenerate.
3236         * top.c (print_gdb_version): plumb --enable-source-highlight
3237         status to "show configuration".
3238
3239 2019-04-19  Tom Tromey  <tromey@adacore.com>
3240
3241         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3242         Check ADA_TYPE_P.
3243         (empty_record, ada_template_to_fixed_record_type_1)
3244         (template_to_static_fixed_type)
3245         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3246         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3247         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3248         macros.
3249
3250 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3251
3252         PR symtab/24423:
3253         * source.c (print_source_lines_base): Advance "iter" when a
3254         control character is seen.
3255
3256 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3257
3258         * inferior.h (struct infcall_suspend_state_deleter):
3259         Catch exception in destructor to avoid crash.
3260
3261 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3262
3263         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3264         close to the add_com "shell".
3265
3266 2019-04-18  Tom Tromey  <tromey@adacore.com>
3267
3268         * process-stratum-target.h (class process_stratum_target)
3269         <stratum>: Add "final".
3270
3271 2019-04-17  Tom Tromey  <tromey@adacore.com>
3272
3273         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3274         against nullptr before use.
3275
3276 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3277
3278         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3279
3280 2019-04-17  Jim Wilson  <jimw@sifive.com>
3281             Andrew Burgess  <andrew.burgess@embecosm.com>
3282
3283         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3284         code read might fail, assume 4-byte breakpoint in that case.
3285
3286 2019-04-15  Leszek Swirski  <leszeks@google.com>
3287
3288         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3289         rather than a hand-rolled POD check when checking for forced MEMORY
3290         classification.
3291
3292 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3293
3294         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3295         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3296         function.
3297         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3298         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3299         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3300         declaration.
3301
3302 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3303
3304         * aarch64-linux-nat.c
3305         (aarch64_linux_nat_target::thread_architecture): Add override.
3306         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3307         each VQ.
3308
3309 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3310
3311         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3312
3313 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3314
3315         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3316         target types of size 96-bits, add some additional comments, and
3317         check that the builtin type we found was the correct size.
3318
3319 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3320
3321         * utils.c (prompt_for_continue): Don't restore the styling at the
3322         end, as applied_style has the wrong value.  This fixes styling in
3323         long lists of file names that are interrupted by the "Continue?"
3324         prompt.
3325
3326 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3327
3328         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3329         * c-lang.c (c_language_defn): Likewise.
3330         (cplus_language_defn): Likewise.
3331         (asm_language_defn): Likewise.
3332         (minimal_language_defn): Likewise.
3333         * d-lang.c (d_language_defn): Likewise.
3334         * f-lang.c (f_language_defn): Likewise.
3335         * go-lang.c (go_language_defn): Likewise.
3336         * language.c (unknown_language_defn): Likewise.
3337         (auto_language_defn): Likewise.
3338         * language.h (struct language_defn): Remove la_magic field.
3339         (LANG_MAGIC): Delete.
3340         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3341         * objc-lang.c (objc_language_defn): Likewise.
3342         * opencl-lang.c (opencl_language_defn): Likewise.
3343         * p-lang.c (pascal_language_defn): Likewise.
3344         * rust-lang.c (rust_language_defn): Likewise.
3345
3346 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3347
3348         * riscv-tdep.c (riscv_type_align): New function.
3349         (riscv_type_alignment): Delete.
3350         (riscv_arg_location): Use 'type_align'.
3351         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3352
3353 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3354
3355         * gdbtypes.c (type_align): A struct with no non-static fields also
3356         has alignment of 1.
3357
3358 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3359
3360         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3361         component to 0.
3362         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3363         member.
3364         (riscv_struct_info::analyse): New implementation using new
3365         analyse_inner member function.
3366         (riscv_struct_info::field_offset): New member function.
3367         (riscv_struct_info::m_offsets): New member variable.
3368         (riscv_struct_info::analyse_inner): New private member function,
3369         takes the old implementation of riscv_struct_info::analyse but
3370         extended to track field offsets.
3371         (riscv_call_arg_struct): Update the struct folding special cases
3372         to handle cases where empty C++ structs, which are non-zero
3373         length, are found.
3374         (riscv_arg_location): Initialise the length of each location, a
3375         non-zero length now indicates the location is in use.
3376         (riscv_push_dummy_call): Allow for the first location having a
3377         non-zero offset when setting up arguments.
3378         (riscv_return_value): Likewise, but for return values.
3379
3380 2019-04-11  Tom Tromey  <tromey@adacore.com>
3381
3382         * utils.c (internal_vproblem): Make "msg" const.
3383
3384 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3385
3386         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3387         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3388         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3389         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3390
3391 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3392
3393         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3394         function.
3395         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3396         of amd64_collect_native_gregset.
3397         (amd64_linux_nat_target::store_registers): Likewise.
3398
3399 2019-04-10  Tom Tromey  <tom@tromey.com>
3400
3401         * symtab.c (lookup_global_symbol_from_objfile)
3402         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3403         * objfiles.h (class separate_debug_iterator): New.
3404         (class separate_debug_range): New.
3405         (struct objfile) <separate_debug_objfiles>: New method.
3406         (objfile_separate_debug_iterate): Don't declare.
3407         * objfiles.c (separate_debug_iterator::operator++): Rename from
3408         objfile_separate_debug_iterate.
3409         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3410         iterator.
3411         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3412         iterator.
3413
3414 2019-04-10  Tom Tromey  <tom@tromey.com>
3415
3416         * symfile.c (reread_symbols): Remove old comment.
3417         * objfiles.c (free_all_objfiles): Fix a typo.
3418
3419 2019-04-10  Tom Tromey  <tom@tromey.com>
3420
3421         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3422         * minsyms.c (lookup_minimal_symbol): Use foreach.
3423         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3424         (lookup_minimal_symbol_solib_trampoline): Likewise.
3425         * symfile.c (reread_symbols): Use foreach.
3426
3427 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3428             Tom Tromey  <tromey@adacore.com>
3429
3430         PR rust/24414:
3431         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3432         (rust_lex_int_test): Change "value" to be LONGEST.
3433         (rust_lex_tests): Add test for long integer literal.
3434
3435 2019-04-09  Tom Tromey  <tromey@adacore.com>
3436
3437         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3438         to bool.
3439         (extended_remote_target::attach): Update.
3440         (remote_target::remote_notice_new_inferior): Update.
3441         (remote_target::add_current_inferior_and_thread): Update.
3442         * inferior.c (exit_inferior_1): Use "false".
3443         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3444
3445 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3446
3447         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3448         the "start" command.
3449
3450 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3451
3452         * python/py-inferior.c (infpy_thread_from_thread_handle):
3453         Adjust comments to reflect renaming of thread_from_thread_handle
3454         to thread_from_handle.  Adjust keywords.  Fix type error message.
3455         (inferior_object_methods): Add thread_from_handle.  Retain
3456         thread_from_thread_handle, but mark it as deprecated.
3457
3458 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3459
3460         * gdbthread.h (find_thread_by_handle): Revise declaration.
3461         * thread.c (find_thread_by_handle): Likewise.  Adjust
3462         implementation too.
3463         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3464         support for buffer objects as handles.
3465
3466 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3467
3468         * python/py-infthread.c (thpy_thread_handle): New function.
3469         (thread_object_methods): Register thpy_thread_handle.
3470
3471 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3472
3473         * gdbthread.h (thread_to_thread_handle): Declare.
3474         * thread.c (gdbtypes.h): Include.
3475         (thread_to_thread_handle): New function.
3476
3477         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3478         (target_thread_info_to_thread_handle): Declare.
3479         * target.c (target_thread_info_to_thread_handle): New function.
3480         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3481         * target-delegates.c: Regenerate.
3482
3483         * linux-thread-db.c (class thread_db_target): Add method
3484         thread_info_to_thread_handle.
3485         (thread_db_target::thread_info_to_thread_handle): Define.
3486         * remote.c (class remote_target): Add new method
3487         thread_info_to_thread_handle.
3488         (remote_target::thread_info_to_thread_handle): Define.
3489
3490 2019-04-08  Pedro Alves  <palves@redhat.com>
3491
3492         * common/common-exceptions.c (throw_exception): Don't create
3493         named object to throw; throw directly.
3494         (throw_it): Likewise.  Don't initialize gdb_exception::message
3495         here, with new; pass FMT and AP to the ctor instead.
3496         * common/common-exceptions.h: Include <string>.
3497         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3498         const char *, va_list)): New ctor.  Use std::make_shared.
3499         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3500         errors)): Delete.
3501         (gdb_exception_error::gdb_exception_error(enum errors, const char
3502         *, va_list)): New.
3503         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3504         Add assertion.
3505         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3506         errors)): Delete.
3507         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3508         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3509         Add assertion.
3510
3511 2019-04-08  Tom Tromey  <tom@tromey.com>
3512
3513         * valops.c (value_rtti_indirect_type): Replace throw_exception
3514         with throw.
3515         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3516         with throw.
3517         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3518         throw.
3519         * target.c (target_translate_tls_address): Replace throw_exception
3520         with throw.
3521         * stack.c (frame_apply_command_count): Replace throw_exception
3522         with throw.
3523         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3524         throw.
3525         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3526         with throw.
3527         * rs6000-tdep.c (rs6000_frame_cache)
3528         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3529         * remote.c: Replace throw_exception with throw.
3530         * record-full.c (record_full_message, record_full_wait_1)
3531         (record_full_restore): Replace throw_exception with throw.
3532         * record-btrace.c:
3533         (get_thread_current_frame_id, record_btrace_start_replaying)
3534         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3535         (cmd_record_btrace_start): Replace throw_exception with throw.
3536         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3537         throw.
3538         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3539         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3540         * linespec.c:
3541         (find_linespec_symbols): Replace throw_exception with throw.
3542         * infrun.c (displaced_step_prepare, resume): Replace
3543         throw_exception with throw.
3544         * infcmd.c (post_create_inferior): Replace throw_exception with
3545         throw.
3546         * inf-loop.c (inferior_event_handler): Replace throw_exception
3547         with throw.
3548         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3549         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3550         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3551         (get_prev_frame_always, get_frame_pc_if_available)
3552         (get_frame_address_in_block_if_available, get_frame_language):
3553         Replace throw_exception with throw.
3554         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3555         throw_exception with throw.
3556         * eval.c (fetch_subexp_value, evaluate_var_value)
3557         (evaluate_funcall, evaluate_subexp_standard): Replace
3558         throw_exception with throw.
3559         * dwarf2loc.c (call_site_find_chain)
3560         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3561         Replace throw_exception with throw.
3562         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3563         with throw.
3564         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3565         throw.
3566         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3567         * completer.c (complete_line_internal): Replace throw_exception
3568         with throw.
3569         * compile/compile-object-run.c (compile_object_run): Replace
3570         throw_exception with throw.
3571         * cli/cli-script.c (process_next_line): Replace throw_exception
3572         with throw.
3573         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3574         (btrace_enable, btrace_maint_update_pt_packets): Replace
3575         throw_exception with throw.
3576         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3577         throw_exception with throw.
3578         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3579         throw_exception with throw.
3580         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3581         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3582         * aarch64-tdep.c (aarch64_make_prologue_cache)
3583         (aarch64_make_stub_cache): Replace throw_exception with throw.
3584
3585 2019-04-08  Tom Tromey  <tom@tromey.com>
3586
3587         * common/common-exceptions.c (throw_exception): Rename from
3588         throw_exception_cxx.  Remove old copy.  Make argument const.
3589         (throw_it): Create and throw exception objects directly.
3590         * common/common-exceptions.h (throw_exception): Make argument
3591         const.
3592         (struct gdb_exception_error): Add constructor.
3593         (struct gdb_exception_quit): Add constructor.
3594
3595 2019-04-08  Tom Tromey  <tom@tromey.com>
3596
3597         * common/common-exceptions.h (exception_rethrow): Don't declare.
3598         (TRY_SJLJ): Update comment.
3599         (TRY, CATCH, END_CATCH): Remove.
3600         * common/common-exceptions.c (exception_rethrow): Remove.
3601
3602 2019-04-08  Tom Tromey  <tom@tromey.com>
3603
3604         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3605         Remove.
3606         (gdb_exception_error): Rename from
3607         gdb_exception_RETURN_MASK_ERROR.
3608         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3609         (gdb_quit_bad_alloc): Update.
3610         * aarch64-tdep.c: Update.
3611         * ada-lang.c: Update.
3612         * ada-typeprint.c: Update.
3613         * ada-valprint.c: Update.
3614         * amd64-tdep.c: Update.
3615         * arch-utils.c: Update.
3616         * break-catch-throw.c: Update.
3617         * breakpoint.c: Update.
3618         * btrace.c: Update.
3619         * c-varobj.c: Update.
3620         * cli/cli-cmds.c: Update.
3621         * cli/cli-interp.c: Update.
3622         * cli/cli-script.c: Update.
3623         * common/common-exceptions.c: Update.
3624         * common/new-op.c: Update.
3625         * common/selftest.c: Update.
3626         * compile/compile-c-symbols.c: Update.
3627         * compile/compile-cplus-symbols.c: Update.
3628         * compile/compile-object-load.c: Update.
3629         * compile/compile-object-run.c: Update.
3630         * completer.c: Update.
3631         * corelow.c: Update.
3632         * cp-abi.c: Update.
3633         * cp-support.c: Update.
3634         * cp-valprint.c: Update.
3635         * darwin-nat.c: Update.
3636         * disasm-selftests.c: Update.
3637         * dtrace-probe.c: Update.
3638         * dwarf-index-cache.c: Update.
3639         * dwarf-index-write.c: Update.
3640         * dwarf2-frame-tailcall.c: Update.
3641         * dwarf2-frame.c: Update.
3642         * dwarf2loc.c: Update.
3643         * dwarf2read.c: Update.
3644         * eval.c: Update.
3645         * event-loop.c: Update.
3646         * event-top.c: Update.
3647         * exec.c: Update.
3648         * f-valprint.c: Update.
3649         * fbsd-tdep.c: Update.
3650         * frame-unwind.c: Update.
3651         * frame.c: Update.
3652         * gdbtypes.c: Update.
3653         * gnu-v3-abi.c: Update.
3654         * guile/guile-internal.h: Update.
3655         * guile/scm-block.c: Update.
3656         * guile/scm-breakpoint.c: Update.
3657         * guile/scm-cmd.c: Update.
3658         * guile/scm-disasm.c: Update.
3659         * guile/scm-frame.c: Update.
3660         * guile/scm-lazy-string.c: Update.
3661         * guile/scm-math.c: Update.
3662         * guile/scm-param.c: Update.
3663         * guile/scm-ports.c: Update.
3664         * guile/scm-pretty-print.c: Update.
3665         * guile/scm-symbol.c: Update.
3666         * guile/scm-symtab.c: Update.
3667         * guile/scm-type.c: Update.
3668         * guile/scm-value.c: Update.
3669         * i386-linux-tdep.c: Update.
3670         * i386-tdep.c: Update.
3671         * inf-loop.c: Update.
3672         * infcall.c: Update.
3673         * infcmd.c: Update.
3674         * infrun.c: Update.
3675         * jit.c: Update.
3676         * language.c: Update.
3677         * linespec.c: Update.
3678         * linux-fork.c: Update.
3679         * linux-nat.c: Update.
3680         * linux-tdep.c: Update.
3681         * linux-thread-db.c: Update.
3682         * main.c: Update.
3683         * mi/mi-cmd-break.c: Update.
3684         * mi/mi-cmd-stack.c: Update.
3685         * mi/mi-interp.c: Update.
3686         * mi/mi-main.c: Update.
3687         * objc-lang.c: Update.
3688         * p-valprint.c: Update.
3689         * parse.c: Update.
3690         * ppc-linux-tdep.c: Update.
3691         * printcmd.c: Update.
3692         * python/py-arch.c: Update.
3693         * python/py-breakpoint.c: Update.
3694         * python/py-cmd.c: Update.
3695         * python/py-finishbreakpoint.c: Update.
3696         * python/py-frame.c: Update.
3697         * python/py-framefilter.c: Update.
3698         * python/py-gdb-readline.c: Update.
3699         * python/py-inferior.c: Update.
3700         * python/py-infthread.c: Update.
3701         * python/py-lazy-string.c: Update.
3702         * python/py-linetable.c: Update.
3703         * python/py-objfile.c: Update.
3704         * python/py-param.c: Update.
3705         * python/py-prettyprint.c: Update.
3706         * python/py-progspace.c: Update.
3707         * python/py-record-btrace.c: Update.
3708         * python/py-record.c: Update.
3709         * python/py-symbol.c: Update.
3710         * python/py-type.c: Update.
3711         * python/py-unwind.c: Update.
3712         * python/py-utils.c: Update.
3713         * python/py-value.c: Update.
3714         * python/python.c: Update.
3715         * record-btrace.c: Update.
3716         * record-full.c: Update.
3717         * remote-fileio.c: Update.
3718         * remote.c: Update.
3719         * riscv-tdep.c: Update.
3720         * rs6000-aix-tdep.c: Update.
3721         * rs6000-tdep.c: Update.
3722         * rust-exp.y: Update.
3723         * rust-lang.c: Update.
3724         * s390-tdep.c: Update.
3725         * selftest-arch.c: Update.
3726         * solib-dsbt.c: Update.
3727         * solib-frv.c: Update.
3728         * solib-spu.c: Update.
3729         * solib-svr4.c: Update.
3730         * solib.c: Update.
3731         * sparc64-linux-tdep.c: Update.
3732         * stack.c: Update.
3733         * symfile-mem.c: Update.
3734         * symmisc.c: Update.
3735         * target.c: Update.
3736         * thread.c: Update.
3737         * top.c: Update.
3738         * tracefile-tfile.c: Update.
3739         * tui/tui.c: Update.
3740         * typeprint.c: Update.
3741         * unittests/cli-utils-selftests.c: Update.
3742         * unittests/parse-connection-spec-selftests.c: Update.
3743         * valops.c: Update.
3744         * valprint.c: Update.
3745         * value.c: Update.
3746         * varobj.c: Update.
3747         * windows-nat.c: Update.
3748         * x86-linux-nat.c: Update.
3749         * xml-support.c: Update.
3750
3751 2019-04-08  Tom Tromey  <tom@tromey.com>
3752
3753         * xml-support.c: Use C++ exception handling.
3754         * x86-linux-nat.c: Use C++ exception handling.
3755         * windows-nat.c: Use C++ exception handling.
3756         * varobj.c: Use C++ exception handling.
3757         * value.c: Use C++ exception handling.
3758         * valprint.c: Use C++ exception handling.
3759         * valops.c: Use C++ exception handling.
3760         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3761         handling.
3762         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3763         * typeprint.c: Use C++ exception handling.
3764         * tui/tui.c: Use C++ exception handling.
3765         * tracefile-tfile.c: Use C++ exception handling.
3766         * top.c: Use C++ exception handling.
3767         * thread.c: Use C++ exception handling.
3768         * target.c: Use C++ exception handling.
3769         * symmisc.c: Use C++ exception handling.
3770         * symfile-mem.c: Use C++ exception handling.
3771         * stack.c: Use C++ exception handling.
3772         * sparc64-linux-tdep.c: Use C++ exception handling.
3773         * solib.c: Use C++ exception handling.
3774         * solib-svr4.c: Use C++ exception handling.
3775         * solib-spu.c: Use C++ exception handling.
3776         * solib-frv.c: Use C++ exception handling.
3777         * solib-dsbt.c: Use C++ exception handling.
3778         * selftest-arch.c: Use C++ exception handling.
3779         * s390-tdep.c: Use C++ exception handling.
3780         * rust-lang.c: Use C++ exception handling.
3781         * rust-exp.y: Use C++ exception handling.
3782         * rs6000-tdep.c: Use C++ exception handling.
3783         * rs6000-aix-tdep.c: Use C++ exception handling.
3784         * riscv-tdep.c: Use C++ exception handling.
3785         * remote.c: Use C++ exception handling.
3786         * remote-fileio.c: Use C++ exception handling.
3787         * record-full.c: Use C++ exception handling.
3788         * record-btrace.c: Use C++ exception handling.
3789         * python/python.c: Use C++ exception handling.
3790         * python/py-value.c: Use C++ exception handling.
3791         * python/py-utils.c: Use C++ exception handling.
3792         * python/py-unwind.c: Use C++ exception handling.
3793         * python/py-type.c: Use C++ exception handling.
3794         * python/py-symbol.c: Use C++ exception handling.
3795         * python/py-record.c: Use C++ exception handling.
3796         * python/py-record-btrace.c: Use C++ exception handling.
3797         * python/py-progspace.c: Use C++ exception handling.
3798         * python/py-prettyprint.c: Use C++ exception handling.
3799         * python/py-param.c: Use C++ exception handling.
3800         * python/py-objfile.c: Use C++ exception handling.
3801         * python/py-linetable.c: Use C++ exception handling.
3802         * python/py-lazy-string.c: Use C++ exception handling.
3803         * python/py-infthread.c: Use C++ exception handling.
3804         * python/py-inferior.c: Use C++ exception handling.
3805         * python/py-gdb-readline.c: Use C++ exception handling.
3806         * python/py-framefilter.c: Use C++ exception handling.
3807         * python/py-frame.c: Use C++ exception handling.
3808         * python/py-finishbreakpoint.c: Use C++ exception handling.
3809         * python/py-cmd.c: Use C++ exception handling.
3810         * python/py-breakpoint.c: Use C++ exception handling.
3811         * python/py-arch.c: Use C++ exception handling.
3812         * printcmd.c: Use C++ exception handling.
3813         * ppc-linux-tdep.c: Use C++ exception handling.
3814         * parse.c: Use C++ exception handling.
3815         * p-valprint.c: Use C++ exception handling.
3816         * objc-lang.c: Use C++ exception handling.
3817         * mi/mi-main.c: Use C++ exception handling.
3818         * mi/mi-interp.c: Use C++ exception handling.
3819         * mi/mi-cmd-stack.c: Use C++ exception handling.
3820         * mi/mi-cmd-break.c: Use C++ exception handling.
3821         * main.c: Use C++ exception handling.
3822         * linux-thread-db.c: Use C++ exception handling.
3823         * linux-tdep.c: Use C++ exception handling.
3824         * linux-nat.c: Use C++ exception handling.
3825         * linux-fork.c: Use C++ exception handling.
3826         * linespec.c: Use C++ exception handling.
3827         * language.c: Use C++ exception handling.
3828         * jit.c: Use C++ exception handling.
3829         * infrun.c: Use C++ exception handling.
3830         * infcmd.c: Use C++ exception handling.
3831         * infcall.c: Use C++ exception handling.
3832         * inf-loop.c: Use C++ exception handling.
3833         * i386-tdep.c: Use C++ exception handling.
3834         * i386-linux-tdep.c: Use C++ exception handling.
3835         * guile/scm-value.c: Use C++ exception handling.
3836         * guile/scm-type.c: Use C++ exception handling.
3837         * guile/scm-symtab.c: Use C++ exception handling.
3838         * guile/scm-symbol.c: Use C++ exception handling.
3839         * guile/scm-pretty-print.c: Use C++ exception handling.
3840         * guile/scm-ports.c: Use C++ exception handling.
3841         * guile/scm-param.c: Use C++ exception handling.
3842         * guile/scm-math.c: Use C++ exception handling.
3843         * guile/scm-lazy-string.c: Use C++ exception handling.
3844         * guile/scm-frame.c: Use C++ exception handling.
3845         * guile/scm-disasm.c: Use C++ exception handling.
3846         * guile/scm-cmd.c: Use C++ exception handling.
3847         * guile/scm-breakpoint.c: Use C++ exception handling.
3848         * guile/scm-block.c: Use C++ exception handling.
3849         * guile/guile-internal.h: Use C++ exception handling.
3850         * gnu-v3-abi.c: Use C++ exception handling.
3851         * gdbtypes.c: Use C++ exception handling.
3852         * frame.c: Use C++ exception handling.
3853         * frame-unwind.c: Use C++ exception handling.
3854         * fbsd-tdep.c: Use C++ exception handling.
3855         * f-valprint.c: Use C++ exception handling.
3856         * exec.c: Use C++ exception handling.
3857         * event-top.c: Use C++ exception handling.
3858         * event-loop.c: Use C++ exception handling.
3859         * eval.c: Use C++ exception handling.
3860         * dwarf2read.c: Use C++ exception handling.
3861         * dwarf2loc.c: Use C++ exception handling.
3862         * dwarf2-frame.c: Use C++ exception handling.
3863         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3864         * dwarf-index-write.c: Use C++ exception handling.
3865         * dwarf-index-cache.c: Use C++ exception handling.
3866         * dtrace-probe.c: Use C++ exception handling.
3867         * disasm-selftests.c: Use C++ exception handling.
3868         * darwin-nat.c: Use C++ exception handling.
3869         * cp-valprint.c: Use C++ exception handling.
3870         * cp-support.c: Use C++ exception handling.
3871         * cp-abi.c: Use C++ exception handling.
3872         * corelow.c: Use C++ exception handling.
3873         * completer.c: Use C++ exception handling.
3874         * compile/compile-object-run.c: Use C++ exception handling.
3875         * compile/compile-object-load.c: Use C++ exception handling.
3876         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3877         * compile/compile-c-symbols.c: Use C++ exception handling.
3878         * common/selftest.c: Use C++ exception handling.
3879         * common/new-op.c: Use C++ exception handling.
3880         * cli/cli-script.c: Use C++ exception handling.
3881         * cli/cli-interp.c: Use C++ exception handling.
3882         * cli/cli-cmds.c: Use C++ exception handling.
3883         * c-varobj.c: Use C++ exception handling.
3884         * btrace.c: Use C++ exception handling.
3885         * breakpoint.c: Use C++ exception handling.
3886         * break-catch-throw.c: Use C++ exception handling.
3887         * arch-utils.c: Use C++ exception handling.
3888         * amd64-tdep.c: Use C++ exception handling.
3889         * ada-valprint.c: Use C++ exception handling.
3890         * ada-typeprint.c: Use C++ exception handling.
3891         * ada-lang.c: Use C++ exception handling.
3892         * aarch64-tdep.c: Use C++ exception handling.
3893
3894 2019-04-08  Tom Tromey  <tom@tromey.com>
3895
3896         * xml-support.c (gdb_xml_parser::parse): Update.
3897         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3898         * value.c (show_convenience): Update.
3899         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3900         (test_parse_flags_qcs): Update.
3901         * thread.c (thr_try_catch_cmd): Update.
3902         * target.c (target_translate_tls_address): Update.
3903         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3904         (info_frame_command_core, frame_apply_command_count): Update.
3905         * rust-exp.y (rust_lex_exception_test): Update.
3906         * riscv-tdep.c (riscv_print_one_register_info): Update.
3907         * remote.c (remote_target::enable_btrace): Update.
3908         * record-btrace.c (record_btrace_enable_warn): Update.
3909         * python/py-utils.c (gdbpy_convert_exception): Update.
3910         * printcmd.c (do_one_display, print_variable_and_value): Update.
3911         * mi/mi-main.c (mi_print_exception): Update.
3912         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3913         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3914         * linux-nat.c (linux_nat_target::attach): Update.
3915         * linux-fork.c (class scoped_switch_fork_info): Update.
3916         * infrun.c (displaced_step_prepare): Update.
3917         * infcall.c (call_function_by_hand_dummy): Update.
3918         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3919         * gnu-v3-abi.c (print_one_vtable): Update.
3920         * frame.c (get_prev_frame_always): Update.
3921         * f-valprint.c (info_common_command_for_block): Update.
3922         * exec.c (try_open_exec_file): Update.
3923         * exceptions.c (print_exception, exception_print)
3924         (exception_fprintf, exception_print_same): Update.
3925         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3926         * dwarf-index-cache.c (index_cache::store)
3927         (index_cache::lookup_gdb_index): Update.
3928         * darwin-nat.c (maybe_cache_shell): Update.
3929         * cp-valprint.c (cp_print_value_fields): Update.
3930         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3931         (gcc_cplus_symbol_address): Update.
3932         * compile/compile-c-symbols.c (gcc_convert_symbol)
3933         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3934         * common/selftest.c: Update.
3935         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3936         a std::string.
3937         (exception_try_scope_entry, exception_try_scope_exit): Don't
3938         declare.
3939         (struct exception_try_scope): Remove.
3940         (TRY): Don't use exception_try_scope.
3941         (struct gdb_exception): Add constructor, operator=.
3942         <what>: New method.
3943         (struct gdb_exception_RETURN_MASK_ALL)
3944         (struct gdb_exception_RETURN_MASK_ERROR)
3945         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3946         (struct gdb_quit_bad_alloc): Update.
3947         * common/common-exceptions.c (exception_none): Change
3948         initializer.
3949         (struct catcher) <state, exception>: Initialize inline.
3950         <prev>: Remove member.
3951         (current_catcher): Remove.
3952         (catchers): New global.
3953         (exceptions_state_mc_init): Simplify.
3954         (catcher_pop): Remove.
3955         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3956         (try_scope_depth, exception_try_scope_entry)
3957         (exception_try_scope_exit): Remove.
3958         (throw_exception_sjlj): Update.
3959         (exception_messages, exception_messages_size): Remove.
3960         (throw_it): Simplify.
3961         (gdb_exception_sliced_copy): Remove.
3962         (throw_exception_cxx): Update.
3963         * cli/cli-script.c (script_from_file): Update.
3964         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3965         Update.
3966         * ada-valprint.c (ada_val_print): Update.
3967         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3968         (create_excep_cond_exprs): Update.
3969
3970 2019-04-08  Tom Tromey  <tom@tromey.com>
3971
3972         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3973         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3974         (TRY, CATCH, END_CATCH): Remove some definitions.
3975         * common/common-exceptions.c: Don't use GDB_XCPT.
3976         (catcher_list_size): Remove.
3977         (throw_exception, throw_it): Simplify.
3978
3979 2019-04-05  Tom Tromey  <tom@tromey.com>
3980
3981         Revert the header-sorting patch.
3982         * ft32-tdep.c: Revert.
3983         * frv-tdep.c: Revert.
3984         * frv-linux-tdep.c: Revert.
3985         * frame.c: Revert.
3986         * frame-unwind.c: Revert.
3987         * frame-base.c: Revert.
3988         * fork-child.c: Revert.
3989         * findvar.c: Revert.
3990         * findcmd.c: Revert.
3991         * filesystem.c: Revert.
3992         * filename-seen-cache.h: Revert.
3993         * filename-seen-cache.c: Revert.
3994         * fbsd-tdep.c: Revert.
3995         * fbsd-nat.h: Revert.
3996         * fbsd-nat.c: Revert.
3997         * f-valprint.c: Revert.
3998         * f-typeprint.c: Revert.
3999         * f-lang.c: Revert.
4000         * extension.h: Revert.
4001         * extension.c: Revert.
4002         * extension-priv.h: Revert.
4003         * expprint.c: Revert.
4004         * exec.h: Revert.
4005         * exec.c: Revert.
4006         * exceptions.c: Revert.
4007         * event-top.c: Revert.
4008         * event-loop.c: Revert.
4009         * eval.c: Revert.
4010         * elfread.c: Revert.
4011         * dwarf2read.h: Revert.
4012         * dwarf2read.c: Revert.
4013         * dwarf2loc.c: Revert.
4014         * dwarf2expr.h: Revert.
4015         * dwarf2expr.c: Revert.
4016         * dwarf2-frame.c: Revert.
4017         * dwarf2-frame-tailcall.c: Revert.
4018         * dwarf-index-write.h: Revert.
4019         * dwarf-index-write.c: Revert.
4020         * dwarf-index-common.c: Revert.
4021         * dwarf-index-cache.h: Revert.
4022         * dwarf-index-cache.c: Revert.
4023         * dummy-frame.c: Revert.
4024         * dtrace-probe.c: Revert.
4025         * disasm.h: Revert.
4026         * disasm.c: Revert.
4027         * disasm-selftests.c: Revert.
4028         * dictionary.c: Revert.
4029         * dicos-tdep.c: Revert.
4030         * demangle.c: Revert.
4031         * dcache.h: Revert.
4032         * dcache.c: Revert.
4033         * darwin-nat.h: Revert.
4034         * darwin-nat.c: Revert.
4035         * darwin-nat-info.c: Revert.
4036         * d-valprint.c: Revert.
4037         * d-namespace.c: Revert.
4038         * d-lang.c: Revert.
4039         * ctf.c: Revert.
4040         * csky-tdep.c: Revert.
4041         * csky-linux-tdep.c: Revert.
4042         * cris-tdep.c: Revert.
4043         * cris-linux-tdep.c: Revert.
4044         * cp-valprint.c: Revert.
4045         * cp-support.c: Revert.
4046         * cp-namespace.c: Revert.
4047         * cp-abi.c: Revert.
4048         * corelow.c: Revert.
4049         * corefile.c: Revert.
4050         * continuations.c: Revert.
4051         * completer.h: Revert.
4052         * completer.c: Revert.
4053         * complaints.c: Revert.
4054         * coffread.c: Revert.
4055         * coff-pe-read.c: Revert.
4056         * cli-out.h: Revert.
4057         * cli-out.c: Revert.
4058         * charset.c: Revert.
4059         * c-varobj.c: Revert.
4060         * c-valprint.c: Revert.
4061         * c-typeprint.c: Revert.
4062         * c-lang.c: Revert.
4063         * buildsym.c: Revert.
4064         * buildsym-legacy.c: Revert.
4065         * build-id.h: Revert.
4066         * build-id.c: Revert.
4067         * btrace.c: Revert.
4068         * bsd-uthread.c: Revert.
4069         * breakpoint.h: Revert.
4070         * breakpoint.c: Revert.
4071         * break-catch-throw.c: Revert.
4072         * break-catch-syscall.c: Revert.
4073         * break-catch-sig.c: Revert.
4074         * blockframe.c: Revert.
4075         * block.c: Revert.
4076         * bfin-tdep.c: Revert.
4077         * bfin-linux-tdep.c: Revert.
4078         * bfd-target.c: Revert.
4079         * bcache.c: Revert.
4080         * ax-general.c: Revert.
4081         * ax-gdb.h: Revert.
4082         * ax-gdb.c: Revert.
4083         * avr-tdep.c: Revert.
4084         * auxv.c: Revert.
4085         * auto-load.c: Revert.
4086         * arm-wince-tdep.c: Revert.
4087         * arm-tdep.c: Revert.
4088         * arm-symbian-tdep.c: Revert.
4089         * arm-pikeos-tdep.c: Revert.
4090         * arm-obsd-tdep.c: Revert.
4091         * arm-nbsd-tdep.c: Revert.
4092         * arm-nbsd-nat.c: Revert.
4093         * arm-linux-tdep.c: Revert.
4094         * arm-linux-nat.c: Revert.
4095         * arm-fbsd-tdep.c: Revert.
4096         * arm-fbsd-nat.c: Revert.
4097         * arm-bsd-tdep.c: Revert.
4098         * arch-utils.c: Revert.
4099         * arc-tdep.c: Revert.
4100         * arc-newlib-tdep.c: Revert.
4101         * annotate.h: Revert.
4102         * annotate.c: Revert.
4103         * amd64-windows-tdep.c: Revert.
4104         * amd64-windows-nat.c: Revert.
4105         * amd64-tdep.c: Revert.
4106         * amd64-sol2-tdep.c: Revert.
4107         * amd64-obsd-tdep.c: Revert.
4108         * amd64-obsd-nat.c: Revert.
4109         * amd64-nbsd-tdep.c: Revert.
4110         * amd64-nbsd-nat.c: Revert.
4111         * amd64-nat.c: Revert.
4112         * amd64-linux-tdep.c: Revert.
4113         * amd64-linux-nat.c: Revert.
4114         * amd64-fbsd-tdep.c: Revert.
4115         * amd64-fbsd-nat.c: Revert.
4116         * amd64-dicos-tdep.c: Revert.
4117         * amd64-darwin-tdep.c: Revert.
4118         * amd64-bsd-nat.c: Revert.
4119         * alpha-tdep.c: Revert.
4120         * alpha-obsd-tdep.c: Revert.
4121         * alpha-nbsd-tdep.c: Revert.
4122         * alpha-mdebug-tdep.c: Revert.
4123         * alpha-linux-tdep.c: Revert.
4124         * alpha-linux-nat.c: Revert.
4125         * alpha-bsd-tdep.c: Revert.
4126         * alpha-bsd-nat.c: Revert.
4127         * aix-thread.c: Revert.
4128         * agent.c: Revert.
4129         * addrmap.c: Revert.
4130         * ada-varobj.c: Revert.
4131         * ada-valprint.c: Revert.
4132         * ada-typeprint.c: Revert.
4133         * ada-tasks.c: Revert.
4134         * ada-lang.c: Revert.
4135         * aarch64-tdep.c: Revert.
4136         * aarch64-ravenscar-thread.c: Revert.
4137         * aarch64-newlib-tdep.c: Revert.
4138         * aarch64-linux-tdep.c: Revert.
4139         * aarch64-linux-nat.c: Revert.
4140         * aarch64-fbsd-tdep.c: Revert.
4141         * aarch64-fbsd-nat.c: Revert.
4142         * aarch32-linux-nat.c: Revert.
4143
4144 2019-04-05  Tom Tromey  <tom@tromey.com>
4145
4146         * ft32-tdep.c: Sort headers.
4147         * frv-tdep.c: Sort headers.
4148         * frv-linux-tdep.c: Sort headers.
4149         * frame.c: Sort headers.
4150         * frame-unwind.c: Sort headers.
4151         * frame-base.c: Sort headers.
4152         * fork-child.c: Sort headers.
4153         * findvar.c: Sort headers.
4154         * findcmd.c: Sort headers.
4155         * filesystem.c: Sort headers.
4156         * filename-seen-cache.h: Sort headers.
4157         * filename-seen-cache.c: Sort headers.
4158         * fbsd-tdep.c: Sort headers.
4159         * fbsd-nat.h: Sort headers.
4160         * fbsd-nat.c: Sort headers.
4161         * f-valprint.c: Sort headers.
4162         * f-typeprint.c: Sort headers.
4163         * f-lang.c: Sort headers.
4164         * extension.h: Sort headers.
4165         * extension.c: Sort headers.
4166         * extension-priv.h: Sort headers.
4167         * expprint.c: Sort headers.
4168         * exec.h: Sort headers.
4169         * exec.c: Sort headers.
4170         * exceptions.c: Sort headers.
4171         * event-top.c: Sort headers.
4172         * event-loop.c: Sort headers.
4173         * eval.c: Sort headers.
4174         * elfread.c: Sort headers.
4175         * dwarf2read.h: Sort headers.
4176         * dwarf2read.c: Sort headers.
4177         * dwarf2loc.c: Sort headers.
4178         * dwarf2expr.h: Sort headers.
4179         * dwarf2expr.c: Sort headers.
4180         * dwarf2-frame.c: Sort headers.
4181         * dwarf2-frame-tailcall.c: Sort headers.
4182         * dwarf-index-write.h: Sort headers.
4183         * dwarf-index-write.c: Sort headers.
4184         * dwarf-index-common.c: Sort headers.
4185         * dwarf-index-cache.h: Sort headers.
4186         * dwarf-index-cache.c: Sort headers.
4187         * dummy-frame.c: Sort headers.
4188         * dtrace-probe.c: Sort headers.
4189         * disasm.h: Sort headers.
4190         * disasm.c: Sort headers.
4191         * disasm-selftests.c: Sort headers.
4192         * dictionary.c: Sort headers.
4193         * dicos-tdep.c: Sort headers.
4194         * demangle.c: Sort headers.
4195         * dcache.h: Sort headers.
4196         * dcache.c: Sort headers.
4197         * darwin-nat.h: Sort headers.
4198         * darwin-nat.c: Sort headers.
4199         * darwin-nat-info.c: Sort headers.
4200         * d-valprint.c: Sort headers.
4201         * d-namespace.c: Sort headers.
4202         * d-lang.c: Sort headers.
4203         * ctf.c: Sort headers.
4204         * csky-tdep.c: Sort headers.
4205         * csky-linux-tdep.c: Sort headers.
4206         * cris-tdep.c: Sort headers.
4207         * cris-linux-tdep.c: Sort headers.
4208         * cp-valprint.c: Sort headers.
4209         * cp-support.c: Sort headers.
4210         * cp-namespace.c: Sort headers.
4211         * cp-abi.c: Sort headers.
4212         * corelow.c: Sort headers.
4213         * corefile.c: Sort headers.
4214         * continuations.c: Sort headers.
4215         * completer.h: Sort headers.
4216         * completer.c: Sort headers.
4217         * complaints.c: Sort headers.
4218         * coffread.c: Sort headers.
4219         * coff-pe-read.c: Sort headers.
4220         * cli-out.h: Sort headers.
4221         * cli-out.c: Sort headers.
4222         * charset.c: Sort headers.
4223         * c-varobj.c: Sort headers.
4224         * c-valprint.c: Sort headers.
4225         * c-typeprint.c: Sort headers.
4226         * c-lang.c: Sort headers.
4227         * buildsym.c: Sort headers.
4228         * buildsym-legacy.c: Sort headers.
4229         * build-id.h: Sort headers.
4230         * build-id.c: Sort headers.
4231         * btrace.c: Sort headers.
4232         * bsd-uthread.c: Sort headers.
4233         * breakpoint.h: Sort headers.
4234         * breakpoint.c: Sort headers.
4235         * break-catch-throw.c: Sort headers.
4236         * break-catch-syscall.c: Sort headers.
4237         * break-catch-sig.c: Sort headers.
4238         * blockframe.c: Sort headers.
4239         * block.c: Sort headers.
4240         * bfin-tdep.c: Sort headers.
4241         * bfin-linux-tdep.c: Sort headers.
4242         * bfd-target.c: Sort headers.
4243         * bcache.c: Sort headers.
4244         * ax-general.c: Sort headers.
4245         * ax-gdb.h: Sort headers.
4246         * ax-gdb.c: Sort headers.
4247         * avr-tdep.c: Sort headers.
4248         * auxv.c: Sort headers.
4249         * auto-load.c: Sort headers.
4250         * arm-wince-tdep.c: Sort headers.
4251         * arm-tdep.c: Sort headers.
4252         * arm-symbian-tdep.c: Sort headers.
4253         * arm-pikeos-tdep.c: Sort headers.
4254         * arm-obsd-tdep.c: Sort headers.
4255         * arm-nbsd-tdep.c: Sort headers.
4256         * arm-nbsd-nat.c: Sort headers.
4257         * arm-linux-tdep.c: Sort headers.
4258         * arm-linux-nat.c: Sort headers.
4259         * arm-fbsd-tdep.c: Sort headers.
4260         * arm-fbsd-nat.c: Sort headers.
4261         * arm-bsd-tdep.c: Sort headers.
4262         * arch-utils.c: Sort headers.
4263         * arc-tdep.c: Sort headers.
4264         * arc-newlib-tdep.c: Sort headers.
4265         * annotate.h: Sort headers.
4266         * annotate.c: Sort headers.
4267         * amd64-windows-tdep.c: Sort headers.
4268         * amd64-windows-nat.c: Sort headers.
4269         * amd64-tdep.c: Sort headers.
4270         * amd64-sol2-tdep.c: Sort headers.
4271         * amd64-obsd-tdep.c: Sort headers.
4272         * amd64-obsd-nat.c: Sort headers.
4273         * amd64-nbsd-tdep.c: Sort headers.
4274         * amd64-nbsd-nat.c: Sort headers.
4275         * amd64-nat.c: Sort headers.
4276         * amd64-linux-tdep.c: Sort headers.
4277         * amd64-linux-nat.c: Sort headers.
4278         * amd64-fbsd-tdep.c: Sort headers.
4279         * amd64-fbsd-nat.c: Sort headers.
4280         * amd64-dicos-tdep.c: Sort headers.
4281         * amd64-darwin-tdep.c: Sort headers.
4282         * amd64-bsd-nat.c: Sort headers.
4283         * alpha-tdep.c: Sort headers.
4284         * alpha-obsd-tdep.c: Sort headers.
4285         * alpha-nbsd-tdep.c: Sort headers.
4286         * alpha-mdebug-tdep.c: Sort headers.
4287         * alpha-linux-tdep.c: Sort headers.
4288         * alpha-linux-nat.c: Sort headers.
4289         * alpha-bsd-tdep.c: Sort headers.
4290         * alpha-bsd-nat.c: Sort headers.
4291         * aix-thread.c: Sort headers.
4292         * agent.c: Sort headers.
4293         * addrmap.c: Sort headers.
4294         * ada-varobj.c: Sort headers.
4295         * ada-valprint.c: Sort headers.
4296         * ada-typeprint.c: Sort headers.
4297         * ada-tasks.c: Sort headers.
4298         * ada-lang.c: Sort headers.
4299         * aarch64-tdep.c: Sort headers.
4300         * aarch64-ravenscar-thread.c: Sort headers.
4301         * aarch64-newlib-tdep.c: Sort headers.
4302         * aarch64-linux-tdep.c: Sort headers.
4303         * aarch64-linux-nat.c: Sort headers.
4304         * aarch64-fbsd-tdep.c: Sort headers.
4305         * aarch64-fbsd-nat.c: Sort headers.
4306         * aarch32-linux-nat.c: Sort headers.
4307
4308 2019-04-04  Tom Tromey  <tom@tromey.com>
4309
4310         * varobj.c (varobj_create): Update.
4311         * rust-exp.y (struct rust_parser) <update_innermost_block,
4312         lookup_symbol>: New methods.
4313         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4314         Rename.
4315         (rust_parser::rust_lookup_type)
4316         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4317         * printcmd.c (display_command, do_one_display): Update.
4318         * parser-defs.h (struct parser_state) <parser_state>: Add
4319         "tracker" parameter.
4320         (block_tracker): New member.
4321         (class innermost_block_tracker) <innermost_block_tracker>: Add
4322         "types" parameter.
4323         <reset>: Remove method.
4324         (innermost_block): Don't declare.
4325         (null_post_parser): Update.
4326         * parse.c (innermost_block): Remove global.
4327         (write_dollar_variable): Update.
4328         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4329         Remove "tracker_types" parameter.
4330         (parse_expression): Add "tracker" parameter.
4331         (parse_expression_for_completion): Update.
4332         (null_post_parser): Add "tracker" parameter.
4333         * p-exp.y: Update rules.
4334         * m2-exp.y: Update rules.
4335         * language.h (struct language_defn) <la_post_parser>: Add
4336         "tracker" parameter.
4337         * go-exp.y: Update rules.
4338         * f-exp.y: Update rules.
4339         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4340         parameter.
4341         * d-exp.y: Update rules.
4342         * c-exp.y: Update rules.
4343         * breakpoint.c (set_breakpoint_condition): Create an
4344         innermost_block_tracker.
4345         (watch_command_1): Likewise.
4346         * ada-lang.c (resolve): Add "tracker" parameter.
4347         (resolve_subexp): Likewise.
4348         * ada-exp.y (write_var_from_sym): Update.
4349
4350 2019-04-04  Tom Tromey  <tom@tromey.com>
4351
4352         * type-stack.h: New file.
4353         * type-stack.c: New file.
4354         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4355         type-stack.h.
4356         (insert_into_type_stack, insert_type, push_type, push_type_int)
4357         (insert_type_address_space, pop_type, pop_type_int)
4358         (pop_typelist, pop_type_stack, append_type_stack)
4359         (push_type_stack, get_type_stack, push_typelist)
4360         (follow_type_instance_flags, follow_types): Don't declare.
4361         * parse.c (type_stack): Remove global.
4362         (parse_exp_in_context): Update.
4363         (insert_into_type_stack, insert_type, push_type, push_type_int)
4364         (insert_type_address_space, pop_type, pop_type_int)
4365         (pop_typelist, pop_type_stack, append_type_stack)
4366         (push_type_stack, get_type_stack, push_typelist)
4367         (follow_type_instance_flags, follow_types): Remove (moved to
4368         type-stack.c).
4369         * f-exp.y (type_stack): New global.
4370         Update rules.
4371         (push_kind_type, f_parse): Update.
4372         * d-exp.y (type_stack): New global.
4373         Update rules.
4374         (d_parse): Update.
4375         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4376         Update rules.
4377         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4378         (HFILES_NO_SRCDIR): Add type-stack.h.
4379
4380 2019-04-04  Tom Tromey  <tom@tromey.com>
4381
4382         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4383         (rust_parser::convert_ast_to_expression, rust_parse)
4384         (rust_lex_test_completion, rust_lex_tests): Update.
4385         * parser-defs.h (struct expr_completion_state): New.
4386         (struct parser_state) <parser_state>: Add completion parameter.
4387         <mark_struct_expression, mark_completion_tag>: New methods.
4388         <parse_completion, m_completion_state>: New members.
4389         (prefixify_expression, null_post_parser): Update.
4390         (mark_struct_expression, mark_completion_tag): Don't declare.
4391         * parse.c (parse_completion, expout_last_struct)
4392         (expout_tag_completion_type, expout_completion_name): Remove
4393         globals.
4394         (parser_state::mark_struct_expression)
4395         (parser_state::mark_completion_tag): Now methods.
4396         (prefixify_expression): Add last_struct parameter.
4397         (prefixify_subexp): Likewise.
4398         (parse_exp_1): Update.
4399         (parse_exp_in_context): Add cstate parameter.  Update.
4400         (parse_expression_for_completion): Create an
4401         expr_completion_state.
4402         (null_post_parser): Add "completion" parameter.
4403         * p-exp.y: Update rules.
4404         (yylex): Update.
4405         * language.h (struct language_defn) <la_post_parser>: Add
4406         "completing" parameter.
4407         * go-exp.y: Update rules.
4408         (lex_one_token): Update.
4409         * expression.h (parse_completion): Don't declare.
4410         * d-exp.y: Update rules.
4411         (lex_one_token): Update rules.
4412         * c-exp.y: Update rules.
4413         (lex_one_token): Update.
4414         * ada-lang.c (resolve): Add "parse_completion" parameter.
4415         (resolve_subexp): Likewise.
4416         (ada_resolve_function): Likewise.
4417
4418 2019-04-04  Tom Tromey  <tom@tromey.com>
4419
4420         * parser-defs.h (struct parser_state) <start_arglist,
4421         end_arglist>: New methods.
4422         <arglist_len, m_funcall_chain>: New members.
4423         (arglist_len, start_arglist, end_arglist): Don't declare.
4424         * parse.c (arglist_len, funcall_chain): Remove global.
4425         (start_arglist, end_arglist): Remove functions.
4426         (parse_exp_in_context): Update.
4427         * p-exp.y: Update rules.
4428         * m2-exp.y: Update rules.
4429         * go-exp.y: Update rules.
4430         * f-exp.y: Update rules.
4431         * d-exp.y: Update rules.
4432         * c-exp.y: Update rules.
4433
4434 2019-04-04  Tom Tromey  <tom@tromey.com>
4435
4436         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4437         lex_operator, push_back>: New methods.
4438         Update all rules.
4439         (rust_parser::lex_hex, lex_escape): Rename and update.
4440         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4441         (rust_parser::lex_operator): Rename and update.
4442         (rust_parser::lex_number, rustyylex, rustyyerror)
4443         (rust_lex_test_init, rust_lex_test_sequence)
4444         (rust_lex_test_push_back, rust_lex_tests): Update.
4445         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4446         parameter.
4447         <lexptr, prev_lexptr>: New members.
4448         (lexptr, prev_lexptr): Don't declare.
4449         * parse.c (lexptr, prev_lexptr): Remove globals.
4450         (parse_exp_in_context): Update.
4451         * p-exp.y (yylex, yyerror): Update.
4452         * m2-exp.y (parse_number, yylex, yyerror): Update.
4453         * go-exp.y (lex_one_token, yyerror): Update.
4454         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4455         * d-exp.y (lex_one_token, yyerror): Update.
4456         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4457         (lex_one_token, yyerror): Update.
4458         * ada-lex.l (YY_INPUT): Update.
4459         (rewind_to_char): Update.
4460         * ada-exp.y (yyerror): Update.
4461
4462 2019-04-04  Tom Tromey  <tom@tromey.com>
4463
4464         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4465         * parser-defs.h (struct parser_state) <parser_state>: Add new
4466         parameter.
4467         <comma_terminates>: New member.
4468         (comma_terminates): Don't declare global.
4469         * parse.c (comma_terminates): Remove global.
4470         (parse_exp_in_context): Update.
4471         * p-exp.y (yylex): Update.
4472         * m2-exp.y (yylex): Update.
4473         * go-exp.y (lex_one_token): Update.
4474         * f-exp.y (yylex): Update.
4475         * d-exp.y (lex_one_token): Update.
4476         * c-exp.y (lex_one_token): Update.
4477         * ada-lex.l: Update.
4478
4479 2019-04-04  Tom Tromey  <tom@tromey.com>
4480
4481         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4482         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4483         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4484         * parser-defs.h (paren_depth): Don't declare.
4485         * parse.c (paren_depth): Remove global.
4486         (parse_exp_in_context): Update.
4487         * p-exp.y (paren_depth): New global.
4488         (pascal_parse): Initialize it.
4489         * m2-exp.y (paren_depth): New global.
4490         (m2_parse): Initialize it.
4491         * go-exp.y (paren_depth): New global.
4492         (go_parse): Initialize it.
4493         * f-exp.y (paren_depth): New global.
4494         (f_parse): Initialize it.
4495         * d-exp.y (paren_depth): New global.
4496         (d_parse): Initialize it.
4497         * c-exp.y (paren_depth): New global.
4498         (c_parse): Initialize it.
4499         * ada-lex.l (paren_depth): New global.
4500         (lexer_init): Initialize it.
4501
4502 2019-04-04  Tom Tromey  <tom@tromey.com>
4503
4504         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4505         (rust_parser::convert_ast_to_type)
4506         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4507         * parser-defs.h (struct parser_state) <parser_state>: Add
4508         parameters.  Initialize new members.
4509         <expression_context_block, expression_context_pc>: New members.
4510         * parse.c (expression_context_block, expression_context_pc):
4511         Remove globals.
4512         (parse_exp_in_context): Update.
4513         * p-exp.y: Update all rules.
4514         (yylex): Update.
4515         * m2-exp.y: Update all rules.
4516         (yylex): Update.
4517         * go-exp.y (yylex): Update.
4518         * f-exp.y (yylex): Update.
4519         * d-exp.y: Update all rules.
4520         (yylex): Update.
4521         * c-exp.y: Update all rules.
4522         (lex_one_token, classify_name, yylex, c_parse): Update.
4523         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4524
4525 2019-04-04  Tom Tromey  <tom@tromey.com>
4526
4527         * gdbarch.h, gdbarch.c: Rebuild.
4528         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4529         * stap-probe.h:
4530         (struct stap_parse_info): Replace "parser_state" with
4531         "expr_builder".
4532         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4533         (parser_state): New class.
4534         * parse.c (expr_builder): Rename.
4535         (expr_builder::release): Rename.
4536         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4537         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4538         (write_exp_elt_longcst, write_exp_elt_floatcst)
4539         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4540         (write_exp_string_vector, write_exp_bitstring)
4541         (write_exp_msymbol, mark_struct_expression)
4542         (write_dollar_variable)
4543         (insert_type_address_space, increase_expout_size): Replace
4544         "parser_state" with "expr_builder".
4545         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4546         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4547         "parser_state" with "expr_builder".
4548
4549 2019-04-04  Tom Tromey  <tom@tromey.com>
4550
4551         * rust-exp.y: Replace "parse_language" with method call.
4552         * p-exp.y:
4553         (yylex): Replace "parse_language" with method call.
4554         * m2-exp.y:
4555         (yylex): Replace "parse_language" with method call.
4556         * go-exp.y (classify_name): Replace "parse_language" with method
4557         call.
4558         * f-exp.y (yylex): Replace "parse_language" with method call.
4559         * d-exp.y (lex_one_token): Replace "parse_language" with method
4560         call.
4561         * c-exp.y:
4562         (lex_one_token, classify_name, yylex): Replace "parse_language"
4563         with method call.
4564         * ada-exp.y (find_primitive_type, type_char)
4565         (type_system_address): Replace "parse_language" with method call.
4566
4567 2019-04-04  Tom Tromey  <tom@tromey.com>
4568
4569         * rust-exp.y: Replace "parse_gdbarch" with method call.
4570         * parse.c (write_dollar_variable, insert_type_address_space):
4571         Replace "parse_gdbarch" with method call.
4572         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4573         call.
4574         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4575         call.
4576         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4577         "parse_gdbarch" with method call.
4578         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4579         with method call.
4580         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4581         "parse_gdbarch" with method call.
4582         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4583         "parse_gdbarch" with method call.
4584         * c-exp.y (parse_type, parse_number, classify_name): Replace
4585         "parse_gdbarch" with method call.
4586         * ada-lex.l: Replace "parse_gdbarch" with method call.
4587         * ada-exp.y (parse_type, find_primitive_type, type_char)
4588         (type_system_address): Replace "parse_gdbarch" with method call.
4589
4590 2019-04-04  Tom Tromey  <tom@tromey.com>
4591
4592         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4593         * stap-probe.c (stap_parse_argument): Update.
4594         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4595         initial_size parameter.
4596         * rust-exp.y (rust_lex_tests): Update.
4597         * parse.c (parser_state): Update.
4598         (parse_exp_in_context): Update.
4599         * parser-defs.h (struct parser_state) <parser_state>: Remove
4600         "initial_size" parameter.
4601
4602 2019-04-04  Tom Tromey  <tom@tromey.com>
4603
4604         * parser-defs.h (increase_expout_size): Don't declare.
4605         * parse.c (increase_expout_size): Now static.
4606
4607 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4608
4609         * gnu-nat.c (gnu_nat_target::wait): Fix
4610         target_waitstatus_to_string call.
4611
4612 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4613
4614         * eval.c (evaluate_subexp_standard): Handle internal functions
4615         during Fortran function call handling.
4616
4617 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4618
4619         * NEWS: Mention new internal functions.
4620         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4621         (read_base_type): Use dwarf2_init_complex_target_type.
4622         * value.c (creal_internal_fn): New function.
4623         (cimag_internal_fn): New function.
4624         (_initialize_values): Register new internal functions.
4625
4626 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4627
4628         * infrun.c (stop_all_threads): If debug_infrun, always
4629         trace the wait status after wait_one, using
4630         target_waitstatus_to_string and target_pid_to_str.
4631         (handle_inferior_event): Replace various trace of
4632         wait status kind by a single trace.
4633         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4634         wait status kind image by target_waitstatus_to_string.
4635         * target/waitstatus.c (target_waitstatus_to_string): Fix
4636         obsolete comment.
4637
4638 2019-04-01  Tom Tromey  <tromey@adacore.com>
4639
4640         PR symtab/23331:
4641         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4642
4643 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4644             Pedro Alves  <palves@redhat.com>
4645
4646         * top.c (quit_force): Call 'finalize_values'.
4647         * value.c (finalize_values): New function.
4648         * value.h (finalize_values): Declare.
4649
4650 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4651
4652         * NEWS: Announce $_gdb_major and $_gdb_minor.
4653
4654         * top.c (init_gdb_version_vars): New function.
4655         (gdb_init): Call init_gdb_version_vars.
4656
4657 2019-03-29  Tom Tromey  <tromey@adacore.com>
4658
4659         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4660         help text.  Remove dead code.
4661
4662 2019-03-29  Keith Seitz  <keiths@redhat.com>
4663
4664         From Siddhesh Poyarekar:
4665         * f-lang.h (f77_get_upperbound): Return LONGEST.
4666         (f77_get_lowerbound): Likewise.
4667         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4668         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4669         print them.
4670         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4671         plongest to format print it.
4672         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4673         (f77_get_upperbound): Likewise.
4674         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4675         LOWER_BOUND to LONGEST.
4676         (f77_create_arrayprint_offset_tbl): Likewise.
4677
4678 2019-03-29  Keith Seitz  <keiths@redhat.com>
4679
4680         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4681         %s/pulongest for TYPE_LENGTH instead of %d in format
4682         strings.
4683         * ada-typerint.c (ada_print_type): Likewise.
4684         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4685         * compile/compile-c-support.c (generate_register_struct): Likewise.
4686         * gdbtypes.c (recursive_dump_type): Likewise.
4687         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4688         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4689         instead of %d in format strings.
4690         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4691         to std::min to ULONGEST.
4692         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4693         instead of %d in format strings.
4694         * tracepoint.c (info_scope_command): Likewise.
4695         * typeprint.c (print_offset_data::update)
4696         (print_offset_data::finish): Likewise.
4697         * xtensa-tdep.c (xtensa_store_return_value)
4698         (xtensa_push_dummy_call): Likewise.
4699
4700 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4701
4702         * windows-nat.c (display_selector): Fixed format specifications
4703         for 64-bit Cygwin.
4704
4705 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4706
4707         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4708
4709 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4710
4711         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4712         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4713         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4714         (nios2_linux_init_abi): Install it.
4715
4716 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4717
4718         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4719
4720 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4721
4722         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4723
4724 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4725             Tom Tromey  <tromey@adacore.com>
4726
4727         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4728
4729 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4730
4731         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4732         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4733         method to compute the bounds of range types. Also print "[evaluated]"
4734         if the bounds' values come from a dynamic evaluation.
4735
4736 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4737
4738         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4739         whitespace when pretty printing is on.
4740
4741 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4742
4743         * ppc-linux-nat.c: Add include.
4744
4745 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4746
4747         * NEWS: Mention AArch64 Pointer Authentication.
4748
4749 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4750
4751         * arm-linux-nat.c: Add include.
4752
4753 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4754
4755         * source-cache.c (source_cache::get_source_lines): Re-read
4756         fullname after calling open_source_file.
4757
4758 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4759
4760         * NEWS: Mention TLS support for FreeBSD.
4761
4762 2019-03-25  Tom Tromey  <tromey@adacore.com>
4763
4764         * minsyms.c (BUNCH_SIZE): Update comment.
4765         (~minimal_symbol_reader): Remove old comment.
4766         (compact_minimal_symbols): Update comment.
4767         (minimal_symbol_reader::install): Remove old comment.  Update
4768         other comments.
4769
4770 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4771
4772         * s390-linux-nat.c: Add include.
4773
4774 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4775
4776         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4777         Call linux_get_hwcap.
4778         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4779         Likewise.
4780         (aarch64_linux_get_hwcap): Remove function.
4781         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4782         declaration.
4783         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4784         linux_get_hwcap.
4785         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4786         * linux-tdep.c (linux_get_hwcap): Add function.
4787         (linux_get_hwcap2): Likewise.
4788         * linux-tdep.h (linux_get_hwcap): Add declaration.
4789         (linux_get_hwcap2): Likewise.
4790         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4791         (ppc_linux_get_hwcap2): Likewise.
4792         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4793         linux_get_hwcap.
4794         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4795         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4796         (ppc_linux_nat_target::read_description): Likewise.
4797         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4798         * s390-linux-nat.c: Likewise.
4799         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4800
4801 2019-03-24  Tom Tromey  <tom@tromey.com>
4802
4803         * ada-lang.c (standard_lookup): Simplify initialization.
4804         (ada_lookup_symbol_nonlocal): Simplify return.
4805         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4806         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4807         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4808         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4809         initialization.
4810         * solib.c (solib_global_lookup): Simplify.
4811         * symtab.c (null_block_symbol): Remove.
4812         (symbol_cache_lookup): Simplify returns.
4813         (lookup_language_this): Simplify returns.
4814         (lookup_symbol_aux): Simplify return.
4815         (lookup_local_symbol): Simplify returns.
4816         (lookup_global_symbol_from_objfile): Simplify return.
4817         (lookup_symbol_in_objfile_symtabs)
4818         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4819         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4820         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4821         * cp-namespace.c (cp_lookup_bare_symbol)
4822         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4823         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4824         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4825         (cp_lookup_symbol_via_imports): Simplify initialization.
4826         (find_symbol_in_baseclass): Likewise.
4827         * symtab.h (null_block_symbol): Remove.
4828         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4829         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4830         (d_lookup_symbol_module): Likewise.
4831         (find_symbol_in_baseclass): Simplify initialization.
4832
4833 2019-03-24  Tom Tromey  <tom@tromey.com>
4834
4835         * expression.h: Don't include symtab.h.
4836         (struct block): Forward declare.
4837
4838 2019-03-24  Tom Tromey  <tom@tromey.com>
4839
4840         * c-exp.y (typebase): Remove casts.
4841         * gdbtypes.c (lookup_unsigned_typename, )
4842         (lookup_signed_typename): Remove cast.
4843         * eval.c (parse_to_comma_and_eval): Remove cast.
4844         * parse.c (write_dollar_variable): Remove cast.
4845         * block.h (struct block) <superblock>: Now const.
4846         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4847         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4848         (map_block): Make "block" const.
4849         * symfile.h (struct quick_symbol_functions)
4850         <map_matching_symbols>: Constify block argument to "callback".
4851         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4852         const.
4853         (find_pc_sect_compunit_symtab): Make "b" const.
4854         (find_symbol_at_address): Likewise.
4855         (search_symbols): Likewise.
4856         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4857         (dw2_debug_names_lookup_symbol): Likewise.
4858         (dw2_map_matching_symbols): Update.
4859         * p-valprint.c (pascal_val_print): Remove "block".
4860         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4861         (aux_add_nonlocal_symbols): Make "block" const.
4862         (resolve_subexp): Remove cast.
4863         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4864         const.
4865         (iterate_over_file_blocks): Likewise.
4866         * f-exp.y (%union) <bval>: Remove.
4867         * coffread.c (patch_opaque_types): Make "b" const.
4868         * spu-tdep.c (spu_catch_start): Make "block" const.
4869         * c-valprint.c (print_unpacked_pointer): Remove "block".
4870         * symmisc.c (dump_symtab_1): Make "b" const.
4871         (block_depth): Make "block" const.
4872         * d-exp.y (%union) <bval>: Remove.
4873         * cp-support.h (cp_lookup_rtti_type): Update.
4874         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4875         * psymtab.c (psym_lookup_symbol): Make "block" const.
4876         (maintenance_check_psymtabs): Make "b" const.
4877         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4878         (enumerate_locals, enumerate_args): Update.
4879         * python/py-symtab.c (stpy_global_block): Make "block" const.
4880         (stpy_static_block): Likewise.
4881         * inline-frame.c (block_starting_point_at): Make "new_block"
4882         const.
4883         * block.c (find_block_in_blockvector): Make return type const.
4884         (blockvector_for_pc_sect): Make "b" const.
4885         (find_block_in_blockvector): Make "b" const.
4886
4887 2019-03-23  Tom Tromey  <tom@tromey.com>
4888
4889         * varobj.c (varobj_create): Update.
4890         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4891         * printcmd.c (display_command, do_one_display): Don't reset
4892         innermost_block.
4893         * parser-defs.h (enum innermost_block_tracker_type): Move to
4894         expression.h.
4895         (innermost_block): Update comment.
4896         * parse.c (parse_exp_1): Add tracker_types parameter.
4897         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4898         tracker_types parameter.  Reset innermost_block.
4899         (parse_exp_in_context): Remove.
4900         (parse_expression_for_completion): Update.
4901         * objfiles.c (~objfile): Don't reset expression_context_block or
4902         innermost_block.
4903         * expression.h (enum innermost_block_tracker_type): Move from
4904         parser-defs.h.
4905         (parse_exp_1): Add tracker_types parameter.
4906         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4907         reset innermost_block.
4908
4909 2019-03-23  Tom Tromey  <tom@tromey.com>
4910
4911         * objfiles.h: Include bcache.h.
4912
4913 2019-03-23  Tom Tromey  <tom@tromey.com>
4914
4915         * linespec.c (get_current_search_block): Use
4916         scoped_restore_current_language.
4917         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4918
4919 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4920             Jiong Wang  <jiong.wang@arm.com>
4921
4922         * aarch64-linux-tdep.c
4923         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4924         section.
4925         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4926
4927 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4928             Jiong Wang  <jiong.wang@arm.com>
4929
4930         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4931         instructions.
4932         (aarch64_analyze_prologue_test): Add PACIASP test.
4933         (aarch64_prologue_prev_register): Unmask PC value.
4934
4935 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4936             Jiong Wang  <jiong.wang@arm.com>
4937
4938         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4939         (aarch64_dwarf2_prev_register): Unmask PC value.
4940         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4941         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4942         DW_CFA_AARCH64_negate_ra_state.
4943         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4944
4945 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4946             Jiong Wang  <jiong.wang@arm.com>
4947
4948         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4949         registers.
4950         (aarch64_pseudo_register_name): Likewise.
4951         (aarch64_pseudo_register_type): Likewise.
4952         (aarch64_pseudo_register_reggroup_p): Likewise.
4953         (aarch64_gdbarch_init): Add pauth registers.
4954         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4955         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4956         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4957         (struct gdbarch_tdep): Add regnum for ra_state.
4958
4959 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4960             Jiong Wang  <jiong.wang@arm.com>
4961
4962         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4963
4964 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4965             Jiong Wang  <jiong.wang@arm.com>
4966
4967         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4968         function.
4969         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4970         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4971         (aarch64_gdbarch_init): Add puth registers.
4972         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4973         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4974         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4975
4976 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4977             Jiong Wang  <jiong.wang@arm.com>
4978
4979         * aarch64-linux-nat.c
4980         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4981         * aarch64-linux-tdep.c
4982         (aarch64_linux_core_read_description): Likewise.
4983         (aarch64_linux_get_hwcap): New function.
4984         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4985         (aarch64_linux_get_hwcap): New declaration.
4986
4987 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4988             Jiong Wang  <jiong.wang@arm.com>
4989
4990         * aarch64-linux-nat.c
4991         (aarch64_linux_nat_target::read_description): Add pauth param.
4992         * aarch64-linux-tdep.c
4993         (aarch64_linux_core_read_description): Likewise.
4994         * aarch64-tdep.c (struct target_desc): Add in pauth.
4995         (aarch64_read_description): Add pauth param.
4996         (aarch64_gdbarch_init): Likewise.
4997         * aarch64-tdep.h (aarch64_read_description): Likewise.
4998         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4999         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5000         * features/Makefile: Add new files.
5001         * features/aarch64-pauth.c: New file.
5002         * features/aarch64-pauth.xml: New file.
5003
5004 2019-03-20  Tom Tromey  <tromey@adacore.com>
5005
5006         * infrun.c (handle_inferior_event): Rename from
5007         handle_inferior_event_1.  Create a scoped_value_mark.
5008         (handle_inferior_event): Remove.
5009
5010 2019-03-19  Tom Tromey  <tromey@adacore.com>
5011
5012         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5013         * infrun.h (print_stop_event): Add "displays" parameter.
5014         * infrun.c (print_stop_event): Add "displays" parameter.
5015
5016 2019-03-19  Pedro Alves  <palves@redhat.com>
5017
5018         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5019         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5020         to -1.  Fix TABs vs spaces.
5021         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5022         * tui/tui-out.h (tui_ui_out) Add intro comments.
5023         <m_line, m_start_of_line>: In-class initialize, and add describing
5024         comment.
5025
5026 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5027
5028         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5029         variable names.
5030         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5031
5032 2019-03-18  Pedro Alves  <palves@redhat.com>
5033             Eli Zaretskii <eliz@gnu.org>
5034
5035         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5036         m_line and m_start_of_line.
5037
5038 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5039
5040         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5041         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5042         it returns a newline.  This fixes a regression in TU mode, whereby
5043         the next line is output on the same screen line as the user input.
5044
5045 2019-03-18  Tom Tromey  <tromey@adacore.com>
5046
5047         * minsyms.c (minimal_symbol_reader::install): Remove call to
5048         obstack_blank.
5049
5050 2019-03-18  Pedro Alves  <palves@redhat.com>
5051
5052         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5053         New globals.
5054         (apply_style): New, factored out from ...
5055         (apply_ansi_escape): ... this.  Handle reverse video mode.
5056         (tui_set_reverse_mode): New function.
5057         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5058         * tui/tui-winsource.c (tui_show_source_line): Use
5059         tui_set_reverse_mode instead of setting A_STANDOUT.
5060         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5061         New setter methods.
5062
5063 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5064
5065         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5066         Handle tabs.
5067
5068 2019-03-18  Tom Tromey  <tromey@adacore.com>
5069
5070         * ada-lang.c (empty_array): Add "high" parameter.
5071         (ada_evaluate_subexp): Update.
5072
5073 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5074
5075         * unittests/string_view-selftests.c: Define
5076         _initialize_string_view_selftests unconditionally.
5077
5078 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5079
5080         PR gdb/24350
5081         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5082
5083 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5084
5085         PR gdb/24351
5086         * windows-nat.c (display_selector): Fix format specifiers.
5087
5088 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5089
5090         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5091         tui_refill_source_window instead of tui_refresh_win, to update the
5092         current execution line.  This fixes redisplay of the current line
5093         when stepping through the code with "next" or "step".
5094
5095 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5096
5097         * source-cache.c (source_cache::get_source_lines): Call
5098         find_source_lines to initialize s->nlines.  This fixes vertical
5099         scrolling of TUI source window when the DOWN arrow is pressed.
5100
5101 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5102
5103         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5104         linux-thread-db.c (_initialize_thread_db): Likewise.
5105
5106 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5107
5108         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5109         wclrtoeol in tui_show_source_line".  This reverts changes made in
5110         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5111
5112 2019-03-15  Tom Tromey  <tom@tromey.com>
5113
5114         * symtab.h (struct minimal_symbol): Derive from
5115         general_symbol_info.
5116         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5117         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5118         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5119         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5120         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5121         (MSYMBOL_SEARCH_NAME): Update.
5122         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5123         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5124         * minsyms.c (minimal_symbol_reader::record_full): Update.
5125
5126 2019-03-15  Tom Tromey  <tom@tromey.com>
5127
5128         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5129
5130 2019-03-15  Tom Tromey  <tom@tromey.com>
5131
5132         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5133         unique_xmalloc_ptr.
5134         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5135         Update.
5136         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5137         (build_minimal_symbol_hash_tables)
5138         (minimal_symbol_reader::install): Update.
5139
5140 2019-03-15  Tom Tromey  <tom@tromey.com>
5141
5142         * symtab.c (create_demangled_names_hash): Update.
5143         (symbol_set_names): Update.
5144         * objfiles.h (struct objfile_per_bfd_storage)
5145         <demangled_names_hash>: Now an htab_up.
5146         * objfiles.c (objfile_per_bfd_storage): Simplify.
5147
5148 2019-03-15  Tom Tromey  <tom@tromey.com>
5149
5150         * objfiles.h (struct objfile_per_bfd_storage): Declare
5151         destructor.
5152         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5153         New.
5154         (get_objfile_bfd_data): Use new.  Don't initialize
5155         language_of_main.
5156         (free_objfile_per_bfd_storage): Remove.
5157         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5158
5159 2019-03-15  Tom Tromey  <tom@tromey.com>
5160
5161         * symfile.c (reread_symbols): Update.
5162         * objfiles.c (objfile::objfile): Update.
5163         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5164         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5165         comment.
5166         (minimal_symbol_reader::install): Update.
5167         (terminate_minimal_symbol_table): Remove.
5168         * jit.c (jit_object_close_impl): Update.
5169
5170 2019-03-15  Tom Tromey  <tom@tromey.com>
5171
5172         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5173         initializations.
5174
5175 2019-03-15  Tom Tromey  <tom@tromey.com>
5176
5177         * objfiles.h (struct objfile_per_bfd_storage)
5178         <demangled_hash_languages>: Now a bitset.
5179         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5180         (lookup_minimal_symbol): Update.
5181
5182 2019-03-15  Tom Tromey  <tom@tromey.com>
5183
5184         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5185         Don't return the symbol.
5186         * coffread.c (record_minimal_symbol): Use record_full.
5187
5188 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5189
5190         The MS-Windows port of ncurses fails to switch to a color pair if
5191         one or both of the colors are the implicit default colors.  This
5192         change records the default colors when TUI is initialized, and
5193         then specifies them explicitly when a color pair uses the default
5194         colors.  This allows color styling in TUI mode on MS-Windows.
5195
5196         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5197         ncurses_norm_attr.
5198         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5199         colors in ncurses_norm_attr.
5200         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5201         "none", replace it with the default color recorded in
5202         ncurses_norm_attr.
5203
5204 2019-03-14  Tom Tromey  <tromey@adacore.com>
5205
5206         * source-cache.h (class source_cache) <get_source_lines>: Return
5207         std::string.
5208         * source-cache.c (source_cache::extract_lines): Handle case where
5209         first_pos==npos.  Return std::string.
5210         (source_cache::get_source_lines): Update.
5211
5212 2019-03-14  Tom Tromey  <tromey@adacore.com>
5213
5214         * NEWS: Add item for "style sources" commands.
5215         * source-cache.c (source_cache::get_source_lines): Check
5216         source_styling.
5217         * cli/cli-style.c (source_styling): New global.
5218         (_initialize_cli_style): Add "style sources" commands.
5219         (show_style_sources): New function.
5220         * cli/cli-style.h (source_styling): Declare.
5221
5222 2019-03-14  Pedro Alves  <palves@redhat.com>
5223             Tom Tromey  <tromey@adacore.com>
5224
5225         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5226         * tui/tui-winsource.c (tui_refill_source_window): New function,
5227         from...
5228         (tui_horizontal_source_scroll): ... here.  Move some logic.
5229         * cli/cli-style.c (set_style_enabled): Notify new observable.
5230         * tui/tui-hooks.c (tui_redisplay_source): New function.
5231         (tui_attach_detach_observers): Attach or detach
5232         tui_redisplay_source.
5233         * observable.h (source_styling_changed): New observable.
5234         * observable.c: Define source_styling_changed observable.
5235
5236 2019-03-13  Tom Tromey  <tromey@adacore.com>
5237
5238         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5239         (i386_gnu_nat_target::store_registers): Update.
5240         * target-debug.h (target_debug_print_std_string): New macro.
5241         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5242         * windows-tdep.c (display_one_tib): Update.
5243         * tui/tui-stack.c (tui_make_status_line): Update.
5244         * top.c (print_inferior_quit_action): Update.
5245         * thread.c (thr_try_catch_cmd): Update.
5246         (add_thread_with_info): Update.
5247         (thread_target_id_str): Update.
5248         (thr_try_catch_cmd): Update.
5249         (thread_command): Update.
5250         (thread_find_command): Update.
5251         * record-btrace.c (record_btrace_target::info_record)
5252         (record_btrace_resume_thread, record_btrace_target::resume)
5253         (record_btrace_cancel_resume, record_btrace_step_thread)
5254         (record_btrace_target::wait, record_btrace_target::wait)
5255         (record_btrace_target::wait, record_btrace_target::stop): Update.
5256         * progspace.c (print_program_space): Update.
5257         * process-stratum-target.c
5258         (process_stratum_target::thread_address_space): Update.
5259         * linux-fork.c (linux_fork_mourn_inferior)
5260         (detach_checkpoint_command, info_checkpoints_command)
5261         (linux_fork_context): Update.
5262         (linux_fork_detach): Update.
5263         (class scoped_switch_fork_info): Update.
5264         (delete_checkpoint_command): Update.
5265         * infrun.c (follow_fork_inferior): Update.
5266         (follow_fork_inferior): Update.
5267         (proceed_after_vfork_done): Update.
5268         (handle_vfork_child_exec_or_exit): Update.
5269         (follow_exec): Update.
5270         (displaced_step_prepare_throw): Update.
5271         (displaced_step_restore): Update.
5272         (start_step_over): Update.
5273         (resume_1): Update.
5274         (clear_proceed_status_thread): Update.
5275         (proceed): Update.
5276         (print_target_wait_results): Update.
5277         (do_target_wait): Update.
5278         (context_switch): Update.
5279         (stop_all_threads): Update.
5280         (restart_threads): Update.
5281         (finish_step_over): Update.
5282         (handle_signal_stop): Update.
5283         (switch_back_to_stepped_thread): Update.
5284         (keep_going_pass_signal): Update.
5285         (print_exited_reason): Update.
5286         (normal_stop): Update.
5287         * inferior.c (inferior_pid_to_str): Change return type.
5288         (print_selected_inferior): Update.
5289         (add_inferior): Update.
5290         (detach_inferior): Update.
5291         * dummy-frame.c (fprint_dummy_frames): Update.
5292         * dcache.c (dcache_info_1): Update.
5293         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5294         (btrace_fetch, btrace_clear): Update.
5295         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5296         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5297         type.
5298         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5299         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5300         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5301         * gdbarch.c, gdbarch.h: Rebuild.
5302         * gdbarch.sh (core_pid_to_str): Change return type.
5303         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5304         return type.
5305         (windows_nat_target::pid_to_str): Change return type.
5306         (windows_delete_thread): Update.
5307         (windows_nat_target::attach): Update.
5308         (windows_nat_target::files_info): Update.
5309         * target-delegates.c: Rebuild.
5310         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5311         return type.
5312         (sol_thread_target::pid_to_str): Change return type.
5313         * remote.c (class remote_target) <pid_to_str>: Change return
5314         type.
5315         (remote_target::pid_to_str): Change return type.
5316         (extended_remote_target::attach, remote_target::remote_stop_ns)
5317         (remote_target::remote_notif_remove_queued_reply)
5318         (remote_target::push_stop_reply, remote_target::disable_btrace):
5319         Update.
5320         (extended_remote_target::attach): Update.
5321         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5322         type.
5323         (gdbsim_target::pid_to_str): Change return type.
5324         * ravenscar-thread.c (struct ravenscar_thread_target)
5325         <pid_to_str>: Change return type.
5326         (ravenscar_thread_target::pid_to_str): Change return type.
5327         * procfs.c (class procfs_target) <pid_to_str>: Change return
5328         type.
5329         (procfs_target::pid_to_str): Change return type.
5330         (procfs_target::attach): Update.
5331         (procfs_target::detach): Update.
5332         (procfs_target::fetch_registers): Update.
5333         (procfs_target::store_registers): Update.
5334         (procfs_target::wait): Update.
5335         (procfs_target::files_info): Update.
5336         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5337         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5338         return type.
5339         (nto_procfs_target::pid_to_str): Change return type.
5340         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5341         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5342         return type.
5343         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5344         (exit_lwp): Update.
5345         (attach_proc_task_lwp_callback, get_detach_signal)
5346         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5347         (linux_nat_target::resume, wait_lwp, stop_callback)
5348         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5349         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5350         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5351         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5352         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5353         type.
5354         (inf_ptrace_target::attach): Update.
5355         (inf_ptrace_target::files_info): Update.
5356         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5357         type.
5358         (go32_nat_target::pid_to_str): Change return type.
5359         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5360         (gnu_nat_target::wait): Update.
5361         (gnu_nat_target::wait): Update.
5362         (gnu_nat_target::resume): Update.
5363         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5364         (fbsd_nat_target::wait): Update.
5365         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5366         type.
5367         (darwin_nat_target::attach): Update.
5368         * corelow.c (class core_target) <pid_to_str>: Change return type.
5369         (core_target::pid_to_str): Change return type.
5370         * target.c (normal_pid_to_str): Change return type.
5371         (default_pid_to_str): Likewise.
5372         (target_pid_to_str): Change return type.
5373         (target_translate_tls_address): Update.
5374         (target_announce_detach): Update.
5375         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5376         return type.
5377         (bsd_uthread_target::pid_to_str): Change return type.
5378         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5379         type.
5380         (bsd_kvm_target::pid_to_str): Change return type.
5381         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5382         return type.
5383         (aix_thread_target::pid_to_str): Change return type.
5384         * target.h (struct target_ops) <pid_to_str>: Change return type.
5385         (target_pid_to_str, normal_pid_to_str): Likewise.
5386         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5387         type.
5388         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5389         type.
5390         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5391         return type.
5392         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5393         type.
5394         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5395         type.
5396         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5397         return type.
5398
5399 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5400
5401         * NEWS: Mention that the new default MI version is 3.  Mention
5402         changes to the output of commands and events that deal with
5403         multi-location breakpoints.
5404         * breakpoint.c: Include "mi/mi-out.h".
5405         (print_one_breakpoint): Change output syntax if using MI version
5406         >= 3.
5407         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5408         New.
5409         (mi_multi_location_breakpoint_output_fixed): New.
5410         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5411         (mi_cmd_fix_multi_location_breakpoint_output): New.
5412         (mi_multi_location_breakpoint_output_fixed): New.
5413         * mi/mi-cmds.c (mi_cmds): Register command
5414         -fix-multi-location-breakpoint-output.
5415         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5416         interpreter "mi".
5417
5418 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5419
5420         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5421         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5422         instantiate mi_ui_out based on interpreter name.
5423         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5424         * mi/mi-main.c (mi_load_progress): Likewise.
5425
5426 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5427
5428         * NEWS: Combine separate "New targets" sections for 8.3.
5429
5430 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5431
5432         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5433         (ppcfbsd_init_abi): Install gdbarch
5434         "fetch_tls_load_module_address" and "get_thread_local_address"
5435         methods.
5436
5437 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5438
5439         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5440         (riscv_fbsd_init_abi): Install gdbarch
5441         "fetch_tls_load_module_address" and "get_thread_local_address"
5442         methods.
5443
5444 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5445
5446         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5447         (i386fbsd_init_abi): Install gdbarch
5448         "fetch_tls_load_module_address" and "get_thread_local_address"
5449         methods.
5450
5451 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5452
5453         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5454         (amd64fbsd_init_abi): Install gdbarch
5455         "fetch_tls_load_module_address" and "get_thread_local_address"
5456         methods.
5457
5458 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5459
5460         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5461         (struct fbsd_pspace_data): New type.
5462         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5463         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5464         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5465         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5466         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5467
5468 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5469
5470         * gdbtypes.c (lookup_struct_elt): New function.
5471         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5472         * gdbtypes.h (struct struct_elt): New type.
5473         (lookup_struct_elt): New prototype.
5474
5475 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5476
5477         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5478         remove disabled code block.
5479
5480 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5481
5482         * gdbarch.sh (get_thread_local_address): New method.
5483         * gdbarch.h, gdbarch.c: Regenerate.
5484         * target.c (target_translate_tls_address): Use
5485         gdbarch_get_thread_local_address if present instead of
5486         target::get_thread_local_address.
5487
5488 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5489
5490         * target.h (target::get_thread_local_address): Update comment.
5491
5492 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5493
5494         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5495         objfile->separate_debug_objfile_backlink if not NULL.
5496
5497 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5498
5499         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5500         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5501         (amd64bsd_store_inferior_registers): Likewise.
5502         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5503         Enable segment base registers.
5504         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5505         PT_GETFSBASE and PT_GETGSBASE.
5506         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5507         PT_SETGSBASE.
5508         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5509         segment base registers.
5510         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5511
5512 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5513
5514         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5515         Update calls to i386_target_description to add 'segments'
5516         parameter.
5517         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5518         add segment base registers.
5519         * arch/i386.c (i386_create_target_description): Add 'segments'
5520         parameter to enable segment base registers.
5521         * arch/i386.h (i386_create_target_description): Likewise.
5522         * features/i386/32bit-segments.xml: New file.
5523         * features/i386/32bit-segments.c: Generate.
5524         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5525         call to i386_target_description to add 'segments' parameter.
5526         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5527         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5528         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5529         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5530         if feature is present.
5531         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5532         Add 'segments' parameter to call to i386_target_description.
5533         (i386_target_description): Add 'segments' parameter to enable
5534         segment base registers.
5535         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5536         to call to i386_target_description.
5537         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5538         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5539         Define I386_NUM_REGS.
5540         (i386_target_description): Add 'segments' parameter to enable
5541         segment base registers.
5542
5543 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5544
5545         PR/24325
5546         * source-cache.c: #undef open and close, to avoid unresolved
5547         externals during linking.
5548
5549 2019-03-12  Tom Tromey  <tromey@adacore.com>
5550
5551         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5552         const.  Add initializers.
5553         (_initialize_remote): Don't initialize ptid globals.
5554
5555 2019-03-12  Pedro Alves  <palves@redhat.com>
5556
5557         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5558
5559 2019-03-12  Pedro Alves  <palves@redhat.com>
5560
5561         * cp-name-parser.y (main): Remove unused 'len' variable.
5562
5563 2019-03-12  Tom Tromey  <tromey@adacore.com>
5564
5565         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5566         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5567
5568 2019-03-12  Tom Tromey  <tromey@adacore.com>
5569
5570         * linux-nat.c (iterate_over_lwps): Update.
5571         (stop_callback): Remove parameter.
5572         (stop_wait_callback, detach_callback, resume_set_callback)
5573         (select_singlestep_lwp_callback, set_ignore_sigint)
5574         (status_callback, resumed_callback, resume_clear_callback)
5575         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5576         data parameter.
5577         (linux_nat_target::detach, linux_nat_target::resume)
5578         (linux_stop_and_wait_all_lwps, select_event_lwp)
5579         (linux_nat_filter_event, linux_nat_wait_1)
5580         (linux_nat_target::kill, linux_nat_target::stop)
5581         (linux_nat_target::stop): Update.
5582         (linux_nat_resume_callback): Change type.
5583         (resume_stopped_resumed_lwps, count_events_callback)
5584         (select_event_lwp_callback): Likewise.
5585         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5586         * arm-linux-nat.c (struct update_registers_data): Remove.
5587         (update_registers_callback): Change type.
5588         (arm_linux_insert_hw_breakpoint1): Update.
5589         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5590         parameter.
5591         (x86_linux_dr_set_addr): Update.
5592         (x86_linux_dr_set_control): Update.
5593         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5594         (iterate_over_lwps): Use gdb::function_view.
5595         * nat/aarch64-linux-hw-point.c (struct
5596         aarch64_dr_update_callback_param): Remove.
5597         (debug_reg_change_callback): Change type.
5598         (aarch64_notify_debug_reg_change): Update.
5599         * s390-linux-nat.c (s390_refresh_per_info): Update.
5600
5601 2019-03-11  Tom Tromey  <tromey@adacore.com>
5602
5603         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5604         redundant assignment to "this_cu".
5605
5606 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5607
5608         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5609
5610 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5611
5612         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5613         from...
5614         (rank_one_type): ... this.
5615
5616 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5617
5618         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5619         from...
5620         (rank_one_type): ... this.
5621
5622 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5623
5624         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5625         from...
5626         (rank_one_type): ... this.
5627
5628 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5629
5630         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5631         from...
5632         (rank_one_type): ... this.
5633
5634 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5635
5636         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5637         from...
5638         (rank_one_type): ... this.
5639
5640 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5641
5642         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5643         from...
5644         (rank_one_type): ... this.
5645
5646 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5647
5648         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5649         from...
5650         (rank_one_type): ... this.
5651
5652 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5653
5654         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5655         from...
5656         (rank_one_type): ... this.
5657
5658 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5659
5660         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5661         from...
5662         (rank_one_type): ... this.
5663
5664 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5665
5666         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5667         from...
5668         (rank_one_type): ... this.
5669
5670 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5671
5672         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5673         from...
5674         (rank_one_type): ... this.
5675
5676 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5677
5678         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5679         from...
5680         (rank_one_type): ... this.
5681
5682 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5683
5684         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5685         inferior-events' shows the example events.
5686
5687 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5688
5689         Support styling on native MS-Windows console
5690
5691         PR/24315
5692         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5693         on MS-Windows if $TERM is not defined.
5694
5695         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5696
5697         * posix-hdep.c (gdb_console_fputs):
5698         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5699         functions.
5700         * ui-file.h (gdb_console_fputs): Add prototype.
5701
5702         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5703         back to fputs only if the former returns zero.
5704
5705 2019-03-07  Tom Tromey  <tom@tromey.com>
5706
5707         * symmisc.c (print_symbol_bcache_statistics): Update.
5708         (print_objfile_statistics): Update.
5709         * symfile.c (allocate_symtab): Update.
5710         * stabsread.c: Don't include bcache.h.
5711         * psymtab.h (struct psymbol_bcache): Don't declare.
5712         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5713         (psymbol_bcache_init, psymbol_bcache_free)
5714         (psymbol_bcache_get_bcache): Don't declare.
5715         * psymtab.c (struct psymbol_bcache): Remove.
5716         (psymtab_storage::psymtab_storage): Update.
5717         (psymtab_storage::~psymtab_storage): Update.
5718         (psymbol_bcache_init, psymbol_bcache_free)
5719         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5720         (add_psymbol_to_bcache): Update.
5721         (allocate_psymtab): Update.
5722         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5723         macro_cache>: No longer pointers.
5724         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5725         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5726         * macrotab.c (macro_bcache): Update.
5727         * macroexp.c: Don't include bcache.h.
5728         * gdbtypes.c (check_types_worklist): Update.
5729         (types_deeply_equal): Remove TRY/CATCH.  Update.
5730         * elfread.c (elf_symtab_read): Update.
5731         * dwarf2read.c: Don't include bcache.h.
5732         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5733         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5734         (print_bcache_statistics, bcache_memory_used): Don't declare.
5735         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5736         methods.  Rename all data members.
5737         * bcache.c (struct bcache): Move to bcache.h.
5738         (bcache::expand_hash_table): Rename from expand_hash_table.
5739         (bcache): Remove.
5740         (bcache::insert): Rename from bcache_full.
5741         (bcache::compare): Rename from bcache_compare.
5742         (bcache_xmalloc): Remove.
5743         (bcache::~bcache): Rename from bcache_xfree.
5744         (bcache::print_statistics): Rename from print_bcache_statistics.
5745         (bcache::memory_used): Rename from bcache_memory_used.
5746
5747 2019-03-07  Pedro Alves  <palves@redhat.com>
5748
5749         * infrun.c (normal_stop): Also check for
5750         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5751
5752 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5753
5754         * f-lang.c (value_from_host_double): Moved to...
5755         * value.c (value_from_host_double): ...here.
5756         * value.h (value_from_host_double): Declare.
5757         * guile/scm-math.c (vlscm_convert_typed_number): Use
5758         value_from_host_double.
5759         (vlscm_convert_number): Likewise.
5760         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5761         * python/py-value.c (convert_value_from_python): Likewise.
5762
5763 2019-03-06  Tom Tromey  <tom@tromey.com>
5764
5765         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5766
5767 2019-03-06  Tom Tromey  <tom@tromey.com>
5768
5769         * utils.h (free_current_contents): Don't declare.
5770         * utils.c (free_current_contents): Remove.
5771
5772 2019-03-06  Tom Tromey  <tom@tromey.com>
5773
5774         * top.c (quit_force): Update.
5775         * main.c (captured_command_loop): Update.
5776         * common/new-op.c (operator new): Update.
5777         * common/common-exceptions.c (struct catcher)
5778         <save_cleanup_chain>: Remove member.
5779         (exceptions_state_mc_init): Update.
5780         (exception_try_scope_entry): Return nullptr.
5781         (exception_try_scope_exit, exception_rethrow)
5782         (throw_exception_sjlj, throw_exception_cxx): Update.
5783         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5784         (all_cleanups, do_cleanups, discard_cleanups)
5785         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5786         (restore_cleanups, restore_final_cleanups): Don't declare.
5787         (do_final_cleanups): Remove parameter.
5788         * common/cleanups.c (cleanup_chain, make_cleanup)
5789         (make_cleanup_dtor, all_cleanups, do_cleanups)
5790         (discard_my_cleanups, discard_cleanups)
5791         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5792         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5793         (null_cleanup): Remove.
5794         (do_final_cleanups): Remove parameter.
5795
5796 2019-03-06  Tom Tromey  <tom@tromey.com>
5797
5798         * remote.c (remote_target::remote_parse_stop_reply): Use
5799         unique_xmalloc_ptr.
5800
5801 2019-03-06  Tom Tromey  <tom@tromey.com>
5802
5803         * stabsread.c (struct stabs_field_info): Rename from field_info.
5804         <list, fnlist>: Add initializers.
5805         <obstack>: New member.
5806         (read_member_functions, read_struct_fields, read_baseclasses):
5807         Allocate on obstack.  Don't use cleanups.
5808         (read_one_struct_field, read_member_functions, read_struct_fields)
5809         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5810         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5811         (read_struct_type): Update.
5812
5813 2019-03-06  Tom Tromey  <tom@tromey.com>
5814
5815         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5816         * common/filestuff.h (make_cleanup_close): Don't declare.
5817         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5818         Remove.
5819
5820 2019-03-06  Tom Tromey  <tom@tromey.com>
5821
5822         * solib-aix.c: Use make_scope_exit.
5823
5824 2019-03-06  Tom Tromey  <tom@tromey.com>
5825
5826         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5827         Use make_scope_exit.
5828
5829 2019-03-06  Tom Tromey  <tom@tromey.com>
5830
5831         * solib-svr4.c (disable_probes_interface): Remove parameter.
5832         (svr4_handle_solib_event): Use make_scope_exit.
5833
5834 2019-03-06  Tom Tromey  <tom@tromey.com>
5835
5836         * remote.c (struct stop_reply_deleter): Remove.
5837         (stop_reply_up): Update.
5838         (struct stop_reply): Derive from notif_event.  Don't typedef.
5839         <regcache>: Now a std::vector.
5840         (stop_reply_xfree): Remove.
5841         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5842         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5843         (remote_target::discard_pending_stop_replies): Use delete.
5844         (remote_target::remote_parse_stop_reply): Update.
5845         (remote_target::process_stop_reply): Update.
5846         * remote-notif.h (struct notif_event): Add virtual destructor.
5847         Remove "dtr" member.
5848         (struct notif_client) <alloc_event>: Return a unique_ptr.
5849         (notif_event_xfree): Don't declare.
5850         (notif_event_up): New typedef.
5851         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5852         (notif_event_xfree, do_notif_event_xfree): Remove.
5853         (remote_notif_state_xfree): Update.
5854
5855 2019-03-06  Tom Tromey  <tom@tromey.com>
5856
5857         * infrun.c (displaced_step_clear_cleanup): Now a
5858         forward_scope_exit type.
5859         (displaced_step_prepare_throw): Update.
5860         (displaced_step_fixup): Update.
5861
5862 2019-03-06  Tom Tromey  <tom@tromey.com>
5863
5864         * inferior.h (class inferior): Update comment.
5865         * gdbthread.h (class thread_info): Update comment.
5866
5867 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5868             Tom Tromey  <tom@tromey.com>
5869
5870         * stabsread.h (struct stab_section_list): Remove.
5871         (coffstab_build_psymtabs): Update.
5872         * dbxread.c (symbuf_sections): Now a std::vector.
5873         (sect_idx): New global.
5874         (fill_symbuf): Update.
5875         (coffstab_build_psymtabs): Change type of stabsects parameter.
5876         Update.
5877         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5878         std::vector.
5879         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5880         (coff_locate_sections): Update.
5881         (coff_symfile_read): Remove cleanups.  Update.
5882         (init_stringtab): Add storage parameter.
5883         (free_stringtab, free_stringtab_cleanup): Remove.
5884         (init_lineno): Add storage parameter.
5885         (free_linetab, free_linetab_cleanup): Remove.
5886
5887 2019-03-06  Pedro Alves  <palves@redhat.com>
5888
5889         * linux-fork.c (fork_info::clobber_regs): Delete.
5890         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5891         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5892         comment.  Adjust.
5893         (scoped_switch_fork_info::scoped_switch_fork_info)
5894         (checkpoint_command, linux_fork_context): Adjust
5895         fork_save_infrun_state calls.
5896
5897 2019-03-06  Pedro Alves  <palves@redhat.com>
5898
5899         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5900         (inf_has_multiple_threads): Return 'bool' and rewrite using
5901         inferior_info::threads().
5902
5903 2019-03-06  Pedro Alves  <palves@redhat.com>
5904
5905         * linux-fork.c: Include <list>.
5906         (fork_list): Now a std::list instance.
5907         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5908         (forks_exist_p, find_last_fork): Adjust.
5909         (new_fork): Delete.
5910         (one_fork_p): New.
5911         (add_fork): Adjust.
5912         (free_fork): Delete, folded into fork_info::~fork_info().
5913         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5914         Adjust.
5915         (init_fork_list): Delete.
5916         (linux_fork_killall, linux_fork_mourn_inferior)
5917         (linux_fork_detach, info_checkpoints_command): Adjust.
5918         (_initialize_linux_fork): No longer call init_fork_list.
5919
5920 2019-03-06  Pedro Alves  <palves@redhat.com>
5921
5922         * linux-fork.c (new_fork): New, split out of ...
5923         (add_fork): ... this.  Return void.  Move "first fork" special
5924         case from here, to ...
5925         (checkpoint_command): ... here.
5926         * linux-linux.h (add_fork): Return void.
5927
5928 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5929
5930         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5931
5932 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5933             Chris January  <chris.january@arm.com>
5934             David Lecomber  <david.lecomber@arm.com>
5935
5936         * f-exp.y: New token, UNOP_INTRINSIC.
5937         (exp): New pattern using UNOP_INTRINSIC token.
5938         (f77_keywords): Add 'abs' keyword.
5939         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5940         (value_from_host_double): New function.
5941         (evaluate_subexp_f): Support UNOP_ABS.
5942
5943 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5944
5945         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5946         types.
5947
5948 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5949
5950         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5951         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5952         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5953
5954 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5955
5956         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5957
5958 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5959             Chris January  <chris.january@arm.com>
5960
5961         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5962         * f-exp.y: Define 'KIND' token.
5963         (exp): New pattern for KIND expressions.
5964         (ptype): Handle types with a kind extension.
5965         (direct_abs_decl): Extend to spot kind extensions.
5966         (f77_keywords): Add 'kind' to the list.
5967         (push_kind_type): New function.
5968         (convert_to_kind_type): New function.
5969         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5970         * parse.c (operator_length_standard): Likewise.
5971         * parser-defs.h (enum type_pieces): Add tp_kind.
5972         * std-operator.def: Add UNOP_KIND.
5973
5974 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5975
5976         * f-exp.y (f_parse): Set yydebug.
5977
5978 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5979
5980         * f-lang.c (evaluate_subexp_f): New function.
5981         (exp_descriptor_f): New global.
5982         (f_language_defn): Use exp_descriptor_f instead of
5983         exp_descriptor_standard.
5984
5985 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5986
5987         * f-exp.y (struct token): Add comments.
5988         (dot_ops): Remove uppercase versions and the end marker.
5989         (f77_keywords): Likewise.
5990         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5991         entries in the dot_ops array are case insensitive, and use
5992         strncasecmp to compare strings.  Also some whitespace cleanup in
5993         this area.  Similar for the f77_keywords array, except entries in
5994         this list might be case sensitive.
5995
5996 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5997
5998         * f-exp.y (struct f77_boolean_val): Add comments.
5999         (boolean_values): Remove uppercase versions, and end marker.
6000         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6001         and use strncasecmp to achieve case insensitivity.  Additionally,
6002         perform whitespace cleanup around this code.
6003
6004 2019-03-06  Tom Tromey  <tromey@adacore.com>
6005
6006         * remote-sim.c (gdbsim_target_open): Use result of
6007         gdb_argv::release.
6008
6009 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6010         Dirk Schubert  <dirk.schubert@arm.com>
6011         Chris January  <chris.january@arm.com>
6012
6013         * eval.c (evaluate_subexp_standard): Call Fortran argument
6014         wrapping logic.
6015         * f-lang.c (struct value): A value which can be passed into a
6016         Fortran function call.
6017         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6018         where appropriate.
6019         (struct type): Value ready for a Fortran function call.
6020         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6021         is needed.
6022         * f-lang.h (fortran_argument_convert): Declaration.
6023         (fortran_preserve_arg_pointer): Declaration.
6024         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6025
6026 2019-03-05  Tom Tromey  <tromey@adacore.com>
6027
6028         * python/py-prettyprint.c (print_string_repr): Remove #if.
6029         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6030
6031 2019-03-05  Tom Tromey  <tromey@adacore.com>
6032
6033         * target.c (the_dummy_target): Move later.  Change type to
6034         "dummy_target".
6035         (initialize_targets): Don't initialize the_dummy_target.
6036
6037 2019-03-05  Tom Tromey  <tromey@adacore.com>
6038
6039         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6040         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6041
6042 2019-03-05  Tom Tromey  <tromey@adacore.com>
6043
6044         * windows-nat.c (windows_nat_target::attach)
6045         (windows_nat_target::detach): Don't call gdb_flush.
6046         * valprint.c (generic_val_print, val_print, val_print_string):
6047         Don't call gdb_flush.
6048         * utils.c (defaulted_query): Don't call gdb_flush.
6049         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6050         * target.c (target_announce_detach): Don't call gdb_flush.
6051         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6052         * remote.c (extended_remote_target::attach): Don't call
6053         gdb_flush.
6054         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6055         * printcmd.c (do_examine): Don't call gdb_flush.
6056         (info_display_command): Don't call gdb_flush.
6057         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6058         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6059         * memattr.c (info_mem_command): Don't call gdb_flush.
6060         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6061         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6062         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6063         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6064         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6065         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6066         (gnu_nat_target::detach): Don't call gdb_flush.
6067         * f-valprint.c (f_val_print): Don't call gdb_flush.
6068         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6069         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6070         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6071         gdb_flush.
6072         * c-valprint.c (c_val_print): Don't call gdb_flush.
6073         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6074
6075 2019-03-05  Tom Tromey  <tromey@adacore.com>
6076
6077         * varobj.c (update_dynamic_varobj_children): Update.
6078         (install_default_visualizer): Use reset, not release.
6079         * value.c (set_internalvar): Update.
6080         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6081         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6082         ATTRIBUTE_UNUSED_RESULT.
6083
6084 2019-03-05  Tom Tromey  <tromey@adacore.com>
6085
6086         * remote.c (class scoped_remote_fd) <release>: Add
6087         ATTRIBUTE_UNUSED_RESULT.
6088
6089 2019-03-05  Tom Tromey  <tromey@adacore.com>
6090
6091         * macroexp.c (struct macro_buffer) <release>: Add
6092         ATTRIBUTE_UNUSED_RESULT.
6093
6094 2019-03-05  Tom Tromey  <tromey@adacore.com>
6095
6096         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6097         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6098         ATTRIBUTE_UNUSED_RESULT.
6099
6100 2019-03-05  Tom Tromey  <tromey@adacore.com>
6101
6102         * common/scoped_fd.h (class scoped_fd) <release>: Add
6103         ATTRIBUTE_UNUSED_RESULT.
6104
6105 2019-03-05  Tom Tromey  <tromey@adacore.com>
6106
6107         * parser-defs.h (struct parser_state) <release>: Add
6108         ATTRIBUTE_UNUSED_RESULT.
6109
6110 2019-03-05  Tom Tromey  <tromey@adacore.com>
6111
6112         * utils.h (class gdb_argv) <release>: Add
6113         ATTRIBUTE_UNUSED_RESULT.
6114         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6115
6116 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6117
6118         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6119         for-loop range, to avoid compiler warnings.
6120
6121         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6122         avoid compiler warnings about unused variables.
6123
6124         * NEWS: Mention end of support for native debugging on MS-Windows
6125         before XP.
6126
6127         PR gdb/24292
6128         * common/netstuff.c:
6129         * gdbserver/gdbreplay.c
6130         * gdbserver/remote-utils.c:
6131         * ser-tcp.c:
6132         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6133         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6134         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6135         'getaddrinfo' and 'freeaddrinfo' were not available before
6136         Windows XP, and mingw.org's MinGW headers by default define
6137         _WIN32_WINNT to 0x500.
6138
6139 2019-03-01  Gary Benson <gbenson@redhat.com>
6140
6141         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6142
6143 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6144             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6145
6146         PR gdb/8527
6147         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6148         set_sigint_trap, clear_sigint_trap.
6149
6150 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6151
6152         * target.c (target_detach): Clear the regcache and the
6153         frame cache.
6154
6155 2019-02-27  Pedro Alves  <palves@redhat.com>
6156
6157         * utils.c (set_screen_size): When we cap the height/width sizes,
6158         tweak the corresponding command variable to show "unlimited":
6159
6160 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6161             Pedro Alves  <palves@redhat.com>
6162
6163         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6164         before calling rl_set_screen_size.
6165
6166 2019-02-27  Tom Tromey  <tromey@adacore.com>
6167
6168         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6169         define.
6170         * python/py-value.c: Remove Python 2.4 workaround.
6171         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6172         workaround.
6173         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6174         Python 2.4 workaround.
6175         * python/python-internal.h: Remove Python 2.4 comment.
6176         (Py_ssize_t): Don't define.
6177         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6178         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6179         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6180         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6181         * python/python.c (do_start_initialization): Remove Python 2.4
6182         workaround.
6183         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6184         (print_children): Remove Python 2.4 workaround.
6185         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6186         workaround.
6187         (CHARBUFFERPROC_NAME): Remove.
6188         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6189         Python 2.4 workaround.
6190
6191 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6192
6193         * NEWS: Note minimum Python version.
6194
6195 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6196
6197         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6198         code from these functions.  Remove corresponding ifdefs.  Use
6199         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6200         Remove gotos and target of gotos.
6201         (infpy_search_memory): Likewise.
6202
6203 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6204
6205         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6206         (hppa_gdbarch_init): Don't register deleted functions with
6207         gdbarch.
6208
6209 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6210
6211         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6212         (h8300_unwind_sp): Delete.
6213         (h8300_dummy_id): Delete.
6214         (h8300_gdbarch_init): Don't register deleted functions with
6215         gdbarch.
6216
6217 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6218
6219         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6220         (ft32_unwind_pc): Delete.
6221         (ft32_unwind_sp): Delete.
6222         (ft32_gdbarch_init): Don't register deleted functions with
6223         gdbarch.
6224
6225 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6226
6227         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6228         (frv_unwind_pc): Delete.
6229         (frv_unwind_sp): Delete.
6230         (frv_gdbarch_init): Don't register deleted functions with
6231         gdbarch.
6232
6233 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6234
6235         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6236         (riscv_unwind_pc): Delete.
6237         (riscv_unwind_sp): Delete.
6238         (riscv_gdbarch_init): Don't register deleted functions with
6239         gdbarch.
6240
6241 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6242
6243         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6244         (csky_unwind_pc): Delete.
6245         (csky_unwind_sp): Delete.
6246         (csky_gdbarch_init): Don't register deleted functions with
6247         gdbarch.
6248
6249 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6250
6251         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6252         (cris_unwind_pc): Delete.
6253         (cris_unwind_sp): Delete.
6254         (cris_gdbarch_init): Don't register deleted functions with
6255         gdbarch.
6256
6257 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6258
6259         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6260         (bfin_unwind_pc): Delete.
6261         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6262
6263 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6264
6265         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6266         (arm_unwind_pc): Delete.
6267         (arm_unwind_sp): Delete.
6268         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6269
6270 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6271
6272         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6273         (arc_unwind_pc): Delete.
6274         (arc_unwind_sp): Delete.
6275         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6276
6277 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6278
6279         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6280         (alpha_unwind_pc): Delete.
6281         (alpha_gdbarch_init): Don't register deleted functions with
6282         gdbarch.
6283
6284 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6285
6286         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6287         (aarch64_unwind_pc): Delete.
6288         (aarch64_unwind_sp): Delete.
6289         (aarch64_gdbarch_init): Don't register deleted functions with
6290         gdbarch.
6291
6292 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6293
6294         * gdbtypes.c (type_align): Don't consider static members when
6295         computing structure alignment.
6296
6297 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6298
6299         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6300         return 0 for other types.
6301         * arch-utils.c (default_type_align): Always return 0.
6302         * gdbarch.h: Regenerate.
6303         * gdbarch.sh (type_align): Extend comment.
6304         * gdbtypes.c (type_align): Add additional comments, always call
6305         gdbarch_type_align before applying the default rules.
6306         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6307         generic code will then apply a suitable default.
6308         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6309         types, return 0 for other types.
6310
6311 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6312
6313         * NEWS: Create a new section for the next release branch.
6314         Rename the section of the current branch, now that it has
6315         been cut.
6316
6317 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6318
6319         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6320         * version.in: Bump version to 8.3.50.DATE-git.
6321
6322 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6323
6324         * aix-thread.c (ptid_cmp): Remove unused variable.
6325         (get_signaled_thread): Likewise.
6326         (store_regs_user_thread): Likewise.
6327         (store_regs_kernel_thread): Likewise.
6328         (fetch_regs_kernel_thread): Remove shadowed variable.
6329
6330 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6331
6332         * features/riscv/32bit-cpu.xml: Add register numbers.
6333         * features/riscv/32bit-fpu.c: Regenerate.
6334         * features/riscv/32bit-fpu.xml: Add register numbers.
6335         * features/riscv/64bit-cpu.xml: Add register numbers.
6336         * features/riscv/64bit-fpu.c: Regenerate.
6337         * features/riscv/64bit-fpu.xml: Add register numbers.
6338
6339 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6340
6341         * NEWS: Mention two argument form of gdb.Value constructor.
6342         * python/py-value.c (convert_buffer_and_type_to_value): New
6343         function.
6344         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6345         Add support for handling an optional second argument.  Call
6346         convert_buffer_and_type_to_value as appropriate.
6347         * python/python-internal.h (Py_buffer_deleter): New struct.
6348         (Py_buffer_up): New typedef.
6349
6350 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6351
6352         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6353         instead of releasing ownership.
6354
6355 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6356
6357         * dwarf2read.c (open_and_init_dwp_file): Call
6358         elf_numsections instead of bfd_count_sections to initialize
6359         dwp_file->num_sections.
6360
6361 2019-02-25  Tom Tromey  <tromey@adacore.com>
6362
6363         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6364
6365 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6366
6367         * gcore.in: Add '--readnever' option when invoking GDB.
6368
6369 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6370
6371         * MAINTAINERS: Update my email address.
6372
6373 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6374
6375         * build-id.c (build_id_to_debug_bfd_1): New function.
6376         (build_id_to_debug_bfd): Look for separate debug file in
6377         sysroot.
6378
6379 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6380
6381         * gdbarch.sh: Update the copyright year range that is placed into
6382         generated files.
6383
6384 2019-02-22  Keith Seitz  <keiths@redhat.com>
6385
6386         PR symtab/23853
6387         * linespec.c (create_sals_line_offset): Search for the default
6388         symtab's filename instead of its fullname.
6389
6390 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6391
6392         * NEWS: Update style defaults.
6393
6394 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6395
6396         * main.c (captured_main_1): Disable styling in batch mode.
6397
6398 2019-02-20  Tom Tromey  <tom@tromey.com>
6399
6400         * symtab.c (symtab_symbol_info): Fix typos.
6401
6402 2019-02-20  Tom Tromey  <tromey@adacore.com>
6403
6404         * findcmd.c (_initialize_mem_search): Use upper case for
6405         metasyntactic variables.
6406
6407 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6408
6409         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6410         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6411
6412 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6413
6414         * top.h (source_file_name): Change to std::string.
6415         * top.c (source_file_name): Likewise.
6416         (command_line_input): Adjust.
6417         * cli/cli-script.c (script_from_file): Adjust.
6418
6419 2019-02-19  Tom Tromey  <tromey@adacore.com>
6420
6421         * ravenscar-thread.c
6422         (ravenscar_thread_target::update_thread_list): Don't call
6423         ada_build_task_list.
6424         * ada-lang.h (ada_build_task_list): Don't declare.
6425         * ada-tasks.c (struct ada_tasks_inferior_data)
6426         <task_list_valid_p>: Now bool.
6427         (read_known_tasks, ada_task_list_changed)
6428         (ada_tasks_invalidate_inferior_data): Update.
6429         (read_known_tasks_array): Return bool.
6430         (read_known_tasks_list): Likewise.
6431         (read_known_tasks): Return void.
6432         (ada_build_task_list): Now static.
6433
6434 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6435
6436         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6437         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6438
6439 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6440
6441         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6442         variant for ada_tasks_pspace_data_handle and
6443         ada_tasks_inferior_data_handle.
6444         (ada_tasks_pspace_data_cleanup): New function.
6445         (ada_tasks_inferior_data_cleanup): New function.
6446
6447 2019-02-17  Tom Tromey  <tom@tromey.com>
6448
6449         * macrotab.h (macro_source_fullname): Return a std::string.
6450         * macrotab.c (macro_include, check_for_redefinition)
6451         (macro_undef, macro_lookup_definition, foreach_macro)
6452         (foreach_macro_in_scope): Update.
6453         (macro_source_fullname): Return a std::string.
6454         * macrocmd.c (show_pp_source_pos): Update.
6455
6456 2019-02-17  Tom Tromey  <tom@tromey.com>
6457
6458         * macrocmd.c (show_pp_source_pos): Style the file names.
6459
6460 2019-02-17  Tom Tromey  <tom@tromey.com>
6461
6462         PR tui/24197:
6463         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6464
6465 2019-02-17  Tom Tromey  <tom@tromey.com>
6466
6467         * ada-lang.c (user_select_syms): Use filtered printing.
6468         * utils.c (wrap_style): New global.
6469         (desired_style): Remove.
6470         (emit_style_escape): Add stream parameter.
6471         (set_output_style, reset_terminal_style, prompt_for_continue):
6472         Update.
6473         (flush_wrap_buffer): Only flush gdb_stdout.
6474         (wrap_here): Set wrap_style.
6475         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6476         treat escape sequences as a character.  Change when wrap buffer is
6477         flushed.
6478         (fputs_styled): Do not set the output style when the default is
6479         requested.
6480         * ui-style.h (struct ui_file_style) <is_default>: New method.
6481         * source.c (print_source_lines_base): Emit escape sequences in one
6482         piece.
6483
6484 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6485
6486         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6487         integers and enumeration types.
6488
6489 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6490
6491         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6492         instead of lookup_symbol_in_language
6493         (do_exact_match): New function.
6494         (ada_get_symbol_name_matcher): Return do_exact_match when
6495         doing a verbatim match.
6496
6497 2019-02-15  Tom Tromey  <tromey@adacore.com>
6498
6499         * ravenscar-thread.c (ravenscar_thread_target::resume)
6500         (ravenscar_thread_target::wait): Special case wildcard requests.
6501
6502 2019-02-15  Tom Tromey  <tromey@adacore.com>
6503
6504         * ravenscar-thread.c (base_ptid): Remove.
6505         (struct ravenscar_thread_target) <close>: New method.
6506         <m_base_ptid>: New member.
6507         <update_inferior_ptid, active_task, task_is_currently_active,
6508         runtime_initialized>: Declare methods.
6509         <ravenscar_thread_target>: Add constructor.
6510         (ravenscar_thread_target::task_is_currently_active)
6511         (ravenscar_thread_target::update_inferior_ptid)
6512         (ravenscar_runtime_initialized): Rename.  Now methods.
6513         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6514         (ravenscar_thread_target::update_thread_list): Update.
6515         (ravenscar_thread_target::active_task): Now method.
6516         (ravenscar_thread_target::store_registers)
6517         (ravenscar_thread_target::prepare_to_store)
6518         (ravenscar_thread_target::prepare_to_store)
6519         (ravenscar_thread_target::mourn_inferior): Update.
6520         (ravenscar_inferior_created): Use "new" to create target.
6521         (ravenscar_thread_target::get_ada_task_ptid): Update.
6522         (_initialize_ravenscar): Don't initialize base_ptid.
6523         (ravenscar_ops): Remove global.
6524
6525 2019-02-15  Tom Tromey  <tromey@adacore.com>
6526
6527         * target.h (push_target): Declare new overload.
6528         * target.c (push_target): New overload, taking an rvalue reference.
6529         * remote.c (remote_target::open_1): Use push_target overload.
6530         * corelow.c (core_target_open): Use push_target overload.
6531
6532 2019-02-15  Tom Tromey  <tromey@adacore.com>
6533
6534         * ravenscar-thread.c (is_ravenscar_task)
6535         (ravenscar_task_is_currently_active): Return bool.
6536         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6537         (_initialize_ravenscar): Remove "(void)".
6538         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6539         Return bool.
6540
6541 2019-02-15  Tom Tromey  <tromey@adacore.com>
6542
6543         * ravenscar-thread.c (ravenscar_runtime_initializer)
6544         (has_ravenscar_runtime, get_running_thread_id)
6545         (ravenscar_thread_target::resume): Fix indentation.
6546
6547 2019-02-15  Tom Tromey  <tromey@adacore.com>
6548
6549         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6550         from ravenscar_arch_ops.
6551         (sparc_ravenscar_ops::fetch_registers)
6552         (sparc_ravenscar_ops::store_registers): Now methods.
6553         (sparc_ravenscar_prepare_to_store): Remove.
6554         (sparc_ravenscar_ops): Redefine.
6555         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6556         methods and destructor.  Remove members.
6557         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6558         (ravenscar_thread_target::store_registers)
6559         (ravenscar_thread_target::prepare_to_store): Update.
6560         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6561         Remove.
6562         (struct ppc_ravenscar_powerpc_ops): Derive from
6563         ravenscar_arch_ops.
6564         (ppc_ravenscar_powerpc_ops::fetch_registers)
6565         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6566         (ppc_ravenscar_powerpc_ops): Redefine.
6567         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6568         (ppc_ravenscar_e500_ops::fetch_registers)
6569         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6570         (ppc_ravenscar_e500_ops): Redefine.
6571         * aarch64-ravenscar-thread.c
6572         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6573         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6574         (aarch64_ravenscar_fetch_registers)
6575         (aarch64_ravenscar_store_registers): Now methods.
6576         (aarch64_ravenscar_ops): Redefine.
6577
6578 2019-02-15  Tom Tromey  <tromey@adacore.com>
6579
6580         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6581         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6582         (ravenscar_thread_target::stopped_by_watchpoint)
6583         (ravenscar_thread_target::stopped_data_address)
6584         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6585
6586 2019-02-15  Tom Tromey  <tromey@adacore.com>
6587
6588         * ravenscar-thread.c: Fix some typos.
6589
6590 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6591             Tom Tromey  <tromey@adacore.com>
6592
6593         * ada-lang.c (ada_exception_sal): Change addr_string to a
6594         std::string.
6595         (create_ada_exception_catchpoint): Update.
6596
6597 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6598             Tom Tromey  <tromey@adacore.com>
6599
6600         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6601         (bp_location_ops): Remove.
6602         (base_breakpoint_allocate_location): Update.
6603         (free_bp_location): Update.
6604         * ada-lang.c (class ada_catchpoint_location)
6605         <ada_catchpoint_location>: Remove ops parameter.
6606         (ada_catchpoint_location_dtor): Remove.
6607         (ada_catchpoint_location_ops): Remove.
6608         (allocate_location_exception): Update.
6609         * breakpoint.h (struct bp_location_ops): Remove.
6610         (class bp_location) <bp_location>: Remove bp_location_ops
6611         parameter.
6612         <~bp_location>: Add destructor.
6613         <ops>: Remove.
6614
6615 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6616             Pedro Alves  <palves@redhat.com>
6617
6618         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6619         'PATH_MAX'.
6620
6621 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6622             Samuel Thibault  <samuel.thibault@gnu.org>
6623             Thomas Schwinge  <thomas@codesourcery.com>
6624
6625         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6626         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6627
6628 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6629
6630         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6631         (check_empty): Use "const char *".
6632
6633         * gnu-nat.c (gnu_nat_target::detach): Instead of
6634         'detach_inferior (pid)' call
6635         'detach_inferior (find_inferior_pid (pid))'.
6636
6637         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6638         'nat/fork-inferior.o'.
6639         * gnu-nat.c: #include "nat/fork-inferior.h".
6640
6641         * gnu-nat.c (gnu_nat_target::detach): Instead of
6642         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6643         * gnu-nat.h: #include "inf-child.h".
6644         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6645         'i386_gnu_nat_target::fetch_registers'.
6646         (gnu_store_registers): Rename/move to
6647         'i386_gnu_nat_target::store_registers'.
6648
6649         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6650         * gnu-nat.h (mach_thread_info): New function.
6651         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6652
6653         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6654
6655 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6656
6657         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6658
6659 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6660
6661         * windows-nat.c (windows_add_thread): Add new parameter
6662         "main_thread_p" with default value set to false.  Update
6663         function documentation as well as all callers.
6664         (windows_delete_thread): Likewise.
6665         (fake_create_process): Update call to windows_add_thread.
6666         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6667         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6668         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6669         call to windows_delete_thread.
6670
6671 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6672
6673         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6674
6675 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6676
6677         * symfile.c (find_separate_debug_file): Use canonical path of
6678         sysroot with child_path instead of gdb_sysroot if it is valid.
6679
6680 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6681
6682         * symfile.c (find_separate_debug_file): Use child_path to
6683         determine if an object file is under a sysroot.
6684
6685 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6686
6687         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6688         unittests/child-path-selftests.c.
6689         * common/pathstuff.c (child_path): New function.
6690         * common/pathstuff.h (child_path): New prototype.
6691         * unittests/child-path-selftests.c: New file.
6692
6693 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6694
6695         * symfile.c (find_separate_debug_file): Look for separate debug
6696         files in debug directories under the sysroot.
6697
6698 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6699
6700         * symtab.h (struct minimal_symbol data_p): New const method.
6701         (struct minimal_symbol text_p): Likewise.
6702         * symtab.c (output_source_filename): Use file name style
6703         to print file name.
6704         (print_symbol_info): Likewise.
6705         (print_msymbol_info): Use address style to print addresses.
6706         Use function name style to print executable text symbols.
6707         (expand_symtab_containing_pc): Use data_p.
6708         (find_pc_sect_compunit_symtab): Likewise.
6709
6710 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6711
6712         * breakpoint.c (describe_other_breakpoints): Use address style
6713         to print addresses.
6714         (say_where): Likewise.
6715
6716 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6717
6718         * ada-typeprint.c (print_func_type): Print function name
6719         style to print function name.
6720         * c-typeprint.c (c_print_type_1): Likewise.
6721
6722 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6723
6724         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6725         for execve.
6726
6727 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6728
6729         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6730         type_stack.
6731
6732 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6733
6734         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6735         TYPE_CODE_REF types.
6736
6737 2019-02-08  Jim Wilson  <jimw@sifive.com>
6738
6739         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6740         (riscv_linux_fregset): New.
6741         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6742
6743 2019-02-07  Tom Tromey  <tom@tromey.com>
6744
6745         * thread.c (thread_cancel_execution_command): Update.
6746         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6747         methods.
6748         (struct thread_fsm_ops): Remove.
6749         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6750         (thread_fsm_should_stop, thread_fsm_return_value)
6751         (thread_fsm_set_finished, thread_fsm_finished_p)
6752         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6753         Don't declare.
6754         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6755         * infrun.c (clear_proceed_status_thread)
6756         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6757         (print_stop_event): Update.
6758         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6759         Add constructor.
6760         (step_command_fsm_ops): Remove.
6761         (new_step_command_fsm): Remove.
6762         (step_1): Update.
6763         (step_command_fsm::should_stop): Rename from
6764         step_command_fsm_should_stop.
6765         (step_command_fsm::clean_up): Rename from
6766         step_command_fsm_clean_up.
6767         (step_command_fsm::do_async_reply_reason): Rename from
6768         step_command_fsm_async_reply_reason.
6769         (struct until_next_fsm): Inherit from thread_fsm.  Add
6770         constructor.
6771         (until_next_fsm_ops): Remove.
6772         (new_until_next_fsm): Remove.
6773         (until_next_fsm::should_stop): Rename from
6774         until_next_fsm_should_stop.
6775         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6776         (until_next_fsm::do_async_reply_reason): Rename from
6777         until_next_fsm_async_reply_reason.
6778         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6779         constructor.  Change type of breakpoint.
6780         (finish_command_fsm_ops): Remove.
6781         (new_finish_command_fsm): Remove.
6782         (finish_command_fsm::should_stop): Rename from
6783         finish_command_fsm_should_stop.
6784         (finish_command_fsm::clean_up): Rename from
6785         finish_command_fsm_clean_up.
6786         (finish_command_fsm::return_value): Rename from
6787         finish_command_fsm_return_value.
6788         (finish_command_fsm::do_async_reply_reason): Rename from
6789         finish_command_fsm_async_reply_reason.
6790         (finish_command): Update.
6791         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6792         Add constructor.
6793         (call_thread_fsm_ops): Remove.
6794         (call_thread_fsm::call_thread_fsm): Rename from
6795         new_call_thread_fsm.
6796         (call_thread_fsm::should_stop): Rename from
6797         call_thread_fsm_should_stop.
6798         (call_thread_fsm::should_notify_stop): Rename from
6799         call_thread_fsm_should_notify_stop.
6800         (run_inferior_call, call_function_by_hand_dummy): Update.
6801         * cli/cli-interp.c (should_print_stop_to_console): Update.
6802         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6803         Add constructor.  Change type of location_breakpoint,
6804         caller_breakpoint.
6805         (until_break_fsm_ops): Remove.
6806         (new_until_break_fsm): Remove.
6807         (until_break_fsm::should_stop): Rename from
6808         until_break_fsm_should_stop.
6809         (until_break_fsm::clean_up): Rename from
6810         until_break_fsm_clean_up.
6811         (until_break_fsm::do_async_reply_reason): Rename from
6812         until_break_fsm_async_reply_reason.
6813         (until_break_command): Update.
6814         * thread-fsm.c: Remove.
6815         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6816
6817 2019-02-07  Tom Tromey  <tom@tromey.com>
6818
6819         * yy-remap.h: Add include guard.
6820         * xtensa-tdep.h: Add include guard.
6821         * xcoffread.h: Rename include guard.
6822         * varobj-iter.h: Add include guard.
6823         * tui/tui.h: Rename include guard.
6824         * tui/tui-winsource.h: Rename include guard.
6825         * tui/tui-wingeneral.h: Rename include guard.
6826         * tui/tui-windata.h: Rename include guard.
6827         * tui/tui-win.h: Rename include guard.
6828         * tui/tui-stack.h: Rename include guard.
6829         * tui/tui-source.h: Rename include guard.
6830         * tui/tui-regs.h: Rename include guard.
6831         * tui/tui-out.h: Rename include guard.
6832         * tui/tui-layout.h: Rename include guard.
6833         * tui/tui-io.h: Rename include guard.
6834         * tui/tui-hooks.h: Rename include guard.
6835         * tui/tui-file.h: Rename include guard.
6836         * tui/tui-disasm.h: Rename include guard.
6837         * tui/tui-data.h: Rename include guard.
6838         * tui/tui-command.h: Rename include guard.
6839         * tic6x-tdep.h: Add include guard.
6840         * target/waitstatus.h: Rename include guard.
6841         * target/wait.h: Rename include guard.
6842         * target/target.h: Rename include guard.
6843         * target/resume.h: Rename include guard.
6844         * target-float.h: Rename include guard.
6845         * stabsread.h: Add include guard.
6846         * rs6000-tdep.h: Add include guard.
6847         * riscv-fbsd-tdep.h: Add include guard.
6848         * regformats/regdef.h: Rename include guard.
6849         * record.h: Rename include guard.
6850         * python/python.h: Rename include guard.
6851         * python/python-internal.h: Rename include guard.
6852         * python/py-stopevent.h: Rename include guard.
6853         * python/py-ref.h: Rename include guard.
6854         * python/py-record.h: Rename include guard.
6855         * python/py-record-full.h: Rename include guard.
6856         * python/py-record-btrace.h: Rename include guard.
6857         * python/py-instruction.h: Rename include guard.
6858         * python/py-events.h: Rename include guard.
6859         * python/py-event.h: Rename include guard.
6860         * procfs.h: Add include guard.
6861         * proc-utils.h: Add include guard.
6862         * p-lang.h: Add include guard.
6863         * or1k-tdep.h: Rename include guard.
6864         * observable.h: Rename include guard.
6865         * nto-tdep.h: Rename include guard.
6866         * nat/x86-linux.h: Rename include guard.
6867         * nat/x86-linux-dregs.h: Rename include guard.
6868         * nat/x86-gcc-cpuid.h: Add include guard.
6869         * nat/x86-dregs.h: Rename include guard.
6870         * nat/x86-cpuid.h: Rename include guard.
6871         * nat/ppc-linux.h: Rename include guard.
6872         * nat/mips-linux-watch.h: Rename include guard.
6873         * nat/linux-waitpid.h: Rename include guard.
6874         * nat/linux-ptrace.h: Rename include guard.
6875         * nat/linux-procfs.h: Rename include guard.
6876         * nat/linux-osdata.h: Rename include guard.
6877         * nat/linux-nat.h: Rename include guard.
6878         * nat/linux-namespaces.h: Rename include guard.
6879         * nat/linux-btrace.h: Rename include guard.
6880         * nat/glibc_thread_db.h: Rename include guard.
6881         * nat/gdb_thread_db.h: Rename include guard.
6882         * nat/gdb_ptrace.h: Rename include guard.
6883         * nat/fork-inferior.h: Rename include guard.
6884         * nat/amd64-linux-siginfo.h: Rename include guard.
6885         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6886         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6887         * nat/aarch64-linux.h: Rename include guard.
6888         * nat/aarch64-linux-hw-point.h: Rename include guard.
6889         * mn10300-tdep.h: Add include guard.
6890         * mips-linux-tdep.h: Add include guard.
6891         * mi/mi-parse.h: Rename include guard.
6892         * mi/mi-out.h: Rename include guard.
6893         * mi/mi-main.h: Rename include guard.
6894         * mi/mi-interp.h: Rename include guard.
6895         * mi/mi-getopt.h: Rename include guard.
6896         * mi/mi-console.h: Rename include guard.
6897         * mi/mi-common.h: Rename include guard.
6898         * mi/mi-cmds.h: Rename include guard.
6899         * mi/mi-cmd-break.h: Rename include guard.
6900         * m2-lang.h: Add include guard.
6901         * location.h: Rename include guard.
6902         * linux-record.h: Rename include guard.
6903         * linux-nat.h: Add include guard.
6904         * linux-fork.h: Add include guard.
6905         * i386-darwin-tdep.h: Rename include guard.
6906         * hppa-linux-offsets.h: Add include guard.
6907         * guile/guile.h: Rename include guard.
6908         * guile/guile-internal.h: Rename include guard.
6909         * gnu-nat.h: Rename include guard.
6910         * gdb-stabs.h: Rename include guard.
6911         * frv-tdep.h: Add include guard.
6912         * f-lang.h: Add include guard.
6913         * event-loop.h: Add include guard.
6914         * darwin-nat.h: Rename include guard.
6915         * cp-abi.h: Rename include guard.
6916         * config/sparc/nm-sol2.h: Rename include guard.
6917         * config/nm-nto.h: Rename include guard.
6918         * config/nm-linux.h: Add include guard.
6919         * config/i386/nm-i386gnu.h: Rename include guard.
6920         * config/djgpp/nl_types.h: Rename include guard.
6921         * config/djgpp/langinfo.h: Rename include guard.
6922         * compile/gcc-cp-plugin.h: Add include guard.
6923         * compile/gcc-c-plugin.h: Add include guard.
6924         * compile/compile.h: Rename include guard.
6925         * compile/compile-object-run.h: Rename include guard.
6926         * compile/compile-object-load.h: Rename include guard.
6927         * compile/compile-internal.h: Rename include guard.
6928         * compile/compile-cplus.h: Rename include guard.
6929         * compile/compile-c.h: Rename include guard.
6930         * common/xml-utils.h: Rename include guard.
6931         * common/x86-xstate.h: Rename include guard.
6932         * common/version.h: Rename include guard.
6933         * common/vec.h: Rename include guard.
6934         * common/tdesc.h: Rename include guard.
6935         * common/selftest.h: Rename include guard.
6936         * common/scoped_restore.h: Rename include guard.
6937         * common/scoped_mmap.h: Rename include guard.
6938         * common/scoped_fd.h: Rename include guard.
6939         * common/safe-iterator.h: Rename include guard.
6940         * common/run-time-clock.h: Rename include guard.
6941         * common/refcounted-object.h: Rename include guard.
6942         * common/queue.h: Rename include guard.
6943         * common/ptid.h: Rename include guard.
6944         * common/print-utils.h: Rename include guard.
6945         * common/preprocessor.h: Rename include guard.
6946         * common/pathstuff.h: Rename include guard.
6947         * common/observable.h: Rename include guard.
6948         * common/netstuff.h: Rename include guard.
6949         * common/job-control.h: Rename include guard.
6950         * common/host-defs.h: Rename include guard.
6951         * common/gdb_wait.h: Rename include guard.
6952         * common/gdb_vecs.h: Rename include guard.
6953         * common/gdb_unlinker.h: Rename include guard.
6954         * common/gdb_unique_ptr.h: Rename include guard.
6955         * common/gdb_tilde_expand.h: Rename include guard.
6956         * common/gdb_sys_time.h: Rename include guard.
6957         * common/gdb_string_view.h: Rename include guard.
6958         * common/gdb_splay_tree.h: Rename include guard.
6959         * common/gdb_setjmp.h: Rename include guard.
6960         * common/gdb_ref_ptr.h: Rename include guard.
6961         * common/gdb_optional.h: Rename include guard.
6962         * common/gdb_locale.h: Rename include guard.
6963         * common/gdb_assert.h: Rename include guard.
6964         * common/filtered-iterator.h: Rename include guard.
6965         * common/filestuff.h: Rename include guard.
6966         * common/fileio.h: Rename include guard.
6967         * common/environ.h: Rename include guard.
6968         * common/common-utils.h: Rename include guard.
6969         * common/common-types.h: Rename include guard.
6970         * common/common-regcache.h: Rename include guard.
6971         * common/common-inferior.h: Rename include guard.
6972         * common/common-gdbthread.h: Rename include guard.
6973         * common/common-exceptions.h: Rename include guard.
6974         * common/common-defs.h: Rename include guard.
6975         * common/common-debug.h: Rename include guard.
6976         * common/cleanups.h: Rename include guard.
6977         * common/buffer.h: Rename include guard.
6978         * common/btrace-common.h: Rename include guard.
6979         * common/break-common.h: Rename include guard.
6980         * cli/cli-utils.h: Rename include guard.
6981         * cli/cli-style.h: Rename include guard.
6982         * cli/cli-setshow.h: Rename include guard.
6983         * cli/cli-script.h: Rename include guard.
6984         * cli/cli-interp.h: Rename include guard.
6985         * cli/cli-decode.h: Rename include guard.
6986         * cli/cli-cmds.h: Rename include guard.
6987         * charset-list.h: Add include guard.
6988         * buildsym-legacy.h: Rename include guard.
6989         * bfin-tdep.h: Add include guard.
6990         * ax.h: Rename include guard.
6991         * arm-linux-tdep.h: Add include guard.
6992         * arm-fbsd-tdep.h: Add include guard.
6993         * arch/xtensa.h: Rename include guard.
6994         * arch/tic6x.h: Add include guard.
6995         * arch/i386.h: Add include guard.
6996         * arch/arm.h: Rename include guard.
6997         * arch/arm-linux.h: Rename include guard.
6998         * arch/arm-get-next-pcs.h: Rename include guard.
6999         * arch/amd64.h: Add include guard.
7000         * arch/aarch64-insn.h: Rename include guard.
7001         * arch-utils.h: Rename include guard.
7002         * annotate.h: Add include guard.
7003         * amd64-darwin-tdep.h: Rename include guard.
7004         * aarch64-linux-tdep.h: Add include guard.
7005         * aarch64-fbsd-tdep.h: Add include guard.
7006         * aarch32-linux-nat.h: Add include guard.
7007
7008 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7009
7010         * macrotab.c (macro_define_internal): New function that
7011         factorizes macro_define_object_internal and macro_define_function
7012         code.
7013         (macro_define_object_internal): Use macro_define_internal.
7014         (macro_define_function): Likewise.
7015
7016 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7017
7018         * macrocmd.c (extract_identifier): Return
7019         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7020         callers.
7021
7022 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7023
7024         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7025
7026 2019-02-05  Tom Tromey  <tom@tromey.com>
7027
7028         * target.c (target_stack::unpush): Move assertion earlier.
7029
7030 2019-01-30  Tom Tromey  <tom@tromey.com>
7031
7032         PR python/23615:
7033         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7034         (gdbpy_parse_and_eval): Likewise.
7035         * python/python-internal.h (gdbpy_allow_threads): New class.
7036
7037 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7038
7039         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7040         (aarch64_fbsd_fpregmap): Move earlier.
7041         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7042         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7043         instead of individual calls to trad_frame_set_reg_addr.
7044         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7045         earlier.
7046         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7047         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7048         instead of individual calls to trad_frame_set_reg_addr.
7049
7050 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7051
7052         * CONTRIBUTE: Replace contribution list with wiki link.
7053
7054 2019-01-25  Tom Tromey  <tom@tromey.com>
7055
7056         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7057
7058 2019-01-25  Tom Tromey  <tom@tromey.com>
7059
7060         * xtensa-linux-nat.c: Fix common/ includes.
7061         * xml-support.h: Fix common/ includes.
7062         * xml-support.c: Fix common/ includes.
7063         * x86-linux-nat.c: Fix common/ includes.
7064         * windows-nat.c: Fix common/ includes.
7065         * varobj.h: Fix common/ includes.
7066         * varobj.c: Fix common/ includes.
7067         * value.c: Fix common/ includes.
7068         * valops.c: Fix common/ includes.
7069         * utils.c: Fix common/ includes.
7070         * unittests/xml-utils-selftests.c: Fix common/ includes.
7071         * unittests/utils-selftests.c: Fix common/ includes.
7072         * unittests/unpack-selftests.c: Fix common/ includes.
7073         * unittests/tracepoint-selftests.c: Fix common/ includes.
7074         * unittests/style-selftests.c: Fix common/ includes.
7075         * unittests/string_view-selftests.c: Fix common/ includes.
7076         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7077         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7078         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7079         * unittests/rsp-low-selftests.c: Fix common/ includes.
7080         * unittests/parse-connection-spec-selftests.c: Fix common/
7081         includes.
7082         * unittests/optional-selftests.c: Fix common/ includes.
7083         * unittests/offset-type-selftests.c: Fix common/ includes.
7084         * unittests/observable-selftests.c: Fix common/ includes.
7085         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7086         * unittests/memrange-selftests.c: Fix common/ includes.
7087         * unittests/memory-map-selftests.c: Fix common/ includes.
7088         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7089         * unittests/function-view-selftests.c: Fix common/ includes.
7090         * unittests/environ-selftests.c: Fix common/ includes.
7091         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7092         * unittests/common-utils-selftests.c: Fix common/ includes.
7093         * unittests/cli-utils-selftests.c: Fix common/ includes.
7094         * unittests/array-view-selftests.c: Fix common/ includes.
7095         * ui-file.c: Fix common/ includes.
7096         * tui/tui-io.c: Fix common/ includes.
7097         * tracepoint.h: Fix common/ includes.
7098         * tracepoint.c: Fix common/ includes.
7099         * tracefile-tfile.c: Fix common/ includes.
7100         * top.h: Fix common/ includes.
7101         * top.c: Fix common/ includes.
7102         * thread.c: Fix common/ includes.
7103         * target/waitstatus.h: Fix common/ includes.
7104         * target/waitstatus.c: Fix common/ includes.
7105         * target.h: Fix common/ includes.
7106         * target.c: Fix common/ includes.
7107         * target-memory.c: Fix common/ includes.
7108         * target-descriptions.c: Fix common/ includes.
7109         * symtab.h: Fix common/ includes.
7110         * symfile.c: Fix common/ includes.
7111         * stap-probe.c: Fix common/ includes.
7112         * spu-linux-nat.c: Fix common/ includes.
7113         * sparc-nat.c: Fix common/ includes.
7114         * source.c: Fix common/ includes.
7115         * solib.c: Fix common/ includes.
7116         * solib-target.c: Fix common/ includes.
7117         * ser-unix.c: Fix common/ includes.
7118         * ser-tcp.c: Fix common/ includes.
7119         * ser-pipe.c: Fix common/ includes.
7120         * ser-base.c: Fix common/ includes.
7121         * selftest-arch.c: Fix common/ includes.
7122         * s12z-tdep.c: Fix common/ includes.
7123         * rust-exp.y: Fix common/ includes.
7124         * rs6000-aix-tdep.c: Fix common/ includes.
7125         * riscv-tdep.c: Fix common/ includes.
7126         * remote.c: Fix common/ includes.
7127         * remote-notif.h: Fix common/ includes.
7128         * remote-fileio.h: Fix common/ includes.
7129         * remote-fileio.c: Fix common/ includes.
7130         * regcache.h: Fix common/ includes.
7131         * regcache.c: Fix common/ includes.
7132         * record-btrace.c: Fix common/ includes.
7133         * python/python.c: Fix common/ includes.
7134         * python/py-type.c: Fix common/ includes.
7135         * python/py-inferior.c: Fix common/ includes.
7136         * progspace.h: Fix common/ includes.
7137         * producer.c: Fix common/ includes.
7138         * procfs.c: Fix common/ includes.
7139         * proc-api.c: Fix common/ includes.
7140         * printcmd.c: Fix common/ includes.
7141         * ppc-linux-nat.c: Fix common/ includes.
7142         * parser-defs.h: Fix common/ includes.
7143         * osdata.c: Fix common/ includes.
7144         * obsd-nat.c: Fix common/ includes.
7145         * nat/x86-linux.c: Fix common/ includes.
7146         * nat/x86-linux-dregs.c: Fix common/ includes.
7147         * nat/x86-dregs.h: Fix common/ includes.
7148         * nat/x86-dregs.c: Fix common/ includes.
7149         * nat/ppc-linux.c: Fix common/ includes.
7150         * nat/mips-linux-watch.h: Fix common/ includes.
7151         * nat/mips-linux-watch.c: Fix common/ includes.
7152         * nat/linux-waitpid.c: Fix common/ includes.
7153         * nat/linux-ptrace.h: Fix common/ includes.
7154         * nat/linux-ptrace.c: Fix common/ includes.
7155         * nat/linux-procfs.c: Fix common/ includes.
7156         * nat/linux-personality.c: Fix common/ includes.
7157         * nat/linux-osdata.c: Fix common/ includes.
7158         * nat/linux-namespaces.c: Fix common/ includes.
7159         * nat/linux-btrace.h: Fix common/ includes.
7160         * nat/linux-btrace.c: Fix common/ includes.
7161         * nat/fork-inferior.c: Fix common/ includes.
7162         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7163         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7164         * nat/aarch64-linux.c: Fix common/ includes.
7165         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7166         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7167         * namespace.h: Fix common/ includes.
7168         * mips-linux-tdep.c: Fix common/ includes.
7169         * minsyms.c: Fix common/ includes.
7170         * mi/mi-parse.h: Fix common/ includes.
7171         * mi/mi-main.c: Fix common/ includes.
7172         * mi/mi-cmd-env.c: Fix common/ includes.
7173         * memrange.h: Fix common/ includes.
7174         * memattr.c: Fix common/ includes.
7175         * maint.h: Fix common/ includes.
7176         * maint.c: Fix common/ includes.
7177         * main.c: Fix common/ includes.
7178         * machoread.c: Fix common/ includes.
7179         * location.c: Fix common/ includes.
7180         * linux-thread-db.c: Fix common/ includes.
7181         * linux-nat.c: Fix common/ includes.
7182         * linux-fork.c: Fix common/ includes.
7183         * inline-frame.c: Fix common/ includes.
7184         * infrun.c: Fix common/ includes.
7185         * inflow.c: Fix common/ includes.
7186         * inferior.h: Fix common/ includes.
7187         * inferior.c: Fix common/ includes.
7188         * infcmd.c: Fix common/ includes.
7189         * inf-ptrace.c: Fix common/ includes.
7190         * inf-child.c: Fix common/ includes.
7191         * ia64-linux-nat.c: Fix common/ includes.
7192         * i387-tdep.c: Fix common/ includes.
7193         * i386-tdep.c: Fix common/ includes.
7194         * i386-linux-tdep.c: Fix common/ includes.
7195         * i386-linux-nat.c: Fix common/ includes.
7196         * i386-go32-tdep.c: Fix common/ includes.
7197         * i386-fbsd-tdep.c: Fix common/ includes.
7198         * i386-fbsd-nat.c: Fix common/ includes.
7199         * guile/scm-type.c: Fix common/ includes.
7200         * guile/guile.c: Fix common/ includes.
7201         * go32-nat.c: Fix common/ includes.
7202         * gnu-nat.c: Fix common/ includes.
7203         * gdbthread.h: Fix common/ includes.
7204         * gdbarch-selftests.c: Fix common/ includes.
7205         * gdb_usleep.c: Fix common/ includes.
7206         * gdb_select.h: Fix common/ includes.
7207         * gdb_bfd.c: Fix common/ includes.
7208         * gcore.c: Fix common/ includes.
7209         * fork-child.c: Fix common/ includes.
7210         * findvar.c: Fix common/ includes.
7211         * fbsd-nat.c: Fix common/ includes.
7212         * event-top.c: Fix common/ includes.
7213         * event-loop.c: Fix common/ includes.
7214         * dwarf2read.c: Fix common/ includes.
7215         * dwarf2loc.c: Fix common/ includes.
7216         * dwarf2-frame.c: Fix common/ includes.
7217         * dwarf-index-cache.c: Fix common/ includes.
7218         * dtrace-probe.c: Fix common/ includes.
7219         * disasm-selftests.c: Fix common/ includes.
7220         * defs.h: Fix common/ includes.
7221         * csky-tdep.c: Fix common/ includes.
7222         * cp-valprint.c: Fix common/ includes.
7223         * cp-support.h: Fix common/ includes.
7224         * cp-support.c: Fix common/ includes.
7225         * corelow.c: Fix common/ includes.
7226         * completer.h: Fix common/ includes.
7227         * completer.c: Fix common/ includes.
7228         * compile/compile.c: Fix common/ includes.
7229         * compile/compile-loc2c.c: Fix common/ includes.
7230         * compile/compile-cplus-types.c: Fix common/ includes.
7231         * compile/compile-cplus-symbols.c: Fix common/ includes.
7232         * command.h: Fix common/ includes.
7233         * cli/cli-dump.c: Fix common/ includes.
7234         * cli/cli-cmds.c: Fix common/ includes.
7235         * charset.c: Fix common/ includes.
7236         * build-id.c: Fix common/ includes.
7237         * btrace.h: Fix common/ includes.
7238         * btrace.c: Fix common/ includes.
7239         * breakpoint.h: Fix common/ includes.
7240         * breakpoint.c: Fix common/ includes.
7241         * ax.h:
7242         (enum agent_op): Fix common/ includes.
7243         * ax-general.c (struct aop_map): Fix common/ includes.
7244         * ax-gdb.c: Fix common/ includes.
7245         * auxv.c: Fix common/ includes.
7246         * auto-load.c: Fix common/ includes.
7247         * arm-tdep.c: Fix common/ includes.
7248         * arch/riscv.c: Fix common/ includes.
7249         * arch/ppc-linux-common.c: Fix common/ includes.
7250         * arch/i386.c: Fix common/ includes.
7251         * arch/arm.c: Fix common/ includes.
7252         * arch/arm-linux.c: Fix common/ includes.
7253         * arch/arm-get-next-pcs.c: Fix common/ includes.
7254         * arch/amd64.c: Fix common/ includes.
7255         * arch/aarch64.c: Fix common/ includes.
7256         * arch/aarch64-insn.c: Fix common/ includes.
7257         * arch-utils.c: Fix common/ includes.
7258         * amd64-windows-tdep.c: Fix common/ includes.
7259         * amd64-tdep.c: Fix common/ includes.
7260         * amd64-sol2-tdep.c: Fix common/ includes.
7261         * amd64-obsd-tdep.c: Fix common/ includes.
7262         * amd64-nbsd-tdep.c: Fix common/ includes.
7263         * amd64-linux-tdep.c: Fix common/ includes.
7264         * amd64-linux-nat.c: Fix common/ includes.
7265         * amd64-fbsd-tdep.c: Fix common/ includes.
7266         * amd64-fbsd-nat.c: Fix common/ includes.
7267         * amd64-dicos-tdep.c: Fix common/ includes.
7268         * amd64-darwin-tdep.c: Fix common/ includes.
7269         * agent.c: Fix common/ includes.
7270         * ada-lang.h: Fix common/ includes.
7271         * ada-lang.c: Fix common/ includes.
7272         * aarch64-tdep.c: Fix common/ includes.
7273
7274 2019-01-25  Tom Tromey  <tom@tromey.com>
7275
7276         * common/create-version.sh: Use common/version.h.
7277
7278 2019-01-24  Pedro Alves  <palves@redhat.com>
7279
7280         * infrun.c (signal_stop, signal_print, signal_program)
7281         (signal_catch, signal_pass): Now arrays instead of pointers.
7282         (update_signals_program_target, do_target_resume)
7283         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7284         * linux-nat.c (linux_nat_target::pass_signals)
7285         (linux_nat_target::create_inferior, linux_nat_target::attach):
7286         Adjust.
7287         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7288         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7289         * procfs.c (procfs_target::pass_signals): Adjust.
7290         * record-full.c (record_full_target::resume): Adjust.
7291         * remote.c (remote_target::pass_signals)
7292         (remote_target::program_signals): Adjust.
7293         * target-debug.h (target_debug_print_signals): Now takes a
7294         gdb::array_view as parameter.  Adjust.
7295         * target.h (target_ops) <pass_signals, program_signals>: Replace
7296         pointer and length parameters with gdb::array_view.
7297         (target_pass_signals, target_program_signals): Likewise.
7298         * target-delegates.c: Regenerate.
7299
7300 2019-01-24  Pedro Alves  <palves@redhat.com>
7301
7302         * common/forward-scope-exit.h
7303         (forward_scope_exit::forward_scope_exit): Pass arguments to
7304         m_bind_function directly, instead of creating a std::bind and
7305         copying that.
7306
7307 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7308
7309         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7310         for static members.
7311         (pass_in_v_vfp_candidate): Likewise.
7312
7313 2019-01-23  Tom Tromey  <tom@tromey.com>
7314             Pedro Alves  <palves@redhat.com>
7315
7316         * regcache.c (class regcache_invalidator): Remove.
7317         (regcache::raw_write): Use make_scope_exit.
7318
7319 2019-01-23  Tom Tromey  <tom@tromey.com>
7320
7321         * ui-out.h (class ui_out_emit_type): Update comment.
7322
7323 2019-01-23  Tom Tromey  <tom@tromey.com>
7324
7325         * infrun.c (fetch_inferior_event): Update comment.
7326
7327 2019-01-23  Tom Tromey  <tom@tromey.com>
7328             Pedro Alves  <palves@redhat.com>
7329
7330         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7331         parameter.
7332         (fetch_inferior_event): Use SCOPE_EXIT.
7333
7334
7335 2019-01-23  Tom Tromey  <tom@tromey.com>
7336             Pedro Alves  <palves@redhat.com>
7337
7338         * infrun.c (disable_thread_events): Delete.
7339         (stop_all_threads): Use SCOPE_EXIT.
7340
7341 2019-01-23  Tom Tromey  <tom@tromey.com>
7342             Pedro Alves  <palves@redhat.com>
7343
7344         * symfile.c: Include forward-scope-exit.h.
7345         (clear_symtab_users_cleanup): Replace forward declaration with
7346         a FORWARD_SCOPE_EXIT.
7347         (syms_from_objfile_1): Use the forward_scope_exit and
7348         gdb::optional instead of cleanup_function.
7349         (reread_symbols): Use the forward_scope_exit instead of
7350         cleanup_function.
7351         (clear_symtab_users_cleanup): Remove function.
7352
7353 2019-01-23  Tom Tromey  <tom@tromey.com>
7354             Pedro Alves  <palves@redhat.com>
7355
7356         * linux-nat.c: Include scope-exit.h.
7357         (cleanup_target_stop): Remove.
7358         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7359         SCOPE_EXIT.
7360
7361 2019-01-23  Tom Tromey  <tom@tromey.com>
7362             Pedro Alves  <palves@redhat.com>
7363
7364         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7365         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7366
7367 2019-01-23  Tom Tromey  <tom@tromey.com>
7368             Andrew Burgess  <andrew.burgess@embecosm.com>
7369             Pedro Alves  <palves@redhat.com>
7370
7371         * infrun.c (fetch_inferior_event): Use scope_exit.
7372         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7373         * top.c (execute_command): Use scope_exit.
7374         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7375         * utils.c (do_bpstat_clear_actions_cleanup)
7376         (make_bpstat_clear_actions_cleanup): Remove.
7377
7378 2019-01-23  Tom Tromey  <tom@tromey.com>
7379             Pedro Alves  <palves@redhat.com>
7380
7381         * infrun.c: Include "common/scope-exit.h"
7382         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7383         (wait_for_inferior): Use SCOPE_EXIT.
7384         (fetch_inferior_event): Use scope_exit.
7385
7386 2019-01-23  Tom Tromey  <tom@tromey.com>
7387             Pedro Alves  <palves@redhat.com>
7388
7389         * breakpoint.c (create_breakpoint): Remove cleanup.
7390
7391 2019-01-23  Tom Tromey  <tom@tromey.com>
7392             Andrew Burgess  <andrew.burgess@embecosm.com>
7393             Pedro Alves  <palves@redhat.com>
7394
7395 2019-01-23  Pedro Alves  <palves@redhat.com>
7396
7397         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7398
7399 2019-01-23  Pedro Alves  <palves@redhat.com>
7400             Andrew Burgess  <andrew.burgess@embecosm.com>
7401
7402         * gdbthread.h: Include "common/forward-scope-exit.h".
7403         (scoped_finish_thread_state): Redefine custom class in terms of
7404         forward_scope_exit.
7405
7406 2019-01-23  Pedro Alves  <palves@redhat.com>
7407             Andrew Burgess  <andrew.burgess@embecosm.com>
7408
7409         * common/forward-scope-exit.h: New file.
7410
7411 2019-01-23  Pedro Alves  <palves@redhat.com>
7412             Andrew Burgess  <andrew.burgess@embecosm.com>
7413             Tom Tromey  <tom@tromey.com>
7414
7415         * common/scope-exit.h: New file.
7416
7417 2019-01-23  Pedro Alves  <palves@redhat.com>
7418
7419         * common/preprocessor.h (ESC): Rename to ...
7420         (ESC_PARENS): ... this.
7421         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7422         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7423
7424 2019-01-23  Tom Tromey  <tom@tromey.com>
7425
7426         * language.h (class scoped_switch_to_sym_language_if_auto):
7427         Initialize m_lang in both cases.
7428
7429 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7430
7431         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7432         with XCNEW.
7433
7434 2019-01-22  Tom Tromey  <tom@tromey.com>
7435
7436         * corelow.c: Do not include sys/file.h.
7437
7438 2019-01-22  Tom Tromey  <tom@tromey.com>
7439
7440         * tui/tui-wingeneral.h: Include gdb_curses.h.
7441
7442 2019-01-22  Tom Tromey  <tom@tromey.com>
7443
7444         * source-cache.h (class source_cache) <get_source_lines,
7445         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7446
7447 2019-01-22  Tom Tromey  <tom@tromey.com>
7448
7449         * remote-fileio.h (struct remote_target): Declare.
7450
7451 2019-01-22  Tom Tromey  <tom@tromey.com>
7452
7453         * python/py-arch.c: Do not include py-ref.h.
7454         * python/py-bpevent.c: Do not include py-ref.h.
7455         * python/py-cmd.c: Do not include py-ref.h.
7456         * python/py-continueevent.c: Do not include py-ref.h.
7457         * python/py-event.h: Do not include py-ref.h.
7458         * python/py-evtregistry.c: Do not include py-ref.h.
7459         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7460         * python/py-frame.c: Do not include py-ref.h.
7461         * python/py-framefilter.c: Do not include py-ref.h.
7462         * python/py-function.c: Do not include py-ref.h.
7463         * python/py-infevents.c: Do not include py-ref.h.
7464         * python/py-linetable.c: Do not include py-ref.h.
7465         * python/py-objfile.c: Do not include py-ref.h.
7466         * python/py-param.c: Do not include py-ref.h.
7467         * python/py-prettyprint.c: Do not include py-ref.h.
7468         * python/py-progspace.c: Do not include py-ref.h.
7469         * python/py-symbol.c: Do not include py-ref.h.
7470         * python/py-symtab.c: Do not include py-ref.h.
7471         * python/py-type.c: Do not include py-ref.h.
7472         * python/py-unwind.c: Do not include py-ref.h.
7473         * python/py-utils.c: Do not include py-ref.h.
7474         * python/py-value.c: Do not include py-ref.h.
7475         * python/py-varobj.c: Do not include py-ref.h.
7476         * python/py-xmethods.c: Do not include py-ref.h.
7477         * python/python.c: Do not include py-ref.h.
7478         * varobj.c: Do not include py-ref.h.
7479
7480 2019-01-22  Tom Tromey  <tom@tromey.com>
7481
7482         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7483         keyword for bcache.
7484
7485 2019-01-22  Tom Tromey  <tom@tromey.com>
7486
7487         * compile/compile-cplus-types.c: Remove a comment by #include.
7488
7489 2019-01-22  Tom Tromey  <tom@tromey.com>
7490
7491         * compile/gcc-c-plugin.h: Include compile-internal.h.
7492
7493 2019-01-22  Tom Tromey  <tom@tromey.com>
7494
7495         * stabsread.c (EXTERN): Do not define.
7496         (symnum, next_symbol_text_func, processing_gcc_compilation)
7497         (within_function, global_sym_chain, global_stabs)
7498         (previous_stab_code, this_object_header_files)
7499         (n_this_object_header_files)
7500         (n_allocated_this_object_header_files): Define.
7501         * stabsread.h (EXTERN): Never define.  Use "extern".
7502
7503 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7504
7505         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7506         history_value.
7507
7508 2019-01-21  Tom Tromey  <tom@tromey.com>
7509
7510         * ui-out.c: Fix includes.
7511         * tui/tui-source.c: Fix includes.
7512         * target.c: Fix includes.
7513         * remote.c: Fix includes.
7514         * regcache.c: Fix includes.
7515         * python/py-block.c: Fix includes.
7516         * printcmd.c: Fix includes.
7517         * or1k-tdep.c: Fix includes.
7518         * mi/mi-main.c: Fix includes.
7519         * m32r-tdep.c: Fix includes.
7520         * csky-tdep.c: Fix includes.
7521         * compile/compile-cplus-types.c: Fix includes.
7522         * cli/cli-interp.c: Fix includes.
7523
7524 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7525
7526         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7527         for padding.
7528
7529 2019-01-16  Tom Tromey  <tom@tromey.com>
7530
7531         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7532         earlier.
7533         (struct objfile) <msymbols_range>: Move from top level.
7534         <msymbols>: New method.
7535         (class objfile_msymbols): Remove.
7536         * symtab.c (default_collect_symbol_completion_matches_break_on):
7537         Update.
7538         * symmisc.c (dump_msymbols): Update.
7539         * stabsread.c (scan_file_globals): Update.
7540         * objc-lang.c (info_selectors_command, info_classes_command)
7541         (find_methods): Update.
7542         * minsyms.c (find_solib_trampoline_target): Update.
7543         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7544         * coffread.c (coff_symfile_read): Update.
7545         * ada-lang.c (ada_lookup_simple_minsym)
7546         (ada_collect_symbol_completion_matches): Update.
7547
7548 2019-01-16  Tom Tromey  <tom@tromey.com>
7549
7550         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7551         type.  Remove no-argument constructor.
7552         <iterator::operator++>: Simplify.
7553         <begin>: Update.
7554         <end>: Use minimal_symbol_count.
7555
7556 2019-01-16  Tom Tromey  <tom@tromey.com>
7557
7558         * objfiles.h (struct objfile) <psymtabs>: New method.
7559         (class objfile_psymtabs): Remove.
7560         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7561         typedef.
7562         <range>: New method.
7563         (require_partial_symbols): Change return type.
7564         * psymtab.c (require_partial_symbols)
7565         (psym_expand_symtabs_matching): Update.
7566         * mdebugread.c (parse_partial_symbols): Update.
7567         * dbxread.c (dbx_end_psymtab): Update.
7568
7569 2019-01-15  Tom Tromey  <tom@tromey.com>
7570
7571         * symtab.c (lookup_objfile_from_block)
7572         (lookup_symbol_in_objfile_symtabs)
7573         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7574         (find_line_symtab, info_sources_command)
7575         (default_collect_symbol_completion_matches_break_on)
7576         (make_source_files_completion_list): Update.
7577         * symmisc.c (print_objfile_statistics, dump_objfile)
7578         (maintenance_print_symbols, maintenance_info_symtabs)
7579         (maintenance_check_symtabs, maintenance_info_line_tables):
7580         Update.
7581         * source.c (select_source_symtab)
7582         (forget_cached_source_info_for_objfile): Update.
7583         * objfiles.h (class objfile_compunits): Remove.
7584         (struct objfile) <compunits_range>: New typedef.
7585         (compunits): New method.
7586         * objfiles.c (objfile_relocate1): Update.
7587         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7588         * maint.c (count_symtabs_and_blocks): Update.
7589         * linespec.c (iterate_over_all_matching_symtabs): Update.
7590         * cp-support.c (add_symbol_overload_list_qualified): Update.
7591         * coffread.c (coff_symtab_read): Update.
7592         * ada-lang.c (add_nonlocal_symbols)
7593         (ada_collect_symbol_completion_matches)
7594         (ada_add_global_exceptions): Update.
7595
7596 2019-01-15  Tom Tromey  <tom@tromey.com>
7597
7598         * progspace.h (program_space) <objfiles_safe_range>: New
7599         typedef.
7600         <objfiles_safe>: New method.
7601         * objfiles.h (class all_objfiles_safe): Remove.
7602         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7603         * jit.c (jit_inferior_exit_hook): Update.
7604
7605 2019-01-17  Tom Tromey  <tom@tromey.com>
7606
7607         * progspace.h (program_space) <objfiles_range>: New typedef.
7608         <objfiles>: New method.
7609         <objfiles_head>: Rename from objfiles.
7610         (object_files): Update.
7611         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7612         * guile/scm-pretty-print.c
7613         (ppscm_find_pretty_printer_from_objfiles): Update.
7614         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7615         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7616         Update.
7617         * python/py-progspace.c (pspy_get_objfiles): Update.
7618         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7619         Update.
7620         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7621         (objfpy_lookup_objfile_by_build_id): Update.
7622         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7623         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7624         Update.
7625         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7626         (expand_symtab_containing_pc, lookup_objfile_from_block)
7627         (lookup_static_symbol, basic_lookup_transparent_type)
7628         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7629         (find_line_symtab, info_sources_command)
7630         (default_collect_symbol_completion_matches_break_on)
7631         (make_source_files_completion_list, find_main_name): Update.
7632         * symmisc.c (print_symbol_bcache_statistics)
7633         (print_objfile_statistics, maintenance_print_symbols)
7634         (maintenance_print_msymbols, maintenance_print_objfiles)
7635         (maintenance_info_symtabs, maintenance_check_symtabs)
7636         (maintenance_expand_symtabs, maintenance_info_line_tables):
7637         Update.
7638         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7639         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7640         (map_overlay_command, unmap_overlay_command)
7641         (simple_overlay_update, expand_symtabs_matching)
7642         (map_symbol_filenames): Update.
7643         * symfile-debug.c (set_debug_symfile): Update.
7644         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7645         Update.
7646         * source.c (select_source_symtab, forget_cached_source_info):
7647         Update.
7648         * solib.c (solib_read_symbols): Update.
7649         * solib-spu.c (append_ocl_sos): Update.
7650         * psymtab.c (maintenance_print_psymbols)
7651         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7652         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7653         * printcmd.c (info_symbol_command): Update.
7654         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7655         Update.
7656         * objfiles.h (class all_objfiles): Remove.
7657         * objfiles.c (have_partial_symbols, have_full_symbols)
7658         (have_minimal_symbols, qsort_cmp, update_section_map)
7659         (shared_objfile_contains_address_p)
7660         (default_iterate_over_objfiles_in_search_order): Update.
7661         * objc-lang.c (info_selectors_command, info_classes_command)
7662         (find_methods): Update.
7663         * minsyms.c (find_solib_trampoline_target): Update.
7664         * maint.c (maintenance_info_sections)
7665         (maintenance_translate_address, count_symtabs_and_blocks):
7666         Update.
7667         * main.c (captured_main_1): Update.
7668         * linux-thread-db.c (try_thread_db_load_from_pdir)
7669         (has_libpthread): Update.
7670         * linespec.c (iterate_over_all_matching_symtabs)
7671         (search_minsyms_for_name): Update.
7672         * jit.c (jit_find_objf_with_entry_addr): Update.
7673         * hppa-tdep.c (find_unwind_entry)
7674         (hppa_lookup_stub_minimal_symbol): Update.
7675         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7676         Update.
7677         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7678         (elf_gnu_ifunc_resolve_by_got): Update.
7679         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7680         * dwarf-index-write.c (save_gdb_index_command): Update.
7681         * cp-support.c (add_symbol_overload_list_qualified): Update.
7682         * breakpoint.c (create_overlay_event_breakpoint)
7683         (create_longjmp_master_breakpoint)
7684         (create_std_terminate_master_breakpoint)
7685         (create_exception_master_breakpoint): Update.
7686         * blockframe.c (find_pc_partial_function): Update.
7687         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7688         (ada_collect_symbol_completion_matches)
7689         (ada_add_global_exceptions): Update.
7690
7691 2019-01-17  Tom Tromey  <tom@tromey.com>
7692
7693         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7694         declare VEC.
7695         (solib_target_parse_libraries): Change return type.
7696         (library_list_start_segment, library_list_start_section)
7697         (library_list_end_library, library_list_start_library); Update.
7698         (solib_target_free_library_list): Remove.
7699         (solib_target_parse_libraries): Remove cleanup.  Change return
7700         type.
7701         (solib_target_current_sos): Update.
7702
7703 2019-01-17  Tom Tromey  <tromey@bapiya>
7704
7705         * valprint.c: Replace "the the" with "the".
7706         * symtab.c: Replace "the the" with "the".
7707         * solib.c: Replace "the the" with "the".
7708         * solib-dsbt.c: Replace "the the" with "the".
7709         * linespec.c: Replace "the the" with "the".
7710         * dwarf2loc.h: Replace "the the" with "the".
7711         * amd64-windows-tdep.c: Replace "the the" with "the".
7712         * aarch64-tdep.c: Replace "the the" with "the".
7713
7714 2019-01-16  Keith Seitz  <keiths@redhat.com>
7715
7716         PR gdb/23773
7717         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7718         <builder>: Rename to ..
7719         <m_builder>: ... this and make private.
7720         (dwarf2_cu::get_builder): New method.  Change all users of
7721         `builder' to use this method.
7722         (dwarf2_start_symtab): Move to ...
7723         (dwarf2_cu::start_symtab): ... here.  Update all callers
7724         (setup_type_unit_groups): Move to ...
7725         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7726         callers.
7727         (dwarf2_cu::reset_builder): New method.
7728         (process_full_compunit, process_full_type_unit): Use
7729         dwarf2_cu::reset_builder.
7730         (follow_die_offset): Record the ancestor CU if it is different
7731         from the followed DIE's CU.
7732         (follow_die_sig_1): Likewise.
7733
7734 2019-01-15  Tom Tromey  <tom@tromey.com>
7735
7736         * remote.c (class remote_state) <buf>: Now a char_vector.
7737         <buf_size>: Remove.
7738         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7739         parameter.
7740         (remote_target::getpkt_or_notif_sane_1)
7741         (remote_target::getpkt_sane)
7742         (remote_target::getpkt_or_notif_sane): Likewise.
7743         (class remote_target) <putpkt>: New overload.
7744         (remote_target::read_frame): Change type of "buf_p".  Remove
7745         sizeof_p parameter.
7746         (packet_ok): New overload.
7747         (packet_check_result): New overload.
7748         Update all uses.
7749
7750 2019-01-14  Tom Tromey  <tom@tromey.com>
7751
7752         * remote-notif.c (handle_notification, remote_notif_ack)
7753         (remote_notif_parse): Make "buf" const.
7754         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7755         const.
7756         (remote_notif_parse, remote_notif_ack, handle_notification):
7757         Likewise.
7758         * remote.c (remote_notif_stop_parse): Make "buf" const.
7759         (remote_target::remote_parse_stop_reply): Make "buf" const.
7760         (remote_notif_stop_ack): Make "buf" const.
7761
7762 2019-01-14  Tom Tromey  <tom@tromey.com>
7763
7764         * remote.c (remote_console_output): Make parameter const.
7765
7766 2019-01-14  Tom Tromey  <tom@tromey.com>
7767
7768         * target-debug.h (target_debug_print_signals): Constify.
7769         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7770         * procfs.c (procfs_target::pass_signals): Update.
7771         * linux-nat.c (linux_nat_target::pass_signals): Update.
7772         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7773         * target-delegates.c: Rebuild.
7774         * remote.c (remote_target::program_signals): Update.
7775         (remote_target::pass_signals): Update.
7776         * target.c (target_pass_signals): Constify argument.
7777         (target_program_signals): Likewise.
7778         * target.h (struct target_ops) <pass_signals, program_signals>:
7779         Constify argument.
7780         (target_pass_signals, target_program_signals): Constify argument.
7781
7782 2019-01-14  Tom Tromey  <tom@tromey.com>
7783
7784         PR tui/28819:
7785         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7786
7787 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7788
7789         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7790         field.
7791         * rs6000-tdep.c: Include reggroups.h.
7792         (IS_V_ALIAS_PSEUDOREG): Define.
7793         (rs6000_register_name): Return names for the "vX" aliases.
7794         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7795         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7796         aliases.  Call default_register_reggroup_p for all other
7797         pseudo-registers.
7798         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7799         New functions.
7800         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7801         Handle "vX" aliases.
7802         (v_alias_pseudo_register_collect): New function.
7803         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7804         (rs6000_gdbarch_init): Initialize "vX" aliases as
7805         pseudo-registers.  Restore registration of
7806         rs6000_pseudo_register_reggroup_p with
7807         set_tdesc_pseudo_register_reggroup_p.
7808
7809 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7810
7811         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7812         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7813         set_gdbarch_num_pseudo_regs.
7814
7815 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7816
7817         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7818         Remove arg prefixname, add do_set and do_show.
7819         Add member functions set_list and show_list.
7820         * cli/cli-style.c (class cli_style_option): Update accordingly.
7821         (style_set_list): Move to file scope.
7822         (style_show_list): Likewise.
7823         (set_style): Call help_list.
7824         (show_style): Call cmd_show_list.
7825         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7826         Update to use the new macro.
7827
7828 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7829
7830         * ada-lang.c (_initialize_ada_language): Expand the help text
7831         for the "catch exception" command.
7832
7833 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7834
7835         * symtab.c (matching_obj_sections): Initialize obj,
7836         declare it closer to its usage.
7837
7838 2019-01-10  Tom Tromey  <tom@tromey.com>
7839
7840         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7841         (basic_inf_threads_range): Remove.
7842         (inf_threads_range, inf_non_exited_threads_range)
7843         (safe_inf_threads_range): Use next_adapter.
7844
7845 2019-01-10  Keith Seitz  <keiths@redhat.com>
7846
7847         PR gdb/23712
7848         PR symtab/23010
7849         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7850         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7851
7852 2019-01-10  Keith Seitz  <keiths@redhat.com>
7853
7854         PR gdb/23712
7855         PR symtab/23010
7856         * dictionary.c (pending_to_vector): Remove.
7857         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7858         Remove _1 suffix, replacing functions of the same name.  Update
7859         all callers.
7860         (dict_create_hashed, dict_create_hashed_expandable)
7861         (dict_create_linear, dict_create_linear_expandable, dict_free)
7862         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7863         Make functions static.
7864
7865 2019-01-10  Keith Seitz  <keiths@redhat.com>
7866
7867         PR gdb/23712
7868         PR symtab/23010
7869         * dictionary.h (struct dictionary): Replace declaration with
7870         multidictionary.
7871         (dict_create_hashed, dict_create_hashed_expandable)
7872         (dict_create_linear, dict_create_linear_expandable)
7873         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7874         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7875         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7876         taking multidictionary argument.
7877         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7878         * block.h (struct block) <dict>: Change to multidictionary
7879         and rename `multidict'.
7880         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7881         symmisc.c: Update all dictionary references to multidictionary.
7882
7883 2019-01-10  Keith Seitz  <keiths@redhat.com>
7884
7885         PR gdb/23712
7886         PR symtab/23010
7887         * dictionary.c: Include unordered_map.
7888         (pending_to_vector): New function.
7889         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7890         Rewrite the non-"_1" functions to take vector instead
7891         of linked list.
7892         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7893         "new" _1 versions of the same name.
7894         (multidictionary): Define.
7895         (std::hash<enum language): New definition.
7896         (collate_pending_symbols_by_language, mdict_create_hashed)
7897         (mdict_create_hashed_expandable, mdict_create_linear)
7898         (mdict_create_linear_expandable, mdict_free)
7899         (find_language_dictionary, create_new_language_dictionary)
7900         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7901         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7902         (mdict_size, mdict_empty): New functions.
7903         * dictionary.h (mdict_iterator): Define.
7904
7905 2019-01-10  Pedro Alves  <palves@redhat.com>
7906
7907         * breakpoint.c (read_uploaded_action)
7908         (create_tracepoint_from_upload): Adjust to use
7909         gdb::unique_xmalloc_ptr.
7910         * ctf.c (ctf_write_uploaded_tp):
7911         (SET_ARRAY_FIELD): Use emplace_back.
7912         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7913         * tracefile-tfile.c (tfile_write_uploaded_tp):
7914         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7915         gdb::unique_xmalloc_ptr.
7916         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7917         at_string, cond_string, cmd_strings>: Replace char pointers
7918         with gdb::unique_xmalloc_ptr.
7919
7920 2019-01-10  Pedro Alves  <palves@redhat.com>
7921
7922         * solib-target.c (library_list_start_library): Don't xstrdup name.
7923
7924 2019-01-10  Pedro Alves  <palves@redhat.com>
7925
7926         * mdebugread.c (parse_partial_symbols): Use
7927         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7928
7929 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7930
7931         * linux-fork.c (scoped_switch_fork_info)
7932         <~scoped_switch_fork_info>: Fix incorrect variable name.
7933
7934 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7935
7936         * linux-fork.c (scoped_switch_fork_info)
7937         <scoped_switch_fork_info>: Make explicit.
7938         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7939
7940 2019-01-10  Tom Tromey  <tom@tromey.com>
7941
7942         * objfiles.h (objfile::reset_psymtabs): Update.
7943         * objfiles.c (objfile::objfile): Update.
7944         * psymtab.h (psymtab_storage::obstack): Update.
7945         (psymtab_storage::m_obstack): Use gdb::optional.
7946         (class psymtab_storage): Update comment.  Remove objfile
7947         parameter.
7948         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7949
7950 2019-01-10  Tom Tromey  <tom@tromey.com>
7951
7952         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7953         <free_psymtabs>: Now private.
7954         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7955         (allocate_psymtab): Use new method.
7956
7957 2019-01-10  Tom Tromey  <tom@tromey.com>
7958
7959         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7960         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7961         * mdebugread.c (parse_partial_symbols): Use
7962         allocate_dependencies.
7963         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7964         allocate_dependencies.
7965         (process_psymtab_comp_unit_reader)
7966         (build_type_psymtab_dependencies): Likewise.
7967         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7968
7969 2019-01-10  Tom Tromey  <tom@tromey.com>
7970
7971         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7972         PSYMBOL_SET_LANGUAGE.
7973         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7974
7975 2019-01-10  Tom Tromey  <tom@tromey.com>
7976
7977         * psymtab.h (psymtab_storage::obstack): New method.
7978         <m_obstack>: Rename from obstack; now private.
7979         * psymtab.c (psymtab_storage): Update.
7980         * dwarf2read.c (create_addrmap_from_index)
7981         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7982         Update.
7983
7984 2019-01-10  Tom Tromey  <tom@tromey.com>
7985
7986         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7987         * objfiles.h (objfile::reset_psymtabs): New method.
7988
7989 2019-01-10  Tom Tromey  <tom@tromey.com>
7990
7991         * symmisc.c (print_symbol_bcache_statistics): Update.
7992         (print_objfile_statistics): Update.
7993         * symfile.c (reread_symbols): Update.
7994         * psymtab.h (class psymtab_storage): New.
7995         * psymtab.c (psymtab_storage): New constructor.
7996         (~psymtab_storage): New destructor.
7997         (require_partial_symbols): Update.
7998         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7999         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8000         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8001         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8002         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8003         (start_psymtab_common, end_psymtab_common)
8004         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8005         (allocate_psymtab): Update.
8006         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8007         Update.
8008         (dump_psymtab_addrmap, maintenance_print_psymbols)
8009         (maintenance_check_psymtabs): Update.
8010         (class objfile_psymtabs): Move to objfiles.h.
8011         * psympriv.h (discard_psymtab): Now inline.
8012         (psymtab_discarder::psymtab_discarder): Update.
8013         (psymtab_discarder::~psymtab_discarder): Update.
8014         (ALL_OBJFILE_PSYMTABS): Rewrite.
8015         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8016         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8017         Remove fields.
8018         <partial_symtabs>: New field.
8019         (class objfile_psymtabs): Move from psymtab.h.  Update.
8020         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8021         psymbol_cache.
8022         (objfile::~objfile): Don't destroy psymbol_cache.
8023         * mdebugread.c (parse_partial_symbols): Update.
8024         * dwarf2read.c (create_addrmap_from_index)
8025         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8026         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8027         (add_partial_subprogram, dwarf2_ranges_read): Update.
8028         * dwarf-index-write.c (write_address_map)
8029         (write_one_signatured_type, recursively_write_psymbols)
8030         (class debug_names, class debug_names, write_psymtabs_to_index):
8031         Update.
8032
8033 2019-01-10  Tom Tromey  <tom@tromey.com>
8034
8035         * symtab.h (SYMBOL_SET_NAMES): Update.
8036         (symbol_set_names): Update.
8037         (MSYMBOL_SET_NAMES): Update.
8038         * symtab.c (symbol_set_names): Change argument to be an
8039         objfile_per_bfd_storage.
8040         * psymtab.c (add_psymbol_to_bcache): Update.
8041         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8042
8043 2019-01-10  Tom Tromey  <tom@tromey.com>
8044
8045         * symtab.c (create_demangled_names_hash): Change argument to be an
8046         objfile_per_bfd_storage.
8047         (symbol_set_names): Update.
8048
8049 2019-01-10  Tom Tromey  <tom@tromey.com>
8050
8051         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8052         init_psymbol_list.
8053         * psymtab.c (init_psymbol_list): Do nothing if already called.
8054         * psympriv.h (init_psymbol_list): Add comment.
8055         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8056         init_psymbol_list.
8057         * dbxread.c (dbx_symfile_read): Unconditionally call
8058         init_psymbol_list.
8059
8060 2019-01-10  Tom Tromey  <tom@tromey.com>
8061
8062         * xcoffread.c (scan_xcoff_symtab): Update.
8063         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8064         "where".
8065         * mdebugread.c (parse_partial_symbols)
8066         (handle_psymbol_enumerators): Update.
8067         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8068         * dbxread.c (read_dbx_symtab): Update.
8069         * psympriv.h (psymbol_placement): New enum.
8070         (add_psymbol_to_list): Update.
8071
8072 2019-01-10  Tom Tromey  <tom@tromey.com>
8073
8074         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8075         static_psymbols parameters.
8076         (scan_xcoff_symtab): Update.
8077         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8078         static_psymbols parameters.
8079         * psympriv.h (start_psymtab_common): Update.
8080         * mdebugread.c (parse_partial_symbols): Update.
8081         * dwarf2read.c (create_partial_symtab): Update.
8082         * dbxread.c (read_dbx_symtab): Update.
8083         (start_psymtab): Remove global_psymbols and static_psymbols
8084         parameters.
8085
8086 2019-01-10  Tom Tromey  <tom@tromey.com>
8087
8088         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8089         * psymtab.c (allocate_psymtab): Add comment.
8090         * psympriv.h (allocate_psymtab): Add comment.
8091         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8092         initializations.
8093         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8094
8095 2019-01-10  Tom Tromey  <tom@tromey.com>
8096
8097         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8098         Don't declare.
8099         * mipsread.c: Include mdebugread.h.
8100         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8101         Declare.
8102         * elfread.c: Include mdebugread.h.
8103
8104 2019-01-09  Tom Tromey  <tom@tromey.com>
8105
8106         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8107         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8108         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8109         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8110         (psym_lookup_symbol, psym_find_last_source_symtab)
8111         (psym_forget_cached_source_info, psym_print_stats)
8112         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8113         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8114         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8115         (psym_find_compunit_symtab_by_address)
8116         (maintenance_print_psymbols, maintenance_info_psymtabs)
8117         (maintenance_check_psymtabs): Use ranged for.
8118         * psymtab.h (class objfile_psymtabs): New.
8119         (require_partial_symbols): Return objfile_psymtabs.
8120         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8121
8122 2019-01-09  Tom Tromey  <tom@tromey.com>
8123
8124         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8125         (find_pc_mapped_section, list_overlays_command)
8126         (map_overlay_command, unmap_overlay_command)
8127         (simple_overlay_update): Use all_objfiles.
8128         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8129         * printcmd.c (info_symbol_command): Use all_objfiles.
8130         * objfiles.h (ALL_OBJSECTIONS): Remove.
8131         * maint.c (maintenance_translate_address): Use all_objfiles.
8132         * gcore.c (gcore_create_callback): Use all_objfiles.
8133         (objfile_find_memory_regions): Likewise.
8134
8135 2019-01-09  Tom Tromey  <tom@tromey.com>
8136
8137         * symtab.c (find_line_symtab, info_sources_command)
8138         (make_source_files_completion_list): Use objfile_compunits.
8139         * source.c (select_source_symtab): Use objfile_compunits.
8140         * objfiles.h (struct objfile): Update comment.
8141         (ALL_OBJFILES): Remove.
8142         (ALL_FILETABS): Remove.
8143         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8144         objfile_compunits.
8145
8146 2019-01-09  Tom Tromey  <tom@tromey.com>
8147
8148         * symmisc.c (print_objfile_statistics, dump_objfile)
8149         (maintenance_print_symbols): Use compunit_filetabs.
8150         * source.c (forget_cached_source_info_for_objfile): Use
8151         compunit_filetabs.
8152         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8153         (ALL_FILETABS): Use compunit_filetabs.
8154         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8155         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8156
8157 2019-01-09  Tom Tromey  <tom@tromey.com>
8158
8159         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8160         (compunit_filetabs): New.
8161         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8162         compunit_filetabs.
8163         (info_sources_command, make_source_files_completion_list): Remove
8164         declaration.
8165         * symmisc.c (print_objfile_statistics, dump_objfile)
8166         (maintenance_print_symbols): Remove declaration.
8167         (maintenance_info_symtabs): Use compunit_filetabs.
8168         (maintenance_info_line_tables): Likewise.
8169         * source.c (select_source_symtab): Change local variable name.
8170         (forget_cached_source_info_for_objfile): Remove declaration.
8171         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8172         * objfiles.c (objfile_relocate1): Remove declaration.
8173         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8174         declaration.
8175         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8176         * coffread.c (coff_symtab_read): Remove declaration.
8177         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8178         compunit_filetabs.
8179
8180 2019-01-09  Tom Tromey  <tom@tromey.com>
8181
8182         * symtab.c (lookup_objfile_from_block)
8183         (find_pc_sect_compunit_symtab, search_symbols)
8184         (default_collect_symbol_completion_matches_break_on): Use
8185         objfile_compunits.
8186         * objfiles.h (ALL_COMPUNITS): Remove.
8187         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8188         * cp-support.c (add_symbol_overload_list_qualified): Use
8189         objfile_compunits.
8190         * ada-lang.c (ada_collect_symbol_completion_matches)
8191         (ada_add_global_exceptions): Use objfile_compunits.
8192
8193 2019-01-09  Tom Tromey  <tom@tromey.com>
8194
8195         * source.c (select_source_symtab)
8196         (forget_cached_source_info_for_objfile): Remove declaration.
8197         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8198         declaration.
8199         * maint.c (count_symtabs_and_blocks): Remove declaration.
8200         * cp-support.c (add_symbol_overload_list_qualified): Remove
8201         declaration.
8202         * coffread.c (coff_symtab_read): Remove declaration.
8203         * symtab.c (lookup_symbol_in_objfile_symtabs)
8204         (basic_lookup_transparent_type_1): Use objfile_compunits.
8205         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8206         (info_sources_command, search_symbols)
8207         (default_collect_symbol_completion_matches_break_on)
8208         (make_source_files_completion_list): Remove declaration.
8209         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8210         (ada_collect_symbol_completion_matches)
8211         (ada_add_global_exceptions): Remove declaration.
8212         * linespec.c (iterate_over_all_matching_symtabs): Use
8213         objfile_compunits.
8214         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8215         (class objfile_compunits): New.
8216         (ALL_COMPUNITS): Use objfile_compunits.
8217         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8218         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8219         objfile_compunits.
8220         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8221
8222 2019-01-09  Tom Tromey  <tom@tromey.com>
8223
8224         * symtab.c (search_symbols)
8225         (default_collect_symbol_completion_matches_break_on): Use
8226         objfile_msymbols.
8227         * ada-lang.c (ada_lookup_simple_minsym)
8228         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8229         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8230         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8231         objfile_msymbols.
8232         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8233         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8234         * objc-lang.c (find_methods): Use objfile_msymbols.
8235         (info_selectors_command, info_classes_command): Likewise.
8236         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8237         * objfiles.h (class objfile_msymbols): New.
8238         (ALL_OBJFILE_MSYMBOLS): Remove.
8239         (ALL_MSYMBOLS): Remove.
8240
8241 2019-01-09  Tom Tromey  <tom@tromey.com>
8242
8243         * common/next-iterator.h (next_adapter): Add Iterator template
8244         parameter.
8245         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8246         (class all_objfiles_safe): New.
8247         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8248         * objfiles.c (put_objfile_before): Update comment.
8249         (add_separate_debug_objfile): Likewise.
8250         (free_all_objfiles): Use all_objfiles_safe.
8251         (objfile_purge_solibs): Likewise.
8252
8253 2019-01-09  Tom Tromey  <tom@tromey.com>
8254
8255         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8256         (expand_symtab_containing_pc, lookup_static_symbol)
8257         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8258         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8259         all_objfiles.
8260         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8261         * breakpoint.c (create_overlay_event_breakpoint)
8262         (create_longjmp_master_breakpoint)
8263         (create_std_terminate_master_breakpoint)
8264         (create_exception_master_breakpoint): Use all_objfiles.
8265         * linux-thread-db.c (try_thread_db_load_from_pdir)
8266         (has_libpthread): Use all_objfiles.
8267         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8268         * linespec.c (iterate_over_all_matching_symtabs)
8269         (search_minsyms_for_name): Use all_objfiles.
8270         * maint.c (maintenance_info_sections): Use all_objfiles.
8271         * main.c (captured_main_1): Use all_objfiles.
8272         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8273         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8274         * guile/scm-pretty-print.c
8275         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8276         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8277         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8278         (maintenance_print_msymbols): Use all_objfiles.
8279         * source.c (select_source_symtab): Use all_objfiles.
8280         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8281         * symfile.c (remove_symbol_file_command)
8282         (expand_symtabs_matching, map_symbol_filenames): Use
8283         all_objfiles.
8284         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8285         all_objfiles.
8286         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8287         * objc-lang.c (find_methods): Use all_objfiles.
8288         * objfiles.c (have_partial_symbols, have_full_symbols)
8289         (have_minimal_symbols, qsort_cmp)
8290         (default_iterate_over_objfiles_in_search_order): Use
8291         all_objfiles.
8292         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8293         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8294         (maintenance_check_psymtabs): Use all_objfiles.
8295         (ALL_PSYMTABS): Remove.
8296         * compile/compile-object-run.c (do_module_cleanup): Use
8297         all_objfiles.
8298         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8299         * cp-support.c (add_symbol_overload_list_qualified): Use
8300         all_objfiles.
8301         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8302         Use all_objfiles.
8303         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8304         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8305         all_objfiles.
8306         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8307         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8308         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8309         Uses all_objfiles.
8310         * solib.c (solib_read_symbols): Use all_objfiles
8311
8312 2019-01-09  Tom Tromey  <tom@tromey.com>
8313
8314         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8315         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8316         all_objfiles.
8317         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8318         * symmisc.c (print_symbol_bcache_statistics)
8319         (print_objfile_statistics, maintenance_print_objfiles)
8320         (maintenance_info_symtabs, maintenance_check_symtabs)
8321         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8322         all_objfiles.
8323         * source.c (forget_cached_source_info): Use all_objfiles.
8324         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8325         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8326         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8327         * objfiles.c (update_section_map): Use all_objfiles.
8328         (shared_objfile_contains_address_p): Likewise.
8329         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8330         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8331
8332 2019-01-09  Tom Tromey  <tom@tromey.com>
8333
8334         * common/next-iterator.h: New file.
8335         * objfiles.h (class all_objfiles): New.
8336         (struct objfile_iterator): New.
8337
8338 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8339
8340         * NEWS: Move the description of the changed "frame", "select-frame",
8341          and "info frame" commands to the Changed commands section.
8342
8343 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8344
8345         * gdbtypes.c (check_stub_method_group): Remove handling of old
8346         mangling schemes.
8347         * linespec.c (find_methods): Likewise.
8348         * stabsread.c (read_member_functions): Likewise.
8349         * valops.c (search_struct_method): Likewise.
8350         (value_struct_elt_for_reference): Likewise.
8351         * NEWS: Mention this change.
8352
8353 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8354
8355         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8356         print_source_lines.
8357         * source.c (print_source_lines_base): Update line number check.
8358         (print_source_lines): New function.
8359         (source_lines_range::source_lines_range): New function.
8360         * source.h (class source_lines_range): New class.
8361         (print_source_lines): New declaration.
8362
8363 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8364
8365         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8366
8367 2019-01-08  Tom Tromey  <tom@tromey.com>
8368             Simon Marchi  <simon.marchi@ericsson.com>
8369
8370         PR gdb/24060
8371         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8372         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8373         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8374         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8375         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8376         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8377
8378 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8379
8380         * source.c (select_source_symtab): Move header comment to
8381         declaration in source.h.
8382         (forget_cached_source_info_for_objfile): Likewise.
8383         (forget_cached_source_info): Likewise.
8384         (identify_source_line): Likewise.
8385         * source.h (identify_source_line): Move declaration from symtab.h
8386         and add comment from source.c
8387         (print_source_lines): Likewise.
8388         (forget_cached_source_info_for_objfile): Likewise.
8389         (forget_cached_source_info): Likewise.
8390         (select_source_symtab): Likewise.
8391         (enum print_source_lines_flag): Move definition from symtab.h.
8392         * symtab.h (identify_source_line): Move declaration to source.h.
8393         (print_source_lines): Likewise.
8394         (forget_cached_source_info_for_objfile): Likewise.
8395         (forget_cached_source_info): Likewise.
8396         (select_source_symtab): Likewise.
8397         (enum print_source_lines_flag): Move definition to source.h.
8398         * tui/tui-hooks.c: Add 'source.h' include.
8399
8400 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8401
8402         * source.c (print_source_lines_base): Handle requests to print
8403         reverse line number sequences, and guard against empty lines
8404         string.
8405
8406 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8407
8408         * source.c (print_source_lines_base): Fix skip of '\r' if next
8409         character is '\n'.
8410
8411 2019-01-06  Tom Tromey  <tom@tromey.com>
8412
8413         * c-exp.y (struct c_parse_state) <macro_original_text,
8414         expansion_obstack>: New member.
8415         (macro_original_text, expansion_obstack): Remove globals.
8416         (scan_macro_expansion, scanning_macro_expansion)
8417         (finished_macro_expansion): Update.
8418         (scan_macro_cleanup): Remove.
8419         (yylex, c_parse): Update.
8420
8421 2019-01-06  Tom Tromey  <tom@tromey.com>
8422
8423         * c-exp.y (struct c_parse_state) <strings>: New member.
8424         (operator_stoken): Update.
8425
8426 2019-01-06  Tom Tromey  <tom@tromey.com>
8427
8428         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8429         (union type_stack_elt) <typelist_val>: Now a pointer to
8430         std::vector.
8431         (type_stack_cleanup): Don't declare.
8432         (push_typelist): Update.
8433         * parse.c (pop_typelist): Return a std::vector.
8434         (push_typelist): Take a std::vector.
8435         (follow_types): Update.  Do not free args.
8436         (type_stack_cleanup): Remove.
8437         * c-exp.y (struct c_parse_state): New.
8438         (cpstate): New global.
8439         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8440         (nonempty_typelist): Update.
8441         (func_mod): Create a new vector.
8442         (c_parse): Create a c_parse_state.
8443         (check_parameter_typelist): Do not delete params.
8444         (function_method): Update.  Do not delete type_list.
8445
8446 2019-01-06  Tom Tromey  <tom@tromey.com>
8447
8448         PR gdb/28155:
8449         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8450         check_typedef.
8451         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8452         (print_return_value): Likewise.
8453
8454 2019-01-05  Tom Tromey  <tom@tromey.com>
8455
8456         * contrib/cleanup_check.py: Remove.
8457         * contrib/gcc-with-excheck: Remove.
8458         * contrib/exsummary.py: Remove.
8459         * contrib/excheck.py: Remove.
8460
8461 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8462
8463         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8464         NULL. Initialize tpprev to NULL instead of assigning it
8465         to NULL on the next statement.
8466         * windows-nat.c (windows_delete_thread): Remove check for
8467         main_thread_id before printing thread exit notifications.
8468         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8469         Remove thread ID check against main_thread_id.
8470         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8471         windows_delete_thread.
8472         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8473
8474 2019-01-04  Tom Tromey  <tom@tromey.com>
8475
8476         * compile/compile.c (_initialize_compile): Use upper case for
8477         metasyntactic variables.
8478         * symmisc.c (_initialize_symmisc): Use upper case for
8479         metasyntactic variables.
8480         * psymtab.c (_initialize_psymtab): Use upper case for
8481         metasyntactic variables.
8482         * demangle.c (demangle_command): Use upper case for metasyntactic
8483         variables.
8484         (_initialize_demangler): Likewise.
8485         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8486         variables.
8487
8488 2019-01-03  Tom Tromey  <tom@tromey.com>
8489
8490         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8491
8492 2019-01-03  Tom Tromey  <tom@tromey.com>
8493
8494         * python/py-symtab.c (salpy_str): Update.
8495         (struct salpy_sal_object) <symtab>: Now a PyObject.
8496         (salpy_dealloc): Update.
8497         (del_objfile_sal): Use gdbpy_ref.
8498
8499 2019-01-03  Tom Tromey  <tom@tromey.com>
8500
8501         * python/py-type.c (convert_field): Use new_reference.  Return
8502         gdbpy_ref.
8503         (make_fielditem): Return gdbpy_ref.
8504         (typy_fields): Update.
8505         (typy_getitem): Update.
8506         (field_name): Return gdbpy_ref.  Use new_reference.
8507         (typy_iterator_iternext): Update.
8508
8509 2019-01-03  Tom Tromey  <tom@tromey.com>
8510
8511         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8512
8513 2019-01-03  Tom Tromey  <tom@tromey.com>
8514
8515         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8516         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8517         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8518         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8519         (pspy_set_type_printers): Likewise.
8520         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8521         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8522         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8523         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8524         (objfpy_set_type_printers): Likewise.
8525
8526 2019-01-03  Tom Tromey  <tom@tromey.com>
8527
8528         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8529         (gdbpy_print_stack): Use gdbpy_err_fetch.
8530         * python/python-internal.h (class gdbpy_err_fetch): New class.
8531         (class gdbpy_enter) <m_error_type, m_error_value,
8532         m_error_traceback>: Remove.
8533         <m_error>: New member.
8534         (gdbpy_exception_to_string): Don't declare.
8535         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8536         * python/py-value.c (convert_value_from_python): Use
8537         gdbpy_err_fetch.
8538         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8539         gdbpy_exception_to_string.
8540         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8541         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8542         gdbpy_err_fetch.
8543
8544 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8545
8546         * linux-nat.c (delete_lwp_cleanup): Delete.
8547         (struct lwp_deleter): New struct.
8548         (lwp_info_up): New typedef.
8549         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8550         lwp_info_up.
8551
8552 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8553
8554         * linux-fork.c (class scoped_switch_fork_info): New class.
8555         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8556
8557 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8558
8559         * valops.c (find_overload_match): Remove use of null_cleanup, and
8560         calls to do_cleanups.
8561
8562 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8563
8564         * compile/compile-cplus-types.c
8565         (compile_cplus_instance::decl_name): Handle changes to
8566         cp_func_name.
8567         * cp-support.c (cp_func_name): Update header comment, update
8568         return type.
8569         * cp-support.h (cp_func_name): Update return type in declaration.
8570         * valops.c (find_overload_match): Move temp_func local to top
8571         level of function and change its type.  Use temp_func to hold and
8572         delete temporary string obtained from cp_func_name.
8573
8574 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8575
8576         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8577         gdb::char_vector, remove cleanup, and update uses of `msg`.
8578
8579 2019-01-03  Jim Wilson  <jimw@sifive.com>
8580
8581         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8582
8583 2019-01-02  Tom Tromey  <tom@tromey.com>
8584
8585         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8586         (tdesc_parse_xml): Remove cleanups.
8587         * target-descriptions.h (make_cleanup_free_target_description):
8588         Don't declare.
8589         (target_desc_deleter): New struct.
8590         (target_desc_up): New typedef.
8591         * target-descriptions.c (target_desc_deleter::operator()): Rename
8592         from free_target_description.
8593         (make_cleanup_free_target_description): Remove.
8594
8595 2019-01-02  Tom Tromey  <tom@tromey.com>
8596
8597         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8598         constructor, destructor.
8599         (linespec_parser): Remove typedef.
8600         (~linespec_parser): Rename from linespec_parser_delete.
8601         (linespec_lex_to_end, linespec_complete_label)
8602         (linespec_complete): Update.
8603         (decode_line_full): Remove cleanups.
8604         (decode_line_1): Update.
8605
8606 2019-01-02  Tom Tromey  <tom@tromey.com>
8607
8608         * python/python-internal.h (inferior_to_inferior_object): Change
8609         return type.
8610         * python/py-exitedevent.c (create_exited_event_object): Update.
8611         * python/py-inferior.c (inferior_to_inferior_object): Return
8612         gdbpy_ref.
8613         (python_new_inferior, python_inferior_deleted)
8614         (thread_to_thread_object, delete_thread_object)
8615         (build_inferior_list, gdbpy_selected_inferior): Update.
8616         * python/py-infthread.c (create_thread_object): Update.  Also fail
8617         if inferior_to_inferior_object fails.
8618
8619 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8620
8621         * inferior.h (class inferior) <displaced_step_state>: New field.
8622         * infrun.h (struct displaced_step_state): Move here from
8623         infrun.c.  Initialize fields, add constructor.
8624         <inf>: Remove field.
8625         <reset>: New method.
8626         * infrun.c (struct displaced_step_inferior_state): Move to
8627         infrun.h.
8628         (displaced_step_inferior_states): Remove.
8629         (get_displaced_stepping_state): Adust.
8630         (displaced_step_in_progress_any_inferior): Adjust.
8631         (displaced_step_in_progress_thread): Adjust.
8632         (displaced_step_in_progress): Adjust.
8633         (add_displaced_stepping_state): Remove.
8634         (get_displaced_step_closure_by_addr): Adjust.
8635         (remove_displaced_stepping_state): Remove.
8636         (infrun_inferior_exit): Call displaced_step_state.reset.
8637         (use_displaced_stepping): Don't check for NULL.
8638         (displaced_step_prepare_throw): Call
8639         get_displaced_stepping_state.
8640         (displaced_step_fixup): Don't check for NULL.
8641         (prepare_for_detach): Don't check for NULL.
8642
8643 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8644
8645         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8646          in case of call that did not complete.
8647
8648 2019-01-02  Andrey Utkin  <autkin@undo.io>
8649
8650         * symfile.c (find_separate_debug_file): Fix search of debug files for
8651         remote debuggee.
8652
8653 2019-01-02  Tom Tromey  <tom@tromey.com>
8654
8655         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8656         indentation.
8657         * python/py-frame.c (frapy_older): Remove cast.
8658         (frapy_newer): Likewise.
8659         * python/py-breakpoint.c (local_setattro): Remove cast.
8660         * python/py-arch.c (archpy_name): Remove local variable.
8661         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8662
8663 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8664
8665         * unittests/basic_string_view/element_access/char/empty.cc:
8666         Fix year range in copyright header.
8667
8668 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8669
8670         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8671         Delete.
8672         <operator==>: Update with for removed field.
8673         <hash>: Likewise.
8674         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8675         <isa_features>: ...this.
8676         <abi_features>: New field.
8677         (riscv_isa_flen): Update comment.
8678         (riscv_abi_xlen): New declaration.
8679         (riscv_abi_flen): New declaration.
8680         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8681         isa_features.
8682         (riscv_abi_xlen): New function.
8683         (riscv_isa_flen): Update to get answer from isa_features.
8684         (riscv_abi_flen): New function.
8685         (riscv_has_fp_abi): Update to get answer from abi_features.
8686         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8687         xlen and flen.
8688         (riscv_call_info) <xlen, flen>: Update comment.
8689         (riscv_call_arg_struct): Remove invalid assertions
8690         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8691         is removed.
8692         (riscv_gdbarch_init): Gather isa features and abi features
8693         separately, ensure both match on the gdbarch when reusing an old
8694         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8695         a target with 64-bit float hardware.
8696
8697 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8698
8699         * source.c (search_command_helper): Stop reverse search
8700         when line 1 has been searched.
8701
8702 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8703
8704         * record-full.c (record_full_base_target::close): Rewrite
8705         record_full_core_buf_list free logic.
8706
8707 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8708
8709         * break-catch-syscall.c (print_one_catch_syscall): xfree
8710         the last text.
8711
8712 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8713
8714         * top.c (print_gdb_version): Update Copyright year in version
8715         message.
8716
8717 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8718
8719         Update copyright year range in all GDB files.
8720
8721 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8722
8723         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8724
8725 For older changes see ChangeLog-2018.
8726 \f
8727 Local Variables:
8728 mode: change-log
8729 left-margin: 8
8730 fill-column: 74
8731 version-control: never
8732 coding: utf-8
8733 End:
8734