gdb/ChangeLog

   1 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
   2
   3         * breakpoint.h (remove_breakpoints_inf): Change return type to
   4         void, move function documentation here.
   5         * breakpoint.c (remove_breakpoints_inf): Change return type to
   6         void, move function documentation to header.
   7
   8 2019-07-02  Pedro Alves  <palves@redhat.com>
   9
  10         * NEWS (Completion improvements): Mention "info threads".
  11         * thread.c (struct info_threads_opts, info_threads_option_defs)
  12         (make_info_threads_options_def_group): New.
  13         (info_threads_command): Use gdb::option::process_options.
  14         (info_threads_command_completer): New.
  15         (_initialize_thread): Use gdb::option::build_help to build the
  16         help text for "info threads".
  17
  18 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
  19
  20         * defs.h (generic_load): Move from here...
  21         * symfile.h (generic_load): ... to here.  Rename name parameter
  22         to args.
  23         * symfile.c (generic_load): Add comment.
  24
  25 2019-07-01  Tom Tromey  <tromey@adacore.com>
  26
  27         * dwarf2read.c
  28         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
  29         declaration of without_params.  Fix formatting.
  30
  31 2019-07-01  Tom Tromey  <tromey@adacore.com>
  32
  33         * ada-exp.y (find_primitive_type): Update.
  34         * ada-lang.h (ada_lookup_symbol): Update.
  35         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
  36         parameter.
  37         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
  38
  39 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
  40
  41         PR breakpoints/24541
  42         * gdbarch.c: Regenerate.
  43         * gdbarch.h: Regenerate.
  44         * gdbarch.sh: Add 'stap_adjust_register'.
  45         * i386-tdep.c: Include '<unordered_set>'.
  46         (i386_stap_adjust_register): New function.
  47         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
  48         * stap-probe.c (stap_parse_register_operand): Call
  49         'gdbarch_stap_adjust_register'.
  50
  51 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
  52
  53         PR python/24742
  54         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
  55         * python/python.c (do_start_initialization): Use 'xmalloc'
  56         instead of 'PyMem_Malloc'.
  57
  58 2019-06-28  Tom Tromey  <tromey@adacore.com>
  59
  60         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
  61         for Ada.
  62
  63 2019-06-27  Tom Tromey  <tromey@adacore.com>
  64
  65         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
  66         objfile_key.
  67         (arm_find_mapping_symbol, arm_record_special_symbol)
  68         (_initialize_arm_tdep): Update.
  69         (arm_objfile_data_free): Remove.
  70
  71 2019-06-27  Tom Tromey  <tromey@adacore.com>
  72
  73         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
  74         to cp_print_static_field.
  75
  76 2019-06-26  Tom Tromey  <tromey@adacore.com>
  77
  78         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
  79         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
  80         declare.
  81
  82 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
  83
  84         * features/aarch64-core.c (create_feature_aarch64_core):
  85         Regenerate.
  86         * features/aarch64-core.xml: Add cpsr flags.
  87
  88 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
  89
  90         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
  91         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
  92
  93 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
  94
  95         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
  96         field.
  97         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
  98         use.
  99         (arm_record_special_symbol): Don't insert new symbol in sorted
 100         position, push it at the end.
 101
 102 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 103
 104         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 105         (arm_mapping_symbol_s): Remove.
 106         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 107         (arm_mapping_symbol_vec): New typedef.
 108         (struct arm_per_objfile): Add constructor.
 109         <section_maps>: Change type to
 110         std::unique_ptr<arm_mapping_symbol_vec[]>.
 111         (arm_compare_mapping_symbols): Remove.
 112         (arm_find_mapping_symbol): Adjust to section_maps type change.
 113         (arm_objfile_data_free): Call delete on arm_per_objfile.
 114         (arm_record_special_symbol): Adjust to section_maps type change.
 115         Allocate arm_per_objfile with new.
 116
 117 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 118
 119         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 120         with the command prefix.
 121
 122 2019-06-25  Tom Tromey  <tom@tromey.com>
 123
 124         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 125         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 126
 127 2019-06-25  Tom Tromey  <tom@tromey.com>
 128
 129         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 130         type.
 131         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 132         protected.
 133
 134 2019-06-25  Tom Tromey  <tom@tromey.com>
 135
 136         * tui/tui-winsource.c
 137         (tui_source_window_base::set_is_exec_point_at): Add check against
 138         LOA_ADDRESS.
 139
 140 2019-06-25  Tom Tromey  <tom@tromey.com>
 141
 142         * tui/tui-source.c (tui_set_source_content): Don't check before
 143         xfree.
 144         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 145
 146 2019-06-25  Tom Tromey  <tom@tromey.com>
 147
 148         * tui/tui-winsource.h (tui_update_source_window_as_is)
 149         (tui_alloc_source_buffer, tui_line_is_displayed)
 150         (tui_addr_is_displayed): Change type of win_info.
 151         * tui/tui-winsource.c (tui_update_source_window_as_is)
 152         (tui_clear_source_content, tui_show_source_line)
 153         (tui_show_source_content, tui_source_window_base::refill)
 154         (tui_source_window_base::set_is_exec_point_at)
 155         (tui_source_window_base::set_is_exec_point_at)
 156         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 157         (tui_alloc_source_buffer, tui_line_is_displayed)
 158         (tui_addr_is_displayed): Change type of win_info.  Update.
 159         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 160         (tui_source_window_base::do_make_visible_with_new_height):
 161         Update.
 162         * tui/tui-source.c (tui_set_source_content)
 163         (tui_set_source_content_nil)
 164         (tui_source_window::do_scroll_vertical): Update.
 165         * tui/tui-layout.c (show_layout): Update.
 166         * tui/tui-disasm.c (tui_set_disassem_content)
 167         (tui_disasm_window::do_scroll_vertical): Update.
 168         * tui/tui-data.h (tui_win_content): Remove.
 169         (struct tui_gen_win_info) <content, content_size>: Remove.
 170         (struct tui_source_element): Add initializers and destructor.
 171         (union tui_which_element, struct tui_win_element): Remove.
 172         (struct tui_source_window_base) <content>: New field.
 173         (struct tui_data_window): Remove destructor.
 174         (tui_alloc_content, tui_free_win_content)
 175         (tui_free_all_source_wins_content): Don't declare.
 176         * tui/tui-data.c (tui_initialize_static_data): Update.
 177         (init_content_element, tui_alloc_content): Remove.
 178         (~tui_gen_win_info): Update.
 179         (~tui_data_window, tui_free_all_source_wins_content)
 180         (tui_free_win_content, free_content, free_content_elements):
 181         Remove.
 182
 183 2019-06-25  Tom Tromey  <tom@tromey.com>
 184
 185         * tui/tui-winsource.h (tui_clear_source_content)
 186         (tui_erase_source_content, tui_show_source_content): Change type
 187         of win_info.
 188         * tui/tui-winsource.c (tui_clear_source_content)
 189         (tui_erase_source_content, tui_show_source_content): Change type
 190         of win_info.
 191         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 192         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 193         win_info.
 194         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 195         win_info.
 196         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 197
 198 2019-06-25  Tom Tromey  <tom@tromey.com>
 199
 200         * tui/tui-winsource.c (tui_clear_source_content)
 201         (tui_source_window_base::set_is_exec_point_at): Update.
 202         * tui/tui-source.c (tui_set_source_content_nil): Update.
 203         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 204         a bool.
 205         * tui/tui-data.c (init_content_element): Update.
 206
 207 2019-06-25  Tom Tromey  <tom@tromey.com>
 208
 209         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 210         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 211         * tui/tui-layout.c (init_and_make_win): Update.
 212         * tui/tui.h (enum tui_win_type): Update.
 213         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 214         tui_win_is_auxillary.
 215         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 216         tui_win_is_auxillary.
 217
 218 2019-06-25  Tom Tromey  <tom@tromey.com>
 219
 220         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 221         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 222         (tui_delete_data_content_windows, tui_display_all_data)
 223         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 224         Update.
 225         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 226         * tui/tui-regs.c (tui_last_regs_line_no)
 227         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 228         (tui_show_registers): Update.
 229         (tui_show_register_group): Return void.  Update.
 230         (tui_display_registers_from, tui_display_reg_element_at_line)
 231         (tui_display_registers_from_line, tui_check_register_values):
 232         Update.
 233         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 234         member.
 235         (struct tui_data_window) <regs_content>: Now a std::vector.
 236         <regs_content_count>: Remove.
 237         (tui_add_content_elements, tui_free_data_content): Don't declare.
 238         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 239         (init_content_element): Remove DATA_WIN case.  Add assert.
 240         (tui_add_content_elements): Remove.
 241         (tui_data_window): Update.
 242         (tui_free_data_content): Remove.
 243         (free_content_elements): Remove DATA_WIN case.
 244
 245 2019-06-25  Tom Tromey  <tom@tromey.com>
 246
 247         * tui/tui-data.c (tui_data_item_window): Update.
 248         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 249         * tui/tui-windata.c (tui_display_all_data)
 250         (tui_display_data_from_line): Update.
 251         (tui_check_data_values): Remove.
 252         * tui/tui-regs.c (tui_show_register_group)
 253         (tui_display_reg_element_at_line): Update.
 254         * tui/tui-hooks.c (tui_register_changed)
 255         (tui_refresh_frame_and_register_information): Call
 256         tui_check_register_values.
 257         * tui/tui-data.h (struct tui_data_window) <data_content,
 258         data_content_count, data_type>: Remove.
 259         (enum tui_data_type): Remove.
 260
 261         * tui/tui-data.c (tui_data_window::clear_detail)
 262         (~tui_data_window): Update.
 263
 264 2019-06-25  Tom Tromey  <tom@tromey.com>
 265
 266         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 267         declare.
 268         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 269         Rename from tui_first_data_item_displayed.  Update.
 270         (tui_data_window::refresh_all)
 271         (tui_data_window::do_scroll_vertical): Update.
 272         * tui/tui-data.h (struct tui_data_window)
 273         <first_data_item_displayed>: Declare new method.
 274
 275 2019-06-25  Tom Tromey  <tom@tromey.com>
 276
 277         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 278         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 279         contents...
 280         (tui_initialize_static_data): ...here.
 281
 282 2019-06-25  Tom Tromey  <tom@tromey.com>
 283
 284         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 285         (tui_display_registers_from, tui_check_register_values): Update.
 286         (tui_display_register): Remove win_info parameter; update.
 287         (tui_get_register): Change type of parameters.
 288         * tui/tui-data.h (struct tui_data_element): Remove.
 289         (union tui_which_element) <data>: Remove.
 290         <data_window>: Change type.
 291         (struct tui_data_item_window): New.
 292         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 293         case.  Add assert.
 294         (~tui_data_item_window): New destructor.
 295         (free_content_elements): Remove DATA_ITEM_WIN case.
 296
 297 2019-06-25  Tom Tromey  <tom@tromey.com>
 298
 299         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 300         Remove.
 301
 302 2019-06-25  Tom Tromey  <tom@tromey.com>
 303
 304         * tui/tui-data.h (struct tui_command_element): Remove.
 305         (union tui_which_element) <command>: Remove.
 306         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 307         assert.
 308         (free_content_elements): Remove CMD_WIN case.
 309
 310 2019-06-25  Tom Tromey  <tom@tromey.com>
 311
 312         * tui/tui-layout.c (tui_set_layout): Update.
 313         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 314         * tui/tui-data.c (layout_def): Update.
 315
 316 2019-06-25  Tom Tromey  <tom@tromey.com>
 317
 318         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 319         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 320         (tui_source_window_base::set_new_height): Update.
 321         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 322         Update.
 323         (tui_set_locator_fullname, tui_set_locator_info)
 324         (tui_show_frame_info): Update.
 325         * tui/tui-source.c (tui_set_source_content)
 326         (tui_source_is_displayed): Update.
 327         * tui/tui-layout.c (show_source_disasm_command, show_data)
 328         (show_source_or_disasm_and_command): Update.
 329         * tui/tui-disasm.c (tui_set_disassem_content)
 330         (tui_get_begin_asm_address): Update.
 331         * tui/tui-data.h (struct tui_locator_element): Remove.
 332         (union tui_which_element) <locator>: Remove.
 333         (struct tui_locator_window): New.
 334         (tui_locator_win_info_ptr): Change return type.
 335         * tui/tui-data.c (_locator): Change type.
 336         (tui_locator_win_info_ptr): Change return type.
 337         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 338         (tui_alloc_content): Add assert.
 339
 340 2019-06-25  Tom Tromey  <tom@tromey.com>
 341
 342         * tui/tui-winsource.c
 343         (tui_exec_info_window::maybe_allocate_content): New method.
 344         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 345         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 346         (make_source_or_disasm_window): Add cast.
 347         * tui/tui-data.h (union tui_which_element) <simple_string>:
 348         Remove.
 349         (struct tui_source_info): New.
 350         (struct tui_source_window_base) <execution_info>: Change type.
 351         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 352         case, and add assert.
 353         (tui_alloc_content): Add assert.
 354
 355 2019-06-25  Tom Tromey  <tom@tromey.com>
 356
 357         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 358         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 359         * tui/tui-data.c (tui_alloc_win_info): Remove.
 360
 361 2019-06-25  Tom Tromey  <tom@tromey.com>
 362
 363         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 364         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 365         can_highlight.
 366
 367 2019-06-25  Tom Tromey  <tom@tromey.com>
 368
 369         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 370         make_visible_with_new_height method.
 371         (tui_win_info::make_visible_with_new_height): New method.
 372         (tui_source_window_base::do_make_visible_with_new_height)
 373         (tui_data_window::do_make_visible_with_new_height)
 374         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 375         (make_visible_with_new_height): Remove.
 376         (tui_resize_all, tui_adjust_win_heights): Use
 377         make_visible_with_new_height method.
 378         * tui/tui-data.h (struct tui_win_info)
 379         <do_make_visible_with_new_height, make_visible_with_new_height>:
 380         New methods.
 381         (struct tui_source_window_base, struct tui_data_window)
 382         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 383         methods.
 384
 385 2019-06-25  Tom Tromey  <tom@tromey.com>
 386
 387         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 388         method.
 389         (update_tab_width): Call update_tab_width method.
 390         * tui/tui-data.h (struct tui_win_info)
 391         (struct tui_source_window_base) <update_tab_width>: New methods.
 392
 393 2019-06-25  Tom Tromey  <tom@tromey.com>
 394
 395         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 396         parameter.
 397         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 398         parameter.
 399         (tui_gen_win_info::make_visible): Update.
 400         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 401         parameter.
 402         * tui/tui-data.h (enum tui_box): New enum.
 403         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 404
 405 2019-06-25  Tom Tromey  <tom@tromey.com>
 406
 407         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 408         init_and_make_win for EXEC_INFO_WIN.
 409         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 410         longer inline.
 411         (struct tui_win_info) <~tui_win_info>: Inline.
 412         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 413         Don't declare.
 414         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 415         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 416         Remove.
 417         (tui_initialize_static_data): Update.
 418         (~tui_gen_win_info): Handle more cleanup here.
 419         (~tui_source_window_base): Delete "execution_info".
 420         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 421
 422 2019-06-25  Tom Tromey  <tom@tromey.com>
 423
 424         * tui/tui-layout.c (make_command_window): Don't set
 425         can_highlight.
 426         (show_source_disasm_command): Call the reset method.
 427         (show_data): Don't set can_highlight.  Call the reset method.
 428         (tui_gen_win_info::reset): Rename from init_gen_win_info
 429         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 430         (show_source_or_disasm_and_command): Call the reset method.
 431         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 432         (struct tui_cmd_window): Set can_highlight.
 433
 434 2019-06-25  Tom Tromey  <tom@tromey.com>
 435
 436         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 437         from make_visible.
 438         (tui_make_visible, tui_make_invisible): Rewrite.
 439         (tui_win_info::make_visible): Remove.
 440         (tui_source_window_base::make_visible): Update.
 441         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 442         method.  Moved from...
 443         (struct tui_win_info) <make_visible>: ...here.
 444
 445 2019-06-25  Tom Tromey  <tom@tromey.com>
 446
 447         * tui/tui-winsource.c
 448         (tui_source_window_base::do_scroll_horizontal): Remove direction
 449         parameter.
 450         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 451         direction parameter.
 452         * tui/tui-win.c (tui_win_info::forward_scroll)
 453         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 454         (tui_win_info::right_scroll): Update.
 455         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 456         direction parameter.
 457         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 458         direction parameter.
 459         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 460         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 461         Remove direction parameter.
 462         (struct tui_source_window_base, struct tui_source_window)
 463         (struct tui_disasm_window, struct tui_data_window)
 464         (struct tui_cmd_window): Update.
 465
 466 2019-06-25  Tom Tromey  <tom@tromey.com>
 467
 468         * tui/tui-winsource.h (tui_set_exec_info_content)
 469         (tui_show_exec_info_content, tui_erase_exec_info_content)
 470         (tui_clear_exec_info_content, tui_update_exec_info): Change
 471         argument to tui_source_window_base.
 472         * tui/tui-winsource.c (tui_set_exec_info_content)
 473         (tui_show_exec_info_content, tui_erase_exec_info_content)
 474         (tui_clear_exec_info_content, tui_update_exec_info): Change
 475         argument to tui_source_window_base.
 476
 477 2019-06-25  Tom Tromey  <tom@tromey.com>
 478
 479         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 480         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 481
 482 2019-06-25  Tom Tromey  <tom@tromey.com>
 483
 484         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 485         check.
 486
 487 2019-06-25  Tom Tromey  <tom@tromey.com>
 488
 489         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 490         type to void.
 491         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 492         type to void.
 493         * tui/tui-source.c (tui_set_source_content): Update.
 494         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 495
 496 2019-06-25  Tom Tromey  <tom@tromey.com>
 497
 498         * tui/tui-win.c (window_name_completer, tui_set_focus)
 499         (tui_all_windows_info): Use name method.
 500         * tui/tui-data.h (struct tui_gen_win_info)
 501         (struct tui_source_window, struct tui_disasm_window)
 502         (struct tui_data_window, struct tui_cmd_window) <name>: New
 503         method.
 504         (tui_win_name): Don't declare.
 505         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 506         (tui_win_name): Remove.
 507
 508 2019-06-25  Tom Tromey  <tom@tromey.com>
 509
 510         * tui/tui-winsource.h (tui_update_source_window)
 511         (tui_update_source_window_as_is): Change parameter type.
 512         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 513         to be a tui_source_window_base.
 514         (tui_update_source_window_as_is): Likewise.
 515         * tui/tui-win.c (make_visible_with_new_height): Update.
 516
 517 2019-06-25  Tom Tromey  <tom@tromey.com>
 518
 519         * tui/tui-winsource.c (tui_erase_source_content)
 520         (tui_show_source_content, tui_show_exec_info_content)
 521         (tui_erase_exec_info_content): Use refresh_window method.
 522         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 523         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 524         from tui_refresh_win.
 525         (tui_data_window::refresh_window): New method.
 526         (tui_win_info::refresh, tui_source_window_base::refresh)
 527         (tui_refresh_all): Use refresh_window method.
 528         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 529         method.
 530         * tui/tui-regs.c (tui_display_register): Call refresh_window
 531         method.
 532         * tui/tui-layout.c (show_source_disasm_command)
 533         (show_source_or_disasm_and_command): Call refresh_window method.
 534         * tui/tui-data.h (struct tui_gen_win_info)
 535         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 536         New method.
 537
 538 2019-06-25  Tom Tromey  <tom@tromey.com>
 539
 540         * tui/tui.c (tui_rl_other_window, tui_enable)
 541         (tui_is_window_visible, tui_get_command_dimension): Update.
 542         * tui/tui-winsource.c (tui_update_source_window_as_is)
 543         (tui_clear_source_content, tui_erase_source_content)
 544         (tui_show_source_line, tui_source_window_base::refill)
 545         (tui_source_window_base::do_scroll_horizontal)
 546         (tui_source_window_base::set_is_exec_point_at)
 547         (tui_update_breakpoint_info, tui_set_exec_info_content)
 548         (tui_alloc_source_buffer, tui_line_is_displayed)
 549         (tui_addr_is_displayed): Update.
 550         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 551         (tui_check_and_display_highlight_if_needed)
 552         (tui_win_info::make_visible, tui_win_info::refresh)
 553         (tui_refresh_all): Update.
 554         * tui/tui-windata.c (tui_first_data_item_displayed)
 555         (tui_delete_data_content_windows, tui_erase_data_content)
 556         (tui_display_all_data, tui_data_window::refresh_all)
 557         (tui_check_data_values): Update.
 558         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 559         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 560         (tui_win_info::backward_scroll, tui_refresh_all_win)
 561         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 562         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 563         (tui_source_window_base::set_new_height)
 564         (tui_data_window::set_new_height)
 565         (make_invisible_and_set_new_height)
 566         (make_visible_with_new_height, new_height_ok)
 567         (parse_scrolling_args): Update.
 568         * tui/tui-stack.c (tui_show_frame_info): Update.
 569         * tui/tui-source.c (tui_set_source_content)
 570         (tui_set_source_content_nil, tui_source_is_displayed)
 571         (tui_source_window::do_scroll_vertical): Update.
 572         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 573         (tui_display_registers_from, tui_display_reg_element_at_line)
 574         (tui_check_register_values, tui_reg_command): Update.
 575         * tui/tui-layout.c (tui_default_win_height)
 576         (show_source_disasm_command, show_data, init_and_make_win)
 577         (show_source_or_disasm_and_command): Update.
 578         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 579         (tui_redisplay_readline, tui_mld_flush)
 580         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 581         (tui_getc): Update.
 582         * tui/tui-disasm.c (tui_set_disassem_content)
 583         (tui_disasm_window::do_scroll_vertical): Update.
 584         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 585         Now virtual.
 586         (struct tui_win_info): Derive from tui_gen_win_info.
 587         <~tui_win_info>: Mark as override.
 588         <generic>: Remove member.
 589         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 590         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 591         (~tui_data_window, ~tui_win_info)
 592         (tui_free_all_source_wins_content): Update.
 593         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 594
 595 2019-06-25  Tom Tromey  <tom@tromey.com>
 596
 597         * tui/tui-layout.c (init_and_make_win): Use new.
 598         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 599         destructor, initializers.
 600         (tui_alloc_generic_win_info): Don't declare.
 601         * tui/tui-data.c (_locator): Add argument to constructor.
 602         (source_win, disasm_win): New globals.
 603         (exec_info): Remove.
 604         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 605         Update.
 606         (tui_alloc_generic_win_info): Remove.
 607         (init_content_element): Use new.
 608         (tui_win_info::tui_win_info): Update.
 609         (free_content_elements) <case DATA_WIN>: Use delete.
 610
 611 2019-06-25  Tom Tromey  <tom@tromey.com>
 612
 613         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 614         * tui/tui-windata.c (tui_first_data_item_displayed)
 615         (tui_delete_data_content_windows): Update.
 616         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 617         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 618         (tui_display_registers_from, tui_check_register_values): Update.
 619         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 620         pointer.
 621         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 622         window.
 623         (tui_free_data_content): Update.
 624         (free_content_elements) <case DATA_WIN>: Free the window.
 625
 626 2019-06-25  Tom Tromey  <tom@tromey.com>
 627
 628         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 629         Update.
 630         * tui/tui-layout.c (make_command_window)
 631         (show_source_disasm_command, show_data, init_and_make_win)
 632         (show_source_or_disasm_and_command): Update.
 633         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 634         method.
 635         <can_highight, is_highlighted>: Now bool.
 636         (tui_set_win_highlight): Don't declare.
 637         * tui/tui-data.c (tui_set_win_highlight): Remove.
 638
 639 2019-06-25  Tom Tromey  <tom@tromey.com>
 640
 641         * tui/tui-wingeneral.c (make_visible): Remove check of window
 642         type.
 643
 644 2019-06-25  Tom Tromey  <tom@tromey.com>
 645
 646         * tui/tui-win.c (tui_win_info::max_height)
 647         (tui_cmd_window::max_height): New methods.
 648         (new_height_ok): Call max_height.
 649         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 650         <max_height>: New method.
 651
 652 2019-06-25  Tom Tromey  <tom@tromey.com>
 653
 654         * tui/tui-win.c (tui_source_window_base::set_new_height)
 655         (tui_data_window::set_new_height): New methods.
 656         (make_invisible_and_set_new_height): Call set_new_height method.
 657         * tui/tui-data.h (struct tui_win_info)
 658         (struct tui_source_window_base, struct tui_data_window)
 659         <set_new_height>: New method.
 660
 661 2019-06-25  Tom Tromey  <tom@tromey.com>
 662
 663         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 664         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 665         tui_refresh_data_win.
 666         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 667         method.
 668         (tui_refresh_all_win): Call the refresh_all method.
 669         (tui_set_focus): Likewise.
 670         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 671         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 672         Likewise.
 673
 674 2019-06-25  Tom Tromey  <tom@tromey.com>
 675
 676         * tui/tui-winsource.h (tui_refill_source_window)
 677         (tui_set_is_exec_point_at): Don't declare.
 678         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 679         (tui_source_window_base::refill): Rename from
 680         tui_refill_source_window.
 681         (tui_source_window_base::do_scroll_horizontal): Update.
 682         (tui_source_window_base::set_is_exec_point_at): Rename from
 683         tui_set_is_exec_point_at.
 684         (tui_update_all_breakpoint_info): Update.
 685         * tui/tui-stack.c (tui_show_frame_info): Update.
 686         * tui/tui-layout.c (show_data): Add cast.
 687         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 688         * tui/tui-data.h (struct tui_source_window_base) <refill,
 689         set_is_exec_point_at>: New methods.
 690         (tui_source_windows, tui_add_to_source_windows): Update types.
 691         (tui_add_to_source_windows): Remove redundant declaration.
 692         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 693         (tui_source_windows): Change return type.
 694         (tui_clear_source_windows_detail): Update.
 695         (tui_add_to_source_windows): Change type of parameter.
 696         (tui_free_all_source_wins_content): Update.
 697
 698 2019-06-25  Tom Tromey  <tom@tromey.com>
 699
 700         * tui/tui-wingeneral.c (tui_win_info::refresh)
 701         (tui_source_window_base::refresh): New methods.
 702         (tui_refresh_all): Call the refresh method.
 703         * tui/tui-data.h (struct tui_win_info)
 704         (struct tui_source_window_base) <refresh>: New method.
 705
 706 2019-06-25  Tom Tromey  <tom@tromey.com>
 707
 708         * tui/tui.h (tui_is_window_visible): Return bool.
 709         * tui/tui.c (tui_is_window_visible): Return bool.
 710         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 711         (tui_make_visible, tui_make_invisible)
 712         (tui_win_info::make_visible)
 713         (tui_source_window_base::make_visible, make_all_visible)
 714         (tui_make_all_visible, tui_make_all_invisible): Update.
 715         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 716         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 717         bool.
 718         (struct tui_win_info, struct tui_source_window_base)
 719         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 720         * tui/tui-data.c (tui_init_generic_part): Update.
 721
 722 2019-06-25  Tom Tromey  <tom@tromey.com>
 723
 724         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 725         (tui_source_window_base::make_visible): New methods.
 726         (make_all_visible): Make method call.
 727         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 728         (struct tui_source_window_base, struct tui_cmd_window): Override
 729         make_visible.
 730         (tui_win_is_source_type): Don't declare.
 731         * tui/tui-data.c (tui_win_is_source_type): Remove.
 732
 733 2019-06-25  Tom Tromey  <tom@tromey.com>
 734
 735         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 736         NULL check.
 737
 738 2019-06-25  Tom Tromey  <tom@tromey.com>
 739
 740         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 741         Inline constructor.  Add initializers for members.
 742         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 743         constructors; now inline in class.
 744
 745 2019-06-25  Tom Tromey  <tom@tromey.com>
 746
 747         * tui/tui-regs.c (tui_show_registers): Update.
 748         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 749         bool.
 750         * tui/tui-data.c (tui_data_window::clear_detail)
 751         (tui_data_window): Update.
 752
 753 2019-06-25  Tom Tromey  <tom@tromey.com>
 754
 755         * tui/tui-windata.c (tui_display_all_data)
 756         (tui_display_data_from_line, tui_display_data_from)
 757         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 758         Update.
 759         * tui/tui-regs.c (tui_last_regs_line_no)
 760         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 761         (tui_show_registers, tui_show_register_group)
 762         (tui_display_registers_from, tui_display_reg_element_at_line)
 763         (tui_display_registers_from_line, tui_check_register_values)
 764         (tui_reg_next, tui_reg_prev): Update.
 765         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 766         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 767         tui_data_window.
 768         (struct tui_win_info) <detail>: Remove.  Add new fields from
 769         tui_data_info.
 770         (TUI_DATA_WIN): Add cast.
 771         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 772         (~tui_data_window): Simplify.
 773
 774 2019-06-25  Tom Tromey  <tom@tromey.com>
 775
 776         * tui/tui-layout.c (show_source_disasm_command)
 777         (show_source_or_disasm_and_command): Update.
 778         * tui/tui-io.c (update_cmdwin_start_line)
 779         (tui_redisplay_readline): Update.
 780         * tui/tui-data.h (struct tui_command_info): Remove.
 781         (struct tui_win_info) <detail>: Remove command_info member.
 782         (struct tui_data_window) <start_line>: New member, from
 783         tui_command_info.
 784         (TUI_CMD_WIN): Add casts.
 785
 786 2019-06-25  Tom Tromey  <tom@tromey.com>
 787
 788         * tui/tui-winsource.c (tui_update_source_window)
 789         (tui_refill_source_window)
 790         (tui_source_window_base::do_scroll_horizontal)
 791         (tui_update_breakpoint_info, tui_set_exec_info_content)
 792         (tui_show_exec_info_content, tui_erase_exec_info_content)
 793         (tui_clear_exec_info_content): Update.
 794         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 795         Update.
 796         * tui/tui-win.c (make_invisible_and_set_new_height)
 797         (make_visible_with_new_height): Update.
 798         * tui/tui-source.c (tui_set_source_content)
 799         (tui_show_symtab_source): Update.
 800         * tui/tui-layout.c (extract_display_start_addr)
 801         (show_source_disasm_command, show_data)
 802         (make_source_or_disasm_window)
 803         (show_source_or_disasm_and_command): Update.
 804         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 805         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 806         "gdbarch".
 807         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 808         to tui_source_window_base.
 809         (struct tui_win_info) <detail>: Remove source_info member.
 810         (struct tui_source_window_base) <has_locator>: Inline.
 811         Move contents from tui_source_info; rename has_locator member to
 812         m_has_locator.
 813         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 814         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 815         header file.
 816         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 817         Simplify.
 818         (tui_free_all_source_wins_content): Cast to
 819         tui_source_window_base.
 820
 821 2019-06-25  Tom Tromey  <tom@tromey.com>
 822
 823         * tui/tui-win.c (make_invisible_and_set_new_height)
 824         (make_visible_with_new_height): Call has_locator method.
 825         * tui/tui-layout.c (show_source_disasm_command, show_data)
 826         (show_source_or_disasm_and_command): Update for bool change.
 827         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 828         (tui_win_info) <has_locator>: New method.
 829         (struct tui_source_window_base) <has_locator>: New method.
 830         (tui_win_has_locator): Don't declare.
 831         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 832         from tui_win_has_locator.
 833         (tui_source_window_base): Use false, not FALSE.
 834
 835 2019-06-25  Tom Tromey  <tom@tromey.com>
 836
 837         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 838         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 839         clear_detail method directly.
 840         (tui_clear_win_detail): Remove.
 841
 842 2019-06-25  Tom Tromey  <tom@tromey.com>
 843
 844         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 845         "this", not TUI_DISASM_WIN.
 846
 847 2019-06-25  Tom Tromey  <tom@tromey.com>
 848
 849         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 850         declare.
 851         * tui/tui-winsource.c
 852         (tui_source_window_base::do_scroll_horizontal): Rename from
 853         tui_horizontal_source_scroll.
 854         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 855         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 856         from tui_vertical_data_scroll.
 857         * tui/tui-win.h (tui_scroll): Don't declare.
 858         * tui/tui-win.c (tui_win_info::forward_scroll)
 859         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 860         (tui_win_info::right_scroll): Rename and update.
 861         (tui_scroll_forward_command, tui_scroll_backward_command)
 862         (tui_scroll_left_command, tui_scroll_right_command): Update.
 863         (tui_scroll): Remove.
 864         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 865         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 866         from tui_vertical_source_scroll.
 867         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 868         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 869         from tui_vertical_disassem_scroll.
 870         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 871         do_scroll_horizontal>: New methods.
 872         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 873         Likewise.
 874         (struct tui_source_window_base): Add do_scroll_horizontal.
 875         (struct tui_source_window, struct tui_disasm_window): Add
 876         do_scroll_vertical.
 877         (struct tui_data_window, struct tui_cmd_window): Add
 878         do_scroll_horizontal and do_scroll_vertical.
 879         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 880
 881 2019-06-25  Tom Tromey  <tom@tromey.com>
 882
 883         * tui/tui-data.h (struct tui_source_window_base): New struct.
 884         (struct tui_source_window): Derive from tui_source_window_base.
 885         (struct tui_disasm_window): New struct.
 886         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 887         from tui_source_window::clear_detail.
 888         (tui_source_window_base): Rename from tui_source_window.
 889         (~tui_source_window_base): Rename from ~tui_source_window.
 890         (tui_alloc_win_info): Create a tui_disasm_window.
 891
 892 2019-06-25  Tom Tromey  <tom@tromey.com>
 893
 894         * tui/tui-data.h (struct tui_source_window)
 895         (struct tui_data_window): Declare destructors.
 896         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 897         destructors.
 898         (tui_win_info): Simplify.
 899
 900 2019-06-25  Tom Tromey  <tom@tromey.com>
 901
 902         * tui/tui-winsource.c (tui_display_main)
 903         (tui_update_source_windows_with_addr)
 904         (tui_update_all_breakpoint_info): Update.
 905         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 906         (new_height_ok, parse_scrolling_args): Update.
 907         * tui/tui-stack.c (tui_show_frame_info): Update.
 908         * tui/tui-data.h (struct tui_list): Remove.
 909         (tui_source_windows): Return a reference to a std::vector.
 910         * tui/tui-data.c (source_windows): Now a std::vector.
 911         (tui_source_windows): Change return type.
 912         (tui_clear_source_windows): Rewrite.
 913         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 914         (tui_free_all_source_wins_content): Rewrite.
 915
 916 2019-06-25  Tom Tromey  <tom@tromey.com>
 917
 918         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 919         (struct tui_data_window, struct tui_cmd_window): Declare
 920         clear_detail method.
 921         * tui/tui-data.c (tui_source_window::clear_detail)
 922         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 923         methods.
 924         (tui_clear_win_detail): Simplify.
 925
 926 2019-06-25  Tom Tromey  <tom@tromey.com>
 927
 928         * tui/tui-layout.c (make_source_window, make_disasm_window)
 929         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 930         Return the new window.
 931         (show_source_disasm_command, show_data)
 932         (show_source_or_disasm_and_command): Update.
 933
 934 2019-06-25  Tom Tromey  <tom@tromey.com>
 935
 936         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 937         parameter.  Return the new window.
 938         (show_source_disasm_command): Update and remove NULL check.
 939         (show_source_or_disasm_and_command): Update.
 940
 941 2019-06-25  Tom Tromey  <tom@tromey.com>
 942
 943         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 944
 945 2019-06-25  Tom Tromey  <tom@tromey.com>
 946
 947         * tui/tui-data.h (struct tui_win_info): Make constructor
 948         protected.  Make destructor virtual.  Add initializers.
 949         (tui_source_window, tui_data_window, tui_cmd_window): New
 950         classes.
 951         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 952         constructor.  Add "type" parameter.
 953         (tui_source_window, tui_data_window, tui_cmd_window): New
 954         constructors.
 955         (tui_alloc_win_info): Instantiate the appropriate subclass.
 956
 957 2019-06-25  Tom Tromey  <tom@tromey.com>
 958
 959         * tui/tui-win.c (tui_resize_all): Use delete.
 960         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 961         destructor.
 962         (tui_free_window): Don't declare.
 963         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 964         Update.
 965
 966 2019-06-25  Tom Tromey  <tom@tromey.com>
 967
 968         * tui/tui-data.h (struct tui_win_info): Add constructor.
 969         * tui/tui-data.c (tui_alloc_win_info): Use new.
 970         (tui_free_window): Use delete.
 971
 972 2019-06-22  Tom Tromey  <tom@tromey.com>
 973
 974         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 975         declare.
 976         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 977
 978 2019-06-22  Tom Tromey  <tom@tromey.com>
 979
 980         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 981         declare.
 982         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 983
 984 2019-06-22  Tom de Vries  <tdevries@suse.de>
 985
 986         * dwarf2read.c (create_addrmap_from_aranges)
 987         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 988         instead of '%zu'.
 989
 990 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 991
 992         * dwarf2read.h (dwarf2_section_info_def): Remove.
 993         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 994         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 995         std::vector<dwarf2_section_info>.
 996         (struct dwo_file) <~dwo_file>: Remove.
 997         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 998         types field.
 999         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1000         (dwarf2_read_debug_names): Likewise.
1001         (create_debug_types_hash_table): Change parameter type to
1002         array_view, adjust code accordingly.
1003         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1004         (partial_die_info::fixup): Likewise.
1005         (determine_prefix): Likewise.
1006         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1007
1008 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1009
1010         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1011         gdb_bfd_ref_ptr.
1012         <~dwo_file>: Remove call to gdb_bfd_unref.
1013         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1014         gdb_bfd_ref_ptr::get.
1015
1016 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1017
1018         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1019         type to htab_up.
1020         * dwarf2read.c (struct dwo_file): Initialize fields.
1021         <~dwo_file>: New.
1022         (free_dwo_file): Remove, move content to ~dwo_file.
1023         (struct dwo_file_deleter): Remove.
1024         (dwo_file_up>: Remove custom deleter.
1025         (free_dwo_files): Remove.
1026         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1027         dwo_files.
1028         (process_skeletonless_type_units): Call unique_ptr::get.
1029         (allocate_dwo_file_hash_table): Add deleter to created hash
1030         table.  Change return type to htab_up.
1031         (lookup_dwo_file_slot): Don't memset dwo_file, call
1032         unique_ptr::get.
1033         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1034         (create_dwo_unit_in_dwp_v2): Likewise.
1035         (open_and_init_dwo_file): Likewise.
1036         (free_dwo_file_from_slot): Remove.
1037
1038 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1039
1040         * dwarf2read.h (struct dwarf2_section_info) <readin,
1041         is_virtual>: Change type to bool.
1042         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1043         true instead of 1.
1044
1045 2019-06-19  Tom Tromey  <tom@tromey.com>
1046
1047         * tui/tui-data.h (tui_init_content_element): Don't declare.
1048
1049 2019-06-19  Tom Tromey  <tom@tromey.com>
1050
1051         * tui/tui-data.h (tui_init_win_info): Don't declare.
1052
1053 2019-06-19  Tom de Vries  <tdevries@suse.de>
1054
1055         * dwarf2read.h (abstract_to_concrete): Change type to
1056         std::unordered_map<sect_offset, std::vector<sect_offset>,
1057         gdb::hash_enum<sect_offset>>.
1058
1059 2019-06-19  Tom Tromey  <tromey@adacore.com>
1060
1061         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1062         EVAL_AVOID_SIDE_EFFECTS specially.
1063
1064 2019-06-19  Tom Tromey  <tromey@adacore.com>
1065
1066         * source-cache.c (highlighter): New global.
1067         (source_cache::get_source_lines): Create a highlighter on demand.
1068
1069 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1070
1071         * defs.h (deprecated_interactive_hook): Delete declaration.
1072         * interps.c (clear_interpreter_hooks): Remove use of
1073         deprecated_interactive_hook.
1074         * top.c (deprecated_interactive_hook): Delete definition.
1075         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1076
1077 2019-06-18  Tom de Vries  <tdevries@suse.de>
1078
1079         PR gdb/24515
1080         * dwarf2read.h (abstract_to_concrete): Change type from
1081         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1082         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1083         * dwarf2read.c (read_variable): Update.
1084         (dwarf2_fetch_die_loc_sect_off): Update.
1085
1086 2019-06-17  Tom de Vries  <tdevries@suse.de>
1087
1088         PR gdb/24617
1089         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1090         accessing parent[parent_len - 1].
1091
1092 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1093
1094         PR gdb/24364
1095         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1096         call dtrace_process_dof with NULL dof.
1097
1098 2019-06-16  Tom de Vries  <tdevries@suse.de>
1099
1100         PR gdb/24445
1101         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1102
1103 2019-06-16  Tom Tromey  <tom@tromey.com>
1104
1105         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1106         (make_all_visible): Use address of member.
1107
1108 2019-06-16  Tom Tromey  <tom@tromey.com>
1109
1110         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1111         (tui_free_window, free_content, free_content_elements): Remove
1112         unnecessary cast.
1113         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1114         cast.
1115         * tui/tui-regs.c (tui_show_register_group)
1116         (tui_display_registers_from, tui_display_reg_element_at_line):
1117         Remove unnecessary cast.
1118
1119 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1120
1121         * linux-nat.c (normal_mask): Delete.
1122         (_initialize_linux_nat): Don't initialise normal_mask.
1123
1124 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1125
1126         PR gdb/24445
1127         * dwarf-index-write.h (write_psymtabs_to_index): Add
1128         dwz_basename parameter.
1129         * dwarf-index-write.c (write_gdbindex): Move file writing to
1130         write_gdbindex_1.  Change return type void.
1131         (assert_file_size): Move up, remove filename parameter.
1132         (write_gdbindex_1): New function.
1133         (write_debug_names): Change return type to void, call
1134         assert_file_size.
1135         (struct index_wip_file): New struct.
1136         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1137         file logic to index_wip_file.  Write index for dwz file if
1138         needed.
1139         (save_gdb_index_command): Pass basename of dwz file, if present.
1140         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1141         build-id of dwz file, if present.
1142         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1143         (dwarf2_get_dwz_file): Likewise.
1144         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1145         (dwarf2_get_dwz_file): Likewise.
1146
1147 2019-06-16  Tom Tromey  <tom@tromey.com>
1148
1149         * coffread.c (process_coff_symbol): Use xstrdup.
1150         * value.c (create_internalvar): Use xstrdup.
1151
1152 2019-06-16  Tom Tromey  <tom@tromey.com>
1153
1154         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1155         * breakpoint.c (stopin_command, stopat_command)
1156         (until_break_command, decode_location_default): Remove unnecessary
1157         cast.
1158         * utils.c (subset_compare): Remove unnecessary cast.
1159         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1160         cast.
1161         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1162         cast.
1163         * infcmd.c (path_command): Remove unnecessary cast.
1164         * coffread.c (decode_type): Remove unnecessary cast.
1165         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1166         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1167         * tui/tui-stack.c (tui_show_locator_content)
1168         (tui_show_frame_info): Remove unnecessary cast.
1169         * tui/tui-win.c (tui_scroll_forward_command)
1170         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1171         (parse_scrolling_args): Remove unnecessary cast.
1172         * tui/tui-data.c (init_win_info, tui_del_window)
1173         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1174         (free_content_elements): Remove unnecessary cast.
1175         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1176         unnecessary cast.
1177         * tui/tui-source.c (tui_set_source_content)
1178         (tui_vertical_source_scroll): Remove unnecessary cast.
1179         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1180         cast.
1181         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1182         * tui/tui-regs.c (tui_display_registers_from)
1183         (tui_display_register): Remove unnecessary cast.
1184         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1185         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1186         (make_visible): Remove unnecessary cast.
1187         * tui/tui-winsource.c (tui_erase_source_content)
1188         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1189         unnecessary cast.
1190         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1191         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1192         * stabsread.c (read_type, read_array_type, read_range_type):
1193         Remove unnecessary cast.
1194         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1195         (parse_symbol, parse_type, upgrade_type, parse_external)
1196         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1197         unnecessary cast.
1198         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1199
1200 2019-06-16  Tom Tromey  <tom@tromey.com>
1201
1202         * tui/tui-data.c (tui_alloc_generic_win_info)
1203         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1204         checks.
1205
1206 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1207             Andrew Burgess  <andrew.burgess@embecosm.com>
1208
1209         * f-typeprint.c (f_print_type): Don't return early for not
1210         associated or not allocated types.
1211         (f_type_print_varspec_suffix): Add print_rank parameter and print
1212         ranks of array types in case they dangling.
1213         (f_type_print_base): Add print_rank parameter.
1214
1215 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1216
1217         * NEWS: Mention new MI commands.
1218         * break-catch-throw.c (enum exception_event_kind): Move to
1219         breakpoint.h.
1220         (print_mention_exception_catchpoint): Output text as a single
1221         message.
1222         (catch_exception_command_1): Rename to...
1223         (catch_exception_event): ...this, make non-static, update header
1224         command, and change some parameter types.
1225         (catch_catch_command): Update for changes to
1226         catch_exception_command_1.
1227         (catch_throw_command): Likewise.
1228         (catch_rethrow_command): Likewise.
1229         * breakpoint.c (enum exception_event_kind): Delete.
1230         * breakpoint.h (enum exception_event_kind): Moved here from
1231         break-catch-throw.c.
1232         (catch_exception_event): Declare.
1233         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1234         (mi_cmd_catch_throw): New function.
1235         (mi_cmd_catch_rethrow): New function.
1236         (mi_cmd_catch_catch): New function.
1237         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1238         'catch-catch' entries.
1239         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1240         (mi_cmd_catch_rethrow): Declare.
1241         (mi_cmd_catch_catch): Declare.
1242
1243 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1244
1245         * annotate.c (annotate_source_line): Change return type to void,
1246         update implementation to match.
1247         * annotate.h (annotate_source_line): Change return type to void,
1248         update header comment.
1249         * stack.c (print_frame_info): Don't change what frame information
1250         is printed based on whether annotations are on or not.
1251
1252 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1253
1254         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1255         (annotate_source): Make static.
1256         (annotate_source_line): Moved from source.c and renamed from
1257         identify_source_line.  Update the return type.
1258         * annotate.h (annotate_source): Delete declaration.
1259         (annotate_source_line): Declaration moved from source.h, and
1260         renamed from identify_source_line.  Return type updated.
1261         * source.c (identify_source_line): Moved to annotate.c and renamed
1262         to annotate_source_line.
1263         (info_line_command): Remove check of annotation_level.
1264         * source.h (identify_source_line): Move declaration to annotate.h
1265         and rename to annotate_source_line.
1266         * stack.c: Add 'annotate.h' include.
1267         (print_frame_info): Remove check of annotation_level before
1268         calling annotate_source_line.
1269
1270 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1271
1272         * source-cache.c (source_cache::get_plain_source_lines): Use
1273         open_source_file_with_line_charpos instead of just
1274         open_source_file, remove call to find_source_lines.
1275         (source_cache::get_source_lines): Likewise.
1276         * source.c (find_source_lines): Make static.
1277         (get_filename_and_charpos): Renamed into...
1278         (open_source_file_with_line_charpos): ..this along with changes to
1279         return a scoped_fd, and some other minor clean ups.
1280         (identify_source_line): Use open_source_file_with_line_charpos.
1281         (search_command_helper): Use open_source_file_with_line_charpos
1282         instead of just open_source_file, remove call to
1283         find_source_lines.
1284         * source.h (open_source_file_with_line_charpos): Declare new
1285         function.
1286         (find_source_lines): Delete declaration.
1287
1288 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1289
1290         * source.c (get_filename_and_charpos): Remove fullname
1291         parameter.
1292         (identify_source_line): Update call to get_filename_and_charpos.
1293
1294 2019-06-14  Tom Tromey  <tromey@adacore.com>
1295
1296         PR gdb/24502:
1297         * ui-style.h (skip_ansi_escape): Update comment.
1298         * ui-file.h (class no_terminal_escape_file): New class.
1299         * ui-file.c (no_terminal_escape_file::write)
1300         (no_terminal_escape_file::puts): New methods.
1301         * cli/cli-logging.c (handle_redirections): Use
1302         no_terminal_escape_file.
1303
1304 2019-06-14  Tom Tromey  <tromey@adacore.com>
1305
1306         * NEWS: Move convenience variable news above Python news.
1307
1308 2019-06-14  Tom Tromey  <tom@tromey.com>
1309
1310         * gnulib: Move directory to top-level.
1311         * configure.ac: Don't configure gnulib.
1312         * configure: Rebuild.
1313         * common/common-defs.h: Use new path to gnulib.
1314         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1315         (GNULIB_H): Remove.
1316         (INCGNU): Look in new gnulib location.
1317         (HFILES_NO_SRCDIR): Remove gnulib files.
1318         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1319         (generated_files): Remove GNULIB_H.
1320         ($(LIBGNU), all-lib): Remove targets.
1321         (distclean): Don't mention GNULIB_BUILDDIR.
1322         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1323
1324 2019-06-14  Tom Tromey  <tromey@adacore.com>
1325
1326         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1327         Warn if symbol file does not provide any symbols.
1328
1329 2019-06-14  Tom Tromey  <tromey@adacore.com>
1330
1331         * source.c (find_and_open_source): Respect basenames_may_differ.
1332
1333 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1334
1335         * annotate.c (annotate_breakpoints_invalid): Make use of
1336         scoped_restore_terminal_state.
1337         (annotate_frames_invalid): Likewise.
1338
1339 2019-06-14  Tom Tromey  <tromey@adacore.com>
1340
1341         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1342         allow assignment to an internalvar.
1343
1344 2019-06-14  Tom Tromey  <tromey@adacore.com>
1345
1346         * ada-lex.l: Allow "_" in attribute names.
1347
1348 2019-06-14  Tom Tromey  <tromey@adacore.com>
1349
1350         PR gdb/24653:
1351         * regcache.c (registers_changed): Don't call alloca.
1352         * top.c (execute_command): Don't call alloca.
1353
1354 2019-06-13  Pedro Alves  <palves@redhat.com>
1355
1356         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1357         'expression'.  When parsing an expression, error out if there's
1358         junk after "unlimited".
1359         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1360         (do_set_command): Adjust calls to is_unlimited_literal.
1361
1362 2019-06-13  Pedro Alves  <palves@redhat.com>
1363
1364         * compile/compile.c (make_compile_options_def_group): Add braces
1365         around array_view initializer.
1366         * thread.c (make_thread_apply_all_options_def_group)
1367         (make_thread_apply_all_options_def_group): Likewise.
1368
1369 2019-06-13  Pedro Alves  <palves@redhat.com>
1370
1371         * NEWS (New commands): Mention "maint test-options
1372         require-delimiter", "maint test-options unknown-is-error", "maint
1373         test-options unknown-is-operand" and "maint show
1374         test-options-completion-result".
1375         (New command options, command completion): New section.
1376         (Completion improvements): New section.
1377         Mention that you can abbreviate "unlimited".
1378
1379 2019-06-13  Pedro Alves  <palves@redhat.com>
1380
1381         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1382         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1383         * unittests/cli-utils-selftests.c (test_parse_flags)
1384         (test_parse_flags_qcs): Delete.
1385         (test_cli_utils): Don't call deleted functions.
1386
1387 2019-06-13  Pedro Alves  <palves@redhat.com>
1388
1389         * thread.c: Include "cli/cli-option.h".
1390         (tp_array_compar_ascending): Global.
1391         (tp_array_compar): Delete function.
1392         (tp_array_compar_ascending, tp_array_compar_descending): New
1393         functions.
1394         (ascending_option_def, qcs_flag_option_def)
1395         (thr_qcs_flags_option_defs)
1396         (make_thread_apply_all_options_def_group)
1397         (make_thread_apply_options_def_group): New.
1398         (thread_apply_all_command): Use gdb::option::process_options.
1399         (thread_apply_command_completer)
1400         (thread_apply_all_command_completer): New.
1401         (thread_apply_command): Use gdb::option::process_options.
1402         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1403         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1404         to generate help text of "thread apply".  Adjust "taas"'s help.
1405         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1406         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1407
1408 2019-06-13  Pedro Alves  <palves@redhat.com>
1409
1410         * thread.c (thread_apply_command): Check for invalid TID with
1411         isdigit instead of !isalpha.
1412
1413 2019-06-13  Pedro Alves  <palves@redhat.com>
1414
1415         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1416         (validate_flags_qcs): New.
1417         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1418         (validate_flags_qcs): Declare.
1419         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1420         (make_frame_apply_options_def_group): New.
1421         (frame_apply_command_count): Process options with
1422         gdb::option::process_options.
1423         (frame_apply_completer): New.
1424         (frame_apply_level_completer, frame_apply_all_completer)
1425         (frame_apply_completer): New.
1426         (_initialize_stack): Update help of "frame apply", "frame apply
1427         level", "frame apply all" and "faas" to mention supported options
1428         and install command completers.
1429         * stack.h (frame_apply_all_completer): Declare.
1430         * thread.c: Include "stack.h".
1431         (tfaas_command): Add "--".
1432         (_initialize_thread): Update help "tfaas" to mention supported
1433         options and install command completer.
1434
1435 2019-06-13  Pedro Alves  <palves@redhat.com>
1436
1437         * completer.c (complete_nested_command_line): New.
1438         (gdb_completion_word_break_characters_throw): Add assertion.
1439         * completer.h (complete_nested_command_line): Declare.
1440
1441 2019-06-13  Pedro Alves  <palves@redhat.com>
1442
1443         * stack.c (parse_backtrace_qualifiers): New.
1444         (backtrace_command): Use it.
1445         (backtrace_command_completer): Complete on qualifiers.
1446
1447 2019-06-13  Pedro Alves  <palves@redhat.com>
1448
1449         * frame.c: Include "cli/cli-option.h.
1450         (user_set_backtrace_options): New.
1451         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1452         Delete.
1453         (get_prev_frame): Adjust.
1454         (boolean_option_def, uinteger_option_def)
1455         (set_backtrace_option_defs): New.
1456         (_initialize_frame): Adjust and use
1457         gdb::option::add_setshow_cmds_for_options to install "set
1458         backtrace past-main" and "set backtrace past-entry".
1459         * frame.h: Include "cli/cli-option.h".
1460         (struct frame_print_options): Forward declare.
1461         (print_frame_arguments_all, print_frame_arguments_scalars)
1462         (print_frame_arguments_none): Declare.
1463         (print_entry_values): Delete declaration.
1464         (struct frame_print_options, user_frame_print_options): New.
1465         (struct set_backtrace_options): New.
1466         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1467         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1468         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1469         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1470         (list_args_or_locals): Add frame_print_options parameter.
1471         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1472         * python/py-framefilter.c (enumerate_args): Pass down
1473         USER_FRAME_PRINT_OPTIONS.
1474         * stack.c: Include "cli/cli-option.h".
1475         (print_frame_arguments_all, print_frame_arguments_scalars)
1476         (print_frame_arguments_none): Declare.
1477         (print_raw_frame_arguments, print_entry_values): Delete.
1478         (user_frame_print_options): New.
1479         (boolean_option_def, enum_option_def, frame_print_option_defs):
1480         New.
1481         (struct backtrace_cmd_options): New.
1482         (bt_flag_option_def): New.
1483         (backtrace_command_option_defs): New.
1484         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1485         (print_frame_arg, read_frame_arg, print_frame_args)
1486         (print_frame_info, print_frame): Add frame_print_options parameter
1487         and use it.
1488         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1489         (backtrace_command_1): Add frame_print_options and
1490         backtrace_cmd_options parameters and use them.
1491         (make_backtrace_options_def_group): New.
1492         (backtrace_command): Process command options with
1493         gdb::option::process_options.
1494         (backtrace_command_completer): New.
1495         (_initialize_stack): Extend "backtrace"'s help to mention
1496         supported options.  Install completer for "backtrace".
1497         Install some settings commands with add_setshow_cmds_for_options.
1498
1499 2019-06-13  Pedro Alves  <palves@redhat.com>
1500
1501         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1502         and that "set/show print raw frame-arguments" are now deprecated.
1503
1504         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1505         command.
1506         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1507         * stack.c (_initialize_stack): Install "set/show print
1508         raw-frame-arguments", and deprecate "set/show print raw
1509         frame-arguments".
1510         * valprint.c (_initialize_valprint): Deprecate "set/show print
1511         raw".
1512
1513 2019-06-13  Pedro Alves  <palves@redhat.com>
1514
1515         * compile/compile.c (struct compile_options): New.
1516         (compile_flag_option_def, compile_command_option_defs)
1517         (make_compile_options_def_group): New.
1518         (compile_file_command): Handle options with
1519         gdb::option::process_options.
1520         (compile_file_command_completer): New function.
1521         (compile_code_command): Handle options with
1522         gdb::option::process_options.
1523         (compile_code_command_completer): New function.
1524         (_initialize_compiler): Install completers for "compile code" and
1525         "compile file".  Mention available options in "compile code" and
1526         "compile code"'s help.
1527         * completer.c (advance_to_completion_word): New, factored out from
1528         ...
1529         (advance_to_expression_complete_word_point): ... this.
1530         (advance_to_filename_complete_word_point): New.
1531         * completer.h (advance_to_filename_complete_word_point): New
1532         declaration.
1533
1534 2019-06-13  Pedro Alves  <palves@redhat.com>
1535
1536         * compile/compile.c: Include "cli/cli-option.h".
1537         (compile_print_value): Scope data pointer is now a
1538         value_print_options pointer; adjust.
1539         (compile_print_command): Process options.  Scope data pointer is
1540         now a value_print_options pointer; adjust.
1541         (_initialize_compile): Update "compile print"'s help to include
1542         supported options.  Install a completer for "compile print".
1543         * cp-valprint.c (show_vtblprint, show_objectprint)
1544         (show_static_field_print): Delete.
1545         (_initialize_cp_valprint): Don't install "set print
1546         static-members", "set print vtbl", "set print object" here.
1547         * printcmd.c: Include "cli/cli-option.h" and
1548         "common/gdb_optional.h".
1549         (print_command_parse_format): Rework to fill in a
1550         value_print_options instead of a format_data.
1551         (print_value): Change parameter type from format_data pointer to
1552         value_print_options reference.  Adjust.
1553         (print_command_1): Process options.  Adjust to pass down a
1554         value_print_options.
1555         (print_command_completer): New.
1556         (_initialize_printcmd): Install print_command_completer as
1557         handle_brkchars completer for the "print" command.  Update
1558         "print"'s help to include supported options.
1559         * valprint.c: Include "cli/cli-option.h".
1560         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1561         here from cp-valprint.c.
1562         (boolean_option_def, uinteger_option_def)
1563         (value_print_option_defs, make_value_print_options_def_group):
1564         New.  Use gdb::option::add_setshow_cmds_for_options to install
1565         "set print elements", "set print null-stop", "set print repeats",
1566         "set print pretty", "set print union", "set print array", "set
1567         print address", "set print symbol", "set print array-indexes".
1568         * valprint.h: Include <string> and "cli/cli-option.h".
1569         (make_value_print_options_def_group): Declare.
1570         (print_value): Change parameter type from format_data pointer to
1571         value_print_options reference.
1572         (print_command_completer): Declare.
1573
1574 2019-06-13  Pedro Alves  <palves@redhat.com>
1575
1576         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1577         (COMMON_SFILES): Add maint-test-settings.c.
1578         * cli/cli-decode.c (boolean_enums): New global, factored out from
1579         ...
1580         (add_setshow_boolean_cmd): ... here.
1581         * cli/cli-decode.h (boolean_enums): Declare.
1582         * cli/cli-option.c: New file.
1583         * cli/cli-option.h: New file.
1584         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1585         factored out from ...
1586         (parse_cli_boolean_value(const char *)): ... this.
1587         (is_unlimited_literal): Change parameter type to pointer to
1588         pointer.  Adjust and advance ARG pointer.
1589         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1590         (parse_cli_var_enum): New, factored out from ...
1591         (do_set_command): ... this.  Adjust.
1592         * cli/cli-setshow.h (parse_cli_boolean_value)
1593         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1594         (parse_cli_var_enum): Declare.
1595         * cli/cli-utils.c: Include "cli/cli-option.h".
1596         (get_ulongest): New.
1597         * cli/cli-utils.h (get_ulongest): Declare.
1598         (check_for_argument): New overloads.
1599         * maint-test-options.c: New file.
1600
1601 2019-06-13  Pedro Alves  <palves@redhat.com>
1602
1603         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1604         parse a range if "-" is at the end of the string.
1605
1606 2019-06-13  Pedro Alves  <palves@redhat.com>
1607
1608         * cli/cli-setshow.c (parse_auto_binary_operation)
1609         (parse_cli_boolean_value): Don't allow "o".
1610
1611 2019-06-13  Pedro Alves  <palves@redhat.com>
1612
1613         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1614         * NEWS: Mention maint test-settings KIND.
1615         * maint-test-settings.c: New file.
1616
1617 2019-06-13  Pedro Alves  <palves@redhat.com>
1618
1619         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1620         completer.
1621         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1622         "set" completers.
1623
1624 2019-06-13  Pedro Alves  <palves@redhat.com>
1625
1626         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1627         after item.
1628
1629 2019-06-13  Pedro Alves  <palves@redhat.com>
1630
1631         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1632
1633 2019-06-13  Pedro Alves <palves@redhat.com>
1634
1635         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1636         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1637         call.
1638         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1639         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1640         calls.
1641         (check_for_argument): Skip spaces after argument.
1642
1643 2019-06-13  Pedro Alves  <palves@redhat.com>
1644
1645         * thread.c (thread_apply_command): Adjust TID parsing.
1646         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1647         detected before end of string.
1648         (tid_is_in_list): Error out if LIST is invalid.
1649
1650 2019-06-13  Pedro Alves  <palves@redhat.com>
1651
1652         * completer.c (complete_line_internal_1): Rewind completion word
1653         point.
1654         (completion_tracker::advance_custom_word_point_by): Change
1655         parameter type to int.
1656         * completer.h (completion_tracker::advance_custom_word_point_by):
1657         Likewise.
1658
1659 2019-06-13  Pedro Alves  <palves@redhat.com>
1660
1661         * completer.c (advance_to_completion_word): Handle delimiters.
1662
1663 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1664
1665         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1666
1667 2019-06-11  Tom Tromey  <tom@tromey.com>
1668
1669         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1670         (xmalloc_failed): Move to alloc.c.
1671         * alloc.c: New file.
1672         * Makefile.in (COMMON_SFILES): Add alloc.c.
1673
1674 2019-06-11  Tom Tromey  <tom@tromey.com>
1675
1676         * nat/linux-waitpid.c: Don't include server.h.
1677         (linux_debug): Remove.
1678         (my_waitpid): Update.
1679
1680 2019-06-11  Tom Tromey  <tromey@adacore.com>
1681
1682         * infcall.c (_initialize_infcall): Remove trailing newline from
1683         help.
1684         * user-regs.c (_initialize_user_regs): Remove trailing newline
1685         from help.
1686         * typeprint.c (_initialize_typeprint): Remove trailing newline
1687         from help.
1688         * reverse.c (_initialize_reverse): Remove trailing newlines from
1689         help.
1690         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1691         from help.
1692         * language.c (add_set_language_command): Remove trailing newline
1693         from help.
1694         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1695         help.
1696         * disasm.c (_initialize_disasm): Remove trailing newline from
1697         help.
1698         * top.c (init_main): Remove trailing newline from help.
1699         * interps.c (_initialize_interpreter): Remove trailing newline
1700         from help.
1701         * btrace.c (_initialize_btrace): Remove trailing newlines from
1702         help.
1703         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1704         from help.
1705         * python/python.c (_initialize_python): Remove trailing newline
1706         from help.
1707         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1708         help.
1709         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1710         from help.  Reformat some text.
1711         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1712         from help.
1713         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1714         newline from help.
1715
1716 2019-06-11  Tom Tromey  <tromey@adacore.com>
1717
1718         * darwin-nat.c (darwin_decode_exception_message)
1719         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1720
1721 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1722
1723         * valops.c (value_slice): Check for not allocated or not
1724         associated values.
1725
1726 2019-06-10  Tom de Vries  <tdevries@suse.de>
1727
1728         PR gdb/24618
1729         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1730         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1731         invalid.
1732
1733 2019-06-10  Tom de Vries  <tdevries@suse.de>
1734
1735         PR gdb/24611
1736         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1737         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1738
1739 2019-06-10  Tom de Vries  <tdevries@suse.de>
1740
1741         PR symtab/24545
1742         * symtab.c (struct demangled_name_entry): Add language field.
1743         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1744         static minimal symbol".  Set and use language field.
1745
1746 2019-06-10  Tom Tromey  <tromey@adacore.com>
1747
1748         * ada-lang.c (_initialize_ada_language): Update help text.
1749
1750 2019-06-10  Tom Tromey  <tromey@adacore.com>
1751
1752         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1753         with a newline.
1754         * guile/guile.c (handle_boot_error): Don't end warning with a
1755         newline.
1756         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1757         warning with a newline.
1758         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1759         newline.
1760         (s12z_frame_cache): Likewise.
1761         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1762         a newline.
1763         * solib-svr4.c (disable_probes_interface): Don't end warning with
1764         a newline.
1765         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1766         newline.
1767         * python/python.c (do_finish_initialization): Don't end warning
1768         with a newline.
1769
1770 2019-06-10  Tom Tromey  <tom@tromey.com>
1771
1772         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1773         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1774         gdbpy_enter.
1775
1776 2019-06-10  Tom Tromey  <tromey@adacore.com>
1777
1778         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1779         data.
1780         (elf_new_init): Don't call stabsread_new_init.
1781         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1782         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1783         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1784
1785 2019-06-10  Tom de Vries  <tdevries@suse.de>
1786
1787         PR symtab/16264
1788         PR symtab/24517
1789         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1790
1791 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1792
1793         * source.c (find_and_open_source): Also rewrite relative file
1794         names.
1795
1796 2019-04-26  Amos Bird  <amosbird@gmail.com>
1797
1798         * annotate.c (annotate_thread_exited): Add "thread-exited"
1799         annotation.
1800
1801 2019-06-06  Tom Tromey  <tromey@adacore.com>
1802
1803         * maint.h (class scoped_command_stats): Use
1804         DISABLE_COPY_AND_ASSIGN.
1805         <print_time>: New method.
1806         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1807         print_time.
1808         (scoped_command_stats::print_time): New method.
1809
1810 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1811
1812         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1813         instructions of lengths 6 or 8 bytes.
1814
1815 2019-06-04  Pedro Alves  <palves@redhat.com>
1816
1817         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1818
1819         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1820         * breakpoint.c (condition_completer): Likewise.
1821         * cli/cli-dump.c (scan_expression): Likewise.
1822         * common/filestuff.c (mkdir_recursive): Likewise.
1823         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1824         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1825         (gdb_abspath): Likewise.
1826         * compile/compile-cplus-types.c
1827         (compile_cplus_instance::decl_name): Likewise.
1828         * completer.c (complete_explicit_location):
1829         (signal_completer, reg_or_group_completer_1): Likewise.
1830         * cp-support.c (cp_remove_params_if_any): Likewise.
1831         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1832         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1833         * infcmd.c (strip_bg_char): Likewise.
1834         * linespec.c (copy_token_string): Likewise.
1835         * mi/mi-main.c (output_cores): Likewise.
1836         * psymtab.c (psymtab_search_name):
1837         * symfile.c (test_set_ext_lang_command): Likewise.
1838         * target.c (target_fileio_read_stralloc): Likewise.
1839         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1840         * value.c (complete_internalvar): Likewise.
1841
1842 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1843
1844         Add objfile property to gdb.Type.
1845         * NEWS: Mention Python API addition.
1846         * python/py-type.c (typy_get_objfile): New method.
1847
1848 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1849
1850         * NEWS: Mention the new set|show style [title|highlight].
1851         Mention changes to "show style", "help" and "apropos".
1852
1853 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1854
1855         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1856         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1857         instead of print_help_for_command.
1858         (print_doc_of_command): New function.
1859         (help_list): Add 'apropos -v word' suggestion.
1860         (print_help_for_command): Style the command name using title style.
1861         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1862         (_initialize_cli_cmds): Describe -v in apropos_command help.
1863
1864 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1865
1866         * cli/cli-style.h (cli_style_option): Add name in constructor,
1867         add m_name class member, add constructor with intensity,
1868         add name class function.
1869         (cli_style_option::add_setshow_commands): Remove name argument.
1870         (highlight_style, title_style): New styles.
1871         * cli/cli-style.c (do_show): New function that shows a style
1872         characteristic styling the style name with itself.
1873         (set_style_name): New function.
1874         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1875         Update all callers according to the changes in cli/cli-style.h.
1876         * utils.h (fputs_highlighted): New function.
1877         * utils.c (fputs_highlighted): Likewise.
1878
1879 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1880
1881         * NEWS: Mention new pipe command and new convenience variables.
1882
1883 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1884
1885         * cli/cli-cmds.c (pipe_command): New function.
1886         (_initialize_cli_cmds): Call add_com for pipe_command.
1887         Define | as an alias for pipe.
1888         (exit_status_set_internal_vars): New function.
1889         (shell_escape): Call exit_status_set_internal_vars.
1890         cli/cli-decode.c (find_command_name_length): Recognize | as
1891         a single character command.
1892
1893 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1894
1895         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1896         top.c (execute_command_to_ui_file): New function, mostly a copy
1897         of execute_command_to_string.
1898         (execute_command_to_string): Implement by calling
1899         execute_command_to_ui_file.
1900
1901 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1902
1903         * top.h (saved_command_line): Remove declaration.
1904         * top.c (previous_saved_command_line, previous_repeat_arguments):
1905         New variables.
1906         (saved_command_line): Make static, define together with other
1907         'repeat variables'.
1908         (dont_repeat): Clear repeat_arguments.
1909         (repeat_previous, get_saved_command_line, save_command_line):
1910         New functions.
1911         (gdb_init): Initialize saved_command_line
1912         and previous_saved_command_line.
1913         * main.c (captured_main_1): Remove saved_command_line initialization.
1914         * event-top.c (handle_line_of_input): Update to use
1915         the new 'repeat' related functions instead of direct access to
1916         saved_command_line.
1917         * command.h (repeat_previous, get_saved_command_line,
1918         save_command_line): New declarations.
1919         (dont_repeat): Add comment.
1920
1921 2019-05-30  Tom Tromey  <tromey@adacore.com>
1922
1923         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1924         Fix comment.
1925         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1926
1927 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1928
1929         PR cli/24587
1930         * completer.c (complete): Initialize variable word.
1931
1932 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1933
1934         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1935         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1936         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1937         'body' is NULL to the outter 'if', protecting the '!is_define'
1938         situation as well.
1939
1940 2019-05-29  Tom Tromey  <tromey@adacore.com>
1941
1942         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1943         (dwarf_unknown): New function.
1944         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1945         (dwarf_type_encoding_name): Use dwarf_unknown.
1946
1947 2019-05-29  Tom Tromey  <tromey@adacore.com>
1948
1949         PR c++/20020:
1950         * cp-valprint.c (cp_print_value_fields): Call
1951         cp_print_static_field inside "try".
1952
1953 2019-05-29  Tom Tromey  <tromey@adacore.com>
1954
1955         * inflow.c (struct terminal_info): Add default operator=.
1956         * configure: Rebuild.
1957         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1958         -Wdeprecated-copy-dtor, -Wredundant-move.
1959
1960 2019-05-29  Tom Tromey  <tromey@adacore.com>
1961
1962         * NEWS: Add entry.
1963         * infcmd.c (print_return_value_1): Handle finish_print
1964         option.
1965         (show_print_finish): New function.
1966         (_initialize_infcmd): Add "set/show print finish" commands.
1967         * valprint.c (user_print_options): Initialize new member.
1968         * valprint.h (struct value_print_options) <finish_print>: New
1969         member.
1970
1971 2019-05-28  Tom Tromey  <tromey@adacore.com>
1972
1973         * ada-lang.c (ada_remove_Xbn_suffix)
1974         (find_old_style_renaming_symbol)
1975         (parse_old_style_renaming): Remove.
1976         (ada_find_renaming_symbol): Don't call
1977         find_old_style_renaming_symbol.
1978         (ada_is_renaming_symbol): Rename from
1979         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1980         bool.  Now static.
1981         (ada_read_var_value): Update and simplify.
1982         * ada-exp.y (write_var_or_type): Remove old code.
1983
1984 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1985
1986         * event-top.c: Remove include comment.
1987         * inflow.c (class scoped_ignore_sigttou): Move from here...
1988         * inflow.h (class scoped_ignore_sigttou): ...to here.
1989         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1990         * top.c:  Remove include comment.
1991
1992 2019-05-27  Tom Tromey  <tom@tromey.com>
1993
1994         * NEWS: Fix typo.
1995
1996 2019-05-22  Tom Tromey  <tromey@adacore.com>
1997
1998         * target.c (target_follow_exec): Constify parameter.
1999         * target-delegates.c: Rebuild.
2000         * remote.c (remote_target::follow_exec): Constify parameter.
2001         * infrun.c (follow_exec): Constify parameter.
2002         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2003         (target_follow_exec): Likewise.
2004
2005 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2006
2007         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2008         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2009
2010 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2011
2012         * NEWS: Add debugredirect and testsuite sections.
2013
2014 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2015
2016         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2017         target descriptions using exclusively floating point register name
2018         aliases.
2019
2020 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2021
2022         PR gdb/18644:
2023         * f-lang.c (build_fortran_types): Handle the case where
2024         gdbarch_floatformat_for_type returns a nullptr.
2025
2026 2019-05-21  Tom de Vries  <tdevries@suse.de>
2027
2028         PR cli/24587
2029         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2030
2031 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2032
2033         PR gdb/18644:
2034         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2035         16-byte floats.
2036         * i386-tdep.c (i386_floatformat_for_type): Use
2037         floatformats_ia64_quad for the 16-byte floating point component
2038         within a fortran 32-byte complex number.
2039
2040 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2041
2042         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2043         delete default constructor.
2044         (find_partial_die): Update to return const struct.
2045         (partial_die_parent_scope): Move variable declaration into scope
2046         of its use and change its type to auto.
2047         (guess_partial_die_structure_name): Likewise.
2048         (partial_die_info::fixup): Likewise.
2049
2050 2019-05-17  Tom Tromey  <tromey@adacore.com>
2051
2052         * source.c (find_and_open_source): Remove cast.
2053
2054 2019-05-17  Tom Tromey  <tromey@adacore.com>
2055
2056         * annotate.c (annotate_source): Make "filename" const.
2057         * annotate.h (annotate_source): Use const.
2058
2059 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2060
2061         * disasm.c (set_disassembler_options): Send errors to stderr.
2062
2063 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2064
2065         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2066         (cli_interp_base::set_logging): Check debug_redirect.
2067         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2068         * cli/cli-logging.c (debug_redirect): Add static variable.
2069         (pop_output_files): Add default param.
2070         (handle_redirections): Print debug setting.
2071         (show_logging_command): Likewise.
2072         (_initialize_cli_logging): Add debugredirect command.
2073         * interps.c (current_interp_set_logging): Add debug_redirect
2074         parameter.
2075         * interps.h (set_logging): Add debug_redirect parameter.
2076         (current_interp_set_logging): Likewise.
2077         * mi/mi-common.h: Likewise.
2078         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2079
2080 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2081             Tom Tromey  <tromey@adacore.com>
2082
2083         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2084         directly.
2085         * cli/cli-interp.h (make_logging_output): Remove declaration.
2086         * cli/cli-logging.c (make_logging_output): Remove function.
2087         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2088         directly.
2089         * ui-file.c (tee_file::tee_file): Remove bools.
2090         (tee_file::~tee_file): Remove deletes.
2091         * ui-file.h (tee_file): Remove bools.
2092
2093 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2094
2095         * mi/mi-cmds.h (mi_cmd_complete): New function.
2096         * mi/mi-main.c (mi_cmd_complete): Likewise.
2097         * mi/mi-cmds.c: Define new MI command -complete.
2098         * NEWS: Mention new -complete command.
2099
2100 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2101
2102         * completer.h (complete): New function.
2103         * completer.c (complete): Likewise.
2104         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2105         function defined in completer.h.
2106
2107 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2108
2109         * MAINTAINERS (Write After Approval): Add myself.
2110
2111 2019-05-17  Tom de Vries  <tdevries@suse.de>
2112
2113         PR gdb/24094
2114         * dwarf2read.c (struct cu_partial_die_info): New struct.
2115         (find_partial_die): Return cu_partial_die_info.
2116         (partial_die_parent_scope, guess_partial_die_structure_name)
2117         (partial_die_info::fixup): Handle new return type of find_partial_die.
2118
2119 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2120
2121         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2122         "std::string", simplifying the algorithm.
2123
2124 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2125
2126         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2127         (stap_static_probe_ops::get_probes): Likewise.
2128
2129 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2130
2131         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2132         '-')" and "else if".
2133         (stap_parse_single_operand): Join checks for
2134         "gdbarch_stap_parse_special_token_p" and
2135         "gdbarch_stap_parse_special_token" in the same "if" statement.
2136         Invert check when verifying for operation on register
2137         displacement.
2138
2139 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2140
2141         * stap-probe.c (stap_get_opcode): Update comment.
2142         (stap_get_expected_argument_type): Likewise.
2143         (handle_stap_probe): Likewise.
2144
2145 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2146
2147         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2148         return type to 'bool'.  Adjust comment.  Use 'bool' when
2149         appropriate.
2150         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2151         * stap-probe.c (stap_parse_argument_1): Likewise.
2152         (stap_is_operator): Likewise.
2153         (stap_is_generic_prefix): Likewise.
2154         (stap_is_register_prefix): Likewise.
2155         (stap_is_register_indirection_prefix): Likewise.
2156         (stap_is_integer_prefix): Likewise.
2157         (stap_generic_check_suffix): Likewise.
2158         (stap_check_integer_suffix): Likewise.
2159         (stap_check_register_suffix): Likewise.
2160         (stap_check_register_indirection_suffix): Likewise.
2161         (stap_parse_register_operand): Likewise.
2162         (stap_parse_single_operand): Likewise.
2163         (stap_parse_argument_1): Likewise.
2164         (stap_probe::get_argument_count): Likewise.
2165         (stap_is_operator): Likewise.
2166
2167 2019-05-16  Tom Tromey  <tromey@adacore.com>
2168
2169         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2170         keyword to foreach.
2171
2172 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2173
2174         * linux-thread-db.c (try_thread_db_load_1): Change return type
2175         to bool.
2176         (try_thread_db_load): Likewise.
2177         (try_thread_db_load_from_pdir_1): Likewise.
2178         (try_thread_db_load_from_pdir): Likewise.
2179         (try_thread_db_load_from_sdir): Likewise.
2180         (try_thread_db_load_from_dir): Likewise.
2181         (thread_db_load_search): Likewise.
2182         (has_libpthread): Likewise.
2183         (thread_db_load): Likewise.
2184
2185 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2186
2187         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2188         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2189         NULL, and complain/return if that's the case.
2190
2191 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2192
2193         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2194         (advance, posn, abstract_read_memory): New functions.
2195         [struct mem_read_abstraction]: New struct.
2196         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2197
2198 2019-05-14  Tom Tromey  <tromey@adacore.com>
2199
2200         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2201         value is not lval_memory.
2202
2203 2019-05-14  Tom Tromey  <tromey@adacore.com>
2204
2205         * solib.c (info_sharedlibrary_command): Style the file name.
2206
2207 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2208
2209         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2210         (aarch64_vnv_type): Likewise.
2211         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2212         * common/tdesc.c: Likewise.
2213         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2214         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2215         * features/aarch64-fpu.xml: Add ieee half view.
2216         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2217         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2218         * gdbtypes.h (struct builtin_type): Likewise.
2219         (struct objfile_type): Likewise.
2220
2221 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2222
2223         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2224         typo.
2225         * location.h (string_to_event_location): Likewise.
2226
2227 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2228
2229         GDB 8.3 released.
2230
2231 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2232
2233         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2234         New variable declaration.
2235         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2236         New variable.
2237         (print_one_breakpoint): Use ui_out::test_flags and new global
2238         variable to compute use_fixed_output.
2239         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2240         Remove.
2241         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2242         (mi_multi_location_breakpoint_output_fixed): Remove.
2243         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2244         new variable.
2245         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2246         fix_multi_location_breakpoint_output flag if version >= 3.
2247         * ui-out.h (enum ui_out_flag)
2248         <fix_multi_location_breakpoint_output>: New enumerator.
2249
2250 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2251
2252         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2253
2254 2019-05-10  Tom Tromey  <tromey@adacore.com>
2255
2256         * ada-lang.c (catch_ada_completer): New function.
2257         (_initialize_ada_language): Use it.
2258
2259 2019-05-10  Tom Tromey  <tromey@adacore.com>
2260
2261         * thread.c (print_thread_info): Make "requested_threads" const.
2262         * gdbthread.h (print_thread_info): Make "requested_threads"
2263         const.
2264         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2265         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2266
2267 2019-05-08  Tom Tromey  <tom@tromey.com>
2268
2269         * gdbtypes.c (objfile_type_data): Change type.
2270         (objfile_type, _initialize_gdbtypes): Update.
2271
2272 2019-05-08  Tom Tromey  <tom@tromey.com>
2273
2274         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2275         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2276         (_initialize_dwarf2_frame): Update.
2277
2278 2019-05-08  Tom Tromey  <tom@tromey.com>
2279
2280         * objc-lang.c (objc_objfile_data): Change type.
2281         (find_methods): Update.
2282         (_initialize_objc_lang): Remove.
2283
2284 2019-05-08  Tom Tromey  <tom@tromey.com>
2285
2286         * stabsread.c (rs6000_builtin_type_data): Change type.
2287         (rs6000_builtin_type, _initialize_stabsread): Update.
2288
2289 2019-05-08  Tom Tromey  <tom@tromey.com>
2290
2291         * mips-tdep.c (mips_pdr_data): Remove.
2292         (_initialize_mips_tdep): Update.
2293
2294 2019-05-08  Tom Tromey  <tom@tromey.com>
2295
2296         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2297         (hppa_init_objfile_priv_data, read_unwind_info)
2298         (find_unwind_entry, _initialize_hppa_tdep): Update.
2299
2300 2019-05-08  Tom Tromey  <tom@tromey.com>
2301
2302         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2303         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2304         on obstack.
2305         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2306
2307 2019-05-08  Tom Tromey  <tom@tromey.com>
2308
2309         * mdebugread.c (basic_type_data): Change type.
2310         (basic_type, _initialize_mdebugread): Update.
2311
2312 2019-05-08  Tom Tromey  <tom@tromey.com>
2313
2314         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2315
2316 2019-05-08  Tom Tromey  <tom@tromey.com>
2317
2318         * nto-tdep.c (nto_inferior_data_reg): Change type.
2319         (nto_inferior_data): Update.
2320         (nto_inferior_data_cleanup, nto_new_inferior_data)
2321         (_initialize_nto_tdep): Remove.
2322         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2323
2324 2019-05-08  Tom Tromey  <tom@tromey.com>
2325
2326         * ada-lang.c (struct ada_inferior_data): Add initializers.
2327         (ada_inferior_data): Change type.
2328         (ada_inferior_data_cleanup): Remove.
2329         (get_ada_inferior_data, ada_inferior_exit)
2330         (struct ada_pspace_data): Add initializers, destructor.
2331         (ada_pspace_data_handle): Change type.
2332         (get_ada_pspace_data): Update.
2333         (ada_pspace_data_cleanup): Remove.
2334
2335 2019-05-08  Tom Tromey  <tom@tromey.com>
2336
2337         * coffread.c (struct coff_symfile_info): Add initializers.
2338         (coff_objfile_data_key): Move lower.  Change type.
2339         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2340         Update.
2341         (coff_free_info): Remove.
2342
2343 2019-05-08  Tom Tromey  <tom@tromey.com>
2344
2345         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2346         (fbsd_pspace_data_handle): Move lower.  Change type.
2347         (get_fbsd_pspace_data): Update.
2348         (fbsd_pspace_data_cleanup): Remove.
2349         (_initialize_fbsd_tdep): Update.
2350
2351 2019-05-08  Tom Tromey  <tom@tromey.com>
2352
2353         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2354         (get_ada_tasks_pspace_data): Update.
2355         (ada_tasks_pspace_data_cleanup): Remove.
2356         (_initialize_tasks): Update.
2357         (ada_tasks_inferior_data_handle): Change type.
2358         (get_ada_tasks_inferior_data): Update.
2359         (ada_tasks_inferior_data_cleanup): Remove.
2360         (struct ada_tasks_pspace_data): Add initializers.
2361
2362 2019-05-08  Tom Tromey  <tom@tromey.com>
2363
2364         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2365         * symfile-debug.c (debug_sym_get_probes): Change type.
2366         * stap-probe.c (handle_stap_probe):
2367         (stap_static_probe_ops::get_probes): Change type.
2368         * probe.h (class static_probe_ops) <get_probes>: Change type.
2369         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2370         (parse_probes_in_pspace): Update.
2371         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2372         Update.
2373         (any_static_probe_ops::get_probes): Change type.
2374         * elfread.c (elfread_data): New typedef.
2375         (probe_key): Change type.
2376         (elf_get_probes): Likewise.  Update.
2377         (probe_key_free): Remove.
2378         (_initialize_elfread): Update.
2379         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2380         Change type.
2381         (dtrace_process_dof_probe, dtrace_process_dof)
2382         (dtrace_static_probe_ops::get_probe): Change type.
2383
2384 2019-05-08  Tom Tromey  <tom@tromey.com>
2385
2386         * xcoffread.c (struct xcoff_symfile_info): Rename from
2387         coff_symfile_info.  Add initializers.
2388         (xcoff_objfile_data_key): Move lower.  Change type.
2389         (XCOFF_DATA): Rewrite.
2390         (xcoff_free_info): Remove.
2391         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2392         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2393         (xcoff_initial_scan): Update.
2394
2395 2019-05-08  Tom Tromey  <tom@tromey.com>
2396
2397         * solib-svr4.c (struct svr4_info): Add initializers and
2398         destructor.
2399         <probes_table>: Now an htab_up.
2400         (solib_svr4_pspace_data): Change type.
2401         (free_probes_table): Simplify.
2402         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2403         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2404         (probes_table_remove_objfile_probes, register_solib_event_probe)
2405         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2406         (_initialize_svr4_solib): Update.
2407
2408 2019-05-08  Tom Tromey  <tom@tromey.com>
2409
2410         * remote.c (remote_pspace_data): Change type.
2411         (remote_pspace_data_cleanup): Remove.
2412         (get_remote_exec_file, set_pspace_remote_exec_file)
2413         (_initialize_remote): Update.
2414
2415 2019-05-08  Tom Tromey  <tom@tromey.com>
2416
2417         * breakpoint.c (breakpoint_objfile_key): Change type.
2418         (get_breakpoint_objfile_data): Update.
2419         (free_breakpoint_objfile_data): Remove.
2420         (_initialize_breakpoint): Update.
2421
2422 2019-05-08  Tom Tromey  <tom@tromey.com>
2423
2424         * linux-tdep.c (struct linux_info): Add initializers.
2425         (linux_inferior_data): Move.  Change type.
2426         (invalidate_linux_cache_inf): Update.
2427         (linux_inferior_data_cleanup): Remove.
2428         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2429
2430 2019-05-08  Tom Tromey  <tom@tromey.com>
2431
2432         * auxv.c (auxv_inferior_data): Move.  Change type.
2433         (auxv_inferior_data_cleanup): Remove.
2434         (invalidate_auxv_cache_inf): Rewrite.
2435         (get_auxv_inferior_data, _initialize_auxv): Update.
2436
2437 2019-05-08  Tom Tromey  <tom@tromey.com>
2438
2439         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2440         (symfile_debug_objfile_data_key): Change type.
2441         (symfile_debug_installed, debug_qf_has_symbols)
2442         (debug_qf_find_last_source_symtab)
2443         (debug_qf_forget_cached_source_info)
2444         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2445         (debug_qf_print_stats, debug_qf_dump)
2446         (debug_qf_expand_symtabs_for_function)
2447         (debug_qf_expand_all_symtabs)
2448         (debug_qf_expand_symtabs_with_fullname)
2449         (debug_qf_map_matching_symbols)
2450         (debug_qf_expand_symtabs_matching)
2451         (debug_qf_find_pc_sect_compunit_symtab)
2452         (debug_qf_map_symbol_filenames)
2453         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2454         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2455         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2456         (debug_sym_read_linetable, debug_sym_relocate): Update.
2457         (symfile_debug_free_objfile): Remove.
2458         (install_symfile_debug_logging, _initialize_symfile_debug):
2459         Update.
2460
2461 2019-05-08  Tom Tromey  <tom@tromey.com>
2462
2463         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2464         allocate_on_obstack.
2465         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2466         (get_dwarf2_per_objfile): Update.
2467         (set_dwarf2_per_objfile): Remove.
2468         (dwarf2_has_info, dwarf2_get_section_info): Update.
2469         (dwarf2_free_objfile): Remove.
2470         (_initialize_dwarf2_read): Update.
2471
2472 2019-05-08  Tom Tromey  <tom@tromey.com>
2473
2474         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2475         initializers.
2476         <unsupported_script_warning_printed,
2477         script_not_found_warning_printed>: Now bool.
2478         (auto_load_pspace_data): Change type.
2479         (~auto_load_pspace_info): Rename from
2480         auto_load_pspace_data_cleanup.
2481         (get_auto_load_pspace_data, init_loaded_scripts_info)
2482         (clear_section_scripts, maybe_print_unsupported_script_warning)
2483         (maybe_print_script_not_found_warning, _initialize_auto_load):
2484         Update.
2485
2486 2019-05-08  Tom Tromey  <tom@tromey.com>
2487
2488         * objfiles.c (objfile_pspace_info): Add destructor and
2489         initializers.
2490         (objfiles_pspace_data): Change type.
2491         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2492         (get_objfile_pspace_data): Update.
2493         (objfiles_bfd_data): Change type.
2494         (get_objfile_bfd_data): Update.
2495         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2496
2497 2019-05-08  Tom Tromey  <tom@tromey.com>
2498
2499         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2500         Change type.
2501         (get_catch_syscall_inferior_data): Update.
2502         (catch_syscall_inferior_data_cleanup): Remove.
2503         (_initialize_break_catch_syscall): Update.
2504
2505 2019-05-08  Tom Tromey  <tom@tromey.com>
2506
2507         * inflow.c (struct terminal_info): Add destructor and
2508         initializers.
2509         (inflow_inferior_data): Change type.
2510         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2511         (get_inflow_inferior_data, inflow_inferior_exit)
2512         (swap_terminal_info, _initialize_inflow): Update.
2513
2514 2019-05-08  Tom Tromey  <tom@tromey.com>
2515
2516         * target-dcache.c (target_dcache_cleanup): Remove.
2517         (target_dcache_aspace_key): Change type.
2518         (target_dcache_init_p, target_dcache_invalidate)
2519         (target_dcache_get, target_dcache_get_or_init)
2520         (_initialize_target_dcache): Update.
2521         * dcache.h (struct dcache_deleter): New.
2522
2523 2019-05-08  Tom Tromey  <tom@tromey.com>
2524
2525         * symtab.c (struct symbol_cache): Add destructor and
2526         initializers.
2527         (symbol_cache_key): Move.  Change type.
2528         (make_symbol_cache, free_symbol_cache): Remove.
2529         (get_symbol_cache): Update.
2530         (symbol_cache_cleanup): Remove.
2531         (ALL_PSPACES, symbol_cache_flush)
2532         (maintenance_print_symbol_cache)
2533         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2534         Update.
2535
2536 2019-05-08  Tom Tromey  <tom@tromey.com>
2537
2538         * symtab.c (struct main_info): Add destructor and initializers.
2539         (main_progspace_key): Move.  Change type.
2540         (get_main_info): Update.
2541         (main_info_cleanup): Remove.
2542         (_initialize_symtab): Update.
2543
2544 2019-05-08  Tom Tromey  <tom@tromey.com>
2545
2546         * registry.h (DECLARE_REGISTRY): Define the _key class.
2547
2548 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2549
2550         * NEWS: Merge two 'New commands' sections.
2551
2552 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2553
2554         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2555         parameter and use Ada language definition instead.
2556         (ada_val_print_ptr): Remove unused language parameter.
2557         (ada_val_print_num): Remove language parameter and use Ada language
2558         definition instead.
2559         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2560         parameter.
2561         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2562         parameter and use Ada language definition instead.
2563         (ada_val_print_1): Update all ada_val_print_xxx calls.
2564         Remove language parameter.
2565         (ada_val_print): Update ada_val_print_1 call.
2566
2567 2019-05-08  Tom Tromey  <tromey@adacore.com>
2568
2569         * remote.c (remote_hw_watchpoint_limit)
2570         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2571         Now static.
2572
2573 2019-05-08  Tom Tromey  <tromey@adacore.com>
2574
2575         * maint.c (_initialize_maint_cmds): Move initialization code to
2576         remote.c.
2577         (watchdog, show_watchdog): Move to remote.c.
2578         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2579         "watchdog" static.
2580         (_initialize_remote): Move initialization code from maint.c.
2581         * defs.h (watchdog): Don't declare.
2582
2583 2019-05-08  Tom Tromey  <tromey@adacore.com>
2584
2585         * tui/tui-interp.c: Include main.h.
2586         * interps.c: Include main.h.
2587         * main.h (interpreter_p): Declare.
2588         * defs.h (interpreter_p): Don't declare.
2589
2590 2019-05-08  Tom Tromey  <tromey@adacore.com>
2591
2592         * dwarf2loc.c: Include dwarf2read.h.
2593         * defs.h (read_unsigned_leb128): Don't declare.
2594         * dwarf2read.h (read_unsigned_leb128): Declare.
2595
2596 2019-05-08  Tom Tromey  <tromey@adacore.com>
2597
2598         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2599         method.
2600
2601 2019-05-08  Tom Tromey  <tromey@adacore.com>
2602
2603         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2604         when no wrap column is set.
2605
2606 2019-05-08  Tom Tromey  <tromey@adacore.com>
2607
2608         * c-lang.c (c_get_string): Handle non-C-style arrays.
2609
2610 2019-05-08  Tom Tromey  <tromey@adacore.com>
2611
2612         * typeprint.c (print_offset_data::update): Print the bit offset,
2613         not the number of bits remaining.
2614
2615 2019-05-08  Tom Tromey  <tromey@adacore.com>
2616
2617         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2618         padding at end of comment.
2619
2620 2019-05-08  Tom Tromey  <tromey@adacore.com>
2621
2622         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2623         Compare main types.
2624
2625 2019-05-06  Tom Tromey  <tom@tromey.com>
2626
2627         * common/scoped_mmap.c: Include common-defs.h.
2628         * common/scoped_mmap.h: Don't include config.h.
2629
2630 2019-05-04  Tom Tromey  <tom@tromey.com>
2631
2632         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2633         (struct aarch64_call_info): Add initializers.
2634         <si>: Now a std::vector.
2635         (pass_on_stack, aarch64_push_dummy_call): Update.
2636
2637 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2638             Tom Tromey  <tom@tromey.com>
2639
2640         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2641         (ppc_threads): Now a std::vector.  Now static.
2642         (hwdebug_find_thread_points_by_tid)
2643         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2644         Update.
2645
2646 2019-05-04  Tom Tromey  <tom@tromey.com>
2647
2648         * arc-tdep.c (arc_tdesc_init): Return bool.
2649
2650 2019-05-04  Tom Tromey  <tom@tromey.com>
2651
2652         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2653         Use gdb_assert_not_reached.
2654
2655 2019-05-04  Tom Tromey  <tom@tromey.com>
2656
2657         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2658         "false".
2659
2660 2019-05-04  Tom Tromey  <tom@tromey.com>
2661
2662         * arc-tdep.c (arc_tdesc_init): Use bool.
2663
2664 2019-05-04  Tom Tromey  <tom@tromey.com>
2665
2666         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2667
2668 2019-05-04  Tom Tromey  <tom@tromey.com>
2669
2670         * cli/cli-cmds.c (valid_command_p): Return bool.
2671
2672 2019-05-04  Tom Tromey  <tom@tromey.com>
2673
2674         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2675         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2676
2677 2019-05-04  Raul Tambre  <raul@tambre.ee>
2678
2679         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2680         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2681         operator for comparison.
2682
2683 2019-05-04  Tom Tromey  <tom@tromey.com>
2684
2685         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2686         (lookup_partial_symbol, print_partial_symbols)
2687         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2688         (psymbol_compare): Update.
2689         (add_psymbol_to_bcache): Clear the entire psymbol.
2690         (maintenance_check_psymtabs): Update.
2691         * psympriv.h (struct partial_symbol): Don't derive from
2692         general_symbol_info.
2693         <obj_section, unrelocated_address, address,
2694         set_unrelocated_address>: Update.
2695         <ginfo>: New member.
2696         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2697         (debug_names::write_psymbols): Update.
2698
2699 2019-05-04  Tom de Vries  <tdevries@suse.de>
2700
2701         * contrib/cc-with-tweaks.sh: Support -n arg.
2702
2703 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2704
2705         * corelow.c (core_target::detach): Ensure frame cache and
2706         register caches are cleared.
2707         inferior.c (exit_inferior_1): Likewise.
2708
2709 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2710             Tom Tromey  <tom@tromey.com>
2711
2712         * dictionary.c (collate_pending_symbols_by_language): Remove
2713         "struct" from foreach.
2714         * symtab.c (lookup_global_symbol_from_objfile)
2715         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2716         foreach.
2717         * ser-tcp.c (net_open): Remove "struct" from foreach.
2718         * objfiles.c (objfile_relocate, objfile_rebase)
2719         (objfile_has_symbols): Remove "struct" from foreach.
2720         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2721         from foreach.
2722         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2723         foreach.
2724         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2725         "struct" from foreach.
2726         * ada-lang.c (create_excep_cond_exprs)
2727         (ada_exception_catchpoint_cond_string): Remove "struct" from
2728         foreach.
2729
2730 2019-05-03  Tom Tromey  <tromey@adacore.com>
2731
2732         * ada-exp.y (convert_char_literal): Check suffix of each
2733         enumerator.
2734
2735 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2736
2737         PR ada/21406:
2738         * ada-exp.y (yywrap): Don't define.
2739         * ada-lex.l (%option): Add noyywrap
2740         (yywrap): Remove.
2741
2742 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2743
2744         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2745         _WIN32_WINNT to the XP level, unless already defined to a higher
2746         level.
2747
2748         * unittests/parse-connection-spec-selftests.c:
2749         * ser-tcp.c:
2750         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2751         override.
2752
2753         * symfile.c (find_separate_debug_file): Remove colon from the
2754         drive spec of DOS/Windows file names of the target, so that the
2755         file name produced from DEBUGDIR and the target's directory will
2756         be valid on DOS/Windows systems.
2757
2758 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2759
2760         * rust-lang.c (val_print_struct): Handle printing structures
2761         containing strings.
2762
2763 2019-05-02  Tom Tromey  <tromey@adacore.com>
2764
2765         * valarith.c (_initialize_valarith): Remove.
2766
2767 2019-05-01  Tom Tromey  <tromey@adacore.com>
2768
2769         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2770         bitfields.
2771
2772 2019-05-01  Tom Tromey  <tromey@adacore.com>
2773
2774         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2775         for big-endian copies.
2776
2777 2019-04-30  Ali Tamur  <tamur@google.com>
2778         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2779         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2780         (read_3_bytes): New function.
2781
2782 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2783
2784         * windows-nat.c (main_thread_id): Delete.
2785         (handle_output_debug_string): Replace main_thread_id by
2786         current_event.dwThreadId.
2787         (fake_create_process): Likewise.
2788         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2789         Do not set main_thread_id.
2790         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2791         current_event.dwThreadId.
2792         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2793
2794 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2795
2796         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2797         Use current_event.dwThreadId instead of main_thread_id.
2798
2799 2019-04-30  Tom Tromey  <tromey@adacore.com>
2800
2801         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2802         (create_excep_cond_exprs): Iterate over program spaces.
2803         (ada_exception_catchpoint_cond_string): Examine all minimal
2804         symbols for exception types.
2805
2806 2019-04-30  Tom Tromey  <tromey@adacore.com>
2807
2808         PR c++/24470:
2809         * dwarf2read.c (process_structure_scope): Handle case where type
2810         has template parameters but no symbol was created.
2811
2812 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2813             Chris January  <chris.january@arm.com>
2814
2815         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2816         qualifier.
2817         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2818
2819 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2820
2821         * f-typeprint.c (f_print_type): Update rules for printing
2822         whitespace.
2823         (f_type_print_varspec_suffix): Likewise.
2824
2825 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2826             Chris January  <chris.january@arm.com>
2827
2828         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2829         function arguments.
2830
2831 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2832
2833         * f-lang.c (build_fortran_types): Change name of void type to
2834         lower case.
2835         * f-typeprint.c (f_type_print_base): Print the name of the void
2836         type, rather than a fixed string.
2837         * f-valprint.c (f_decorations): Use lower case void string.
2838
2839 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2840             Chris January  <chris.january@arm.com>
2841
2842         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2843         types for Fortran.
2844
2845 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2846             Chris January  <chris.january@arm.com>
2847             David Lecomber  <david.lecomber@arm.com>
2848
2849         * f-exp.y (BINOP_INTRINSIC): New token.
2850         (exp): New parser rule handling BINOP_INTRINSIC.
2851         (f77_keywords): Add new builtin procedures.
2852         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2853         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2854         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2855         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2856         (print_unop_subexp_f): New function.
2857         (print_binop_subexp_f): New function.
2858         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2859         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2860         (dump_subexp_body_f): Likewise.
2861         (operator_check_f): Likewise.
2862         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2863         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2864
2865 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2866
2867         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2868         UNOP_KIND.
2869         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2870         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2871         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2872         (operator_length_f): New fuction.
2873         (print_subexp_f): New function.
2874         (op_name_f): New function.
2875         (dump_subexp_body_f): New function.
2876         (operator_check_f): New function.
2877         (exp_descriptor_f): Replace standard expression handling functions
2878         with new functions.
2879         * gdb/fortran-operator.def: New file.
2880         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2881         * gdb/std-operator.def: Remove UNOP_KIND.
2882
2883 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2884
2885         * std-operator.def: Remove unbalanced, stray double quote
2886         character.
2887
2888 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2889             Chris January  <chris.january@arm.com>
2890             Daniel Everett  <daniel.everett@arm.com>
2891             Nick Forrington  <nick.forrington@arm.com>
2892             Richard Bunt  <richard.bunt@arm.com>
2893
2894         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2895         of depth when printing anonymous structs or unions.
2896         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2897         Don't print either the top-level value, or the children if the
2898         max-depth is exceeded.
2899         (ppscm_print_children): When printing the key of a map, allow one
2900         extra level of depth.
2901         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2902         print either the top-level value, or the children if the max-depth
2903         is exceeded.
2904         (print_children): When printing the key of a map, allow one extra
2905         level of depth.
2906         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2907         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2908         (user_print_options): Initialise max_depth field.
2909         (val_print_scalar_or_string_type_p): New function.
2910         (val_print): Check to see if the max depth has been reached.
2911         (val_print_check_max_depth): Define new function.
2912         (show_print_max_depth): New function.
2913         (_initialize_valprint): Add 'print max-depth' option.
2914         * valprint.h (struct value_print_options) <max_depth>: New field.
2915         (val_print_check_max_depth): Declare new function.
2916         * NEWS: Document new feature.
2917
2918 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2919
2920         * ada-lang.c (ada_language_defn): Initialise new field.
2921         * c-lang.c (c_is_string_type_p): New function.
2922         (c_language_defn): Initialise new field.
2923         (cplus_language_defn): Initialise new field.
2924         (asm_language_defn): Initialise new field.
2925         (minimal_language_defn): Initialise new field.
2926         * c-lang.h (c_is_string_type_p): Declare new function.
2927         * d-lang.c (d_language_defn): Initialise new field.
2928         * f-lang.c (f_is_string_type_p): New function.
2929         (f_language_defn): Initialise new field.
2930         * go-lang.c (go_is_string_type_p): New function.
2931         (go_language_defn): Initialise new field.
2932         * language.c (default_is_string_type_p): New function.
2933         (unknown_language_defn): Initialise new field.
2934         (auto_language_defn): Initialise new field.
2935         * language.h (struct language_defn) <la_is_string_type_p>: New
2936         member variable.
2937         (default_is_string_type_p): Declare new function.
2938         * m2-lang.c (m2_language_defn): Initialise new field.
2939         * objc-lang.c (objc_language_defn): Initialise new field.
2940         * opencl-lang.c (opencl_language_defn): Initialise new field.
2941         * p-lang.c (pascal_is_string_type_p): New function.
2942         (pascal_language_defn): Initialise new field.
2943         * rust-lang.c (rust_is_string_type_p): New function.
2944         (rust_language_defn): Initialise new field.
2945
2946 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2947
2948         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2949         New field.
2950         * ada-lang.c (ada_language_defn): Initialise new field.
2951         * c-lang.c (c_language_defn): Likewise.
2952         (cplus_language_defn): Likewise.
2953         (asm_language_defn): Likewise.
2954         (minimal_language_defn): Likewise.
2955         * d-lang.c (d_language_defn): Likewise.
2956         * f-lang.c (f_language_defn): Likewise.
2957         * go-lang.c (go_language_defn): Likewise.
2958         * language.c (unknown_language_defn): Likewise.
2959         (auto_language_defn): Likewise.
2960         * m2-lang.c (m2_language_defn): Likewise.
2961         * objc-lang.c (objc_language_defn): Likewise.
2962         * opencl-lang.c (opencl_language_defn): Likewise.
2963         * p-lang.c (pascal_language_defn): Likewise.
2964         * rust-lang.c (rust_language_defn): Likewise.
2965
2966 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2967
2968         * ada-lang.c (ada_is_character_type): Change return type to bool.
2969         (ada_is_string_type): Likewise.
2970         * ada-lang.h (ada_is_character_type): Update declaration
2971         (ada_is_string_type): Likewise.
2972
2973 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2974
2975         Support style in 'frame|thread apply'
2976
2977         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2978         * record.c (record_start, record_stop): Update callers of
2979         execute_command_to_string with false.
2980         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2981         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2982         methods.
2983         (class string_file): New constructor with term_out parameter.
2984         Override methods term_out and can_emit_style_escape.  New member
2985         term_out.
2986         (class stdio_file): Override can_emit_style_escape.
2987         (class tee_file): Override term_out and can_emit_style_escape.
2988         * utils.h (can_emit_style_escape): Remove.
2989         * utils.c (can_emit_style_escape): Likewise.
2990         Update all callers of can_emit_style_escape (SOMESTREAM) to
2991         SOMESTREAM->can_emit_style_escape.
2992         * source-cache.c (source_cache::get_source_lines): Likewise.
2993         * stack.c (frame_apply_command_count): Call execute_command_to_string
2994         passing the term_out characteristic of the current gdb_stdout.
2995         * thread.c (thr_try_catch_cmd): Likewise.
2996         * top.c (execute_command_to_string): pass term_out parameter
2997         to construct the string_file for the command output.
2998         * ui-file.c (term_cli_styling): New function (most code moved
2999         from utils.c can_emit_style_escape).
3000         (string_file::string_file, string_file::can_emit_style_escape,
3001         stdio_file::can_emit_style_escape, tee_file::term_out,
3002         tee_file::can_emit_style_escape): New functions.
3003
3004 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3005
3006         * NEWS: Mention the new set|show may-call-functions.
3007         * infcall.c (may_call_functions_p): New variable.
3008         (show_may_call_functions_p): New function.
3009         (call_function_by_hand_dummy): Throws an error if not
3010         may-call-functions.
3011         (_initialize_infcall): Call add_setshow_boolean_cmd for
3012         may-call-functions.
3013
3014 2019-04-25  Keith Seitz  <keiths@redhat.com>
3015
3016         PR c++/24367
3017         * cp-support.c (inspect_type): Don't attempt substitutions
3018         of symbol with the same name.
3019
3020 2019-04-25  Tom Tromey  <tromey@adacore.com>
3021
3022         PR gdb/24475:
3023         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3024         static.
3025
3026 2019-04-25  Tom Tromey  <tromey@adacore.com>
3027
3028         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3029         rvalue reference.
3030         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3031         (gdb_xml_parser::parse): Use std::move.
3032         * python/python-internal.h (gdbpy_convert_exception): Take a const
3033         reference.
3034         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3035         std::move.
3036         * python/py-utils.c (gdbpy_convert_exception): Take a const
3037         reference.
3038         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3039         Use std::move.
3040         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3041         Use std::move.
3042         * mi/mi-main.c (mi_print_exception): Take a const reference.
3043         * main.c (handle_command_errors): Take a const reference.
3044         * linespec.c (parse_linespec): Use std::move.
3045         * infcall.c (run_inferior_call): Use std::move.
3046         (call_function_by_hand_dummy): Use std::move.
3047         * exec.c (try_open_exec_file): Use std::move.
3048         * exceptions.h (exception_print, exception_fprintf)
3049         (exception_print_same): Update.
3050         * exceptions.c (print_exception, exception_print)
3051         (exception_fprintf, exception_print_same): Change parameters to
3052         const reference.
3053         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3054         * common/new-op.c: Use std::move.
3055         * common/common-exceptions.h (struct gdb_exception): Add move
3056         constructor.
3057         (struct gdb_exception_error, struct gdb_exception_quit, struct
3058         gdb_quit_bad_alloc): Change constructor to move constructor.
3059         (throw_exception): Change parameter to rvalue reference.
3060         * common/common-exceptions.c (throw_exception): Take rvalue
3061         reference.
3062         * cli/cli-interp.c (safe_execute_command): Use std::move.
3063         * breakpoint.c (insert_bp_location, location_to_sals): Use
3064         std::move.
3065
3066 2019-04-25  Tom Tromey  <tromey@adacore.com>
3067
3068         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3069         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3070         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3071         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3072         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3073         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3074         guile/scm-value.c: Use unpack.
3075         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3076         gdbscm_gdb_exception.
3077         (gdbscm_throw_gdb_exception): Likewise.
3078         (struct gdbscm_gdb_exception): New.
3079         (unpack): New function.
3080         (gdbscm_wrap): Use unpack.
3081
3082 2019-04-25  Tom Tromey  <tromey@adacore.com>
3083
3084         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3085         (gdb_rl_callback_handler): Use std::move.
3086         * common/common-exceptions.h (struct gdb_exception): Add move
3087         assignment operator.
3088         (throw_exception_sjlj): Change "exception" to const reference.
3089         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3090         (throw_exception_sjlj): Change "exception" to const reference.
3091
3092 2019-04-25  Tom Tromey  <tromey@adacore.com>
3093
3094         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3095         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3096         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3097         Update.
3098         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3099         Update.
3100         * mi/mi-interp.c (mi_interp::exec): Update.
3101         * linespec.c (parse_linespec): Update.
3102         * infcall.c (run_inferior_call): Update.
3103         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3104         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3105         (gdbscm_lookup_global_symbol): Update.
3106         * guile/scm-param.c (gdbscm_parameter_value): Update.
3107         * guile/scm-frame.c (gdbscm_frame_read_register)
3108         (gdbscm_frame_read_var): Update.
3109         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3110         * exec.c (try_open_exec_file): Update.
3111         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3112         (gdb_rl_callback_handler): Update.
3113         * common/common-exceptions.h (exception_none): Don't declare.
3114         * common/common-exceptions.c (exception_none): Don't define.
3115         (struct catcher) <exception>: Update.
3116         * cli/cli-interp.c (safe_execute_command): Update.
3117         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3118
3119 2019-04-25  Ali Tamur  <tamur@google.com>
3120
3121         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3122         (read_attribute_value): Likewise.
3123         (dwarf2_read_addr_index): Update comment.
3124         (read_str_index): Add DW_FORM_strx.
3125         (dwarf2_string_attr): Likewise.
3126         (dwarf2_const_value_attr): Likewise.
3127         (dump_die_shallow): Likewise.
3128         (dwarf2_fetch_constant_bytes): Likewise.
3129         (skip_form_bytes): Likewise.
3130         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3131
3132 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3133
3134         PR corefiles/11608
3135         PR corefiles/18187
3136         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3137         OFFSET.  Verify if current mapping contains an ELF header.
3138         (linux_find_memory_regions_full): Adjust call to
3139         dump_mapping_p.
3140
3141 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3142             Kang Li <kanglictf@gmail.com>
3143
3144         PR gdb/21600
3145
3146         * dwarf2-frame.c (read_initial_length): Be consistent about using
3147         unsigned representation of length.
3148         (decode_frame_entry_1): Likewise.  Check for wraparound of
3149         end pointer as well as buffer overflow.
3150
3151 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3152
3153         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3154         "vq".
3155
3156 2019-04-24  Tom Tromey  <tromey@adacore.com>
3157
3158         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3159
3160 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3161
3162         * s12z-tdep.c (s12z_unwind_pc): Delete.
3163         (s12z_unwind_sp): Delete.
3164         (s12z_gdbarch_init): Don't register deleted functions with
3165         gdbarch.
3166
3167 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3168
3169         * rl78-tdep.c (rl78_unwind_sp): Delete.
3170         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3171
3172 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3173
3174         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3175         (xstormy16_unwind_pc): Delete.
3176         (xstormy16_dummy_id): Delete.
3177         (xstormy16_gdbarch_init): Don't register deleted functions with
3178         gdbarch.
3179
3180 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3181
3182         * vax-tdep.c (vax_unwind_pc): Delete.
3183         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3184
3185 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3186
3187         * v850-tdep.c (v850_unwind_sp): Delete.
3188         (v850_unwind_pc): Delete.
3189         (v850_dummy_id): Delete.
3190         (v850_gdbarch_init): Don't register deleted functions with
3191         gdbarch.
3192
3193 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3194
3195         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3196         (tilegx_unwind_pc): Delete.
3197         (tilegx_unwind_dummy_id): Delete.
3198         (tilegx_gdbarch_init): Don't register deleted functions with
3199         gdbarch.
3200
3201 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3202
3203         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3204         (tic6x_dummy_id): Delete.
3205         (tic6x_gdbarch_init): Don't register deleted functions with
3206         gdbarch.
3207
3208 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3209
3210         * sparc-tdep.c (sparc_unwind_pc): Delete.
3211         (sparc32_gdbarch_init): Don't register deleted function with
3212         gdbarch.
3213
3214 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3215
3216         * sh-tdep.c (sh_unwind_sp): Delete.
3217         (sh_unwind_pc): Delete.
3218         (sh_dummy_id): Delete.
3219         (sh_gdbarch_init): Don't register deleted functions with
3220         gdbarch.
3221
3222 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3223
3224         * score-tdep.c (score_unwind_sp): Delete.
3225         (score_unwind_pc): Delete.
3226         (score_dummy_id): Delete.
3227         (score_gdbarch_init): Don't register deleted functions with
3228         gdbarch.
3229
3230 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3231
3232         * rx-tdep.c (rx_unwind_pc): Delete.
3233         (rx_unwind_sp): Delete.
3234         (rx_dummy_id): Delete.
3235         (rx_gdbarch_init): Don't register deleted functions with
3236         gdbarch.  Update comment.
3237
3238 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3239
3240         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3241         (rs6000_dummy_id): Delete.
3242         (rs6000_gdbarch_init): Don't register deleted functions with
3243         gdbarch.
3244
3245 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3246
3247         * or1k-tdep.c (or1k_dummy_id): Delete.
3248         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3249
3250 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3251
3252         * nios2-tdep.c (nios2_dummy_id): Delete.
3253         (nios2_unwind_sp): Delete.
3254         (nios2_gdbarch_init): Don't register deleted functions with
3255         gdbarch.
3256
3257 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3258
3259         * nds32-tdep.c (nds32_dummy_id): Delete.
3260         (nds32_unwind_pc): Delete.
3261         (nds32_unwind_sp): Delete.
3262         (nds32_gdbarch_init): Don't register deleted functions with
3263         gdbarch.
3264
3265 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3266
3267         * msp430-tdep.c (msp430_unwind_pc): Delete.
3268         (msp430_unwind_sp): Delete.
3269         (msp430_dummy_id): Delete.
3270         (msp430_gdbarch_init): Don't register deleted functions with
3271         gdbarch.
3272
3273 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3274
3275         * moxie-tdep.c (moxie_unwind_sp): Delete.
3276         (moxie_unwind_pc): Delete.
3277         (moxie_dummy_id): Delete.
3278         (moxie_gdbarch_init): Don't register deleted functions with
3279         gdbarch.
3280
3281 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3282
3283         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3284         (mn10300_unwind_pc): Delete.
3285         (mn10300_unwind_sp): Delete.
3286         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3287         mn10300_unwind_sp.
3288         (mn10300_frame_unwind_init): Don't register deleted functions with
3289         gdbarch.
3290
3291 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3292
3293         * mep-tdep.c (mep_unwind_pc): Delete.
3294         (mep_unwind_sp): Delete.
3295         (mep_dummy_id): Delete.
3296         (mep_gdbarch_init): Don't register deleted functions with
3297         gdbarch.
3298
3299 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3300
3301         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3302         (m68hc11_unwind_sp): Delete.
3303         (m68hc11_gdbarch_init): Don't register deleted functions with
3304         gdbarch.
3305
3306 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3307
3308         * m32r-tdep.c (m32r_unwind_sp): Delete.
3309         (m32r_unwind_pc): Delete.
3310         (m32r_dummy_id): Delete.
3311         (m32r_gdbarch_init): Don't register deleted functions with
3312         gdbarch.
3313
3314 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3315
3316         * m32c-tdep.c (m32c_unwind_pc): Delete.
3317         (m32c_unwind_sp): Delete.
3318         (m32c_dummy_id): Delete.
3319         (m32c_gdbarch_init): Don't register deleted functions with
3320         gdbarch.
3321
3322 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3323
3324         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3325         (lm32_unwind_pc): Delete.
3326         (lm32_dummy_id): Delete.
3327         (lm32_gdbarch_init): Don't register deleted functions with
3328         gdbarch.
3329
3330 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3331
3332         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3333         (iq2000_unwind_pc): Delete.
3334         (iq2000_dummy_id): Delete.
3335         (iq2000_gdbarch_init): Don't register deleted functions with
3336         gdbarch.
3337
3338 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3339
3340         * nds32-tdep.c (nds32_type_align): Delete.
3341         (nds32_push_dummy_call): Use type_align instead.
3342
3343 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3344
3345         * arm-tdep.c (arm_type_align): Only handle vector override case.
3346         (arm_push_dummy_call): Use type_align.
3347         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3348
3349 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3350
3351         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3352         case.
3353         (pass_on_stack): Use type_align.
3354         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3355         function.
3356
3357 2019-04-23  Tom Tromey  <tromey@adacore.com>
3358
3359         * dwarf2read.c (line_header::file_name_at): Remove unused
3360         overload.
3361
3362 2019-04-23  Tom de Vries  <tdevries@suse.de>
3363
3364         PR gdb/24438
3365         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3366         invocation.
3367
3368
3369 2019-03-27  Ali Tamur  <tamur@google.com>
3370
3371         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3372         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3373         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3374         (dwarf_expr_context::get_addr_index): Likewise
3375         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3376         (symbol_needs_eval_context::get_addr_index): Likewise
3377         (disassemble_dwarf_expression): Add DW_OP_addrx
3378         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3379         (read_cutu_die_from_dwo): Update comment
3380         (skip_one_die): Add DW_FORM_addrx
3381         (read_attribute_value): Likewise
3382         (var_decode_location): Add DW_OP_addrx
3383         (dwarf2_const_value_attr): Add DW_FORM_addrx
3384         (dump_die_shallow): Likewise
3385         (dwarf2_fetch_constant_bytes): Likewise
3386         (decode_locdesc): Add DW_OP_addrx
3387         (skip_form_bytes): Add DW_FORM_addrx
3388
3389 2019-04-22  Ali Tamur  <tamur@google.com>
3390
3391         * MAINTAINERS (Write After Approval): Add self.
3392
3393 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3394
3395         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3396         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3397         (open_symbol_file_object): Likewise.
3398         (svr4_default_sos): Add info parameter.
3399         (svr4_read_so_list): Likewise.
3400         (svr4_current_sos_direct): Adjust functions calls to pass down
3401         info.
3402         (svr4_current_sos_1): Add info parameter.
3403         (svr4_current_sos): Call get_svr4_info, pass info down to
3404         svr4_current_sos_1.
3405         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3406         get_svr4_info.
3407         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3408         get_svr4_info.
3409         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3410         to get_svr4_info.
3411         (probes_table_remove_objfile_probes): Likewise.
3412         (register_solib_event_probe): Add info parameter.
3413         (solist_update_incremental): Pass info parameter down to
3414         svr4_read_so_list.
3415         (disable_probes_interface): Add info parameter.
3416         (svr4_handle_solib_event): Pass current_program_space to
3417         get_svr4_info.  Adjust disable_probes_interface cleanup.
3418         (svr4_create_probe_breakpoints): Add info parameter, pass it
3419         down to register_solib_event_probe.
3420         (svr4_create_solib_event_breakpoints): Add info parameter,
3421         pass it down to svr4_create_probe_breakpoints.
3422         (enable_break): Pass info down to
3423         svr4_create_solib_event_breakpoints.
3424         (svr4_solib_create_inferior_hook): Pass current_program_space to
3425         get_svr4_info.
3426         (svr4_clear_solib): Likewise.
3427
3428 2019-04-22  Pedro Alves  <palves@redhat.com>
3429
3430         * solib-svr4.c (svr4_free_objfile_observer): New.
3431         (probe_and_action::objfile): New field.
3432         (probes_table_htab_remove_objfile_probes)
3433         (probes_table_remove_objfile_probes): New functions.
3434         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3435         in the new probe_and_action.  Don't store the probe in 'lookup'.
3436         (svr4_create_probe_breakpoints): Pass objfile to
3437         register_solib_event_probe.
3438         (_initialize_svr4_solib): Register a free_objfile observer.
3439
3440 2019-04-19  Tom Tromey  <tom@tromey.com>
3441
3442         * common/queue.h: Remove.
3443
3444 2019-04-19  Tom Tromey  <tom@tromey.com>
3445
3446         * event-loop.c: Don't include "common/queue.h".
3447
3448 2019-04-19  Tom Tromey  <tom@tromey.com>
3449
3450         * remote.c (remote_target): Use delete.
3451         * remote-notif.h: Include <list>, not "common/queue.h".
3452         (notif_client_p): Remove typedef.
3453         (remote_notif_state): Add constructor, destructor, initializer.
3454         <notif_queue>: Now a std::list.
3455         (remote_notif_state_xfree): Don't declare.
3456         * remote-notif.c (remote_notif_process, handle_notification)
3457         (remote_notif_state_allocate): Update.
3458         (~remote_notif_state): Rename from remote_notif_state_xfree.
3459
3460 2019-04-19  Tom Tromey  <tom@tromey.com>
3461
3462         * symfile.c (reread_symbols): Update.
3463         * objfiles.c (objfile_register_static_link)
3464         (objfile_lookup_static_link): Update
3465         (~objfile) Don't delete static_links.
3466         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3467
3468 2019-04-19  Tom Tromey  <tom@tromey.com>
3469
3470         * type-stack.h (struct type_stack) <insert>: Constify string.
3471         * type-stack.c (type_stack::insert): Constify string.
3472         * gdbtypes.h (lookup_template_type): Update.
3473         (address_space_name_to_int): Update.
3474         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3475         const.
3476         (lookup_template_type): Make name const.
3477         * c-exp.y: Update rules.
3478         (lex_one_token, classify_name, classify_inner_name)
3479         (c_print_token): Update.
3480         * p-exp.y: Update rules.
3481         (yylex): Update.
3482         * f-exp.y: Update rules.
3483         (yylex): Update.
3484         * d-exp.y: Update rules.
3485         (lex_one_token, classify_name, classify_inner_name): Update.
3486         * parse.c (write_dollar_variable, copy_name): Return std::string.
3487         * parser-defs.h (copy_name): Change return type.
3488         * m2-exp.y: Update rules.
3489         (yylex): Update.
3490         * go-exp.y (lex_one_token): Update.
3491         Update rules.
3492         (classify_unsafe_function, classify_packaged_name)
3493         (classify_name, yylex): Update.
3494
3495 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3496
3497         * configure.ac: add --enable-source-highlight switch.
3498         * configure: Regenerate.
3499         * top.c (print_gdb_version): plumb --enable-source-highlight
3500         status to "show configuration".
3501
3502 2019-04-19  Tom Tromey  <tromey@adacore.com>
3503
3504         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3505         Check ADA_TYPE_P.
3506         (empty_record, ada_template_to_fixed_record_type_1)
3507         (template_to_static_fixed_type)
3508         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3509         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3510         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3511         macros.
3512
3513 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3514
3515         PR symtab/24423:
3516         * source.c (print_source_lines_base): Advance "iter" when a
3517         control character is seen.
3518
3519 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3520
3521         * inferior.h (struct infcall_suspend_state_deleter):
3522         Catch exception in destructor to avoid crash.
3523
3524 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3525
3526         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3527         close to the add_com "shell".
3528
3529 2019-04-18  Tom Tromey  <tromey@adacore.com>
3530
3531         * process-stratum-target.h (class process_stratum_target)
3532         <stratum>: Add "final".
3533
3534 2019-04-17  Tom Tromey  <tromey@adacore.com>
3535
3536         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3537         against nullptr before use.
3538
3539 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3540
3541         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3542
3543 2019-04-17  Jim Wilson  <jimw@sifive.com>
3544             Andrew Burgess  <andrew.burgess@embecosm.com>
3545
3546         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3547         code read might fail, assume 4-byte breakpoint in that case.
3548
3549 2019-04-15  Leszek Swirski  <leszeks@google.com>
3550
3551         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3552         rather than a hand-rolled POD check when checking for forced MEMORY
3553         classification.
3554
3555 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3556
3557         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3558         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3559         function.
3560         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3561         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3562         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3563         declaration.
3564
3565 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3566
3567         * aarch64-linux-nat.c
3568         (aarch64_linux_nat_target::thread_architecture): Add override.
3569         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3570         each VQ.
3571
3572 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3573
3574         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3575
3576 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3577
3578         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3579         target types of size 96-bits, add some additional comments, and
3580         check that the builtin type we found was the correct size.
3581
3582 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3583
3584         * utils.c (prompt_for_continue): Don't restore the styling at the
3585         end, as applied_style has the wrong value.  This fixes styling in
3586         long lists of file names that are interrupted by the "Continue?"
3587         prompt.
3588
3589 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3590
3591         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3592         * c-lang.c (c_language_defn): Likewise.
3593         (cplus_language_defn): Likewise.
3594         (asm_language_defn): Likewise.
3595         (minimal_language_defn): Likewise.
3596         * d-lang.c (d_language_defn): Likewise.
3597         * f-lang.c (f_language_defn): Likewise.
3598         * go-lang.c (go_language_defn): Likewise.
3599         * language.c (unknown_language_defn): Likewise.
3600         (auto_language_defn): Likewise.
3601         * language.h (struct language_defn): Remove la_magic field.
3602         (LANG_MAGIC): Delete.
3603         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3604         * objc-lang.c (objc_language_defn): Likewise.
3605         * opencl-lang.c (opencl_language_defn): Likewise.
3606         * p-lang.c (pascal_language_defn): Likewise.
3607         * rust-lang.c (rust_language_defn): Likewise.
3608
3609 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3610
3611         * riscv-tdep.c (riscv_type_align): New function.
3612         (riscv_type_alignment): Delete.
3613         (riscv_arg_location): Use 'type_align'.
3614         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3615
3616 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3617
3618         * gdbtypes.c (type_align): A struct with no non-static fields also
3619         has alignment of 1.
3620
3621 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3622
3623         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3624         component to 0.
3625         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3626         member.
3627         (riscv_struct_info::analyse): New implementation using new
3628         analyse_inner member function.
3629         (riscv_struct_info::field_offset): New member function.
3630         (riscv_struct_info::m_offsets): New member variable.
3631         (riscv_struct_info::analyse_inner): New private member function,
3632         takes the old implementation of riscv_struct_info::analyse but
3633         extended to track field offsets.
3634         (riscv_call_arg_struct): Update the struct folding special cases
3635         to handle cases where empty C++ structs, which are non-zero
3636         length, are found.
3637         (riscv_arg_location): Initialise the length of each location, a
3638         non-zero length now indicates the location is in use.
3639         (riscv_push_dummy_call): Allow for the first location having a
3640         non-zero offset when setting up arguments.
3641         (riscv_return_value): Likewise, but for return values.
3642
3643 2019-04-11  Tom Tromey  <tromey@adacore.com>
3644
3645         * utils.c (internal_vproblem): Make "msg" const.
3646
3647 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3648
3649         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3650         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3651         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3652         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3653
3654 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3655
3656         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3657         function.
3658         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3659         of amd64_collect_native_gregset.
3660         (amd64_linux_nat_target::store_registers): Likewise.
3661
3662 2019-04-10  Tom Tromey  <tom@tromey.com>
3663
3664         * symtab.c (lookup_global_symbol_from_objfile)
3665         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3666         * objfiles.h (class separate_debug_iterator): New.
3667         (class separate_debug_range): New.
3668         (struct objfile) <separate_debug_objfiles>: New method.
3669         (objfile_separate_debug_iterate): Don't declare.
3670         * objfiles.c (separate_debug_iterator::operator++): Rename from
3671         objfile_separate_debug_iterate.
3672         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3673         iterator.
3674         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3675         iterator.
3676
3677 2019-04-10  Tom Tromey  <tom@tromey.com>
3678
3679         * symfile.c (reread_symbols): Remove old comment.
3680         * objfiles.c (free_all_objfiles): Fix a typo.
3681
3682 2019-04-10  Tom Tromey  <tom@tromey.com>
3683
3684         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3685         * minsyms.c (lookup_minimal_symbol): Use foreach.
3686         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3687         (lookup_minimal_symbol_solib_trampoline): Likewise.
3688         * symfile.c (reread_symbols): Use foreach.
3689
3690 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3691             Tom Tromey  <tromey@adacore.com>
3692
3693         PR rust/24414:
3694         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3695         (rust_lex_int_test): Change "value" to be LONGEST.
3696         (rust_lex_tests): Add test for long integer literal.
3697
3698 2019-04-09  Tom Tromey  <tromey@adacore.com>
3699
3700         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3701         to bool.
3702         (extended_remote_target::attach): Update.
3703         (remote_target::remote_notice_new_inferior): Update.
3704         (remote_target::add_current_inferior_and_thread): Update.
3705         * inferior.c (exit_inferior_1): Use "false".
3706         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3707
3708 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3709
3710         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3711         the "start" command.
3712
3713 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3714
3715         * python/py-inferior.c (infpy_thread_from_thread_handle):
3716         Adjust comments to reflect renaming of thread_from_thread_handle
3717         to thread_from_handle.  Adjust keywords.  Fix type error message.
3718         (inferior_object_methods): Add thread_from_handle.  Retain
3719         thread_from_thread_handle, but mark it as deprecated.
3720
3721 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3722
3723         * gdbthread.h (find_thread_by_handle): Revise declaration.
3724         * thread.c (find_thread_by_handle): Likewise.  Adjust
3725         implementation too.
3726         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3727         support for buffer objects as handles.
3728
3729 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3730
3731         * python/py-infthread.c (thpy_thread_handle): New function.
3732         (thread_object_methods): Register thpy_thread_handle.
3733
3734 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3735
3736         * gdbthread.h (thread_to_thread_handle): Declare.
3737         * thread.c (gdbtypes.h): Include.
3738         (thread_to_thread_handle): New function.
3739
3740         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3741         (target_thread_info_to_thread_handle): Declare.
3742         * target.c (target_thread_info_to_thread_handle): New function.
3743         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3744         * target-delegates.c: Regenerate.
3745
3746         * linux-thread-db.c (class thread_db_target): Add method
3747         thread_info_to_thread_handle.
3748         (thread_db_target::thread_info_to_thread_handle): Define.
3749         * remote.c (class remote_target): Add new method
3750         thread_info_to_thread_handle.
3751         (remote_target::thread_info_to_thread_handle): Define.
3752
3753 2019-04-08  Pedro Alves  <palves@redhat.com>
3754
3755         * common/common-exceptions.c (throw_exception): Don't create
3756         named object to throw; throw directly.
3757         (throw_it): Likewise.  Don't initialize gdb_exception::message
3758         here, with new; pass FMT and AP to the ctor instead.
3759         * common/common-exceptions.h: Include <string>.
3760         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3761         const char *, va_list)): New ctor.  Use std::make_shared.
3762         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3763         errors)): Delete.
3764         (gdb_exception_error::gdb_exception_error(enum errors, const char
3765         *, va_list)): New.
3766         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3767         Add assertion.
3768         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3769         errors)): Delete.
3770         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3771         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3772         Add assertion.
3773
3774 2019-04-08  Tom Tromey  <tom@tromey.com>
3775
3776         * valops.c (value_rtti_indirect_type): Replace throw_exception
3777         with throw.
3778         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3779         with throw.
3780         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3781         throw.
3782         * target.c (target_translate_tls_address): Replace throw_exception
3783         with throw.
3784         * stack.c (frame_apply_command_count): Replace throw_exception
3785         with throw.
3786         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3787         throw.
3788         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3789         with throw.
3790         * rs6000-tdep.c (rs6000_frame_cache)
3791         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3792         * remote.c: Replace throw_exception with throw.
3793         * record-full.c (record_full_message, record_full_wait_1)
3794         (record_full_restore): Replace throw_exception with throw.
3795         * record-btrace.c:
3796         (get_thread_current_frame_id, record_btrace_start_replaying)
3797         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3798         (cmd_record_btrace_start): Replace throw_exception with throw.
3799         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3800         throw.
3801         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3802         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3803         * linespec.c:
3804         (find_linespec_symbols): Replace throw_exception with throw.
3805         * infrun.c (displaced_step_prepare, resume): Replace
3806         throw_exception with throw.
3807         * infcmd.c (post_create_inferior): Replace throw_exception with
3808         throw.
3809         * inf-loop.c (inferior_event_handler): Replace throw_exception
3810         with throw.
3811         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3812         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3813         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3814         (get_prev_frame_always, get_frame_pc_if_available)
3815         (get_frame_address_in_block_if_available, get_frame_language):
3816         Replace throw_exception with throw.
3817         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3818         throw_exception with throw.
3819         * eval.c (fetch_subexp_value, evaluate_var_value)
3820         (evaluate_funcall, evaluate_subexp_standard): Replace
3821         throw_exception with throw.
3822         * dwarf2loc.c (call_site_find_chain)
3823         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3824         Replace throw_exception with throw.
3825         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3826         with throw.
3827         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3828         throw.
3829         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3830         * completer.c (complete_line_internal): Replace throw_exception
3831         with throw.
3832         * compile/compile-object-run.c (compile_object_run): Replace
3833         throw_exception with throw.
3834         * cli/cli-script.c (process_next_line): Replace throw_exception
3835         with throw.
3836         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3837         (btrace_enable, btrace_maint_update_pt_packets): Replace
3838         throw_exception with throw.
3839         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3840         throw_exception with throw.
3841         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3842         throw_exception with throw.
3843         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3844         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3845         * aarch64-tdep.c (aarch64_make_prologue_cache)
3846         (aarch64_make_stub_cache): Replace throw_exception with throw.
3847
3848 2019-04-08  Tom Tromey  <tom@tromey.com>
3849
3850         * common/common-exceptions.c (throw_exception): Rename from
3851         throw_exception_cxx.  Remove old copy.  Make argument const.
3852         (throw_it): Create and throw exception objects directly.
3853         * common/common-exceptions.h (throw_exception): Make argument
3854         const.
3855         (struct gdb_exception_error): Add constructor.
3856         (struct gdb_exception_quit): Add constructor.
3857
3858 2019-04-08  Tom Tromey  <tom@tromey.com>
3859
3860         * common/common-exceptions.h (exception_rethrow): Don't declare.
3861         (TRY_SJLJ): Update comment.
3862         (TRY, CATCH, END_CATCH): Remove.
3863         * common/common-exceptions.c (exception_rethrow): Remove.
3864
3865 2019-04-08  Tom Tromey  <tom@tromey.com>
3866
3867         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3868         Remove.
3869         (gdb_exception_error): Rename from
3870         gdb_exception_RETURN_MASK_ERROR.
3871         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3872         (gdb_quit_bad_alloc): Update.
3873         * aarch64-tdep.c: Update.
3874         * ada-lang.c: Update.
3875         * ada-typeprint.c: Update.
3876         * ada-valprint.c: Update.
3877         * amd64-tdep.c: Update.
3878         * arch-utils.c: Update.
3879         * break-catch-throw.c: Update.
3880         * breakpoint.c: Update.
3881         * btrace.c: Update.
3882         * c-varobj.c: Update.
3883         * cli/cli-cmds.c: Update.
3884         * cli/cli-interp.c: Update.
3885         * cli/cli-script.c: Update.
3886         * common/common-exceptions.c: Update.
3887         * common/new-op.c: Update.
3888         * common/selftest.c: Update.
3889         * compile/compile-c-symbols.c: Update.
3890         * compile/compile-cplus-symbols.c: Update.
3891         * compile/compile-object-load.c: Update.
3892         * compile/compile-object-run.c: Update.
3893         * completer.c: Update.
3894         * corelow.c: Update.
3895         * cp-abi.c: Update.
3896         * cp-support.c: Update.
3897         * cp-valprint.c: Update.
3898         * darwin-nat.c: Update.
3899         * disasm-selftests.c: Update.
3900         * dtrace-probe.c: Update.
3901         * dwarf-index-cache.c: Update.
3902         * dwarf-index-write.c: Update.
3903         * dwarf2-frame-tailcall.c: Update.
3904         * dwarf2-frame.c: Update.
3905         * dwarf2loc.c: Update.
3906         * dwarf2read.c: Update.
3907         * eval.c: Update.
3908         * event-loop.c: Update.
3909         * event-top.c: Update.
3910         * exec.c: Update.
3911         * f-valprint.c: Update.
3912         * fbsd-tdep.c: Update.
3913         * frame-unwind.c: Update.
3914         * frame.c: Update.
3915         * gdbtypes.c: Update.
3916         * gnu-v3-abi.c: Update.
3917         * guile/guile-internal.h: Update.
3918         * guile/scm-block.c: Update.
3919         * guile/scm-breakpoint.c: Update.
3920         * guile/scm-cmd.c: Update.
3921         * guile/scm-disasm.c: Update.
3922         * guile/scm-frame.c: Update.
3923         * guile/scm-lazy-string.c: Update.
3924         * guile/scm-math.c: Update.
3925         * guile/scm-param.c: Update.
3926         * guile/scm-ports.c: Update.
3927         * guile/scm-pretty-print.c: Update.
3928         * guile/scm-symbol.c: Update.
3929         * guile/scm-symtab.c: Update.
3930         * guile/scm-type.c: Update.
3931         * guile/scm-value.c: Update.
3932         * i386-linux-tdep.c: Update.
3933         * i386-tdep.c: Update.
3934         * inf-loop.c: Update.
3935         * infcall.c: Update.
3936         * infcmd.c: Update.
3937         * infrun.c: Update.
3938         * jit.c: Update.
3939         * language.c: Update.
3940         * linespec.c: Update.
3941         * linux-fork.c: Update.
3942         * linux-nat.c: Update.
3943         * linux-tdep.c: Update.
3944         * linux-thread-db.c: Update.
3945         * main.c: Update.
3946         * mi/mi-cmd-break.c: Update.
3947         * mi/mi-cmd-stack.c: Update.
3948         * mi/mi-interp.c: Update.
3949         * mi/mi-main.c: Update.
3950         * objc-lang.c: Update.
3951         * p-valprint.c: Update.
3952         * parse.c: Update.
3953         * ppc-linux-tdep.c: Update.
3954         * printcmd.c: Update.
3955         * python/py-arch.c: Update.
3956         * python/py-breakpoint.c: Update.
3957         * python/py-cmd.c: Update.
3958         * python/py-finishbreakpoint.c: Update.
3959         * python/py-frame.c: Update.
3960         * python/py-framefilter.c: Update.
3961         * python/py-gdb-readline.c: Update.
3962         * python/py-inferior.c: Update.
3963         * python/py-infthread.c: Update.
3964         * python/py-lazy-string.c: Update.
3965         * python/py-linetable.c: Update.
3966         * python/py-objfile.c: Update.
3967         * python/py-param.c: Update.
3968         * python/py-prettyprint.c: Update.
3969         * python/py-progspace.c: Update.
3970         * python/py-record-btrace.c: Update.
3971         * python/py-record.c: Update.
3972         * python/py-symbol.c: Update.
3973         * python/py-type.c: Update.
3974         * python/py-unwind.c: Update.
3975         * python/py-utils.c: Update.
3976         * python/py-value.c: Update.
3977         * python/python.c: Update.
3978         * record-btrace.c: Update.
3979         * record-full.c: Update.
3980         * remote-fileio.c: Update.
3981         * remote.c: Update.
3982         * riscv-tdep.c: Update.
3983         * rs6000-aix-tdep.c: Update.
3984         * rs6000-tdep.c: Update.
3985         * rust-exp.y: Update.
3986         * rust-lang.c: Update.
3987         * s390-tdep.c: Update.
3988         * selftest-arch.c: Update.
3989         * solib-dsbt.c: Update.
3990         * solib-frv.c: Update.
3991         * solib-spu.c: Update.
3992         * solib-svr4.c: Update.
3993         * solib.c: Update.
3994         * sparc64-linux-tdep.c: Update.
3995         * stack.c: Update.
3996         * symfile-mem.c: Update.
3997         * symmisc.c: Update.
3998         * target.c: Update.
3999         * thread.c: Update.
4000         * top.c: Update.
4001         * tracefile-tfile.c: Update.
4002         * tui/tui.c: Update.
4003         * typeprint.c: Update.
4004         * unittests/cli-utils-selftests.c: Update.
4005         * unittests/parse-connection-spec-selftests.c: Update.
4006         * valops.c: Update.
4007         * valprint.c: Update.
4008         * value.c: Update.
4009         * varobj.c: Update.
4010         * windows-nat.c: Update.
4011         * x86-linux-nat.c: Update.
4012         * xml-support.c: Update.
4013
4014 2019-04-08  Tom Tromey  <tom@tromey.com>
4015
4016         * xml-support.c: Use C++ exception handling.
4017         * x86-linux-nat.c: Use C++ exception handling.
4018         * windows-nat.c: Use C++ exception handling.
4019         * varobj.c: Use C++ exception handling.
4020         * value.c: Use C++ exception handling.
4021         * valprint.c: Use C++ exception handling.
4022         * valops.c: Use C++ exception handling.
4023         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4024         handling.
4025         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4026         * typeprint.c: Use C++ exception handling.
4027         * tui/tui.c: Use C++ exception handling.
4028         * tracefile-tfile.c: Use C++ exception handling.
4029         * top.c: Use C++ exception handling.
4030         * thread.c: Use C++ exception handling.
4031         * target.c: Use C++ exception handling.
4032         * symmisc.c: Use C++ exception handling.
4033         * symfile-mem.c: Use C++ exception handling.
4034         * stack.c: Use C++ exception handling.
4035         * sparc64-linux-tdep.c: Use C++ exception handling.
4036         * solib.c: Use C++ exception handling.
4037         * solib-svr4.c: Use C++ exception handling.
4038         * solib-spu.c: Use C++ exception handling.
4039         * solib-frv.c: Use C++ exception handling.
4040         * solib-dsbt.c: Use C++ exception handling.
4041         * selftest-arch.c: Use C++ exception handling.
4042         * s390-tdep.c: Use C++ exception handling.
4043         * rust-lang.c: Use C++ exception handling.
4044         * rust-exp.y: Use C++ exception handling.
4045         * rs6000-tdep.c: Use C++ exception handling.
4046         * rs6000-aix-tdep.c: Use C++ exception handling.
4047         * riscv-tdep.c: Use C++ exception handling.
4048         * remote.c: Use C++ exception handling.
4049         * remote-fileio.c: Use C++ exception handling.
4050         * record-full.c: Use C++ exception handling.
4051         * record-btrace.c: Use C++ exception handling.
4052         * python/python.c: Use C++ exception handling.
4053         * python/py-value.c: Use C++ exception handling.
4054         * python/py-utils.c: Use C++ exception handling.
4055         * python/py-unwind.c: Use C++ exception handling.
4056         * python/py-type.c: Use C++ exception handling.
4057         * python/py-symbol.c: Use C++ exception handling.
4058         * python/py-record.c: Use C++ exception handling.
4059         * python/py-record-btrace.c: Use C++ exception handling.
4060         * python/py-progspace.c: Use C++ exception handling.
4061         * python/py-prettyprint.c: Use C++ exception handling.
4062         * python/py-param.c: Use C++ exception handling.
4063         * python/py-objfile.c: Use C++ exception handling.
4064         * python/py-linetable.c: Use C++ exception handling.
4065         * python/py-lazy-string.c: Use C++ exception handling.
4066         * python/py-infthread.c: Use C++ exception handling.
4067         * python/py-inferior.c: Use C++ exception handling.
4068         * python/py-gdb-readline.c: Use C++ exception handling.
4069         * python/py-framefilter.c: Use C++ exception handling.
4070         * python/py-frame.c: Use C++ exception handling.
4071         * python/py-finishbreakpoint.c: Use C++ exception handling.
4072         * python/py-cmd.c: Use C++ exception handling.
4073         * python/py-breakpoint.c: Use C++ exception handling.
4074         * python/py-arch.c: Use C++ exception handling.
4075         * printcmd.c: Use C++ exception handling.
4076         * ppc-linux-tdep.c: Use C++ exception handling.
4077         * parse.c: Use C++ exception handling.
4078         * p-valprint.c: Use C++ exception handling.
4079         * objc-lang.c: Use C++ exception handling.
4080         * mi/mi-main.c: Use C++ exception handling.
4081         * mi/mi-interp.c: Use C++ exception handling.
4082         * mi/mi-cmd-stack.c: Use C++ exception handling.
4083         * mi/mi-cmd-break.c: Use C++ exception handling.
4084         * main.c: Use C++ exception handling.
4085         * linux-thread-db.c: Use C++ exception handling.
4086         * linux-tdep.c: Use C++ exception handling.
4087         * linux-nat.c: Use C++ exception handling.
4088         * linux-fork.c: Use C++ exception handling.
4089         * linespec.c: Use C++ exception handling.
4090         * language.c: Use C++ exception handling.
4091         * jit.c: Use C++ exception handling.
4092         * infrun.c: Use C++ exception handling.
4093         * infcmd.c: Use C++ exception handling.
4094         * infcall.c: Use C++ exception handling.
4095         * inf-loop.c: Use C++ exception handling.
4096         * i386-tdep.c: Use C++ exception handling.
4097         * i386-linux-tdep.c: Use C++ exception handling.
4098         * guile/scm-value.c: Use C++ exception handling.
4099         * guile/scm-type.c: Use C++ exception handling.
4100         * guile/scm-symtab.c: Use C++ exception handling.
4101         * guile/scm-symbol.c: Use C++ exception handling.
4102         * guile/scm-pretty-print.c: Use C++ exception handling.
4103         * guile/scm-ports.c: Use C++ exception handling.
4104         * guile/scm-param.c: Use C++ exception handling.
4105         * guile/scm-math.c: Use C++ exception handling.
4106         * guile/scm-lazy-string.c: Use C++ exception handling.
4107         * guile/scm-frame.c: Use C++ exception handling.
4108         * guile/scm-disasm.c: Use C++ exception handling.
4109         * guile/scm-cmd.c: Use C++ exception handling.
4110         * guile/scm-breakpoint.c: Use C++ exception handling.
4111         * guile/scm-block.c: Use C++ exception handling.
4112         * guile/guile-internal.h: Use C++ exception handling.
4113         * gnu-v3-abi.c: Use C++ exception handling.
4114         * gdbtypes.c: Use C++ exception handling.
4115         * frame.c: Use C++ exception handling.
4116         * frame-unwind.c: Use C++ exception handling.
4117         * fbsd-tdep.c: Use C++ exception handling.
4118         * f-valprint.c: Use C++ exception handling.
4119         * exec.c: Use C++ exception handling.
4120         * event-top.c: Use C++ exception handling.
4121         * event-loop.c: Use C++ exception handling.
4122         * eval.c: Use C++ exception handling.
4123         * dwarf2read.c: Use C++ exception handling.
4124         * dwarf2loc.c: Use C++ exception handling.
4125         * dwarf2-frame.c: Use C++ exception handling.
4126         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4127         * dwarf-index-write.c: Use C++ exception handling.
4128         * dwarf-index-cache.c: Use C++ exception handling.
4129         * dtrace-probe.c: Use C++ exception handling.
4130         * disasm-selftests.c: Use C++ exception handling.
4131         * darwin-nat.c: Use C++ exception handling.
4132         * cp-valprint.c: Use C++ exception handling.
4133         * cp-support.c: Use C++ exception handling.
4134         * cp-abi.c: Use C++ exception handling.
4135         * corelow.c: Use C++ exception handling.
4136         * completer.c: Use C++ exception handling.
4137         * compile/compile-object-run.c: Use C++ exception handling.
4138         * compile/compile-object-load.c: Use C++ exception handling.
4139         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4140         * compile/compile-c-symbols.c: Use C++ exception handling.
4141         * common/selftest.c: Use C++ exception handling.
4142         * common/new-op.c: Use C++ exception handling.
4143         * cli/cli-script.c: Use C++ exception handling.
4144         * cli/cli-interp.c: Use C++ exception handling.
4145         * cli/cli-cmds.c: Use C++ exception handling.
4146         * c-varobj.c: Use C++ exception handling.
4147         * btrace.c: Use C++ exception handling.
4148         * breakpoint.c: Use C++ exception handling.
4149         * break-catch-throw.c: Use C++ exception handling.
4150         * arch-utils.c: Use C++ exception handling.
4151         * amd64-tdep.c: Use C++ exception handling.
4152         * ada-valprint.c: Use C++ exception handling.
4153         * ada-typeprint.c: Use C++ exception handling.
4154         * ada-lang.c: Use C++ exception handling.
4155         * aarch64-tdep.c: Use C++ exception handling.
4156
4157 2019-04-08  Tom Tromey  <tom@tromey.com>
4158
4159         * xml-support.c (gdb_xml_parser::parse): Update.
4160         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4161         * value.c (show_convenience): Update.
4162         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4163         (test_parse_flags_qcs): Update.
4164         * thread.c (thr_try_catch_cmd): Update.
4165         * target.c (target_translate_tls_address): Update.
4166         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4167         (info_frame_command_core, frame_apply_command_count): Update.
4168         * rust-exp.y (rust_lex_exception_test): Update.
4169         * riscv-tdep.c (riscv_print_one_register_info): Update.
4170         * remote.c (remote_target::enable_btrace): Update.
4171         * record-btrace.c (record_btrace_enable_warn): Update.
4172         * python/py-utils.c (gdbpy_convert_exception): Update.
4173         * printcmd.c (do_one_display, print_variable_and_value): Update.
4174         * mi/mi-main.c (mi_print_exception): Update.
4175         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4176         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4177         * linux-nat.c (linux_nat_target::attach): Update.
4178         * linux-fork.c (class scoped_switch_fork_info): Update.
4179         * infrun.c (displaced_step_prepare): Update.
4180         * infcall.c (call_function_by_hand_dummy): Update.
4181         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4182         * gnu-v3-abi.c (print_one_vtable): Update.
4183         * frame.c (get_prev_frame_always): Update.
4184         * f-valprint.c (info_common_command_for_block): Update.
4185         * exec.c (try_open_exec_file): Update.
4186         * exceptions.c (print_exception, exception_print)
4187         (exception_fprintf, exception_print_same): Update.
4188         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4189         * dwarf-index-cache.c (index_cache::store)
4190         (index_cache::lookup_gdb_index): Update.
4191         * darwin-nat.c (maybe_cache_shell): Update.
4192         * cp-valprint.c (cp_print_value_fields): Update.
4193         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4194         (gcc_cplus_symbol_address): Update.
4195         * compile/compile-c-symbols.c (gcc_convert_symbol)
4196         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4197         * common/selftest.c: Update.
4198         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4199         a std::string.
4200         (exception_try_scope_entry, exception_try_scope_exit): Don't
4201         declare.
4202         (struct exception_try_scope): Remove.
4203         (TRY): Don't use exception_try_scope.
4204         (struct gdb_exception): Add constructor, operator=.
4205         <what>: New method.
4206         (struct gdb_exception_RETURN_MASK_ALL)
4207         (struct gdb_exception_RETURN_MASK_ERROR)
4208         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4209         (struct gdb_quit_bad_alloc): Update.
4210         * common/common-exceptions.c (exception_none): Change
4211         initializer.
4212         (struct catcher) <state, exception>: Initialize inline.
4213         <prev>: Remove member.
4214         (current_catcher): Remove.
4215         (catchers): New global.
4216         (exceptions_state_mc_init): Simplify.
4217         (catcher_pop): Remove.
4218         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4219         (try_scope_depth, exception_try_scope_entry)
4220         (exception_try_scope_exit): Remove.
4221         (throw_exception_sjlj): Update.
4222         (exception_messages, exception_messages_size): Remove.
4223         (throw_it): Simplify.
4224         (gdb_exception_sliced_copy): Remove.
4225         (throw_exception_cxx): Update.
4226         * cli/cli-script.c (script_from_file): Update.
4227         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4228         Update.
4229         * ada-valprint.c (ada_val_print): Update.
4230         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4231         (create_excep_cond_exprs): Update.
4232
4233 2019-04-08  Tom Tromey  <tom@tromey.com>
4234
4235         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4236         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4237         (TRY, CATCH, END_CATCH): Remove some definitions.
4238         * common/common-exceptions.c: Don't use GDB_XCPT.
4239         (catcher_list_size): Remove.
4240         (throw_exception, throw_it): Simplify.
4241
4242 2019-04-05  Tom Tromey  <tom@tromey.com>
4243
4244         Revert the header-sorting patch.
4245         * ft32-tdep.c: Revert.
4246         * frv-tdep.c: Revert.
4247         * frv-linux-tdep.c: Revert.
4248         * frame.c: Revert.
4249         * frame-unwind.c: Revert.
4250         * frame-base.c: Revert.
4251         * fork-child.c: Revert.
4252         * findvar.c: Revert.
4253         * findcmd.c: Revert.
4254         * filesystem.c: Revert.
4255         * filename-seen-cache.h: Revert.
4256         * filename-seen-cache.c: Revert.
4257         * fbsd-tdep.c: Revert.
4258         * fbsd-nat.h: Revert.
4259         * fbsd-nat.c: Revert.
4260         * f-valprint.c: Revert.
4261         * f-typeprint.c: Revert.
4262         * f-lang.c: Revert.
4263         * extension.h: Revert.
4264         * extension.c: Revert.
4265         * extension-priv.h: Revert.
4266         * expprint.c: Revert.
4267         * exec.h: Revert.
4268         * exec.c: Revert.
4269         * exceptions.c: Revert.
4270         * event-top.c: Revert.
4271         * event-loop.c: Revert.
4272         * eval.c: Revert.
4273         * elfread.c: Revert.
4274         * dwarf2read.h: Revert.
4275         * dwarf2read.c: Revert.
4276         * dwarf2loc.c: Revert.
4277         * dwarf2expr.h: Revert.
4278         * dwarf2expr.c: Revert.
4279         * dwarf2-frame.c: Revert.
4280         * dwarf2-frame-tailcall.c: Revert.
4281         * dwarf-index-write.h: Revert.
4282         * dwarf-index-write.c: Revert.
4283         * dwarf-index-common.c: Revert.
4284         * dwarf-index-cache.h: Revert.
4285         * dwarf-index-cache.c: Revert.
4286         * dummy-frame.c: Revert.
4287         * dtrace-probe.c: Revert.
4288         * disasm.h: Revert.
4289         * disasm.c: Revert.
4290         * disasm-selftests.c: Revert.
4291         * dictionary.c: Revert.
4292         * dicos-tdep.c: Revert.
4293         * demangle.c: Revert.
4294         * dcache.h: Revert.
4295         * dcache.c: Revert.
4296         * darwin-nat.h: Revert.
4297         * darwin-nat.c: Revert.
4298         * darwin-nat-info.c: Revert.
4299         * d-valprint.c: Revert.
4300         * d-namespace.c: Revert.
4301         * d-lang.c: Revert.
4302         * ctf.c: Revert.
4303         * csky-tdep.c: Revert.
4304         * csky-linux-tdep.c: Revert.
4305         * cris-tdep.c: Revert.
4306         * cris-linux-tdep.c: Revert.
4307         * cp-valprint.c: Revert.
4308         * cp-support.c: Revert.
4309         * cp-namespace.c: Revert.
4310         * cp-abi.c: Revert.
4311         * corelow.c: Revert.
4312         * corefile.c: Revert.
4313         * continuations.c: Revert.
4314         * completer.h: Revert.
4315         * completer.c: Revert.
4316         * complaints.c: Revert.
4317         * coffread.c: Revert.
4318         * coff-pe-read.c: Revert.
4319         * cli-out.h: Revert.
4320         * cli-out.c: Revert.
4321         * charset.c: Revert.
4322         * c-varobj.c: Revert.
4323         * c-valprint.c: Revert.
4324         * c-typeprint.c: Revert.
4325         * c-lang.c: Revert.
4326         * buildsym.c: Revert.
4327         * buildsym-legacy.c: Revert.
4328         * build-id.h: Revert.
4329         * build-id.c: Revert.
4330         * btrace.c: Revert.
4331         * bsd-uthread.c: Revert.
4332         * breakpoint.h: Revert.
4333         * breakpoint.c: Revert.
4334         * break-catch-throw.c: Revert.
4335         * break-catch-syscall.c: Revert.
4336         * break-catch-sig.c: Revert.
4337         * blockframe.c: Revert.
4338         * block.c: Revert.
4339         * bfin-tdep.c: Revert.
4340         * bfin-linux-tdep.c: Revert.
4341         * bfd-target.c: Revert.
4342         * bcache.c: Revert.
4343         * ax-general.c: Revert.
4344         * ax-gdb.h: Revert.
4345         * ax-gdb.c: Revert.
4346         * avr-tdep.c: Revert.
4347         * auxv.c: Revert.
4348         * auto-load.c: Revert.
4349         * arm-wince-tdep.c: Revert.
4350         * arm-tdep.c: Revert.
4351         * arm-symbian-tdep.c: Revert.
4352         * arm-pikeos-tdep.c: Revert.
4353         * arm-obsd-tdep.c: Revert.
4354         * arm-nbsd-tdep.c: Revert.
4355         * arm-nbsd-nat.c: Revert.
4356         * arm-linux-tdep.c: Revert.
4357         * arm-linux-nat.c: Revert.
4358         * arm-fbsd-tdep.c: Revert.
4359         * arm-fbsd-nat.c: Revert.
4360         * arm-bsd-tdep.c: Revert.
4361         * arch-utils.c: Revert.
4362         * arc-tdep.c: Revert.
4363         * arc-newlib-tdep.c: Revert.
4364         * annotate.h: Revert.
4365         * annotate.c: Revert.
4366         * amd64-windows-tdep.c: Revert.
4367         * amd64-windows-nat.c: Revert.
4368         * amd64-tdep.c: Revert.
4369         * amd64-sol2-tdep.c: Revert.
4370         * amd64-obsd-tdep.c: Revert.
4371         * amd64-obsd-nat.c: Revert.
4372         * amd64-nbsd-tdep.c: Revert.
4373         * amd64-nbsd-nat.c: Revert.
4374         * amd64-nat.c: Revert.
4375         * amd64-linux-tdep.c: Revert.
4376         * amd64-linux-nat.c: Revert.
4377         * amd64-fbsd-tdep.c: Revert.
4378         * amd64-fbsd-nat.c: Revert.
4379         * amd64-dicos-tdep.c: Revert.
4380         * amd64-darwin-tdep.c: Revert.
4381         * amd64-bsd-nat.c: Revert.
4382         * alpha-tdep.c: Revert.
4383         * alpha-obsd-tdep.c: Revert.
4384         * alpha-nbsd-tdep.c: Revert.
4385         * alpha-mdebug-tdep.c: Revert.
4386         * alpha-linux-tdep.c: Revert.
4387         * alpha-linux-nat.c: Revert.
4388         * alpha-bsd-tdep.c: Revert.
4389         * alpha-bsd-nat.c: Revert.
4390         * aix-thread.c: Revert.
4391         * agent.c: Revert.
4392         * addrmap.c: Revert.
4393         * ada-varobj.c: Revert.
4394         * ada-valprint.c: Revert.
4395         * ada-typeprint.c: Revert.
4396         * ada-tasks.c: Revert.
4397         * ada-lang.c: Revert.
4398         * aarch64-tdep.c: Revert.
4399         * aarch64-ravenscar-thread.c: Revert.
4400         * aarch64-newlib-tdep.c: Revert.
4401         * aarch64-linux-tdep.c: Revert.
4402         * aarch64-linux-nat.c: Revert.
4403         * aarch64-fbsd-tdep.c: Revert.
4404         * aarch64-fbsd-nat.c: Revert.
4405         * aarch32-linux-nat.c: Revert.
4406
4407 2019-04-05  Tom Tromey  <tom@tromey.com>
4408
4409         * ft32-tdep.c: Sort headers.
4410         * frv-tdep.c: Sort headers.
4411         * frv-linux-tdep.c: Sort headers.
4412         * frame.c: Sort headers.
4413         * frame-unwind.c: Sort headers.
4414         * frame-base.c: Sort headers.
4415         * fork-child.c: Sort headers.
4416         * findvar.c: Sort headers.
4417         * findcmd.c: Sort headers.
4418         * filesystem.c: Sort headers.
4419         * filename-seen-cache.h: Sort headers.
4420         * filename-seen-cache.c: Sort headers.
4421         * fbsd-tdep.c: Sort headers.
4422         * fbsd-nat.h: Sort headers.
4423         * fbsd-nat.c: Sort headers.
4424         * f-valprint.c: Sort headers.
4425         * f-typeprint.c: Sort headers.
4426         * f-lang.c: Sort headers.
4427         * extension.h: Sort headers.
4428         * extension.c: Sort headers.
4429         * extension-priv.h: Sort headers.
4430         * expprint.c: Sort headers.
4431         * exec.h: Sort headers.
4432         * exec.c: Sort headers.
4433         * exceptions.c: Sort headers.
4434         * event-top.c: Sort headers.
4435         * event-loop.c: Sort headers.
4436         * eval.c: Sort headers.
4437         * elfread.c: Sort headers.
4438         * dwarf2read.h: Sort headers.
4439         * dwarf2read.c: Sort headers.
4440         * dwarf2loc.c: Sort headers.
4441         * dwarf2expr.h: Sort headers.
4442         * dwarf2expr.c: Sort headers.
4443         * dwarf2-frame.c: Sort headers.
4444         * dwarf2-frame-tailcall.c: Sort headers.
4445         * dwarf-index-write.h: Sort headers.
4446         * dwarf-index-write.c: Sort headers.
4447         * dwarf-index-common.c: Sort headers.
4448         * dwarf-index-cache.h: Sort headers.
4449         * dwarf-index-cache.c: Sort headers.
4450         * dummy-frame.c: Sort headers.
4451         * dtrace-probe.c: Sort headers.
4452         * disasm.h: Sort headers.
4453         * disasm.c: Sort headers.
4454         * disasm-selftests.c: Sort headers.
4455         * dictionary.c: Sort headers.
4456         * dicos-tdep.c: Sort headers.
4457         * demangle.c: Sort headers.
4458         * dcache.h: Sort headers.
4459         * dcache.c: Sort headers.
4460         * darwin-nat.h: Sort headers.
4461         * darwin-nat.c: Sort headers.
4462         * darwin-nat-info.c: Sort headers.
4463         * d-valprint.c: Sort headers.
4464         * d-namespace.c: Sort headers.
4465         * d-lang.c: Sort headers.
4466         * ctf.c: Sort headers.
4467         * csky-tdep.c: Sort headers.
4468         * csky-linux-tdep.c: Sort headers.
4469         * cris-tdep.c: Sort headers.
4470         * cris-linux-tdep.c: Sort headers.
4471         * cp-valprint.c: Sort headers.
4472         * cp-support.c: Sort headers.
4473         * cp-namespace.c: Sort headers.
4474         * cp-abi.c: Sort headers.
4475         * corelow.c: Sort headers.
4476         * corefile.c: Sort headers.
4477         * continuations.c: Sort headers.
4478         * completer.h: Sort headers.
4479         * completer.c: Sort headers.
4480         * complaints.c: Sort headers.
4481         * coffread.c: Sort headers.
4482         * coff-pe-read.c: Sort headers.
4483         * cli-out.h: Sort headers.
4484         * cli-out.c: Sort headers.
4485         * charset.c: Sort headers.
4486         * c-varobj.c: Sort headers.
4487         * c-valprint.c: Sort headers.
4488         * c-typeprint.c: Sort headers.
4489         * c-lang.c: Sort headers.
4490         * buildsym.c: Sort headers.
4491         * buildsym-legacy.c: Sort headers.
4492         * build-id.h: Sort headers.
4493         * build-id.c: Sort headers.
4494         * btrace.c: Sort headers.
4495         * bsd-uthread.c: Sort headers.
4496         * breakpoint.h: Sort headers.
4497         * breakpoint.c: Sort headers.
4498         * break-catch-throw.c: Sort headers.
4499         * break-catch-syscall.c: Sort headers.
4500         * break-catch-sig.c: Sort headers.
4501         * blockframe.c: Sort headers.
4502         * block.c: Sort headers.
4503         * bfin-tdep.c: Sort headers.
4504         * bfin-linux-tdep.c: Sort headers.
4505         * bfd-target.c: Sort headers.
4506         * bcache.c: Sort headers.
4507         * ax-general.c: Sort headers.
4508         * ax-gdb.h: Sort headers.
4509         * ax-gdb.c: Sort headers.
4510         * avr-tdep.c: Sort headers.
4511         * auxv.c: Sort headers.
4512         * auto-load.c: Sort headers.
4513         * arm-wince-tdep.c: Sort headers.
4514         * arm-tdep.c: Sort headers.
4515         * arm-symbian-tdep.c: Sort headers.
4516         * arm-pikeos-tdep.c: Sort headers.
4517         * arm-obsd-tdep.c: Sort headers.
4518         * arm-nbsd-tdep.c: Sort headers.
4519         * arm-nbsd-nat.c: Sort headers.
4520         * arm-linux-tdep.c: Sort headers.
4521         * arm-linux-nat.c: Sort headers.
4522         * arm-fbsd-tdep.c: Sort headers.
4523         * arm-fbsd-nat.c: Sort headers.
4524         * arm-bsd-tdep.c: Sort headers.
4525         * arch-utils.c: Sort headers.
4526         * arc-tdep.c: Sort headers.
4527         * arc-newlib-tdep.c: Sort headers.
4528         * annotate.h: Sort headers.
4529         * annotate.c: Sort headers.
4530         * amd64-windows-tdep.c: Sort headers.
4531         * amd64-windows-nat.c: Sort headers.
4532         * amd64-tdep.c: Sort headers.
4533         * amd64-sol2-tdep.c: Sort headers.
4534         * amd64-obsd-tdep.c: Sort headers.
4535         * amd64-obsd-nat.c: Sort headers.
4536         * amd64-nbsd-tdep.c: Sort headers.
4537         * amd64-nbsd-nat.c: Sort headers.
4538         * amd64-nat.c: Sort headers.
4539         * amd64-linux-tdep.c: Sort headers.
4540         * amd64-linux-nat.c: Sort headers.
4541         * amd64-fbsd-tdep.c: Sort headers.
4542         * amd64-fbsd-nat.c: Sort headers.
4543         * amd64-dicos-tdep.c: Sort headers.
4544         * amd64-darwin-tdep.c: Sort headers.
4545         * amd64-bsd-nat.c: Sort headers.
4546         * alpha-tdep.c: Sort headers.
4547         * alpha-obsd-tdep.c: Sort headers.
4548         * alpha-nbsd-tdep.c: Sort headers.
4549         * alpha-mdebug-tdep.c: Sort headers.
4550         * alpha-linux-tdep.c: Sort headers.
4551         * alpha-linux-nat.c: Sort headers.
4552         * alpha-bsd-tdep.c: Sort headers.
4553         * alpha-bsd-nat.c: Sort headers.
4554         * aix-thread.c: Sort headers.
4555         * agent.c: Sort headers.
4556         * addrmap.c: Sort headers.
4557         * ada-varobj.c: Sort headers.
4558         * ada-valprint.c: Sort headers.
4559         * ada-typeprint.c: Sort headers.
4560         * ada-tasks.c: Sort headers.
4561         * ada-lang.c: Sort headers.
4562         * aarch64-tdep.c: Sort headers.
4563         * aarch64-ravenscar-thread.c: Sort headers.
4564         * aarch64-newlib-tdep.c: Sort headers.
4565         * aarch64-linux-tdep.c: Sort headers.
4566         * aarch64-linux-nat.c: Sort headers.
4567         * aarch64-fbsd-tdep.c: Sort headers.
4568         * aarch64-fbsd-nat.c: Sort headers.
4569         * aarch32-linux-nat.c: Sort headers.
4570
4571 2019-04-04  Tom Tromey  <tom@tromey.com>
4572
4573         * varobj.c (varobj_create): Update.
4574         * rust-exp.y (struct rust_parser) <update_innermost_block,
4575         lookup_symbol>: New methods.
4576         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4577         Rename.
4578         (rust_parser::rust_lookup_type)
4579         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4580         * printcmd.c (display_command, do_one_display): Update.
4581         * parser-defs.h (struct parser_state) <parser_state>: Add
4582         "tracker" parameter.
4583         (block_tracker): New member.
4584         (class innermost_block_tracker) <innermost_block_tracker>: Add
4585         "types" parameter.
4586         <reset>: Remove method.
4587         (innermost_block): Don't declare.
4588         (null_post_parser): Update.
4589         * parse.c (innermost_block): Remove global.
4590         (write_dollar_variable): Update.
4591         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4592         Remove "tracker_types" parameter.
4593         (parse_expression): Add "tracker" parameter.
4594         (parse_expression_for_completion): Update.
4595         (null_post_parser): Add "tracker" parameter.
4596         * p-exp.y: Update rules.
4597         * m2-exp.y: Update rules.
4598         * language.h (struct language_defn) <la_post_parser>: Add
4599         "tracker" parameter.
4600         * go-exp.y: Update rules.
4601         * f-exp.y: Update rules.
4602         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4603         parameter.
4604         * d-exp.y: Update rules.
4605         * c-exp.y: Update rules.
4606         * breakpoint.c (set_breakpoint_condition): Create an
4607         innermost_block_tracker.
4608         (watch_command_1): Likewise.
4609         * ada-lang.c (resolve): Add "tracker" parameter.
4610         (resolve_subexp): Likewise.
4611         * ada-exp.y (write_var_from_sym): Update.
4612
4613 2019-04-04  Tom Tromey  <tom@tromey.com>
4614
4615         * type-stack.h: New file.
4616         * type-stack.c: New file.
4617         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4618         type-stack.h.
4619         (insert_into_type_stack, insert_type, push_type, push_type_int)
4620         (insert_type_address_space, pop_type, pop_type_int)
4621         (pop_typelist, pop_type_stack, append_type_stack)
4622         (push_type_stack, get_type_stack, push_typelist)
4623         (follow_type_instance_flags, follow_types): Don't declare.
4624         * parse.c (type_stack): Remove global.
4625         (parse_exp_in_context): Update.
4626         (insert_into_type_stack, insert_type, push_type, push_type_int)
4627         (insert_type_address_space, pop_type, pop_type_int)
4628         (pop_typelist, pop_type_stack, append_type_stack)
4629         (push_type_stack, get_type_stack, push_typelist)
4630         (follow_type_instance_flags, follow_types): Remove (moved to
4631         type-stack.c).
4632         * f-exp.y (type_stack): New global.
4633         Update rules.
4634         (push_kind_type, f_parse): Update.
4635         * d-exp.y (type_stack): New global.
4636         Update rules.
4637         (d_parse): Update.
4638         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4639         Update rules.
4640         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4641         (HFILES_NO_SRCDIR): Add type-stack.h.
4642
4643 2019-04-04  Tom Tromey  <tom@tromey.com>
4644
4645         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4646         (rust_parser::convert_ast_to_expression, rust_parse)
4647         (rust_lex_test_completion, rust_lex_tests): Update.
4648         * parser-defs.h (struct expr_completion_state): New.
4649         (struct parser_state) <parser_state>: Add completion parameter.
4650         <mark_struct_expression, mark_completion_tag>: New methods.
4651         <parse_completion, m_completion_state>: New members.
4652         (prefixify_expression, null_post_parser): Update.
4653         (mark_struct_expression, mark_completion_tag): Don't declare.
4654         * parse.c (parse_completion, expout_last_struct)
4655         (expout_tag_completion_type, expout_completion_name): Remove
4656         globals.
4657         (parser_state::mark_struct_expression)
4658         (parser_state::mark_completion_tag): Now methods.
4659         (prefixify_expression): Add last_struct parameter.
4660         (prefixify_subexp): Likewise.
4661         (parse_exp_1): Update.
4662         (parse_exp_in_context): Add cstate parameter.  Update.
4663         (parse_expression_for_completion): Create an
4664         expr_completion_state.
4665         (null_post_parser): Add "completion" parameter.
4666         * p-exp.y: Update rules.
4667         (yylex): Update.
4668         * language.h (struct language_defn) <la_post_parser>: Add
4669         "completing" parameter.
4670         * go-exp.y: Update rules.
4671         (lex_one_token): Update.
4672         * expression.h (parse_completion): Don't declare.
4673         * d-exp.y: Update rules.
4674         (lex_one_token): Update rules.
4675         * c-exp.y: Update rules.
4676         (lex_one_token): Update.
4677         * ada-lang.c (resolve): Add "parse_completion" parameter.
4678         (resolve_subexp): Likewise.
4679         (ada_resolve_function): Likewise.
4680
4681 2019-04-04  Tom Tromey  <tom@tromey.com>
4682
4683         * parser-defs.h (struct parser_state) <start_arglist,
4684         end_arglist>: New methods.
4685         <arglist_len, m_funcall_chain>: New members.
4686         (arglist_len, start_arglist, end_arglist): Don't declare.
4687         * parse.c (arglist_len, funcall_chain): Remove global.
4688         (start_arglist, end_arglist): Remove functions.
4689         (parse_exp_in_context): Update.
4690         * p-exp.y: Update rules.
4691         * m2-exp.y: Update rules.
4692         * go-exp.y: Update rules.
4693         * f-exp.y: Update rules.
4694         * d-exp.y: Update rules.
4695         * c-exp.y: Update rules.
4696
4697 2019-04-04  Tom Tromey  <tom@tromey.com>
4698
4699         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4700         lex_operator, push_back>: New methods.
4701         Update all rules.
4702         (rust_parser::lex_hex, lex_escape): Rename and update.
4703         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4704         (rust_parser::lex_operator): Rename and update.
4705         (rust_parser::lex_number, rustyylex, rustyyerror)
4706         (rust_lex_test_init, rust_lex_test_sequence)
4707         (rust_lex_test_push_back, rust_lex_tests): Update.
4708         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4709         parameter.
4710         <lexptr, prev_lexptr>: New members.
4711         (lexptr, prev_lexptr): Don't declare.
4712         * parse.c (lexptr, prev_lexptr): Remove globals.
4713         (parse_exp_in_context): Update.
4714         * p-exp.y (yylex, yyerror): Update.
4715         * m2-exp.y (parse_number, yylex, yyerror): Update.
4716         * go-exp.y (lex_one_token, yyerror): Update.
4717         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4718         * d-exp.y (lex_one_token, yyerror): Update.
4719         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4720         (lex_one_token, yyerror): Update.
4721         * ada-lex.l (YY_INPUT): Update.
4722         (rewind_to_char): Update.
4723         * ada-exp.y (yyerror): Update.
4724
4725 2019-04-04  Tom Tromey  <tom@tromey.com>
4726
4727         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4728         * parser-defs.h (struct parser_state) <parser_state>: Add new
4729         parameter.
4730         <comma_terminates>: New member.
4731         (comma_terminates): Don't declare global.
4732         * parse.c (comma_terminates): Remove global.
4733         (parse_exp_in_context): Update.
4734         * p-exp.y (yylex): Update.
4735         * m2-exp.y (yylex): Update.
4736         * go-exp.y (lex_one_token): Update.
4737         * f-exp.y (yylex): Update.
4738         * d-exp.y (lex_one_token): Update.
4739         * c-exp.y (lex_one_token): Update.
4740         * ada-lex.l: Update.
4741
4742 2019-04-04  Tom Tromey  <tom@tromey.com>
4743
4744         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4745         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4746         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4747         * parser-defs.h (paren_depth): Don't declare.
4748         * parse.c (paren_depth): Remove global.
4749         (parse_exp_in_context): Update.
4750         * p-exp.y (paren_depth): New global.
4751         (pascal_parse): Initialize it.
4752         * m2-exp.y (paren_depth): New global.
4753         (m2_parse): Initialize it.
4754         * go-exp.y (paren_depth): New global.
4755         (go_parse): Initialize it.
4756         * f-exp.y (paren_depth): New global.
4757         (f_parse): Initialize it.
4758         * d-exp.y (paren_depth): New global.
4759         (d_parse): Initialize it.
4760         * c-exp.y (paren_depth): New global.
4761         (c_parse): Initialize it.
4762         * ada-lex.l (paren_depth): New global.
4763         (lexer_init): Initialize it.
4764
4765 2019-04-04  Tom Tromey  <tom@tromey.com>
4766
4767         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4768         (rust_parser::convert_ast_to_type)
4769         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4770         * parser-defs.h (struct parser_state) <parser_state>: Add
4771         parameters.  Initialize new members.
4772         <expression_context_block, expression_context_pc>: New members.
4773         * parse.c (expression_context_block, expression_context_pc):
4774         Remove globals.
4775         (parse_exp_in_context): Update.
4776         * p-exp.y: Update all rules.
4777         (yylex): Update.
4778         * m2-exp.y: Update all rules.
4779         (yylex): Update.
4780         * go-exp.y (yylex): Update.
4781         * f-exp.y (yylex): Update.
4782         * d-exp.y: Update all rules.
4783         (yylex): Update.
4784         * c-exp.y: Update all rules.
4785         (lex_one_token, classify_name, yylex, c_parse): Update.
4786         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4787
4788 2019-04-04  Tom Tromey  <tom@tromey.com>
4789
4790         * gdbarch.h, gdbarch.c: Rebuild.
4791         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4792         * stap-probe.h:
4793         (struct stap_parse_info): Replace "parser_state" with
4794         "expr_builder".
4795         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4796         (parser_state): New class.
4797         * parse.c (expr_builder): Rename.
4798         (expr_builder::release): Rename.
4799         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4800         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4801         (write_exp_elt_longcst, write_exp_elt_floatcst)
4802         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4803         (write_exp_string_vector, write_exp_bitstring)
4804         (write_exp_msymbol, mark_struct_expression)
4805         (write_dollar_variable)
4806         (insert_type_address_space, increase_expout_size): Replace
4807         "parser_state" with "expr_builder".
4808         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4809         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4810         "parser_state" with "expr_builder".
4811
4812 2019-04-04  Tom Tromey  <tom@tromey.com>
4813
4814         * rust-exp.y: Replace "parse_language" with method call.
4815         * p-exp.y:
4816         (yylex): Replace "parse_language" with method call.
4817         * m2-exp.y:
4818         (yylex): Replace "parse_language" with method call.
4819         * go-exp.y (classify_name): Replace "parse_language" with method
4820         call.
4821         * f-exp.y (yylex): Replace "parse_language" with method call.
4822         * d-exp.y (lex_one_token): Replace "parse_language" with method
4823         call.
4824         * c-exp.y:
4825         (lex_one_token, classify_name, yylex): Replace "parse_language"
4826         with method call.
4827         * ada-exp.y (find_primitive_type, type_char)
4828         (type_system_address): Replace "parse_language" with method call.
4829
4830 2019-04-04  Tom Tromey  <tom@tromey.com>
4831
4832         * rust-exp.y: Replace "parse_gdbarch" with method call.
4833         * parse.c (write_dollar_variable, insert_type_address_space):
4834         Replace "parse_gdbarch" with method call.
4835         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4836         call.
4837         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4838         call.
4839         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4840         "parse_gdbarch" with method call.
4841         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4842         with method call.
4843         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4844         "parse_gdbarch" with method call.
4845         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4846         "parse_gdbarch" with method call.
4847         * c-exp.y (parse_type, parse_number, classify_name): Replace
4848         "parse_gdbarch" with method call.
4849         * ada-lex.l: Replace "parse_gdbarch" with method call.
4850         * ada-exp.y (parse_type, find_primitive_type, type_char)
4851         (type_system_address): Replace "parse_gdbarch" with method call.
4852
4853 2019-04-04  Tom Tromey  <tom@tromey.com>
4854
4855         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4856         * stap-probe.c (stap_parse_argument): Update.
4857         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4858         initial_size parameter.
4859         * rust-exp.y (rust_lex_tests): Update.
4860         * parse.c (parser_state): Update.
4861         (parse_exp_in_context): Update.
4862         * parser-defs.h (struct parser_state) <parser_state>: Remove
4863         "initial_size" parameter.
4864
4865 2019-04-04  Tom Tromey  <tom@tromey.com>
4866
4867         * parser-defs.h (increase_expout_size): Don't declare.
4868         * parse.c (increase_expout_size): Now static.
4869
4870 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4871
4872         * gnu-nat.c (gnu_nat_target::wait): Fix
4873         target_waitstatus_to_string call.
4874
4875 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4876
4877         * eval.c (evaluate_subexp_standard): Handle internal functions
4878         during Fortran function call handling.
4879
4880 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4881
4882         * NEWS: Mention new internal functions.
4883         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4884         (read_base_type): Use dwarf2_init_complex_target_type.
4885         * value.c (creal_internal_fn): New function.
4886         (cimag_internal_fn): New function.
4887         (_initialize_values): Register new internal functions.
4888
4889 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4890
4891         * infrun.c (stop_all_threads): If debug_infrun, always
4892         trace the wait status after wait_one, using
4893         target_waitstatus_to_string and target_pid_to_str.
4894         (handle_inferior_event): Replace various trace of
4895         wait status kind by a single trace.
4896         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4897         wait status kind image by target_waitstatus_to_string.
4898         * target/waitstatus.c (target_waitstatus_to_string): Fix
4899         obsolete comment.
4900
4901 2019-04-01  Tom Tromey  <tromey@adacore.com>
4902
4903         PR symtab/23331:
4904         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4905
4906 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4907             Pedro Alves  <palves@redhat.com>
4908
4909         * top.c (quit_force): Call 'finalize_values'.
4910         * value.c (finalize_values): New function.
4911         * value.h (finalize_values): Declare.
4912
4913 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4914
4915         * NEWS: Announce $_gdb_major and $_gdb_minor.
4916
4917         * top.c (init_gdb_version_vars): New function.
4918         (gdb_init): Call init_gdb_version_vars.
4919
4920 2019-03-29  Tom Tromey  <tromey@adacore.com>
4921
4922         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4923         help text.  Remove dead code.
4924
4925 2019-03-29  Keith Seitz  <keiths@redhat.com>
4926
4927         From Siddhesh Poyarekar:
4928         * f-lang.h (f77_get_upperbound): Return LONGEST.
4929         (f77_get_lowerbound): Likewise.
4930         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4931         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4932         print them.
4933         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4934         plongest to format print it.
4935         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4936         (f77_get_upperbound): Likewise.
4937         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4938         LOWER_BOUND to LONGEST.
4939         (f77_create_arrayprint_offset_tbl): Likewise.
4940
4941 2019-03-29  Keith Seitz  <keiths@redhat.com>
4942
4943         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4944         %s/pulongest for TYPE_LENGTH instead of %d in format
4945         strings.
4946         * ada-typerint.c (ada_print_type): Likewise.
4947         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4948         * compile/compile-c-support.c (generate_register_struct): Likewise.
4949         * gdbtypes.c (recursive_dump_type): Likewise.
4950         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4951         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4952         instead of %d in format strings.
4953         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4954         to std::min to ULONGEST.
4955         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4956         instead of %d in format strings.
4957         * tracepoint.c (info_scope_command): Likewise.
4958         * typeprint.c (print_offset_data::update)
4959         (print_offset_data::finish): Likewise.
4960         * xtensa-tdep.c (xtensa_store_return_value)
4961         (xtensa_push_dummy_call): Likewise.
4962
4963 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4964
4965         * windows-nat.c (display_selector): Fixed format specifications
4966         for 64-bit Cygwin.
4967
4968 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4969
4970         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4971
4972 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4973
4974         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4975         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4976         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4977         (nios2_linux_init_abi): Install it.
4978
4979 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4980
4981         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4982
4983 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4984
4985         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4986
4987 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4988             Tom Tromey  <tromey@adacore.com>
4989
4990         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4991
4992 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4993
4994         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4995         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4996         method to compute the bounds of range types. Also print "[evaluated]"
4997         if the bounds' values come from a dynamic evaluation.
4998
4999 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5000
5001         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5002         whitespace when pretty printing is on.
5003
5004 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5005
5006         * ppc-linux-nat.c: Add include.
5007
5008 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5009
5010         * NEWS: Mention AArch64 Pointer Authentication.
5011
5012 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5013
5014         * arm-linux-nat.c: Add include.
5015
5016 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5017
5018         * source-cache.c (source_cache::get_source_lines): Re-read
5019         fullname after calling open_source_file.
5020
5021 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5022
5023         * NEWS: Mention TLS support for FreeBSD.
5024
5025 2019-03-25  Tom Tromey  <tromey@adacore.com>
5026
5027         * minsyms.c (BUNCH_SIZE): Update comment.
5028         (~minimal_symbol_reader): Remove old comment.
5029         (compact_minimal_symbols): Update comment.
5030         (minimal_symbol_reader::install): Remove old comment.  Update
5031         other comments.
5032
5033 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5034
5035         * s390-linux-nat.c: Add include.
5036
5037 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5038
5039         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5040         Call linux_get_hwcap.
5041         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5042         Likewise.
5043         (aarch64_linux_get_hwcap): Remove function.
5044         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5045         declaration.
5046         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5047         linux_get_hwcap.
5048         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5049         * linux-tdep.c (linux_get_hwcap): Add function.
5050         (linux_get_hwcap2): Likewise.
5051         * linux-tdep.h (linux_get_hwcap): Add declaration.
5052         (linux_get_hwcap2): Likewise.
5053         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5054         (ppc_linux_get_hwcap2): Likewise.
5055         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5056         linux_get_hwcap.
5057         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5058         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5059         (ppc_linux_nat_target::read_description): Likewise.
5060         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5061         * s390-linux-nat.c: Likewise.
5062         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5063
5064 2019-03-24  Tom Tromey  <tom@tromey.com>
5065
5066         * ada-lang.c (standard_lookup): Simplify initialization.
5067         (ada_lookup_symbol_nonlocal): Simplify return.
5068         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5069         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5070         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5071         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5072         initialization.
5073         * solib.c (solib_global_lookup): Simplify.
5074         * symtab.c (null_block_symbol): Remove.
5075         (symbol_cache_lookup): Simplify returns.
5076         (lookup_language_this): Simplify returns.
5077         (lookup_symbol_aux): Simplify return.
5078         (lookup_local_symbol): Simplify returns.
5079         (lookup_global_symbol_from_objfile): Simplify return.
5080         (lookup_symbol_in_objfile_symtabs)
5081         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5082         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5083         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5084         * cp-namespace.c (cp_lookup_bare_symbol)
5085         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5086         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5087         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5088         (cp_lookup_symbol_via_imports): Simplify initialization.
5089         (find_symbol_in_baseclass): Likewise.
5090         * symtab.h (null_block_symbol): Remove.
5091         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5092         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5093         (d_lookup_symbol_module): Likewise.
5094         (find_symbol_in_baseclass): Simplify initialization.
5095
5096 2019-03-24  Tom Tromey  <tom@tromey.com>
5097
5098         * expression.h: Don't include symtab.h.
5099         (struct block): Forward declare.
5100
5101 2019-03-24  Tom Tromey  <tom@tromey.com>
5102
5103         * c-exp.y (typebase): Remove casts.
5104         * gdbtypes.c (lookup_unsigned_typename, )
5105         (lookup_signed_typename): Remove cast.
5106         * eval.c (parse_to_comma_and_eval): Remove cast.
5107         * parse.c (write_dollar_variable): Remove cast.
5108         * block.h (struct block) <superblock>: Now const.
5109         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5110         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5111         (map_block): Make "block" const.
5112         * symfile.h (struct quick_symbol_functions)
5113         <map_matching_symbols>: Constify block argument to "callback".
5114         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5115         const.
5116         (find_pc_sect_compunit_symtab): Make "b" const.
5117         (find_symbol_at_address): Likewise.
5118         (search_symbols): Likewise.
5119         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5120         (dw2_debug_names_lookup_symbol): Likewise.
5121         (dw2_map_matching_symbols): Update.
5122         * p-valprint.c (pascal_val_print): Remove "block".
5123         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5124         (aux_add_nonlocal_symbols): Make "block" const.
5125         (resolve_subexp): Remove cast.
5126         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5127         const.
5128         (iterate_over_file_blocks): Likewise.
5129         * f-exp.y (%union) <bval>: Remove.
5130         * coffread.c (patch_opaque_types): Make "b" const.
5131         * spu-tdep.c (spu_catch_start): Make "block" const.
5132         * c-valprint.c (print_unpacked_pointer): Remove "block".
5133         * symmisc.c (dump_symtab_1): Make "b" const.
5134         (block_depth): Make "block" const.
5135         * d-exp.y (%union) <bval>: Remove.
5136         * cp-support.h (cp_lookup_rtti_type): Update.
5137         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5138         * psymtab.c (psym_lookup_symbol): Make "block" const.
5139         (maintenance_check_psymtabs): Make "b" const.
5140         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5141         (enumerate_locals, enumerate_args): Update.
5142         * python/py-symtab.c (stpy_global_block): Make "block" const.
5143         (stpy_static_block): Likewise.
5144         * inline-frame.c (block_starting_point_at): Make "new_block"
5145         const.
5146         * block.c (find_block_in_blockvector): Make return type const.
5147         (blockvector_for_pc_sect): Make "b" const.
5148         (find_block_in_blockvector): Make "b" const.
5149
5150 2019-03-23  Tom Tromey  <tom@tromey.com>
5151
5152         * varobj.c (varobj_create): Update.
5153         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5154         * printcmd.c (display_command, do_one_display): Don't reset
5155         innermost_block.
5156         * parser-defs.h (enum innermost_block_tracker_type): Move to
5157         expression.h.
5158         (innermost_block): Update comment.
5159         * parse.c (parse_exp_1): Add tracker_types parameter.
5160         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5161         tracker_types parameter.  Reset innermost_block.
5162         (parse_exp_in_context): Remove.
5163         (parse_expression_for_completion): Update.
5164         * objfiles.c (~objfile): Don't reset expression_context_block or
5165         innermost_block.
5166         * expression.h (enum innermost_block_tracker_type): Move from
5167         parser-defs.h.
5168         (parse_exp_1): Add tracker_types parameter.
5169         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5170         reset innermost_block.
5171
5172 2019-03-23  Tom Tromey  <tom@tromey.com>
5173
5174         * objfiles.h: Include bcache.h.
5175
5176 2019-03-23  Tom Tromey  <tom@tromey.com>
5177
5178         * linespec.c (get_current_search_block): Use
5179         scoped_restore_current_language.
5180         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5181
5182 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5183             Jiong Wang  <jiong.wang@arm.com>
5184
5185         * aarch64-linux-tdep.c
5186         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5187         section.
5188         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5189
5190 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5191             Jiong Wang  <jiong.wang@arm.com>
5192
5193         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5194         instructions.
5195         (aarch64_analyze_prologue_test): Add PACIASP test.
5196         (aarch64_prologue_prev_register): Unmask PC value.
5197
5198 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5199             Jiong Wang  <jiong.wang@arm.com>
5200
5201         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5202         (aarch64_dwarf2_prev_register): Unmask PC value.
5203         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5204         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5205         DW_CFA_AARCH64_negate_ra_state.
5206         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5207
5208 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5209             Jiong Wang  <jiong.wang@arm.com>
5210
5211         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5212         registers.
5213         (aarch64_pseudo_register_name): Likewise.
5214         (aarch64_pseudo_register_type): Likewise.
5215         (aarch64_pseudo_register_reggroup_p): Likewise.
5216         (aarch64_gdbarch_init): Add pauth registers.
5217         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5218         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5219         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5220         (struct gdbarch_tdep): Add regnum for ra_state.
5221
5222 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5223             Jiong Wang  <jiong.wang@arm.com>
5224
5225         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5226
5227 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5228             Jiong Wang  <jiong.wang@arm.com>
5229
5230         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5231         function.
5232         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5233         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5234         (aarch64_gdbarch_init): Add puth registers.
5235         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5236         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5237         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5238
5239 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5240             Jiong Wang  <jiong.wang@arm.com>
5241
5242         * aarch64-linux-nat.c
5243         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5244         * aarch64-linux-tdep.c
5245         (aarch64_linux_core_read_description): Likewise.
5246         (aarch64_linux_get_hwcap): New function.
5247         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5248         (aarch64_linux_get_hwcap): New declaration.
5249
5250 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5251             Jiong Wang  <jiong.wang@arm.com>
5252
5253         * aarch64-linux-nat.c
5254         (aarch64_linux_nat_target::read_description): Add pauth param.
5255         * aarch64-linux-tdep.c
5256         (aarch64_linux_core_read_description): Likewise.
5257         * aarch64-tdep.c (struct target_desc): Add in pauth.
5258         (aarch64_read_description): Add pauth param.
5259         (aarch64_gdbarch_init): Likewise.
5260         * aarch64-tdep.h (aarch64_read_description): Likewise.
5261         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5262         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5263         * features/Makefile: Add new files.
5264         * features/aarch64-pauth.c: New file.
5265         * features/aarch64-pauth.xml: New file.
5266
5267 2019-03-20  Tom Tromey  <tromey@adacore.com>
5268
5269         * infrun.c (handle_inferior_event): Rename from
5270         handle_inferior_event_1.  Create a scoped_value_mark.
5271         (handle_inferior_event): Remove.
5272
5273 2019-03-19  Tom Tromey  <tromey@adacore.com>
5274
5275         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5276         * infrun.h (print_stop_event): Add "displays" parameter.
5277         * infrun.c (print_stop_event): Add "displays" parameter.
5278
5279 2019-03-19  Pedro Alves  <palves@redhat.com>
5280
5281         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5282         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5283         to -1.  Fix TABs vs spaces.
5284         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5285         * tui/tui-out.h (tui_ui_out) Add intro comments.
5286         <m_line, m_start_of_line>: In-class initialize, and add describing
5287         comment.
5288
5289 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5290
5291         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5292         variable names.
5293         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5294
5295 2019-03-18  Pedro Alves  <palves@redhat.com>
5296             Eli Zaretskii <eliz@gnu.org>
5297
5298         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5299         m_line and m_start_of_line.
5300
5301 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5302
5303         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5304         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5305         it returns a newline.  This fixes a regression in TU mode, whereby
5306         the next line is output on the same screen line as the user input.
5307
5308 2019-03-18  Tom Tromey  <tromey@adacore.com>
5309
5310         * minsyms.c (minimal_symbol_reader::install): Remove call to
5311         obstack_blank.
5312
5313 2019-03-18  Pedro Alves  <palves@redhat.com>
5314
5315         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5316         New globals.
5317         (apply_style): New, factored out from ...
5318         (apply_ansi_escape): ... this.  Handle reverse video mode.
5319         (tui_set_reverse_mode): New function.
5320         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5321         * tui/tui-winsource.c (tui_show_source_line): Use
5322         tui_set_reverse_mode instead of setting A_STANDOUT.
5323         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5324         New setter methods.
5325
5326 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5327
5328         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5329         Handle tabs.
5330
5331 2019-03-18  Tom Tromey  <tromey@adacore.com>
5332
5333         * ada-lang.c (empty_array): Add "high" parameter.
5334         (ada_evaluate_subexp): Update.
5335
5336 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5337
5338         * unittests/string_view-selftests.c: Define
5339         _initialize_string_view_selftests unconditionally.
5340
5341 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5342
5343         PR gdb/24350
5344         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5345
5346 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5347
5348         PR gdb/24351
5349         * windows-nat.c (display_selector): Fix format specifiers.
5350
5351 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5352
5353         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5354         tui_refill_source_window instead of tui_refresh_win, to update the
5355         current execution line.  This fixes redisplay of the current line
5356         when stepping through the code with "next" or "step".
5357
5358 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5359
5360         * source-cache.c (source_cache::get_source_lines): Call
5361         find_source_lines to initialize s->nlines.  This fixes vertical
5362         scrolling of TUI source window when the DOWN arrow is pressed.
5363
5364 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5365
5366         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5367         linux-thread-db.c (_initialize_thread_db): Likewise.
5368
5369 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5370
5371         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5372         wclrtoeol in tui_show_source_line".  This reverts changes made in
5373         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5374
5375 2019-03-15  Tom Tromey  <tom@tromey.com>
5376
5377         * symtab.h (struct minimal_symbol): Derive from
5378         general_symbol_info.
5379         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5380         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5381         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5382         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5383         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5384         (MSYMBOL_SEARCH_NAME): Update.
5385         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5386         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5387         * minsyms.c (minimal_symbol_reader::record_full): Update.
5388
5389 2019-03-15  Tom Tromey  <tom@tromey.com>
5390
5391         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5392
5393 2019-03-15  Tom Tromey  <tom@tromey.com>
5394
5395         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5396         unique_xmalloc_ptr.
5397         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5398         Update.
5399         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5400         (build_minimal_symbol_hash_tables)
5401         (minimal_symbol_reader::install): Update.
5402
5403 2019-03-15  Tom Tromey  <tom@tromey.com>
5404
5405         * symtab.c (create_demangled_names_hash): Update.
5406         (symbol_set_names): Update.
5407         * objfiles.h (struct objfile_per_bfd_storage)
5408         <demangled_names_hash>: Now an htab_up.
5409         * objfiles.c (objfile_per_bfd_storage): Simplify.
5410
5411 2019-03-15  Tom Tromey  <tom@tromey.com>
5412
5413         * objfiles.h (struct objfile_per_bfd_storage): Declare
5414         destructor.
5415         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5416         New.
5417         (get_objfile_bfd_data): Use new.  Don't initialize
5418         language_of_main.
5419         (free_objfile_per_bfd_storage): Remove.
5420         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5421
5422 2019-03-15  Tom Tromey  <tom@tromey.com>
5423
5424         * symfile.c (reread_symbols): Update.
5425         * objfiles.c (objfile::objfile): Update.
5426         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5427         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5428         comment.
5429         (minimal_symbol_reader::install): Update.
5430         (terminate_minimal_symbol_table): Remove.
5431         * jit.c (jit_object_close_impl): Update.
5432
5433 2019-03-15  Tom Tromey  <tom@tromey.com>
5434
5435         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5436         initializations.
5437
5438 2019-03-15  Tom Tromey  <tom@tromey.com>
5439
5440         * objfiles.h (struct objfile_per_bfd_storage)
5441         <demangled_hash_languages>: Now a bitset.
5442         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5443         (lookup_minimal_symbol): Update.
5444
5445 2019-03-15  Tom Tromey  <tom@tromey.com>
5446
5447         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5448         Don't return the symbol.
5449         * coffread.c (record_minimal_symbol): Use record_full.
5450
5451 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5452
5453         The MS-Windows port of ncurses fails to switch to a color pair if
5454         one or both of the colors are the implicit default colors.  This
5455         change records the default colors when TUI is initialized, and
5456         then specifies them explicitly when a color pair uses the default
5457         colors.  This allows color styling in TUI mode on MS-Windows.
5458
5459         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5460         ncurses_norm_attr.
5461         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5462         colors in ncurses_norm_attr.
5463         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5464         "none", replace it with the default color recorded in
5465         ncurses_norm_attr.
5466
5467 2019-03-14  Tom Tromey  <tromey@adacore.com>
5468
5469         * source-cache.h (class source_cache) <get_source_lines>: Return
5470         std::string.
5471         * source-cache.c (source_cache::extract_lines): Handle case where
5472         first_pos==npos.  Return std::string.
5473         (source_cache::get_source_lines): Update.
5474
5475 2019-03-14  Tom Tromey  <tromey@adacore.com>
5476
5477         * NEWS: Add item for "style sources" commands.
5478         * source-cache.c (source_cache::get_source_lines): Check
5479         source_styling.
5480         * cli/cli-style.c (source_styling): New global.
5481         (_initialize_cli_style): Add "style sources" commands.
5482         (show_style_sources): New function.
5483         * cli/cli-style.h (source_styling): Declare.
5484
5485 2019-03-14  Pedro Alves  <palves@redhat.com>
5486             Tom Tromey  <tromey@adacore.com>
5487
5488         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5489         * tui/tui-winsource.c (tui_refill_source_window): New function,
5490         from...
5491         (tui_horizontal_source_scroll): ... here.  Move some logic.
5492         * cli/cli-style.c (set_style_enabled): Notify new observable.
5493         * tui/tui-hooks.c (tui_redisplay_source): New function.
5494         (tui_attach_detach_observers): Attach or detach
5495         tui_redisplay_source.
5496         * observable.h (source_styling_changed): New observable.
5497         * observable.c: Define source_styling_changed observable.
5498
5499 2019-03-13  Tom Tromey  <tromey@adacore.com>
5500
5501         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5502         (i386_gnu_nat_target::store_registers): Update.
5503         * target-debug.h (target_debug_print_std_string): New macro.
5504         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5505         * windows-tdep.c (display_one_tib): Update.
5506         * tui/tui-stack.c (tui_make_status_line): Update.
5507         * top.c (print_inferior_quit_action): Update.
5508         * thread.c (thr_try_catch_cmd): Update.
5509         (add_thread_with_info): Update.
5510         (thread_target_id_str): Update.
5511         (thr_try_catch_cmd): Update.
5512         (thread_command): Update.
5513         (thread_find_command): Update.
5514         * record-btrace.c (record_btrace_target::info_record)
5515         (record_btrace_resume_thread, record_btrace_target::resume)
5516         (record_btrace_cancel_resume, record_btrace_step_thread)
5517         (record_btrace_target::wait, record_btrace_target::wait)
5518         (record_btrace_target::wait, record_btrace_target::stop): Update.
5519         * progspace.c (print_program_space): Update.
5520         * process-stratum-target.c
5521         (process_stratum_target::thread_address_space): Update.
5522         * linux-fork.c (linux_fork_mourn_inferior)
5523         (detach_checkpoint_command, info_checkpoints_command)
5524         (linux_fork_context): Update.
5525         (linux_fork_detach): Update.
5526         (class scoped_switch_fork_info): Update.
5527         (delete_checkpoint_command): Update.
5528         * infrun.c (follow_fork_inferior): Update.
5529         (follow_fork_inferior): Update.
5530         (proceed_after_vfork_done): Update.
5531         (handle_vfork_child_exec_or_exit): Update.
5532         (follow_exec): Update.
5533         (displaced_step_prepare_throw): Update.
5534         (displaced_step_restore): Update.
5535         (start_step_over): Update.
5536         (resume_1): Update.
5537         (clear_proceed_status_thread): Update.
5538         (proceed): Update.
5539         (print_target_wait_results): Update.
5540         (do_target_wait): Update.
5541         (context_switch): Update.
5542         (stop_all_threads): Update.
5543         (restart_threads): Update.
5544         (finish_step_over): Update.
5545         (handle_signal_stop): Update.
5546         (switch_back_to_stepped_thread): Update.
5547         (keep_going_pass_signal): Update.
5548         (print_exited_reason): Update.
5549         (normal_stop): Update.
5550         * inferior.c (inferior_pid_to_str): Change return type.
5551         (print_selected_inferior): Update.
5552         (add_inferior): Update.
5553         (detach_inferior): Update.
5554         * dummy-frame.c (fprint_dummy_frames): Update.
5555         * dcache.c (dcache_info_1): Update.
5556         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5557         (btrace_fetch, btrace_clear): Update.
5558         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5559         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5560         type.
5561         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5562         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5563         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5564         * gdbarch.c, gdbarch.h: Rebuild.
5565         * gdbarch.sh (core_pid_to_str): Change return type.
5566         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5567         return type.
5568         (windows_nat_target::pid_to_str): Change return type.
5569         (windows_delete_thread): Update.
5570         (windows_nat_target::attach): Update.
5571         (windows_nat_target::files_info): Update.
5572         * target-delegates.c: Rebuild.
5573         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5574         return type.
5575         (sol_thread_target::pid_to_str): Change return type.
5576         * remote.c (class remote_target) <pid_to_str>: Change return
5577         type.
5578         (remote_target::pid_to_str): Change return type.
5579         (extended_remote_target::attach, remote_target::remote_stop_ns)
5580         (remote_target::remote_notif_remove_queued_reply)
5581         (remote_target::push_stop_reply, remote_target::disable_btrace):
5582         Update.
5583         (extended_remote_target::attach): Update.
5584         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5585         type.
5586         (gdbsim_target::pid_to_str): Change return type.
5587         * ravenscar-thread.c (struct ravenscar_thread_target)
5588         <pid_to_str>: Change return type.
5589         (ravenscar_thread_target::pid_to_str): Change return type.
5590         * procfs.c (class procfs_target) <pid_to_str>: Change return
5591         type.
5592         (procfs_target::pid_to_str): Change return type.
5593         (procfs_target::attach): Update.
5594         (procfs_target::detach): Update.
5595         (procfs_target::fetch_registers): Update.
5596         (procfs_target::store_registers): Update.
5597         (procfs_target::wait): Update.
5598         (procfs_target::files_info): Update.
5599         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5600         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5601         return type.
5602         (nto_procfs_target::pid_to_str): Change return type.
5603         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5604         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5605         return type.
5606         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5607         (exit_lwp): Update.
5608         (attach_proc_task_lwp_callback, get_detach_signal)
5609         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5610         (linux_nat_target::resume, wait_lwp, stop_callback)
5611         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5612         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5613         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5614         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5615         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5616         type.
5617         (inf_ptrace_target::attach): Update.
5618         (inf_ptrace_target::files_info): Update.
5619         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5620         type.
5621         (go32_nat_target::pid_to_str): Change return type.
5622         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5623         (gnu_nat_target::wait): Update.
5624         (gnu_nat_target::wait): Update.
5625         (gnu_nat_target::resume): Update.
5626         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5627         (fbsd_nat_target::wait): Update.
5628         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5629         type.
5630         (darwin_nat_target::attach): Update.
5631         * corelow.c (class core_target) <pid_to_str>: Change return type.
5632         (core_target::pid_to_str): Change return type.
5633         * target.c (normal_pid_to_str): Change return type.
5634         (default_pid_to_str): Likewise.
5635         (target_pid_to_str): Change return type.
5636         (target_translate_tls_address): Update.
5637         (target_announce_detach): Update.
5638         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5639         return type.
5640         (bsd_uthread_target::pid_to_str): Change return type.
5641         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5642         type.
5643         (bsd_kvm_target::pid_to_str): Change return type.
5644         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5645         return type.
5646         (aix_thread_target::pid_to_str): Change return type.
5647         * target.h (struct target_ops) <pid_to_str>: Change return type.
5648         (target_pid_to_str, normal_pid_to_str): Likewise.
5649         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5650         type.
5651         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5652         type.
5653         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5654         return type.
5655         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5656         type.
5657         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5658         type.
5659         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5660         return type.
5661
5662 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5663
5664         * NEWS: Mention that the new default MI version is 3.  Mention
5665         changes to the output of commands and events that deal with
5666         multi-location breakpoints.
5667         * breakpoint.c: Include "mi/mi-out.h".
5668         (print_one_breakpoint): Change output syntax if using MI version
5669         >= 3.
5670         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5671         New.
5672         (mi_multi_location_breakpoint_output_fixed): New.
5673         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5674         (mi_cmd_fix_multi_location_breakpoint_output): New.
5675         (mi_multi_location_breakpoint_output_fixed): New.
5676         * mi/mi-cmds.c (mi_cmds): Register command
5677         -fix-multi-location-breakpoint-output.
5678         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5679         interpreter "mi".
5680
5681 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5682
5683         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5684         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5685         instantiate mi_ui_out based on interpreter name.
5686         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5687         * mi/mi-main.c (mi_load_progress): Likewise.
5688
5689 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5690
5691         * NEWS: Combine separate "New targets" sections for 8.3.
5692
5693 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5694
5695         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5696         (ppcfbsd_init_abi): Install gdbarch
5697         "fetch_tls_load_module_address" and "get_thread_local_address"
5698         methods.
5699
5700 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5701
5702         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5703         (riscv_fbsd_init_abi): Install gdbarch
5704         "fetch_tls_load_module_address" and "get_thread_local_address"
5705         methods.
5706
5707 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5708
5709         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5710         (i386fbsd_init_abi): Install gdbarch
5711         "fetch_tls_load_module_address" and "get_thread_local_address"
5712         methods.
5713
5714 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5715
5716         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5717         (amd64fbsd_init_abi): Install gdbarch
5718         "fetch_tls_load_module_address" and "get_thread_local_address"
5719         methods.
5720
5721 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5722
5723         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5724         (struct fbsd_pspace_data): New type.
5725         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5726         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5727         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5728         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5729         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5730
5731 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5732
5733         * gdbtypes.c (lookup_struct_elt): New function.
5734         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5735         * gdbtypes.h (struct struct_elt): New type.
5736         (lookup_struct_elt): New prototype.
5737
5738 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5739
5740         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5741         remove disabled code block.
5742
5743 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5744
5745         * gdbarch.sh (get_thread_local_address): New method.
5746         * gdbarch.h, gdbarch.c: Regenerate.
5747         * target.c (target_translate_tls_address): Use
5748         gdbarch_get_thread_local_address if present instead of
5749         target::get_thread_local_address.
5750
5751 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5752
5753         * target.h (target::get_thread_local_address): Update comment.
5754
5755 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5756
5757         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5758         objfile->separate_debug_objfile_backlink if not NULL.
5759
5760 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5761
5762         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5763         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5764         (amd64bsd_store_inferior_registers): Likewise.
5765         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5766         Enable segment base registers.
5767         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5768         PT_GETFSBASE and PT_GETGSBASE.
5769         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5770         PT_SETGSBASE.
5771         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5772         segment base registers.
5773         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5774
5775 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5776
5777         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5778         Update calls to i386_target_description to add 'segments'
5779         parameter.
5780         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5781         add segment base registers.
5782         * arch/i386.c (i386_create_target_description): Add 'segments'
5783         parameter to enable segment base registers.
5784         * arch/i386.h (i386_create_target_description): Likewise.
5785         * features/i386/32bit-segments.xml: New file.
5786         * features/i386/32bit-segments.c: Generate.
5787         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5788         call to i386_target_description to add 'segments' parameter.
5789         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5790         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5791         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5792         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5793         if feature is present.
5794         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5795         Add 'segments' parameter to call to i386_target_description.
5796         (i386_target_description): Add 'segments' parameter to enable
5797         segment base registers.
5798         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5799         to call to i386_target_description.
5800         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5801         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5802         Define I386_NUM_REGS.
5803         (i386_target_description): Add 'segments' parameter to enable
5804         segment base registers.
5805
5806 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5807
5808         PR/24325
5809         * source-cache.c: #undef open and close, to avoid unresolved
5810         externals during linking.
5811
5812 2019-03-12  Tom Tromey  <tromey@adacore.com>
5813
5814         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5815         const.  Add initializers.
5816         (_initialize_remote): Don't initialize ptid globals.
5817
5818 2019-03-12  Pedro Alves  <palves@redhat.com>
5819
5820         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5821
5822 2019-03-12  Pedro Alves  <palves@redhat.com>
5823
5824         * cp-name-parser.y (main): Remove unused 'len' variable.
5825
5826 2019-03-12  Tom Tromey  <tromey@adacore.com>
5827
5828         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5829         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5830
5831 2019-03-12  Tom Tromey  <tromey@adacore.com>
5832
5833         * linux-nat.c (iterate_over_lwps): Update.
5834         (stop_callback): Remove parameter.
5835         (stop_wait_callback, detach_callback, resume_set_callback)
5836         (select_singlestep_lwp_callback, set_ignore_sigint)
5837         (status_callback, resumed_callback, resume_clear_callback)
5838         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5839         data parameter.
5840         (linux_nat_target::detach, linux_nat_target::resume)
5841         (linux_stop_and_wait_all_lwps, select_event_lwp)
5842         (linux_nat_filter_event, linux_nat_wait_1)
5843         (linux_nat_target::kill, linux_nat_target::stop)
5844         (linux_nat_target::stop): Update.
5845         (linux_nat_resume_callback): Change type.
5846         (resume_stopped_resumed_lwps, count_events_callback)
5847         (select_event_lwp_callback): Likewise.
5848         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5849         * arm-linux-nat.c (struct update_registers_data): Remove.
5850         (update_registers_callback): Change type.
5851         (arm_linux_insert_hw_breakpoint1): Update.
5852         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5853         parameter.
5854         (x86_linux_dr_set_addr): Update.
5855         (x86_linux_dr_set_control): Update.
5856         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5857         (iterate_over_lwps): Use gdb::function_view.
5858         * nat/aarch64-linux-hw-point.c (struct
5859         aarch64_dr_update_callback_param): Remove.
5860         (debug_reg_change_callback): Change type.
5861         (aarch64_notify_debug_reg_change): Update.
5862         * s390-linux-nat.c (s390_refresh_per_info): Update.
5863
5864 2019-03-11  Tom Tromey  <tromey@adacore.com>
5865
5866         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5867         redundant assignment to "this_cu".
5868
5869 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5870
5871         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5872
5873 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5874
5875         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5876         from...
5877         (rank_one_type): ... this.
5878
5879 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5880
5881         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5882         from...
5883         (rank_one_type): ... this.
5884
5885 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5886
5887         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5888         from...
5889         (rank_one_type): ... this.
5890
5891 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5892
5893         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5894         from...
5895         (rank_one_type): ... this.
5896
5897 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5898
5899         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5900         from...
5901         (rank_one_type): ... this.
5902
5903 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5904
5905         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5906         from...
5907         (rank_one_type): ... this.
5908
5909 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5910
5911         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5912         from...
5913         (rank_one_type): ... this.
5914
5915 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5916
5917         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5918         from...
5919         (rank_one_type): ... this.
5920
5921 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5922
5923         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5924         from...
5925         (rank_one_type): ... this.
5926
5927 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5928
5929         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5930         from...
5931         (rank_one_type): ... this.
5932
5933 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5934
5935         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5936         from...
5937         (rank_one_type): ... this.
5938
5939 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5940
5941         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5942         from...
5943         (rank_one_type): ... this.
5944
5945 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5946
5947         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5948         inferior-events' shows the example events.
5949
5950 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5951
5952         Support styling on native MS-Windows console
5953
5954         PR/24315
5955         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5956         on MS-Windows if $TERM is not defined.
5957
5958         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5959
5960         * posix-hdep.c (gdb_console_fputs):
5961         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5962         functions.
5963         * ui-file.h (gdb_console_fputs): Add prototype.
5964
5965         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5966         back to fputs only if the former returns zero.
5967
5968 2019-03-07  Tom Tromey  <tom@tromey.com>
5969
5970         * symmisc.c (print_symbol_bcache_statistics): Update.
5971         (print_objfile_statistics): Update.
5972         * symfile.c (allocate_symtab): Update.
5973         * stabsread.c: Don't include bcache.h.
5974         * psymtab.h (struct psymbol_bcache): Don't declare.
5975         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5976         (psymbol_bcache_init, psymbol_bcache_free)
5977         (psymbol_bcache_get_bcache): Don't declare.
5978         * psymtab.c (struct psymbol_bcache): Remove.
5979         (psymtab_storage::psymtab_storage): Update.
5980         (psymtab_storage::~psymtab_storage): Update.
5981         (psymbol_bcache_init, psymbol_bcache_free)
5982         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5983         (add_psymbol_to_bcache): Update.
5984         (allocate_psymtab): Update.
5985         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5986         macro_cache>: No longer pointers.
5987         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5988         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5989         * macrotab.c (macro_bcache): Update.
5990         * macroexp.c: Don't include bcache.h.
5991         * gdbtypes.c (check_types_worklist): Update.
5992         (types_deeply_equal): Remove TRY/CATCH.  Update.
5993         * elfread.c (elf_symtab_read): Update.
5994         * dwarf2read.c: Don't include bcache.h.
5995         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5996         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5997         (print_bcache_statistics, bcache_memory_used): Don't declare.
5998         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5999         methods.  Rename all data members.
6000         * bcache.c (struct bcache): Move to bcache.h.
6001         (bcache::expand_hash_table): Rename from expand_hash_table.
6002         (bcache): Remove.
6003         (bcache::insert): Rename from bcache_full.
6004         (bcache::compare): Rename from bcache_compare.
6005         (bcache_xmalloc): Remove.
6006         (bcache::~bcache): Rename from bcache_xfree.
6007         (bcache::print_statistics): Rename from print_bcache_statistics.
6008         (bcache::memory_used): Rename from bcache_memory_used.
6009
6010 2019-03-07  Pedro Alves  <palves@redhat.com>
6011
6012         * infrun.c (normal_stop): Also check for
6013         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6014
6015 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6016
6017         * f-lang.c (value_from_host_double): Moved to...
6018         * value.c (value_from_host_double): ...here.
6019         * value.h (value_from_host_double): Declare.
6020         * guile/scm-math.c (vlscm_convert_typed_number): Use
6021         value_from_host_double.
6022         (vlscm_convert_number): Likewise.
6023         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6024         * python/py-value.c (convert_value_from_python): Likewise.
6025
6026 2019-03-06  Tom Tromey  <tom@tromey.com>
6027
6028         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6029
6030 2019-03-06  Tom Tromey  <tom@tromey.com>
6031
6032         * utils.h (free_current_contents): Don't declare.
6033         * utils.c (free_current_contents): Remove.
6034
6035 2019-03-06  Tom Tromey  <tom@tromey.com>
6036
6037         * top.c (quit_force): Update.
6038         * main.c (captured_command_loop): Update.
6039         * common/new-op.c (operator new): Update.
6040         * common/common-exceptions.c (struct catcher)
6041         <save_cleanup_chain>: Remove member.
6042         (exceptions_state_mc_init): Update.
6043         (exception_try_scope_entry): Return nullptr.
6044         (exception_try_scope_exit, exception_rethrow)
6045         (throw_exception_sjlj, throw_exception_cxx): Update.
6046         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6047         (all_cleanups, do_cleanups, discard_cleanups)
6048         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6049         (restore_cleanups, restore_final_cleanups): Don't declare.
6050         (do_final_cleanups): Remove parameter.
6051         * common/cleanups.c (cleanup_chain, make_cleanup)
6052         (make_cleanup_dtor, all_cleanups, do_cleanups)
6053         (discard_my_cleanups, discard_cleanups)
6054         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6055         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6056         (null_cleanup): Remove.
6057         (do_final_cleanups): Remove parameter.
6058
6059 2019-03-06  Tom Tromey  <tom@tromey.com>
6060
6061         * remote.c (remote_target::remote_parse_stop_reply): Use
6062         unique_xmalloc_ptr.
6063
6064 2019-03-06  Tom Tromey  <tom@tromey.com>
6065
6066         * stabsread.c (struct stabs_field_info): Rename from field_info.
6067         <list, fnlist>: Add initializers.
6068         <obstack>: New member.
6069         (read_member_functions, read_struct_fields, read_baseclasses):
6070         Allocate on obstack.  Don't use cleanups.
6071         (read_one_struct_field, read_member_functions, read_struct_fields)
6072         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6073         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6074         (read_struct_type): Update.
6075
6076 2019-03-06  Tom Tromey  <tom@tromey.com>
6077
6078         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6079         * common/filestuff.h (make_cleanup_close): Don't declare.
6080         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6081         Remove.
6082
6083 2019-03-06  Tom Tromey  <tom@tromey.com>
6084
6085         * solib-aix.c: Use make_scope_exit.
6086
6087 2019-03-06  Tom Tromey  <tom@tromey.com>
6088
6089         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6090         Use make_scope_exit.
6091
6092 2019-03-06  Tom Tromey  <tom@tromey.com>
6093
6094         * solib-svr4.c (disable_probes_interface): Remove parameter.
6095         (svr4_handle_solib_event): Use make_scope_exit.
6096
6097 2019-03-06  Tom Tromey  <tom@tromey.com>
6098
6099         * remote.c (struct stop_reply_deleter): Remove.
6100         (stop_reply_up): Update.
6101         (struct stop_reply): Derive from notif_event.  Don't typedef.
6102         <regcache>: Now a std::vector.
6103         (stop_reply_xfree): Remove.
6104         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6105         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6106         (remote_target::discard_pending_stop_replies): Use delete.
6107         (remote_target::remote_parse_stop_reply): Update.
6108         (remote_target::process_stop_reply): Update.
6109         * remote-notif.h (struct notif_event): Add virtual destructor.
6110         Remove "dtr" member.
6111         (struct notif_client) <alloc_event>: Return a unique_ptr.
6112         (notif_event_xfree): Don't declare.
6113         (notif_event_up): New typedef.
6114         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6115         (notif_event_xfree, do_notif_event_xfree): Remove.
6116         (remote_notif_state_xfree): Update.
6117
6118 2019-03-06  Tom Tromey  <tom@tromey.com>
6119
6120         * infrun.c (displaced_step_clear_cleanup): Now a
6121         forward_scope_exit type.
6122         (displaced_step_prepare_throw): Update.
6123         (displaced_step_fixup): Update.
6124
6125 2019-03-06  Tom Tromey  <tom@tromey.com>
6126
6127         * inferior.h (class inferior): Update comment.
6128         * gdbthread.h (class thread_info): Update comment.
6129
6130 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6131             Tom Tromey  <tom@tromey.com>
6132
6133         * stabsread.h (struct stab_section_list): Remove.
6134         (coffstab_build_psymtabs): Update.
6135         * dbxread.c (symbuf_sections): Now a std::vector.
6136         (sect_idx): New global.
6137         (fill_symbuf): Update.
6138         (coffstab_build_psymtabs): Change type of stabsects parameter.
6139         Update.
6140         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6141         std::vector.
6142         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6143         (coff_locate_sections): Update.
6144         (coff_symfile_read): Remove cleanups.  Update.
6145         (init_stringtab): Add storage parameter.
6146         (free_stringtab, free_stringtab_cleanup): Remove.
6147         (init_lineno): Add storage parameter.
6148         (free_linetab, free_linetab_cleanup): Remove.
6149
6150 2019-03-06  Pedro Alves  <palves@redhat.com>
6151
6152         * linux-fork.c (fork_info::clobber_regs): Delete.
6153         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6154         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6155         comment.  Adjust.
6156         (scoped_switch_fork_info::scoped_switch_fork_info)
6157         (checkpoint_command, linux_fork_context): Adjust
6158         fork_save_infrun_state calls.
6159
6160 2019-03-06  Pedro Alves  <palves@redhat.com>
6161
6162         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6163         (inf_has_multiple_threads): Return 'bool' and rewrite using
6164         inferior_info::threads().
6165
6166 2019-03-06  Pedro Alves  <palves@redhat.com>
6167
6168         * linux-fork.c: Include <list>.
6169         (fork_list): Now a std::list instance.
6170         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6171         (forks_exist_p, find_last_fork): Adjust.
6172         (new_fork): Delete.
6173         (one_fork_p): New.
6174         (add_fork): Adjust.
6175         (free_fork): Delete, folded into fork_info::~fork_info().
6176         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6177         Adjust.
6178         (init_fork_list): Delete.
6179         (linux_fork_killall, linux_fork_mourn_inferior)
6180         (linux_fork_detach, info_checkpoints_command): Adjust.
6181         (_initialize_linux_fork): No longer call init_fork_list.
6182
6183 2019-03-06  Pedro Alves  <palves@redhat.com>
6184
6185         * linux-fork.c (new_fork): New, split out of ...
6186         (add_fork): ... this.  Return void.  Move "first fork" special
6187         case from here, to ...
6188         (checkpoint_command): ... here.
6189         * linux-linux.h (add_fork): Return void.
6190
6191 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6192
6193         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6194
6195 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6196             Chris January  <chris.january@arm.com>
6197             David Lecomber  <david.lecomber@arm.com>
6198
6199         * f-exp.y: New token, UNOP_INTRINSIC.
6200         (exp): New pattern using UNOP_INTRINSIC token.
6201         (f77_keywords): Add 'abs' keyword.
6202         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6203         (value_from_host_double): New function.
6204         (evaluate_subexp_f): Support UNOP_ABS.
6205
6206 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6207
6208         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6209         types.
6210
6211 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6212
6213         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6214         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6215         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6216
6217 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6218
6219         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6220
6221 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6222             Chris January  <chris.january@arm.com>
6223
6224         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6225         * f-exp.y: Define 'KIND' token.
6226         (exp): New pattern for KIND expressions.
6227         (ptype): Handle types with a kind extension.
6228         (direct_abs_decl): Extend to spot kind extensions.
6229         (f77_keywords): Add 'kind' to the list.
6230         (push_kind_type): New function.
6231         (convert_to_kind_type): New function.
6232         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6233         * parse.c (operator_length_standard): Likewise.
6234         * parser-defs.h (enum type_pieces): Add tp_kind.
6235         * std-operator.def: Add UNOP_KIND.
6236
6237 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6238
6239         * f-exp.y (f_parse): Set yydebug.
6240
6241 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6242
6243         * f-lang.c (evaluate_subexp_f): New function.
6244         (exp_descriptor_f): New global.
6245         (f_language_defn): Use exp_descriptor_f instead of
6246         exp_descriptor_standard.
6247
6248 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6249
6250         * f-exp.y (struct token): Add comments.
6251         (dot_ops): Remove uppercase versions and the end marker.
6252         (f77_keywords): Likewise.
6253         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6254         entries in the dot_ops array are case insensitive, and use
6255         strncasecmp to compare strings.  Also some whitespace cleanup in
6256         this area.  Similar for the f77_keywords array, except entries in
6257         this list might be case sensitive.
6258
6259 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6260
6261         * f-exp.y (struct f77_boolean_val): Add comments.
6262         (boolean_values): Remove uppercase versions, and end marker.
6263         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6264         and use strncasecmp to achieve case insensitivity.  Additionally,
6265         perform whitespace cleanup around this code.
6266
6267 2019-03-06  Tom Tromey  <tromey@adacore.com>
6268
6269         * remote-sim.c (gdbsim_target_open): Use result of
6270         gdb_argv::release.
6271
6272 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6273         Dirk Schubert  <dirk.schubert@arm.com>
6274         Chris January  <chris.january@arm.com>
6275
6276         * eval.c (evaluate_subexp_standard): Call Fortran argument
6277         wrapping logic.
6278         * f-lang.c (struct value): A value which can be passed into a
6279         Fortran function call.
6280         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6281         where appropriate.
6282         (struct type): Value ready for a Fortran function call.
6283         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6284         is needed.
6285         * f-lang.h (fortran_argument_convert): Declaration.
6286         (fortran_preserve_arg_pointer): Declaration.
6287         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6288
6289 2019-03-05  Tom Tromey  <tromey@adacore.com>
6290
6291         * python/py-prettyprint.c (print_string_repr): Remove #if.
6292         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6293
6294 2019-03-05  Tom Tromey  <tromey@adacore.com>
6295
6296         * target.c (the_dummy_target): Move later.  Change type to
6297         "dummy_target".
6298         (initialize_targets): Don't initialize the_dummy_target.
6299
6300 2019-03-05  Tom Tromey  <tromey@adacore.com>
6301
6302         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6303         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6304
6305 2019-03-05  Tom Tromey  <tromey@adacore.com>
6306
6307         * windows-nat.c (windows_nat_target::attach)
6308         (windows_nat_target::detach): Don't call gdb_flush.
6309         * valprint.c (generic_val_print, val_print, val_print_string):
6310         Don't call gdb_flush.
6311         * utils.c (defaulted_query): Don't call gdb_flush.
6312         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6313         * target.c (target_announce_detach): Don't call gdb_flush.
6314         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6315         * remote.c (extended_remote_target::attach): Don't call
6316         gdb_flush.
6317         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6318         * printcmd.c (do_examine): Don't call gdb_flush.
6319         (info_display_command): Don't call gdb_flush.
6320         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6321         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6322         * memattr.c (info_mem_command): Don't call gdb_flush.
6323         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6324         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6325         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6326         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6327         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6328         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6329         (gnu_nat_target::detach): Don't call gdb_flush.
6330         * f-valprint.c (f_val_print): Don't call gdb_flush.
6331         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6332         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6333         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6334         gdb_flush.
6335         * c-valprint.c (c_val_print): Don't call gdb_flush.
6336         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6337
6338 2019-03-05  Tom Tromey  <tromey@adacore.com>
6339
6340         * varobj.c (update_dynamic_varobj_children): Update.
6341         (install_default_visualizer): Use reset, not release.
6342         * value.c (set_internalvar): Update.
6343         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6344         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6345         ATTRIBUTE_UNUSED_RESULT.
6346
6347 2019-03-05  Tom Tromey  <tromey@adacore.com>
6348
6349         * remote.c (class scoped_remote_fd) <release>: Add
6350         ATTRIBUTE_UNUSED_RESULT.
6351
6352 2019-03-05  Tom Tromey  <tromey@adacore.com>
6353
6354         * macroexp.c (struct macro_buffer) <release>: Add
6355         ATTRIBUTE_UNUSED_RESULT.
6356
6357 2019-03-05  Tom Tromey  <tromey@adacore.com>
6358
6359         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6360         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6361         ATTRIBUTE_UNUSED_RESULT.
6362
6363 2019-03-05  Tom Tromey  <tromey@adacore.com>
6364
6365         * common/scoped_fd.h (class scoped_fd) <release>: Add
6366         ATTRIBUTE_UNUSED_RESULT.
6367
6368 2019-03-05  Tom Tromey  <tromey@adacore.com>
6369
6370         * parser-defs.h (struct parser_state) <release>: Add
6371         ATTRIBUTE_UNUSED_RESULT.
6372
6373 2019-03-05  Tom Tromey  <tromey@adacore.com>
6374
6375         * utils.h (class gdb_argv) <release>: Add
6376         ATTRIBUTE_UNUSED_RESULT.
6377         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6378
6379 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6380
6381         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6382         for-loop range, to avoid compiler warnings.
6383
6384         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6385         avoid compiler warnings about unused variables.
6386
6387         * NEWS: Mention end of support for native debugging on MS-Windows
6388         before XP.
6389
6390         PR gdb/24292
6391         * common/netstuff.c:
6392         * gdbserver/gdbreplay.c
6393         * gdbserver/remote-utils.c:
6394         * ser-tcp.c:
6395         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6396         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6397         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6398         'getaddrinfo' and 'freeaddrinfo' were not available before
6399         Windows XP, and mingw.org's MinGW headers by default define
6400         _WIN32_WINNT to 0x500.
6401
6402 2019-03-01  Gary Benson <gbenson@redhat.com>
6403
6404         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6405
6406 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6407             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6408
6409         PR gdb/8527
6410         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6411         set_sigint_trap, clear_sigint_trap.
6412
6413 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6414
6415         * target.c (target_detach): Clear the regcache and the
6416         frame cache.
6417
6418 2019-02-27  Pedro Alves  <palves@redhat.com>
6419
6420         * utils.c (set_screen_size): When we cap the height/width sizes,
6421         tweak the corresponding command variable to show "unlimited":
6422
6423 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6424             Pedro Alves  <palves@redhat.com>
6425
6426         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6427         before calling rl_set_screen_size.
6428
6429 2019-02-27  Tom Tromey  <tromey@adacore.com>
6430
6431         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6432         define.
6433         * python/py-value.c: Remove Python 2.4 workaround.
6434         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6435         workaround.
6436         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6437         Python 2.4 workaround.
6438         * python/python-internal.h: Remove Python 2.4 comment.
6439         (Py_ssize_t): Don't define.
6440         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6441         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6442         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6443         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6444         * python/python.c (do_start_initialization): Remove Python 2.4
6445         workaround.
6446         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6447         (print_children): Remove Python 2.4 workaround.
6448         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6449         workaround.
6450         (CHARBUFFERPROC_NAME): Remove.
6451         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6452         Python 2.4 workaround.
6453
6454 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6455
6456         * NEWS: Note minimum Python version.
6457
6458 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6459
6460         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6461         code from these functions.  Remove corresponding ifdefs.  Use
6462         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6463         Remove gotos and target of gotos.
6464         (infpy_search_memory): Likewise.
6465
6466 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6467
6468         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6469         (hppa_gdbarch_init): Don't register deleted functions with
6470         gdbarch.
6471
6472 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6473
6474         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6475         (h8300_unwind_sp): Delete.
6476         (h8300_dummy_id): Delete.
6477         (h8300_gdbarch_init): Don't register deleted functions with
6478         gdbarch.
6479
6480 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6481
6482         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6483         (ft32_unwind_pc): Delete.
6484         (ft32_unwind_sp): Delete.
6485         (ft32_gdbarch_init): Don't register deleted functions with
6486         gdbarch.
6487
6488 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6489
6490         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6491         (frv_unwind_pc): Delete.
6492         (frv_unwind_sp): Delete.
6493         (frv_gdbarch_init): Don't register deleted functions with
6494         gdbarch.
6495
6496 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6497
6498         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6499         (riscv_unwind_pc): Delete.
6500         (riscv_unwind_sp): Delete.
6501         (riscv_gdbarch_init): Don't register deleted functions with
6502         gdbarch.
6503
6504 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6505
6506         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6507         (csky_unwind_pc): Delete.
6508         (csky_unwind_sp): Delete.
6509         (csky_gdbarch_init): Don't register deleted functions with
6510         gdbarch.
6511
6512 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6513
6514         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6515         (cris_unwind_pc): Delete.
6516         (cris_unwind_sp): Delete.
6517         (cris_gdbarch_init): Don't register deleted functions with
6518         gdbarch.
6519
6520 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6521
6522         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6523         (bfin_unwind_pc): Delete.
6524         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6525
6526 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6527
6528         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6529         (arm_unwind_pc): Delete.
6530         (arm_unwind_sp): Delete.
6531         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6532
6533 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6534
6535         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6536         (arc_unwind_pc): Delete.
6537         (arc_unwind_sp): Delete.
6538         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6539
6540 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6541
6542         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6543         (alpha_unwind_pc): Delete.
6544         (alpha_gdbarch_init): Don't register deleted functions with
6545         gdbarch.
6546
6547 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6548
6549         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6550         (aarch64_unwind_pc): Delete.
6551         (aarch64_unwind_sp): Delete.
6552         (aarch64_gdbarch_init): Don't register deleted functions with
6553         gdbarch.
6554
6555 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6556
6557         * gdbtypes.c (type_align): Don't consider static members when
6558         computing structure alignment.
6559
6560 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6561
6562         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6563         return 0 for other types.
6564         * arch-utils.c (default_type_align): Always return 0.
6565         * gdbarch.h: Regenerate.
6566         * gdbarch.sh (type_align): Extend comment.
6567         * gdbtypes.c (type_align): Add additional comments, always call
6568         gdbarch_type_align before applying the default rules.
6569         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6570         generic code will then apply a suitable default.
6571         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6572         types, return 0 for other types.
6573
6574 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6575
6576         * NEWS: Create a new section for the next release branch.
6577         Rename the section of the current branch, now that it has
6578         been cut.
6579
6580 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6581
6582         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6583         * version.in: Bump version to 8.3.50.DATE-git.
6584
6585 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6586
6587         * aix-thread.c (ptid_cmp): Remove unused variable.
6588         (get_signaled_thread): Likewise.
6589         (store_regs_user_thread): Likewise.
6590         (store_regs_kernel_thread): Likewise.
6591         (fetch_regs_kernel_thread): Remove shadowed variable.
6592
6593 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6594
6595         * features/riscv/32bit-cpu.xml: Add register numbers.
6596         * features/riscv/32bit-fpu.c: Regenerate.
6597         * features/riscv/32bit-fpu.xml: Add register numbers.
6598         * features/riscv/64bit-cpu.xml: Add register numbers.
6599         * features/riscv/64bit-fpu.c: Regenerate.
6600         * features/riscv/64bit-fpu.xml: Add register numbers.
6601
6602 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6603
6604         * NEWS: Mention two argument form of gdb.Value constructor.
6605         * python/py-value.c (convert_buffer_and_type_to_value): New
6606         function.
6607         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6608         Add support for handling an optional second argument.  Call
6609         convert_buffer_and_type_to_value as appropriate.
6610         * python/python-internal.h (Py_buffer_deleter): New struct.
6611         (Py_buffer_up): New typedef.
6612
6613 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6614
6615         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6616         instead of releasing ownership.
6617
6618 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6619
6620         * dwarf2read.c (open_and_init_dwp_file): Call
6621         elf_numsections instead of bfd_count_sections to initialize
6622         dwp_file->num_sections.
6623
6624 2019-02-25  Tom Tromey  <tromey@adacore.com>
6625
6626         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6627
6628 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6629
6630         * gcore.in: Add '--readnever' option when invoking GDB.
6631
6632 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6633
6634         * MAINTAINERS: Update my email address.
6635
6636 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6637
6638         * build-id.c (build_id_to_debug_bfd_1): New function.
6639         (build_id_to_debug_bfd): Look for separate debug file in
6640         sysroot.
6641
6642 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6643
6644         * gdbarch.sh: Update the copyright year range that is placed into
6645         generated files.
6646
6647 2019-02-22  Keith Seitz  <keiths@redhat.com>
6648
6649         PR symtab/23853
6650         * linespec.c (create_sals_line_offset): Search for the default
6651         symtab's filename instead of its fullname.
6652
6653 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6654
6655         * NEWS: Update style defaults.
6656
6657 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6658
6659         * main.c (captured_main_1): Disable styling in batch mode.
6660
6661 2019-02-20  Tom Tromey  <tom@tromey.com>
6662
6663         * symtab.c (symtab_symbol_info): Fix typos.
6664
6665 2019-02-20  Tom Tromey  <tromey@adacore.com>
6666
6667         * findcmd.c (_initialize_mem_search): Use upper case for
6668         metasyntactic variables.
6669
6670 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6671
6672         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6673         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6674
6675 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6676
6677         * top.h (source_file_name): Change to std::string.
6678         * top.c (source_file_name): Likewise.
6679         (command_line_input): Adjust.
6680         * cli/cli-script.c (script_from_file): Adjust.
6681
6682 2019-02-19  Tom Tromey  <tromey@adacore.com>
6683
6684         * ravenscar-thread.c
6685         (ravenscar_thread_target::update_thread_list): Don't call
6686         ada_build_task_list.
6687         * ada-lang.h (ada_build_task_list): Don't declare.
6688         * ada-tasks.c (struct ada_tasks_inferior_data)
6689         <task_list_valid_p>: Now bool.
6690         (read_known_tasks, ada_task_list_changed)
6691         (ada_tasks_invalidate_inferior_data): Update.
6692         (read_known_tasks_array): Return bool.
6693         (read_known_tasks_list): Likewise.
6694         (read_known_tasks): Return void.
6695         (ada_build_task_list): Now static.
6696
6697 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6698
6699         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6700         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6701
6702 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6703
6704         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6705         variant for ada_tasks_pspace_data_handle and
6706         ada_tasks_inferior_data_handle.
6707         (ada_tasks_pspace_data_cleanup): New function.
6708         (ada_tasks_inferior_data_cleanup): New function.
6709
6710 2019-02-17  Tom Tromey  <tom@tromey.com>
6711
6712         * macrotab.h (macro_source_fullname): Return a std::string.
6713         * macrotab.c (macro_include, check_for_redefinition)
6714         (macro_undef, macro_lookup_definition, foreach_macro)
6715         (foreach_macro_in_scope): Update.
6716         (macro_source_fullname): Return a std::string.
6717         * macrocmd.c (show_pp_source_pos): Update.
6718
6719 2019-02-17  Tom Tromey  <tom@tromey.com>
6720
6721         * macrocmd.c (show_pp_source_pos): Style the file names.
6722
6723 2019-02-17  Tom Tromey  <tom@tromey.com>
6724
6725         PR tui/24197:
6726         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6727
6728 2019-02-17  Tom Tromey  <tom@tromey.com>
6729
6730         * ada-lang.c (user_select_syms): Use filtered printing.
6731         * utils.c (wrap_style): New global.
6732         (desired_style): Remove.
6733         (emit_style_escape): Add stream parameter.
6734         (set_output_style, reset_terminal_style, prompt_for_continue):
6735         Update.
6736         (flush_wrap_buffer): Only flush gdb_stdout.
6737         (wrap_here): Set wrap_style.
6738         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6739         treat escape sequences as a character.  Change when wrap buffer is
6740         flushed.
6741         (fputs_styled): Do not set the output style when the default is
6742         requested.
6743         * ui-style.h (struct ui_file_style) <is_default>: New method.
6744         * source.c (print_source_lines_base): Emit escape sequences in one
6745         piece.
6746
6747 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6748
6749         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6750         integers and enumeration types.
6751
6752 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6753
6754         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6755         instead of lookup_symbol_in_language
6756         (do_exact_match): New function.
6757         (ada_get_symbol_name_matcher): Return do_exact_match when
6758         doing a verbatim match.
6759
6760 2019-02-15  Tom Tromey  <tromey@adacore.com>
6761
6762         * ravenscar-thread.c (ravenscar_thread_target::resume)
6763         (ravenscar_thread_target::wait): Special case wildcard requests.
6764
6765 2019-02-15  Tom Tromey  <tromey@adacore.com>
6766
6767         * ravenscar-thread.c (base_ptid): Remove.
6768         (struct ravenscar_thread_target) <close>: New method.
6769         <m_base_ptid>: New member.
6770         <update_inferior_ptid, active_task, task_is_currently_active,
6771         runtime_initialized>: Declare methods.
6772         <ravenscar_thread_target>: Add constructor.
6773         (ravenscar_thread_target::task_is_currently_active)
6774         (ravenscar_thread_target::update_inferior_ptid)
6775         (ravenscar_runtime_initialized): Rename.  Now methods.
6776         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6777         (ravenscar_thread_target::update_thread_list): Update.
6778         (ravenscar_thread_target::active_task): Now method.
6779         (ravenscar_thread_target::store_registers)
6780         (ravenscar_thread_target::prepare_to_store)
6781         (ravenscar_thread_target::prepare_to_store)
6782         (ravenscar_thread_target::mourn_inferior): Update.
6783         (ravenscar_inferior_created): Use "new" to create target.
6784         (ravenscar_thread_target::get_ada_task_ptid): Update.
6785         (_initialize_ravenscar): Don't initialize base_ptid.
6786         (ravenscar_ops): Remove global.
6787
6788 2019-02-15  Tom Tromey  <tromey@adacore.com>
6789
6790         * target.h (push_target): Declare new overload.
6791         * target.c (push_target): New overload, taking an rvalue reference.
6792         * remote.c (remote_target::open_1): Use push_target overload.
6793         * corelow.c (core_target_open): Use push_target overload.
6794
6795 2019-02-15  Tom Tromey  <tromey@adacore.com>
6796
6797         * ravenscar-thread.c (is_ravenscar_task)
6798         (ravenscar_task_is_currently_active): Return bool.
6799         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6800         (_initialize_ravenscar): Remove "(void)".
6801         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6802         Return bool.
6803
6804 2019-02-15  Tom Tromey  <tromey@adacore.com>
6805
6806         * ravenscar-thread.c (ravenscar_runtime_initializer)
6807         (has_ravenscar_runtime, get_running_thread_id)
6808         (ravenscar_thread_target::resume): Fix indentation.
6809
6810 2019-02-15  Tom Tromey  <tromey@adacore.com>
6811
6812         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6813         from ravenscar_arch_ops.
6814         (sparc_ravenscar_ops::fetch_registers)
6815         (sparc_ravenscar_ops::store_registers): Now methods.
6816         (sparc_ravenscar_prepare_to_store): Remove.
6817         (sparc_ravenscar_ops): Redefine.
6818         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6819         methods and destructor.  Remove members.
6820         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6821         (ravenscar_thread_target::store_registers)
6822         (ravenscar_thread_target::prepare_to_store): Update.
6823         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6824         Remove.
6825         (struct ppc_ravenscar_powerpc_ops): Derive from
6826         ravenscar_arch_ops.
6827         (ppc_ravenscar_powerpc_ops::fetch_registers)
6828         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6829         (ppc_ravenscar_powerpc_ops): Redefine.
6830         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6831         (ppc_ravenscar_e500_ops::fetch_registers)
6832         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6833         (ppc_ravenscar_e500_ops): Redefine.
6834         * aarch64-ravenscar-thread.c
6835         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6836         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6837         (aarch64_ravenscar_fetch_registers)
6838         (aarch64_ravenscar_store_registers): Now methods.
6839         (aarch64_ravenscar_ops): Redefine.
6840
6841 2019-02-15  Tom Tromey  <tromey@adacore.com>
6842
6843         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6844         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6845         (ravenscar_thread_target::stopped_by_watchpoint)
6846         (ravenscar_thread_target::stopped_data_address)
6847         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6848
6849 2019-02-15  Tom Tromey  <tromey@adacore.com>
6850
6851         * ravenscar-thread.c: Fix some typos.
6852
6853 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6854             Tom Tromey  <tromey@adacore.com>
6855
6856         * ada-lang.c (ada_exception_sal): Change addr_string to a
6857         std::string.
6858         (create_ada_exception_catchpoint): Update.
6859
6860 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6861             Tom Tromey  <tromey@adacore.com>
6862
6863         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6864         (bp_location_ops): Remove.
6865         (base_breakpoint_allocate_location): Update.
6866         (free_bp_location): Update.
6867         * ada-lang.c (class ada_catchpoint_location)
6868         <ada_catchpoint_location>: Remove ops parameter.
6869         (ada_catchpoint_location_dtor): Remove.
6870         (ada_catchpoint_location_ops): Remove.
6871         (allocate_location_exception): Update.
6872         * breakpoint.h (struct bp_location_ops): Remove.
6873         (class bp_location) <bp_location>: Remove bp_location_ops
6874         parameter.
6875         <~bp_location>: Add destructor.
6876         <ops>: Remove.
6877
6878 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6879             Pedro Alves  <palves@redhat.com>
6880
6881         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6882         'PATH_MAX'.
6883
6884 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6885             Samuel Thibault  <samuel.thibault@gnu.org>
6886             Thomas Schwinge  <thomas@codesourcery.com>
6887
6888         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6889         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6890
6891 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6892
6893         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6894         (check_empty): Use "const char *".
6895
6896         * gnu-nat.c (gnu_nat_target::detach): Instead of
6897         'detach_inferior (pid)' call
6898         'detach_inferior (find_inferior_pid (pid))'.
6899
6900         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6901         'nat/fork-inferior.o'.
6902         * gnu-nat.c: #include "nat/fork-inferior.h".
6903
6904         * gnu-nat.c (gnu_nat_target::detach): Instead of
6905         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6906         * gnu-nat.h: #include "inf-child.h".
6907         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6908         'i386_gnu_nat_target::fetch_registers'.
6909         (gnu_store_registers): Rename/move to
6910         'i386_gnu_nat_target::store_registers'.
6911
6912         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6913         * gnu-nat.h (mach_thread_info): New function.
6914         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6915
6916         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6917
6918 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6919
6920         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6921
6922 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6923
6924         * windows-nat.c (windows_add_thread): Add new parameter
6925         "main_thread_p" with default value set to false.  Update
6926         function documentation as well as all callers.
6927         (windows_delete_thread): Likewise.
6928         (fake_create_process): Update call to windows_add_thread.
6929         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6930         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6931         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6932         call to windows_delete_thread.
6933
6934 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6935
6936         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6937
6938 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6939
6940         * symfile.c (find_separate_debug_file): Use canonical path of
6941         sysroot with child_path instead of gdb_sysroot if it is valid.
6942
6943 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6944
6945         * symfile.c (find_separate_debug_file): Use child_path to
6946         determine if an object file is under a sysroot.
6947
6948 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6949
6950         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6951         unittests/child-path-selftests.c.
6952         * common/pathstuff.c (child_path): New function.
6953         * common/pathstuff.h (child_path): New prototype.
6954         * unittests/child-path-selftests.c: New file.
6955
6956 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6957
6958         * symfile.c (find_separate_debug_file): Look for separate debug
6959         files in debug directories under the sysroot.
6960
6961 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6962
6963         * symtab.h (struct minimal_symbol data_p): New const method.
6964         (struct minimal_symbol text_p): Likewise.
6965         * symtab.c (output_source_filename): Use file name style
6966         to print file name.
6967         (print_symbol_info): Likewise.
6968         (print_msymbol_info): Use address style to print addresses.
6969         Use function name style to print executable text symbols.
6970         (expand_symtab_containing_pc): Use data_p.
6971         (find_pc_sect_compunit_symtab): Likewise.
6972
6973 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6974
6975         * breakpoint.c (describe_other_breakpoints): Use address style
6976         to print addresses.
6977         (say_where): Likewise.
6978
6979 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6980
6981         * ada-typeprint.c (print_func_type): Print function name
6982         style to print function name.
6983         * c-typeprint.c (c_print_type_1): Likewise.
6984
6985 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6986
6987         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6988         for execve.
6989
6990 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6991
6992         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6993         type_stack.
6994
6995 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6996
6997         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6998         TYPE_CODE_REF types.
6999
7000 2019-02-08  Jim Wilson  <jimw@sifive.com>
7001
7002         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7003         (riscv_linux_fregset): New.
7004         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7005
7006 2019-02-07  Tom Tromey  <tom@tromey.com>
7007
7008         * thread.c (thread_cancel_execution_command): Update.
7009         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7010         methods.
7011         (struct thread_fsm_ops): Remove.
7012         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7013         (thread_fsm_should_stop, thread_fsm_return_value)
7014         (thread_fsm_set_finished, thread_fsm_finished_p)
7015         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7016         Don't declare.
7017         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7018         * infrun.c (clear_proceed_status_thread)
7019         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7020         (print_stop_event): Update.
7021         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7022         Add constructor.
7023         (step_command_fsm_ops): Remove.
7024         (new_step_command_fsm): Remove.
7025         (step_1): Update.
7026         (step_command_fsm::should_stop): Rename from
7027         step_command_fsm_should_stop.
7028         (step_command_fsm::clean_up): Rename from
7029         step_command_fsm_clean_up.
7030         (step_command_fsm::do_async_reply_reason): Rename from
7031         step_command_fsm_async_reply_reason.
7032         (struct until_next_fsm): Inherit from thread_fsm.  Add
7033         constructor.
7034         (until_next_fsm_ops): Remove.
7035         (new_until_next_fsm): Remove.
7036         (until_next_fsm::should_stop): Rename from
7037         until_next_fsm_should_stop.
7038         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7039         (until_next_fsm::do_async_reply_reason): Rename from
7040         until_next_fsm_async_reply_reason.
7041         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7042         constructor.  Change type of breakpoint.
7043         (finish_command_fsm_ops): Remove.
7044         (new_finish_command_fsm): Remove.
7045         (finish_command_fsm::should_stop): Rename from
7046         finish_command_fsm_should_stop.
7047         (finish_command_fsm::clean_up): Rename from
7048         finish_command_fsm_clean_up.
7049         (finish_command_fsm::return_value): Rename from
7050         finish_command_fsm_return_value.
7051         (finish_command_fsm::do_async_reply_reason): Rename from
7052         finish_command_fsm_async_reply_reason.
7053         (finish_command): Update.
7054         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7055         Add constructor.
7056         (call_thread_fsm_ops): Remove.
7057         (call_thread_fsm::call_thread_fsm): Rename from
7058         new_call_thread_fsm.
7059         (call_thread_fsm::should_stop): Rename from
7060         call_thread_fsm_should_stop.
7061         (call_thread_fsm::should_notify_stop): Rename from
7062         call_thread_fsm_should_notify_stop.
7063         (run_inferior_call, call_function_by_hand_dummy): Update.
7064         * cli/cli-interp.c (should_print_stop_to_console): Update.
7065         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7066         Add constructor.  Change type of location_breakpoint,
7067         caller_breakpoint.
7068         (until_break_fsm_ops): Remove.
7069         (new_until_break_fsm): Remove.
7070         (until_break_fsm::should_stop): Rename from
7071         until_break_fsm_should_stop.
7072         (until_break_fsm::clean_up): Rename from
7073         until_break_fsm_clean_up.
7074         (until_break_fsm::do_async_reply_reason): Rename from
7075         until_break_fsm_async_reply_reason.
7076         (until_break_command): Update.
7077         * thread-fsm.c: Remove.
7078         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7079
7080 2019-02-07  Tom Tromey  <tom@tromey.com>
7081
7082         * yy-remap.h: Add include guard.
7083         * xtensa-tdep.h: Add include guard.
7084         * xcoffread.h: Rename include guard.
7085         * varobj-iter.h: Add include guard.
7086         * tui/tui.h: Rename include guard.
7087         * tui/tui-winsource.h: Rename include guard.
7088         * tui/tui-wingeneral.h: Rename include guard.
7089         * tui/tui-windata.h: Rename include guard.
7090         * tui/tui-win.h: Rename include guard.
7091         * tui/tui-stack.h: Rename include guard.
7092         * tui/tui-source.h: Rename include guard.
7093         * tui/tui-regs.h: Rename include guard.
7094         * tui/tui-out.h: Rename include guard.
7095         * tui/tui-layout.h: Rename include guard.
7096         * tui/tui-io.h: Rename include guard.
7097         * tui/tui-hooks.h: Rename include guard.
7098         * tui/tui-file.h: Rename include guard.
7099         * tui/tui-disasm.h: Rename include guard.
7100         * tui/tui-data.h: Rename include guard.
7101         * tui/tui-command.h: Rename include guard.
7102         * tic6x-tdep.h: Add include guard.
7103         * target/waitstatus.h: Rename include guard.
7104         * target/wait.h: Rename include guard.
7105         * target/target.h: Rename include guard.
7106         * target/resume.h: Rename include guard.
7107         * target-float.h: Rename include guard.
7108         * stabsread.h: Add include guard.
7109         * rs6000-tdep.h: Add include guard.
7110         * riscv-fbsd-tdep.h: Add include guard.
7111         * regformats/regdef.h: Rename include guard.
7112         * record.h: Rename include guard.
7113         * python/python.h: Rename include guard.
7114         * python/python-internal.h: Rename include guard.
7115         * python/py-stopevent.h: Rename include guard.
7116         * python/py-ref.h: Rename include guard.
7117         * python/py-record.h: Rename include guard.
7118         * python/py-record-full.h: Rename include guard.
7119         * python/py-record-btrace.h: Rename include guard.
7120         * python/py-instruction.h: Rename include guard.
7121         * python/py-events.h: Rename include guard.
7122         * python/py-event.h: Rename include guard.
7123         * procfs.h: Add include guard.
7124         * proc-utils.h: Add include guard.
7125         * p-lang.h: Add include guard.
7126         * or1k-tdep.h: Rename include guard.
7127         * observable.h: Rename include guard.
7128         * nto-tdep.h: Rename include guard.
7129         * nat/x86-linux.h: Rename include guard.
7130         * nat/x86-linux-dregs.h: Rename include guard.
7131         * nat/x86-gcc-cpuid.h: Add include guard.
7132         * nat/x86-dregs.h: Rename include guard.
7133         * nat/x86-cpuid.h: Rename include guard.
7134         * nat/ppc-linux.h: Rename include guard.
7135         * nat/mips-linux-watch.h: Rename include guard.
7136         * nat/linux-waitpid.h: Rename include guard.
7137         * nat/linux-ptrace.h: Rename include guard.
7138         * nat/linux-procfs.h: Rename include guard.
7139         * nat/linux-osdata.h: Rename include guard.
7140         * nat/linux-nat.h: Rename include guard.
7141         * nat/linux-namespaces.h: Rename include guard.
7142         * nat/linux-btrace.h: Rename include guard.
7143         * nat/glibc_thread_db.h: Rename include guard.
7144         * nat/gdb_thread_db.h: Rename include guard.
7145         * nat/gdb_ptrace.h: Rename include guard.
7146         * nat/fork-inferior.h: Rename include guard.
7147         * nat/amd64-linux-siginfo.h: Rename include guard.
7148         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7149         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7150         * nat/aarch64-linux.h: Rename include guard.
7151         * nat/aarch64-linux-hw-point.h: Rename include guard.
7152         * mn10300-tdep.h: Add include guard.
7153         * mips-linux-tdep.h: Add include guard.
7154         * mi/mi-parse.h: Rename include guard.
7155         * mi/mi-out.h: Rename include guard.
7156         * mi/mi-main.h: Rename include guard.
7157         * mi/mi-interp.h: Rename include guard.
7158         * mi/mi-getopt.h: Rename include guard.
7159         * mi/mi-console.h: Rename include guard.
7160         * mi/mi-common.h: Rename include guard.
7161         * mi/mi-cmds.h: Rename include guard.
7162         * mi/mi-cmd-break.h: Rename include guard.
7163         * m2-lang.h: Add include guard.
7164         * location.h: Rename include guard.
7165         * linux-record.h: Rename include guard.
7166         * linux-nat.h: Add include guard.
7167         * linux-fork.h: Add include guard.
7168         * i386-darwin-tdep.h: Rename include guard.
7169         * hppa-linux-offsets.h: Add include guard.
7170         * guile/guile.h: Rename include guard.
7171         * guile/guile-internal.h: Rename include guard.
7172         * gnu-nat.h: Rename include guard.
7173         * gdb-stabs.h: Rename include guard.
7174         * frv-tdep.h: Add include guard.
7175         * f-lang.h: Add include guard.
7176         * event-loop.h: Add include guard.
7177         * darwin-nat.h: Rename include guard.
7178         * cp-abi.h: Rename include guard.
7179         * config/sparc/nm-sol2.h: Rename include guard.
7180         * config/nm-nto.h: Rename include guard.
7181         * config/nm-linux.h: Add include guard.
7182         * config/i386/nm-i386gnu.h: Rename include guard.
7183         * config/djgpp/nl_types.h: Rename include guard.
7184         * config/djgpp/langinfo.h: Rename include guard.
7185         * compile/gcc-cp-plugin.h: Add include guard.
7186         * compile/gcc-c-plugin.h: Add include guard.
7187         * compile/compile.h: Rename include guard.
7188         * compile/compile-object-run.h: Rename include guard.
7189         * compile/compile-object-load.h: Rename include guard.
7190         * compile/compile-internal.h: Rename include guard.
7191         * compile/compile-cplus.h: Rename include guard.
7192         * compile/compile-c.h: Rename include guard.
7193         * common/xml-utils.h: Rename include guard.
7194         * common/x86-xstate.h: Rename include guard.
7195         * common/version.h: Rename include guard.
7196         * common/vec.h: Rename include guard.
7197         * common/tdesc.h: Rename include guard.
7198         * common/selftest.h: Rename include guard.
7199         * common/scoped_restore.h: Rename include guard.
7200         * common/scoped_mmap.h: Rename include guard.
7201         * common/scoped_fd.h: Rename include guard.
7202         * common/safe-iterator.h: Rename include guard.
7203         * common/run-time-clock.h: Rename include guard.
7204         * common/refcounted-object.h: Rename include guard.
7205         * common/queue.h: Rename include guard.
7206         * common/ptid.h: Rename include guard.
7207         * common/print-utils.h: Rename include guard.
7208         * common/preprocessor.h: Rename include guard.
7209         * common/pathstuff.h: Rename include guard.
7210         * common/observable.h: Rename include guard.
7211         * common/netstuff.h: Rename include guard.
7212         * common/job-control.h: Rename include guard.
7213         * common/host-defs.h: Rename include guard.
7214         * common/gdb_wait.h: Rename include guard.
7215         * common/gdb_vecs.h: Rename include guard.
7216         * common/gdb_unlinker.h: Rename include guard.
7217         * common/gdb_unique_ptr.h: Rename include guard.
7218         * common/gdb_tilde_expand.h: Rename include guard.
7219         * common/gdb_sys_time.h: Rename include guard.
7220         * common/gdb_string_view.h: Rename include guard.
7221         * common/gdb_splay_tree.h: Rename include guard.
7222         * common/gdb_setjmp.h: Rename include guard.
7223         * common/gdb_ref_ptr.h: Rename include guard.
7224         * common/gdb_optional.h: Rename include guard.
7225         * common/gdb_locale.h: Rename include guard.
7226         * common/gdb_assert.h: Rename include guard.
7227         * common/filtered-iterator.h: Rename include guard.
7228         * common/filestuff.h: Rename include guard.
7229         * common/fileio.h: Rename include guard.
7230         * common/environ.h: Rename include guard.
7231         * common/common-utils.h: Rename include guard.
7232         * common/common-types.h: Rename include guard.
7233         * common/common-regcache.h: Rename include guard.
7234         * common/common-inferior.h: Rename include guard.
7235         * common/common-gdbthread.h: Rename include guard.
7236         * common/common-exceptions.h: Rename include guard.
7237         * common/common-defs.h: Rename include guard.
7238         * common/common-debug.h: Rename include guard.
7239         * common/cleanups.h: Rename include guard.
7240         * common/buffer.h: Rename include guard.
7241         * common/btrace-common.h: Rename include guard.
7242         * common/break-common.h: Rename include guard.
7243         * cli/cli-utils.h: Rename include guard.
7244         * cli/cli-style.h: Rename include guard.
7245         * cli/cli-setshow.h: Rename include guard.
7246         * cli/cli-script.h: Rename include guard.
7247         * cli/cli-interp.h: Rename include guard.
7248         * cli/cli-decode.h: Rename include guard.
7249         * cli/cli-cmds.h: Rename include guard.
7250         * charset-list.h: Add include guard.
7251         * buildsym-legacy.h: Rename include guard.
7252         * bfin-tdep.h: Add include guard.
7253         * ax.h: Rename include guard.
7254         * arm-linux-tdep.h: Add include guard.
7255         * arm-fbsd-tdep.h: Add include guard.
7256         * arch/xtensa.h: Rename include guard.
7257         * arch/tic6x.h: Add include guard.
7258         * arch/i386.h: Add include guard.
7259         * arch/arm.h: Rename include guard.
7260         * arch/arm-linux.h: Rename include guard.
7261         * arch/arm-get-next-pcs.h: Rename include guard.
7262         * arch/amd64.h: Add include guard.
7263         * arch/aarch64-insn.h: Rename include guard.
7264         * arch-utils.h: Rename include guard.
7265         * annotate.h: Add include guard.
7266         * amd64-darwin-tdep.h: Rename include guard.
7267         * aarch64-linux-tdep.h: Add include guard.
7268         * aarch64-fbsd-tdep.h: Add include guard.
7269         * aarch32-linux-nat.h: Add include guard.
7270
7271 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7272
7273         * macrotab.c (macro_define_internal): New function that
7274         factorizes macro_define_object_internal and macro_define_function
7275         code.
7276         (macro_define_object_internal): Use macro_define_internal.
7277         (macro_define_function): Likewise.
7278
7279 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7280
7281         * macrocmd.c (extract_identifier): Return
7282         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7283         callers.
7284
7285 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7286
7287         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7288
7289 2019-02-05  Tom Tromey  <tom@tromey.com>
7290
7291         * target.c (target_stack::unpush): Move assertion earlier.
7292
7293 2019-01-30  Tom Tromey  <tom@tromey.com>
7294
7295         PR python/23615:
7296         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7297         (gdbpy_parse_and_eval): Likewise.
7298         * python/python-internal.h (gdbpy_allow_threads): New class.
7299
7300 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7301
7302         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7303         (aarch64_fbsd_fpregmap): Move earlier.
7304         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7305         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7306         instead of individual calls to trad_frame_set_reg_addr.
7307         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7308         earlier.
7309         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7310         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7311         instead of individual calls to trad_frame_set_reg_addr.
7312
7313 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7314
7315         * CONTRIBUTE: Replace contribution list with wiki link.
7316
7317 2019-01-25  Tom Tromey  <tom@tromey.com>
7318
7319         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7320
7321 2019-01-25  Tom Tromey  <tom@tromey.com>
7322
7323         * xtensa-linux-nat.c: Fix common/ includes.
7324         * xml-support.h: Fix common/ includes.
7325         * xml-support.c: Fix common/ includes.
7326         * x86-linux-nat.c: Fix common/ includes.
7327         * windows-nat.c: Fix common/ includes.
7328         * varobj.h: Fix common/ includes.
7329         * varobj.c: Fix common/ includes.
7330         * value.c: Fix common/ includes.
7331         * valops.c: Fix common/ includes.
7332         * utils.c: Fix common/ includes.
7333         * unittests/xml-utils-selftests.c: Fix common/ includes.
7334         * unittests/utils-selftests.c: Fix common/ includes.
7335         * unittests/unpack-selftests.c: Fix common/ includes.
7336         * unittests/tracepoint-selftests.c: Fix common/ includes.
7337         * unittests/style-selftests.c: Fix common/ includes.
7338         * unittests/string_view-selftests.c: Fix common/ includes.
7339         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7340         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7341         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7342         * unittests/rsp-low-selftests.c: Fix common/ includes.
7343         * unittests/parse-connection-spec-selftests.c: Fix common/
7344         includes.
7345         * unittests/optional-selftests.c: Fix common/ includes.
7346         * unittests/offset-type-selftests.c: Fix common/ includes.
7347         * unittests/observable-selftests.c: Fix common/ includes.
7348         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7349         * unittests/memrange-selftests.c: Fix common/ includes.
7350         * unittests/memory-map-selftests.c: Fix common/ includes.
7351         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7352         * unittests/function-view-selftests.c: Fix common/ includes.
7353         * unittests/environ-selftests.c: Fix common/ includes.
7354         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7355         * unittests/common-utils-selftests.c: Fix common/ includes.
7356         * unittests/cli-utils-selftests.c: Fix common/ includes.
7357         * unittests/array-view-selftests.c: Fix common/ includes.
7358         * ui-file.c: Fix common/ includes.
7359         * tui/tui-io.c: Fix common/ includes.
7360         * tracepoint.h: Fix common/ includes.
7361         * tracepoint.c: Fix common/ includes.
7362         * tracefile-tfile.c: Fix common/ includes.
7363         * top.h: Fix common/ includes.
7364         * top.c: Fix common/ includes.
7365         * thread.c: Fix common/ includes.
7366         * target/waitstatus.h: Fix common/ includes.
7367         * target/waitstatus.c: Fix common/ includes.
7368         * target.h: Fix common/ includes.
7369         * target.c: Fix common/ includes.
7370         * target-memory.c: Fix common/ includes.
7371         * target-descriptions.c: Fix common/ includes.
7372         * symtab.h: Fix common/ includes.
7373         * symfile.c: Fix common/ includes.
7374         * stap-probe.c: Fix common/ includes.
7375         * spu-linux-nat.c: Fix common/ includes.
7376         * sparc-nat.c: Fix common/ includes.
7377         * source.c: Fix common/ includes.
7378         * solib.c: Fix common/ includes.
7379         * solib-target.c: Fix common/ includes.
7380         * ser-unix.c: Fix common/ includes.
7381         * ser-tcp.c: Fix common/ includes.
7382         * ser-pipe.c: Fix common/ includes.
7383         * ser-base.c: Fix common/ includes.
7384         * selftest-arch.c: Fix common/ includes.
7385         * s12z-tdep.c: Fix common/ includes.
7386         * rust-exp.y: Fix common/ includes.
7387         * rs6000-aix-tdep.c: Fix common/ includes.
7388         * riscv-tdep.c: Fix common/ includes.
7389         * remote.c: Fix common/ includes.
7390         * remote-notif.h: Fix common/ includes.
7391         * remote-fileio.h: Fix common/ includes.
7392         * remote-fileio.c: Fix common/ includes.
7393         * regcache.h: Fix common/ includes.
7394         * regcache.c: Fix common/ includes.
7395         * record-btrace.c: Fix common/ includes.
7396         * python/python.c: Fix common/ includes.
7397         * python/py-type.c: Fix common/ includes.
7398         * python/py-inferior.c: Fix common/ includes.
7399         * progspace.h: Fix common/ includes.
7400         * producer.c: Fix common/ includes.
7401         * procfs.c: Fix common/ includes.
7402         * proc-api.c: Fix common/ includes.
7403         * printcmd.c: Fix common/ includes.
7404         * ppc-linux-nat.c: Fix common/ includes.
7405         * parser-defs.h: Fix common/ includes.
7406         * osdata.c: Fix common/ includes.
7407         * obsd-nat.c: Fix common/ includes.
7408         * nat/x86-linux.c: Fix common/ includes.
7409         * nat/x86-linux-dregs.c: Fix common/ includes.
7410         * nat/x86-dregs.h: Fix common/ includes.
7411         * nat/x86-dregs.c: Fix common/ includes.
7412         * nat/ppc-linux.c: Fix common/ includes.
7413         * nat/mips-linux-watch.h: Fix common/ includes.
7414         * nat/mips-linux-watch.c: Fix common/ includes.
7415         * nat/linux-waitpid.c: Fix common/ includes.
7416         * nat/linux-ptrace.h: Fix common/ includes.
7417         * nat/linux-ptrace.c: Fix common/ includes.
7418         * nat/linux-procfs.c: Fix common/ includes.
7419         * nat/linux-personality.c: Fix common/ includes.
7420         * nat/linux-osdata.c: Fix common/ includes.
7421         * nat/linux-namespaces.c: Fix common/ includes.
7422         * nat/linux-btrace.h: Fix common/ includes.
7423         * nat/linux-btrace.c: Fix common/ includes.
7424         * nat/fork-inferior.c: Fix common/ includes.
7425         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7426         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7427         * nat/aarch64-linux.c: Fix common/ includes.
7428         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7429         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7430         * namespace.h: Fix common/ includes.
7431         * mips-linux-tdep.c: Fix common/ includes.
7432         * minsyms.c: Fix common/ includes.
7433         * mi/mi-parse.h: Fix common/ includes.
7434         * mi/mi-main.c: Fix common/ includes.
7435         * mi/mi-cmd-env.c: Fix common/ includes.
7436         * memrange.h: Fix common/ includes.
7437         * memattr.c: Fix common/ includes.
7438         * maint.h: Fix common/ includes.
7439         * maint.c: Fix common/ includes.
7440         * main.c: Fix common/ includes.
7441         * machoread.c: Fix common/ includes.
7442         * location.c: Fix common/ includes.
7443         * linux-thread-db.c: Fix common/ includes.
7444         * linux-nat.c: Fix common/ includes.
7445         * linux-fork.c: Fix common/ includes.
7446         * inline-frame.c: Fix common/ includes.
7447         * infrun.c: Fix common/ includes.
7448         * inflow.c: Fix common/ includes.
7449         * inferior.h: Fix common/ includes.
7450         * inferior.c: Fix common/ includes.
7451         * infcmd.c: Fix common/ includes.
7452         * inf-ptrace.c: Fix common/ includes.
7453         * inf-child.c: Fix common/ includes.
7454         * ia64-linux-nat.c: Fix common/ includes.
7455         * i387-tdep.c: Fix common/ includes.
7456         * i386-tdep.c: Fix common/ includes.
7457         * i386-linux-tdep.c: Fix common/ includes.
7458         * i386-linux-nat.c: Fix common/ includes.
7459         * i386-go32-tdep.c: Fix common/ includes.
7460         * i386-fbsd-tdep.c: Fix common/ includes.
7461         * i386-fbsd-nat.c: Fix common/ includes.
7462         * guile/scm-type.c: Fix common/ includes.
7463         * guile/guile.c: Fix common/ includes.
7464         * go32-nat.c: Fix common/ includes.
7465         * gnu-nat.c: Fix common/ includes.
7466         * gdbthread.h: Fix common/ includes.
7467         * gdbarch-selftests.c: Fix common/ includes.
7468         * gdb_usleep.c: Fix common/ includes.
7469         * gdb_select.h: Fix common/ includes.
7470         * gdb_bfd.c: Fix common/ includes.
7471         * gcore.c: Fix common/ includes.
7472         * fork-child.c: Fix common/ includes.
7473         * findvar.c: Fix common/ includes.
7474         * fbsd-nat.c: Fix common/ includes.
7475         * event-top.c: Fix common/ includes.
7476         * event-loop.c: Fix common/ includes.
7477         * dwarf2read.c: Fix common/ includes.
7478         * dwarf2loc.c: Fix common/ includes.
7479         * dwarf2-frame.c: Fix common/ includes.
7480         * dwarf-index-cache.c: Fix common/ includes.
7481         * dtrace-probe.c: Fix common/ includes.
7482         * disasm-selftests.c: Fix common/ includes.
7483         * defs.h: Fix common/ includes.
7484         * csky-tdep.c: Fix common/ includes.
7485         * cp-valprint.c: Fix common/ includes.
7486         * cp-support.h: Fix common/ includes.
7487         * cp-support.c: Fix common/ includes.
7488         * corelow.c: Fix common/ includes.
7489         * completer.h: Fix common/ includes.
7490         * completer.c: Fix common/ includes.
7491         * compile/compile.c: Fix common/ includes.
7492         * compile/compile-loc2c.c: Fix common/ includes.
7493         * compile/compile-cplus-types.c: Fix common/ includes.
7494         * compile/compile-cplus-symbols.c: Fix common/ includes.
7495         * command.h: Fix common/ includes.
7496         * cli/cli-dump.c: Fix common/ includes.
7497         * cli/cli-cmds.c: Fix common/ includes.
7498         * charset.c: Fix common/ includes.
7499         * build-id.c: Fix common/ includes.
7500         * btrace.h: Fix common/ includes.
7501         * btrace.c: Fix common/ includes.
7502         * breakpoint.h: Fix common/ includes.
7503         * breakpoint.c: Fix common/ includes.
7504         * ax.h:
7505         (enum agent_op): Fix common/ includes.
7506         * ax-general.c (struct aop_map): Fix common/ includes.
7507         * ax-gdb.c: Fix common/ includes.
7508         * auxv.c: Fix common/ includes.
7509         * auto-load.c: Fix common/ includes.
7510         * arm-tdep.c: Fix common/ includes.
7511         * arch/riscv.c: Fix common/ includes.
7512         * arch/ppc-linux-common.c: Fix common/ includes.
7513         * arch/i386.c: Fix common/ includes.
7514         * arch/arm.c: Fix common/ includes.
7515         * arch/arm-linux.c: Fix common/ includes.
7516         * arch/arm-get-next-pcs.c: Fix common/ includes.
7517         * arch/amd64.c: Fix common/ includes.
7518         * arch/aarch64.c: Fix common/ includes.
7519         * arch/aarch64-insn.c: Fix common/ includes.
7520         * arch-utils.c: Fix common/ includes.
7521         * amd64-windows-tdep.c: Fix common/ includes.
7522         * amd64-tdep.c: Fix common/ includes.
7523         * amd64-sol2-tdep.c: Fix common/ includes.
7524         * amd64-obsd-tdep.c: Fix common/ includes.
7525         * amd64-nbsd-tdep.c: Fix common/ includes.
7526         * amd64-linux-tdep.c: Fix common/ includes.
7527         * amd64-linux-nat.c: Fix common/ includes.
7528         * amd64-fbsd-tdep.c: Fix common/ includes.
7529         * amd64-fbsd-nat.c: Fix common/ includes.
7530         * amd64-dicos-tdep.c: Fix common/ includes.
7531         * amd64-darwin-tdep.c: Fix common/ includes.
7532         * agent.c: Fix common/ includes.
7533         * ada-lang.h: Fix common/ includes.
7534         * ada-lang.c: Fix common/ includes.
7535         * aarch64-tdep.c: Fix common/ includes.
7536
7537 2019-01-25  Tom Tromey  <tom@tromey.com>
7538
7539         * common/create-version.sh: Use common/version.h.
7540
7541 2019-01-24  Pedro Alves  <palves@redhat.com>
7542
7543         * infrun.c (signal_stop, signal_print, signal_program)
7544         (signal_catch, signal_pass): Now arrays instead of pointers.
7545         (update_signals_program_target, do_target_resume)
7546         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7547         * linux-nat.c (linux_nat_target::pass_signals)
7548         (linux_nat_target::create_inferior, linux_nat_target::attach):
7549         Adjust.
7550         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7551         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7552         * procfs.c (procfs_target::pass_signals): Adjust.
7553         * record-full.c (record_full_target::resume): Adjust.
7554         * remote.c (remote_target::pass_signals)
7555         (remote_target::program_signals): Adjust.
7556         * target-debug.h (target_debug_print_signals): Now takes a
7557         gdb::array_view as parameter.  Adjust.
7558         * target.h (target_ops) <pass_signals, program_signals>: Replace
7559         pointer and length parameters with gdb::array_view.
7560         (target_pass_signals, target_program_signals): Likewise.
7561         * target-delegates.c: Regenerate.
7562
7563 2019-01-24  Pedro Alves  <palves@redhat.com>
7564
7565         * common/forward-scope-exit.h
7566         (forward_scope_exit::forward_scope_exit): Pass arguments to
7567         m_bind_function directly, instead of creating a std::bind and
7568         copying that.
7569
7570 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7571
7572         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7573         for static members.
7574         (pass_in_v_vfp_candidate): Likewise.
7575
7576 2019-01-23  Tom Tromey  <tom@tromey.com>
7577             Pedro Alves  <palves@redhat.com>
7578
7579         * regcache.c (class regcache_invalidator): Remove.
7580         (regcache::raw_write): Use make_scope_exit.
7581
7582 2019-01-23  Tom Tromey  <tom@tromey.com>
7583
7584         * ui-out.h (class ui_out_emit_type): Update comment.
7585
7586 2019-01-23  Tom Tromey  <tom@tromey.com>
7587
7588         * infrun.c (fetch_inferior_event): Update comment.
7589
7590 2019-01-23  Tom Tromey  <tom@tromey.com>
7591             Pedro Alves  <palves@redhat.com>
7592
7593         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7594         parameter.
7595         (fetch_inferior_event): Use SCOPE_EXIT.
7596
7597
7598 2019-01-23  Tom Tromey  <tom@tromey.com>
7599             Pedro Alves  <palves@redhat.com>
7600
7601         * infrun.c (disable_thread_events): Delete.
7602         (stop_all_threads): Use SCOPE_EXIT.
7603
7604 2019-01-23  Tom Tromey  <tom@tromey.com>
7605             Pedro Alves  <palves@redhat.com>
7606
7607         * symfile.c: Include forward-scope-exit.h.
7608         (clear_symtab_users_cleanup): Replace forward declaration with
7609         a FORWARD_SCOPE_EXIT.
7610         (syms_from_objfile_1): Use the forward_scope_exit and
7611         gdb::optional instead of cleanup_function.
7612         (reread_symbols): Use the forward_scope_exit instead of
7613         cleanup_function.
7614         (clear_symtab_users_cleanup): Remove function.
7615
7616 2019-01-23  Tom Tromey  <tom@tromey.com>
7617             Pedro Alves  <palves@redhat.com>
7618
7619         * linux-nat.c: Include scope-exit.h.
7620         (cleanup_target_stop): Remove.
7621         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7622         SCOPE_EXIT.
7623
7624 2019-01-23  Tom Tromey  <tom@tromey.com>
7625             Pedro Alves  <palves@redhat.com>
7626
7627         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7628         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7629
7630 2019-01-23  Tom Tromey  <tom@tromey.com>
7631             Andrew Burgess  <andrew.burgess@embecosm.com>
7632             Pedro Alves  <palves@redhat.com>
7633
7634         * infrun.c (fetch_inferior_event): Use scope_exit.
7635         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7636         * top.c (execute_command): Use scope_exit.
7637         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7638         * utils.c (do_bpstat_clear_actions_cleanup)
7639         (make_bpstat_clear_actions_cleanup): Remove.
7640
7641 2019-01-23  Tom Tromey  <tom@tromey.com>
7642             Pedro Alves  <palves@redhat.com>
7643
7644         * infrun.c: Include "common/scope-exit.h"
7645         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7646         (wait_for_inferior): Use SCOPE_EXIT.
7647         (fetch_inferior_event): Use scope_exit.
7648
7649 2019-01-23  Tom Tromey  <tom@tromey.com>
7650             Pedro Alves  <palves@redhat.com>
7651
7652         * breakpoint.c (create_breakpoint): Remove cleanup.
7653
7654 2019-01-23  Tom Tromey  <tom@tromey.com>
7655             Andrew Burgess  <andrew.burgess@embecosm.com>
7656             Pedro Alves  <palves@redhat.com>
7657
7658 2019-01-23  Pedro Alves  <palves@redhat.com>
7659
7660         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7661
7662 2019-01-23  Pedro Alves  <palves@redhat.com>
7663             Andrew Burgess  <andrew.burgess@embecosm.com>
7664
7665         * gdbthread.h: Include "common/forward-scope-exit.h".
7666         (scoped_finish_thread_state): Redefine custom class in terms of
7667         forward_scope_exit.
7668
7669 2019-01-23  Pedro Alves  <palves@redhat.com>
7670             Andrew Burgess  <andrew.burgess@embecosm.com>
7671
7672         * common/forward-scope-exit.h: New file.
7673
7674 2019-01-23  Pedro Alves  <palves@redhat.com>
7675             Andrew Burgess  <andrew.burgess@embecosm.com>
7676             Tom Tromey  <tom@tromey.com>
7677
7678         * common/scope-exit.h: New file.
7679
7680 2019-01-23  Pedro Alves  <palves@redhat.com>
7681
7682         * common/preprocessor.h (ESC): Rename to ...
7683         (ESC_PARENS): ... this.
7684         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7685         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7686
7687 2019-01-23  Tom Tromey  <tom@tromey.com>
7688
7689         * language.h (class scoped_switch_to_sym_language_if_auto):
7690         Initialize m_lang in both cases.
7691
7692 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7693
7694         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7695         with XCNEW.
7696
7697 2019-01-22  Tom Tromey  <tom@tromey.com>
7698
7699         * corelow.c: Do not include sys/file.h.
7700
7701 2019-01-22  Tom Tromey  <tom@tromey.com>
7702
7703         * tui/tui-wingeneral.h: Include gdb_curses.h.
7704
7705 2019-01-22  Tom Tromey  <tom@tromey.com>
7706
7707         * source-cache.h (class source_cache) <get_source_lines,
7708         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7709
7710 2019-01-22  Tom Tromey  <tom@tromey.com>
7711
7712         * remote-fileio.h (struct remote_target): Declare.
7713
7714 2019-01-22  Tom Tromey  <tom@tromey.com>
7715
7716         * python/py-arch.c: Do not include py-ref.h.
7717         * python/py-bpevent.c: Do not include py-ref.h.
7718         * python/py-cmd.c: Do not include py-ref.h.
7719         * python/py-continueevent.c: Do not include py-ref.h.
7720         * python/py-event.h: Do not include py-ref.h.
7721         * python/py-evtregistry.c: Do not include py-ref.h.
7722         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7723         * python/py-frame.c: Do not include py-ref.h.
7724         * python/py-framefilter.c: Do not include py-ref.h.
7725         * python/py-function.c: Do not include py-ref.h.
7726         * python/py-infevents.c: Do not include py-ref.h.
7727         * python/py-linetable.c: Do not include py-ref.h.
7728         * python/py-objfile.c: Do not include py-ref.h.
7729         * python/py-param.c: Do not include py-ref.h.
7730         * python/py-prettyprint.c: Do not include py-ref.h.
7731         * python/py-progspace.c: Do not include py-ref.h.
7732         * python/py-symbol.c: Do not include py-ref.h.
7733         * python/py-symtab.c: Do not include py-ref.h.
7734         * python/py-type.c: Do not include py-ref.h.
7735         * python/py-unwind.c: Do not include py-ref.h.
7736         * python/py-utils.c: Do not include py-ref.h.
7737         * python/py-value.c: Do not include py-ref.h.
7738         * python/py-varobj.c: Do not include py-ref.h.
7739         * python/py-xmethods.c: Do not include py-ref.h.
7740         * python/python.c: Do not include py-ref.h.
7741         * varobj.c: Do not include py-ref.h.
7742
7743 2019-01-22  Tom Tromey  <tom@tromey.com>
7744
7745         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7746         keyword for bcache.
7747
7748 2019-01-22  Tom Tromey  <tom@tromey.com>
7749
7750         * compile/compile-cplus-types.c: Remove a comment by #include.
7751
7752 2019-01-22  Tom Tromey  <tom@tromey.com>
7753
7754         * compile/gcc-c-plugin.h: Include compile-internal.h.
7755
7756 2019-01-22  Tom Tromey  <tom@tromey.com>
7757
7758         * stabsread.c (EXTERN): Do not define.
7759         (symnum, next_symbol_text_func, processing_gcc_compilation)
7760         (within_function, global_sym_chain, global_stabs)
7761         (previous_stab_code, this_object_header_files)
7762         (n_this_object_header_files)
7763         (n_allocated_this_object_header_files): Define.
7764         * stabsread.h (EXTERN): Never define.  Use "extern".
7765
7766 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7767
7768         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7769         history_value.
7770
7771 2019-01-21  Tom Tromey  <tom@tromey.com>
7772
7773         * ui-out.c: Fix includes.
7774         * tui/tui-source.c: Fix includes.
7775         * target.c: Fix includes.
7776         * remote.c: Fix includes.
7777         * regcache.c: Fix includes.
7778         * python/py-block.c: Fix includes.
7779         * printcmd.c: Fix includes.
7780         * or1k-tdep.c: Fix includes.
7781         * mi/mi-main.c: Fix includes.
7782         * m32r-tdep.c: Fix includes.
7783         * csky-tdep.c: Fix includes.
7784         * compile/compile-cplus-types.c: Fix includes.
7785         * cli/cli-interp.c: Fix includes.
7786
7787 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7788
7789         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7790         for padding.
7791
7792 2019-01-16  Tom Tromey  <tom@tromey.com>
7793
7794         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7795         earlier.
7796         (struct objfile) <msymbols_range>: Move from top level.
7797         <msymbols>: New method.
7798         (class objfile_msymbols): Remove.
7799         * symtab.c (default_collect_symbol_completion_matches_break_on):
7800         Update.
7801         * symmisc.c (dump_msymbols): Update.
7802         * stabsread.c (scan_file_globals): Update.
7803         * objc-lang.c (info_selectors_command, info_classes_command)
7804         (find_methods): Update.
7805         * minsyms.c (find_solib_trampoline_target): Update.
7806         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7807         * coffread.c (coff_symfile_read): Update.
7808         * ada-lang.c (ada_lookup_simple_minsym)
7809         (ada_collect_symbol_completion_matches): Update.
7810
7811 2019-01-16  Tom Tromey  <tom@tromey.com>
7812
7813         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7814         type.  Remove no-argument constructor.
7815         <iterator::operator++>: Simplify.
7816         <begin>: Update.
7817         <end>: Use minimal_symbol_count.
7818
7819 2019-01-16  Tom Tromey  <tom@tromey.com>
7820
7821         * objfiles.h (struct objfile) <psymtabs>: New method.
7822         (class objfile_psymtabs): Remove.
7823         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7824         typedef.
7825         <range>: New method.
7826         (require_partial_symbols): Change return type.
7827         * psymtab.c (require_partial_symbols)
7828         (psym_expand_symtabs_matching): Update.
7829         * mdebugread.c (parse_partial_symbols): Update.
7830         * dbxread.c (dbx_end_psymtab): Update.
7831
7832 2019-01-15  Tom Tromey  <tom@tromey.com>
7833
7834         * symtab.c (lookup_objfile_from_block)
7835         (lookup_symbol_in_objfile_symtabs)
7836         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7837         (find_line_symtab, info_sources_command)
7838         (default_collect_symbol_completion_matches_break_on)
7839         (make_source_files_completion_list): Update.
7840         * symmisc.c (print_objfile_statistics, dump_objfile)
7841         (maintenance_print_symbols, maintenance_info_symtabs)
7842         (maintenance_check_symtabs, maintenance_info_line_tables):
7843         Update.
7844         * source.c (select_source_symtab)
7845         (forget_cached_source_info_for_objfile): Update.
7846         * objfiles.h (class objfile_compunits): Remove.
7847         (struct objfile) <compunits_range>: New typedef.
7848         (compunits): New method.
7849         * objfiles.c (objfile_relocate1): Update.
7850         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7851         * maint.c (count_symtabs_and_blocks): Update.
7852         * linespec.c (iterate_over_all_matching_symtabs): Update.
7853         * cp-support.c (add_symbol_overload_list_qualified): Update.
7854         * coffread.c (coff_symtab_read): Update.
7855         * ada-lang.c (add_nonlocal_symbols)
7856         (ada_collect_symbol_completion_matches)
7857         (ada_add_global_exceptions): Update.
7858
7859 2019-01-15  Tom Tromey  <tom@tromey.com>
7860
7861         * progspace.h (program_space) <objfiles_safe_range>: New
7862         typedef.
7863         <objfiles_safe>: New method.
7864         * objfiles.h (class all_objfiles_safe): Remove.
7865         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7866         * jit.c (jit_inferior_exit_hook): Update.
7867
7868 2019-01-17  Tom Tromey  <tom@tromey.com>
7869
7870         * progspace.h (program_space) <objfiles_range>: New typedef.
7871         <objfiles>: New method.
7872         <objfiles_head>: Rename from objfiles.
7873         (object_files): Update.
7874         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7875         * guile/scm-pretty-print.c
7876         (ppscm_find_pretty_printer_from_objfiles): Update.
7877         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7878         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7879         Update.
7880         * python/py-progspace.c (pspy_get_objfiles): Update.
7881         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7882         Update.
7883         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7884         (objfpy_lookup_objfile_by_build_id): Update.
7885         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7886         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7887         Update.
7888         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7889         (expand_symtab_containing_pc, lookup_objfile_from_block)
7890         (lookup_static_symbol, basic_lookup_transparent_type)
7891         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7892         (find_line_symtab, info_sources_command)
7893         (default_collect_symbol_completion_matches_break_on)
7894         (make_source_files_completion_list, find_main_name): Update.
7895         * symmisc.c (print_symbol_bcache_statistics)
7896         (print_objfile_statistics, maintenance_print_symbols)
7897         (maintenance_print_msymbols, maintenance_print_objfiles)
7898         (maintenance_info_symtabs, maintenance_check_symtabs)
7899         (maintenance_expand_symtabs, maintenance_info_line_tables):
7900         Update.
7901         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7902         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7903         (map_overlay_command, unmap_overlay_command)
7904         (simple_overlay_update, expand_symtabs_matching)
7905         (map_symbol_filenames): Update.
7906         * symfile-debug.c (set_debug_symfile): Update.
7907         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7908         Update.
7909         * source.c (select_source_symtab, forget_cached_source_info):
7910         Update.
7911         * solib.c (solib_read_symbols): Update.
7912         * solib-spu.c (append_ocl_sos): Update.
7913         * psymtab.c (maintenance_print_psymbols)
7914         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7915         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7916         * printcmd.c (info_symbol_command): Update.
7917         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7918         Update.
7919         * objfiles.h (class all_objfiles): Remove.
7920         * objfiles.c (have_partial_symbols, have_full_symbols)
7921         (have_minimal_symbols, qsort_cmp, update_section_map)
7922         (shared_objfile_contains_address_p)
7923         (default_iterate_over_objfiles_in_search_order): Update.
7924         * objc-lang.c (info_selectors_command, info_classes_command)
7925         (find_methods): Update.
7926         * minsyms.c (find_solib_trampoline_target): Update.
7927         * maint.c (maintenance_info_sections)
7928         (maintenance_translate_address, count_symtabs_and_blocks):
7929         Update.
7930         * main.c (captured_main_1): Update.
7931         * linux-thread-db.c (try_thread_db_load_from_pdir)
7932         (has_libpthread): Update.
7933         * linespec.c (iterate_over_all_matching_symtabs)
7934         (search_minsyms_for_name): Update.
7935         * jit.c (jit_find_objf_with_entry_addr): Update.
7936         * hppa-tdep.c (find_unwind_entry)
7937         (hppa_lookup_stub_minimal_symbol): Update.
7938         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7939         Update.
7940         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7941         (elf_gnu_ifunc_resolve_by_got): Update.
7942         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7943         * dwarf-index-write.c (save_gdb_index_command): Update.
7944         * cp-support.c (add_symbol_overload_list_qualified): Update.
7945         * breakpoint.c (create_overlay_event_breakpoint)
7946         (create_longjmp_master_breakpoint)
7947         (create_std_terminate_master_breakpoint)
7948         (create_exception_master_breakpoint): Update.
7949         * blockframe.c (find_pc_partial_function): Update.
7950         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7951         (ada_collect_symbol_completion_matches)
7952         (ada_add_global_exceptions): Update.
7953
7954 2019-01-17  Tom Tromey  <tom@tromey.com>
7955
7956         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7957         declare VEC.
7958         (solib_target_parse_libraries): Change return type.
7959         (library_list_start_segment, library_list_start_section)
7960         (library_list_end_library, library_list_start_library); Update.
7961         (solib_target_free_library_list): Remove.
7962         (solib_target_parse_libraries): Remove cleanup.  Change return
7963         type.
7964         (solib_target_current_sos): Update.
7965
7966 2019-01-17  Tom Tromey  <tromey@bapiya>
7967
7968         * valprint.c: Replace "the the" with "the".
7969         * symtab.c: Replace "the the" with "the".
7970         * solib.c: Replace "the the" with "the".
7971         * solib-dsbt.c: Replace "the the" with "the".
7972         * linespec.c: Replace "the the" with "the".
7973         * dwarf2loc.h: Replace "the the" with "the".
7974         * amd64-windows-tdep.c: Replace "the the" with "the".
7975         * aarch64-tdep.c: Replace "the the" with "the".
7976
7977 2019-01-16  Keith Seitz  <keiths@redhat.com>
7978
7979         PR gdb/23773
7980         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7981         <builder>: Rename to ..
7982         <m_builder>: ... this and make private.
7983         (dwarf2_cu::get_builder): New method.  Change all users of
7984         `builder' to use this method.
7985         (dwarf2_start_symtab): Move to ...
7986         (dwarf2_cu::start_symtab): ... here.  Update all callers
7987         (setup_type_unit_groups): Move to ...
7988         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7989         callers.
7990         (dwarf2_cu::reset_builder): New method.
7991         (process_full_compunit, process_full_type_unit): Use
7992         dwarf2_cu::reset_builder.
7993         (follow_die_offset): Record the ancestor CU if it is different
7994         from the followed DIE's CU.
7995         (follow_die_sig_1): Likewise.
7996
7997 2019-01-15  Tom Tromey  <tom@tromey.com>
7998
7999         * remote.c (class remote_state) <buf>: Now a char_vector.
8000         <buf_size>: Remove.
8001         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8002         parameter.
8003         (remote_target::getpkt_or_notif_sane_1)
8004         (remote_target::getpkt_sane)
8005         (remote_target::getpkt_or_notif_sane): Likewise.
8006         (class remote_target) <putpkt>: New overload.
8007         (remote_target::read_frame): Change type of "buf_p".  Remove
8008         sizeof_p parameter.
8009         (packet_ok): New overload.
8010         (packet_check_result): New overload.
8011         Update all uses.
8012
8013 2019-01-14  Tom Tromey  <tom@tromey.com>
8014
8015         * remote-notif.c (handle_notification, remote_notif_ack)
8016         (remote_notif_parse): Make "buf" const.
8017         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8018         const.
8019         (remote_notif_parse, remote_notif_ack, handle_notification):
8020         Likewise.
8021         * remote.c (remote_notif_stop_parse): Make "buf" const.
8022         (remote_target::remote_parse_stop_reply): Make "buf" const.
8023         (remote_notif_stop_ack): Make "buf" const.
8024
8025 2019-01-14  Tom Tromey  <tom@tromey.com>
8026
8027         * remote.c (remote_console_output): Make parameter const.
8028
8029 2019-01-14  Tom Tromey  <tom@tromey.com>
8030
8031         * target-debug.h (target_debug_print_signals): Constify.
8032         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8033         * procfs.c (procfs_target::pass_signals): Update.
8034         * linux-nat.c (linux_nat_target::pass_signals): Update.
8035         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8036         * target-delegates.c: Rebuild.
8037         * remote.c (remote_target::program_signals): Update.
8038         (remote_target::pass_signals): Update.
8039         * target.c (target_pass_signals): Constify argument.
8040         (target_program_signals): Likewise.
8041         * target.h (struct target_ops) <pass_signals, program_signals>:
8042         Constify argument.
8043         (target_pass_signals, target_program_signals): Constify argument.
8044
8045 2019-01-14  Tom Tromey  <tom@tromey.com>
8046
8047         PR tui/28819:
8048         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8049
8050 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8051
8052         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8053         field.
8054         * rs6000-tdep.c: Include reggroups.h.
8055         (IS_V_ALIAS_PSEUDOREG): Define.
8056         (rs6000_register_name): Return names for the "vX" aliases.
8057         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8058         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8059         aliases.  Call default_register_reggroup_p for all other
8060         pseudo-registers.
8061         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8062         New functions.
8063         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8064         Handle "vX" aliases.
8065         (v_alias_pseudo_register_collect): New function.
8066         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8067         (rs6000_gdbarch_init): Initialize "vX" aliases as
8068         pseudo-registers.  Restore registration of
8069         rs6000_pseudo_register_reggroup_p with
8070         set_tdesc_pseudo_register_reggroup_p.
8071
8072 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8073
8074         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8075         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8076         set_gdbarch_num_pseudo_regs.
8077
8078 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8079
8080         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8081         Remove arg prefixname, add do_set and do_show.
8082         Add member functions set_list and show_list.
8083         * cli/cli-style.c (class cli_style_option): Update accordingly.
8084         (style_set_list): Move to file scope.
8085         (style_show_list): Likewise.
8086         (set_style): Call help_list.
8087         (show_style): Call cmd_show_list.
8088         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8089         Update to use the new macro.
8090
8091 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8092
8093         * ada-lang.c (_initialize_ada_language): Expand the help text
8094         for the "catch exception" command.
8095
8096 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8097
8098         * symtab.c (matching_obj_sections): Initialize obj,
8099         declare it closer to its usage.
8100
8101 2019-01-10  Tom Tromey  <tom@tromey.com>
8102
8103         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8104         (basic_inf_threads_range): Remove.
8105         (inf_threads_range, inf_non_exited_threads_range)
8106         (safe_inf_threads_range): Use next_adapter.
8107
8108 2019-01-10  Keith Seitz  <keiths@redhat.com>
8109
8110         PR gdb/23712
8111         PR symtab/23010
8112         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8113         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8114
8115 2019-01-10  Keith Seitz  <keiths@redhat.com>
8116
8117         PR gdb/23712
8118         PR symtab/23010
8119         * dictionary.c (pending_to_vector): Remove.
8120         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8121         Remove _1 suffix, replacing functions of the same name.  Update
8122         all callers.
8123         (dict_create_hashed, dict_create_hashed_expandable)
8124         (dict_create_linear, dict_create_linear_expandable, dict_free)
8125         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8126         Make functions static.
8127
8128 2019-01-10  Keith Seitz  <keiths@redhat.com>
8129
8130         PR gdb/23712
8131         PR symtab/23010
8132         * dictionary.h (struct dictionary): Replace declaration with
8133         multidictionary.
8134         (dict_create_hashed, dict_create_hashed_expandable)
8135         (dict_create_linear, dict_create_linear_expandable)
8136         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8137         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8138         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8139         taking multidictionary argument.
8140         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8141         * block.h (struct block) <dict>: Change to multidictionary
8142         and rename `multidict'.
8143         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8144         symmisc.c: Update all dictionary references to multidictionary.
8145
8146 2019-01-10  Keith Seitz  <keiths@redhat.com>
8147
8148         PR gdb/23712
8149         PR symtab/23010
8150         * dictionary.c: Include unordered_map.
8151         (pending_to_vector): New function.
8152         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8153         Rewrite the non-"_1" functions to take vector instead
8154         of linked list.
8155         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8156         "new" _1 versions of the same name.
8157         (multidictionary): Define.
8158         (std::hash<enum language): New definition.
8159         (collate_pending_symbols_by_language, mdict_create_hashed)
8160         (mdict_create_hashed_expandable, mdict_create_linear)
8161         (mdict_create_linear_expandable, mdict_free)
8162         (find_language_dictionary, create_new_language_dictionary)
8163         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8164         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8165         (mdict_size, mdict_empty): New functions.
8166         * dictionary.h (mdict_iterator): Define.
8167
8168 2019-01-10  Pedro Alves  <palves@redhat.com>
8169
8170         * breakpoint.c (read_uploaded_action)
8171         (create_tracepoint_from_upload): Adjust to use
8172         gdb::unique_xmalloc_ptr.
8173         * ctf.c (ctf_write_uploaded_tp):
8174         (SET_ARRAY_FIELD): Use emplace_back.
8175         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8176         * tracefile-tfile.c (tfile_write_uploaded_tp):
8177         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8178         gdb::unique_xmalloc_ptr.
8179         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8180         at_string, cond_string, cmd_strings>: Replace char pointers
8181         with gdb::unique_xmalloc_ptr.
8182
8183 2019-01-10  Pedro Alves  <palves@redhat.com>
8184
8185         * solib-target.c (library_list_start_library): Don't xstrdup name.
8186
8187 2019-01-10  Pedro Alves  <palves@redhat.com>
8188
8189         * mdebugread.c (parse_partial_symbols): Use
8190         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8191
8192 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8193
8194         * linux-fork.c (scoped_switch_fork_info)
8195         <~scoped_switch_fork_info>: Fix incorrect variable name.
8196
8197 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8198
8199         * linux-fork.c (scoped_switch_fork_info)
8200         <scoped_switch_fork_info>: Make explicit.
8201         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8202
8203 2019-01-10  Tom Tromey  <tom@tromey.com>
8204
8205         * objfiles.h (objfile::reset_psymtabs): Update.
8206         * objfiles.c (objfile::objfile): Update.
8207         * psymtab.h (psymtab_storage::obstack): Update.
8208         (psymtab_storage::m_obstack): Use gdb::optional.
8209         (class psymtab_storage): Update comment.  Remove objfile
8210         parameter.
8211         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8212
8213 2019-01-10  Tom Tromey  <tom@tromey.com>
8214
8215         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8216         <free_psymtabs>: Now private.
8217         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8218         (allocate_psymtab): Use new method.
8219
8220 2019-01-10  Tom Tromey  <tom@tromey.com>
8221
8222         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8223         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8224         * mdebugread.c (parse_partial_symbols): Use
8225         allocate_dependencies.
8226         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8227         allocate_dependencies.
8228         (process_psymtab_comp_unit_reader)
8229         (build_type_psymtab_dependencies): Likewise.
8230         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8231
8232 2019-01-10  Tom Tromey  <tom@tromey.com>
8233
8234         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8235         PSYMBOL_SET_LANGUAGE.
8236         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8237
8238 2019-01-10  Tom Tromey  <tom@tromey.com>
8239
8240         * psymtab.h (psymtab_storage::obstack): New method.
8241         <m_obstack>: Rename from obstack; now private.
8242         * psymtab.c (psymtab_storage): Update.
8243         * dwarf2read.c (create_addrmap_from_index)
8244         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8245         Update.
8246
8247 2019-01-10  Tom Tromey  <tom@tromey.com>
8248
8249         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8250         * objfiles.h (objfile::reset_psymtabs): New method.
8251
8252 2019-01-10  Tom Tromey  <tom@tromey.com>
8253
8254         * symmisc.c (print_symbol_bcache_statistics): Update.
8255         (print_objfile_statistics): Update.
8256         * symfile.c (reread_symbols): Update.
8257         * psymtab.h (class psymtab_storage): New.
8258         * psymtab.c (psymtab_storage): New constructor.
8259         (~psymtab_storage): New destructor.
8260         (require_partial_symbols): Update.
8261         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8262         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8263         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8264         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8265         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8266         (start_psymtab_common, end_psymtab_common)
8267         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8268         (allocate_psymtab): Update.
8269         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8270         Update.
8271         (dump_psymtab_addrmap, maintenance_print_psymbols)
8272         (maintenance_check_psymtabs): Update.
8273         (class objfile_psymtabs): Move to objfiles.h.
8274         * psympriv.h (discard_psymtab): Now inline.
8275         (psymtab_discarder::psymtab_discarder): Update.
8276         (psymtab_discarder::~psymtab_discarder): Update.
8277         (ALL_OBJFILE_PSYMTABS): Rewrite.
8278         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8279         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8280         Remove fields.
8281         <partial_symtabs>: New field.
8282         (class objfile_psymtabs): Move from psymtab.h.  Update.
8283         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8284         psymbol_cache.
8285         (objfile::~objfile): Don't destroy psymbol_cache.
8286         * mdebugread.c (parse_partial_symbols): Update.
8287         * dwarf2read.c (create_addrmap_from_index)
8288         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8289         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8290         (add_partial_subprogram, dwarf2_ranges_read): Update.
8291         * dwarf-index-write.c (write_address_map)
8292         (write_one_signatured_type, recursively_write_psymbols)
8293         (class debug_names, class debug_names, write_psymtabs_to_index):
8294         Update.
8295
8296 2019-01-10  Tom Tromey  <tom@tromey.com>
8297
8298         * symtab.h (SYMBOL_SET_NAMES): Update.
8299         (symbol_set_names): Update.
8300         (MSYMBOL_SET_NAMES): Update.
8301         * symtab.c (symbol_set_names): Change argument to be an
8302         objfile_per_bfd_storage.
8303         * psymtab.c (add_psymbol_to_bcache): Update.
8304         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8305
8306 2019-01-10  Tom Tromey  <tom@tromey.com>
8307
8308         * symtab.c (create_demangled_names_hash): Change argument to be an
8309         objfile_per_bfd_storage.
8310         (symbol_set_names): Update.
8311
8312 2019-01-10  Tom Tromey  <tom@tromey.com>
8313
8314         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8315         init_psymbol_list.
8316         * psymtab.c (init_psymbol_list): Do nothing if already called.
8317         * psympriv.h (init_psymbol_list): Add comment.
8318         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8319         init_psymbol_list.
8320         * dbxread.c (dbx_symfile_read): Unconditionally call
8321         init_psymbol_list.
8322
8323 2019-01-10  Tom Tromey  <tom@tromey.com>
8324
8325         * xcoffread.c (scan_xcoff_symtab): Update.
8326         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8327         "where".
8328         * mdebugread.c (parse_partial_symbols)
8329         (handle_psymbol_enumerators): Update.
8330         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8331         * dbxread.c (read_dbx_symtab): Update.
8332         * psympriv.h (psymbol_placement): New enum.
8333         (add_psymbol_to_list): Update.
8334
8335 2019-01-10  Tom Tromey  <tom@tromey.com>
8336
8337         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8338         static_psymbols parameters.
8339         (scan_xcoff_symtab): Update.
8340         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8341         static_psymbols parameters.
8342         * psympriv.h (start_psymtab_common): Update.
8343         * mdebugread.c (parse_partial_symbols): Update.
8344         * dwarf2read.c (create_partial_symtab): Update.
8345         * dbxread.c (read_dbx_symtab): Update.
8346         (start_psymtab): Remove global_psymbols and static_psymbols
8347         parameters.
8348
8349 2019-01-10  Tom Tromey  <tom@tromey.com>
8350
8351         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8352         * psymtab.c (allocate_psymtab): Add comment.
8353         * psympriv.h (allocate_psymtab): Add comment.
8354         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8355         initializations.
8356         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8357
8358 2019-01-10  Tom Tromey  <tom@tromey.com>
8359
8360         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8361         Don't declare.
8362         * mipsread.c: Include mdebugread.h.
8363         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8364         Declare.
8365         * elfread.c: Include mdebugread.h.
8366
8367 2019-01-09  Tom Tromey  <tom@tromey.com>
8368
8369         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8370         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8371         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8372         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8373         (psym_lookup_symbol, psym_find_last_source_symtab)
8374         (psym_forget_cached_source_info, psym_print_stats)
8375         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8376         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8377         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8378         (psym_find_compunit_symtab_by_address)
8379         (maintenance_print_psymbols, maintenance_info_psymtabs)
8380         (maintenance_check_psymtabs): Use ranged for.
8381         * psymtab.h (class objfile_psymtabs): New.
8382         (require_partial_symbols): Return objfile_psymtabs.
8383         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8384
8385 2019-01-09  Tom Tromey  <tom@tromey.com>
8386
8387         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8388         (find_pc_mapped_section, list_overlays_command)
8389         (map_overlay_command, unmap_overlay_command)
8390         (simple_overlay_update): Use all_objfiles.
8391         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8392         * printcmd.c (info_symbol_command): Use all_objfiles.
8393         * objfiles.h (ALL_OBJSECTIONS): Remove.
8394         * maint.c (maintenance_translate_address): Use all_objfiles.
8395         * gcore.c (gcore_create_callback): Use all_objfiles.
8396         (objfile_find_memory_regions): Likewise.
8397
8398 2019-01-09  Tom Tromey  <tom@tromey.com>
8399
8400         * symtab.c (find_line_symtab, info_sources_command)
8401         (make_source_files_completion_list): Use objfile_compunits.
8402         * source.c (select_source_symtab): Use objfile_compunits.
8403         * objfiles.h (struct objfile): Update comment.
8404         (ALL_OBJFILES): Remove.
8405         (ALL_FILETABS): Remove.
8406         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8407         objfile_compunits.
8408
8409 2019-01-09  Tom Tromey  <tom@tromey.com>
8410
8411         * symmisc.c (print_objfile_statistics, dump_objfile)
8412         (maintenance_print_symbols): Use compunit_filetabs.
8413         * source.c (forget_cached_source_info_for_objfile): Use
8414         compunit_filetabs.
8415         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8416         (ALL_FILETABS): Use compunit_filetabs.
8417         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8418         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8419
8420 2019-01-09  Tom Tromey  <tom@tromey.com>
8421
8422         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8423         (compunit_filetabs): New.
8424         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8425         compunit_filetabs.
8426         (info_sources_command, make_source_files_completion_list): Remove
8427         declaration.
8428         * symmisc.c (print_objfile_statistics, dump_objfile)
8429         (maintenance_print_symbols): Remove declaration.
8430         (maintenance_info_symtabs): Use compunit_filetabs.
8431         (maintenance_info_line_tables): Likewise.
8432         * source.c (select_source_symtab): Change local variable name.
8433         (forget_cached_source_info_for_objfile): Remove declaration.
8434         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8435         * objfiles.c (objfile_relocate1): Remove declaration.
8436         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8437         declaration.
8438         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8439         * coffread.c (coff_symtab_read): Remove declaration.
8440         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8441         compunit_filetabs.
8442
8443 2019-01-09  Tom Tromey  <tom@tromey.com>
8444
8445         * symtab.c (lookup_objfile_from_block)
8446         (find_pc_sect_compunit_symtab, search_symbols)
8447         (default_collect_symbol_completion_matches_break_on): Use
8448         objfile_compunits.
8449         * objfiles.h (ALL_COMPUNITS): Remove.
8450         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8451         * cp-support.c (add_symbol_overload_list_qualified): Use
8452         objfile_compunits.
8453         * ada-lang.c (ada_collect_symbol_completion_matches)
8454         (ada_add_global_exceptions): Use objfile_compunits.
8455
8456 2019-01-09  Tom Tromey  <tom@tromey.com>
8457
8458         * source.c (select_source_symtab)
8459         (forget_cached_source_info_for_objfile): Remove declaration.
8460         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8461         declaration.
8462         * maint.c (count_symtabs_and_blocks): Remove declaration.
8463         * cp-support.c (add_symbol_overload_list_qualified): Remove
8464         declaration.
8465         * coffread.c (coff_symtab_read): Remove declaration.
8466         * symtab.c (lookup_symbol_in_objfile_symtabs)
8467         (basic_lookup_transparent_type_1): Use objfile_compunits.
8468         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8469         (info_sources_command, search_symbols)
8470         (default_collect_symbol_completion_matches_break_on)
8471         (make_source_files_completion_list): Remove declaration.
8472         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8473         (ada_collect_symbol_completion_matches)
8474         (ada_add_global_exceptions): Remove declaration.
8475         * linespec.c (iterate_over_all_matching_symtabs): Use
8476         objfile_compunits.
8477         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8478         (class objfile_compunits): New.
8479         (ALL_COMPUNITS): Use objfile_compunits.
8480         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8481         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8482         objfile_compunits.
8483         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8484
8485 2019-01-09  Tom Tromey  <tom@tromey.com>
8486
8487         * symtab.c (search_symbols)
8488         (default_collect_symbol_completion_matches_break_on): Use
8489         objfile_msymbols.
8490         * ada-lang.c (ada_lookup_simple_minsym)
8491         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8492         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8493         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8494         objfile_msymbols.
8495         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8496         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8497         * objc-lang.c (find_methods): Use objfile_msymbols.
8498         (info_selectors_command, info_classes_command): Likewise.
8499         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8500         * objfiles.h (class objfile_msymbols): New.
8501         (ALL_OBJFILE_MSYMBOLS): Remove.
8502         (ALL_MSYMBOLS): Remove.
8503
8504 2019-01-09  Tom Tromey  <tom@tromey.com>
8505
8506         * common/next-iterator.h (next_adapter): Add Iterator template
8507         parameter.
8508         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8509         (class all_objfiles_safe): New.
8510         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8511         * objfiles.c (put_objfile_before): Update comment.
8512         (add_separate_debug_objfile): Likewise.
8513         (free_all_objfiles): Use all_objfiles_safe.
8514         (objfile_purge_solibs): Likewise.
8515
8516 2019-01-09  Tom Tromey  <tom@tromey.com>
8517
8518         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8519         (expand_symtab_containing_pc, lookup_static_symbol)
8520         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8521         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8522         all_objfiles.
8523         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8524         * breakpoint.c (create_overlay_event_breakpoint)
8525         (create_longjmp_master_breakpoint)
8526         (create_std_terminate_master_breakpoint)
8527         (create_exception_master_breakpoint): Use all_objfiles.
8528         * linux-thread-db.c (try_thread_db_load_from_pdir)
8529         (has_libpthread): Use all_objfiles.
8530         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8531         * linespec.c (iterate_over_all_matching_symtabs)
8532         (search_minsyms_for_name): Use all_objfiles.
8533         * maint.c (maintenance_info_sections): Use all_objfiles.
8534         * main.c (captured_main_1): Use all_objfiles.
8535         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8536         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8537         * guile/scm-pretty-print.c
8538         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8539         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8540         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8541         (maintenance_print_msymbols): Use all_objfiles.
8542         * source.c (select_source_symtab): Use all_objfiles.
8543         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8544         * symfile.c (remove_symbol_file_command)
8545         (expand_symtabs_matching, map_symbol_filenames): Use
8546         all_objfiles.
8547         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8548         all_objfiles.
8549         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8550         * objc-lang.c (find_methods): Use all_objfiles.
8551         * objfiles.c (have_partial_symbols, have_full_symbols)
8552         (have_minimal_symbols, qsort_cmp)
8553         (default_iterate_over_objfiles_in_search_order): Use
8554         all_objfiles.
8555         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8556         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8557         (maintenance_check_psymtabs): Use all_objfiles.
8558         (ALL_PSYMTABS): Remove.
8559         * compile/compile-object-run.c (do_module_cleanup): Use
8560         all_objfiles.
8561         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8562         * cp-support.c (add_symbol_overload_list_qualified): Use
8563         all_objfiles.
8564         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8565         Use all_objfiles.
8566         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8567         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8568         all_objfiles.
8569         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8570         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8571         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8572         Uses all_objfiles.
8573         * solib.c (solib_read_symbols): Use all_objfiles
8574
8575 2019-01-09  Tom Tromey  <tom@tromey.com>
8576
8577         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8578         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8579         all_objfiles.
8580         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8581         * symmisc.c (print_symbol_bcache_statistics)
8582         (print_objfile_statistics, maintenance_print_objfiles)
8583         (maintenance_info_symtabs, maintenance_check_symtabs)
8584         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8585         all_objfiles.
8586         * source.c (forget_cached_source_info): Use all_objfiles.
8587         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8588         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8589         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8590         * objfiles.c (update_section_map): Use all_objfiles.
8591         (shared_objfile_contains_address_p): Likewise.
8592         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8593         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8594
8595 2019-01-09  Tom Tromey  <tom@tromey.com>
8596
8597         * common/next-iterator.h: New file.
8598         * objfiles.h (class all_objfiles): New.
8599         (struct objfile_iterator): New.
8600
8601 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8602
8603         * NEWS: Move the description of the changed "frame", "select-frame",
8604          and "info frame" commands to the Changed commands section.
8605
8606 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8607
8608         * gdbtypes.c (check_stub_method_group): Remove handling of old
8609         mangling schemes.
8610         * linespec.c (find_methods): Likewise.
8611         * stabsread.c (read_member_functions): Likewise.
8612         * valops.c (search_struct_method): Likewise.
8613         (value_struct_elt_for_reference): Likewise.
8614         * NEWS: Mention this change.
8615
8616 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8617
8618         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8619         print_source_lines.
8620         * source.c (print_source_lines_base): Update line number check.
8621         (print_source_lines): New function.
8622         (source_lines_range::source_lines_range): New function.
8623         * source.h (class source_lines_range): New class.
8624         (print_source_lines): New declaration.
8625
8626 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8627
8628         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8629
8630 2019-01-08  Tom Tromey  <tom@tromey.com>
8631             Simon Marchi  <simon.marchi@ericsson.com>
8632
8633         PR gdb/24060
8634         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8635         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8636         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8637         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8638         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8639         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8640
8641 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8642
8643         * source.c (select_source_symtab): Move header comment to
8644         declaration in source.h.
8645         (forget_cached_source_info_for_objfile): Likewise.
8646         (forget_cached_source_info): Likewise.
8647         (identify_source_line): Likewise.
8648         * source.h (identify_source_line): Move declaration from symtab.h
8649         and add comment from source.c
8650         (print_source_lines): Likewise.
8651         (forget_cached_source_info_for_objfile): Likewise.
8652         (forget_cached_source_info): Likewise.
8653         (select_source_symtab): Likewise.
8654         (enum print_source_lines_flag): Move definition from symtab.h.
8655         * symtab.h (identify_source_line): Move declaration to source.h.
8656         (print_source_lines): Likewise.
8657         (forget_cached_source_info_for_objfile): Likewise.
8658         (forget_cached_source_info): Likewise.
8659         (select_source_symtab): Likewise.
8660         (enum print_source_lines_flag): Move definition to source.h.
8661         * tui/tui-hooks.c: Add 'source.h' include.
8662
8663 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8664
8665         * source.c (print_source_lines_base): Handle requests to print
8666         reverse line number sequences, and guard against empty lines
8667         string.
8668
8669 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8670
8671         * source.c (print_source_lines_base): Fix skip of '\r' if next
8672         character is '\n'.
8673
8674 2019-01-06  Tom Tromey  <tom@tromey.com>
8675
8676         * c-exp.y (struct c_parse_state) <macro_original_text,
8677         expansion_obstack>: New member.
8678         (macro_original_text, expansion_obstack): Remove globals.
8679         (scan_macro_expansion, scanning_macro_expansion)
8680         (finished_macro_expansion): Update.
8681         (scan_macro_cleanup): Remove.
8682         (yylex, c_parse): Update.
8683
8684 2019-01-06  Tom Tromey  <tom@tromey.com>
8685
8686         * c-exp.y (struct c_parse_state) <strings>: New member.
8687         (operator_stoken): Update.
8688
8689 2019-01-06  Tom Tromey  <tom@tromey.com>
8690
8691         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8692         (union type_stack_elt) <typelist_val>: Now a pointer to
8693         std::vector.
8694         (type_stack_cleanup): Don't declare.
8695         (push_typelist): Update.
8696         * parse.c (pop_typelist): Return a std::vector.
8697         (push_typelist): Take a std::vector.
8698         (follow_types): Update.  Do not free args.
8699         (type_stack_cleanup): Remove.
8700         * c-exp.y (struct c_parse_state): New.
8701         (cpstate): New global.
8702         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8703         (nonempty_typelist): Update.
8704         (func_mod): Create a new vector.
8705         (c_parse): Create a c_parse_state.
8706         (check_parameter_typelist): Do not delete params.
8707         (function_method): Update.  Do not delete type_list.
8708
8709 2019-01-06  Tom Tromey  <tom@tromey.com>
8710
8711         PR gdb/28155:
8712         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8713         check_typedef.
8714         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8715         (print_return_value): Likewise.
8716
8717 2019-01-05  Tom Tromey  <tom@tromey.com>
8718
8719         * contrib/cleanup_check.py: Remove.
8720         * contrib/gcc-with-excheck: Remove.
8721         * contrib/exsummary.py: Remove.
8722         * contrib/excheck.py: Remove.
8723
8724 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8725
8726         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8727         NULL. Initialize tpprev to NULL instead of assigning it
8728         to NULL on the next statement.
8729         * windows-nat.c (windows_delete_thread): Remove check for
8730         main_thread_id before printing thread exit notifications.
8731         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8732         Remove thread ID check against main_thread_id.
8733         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8734         windows_delete_thread.
8735         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8736
8737 2019-01-04  Tom Tromey  <tom@tromey.com>
8738
8739         * compile/compile.c (_initialize_compile): Use upper case for
8740         metasyntactic variables.
8741         * symmisc.c (_initialize_symmisc): Use upper case for
8742         metasyntactic variables.
8743         * psymtab.c (_initialize_psymtab): Use upper case for
8744         metasyntactic variables.
8745         * demangle.c (demangle_command): Use upper case for metasyntactic
8746         variables.
8747         (_initialize_demangler): Likewise.
8748         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8749         variables.
8750
8751 2019-01-03  Tom Tromey  <tom@tromey.com>
8752
8753         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8754
8755 2019-01-03  Tom Tromey  <tom@tromey.com>
8756
8757         * python/py-symtab.c (salpy_str): Update.
8758         (struct salpy_sal_object) <symtab>: Now a PyObject.
8759         (salpy_dealloc): Update.
8760         (del_objfile_sal): Use gdbpy_ref.
8761
8762 2019-01-03  Tom Tromey  <tom@tromey.com>
8763
8764         * python/py-type.c (convert_field): Use new_reference.  Return
8765         gdbpy_ref.
8766         (make_fielditem): Return gdbpy_ref.
8767         (typy_fields): Update.
8768         (typy_getitem): Update.
8769         (field_name): Return gdbpy_ref.  Use new_reference.
8770         (typy_iterator_iternext): Update.
8771
8772 2019-01-03  Tom Tromey  <tom@tromey.com>
8773
8774         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8775
8776 2019-01-03  Tom Tromey  <tom@tromey.com>
8777
8778         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8779         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8780         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8781         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8782         (pspy_set_type_printers): Likewise.
8783         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8784         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8785         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8786         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8787         (objfpy_set_type_printers): Likewise.
8788
8789 2019-01-03  Tom Tromey  <tom@tromey.com>
8790
8791         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8792         (gdbpy_print_stack): Use gdbpy_err_fetch.
8793         * python/python-internal.h (class gdbpy_err_fetch): New class.
8794         (class gdbpy_enter) <m_error_type, m_error_value,
8795         m_error_traceback>: Remove.
8796         <m_error>: New member.
8797         (gdbpy_exception_to_string): Don't declare.
8798         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8799         * python/py-value.c (convert_value_from_python): Use
8800         gdbpy_err_fetch.
8801         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8802         gdbpy_exception_to_string.
8803         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8804         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8805         gdbpy_err_fetch.
8806
8807 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8808
8809         * linux-nat.c (delete_lwp_cleanup): Delete.
8810         (struct lwp_deleter): New struct.
8811         (lwp_info_up): New typedef.
8812         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8813         lwp_info_up.
8814
8815 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8816
8817         * linux-fork.c (class scoped_switch_fork_info): New class.
8818         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8819
8820 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8821
8822         * valops.c (find_overload_match): Remove use of null_cleanup, and
8823         calls to do_cleanups.
8824
8825 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8826
8827         * compile/compile-cplus-types.c
8828         (compile_cplus_instance::decl_name): Handle changes to
8829         cp_func_name.
8830         * cp-support.c (cp_func_name): Update header comment, update
8831         return type.
8832         * cp-support.h (cp_func_name): Update return type in declaration.
8833         * valops.c (find_overload_match): Move temp_func local to top
8834         level of function and change its type.  Use temp_func to hold and
8835         delete temporary string obtained from cp_func_name.
8836
8837 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8838
8839         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8840         gdb::char_vector, remove cleanup, and update uses of `msg`.
8841
8842 2019-01-03  Jim Wilson  <jimw@sifive.com>
8843
8844         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8845
8846 2019-01-02  Tom Tromey  <tom@tromey.com>
8847
8848         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8849         (tdesc_parse_xml): Remove cleanups.
8850         * target-descriptions.h (make_cleanup_free_target_description):
8851         Don't declare.
8852         (target_desc_deleter): New struct.
8853         (target_desc_up): New typedef.
8854         * target-descriptions.c (target_desc_deleter::operator()): Rename
8855         from free_target_description.
8856         (make_cleanup_free_target_description): Remove.
8857
8858 2019-01-02  Tom Tromey  <tom@tromey.com>
8859
8860         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8861         constructor, destructor.
8862         (linespec_parser): Remove typedef.
8863         (~linespec_parser): Rename from linespec_parser_delete.
8864         (linespec_lex_to_end, linespec_complete_label)
8865         (linespec_complete): Update.
8866         (decode_line_full): Remove cleanups.
8867         (decode_line_1): Update.
8868
8869 2019-01-02  Tom Tromey  <tom@tromey.com>
8870
8871         * python/python-internal.h (inferior_to_inferior_object): Change
8872         return type.
8873         * python/py-exitedevent.c (create_exited_event_object): Update.
8874         * python/py-inferior.c (inferior_to_inferior_object): Return
8875         gdbpy_ref.
8876         (python_new_inferior, python_inferior_deleted)
8877         (thread_to_thread_object, delete_thread_object)
8878         (build_inferior_list, gdbpy_selected_inferior): Update.
8879         * python/py-infthread.c (create_thread_object): Update.  Also fail
8880         if inferior_to_inferior_object fails.
8881
8882 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8883
8884         * inferior.h (class inferior) <displaced_step_state>: New field.
8885         * infrun.h (struct displaced_step_state): Move here from
8886         infrun.c.  Initialize fields, add constructor.
8887         <inf>: Remove field.
8888         <reset>: New method.
8889         * infrun.c (struct displaced_step_inferior_state): Move to
8890         infrun.h.
8891         (displaced_step_inferior_states): Remove.
8892         (get_displaced_stepping_state): Adust.
8893         (displaced_step_in_progress_any_inferior): Adjust.
8894         (displaced_step_in_progress_thread): Adjust.
8895         (displaced_step_in_progress): Adjust.
8896         (add_displaced_stepping_state): Remove.
8897         (get_displaced_step_closure_by_addr): Adjust.
8898         (remove_displaced_stepping_state): Remove.
8899         (infrun_inferior_exit): Call displaced_step_state.reset.
8900         (use_displaced_stepping): Don't check for NULL.
8901         (displaced_step_prepare_throw): Call
8902         get_displaced_stepping_state.
8903         (displaced_step_fixup): Don't check for NULL.
8904         (prepare_for_detach): Don't check for NULL.
8905
8906 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8907
8908         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8909          in case of call that did not complete.
8910
8911 2019-01-02  Andrey Utkin  <autkin@undo.io>
8912
8913         * symfile.c (find_separate_debug_file): Fix search of debug files for
8914         remote debuggee.
8915
8916 2019-01-02  Tom Tromey  <tom@tromey.com>
8917
8918         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8919         indentation.
8920         * python/py-frame.c (frapy_older): Remove cast.
8921         (frapy_newer): Likewise.
8922         * python/py-breakpoint.c (local_setattro): Remove cast.
8923         * python/py-arch.c (archpy_name): Remove local variable.
8924         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8925
8926 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8927
8928         * unittests/basic_string_view/element_access/char/empty.cc:
8929         Fix year range in copyright header.
8930
8931 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8932
8933         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8934         Delete.
8935         <operator==>: Update with for removed field.
8936         <hash>: Likewise.
8937         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8938         <isa_features>: ...this.
8939         <abi_features>: New field.
8940         (riscv_isa_flen): Update comment.
8941         (riscv_abi_xlen): New declaration.
8942         (riscv_abi_flen): New declaration.
8943         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8944         isa_features.
8945         (riscv_abi_xlen): New function.
8946         (riscv_isa_flen): Update to get answer from isa_features.
8947         (riscv_abi_flen): New function.
8948         (riscv_has_fp_abi): Update to get answer from abi_features.
8949         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8950         xlen and flen.
8951         (riscv_call_info) <xlen, flen>: Update comment.
8952         (riscv_call_arg_struct): Remove invalid assertions
8953         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8954         is removed.
8955         (riscv_gdbarch_init): Gather isa features and abi features
8956         separately, ensure both match on the gdbarch when reusing an old
8957         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8958         a target with 64-bit float hardware.
8959
8960 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8961
8962         * source.c (search_command_helper): Stop reverse search
8963         when line 1 has been searched.
8964
8965 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8966
8967         * record-full.c (record_full_base_target::close): Rewrite
8968         record_full_core_buf_list free logic.
8969
8970 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8971
8972         * break-catch-syscall.c (print_one_catch_syscall): xfree
8973         the last text.
8974
8975 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8976
8977         * top.c (print_gdb_version): Update Copyright year in version
8978         message.
8979
8980 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8981
8982         Update copyright year range in all GDB files.
8983
8984 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8985
8986         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8987
8988 For older changes see ChangeLog-2018.
8989 \f
8990 Local Variables:
8991 mode: change-log
8992 left-margin: 8
8993 fill-column: 74
8994 version-control: never
8995 coding: utf-8
8996 End:
8997