gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-layout.c (show_source_disasm_command): Simplify window
   4         resetting.
   5
   6 2019-07-17  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui.h (tui_set_layout_by_name): Don't declare.
   9         * tui/tui-regs.c (tui_reg_layout): New function.
  10         (tui_show_registers, tui_reg_command): Use it.
  11         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
  12         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
  13         parameters.
  14         (tui_layout_command): Remove.
  15
  16 2019-07-17  Tom Tromey  <tom@tromey.com>
  17
  18         * tui/tui-layout.h (tui/tui-layout): Return void.
  19         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
  20
  21 2019-07-17  Tom Tromey  <tom@tromey.com>
  22
  23         * tui/tui-layout.c (show_source_disasm_command, show_data):
  24         Update.
  25         (reset_locator): Remove.
  26         (show_source_or_disasm_and_command): Update.
  27
  28 2019-07-17  Tom Tromey  <tom@tromey.com>
  29
  30         * tui/tui-source.c (tui_source_window_base::reset): Remove
  31         win_type parameter.
  32         * tui/tui-layout.c (make_command_window, make_source_window)
  33         (make_disasm_window, make_data_window)
  34         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
  35         (reset_locator, show_source_or_disasm_and_command): Update.
  36         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
  37         win_type parameter.
  38         (struct tui_source_window_base) <reset>: Likewise.
  39
  40 2019-07-17  Tom Tromey  <tom@tromey.com>
  41
  42         * tui/tui-layout.c (show_source_disasm_command): Use
  43         reset_locator.
  44         (reset_locator): New function.
  45         (init_and_make_win): Remove.
  46         (show_source_or_disasm_and_command): Use reset_locator.
  47
  48 2019-07-17  Tom Tromey  <tom@tromey.com>
  49
  50         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
  51         condition.
  52         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
  53         Remove condition.
  54         * tui/tui-source.c (tui_source_window_base::reset): New method.
  55         * tui/tui-layout.c (make_command_window): Don't call
  56         init_and_make_win.
  57         (make_source_window, make_disasm_window): Don't call
  58         make_source_or_disasm_window.
  59         (make_data_window): Don't call init_and_make_win.  Change calling
  60         convention.
  61         (show_source_disasm_command, show_data): Simplify.
  62         (make_source_or_disasm_window): Remove.
  63         (show_source_or_disasm_and_command): Simplify.
  64         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
  65         (struct tui_source_window_base) <reset>: Likewise.
  66         <execution_info>: Remove initializer.
  67         * tui/tui-data.c (tui_source_window_base): Initialize
  68         execution_info.
  69
  70 2019-07-17  Tom Tromey  <tom@tromey.com>
  71
  72         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
  73         variable.
  74
  75 2019-07-17  Tom Tromey  <tom@tromey.com>
  76
  77         * tui/tui.c (tui_rl_other_window): Update.
  78         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
  79         superclass method first.  Always iterate over regs_content.
  80         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
  81         method.
  82         * tui/tui-win.c (tui_set_focus_command): Update.
  83
  84 2019-07-17  Tom Tromey  <tom@tromey.com>
  85
  86         * tui/tui-win.c (tui_set_focus_command): Rename from
  87         tui_set_focus.  Call tui_enable.
  88         (tui_set_focus_command): Remove.
  89
  90 2019-07-17  Tom Tromey  <tom@tromey.com>
  91
  92         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
  93         refresh_window.
  94         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
  95         touchwin.
  96         (tui_data_window::refresh_window): Call refresh_window on data
  97         items.  Always call superclass refresh_window.
  98         (tui_win_info::refresh): Remove.
  99         (tui_source_window_base::refresh_window): Update.
 100         (tui_refresh_all): Update.
 101         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 102         refresh_window.
 103         (show_source_or_disasm_and_command): Likewise.
 104         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 105         (struct tui_source_window_base) <refresh>: Likewise.
 106
 107 2019-07-17  Tom Tromey  <tom@tromey.com>
 108
 109         * tui/tui-winsource.c (tui_clear_source_content)
 110         (tui_show_source_content): Update.
 111         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 112         whether content is empty.
 113         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 114         Remove.
 115
 116 2019-07-17  Tom Tromey  <tom@tromey.com>
 117
 118         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 119         window's contents.
 120         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 121         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 122
 123 2019-07-17  Tom Tromey  <tom@tromey.com>
 124
 125         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 126         (struct tui_data_item_window): Update.
 127
 128 2019-07-17  Tom Tromey  <tom@tromey.com>
 129
 130         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 131         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 132         defines.
 133
 134 2019-07-17  Tom Tromey  <tom@tromey.com>
 135
 136         * tui/tui-winsource.h (tui_erase_source_content)
 137         (tui_clear_source_content): Remove "display_prompt" parameter.
 138         * tui/tui-winsource.c (tui_update_source_window_as_is)
 139         (tui_update_source_windows_with_addr): Update.
 140         (tui_clear_source_content): Remove "display_prompt" parameter.
 141         (tui_erase_source_content): Likewise.  Simplify.
 142         (tui_show_source_content): Update.
 143         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 144         * tui/tui-stack.c (tui_show_frame_info): Update.
 145         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 146         Remove defines.
 147
 148 2019-07-17  Tom Tromey  <tom@tromey.com>
 149
 150         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 151         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 152         parameter.
 153         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 154         parameter.
 155
 156 2019-07-17  Tom Tromey  <tom@tromey.com>
 157
 158         * tui/tui-winsource.c (tui_clear_source_content)
 159         (tui_show_source_content, tui_show_exec_info_content)
 160         (tui_clear_exec_info_content): Update.
 161         * tui/tui-stack.c (tui_show_locator_content): Update.
 162         (tui_show_frame_info): Update.
 163         * tui/tui-source.h (tui_source_window): Don't declare.
 164         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 165         from tui_source_is_displayed.
 166         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 167         Remove field.
 168         (struct tui_source_window_base) <content_in_use>: New field.  Now
 169         bool.
 170         (struct tui_source_window) <showing_source_p>: New method.
 171         (TUI_SRC_WIN): Change cast.
 172         * tui/tui-data.c (tui_initialize_static_data): Update.
 173
 174 2019-07-17  Tom Tromey  <tom@tromey.com>
 175
 176         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 177         location_matches_p.
 178         * tui/tui-source.c (tui_source_window::location_matches_p): New
 179         method.
 180         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 181         method.
 182         * tui/tui-data.h (struct tui_source_window_base)
 183         <location_matches_p>: New method.
 184         (struct tui_source_window, struct tui_disasm_window)
 185         <location_matches_p>: Likewise.
 186
 187 2019-07-17  Tom Tromey  <tom@tromey.com>
 188
 189         * tui/tui-win.c (tui_set_win_height_command): Rename from
 190         tui_set_win_height.
 191         (tui_set_win_height_command): Remove.
 192
 193 2019-07-17  Tom Tromey  <tom@tromey.com>
 194
 195         * tui/tui-source.c (tui_source_window): New constructor.  Add
 196         observer.
 197         (~tui_source_window): New destructor.
 198         (tui_source_window::style_changed): New method.
 199         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 200         (tui_attach_detach_observers): Update.
 201         * tui/tui-data.h (struct tui_source_window): Make constructor not
 202         inline.  Add destructor.
 203         (struct tui_source_window) <style_changed>: New method.
 204         <m_observable>: New member.
 205
 206 2019-07-17  Tom Tromey  <tom@tromey.com>
 207
 208         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 209         * tui/tui-win.c (tui_resize_all): Fix typo.
 210
 211 2019-07-17  Tom Tromey  <tom@tromey.com>
 212
 213         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 214         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 215         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 216         * tui/tui-win.c (window_name_completer): Use foreach.
 217         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 218         (update_tab_width): Likewise.
 219         * tui/tui-layout.c (show_layout): Update.
 220         * tui/tui-data.h (class tui_window_iterator): New.
 221         (struct all_tui_windows): New.
 222         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 223
 224 2019-07-17  Tom Tromey  <tom@tromey.com>
 225
 226         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 227         parameter.  Don't reference globals.
 228         (tui_reg_command): Update.
 229
 230 2019-07-17  Tom Tromey  <tom@tromey.com>
 231
 232         * tui/tui-regs.c (tui_show_registers): Simplify.
 233
 234 2019-07-17  Tom Tromey  <tom@tromey.com>
 235
 236         * tui/tui-regs.c (tui_show_registers): Update.
 237         (tui_show_register_group): Add win_info parameter.
 238
 239 2019-07-17  Tom Tromey  <tom@tromey.com>
 240
 241         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 242         Rename from tui_display_reg_element_at_line.
 243         (tui_data_window::display_registers_from_line): Update.
 244         * tui/tui-data.h (struct tui_data_window)
 245         <display_reg_element_at_line>: New method.
 246
 247 2019-07-17  Tom Tromey  <tom@tromey.com>
 248
 249         * tui/tui-regs.h (tui_display_registers_from)
 250         (tui_display_registers_from_line): Don't declare.
 251         * tui/tui-windata.c (tui_data_window::display_all_data)
 252         (tui_data_window::refresh_all)
 253         (tui_data_window::do_scroll_vertical): Update.
 254         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 255         from tui_display_registers_from.
 256         (tui_display_reg_element_at_line): Update.
 257         (tui_data_window::display_registers_from_line): Rename from
 258         tui_display_registers_from_line.
 259         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 260         display_registers_from_line>: New methods.
 261
 262 2019-07-17  Tom Tromey  <tom@tromey.com>
 263
 264         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 265         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 266         from tui_erase_data_content.
 267         (tui_data_window::display_all_data)
 268         (tui_data_window::refresh_all)
 269         (tui_data_window::do_scroll_vertical): Update.
 270         * tui/tui-regs.c (tui_show_registers): Update.
 271         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 272         New method.
 273
 274 2019-07-17  Tom Tromey  <tom@tromey.com>
 275
 276         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 277         declare.
 278         * tui/tui-windata.c
 279         (tui_data_window::delete_data_content_windows): Rename from
 280         tui_delete_data_content_windows.
 281         (tui_data_window::display_all_data)
 282         (tui_data_window::do_scroll_vertical): Update.
 283         * tui/tui-data.h (struct tui_data_window)
 284         <delete_data_content_windows>: New method.
 285
 286 2019-07-17  Tom Tromey  <tom@tromey.com>
 287
 288         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 289         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 290
 291 2019-07-17  Tom Tromey  <tom@tromey.com>
 292
 293         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 294         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 295         from tui_display_all_data.
 296         * tui/tui-win.c
 297         (tui_data_window::do_make_visible_with_new_height): Update.
 298         * tui/tui-regs.c (tui_show_registers): Update.
 299         * tui/tui-layout.c (tui_set_layout): Update.
 300         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 301         method.
 302
 303 2019-07-17  Tom Tromey  <tom@tromey.com>
 304
 305         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 306         * tui/tui-windata.c (tui_display_data_from): Remove.
 307         (tui_data_window::refresh_all): Update.
 308
 309 2019-07-17  Tom Tromey  <tom@tromey.com>
 310
 311         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 312         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 313         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 314         tui_display_registers_from_line.
 315         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 316         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 317         "force_display" parameter.
 318
 319 2019-07-17  Tom Tromey  <tom@tromey.com>
 320
 321         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 322         declare.
 323         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 324         Rename from tui_first_reg_element_no_inline.
 325         (tui_display_reg_element_at_line)
 326         (tui_display_registers_from_line): Update.
 327         * tui/tui-data.h (struct tui_data_window)
 328         <first_reg_element_no_inline>: New method.
 329
 330 2019-07-17  Tom Tromey  <tom@tromey.com>
 331
 332         * tui/tui-windata.c (tui_display_data_from)
 333         (tui_data_window::do_scroll_vertical): Update.
 334         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 335         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 336         Rename from tui_line_from_reg_element_no.
 337         (tui_display_registers_from_line): Update.
 338         * tui/tui-data.h (struct tui_data_window)
 339         <line_from_reg_element_no>: New method.
 340
 341 2019-07-17  Tom Tromey  <tom@tromey.com>
 342
 343         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 344         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 345         tui_last_regs_line_no.
 346         (tui_display_reg_element_at_line)
 347         (tui_display_registers_from_line): Update.
 348         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 349         method.
 350
 351 2019-07-17  Tom Tromey  <tom@tromey.com>
 352
 353         PR tui/24722:
 354         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 355         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 356         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 357         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 358         (tui_update_breakpoint_info): Likewise.
 359         * tui/tui-hooks.c (tui_event_create_breakpoint)
 360         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 361         Update.
 362
 363 2019-07-17  Tom Tromey  <tom@tromey.com>
 364
 365         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 366
 367 2019-07-17  Tom Tromey  <tom@tromey.com>
 368
 369         * tui/tui-winsource.c (tui_update_source_window_as_is)
 370         (tui_update_source_windows_with_addr): Update.
 371         * tui/tui-source.h (tui_set_source_content)
 372         (tui_show_symtab_source): Add "win_info" parameter.
 373         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 374         parameter.
 375         (tui_show_symtab_source): Likewise.
 376
 377 2019-07-17  Tom Tromey  <tom@tromey.com>
 378
 379         * tui/tui-wingeneral.c
 380         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 381
 382 2019-07-17  Tom Tromey  <tom@tromey.com>
 383
 384         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 385         (struct tui_cmd_window) <can_scroll>: New method.
 386         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 387         method.
 388
 389 2019-07-17  Tom Tromey  <tromey@adacore.com>
 390
 391         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 392         do_field_signed>: Rename.  Change type of "value".
 393         * ui-out.c (ui_out::field_signed): Rename from field_int.
 394         Change type of "value".
 395         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 396         type of "value".
 397         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 398         do_field_int.  Change type of "value".
 399         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 400         do_field_int.  Change type of "value".
 401         * tracepoint.c (trace_status_mi, tfind_1)
 402         (print_one_static_tracepoint_marker): Update.
 403         * thread.c (print_thread_info_1, print_selected_thread_frame):
 404         Update.
 405         * stack.c (print_frame, print_frame_info): Update.
 406         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 407         Update.
 408         * source.c (print_source_lines_base): Update.
 409         * skip.c (info_skip_command): Update.
 410         * record-btrace.c (btrace_ui_out_decode_error)
 411         (btrace_call_history_src_line): Update.
 412         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 413         Update.
 414         * progspace.c (print_program_space): Update.
 415         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 416         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 417         do_field_int.  Change type of "value".
 418         * mi/mi-out.c (mi_ui_out::do_table_begin)
 419         (mi_ui_out::do_table_header): Update.
 420         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 421         type of "value".
 422         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 423         (mi_cmd_data_list_changed_registers, output_register)
 424         (mi_cmd_data_read_memory, mi_load_progress)
 425         (mi_cmd_trace_frame_collected): Update.
 426         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 427         Update.
 428         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 429         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 430         (mi_cmd_var_list_children, varobj_update_one): Update.
 431         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 432         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 433         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 434         * inferior.c (print_inferior): Update.
 435         * gdb_bfd.c (print_one_bfd): Update.
 436         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 437         Update.
 438         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 439         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 440         do_field_int.  Change type of "value".
 441         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 442         do_field_int.  Change type of "value".
 443         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 444         (print_one_breakpoint_location, print_it_catch_fork)
 445         (print_one_catch_fork, print_it_catch_vfork)
 446         (print_one_catch_vfork, print_it_catch_solib)
 447         (print_it_catch_exec, print_it_ranged_breakpoint)
 448         (print_mention_watchpoint, print_mention_masked_watchpoint)
 449         (bkpt_print_it, update_static_tracepoint): Update.
 450         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 451         * break-catch-syscall.c (print_it_catch_syscall): Update.
 452         * ada-tasks.c (print_ada_task_info): Update.
 453         * ada-lang.c (print_it_exception, print_mention_exception):
 454         Update.
 455
 456 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 457
 458         PR breakpoints/24541
 459         * gdbarch.c: Regenerate.
 460         * gdbarch.h: Regenerate.
 461         * gdbarch.sh: Adjust return type and parameter types for
 462         'stap_adjust_register'.
 463         (i386_stap_adjust_register): Adjust signature and return new
 464         register name.
 465         * stap-probe.c (stap_parse_register_operand): Adjust use of
 466         'gdbarch_stap_adjust_register'.
 467
 468 2019-07-17  Tom Tromey  <tromey@adacore.com>
 469
 470         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 471         declare VEC.
 472         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 473         std::vector.
 474         (struct s390_process_info): Add initializers.
 475         (s390_add_process): Use new.
 476         (s390_linux_nat_target::low_forget_process): Use delete.
 477         (s390_linux_nat_target::low_new_fork)
 478         (s390_linux_nat_target::stopped_by_watchpoint)
 479         (s390_linux_nat_target::low_prepare_to_resume)
 480         (s390_linux_nat_target::insert_watchpoint)
 481         (s390_linux_nat_target::insert_hw_breakpoint)
 482         (s390_linux_nat_target::remove_watchpoint)
 483         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 484
 485 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 486
 487         * aarch64-fbsd-nat.c: Include regcache.h.
 488         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 489         argument.
 490         (aarch64_fbsd_nat_target::fetch_registers)
 491         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 492         variable.
 493         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 494
 495 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 496
 497         * fbsd-nat.c: Include gdbarch.h.
 498
 499 2019-07-15  Tom Tromey  <tromey@adacore.com>
 500
 501         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 502
 503 2019-07-15  Tom Tromey  <tromey@adacore.com>
 504
 505         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 506         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 507         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 508         * cli-out.c (cli_ui_out::do_field_int): New method.
 509         * ui-out.c (ui_out::field_unsigned): New method.
 510         * symfile.c (generic_load): Use field_unsigned.
 511         (print_transfer_performance): Likewise.
 512         * record-btrace.c (ui_out_field_uint): Remove.
 513         (btrace_call_history_insn_range, btrace_call_history): Use
 514         field_unsigned.
 515         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 516         field_unsigned.
 517         * ui-out.h (class ui_out) <field_unsigned>: New method.
 518         <do_field_unsigned>: Likewise.
 519
 520 2019-07-15  Tom Tromey  <tromey@adacore.com>
 521
 522         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 523         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 524         * target.c (flash_erase_command): Use field_string.
 525         * infrun.c (print_signal_received_reason): Use field_string.
 526         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 527         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 528         field_string.
 529         * ada-tasks.c (print_ada_task_info): Use field_string.
 530
 531 2019-07-15  Tom Tromey  <tromey@adacore.com>
 532
 533         * target.c (flash_erase_command): Use field_core_addr.
 534         * symfile.c (generic_load): Use field_core_addr.
 535         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 536         Use field_core_addr.
 537         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 538         field_core_addr.
 539
 540 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 541
 542         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 543         value if its desired type is smaller than a CORE_ADDR and signed.
 544
 545 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 546
 547         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 548         of changes to field names, and use new is_reference field to
 549         decide if a property is a reference or not.
 550         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 551         field.
 552         (struct dwarf2_property_baton): Update header comment, rename
 553         'referenced_type' to 'property_type' and update comments.
 554         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 555         default property type, store in property baton, update to take
 556         accound of renamed field.
 557         (read_func_scope): Update call to attr_to_dynamic_prop.
 558         (read_array_type): Likewise.
 559         (dwarf2_per_cu_addr_sized_int_type): New function.
 560         (read_subrange_index_type): Move type finding code to
 561         dwarf2_per_cu_addr_sized_int_type.
 562         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 563         (dwarf2_per_cu_addr_type): New function.
 564         (set_die_type): Update calls to attr_to_dynamic_prop.
 565
 566 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 567
 568         * dwarf2read.c (read_subrange_index_type): New function.
 569         (read_subrange_type): Move code into new function and call it.
 570         * gdbtypes.c (create_range_type): Add some asserts.
 571
 572 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 573
 574         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 575         update return statements.
 576         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 577         declaration, and update comment to match.
 578         * gdbtypes.c (resolve_dynamic_array): Update call to
 579         dwarf2_evaluate_property to match new return type.
 580
 581 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 582
 583         * valarith.c (value_subscripted_rvalue): Change lowerbound
 584         parameter type from int to LONGEST.
 585         * value.h (value_subscripted_rvalue): Likewise in declaration.
 586
 587 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 588
 589         * cli/cli-utils.c (info_print_command_completer): New function.
 590         * cli/cli-utils.h: Add 'completer.h' include, and forward
 591         declaration for 'struct cmd_list_element'.
 592         (info_print_command_completer): Declare.
 593         * stack.c (_initialize_stack): Add completer for 'info locals' and
 594         'info args'.
 595         * symtab.c (_initialize_symtab): Add completer for 'info
 596         variables' and 'info functions'.
 597         * NEWS: Mention completion for additional info commands.
 598
 599 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 600
 601         * cli/cli-utils.c (extract_info_print_args): Delete.
 602         (extract_arg_maybe_quoted): Delete.
 603         (info_print_options_defs): New variable.
 604         (make_info_print_options_def_group): New function.
 605         (extract_info_print_options): Define new function.
 606         * cli/cli-utils.h (extract_info_print_args): Delete.
 607         (struct info_print_options): New structure.
 608         (extract_info_print_options): Declare new function.
 609         * stack.c (info_locals_command): Update to use new
 610         extract_info_print_options, also add a header comment.
 611         (info_args_command): Likewise.
 612         * symtab.c (info_variables_command): Likewise.
 613         (info_functions_command): Likewise.
 614
 615 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 616
 617         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 618         to extract string arguments.
 619         * common/common-utils.c (extract_string_maybe_quoted): New function.
 620         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 621
 622 2019-07-11  Tom Tromey  <tromey@adacore.com>
 623
 624         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 625         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 626         * top.h (gdbinit): Don't declare.
 627         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 628         into...
 629         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 630         * top.c (gdb_init): Don't call init_cli_cmds.
 631         (gdbinit): Remove.
 632         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 633
 634 2019-07-11  Tom Tromey  <tromey@adacore.com>
 635
 636         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 637         after it has been moved.
 638
 639 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 640
 641         * valops.c (value_must_coerce_to_target): Change return type to
 642         bool.
 643         * value.h (value_must_coerce_to_target): Likewise.
 644
 645 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 646
 647         * breakpoint.c (is_hardware_watchpoint): Remove
 648         forward-declaration.
 649         (is_masked_watchpoint): Change return type to bool.
 650         (is_tracepoint): Likewise.
 651         (is_breakpoint): Likewise.
 652         (is_hardware_watchpoint): Likewise.
 653         (is_watchpoint): Likewise.
 654         (is_no_memory_software_watchpoint): Likewise.
 655         (is_catchpoint): Likewise.
 656         (breakpoint_1): Make FILTER parameter's return type bool.
 657         is_masked_watchpoint): Change return type to bool.
 658         (save_breakpoints): Make FILTER parameter's return type bool.
 659         * breakpoint.h (is_breakpoint): Change return type to bool.
 660         (is_watchpoint): Likewise.
 661         (is_catchpoint): Likewise.
 662         (is_tracepoint): Likewise.
 663
 664 2019-07-10  Tom Tromey  <tom@tromey.com>
 665
 666         * defs.h: Don't include gdbarch.h.
 667         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 668         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 669         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 670         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 671         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 672         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 673         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 674         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 675         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 676         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 677         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 678         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 679         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 680         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 681         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 682         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 683         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 684         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 685         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 686         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 687         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 688         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 689         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 690         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 691         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 692         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 693         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 694
 695 2019-07-10  Tom Tromey  <tromey@adacore.com>
 696
 697         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 698         * breakpoint.c (init_ada_exception_breakpoint): Register as
 699         bp_catchpoint.
 700         (print_one_breakpoint_location, print_one_breakpoint): Use
 701         is_ada_exception_catchpoint.
 702         * ada-lang.c (class ada_catchpoint_location): Pass
 703         bp_loc_software_breakpoint to bp_location constructor.
 704         (is_ada_exception_catchpoint): New function.
 705
 706 2019-07-10  Tom Tromey  <tromey@adacore.com>
 707
 708         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 709         VEC.
 710         (struct arm_exidx_entry): New method operator<.
 711         (struct arm_exidx_data) <section_maps>: Change type.
 712         (arm_exidx_data_free): Remove.
 713         (arm_exidx_data_key): Change type.  Move lower.
 714         (arm_exidx_new_objfile): Update.
 715         (arm_compare_exidx_entries): Remove.
 716         (arm_find_exidx_entry, _initialize_arm_tdep)
 717
 718 2019-07-10  Tom Tromey  <tromey@adacore.com>
 719
 720         * solib-spu.c (ocl_program_data_key): Change type.
 721         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 722         Update.
 723
 724 2019-07-10  Tom Tromey  <tromey@adacore.com>
 725
 726         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 727         (struct solib_aix_inferior_data) <library_list>: Change type.
 728         (solib_aix_inferior_data_handle): Change type.
 729         (get_solib_aix_inferior_data): Update.
 730         (solib_aix_free_library_list): Remove.
 731         (library_list_start_library): Update.
 732         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 733         return type.
 734         (solib_aix_get_library_list)
 735         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 736         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 737
 738 2019-07-10  Tom Tromey  <tromey@adacore.com>
 739
 740         * solib-dsbt.c (struct dsbt_info): Add initializers.
 741         (solib_dsbt_pspace_data): Change type.
 742         (dsbt_pspace_data_cleanup): Remove.
 743         (get_dsbt_info, _initialize_dsbt_solib): Update.
 744
 745 2019-07-10  Tom Tromey  <tromey@adacore.com>
 746
 747         * spu-tdep.c (spu_overlay_data): Change type.
 748         (spu_get_overlay_table, spu_overlay_new_objfile)
 749         (_initialize_spu_tdep): Update.
 750
 751 2019-07-10  Tom Tromey  <tromey@adacore.com>
 752
 753         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 754         destructor.
 755         (dbx_objfile_data_key): Change type and declare later.
 756         (DBX_SYMFILE_INFO): Rewrite.
 757         * dbxread.c (dbx_objfile_data_key): Change type.
 758         (dbx_symfile_init): Update.
 759         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 760         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 761         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 762
 763 2019-07-10  Tom Tromey  <tromey@adacore.com>
 764
 765         * jit.c (jit_program_space_key): Change type.  Move lower.
 766         (get_jit_program_space_data): Update.
 767         (jit_program_space_data_cleanup): Remove.
 768         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 769         Update.
 770         (struct jit_program_space_data): Add initializers.
 771
 772 2019-07-10  Tom Tromey  <tromey@adacore.com>
 773
 774         * solib-darwin.c (struct darwin_info): Add initializers.
 775         (solib_darwin_pspace_data): Change type.
 776         (darwin_pspace_data_cleanup): Remove.
 777         (get_darwin_info, _initialize_darwin_solib): Update.
 778
 779 2019-07-10  Tom Tromey  <tromey@adacore.com>
 780
 781         * remote-sim.c (struct sim_inferior_data): Add initializers,
 782         constructor, and destructor.
 783         (sim_inferior_data_key): Change type.  Move lower.
 784         (check_for_duplicate_sim_descriptor): Update.
 785         (get_sim_inferior_data): Use new.  Update.
 786         (~sim_inferior_data_cleanup): Rename from
 787         sim_inferior_data_cleanup.  Simplify.
 788         (gdbsim_close_inferior, simulator_command)
 789         (sim_command_completer, _initialize_remote_sim): Update.
 790         (next_pid, INITIAL_PID): Move earlier.
 791
 792 2019-07-10  Tom Tromey  <tromey@adacore.com>
 793
 794         * python/python-internal.h (create_thread_object): Return
 795         gdbpy_ref.
 796         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 797         * python/py-inferior.c (struct threadlist_entry): Add
 798         constructor.
 799         <thread_obj>: Now a gdbpy_ref.
 800         (thread_to_thread_object): Update.
 801         (add_thread_object): Use new.
 802         (delete_thread_object): Use delete.
 803         (infpy_threads): Update.
 804         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 805         GIL.
 806
 807 2019-07-10  Tom Tromey  <tromey@adacore.com>
 808
 809         * valops.c (value_cast): Specialize error message for Ada.
 810
 811 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 812
 813         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 814
 815 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 816
 817         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 818         bpstat_should_step): Return bool, adjust comments.
 819         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 820         bpstat_should_step): Likewise.
 821
 822 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 823
 824         * features/Makefile: Use feature target descriptions for Arm.
 825         * features/arm/arm-core.c: Generate new file.
 826         * features/arm/arm-fpa.c: Likewise.
 827         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 828         * features/arm/arm-m-profile.c: Likewise.
 829         * features/arm/arm-vfpv2.c: Likewise.
 830         * features/arm/arm-vfpv3.c: Likewise.
 831         * features/arm/xscale-iwmmxt.c: Likewise.
 832         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 833
 834 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 835
 836         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 837         ptrace earlier.
 838
 839 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 840
 841         * features/aarch64-pauth.c: Regenerate.
 842
 843 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 844
 845         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 846         bool.
 847         (bpstat_what): Use false instead of 0.
 848
 849 2019-07-09  Pedro Alves  <palves@redhat.com>
 850
 851         * break-catch-throw.c (is_exception_catchpoint): New.
 852         * breakpoint.c (print_one_breakpoint_location): New parameter
 853         'raw_loc'.  Handle it.  Use
 854         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 855         looking at the breakpoint's type.
 856         (print_one_breakpoint): If handling "maint info breakpoints", also
 857         print locations of exception catchpoints.
 858         * breakpoint.h (is_exception_catchpoint): Declare.
 859
 860 2019-07-09  Pedro Alves  <palves@redhat.com>
 861
 862         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 863         "addr" field.
 864         (allocate_location_exception_catchpoint): New.
 865         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 866         (initialize_throw_catchpoint_ops): Install
 867         allocate_location_exception_catchpoint as allocate_location
 868         method.
 869         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 870         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 871         bp_loc_other.
 872         (breakpoint_address_is_meaningful): Delete.
 873         (bl_address_is_meaningful): New.
 874         (breakpoint_locations_match): Adjust comment.
 875         (bp_location_from_bp_type): New, factored out of...
 876         (bp_location::bp_location(breakpoint *)): ... this.
 877         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 878         factored out of...
 879         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 880         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 881         breakpoint_address_is_meaningful.
 882         (bp_locations_compare): Adjust comment.
 883         (update_global_location_list): Use bl_address_is_meaningful
 884         instead of breakpoint_address_is_meaningful.
 885         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 886         explicit.
 887         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 888         * python/py-breakpoint.c (bppy_get_location): No longer check
 889         whether location is null.
 890
 891 2019-07-09  Pedro Alves  <palves@redhat.com>
 892
 893         PR c++/15468
 894         * breakpoint.c (print_one_breakpoint_location): Remove
 895         single-location assert.
 896
 897 2019-07-09  Tom Tromey  <tom@tromey.com>
 898
 899         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 900         * configure: Rebuild.
 901         * configure.ac: Change common to gdbsupport.
 902         * gdbsupport: Rename from common.
 903         * acinclude.m4: Change common to gdbsupport.
 904         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 905         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 906         gdbsupport.
 907         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 908         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 909         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 910         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 911         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 912         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 913         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 914         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 915         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 916         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 917         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 918         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 919         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 920         coff-pe-read.c, command.h, compile/compile-c-support.c,
 921         compile/compile-c.h, compile/compile-cplus-symbols.c,
 922         compile/compile-cplus-types.c, compile/compile-cplus.h,
 923         compile/compile-loc2c.c, compile/compile.c, completer.c,
 924         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 925         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 926         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 927         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 928         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 929         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 930         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 931         features/aarch64-core.c, features/aarch64-fpu.c,
 932         features/aarch64-pauth.c, features/aarch64-sve.c,
 933         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 934         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 935         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 936         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 937         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 938         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 939         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 940         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 941         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 942         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 943         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 944         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 945         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 946         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 947         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 948         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 949         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 950         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 951         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 952         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 953         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 954         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 955         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 956         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 957         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 958         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 959         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 960         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 961         minsyms.c, mips-linux-tdep.c, namespace.h,
 962         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 963         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 964         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 965         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 966         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 967         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 968         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 969         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 970         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 971         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 972         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 973         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 974         procfs.c, producer.c, progspace.h, psymtab.h,
 975         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 976         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 977         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 978         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 979         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 980         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 981         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 982         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 983         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 984         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 985         target-memory.c, target.c, target.h, target/waitstatus.c,
 986         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 987         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 988         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 989         unittests/array-view-selftests.c,
 990         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 991         unittests/common-utils-selftests.c,
 992         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 993         unittests/format_pieces-selftests.c,
 994         unittests/function-view-selftests.c,
 995         unittests/lookup_name_info-selftests.c,
 996         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 997         unittests/mkdir-recursive-selftests.c,
 998         unittests/observable-selftests.c,
 999         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1000         unittests/parse-connection-spec-selftests.c,
1001         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1002         unittests/scoped_fd-selftests.c,
1003         unittests/scoped_mmap-selftests.c,
1004         unittests/scoped_restore-selftests.c,
1005         unittests/string_view-selftests.c, unittests/style-selftests.c,
1006         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1007         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1008         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1009         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1010         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1011         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1012
1013 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1014
1015         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1016         bool value.
1017         (decode_digits_ordinary): Set explicit_line field in sal.
1018         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1019         symtab_and_line that was set on an explicit line number in
1020         assembler code.  Do always update the recorded symtab and line if
1021         we do skip the prologue.
1022
1023 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1024
1025         * breakpoint.c (set_breakpoint_location_function): Remove
1026         explicit_loc parameter.
1027         (momentary_breakpoint_from_master): Update call to
1028         set_breakpoint_location_function.
1029         (add_location_to_breakpoint): Likewise.
1030
1031 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1032
1033         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1034         required features based on default bfd type when no specific bfd
1035         is present.
1036
1037 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1038
1039         * NEWS: Mention that GDB printf and eval commands can now print
1040         C-style and Ada-style convenience var strings without
1041         calling the inferior.
1042         * printcmd.c (printf_c_string): Locally print GDB internal var
1043         instead of transiting via the inferior.
1044         (printf_wide_c_string): Likewise.
1045
1046 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1047
1048         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1049
1050 2019-07-04  Tom Tromey  <tom@tromey.com>
1051
1052         PR tui/24724:
1053         * tui/tui-winsource.c (tui_clear_source_content): Update.
1054         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1055         (tui_update_breakpoint_info): Update.
1056         (tui_set_exec_info_content): Update.
1057         * tui/tui-source.c (tui_set_source_content_nil): Update.
1058         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1059         has_break.
1060         * tui/tui-data.h (enum tui_bp_flag): New.
1061         (tui_bp_flags): New enum flags type.
1062         (struct tui_source_element) <break_mode>: Change type.  Rename
1063         from has_break.
1064         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1065         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1066         constants.
1067         * tui/tui-winsource.h: Fix comment.
1068
1069 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1070
1071         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1072         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1073         (store_fpregs_to_thread)
1074         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1075         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1076         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1077         (IWMMXT_REGS_SIZE): Add define.
1078         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1079         (fetch_vfp_regs, store_vfp_regs)
1080         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1081         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1082
1083 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1084
1085         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1086         defines.
1087         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1088         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1089         (ARM_INT_REGISTER_SIZE): ...to this.
1090         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1091         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1092         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1093         (arm_linux_collect_gregset, supply_nwfpe_register)
1094         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1095         defines.
1096         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1097         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1098         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1099         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1100         (arm_return_in_memory, arm_store_return_value)
1101         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1102         (arm_record_ld_st_multiple): Likewise.
1103         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1104         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1105
1106 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1107
1108         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1109         AARCH64_DISPLACED_MODIFIED_INSNS.
1110         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1111         (aarch64_displaced_step_copy_insn): Likewise.
1112         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1113         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1114         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1115         ARM_DISPLACED_MODIFIED_INSNS.
1116         * arm-tdep.c (arm_gdbarch_init): Likewise.
1117         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1118         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1119         (struct arm_displaced_step_closure): Use
1120         ARM_DISPLACED_MODIFIED_INSNS.
1121
1122 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1123
1124         * features/Makefile: Remove unused xml files.
1125         * features/aarch64.xml: Remove.
1126         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1127         * features/i386/amd64-avx-avx512.xml: Remove.
1128         * features/i386/amd64-avx-linux.xml: Remove.
1129         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1130         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1131         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1132         * features/i386/amd64-avx-mpx.xml: Remove.
1133         * features/i386/amd64-avx.xml: Remove.
1134         * features/i386/amd64-linux.xml: Remove.
1135         * features/i386/amd64-mpx-linux.xml: Remove.
1136         * features/i386/amd64-mpx.xml: Remove.
1137         * features/i386/amd64.xml: Remove.
1138         * features/i386/i386-avx-avx512-linux.xml: Remove.
1139         * features/i386/i386-avx-avx512.xml: Remove.
1140         * features/i386/i386-avx-linux.xml: Remove.
1141         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1142         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1143         * features/i386/i386-avx-mpx-linux.xml: Remove.
1144         * features/i386/i386-avx-mpx.xml: Remove.
1145         * features/i386/i386-avx.xml: Remove.
1146         * features/i386/i386-linux.xml: Remove.
1147         * features/i386/i386-mmx-linux.xml: Remove.
1148         * features/i386/i386-mmx.xml: Remove.
1149         * features/i386/i386-mpx-linux.xml: Remove.
1150         * features/i386/i386-mpx.xml: Remove.
1151         * features/i386/i386.xml: Remove.
1152         * features/i386/x32-avx-avx512-linux.xml: Remove.
1153         * features/i386/x32-avx-linux.xml: Remove.
1154         * features/i386/x32-linux.xml: Remove.
1155
1156 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1157
1158         * regformats/aarch64.dat: Remove.
1159         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1160         * regformats/i386/amd64-avx-linux.dat: Remove.
1161         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1162         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1163         * regformats/i386/amd64-linux.dat: Remove.
1164         * regformats/i386/amd64-mpx-linux.dat: Remove.
1165         * regformats/i386/amd64.dat: Remove.
1166         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1167         * regformats/i386/i386-avx-linux.dat: Remove.
1168         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1169         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1170         * regformats/i386/i386-linux.dat: Remove.
1171         * regformats/i386/i386-mmx-linux.dat: Remove.
1172         * regformats/i386/i386-mpx-linux.dat: Remove.
1173         * regformats/i386/i386.dat: Remove.
1174         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1175         * regformats/i386/x32-avx-linux.dat: Remove.
1176         * regformats/i386/x32-linux.dat: Remove.
1177
1178 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1179
1180         * aarch64-tdep.c: Remove xml self tests.
1181         * amd64-linux-tdep.c: Likewise.
1182         * amd64-tdep.c: Likewise.
1183         * i386-linux-tdep.c: Likewise.
1184         * i386-tdep.c: Likewise.
1185
1186 2019-07-03  Pedro Alves  <palves@redhat.com>
1187
1188         PR cli/24732
1189         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1190         (pipe_cmd_option_defs): New.
1191         (make_pipe_cmd_options_def_group): New.
1192         (pipe_command): Use gdb::option::process_options.
1193         (pipe_command_completer): New function.
1194         (_initialize_cli_cmds): Install completer for "pipe" command.
1195
1196 2019-07-03  Pedro Alves  <palves@redhat.com>
1197
1198         * cli/cli-option.c (union option_value) <string>: New field.
1199         (struct option_def_and_value): Add ctor, move ctor, dtor and
1200         use DISABLE_COPY_AND_ASSIGN.
1201         (option_def_and_value::clear_value): New.
1202         (parse_option, save_option_value_in_ctx, get_val_type_str)
1203         (add_setshow_cmds_for_options): Handle var_string.
1204         * cli-option.h (union option_def::var_address) <string>: New
1205         field.
1206         (struct string_option_def): New.
1207         * maint-test-options.c (struct test_options_opts): Add default
1208         ctor and use DISABLE_COPY_AND_ASSIGN.
1209         <string_opt>: New field.
1210         (test_options_opts::~test_options_opts): New.
1211         (test_options_opts::dump): Also dump "-string".
1212         (test_options_option_defs): Install "string.
1213
1214 2019-07-03  Pedro Alves  <palves@redhat.com>
1215
1216         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1217         option_value with a null enumeration.
1218         (complete_options): Save the option values in the context.
1219         (save_option_value_in_ctx): New, factored out from ...
1220         (process_options): ... here.
1221         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1222         of the function.
1223         * maint-test-options.c (test_options_opts::dump): New, factored
1224         out from ...
1225         (maintenance_test_options_command_mode): ... here.
1226         (maintenance_test_options_command_completion_result): Delete.
1227         (maintenance_test_options_command_completion_text): Update
1228         comment.
1229         (maintenance_show_test_options_completion_result): Change
1230         prototype.  Just print
1231         maintenance_test_options_command_completion_text.
1232         (save_completion_result): New.
1233         (maintenance_test_options_completer_mode): Pass options context to
1234         complete_options, and then save a dump.
1235         (_initialize_maint_test_options): Use add_cmd to install "maint
1236         show test-options-completion-result".
1237
1238 2019-07-03  Pedro Alves  <palves@redhat.com>
1239
1240         * NEWS (New commands): Mention "with" and "maint with".
1241         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1242         (with_command, with_command_completer): New.
1243         (pipe_command): Adjust to new repeat_previous
1244         interface.
1245         (_initialize_cli_cmds): Install the "with" command and its "w"
1246         alias.
1247         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1248         declarations.
1249         * cli/cli-setshow.c (parse_cli_var_uinteger)
1250         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1251         argument strings for all var_types.
1252         (get_setshow_command_value_string): New, factored out from ...
1253         (do_show_command): ... this.
1254         * cli/cli-setshow.h: Include <string>.
1255         (get_setshow_command_value_string): Declare.
1256         * command.h (repeat_previous): Now returns const char *.  Adjust
1257         comment.
1258         * maint.c: Include "cli/cli-cmds.h".
1259         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1260         (_initialize_maint_cmds): Register the "maintenance with" command.
1261         * top.c (repeat_previous): Move bits from pipe_command here:
1262         Return the saved command line, if any; error out if there's no
1263         command to relaunch.
1264
1265 2019-07-03  Pedro Alves  <palves@redhat.com>
1266
1267         * NEWS (New commands): Mention "maint set/show test-settings"
1268         instead of "maint test-settings".
1269         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1270         (maintenance_test_settings_set_list): Rename to ...
1271         (maintenance_set_test_settings_list): ... this.
1272         (maintenance_test_settings_show_list): Rename to  ...
1273         (maintenance_show_test_settings_list): ... this.
1274         (maintenance_test_settings_cmd): Delete.
1275         (maintenance_test_settings_set_cmd): ...
1276         (maintenance_set_test_settings_cmd): ... this.
1277         (maintenance_test_settings_show_cmd): ...
1278         (maintenance_show_test_settings_cmd): ... this.
1279         (maintenance_test_settings_show_value_cmd):
1280         (maintenance_show_test_settings_value_cmd): ... this.
1281         (_initialize_maint_test_settings): No longer install the "maint
1282         test-settings" prefix command.  Rename "maint test-settings set"
1283         to "maint set test-settings", and "maint test-settings show" to
1284         "maint show test-settings".  Adjust all subcommands.
1285
1286 2019-07-03  Pedro Alves  <palves@redhat.com>
1287
1288         * maint-test-settings.c: Fix file's intro comment.  Replace all
1289         references to "test-options" with references to "test-settings",
1290         in comments.
1291
1292 2019-07-03  Pedro Alves  <palves@redhat.com>
1293
1294         * maint-test-settings.c (maintenance_test_settings_xxx)
1295         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1296         New.
1297         (maintenance_test_settings_enums): Use them.
1298         (maintenance_test_settings_enum): Default to
1299         maintenance_test_settings_xxx.
1300         (_initialize_maint_test_settings): Initialize
1301         MAINTENANCE_TEST_SETTINGS_FILENAME.
1302
1303 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1304
1305         * breakpoint.h (remove_breakpoints_inf): Change return type to
1306         void, move function documentation here.
1307         * breakpoint.c (remove_breakpoints_inf): Change return type to
1308         void, move function documentation to header.
1309
1310 2019-07-02  Pedro Alves  <palves@redhat.com>
1311
1312         * NEWS (Completion improvements): Mention "info threads".
1313         * thread.c (struct info_threads_opts, info_threads_option_defs)
1314         (make_info_threads_options_def_group): New.
1315         (info_threads_command): Use gdb::option::process_options.
1316         (info_threads_command_completer): New.
1317         (_initialize_thread): Use gdb::option::build_help to build the
1318         help text for "info threads".
1319
1320 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1321
1322         * defs.h (generic_load): Move from here...
1323         * symfile.h (generic_load): ... to here.  Rename name parameter
1324         to args.
1325         * symfile.c (generic_load): Add comment.
1326
1327 2019-07-01  Tom Tromey  <tromey@adacore.com>
1328
1329         * dwarf2read.c
1330         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1331         declaration of without_params.  Fix formatting.
1332
1333 2019-07-01  Tom Tromey  <tromey@adacore.com>
1334
1335         * ada-exp.y (find_primitive_type): Update.
1336         * ada-lang.h (ada_lookup_symbol): Update.
1337         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1338         parameter.
1339         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1340
1341 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1342
1343         PR breakpoints/24541
1344         * gdbarch.c: Regenerate.
1345         * gdbarch.h: Regenerate.
1346         * gdbarch.sh: Add 'stap_adjust_register'.
1347         * i386-tdep.c: Include '<unordered_set>'.
1348         (i386_stap_adjust_register): New function.
1349         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1350         * stap-probe.c (stap_parse_register_operand): Call
1351         'gdbarch_stap_adjust_register'.
1352
1353 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1354
1355         PR python/24742
1356         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1357         * python/python.c (do_start_initialization): Use 'xmalloc'
1358         instead of 'PyMem_Malloc'.
1359
1360 2019-06-28  Tom Tromey  <tromey@adacore.com>
1361
1362         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1363         for Ada.
1364
1365 2019-06-27  Tom Tromey  <tromey@adacore.com>
1366
1367         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1368         objfile_key.
1369         (arm_find_mapping_symbol, arm_record_special_symbol)
1370         (_initialize_arm_tdep): Update.
1371         (arm_objfile_data_free): Remove.
1372
1373 2019-06-27  Tom Tromey  <tromey@adacore.com>
1374
1375         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1376         to cp_print_static_field.
1377
1378 2019-06-26  Tom Tromey  <tromey@adacore.com>
1379
1380         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1381         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1382         declare.
1383
1384 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1385
1386         * features/aarch64-core.c (create_feature_aarch64_core):
1387         Regenerate.
1388         * features/aarch64-core.xml: Add cpsr flags.
1389
1390 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1391
1392         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1393         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1394
1395 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1396
1397         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1398         field.
1399         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1400         use.
1401         (arm_record_special_symbol): Don't insert new symbol in sorted
1402         position, push it at the end.
1403
1404 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1405
1406         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1407         (arm_mapping_symbol_s): Remove.
1408         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1409         (arm_mapping_symbol_vec): New typedef.
1410         (struct arm_per_objfile): Add constructor.
1411         <section_maps>: Change type to
1412         std::unique_ptr<arm_mapping_symbol_vec[]>.
1413         (arm_compare_mapping_symbols): Remove.
1414         (arm_find_mapping_symbol): Adjust to section_maps type change.
1415         (arm_objfile_data_free): Call delete on arm_per_objfile.
1416         (arm_record_special_symbol): Adjust to section_maps type change.
1417         Allocate arm_per_objfile with new.
1418
1419 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1420
1421         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1422         with the command prefix.
1423
1424 2019-06-25  Tom Tromey  <tom@tromey.com>
1425
1426         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1427         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1428
1429 2019-06-25  Tom Tromey  <tom@tromey.com>
1430
1431         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1432         type.
1433         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1434         protected.
1435
1436 2019-06-25  Tom Tromey  <tom@tromey.com>
1437
1438         * tui/tui-winsource.c
1439         (tui_source_window_base::set_is_exec_point_at): Add check against
1440         LOA_ADDRESS.
1441
1442 2019-06-25  Tom Tromey  <tom@tromey.com>
1443
1444         * tui/tui-source.c (tui_set_source_content): Don't check before
1445         xfree.
1446         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1447
1448 2019-06-25  Tom Tromey  <tom@tromey.com>
1449
1450         * tui/tui-winsource.h (tui_update_source_window_as_is)
1451         (tui_alloc_source_buffer, tui_line_is_displayed)
1452         (tui_addr_is_displayed): Change type of win_info.
1453         * tui/tui-winsource.c (tui_update_source_window_as_is)
1454         (tui_clear_source_content, tui_show_source_line)
1455         (tui_show_source_content, tui_source_window_base::refill)
1456         (tui_source_window_base::set_is_exec_point_at)
1457         (tui_source_window_base::set_is_exec_point_at)
1458         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1459         (tui_alloc_source_buffer, tui_line_is_displayed)
1460         (tui_addr_is_displayed): Change type of win_info.  Update.
1461         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1462         (tui_source_window_base::do_make_visible_with_new_height):
1463         Update.
1464         * tui/tui-source.c (tui_set_source_content)
1465         (tui_set_source_content_nil)
1466         (tui_source_window::do_scroll_vertical): Update.
1467         * tui/tui-layout.c (show_layout): Update.
1468         * tui/tui-disasm.c (tui_set_disassem_content)
1469         (tui_disasm_window::do_scroll_vertical): Update.
1470         * tui/tui-data.h (tui_win_content): Remove.
1471         (struct tui_gen_win_info) <content, content_size>: Remove.
1472         (struct tui_source_element): Add initializers and destructor.
1473         (union tui_which_element, struct tui_win_element): Remove.
1474         (struct tui_source_window_base) <content>: New field.
1475         (struct tui_data_window): Remove destructor.
1476         (tui_alloc_content, tui_free_win_content)
1477         (tui_free_all_source_wins_content): Don't declare.
1478         * tui/tui-data.c (tui_initialize_static_data): Update.
1479         (init_content_element, tui_alloc_content): Remove.
1480         (~tui_gen_win_info): Update.
1481         (~tui_data_window, tui_free_all_source_wins_content)
1482         (tui_free_win_content, free_content, free_content_elements):
1483         Remove.
1484
1485 2019-06-25  Tom Tromey  <tom@tromey.com>
1486
1487         * tui/tui-winsource.h (tui_clear_source_content)
1488         (tui_erase_source_content, tui_show_source_content): Change type
1489         of win_info.
1490         * tui/tui-winsource.c (tui_clear_source_content)
1491         (tui_erase_source_content, tui_show_source_content): Change type
1492         of win_info.
1493         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1494         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1495         win_info.
1496         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1497         win_info.
1498         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1499
1500 2019-06-25  Tom Tromey  <tom@tromey.com>
1501
1502         * tui/tui-winsource.c (tui_clear_source_content)
1503         (tui_source_window_base::set_is_exec_point_at): Update.
1504         * tui/tui-source.c (tui_set_source_content_nil): Update.
1505         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1506         a bool.
1507         * tui/tui-data.c (init_content_element): Update.
1508
1509 2019-06-25  Tom Tromey  <tom@tromey.com>
1510
1511         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1512         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1513         * tui/tui-layout.c (init_and_make_win): Update.
1514         * tui/tui.h (enum tui_win_type): Update.
1515         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1516         tui_win_is_auxillary.
1517         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1518         tui_win_is_auxillary.
1519
1520 2019-06-25  Tom Tromey  <tom@tromey.com>
1521
1522         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1523         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1524         (tui_delete_data_content_windows, tui_display_all_data)
1525         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1526         Update.
1527         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1528         * tui/tui-regs.c (tui_last_regs_line_no)
1529         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1530         (tui_show_registers): Update.
1531         (tui_show_register_group): Return void.  Update.
1532         (tui_display_registers_from, tui_display_reg_element_at_line)
1533         (tui_display_registers_from_line, tui_check_register_values):
1534         Update.
1535         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1536         member.
1537         (struct tui_data_window) <regs_content>: Now a std::vector.
1538         <regs_content_count>: Remove.
1539         (tui_add_content_elements, tui_free_data_content): Don't declare.
1540         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1541         (init_content_element): Remove DATA_WIN case.  Add assert.
1542         (tui_add_content_elements): Remove.
1543         (tui_data_window): Update.
1544         (tui_free_data_content): Remove.
1545         (free_content_elements): Remove DATA_WIN case.
1546
1547 2019-06-25  Tom Tromey  <tom@tromey.com>
1548
1549         * tui/tui-data.c (tui_data_item_window): Update.
1550         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1551         * tui/tui-windata.c (tui_display_all_data)
1552         (tui_display_data_from_line): Update.
1553         (tui_check_data_values): Remove.
1554         * tui/tui-regs.c (tui_show_register_group)
1555         (tui_display_reg_element_at_line): Update.
1556         * tui/tui-hooks.c (tui_register_changed)
1557         (tui_refresh_frame_and_register_information): Call
1558         tui_check_register_values.
1559         * tui/tui-data.h (struct tui_data_window) <data_content,
1560         data_content_count, data_type>: Remove.
1561         (enum tui_data_type): Remove.
1562
1563         * tui/tui-data.c (tui_data_window::clear_detail)
1564         (~tui_data_window): Update.
1565
1566 2019-06-25  Tom Tromey  <tom@tromey.com>
1567
1568         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1569         declare.
1570         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1571         Rename from tui_first_data_item_displayed.  Update.
1572         (tui_data_window::refresh_all)
1573         (tui_data_window::do_scroll_vertical): Update.
1574         * tui/tui-data.h (struct tui_data_window)
1575         <first_data_item_displayed>: Declare new method.
1576
1577 2019-06-25  Tom Tromey  <tom@tromey.com>
1578
1579         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1580         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1581         contents...
1582         (tui_initialize_static_data): ...here.
1583
1584 2019-06-25  Tom Tromey  <tom@tromey.com>
1585
1586         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1587         (tui_display_registers_from, tui_check_register_values): Update.
1588         (tui_display_register): Remove win_info parameter; update.
1589         (tui_get_register): Change type of parameters.
1590         * tui/tui-data.h (struct tui_data_element): Remove.
1591         (union tui_which_element) <data>: Remove.
1592         <data_window>: Change type.
1593         (struct tui_data_item_window): New.
1594         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1595         case.  Add assert.
1596         (~tui_data_item_window): New destructor.
1597         (free_content_elements): Remove DATA_ITEM_WIN case.
1598
1599 2019-06-25  Tom Tromey  <tom@tromey.com>
1600
1601         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1602         Remove.
1603
1604 2019-06-25  Tom Tromey  <tom@tromey.com>
1605
1606         * tui/tui-data.h (struct tui_command_element): Remove.
1607         (union tui_which_element) <command>: Remove.
1608         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1609         assert.
1610         (free_content_elements): Remove CMD_WIN case.
1611
1612 2019-06-25  Tom Tromey  <tom@tromey.com>
1613
1614         * tui/tui-layout.c (tui_set_layout): Update.
1615         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1616         * tui/tui-data.c (layout_def): Update.
1617
1618 2019-06-25  Tom Tromey  <tom@tromey.com>
1619
1620         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1621         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1622         (tui_source_window_base::set_new_height): Update.
1623         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1624         Update.
1625         (tui_set_locator_fullname, tui_set_locator_info)
1626         (tui_show_frame_info): Update.
1627         * tui/tui-source.c (tui_set_source_content)
1628         (tui_source_is_displayed): Update.
1629         * tui/tui-layout.c (show_source_disasm_command, show_data)
1630         (show_source_or_disasm_and_command): Update.
1631         * tui/tui-disasm.c (tui_set_disassem_content)
1632         (tui_get_begin_asm_address): Update.
1633         * tui/tui-data.h (struct tui_locator_element): Remove.
1634         (union tui_which_element) <locator>: Remove.
1635         (struct tui_locator_window): New.
1636         (tui_locator_win_info_ptr): Change return type.
1637         * tui/tui-data.c (_locator): Change type.
1638         (tui_locator_win_info_ptr): Change return type.
1639         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1640         (tui_alloc_content): Add assert.
1641
1642 2019-06-25  Tom Tromey  <tom@tromey.com>
1643
1644         * tui/tui-winsource.c
1645         (tui_exec_info_window::maybe_allocate_content): New method.
1646         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1647         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1648         (make_source_or_disasm_window): Add cast.
1649         * tui/tui-data.h (union tui_which_element) <simple_string>:
1650         Remove.
1651         (struct tui_source_info): New.
1652         (struct tui_source_window_base) <execution_info>: Change type.
1653         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1654         case, and add assert.
1655         (tui_alloc_content): Add assert.
1656
1657 2019-06-25  Tom Tromey  <tom@tromey.com>
1658
1659         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1660         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1661         * tui/tui-data.c (tui_alloc_win_info): Remove.
1662
1663 2019-06-25  Tom Tromey  <tom@tromey.com>
1664
1665         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1666         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1667         can_highlight.
1668
1669 2019-06-25  Tom Tromey  <tom@tromey.com>
1670
1671         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1672         make_visible_with_new_height method.
1673         (tui_win_info::make_visible_with_new_height): New method.
1674         (tui_source_window_base::do_make_visible_with_new_height)
1675         (tui_data_window::do_make_visible_with_new_height)
1676         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1677         (make_visible_with_new_height): Remove.
1678         (tui_resize_all, tui_adjust_win_heights): Use
1679         make_visible_with_new_height method.
1680         * tui/tui-data.h (struct tui_win_info)
1681         <do_make_visible_with_new_height, make_visible_with_new_height>:
1682         New methods.
1683         (struct tui_source_window_base, struct tui_data_window)
1684         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1685         methods.
1686
1687 2019-06-25  Tom Tromey  <tom@tromey.com>
1688
1689         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1690         method.
1691         (update_tab_width): Call update_tab_width method.
1692         * tui/tui-data.h (struct tui_win_info)
1693         (struct tui_source_window_base) <update_tab_width>: New methods.
1694
1695 2019-06-25  Tom Tromey  <tom@tromey.com>
1696
1697         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1698         parameter.
1699         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1700         parameter.
1701         (tui_gen_win_info::make_visible): Update.
1702         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1703         parameter.
1704         * tui/tui-data.h (enum tui_box): New enum.
1705         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1706
1707 2019-06-25  Tom Tromey  <tom@tromey.com>
1708
1709         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1710         init_and_make_win for EXEC_INFO_WIN.
1711         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1712         longer inline.
1713         (struct tui_win_info) <~tui_win_info>: Inline.
1714         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1715         Don't declare.
1716         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1717         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1718         Remove.
1719         (tui_initialize_static_data): Update.
1720         (~tui_gen_win_info): Handle more cleanup here.
1721         (~tui_source_window_base): Delete "execution_info".
1722         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1723
1724 2019-06-25  Tom Tromey  <tom@tromey.com>
1725
1726         * tui/tui-layout.c (make_command_window): Don't set
1727         can_highlight.
1728         (show_source_disasm_command): Call the reset method.
1729         (show_data): Don't set can_highlight.  Call the reset method.
1730         (tui_gen_win_info::reset): Rename from init_gen_win_info
1731         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1732         (show_source_or_disasm_and_command): Call the reset method.
1733         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1734         (struct tui_cmd_window): Set can_highlight.
1735
1736 2019-06-25  Tom Tromey  <tom@tromey.com>
1737
1738         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1739         from make_visible.
1740         (tui_make_visible, tui_make_invisible): Rewrite.
1741         (tui_win_info::make_visible): Remove.
1742         (tui_source_window_base::make_visible): Update.
1743         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1744         method.  Moved from...
1745         (struct tui_win_info) <make_visible>: ...here.
1746
1747 2019-06-25  Tom Tromey  <tom@tromey.com>
1748
1749         * tui/tui-winsource.c
1750         (tui_source_window_base::do_scroll_horizontal): Remove direction
1751         parameter.
1752         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1753         direction parameter.
1754         * tui/tui-win.c (tui_win_info::forward_scroll)
1755         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1756         (tui_win_info::right_scroll): Update.
1757         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1758         direction parameter.
1759         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1760         direction parameter.
1761         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1762         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1763         Remove direction parameter.
1764         (struct tui_source_window_base, struct tui_source_window)
1765         (struct tui_disasm_window, struct tui_data_window)
1766         (struct tui_cmd_window): Update.
1767
1768 2019-06-25  Tom Tromey  <tom@tromey.com>
1769
1770         * tui/tui-winsource.h (tui_set_exec_info_content)
1771         (tui_show_exec_info_content, tui_erase_exec_info_content)
1772         (tui_clear_exec_info_content, tui_update_exec_info): Change
1773         argument to tui_source_window_base.
1774         * tui/tui-winsource.c (tui_set_exec_info_content)
1775         (tui_show_exec_info_content, tui_erase_exec_info_content)
1776         (tui_clear_exec_info_content, tui_update_exec_info): Change
1777         argument to tui_source_window_base.
1778
1779 2019-06-25  Tom Tromey  <tom@tromey.com>
1780
1781         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1782         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1783
1784 2019-06-25  Tom Tromey  <tom@tromey.com>
1785
1786         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1787         check.
1788
1789 2019-06-25  Tom Tromey  <tom@tromey.com>
1790
1791         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1792         type to void.
1793         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1794         type to void.
1795         * tui/tui-source.c (tui_set_source_content): Update.
1796         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1797
1798 2019-06-25  Tom Tromey  <tom@tromey.com>
1799
1800         * tui/tui-win.c (window_name_completer, tui_set_focus)
1801         (tui_all_windows_info): Use name method.
1802         * tui/tui-data.h (struct tui_gen_win_info)
1803         (struct tui_source_window, struct tui_disasm_window)
1804         (struct tui_data_window, struct tui_cmd_window) <name>: New
1805         method.
1806         (tui_win_name): Don't declare.
1807         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1808         (tui_win_name): Remove.
1809
1810 2019-06-25  Tom Tromey  <tom@tromey.com>
1811
1812         * tui/tui-winsource.h (tui_update_source_window)
1813         (tui_update_source_window_as_is): Change parameter type.
1814         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1815         to be a tui_source_window_base.
1816         (tui_update_source_window_as_is): Likewise.
1817         * tui/tui-win.c (make_visible_with_new_height): Update.
1818
1819 2019-06-25  Tom Tromey  <tom@tromey.com>
1820
1821         * tui/tui-winsource.c (tui_erase_source_content)
1822         (tui_show_source_content, tui_show_exec_info_content)
1823         (tui_erase_exec_info_content): Use refresh_window method.
1824         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1825         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1826         from tui_refresh_win.
1827         (tui_data_window::refresh_window): New method.
1828         (tui_win_info::refresh, tui_source_window_base::refresh)
1829         (tui_refresh_all): Use refresh_window method.
1830         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1831         method.
1832         * tui/tui-regs.c (tui_display_register): Call refresh_window
1833         method.
1834         * tui/tui-layout.c (show_source_disasm_command)
1835         (show_source_or_disasm_and_command): Call refresh_window method.
1836         * tui/tui-data.h (struct tui_gen_win_info)
1837         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1838         New method.
1839
1840 2019-06-25  Tom Tromey  <tom@tromey.com>
1841
1842         * tui/tui.c (tui_rl_other_window, tui_enable)
1843         (tui_is_window_visible, tui_get_command_dimension): Update.
1844         * tui/tui-winsource.c (tui_update_source_window_as_is)
1845         (tui_clear_source_content, tui_erase_source_content)
1846         (tui_show_source_line, tui_source_window_base::refill)
1847         (tui_source_window_base::do_scroll_horizontal)
1848         (tui_source_window_base::set_is_exec_point_at)
1849         (tui_update_breakpoint_info, tui_set_exec_info_content)
1850         (tui_alloc_source_buffer, tui_line_is_displayed)
1851         (tui_addr_is_displayed): Update.
1852         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1853         (tui_check_and_display_highlight_if_needed)
1854         (tui_win_info::make_visible, tui_win_info::refresh)
1855         (tui_refresh_all): Update.
1856         * tui/tui-windata.c (tui_first_data_item_displayed)
1857         (tui_delete_data_content_windows, tui_erase_data_content)
1858         (tui_display_all_data, tui_data_window::refresh_all)
1859         (tui_check_data_values): Update.
1860         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1861         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1862         (tui_win_info::backward_scroll, tui_refresh_all_win)
1863         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1864         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1865         (tui_source_window_base::set_new_height)
1866         (tui_data_window::set_new_height)
1867         (make_invisible_and_set_new_height)
1868         (make_visible_with_new_height, new_height_ok)
1869         (parse_scrolling_args): Update.
1870         * tui/tui-stack.c (tui_show_frame_info): Update.
1871         * tui/tui-source.c (tui_set_source_content)
1872         (tui_set_source_content_nil, tui_source_is_displayed)
1873         (tui_source_window::do_scroll_vertical): Update.
1874         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1875         (tui_display_registers_from, tui_display_reg_element_at_line)
1876         (tui_check_register_values, tui_reg_command): Update.
1877         * tui/tui-layout.c (tui_default_win_height)
1878         (show_source_disasm_command, show_data, init_and_make_win)
1879         (show_source_or_disasm_and_command): Update.
1880         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1881         (tui_redisplay_readline, tui_mld_flush)
1882         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1883         (tui_getc): Update.
1884         * tui/tui-disasm.c (tui_set_disassem_content)
1885         (tui_disasm_window::do_scroll_vertical): Update.
1886         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1887         Now virtual.
1888         (struct tui_win_info): Derive from tui_gen_win_info.
1889         <~tui_win_info>: Mark as override.
1890         <generic>: Remove member.
1891         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1892         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1893         (~tui_data_window, ~tui_win_info)
1894         (tui_free_all_source_wins_content): Update.
1895         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1896
1897 2019-06-25  Tom Tromey  <tom@tromey.com>
1898
1899         * tui/tui-layout.c (init_and_make_win): Use new.
1900         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1901         destructor, initializers.
1902         (tui_alloc_generic_win_info): Don't declare.
1903         * tui/tui-data.c (_locator): Add argument to constructor.
1904         (source_win, disasm_win): New globals.
1905         (exec_info): Remove.
1906         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1907         Update.
1908         (tui_alloc_generic_win_info): Remove.
1909         (init_content_element): Use new.
1910         (tui_win_info::tui_win_info): Update.
1911         (free_content_elements) <case DATA_WIN>: Use delete.
1912
1913 2019-06-25  Tom Tromey  <tom@tromey.com>
1914
1915         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1916         * tui/tui-windata.c (tui_first_data_item_displayed)
1917         (tui_delete_data_content_windows): Update.
1918         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1919         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1920         (tui_display_registers_from, tui_check_register_values): Update.
1921         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1922         pointer.
1923         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1924         window.
1925         (tui_free_data_content): Update.
1926         (free_content_elements) <case DATA_WIN>: Free the window.
1927
1928 2019-06-25  Tom Tromey  <tom@tromey.com>
1929
1930         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1931         Update.
1932         * tui/tui-layout.c (make_command_window)
1933         (show_source_disasm_command, show_data, init_and_make_win)
1934         (show_source_or_disasm_and_command): Update.
1935         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1936         method.
1937         <can_highight, is_highlighted>: Now bool.
1938         (tui_set_win_highlight): Don't declare.
1939         * tui/tui-data.c (tui_set_win_highlight): Remove.
1940
1941 2019-06-25  Tom Tromey  <tom@tromey.com>
1942
1943         * tui/tui-wingeneral.c (make_visible): Remove check of window
1944         type.
1945
1946 2019-06-25  Tom Tromey  <tom@tromey.com>
1947
1948         * tui/tui-win.c (tui_win_info::max_height)
1949         (tui_cmd_window::max_height): New methods.
1950         (new_height_ok): Call max_height.
1951         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1952         <max_height>: New method.
1953
1954 2019-06-25  Tom Tromey  <tom@tromey.com>
1955
1956         * tui/tui-win.c (tui_source_window_base::set_new_height)
1957         (tui_data_window::set_new_height): New methods.
1958         (make_invisible_and_set_new_height): Call set_new_height method.
1959         * tui/tui-data.h (struct tui_win_info)
1960         (struct tui_source_window_base, struct tui_data_window)
1961         <set_new_height>: New method.
1962
1963 2019-06-25  Tom Tromey  <tom@tromey.com>
1964
1965         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1966         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1967         tui_refresh_data_win.
1968         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1969         method.
1970         (tui_refresh_all_win): Call the refresh_all method.
1971         (tui_set_focus): Likewise.
1972         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1973         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1974         Likewise.
1975
1976 2019-06-25  Tom Tromey  <tom@tromey.com>
1977
1978         * tui/tui-winsource.h (tui_refill_source_window)
1979         (tui_set_is_exec_point_at): Don't declare.
1980         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1981         (tui_source_window_base::refill): Rename from
1982         tui_refill_source_window.
1983         (tui_source_window_base::do_scroll_horizontal): Update.
1984         (tui_source_window_base::set_is_exec_point_at): Rename from
1985         tui_set_is_exec_point_at.
1986         (tui_update_all_breakpoint_info): Update.
1987         * tui/tui-stack.c (tui_show_frame_info): Update.
1988         * tui/tui-layout.c (show_data): Add cast.
1989         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1990         * tui/tui-data.h (struct tui_source_window_base) <refill,
1991         set_is_exec_point_at>: New methods.
1992         (tui_source_windows, tui_add_to_source_windows): Update types.
1993         (tui_add_to_source_windows): Remove redundant declaration.
1994         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1995         (tui_source_windows): Change return type.
1996         (tui_clear_source_windows_detail): Update.
1997         (tui_add_to_source_windows): Change type of parameter.
1998         (tui_free_all_source_wins_content): Update.
1999
2000 2019-06-25  Tom Tromey  <tom@tromey.com>
2001
2002         * tui/tui-wingeneral.c (tui_win_info::refresh)
2003         (tui_source_window_base::refresh): New methods.
2004         (tui_refresh_all): Call the refresh method.
2005         * tui/tui-data.h (struct tui_win_info)
2006         (struct tui_source_window_base) <refresh>: New method.
2007
2008 2019-06-25  Tom Tromey  <tom@tromey.com>
2009
2010         * tui/tui.h (tui_is_window_visible): Return bool.
2011         * tui/tui.c (tui_is_window_visible): Return bool.
2012         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2013         (tui_make_visible, tui_make_invisible)
2014         (tui_win_info::make_visible)
2015         (tui_source_window_base::make_visible, make_all_visible)
2016         (tui_make_all_visible, tui_make_all_invisible): Update.
2017         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2018         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2019         bool.
2020         (struct tui_win_info, struct tui_source_window_base)
2021         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2022         * tui/tui-data.c (tui_init_generic_part): Update.
2023
2024 2019-06-25  Tom Tromey  <tom@tromey.com>
2025
2026         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2027         (tui_source_window_base::make_visible): New methods.
2028         (make_all_visible): Make method call.
2029         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2030         (struct tui_source_window_base, struct tui_cmd_window): Override
2031         make_visible.
2032         (tui_win_is_source_type): Don't declare.
2033         * tui/tui-data.c (tui_win_is_source_type): Remove.
2034
2035 2019-06-25  Tom Tromey  <tom@tromey.com>
2036
2037         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2038         NULL check.
2039
2040 2019-06-25  Tom Tromey  <tom@tromey.com>
2041
2042         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2043         Inline constructor.  Add initializers for members.
2044         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2045         constructors; now inline in class.
2046
2047 2019-06-25  Tom Tromey  <tom@tromey.com>
2048
2049         * tui/tui-regs.c (tui_show_registers): Update.
2050         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2051         bool.
2052         * tui/tui-data.c (tui_data_window::clear_detail)
2053         (tui_data_window): Update.
2054
2055 2019-06-25  Tom Tromey  <tom@tromey.com>
2056
2057         * tui/tui-windata.c (tui_display_all_data)
2058         (tui_display_data_from_line, tui_display_data_from)
2059         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2060         Update.
2061         * tui/tui-regs.c (tui_last_regs_line_no)
2062         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2063         (tui_show_registers, tui_show_register_group)
2064         (tui_display_registers_from, tui_display_reg_element_at_line)
2065         (tui_display_registers_from_line, tui_check_register_values)
2066         (tui_reg_next, tui_reg_prev): Update.
2067         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2068         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2069         tui_data_window.
2070         (struct tui_win_info) <detail>: Remove.  Add new fields from
2071         tui_data_info.
2072         (TUI_DATA_WIN): Add cast.
2073         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2074         (~tui_data_window): Simplify.
2075
2076 2019-06-25  Tom Tromey  <tom@tromey.com>
2077
2078         * tui/tui-layout.c (show_source_disasm_command)
2079         (show_source_or_disasm_and_command): Update.
2080         * tui/tui-io.c (update_cmdwin_start_line)
2081         (tui_redisplay_readline): Update.
2082         * tui/tui-data.h (struct tui_command_info): Remove.
2083         (struct tui_win_info) <detail>: Remove command_info member.
2084         (struct tui_data_window) <start_line>: New member, from
2085         tui_command_info.
2086         (TUI_CMD_WIN): Add casts.
2087
2088 2019-06-25  Tom Tromey  <tom@tromey.com>
2089
2090         * tui/tui-winsource.c (tui_update_source_window)
2091         (tui_refill_source_window)
2092         (tui_source_window_base::do_scroll_horizontal)
2093         (tui_update_breakpoint_info, tui_set_exec_info_content)
2094         (tui_show_exec_info_content, tui_erase_exec_info_content)
2095         (tui_clear_exec_info_content): Update.
2096         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2097         Update.
2098         * tui/tui-win.c (make_invisible_and_set_new_height)
2099         (make_visible_with_new_height): Update.
2100         * tui/tui-source.c (tui_set_source_content)
2101         (tui_show_symtab_source): Update.
2102         * tui/tui-layout.c (extract_display_start_addr)
2103         (show_source_disasm_command, show_data)
2104         (make_source_or_disasm_window)
2105         (show_source_or_disasm_and_command): Update.
2106         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2107         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2108         "gdbarch".
2109         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2110         to tui_source_window_base.
2111         (struct tui_win_info) <detail>: Remove source_info member.
2112         (struct tui_source_window_base) <has_locator>: Inline.
2113         Move contents from tui_source_info; rename has_locator member to
2114         m_has_locator.
2115         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2116         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2117         header file.
2118         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2119         Simplify.
2120         (tui_free_all_source_wins_content): Cast to
2121         tui_source_window_base.
2122
2123 2019-06-25  Tom Tromey  <tom@tromey.com>
2124
2125         * tui/tui-win.c (make_invisible_and_set_new_height)
2126         (make_visible_with_new_height): Call has_locator method.
2127         * tui/tui-layout.c (show_source_disasm_command, show_data)
2128         (show_source_or_disasm_and_command): Update for bool change.
2129         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2130         (tui_win_info) <has_locator>: New method.
2131         (struct tui_source_window_base) <has_locator>: New method.
2132         (tui_win_has_locator): Don't declare.
2133         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2134         from tui_win_has_locator.
2135         (tui_source_window_base): Use false, not FALSE.
2136
2137 2019-06-25  Tom Tromey  <tom@tromey.com>
2138
2139         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2140         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2141         clear_detail method directly.
2142         (tui_clear_win_detail): Remove.
2143
2144 2019-06-25  Tom Tromey  <tom@tromey.com>
2145
2146         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2147         "this", not TUI_DISASM_WIN.
2148
2149 2019-06-25  Tom Tromey  <tom@tromey.com>
2150
2151         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2152         declare.
2153         * tui/tui-winsource.c
2154         (tui_source_window_base::do_scroll_horizontal): Rename from
2155         tui_horizontal_source_scroll.
2156         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2157         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2158         from tui_vertical_data_scroll.
2159         * tui/tui-win.h (tui_scroll): Don't declare.
2160         * tui/tui-win.c (tui_win_info::forward_scroll)
2161         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2162         (tui_win_info::right_scroll): Rename and update.
2163         (tui_scroll_forward_command, tui_scroll_backward_command)
2164         (tui_scroll_left_command, tui_scroll_right_command): Update.
2165         (tui_scroll): Remove.
2166         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2167         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2168         from tui_vertical_source_scroll.
2169         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2170         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2171         from tui_vertical_disassem_scroll.
2172         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2173         do_scroll_horizontal>: New methods.
2174         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2175         Likewise.
2176         (struct tui_source_window_base): Add do_scroll_horizontal.
2177         (struct tui_source_window, struct tui_disasm_window): Add
2178         do_scroll_vertical.
2179         (struct tui_data_window, struct tui_cmd_window): Add
2180         do_scroll_horizontal and do_scroll_vertical.
2181         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2182
2183 2019-06-25  Tom Tromey  <tom@tromey.com>
2184
2185         * tui/tui-data.h (struct tui_source_window_base): New struct.
2186         (struct tui_source_window): Derive from tui_source_window_base.
2187         (struct tui_disasm_window): New struct.
2188         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2189         from tui_source_window::clear_detail.
2190         (tui_source_window_base): Rename from tui_source_window.
2191         (~tui_source_window_base): Rename from ~tui_source_window.
2192         (tui_alloc_win_info): Create a tui_disasm_window.
2193
2194 2019-06-25  Tom Tromey  <tom@tromey.com>
2195
2196         * tui/tui-data.h (struct tui_source_window)
2197         (struct tui_data_window): Declare destructors.
2198         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2199         destructors.
2200         (tui_win_info): Simplify.
2201
2202 2019-06-25  Tom Tromey  <tom@tromey.com>
2203
2204         * tui/tui-winsource.c (tui_display_main)
2205         (tui_update_source_windows_with_addr)
2206         (tui_update_all_breakpoint_info): Update.
2207         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2208         (new_height_ok, parse_scrolling_args): Update.
2209         * tui/tui-stack.c (tui_show_frame_info): Update.
2210         * tui/tui-data.h (struct tui_list): Remove.
2211         (tui_source_windows): Return a reference to a std::vector.
2212         * tui/tui-data.c (source_windows): Now a std::vector.
2213         (tui_source_windows): Change return type.
2214         (tui_clear_source_windows): Rewrite.
2215         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2216         (tui_free_all_source_wins_content): Rewrite.
2217
2218 2019-06-25  Tom Tromey  <tom@tromey.com>
2219
2220         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2221         (struct tui_data_window, struct tui_cmd_window): Declare
2222         clear_detail method.
2223         * tui/tui-data.c (tui_source_window::clear_detail)
2224         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2225         methods.
2226         (tui_clear_win_detail): Simplify.
2227
2228 2019-06-25  Tom Tromey  <tom@tromey.com>
2229
2230         * tui/tui-layout.c (make_source_window, make_disasm_window)
2231         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2232         Return the new window.
2233         (show_source_disasm_command, show_data)
2234         (show_source_or_disasm_and_command): Update.
2235
2236 2019-06-25  Tom Tromey  <tom@tromey.com>
2237
2238         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2239         parameter.  Return the new window.
2240         (show_source_disasm_command): Update and remove NULL check.
2241         (show_source_or_disasm_and_command): Update.
2242
2243 2019-06-25  Tom Tromey  <tom@tromey.com>
2244
2245         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2246
2247 2019-06-25  Tom Tromey  <tom@tromey.com>
2248
2249         * tui/tui-data.h (struct tui_win_info): Make constructor
2250         protected.  Make destructor virtual.  Add initializers.
2251         (tui_source_window, tui_data_window, tui_cmd_window): New
2252         classes.
2253         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2254         constructor.  Add "type" parameter.
2255         (tui_source_window, tui_data_window, tui_cmd_window): New
2256         constructors.
2257         (tui_alloc_win_info): Instantiate the appropriate subclass.
2258
2259 2019-06-25  Tom Tromey  <tom@tromey.com>
2260
2261         * tui/tui-win.c (tui_resize_all): Use delete.
2262         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2263         destructor.
2264         (tui_free_window): Don't declare.
2265         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2266         Update.
2267
2268 2019-06-25  Tom Tromey  <tom@tromey.com>
2269
2270         * tui/tui-data.h (struct tui_win_info): Add constructor.
2271         * tui/tui-data.c (tui_alloc_win_info): Use new.
2272         (tui_free_window): Use delete.
2273
2274 2019-06-22  Tom Tromey  <tom@tromey.com>
2275
2276         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2277         declare.
2278         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2279
2280 2019-06-22  Tom Tromey  <tom@tromey.com>
2281
2282         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2283         declare.
2284         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2285
2286 2019-06-22  Tom de Vries  <tdevries@suse.de>
2287
2288         * dwarf2read.c (create_addrmap_from_aranges)
2289         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2290         instead of '%zu'.
2291
2292 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2293
2294         * dwarf2read.h (dwarf2_section_info_def): Remove.
2295         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2296         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2297         std::vector<dwarf2_section_info>.
2298         (struct dwo_file) <~dwo_file>: Remove.
2299         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2300         types field.
2301         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2302         (dwarf2_read_debug_names): Likewise.
2303         (create_debug_types_hash_table): Change parameter type to
2304         array_view, adjust code accordingly.
2305         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2306         (partial_die_info::fixup): Likewise.
2307         (determine_prefix): Likewise.
2308         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2309
2310 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2311
2312         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2313         gdb_bfd_ref_ptr.
2314         <~dwo_file>: Remove call to gdb_bfd_unref.
2315         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2316         gdb_bfd_ref_ptr::get.
2317
2318 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2319
2320         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2321         type to htab_up.
2322         * dwarf2read.c (struct dwo_file): Initialize fields.
2323         <~dwo_file>: New.
2324         (free_dwo_file): Remove, move content to ~dwo_file.
2325         (struct dwo_file_deleter): Remove.
2326         (dwo_file_up>: Remove custom deleter.
2327         (free_dwo_files): Remove.
2328         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2329         dwo_files.
2330         (process_skeletonless_type_units): Call unique_ptr::get.
2331         (allocate_dwo_file_hash_table): Add deleter to created hash
2332         table.  Change return type to htab_up.
2333         (lookup_dwo_file_slot): Don't memset dwo_file, call
2334         unique_ptr::get.
2335         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2336         (create_dwo_unit_in_dwp_v2): Likewise.
2337         (open_and_init_dwo_file): Likewise.
2338         (free_dwo_file_from_slot): Remove.
2339
2340 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2341
2342         * dwarf2read.h (struct dwarf2_section_info) <readin,
2343         is_virtual>: Change type to bool.
2344         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2345         true instead of 1.
2346
2347 2019-06-19  Tom Tromey  <tom@tromey.com>
2348
2349         * tui/tui-data.h (tui_init_content_element): Don't declare.
2350
2351 2019-06-19  Tom Tromey  <tom@tromey.com>
2352
2353         * tui/tui-data.h (tui_init_win_info): Don't declare.
2354
2355 2019-06-19  Tom de Vries  <tdevries@suse.de>
2356
2357         * dwarf2read.h (abstract_to_concrete): Change type to
2358         std::unordered_map<sect_offset, std::vector<sect_offset>,
2359         gdb::hash_enum<sect_offset>>.
2360
2361 2019-06-19  Tom Tromey  <tromey@adacore.com>
2362
2363         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2364         EVAL_AVOID_SIDE_EFFECTS specially.
2365
2366 2019-06-19  Tom Tromey  <tromey@adacore.com>
2367
2368         * source-cache.c (highlighter): New global.
2369         (source_cache::get_source_lines): Create a highlighter on demand.
2370
2371 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2372
2373         * defs.h (deprecated_interactive_hook): Delete declaration.
2374         * interps.c (clear_interpreter_hooks): Remove use of
2375         deprecated_interactive_hook.
2376         * top.c (deprecated_interactive_hook): Delete definition.
2377         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2378
2379 2019-06-18  Tom de Vries  <tdevries@suse.de>
2380
2381         PR gdb/24515
2382         * dwarf2read.h (abstract_to_concrete): Change type from
2383         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2384         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2385         * dwarf2read.c (read_variable): Update.
2386         (dwarf2_fetch_die_loc_sect_off): Update.
2387
2388 2019-06-17  Tom de Vries  <tdevries@suse.de>
2389
2390         PR gdb/24617
2391         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2392         accessing parent[parent_len - 1].
2393
2394 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2395
2396         PR gdb/24364
2397         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2398         call dtrace_process_dof with NULL dof.
2399
2400 2019-06-16  Tom de Vries  <tdevries@suse.de>
2401
2402         PR gdb/24445
2403         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2404
2405 2019-06-16  Tom Tromey  <tom@tromey.com>
2406
2407         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2408         (make_all_visible): Use address of member.
2409
2410 2019-06-16  Tom Tromey  <tom@tromey.com>
2411
2412         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2413         (tui_free_window, free_content, free_content_elements): Remove
2414         unnecessary cast.
2415         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2416         cast.
2417         * tui/tui-regs.c (tui_show_register_group)
2418         (tui_display_registers_from, tui_display_reg_element_at_line):
2419         Remove unnecessary cast.
2420
2421 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2422
2423         * linux-nat.c (normal_mask): Delete.
2424         (_initialize_linux_nat): Don't initialise normal_mask.
2425
2426 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2427
2428         PR gdb/24445
2429         * dwarf-index-write.h (write_psymtabs_to_index): Add
2430         dwz_basename parameter.
2431         * dwarf-index-write.c (write_gdbindex): Move file writing to
2432         write_gdbindex_1.  Change return type void.
2433         (assert_file_size): Move up, remove filename parameter.
2434         (write_gdbindex_1): New function.
2435         (write_debug_names): Change return type to void, call
2436         assert_file_size.
2437         (struct index_wip_file): New struct.
2438         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2439         file logic to index_wip_file.  Write index for dwz file if
2440         needed.
2441         (save_gdb_index_command): Pass basename of dwz file, if present.
2442         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2443         build-id of dwz file, if present.
2444         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2445         (dwarf2_get_dwz_file): Likewise.
2446         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2447         (dwarf2_get_dwz_file): Likewise.
2448
2449 2019-06-16  Tom Tromey  <tom@tromey.com>
2450
2451         * coffread.c (process_coff_symbol): Use xstrdup.
2452         * value.c (create_internalvar): Use xstrdup.
2453
2454 2019-06-16  Tom Tromey  <tom@tromey.com>
2455
2456         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2457         * breakpoint.c (stopin_command, stopat_command)
2458         (until_break_command, decode_location_default): Remove unnecessary
2459         cast.
2460         * utils.c (subset_compare): Remove unnecessary cast.
2461         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2462         cast.
2463         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2464         cast.
2465         * infcmd.c (path_command): Remove unnecessary cast.
2466         * coffread.c (decode_type): Remove unnecessary cast.
2467         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2468         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2469         * tui/tui-stack.c (tui_show_locator_content)
2470         (tui_show_frame_info): Remove unnecessary cast.
2471         * tui/tui-win.c (tui_scroll_forward_command)
2472         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2473         (parse_scrolling_args): Remove unnecessary cast.
2474         * tui/tui-data.c (init_win_info, tui_del_window)
2475         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2476         (free_content_elements): Remove unnecessary cast.
2477         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2478         unnecessary cast.
2479         * tui/tui-source.c (tui_set_source_content)
2480         (tui_vertical_source_scroll): Remove unnecessary cast.
2481         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2482         cast.
2483         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2484         * tui/tui-regs.c (tui_display_registers_from)
2485         (tui_display_register): Remove unnecessary cast.
2486         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2487         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2488         (make_visible): Remove unnecessary cast.
2489         * tui/tui-winsource.c (tui_erase_source_content)
2490         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2491         unnecessary cast.
2492         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2493         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2494         * stabsread.c (read_type, read_array_type, read_range_type):
2495         Remove unnecessary cast.
2496         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2497         (parse_symbol, parse_type, upgrade_type, parse_external)
2498         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2499         unnecessary cast.
2500         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2501
2502 2019-06-16  Tom Tromey  <tom@tromey.com>
2503
2504         * tui/tui-data.c (tui_alloc_generic_win_info)
2505         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2506         checks.
2507
2508 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2509             Andrew Burgess  <andrew.burgess@embecosm.com>
2510
2511         * f-typeprint.c (f_print_type): Don't return early for not
2512         associated or not allocated types.
2513         (f_type_print_varspec_suffix): Add print_rank parameter and print
2514         ranks of array types in case they dangling.
2515         (f_type_print_base): Add print_rank parameter.
2516
2517 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2518
2519         * NEWS: Mention new MI commands.
2520         * break-catch-throw.c (enum exception_event_kind): Move to
2521         breakpoint.h.
2522         (print_mention_exception_catchpoint): Output text as a single
2523         message.
2524         (catch_exception_command_1): Rename to...
2525         (catch_exception_event): ...this, make non-static, update header
2526         command, and change some parameter types.
2527         (catch_catch_command): Update for changes to
2528         catch_exception_command_1.
2529         (catch_throw_command): Likewise.
2530         (catch_rethrow_command): Likewise.
2531         * breakpoint.c (enum exception_event_kind): Delete.
2532         * breakpoint.h (enum exception_event_kind): Moved here from
2533         break-catch-throw.c.
2534         (catch_exception_event): Declare.
2535         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2536         (mi_cmd_catch_throw): New function.
2537         (mi_cmd_catch_rethrow): New function.
2538         (mi_cmd_catch_catch): New function.
2539         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2540         'catch-catch' entries.
2541         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2542         (mi_cmd_catch_rethrow): Declare.
2543         (mi_cmd_catch_catch): Declare.
2544
2545 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2546
2547         * annotate.c (annotate_source_line): Change return type to void,
2548         update implementation to match.
2549         * annotate.h (annotate_source_line): Change return type to void,
2550         update header comment.
2551         * stack.c (print_frame_info): Don't change what frame information
2552         is printed based on whether annotations are on or not.
2553
2554 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2555
2556         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2557         (annotate_source): Make static.
2558         (annotate_source_line): Moved from source.c and renamed from
2559         identify_source_line.  Update the return type.
2560         * annotate.h (annotate_source): Delete declaration.
2561         (annotate_source_line): Declaration moved from source.h, and
2562         renamed from identify_source_line.  Return type updated.
2563         * source.c (identify_source_line): Moved to annotate.c and renamed
2564         to annotate_source_line.
2565         (info_line_command): Remove check of annotation_level.
2566         * source.h (identify_source_line): Move declaration to annotate.h
2567         and rename to annotate_source_line.
2568         * stack.c: Add 'annotate.h' include.
2569         (print_frame_info): Remove check of annotation_level before
2570         calling annotate_source_line.
2571
2572 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2573
2574         * source-cache.c (source_cache::get_plain_source_lines): Use
2575         open_source_file_with_line_charpos instead of just
2576         open_source_file, remove call to find_source_lines.
2577         (source_cache::get_source_lines): Likewise.
2578         * source.c (find_source_lines): Make static.
2579         (get_filename_and_charpos): Renamed into...
2580         (open_source_file_with_line_charpos): ..this along with changes to
2581         return a scoped_fd, and some other minor clean ups.
2582         (identify_source_line): Use open_source_file_with_line_charpos.
2583         (search_command_helper): Use open_source_file_with_line_charpos
2584         instead of just open_source_file, remove call to
2585         find_source_lines.
2586         * source.h (open_source_file_with_line_charpos): Declare new
2587         function.
2588         (find_source_lines): Delete declaration.
2589
2590 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2591
2592         * source.c (get_filename_and_charpos): Remove fullname
2593         parameter.
2594         (identify_source_line): Update call to get_filename_and_charpos.
2595
2596 2019-06-14  Tom Tromey  <tromey@adacore.com>
2597
2598         PR gdb/24502:
2599         * ui-style.h (skip_ansi_escape): Update comment.
2600         * ui-file.h (class no_terminal_escape_file): New class.
2601         * ui-file.c (no_terminal_escape_file::write)
2602         (no_terminal_escape_file::puts): New methods.
2603         * cli/cli-logging.c (handle_redirections): Use
2604         no_terminal_escape_file.
2605
2606 2019-06-14  Tom Tromey  <tromey@adacore.com>
2607
2608         * NEWS: Move convenience variable news above Python news.
2609
2610 2019-06-14  Tom Tromey  <tom@tromey.com>
2611
2612         * gnulib: Move directory to top-level.
2613         * configure.ac: Don't configure gnulib.
2614         * configure: Rebuild.
2615         * common/common-defs.h: Use new path to gnulib.
2616         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2617         (GNULIB_H): Remove.
2618         (INCGNU): Look in new gnulib location.
2619         (HFILES_NO_SRCDIR): Remove gnulib files.
2620         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2621         (generated_files): Remove GNULIB_H.
2622         ($(LIBGNU), all-lib): Remove targets.
2623         (distclean): Don't mention GNULIB_BUILDDIR.
2624         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2625
2626 2019-06-14  Tom Tromey  <tromey@adacore.com>
2627
2628         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2629         Warn if symbol file does not provide any symbols.
2630
2631 2019-06-14  Tom Tromey  <tromey@adacore.com>
2632
2633         * source.c (find_and_open_source): Respect basenames_may_differ.
2634
2635 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2636
2637         * annotate.c (annotate_breakpoints_invalid): Make use of
2638         scoped_restore_terminal_state.
2639         (annotate_frames_invalid): Likewise.
2640
2641 2019-06-14  Tom Tromey  <tromey@adacore.com>
2642
2643         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2644         allow assignment to an internalvar.
2645
2646 2019-06-14  Tom Tromey  <tromey@adacore.com>
2647
2648         * ada-lex.l: Allow "_" in attribute names.
2649
2650 2019-06-14  Tom Tromey  <tromey@adacore.com>
2651
2652         PR gdb/24653:
2653         * regcache.c (registers_changed): Don't call alloca.
2654         * top.c (execute_command): Don't call alloca.
2655
2656 2019-06-13  Pedro Alves  <palves@redhat.com>
2657
2658         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2659         'expression'.  When parsing an expression, error out if there's
2660         junk after "unlimited".
2661         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2662         (do_set_command): Adjust calls to is_unlimited_literal.
2663
2664 2019-06-13  Pedro Alves  <palves@redhat.com>
2665
2666         * compile/compile.c (make_compile_options_def_group): Add braces
2667         around array_view initializer.
2668         * thread.c (make_thread_apply_all_options_def_group)
2669         (make_thread_apply_all_options_def_group): Likewise.
2670
2671 2019-06-13  Pedro Alves  <palves@redhat.com>
2672
2673         * NEWS (New commands): Mention "maint test-options
2674         require-delimiter", "maint test-options unknown-is-error", "maint
2675         test-options unknown-is-operand" and "maint show
2676         test-options-completion-result".
2677         (New command options, command completion): New section.
2678         (Completion improvements): New section.
2679         Mention that you can abbreviate "unlimited".
2680
2681 2019-06-13  Pedro Alves  <palves@redhat.com>
2682
2683         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2684         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2685         * unittests/cli-utils-selftests.c (test_parse_flags)
2686         (test_parse_flags_qcs): Delete.
2687         (test_cli_utils): Don't call deleted functions.
2688
2689 2019-06-13  Pedro Alves  <palves@redhat.com>
2690
2691         * thread.c: Include "cli/cli-option.h".
2692         (tp_array_compar_ascending): Global.
2693         (tp_array_compar): Delete function.
2694         (tp_array_compar_ascending, tp_array_compar_descending): New
2695         functions.
2696         (ascending_option_def, qcs_flag_option_def)
2697         (thr_qcs_flags_option_defs)
2698         (make_thread_apply_all_options_def_group)
2699         (make_thread_apply_options_def_group): New.
2700         (thread_apply_all_command): Use gdb::option::process_options.
2701         (thread_apply_command_completer)
2702         (thread_apply_all_command_completer): New.
2703         (thread_apply_command): Use gdb::option::process_options.
2704         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2705         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2706         to generate help text of "thread apply".  Adjust "taas"'s help.
2707         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2708         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2709
2710 2019-06-13  Pedro Alves  <palves@redhat.com>
2711
2712         * thread.c (thread_apply_command): Check for invalid TID with
2713         isdigit instead of !isalpha.
2714
2715 2019-06-13  Pedro Alves  <palves@redhat.com>
2716
2717         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2718         (validate_flags_qcs): New.
2719         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2720         (validate_flags_qcs): Declare.
2721         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2722         (make_frame_apply_options_def_group): New.
2723         (frame_apply_command_count): Process options with
2724         gdb::option::process_options.
2725         (frame_apply_completer): New.
2726         (frame_apply_level_completer, frame_apply_all_completer)
2727         (frame_apply_completer): New.
2728         (_initialize_stack): Update help of "frame apply", "frame apply
2729         level", "frame apply all" and "faas" to mention supported options
2730         and install command completers.
2731         * stack.h (frame_apply_all_completer): Declare.
2732         * thread.c: Include "stack.h".
2733         (tfaas_command): Add "--".
2734         (_initialize_thread): Update help "tfaas" to mention supported
2735         options and install command completer.
2736
2737 2019-06-13  Pedro Alves  <palves@redhat.com>
2738
2739         * completer.c (complete_nested_command_line): New.
2740         (gdb_completion_word_break_characters_throw): Add assertion.
2741         * completer.h (complete_nested_command_line): Declare.
2742
2743 2019-06-13  Pedro Alves  <palves@redhat.com>
2744
2745         * stack.c (parse_backtrace_qualifiers): New.
2746         (backtrace_command): Use it.
2747         (backtrace_command_completer): Complete on qualifiers.
2748
2749 2019-06-13  Pedro Alves  <palves@redhat.com>
2750
2751         * frame.c: Include "cli/cli-option.h.
2752         (user_set_backtrace_options): New.
2753         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2754         Delete.
2755         (get_prev_frame): Adjust.
2756         (boolean_option_def, uinteger_option_def)
2757         (set_backtrace_option_defs): New.
2758         (_initialize_frame): Adjust and use
2759         gdb::option::add_setshow_cmds_for_options to install "set
2760         backtrace past-main" and "set backtrace past-entry".
2761         * frame.h: Include "cli/cli-option.h".
2762         (struct frame_print_options): Forward declare.
2763         (print_frame_arguments_all, print_frame_arguments_scalars)
2764         (print_frame_arguments_none): Declare.
2765         (print_entry_values): Delete declaration.
2766         (struct frame_print_options, user_frame_print_options): New.
2767         (struct set_backtrace_options): New.
2768         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2769         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2770         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2771         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2772         (list_args_or_locals): Add frame_print_options parameter.
2773         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2774         * python/py-framefilter.c (enumerate_args): Pass down
2775         USER_FRAME_PRINT_OPTIONS.
2776         * stack.c: Include "cli/cli-option.h".
2777         (print_frame_arguments_all, print_frame_arguments_scalars)
2778         (print_frame_arguments_none): Declare.
2779         (print_raw_frame_arguments, print_entry_values): Delete.
2780         (user_frame_print_options): New.
2781         (boolean_option_def, enum_option_def, frame_print_option_defs):
2782         New.
2783         (struct backtrace_cmd_options): New.
2784         (bt_flag_option_def): New.
2785         (backtrace_command_option_defs): New.
2786         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2787         (print_frame_arg, read_frame_arg, print_frame_args)
2788         (print_frame_info, print_frame): Add frame_print_options parameter
2789         and use it.
2790         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2791         (backtrace_command_1): Add frame_print_options and
2792         backtrace_cmd_options parameters and use them.
2793         (make_backtrace_options_def_group): New.
2794         (backtrace_command): Process command options with
2795         gdb::option::process_options.
2796         (backtrace_command_completer): New.
2797         (_initialize_stack): Extend "backtrace"'s help to mention
2798         supported options.  Install completer for "backtrace".
2799         Install some settings commands with add_setshow_cmds_for_options.
2800
2801 2019-06-13  Pedro Alves  <palves@redhat.com>
2802
2803         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2804         and that "set/show print raw frame-arguments" are now deprecated.
2805
2806         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2807         command.
2808         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2809         * stack.c (_initialize_stack): Install "set/show print
2810         raw-frame-arguments", and deprecate "set/show print raw
2811         frame-arguments".
2812         * valprint.c (_initialize_valprint): Deprecate "set/show print
2813         raw".
2814
2815 2019-06-13  Pedro Alves  <palves@redhat.com>
2816
2817         * compile/compile.c (struct compile_options): New.
2818         (compile_flag_option_def, compile_command_option_defs)
2819         (make_compile_options_def_group): New.
2820         (compile_file_command): Handle options with
2821         gdb::option::process_options.
2822         (compile_file_command_completer): New function.
2823         (compile_code_command): Handle options with
2824         gdb::option::process_options.
2825         (compile_code_command_completer): New function.
2826         (_initialize_compiler): Install completers for "compile code" and
2827         "compile file".  Mention available options in "compile code" and
2828         "compile code"'s help.
2829         * completer.c (advance_to_completion_word): New, factored out from
2830         ...
2831         (advance_to_expression_complete_word_point): ... this.
2832         (advance_to_filename_complete_word_point): New.
2833         * completer.h (advance_to_filename_complete_word_point): New
2834         declaration.
2835
2836 2019-06-13  Pedro Alves  <palves@redhat.com>
2837
2838         * compile/compile.c: Include "cli/cli-option.h".
2839         (compile_print_value): Scope data pointer is now a
2840         value_print_options pointer; adjust.
2841         (compile_print_command): Process options.  Scope data pointer is
2842         now a value_print_options pointer; adjust.
2843         (_initialize_compile): Update "compile print"'s help to include
2844         supported options.  Install a completer for "compile print".
2845         * cp-valprint.c (show_vtblprint, show_objectprint)
2846         (show_static_field_print): Delete.
2847         (_initialize_cp_valprint): Don't install "set print
2848         static-members", "set print vtbl", "set print object" here.
2849         * printcmd.c: Include "cli/cli-option.h" and
2850         "common/gdb_optional.h".
2851         (print_command_parse_format): Rework to fill in a
2852         value_print_options instead of a format_data.
2853         (print_value): Change parameter type from format_data pointer to
2854         value_print_options reference.  Adjust.
2855         (print_command_1): Process options.  Adjust to pass down a
2856         value_print_options.
2857         (print_command_completer): New.
2858         (_initialize_printcmd): Install print_command_completer as
2859         handle_brkchars completer for the "print" command.  Update
2860         "print"'s help to include supported options.
2861         * valprint.c: Include "cli/cli-option.h".
2862         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2863         here from cp-valprint.c.
2864         (boolean_option_def, uinteger_option_def)
2865         (value_print_option_defs, make_value_print_options_def_group):
2866         New.  Use gdb::option::add_setshow_cmds_for_options to install
2867         "set print elements", "set print null-stop", "set print repeats",
2868         "set print pretty", "set print union", "set print array", "set
2869         print address", "set print symbol", "set print array-indexes".
2870         * valprint.h: Include <string> and "cli/cli-option.h".
2871         (make_value_print_options_def_group): Declare.
2872         (print_value): Change parameter type from format_data pointer to
2873         value_print_options reference.
2874         (print_command_completer): Declare.
2875
2876 2019-06-13  Pedro Alves  <palves@redhat.com>
2877
2878         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2879         (COMMON_SFILES): Add maint-test-settings.c.
2880         * cli/cli-decode.c (boolean_enums): New global, factored out from
2881         ...
2882         (add_setshow_boolean_cmd): ... here.
2883         * cli/cli-decode.h (boolean_enums): Declare.
2884         * cli/cli-option.c: New file.
2885         * cli/cli-option.h: New file.
2886         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2887         factored out from ...
2888         (parse_cli_boolean_value(const char *)): ... this.
2889         (is_unlimited_literal): Change parameter type to pointer to
2890         pointer.  Adjust and advance ARG pointer.
2891         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2892         (parse_cli_var_enum): New, factored out from ...
2893         (do_set_command): ... this.  Adjust.
2894         * cli/cli-setshow.h (parse_cli_boolean_value)
2895         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2896         (parse_cli_var_enum): Declare.
2897         * cli/cli-utils.c: Include "cli/cli-option.h".
2898         (get_ulongest): New.
2899         * cli/cli-utils.h (get_ulongest): Declare.
2900         (check_for_argument): New overloads.
2901         * maint-test-options.c: New file.
2902
2903 2019-06-13  Pedro Alves  <palves@redhat.com>
2904
2905         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2906         parse a range if "-" is at the end of the string.
2907
2908 2019-06-13  Pedro Alves  <palves@redhat.com>
2909
2910         * cli/cli-setshow.c (parse_auto_binary_operation)
2911         (parse_cli_boolean_value): Don't allow "o".
2912
2913 2019-06-13  Pedro Alves  <palves@redhat.com>
2914
2915         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2916         * NEWS: Mention maint test-settings KIND.
2917         * maint-test-settings.c: New file.
2918
2919 2019-06-13  Pedro Alves  <palves@redhat.com>
2920
2921         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2922         completer.
2923         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2924         "set" completers.
2925
2926 2019-06-13  Pedro Alves  <palves@redhat.com>
2927
2928         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2929         after item.
2930
2931 2019-06-13  Pedro Alves  <palves@redhat.com>
2932
2933         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2934
2935 2019-06-13  Pedro Alves <palves@redhat.com>
2936
2937         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2938         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2939         call.
2940         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2941         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2942         calls.
2943         (check_for_argument): Skip spaces after argument.
2944
2945 2019-06-13  Pedro Alves  <palves@redhat.com>
2946
2947         * thread.c (thread_apply_command): Adjust TID parsing.
2948         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2949         detected before end of string.
2950         (tid_is_in_list): Error out if LIST is invalid.
2951
2952 2019-06-13  Pedro Alves  <palves@redhat.com>
2953
2954         * completer.c (complete_line_internal_1): Rewind completion word
2955         point.
2956         (completion_tracker::advance_custom_word_point_by): Change
2957         parameter type to int.
2958         * completer.h (completion_tracker::advance_custom_word_point_by):
2959         Likewise.
2960
2961 2019-06-13  Pedro Alves  <palves@redhat.com>
2962
2963         * completer.c (advance_to_completion_word): Handle delimiters.
2964
2965 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2966
2967         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2968
2969 2019-06-11  Tom Tromey  <tom@tromey.com>
2970
2971         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2972         (xmalloc_failed): Move to alloc.c.
2973         * alloc.c: New file.
2974         * Makefile.in (COMMON_SFILES): Add alloc.c.
2975
2976 2019-06-11  Tom Tromey  <tom@tromey.com>
2977
2978         * nat/linux-waitpid.c: Don't include server.h.
2979         (linux_debug): Remove.
2980         (my_waitpid): Update.
2981
2982 2019-06-11  Tom Tromey  <tromey@adacore.com>
2983
2984         * infcall.c (_initialize_infcall): Remove trailing newline from
2985         help.
2986         * user-regs.c (_initialize_user_regs): Remove trailing newline
2987         from help.
2988         * typeprint.c (_initialize_typeprint): Remove trailing newline
2989         from help.
2990         * reverse.c (_initialize_reverse): Remove trailing newlines from
2991         help.
2992         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2993         from help.
2994         * language.c (add_set_language_command): Remove trailing newline
2995         from help.
2996         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2997         help.
2998         * disasm.c (_initialize_disasm): Remove trailing newline from
2999         help.
3000         * top.c (init_main): Remove trailing newline from help.
3001         * interps.c (_initialize_interpreter): Remove trailing newline
3002         from help.
3003         * btrace.c (_initialize_btrace): Remove trailing newlines from
3004         help.
3005         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3006         from help.
3007         * python/python.c (_initialize_python): Remove trailing newline
3008         from help.
3009         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3010         help.
3011         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3012         from help.  Reformat some text.
3013         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3014         from help.
3015         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3016         newline from help.
3017
3018 2019-06-11  Tom Tromey  <tromey@adacore.com>
3019
3020         * darwin-nat.c (darwin_decode_exception_message)
3021         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3022
3023 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3024
3025         * valops.c (value_slice): Check for not allocated or not
3026         associated values.
3027
3028 2019-06-10  Tom de Vries  <tdevries@suse.de>
3029
3030         PR gdb/24618
3031         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3032         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3033         invalid.
3034
3035 2019-06-10  Tom de Vries  <tdevries@suse.de>
3036
3037         PR gdb/24611
3038         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3039         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3040
3041 2019-06-10  Tom de Vries  <tdevries@suse.de>
3042
3043         PR symtab/24545
3044         * symtab.c (struct demangled_name_entry): Add language field.
3045         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3046         static minimal symbol".  Set and use language field.
3047
3048 2019-06-10  Tom Tromey  <tromey@adacore.com>
3049
3050         * ada-lang.c (_initialize_ada_language): Update help text.
3051
3052 2019-06-10  Tom Tromey  <tromey@adacore.com>
3053
3054         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3055         with a newline.
3056         * guile/guile.c (handle_boot_error): Don't end warning with a
3057         newline.
3058         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3059         warning with a newline.
3060         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3061         newline.
3062         (s12z_frame_cache): Likewise.
3063         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3064         a newline.
3065         * solib-svr4.c (disable_probes_interface): Don't end warning with
3066         a newline.
3067         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3068         newline.
3069         * python/python.c (do_finish_initialization): Don't end warning
3070         with a newline.
3071
3072 2019-06-10  Tom Tromey  <tom@tromey.com>
3073
3074         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3075         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3076         gdbpy_enter.
3077
3078 2019-06-10  Tom Tromey  <tromey@adacore.com>
3079
3080         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3081         data.
3082         (elf_new_init): Don't call stabsread_new_init.
3083         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3084         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3085         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3086
3087 2019-06-10  Tom de Vries  <tdevries@suse.de>
3088
3089         PR symtab/16264
3090         PR symtab/24517
3091         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3092
3093 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3094
3095         * source.c (find_and_open_source): Also rewrite relative file
3096         names.
3097
3098 2019-04-26  Amos Bird  <amosbird@gmail.com>
3099
3100         * annotate.c (annotate_thread_exited): Add "thread-exited"
3101         annotation.
3102
3103 2019-06-06  Tom Tromey  <tromey@adacore.com>
3104
3105         * maint.h (class scoped_command_stats): Use
3106         DISABLE_COPY_AND_ASSIGN.
3107         <print_time>: New method.
3108         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3109         print_time.
3110         (scoped_command_stats::print_time): New method.
3111
3112 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3113
3114         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3115         instructions of lengths 6 or 8 bytes.
3116
3117 2019-06-04  Pedro Alves  <palves@redhat.com>
3118
3119         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3120
3121         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3122         * breakpoint.c (condition_completer): Likewise.
3123         * cli/cli-dump.c (scan_expression): Likewise.
3124         * common/filestuff.c (mkdir_recursive): Likewise.
3125         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3126         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3127         (gdb_abspath): Likewise.
3128         * compile/compile-cplus-types.c
3129         (compile_cplus_instance::decl_name): Likewise.
3130         * completer.c (complete_explicit_location):
3131         (signal_completer, reg_or_group_completer_1): Likewise.
3132         * cp-support.c (cp_remove_params_if_any): Likewise.
3133         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3134         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3135         * infcmd.c (strip_bg_char): Likewise.
3136         * linespec.c (copy_token_string): Likewise.
3137         * mi/mi-main.c (output_cores): Likewise.
3138         * psymtab.c (psymtab_search_name):
3139         * symfile.c (test_set_ext_lang_command): Likewise.
3140         * target.c (target_fileio_read_stralloc): Likewise.
3141         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3142         * value.c (complete_internalvar): Likewise.
3143
3144 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3145
3146         Add objfile property to gdb.Type.
3147         * NEWS: Mention Python API addition.
3148         * python/py-type.c (typy_get_objfile): New method.
3149
3150 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3151
3152         * NEWS: Mention the new set|show style [title|highlight].
3153         Mention changes to "show style", "help" and "apropos".
3154
3155 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3156
3157         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3158         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3159         instead of print_help_for_command.
3160         (print_doc_of_command): New function.
3161         (help_list): Add 'apropos -v word' suggestion.
3162         (print_help_for_command): Style the command name using title style.
3163         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3164         (_initialize_cli_cmds): Describe -v in apropos_command help.
3165
3166 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3167
3168         * cli/cli-style.h (cli_style_option): Add name in constructor,
3169         add m_name class member, add constructor with intensity,
3170         add name class function.
3171         (cli_style_option::add_setshow_commands): Remove name argument.
3172         (highlight_style, title_style): New styles.
3173         * cli/cli-style.c (do_show): New function that shows a style
3174         characteristic styling the style name with itself.
3175         (set_style_name): New function.
3176         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3177         Update all callers according to the changes in cli/cli-style.h.
3178         * utils.h (fputs_highlighted): New function.
3179         * utils.c (fputs_highlighted): Likewise.
3180
3181 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3182
3183         * NEWS: Mention new pipe command and new convenience variables.
3184
3185 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3186
3187         * cli/cli-cmds.c (pipe_command): New function.
3188         (_initialize_cli_cmds): Call add_com for pipe_command.
3189         Define | as an alias for pipe.
3190         (exit_status_set_internal_vars): New function.
3191         (shell_escape): Call exit_status_set_internal_vars.
3192         cli/cli-decode.c (find_command_name_length): Recognize | as
3193         a single character command.
3194
3195 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3196
3197         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3198         top.c (execute_command_to_ui_file): New function, mostly a copy
3199         of execute_command_to_string.
3200         (execute_command_to_string): Implement by calling
3201         execute_command_to_ui_file.
3202
3203 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3204
3205         * top.h (saved_command_line): Remove declaration.
3206         * top.c (previous_saved_command_line, previous_repeat_arguments):
3207         New variables.
3208         (saved_command_line): Make static, define together with other
3209         'repeat variables'.
3210         (dont_repeat): Clear repeat_arguments.
3211         (repeat_previous, get_saved_command_line, save_command_line):
3212         New functions.
3213         (gdb_init): Initialize saved_command_line
3214         and previous_saved_command_line.
3215         * main.c (captured_main_1): Remove saved_command_line initialization.
3216         * event-top.c (handle_line_of_input): Update to use
3217         the new 'repeat' related functions instead of direct access to
3218         saved_command_line.
3219         * command.h (repeat_previous, get_saved_command_line,
3220         save_command_line): New declarations.
3221         (dont_repeat): Add comment.
3222
3223 2019-05-30  Tom Tromey  <tromey@adacore.com>
3224
3225         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3226         Fix comment.
3227         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3228
3229 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3230
3231         PR cli/24587
3232         * completer.c (complete): Initialize variable word.
3233
3234 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3235
3236         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3237         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3238         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3239         'body' is NULL to the outter 'if', protecting the '!is_define'
3240         situation as well.
3241
3242 2019-05-29  Tom Tromey  <tromey@adacore.com>
3243
3244         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3245         (dwarf_unknown): New function.
3246         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3247         (dwarf_type_encoding_name): Use dwarf_unknown.
3248
3249 2019-05-29  Tom Tromey  <tromey@adacore.com>
3250
3251         PR c++/20020:
3252         * cp-valprint.c (cp_print_value_fields): Call
3253         cp_print_static_field inside "try".
3254
3255 2019-05-29  Tom Tromey  <tromey@adacore.com>
3256
3257         * inflow.c (struct terminal_info): Add default operator=.
3258         * configure: Rebuild.
3259         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3260         -Wdeprecated-copy-dtor, -Wredundant-move.
3261
3262 2019-05-29  Tom Tromey  <tromey@adacore.com>
3263
3264         * NEWS: Add entry.
3265         * infcmd.c (print_return_value_1): Handle finish_print
3266         option.
3267         (show_print_finish): New function.
3268         (_initialize_infcmd): Add "set/show print finish" commands.
3269         * valprint.c (user_print_options): Initialize new member.
3270         * valprint.h (struct value_print_options) <finish_print>: New
3271         member.
3272
3273 2019-05-28  Tom Tromey  <tromey@adacore.com>
3274
3275         * ada-lang.c (ada_remove_Xbn_suffix)
3276         (find_old_style_renaming_symbol)
3277         (parse_old_style_renaming): Remove.
3278         (ada_find_renaming_symbol): Don't call
3279         find_old_style_renaming_symbol.
3280         (ada_is_renaming_symbol): Rename from
3281         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3282         bool.  Now static.
3283         (ada_read_var_value): Update and simplify.
3284         * ada-exp.y (write_var_or_type): Remove old code.
3285
3286 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3287
3288         * event-top.c: Remove include comment.
3289         * inflow.c (class scoped_ignore_sigttou): Move from here...
3290         * inflow.h (class scoped_ignore_sigttou): ...to here.
3291         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3292         * top.c:  Remove include comment.
3293
3294 2019-05-27  Tom Tromey  <tom@tromey.com>
3295
3296         * NEWS: Fix typo.
3297
3298 2019-05-22  Tom Tromey  <tromey@adacore.com>
3299
3300         * target.c (target_follow_exec): Constify parameter.
3301         * target-delegates.c: Rebuild.
3302         * remote.c (remote_target::follow_exec): Constify parameter.
3303         * infrun.c (follow_exec): Constify parameter.
3304         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3305         (target_follow_exec): Likewise.
3306
3307 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3308
3309         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3310         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3311
3312 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3313
3314         * NEWS: Add debugredirect and testsuite sections.
3315
3316 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3317
3318         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3319         target descriptions using exclusively floating point register name
3320         aliases.
3321
3322 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3323
3324         PR gdb/18644:
3325         * f-lang.c (build_fortran_types): Handle the case where
3326         gdbarch_floatformat_for_type returns a nullptr.
3327
3328 2019-05-21  Tom de Vries  <tdevries@suse.de>
3329
3330         PR cli/24587
3331         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3332
3333 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3334
3335         PR gdb/18644:
3336         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3337         16-byte floats.
3338         * i386-tdep.c (i386_floatformat_for_type): Use
3339         floatformats_ia64_quad for the 16-byte floating point component
3340         within a fortran 32-byte complex number.
3341
3342 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3343
3344         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3345         delete default constructor.
3346         (find_partial_die): Update to return const struct.
3347         (partial_die_parent_scope): Move variable declaration into scope
3348         of its use and change its type to auto.
3349         (guess_partial_die_structure_name): Likewise.
3350         (partial_die_info::fixup): Likewise.
3351
3352 2019-05-17  Tom Tromey  <tromey@adacore.com>
3353
3354         * source.c (find_and_open_source): Remove cast.
3355
3356 2019-05-17  Tom Tromey  <tromey@adacore.com>
3357
3358         * annotate.c (annotate_source): Make "filename" const.
3359         * annotate.h (annotate_source): Use const.
3360
3361 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3362
3363         * disasm.c (set_disassembler_options): Send errors to stderr.
3364
3365 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3366
3367         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3368         (cli_interp_base::set_logging): Check debug_redirect.
3369         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3370         * cli/cli-logging.c (debug_redirect): Add static variable.
3371         (pop_output_files): Add default param.
3372         (handle_redirections): Print debug setting.
3373         (show_logging_command): Likewise.
3374         (_initialize_cli_logging): Add debugredirect command.
3375         * interps.c (current_interp_set_logging): Add debug_redirect
3376         parameter.
3377         * interps.h (set_logging): Add debug_redirect parameter.
3378         (current_interp_set_logging): Likewise.
3379         * mi/mi-common.h: Likewise.
3380         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3381
3382 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3383             Tom Tromey  <tromey@adacore.com>
3384
3385         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3386         directly.
3387         * cli/cli-interp.h (make_logging_output): Remove declaration.
3388         * cli/cli-logging.c (make_logging_output): Remove function.
3389         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3390         directly.
3391         * ui-file.c (tee_file::tee_file): Remove bools.
3392         (tee_file::~tee_file): Remove deletes.
3393         * ui-file.h (tee_file): Remove bools.
3394
3395 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3396
3397         * mi/mi-cmds.h (mi_cmd_complete): New function.
3398         * mi/mi-main.c (mi_cmd_complete): Likewise.
3399         * mi/mi-cmds.c: Define new MI command -complete.
3400         * NEWS: Mention new -complete command.
3401
3402 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3403
3404         * completer.h (complete): New function.
3405         * completer.c (complete): Likewise.
3406         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3407         function defined in completer.h.
3408
3409 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3410
3411         * MAINTAINERS (Write After Approval): Add myself.
3412
3413 2019-05-17  Tom de Vries  <tdevries@suse.de>
3414
3415         PR gdb/24094
3416         * dwarf2read.c (struct cu_partial_die_info): New struct.
3417         (find_partial_die): Return cu_partial_die_info.
3418         (partial_die_parent_scope, guess_partial_die_structure_name)
3419         (partial_die_info::fixup): Handle new return type of find_partial_die.
3420
3421 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3422
3423         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3424         "std::string", simplifying the algorithm.
3425
3426 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3427
3428         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3429         (stap_static_probe_ops::get_probes): Likewise.
3430
3431 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3432
3433         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3434         '-')" and "else if".
3435         (stap_parse_single_operand): Join checks for
3436         "gdbarch_stap_parse_special_token_p" and
3437         "gdbarch_stap_parse_special_token" in the same "if" statement.
3438         Invert check when verifying for operation on register
3439         displacement.
3440
3441 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3442
3443         * stap-probe.c (stap_get_opcode): Update comment.
3444         (stap_get_expected_argument_type): Likewise.
3445         (handle_stap_probe): Likewise.
3446
3447 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3448
3449         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3450         return type to 'bool'.  Adjust comment.  Use 'bool' when
3451         appropriate.
3452         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3453         * stap-probe.c (stap_parse_argument_1): Likewise.
3454         (stap_is_operator): Likewise.
3455         (stap_is_generic_prefix): Likewise.
3456         (stap_is_register_prefix): Likewise.
3457         (stap_is_register_indirection_prefix): Likewise.
3458         (stap_is_integer_prefix): Likewise.
3459         (stap_generic_check_suffix): Likewise.
3460         (stap_check_integer_suffix): Likewise.
3461         (stap_check_register_suffix): Likewise.
3462         (stap_check_register_indirection_suffix): Likewise.
3463         (stap_parse_register_operand): Likewise.
3464         (stap_parse_single_operand): Likewise.
3465         (stap_parse_argument_1): Likewise.
3466         (stap_probe::get_argument_count): Likewise.
3467         (stap_is_operator): Likewise.
3468
3469 2019-05-16  Tom Tromey  <tromey@adacore.com>
3470
3471         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3472         keyword to foreach.
3473
3474 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3475
3476         * linux-thread-db.c (try_thread_db_load_1): Change return type
3477         to bool.
3478         (try_thread_db_load): Likewise.
3479         (try_thread_db_load_from_pdir_1): Likewise.
3480         (try_thread_db_load_from_pdir): Likewise.
3481         (try_thread_db_load_from_sdir): Likewise.
3482         (try_thread_db_load_from_dir): Likewise.
3483         (thread_db_load_search): Likewise.
3484         (has_libpthread): Likewise.
3485         (thread_db_load): Likewise.
3486
3487 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3488
3489         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3490         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3491         NULL, and complain/return if that's the case.
3492
3493 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3494
3495         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3496         (advance, posn, abstract_read_memory): New functions.
3497         [struct mem_read_abstraction]: New struct.
3498         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3499
3500 2019-05-14  Tom Tromey  <tromey@adacore.com>
3501
3502         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3503         value is not lval_memory.
3504
3505 2019-05-14  Tom Tromey  <tromey@adacore.com>
3506
3507         * solib.c (info_sharedlibrary_command): Style the file name.
3508
3509 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3510
3511         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3512         (aarch64_vnv_type): Likewise.
3513         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3514         * common/tdesc.c: Likewise.
3515         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3516         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3517         * features/aarch64-fpu.xml: Add ieee half view.
3518         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3519         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3520         * gdbtypes.h (struct builtin_type): Likewise.
3521         (struct objfile_type): Likewise.
3522
3523 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3524
3525         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3526         typo.
3527         * location.h (string_to_event_location): Likewise.
3528
3529 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3530
3531         GDB 8.3 released.
3532
3533 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3534
3535         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3536         New variable declaration.
3537         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3538         New variable.
3539         (print_one_breakpoint): Use ui_out::test_flags and new global
3540         variable to compute use_fixed_output.
3541         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3542         Remove.
3543         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3544         (mi_multi_location_breakpoint_output_fixed): Remove.
3545         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3546         new variable.
3547         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3548         fix_multi_location_breakpoint_output flag if version >= 3.
3549         * ui-out.h (enum ui_out_flag)
3550         <fix_multi_location_breakpoint_output>: New enumerator.
3551
3552 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3553
3554         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3555
3556 2019-05-10  Tom Tromey  <tromey@adacore.com>
3557
3558         * ada-lang.c (catch_ada_completer): New function.
3559         (_initialize_ada_language): Use it.
3560
3561 2019-05-10  Tom Tromey  <tromey@adacore.com>
3562
3563         * thread.c (print_thread_info): Make "requested_threads" const.
3564         * gdbthread.h (print_thread_info): Make "requested_threads"
3565         const.
3566         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3567         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3568
3569 2019-05-08  Tom Tromey  <tom@tromey.com>
3570
3571         * gdbtypes.c (objfile_type_data): Change type.
3572         (objfile_type, _initialize_gdbtypes): Update.
3573
3574 2019-05-08  Tom Tromey  <tom@tromey.com>
3575
3576         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3577         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3578         (_initialize_dwarf2_frame): Update.
3579
3580 2019-05-08  Tom Tromey  <tom@tromey.com>
3581
3582         * objc-lang.c (objc_objfile_data): Change type.
3583         (find_methods): Update.
3584         (_initialize_objc_lang): Remove.
3585
3586 2019-05-08  Tom Tromey  <tom@tromey.com>
3587
3588         * stabsread.c (rs6000_builtin_type_data): Change type.
3589         (rs6000_builtin_type, _initialize_stabsread): Update.
3590
3591 2019-05-08  Tom Tromey  <tom@tromey.com>
3592
3593         * mips-tdep.c (mips_pdr_data): Remove.
3594         (_initialize_mips_tdep): Update.
3595
3596 2019-05-08  Tom Tromey  <tom@tromey.com>
3597
3598         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3599         (hppa_init_objfile_priv_data, read_unwind_info)
3600         (find_unwind_entry, _initialize_hppa_tdep): Update.
3601
3602 2019-05-08  Tom Tromey  <tom@tromey.com>
3603
3604         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3605         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3606         on obstack.
3607         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3608
3609 2019-05-08  Tom Tromey  <tom@tromey.com>
3610
3611         * mdebugread.c (basic_type_data): Change type.
3612         (basic_type, _initialize_mdebugread): Update.
3613
3614 2019-05-08  Tom Tromey  <tom@tromey.com>
3615
3616         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3617
3618 2019-05-08  Tom Tromey  <tom@tromey.com>
3619
3620         * nto-tdep.c (nto_inferior_data_reg): Change type.
3621         (nto_inferior_data): Update.
3622         (nto_inferior_data_cleanup, nto_new_inferior_data)
3623         (_initialize_nto_tdep): Remove.
3624         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3625
3626 2019-05-08  Tom Tromey  <tom@tromey.com>
3627
3628         * ada-lang.c (struct ada_inferior_data): Add initializers.
3629         (ada_inferior_data): Change type.
3630         (ada_inferior_data_cleanup): Remove.
3631         (get_ada_inferior_data, ada_inferior_exit)
3632         (struct ada_pspace_data): Add initializers, destructor.
3633         (ada_pspace_data_handle): Change type.
3634         (get_ada_pspace_data): Update.
3635         (ada_pspace_data_cleanup): Remove.
3636
3637 2019-05-08  Tom Tromey  <tom@tromey.com>
3638
3639         * coffread.c (struct coff_symfile_info): Add initializers.
3640         (coff_objfile_data_key): Move lower.  Change type.
3641         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3642         Update.
3643         (coff_free_info): Remove.
3644
3645 2019-05-08  Tom Tromey  <tom@tromey.com>
3646
3647         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3648         (fbsd_pspace_data_handle): Move lower.  Change type.
3649         (get_fbsd_pspace_data): Update.
3650         (fbsd_pspace_data_cleanup): Remove.
3651         (_initialize_fbsd_tdep): Update.
3652
3653 2019-05-08  Tom Tromey  <tom@tromey.com>
3654
3655         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3656         (get_ada_tasks_pspace_data): Update.
3657         (ada_tasks_pspace_data_cleanup): Remove.
3658         (_initialize_tasks): Update.
3659         (ada_tasks_inferior_data_handle): Change type.
3660         (get_ada_tasks_inferior_data): Update.
3661         (ada_tasks_inferior_data_cleanup): Remove.
3662         (struct ada_tasks_pspace_data): Add initializers.
3663
3664 2019-05-08  Tom Tromey  <tom@tromey.com>
3665
3666         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3667         * symfile-debug.c (debug_sym_get_probes): Change type.
3668         * stap-probe.c (handle_stap_probe):
3669         (stap_static_probe_ops::get_probes): Change type.
3670         * probe.h (class static_probe_ops) <get_probes>: Change type.
3671         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3672         (parse_probes_in_pspace): Update.
3673         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3674         Update.
3675         (any_static_probe_ops::get_probes): Change type.
3676         * elfread.c (elfread_data): New typedef.
3677         (probe_key): Change type.
3678         (elf_get_probes): Likewise.  Update.
3679         (probe_key_free): Remove.
3680         (_initialize_elfread): Update.
3681         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3682         Change type.
3683         (dtrace_process_dof_probe, dtrace_process_dof)
3684         (dtrace_static_probe_ops::get_probe): Change type.
3685
3686 2019-05-08  Tom Tromey  <tom@tromey.com>
3687
3688         * xcoffread.c (struct xcoff_symfile_info): Rename from
3689         coff_symfile_info.  Add initializers.
3690         (xcoff_objfile_data_key): Move lower.  Change type.
3691         (XCOFF_DATA): Rewrite.
3692         (xcoff_free_info): Remove.
3693         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3694         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3695         (xcoff_initial_scan): Update.
3696
3697 2019-05-08  Tom Tromey  <tom@tromey.com>
3698
3699         * solib-svr4.c (struct svr4_info): Add initializers and
3700         destructor.
3701         <probes_table>: Now an htab_up.
3702         (solib_svr4_pspace_data): Change type.
3703         (free_probes_table): Simplify.
3704         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3705         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3706         (probes_table_remove_objfile_probes, register_solib_event_probe)
3707         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3708         (_initialize_svr4_solib): Update.
3709
3710 2019-05-08  Tom Tromey  <tom@tromey.com>
3711
3712         * remote.c (remote_pspace_data): Change type.
3713         (remote_pspace_data_cleanup): Remove.
3714         (get_remote_exec_file, set_pspace_remote_exec_file)
3715         (_initialize_remote): Update.
3716
3717 2019-05-08  Tom Tromey  <tom@tromey.com>
3718
3719         * breakpoint.c (breakpoint_objfile_key): Change type.
3720         (get_breakpoint_objfile_data): Update.
3721         (free_breakpoint_objfile_data): Remove.
3722         (_initialize_breakpoint): Update.
3723
3724 2019-05-08  Tom Tromey  <tom@tromey.com>
3725
3726         * linux-tdep.c (struct linux_info): Add initializers.
3727         (linux_inferior_data): Move.  Change type.
3728         (invalidate_linux_cache_inf): Update.
3729         (linux_inferior_data_cleanup): Remove.
3730         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3731
3732 2019-05-08  Tom Tromey  <tom@tromey.com>
3733
3734         * auxv.c (auxv_inferior_data): Move.  Change type.
3735         (auxv_inferior_data_cleanup): Remove.
3736         (invalidate_auxv_cache_inf): Rewrite.
3737         (get_auxv_inferior_data, _initialize_auxv): Update.
3738
3739 2019-05-08  Tom Tromey  <tom@tromey.com>
3740
3741         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3742         (symfile_debug_objfile_data_key): Change type.
3743         (symfile_debug_installed, debug_qf_has_symbols)
3744         (debug_qf_find_last_source_symtab)
3745         (debug_qf_forget_cached_source_info)
3746         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3747         (debug_qf_print_stats, debug_qf_dump)
3748         (debug_qf_expand_symtabs_for_function)
3749         (debug_qf_expand_all_symtabs)
3750         (debug_qf_expand_symtabs_with_fullname)
3751         (debug_qf_map_matching_symbols)
3752         (debug_qf_expand_symtabs_matching)
3753         (debug_qf_find_pc_sect_compunit_symtab)
3754         (debug_qf_map_symbol_filenames)
3755         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3756         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3757         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3758         (debug_sym_read_linetable, debug_sym_relocate): Update.
3759         (symfile_debug_free_objfile): Remove.
3760         (install_symfile_debug_logging, _initialize_symfile_debug):
3761         Update.
3762
3763 2019-05-08  Tom Tromey  <tom@tromey.com>
3764
3765         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3766         allocate_on_obstack.
3767         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3768         (get_dwarf2_per_objfile): Update.
3769         (set_dwarf2_per_objfile): Remove.
3770         (dwarf2_has_info, dwarf2_get_section_info): Update.
3771         (dwarf2_free_objfile): Remove.
3772         (_initialize_dwarf2_read): Update.
3773
3774 2019-05-08  Tom Tromey  <tom@tromey.com>
3775
3776         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3777         initializers.
3778         <unsupported_script_warning_printed,
3779         script_not_found_warning_printed>: Now bool.
3780         (auto_load_pspace_data): Change type.
3781         (~auto_load_pspace_info): Rename from
3782         auto_load_pspace_data_cleanup.
3783         (get_auto_load_pspace_data, init_loaded_scripts_info)
3784         (clear_section_scripts, maybe_print_unsupported_script_warning)
3785         (maybe_print_script_not_found_warning, _initialize_auto_load):
3786         Update.
3787
3788 2019-05-08  Tom Tromey  <tom@tromey.com>
3789
3790         * objfiles.c (objfile_pspace_info): Add destructor and
3791         initializers.
3792         (objfiles_pspace_data): Change type.
3793         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3794         (get_objfile_pspace_data): Update.
3795         (objfiles_bfd_data): Change type.
3796         (get_objfile_bfd_data): Update.
3797         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3798
3799 2019-05-08  Tom Tromey  <tom@tromey.com>
3800
3801         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3802         Change type.
3803         (get_catch_syscall_inferior_data): Update.
3804         (catch_syscall_inferior_data_cleanup): Remove.
3805         (_initialize_break_catch_syscall): Update.
3806
3807 2019-05-08  Tom Tromey  <tom@tromey.com>
3808
3809         * inflow.c (struct terminal_info): Add destructor and
3810         initializers.
3811         (inflow_inferior_data): Change type.
3812         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3813         (get_inflow_inferior_data, inflow_inferior_exit)
3814         (swap_terminal_info, _initialize_inflow): Update.
3815
3816 2019-05-08  Tom Tromey  <tom@tromey.com>
3817
3818         * target-dcache.c (target_dcache_cleanup): Remove.
3819         (target_dcache_aspace_key): Change type.
3820         (target_dcache_init_p, target_dcache_invalidate)
3821         (target_dcache_get, target_dcache_get_or_init)
3822         (_initialize_target_dcache): Update.
3823         * dcache.h (struct dcache_deleter): New.
3824
3825 2019-05-08  Tom Tromey  <tom@tromey.com>
3826
3827         * symtab.c (struct symbol_cache): Add destructor and
3828         initializers.
3829         (symbol_cache_key): Move.  Change type.
3830         (make_symbol_cache, free_symbol_cache): Remove.
3831         (get_symbol_cache): Update.
3832         (symbol_cache_cleanup): Remove.
3833         (ALL_PSPACES, symbol_cache_flush)
3834         (maintenance_print_symbol_cache)
3835         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3836         Update.
3837
3838 2019-05-08  Tom Tromey  <tom@tromey.com>
3839
3840         * symtab.c (struct main_info): Add destructor and initializers.
3841         (main_progspace_key): Move.  Change type.
3842         (get_main_info): Update.
3843         (main_info_cleanup): Remove.
3844         (_initialize_symtab): Update.
3845
3846 2019-05-08  Tom Tromey  <tom@tromey.com>
3847
3848         * registry.h (DECLARE_REGISTRY): Define the _key class.
3849
3850 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3851
3852         * NEWS: Merge two 'New commands' sections.
3853
3854 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3855
3856         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3857         parameter and use Ada language definition instead.
3858         (ada_val_print_ptr): Remove unused language parameter.
3859         (ada_val_print_num): Remove language parameter and use Ada language
3860         definition instead.
3861         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3862         parameter.
3863         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3864         parameter and use Ada language definition instead.
3865         (ada_val_print_1): Update all ada_val_print_xxx calls.
3866         Remove language parameter.
3867         (ada_val_print): Update ada_val_print_1 call.
3868
3869 2019-05-08  Tom Tromey  <tromey@adacore.com>
3870
3871         * remote.c (remote_hw_watchpoint_limit)
3872         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3873         Now static.
3874
3875 2019-05-08  Tom Tromey  <tromey@adacore.com>
3876
3877         * maint.c (_initialize_maint_cmds): Move initialization code to
3878         remote.c.
3879         (watchdog, show_watchdog): Move to remote.c.
3880         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3881         "watchdog" static.
3882         (_initialize_remote): Move initialization code from maint.c.
3883         * defs.h (watchdog): Don't declare.
3884
3885 2019-05-08  Tom Tromey  <tromey@adacore.com>
3886
3887         * tui/tui-interp.c: Include main.h.
3888         * interps.c: Include main.h.
3889         * main.h (interpreter_p): Declare.
3890         * defs.h (interpreter_p): Don't declare.
3891
3892 2019-05-08  Tom Tromey  <tromey@adacore.com>
3893
3894         * dwarf2loc.c: Include dwarf2read.h.
3895         * defs.h (read_unsigned_leb128): Don't declare.
3896         * dwarf2read.h (read_unsigned_leb128): Declare.
3897
3898 2019-05-08  Tom Tromey  <tromey@adacore.com>
3899
3900         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3901         method.
3902
3903 2019-05-08  Tom Tromey  <tromey@adacore.com>
3904
3905         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3906         when no wrap column is set.
3907
3908 2019-05-08  Tom Tromey  <tromey@adacore.com>
3909
3910         * c-lang.c (c_get_string): Handle non-C-style arrays.
3911
3912 2019-05-08  Tom Tromey  <tromey@adacore.com>
3913
3914         * typeprint.c (print_offset_data::update): Print the bit offset,
3915         not the number of bits remaining.
3916
3917 2019-05-08  Tom Tromey  <tromey@adacore.com>
3918
3919         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3920         padding at end of comment.
3921
3922 2019-05-08  Tom Tromey  <tromey@adacore.com>
3923
3924         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3925         Compare main types.
3926
3927 2019-05-06  Tom Tromey  <tom@tromey.com>
3928
3929         * common/scoped_mmap.c: Include common-defs.h.
3930         * common/scoped_mmap.h: Don't include config.h.
3931
3932 2019-05-04  Tom Tromey  <tom@tromey.com>
3933
3934         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3935         (struct aarch64_call_info): Add initializers.
3936         <si>: Now a std::vector.
3937         (pass_on_stack, aarch64_push_dummy_call): Update.
3938
3939 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3940             Tom Tromey  <tom@tromey.com>
3941
3942         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3943         (ppc_threads): Now a std::vector.  Now static.
3944         (hwdebug_find_thread_points_by_tid)
3945         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3946         Update.
3947
3948 2019-05-04  Tom Tromey  <tom@tromey.com>
3949
3950         * arc-tdep.c (arc_tdesc_init): Return bool.
3951
3952 2019-05-04  Tom Tromey  <tom@tromey.com>
3953
3954         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3955         Use gdb_assert_not_reached.
3956
3957 2019-05-04  Tom Tromey  <tom@tromey.com>
3958
3959         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3960         "false".
3961
3962 2019-05-04  Tom Tromey  <tom@tromey.com>
3963
3964         * arc-tdep.c (arc_tdesc_init): Use bool.
3965
3966 2019-05-04  Tom Tromey  <tom@tromey.com>
3967
3968         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3969
3970 2019-05-04  Tom Tromey  <tom@tromey.com>
3971
3972         * cli/cli-cmds.c (valid_command_p): Return bool.
3973
3974 2019-05-04  Tom Tromey  <tom@tromey.com>
3975
3976         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3977         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3978
3979 2019-05-04  Raul Tambre  <raul@tambre.ee>
3980
3981         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3982         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3983         operator for comparison.
3984
3985 2019-05-04  Tom Tromey  <tom@tromey.com>
3986
3987         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3988         (lookup_partial_symbol, print_partial_symbols)
3989         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3990         (psymbol_compare): Update.
3991         (add_psymbol_to_bcache): Clear the entire psymbol.
3992         (maintenance_check_psymtabs): Update.
3993         * psympriv.h (struct partial_symbol): Don't derive from
3994         general_symbol_info.
3995         <obj_section, unrelocated_address, address,
3996         set_unrelocated_address>: Update.
3997         <ginfo>: New member.
3998         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3999         (debug_names::write_psymbols): Update.
4000
4001 2019-05-04  Tom de Vries  <tdevries@suse.de>
4002
4003         * contrib/cc-with-tweaks.sh: Support -n arg.
4004
4005 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4006
4007         * corelow.c (core_target::detach): Ensure frame cache and
4008         register caches are cleared.
4009         inferior.c (exit_inferior_1): Likewise.
4010
4011 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4012             Tom Tromey  <tom@tromey.com>
4013
4014         * dictionary.c (collate_pending_symbols_by_language): Remove
4015         "struct" from foreach.
4016         * symtab.c (lookup_global_symbol_from_objfile)
4017         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4018         foreach.
4019         * ser-tcp.c (net_open): Remove "struct" from foreach.
4020         * objfiles.c (objfile_relocate, objfile_rebase)
4021         (objfile_has_symbols): Remove "struct" from foreach.
4022         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4023         from foreach.
4024         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4025         foreach.
4026         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4027         "struct" from foreach.
4028         * ada-lang.c (create_excep_cond_exprs)
4029         (ada_exception_catchpoint_cond_string): Remove "struct" from
4030         foreach.
4031
4032 2019-05-03  Tom Tromey  <tromey@adacore.com>
4033
4034         * ada-exp.y (convert_char_literal): Check suffix of each
4035         enumerator.
4036
4037 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4038
4039         PR ada/21406:
4040         * ada-exp.y (yywrap): Don't define.
4041         * ada-lex.l (%option): Add noyywrap
4042         (yywrap): Remove.
4043
4044 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4045
4046         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4047         _WIN32_WINNT to the XP level, unless already defined to a higher
4048         level.
4049
4050         * unittests/parse-connection-spec-selftests.c:
4051         * ser-tcp.c:
4052         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4053         override.
4054
4055         * symfile.c (find_separate_debug_file): Remove colon from the
4056         drive spec of DOS/Windows file names of the target, so that the
4057         file name produced from DEBUGDIR and the target's directory will
4058         be valid on DOS/Windows systems.
4059
4060 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4061
4062         * rust-lang.c (val_print_struct): Handle printing structures
4063         containing strings.
4064
4065 2019-05-02  Tom Tromey  <tromey@adacore.com>
4066
4067         * valarith.c (_initialize_valarith): Remove.
4068
4069 2019-05-01  Tom Tromey  <tromey@adacore.com>
4070
4071         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4072         bitfields.
4073
4074 2019-05-01  Tom Tromey  <tromey@adacore.com>
4075
4076         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4077         for big-endian copies.
4078
4079 2019-04-30  Ali Tamur  <tamur@google.com>
4080         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4081         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4082         (read_3_bytes): New function.
4083
4084 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4085
4086         * windows-nat.c (main_thread_id): Delete.
4087         (handle_output_debug_string): Replace main_thread_id by
4088         current_event.dwThreadId.
4089         (fake_create_process): Likewise.
4090         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4091         Do not set main_thread_id.
4092         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4093         current_event.dwThreadId.
4094         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4095
4096 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4097
4098         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4099         Use current_event.dwThreadId instead of main_thread_id.
4100
4101 2019-04-30  Tom Tromey  <tromey@adacore.com>
4102
4103         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4104         (create_excep_cond_exprs): Iterate over program spaces.
4105         (ada_exception_catchpoint_cond_string): Examine all minimal
4106         symbols for exception types.
4107
4108 2019-04-30  Tom Tromey  <tromey@adacore.com>
4109
4110         PR c++/24470:
4111         * dwarf2read.c (process_structure_scope): Handle case where type
4112         has template parameters but no symbol was created.
4113
4114 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4115             Chris January  <chris.january@arm.com>
4116
4117         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4118         qualifier.
4119         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4120
4121 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4122
4123         * f-typeprint.c (f_print_type): Update rules for printing
4124         whitespace.
4125         (f_type_print_varspec_suffix): Likewise.
4126
4127 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4128             Chris January  <chris.january@arm.com>
4129
4130         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4131         function arguments.
4132
4133 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4134
4135         * f-lang.c (build_fortran_types): Change name of void type to
4136         lower case.
4137         * f-typeprint.c (f_type_print_base): Print the name of the void
4138         type, rather than a fixed string.
4139         * f-valprint.c (f_decorations): Use lower case void string.
4140
4141 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4142             Chris January  <chris.january@arm.com>
4143
4144         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4145         types for Fortran.
4146
4147 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4148             Chris January  <chris.january@arm.com>
4149             David Lecomber  <david.lecomber@arm.com>
4150
4151         * f-exp.y (BINOP_INTRINSIC): New token.
4152         (exp): New parser rule handling BINOP_INTRINSIC.
4153         (f77_keywords): Add new builtin procedures.
4154         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4155         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4156         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4157         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4158         (print_unop_subexp_f): New function.
4159         (print_binop_subexp_f): New function.
4160         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4161         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4162         (dump_subexp_body_f): Likewise.
4163         (operator_check_f): Likewise.
4164         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4165         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4166
4167 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4168
4169         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4170         UNOP_KIND.
4171         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4172         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4173         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4174         (operator_length_f): New fuction.
4175         (print_subexp_f): New function.
4176         (op_name_f): New function.
4177         (dump_subexp_body_f): New function.
4178         (operator_check_f): New function.
4179         (exp_descriptor_f): Replace standard expression handling functions
4180         with new functions.
4181         * gdb/fortran-operator.def: New file.
4182         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4183         * gdb/std-operator.def: Remove UNOP_KIND.
4184
4185 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4186
4187         * std-operator.def: Remove unbalanced, stray double quote
4188         character.
4189
4190 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4191             Chris January  <chris.january@arm.com>
4192             Daniel Everett  <daniel.everett@arm.com>
4193             Nick Forrington  <nick.forrington@arm.com>
4194             Richard Bunt  <richard.bunt@arm.com>
4195
4196         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4197         of depth when printing anonymous structs or unions.
4198         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4199         Don't print either the top-level value, or the children if the
4200         max-depth is exceeded.
4201         (ppscm_print_children): When printing the key of a map, allow one
4202         extra level of depth.
4203         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4204         print either the top-level value, or the children if the max-depth
4205         is exceeded.
4206         (print_children): When printing the key of a map, allow one extra
4207         level of depth.
4208         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4209         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4210         (user_print_options): Initialise max_depth field.
4211         (val_print_scalar_or_string_type_p): New function.
4212         (val_print): Check to see if the max depth has been reached.
4213         (val_print_check_max_depth): Define new function.
4214         (show_print_max_depth): New function.
4215         (_initialize_valprint): Add 'print max-depth' option.
4216         * valprint.h (struct value_print_options) <max_depth>: New field.
4217         (val_print_check_max_depth): Declare new function.
4218         * NEWS: Document new feature.
4219
4220 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4221
4222         * ada-lang.c (ada_language_defn): Initialise new field.
4223         * c-lang.c (c_is_string_type_p): New function.
4224         (c_language_defn): Initialise new field.
4225         (cplus_language_defn): Initialise new field.
4226         (asm_language_defn): Initialise new field.
4227         (minimal_language_defn): Initialise new field.
4228         * c-lang.h (c_is_string_type_p): Declare new function.
4229         * d-lang.c (d_language_defn): Initialise new field.
4230         * f-lang.c (f_is_string_type_p): New function.
4231         (f_language_defn): Initialise new field.
4232         * go-lang.c (go_is_string_type_p): New function.
4233         (go_language_defn): Initialise new field.
4234         * language.c (default_is_string_type_p): New function.
4235         (unknown_language_defn): Initialise new field.
4236         (auto_language_defn): Initialise new field.
4237         * language.h (struct language_defn) <la_is_string_type_p>: New
4238         member variable.
4239         (default_is_string_type_p): Declare new function.
4240         * m2-lang.c (m2_language_defn): Initialise new field.
4241         * objc-lang.c (objc_language_defn): Initialise new field.
4242         * opencl-lang.c (opencl_language_defn): Initialise new field.
4243         * p-lang.c (pascal_is_string_type_p): New function.
4244         (pascal_language_defn): Initialise new field.
4245         * rust-lang.c (rust_is_string_type_p): New function.
4246         (rust_language_defn): Initialise new field.
4247
4248 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4249
4250         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4251         New field.
4252         * ada-lang.c (ada_language_defn): Initialise new field.
4253         * c-lang.c (c_language_defn): Likewise.
4254         (cplus_language_defn): Likewise.
4255         (asm_language_defn): Likewise.
4256         (minimal_language_defn): Likewise.
4257         * d-lang.c (d_language_defn): Likewise.
4258         * f-lang.c (f_language_defn): Likewise.
4259         * go-lang.c (go_language_defn): Likewise.
4260         * language.c (unknown_language_defn): Likewise.
4261         (auto_language_defn): Likewise.
4262         * m2-lang.c (m2_language_defn): Likewise.
4263         * objc-lang.c (objc_language_defn): Likewise.
4264         * opencl-lang.c (opencl_language_defn): Likewise.
4265         * p-lang.c (pascal_language_defn): Likewise.
4266         * rust-lang.c (rust_language_defn): Likewise.
4267
4268 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4269
4270         * ada-lang.c (ada_is_character_type): Change return type to bool.
4271         (ada_is_string_type): Likewise.
4272         * ada-lang.h (ada_is_character_type): Update declaration
4273         (ada_is_string_type): Likewise.
4274
4275 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4276
4277         Support style in 'frame|thread apply'
4278
4279         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4280         * record.c (record_start, record_stop): Update callers of
4281         execute_command_to_string with false.
4282         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4283         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4284         methods.
4285         (class string_file): New constructor with term_out parameter.
4286         Override methods term_out and can_emit_style_escape.  New member
4287         term_out.
4288         (class stdio_file): Override can_emit_style_escape.
4289         (class tee_file): Override term_out and can_emit_style_escape.
4290         * utils.h (can_emit_style_escape): Remove.
4291         * utils.c (can_emit_style_escape): Likewise.
4292         Update all callers of can_emit_style_escape (SOMESTREAM) to
4293         SOMESTREAM->can_emit_style_escape.
4294         * source-cache.c (source_cache::get_source_lines): Likewise.
4295         * stack.c (frame_apply_command_count): Call execute_command_to_string
4296         passing the term_out characteristic of the current gdb_stdout.
4297         * thread.c (thr_try_catch_cmd): Likewise.
4298         * top.c (execute_command_to_string): pass term_out parameter
4299         to construct the string_file for the command output.
4300         * ui-file.c (term_cli_styling): New function (most code moved
4301         from utils.c can_emit_style_escape).
4302         (string_file::string_file, string_file::can_emit_style_escape,
4303         stdio_file::can_emit_style_escape, tee_file::term_out,
4304         tee_file::can_emit_style_escape): New functions.
4305
4306 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4307
4308         * NEWS: Mention the new set|show may-call-functions.
4309         * infcall.c (may_call_functions_p): New variable.
4310         (show_may_call_functions_p): New function.
4311         (call_function_by_hand_dummy): Throws an error if not
4312         may-call-functions.
4313         (_initialize_infcall): Call add_setshow_boolean_cmd for
4314         may-call-functions.
4315
4316 2019-04-25  Keith Seitz  <keiths@redhat.com>
4317
4318         PR c++/24367
4319         * cp-support.c (inspect_type): Don't attempt substitutions
4320         of symbol with the same name.
4321
4322 2019-04-25  Tom Tromey  <tromey@adacore.com>
4323
4324         PR gdb/24475:
4325         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4326         static.
4327
4328 2019-04-25  Tom Tromey  <tromey@adacore.com>
4329
4330         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4331         rvalue reference.
4332         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4333         (gdb_xml_parser::parse): Use std::move.
4334         * python/python-internal.h (gdbpy_convert_exception): Take a const
4335         reference.
4336         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4337         std::move.
4338         * python/py-utils.c (gdbpy_convert_exception): Take a const
4339         reference.
4340         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4341         Use std::move.
4342         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4343         Use std::move.
4344         * mi/mi-main.c (mi_print_exception): Take a const reference.
4345         * main.c (handle_command_errors): Take a const reference.
4346         * linespec.c (parse_linespec): Use std::move.
4347         * infcall.c (run_inferior_call): Use std::move.
4348         (call_function_by_hand_dummy): Use std::move.
4349         * exec.c (try_open_exec_file): Use std::move.
4350         * exceptions.h (exception_print, exception_fprintf)
4351         (exception_print_same): Update.
4352         * exceptions.c (print_exception, exception_print)
4353         (exception_fprintf, exception_print_same): Change parameters to
4354         const reference.
4355         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4356         * common/new-op.c: Use std::move.
4357         * common/common-exceptions.h (struct gdb_exception): Add move
4358         constructor.
4359         (struct gdb_exception_error, struct gdb_exception_quit, struct
4360         gdb_quit_bad_alloc): Change constructor to move constructor.
4361         (throw_exception): Change parameter to rvalue reference.
4362         * common/common-exceptions.c (throw_exception): Take rvalue
4363         reference.
4364         * cli/cli-interp.c (safe_execute_command): Use std::move.
4365         * breakpoint.c (insert_bp_location, location_to_sals): Use
4366         std::move.
4367
4368 2019-04-25  Tom Tromey  <tromey@adacore.com>
4369
4370         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4371         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4372         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4373         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4374         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4375         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4376         guile/scm-value.c: Use unpack.
4377         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4378         gdbscm_gdb_exception.
4379         (gdbscm_throw_gdb_exception): Likewise.
4380         (struct gdbscm_gdb_exception): New.
4381         (unpack): New function.
4382         (gdbscm_wrap): Use unpack.
4383
4384 2019-04-25  Tom Tromey  <tromey@adacore.com>
4385
4386         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4387         (gdb_rl_callback_handler): Use std::move.
4388         * common/common-exceptions.h (struct gdb_exception): Add move
4389         assignment operator.
4390         (throw_exception_sjlj): Change "exception" to const reference.
4391         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4392         (throw_exception_sjlj): Change "exception" to const reference.
4393
4394 2019-04-25  Tom Tromey  <tromey@adacore.com>
4395
4396         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4397         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4398         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4399         Update.
4400         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4401         Update.
4402         * mi/mi-interp.c (mi_interp::exec): Update.
4403         * linespec.c (parse_linespec): Update.
4404         * infcall.c (run_inferior_call): Update.
4405         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4406         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4407         (gdbscm_lookup_global_symbol): Update.
4408         * guile/scm-param.c (gdbscm_parameter_value): Update.
4409         * guile/scm-frame.c (gdbscm_frame_read_register)
4410         (gdbscm_frame_read_var): Update.
4411         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4412         * exec.c (try_open_exec_file): Update.
4413         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4414         (gdb_rl_callback_handler): Update.
4415         * common/common-exceptions.h (exception_none): Don't declare.
4416         * common/common-exceptions.c (exception_none): Don't define.
4417         (struct catcher) <exception>: Update.
4418         * cli/cli-interp.c (safe_execute_command): Update.
4419         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4420
4421 2019-04-25  Ali Tamur  <tamur@google.com>
4422
4423         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4424         (read_attribute_value): Likewise.
4425         (dwarf2_read_addr_index): Update comment.
4426         (read_str_index): Add DW_FORM_strx.
4427         (dwarf2_string_attr): Likewise.
4428         (dwarf2_const_value_attr): Likewise.
4429         (dump_die_shallow): Likewise.
4430         (dwarf2_fetch_constant_bytes): Likewise.
4431         (skip_form_bytes): Likewise.
4432         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4433
4434 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4435
4436         PR corefiles/11608
4437         PR corefiles/18187
4438         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4439         OFFSET.  Verify if current mapping contains an ELF header.
4440         (linux_find_memory_regions_full): Adjust call to
4441         dump_mapping_p.
4442
4443 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4444             Kang Li <kanglictf@gmail.com>
4445
4446         PR gdb/21600
4447
4448         * dwarf2-frame.c (read_initial_length): Be consistent about using
4449         unsigned representation of length.
4450         (decode_frame_entry_1): Likewise.  Check for wraparound of
4451         end pointer as well as buffer overflow.
4452
4453 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4454
4455         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4456         "vq".
4457
4458 2019-04-24  Tom Tromey  <tromey@adacore.com>
4459
4460         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4461
4462 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4463
4464         * s12z-tdep.c (s12z_unwind_pc): Delete.
4465         (s12z_unwind_sp): Delete.
4466         (s12z_gdbarch_init): Don't register deleted functions with
4467         gdbarch.
4468
4469 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4470
4471         * rl78-tdep.c (rl78_unwind_sp): Delete.
4472         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4473
4474 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4475
4476         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4477         (xstormy16_unwind_pc): Delete.
4478         (xstormy16_dummy_id): Delete.
4479         (xstormy16_gdbarch_init): Don't register deleted functions with
4480         gdbarch.
4481
4482 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4483
4484         * vax-tdep.c (vax_unwind_pc): Delete.
4485         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4486
4487 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4488
4489         * v850-tdep.c (v850_unwind_sp): Delete.
4490         (v850_unwind_pc): Delete.
4491         (v850_dummy_id): Delete.
4492         (v850_gdbarch_init): Don't register deleted functions with
4493         gdbarch.
4494
4495 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4496
4497         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4498         (tilegx_unwind_pc): Delete.
4499         (tilegx_unwind_dummy_id): Delete.
4500         (tilegx_gdbarch_init): Don't register deleted functions with
4501         gdbarch.
4502
4503 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4504
4505         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4506         (tic6x_dummy_id): Delete.
4507         (tic6x_gdbarch_init): Don't register deleted functions with
4508         gdbarch.
4509
4510 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4511
4512         * sparc-tdep.c (sparc_unwind_pc): Delete.
4513         (sparc32_gdbarch_init): Don't register deleted function with
4514         gdbarch.
4515
4516 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4517
4518         * sh-tdep.c (sh_unwind_sp): Delete.
4519         (sh_unwind_pc): Delete.
4520         (sh_dummy_id): Delete.
4521         (sh_gdbarch_init): Don't register deleted functions with
4522         gdbarch.
4523
4524 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4525
4526         * score-tdep.c (score_unwind_sp): Delete.
4527         (score_unwind_pc): Delete.
4528         (score_dummy_id): Delete.
4529         (score_gdbarch_init): Don't register deleted functions with
4530         gdbarch.
4531
4532 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4533
4534         * rx-tdep.c (rx_unwind_pc): Delete.
4535         (rx_unwind_sp): Delete.
4536         (rx_dummy_id): Delete.
4537         (rx_gdbarch_init): Don't register deleted functions with
4538         gdbarch.  Update comment.
4539
4540 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4541
4542         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4543         (rs6000_dummy_id): Delete.
4544         (rs6000_gdbarch_init): Don't register deleted functions with
4545         gdbarch.
4546
4547 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4548
4549         * or1k-tdep.c (or1k_dummy_id): Delete.
4550         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4551
4552 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4553
4554         * nios2-tdep.c (nios2_dummy_id): Delete.
4555         (nios2_unwind_sp): Delete.
4556         (nios2_gdbarch_init): Don't register deleted functions with
4557         gdbarch.
4558
4559 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4560
4561         * nds32-tdep.c (nds32_dummy_id): Delete.
4562         (nds32_unwind_pc): Delete.
4563         (nds32_unwind_sp): Delete.
4564         (nds32_gdbarch_init): Don't register deleted functions with
4565         gdbarch.
4566
4567 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4568
4569         * msp430-tdep.c (msp430_unwind_pc): Delete.
4570         (msp430_unwind_sp): Delete.
4571         (msp430_dummy_id): Delete.
4572         (msp430_gdbarch_init): Don't register deleted functions with
4573         gdbarch.
4574
4575 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4576
4577         * moxie-tdep.c (moxie_unwind_sp): Delete.
4578         (moxie_unwind_pc): Delete.
4579         (moxie_dummy_id): Delete.
4580         (moxie_gdbarch_init): Don't register deleted functions with
4581         gdbarch.
4582
4583 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4584
4585         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4586         (mn10300_unwind_pc): Delete.
4587         (mn10300_unwind_sp): Delete.
4588         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4589         mn10300_unwind_sp.
4590         (mn10300_frame_unwind_init): Don't register deleted functions with
4591         gdbarch.
4592
4593 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4594
4595         * mep-tdep.c (mep_unwind_pc): Delete.
4596         (mep_unwind_sp): Delete.
4597         (mep_dummy_id): Delete.
4598         (mep_gdbarch_init): Don't register deleted functions with
4599         gdbarch.
4600
4601 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4602
4603         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4604         (m68hc11_unwind_sp): Delete.
4605         (m68hc11_gdbarch_init): Don't register deleted functions with
4606         gdbarch.
4607
4608 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4609
4610         * m32r-tdep.c (m32r_unwind_sp): Delete.
4611         (m32r_unwind_pc): Delete.
4612         (m32r_dummy_id): Delete.
4613         (m32r_gdbarch_init): Don't register deleted functions with
4614         gdbarch.
4615
4616 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4617
4618         * m32c-tdep.c (m32c_unwind_pc): Delete.
4619         (m32c_unwind_sp): Delete.
4620         (m32c_dummy_id): Delete.
4621         (m32c_gdbarch_init): Don't register deleted functions with
4622         gdbarch.
4623
4624 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4625
4626         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4627         (lm32_unwind_pc): Delete.
4628         (lm32_dummy_id): Delete.
4629         (lm32_gdbarch_init): Don't register deleted functions with
4630         gdbarch.
4631
4632 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4633
4634         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4635         (iq2000_unwind_pc): Delete.
4636         (iq2000_dummy_id): Delete.
4637         (iq2000_gdbarch_init): Don't register deleted functions with
4638         gdbarch.
4639
4640 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4641
4642         * nds32-tdep.c (nds32_type_align): Delete.
4643         (nds32_push_dummy_call): Use type_align instead.
4644
4645 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4646
4647         * arm-tdep.c (arm_type_align): Only handle vector override case.
4648         (arm_push_dummy_call): Use type_align.
4649         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4650
4651 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4652
4653         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4654         case.
4655         (pass_on_stack): Use type_align.
4656         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4657         function.
4658
4659 2019-04-23  Tom Tromey  <tromey@adacore.com>
4660
4661         * dwarf2read.c (line_header::file_name_at): Remove unused
4662         overload.
4663
4664 2019-04-23  Tom de Vries  <tdevries@suse.de>
4665
4666         PR gdb/24438
4667         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4668         invocation.
4669
4670
4671 2019-03-27  Ali Tamur  <tamur@google.com>
4672
4673         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4674         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4675         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4676         (dwarf_expr_context::get_addr_index): Likewise
4677         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4678         (symbol_needs_eval_context::get_addr_index): Likewise
4679         (disassemble_dwarf_expression): Add DW_OP_addrx
4680         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4681         (read_cutu_die_from_dwo): Update comment
4682         (skip_one_die): Add DW_FORM_addrx
4683         (read_attribute_value): Likewise
4684         (var_decode_location): Add DW_OP_addrx
4685         (dwarf2_const_value_attr): Add DW_FORM_addrx
4686         (dump_die_shallow): Likewise
4687         (dwarf2_fetch_constant_bytes): Likewise
4688         (decode_locdesc): Add DW_OP_addrx
4689         (skip_form_bytes): Add DW_FORM_addrx
4690
4691 2019-04-22  Ali Tamur  <tamur@google.com>
4692
4693         * MAINTAINERS (Write After Approval): Add self.
4694
4695 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4696
4697         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4698         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4699         (open_symbol_file_object): Likewise.
4700         (svr4_default_sos): Add info parameter.
4701         (svr4_read_so_list): Likewise.
4702         (svr4_current_sos_direct): Adjust functions calls to pass down
4703         info.
4704         (svr4_current_sos_1): Add info parameter.
4705         (svr4_current_sos): Call get_svr4_info, pass info down to
4706         svr4_current_sos_1.
4707         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4708         get_svr4_info.
4709         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4710         get_svr4_info.
4711         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4712         to get_svr4_info.
4713         (probes_table_remove_objfile_probes): Likewise.
4714         (register_solib_event_probe): Add info parameter.
4715         (solist_update_incremental): Pass info parameter down to
4716         svr4_read_so_list.
4717         (disable_probes_interface): Add info parameter.
4718         (svr4_handle_solib_event): Pass current_program_space to
4719         get_svr4_info.  Adjust disable_probes_interface cleanup.
4720         (svr4_create_probe_breakpoints): Add info parameter, pass it
4721         down to register_solib_event_probe.
4722         (svr4_create_solib_event_breakpoints): Add info parameter,
4723         pass it down to svr4_create_probe_breakpoints.
4724         (enable_break): Pass info down to
4725         svr4_create_solib_event_breakpoints.
4726         (svr4_solib_create_inferior_hook): Pass current_program_space to
4727         get_svr4_info.
4728         (svr4_clear_solib): Likewise.
4729
4730 2019-04-22  Pedro Alves  <palves@redhat.com>
4731
4732         * solib-svr4.c (svr4_free_objfile_observer): New.
4733         (probe_and_action::objfile): New field.
4734         (probes_table_htab_remove_objfile_probes)
4735         (probes_table_remove_objfile_probes): New functions.
4736         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4737         in the new probe_and_action.  Don't store the probe in 'lookup'.
4738         (svr4_create_probe_breakpoints): Pass objfile to
4739         register_solib_event_probe.
4740         (_initialize_svr4_solib): Register a free_objfile observer.
4741
4742 2019-04-19  Tom Tromey  <tom@tromey.com>
4743
4744         * common/queue.h: Remove.
4745
4746 2019-04-19  Tom Tromey  <tom@tromey.com>
4747
4748         * event-loop.c: Don't include "common/queue.h".
4749
4750 2019-04-19  Tom Tromey  <tom@tromey.com>
4751
4752         * remote.c (remote_target): Use delete.
4753         * remote-notif.h: Include <list>, not "common/queue.h".
4754         (notif_client_p): Remove typedef.
4755         (remote_notif_state): Add constructor, destructor, initializer.
4756         <notif_queue>: Now a std::list.
4757         (remote_notif_state_xfree): Don't declare.
4758         * remote-notif.c (remote_notif_process, handle_notification)
4759         (remote_notif_state_allocate): Update.
4760         (~remote_notif_state): Rename from remote_notif_state_xfree.
4761
4762 2019-04-19  Tom Tromey  <tom@tromey.com>
4763
4764         * symfile.c (reread_symbols): Update.
4765         * objfiles.c (objfile_register_static_link)
4766         (objfile_lookup_static_link): Update
4767         (~objfile) Don't delete static_links.
4768         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4769
4770 2019-04-19  Tom Tromey  <tom@tromey.com>
4771
4772         * type-stack.h (struct type_stack) <insert>: Constify string.
4773         * type-stack.c (type_stack::insert): Constify string.
4774         * gdbtypes.h (lookup_template_type): Update.
4775         (address_space_name_to_int): Update.
4776         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4777         const.
4778         (lookup_template_type): Make name const.
4779         * c-exp.y: Update rules.
4780         (lex_one_token, classify_name, classify_inner_name)
4781         (c_print_token): Update.
4782         * p-exp.y: Update rules.
4783         (yylex): Update.
4784         * f-exp.y: Update rules.
4785         (yylex): Update.
4786         * d-exp.y: Update rules.
4787         (lex_one_token, classify_name, classify_inner_name): Update.
4788         * parse.c (write_dollar_variable, copy_name): Return std::string.
4789         * parser-defs.h (copy_name): Change return type.
4790         * m2-exp.y: Update rules.
4791         (yylex): Update.
4792         * go-exp.y (lex_one_token): Update.
4793         Update rules.
4794         (classify_unsafe_function, classify_packaged_name)
4795         (classify_name, yylex): Update.
4796
4797 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4798
4799         * configure.ac: add --enable-source-highlight switch.
4800         * configure: Regenerate.
4801         * top.c (print_gdb_version): plumb --enable-source-highlight
4802         status to "show configuration".
4803
4804 2019-04-19  Tom Tromey  <tromey@adacore.com>
4805
4806         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4807         Check ADA_TYPE_P.
4808         (empty_record, ada_template_to_fixed_record_type_1)
4809         (template_to_static_fixed_type)
4810         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4811         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4812         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4813         macros.
4814
4815 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4816
4817         PR symtab/24423:
4818         * source.c (print_source_lines_base): Advance "iter" when a
4819         control character is seen.
4820
4821 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4822
4823         * inferior.h (struct infcall_suspend_state_deleter):
4824         Catch exception in destructor to avoid crash.
4825
4826 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4827
4828         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4829         close to the add_com "shell".
4830
4831 2019-04-18  Tom Tromey  <tromey@adacore.com>
4832
4833         * process-stratum-target.h (class process_stratum_target)
4834         <stratum>: Add "final".
4835
4836 2019-04-17  Tom Tromey  <tromey@adacore.com>
4837
4838         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4839         against nullptr before use.
4840
4841 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4842
4843         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4844
4845 2019-04-17  Jim Wilson  <jimw@sifive.com>
4846             Andrew Burgess  <andrew.burgess@embecosm.com>
4847
4848         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4849         code read might fail, assume 4-byte breakpoint in that case.
4850
4851 2019-04-15  Leszek Swirski  <leszeks@google.com>
4852
4853         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4854         rather than a hand-rolled POD check when checking for forced MEMORY
4855         classification.
4856
4857 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4858
4859         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4860         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4861         function.
4862         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4863         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4864         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4865         declaration.
4866
4867 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4868
4869         * aarch64-linux-nat.c
4870         (aarch64_linux_nat_target::thread_architecture): Add override.
4871         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4872         each VQ.
4873
4874 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4875
4876         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4877
4878 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4879
4880         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4881         target types of size 96-bits, add some additional comments, and
4882         check that the builtin type we found was the correct size.
4883
4884 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4885
4886         * utils.c (prompt_for_continue): Don't restore the styling at the
4887         end, as applied_style has the wrong value.  This fixes styling in
4888         long lists of file names that are interrupted by the "Continue?"
4889         prompt.
4890
4891 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4892
4893         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4894         * c-lang.c (c_language_defn): Likewise.
4895         (cplus_language_defn): Likewise.
4896         (asm_language_defn): Likewise.
4897         (minimal_language_defn): Likewise.
4898         * d-lang.c (d_language_defn): Likewise.
4899         * f-lang.c (f_language_defn): Likewise.
4900         * go-lang.c (go_language_defn): Likewise.
4901         * language.c (unknown_language_defn): Likewise.
4902         (auto_language_defn): Likewise.
4903         * language.h (struct language_defn): Remove la_magic field.
4904         (LANG_MAGIC): Delete.
4905         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4906         * objc-lang.c (objc_language_defn): Likewise.
4907         * opencl-lang.c (opencl_language_defn): Likewise.
4908         * p-lang.c (pascal_language_defn): Likewise.
4909         * rust-lang.c (rust_language_defn): Likewise.
4910
4911 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4912
4913         * riscv-tdep.c (riscv_type_align): New function.
4914         (riscv_type_alignment): Delete.
4915         (riscv_arg_location): Use 'type_align'.
4916         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4917
4918 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4919
4920         * gdbtypes.c (type_align): A struct with no non-static fields also
4921         has alignment of 1.
4922
4923 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4924
4925         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4926         component to 0.
4927         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4928         member.
4929         (riscv_struct_info::analyse): New implementation using new
4930         analyse_inner member function.
4931         (riscv_struct_info::field_offset): New member function.
4932         (riscv_struct_info::m_offsets): New member variable.
4933         (riscv_struct_info::analyse_inner): New private member function,
4934         takes the old implementation of riscv_struct_info::analyse but
4935         extended to track field offsets.
4936         (riscv_call_arg_struct): Update the struct folding special cases
4937         to handle cases where empty C++ structs, which are non-zero
4938         length, are found.
4939         (riscv_arg_location): Initialise the length of each location, a
4940         non-zero length now indicates the location is in use.
4941         (riscv_push_dummy_call): Allow for the first location having a
4942         non-zero offset when setting up arguments.
4943         (riscv_return_value): Likewise, but for return values.
4944
4945 2019-04-11  Tom Tromey  <tromey@adacore.com>
4946
4947         * utils.c (internal_vproblem): Make "msg" const.
4948
4949 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4950
4951         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4952         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4953         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4954         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4955
4956 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4957
4958         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4959         function.
4960         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4961         of amd64_collect_native_gregset.
4962         (amd64_linux_nat_target::store_registers): Likewise.
4963
4964 2019-04-10  Tom Tromey  <tom@tromey.com>
4965
4966         * symtab.c (lookup_global_symbol_from_objfile)
4967         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4968         * objfiles.h (class separate_debug_iterator): New.
4969         (class separate_debug_range): New.
4970         (struct objfile) <separate_debug_objfiles>: New method.
4971         (objfile_separate_debug_iterate): Don't declare.
4972         * objfiles.c (separate_debug_iterator::operator++): Rename from
4973         objfile_separate_debug_iterate.
4974         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4975         iterator.
4976         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4977         iterator.
4978
4979 2019-04-10  Tom Tromey  <tom@tromey.com>
4980
4981         * symfile.c (reread_symbols): Remove old comment.
4982         * objfiles.c (free_all_objfiles): Fix a typo.
4983
4984 2019-04-10  Tom Tromey  <tom@tromey.com>
4985
4986         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4987         * minsyms.c (lookup_minimal_symbol): Use foreach.
4988         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4989         (lookup_minimal_symbol_solib_trampoline): Likewise.
4990         * symfile.c (reread_symbols): Use foreach.
4991
4992 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4993             Tom Tromey  <tromey@adacore.com>
4994
4995         PR rust/24414:
4996         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4997         (rust_lex_int_test): Change "value" to be LONGEST.
4998         (rust_lex_tests): Add test for long integer literal.
4999
5000 2019-04-09  Tom Tromey  <tromey@adacore.com>
5001
5002         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5003         to bool.
5004         (extended_remote_target::attach): Update.
5005         (remote_target::remote_notice_new_inferior): Update.
5006         (remote_target::add_current_inferior_and_thread): Update.
5007         * inferior.c (exit_inferior_1): Use "false".
5008         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5009
5010 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5011
5012         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5013         the "start" command.
5014
5015 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5016
5017         * python/py-inferior.c (infpy_thread_from_thread_handle):
5018         Adjust comments to reflect renaming of thread_from_thread_handle
5019         to thread_from_handle.  Adjust keywords.  Fix type error message.
5020         (inferior_object_methods): Add thread_from_handle.  Retain
5021         thread_from_thread_handle, but mark it as deprecated.
5022
5023 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5024
5025         * gdbthread.h (find_thread_by_handle): Revise declaration.
5026         * thread.c (find_thread_by_handle): Likewise.  Adjust
5027         implementation too.
5028         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5029         support for buffer objects as handles.
5030
5031 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5032
5033         * python/py-infthread.c (thpy_thread_handle): New function.
5034         (thread_object_methods): Register thpy_thread_handle.
5035
5036 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5037
5038         * gdbthread.h (thread_to_thread_handle): Declare.
5039         * thread.c (gdbtypes.h): Include.
5040         (thread_to_thread_handle): New function.
5041
5042         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5043         (target_thread_info_to_thread_handle): Declare.
5044         * target.c (target_thread_info_to_thread_handle): New function.
5045         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5046         * target-delegates.c: Regenerate.
5047
5048         * linux-thread-db.c (class thread_db_target): Add method
5049         thread_info_to_thread_handle.
5050         (thread_db_target::thread_info_to_thread_handle): Define.
5051         * remote.c (class remote_target): Add new method
5052         thread_info_to_thread_handle.
5053         (remote_target::thread_info_to_thread_handle): Define.
5054
5055 2019-04-08  Pedro Alves  <palves@redhat.com>
5056
5057         * common/common-exceptions.c (throw_exception): Don't create
5058         named object to throw; throw directly.
5059         (throw_it): Likewise.  Don't initialize gdb_exception::message
5060         here, with new; pass FMT and AP to the ctor instead.
5061         * common/common-exceptions.h: Include <string>.
5062         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5063         const char *, va_list)): New ctor.  Use std::make_shared.
5064         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5065         errors)): Delete.
5066         (gdb_exception_error::gdb_exception_error(enum errors, const char
5067         *, va_list)): New.
5068         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5069         Add assertion.
5070         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5071         errors)): Delete.
5072         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5073         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5074         Add assertion.
5075
5076 2019-04-08  Tom Tromey  <tom@tromey.com>
5077
5078         * valops.c (value_rtti_indirect_type): Replace throw_exception
5079         with throw.
5080         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5081         with throw.
5082         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5083         throw.
5084         * target.c (target_translate_tls_address): Replace throw_exception
5085         with throw.
5086         * stack.c (frame_apply_command_count): Replace throw_exception
5087         with throw.
5088         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5089         throw.
5090         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5091         with throw.
5092         * rs6000-tdep.c (rs6000_frame_cache)
5093         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5094         * remote.c: Replace throw_exception with throw.
5095         * record-full.c (record_full_message, record_full_wait_1)
5096         (record_full_restore): Replace throw_exception with throw.
5097         * record-btrace.c:
5098         (get_thread_current_frame_id, record_btrace_start_replaying)
5099         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5100         (cmd_record_btrace_start): Replace throw_exception with throw.
5101         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5102         throw.
5103         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5104         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5105         * linespec.c:
5106         (find_linespec_symbols): Replace throw_exception with throw.
5107         * infrun.c (displaced_step_prepare, resume): Replace
5108         throw_exception with throw.
5109         * infcmd.c (post_create_inferior): Replace throw_exception with
5110         throw.
5111         * inf-loop.c (inferior_event_handler): Replace throw_exception
5112         with throw.
5113         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5114         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5115         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5116         (get_prev_frame_always, get_frame_pc_if_available)
5117         (get_frame_address_in_block_if_available, get_frame_language):
5118         Replace throw_exception with throw.
5119         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5120         throw_exception with throw.
5121         * eval.c (fetch_subexp_value, evaluate_var_value)
5122         (evaluate_funcall, evaluate_subexp_standard): Replace
5123         throw_exception with throw.
5124         * dwarf2loc.c (call_site_find_chain)
5125         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5126         Replace throw_exception with throw.
5127         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5128         with throw.
5129         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5130         throw.
5131         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5132         * completer.c (complete_line_internal): Replace throw_exception
5133         with throw.
5134         * compile/compile-object-run.c (compile_object_run): Replace
5135         throw_exception with throw.
5136         * cli/cli-script.c (process_next_line): Replace throw_exception
5137         with throw.
5138         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5139         (btrace_enable, btrace_maint_update_pt_packets): Replace
5140         throw_exception with throw.
5141         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5142         throw_exception with throw.
5143         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5144         throw_exception with throw.
5145         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5146         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5147         * aarch64-tdep.c (aarch64_make_prologue_cache)
5148         (aarch64_make_stub_cache): Replace throw_exception with throw.
5149
5150 2019-04-08  Tom Tromey  <tom@tromey.com>
5151
5152         * common/common-exceptions.c (throw_exception): Rename from
5153         throw_exception_cxx.  Remove old copy.  Make argument const.
5154         (throw_it): Create and throw exception objects directly.
5155         * common/common-exceptions.h (throw_exception): Make argument
5156         const.
5157         (struct gdb_exception_error): Add constructor.
5158         (struct gdb_exception_quit): Add constructor.
5159
5160 2019-04-08  Tom Tromey  <tom@tromey.com>
5161
5162         * common/common-exceptions.h (exception_rethrow): Don't declare.
5163         (TRY_SJLJ): Update comment.
5164         (TRY, CATCH, END_CATCH): Remove.
5165         * common/common-exceptions.c (exception_rethrow): Remove.
5166
5167 2019-04-08  Tom Tromey  <tom@tromey.com>
5168
5169         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5170         Remove.
5171         (gdb_exception_error): Rename from
5172         gdb_exception_RETURN_MASK_ERROR.
5173         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5174         (gdb_quit_bad_alloc): Update.
5175         * aarch64-tdep.c: Update.
5176         * ada-lang.c: Update.
5177         * ada-typeprint.c: Update.
5178         * ada-valprint.c: Update.
5179         * amd64-tdep.c: Update.
5180         * arch-utils.c: Update.
5181         * break-catch-throw.c: Update.
5182         * breakpoint.c: Update.
5183         * btrace.c: Update.
5184         * c-varobj.c: Update.
5185         * cli/cli-cmds.c: Update.
5186         * cli/cli-interp.c: Update.
5187         * cli/cli-script.c: Update.
5188         * common/common-exceptions.c: Update.
5189         * common/new-op.c: Update.
5190         * common/selftest.c: Update.
5191         * compile/compile-c-symbols.c: Update.
5192         * compile/compile-cplus-symbols.c: Update.
5193         * compile/compile-object-load.c: Update.
5194         * compile/compile-object-run.c: Update.
5195         * completer.c: Update.
5196         * corelow.c: Update.
5197         * cp-abi.c: Update.
5198         * cp-support.c: Update.
5199         * cp-valprint.c: Update.
5200         * darwin-nat.c: Update.
5201         * disasm-selftests.c: Update.
5202         * dtrace-probe.c: Update.
5203         * dwarf-index-cache.c: Update.
5204         * dwarf-index-write.c: Update.
5205         * dwarf2-frame-tailcall.c: Update.
5206         * dwarf2-frame.c: Update.
5207         * dwarf2loc.c: Update.
5208         * dwarf2read.c: Update.
5209         * eval.c: Update.
5210         * event-loop.c: Update.
5211         * event-top.c: Update.
5212         * exec.c: Update.
5213         * f-valprint.c: Update.
5214         * fbsd-tdep.c: Update.
5215         * frame-unwind.c: Update.
5216         * frame.c: Update.
5217         * gdbtypes.c: Update.
5218         * gnu-v3-abi.c: Update.
5219         * guile/guile-internal.h: Update.
5220         * guile/scm-block.c: Update.
5221         * guile/scm-breakpoint.c: Update.
5222         * guile/scm-cmd.c: Update.
5223         * guile/scm-disasm.c: Update.
5224         * guile/scm-frame.c: Update.
5225         * guile/scm-lazy-string.c: Update.
5226         * guile/scm-math.c: Update.
5227         * guile/scm-param.c: Update.
5228         * guile/scm-ports.c: Update.
5229         * guile/scm-pretty-print.c: Update.
5230         * guile/scm-symbol.c: Update.
5231         * guile/scm-symtab.c: Update.
5232         * guile/scm-type.c: Update.
5233         * guile/scm-value.c: Update.
5234         * i386-linux-tdep.c: Update.
5235         * i386-tdep.c: Update.
5236         * inf-loop.c: Update.
5237         * infcall.c: Update.
5238         * infcmd.c: Update.
5239         * infrun.c: Update.
5240         * jit.c: Update.
5241         * language.c: Update.
5242         * linespec.c: Update.
5243         * linux-fork.c: Update.
5244         * linux-nat.c: Update.
5245         * linux-tdep.c: Update.
5246         * linux-thread-db.c: Update.
5247         * main.c: Update.
5248         * mi/mi-cmd-break.c: Update.
5249         * mi/mi-cmd-stack.c: Update.
5250         * mi/mi-interp.c: Update.
5251         * mi/mi-main.c: Update.
5252         * objc-lang.c: Update.
5253         * p-valprint.c: Update.
5254         * parse.c: Update.
5255         * ppc-linux-tdep.c: Update.
5256         * printcmd.c: Update.
5257         * python/py-arch.c: Update.
5258         * python/py-breakpoint.c: Update.
5259         * python/py-cmd.c: Update.
5260         * python/py-finishbreakpoint.c: Update.
5261         * python/py-frame.c: Update.
5262         * python/py-framefilter.c: Update.
5263         * python/py-gdb-readline.c: Update.
5264         * python/py-inferior.c: Update.
5265         * python/py-infthread.c: Update.
5266         * python/py-lazy-string.c: Update.
5267         * python/py-linetable.c: Update.
5268         * python/py-objfile.c: Update.
5269         * python/py-param.c: Update.
5270         * python/py-prettyprint.c: Update.
5271         * python/py-progspace.c: Update.
5272         * python/py-record-btrace.c: Update.
5273         * python/py-record.c: Update.
5274         * python/py-symbol.c: Update.
5275         * python/py-type.c: Update.
5276         * python/py-unwind.c: Update.
5277         * python/py-utils.c: Update.
5278         * python/py-value.c: Update.
5279         * python/python.c: Update.
5280         * record-btrace.c: Update.
5281         * record-full.c: Update.
5282         * remote-fileio.c: Update.
5283         * remote.c: Update.
5284         * riscv-tdep.c: Update.
5285         * rs6000-aix-tdep.c: Update.
5286         * rs6000-tdep.c: Update.
5287         * rust-exp.y: Update.
5288         * rust-lang.c: Update.
5289         * s390-tdep.c: Update.
5290         * selftest-arch.c: Update.
5291         * solib-dsbt.c: Update.
5292         * solib-frv.c: Update.
5293         * solib-spu.c: Update.
5294         * solib-svr4.c: Update.
5295         * solib.c: Update.
5296         * sparc64-linux-tdep.c: Update.
5297         * stack.c: Update.
5298         * symfile-mem.c: Update.
5299         * symmisc.c: Update.
5300         * target.c: Update.
5301         * thread.c: Update.
5302         * top.c: Update.
5303         * tracefile-tfile.c: Update.
5304         * tui/tui.c: Update.
5305         * typeprint.c: Update.
5306         * unittests/cli-utils-selftests.c: Update.
5307         * unittests/parse-connection-spec-selftests.c: Update.
5308         * valops.c: Update.
5309         * valprint.c: Update.
5310         * value.c: Update.
5311         * varobj.c: Update.
5312         * windows-nat.c: Update.
5313         * x86-linux-nat.c: Update.
5314         * xml-support.c: Update.
5315
5316 2019-04-08  Tom Tromey  <tom@tromey.com>
5317
5318         * xml-support.c: Use C++ exception handling.
5319         * x86-linux-nat.c: Use C++ exception handling.
5320         * windows-nat.c: Use C++ exception handling.
5321         * varobj.c: Use C++ exception handling.
5322         * value.c: Use C++ exception handling.
5323         * valprint.c: Use C++ exception handling.
5324         * valops.c: Use C++ exception handling.
5325         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5326         handling.
5327         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5328         * typeprint.c: Use C++ exception handling.
5329         * tui/tui.c: Use C++ exception handling.
5330         * tracefile-tfile.c: Use C++ exception handling.
5331         * top.c: Use C++ exception handling.
5332         * thread.c: Use C++ exception handling.
5333         * target.c: Use C++ exception handling.
5334         * symmisc.c: Use C++ exception handling.
5335         * symfile-mem.c: Use C++ exception handling.
5336         * stack.c: Use C++ exception handling.
5337         * sparc64-linux-tdep.c: Use C++ exception handling.
5338         * solib.c: Use C++ exception handling.
5339         * solib-svr4.c: Use C++ exception handling.
5340         * solib-spu.c: Use C++ exception handling.
5341         * solib-frv.c: Use C++ exception handling.
5342         * solib-dsbt.c: Use C++ exception handling.
5343         * selftest-arch.c: Use C++ exception handling.
5344         * s390-tdep.c: Use C++ exception handling.
5345         * rust-lang.c: Use C++ exception handling.
5346         * rust-exp.y: Use C++ exception handling.
5347         * rs6000-tdep.c: Use C++ exception handling.
5348         * rs6000-aix-tdep.c: Use C++ exception handling.
5349         * riscv-tdep.c: Use C++ exception handling.
5350         * remote.c: Use C++ exception handling.
5351         * remote-fileio.c: Use C++ exception handling.
5352         * record-full.c: Use C++ exception handling.
5353         * record-btrace.c: Use C++ exception handling.
5354         * python/python.c: Use C++ exception handling.
5355         * python/py-value.c: Use C++ exception handling.
5356         * python/py-utils.c: Use C++ exception handling.
5357         * python/py-unwind.c: Use C++ exception handling.
5358         * python/py-type.c: Use C++ exception handling.
5359         * python/py-symbol.c: Use C++ exception handling.
5360         * python/py-record.c: Use C++ exception handling.
5361         * python/py-record-btrace.c: Use C++ exception handling.
5362         * python/py-progspace.c: Use C++ exception handling.
5363         * python/py-prettyprint.c: Use C++ exception handling.
5364         * python/py-param.c: Use C++ exception handling.
5365         * python/py-objfile.c: Use C++ exception handling.
5366         * python/py-linetable.c: Use C++ exception handling.
5367         * python/py-lazy-string.c: Use C++ exception handling.
5368         * python/py-infthread.c: Use C++ exception handling.
5369         * python/py-inferior.c: Use C++ exception handling.
5370         * python/py-gdb-readline.c: Use C++ exception handling.
5371         * python/py-framefilter.c: Use C++ exception handling.
5372         * python/py-frame.c: Use C++ exception handling.
5373         * python/py-finishbreakpoint.c: Use C++ exception handling.
5374         * python/py-cmd.c: Use C++ exception handling.
5375         * python/py-breakpoint.c: Use C++ exception handling.
5376         * python/py-arch.c: Use C++ exception handling.
5377         * printcmd.c: Use C++ exception handling.
5378         * ppc-linux-tdep.c: Use C++ exception handling.
5379         * parse.c: Use C++ exception handling.
5380         * p-valprint.c: Use C++ exception handling.
5381         * objc-lang.c: Use C++ exception handling.
5382         * mi/mi-main.c: Use C++ exception handling.
5383         * mi/mi-interp.c: Use C++ exception handling.
5384         * mi/mi-cmd-stack.c: Use C++ exception handling.
5385         * mi/mi-cmd-break.c: Use C++ exception handling.
5386         * main.c: Use C++ exception handling.
5387         * linux-thread-db.c: Use C++ exception handling.
5388         * linux-tdep.c: Use C++ exception handling.
5389         * linux-nat.c: Use C++ exception handling.
5390         * linux-fork.c: Use C++ exception handling.
5391         * linespec.c: Use C++ exception handling.
5392         * language.c: Use C++ exception handling.
5393         * jit.c: Use C++ exception handling.
5394         * infrun.c: Use C++ exception handling.
5395         * infcmd.c: Use C++ exception handling.
5396         * infcall.c: Use C++ exception handling.
5397         * inf-loop.c: Use C++ exception handling.
5398         * i386-tdep.c: Use C++ exception handling.
5399         * i386-linux-tdep.c: Use C++ exception handling.
5400         * guile/scm-value.c: Use C++ exception handling.
5401         * guile/scm-type.c: Use C++ exception handling.
5402         * guile/scm-symtab.c: Use C++ exception handling.
5403         * guile/scm-symbol.c: Use C++ exception handling.
5404         * guile/scm-pretty-print.c: Use C++ exception handling.
5405         * guile/scm-ports.c: Use C++ exception handling.
5406         * guile/scm-param.c: Use C++ exception handling.
5407         * guile/scm-math.c: Use C++ exception handling.
5408         * guile/scm-lazy-string.c: Use C++ exception handling.
5409         * guile/scm-frame.c: Use C++ exception handling.
5410         * guile/scm-disasm.c: Use C++ exception handling.
5411         * guile/scm-cmd.c: Use C++ exception handling.
5412         * guile/scm-breakpoint.c: Use C++ exception handling.
5413         * guile/scm-block.c: Use C++ exception handling.
5414         * guile/guile-internal.h: Use C++ exception handling.
5415         * gnu-v3-abi.c: Use C++ exception handling.
5416         * gdbtypes.c: Use C++ exception handling.
5417         * frame.c: Use C++ exception handling.
5418         * frame-unwind.c: Use C++ exception handling.
5419         * fbsd-tdep.c: Use C++ exception handling.
5420         * f-valprint.c: Use C++ exception handling.
5421         * exec.c: Use C++ exception handling.
5422         * event-top.c: Use C++ exception handling.
5423         * event-loop.c: Use C++ exception handling.
5424         * eval.c: Use C++ exception handling.
5425         * dwarf2read.c: Use C++ exception handling.
5426         * dwarf2loc.c: Use C++ exception handling.
5427         * dwarf2-frame.c: Use C++ exception handling.
5428         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5429         * dwarf-index-write.c: Use C++ exception handling.
5430         * dwarf-index-cache.c: Use C++ exception handling.
5431         * dtrace-probe.c: Use C++ exception handling.
5432         * disasm-selftests.c: Use C++ exception handling.
5433         * darwin-nat.c: Use C++ exception handling.
5434         * cp-valprint.c: Use C++ exception handling.
5435         * cp-support.c: Use C++ exception handling.
5436         * cp-abi.c: Use C++ exception handling.
5437         * corelow.c: Use C++ exception handling.
5438         * completer.c: Use C++ exception handling.
5439         * compile/compile-object-run.c: Use C++ exception handling.
5440         * compile/compile-object-load.c: Use C++ exception handling.
5441         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5442         * compile/compile-c-symbols.c: Use C++ exception handling.
5443         * common/selftest.c: Use C++ exception handling.
5444         * common/new-op.c: Use C++ exception handling.
5445         * cli/cli-script.c: Use C++ exception handling.
5446         * cli/cli-interp.c: Use C++ exception handling.
5447         * cli/cli-cmds.c: Use C++ exception handling.
5448         * c-varobj.c: Use C++ exception handling.
5449         * btrace.c: Use C++ exception handling.
5450         * breakpoint.c: Use C++ exception handling.
5451         * break-catch-throw.c: Use C++ exception handling.
5452         * arch-utils.c: Use C++ exception handling.
5453         * amd64-tdep.c: Use C++ exception handling.
5454         * ada-valprint.c: Use C++ exception handling.
5455         * ada-typeprint.c: Use C++ exception handling.
5456         * ada-lang.c: Use C++ exception handling.
5457         * aarch64-tdep.c: Use C++ exception handling.
5458
5459 2019-04-08  Tom Tromey  <tom@tromey.com>
5460
5461         * xml-support.c (gdb_xml_parser::parse): Update.
5462         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5463         * value.c (show_convenience): Update.
5464         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5465         (test_parse_flags_qcs): Update.
5466         * thread.c (thr_try_catch_cmd): Update.
5467         * target.c (target_translate_tls_address): Update.
5468         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5469         (info_frame_command_core, frame_apply_command_count): Update.
5470         * rust-exp.y (rust_lex_exception_test): Update.
5471         * riscv-tdep.c (riscv_print_one_register_info): Update.
5472         * remote.c (remote_target::enable_btrace): Update.
5473         * record-btrace.c (record_btrace_enable_warn): Update.
5474         * python/py-utils.c (gdbpy_convert_exception): Update.
5475         * printcmd.c (do_one_display, print_variable_and_value): Update.
5476         * mi/mi-main.c (mi_print_exception): Update.
5477         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5478         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5479         * linux-nat.c (linux_nat_target::attach): Update.
5480         * linux-fork.c (class scoped_switch_fork_info): Update.
5481         * infrun.c (displaced_step_prepare): Update.
5482         * infcall.c (call_function_by_hand_dummy): Update.
5483         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5484         * gnu-v3-abi.c (print_one_vtable): Update.
5485         * frame.c (get_prev_frame_always): Update.
5486         * f-valprint.c (info_common_command_for_block): Update.
5487         * exec.c (try_open_exec_file): Update.
5488         * exceptions.c (print_exception, exception_print)
5489         (exception_fprintf, exception_print_same): Update.
5490         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5491         * dwarf-index-cache.c (index_cache::store)
5492         (index_cache::lookup_gdb_index): Update.
5493         * darwin-nat.c (maybe_cache_shell): Update.
5494         * cp-valprint.c (cp_print_value_fields): Update.
5495         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5496         (gcc_cplus_symbol_address): Update.
5497         * compile/compile-c-symbols.c (gcc_convert_symbol)
5498         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5499         * common/selftest.c: Update.
5500         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5501         a std::string.
5502         (exception_try_scope_entry, exception_try_scope_exit): Don't
5503         declare.
5504         (struct exception_try_scope): Remove.
5505         (TRY): Don't use exception_try_scope.
5506         (struct gdb_exception): Add constructor, operator=.
5507         <what>: New method.
5508         (struct gdb_exception_RETURN_MASK_ALL)
5509         (struct gdb_exception_RETURN_MASK_ERROR)
5510         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5511         (struct gdb_quit_bad_alloc): Update.
5512         * common/common-exceptions.c (exception_none): Change
5513         initializer.
5514         (struct catcher) <state, exception>: Initialize inline.
5515         <prev>: Remove member.
5516         (current_catcher): Remove.
5517         (catchers): New global.
5518         (exceptions_state_mc_init): Simplify.
5519         (catcher_pop): Remove.
5520         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5521         (try_scope_depth, exception_try_scope_entry)
5522         (exception_try_scope_exit): Remove.
5523         (throw_exception_sjlj): Update.
5524         (exception_messages, exception_messages_size): Remove.
5525         (throw_it): Simplify.
5526         (gdb_exception_sliced_copy): Remove.
5527         (throw_exception_cxx): Update.
5528         * cli/cli-script.c (script_from_file): Update.
5529         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5530         Update.
5531         * ada-valprint.c (ada_val_print): Update.
5532         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5533         (create_excep_cond_exprs): Update.
5534
5535 2019-04-08  Tom Tromey  <tom@tromey.com>
5536
5537         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5538         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5539         (TRY, CATCH, END_CATCH): Remove some definitions.
5540         * common/common-exceptions.c: Don't use GDB_XCPT.
5541         (catcher_list_size): Remove.
5542         (throw_exception, throw_it): Simplify.
5543
5544 2019-04-05  Tom Tromey  <tom@tromey.com>
5545
5546         Revert the header-sorting patch.
5547         * ft32-tdep.c: Revert.
5548         * frv-tdep.c: Revert.
5549         * frv-linux-tdep.c: Revert.
5550         * frame.c: Revert.
5551         * frame-unwind.c: Revert.
5552         * frame-base.c: Revert.
5553         * fork-child.c: Revert.
5554         * findvar.c: Revert.
5555         * findcmd.c: Revert.
5556         * filesystem.c: Revert.
5557         * filename-seen-cache.h: Revert.
5558         * filename-seen-cache.c: Revert.
5559         * fbsd-tdep.c: Revert.
5560         * fbsd-nat.h: Revert.
5561         * fbsd-nat.c: Revert.
5562         * f-valprint.c: Revert.
5563         * f-typeprint.c: Revert.
5564         * f-lang.c: Revert.
5565         * extension.h: Revert.
5566         * extension.c: Revert.
5567         * extension-priv.h: Revert.
5568         * expprint.c: Revert.
5569         * exec.h: Revert.
5570         * exec.c: Revert.
5571         * exceptions.c: Revert.
5572         * event-top.c: Revert.
5573         * event-loop.c: Revert.
5574         * eval.c: Revert.
5575         * elfread.c: Revert.
5576         * dwarf2read.h: Revert.
5577         * dwarf2read.c: Revert.
5578         * dwarf2loc.c: Revert.
5579         * dwarf2expr.h: Revert.
5580         * dwarf2expr.c: Revert.
5581         * dwarf2-frame.c: Revert.
5582         * dwarf2-frame-tailcall.c: Revert.
5583         * dwarf-index-write.h: Revert.
5584         * dwarf-index-write.c: Revert.
5585         * dwarf-index-common.c: Revert.
5586         * dwarf-index-cache.h: Revert.
5587         * dwarf-index-cache.c: Revert.
5588         * dummy-frame.c: Revert.
5589         * dtrace-probe.c: Revert.
5590         * disasm.h: Revert.
5591         * disasm.c: Revert.
5592         * disasm-selftests.c: Revert.
5593         * dictionary.c: Revert.
5594         * dicos-tdep.c: Revert.
5595         * demangle.c: Revert.
5596         * dcache.h: Revert.
5597         * dcache.c: Revert.
5598         * darwin-nat.h: Revert.
5599         * darwin-nat.c: Revert.
5600         * darwin-nat-info.c: Revert.
5601         * d-valprint.c: Revert.
5602         * d-namespace.c: Revert.
5603         * d-lang.c: Revert.
5604         * ctf.c: Revert.
5605         * csky-tdep.c: Revert.
5606         * csky-linux-tdep.c: Revert.
5607         * cris-tdep.c: Revert.
5608         * cris-linux-tdep.c: Revert.
5609         * cp-valprint.c: Revert.
5610         * cp-support.c: Revert.
5611         * cp-namespace.c: Revert.
5612         * cp-abi.c: Revert.
5613         * corelow.c: Revert.
5614         * corefile.c: Revert.
5615         * continuations.c: Revert.
5616         * completer.h: Revert.
5617         * completer.c: Revert.
5618         * complaints.c: Revert.
5619         * coffread.c: Revert.
5620         * coff-pe-read.c: Revert.
5621         * cli-out.h: Revert.
5622         * cli-out.c: Revert.
5623         * charset.c: Revert.
5624         * c-varobj.c: Revert.
5625         * c-valprint.c: Revert.
5626         * c-typeprint.c: Revert.
5627         * c-lang.c: Revert.
5628         * buildsym.c: Revert.
5629         * buildsym-legacy.c: Revert.
5630         * build-id.h: Revert.
5631         * build-id.c: Revert.
5632         * btrace.c: Revert.
5633         * bsd-uthread.c: Revert.
5634         * breakpoint.h: Revert.
5635         * breakpoint.c: Revert.
5636         * break-catch-throw.c: Revert.
5637         * break-catch-syscall.c: Revert.
5638         * break-catch-sig.c: Revert.
5639         * blockframe.c: Revert.
5640         * block.c: Revert.
5641         * bfin-tdep.c: Revert.
5642         * bfin-linux-tdep.c: Revert.
5643         * bfd-target.c: Revert.
5644         * bcache.c: Revert.
5645         * ax-general.c: Revert.
5646         * ax-gdb.h: Revert.
5647         * ax-gdb.c: Revert.
5648         * avr-tdep.c: Revert.
5649         * auxv.c: Revert.
5650         * auto-load.c: Revert.
5651         * arm-wince-tdep.c: Revert.
5652         * arm-tdep.c: Revert.
5653         * arm-symbian-tdep.c: Revert.
5654         * arm-pikeos-tdep.c: Revert.
5655         * arm-obsd-tdep.c: Revert.
5656         * arm-nbsd-tdep.c: Revert.
5657         * arm-nbsd-nat.c: Revert.
5658         * arm-linux-tdep.c: Revert.
5659         * arm-linux-nat.c: Revert.
5660         * arm-fbsd-tdep.c: Revert.
5661         * arm-fbsd-nat.c: Revert.
5662         * arm-bsd-tdep.c: Revert.
5663         * arch-utils.c: Revert.
5664         * arc-tdep.c: Revert.
5665         * arc-newlib-tdep.c: Revert.
5666         * annotate.h: Revert.
5667         * annotate.c: Revert.
5668         * amd64-windows-tdep.c: Revert.
5669         * amd64-windows-nat.c: Revert.
5670         * amd64-tdep.c: Revert.
5671         * amd64-sol2-tdep.c: Revert.
5672         * amd64-obsd-tdep.c: Revert.
5673         * amd64-obsd-nat.c: Revert.
5674         * amd64-nbsd-tdep.c: Revert.
5675         * amd64-nbsd-nat.c: Revert.
5676         * amd64-nat.c: Revert.
5677         * amd64-linux-tdep.c: Revert.
5678         * amd64-linux-nat.c: Revert.
5679         * amd64-fbsd-tdep.c: Revert.
5680         * amd64-fbsd-nat.c: Revert.
5681         * amd64-dicos-tdep.c: Revert.
5682         * amd64-darwin-tdep.c: Revert.
5683         * amd64-bsd-nat.c: Revert.
5684         * alpha-tdep.c: Revert.
5685         * alpha-obsd-tdep.c: Revert.
5686         * alpha-nbsd-tdep.c: Revert.
5687         * alpha-mdebug-tdep.c: Revert.
5688         * alpha-linux-tdep.c: Revert.
5689         * alpha-linux-nat.c: Revert.
5690         * alpha-bsd-tdep.c: Revert.
5691         * alpha-bsd-nat.c: Revert.
5692         * aix-thread.c: Revert.
5693         * agent.c: Revert.
5694         * addrmap.c: Revert.
5695         * ada-varobj.c: Revert.
5696         * ada-valprint.c: Revert.
5697         * ada-typeprint.c: Revert.
5698         * ada-tasks.c: Revert.
5699         * ada-lang.c: Revert.
5700         * aarch64-tdep.c: Revert.
5701         * aarch64-ravenscar-thread.c: Revert.
5702         * aarch64-newlib-tdep.c: Revert.
5703         * aarch64-linux-tdep.c: Revert.
5704         * aarch64-linux-nat.c: Revert.
5705         * aarch64-fbsd-tdep.c: Revert.
5706         * aarch64-fbsd-nat.c: Revert.
5707         * aarch32-linux-nat.c: Revert.
5708
5709 2019-04-05  Tom Tromey  <tom@tromey.com>
5710
5711         * ft32-tdep.c: Sort headers.
5712         * frv-tdep.c: Sort headers.
5713         * frv-linux-tdep.c: Sort headers.
5714         * frame.c: Sort headers.
5715         * frame-unwind.c: Sort headers.
5716         * frame-base.c: Sort headers.
5717         * fork-child.c: Sort headers.
5718         * findvar.c: Sort headers.
5719         * findcmd.c: Sort headers.
5720         * filesystem.c: Sort headers.
5721         * filename-seen-cache.h: Sort headers.
5722         * filename-seen-cache.c: Sort headers.
5723         * fbsd-tdep.c: Sort headers.
5724         * fbsd-nat.h: Sort headers.
5725         * fbsd-nat.c: Sort headers.
5726         * f-valprint.c: Sort headers.
5727         * f-typeprint.c: Sort headers.
5728         * f-lang.c: Sort headers.
5729         * extension.h: Sort headers.
5730         * extension.c: Sort headers.
5731         * extension-priv.h: Sort headers.
5732         * expprint.c: Sort headers.
5733         * exec.h: Sort headers.
5734         * exec.c: Sort headers.
5735         * exceptions.c: Sort headers.
5736         * event-top.c: Sort headers.
5737         * event-loop.c: Sort headers.
5738         * eval.c: Sort headers.
5739         * elfread.c: Sort headers.
5740         * dwarf2read.h: Sort headers.
5741         * dwarf2read.c: Sort headers.
5742         * dwarf2loc.c: Sort headers.
5743         * dwarf2expr.h: Sort headers.
5744         * dwarf2expr.c: Sort headers.
5745         * dwarf2-frame.c: Sort headers.
5746         * dwarf2-frame-tailcall.c: Sort headers.
5747         * dwarf-index-write.h: Sort headers.
5748         * dwarf-index-write.c: Sort headers.
5749         * dwarf-index-common.c: Sort headers.
5750         * dwarf-index-cache.h: Sort headers.
5751         * dwarf-index-cache.c: Sort headers.
5752         * dummy-frame.c: Sort headers.
5753         * dtrace-probe.c: Sort headers.
5754         * disasm.h: Sort headers.
5755         * disasm.c: Sort headers.
5756         * disasm-selftests.c: Sort headers.
5757         * dictionary.c: Sort headers.
5758         * dicos-tdep.c: Sort headers.
5759         * demangle.c: Sort headers.
5760         * dcache.h: Sort headers.
5761         * dcache.c: Sort headers.
5762         * darwin-nat.h: Sort headers.
5763         * darwin-nat.c: Sort headers.
5764         * darwin-nat-info.c: Sort headers.
5765         * d-valprint.c: Sort headers.
5766         * d-namespace.c: Sort headers.
5767         * d-lang.c: Sort headers.
5768         * ctf.c: Sort headers.
5769         * csky-tdep.c: Sort headers.
5770         * csky-linux-tdep.c: Sort headers.
5771         * cris-tdep.c: Sort headers.
5772         * cris-linux-tdep.c: Sort headers.
5773         * cp-valprint.c: Sort headers.
5774         * cp-support.c: Sort headers.
5775         * cp-namespace.c: Sort headers.
5776         * cp-abi.c: Sort headers.
5777         * corelow.c: Sort headers.
5778         * corefile.c: Sort headers.
5779         * continuations.c: Sort headers.
5780         * completer.h: Sort headers.
5781         * completer.c: Sort headers.
5782         * complaints.c: Sort headers.
5783         * coffread.c: Sort headers.
5784         * coff-pe-read.c: Sort headers.
5785         * cli-out.h: Sort headers.
5786         * cli-out.c: Sort headers.
5787         * charset.c: Sort headers.
5788         * c-varobj.c: Sort headers.
5789         * c-valprint.c: Sort headers.
5790         * c-typeprint.c: Sort headers.
5791         * c-lang.c: Sort headers.
5792         * buildsym.c: Sort headers.
5793         * buildsym-legacy.c: Sort headers.
5794         * build-id.h: Sort headers.
5795         * build-id.c: Sort headers.
5796         * btrace.c: Sort headers.
5797         * bsd-uthread.c: Sort headers.
5798         * breakpoint.h: Sort headers.
5799         * breakpoint.c: Sort headers.
5800         * break-catch-throw.c: Sort headers.
5801         * break-catch-syscall.c: Sort headers.
5802         * break-catch-sig.c: Sort headers.
5803         * blockframe.c: Sort headers.
5804         * block.c: Sort headers.
5805         * bfin-tdep.c: Sort headers.
5806         * bfin-linux-tdep.c: Sort headers.
5807         * bfd-target.c: Sort headers.
5808         * bcache.c: Sort headers.
5809         * ax-general.c: Sort headers.
5810         * ax-gdb.h: Sort headers.
5811         * ax-gdb.c: Sort headers.
5812         * avr-tdep.c: Sort headers.
5813         * auxv.c: Sort headers.
5814         * auto-load.c: Sort headers.
5815         * arm-wince-tdep.c: Sort headers.
5816         * arm-tdep.c: Sort headers.
5817         * arm-symbian-tdep.c: Sort headers.
5818         * arm-pikeos-tdep.c: Sort headers.
5819         * arm-obsd-tdep.c: Sort headers.
5820         * arm-nbsd-tdep.c: Sort headers.
5821         * arm-nbsd-nat.c: Sort headers.
5822         * arm-linux-tdep.c: Sort headers.
5823         * arm-linux-nat.c: Sort headers.
5824         * arm-fbsd-tdep.c: Sort headers.
5825         * arm-fbsd-nat.c: Sort headers.
5826         * arm-bsd-tdep.c: Sort headers.
5827         * arch-utils.c: Sort headers.
5828         * arc-tdep.c: Sort headers.
5829         * arc-newlib-tdep.c: Sort headers.
5830         * annotate.h: Sort headers.
5831         * annotate.c: Sort headers.
5832         * amd64-windows-tdep.c: Sort headers.
5833         * amd64-windows-nat.c: Sort headers.
5834         * amd64-tdep.c: Sort headers.
5835         * amd64-sol2-tdep.c: Sort headers.
5836         * amd64-obsd-tdep.c: Sort headers.
5837         * amd64-obsd-nat.c: Sort headers.
5838         * amd64-nbsd-tdep.c: Sort headers.
5839         * amd64-nbsd-nat.c: Sort headers.
5840         * amd64-nat.c: Sort headers.
5841         * amd64-linux-tdep.c: Sort headers.
5842         * amd64-linux-nat.c: Sort headers.
5843         * amd64-fbsd-tdep.c: Sort headers.
5844         * amd64-fbsd-nat.c: Sort headers.
5845         * amd64-dicos-tdep.c: Sort headers.
5846         * amd64-darwin-tdep.c: Sort headers.
5847         * amd64-bsd-nat.c: Sort headers.
5848         * alpha-tdep.c: Sort headers.
5849         * alpha-obsd-tdep.c: Sort headers.
5850         * alpha-nbsd-tdep.c: Sort headers.
5851         * alpha-mdebug-tdep.c: Sort headers.
5852         * alpha-linux-tdep.c: Sort headers.
5853         * alpha-linux-nat.c: Sort headers.
5854         * alpha-bsd-tdep.c: Sort headers.
5855         * alpha-bsd-nat.c: Sort headers.
5856         * aix-thread.c: Sort headers.
5857         * agent.c: Sort headers.
5858         * addrmap.c: Sort headers.
5859         * ada-varobj.c: Sort headers.
5860         * ada-valprint.c: Sort headers.
5861         * ada-typeprint.c: Sort headers.
5862         * ada-tasks.c: Sort headers.
5863         * ada-lang.c: Sort headers.
5864         * aarch64-tdep.c: Sort headers.
5865         * aarch64-ravenscar-thread.c: Sort headers.
5866         * aarch64-newlib-tdep.c: Sort headers.
5867         * aarch64-linux-tdep.c: Sort headers.
5868         * aarch64-linux-nat.c: Sort headers.
5869         * aarch64-fbsd-tdep.c: Sort headers.
5870         * aarch64-fbsd-nat.c: Sort headers.
5871         * aarch32-linux-nat.c: Sort headers.
5872
5873 2019-04-04  Tom Tromey  <tom@tromey.com>
5874
5875         * varobj.c (varobj_create): Update.
5876         * rust-exp.y (struct rust_parser) <update_innermost_block,
5877         lookup_symbol>: New methods.
5878         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5879         Rename.
5880         (rust_parser::rust_lookup_type)
5881         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5882         * printcmd.c (display_command, do_one_display): Update.
5883         * parser-defs.h (struct parser_state) <parser_state>: Add
5884         "tracker" parameter.
5885         (block_tracker): New member.
5886         (class innermost_block_tracker) <innermost_block_tracker>: Add
5887         "types" parameter.
5888         <reset>: Remove method.
5889         (innermost_block): Don't declare.
5890         (null_post_parser): Update.
5891         * parse.c (innermost_block): Remove global.
5892         (write_dollar_variable): Update.
5893         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5894         Remove "tracker_types" parameter.
5895         (parse_expression): Add "tracker" parameter.
5896         (parse_expression_for_completion): Update.
5897         (null_post_parser): Add "tracker" parameter.
5898         * p-exp.y: Update rules.
5899         * m2-exp.y: Update rules.
5900         * language.h (struct language_defn) <la_post_parser>: Add
5901         "tracker" parameter.
5902         * go-exp.y: Update rules.
5903         * f-exp.y: Update rules.
5904         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5905         parameter.
5906         * d-exp.y: Update rules.
5907         * c-exp.y: Update rules.
5908         * breakpoint.c (set_breakpoint_condition): Create an
5909         innermost_block_tracker.
5910         (watch_command_1): Likewise.
5911         * ada-lang.c (resolve): Add "tracker" parameter.
5912         (resolve_subexp): Likewise.
5913         * ada-exp.y (write_var_from_sym): Update.
5914
5915 2019-04-04  Tom Tromey  <tom@tromey.com>
5916
5917         * type-stack.h: New file.
5918         * type-stack.c: New file.
5919         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5920         type-stack.h.
5921         (insert_into_type_stack, insert_type, push_type, push_type_int)
5922         (insert_type_address_space, pop_type, pop_type_int)
5923         (pop_typelist, pop_type_stack, append_type_stack)
5924         (push_type_stack, get_type_stack, push_typelist)
5925         (follow_type_instance_flags, follow_types): Don't declare.
5926         * parse.c (type_stack): Remove global.
5927         (parse_exp_in_context): Update.
5928         (insert_into_type_stack, insert_type, push_type, push_type_int)
5929         (insert_type_address_space, pop_type, pop_type_int)
5930         (pop_typelist, pop_type_stack, append_type_stack)
5931         (push_type_stack, get_type_stack, push_typelist)
5932         (follow_type_instance_flags, follow_types): Remove (moved to
5933         type-stack.c).
5934         * f-exp.y (type_stack): New global.
5935         Update rules.
5936         (push_kind_type, f_parse): Update.
5937         * d-exp.y (type_stack): New global.
5938         Update rules.
5939         (d_parse): Update.
5940         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5941         Update rules.
5942         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5943         (HFILES_NO_SRCDIR): Add type-stack.h.
5944
5945 2019-04-04  Tom Tromey  <tom@tromey.com>
5946
5947         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5948         (rust_parser::convert_ast_to_expression, rust_parse)
5949         (rust_lex_test_completion, rust_lex_tests): Update.
5950         * parser-defs.h (struct expr_completion_state): New.
5951         (struct parser_state) <parser_state>: Add completion parameter.
5952         <mark_struct_expression, mark_completion_tag>: New methods.
5953         <parse_completion, m_completion_state>: New members.
5954         (prefixify_expression, null_post_parser): Update.
5955         (mark_struct_expression, mark_completion_tag): Don't declare.
5956         * parse.c (parse_completion, expout_last_struct)
5957         (expout_tag_completion_type, expout_completion_name): Remove
5958         globals.
5959         (parser_state::mark_struct_expression)
5960         (parser_state::mark_completion_tag): Now methods.
5961         (prefixify_expression): Add last_struct parameter.
5962         (prefixify_subexp): Likewise.
5963         (parse_exp_1): Update.
5964         (parse_exp_in_context): Add cstate parameter.  Update.
5965         (parse_expression_for_completion): Create an
5966         expr_completion_state.
5967         (null_post_parser): Add "completion" parameter.
5968         * p-exp.y: Update rules.
5969         (yylex): Update.
5970         * language.h (struct language_defn) <la_post_parser>: Add
5971         "completing" parameter.
5972         * go-exp.y: Update rules.
5973         (lex_one_token): Update.
5974         * expression.h (parse_completion): Don't declare.
5975         * d-exp.y: Update rules.
5976         (lex_one_token): Update rules.
5977         * c-exp.y: Update rules.
5978         (lex_one_token): Update.
5979         * ada-lang.c (resolve): Add "parse_completion" parameter.
5980         (resolve_subexp): Likewise.
5981         (ada_resolve_function): Likewise.
5982
5983 2019-04-04  Tom Tromey  <tom@tromey.com>
5984
5985         * parser-defs.h (struct parser_state) <start_arglist,
5986         end_arglist>: New methods.
5987         <arglist_len, m_funcall_chain>: New members.
5988         (arglist_len, start_arglist, end_arglist): Don't declare.
5989         * parse.c (arglist_len, funcall_chain): Remove global.
5990         (start_arglist, end_arglist): Remove functions.
5991         (parse_exp_in_context): Update.
5992         * p-exp.y: Update rules.
5993         * m2-exp.y: Update rules.
5994         * go-exp.y: Update rules.
5995         * f-exp.y: Update rules.
5996         * d-exp.y: Update rules.
5997         * c-exp.y: Update rules.
5998
5999 2019-04-04  Tom Tromey  <tom@tromey.com>
6000
6001         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6002         lex_operator, push_back>: New methods.
6003         Update all rules.
6004         (rust_parser::lex_hex, lex_escape): Rename and update.
6005         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6006         (rust_parser::lex_operator): Rename and update.
6007         (rust_parser::lex_number, rustyylex, rustyyerror)
6008         (rust_lex_test_init, rust_lex_test_sequence)
6009         (rust_lex_test_push_back, rust_lex_tests): Update.
6010         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6011         parameter.
6012         <lexptr, prev_lexptr>: New members.
6013         (lexptr, prev_lexptr): Don't declare.
6014         * parse.c (lexptr, prev_lexptr): Remove globals.
6015         (parse_exp_in_context): Update.
6016         * p-exp.y (yylex, yyerror): Update.
6017         * m2-exp.y (parse_number, yylex, yyerror): Update.
6018         * go-exp.y (lex_one_token, yyerror): Update.
6019         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6020         * d-exp.y (lex_one_token, yyerror): Update.
6021         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6022         (lex_one_token, yyerror): Update.
6023         * ada-lex.l (YY_INPUT): Update.
6024         (rewind_to_char): Update.
6025         * ada-exp.y (yyerror): Update.
6026
6027 2019-04-04  Tom Tromey  <tom@tromey.com>
6028
6029         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6030         * parser-defs.h (struct parser_state) <parser_state>: Add new
6031         parameter.
6032         <comma_terminates>: New member.
6033         (comma_terminates): Don't declare global.
6034         * parse.c (comma_terminates): Remove global.
6035         (parse_exp_in_context): Update.
6036         * p-exp.y (yylex): Update.
6037         * m2-exp.y (yylex): Update.
6038         * go-exp.y (lex_one_token): Update.
6039         * f-exp.y (yylex): Update.
6040         * d-exp.y (lex_one_token): Update.
6041         * c-exp.y (lex_one_token): Update.
6042         * ada-lex.l: Update.
6043
6044 2019-04-04  Tom Tromey  <tom@tromey.com>
6045
6046         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6047         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6048         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6049         * parser-defs.h (paren_depth): Don't declare.
6050         * parse.c (paren_depth): Remove global.
6051         (parse_exp_in_context): Update.
6052         * p-exp.y (paren_depth): New global.
6053         (pascal_parse): Initialize it.
6054         * m2-exp.y (paren_depth): New global.
6055         (m2_parse): Initialize it.
6056         * go-exp.y (paren_depth): New global.
6057         (go_parse): Initialize it.
6058         * f-exp.y (paren_depth): New global.
6059         (f_parse): Initialize it.
6060         * d-exp.y (paren_depth): New global.
6061         (d_parse): Initialize it.
6062         * c-exp.y (paren_depth): New global.
6063         (c_parse): Initialize it.
6064         * ada-lex.l (paren_depth): New global.
6065         (lexer_init): Initialize it.
6066
6067 2019-04-04  Tom Tromey  <tom@tromey.com>
6068
6069         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6070         (rust_parser::convert_ast_to_type)
6071         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6072         * parser-defs.h (struct parser_state) <parser_state>: Add
6073         parameters.  Initialize new members.
6074         <expression_context_block, expression_context_pc>: New members.
6075         * parse.c (expression_context_block, expression_context_pc):
6076         Remove globals.
6077         (parse_exp_in_context): Update.
6078         * p-exp.y: Update all rules.
6079         (yylex): Update.
6080         * m2-exp.y: Update all rules.
6081         (yylex): Update.
6082         * go-exp.y (yylex): Update.
6083         * f-exp.y (yylex): Update.
6084         * d-exp.y: Update all rules.
6085         (yylex): Update.
6086         * c-exp.y: Update all rules.
6087         (lex_one_token, classify_name, yylex, c_parse): Update.
6088         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6089
6090 2019-04-04  Tom Tromey  <tom@tromey.com>
6091
6092         * gdbarch.h, gdbarch.c: Rebuild.
6093         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6094         * stap-probe.h:
6095         (struct stap_parse_info): Replace "parser_state" with
6096         "expr_builder".
6097         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6098         (parser_state): New class.
6099         * parse.c (expr_builder): Rename.
6100         (expr_builder::release): Rename.
6101         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6102         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6103         (write_exp_elt_longcst, write_exp_elt_floatcst)
6104         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6105         (write_exp_string_vector, write_exp_bitstring)
6106         (write_exp_msymbol, mark_struct_expression)
6107         (write_dollar_variable)
6108         (insert_type_address_space, increase_expout_size): Replace
6109         "parser_state" with "expr_builder".
6110         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6111         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6112         "parser_state" with "expr_builder".
6113
6114 2019-04-04  Tom Tromey  <tom@tromey.com>
6115
6116         * rust-exp.y: Replace "parse_language" with method call.
6117         * p-exp.y:
6118         (yylex): Replace "parse_language" with method call.
6119         * m2-exp.y:
6120         (yylex): Replace "parse_language" with method call.
6121         * go-exp.y (classify_name): Replace "parse_language" with method
6122         call.
6123         * f-exp.y (yylex): Replace "parse_language" with method call.
6124         * d-exp.y (lex_one_token): Replace "parse_language" with method
6125         call.
6126         * c-exp.y:
6127         (lex_one_token, classify_name, yylex): Replace "parse_language"
6128         with method call.
6129         * ada-exp.y (find_primitive_type, type_char)
6130         (type_system_address): Replace "parse_language" with method call.
6131
6132 2019-04-04  Tom Tromey  <tom@tromey.com>
6133
6134         * rust-exp.y: Replace "parse_gdbarch" with method call.
6135         * parse.c (write_dollar_variable, insert_type_address_space):
6136         Replace "parse_gdbarch" with method call.
6137         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6138         call.
6139         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6140         call.
6141         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6142         "parse_gdbarch" with method call.
6143         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6144         with method call.
6145         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6146         "parse_gdbarch" with method call.
6147         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6148         "parse_gdbarch" with method call.
6149         * c-exp.y (parse_type, parse_number, classify_name): Replace
6150         "parse_gdbarch" with method call.
6151         * ada-lex.l: Replace "parse_gdbarch" with method call.
6152         * ada-exp.y (parse_type, find_primitive_type, type_char)
6153         (type_system_address): Replace "parse_gdbarch" with method call.
6154
6155 2019-04-04  Tom Tromey  <tom@tromey.com>
6156
6157         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6158         * stap-probe.c (stap_parse_argument): Update.
6159         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6160         initial_size parameter.
6161         * rust-exp.y (rust_lex_tests): Update.
6162         * parse.c (parser_state): Update.
6163         (parse_exp_in_context): Update.
6164         * parser-defs.h (struct parser_state) <parser_state>: Remove
6165         "initial_size" parameter.
6166
6167 2019-04-04  Tom Tromey  <tom@tromey.com>
6168
6169         * parser-defs.h (increase_expout_size): Don't declare.
6170         * parse.c (increase_expout_size): Now static.
6171
6172 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6173
6174         * gnu-nat.c (gnu_nat_target::wait): Fix
6175         target_waitstatus_to_string call.
6176
6177 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6178
6179         * eval.c (evaluate_subexp_standard): Handle internal functions
6180         during Fortran function call handling.
6181
6182 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6183
6184         * NEWS: Mention new internal functions.
6185         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6186         (read_base_type): Use dwarf2_init_complex_target_type.
6187         * value.c (creal_internal_fn): New function.
6188         (cimag_internal_fn): New function.
6189         (_initialize_values): Register new internal functions.
6190
6191 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6192
6193         * infrun.c (stop_all_threads): If debug_infrun, always
6194         trace the wait status after wait_one, using
6195         target_waitstatus_to_string and target_pid_to_str.
6196         (handle_inferior_event): Replace various trace of
6197         wait status kind by a single trace.
6198         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6199         wait status kind image by target_waitstatus_to_string.
6200         * target/waitstatus.c (target_waitstatus_to_string): Fix
6201         obsolete comment.
6202
6203 2019-04-01  Tom Tromey  <tromey@adacore.com>
6204
6205         PR symtab/23331:
6206         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6207
6208 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6209             Pedro Alves  <palves@redhat.com>
6210
6211         * top.c (quit_force): Call 'finalize_values'.
6212         * value.c (finalize_values): New function.
6213         * value.h (finalize_values): Declare.
6214
6215 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6216
6217         * NEWS: Announce $_gdb_major and $_gdb_minor.
6218
6219         * top.c (init_gdb_version_vars): New function.
6220         (gdb_init): Call init_gdb_version_vars.
6221
6222 2019-03-29  Tom Tromey  <tromey@adacore.com>
6223
6224         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6225         help text.  Remove dead code.
6226
6227 2019-03-29  Keith Seitz  <keiths@redhat.com>
6228
6229         From Siddhesh Poyarekar:
6230         * f-lang.h (f77_get_upperbound): Return LONGEST.
6231         (f77_get_lowerbound): Likewise.
6232         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6233         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6234         print them.
6235         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6236         plongest to format print it.
6237         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6238         (f77_get_upperbound): Likewise.
6239         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6240         LOWER_BOUND to LONGEST.
6241         (f77_create_arrayprint_offset_tbl): Likewise.
6242
6243 2019-03-29  Keith Seitz  <keiths@redhat.com>
6244
6245         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6246         %s/pulongest for TYPE_LENGTH instead of %d in format
6247         strings.
6248         * ada-typerint.c (ada_print_type): Likewise.
6249         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6250         * compile/compile-c-support.c (generate_register_struct): Likewise.
6251         * gdbtypes.c (recursive_dump_type): Likewise.
6252         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6253         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6254         instead of %d in format strings.
6255         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6256         to std::min to ULONGEST.
6257         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6258         instead of %d in format strings.
6259         * tracepoint.c (info_scope_command): Likewise.
6260         * typeprint.c (print_offset_data::update)
6261         (print_offset_data::finish): Likewise.
6262         * xtensa-tdep.c (xtensa_store_return_value)
6263         (xtensa_push_dummy_call): Likewise.
6264
6265 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6266
6267         * windows-nat.c (display_selector): Fixed format specifications
6268         for 64-bit Cygwin.
6269
6270 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6271
6272         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6273
6274 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6275
6276         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6277         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6278         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6279         (nios2_linux_init_abi): Install it.
6280
6281 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6282
6283         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6284
6285 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6286
6287         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6288
6289 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6290             Tom Tromey  <tromey@adacore.com>
6291
6292         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6293
6294 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6295
6296         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6297         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6298         method to compute the bounds of range types. Also print "[evaluated]"
6299         if the bounds' values come from a dynamic evaluation.
6300
6301 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6302
6303         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6304         whitespace when pretty printing is on.
6305
6306 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6307
6308         * ppc-linux-nat.c: Add include.
6309
6310 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6311
6312         * NEWS: Mention AArch64 Pointer Authentication.
6313
6314 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6315
6316         * arm-linux-nat.c: Add include.
6317
6318 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6319
6320         * source-cache.c (source_cache::get_source_lines): Re-read
6321         fullname after calling open_source_file.
6322
6323 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6324
6325         * NEWS: Mention TLS support for FreeBSD.
6326
6327 2019-03-25  Tom Tromey  <tromey@adacore.com>
6328
6329         * minsyms.c (BUNCH_SIZE): Update comment.
6330         (~minimal_symbol_reader): Remove old comment.
6331         (compact_minimal_symbols): Update comment.
6332         (minimal_symbol_reader::install): Remove old comment.  Update
6333         other comments.
6334
6335 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6336
6337         * s390-linux-nat.c: Add include.
6338
6339 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6340
6341         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6342         Call linux_get_hwcap.
6343         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6344         Likewise.
6345         (aarch64_linux_get_hwcap): Remove function.
6346         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6347         declaration.
6348         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6349         linux_get_hwcap.
6350         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6351         * linux-tdep.c (linux_get_hwcap): Add function.
6352         (linux_get_hwcap2): Likewise.
6353         * linux-tdep.h (linux_get_hwcap): Add declaration.
6354         (linux_get_hwcap2): Likewise.
6355         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6356         (ppc_linux_get_hwcap2): Likewise.
6357         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6358         linux_get_hwcap.
6359         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6360         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6361         (ppc_linux_nat_target::read_description): Likewise.
6362         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6363         * s390-linux-nat.c: Likewise.
6364         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6365
6366 2019-03-24  Tom Tromey  <tom@tromey.com>
6367
6368         * ada-lang.c (standard_lookup): Simplify initialization.
6369         (ada_lookup_symbol_nonlocal): Simplify return.
6370         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6371         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6372         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6373         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6374         initialization.
6375         * solib.c (solib_global_lookup): Simplify.
6376         * symtab.c (null_block_symbol): Remove.
6377         (symbol_cache_lookup): Simplify returns.
6378         (lookup_language_this): Simplify returns.
6379         (lookup_symbol_aux): Simplify return.
6380         (lookup_local_symbol): Simplify returns.
6381         (lookup_global_symbol_from_objfile): Simplify return.
6382         (lookup_symbol_in_objfile_symtabs)
6383         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6384         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6385         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6386         * cp-namespace.c (cp_lookup_bare_symbol)
6387         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6388         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6389         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6390         (cp_lookup_symbol_via_imports): Simplify initialization.
6391         (find_symbol_in_baseclass): Likewise.
6392         * symtab.h (null_block_symbol): Remove.
6393         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6394         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6395         (d_lookup_symbol_module): Likewise.
6396         (find_symbol_in_baseclass): Simplify initialization.
6397
6398 2019-03-24  Tom Tromey  <tom@tromey.com>
6399
6400         * expression.h: Don't include symtab.h.
6401         (struct block): Forward declare.
6402
6403 2019-03-24  Tom Tromey  <tom@tromey.com>
6404
6405         * c-exp.y (typebase): Remove casts.
6406         * gdbtypes.c (lookup_unsigned_typename, )
6407         (lookup_signed_typename): Remove cast.
6408         * eval.c (parse_to_comma_and_eval): Remove cast.
6409         * parse.c (write_dollar_variable): Remove cast.
6410         * block.h (struct block) <superblock>: Now const.
6411         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6412         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6413         (map_block): Make "block" const.
6414         * symfile.h (struct quick_symbol_functions)
6415         <map_matching_symbols>: Constify block argument to "callback".
6416         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6417         const.
6418         (find_pc_sect_compunit_symtab): Make "b" const.
6419         (find_symbol_at_address): Likewise.
6420         (search_symbols): Likewise.
6421         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6422         (dw2_debug_names_lookup_symbol): Likewise.
6423         (dw2_map_matching_symbols): Update.
6424         * p-valprint.c (pascal_val_print): Remove "block".
6425         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6426         (aux_add_nonlocal_symbols): Make "block" const.
6427         (resolve_subexp): Remove cast.
6428         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6429         const.
6430         (iterate_over_file_blocks): Likewise.
6431         * f-exp.y (%union) <bval>: Remove.
6432         * coffread.c (patch_opaque_types): Make "b" const.
6433         * spu-tdep.c (spu_catch_start): Make "block" const.
6434         * c-valprint.c (print_unpacked_pointer): Remove "block".
6435         * symmisc.c (dump_symtab_1): Make "b" const.
6436         (block_depth): Make "block" const.
6437         * d-exp.y (%union) <bval>: Remove.
6438         * cp-support.h (cp_lookup_rtti_type): Update.
6439         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6440         * psymtab.c (psym_lookup_symbol): Make "block" const.
6441         (maintenance_check_psymtabs): Make "b" const.
6442         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6443         (enumerate_locals, enumerate_args): Update.
6444         * python/py-symtab.c (stpy_global_block): Make "block" const.
6445         (stpy_static_block): Likewise.
6446         * inline-frame.c (block_starting_point_at): Make "new_block"
6447         const.
6448         * block.c (find_block_in_blockvector): Make return type const.
6449         (blockvector_for_pc_sect): Make "b" const.
6450         (find_block_in_blockvector): Make "b" const.
6451
6452 2019-03-23  Tom Tromey  <tom@tromey.com>
6453
6454         * varobj.c (varobj_create): Update.
6455         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6456         * printcmd.c (display_command, do_one_display): Don't reset
6457         innermost_block.
6458         * parser-defs.h (enum innermost_block_tracker_type): Move to
6459         expression.h.
6460         (innermost_block): Update comment.
6461         * parse.c (parse_exp_1): Add tracker_types parameter.
6462         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6463         tracker_types parameter.  Reset innermost_block.
6464         (parse_exp_in_context): Remove.
6465         (parse_expression_for_completion): Update.
6466         * objfiles.c (~objfile): Don't reset expression_context_block or
6467         innermost_block.
6468         * expression.h (enum innermost_block_tracker_type): Move from
6469         parser-defs.h.
6470         (parse_exp_1): Add tracker_types parameter.
6471         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6472         reset innermost_block.
6473
6474 2019-03-23  Tom Tromey  <tom@tromey.com>
6475
6476         * objfiles.h: Include bcache.h.
6477
6478 2019-03-23  Tom Tromey  <tom@tromey.com>
6479
6480         * linespec.c (get_current_search_block): Use
6481         scoped_restore_current_language.
6482         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6483
6484 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6485             Jiong Wang  <jiong.wang@arm.com>
6486
6487         * aarch64-linux-tdep.c
6488         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6489         section.
6490         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6491
6492 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6493             Jiong Wang  <jiong.wang@arm.com>
6494
6495         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6496         instructions.
6497         (aarch64_analyze_prologue_test): Add PACIASP test.
6498         (aarch64_prologue_prev_register): Unmask PC value.
6499
6500 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6501             Jiong Wang  <jiong.wang@arm.com>
6502
6503         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6504         (aarch64_dwarf2_prev_register): Unmask PC value.
6505         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6506         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6507         DW_CFA_AARCH64_negate_ra_state.
6508         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6509
6510 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6511             Jiong Wang  <jiong.wang@arm.com>
6512
6513         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6514         registers.
6515         (aarch64_pseudo_register_name): Likewise.
6516         (aarch64_pseudo_register_type): Likewise.
6517         (aarch64_pseudo_register_reggroup_p): Likewise.
6518         (aarch64_gdbarch_init): Add pauth registers.
6519         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6520         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6521         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6522         (struct gdbarch_tdep): Add regnum for ra_state.
6523
6524 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6525             Jiong Wang  <jiong.wang@arm.com>
6526
6527         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6528
6529 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6530             Jiong Wang  <jiong.wang@arm.com>
6531
6532         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6533         function.
6534         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6535         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6536         (aarch64_gdbarch_init): Add puth registers.
6537         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6538         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6539         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6540
6541 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6542             Jiong Wang  <jiong.wang@arm.com>
6543
6544         * aarch64-linux-nat.c
6545         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6546         * aarch64-linux-tdep.c
6547         (aarch64_linux_core_read_description): Likewise.
6548         (aarch64_linux_get_hwcap): New function.
6549         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6550         (aarch64_linux_get_hwcap): New declaration.
6551
6552 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6553             Jiong Wang  <jiong.wang@arm.com>
6554
6555         * aarch64-linux-nat.c
6556         (aarch64_linux_nat_target::read_description): Add pauth param.
6557         * aarch64-linux-tdep.c
6558         (aarch64_linux_core_read_description): Likewise.
6559         * aarch64-tdep.c (struct target_desc): Add in pauth.
6560         (aarch64_read_description): Add pauth param.
6561         (aarch64_gdbarch_init): Likewise.
6562         * aarch64-tdep.h (aarch64_read_description): Likewise.
6563         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6564         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6565         * features/Makefile: Add new files.
6566         * features/aarch64-pauth.c: New file.
6567         * features/aarch64-pauth.xml: New file.
6568
6569 2019-03-20  Tom Tromey  <tromey@adacore.com>
6570
6571         * infrun.c (handle_inferior_event): Rename from
6572         handle_inferior_event_1.  Create a scoped_value_mark.
6573         (handle_inferior_event): Remove.
6574
6575 2019-03-19  Tom Tromey  <tromey@adacore.com>
6576
6577         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6578         * infrun.h (print_stop_event): Add "displays" parameter.
6579         * infrun.c (print_stop_event): Add "displays" parameter.
6580
6581 2019-03-19  Pedro Alves  <palves@redhat.com>
6582
6583         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6584         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6585         to -1.  Fix TABs vs spaces.
6586         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6587         * tui/tui-out.h (tui_ui_out) Add intro comments.
6588         <m_line, m_start_of_line>: In-class initialize, and add describing
6589         comment.
6590
6591 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6592
6593         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6594         variable names.
6595         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6596
6597 2019-03-18  Pedro Alves  <palves@redhat.com>
6598             Eli Zaretskii <eliz@gnu.org>
6599
6600         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6601         m_line and m_start_of_line.
6602
6603 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6604
6605         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6606         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6607         it returns a newline.  This fixes a regression in TU mode, whereby
6608         the next line is output on the same screen line as the user input.
6609
6610 2019-03-18  Tom Tromey  <tromey@adacore.com>
6611
6612         * minsyms.c (minimal_symbol_reader::install): Remove call to
6613         obstack_blank.
6614
6615 2019-03-18  Pedro Alves  <palves@redhat.com>
6616
6617         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6618         New globals.
6619         (apply_style): New, factored out from ...
6620         (apply_ansi_escape): ... this.  Handle reverse video mode.
6621         (tui_set_reverse_mode): New function.
6622         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6623         * tui/tui-winsource.c (tui_show_source_line): Use
6624         tui_set_reverse_mode instead of setting A_STANDOUT.
6625         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6626         New setter methods.
6627
6628 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6629
6630         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6631         Handle tabs.
6632
6633 2019-03-18  Tom Tromey  <tromey@adacore.com>
6634
6635         * ada-lang.c (empty_array): Add "high" parameter.
6636         (ada_evaluate_subexp): Update.
6637
6638 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6639
6640         * unittests/string_view-selftests.c: Define
6641         _initialize_string_view_selftests unconditionally.
6642
6643 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6644
6645         PR gdb/24350
6646         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6647
6648 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6649
6650         PR gdb/24351
6651         * windows-nat.c (display_selector): Fix format specifiers.
6652
6653 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6654
6655         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6656         tui_refill_source_window instead of tui_refresh_win, to update the
6657         current execution line.  This fixes redisplay of the current line
6658         when stepping through the code with "next" or "step".
6659
6660 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6661
6662         * source-cache.c (source_cache::get_source_lines): Call
6663         find_source_lines to initialize s->nlines.  This fixes vertical
6664         scrolling of TUI source window when the DOWN arrow is pressed.
6665
6666 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6667
6668         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6669         linux-thread-db.c (_initialize_thread_db): Likewise.
6670
6671 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6672
6673         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6674         wclrtoeol in tui_show_source_line".  This reverts changes made in
6675         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6676
6677 2019-03-15  Tom Tromey  <tom@tromey.com>
6678
6679         * symtab.h (struct minimal_symbol): Derive from
6680         general_symbol_info.
6681         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6682         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6683         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6684         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6685         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6686         (MSYMBOL_SEARCH_NAME): Update.
6687         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6688         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6689         * minsyms.c (minimal_symbol_reader::record_full): Update.
6690
6691 2019-03-15  Tom Tromey  <tom@tromey.com>
6692
6693         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6694
6695 2019-03-15  Tom Tromey  <tom@tromey.com>
6696
6697         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6698         unique_xmalloc_ptr.
6699         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6700         Update.
6701         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6702         (build_minimal_symbol_hash_tables)
6703         (minimal_symbol_reader::install): Update.
6704
6705 2019-03-15  Tom Tromey  <tom@tromey.com>
6706
6707         * symtab.c (create_demangled_names_hash): Update.
6708         (symbol_set_names): Update.
6709         * objfiles.h (struct objfile_per_bfd_storage)
6710         <demangled_names_hash>: Now an htab_up.
6711         * objfiles.c (objfile_per_bfd_storage): Simplify.
6712
6713 2019-03-15  Tom Tromey  <tom@tromey.com>
6714
6715         * objfiles.h (struct objfile_per_bfd_storage): Declare
6716         destructor.
6717         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6718         New.
6719         (get_objfile_bfd_data): Use new.  Don't initialize
6720         language_of_main.
6721         (free_objfile_per_bfd_storage): Remove.
6722         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6723
6724 2019-03-15  Tom Tromey  <tom@tromey.com>
6725
6726         * symfile.c (reread_symbols): Update.
6727         * objfiles.c (objfile::objfile): Update.
6728         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6729         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6730         comment.
6731         (minimal_symbol_reader::install): Update.
6732         (terminate_minimal_symbol_table): Remove.
6733         * jit.c (jit_object_close_impl): Update.
6734
6735 2019-03-15  Tom Tromey  <tom@tromey.com>
6736
6737         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6738         initializations.
6739
6740 2019-03-15  Tom Tromey  <tom@tromey.com>
6741
6742         * objfiles.h (struct objfile_per_bfd_storage)
6743         <demangled_hash_languages>: Now a bitset.
6744         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6745         (lookup_minimal_symbol): Update.
6746
6747 2019-03-15  Tom Tromey  <tom@tromey.com>
6748
6749         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6750         Don't return the symbol.
6751         * coffread.c (record_minimal_symbol): Use record_full.
6752
6753 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6754
6755         The MS-Windows port of ncurses fails to switch to a color pair if
6756         one or both of the colors are the implicit default colors.  This
6757         change records the default colors when TUI is initialized, and
6758         then specifies them explicitly when a color pair uses the default
6759         colors.  This allows color styling in TUI mode on MS-Windows.
6760
6761         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6762         ncurses_norm_attr.
6763         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6764         colors in ncurses_norm_attr.
6765         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6766         "none", replace it with the default color recorded in
6767         ncurses_norm_attr.
6768
6769 2019-03-14  Tom Tromey  <tromey@adacore.com>
6770
6771         * source-cache.h (class source_cache) <get_source_lines>: Return
6772         std::string.
6773         * source-cache.c (source_cache::extract_lines): Handle case where
6774         first_pos==npos.  Return std::string.
6775         (source_cache::get_source_lines): Update.
6776
6777 2019-03-14  Tom Tromey  <tromey@adacore.com>
6778
6779         * NEWS: Add item for "style sources" commands.
6780         * source-cache.c (source_cache::get_source_lines): Check
6781         source_styling.
6782         * cli/cli-style.c (source_styling): New global.
6783         (_initialize_cli_style): Add "style sources" commands.
6784         (show_style_sources): New function.
6785         * cli/cli-style.h (source_styling): Declare.
6786
6787 2019-03-14  Pedro Alves  <palves@redhat.com>
6788             Tom Tromey  <tromey@adacore.com>
6789
6790         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6791         * tui/tui-winsource.c (tui_refill_source_window): New function,
6792         from...
6793         (tui_horizontal_source_scroll): ... here.  Move some logic.
6794         * cli/cli-style.c (set_style_enabled): Notify new observable.
6795         * tui/tui-hooks.c (tui_redisplay_source): New function.
6796         (tui_attach_detach_observers): Attach or detach
6797         tui_redisplay_source.
6798         * observable.h (source_styling_changed): New observable.
6799         * observable.c: Define source_styling_changed observable.
6800
6801 2019-03-13  Tom Tromey  <tromey@adacore.com>
6802
6803         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6804         (i386_gnu_nat_target::store_registers): Update.
6805         * target-debug.h (target_debug_print_std_string): New macro.
6806         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6807         * windows-tdep.c (display_one_tib): Update.
6808         * tui/tui-stack.c (tui_make_status_line): Update.
6809         * top.c (print_inferior_quit_action): Update.
6810         * thread.c (thr_try_catch_cmd): Update.
6811         (add_thread_with_info): Update.
6812         (thread_target_id_str): Update.
6813         (thr_try_catch_cmd): Update.
6814         (thread_command): Update.
6815         (thread_find_command): Update.
6816         * record-btrace.c (record_btrace_target::info_record)
6817         (record_btrace_resume_thread, record_btrace_target::resume)
6818         (record_btrace_cancel_resume, record_btrace_step_thread)
6819         (record_btrace_target::wait, record_btrace_target::wait)
6820         (record_btrace_target::wait, record_btrace_target::stop): Update.
6821         * progspace.c (print_program_space): Update.
6822         * process-stratum-target.c
6823         (process_stratum_target::thread_address_space): Update.
6824         * linux-fork.c (linux_fork_mourn_inferior)
6825         (detach_checkpoint_command, info_checkpoints_command)
6826         (linux_fork_context): Update.
6827         (linux_fork_detach): Update.
6828         (class scoped_switch_fork_info): Update.
6829         (delete_checkpoint_command): Update.
6830         * infrun.c (follow_fork_inferior): Update.
6831         (follow_fork_inferior): Update.
6832         (proceed_after_vfork_done): Update.
6833         (handle_vfork_child_exec_or_exit): Update.
6834         (follow_exec): Update.
6835         (displaced_step_prepare_throw): Update.
6836         (displaced_step_restore): Update.
6837         (start_step_over): Update.
6838         (resume_1): Update.
6839         (clear_proceed_status_thread): Update.
6840         (proceed): Update.
6841         (print_target_wait_results): Update.
6842         (do_target_wait): Update.
6843         (context_switch): Update.
6844         (stop_all_threads): Update.
6845         (restart_threads): Update.
6846         (finish_step_over): Update.
6847         (handle_signal_stop): Update.
6848         (switch_back_to_stepped_thread): Update.
6849         (keep_going_pass_signal): Update.
6850         (print_exited_reason): Update.
6851         (normal_stop): Update.
6852         * inferior.c (inferior_pid_to_str): Change return type.
6853         (print_selected_inferior): Update.
6854         (add_inferior): Update.
6855         (detach_inferior): Update.
6856         * dummy-frame.c (fprint_dummy_frames): Update.
6857         * dcache.c (dcache_info_1): Update.
6858         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6859         (btrace_fetch, btrace_clear): Update.
6860         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6861         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6862         type.
6863         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6864         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6865         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6866         * gdbarch.c, gdbarch.h: Rebuild.
6867         * gdbarch.sh (core_pid_to_str): Change return type.
6868         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6869         return type.
6870         (windows_nat_target::pid_to_str): Change return type.
6871         (windows_delete_thread): Update.
6872         (windows_nat_target::attach): Update.
6873         (windows_nat_target::files_info): Update.
6874         * target-delegates.c: Rebuild.
6875         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6876         return type.
6877         (sol_thread_target::pid_to_str): Change return type.
6878         * remote.c (class remote_target) <pid_to_str>: Change return
6879         type.
6880         (remote_target::pid_to_str): Change return type.
6881         (extended_remote_target::attach, remote_target::remote_stop_ns)
6882         (remote_target::remote_notif_remove_queued_reply)
6883         (remote_target::push_stop_reply, remote_target::disable_btrace):
6884         Update.
6885         (extended_remote_target::attach): Update.
6886         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6887         type.
6888         (gdbsim_target::pid_to_str): Change return type.
6889         * ravenscar-thread.c (struct ravenscar_thread_target)
6890         <pid_to_str>: Change return type.
6891         (ravenscar_thread_target::pid_to_str): Change return type.
6892         * procfs.c (class procfs_target) <pid_to_str>: Change return
6893         type.
6894         (procfs_target::pid_to_str): Change return type.
6895         (procfs_target::attach): Update.
6896         (procfs_target::detach): Update.
6897         (procfs_target::fetch_registers): Update.
6898         (procfs_target::store_registers): Update.
6899         (procfs_target::wait): Update.
6900         (procfs_target::files_info): Update.
6901         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6902         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6903         return type.
6904         (nto_procfs_target::pid_to_str): Change return type.
6905         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6906         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6907         return type.
6908         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6909         (exit_lwp): Update.
6910         (attach_proc_task_lwp_callback, get_detach_signal)
6911         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6912         (linux_nat_target::resume, wait_lwp, stop_callback)
6913         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6914         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6915         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6916         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6917         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6918         type.
6919         (inf_ptrace_target::attach): Update.
6920         (inf_ptrace_target::files_info): Update.
6921         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6922         type.
6923         (go32_nat_target::pid_to_str): Change return type.
6924         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6925         (gnu_nat_target::wait): Update.
6926         (gnu_nat_target::wait): Update.
6927         (gnu_nat_target::resume): Update.
6928         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6929         (fbsd_nat_target::wait): Update.
6930         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6931         type.
6932         (darwin_nat_target::attach): Update.
6933         * corelow.c (class core_target) <pid_to_str>: Change return type.
6934         (core_target::pid_to_str): Change return type.
6935         * target.c (normal_pid_to_str): Change return type.
6936         (default_pid_to_str): Likewise.
6937         (target_pid_to_str): Change return type.
6938         (target_translate_tls_address): Update.
6939         (target_announce_detach): Update.
6940         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6941         return type.
6942         (bsd_uthread_target::pid_to_str): Change return type.
6943         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6944         type.
6945         (bsd_kvm_target::pid_to_str): Change return type.
6946         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6947         return type.
6948         (aix_thread_target::pid_to_str): Change return type.
6949         * target.h (struct target_ops) <pid_to_str>: Change return type.
6950         (target_pid_to_str, normal_pid_to_str): Likewise.
6951         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6952         type.
6953         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6954         type.
6955         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6956         return type.
6957         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6958         type.
6959         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6960         type.
6961         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6962         return type.
6963
6964 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6965
6966         * NEWS: Mention that the new default MI version is 3.  Mention
6967         changes to the output of commands and events that deal with
6968         multi-location breakpoints.
6969         * breakpoint.c: Include "mi/mi-out.h".
6970         (print_one_breakpoint): Change output syntax if using MI version
6971         >= 3.
6972         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6973         New.
6974         (mi_multi_location_breakpoint_output_fixed): New.
6975         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6976         (mi_cmd_fix_multi_location_breakpoint_output): New.
6977         (mi_multi_location_breakpoint_output_fixed): New.
6978         * mi/mi-cmds.c (mi_cmds): Register command
6979         -fix-multi-location-breakpoint-output.
6980         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6981         interpreter "mi".
6982
6983 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6984
6985         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6986         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6987         instantiate mi_ui_out based on interpreter name.
6988         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6989         * mi/mi-main.c (mi_load_progress): Likewise.
6990
6991 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6992
6993         * NEWS: Combine separate "New targets" sections for 8.3.
6994
6995 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6996
6997         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6998         (ppcfbsd_init_abi): Install gdbarch
6999         "fetch_tls_load_module_address" and "get_thread_local_address"
7000         methods.
7001
7002 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7003
7004         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7005         (riscv_fbsd_init_abi): Install gdbarch
7006         "fetch_tls_load_module_address" and "get_thread_local_address"
7007         methods.
7008
7009 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7010
7011         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7012         (i386fbsd_init_abi): Install gdbarch
7013         "fetch_tls_load_module_address" and "get_thread_local_address"
7014         methods.
7015
7016 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7017
7018         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7019         (amd64fbsd_init_abi): Install gdbarch
7020         "fetch_tls_load_module_address" and "get_thread_local_address"
7021         methods.
7022
7023 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7024
7025         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7026         (struct fbsd_pspace_data): New type.
7027         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7028         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7029         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7030         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7031         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7032
7033 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7034
7035         * gdbtypes.c (lookup_struct_elt): New function.
7036         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7037         * gdbtypes.h (struct struct_elt): New type.
7038         (lookup_struct_elt): New prototype.
7039
7040 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7041
7042         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7043         remove disabled code block.
7044
7045 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7046
7047         * gdbarch.sh (get_thread_local_address): New method.
7048         * gdbarch.h, gdbarch.c: Regenerate.
7049         * target.c (target_translate_tls_address): Use
7050         gdbarch_get_thread_local_address if present instead of
7051         target::get_thread_local_address.
7052
7053 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7054
7055         * target.h (target::get_thread_local_address): Update comment.
7056
7057 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7058
7059         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7060         objfile->separate_debug_objfile_backlink if not NULL.
7061
7062 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7063
7064         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7065         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7066         (amd64bsd_store_inferior_registers): Likewise.
7067         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7068         Enable segment base registers.
7069         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7070         PT_GETFSBASE and PT_GETGSBASE.
7071         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7072         PT_SETGSBASE.
7073         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7074         segment base registers.
7075         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7076
7077 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7078
7079         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7080         Update calls to i386_target_description to add 'segments'
7081         parameter.
7082         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7083         add segment base registers.
7084         * arch/i386.c (i386_create_target_description): Add 'segments'
7085         parameter to enable segment base registers.
7086         * arch/i386.h (i386_create_target_description): Likewise.
7087         * features/i386/32bit-segments.xml: New file.
7088         * features/i386/32bit-segments.c: Generate.
7089         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7090         call to i386_target_description to add 'segments' parameter.
7091         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7092         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7093         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7094         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7095         if feature is present.
7096         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7097         Add 'segments' parameter to call to i386_target_description.
7098         (i386_target_description): Add 'segments' parameter to enable
7099         segment base registers.
7100         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7101         to call to i386_target_description.
7102         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7103         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7104         Define I386_NUM_REGS.
7105         (i386_target_description): Add 'segments' parameter to enable
7106         segment base registers.
7107
7108 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7109
7110         PR/24325
7111         * source-cache.c: #undef open and close, to avoid unresolved
7112         externals during linking.
7113
7114 2019-03-12  Tom Tromey  <tromey@adacore.com>
7115
7116         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7117         const.  Add initializers.
7118         (_initialize_remote): Don't initialize ptid globals.
7119
7120 2019-03-12  Pedro Alves  <palves@redhat.com>
7121
7122         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7123
7124 2019-03-12  Pedro Alves  <palves@redhat.com>
7125
7126         * cp-name-parser.y (main): Remove unused 'len' variable.
7127
7128 2019-03-12  Tom Tromey  <tromey@adacore.com>
7129
7130         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7131         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7132
7133 2019-03-12  Tom Tromey  <tromey@adacore.com>
7134
7135         * linux-nat.c (iterate_over_lwps): Update.
7136         (stop_callback): Remove parameter.
7137         (stop_wait_callback, detach_callback, resume_set_callback)
7138         (select_singlestep_lwp_callback, set_ignore_sigint)
7139         (status_callback, resumed_callback, resume_clear_callback)
7140         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7141         data parameter.
7142         (linux_nat_target::detach, linux_nat_target::resume)
7143         (linux_stop_and_wait_all_lwps, select_event_lwp)
7144         (linux_nat_filter_event, linux_nat_wait_1)
7145         (linux_nat_target::kill, linux_nat_target::stop)
7146         (linux_nat_target::stop): Update.
7147         (linux_nat_resume_callback): Change type.
7148         (resume_stopped_resumed_lwps, count_events_callback)
7149         (select_event_lwp_callback): Likewise.
7150         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7151         * arm-linux-nat.c (struct update_registers_data): Remove.
7152         (update_registers_callback): Change type.
7153         (arm_linux_insert_hw_breakpoint1): Update.
7154         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7155         parameter.
7156         (x86_linux_dr_set_addr): Update.
7157         (x86_linux_dr_set_control): Update.
7158         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7159         (iterate_over_lwps): Use gdb::function_view.
7160         * nat/aarch64-linux-hw-point.c (struct
7161         aarch64_dr_update_callback_param): Remove.
7162         (debug_reg_change_callback): Change type.
7163         (aarch64_notify_debug_reg_change): Update.
7164         * s390-linux-nat.c (s390_refresh_per_info): Update.
7165
7166 2019-03-11  Tom Tromey  <tromey@adacore.com>
7167
7168         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7169         redundant assignment to "this_cu".
7170
7171 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7172
7173         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7174
7175 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7176
7177         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7178         from...
7179         (rank_one_type): ... this.
7180
7181 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7182
7183         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7184         from...
7185         (rank_one_type): ... this.
7186
7187 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7188
7189         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7190         from...
7191         (rank_one_type): ... this.
7192
7193 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7194
7195         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7196         from...
7197         (rank_one_type): ... this.
7198
7199 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7200
7201         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7202         from...
7203         (rank_one_type): ... this.
7204
7205 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7206
7207         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7208         from...
7209         (rank_one_type): ... this.
7210
7211 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7212
7213         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7214         from...
7215         (rank_one_type): ... this.
7216
7217 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7218
7219         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7220         from...
7221         (rank_one_type): ... this.
7222
7223 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7224
7225         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7226         from...
7227         (rank_one_type): ... this.
7228
7229 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7230
7231         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7232         from...
7233         (rank_one_type): ... this.
7234
7235 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7236
7237         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7238         from...
7239         (rank_one_type): ... this.
7240
7241 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7242
7243         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7244         from...
7245         (rank_one_type): ... this.
7246
7247 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7248
7249         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7250         inferior-events' shows the example events.
7251
7252 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7253
7254         Support styling on native MS-Windows console
7255
7256         PR/24315
7257         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7258         on MS-Windows if $TERM is not defined.
7259
7260         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7261
7262         * posix-hdep.c (gdb_console_fputs):
7263         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7264         functions.
7265         * ui-file.h (gdb_console_fputs): Add prototype.
7266
7267         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7268         back to fputs only if the former returns zero.
7269
7270 2019-03-07  Tom Tromey  <tom@tromey.com>
7271
7272         * symmisc.c (print_symbol_bcache_statistics): Update.
7273         (print_objfile_statistics): Update.
7274         * symfile.c (allocate_symtab): Update.
7275         * stabsread.c: Don't include bcache.h.
7276         * psymtab.h (struct psymbol_bcache): Don't declare.
7277         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7278         (psymbol_bcache_init, psymbol_bcache_free)
7279         (psymbol_bcache_get_bcache): Don't declare.
7280         * psymtab.c (struct psymbol_bcache): Remove.
7281         (psymtab_storage::psymtab_storage): Update.
7282         (psymtab_storage::~psymtab_storage): Update.
7283         (psymbol_bcache_init, psymbol_bcache_free)
7284         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7285         (add_psymbol_to_bcache): Update.
7286         (allocate_psymtab): Update.
7287         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7288         macro_cache>: No longer pointers.
7289         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7290         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7291         * macrotab.c (macro_bcache): Update.
7292         * macroexp.c: Don't include bcache.h.
7293         * gdbtypes.c (check_types_worklist): Update.
7294         (types_deeply_equal): Remove TRY/CATCH.  Update.
7295         * elfread.c (elf_symtab_read): Update.
7296         * dwarf2read.c: Don't include bcache.h.
7297         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7298         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7299         (print_bcache_statistics, bcache_memory_used): Don't declare.
7300         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7301         methods.  Rename all data members.
7302         * bcache.c (struct bcache): Move to bcache.h.
7303         (bcache::expand_hash_table): Rename from expand_hash_table.
7304         (bcache): Remove.
7305         (bcache::insert): Rename from bcache_full.
7306         (bcache::compare): Rename from bcache_compare.
7307         (bcache_xmalloc): Remove.
7308         (bcache::~bcache): Rename from bcache_xfree.
7309         (bcache::print_statistics): Rename from print_bcache_statistics.
7310         (bcache::memory_used): Rename from bcache_memory_used.
7311
7312 2019-03-07  Pedro Alves  <palves@redhat.com>
7313
7314         * infrun.c (normal_stop): Also check for
7315         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7316
7317 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7318
7319         * f-lang.c (value_from_host_double): Moved to...
7320         * value.c (value_from_host_double): ...here.
7321         * value.h (value_from_host_double): Declare.
7322         * guile/scm-math.c (vlscm_convert_typed_number): Use
7323         value_from_host_double.
7324         (vlscm_convert_number): Likewise.
7325         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7326         * python/py-value.c (convert_value_from_python): Likewise.
7327
7328 2019-03-06  Tom Tromey  <tom@tromey.com>
7329
7330         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7331
7332 2019-03-06  Tom Tromey  <tom@tromey.com>
7333
7334         * utils.h (free_current_contents): Don't declare.
7335         * utils.c (free_current_contents): Remove.
7336
7337 2019-03-06  Tom Tromey  <tom@tromey.com>
7338
7339         * top.c (quit_force): Update.
7340         * main.c (captured_command_loop): Update.
7341         * common/new-op.c (operator new): Update.
7342         * common/common-exceptions.c (struct catcher)
7343         <save_cleanup_chain>: Remove member.
7344         (exceptions_state_mc_init): Update.
7345         (exception_try_scope_entry): Return nullptr.
7346         (exception_try_scope_exit, exception_rethrow)
7347         (throw_exception_sjlj, throw_exception_cxx): Update.
7348         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7349         (all_cleanups, do_cleanups, discard_cleanups)
7350         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7351         (restore_cleanups, restore_final_cleanups): Don't declare.
7352         (do_final_cleanups): Remove parameter.
7353         * common/cleanups.c (cleanup_chain, make_cleanup)
7354         (make_cleanup_dtor, all_cleanups, do_cleanups)
7355         (discard_my_cleanups, discard_cleanups)
7356         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7357         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7358         (null_cleanup): Remove.
7359         (do_final_cleanups): Remove parameter.
7360
7361 2019-03-06  Tom Tromey  <tom@tromey.com>
7362
7363         * remote.c (remote_target::remote_parse_stop_reply): Use
7364         unique_xmalloc_ptr.
7365
7366 2019-03-06  Tom Tromey  <tom@tromey.com>
7367
7368         * stabsread.c (struct stabs_field_info): Rename from field_info.
7369         <list, fnlist>: Add initializers.
7370         <obstack>: New member.
7371         (read_member_functions, read_struct_fields, read_baseclasses):
7372         Allocate on obstack.  Don't use cleanups.
7373         (read_one_struct_field, read_member_functions, read_struct_fields)
7374         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7375         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7376         (read_struct_type): Update.
7377
7378 2019-03-06  Tom Tromey  <tom@tromey.com>
7379
7380         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7381         * common/filestuff.h (make_cleanup_close): Don't declare.
7382         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7383         Remove.
7384
7385 2019-03-06  Tom Tromey  <tom@tromey.com>
7386
7387         * solib-aix.c: Use make_scope_exit.
7388
7389 2019-03-06  Tom Tromey  <tom@tromey.com>
7390
7391         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7392         Use make_scope_exit.
7393
7394 2019-03-06  Tom Tromey  <tom@tromey.com>
7395
7396         * solib-svr4.c (disable_probes_interface): Remove parameter.
7397         (svr4_handle_solib_event): Use make_scope_exit.
7398
7399 2019-03-06  Tom Tromey  <tom@tromey.com>
7400
7401         * remote.c (struct stop_reply_deleter): Remove.
7402         (stop_reply_up): Update.
7403         (struct stop_reply): Derive from notif_event.  Don't typedef.
7404         <regcache>: Now a std::vector.
7405         (stop_reply_xfree): Remove.
7406         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7407         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7408         (remote_target::discard_pending_stop_replies): Use delete.
7409         (remote_target::remote_parse_stop_reply): Update.
7410         (remote_target::process_stop_reply): Update.
7411         * remote-notif.h (struct notif_event): Add virtual destructor.
7412         Remove "dtr" member.
7413         (struct notif_client) <alloc_event>: Return a unique_ptr.
7414         (notif_event_xfree): Don't declare.
7415         (notif_event_up): New typedef.
7416         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7417         (notif_event_xfree, do_notif_event_xfree): Remove.
7418         (remote_notif_state_xfree): Update.
7419
7420 2019-03-06  Tom Tromey  <tom@tromey.com>
7421
7422         * infrun.c (displaced_step_clear_cleanup): Now a
7423         forward_scope_exit type.
7424         (displaced_step_prepare_throw): Update.
7425         (displaced_step_fixup): Update.
7426
7427 2019-03-06  Tom Tromey  <tom@tromey.com>
7428
7429         * inferior.h (class inferior): Update comment.
7430         * gdbthread.h (class thread_info): Update comment.
7431
7432 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7433             Tom Tromey  <tom@tromey.com>
7434
7435         * stabsread.h (struct stab_section_list): Remove.
7436         (coffstab_build_psymtabs): Update.
7437         * dbxread.c (symbuf_sections): Now a std::vector.
7438         (sect_idx): New global.
7439         (fill_symbuf): Update.
7440         (coffstab_build_psymtabs): Change type of stabsects parameter.
7441         Update.
7442         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7443         std::vector.
7444         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7445         (coff_locate_sections): Update.
7446         (coff_symfile_read): Remove cleanups.  Update.
7447         (init_stringtab): Add storage parameter.
7448         (free_stringtab, free_stringtab_cleanup): Remove.
7449         (init_lineno): Add storage parameter.
7450         (free_linetab, free_linetab_cleanup): Remove.
7451
7452 2019-03-06  Pedro Alves  <palves@redhat.com>
7453
7454         * linux-fork.c (fork_info::clobber_regs): Delete.
7455         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7456         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7457         comment.  Adjust.
7458         (scoped_switch_fork_info::scoped_switch_fork_info)
7459         (checkpoint_command, linux_fork_context): Adjust
7460         fork_save_infrun_state calls.
7461
7462 2019-03-06  Pedro Alves  <palves@redhat.com>
7463
7464         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7465         (inf_has_multiple_threads): Return 'bool' and rewrite using
7466         inferior_info::threads().
7467
7468 2019-03-06  Pedro Alves  <palves@redhat.com>
7469
7470         * linux-fork.c: Include <list>.
7471         (fork_list): Now a std::list instance.
7472         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7473         (forks_exist_p, find_last_fork): Adjust.
7474         (new_fork): Delete.
7475         (one_fork_p): New.
7476         (add_fork): Adjust.
7477         (free_fork): Delete, folded into fork_info::~fork_info().
7478         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7479         Adjust.
7480         (init_fork_list): Delete.
7481         (linux_fork_killall, linux_fork_mourn_inferior)
7482         (linux_fork_detach, info_checkpoints_command): Adjust.
7483         (_initialize_linux_fork): No longer call init_fork_list.
7484
7485 2019-03-06  Pedro Alves  <palves@redhat.com>
7486
7487         * linux-fork.c (new_fork): New, split out of ...
7488         (add_fork): ... this.  Return void.  Move "first fork" special
7489         case from here, to ...
7490         (checkpoint_command): ... here.
7491         * linux-linux.h (add_fork): Return void.
7492
7493 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7494
7495         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7496
7497 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7498             Chris January  <chris.january@arm.com>
7499             David Lecomber  <david.lecomber@arm.com>
7500
7501         * f-exp.y: New token, UNOP_INTRINSIC.
7502         (exp): New pattern using UNOP_INTRINSIC token.
7503         (f77_keywords): Add 'abs' keyword.
7504         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7505         (value_from_host_double): New function.
7506         (evaluate_subexp_f): Support UNOP_ABS.
7507
7508 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7509
7510         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7511         types.
7512
7513 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7514
7515         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7516         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7517         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7518
7519 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7520
7521         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7522
7523 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7524             Chris January  <chris.january@arm.com>
7525
7526         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7527         * f-exp.y: Define 'KIND' token.
7528         (exp): New pattern for KIND expressions.
7529         (ptype): Handle types with a kind extension.
7530         (direct_abs_decl): Extend to spot kind extensions.
7531         (f77_keywords): Add 'kind' to the list.
7532         (push_kind_type): New function.
7533         (convert_to_kind_type): New function.
7534         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7535         * parse.c (operator_length_standard): Likewise.
7536         * parser-defs.h (enum type_pieces): Add tp_kind.
7537         * std-operator.def: Add UNOP_KIND.
7538
7539 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7540
7541         * f-exp.y (f_parse): Set yydebug.
7542
7543 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7544
7545         * f-lang.c (evaluate_subexp_f): New function.
7546         (exp_descriptor_f): New global.
7547         (f_language_defn): Use exp_descriptor_f instead of
7548         exp_descriptor_standard.
7549
7550 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7551
7552         * f-exp.y (struct token): Add comments.
7553         (dot_ops): Remove uppercase versions and the end marker.
7554         (f77_keywords): Likewise.
7555         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7556         entries in the dot_ops array are case insensitive, and use
7557         strncasecmp to compare strings.  Also some whitespace cleanup in
7558         this area.  Similar for the f77_keywords array, except entries in
7559         this list might be case sensitive.
7560
7561 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7562
7563         * f-exp.y (struct f77_boolean_val): Add comments.
7564         (boolean_values): Remove uppercase versions, and end marker.
7565         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7566         and use strncasecmp to achieve case insensitivity.  Additionally,
7567         perform whitespace cleanup around this code.
7568
7569 2019-03-06  Tom Tromey  <tromey@adacore.com>
7570
7571         * remote-sim.c (gdbsim_target_open): Use result of
7572         gdb_argv::release.
7573
7574 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7575         Dirk Schubert  <dirk.schubert@arm.com>
7576         Chris January  <chris.january@arm.com>
7577
7578         * eval.c (evaluate_subexp_standard): Call Fortran argument
7579         wrapping logic.
7580         * f-lang.c (struct value): A value which can be passed into a
7581         Fortran function call.
7582         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7583         where appropriate.
7584         (struct type): Value ready for a Fortran function call.
7585         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7586         is needed.
7587         * f-lang.h (fortran_argument_convert): Declaration.
7588         (fortran_preserve_arg_pointer): Declaration.
7589         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7590
7591 2019-03-05  Tom Tromey  <tromey@adacore.com>
7592
7593         * python/py-prettyprint.c (print_string_repr): Remove #if.
7594         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7595
7596 2019-03-05  Tom Tromey  <tromey@adacore.com>
7597
7598         * target.c (the_dummy_target): Move later.  Change type to
7599         "dummy_target".
7600         (initialize_targets): Don't initialize the_dummy_target.
7601
7602 2019-03-05  Tom Tromey  <tromey@adacore.com>
7603
7604         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7605         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7606
7607 2019-03-05  Tom Tromey  <tromey@adacore.com>
7608
7609         * windows-nat.c (windows_nat_target::attach)
7610         (windows_nat_target::detach): Don't call gdb_flush.
7611         * valprint.c (generic_val_print, val_print, val_print_string):
7612         Don't call gdb_flush.
7613         * utils.c (defaulted_query): Don't call gdb_flush.
7614         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7615         * target.c (target_announce_detach): Don't call gdb_flush.
7616         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7617         * remote.c (extended_remote_target::attach): Don't call
7618         gdb_flush.
7619         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7620         * printcmd.c (do_examine): Don't call gdb_flush.
7621         (info_display_command): Don't call gdb_flush.
7622         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7623         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7624         * memattr.c (info_mem_command): Don't call gdb_flush.
7625         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7626         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7627         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7628         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7629         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7630         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7631         (gnu_nat_target::detach): Don't call gdb_flush.
7632         * f-valprint.c (f_val_print): Don't call gdb_flush.
7633         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7634         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7635         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7636         gdb_flush.
7637         * c-valprint.c (c_val_print): Don't call gdb_flush.
7638         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7639
7640 2019-03-05  Tom Tromey  <tromey@adacore.com>
7641
7642         * varobj.c (update_dynamic_varobj_children): Update.
7643         (install_default_visualizer): Use reset, not release.
7644         * value.c (set_internalvar): Update.
7645         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7646         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7647         ATTRIBUTE_UNUSED_RESULT.
7648
7649 2019-03-05  Tom Tromey  <tromey@adacore.com>
7650
7651         * remote.c (class scoped_remote_fd) <release>: Add
7652         ATTRIBUTE_UNUSED_RESULT.
7653
7654 2019-03-05  Tom Tromey  <tromey@adacore.com>
7655
7656         * macroexp.c (struct macro_buffer) <release>: Add
7657         ATTRIBUTE_UNUSED_RESULT.
7658
7659 2019-03-05  Tom Tromey  <tromey@adacore.com>
7660
7661         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7662         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7663         ATTRIBUTE_UNUSED_RESULT.
7664
7665 2019-03-05  Tom Tromey  <tromey@adacore.com>
7666
7667         * common/scoped_fd.h (class scoped_fd) <release>: Add
7668         ATTRIBUTE_UNUSED_RESULT.
7669
7670 2019-03-05  Tom Tromey  <tromey@adacore.com>
7671
7672         * parser-defs.h (struct parser_state) <release>: Add
7673         ATTRIBUTE_UNUSED_RESULT.
7674
7675 2019-03-05  Tom Tromey  <tromey@adacore.com>
7676
7677         * utils.h (class gdb_argv) <release>: Add
7678         ATTRIBUTE_UNUSED_RESULT.
7679         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7680
7681 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7682
7683         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7684         for-loop range, to avoid compiler warnings.
7685
7686         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7687         avoid compiler warnings about unused variables.
7688
7689         * NEWS: Mention end of support for native debugging on MS-Windows
7690         before XP.
7691
7692         PR gdb/24292
7693         * common/netstuff.c:
7694         * gdbserver/gdbreplay.c
7695         * gdbserver/remote-utils.c:
7696         * ser-tcp.c:
7697         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7698         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7699         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7700         'getaddrinfo' and 'freeaddrinfo' were not available before
7701         Windows XP, and mingw.org's MinGW headers by default define
7702         _WIN32_WINNT to 0x500.
7703
7704 2019-03-01  Gary Benson <gbenson@redhat.com>
7705
7706         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7707
7708 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7709             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7710
7711         PR gdb/8527
7712         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7713         set_sigint_trap, clear_sigint_trap.
7714
7715 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7716
7717         * target.c (target_detach): Clear the regcache and the
7718         frame cache.
7719
7720 2019-02-27  Pedro Alves  <palves@redhat.com>
7721
7722         * utils.c (set_screen_size): When we cap the height/width sizes,
7723         tweak the corresponding command variable to show "unlimited":
7724
7725 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7726             Pedro Alves  <palves@redhat.com>
7727
7728         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7729         before calling rl_set_screen_size.
7730
7731 2019-02-27  Tom Tromey  <tromey@adacore.com>
7732
7733         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7734         define.
7735         * python/py-value.c: Remove Python 2.4 workaround.
7736         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7737         workaround.
7738         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7739         Python 2.4 workaround.
7740         * python/python-internal.h: Remove Python 2.4 comment.
7741         (Py_ssize_t): Don't define.
7742         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7743         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7744         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7745         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7746         * python/python.c (do_start_initialization): Remove Python 2.4
7747         workaround.
7748         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7749         (print_children): Remove Python 2.4 workaround.
7750         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7751         workaround.
7752         (CHARBUFFERPROC_NAME): Remove.
7753         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7754         Python 2.4 workaround.
7755
7756 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7757
7758         * NEWS: Note minimum Python version.
7759
7760 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7761
7762         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7763         code from these functions.  Remove corresponding ifdefs.  Use
7764         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7765         Remove gotos and target of gotos.
7766         (infpy_search_memory): Likewise.
7767
7768 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7769
7770         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7771         (hppa_gdbarch_init): Don't register deleted functions with
7772         gdbarch.
7773
7774 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7775
7776         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7777         (h8300_unwind_sp): Delete.
7778         (h8300_dummy_id): Delete.
7779         (h8300_gdbarch_init): Don't register deleted functions with
7780         gdbarch.
7781
7782 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7783
7784         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7785         (ft32_unwind_pc): Delete.
7786         (ft32_unwind_sp): Delete.
7787         (ft32_gdbarch_init): Don't register deleted functions with
7788         gdbarch.
7789
7790 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7791
7792         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7793         (frv_unwind_pc): Delete.
7794         (frv_unwind_sp): Delete.
7795         (frv_gdbarch_init): Don't register deleted functions with
7796         gdbarch.
7797
7798 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7799
7800         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7801         (riscv_unwind_pc): Delete.
7802         (riscv_unwind_sp): Delete.
7803         (riscv_gdbarch_init): Don't register deleted functions with
7804         gdbarch.
7805
7806 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7807
7808         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7809         (csky_unwind_pc): Delete.
7810         (csky_unwind_sp): Delete.
7811         (csky_gdbarch_init): Don't register deleted functions with
7812         gdbarch.
7813
7814 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7815
7816         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7817         (cris_unwind_pc): Delete.
7818         (cris_unwind_sp): Delete.
7819         (cris_gdbarch_init): Don't register deleted functions with
7820         gdbarch.
7821
7822 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7823
7824         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7825         (bfin_unwind_pc): Delete.
7826         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7827
7828 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7829
7830         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7831         (arm_unwind_pc): Delete.
7832         (arm_unwind_sp): Delete.
7833         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7834
7835 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7836
7837         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7838         (arc_unwind_pc): Delete.
7839         (arc_unwind_sp): Delete.
7840         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7841
7842 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7843
7844         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7845         (alpha_unwind_pc): Delete.
7846         (alpha_gdbarch_init): Don't register deleted functions with
7847         gdbarch.
7848
7849 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7850
7851         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7852         (aarch64_unwind_pc): Delete.
7853         (aarch64_unwind_sp): Delete.
7854         (aarch64_gdbarch_init): Don't register deleted functions with
7855         gdbarch.
7856
7857 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7858
7859         * gdbtypes.c (type_align): Don't consider static members when
7860         computing structure alignment.
7861
7862 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7863
7864         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7865         return 0 for other types.
7866         * arch-utils.c (default_type_align): Always return 0.
7867         * gdbarch.h: Regenerate.
7868         * gdbarch.sh (type_align): Extend comment.
7869         * gdbtypes.c (type_align): Add additional comments, always call
7870         gdbarch_type_align before applying the default rules.
7871         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7872         generic code will then apply a suitable default.
7873         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7874         types, return 0 for other types.
7875
7876 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7877
7878         * NEWS: Create a new section for the next release branch.
7879         Rename the section of the current branch, now that it has
7880         been cut.
7881
7882 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7883
7884         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7885         * version.in: Bump version to 8.3.50.DATE-git.
7886
7887 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7888
7889         * aix-thread.c (ptid_cmp): Remove unused variable.
7890         (get_signaled_thread): Likewise.
7891         (store_regs_user_thread): Likewise.
7892         (store_regs_kernel_thread): Likewise.
7893         (fetch_regs_kernel_thread): Remove shadowed variable.
7894
7895 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7896
7897         * features/riscv/32bit-cpu.xml: Add register numbers.
7898         * features/riscv/32bit-fpu.c: Regenerate.
7899         * features/riscv/32bit-fpu.xml: Add register numbers.
7900         * features/riscv/64bit-cpu.xml: Add register numbers.
7901         * features/riscv/64bit-fpu.c: Regenerate.
7902         * features/riscv/64bit-fpu.xml: Add register numbers.
7903
7904 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7905
7906         * NEWS: Mention two argument form of gdb.Value constructor.
7907         * python/py-value.c (convert_buffer_and_type_to_value): New
7908         function.
7909         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7910         Add support for handling an optional second argument.  Call
7911         convert_buffer_and_type_to_value as appropriate.
7912         * python/python-internal.h (Py_buffer_deleter): New struct.
7913         (Py_buffer_up): New typedef.
7914
7915 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7916
7917         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7918         instead of releasing ownership.
7919
7920 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7921
7922         * dwarf2read.c (open_and_init_dwp_file): Call
7923         elf_numsections instead of bfd_count_sections to initialize
7924         dwp_file->num_sections.
7925
7926 2019-02-25  Tom Tromey  <tromey@adacore.com>
7927
7928         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7929
7930 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7931
7932         * gcore.in: Add '--readnever' option when invoking GDB.
7933
7934 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7935
7936         * MAINTAINERS: Update my email address.
7937
7938 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7939
7940         * build-id.c (build_id_to_debug_bfd_1): New function.
7941         (build_id_to_debug_bfd): Look for separate debug file in
7942         sysroot.
7943
7944 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7945
7946         * gdbarch.sh: Update the copyright year range that is placed into
7947         generated files.
7948
7949 2019-02-22  Keith Seitz  <keiths@redhat.com>
7950
7951         PR symtab/23853
7952         * linespec.c (create_sals_line_offset): Search for the default
7953         symtab's filename instead of its fullname.
7954
7955 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7956
7957         * NEWS: Update style defaults.
7958
7959 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7960
7961         * main.c (captured_main_1): Disable styling in batch mode.
7962
7963 2019-02-20  Tom Tromey  <tom@tromey.com>
7964
7965         * symtab.c (symtab_symbol_info): Fix typos.
7966
7967 2019-02-20  Tom Tromey  <tromey@adacore.com>
7968
7969         * findcmd.c (_initialize_mem_search): Use upper case for
7970         metasyntactic variables.
7971
7972 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7973
7974         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7975         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7976
7977 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7978
7979         * top.h (source_file_name): Change to std::string.
7980         * top.c (source_file_name): Likewise.
7981         (command_line_input): Adjust.
7982         * cli/cli-script.c (script_from_file): Adjust.
7983
7984 2019-02-19  Tom Tromey  <tromey@adacore.com>
7985
7986         * ravenscar-thread.c
7987         (ravenscar_thread_target::update_thread_list): Don't call
7988         ada_build_task_list.
7989         * ada-lang.h (ada_build_task_list): Don't declare.
7990         * ada-tasks.c (struct ada_tasks_inferior_data)
7991         <task_list_valid_p>: Now bool.
7992         (read_known_tasks, ada_task_list_changed)
7993         (ada_tasks_invalidate_inferior_data): Update.
7994         (read_known_tasks_array): Return bool.
7995         (read_known_tasks_list): Likewise.
7996         (read_known_tasks): Return void.
7997         (ada_build_task_list): Now static.
7998
7999 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8000
8001         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8002         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8003
8004 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8005
8006         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8007         variant for ada_tasks_pspace_data_handle and
8008         ada_tasks_inferior_data_handle.
8009         (ada_tasks_pspace_data_cleanup): New function.
8010         (ada_tasks_inferior_data_cleanup): New function.
8011
8012 2019-02-17  Tom Tromey  <tom@tromey.com>
8013
8014         * macrotab.h (macro_source_fullname): Return a std::string.
8015         * macrotab.c (macro_include, check_for_redefinition)
8016         (macro_undef, macro_lookup_definition, foreach_macro)
8017         (foreach_macro_in_scope): Update.
8018         (macro_source_fullname): Return a std::string.
8019         * macrocmd.c (show_pp_source_pos): Update.
8020
8021 2019-02-17  Tom Tromey  <tom@tromey.com>
8022
8023         * macrocmd.c (show_pp_source_pos): Style the file names.
8024
8025 2019-02-17  Tom Tromey  <tom@tromey.com>
8026
8027         PR tui/24197:
8028         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8029
8030 2019-02-17  Tom Tromey  <tom@tromey.com>
8031
8032         * ada-lang.c (user_select_syms): Use filtered printing.
8033         * utils.c (wrap_style): New global.
8034         (desired_style): Remove.
8035         (emit_style_escape): Add stream parameter.
8036         (set_output_style, reset_terminal_style, prompt_for_continue):
8037         Update.
8038         (flush_wrap_buffer): Only flush gdb_stdout.
8039         (wrap_here): Set wrap_style.
8040         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8041         treat escape sequences as a character.  Change when wrap buffer is
8042         flushed.
8043         (fputs_styled): Do not set the output style when the default is
8044         requested.
8045         * ui-style.h (struct ui_file_style) <is_default>: New method.
8046         * source.c (print_source_lines_base): Emit escape sequences in one
8047         piece.
8048
8049 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8050
8051         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8052         integers and enumeration types.
8053
8054 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8055
8056         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8057         instead of lookup_symbol_in_language
8058         (do_exact_match): New function.
8059         (ada_get_symbol_name_matcher): Return do_exact_match when
8060         doing a verbatim match.
8061
8062 2019-02-15  Tom Tromey  <tromey@adacore.com>
8063
8064         * ravenscar-thread.c (ravenscar_thread_target::resume)
8065         (ravenscar_thread_target::wait): Special case wildcard requests.
8066
8067 2019-02-15  Tom Tromey  <tromey@adacore.com>
8068
8069         * ravenscar-thread.c (base_ptid): Remove.
8070         (struct ravenscar_thread_target) <close>: New method.
8071         <m_base_ptid>: New member.
8072         <update_inferior_ptid, active_task, task_is_currently_active,
8073         runtime_initialized>: Declare methods.
8074         <ravenscar_thread_target>: Add constructor.
8075         (ravenscar_thread_target::task_is_currently_active)
8076         (ravenscar_thread_target::update_inferior_ptid)
8077         (ravenscar_runtime_initialized): Rename.  Now methods.
8078         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8079         (ravenscar_thread_target::update_thread_list): Update.
8080         (ravenscar_thread_target::active_task): Now method.
8081         (ravenscar_thread_target::store_registers)
8082         (ravenscar_thread_target::prepare_to_store)
8083         (ravenscar_thread_target::prepare_to_store)
8084         (ravenscar_thread_target::mourn_inferior): Update.
8085         (ravenscar_inferior_created): Use "new" to create target.
8086         (ravenscar_thread_target::get_ada_task_ptid): Update.
8087         (_initialize_ravenscar): Don't initialize base_ptid.
8088         (ravenscar_ops): Remove global.
8089
8090 2019-02-15  Tom Tromey  <tromey@adacore.com>
8091
8092         * target.h (push_target): Declare new overload.
8093         * target.c (push_target): New overload, taking an rvalue reference.
8094         * remote.c (remote_target::open_1): Use push_target overload.
8095         * corelow.c (core_target_open): Use push_target overload.
8096
8097 2019-02-15  Tom Tromey  <tromey@adacore.com>
8098
8099         * ravenscar-thread.c (is_ravenscar_task)
8100         (ravenscar_task_is_currently_active): Return bool.
8101         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8102         (_initialize_ravenscar): Remove "(void)".
8103         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8104         Return bool.
8105
8106 2019-02-15  Tom Tromey  <tromey@adacore.com>
8107
8108         * ravenscar-thread.c (ravenscar_runtime_initializer)
8109         (has_ravenscar_runtime, get_running_thread_id)
8110         (ravenscar_thread_target::resume): Fix indentation.
8111
8112 2019-02-15  Tom Tromey  <tromey@adacore.com>
8113
8114         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8115         from ravenscar_arch_ops.
8116         (sparc_ravenscar_ops::fetch_registers)
8117         (sparc_ravenscar_ops::store_registers): Now methods.
8118         (sparc_ravenscar_prepare_to_store): Remove.
8119         (sparc_ravenscar_ops): Redefine.
8120         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8121         methods and destructor.  Remove members.
8122         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8123         (ravenscar_thread_target::store_registers)
8124         (ravenscar_thread_target::prepare_to_store): Update.
8125         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8126         Remove.
8127         (struct ppc_ravenscar_powerpc_ops): Derive from
8128         ravenscar_arch_ops.
8129         (ppc_ravenscar_powerpc_ops::fetch_registers)
8130         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8131         (ppc_ravenscar_powerpc_ops): Redefine.
8132         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8133         (ppc_ravenscar_e500_ops::fetch_registers)
8134         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8135         (ppc_ravenscar_e500_ops): Redefine.
8136         * aarch64-ravenscar-thread.c
8137         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8138         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8139         (aarch64_ravenscar_fetch_registers)
8140         (aarch64_ravenscar_store_registers): Now methods.
8141         (aarch64_ravenscar_ops): Redefine.
8142
8143 2019-02-15  Tom Tromey  <tromey@adacore.com>
8144
8145         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8146         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8147         (ravenscar_thread_target::stopped_by_watchpoint)
8148         (ravenscar_thread_target::stopped_data_address)
8149         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8150
8151 2019-02-15  Tom Tromey  <tromey@adacore.com>
8152
8153         * ravenscar-thread.c: Fix some typos.
8154
8155 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8156             Tom Tromey  <tromey@adacore.com>
8157
8158         * ada-lang.c (ada_exception_sal): Change addr_string to a
8159         std::string.
8160         (create_ada_exception_catchpoint): Update.
8161
8162 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8163             Tom Tromey  <tromey@adacore.com>
8164
8165         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8166         (bp_location_ops): Remove.
8167         (base_breakpoint_allocate_location): Update.
8168         (free_bp_location): Update.
8169         * ada-lang.c (class ada_catchpoint_location)
8170         <ada_catchpoint_location>: Remove ops parameter.
8171         (ada_catchpoint_location_dtor): Remove.
8172         (ada_catchpoint_location_ops): Remove.
8173         (allocate_location_exception): Update.
8174         * breakpoint.h (struct bp_location_ops): Remove.
8175         (class bp_location) <bp_location>: Remove bp_location_ops
8176         parameter.
8177         <~bp_location>: Add destructor.
8178         <ops>: Remove.
8179
8180 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8181             Pedro Alves  <palves@redhat.com>
8182
8183         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8184         'PATH_MAX'.
8185
8186 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8187             Samuel Thibault  <samuel.thibault@gnu.org>
8188             Thomas Schwinge  <thomas@codesourcery.com>
8189
8190         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8191         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8192
8193 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8194
8195         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8196         (check_empty): Use "const char *".
8197
8198         * gnu-nat.c (gnu_nat_target::detach): Instead of
8199         'detach_inferior (pid)' call
8200         'detach_inferior (find_inferior_pid (pid))'.
8201
8202         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8203         'nat/fork-inferior.o'.
8204         * gnu-nat.c: #include "nat/fork-inferior.h".
8205
8206         * gnu-nat.c (gnu_nat_target::detach): Instead of
8207         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8208         * gnu-nat.h: #include "inf-child.h".
8209         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8210         'i386_gnu_nat_target::fetch_registers'.
8211         (gnu_store_registers): Rename/move to
8212         'i386_gnu_nat_target::store_registers'.
8213
8214         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8215         * gnu-nat.h (mach_thread_info): New function.
8216         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8217
8218         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8219
8220 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8221
8222         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8223
8224 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8225
8226         * windows-nat.c (windows_add_thread): Add new parameter
8227         "main_thread_p" with default value set to false.  Update
8228         function documentation as well as all callers.
8229         (windows_delete_thread): Likewise.
8230         (fake_create_process): Update call to windows_add_thread.
8231         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8232         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8233         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8234         call to windows_delete_thread.
8235
8236 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8237
8238         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8239
8240 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8241
8242         * symfile.c (find_separate_debug_file): Use canonical path of
8243         sysroot with child_path instead of gdb_sysroot if it is valid.
8244
8245 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8246
8247         * symfile.c (find_separate_debug_file): Use child_path to
8248         determine if an object file is under a sysroot.
8249
8250 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8251
8252         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8253         unittests/child-path-selftests.c.
8254         * common/pathstuff.c (child_path): New function.
8255         * common/pathstuff.h (child_path): New prototype.
8256         * unittests/child-path-selftests.c: New file.
8257
8258 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8259
8260         * symfile.c (find_separate_debug_file): Look for separate debug
8261         files in debug directories under the sysroot.
8262
8263 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8264
8265         * symtab.h (struct minimal_symbol data_p): New const method.
8266         (struct minimal_symbol text_p): Likewise.
8267         * symtab.c (output_source_filename): Use file name style
8268         to print file name.
8269         (print_symbol_info): Likewise.
8270         (print_msymbol_info): Use address style to print addresses.
8271         Use function name style to print executable text symbols.
8272         (expand_symtab_containing_pc): Use data_p.
8273         (find_pc_sect_compunit_symtab): Likewise.
8274
8275 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8276
8277         * breakpoint.c (describe_other_breakpoints): Use address style
8278         to print addresses.
8279         (say_where): Likewise.
8280
8281 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8282
8283         * ada-typeprint.c (print_func_type): Print function name
8284         style to print function name.
8285         * c-typeprint.c (c_print_type_1): Likewise.
8286
8287 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8288
8289         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8290         for execve.
8291
8292 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8293
8294         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8295         type_stack.
8296
8297 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8298
8299         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8300         TYPE_CODE_REF types.
8301
8302 2019-02-08  Jim Wilson  <jimw@sifive.com>
8303
8304         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8305         (riscv_linux_fregset): New.
8306         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8307
8308 2019-02-07  Tom Tromey  <tom@tromey.com>
8309
8310         * thread.c (thread_cancel_execution_command): Update.
8311         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8312         methods.
8313         (struct thread_fsm_ops): Remove.
8314         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8315         (thread_fsm_should_stop, thread_fsm_return_value)
8316         (thread_fsm_set_finished, thread_fsm_finished_p)
8317         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8318         Don't declare.
8319         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8320         * infrun.c (clear_proceed_status_thread)
8321         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8322         (print_stop_event): Update.
8323         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8324         Add constructor.
8325         (step_command_fsm_ops): Remove.
8326         (new_step_command_fsm): Remove.
8327         (step_1): Update.
8328         (step_command_fsm::should_stop): Rename from
8329         step_command_fsm_should_stop.
8330         (step_command_fsm::clean_up): Rename from
8331         step_command_fsm_clean_up.
8332         (step_command_fsm::do_async_reply_reason): Rename from
8333         step_command_fsm_async_reply_reason.
8334         (struct until_next_fsm): Inherit from thread_fsm.  Add
8335         constructor.
8336         (until_next_fsm_ops): Remove.
8337         (new_until_next_fsm): Remove.
8338         (until_next_fsm::should_stop): Rename from
8339         until_next_fsm_should_stop.
8340         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8341         (until_next_fsm::do_async_reply_reason): Rename from
8342         until_next_fsm_async_reply_reason.
8343         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8344         constructor.  Change type of breakpoint.
8345         (finish_command_fsm_ops): Remove.
8346         (new_finish_command_fsm): Remove.
8347         (finish_command_fsm::should_stop): Rename from
8348         finish_command_fsm_should_stop.
8349         (finish_command_fsm::clean_up): Rename from
8350         finish_command_fsm_clean_up.
8351         (finish_command_fsm::return_value): Rename from
8352         finish_command_fsm_return_value.
8353         (finish_command_fsm::do_async_reply_reason): Rename from
8354         finish_command_fsm_async_reply_reason.
8355         (finish_command): Update.
8356         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8357         Add constructor.
8358         (call_thread_fsm_ops): Remove.
8359         (call_thread_fsm::call_thread_fsm): Rename from
8360         new_call_thread_fsm.
8361         (call_thread_fsm::should_stop): Rename from
8362         call_thread_fsm_should_stop.
8363         (call_thread_fsm::should_notify_stop): Rename from
8364         call_thread_fsm_should_notify_stop.
8365         (run_inferior_call, call_function_by_hand_dummy): Update.
8366         * cli/cli-interp.c (should_print_stop_to_console): Update.
8367         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8368         Add constructor.  Change type of location_breakpoint,
8369         caller_breakpoint.
8370         (until_break_fsm_ops): Remove.
8371         (new_until_break_fsm): Remove.
8372         (until_break_fsm::should_stop): Rename from
8373         until_break_fsm_should_stop.
8374         (until_break_fsm::clean_up): Rename from
8375         until_break_fsm_clean_up.
8376         (until_break_fsm::do_async_reply_reason): Rename from
8377         until_break_fsm_async_reply_reason.
8378         (until_break_command): Update.
8379         * thread-fsm.c: Remove.
8380         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8381
8382 2019-02-07  Tom Tromey  <tom@tromey.com>
8383
8384         * yy-remap.h: Add include guard.
8385         * xtensa-tdep.h: Add include guard.
8386         * xcoffread.h: Rename include guard.
8387         * varobj-iter.h: Add include guard.
8388         * tui/tui.h: Rename include guard.
8389         * tui/tui-winsource.h: Rename include guard.
8390         * tui/tui-wingeneral.h: Rename include guard.
8391         * tui/tui-windata.h: Rename include guard.
8392         * tui/tui-win.h: Rename include guard.
8393         * tui/tui-stack.h: Rename include guard.
8394         * tui/tui-source.h: Rename include guard.
8395         * tui/tui-regs.h: Rename include guard.
8396         * tui/tui-out.h: Rename include guard.
8397         * tui/tui-layout.h: Rename include guard.
8398         * tui/tui-io.h: Rename include guard.
8399         * tui/tui-hooks.h: Rename include guard.
8400         * tui/tui-file.h: Rename include guard.
8401         * tui/tui-disasm.h: Rename include guard.
8402         * tui/tui-data.h: Rename include guard.
8403         * tui/tui-command.h: Rename include guard.
8404         * tic6x-tdep.h: Add include guard.
8405         * target/waitstatus.h: Rename include guard.
8406         * target/wait.h: Rename include guard.
8407         * target/target.h: Rename include guard.
8408         * target/resume.h: Rename include guard.
8409         * target-float.h: Rename include guard.
8410         * stabsread.h: Add include guard.
8411         * rs6000-tdep.h: Add include guard.
8412         * riscv-fbsd-tdep.h: Add include guard.
8413         * regformats/regdef.h: Rename include guard.
8414         * record.h: Rename include guard.
8415         * python/python.h: Rename include guard.
8416         * python/python-internal.h: Rename include guard.
8417         * python/py-stopevent.h: Rename include guard.
8418         * python/py-ref.h: Rename include guard.
8419         * python/py-record.h: Rename include guard.
8420         * python/py-record-full.h: Rename include guard.
8421         * python/py-record-btrace.h: Rename include guard.
8422         * python/py-instruction.h: Rename include guard.
8423         * python/py-events.h: Rename include guard.
8424         * python/py-event.h: Rename include guard.
8425         * procfs.h: Add include guard.
8426         * proc-utils.h: Add include guard.
8427         * p-lang.h: Add include guard.
8428         * or1k-tdep.h: Rename include guard.
8429         * observable.h: Rename include guard.
8430         * nto-tdep.h: Rename include guard.
8431         * nat/x86-linux.h: Rename include guard.
8432         * nat/x86-linux-dregs.h: Rename include guard.
8433         * nat/x86-gcc-cpuid.h: Add include guard.
8434         * nat/x86-dregs.h: Rename include guard.
8435         * nat/x86-cpuid.h: Rename include guard.
8436         * nat/ppc-linux.h: Rename include guard.
8437         * nat/mips-linux-watch.h: Rename include guard.
8438         * nat/linux-waitpid.h: Rename include guard.
8439         * nat/linux-ptrace.h: Rename include guard.
8440         * nat/linux-procfs.h: Rename include guard.
8441         * nat/linux-osdata.h: Rename include guard.
8442         * nat/linux-nat.h: Rename include guard.
8443         * nat/linux-namespaces.h: Rename include guard.
8444         * nat/linux-btrace.h: Rename include guard.
8445         * nat/glibc_thread_db.h: Rename include guard.
8446         * nat/gdb_thread_db.h: Rename include guard.
8447         * nat/gdb_ptrace.h: Rename include guard.
8448         * nat/fork-inferior.h: Rename include guard.
8449         * nat/amd64-linux-siginfo.h: Rename include guard.
8450         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8451         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8452         * nat/aarch64-linux.h: Rename include guard.
8453         * nat/aarch64-linux-hw-point.h: Rename include guard.
8454         * mn10300-tdep.h: Add include guard.
8455         * mips-linux-tdep.h: Add include guard.
8456         * mi/mi-parse.h: Rename include guard.
8457         * mi/mi-out.h: Rename include guard.
8458         * mi/mi-main.h: Rename include guard.
8459         * mi/mi-interp.h: Rename include guard.
8460         * mi/mi-getopt.h: Rename include guard.
8461         * mi/mi-console.h: Rename include guard.
8462         * mi/mi-common.h: Rename include guard.
8463         * mi/mi-cmds.h: Rename include guard.
8464         * mi/mi-cmd-break.h: Rename include guard.
8465         * m2-lang.h: Add include guard.
8466         * location.h: Rename include guard.
8467         * linux-record.h: Rename include guard.
8468         * linux-nat.h: Add include guard.
8469         * linux-fork.h: Add include guard.
8470         * i386-darwin-tdep.h: Rename include guard.
8471         * hppa-linux-offsets.h: Add include guard.
8472         * guile/guile.h: Rename include guard.
8473         * guile/guile-internal.h: Rename include guard.
8474         * gnu-nat.h: Rename include guard.
8475         * gdb-stabs.h: Rename include guard.
8476         * frv-tdep.h: Add include guard.
8477         * f-lang.h: Add include guard.
8478         * event-loop.h: Add include guard.
8479         * darwin-nat.h: Rename include guard.
8480         * cp-abi.h: Rename include guard.
8481         * config/sparc/nm-sol2.h: Rename include guard.
8482         * config/nm-nto.h: Rename include guard.
8483         * config/nm-linux.h: Add include guard.
8484         * config/i386/nm-i386gnu.h: Rename include guard.
8485         * config/djgpp/nl_types.h: Rename include guard.
8486         * config/djgpp/langinfo.h: Rename include guard.
8487         * compile/gcc-cp-plugin.h: Add include guard.
8488         * compile/gcc-c-plugin.h: Add include guard.
8489         * compile/compile.h: Rename include guard.
8490         * compile/compile-object-run.h: Rename include guard.
8491         * compile/compile-object-load.h: Rename include guard.
8492         * compile/compile-internal.h: Rename include guard.
8493         * compile/compile-cplus.h: Rename include guard.
8494         * compile/compile-c.h: Rename include guard.
8495         * common/xml-utils.h: Rename include guard.
8496         * common/x86-xstate.h: Rename include guard.
8497         * common/version.h: Rename include guard.
8498         * common/vec.h: Rename include guard.
8499         * common/tdesc.h: Rename include guard.
8500         * common/selftest.h: Rename include guard.
8501         * common/scoped_restore.h: Rename include guard.
8502         * common/scoped_mmap.h: Rename include guard.
8503         * common/scoped_fd.h: Rename include guard.
8504         * common/safe-iterator.h: Rename include guard.
8505         * common/run-time-clock.h: Rename include guard.
8506         * common/refcounted-object.h: Rename include guard.
8507         * common/queue.h: Rename include guard.
8508         * common/ptid.h: Rename include guard.
8509         * common/print-utils.h: Rename include guard.
8510         * common/preprocessor.h: Rename include guard.
8511         * common/pathstuff.h: Rename include guard.
8512         * common/observable.h: Rename include guard.
8513         * common/netstuff.h: Rename include guard.
8514         * common/job-control.h: Rename include guard.
8515         * common/host-defs.h: Rename include guard.
8516         * common/gdb_wait.h: Rename include guard.
8517         * common/gdb_vecs.h: Rename include guard.
8518         * common/gdb_unlinker.h: Rename include guard.
8519         * common/gdb_unique_ptr.h: Rename include guard.
8520         * common/gdb_tilde_expand.h: Rename include guard.
8521         * common/gdb_sys_time.h: Rename include guard.
8522         * common/gdb_string_view.h: Rename include guard.
8523         * common/gdb_splay_tree.h: Rename include guard.
8524         * common/gdb_setjmp.h: Rename include guard.
8525         * common/gdb_ref_ptr.h: Rename include guard.
8526         * common/gdb_optional.h: Rename include guard.
8527         * common/gdb_locale.h: Rename include guard.
8528         * common/gdb_assert.h: Rename include guard.
8529         * common/filtered-iterator.h: Rename include guard.
8530         * common/filestuff.h: Rename include guard.
8531         * common/fileio.h: Rename include guard.
8532         * common/environ.h: Rename include guard.
8533         * common/common-utils.h: Rename include guard.
8534         * common/common-types.h: Rename include guard.
8535         * common/common-regcache.h: Rename include guard.
8536         * common/common-inferior.h: Rename include guard.
8537         * common/common-gdbthread.h: Rename include guard.
8538         * common/common-exceptions.h: Rename include guard.
8539         * common/common-defs.h: Rename include guard.
8540         * common/common-debug.h: Rename include guard.
8541         * common/cleanups.h: Rename include guard.
8542         * common/buffer.h: Rename include guard.
8543         * common/btrace-common.h: Rename include guard.
8544         * common/break-common.h: Rename include guard.
8545         * cli/cli-utils.h: Rename include guard.
8546         * cli/cli-style.h: Rename include guard.
8547         * cli/cli-setshow.h: Rename include guard.
8548         * cli/cli-script.h: Rename include guard.
8549         * cli/cli-interp.h: Rename include guard.
8550         * cli/cli-decode.h: Rename include guard.
8551         * cli/cli-cmds.h: Rename include guard.
8552         * charset-list.h: Add include guard.
8553         * buildsym-legacy.h: Rename include guard.
8554         * bfin-tdep.h: Add include guard.
8555         * ax.h: Rename include guard.
8556         * arm-linux-tdep.h: Add include guard.
8557         * arm-fbsd-tdep.h: Add include guard.
8558         * arch/xtensa.h: Rename include guard.
8559         * arch/tic6x.h: Add include guard.
8560         * arch/i386.h: Add include guard.
8561         * arch/arm.h: Rename include guard.
8562         * arch/arm-linux.h: Rename include guard.
8563         * arch/arm-get-next-pcs.h: Rename include guard.
8564         * arch/amd64.h: Add include guard.
8565         * arch/aarch64-insn.h: Rename include guard.
8566         * arch-utils.h: Rename include guard.
8567         * annotate.h: Add include guard.
8568         * amd64-darwin-tdep.h: Rename include guard.
8569         * aarch64-linux-tdep.h: Add include guard.
8570         * aarch64-fbsd-tdep.h: Add include guard.
8571         * aarch32-linux-nat.h: Add include guard.
8572
8573 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8574
8575         * macrotab.c (macro_define_internal): New function that
8576         factorizes macro_define_object_internal and macro_define_function
8577         code.
8578         (macro_define_object_internal): Use macro_define_internal.
8579         (macro_define_function): Likewise.
8580
8581 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8582
8583         * macrocmd.c (extract_identifier): Return
8584         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8585         callers.
8586
8587 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8588
8589         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8590
8591 2019-02-05  Tom Tromey  <tom@tromey.com>
8592
8593         * target.c (target_stack::unpush): Move assertion earlier.
8594
8595 2019-01-30  Tom Tromey  <tom@tromey.com>
8596
8597         PR python/23615:
8598         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8599         (gdbpy_parse_and_eval): Likewise.
8600         * python/python-internal.h (gdbpy_allow_threads): New class.
8601
8602 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8603
8604         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8605         (aarch64_fbsd_fpregmap): Move earlier.
8606         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8607         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8608         instead of individual calls to trad_frame_set_reg_addr.
8609         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8610         earlier.
8611         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8612         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8613         instead of individual calls to trad_frame_set_reg_addr.
8614
8615 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8616
8617         * CONTRIBUTE: Replace contribution list with wiki link.
8618
8619 2019-01-25  Tom Tromey  <tom@tromey.com>
8620
8621         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8622
8623 2019-01-25  Tom Tromey  <tom@tromey.com>
8624
8625         * xtensa-linux-nat.c: Fix common/ includes.
8626         * xml-support.h: Fix common/ includes.
8627         * xml-support.c: Fix common/ includes.
8628         * x86-linux-nat.c: Fix common/ includes.
8629         * windows-nat.c: Fix common/ includes.
8630         * varobj.h: Fix common/ includes.
8631         * varobj.c: Fix common/ includes.
8632         * value.c: Fix common/ includes.
8633         * valops.c: Fix common/ includes.
8634         * utils.c: Fix common/ includes.
8635         * unittests/xml-utils-selftests.c: Fix common/ includes.
8636         * unittests/utils-selftests.c: Fix common/ includes.
8637         * unittests/unpack-selftests.c: Fix common/ includes.
8638         * unittests/tracepoint-selftests.c: Fix common/ includes.
8639         * unittests/style-selftests.c: Fix common/ includes.
8640         * unittests/string_view-selftests.c: Fix common/ includes.
8641         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8642         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8643         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8644         * unittests/rsp-low-selftests.c: Fix common/ includes.
8645         * unittests/parse-connection-spec-selftests.c: Fix common/
8646         includes.
8647         * unittests/optional-selftests.c: Fix common/ includes.
8648         * unittests/offset-type-selftests.c: Fix common/ includes.
8649         * unittests/observable-selftests.c: Fix common/ includes.
8650         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8651         * unittests/memrange-selftests.c: Fix common/ includes.
8652         * unittests/memory-map-selftests.c: Fix common/ includes.
8653         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8654         * unittests/function-view-selftests.c: Fix common/ includes.
8655         * unittests/environ-selftests.c: Fix common/ includes.
8656         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8657         * unittests/common-utils-selftests.c: Fix common/ includes.
8658         * unittests/cli-utils-selftests.c: Fix common/ includes.
8659         * unittests/array-view-selftests.c: Fix common/ includes.
8660         * ui-file.c: Fix common/ includes.
8661         * tui/tui-io.c: Fix common/ includes.
8662         * tracepoint.h: Fix common/ includes.
8663         * tracepoint.c: Fix common/ includes.
8664         * tracefile-tfile.c: Fix common/ includes.
8665         * top.h: Fix common/ includes.
8666         * top.c: Fix common/ includes.
8667         * thread.c: Fix common/ includes.
8668         * target/waitstatus.h: Fix common/ includes.
8669         * target/waitstatus.c: Fix common/ includes.
8670         * target.h: Fix common/ includes.
8671         * target.c: Fix common/ includes.
8672         * target-memory.c: Fix common/ includes.
8673         * target-descriptions.c: Fix common/ includes.
8674         * symtab.h: Fix common/ includes.
8675         * symfile.c: Fix common/ includes.
8676         * stap-probe.c: Fix common/ includes.
8677         * spu-linux-nat.c: Fix common/ includes.
8678         * sparc-nat.c: Fix common/ includes.
8679         * source.c: Fix common/ includes.
8680         * solib.c: Fix common/ includes.
8681         * solib-target.c: Fix common/ includes.
8682         * ser-unix.c: Fix common/ includes.
8683         * ser-tcp.c: Fix common/ includes.
8684         * ser-pipe.c: Fix common/ includes.
8685         * ser-base.c: Fix common/ includes.
8686         * selftest-arch.c: Fix common/ includes.
8687         * s12z-tdep.c: Fix common/ includes.
8688         * rust-exp.y: Fix common/ includes.
8689         * rs6000-aix-tdep.c: Fix common/ includes.
8690         * riscv-tdep.c: Fix common/ includes.
8691         * remote.c: Fix common/ includes.
8692         * remote-notif.h: Fix common/ includes.
8693         * remote-fileio.h: Fix common/ includes.
8694         * remote-fileio.c: Fix common/ includes.
8695         * regcache.h: Fix common/ includes.
8696         * regcache.c: Fix common/ includes.
8697         * record-btrace.c: Fix common/ includes.
8698         * python/python.c: Fix common/ includes.
8699         * python/py-type.c: Fix common/ includes.
8700         * python/py-inferior.c: Fix common/ includes.
8701         * progspace.h: Fix common/ includes.
8702         * producer.c: Fix common/ includes.
8703         * procfs.c: Fix common/ includes.
8704         * proc-api.c: Fix common/ includes.
8705         * printcmd.c: Fix common/ includes.
8706         * ppc-linux-nat.c: Fix common/ includes.
8707         * parser-defs.h: Fix common/ includes.
8708         * osdata.c: Fix common/ includes.
8709         * obsd-nat.c: Fix common/ includes.
8710         * nat/x86-linux.c: Fix common/ includes.
8711         * nat/x86-linux-dregs.c: Fix common/ includes.
8712         * nat/x86-dregs.h: Fix common/ includes.
8713         * nat/x86-dregs.c: Fix common/ includes.
8714         * nat/ppc-linux.c: Fix common/ includes.
8715         * nat/mips-linux-watch.h: Fix common/ includes.
8716         * nat/mips-linux-watch.c: Fix common/ includes.
8717         * nat/linux-waitpid.c: Fix common/ includes.
8718         * nat/linux-ptrace.h: Fix common/ includes.
8719         * nat/linux-ptrace.c: Fix common/ includes.
8720         * nat/linux-procfs.c: Fix common/ includes.
8721         * nat/linux-personality.c: Fix common/ includes.
8722         * nat/linux-osdata.c: Fix common/ includes.
8723         * nat/linux-namespaces.c: Fix common/ includes.
8724         * nat/linux-btrace.h: Fix common/ includes.
8725         * nat/linux-btrace.c: Fix common/ includes.
8726         * nat/fork-inferior.c: Fix common/ includes.
8727         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8728         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8729         * nat/aarch64-linux.c: Fix common/ includes.
8730         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8731         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8732         * namespace.h: Fix common/ includes.
8733         * mips-linux-tdep.c: Fix common/ includes.
8734         * minsyms.c: Fix common/ includes.
8735         * mi/mi-parse.h: Fix common/ includes.
8736         * mi/mi-main.c: Fix common/ includes.
8737         * mi/mi-cmd-env.c: Fix common/ includes.
8738         * memrange.h: Fix common/ includes.
8739         * memattr.c: Fix common/ includes.
8740         * maint.h: Fix common/ includes.
8741         * maint.c: Fix common/ includes.
8742         * main.c: Fix common/ includes.
8743         * machoread.c: Fix common/ includes.
8744         * location.c: Fix common/ includes.
8745         * linux-thread-db.c: Fix common/ includes.
8746         * linux-nat.c: Fix common/ includes.
8747         * linux-fork.c: Fix common/ includes.
8748         * inline-frame.c: Fix common/ includes.
8749         * infrun.c: Fix common/ includes.
8750         * inflow.c: Fix common/ includes.
8751         * inferior.h: Fix common/ includes.
8752         * inferior.c: Fix common/ includes.
8753         * infcmd.c: Fix common/ includes.
8754         * inf-ptrace.c: Fix common/ includes.
8755         * inf-child.c: Fix common/ includes.
8756         * ia64-linux-nat.c: Fix common/ includes.
8757         * i387-tdep.c: Fix common/ includes.
8758         * i386-tdep.c: Fix common/ includes.
8759         * i386-linux-tdep.c: Fix common/ includes.
8760         * i386-linux-nat.c: Fix common/ includes.
8761         * i386-go32-tdep.c: Fix common/ includes.
8762         * i386-fbsd-tdep.c: Fix common/ includes.
8763         * i386-fbsd-nat.c: Fix common/ includes.
8764         * guile/scm-type.c: Fix common/ includes.
8765         * guile/guile.c: Fix common/ includes.
8766         * go32-nat.c: Fix common/ includes.
8767         * gnu-nat.c: Fix common/ includes.
8768         * gdbthread.h: Fix common/ includes.
8769         * gdbarch-selftests.c: Fix common/ includes.
8770         * gdb_usleep.c: Fix common/ includes.
8771         * gdb_select.h: Fix common/ includes.
8772         * gdb_bfd.c: Fix common/ includes.
8773         * gcore.c: Fix common/ includes.
8774         * fork-child.c: Fix common/ includes.
8775         * findvar.c: Fix common/ includes.
8776         * fbsd-nat.c: Fix common/ includes.
8777         * event-top.c: Fix common/ includes.
8778         * event-loop.c: Fix common/ includes.
8779         * dwarf2read.c: Fix common/ includes.
8780         * dwarf2loc.c: Fix common/ includes.
8781         * dwarf2-frame.c: Fix common/ includes.
8782         * dwarf-index-cache.c: Fix common/ includes.
8783         * dtrace-probe.c: Fix common/ includes.
8784         * disasm-selftests.c: Fix common/ includes.
8785         * defs.h: Fix common/ includes.
8786         * csky-tdep.c: Fix common/ includes.
8787         * cp-valprint.c: Fix common/ includes.
8788         * cp-support.h: Fix common/ includes.
8789         * cp-support.c: Fix common/ includes.
8790         * corelow.c: Fix common/ includes.
8791         * completer.h: Fix common/ includes.
8792         * completer.c: Fix common/ includes.
8793         * compile/compile.c: Fix common/ includes.
8794         * compile/compile-loc2c.c: Fix common/ includes.
8795         * compile/compile-cplus-types.c: Fix common/ includes.
8796         * compile/compile-cplus-symbols.c: Fix common/ includes.
8797         * command.h: Fix common/ includes.
8798         * cli/cli-dump.c: Fix common/ includes.
8799         * cli/cli-cmds.c: Fix common/ includes.
8800         * charset.c: Fix common/ includes.
8801         * build-id.c: Fix common/ includes.
8802         * btrace.h: Fix common/ includes.
8803         * btrace.c: Fix common/ includes.
8804         * breakpoint.h: Fix common/ includes.
8805         * breakpoint.c: Fix common/ includes.
8806         * ax.h:
8807         (enum agent_op): Fix common/ includes.
8808         * ax-general.c (struct aop_map): Fix common/ includes.
8809         * ax-gdb.c: Fix common/ includes.
8810         * auxv.c: Fix common/ includes.
8811         * auto-load.c: Fix common/ includes.
8812         * arm-tdep.c: Fix common/ includes.
8813         * arch/riscv.c: Fix common/ includes.
8814         * arch/ppc-linux-common.c: Fix common/ includes.
8815         * arch/i386.c: Fix common/ includes.
8816         * arch/arm.c: Fix common/ includes.
8817         * arch/arm-linux.c: Fix common/ includes.
8818         * arch/arm-get-next-pcs.c: Fix common/ includes.
8819         * arch/amd64.c: Fix common/ includes.
8820         * arch/aarch64.c: Fix common/ includes.
8821         * arch/aarch64-insn.c: Fix common/ includes.
8822         * arch-utils.c: Fix common/ includes.
8823         * amd64-windows-tdep.c: Fix common/ includes.
8824         * amd64-tdep.c: Fix common/ includes.
8825         * amd64-sol2-tdep.c: Fix common/ includes.
8826         * amd64-obsd-tdep.c: Fix common/ includes.
8827         * amd64-nbsd-tdep.c: Fix common/ includes.
8828         * amd64-linux-tdep.c: Fix common/ includes.
8829         * amd64-linux-nat.c: Fix common/ includes.
8830         * amd64-fbsd-tdep.c: Fix common/ includes.
8831         * amd64-fbsd-nat.c: Fix common/ includes.
8832         * amd64-dicos-tdep.c: Fix common/ includes.
8833         * amd64-darwin-tdep.c: Fix common/ includes.
8834         * agent.c: Fix common/ includes.
8835         * ada-lang.h: Fix common/ includes.
8836         * ada-lang.c: Fix common/ includes.
8837         * aarch64-tdep.c: Fix common/ includes.
8838
8839 2019-01-25  Tom Tromey  <tom@tromey.com>
8840
8841         * common/create-version.sh: Use common/version.h.
8842
8843 2019-01-24  Pedro Alves  <palves@redhat.com>
8844
8845         * infrun.c (signal_stop, signal_print, signal_program)
8846         (signal_catch, signal_pass): Now arrays instead of pointers.
8847         (update_signals_program_target, do_target_resume)
8848         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8849         * linux-nat.c (linux_nat_target::pass_signals)
8850         (linux_nat_target::create_inferior, linux_nat_target::attach):
8851         Adjust.
8852         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8853         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8854         * procfs.c (procfs_target::pass_signals): Adjust.
8855         * record-full.c (record_full_target::resume): Adjust.
8856         * remote.c (remote_target::pass_signals)
8857         (remote_target::program_signals): Adjust.
8858         * target-debug.h (target_debug_print_signals): Now takes a
8859         gdb::array_view as parameter.  Adjust.
8860         * target.h (target_ops) <pass_signals, program_signals>: Replace
8861         pointer and length parameters with gdb::array_view.
8862         (target_pass_signals, target_program_signals): Likewise.
8863         * target-delegates.c: Regenerate.
8864
8865 2019-01-24  Pedro Alves  <palves@redhat.com>
8866
8867         * common/forward-scope-exit.h
8868         (forward_scope_exit::forward_scope_exit): Pass arguments to
8869         m_bind_function directly, instead of creating a std::bind and
8870         copying that.
8871
8872 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8873
8874         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8875         for static members.
8876         (pass_in_v_vfp_candidate): Likewise.
8877
8878 2019-01-23  Tom Tromey  <tom@tromey.com>
8879             Pedro Alves  <palves@redhat.com>
8880
8881         * regcache.c (class regcache_invalidator): Remove.
8882         (regcache::raw_write): Use make_scope_exit.
8883
8884 2019-01-23  Tom Tromey  <tom@tromey.com>
8885
8886         * ui-out.h (class ui_out_emit_type): Update comment.
8887
8888 2019-01-23  Tom Tromey  <tom@tromey.com>
8889
8890         * infrun.c (fetch_inferior_event): Update comment.
8891
8892 2019-01-23  Tom Tromey  <tom@tromey.com>
8893             Pedro Alves  <palves@redhat.com>
8894
8895         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8896         parameter.
8897         (fetch_inferior_event): Use SCOPE_EXIT.
8898
8899
8900 2019-01-23  Tom Tromey  <tom@tromey.com>
8901             Pedro Alves  <palves@redhat.com>
8902
8903         * infrun.c (disable_thread_events): Delete.
8904         (stop_all_threads): Use SCOPE_EXIT.
8905
8906 2019-01-23  Tom Tromey  <tom@tromey.com>
8907             Pedro Alves  <palves@redhat.com>
8908
8909         * symfile.c: Include forward-scope-exit.h.
8910         (clear_symtab_users_cleanup): Replace forward declaration with
8911         a FORWARD_SCOPE_EXIT.
8912         (syms_from_objfile_1): Use the forward_scope_exit and
8913         gdb::optional instead of cleanup_function.
8914         (reread_symbols): Use the forward_scope_exit instead of
8915         cleanup_function.
8916         (clear_symtab_users_cleanup): Remove function.
8917
8918 2019-01-23  Tom Tromey  <tom@tromey.com>
8919             Pedro Alves  <palves@redhat.com>
8920
8921         * linux-nat.c: Include scope-exit.h.
8922         (cleanup_target_stop): Remove.
8923         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8924         SCOPE_EXIT.
8925
8926 2019-01-23  Tom Tromey  <tom@tromey.com>
8927             Pedro Alves  <palves@redhat.com>
8928
8929         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8930         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8931
8932 2019-01-23  Tom Tromey  <tom@tromey.com>
8933             Andrew Burgess  <andrew.burgess@embecosm.com>
8934             Pedro Alves  <palves@redhat.com>
8935
8936         * infrun.c (fetch_inferior_event): Use scope_exit.
8937         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8938         * top.c (execute_command): Use scope_exit.
8939         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8940         * utils.c (do_bpstat_clear_actions_cleanup)
8941         (make_bpstat_clear_actions_cleanup): Remove.
8942
8943 2019-01-23  Tom Tromey  <tom@tromey.com>
8944             Pedro Alves  <palves@redhat.com>
8945
8946         * infrun.c: Include "common/scope-exit.h"
8947         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8948         (wait_for_inferior): Use SCOPE_EXIT.
8949         (fetch_inferior_event): Use scope_exit.
8950
8951 2019-01-23  Tom Tromey  <tom@tromey.com>
8952             Pedro Alves  <palves@redhat.com>
8953
8954         * breakpoint.c (create_breakpoint): Remove cleanup.
8955
8956 2019-01-23  Tom Tromey  <tom@tromey.com>
8957             Andrew Burgess  <andrew.burgess@embecosm.com>
8958             Pedro Alves  <palves@redhat.com>
8959
8960 2019-01-23  Pedro Alves  <palves@redhat.com>
8961
8962         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8963
8964 2019-01-23  Pedro Alves  <palves@redhat.com>
8965             Andrew Burgess  <andrew.burgess@embecosm.com>
8966
8967         * gdbthread.h: Include "common/forward-scope-exit.h".
8968         (scoped_finish_thread_state): Redefine custom class in terms of
8969         forward_scope_exit.
8970
8971 2019-01-23  Pedro Alves  <palves@redhat.com>
8972             Andrew Burgess  <andrew.burgess@embecosm.com>
8973
8974         * common/forward-scope-exit.h: New file.
8975
8976 2019-01-23  Pedro Alves  <palves@redhat.com>
8977             Andrew Burgess  <andrew.burgess@embecosm.com>
8978             Tom Tromey  <tom@tromey.com>
8979
8980         * common/scope-exit.h: New file.
8981
8982 2019-01-23  Pedro Alves  <palves@redhat.com>
8983
8984         * common/preprocessor.h (ESC): Rename to ...
8985         (ESC_PARENS): ... this.
8986         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8987         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8988
8989 2019-01-23  Tom Tromey  <tom@tromey.com>
8990
8991         * language.h (class scoped_switch_to_sym_language_if_auto):
8992         Initialize m_lang in both cases.
8993
8994 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8995
8996         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8997         with XCNEW.
8998
8999 2019-01-22  Tom Tromey  <tom@tromey.com>
9000
9001         * corelow.c: Do not include sys/file.h.
9002
9003 2019-01-22  Tom Tromey  <tom@tromey.com>
9004
9005         * tui/tui-wingeneral.h: Include gdb_curses.h.
9006
9007 2019-01-22  Tom Tromey  <tom@tromey.com>
9008
9009         * source-cache.h (class source_cache) <get_source_lines,
9010         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9011
9012 2019-01-22  Tom Tromey  <tom@tromey.com>
9013
9014         * remote-fileio.h (struct remote_target): Declare.
9015
9016 2019-01-22  Tom Tromey  <tom@tromey.com>
9017
9018         * python/py-arch.c: Do not include py-ref.h.
9019         * python/py-bpevent.c: Do not include py-ref.h.
9020         * python/py-cmd.c: Do not include py-ref.h.
9021         * python/py-continueevent.c: Do not include py-ref.h.
9022         * python/py-event.h: Do not include py-ref.h.
9023         * python/py-evtregistry.c: Do not include py-ref.h.
9024         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9025         * python/py-frame.c: Do not include py-ref.h.
9026         * python/py-framefilter.c: Do not include py-ref.h.
9027         * python/py-function.c: Do not include py-ref.h.
9028         * python/py-infevents.c: Do not include py-ref.h.
9029         * python/py-linetable.c: Do not include py-ref.h.
9030         * python/py-objfile.c: Do not include py-ref.h.
9031         * python/py-param.c: Do not include py-ref.h.
9032         * python/py-prettyprint.c: Do not include py-ref.h.
9033         * python/py-progspace.c: Do not include py-ref.h.
9034         * python/py-symbol.c: Do not include py-ref.h.
9035         * python/py-symtab.c: Do not include py-ref.h.
9036         * python/py-type.c: Do not include py-ref.h.
9037         * python/py-unwind.c: Do not include py-ref.h.
9038         * python/py-utils.c: Do not include py-ref.h.
9039         * python/py-value.c: Do not include py-ref.h.
9040         * python/py-varobj.c: Do not include py-ref.h.
9041         * python/py-xmethods.c: Do not include py-ref.h.
9042         * python/python.c: Do not include py-ref.h.
9043         * varobj.c: Do not include py-ref.h.
9044
9045 2019-01-22  Tom Tromey  <tom@tromey.com>
9046
9047         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9048         keyword for bcache.
9049
9050 2019-01-22  Tom Tromey  <tom@tromey.com>
9051
9052         * compile/compile-cplus-types.c: Remove a comment by #include.
9053
9054 2019-01-22  Tom Tromey  <tom@tromey.com>
9055
9056         * compile/gcc-c-plugin.h: Include compile-internal.h.
9057
9058 2019-01-22  Tom Tromey  <tom@tromey.com>
9059
9060         * stabsread.c (EXTERN): Do not define.
9061         (symnum, next_symbol_text_func, processing_gcc_compilation)
9062         (within_function, global_sym_chain, global_stabs)
9063         (previous_stab_code, this_object_header_files)
9064         (n_this_object_header_files)
9065         (n_allocated_this_object_header_files): Define.
9066         * stabsread.h (EXTERN): Never define.  Use "extern".
9067
9068 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9069
9070         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9071         history_value.
9072
9073 2019-01-21  Tom Tromey  <tom@tromey.com>
9074
9075         * ui-out.c: Fix includes.
9076         * tui/tui-source.c: Fix includes.
9077         * target.c: Fix includes.
9078         * remote.c: Fix includes.
9079         * regcache.c: Fix includes.
9080         * python/py-block.c: Fix includes.
9081         * printcmd.c: Fix includes.
9082         * or1k-tdep.c: Fix includes.
9083         * mi/mi-main.c: Fix includes.
9084         * m32r-tdep.c: Fix includes.
9085         * csky-tdep.c: Fix includes.
9086         * compile/compile-cplus-types.c: Fix includes.
9087         * cli/cli-interp.c: Fix includes.
9088
9089 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9090
9091         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9092         for padding.
9093
9094 2019-01-16  Tom Tromey  <tom@tromey.com>
9095
9096         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9097         earlier.
9098         (struct objfile) <msymbols_range>: Move from top level.
9099         <msymbols>: New method.
9100         (class objfile_msymbols): Remove.
9101         * symtab.c (default_collect_symbol_completion_matches_break_on):
9102         Update.
9103         * symmisc.c (dump_msymbols): Update.
9104         * stabsread.c (scan_file_globals): Update.
9105         * objc-lang.c (info_selectors_command, info_classes_command)
9106         (find_methods): Update.
9107         * minsyms.c (find_solib_trampoline_target): Update.
9108         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9109         * coffread.c (coff_symfile_read): Update.
9110         * ada-lang.c (ada_lookup_simple_minsym)
9111         (ada_collect_symbol_completion_matches): Update.
9112
9113 2019-01-16  Tom Tromey  <tom@tromey.com>
9114
9115         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9116         type.  Remove no-argument constructor.
9117         <iterator::operator++>: Simplify.
9118         <begin>: Update.
9119         <end>: Use minimal_symbol_count.
9120
9121 2019-01-16  Tom Tromey  <tom@tromey.com>
9122
9123         * objfiles.h (struct objfile) <psymtabs>: New method.
9124         (class objfile_psymtabs): Remove.
9125         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9126         typedef.
9127         <range>: New method.
9128         (require_partial_symbols): Change return type.
9129         * psymtab.c (require_partial_symbols)
9130         (psym_expand_symtabs_matching): Update.
9131         * mdebugread.c (parse_partial_symbols): Update.
9132         * dbxread.c (dbx_end_psymtab): Update.
9133
9134 2019-01-15  Tom Tromey  <tom@tromey.com>
9135
9136         * symtab.c (lookup_objfile_from_block)
9137         (lookup_symbol_in_objfile_symtabs)
9138         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9139         (find_line_symtab, info_sources_command)
9140         (default_collect_symbol_completion_matches_break_on)
9141         (make_source_files_completion_list): Update.
9142         * symmisc.c (print_objfile_statistics, dump_objfile)
9143         (maintenance_print_symbols, maintenance_info_symtabs)
9144         (maintenance_check_symtabs, maintenance_info_line_tables):
9145         Update.
9146         * source.c (select_source_symtab)
9147         (forget_cached_source_info_for_objfile): Update.
9148         * objfiles.h (class objfile_compunits): Remove.
9149         (struct objfile) <compunits_range>: New typedef.
9150         (compunits): New method.
9151         * objfiles.c (objfile_relocate1): Update.
9152         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9153         * maint.c (count_symtabs_and_blocks): Update.
9154         * linespec.c (iterate_over_all_matching_symtabs): Update.
9155         * cp-support.c (add_symbol_overload_list_qualified): Update.
9156         * coffread.c (coff_symtab_read): Update.
9157         * ada-lang.c (add_nonlocal_symbols)
9158         (ada_collect_symbol_completion_matches)
9159         (ada_add_global_exceptions): Update.
9160
9161 2019-01-15  Tom Tromey  <tom@tromey.com>
9162
9163         * progspace.h (program_space) <objfiles_safe_range>: New
9164         typedef.
9165         <objfiles_safe>: New method.
9166         * objfiles.h (class all_objfiles_safe): Remove.
9167         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9168         * jit.c (jit_inferior_exit_hook): Update.
9169
9170 2019-01-17  Tom Tromey  <tom@tromey.com>
9171
9172         * progspace.h (program_space) <objfiles_range>: New typedef.
9173         <objfiles>: New method.
9174         <objfiles_head>: Rename from objfiles.
9175         (object_files): Update.
9176         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9177         * guile/scm-pretty-print.c
9178         (ppscm_find_pretty_printer_from_objfiles): Update.
9179         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9180         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9181         Update.
9182         * python/py-progspace.c (pspy_get_objfiles): Update.
9183         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9184         Update.
9185         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9186         (objfpy_lookup_objfile_by_build_id): Update.
9187         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9188         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9189         Update.
9190         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9191         (expand_symtab_containing_pc, lookup_objfile_from_block)
9192         (lookup_static_symbol, basic_lookup_transparent_type)
9193         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9194         (find_line_symtab, info_sources_command)
9195         (default_collect_symbol_completion_matches_break_on)
9196         (make_source_files_completion_list, find_main_name): Update.
9197         * symmisc.c (print_symbol_bcache_statistics)
9198         (print_objfile_statistics, maintenance_print_symbols)
9199         (maintenance_print_msymbols, maintenance_print_objfiles)
9200         (maintenance_info_symtabs, maintenance_check_symtabs)
9201         (maintenance_expand_symtabs, maintenance_info_line_tables):
9202         Update.
9203         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9204         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9205         (map_overlay_command, unmap_overlay_command)
9206         (simple_overlay_update, expand_symtabs_matching)
9207         (map_symbol_filenames): Update.
9208         * symfile-debug.c (set_debug_symfile): Update.
9209         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9210         Update.
9211         * source.c (select_source_symtab, forget_cached_source_info):
9212         Update.
9213         * solib.c (solib_read_symbols): Update.
9214         * solib-spu.c (append_ocl_sos): Update.
9215         * psymtab.c (maintenance_print_psymbols)
9216         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9217         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9218         * printcmd.c (info_symbol_command): Update.
9219         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9220         Update.
9221         * objfiles.h (class all_objfiles): Remove.
9222         * objfiles.c (have_partial_symbols, have_full_symbols)
9223         (have_minimal_symbols, qsort_cmp, update_section_map)
9224         (shared_objfile_contains_address_p)
9225         (default_iterate_over_objfiles_in_search_order): Update.
9226         * objc-lang.c (info_selectors_command, info_classes_command)
9227         (find_methods): Update.
9228         * minsyms.c (find_solib_trampoline_target): Update.
9229         * maint.c (maintenance_info_sections)
9230         (maintenance_translate_address, count_symtabs_and_blocks):
9231         Update.
9232         * main.c (captured_main_1): Update.
9233         * linux-thread-db.c (try_thread_db_load_from_pdir)
9234         (has_libpthread): Update.
9235         * linespec.c (iterate_over_all_matching_symtabs)
9236         (search_minsyms_for_name): Update.
9237         * jit.c (jit_find_objf_with_entry_addr): Update.
9238         * hppa-tdep.c (find_unwind_entry)
9239         (hppa_lookup_stub_minimal_symbol): Update.
9240         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9241         Update.
9242         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9243         (elf_gnu_ifunc_resolve_by_got): Update.
9244         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9245         * dwarf-index-write.c (save_gdb_index_command): Update.
9246         * cp-support.c (add_symbol_overload_list_qualified): Update.
9247         * breakpoint.c (create_overlay_event_breakpoint)
9248         (create_longjmp_master_breakpoint)
9249         (create_std_terminate_master_breakpoint)
9250         (create_exception_master_breakpoint): Update.
9251         * blockframe.c (find_pc_partial_function): Update.
9252         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9253         (ada_collect_symbol_completion_matches)
9254         (ada_add_global_exceptions): Update.
9255
9256 2019-01-17  Tom Tromey  <tom@tromey.com>
9257
9258         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9259         declare VEC.
9260         (solib_target_parse_libraries): Change return type.
9261         (library_list_start_segment, library_list_start_section)
9262         (library_list_end_library, library_list_start_library); Update.
9263         (solib_target_free_library_list): Remove.
9264         (solib_target_parse_libraries): Remove cleanup.  Change return
9265         type.
9266         (solib_target_current_sos): Update.
9267
9268 2019-01-17  Tom Tromey  <tromey@bapiya>
9269
9270         * valprint.c: Replace "the the" with "the".
9271         * symtab.c: Replace "the the" with "the".
9272         * solib.c: Replace "the the" with "the".
9273         * solib-dsbt.c: Replace "the the" with "the".
9274         * linespec.c: Replace "the the" with "the".
9275         * dwarf2loc.h: Replace "the the" with "the".
9276         * amd64-windows-tdep.c: Replace "the the" with "the".
9277         * aarch64-tdep.c: Replace "the the" with "the".
9278
9279 2019-01-16  Keith Seitz  <keiths@redhat.com>
9280
9281         PR gdb/23773
9282         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9283         <builder>: Rename to ..
9284         <m_builder>: ... this and make private.
9285         (dwarf2_cu::get_builder): New method.  Change all users of
9286         `builder' to use this method.
9287         (dwarf2_start_symtab): Move to ...
9288         (dwarf2_cu::start_symtab): ... here.  Update all callers
9289         (setup_type_unit_groups): Move to ...
9290         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9291         callers.
9292         (dwarf2_cu::reset_builder): New method.
9293         (process_full_compunit, process_full_type_unit): Use
9294         dwarf2_cu::reset_builder.
9295         (follow_die_offset): Record the ancestor CU if it is different
9296         from the followed DIE's CU.
9297         (follow_die_sig_1): Likewise.
9298
9299 2019-01-15  Tom Tromey  <tom@tromey.com>
9300
9301         * remote.c (class remote_state) <buf>: Now a char_vector.
9302         <buf_size>: Remove.
9303         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9304         parameter.
9305         (remote_target::getpkt_or_notif_sane_1)
9306         (remote_target::getpkt_sane)
9307         (remote_target::getpkt_or_notif_sane): Likewise.
9308         (class remote_target) <putpkt>: New overload.
9309         (remote_target::read_frame): Change type of "buf_p".  Remove
9310         sizeof_p parameter.
9311         (packet_ok): New overload.
9312         (packet_check_result): New overload.
9313         Update all uses.
9314
9315 2019-01-14  Tom Tromey  <tom@tromey.com>
9316
9317         * remote-notif.c (handle_notification, remote_notif_ack)
9318         (remote_notif_parse): Make "buf" const.
9319         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9320         const.
9321         (remote_notif_parse, remote_notif_ack, handle_notification):
9322         Likewise.
9323         * remote.c (remote_notif_stop_parse): Make "buf" const.
9324         (remote_target::remote_parse_stop_reply): Make "buf" const.
9325         (remote_notif_stop_ack): Make "buf" const.
9326
9327 2019-01-14  Tom Tromey  <tom@tromey.com>
9328
9329         * remote.c (remote_console_output): Make parameter const.
9330
9331 2019-01-14  Tom Tromey  <tom@tromey.com>
9332
9333         * target-debug.h (target_debug_print_signals): Constify.
9334         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9335         * procfs.c (procfs_target::pass_signals): Update.
9336         * linux-nat.c (linux_nat_target::pass_signals): Update.
9337         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9338         * target-delegates.c: Rebuild.
9339         * remote.c (remote_target::program_signals): Update.
9340         (remote_target::pass_signals): Update.
9341         * target.c (target_pass_signals): Constify argument.
9342         (target_program_signals): Likewise.
9343         * target.h (struct target_ops) <pass_signals, program_signals>:
9344         Constify argument.
9345         (target_pass_signals, target_program_signals): Constify argument.
9346
9347 2019-01-14  Tom Tromey  <tom@tromey.com>
9348
9349         PR tui/28819:
9350         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9351
9352 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9353
9354         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9355         field.
9356         * rs6000-tdep.c: Include reggroups.h.
9357         (IS_V_ALIAS_PSEUDOREG): Define.
9358         (rs6000_register_name): Return names for the "vX" aliases.
9359         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9360         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9361         aliases.  Call default_register_reggroup_p for all other
9362         pseudo-registers.
9363         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9364         New functions.
9365         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9366         Handle "vX" aliases.
9367         (v_alias_pseudo_register_collect): New function.
9368         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9369         (rs6000_gdbarch_init): Initialize "vX" aliases as
9370         pseudo-registers.  Restore registration of
9371         rs6000_pseudo_register_reggroup_p with
9372         set_tdesc_pseudo_register_reggroup_p.
9373
9374 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9375
9376         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9377         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9378         set_gdbarch_num_pseudo_regs.
9379
9380 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9381
9382         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9383         Remove arg prefixname, add do_set and do_show.
9384         Add member functions set_list and show_list.
9385         * cli/cli-style.c (class cli_style_option): Update accordingly.
9386         (style_set_list): Move to file scope.
9387         (style_show_list): Likewise.
9388         (set_style): Call help_list.
9389         (show_style): Call cmd_show_list.
9390         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9391         Update to use the new macro.
9392
9393 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9394
9395         * ada-lang.c (_initialize_ada_language): Expand the help text
9396         for the "catch exception" command.
9397
9398 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9399
9400         * symtab.c (matching_obj_sections): Initialize obj,
9401         declare it closer to its usage.
9402
9403 2019-01-10  Tom Tromey  <tom@tromey.com>
9404
9405         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9406         (basic_inf_threads_range): Remove.
9407         (inf_threads_range, inf_non_exited_threads_range)
9408         (safe_inf_threads_range): Use next_adapter.
9409
9410 2019-01-10  Keith Seitz  <keiths@redhat.com>
9411
9412         PR gdb/23712
9413         PR symtab/23010
9414         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9415         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9416
9417 2019-01-10  Keith Seitz  <keiths@redhat.com>
9418
9419         PR gdb/23712
9420         PR symtab/23010
9421         * dictionary.c (pending_to_vector): Remove.
9422         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9423         Remove _1 suffix, replacing functions of the same name.  Update
9424         all callers.
9425         (dict_create_hashed, dict_create_hashed_expandable)
9426         (dict_create_linear, dict_create_linear_expandable, dict_free)
9427         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9428         Make functions static.
9429
9430 2019-01-10  Keith Seitz  <keiths@redhat.com>
9431
9432         PR gdb/23712
9433         PR symtab/23010
9434         * dictionary.h (struct dictionary): Replace declaration with
9435         multidictionary.
9436         (dict_create_hashed, dict_create_hashed_expandable)
9437         (dict_create_linear, dict_create_linear_expandable)
9438         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9439         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9440         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9441         taking multidictionary argument.
9442         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9443         * block.h (struct block) <dict>: Change to multidictionary
9444         and rename `multidict'.
9445         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9446         symmisc.c: Update all dictionary references to multidictionary.
9447
9448 2019-01-10  Keith Seitz  <keiths@redhat.com>
9449
9450         PR gdb/23712
9451         PR symtab/23010
9452         * dictionary.c: Include unordered_map.
9453         (pending_to_vector): New function.
9454         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9455         Rewrite the non-"_1" functions to take vector instead
9456         of linked list.
9457         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9458         "new" _1 versions of the same name.
9459         (multidictionary): Define.
9460         (std::hash<enum language): New definition.
9461         (collate_pending_symbols_by_language, mdict_create_hashed)
9462         (mdict_create_hashed_expandable, mdict_create_linear)
9463         (mdict_create_linear_expandable, mdict_free)
9464         (find_language_dictionary, create_new_language_dictionary)
9465         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9466         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9467         (mdict_size, mdict_empty): New functions.
9468         * dictionary.h (mdict_iterator): Define.
9469
9470 2019-01-10  Pedro Alves  <palves@redhat.com>
9471
9472         * breakpoint.c (read_uploaded_action)
9473         (create_tracepoint_from_upload): Adjust to use
9474         gdb::unique_xmalloc_ptr.
9475         * ctf.c (ctf_write_uploaded_tp):
9476         (SET_ARRAY_FIELD): Use emplace_back.
9477         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9478         * tracefile-tfile.c (tfile_write_uploaded_tp):
9479         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9480         gdb::unique_xmalloc_ptr.
9481         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9482         at_string, cond_string, cmd_strings>: Replace char pointers
9483         with gdb::unique_xmalloc_ptr.
9484
9485 2019-01-10  Pedro Alves  <palves@redhat.com>
9486
9487         * solib-target.c (library_list_start_library): Don't xstrdup name.
9488
9489 2019-01-10  Pedro Alves  <palves@redhat.com>
9490
9491         * mdebugread.c (parse_partial_symbols): Use
9492         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9493
9494 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9495
9496         * linux-fork.c (scoped_switch_fork_info)
9497         <~scoped_switch_fork_info>: Fix incorrect variable name.
9498
9499 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9500
9501         * linux-fork.c (scoped_switch_fork_info)
9502         <scoped_switch_fork_info>: Make explicit.
9503         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9504
9505 2019-01-10  Tom Tromey  <tom@tromey.com>
9506
9507         * objfiles.h (objfile::reset_psymtabs): Update.
9508         * objfiles.c (objfile::objfile): Update.
9509         * psymtab.h (psymtab_storage::obstack): Update.
9510         (psymtab_storage::m_obstack): Use gdb::optional.
9511         (class psymtab_storage): Update comment.  Remove objfile
9512         parameter.
9513         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9514
9515 2019-01-10  Tom Tromey  <tom@tromey.com>
9516
9517         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9518         <free_psymtabs>: Now private.
9519         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9520         (allocate_psymtab): Use new method.
9521
9522 2019-01-10  Tom Tromey  <tom@tromey.com>
9523
9524         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9525         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9526         * mdebugread.c (parse_partial_symbols): Use
9527         allocate_dependencies.
9528         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9529         allocate_dependencies.
9530         (process_psymtab_comp_unit_reader)
9531         (build_type_psymtab_dependencies): Likewise.
9532         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9533
9534 2019-01-10  Tom Tromey  <tom@tromey.com>
9535
9536         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9537         PSYMBOL_SET_LANGUAGE.
9538         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9539
9540 2019-01-10  Tom Tromey  <tom@tromey.com>
9541
9542         * psymtab.h (psymtab_storage::obstack): New method.
9543         <m_obstack>: Rename from obstack; now private.
9544         * psymtab.c (psymtab_storage): Update.
9545         * dwarf2read.c (create_addrmap_from_index)
9546         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9547         Update.
9548
9549 2019-01-10  Tom Tromey  <tom@tromey.com>
9550
9551         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9552         * objfiles.h (objfile::reset_psymtabs): New method.
9553
9554 2019-01-10  Tom Tromey  <tom@tromey.com>
9555
9556         * symmisc.c (print_symbol_bcache_statistics): Update.
9557         (print_objfile_statistics): Update.
9558         * symfile.c (reread_symbols): Update.
9559         * psymtab.h (class psymtab_storage): New.
9560         * psymtab.c (psymtab_storage): New constructor.
9561         (~psymtab_storage): New destructor.
9562         (require_partial_symbols): Update.
9563         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9564         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9565         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9566         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9567         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9568         (start_psymtab_common, end_psymtab_common)
9569         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9570         (allocate_psymtab): Update.
9571         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9572         Update.
9573         (dump_psymtab_addrmap, maintenance_print_psymbols)
9574         (maintenance_check_psymtabs): Update.
9575         (class objfile_psymtabs): Move to objfiles.h.
9576         * psympriv.h (discard_psymtab): Now inline.
9577         (psymtab_discarder::psymtab_discarder): Update.
9578         (psymtab_discarder::~psymtab_discarder): Update.
9579         (ALL_OBJFILE_PSYMTABS): Rewrite.
9580         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9581         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9582         Remove fields.
9583         <partial_symtabs>: New field.
9584         (class objfile_psymtabs): Move from psymtab.h.  Update.
9585         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9586         psymbol_cache.
9587         (objfile::~objfile): Don't destroy psymbol_cache.
9588         * mdebugread.c (parse_partial_symbols): Update.
9589         * dwarf2read.c (create_addrmap_from_index)
9590         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9591         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9592         (add_partial_subprogram, dwarf2_ranges_read): Update.
9593         * dwarf-index-write.c (write_address_map)
9594         (write_one_signatured_type, recursively_write_psymbols)
9595         (class debug_names, class debug_names, write_psymtabs_to_index):
9596         Update.
9597
9598 2019-01-10  Tom Tromey  <tom@tromey.com>
9599
9600         * symtab.h (SYMBOL_SET_NAMES): Update.
9601         (symbol_set_names): Update.
9602         (MSYMBOL_SET_NAMES): Update.
9603         * symtab.c (symbol_set_names): Change argument to be an
9604         objfile_per_bfd_storage.
9605         * psymtab.c (add_psymbol_to_bcache): Update.
9606         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9607
9608 2019-01-10  Tom Tromey  <tom@tromey.com>
9609
9610         * symtab.c (create_demangled_names_hash): Change argument to be an
9611         objfile_per_bfd_storage.
9612         (symbol_set_names): Update.
9613
9614 2019-01-10  Tom Tromey  <tom@tromey.com>
9615
9616         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9617         init_psymbol_list.
9618         * psymtab.c (init_psymbol_list): Do nothing if already called.
9619         * psympriv.h (init_psymbol_list): Add comment.
9620         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9621         init_psymbol_list.
9622         * dbxread.c (dbx_symfile_read): Unconditionally call
9623         init_psymbol_list.
9624
9625 2019-01-10  Tom Tromey  <tom@tromey.com>
9626
9627         * xcoffread.c (scan_xcoff_symtab): Update.
9628         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9629         "where".
9630         * mdebugread.c (parse_partial_symbols)
9631         (handle_psymbol_enumerators): Update.
9632         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9633         * dbxread.c (read_dbx_symtab): Update.
9634         * psympriv.h (psymbol_placement): New enum.
9635         (add_psymbol_to_list): Update.
9636
9637 2019-01-10  Tom Tromey  <tom@tromey.com>
9638
9639         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9640         static_psymbols parameters.
9641         (scan_xcoff_symtab): Update.
9642         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9643         static_psymbols parameters.
9644         * psympriv.h (start_psymtab_common): Update.
9645         * mdebugread.c (parse_partial_symbols): Update.
9646         * dwarf2read.c (create_partial_symtab): Update.
9647         * dbxread.c (read_dbx_symtab): Update.
9648         (start_psymtab): Remove global_psymbols and static_psymbols
9649         parameters.
9650
9651 2019-01-10  Tom Tromey  <tom@tromey.com>
9652
9653         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9654         * psymtab.c (allocate_psymtab): Add comment.
9655         * psympriv.h (allocate_psymtab): Add comment.
9656         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9657         initializations.
9658         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9659
9660 2019-01-10  Tom Tromey  <tom@tromey.com>
9661
9662         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9663         Don't declare.
9664         * mipsread.c: Include mdebugread.h.
9665         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9666         Declare.
9667         * elfread.c: Include mdebugread.h.
9668
9669 2019-01-09  Tom Tromey  <tom@tromey.com>
9670
9671         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9672         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9673         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9674         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9675         (psym_lookup_symbol, psym_find_last_source_symtab)
9676         (psym_forget_cached_source_info, psym_print_stats)
9677         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9678         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9679         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9680         (psym_find_compunit_symtab_by_address)
9681         (maintenance_print_psymbols, maintenance_info_psymtabs)
9682         (maintenance_check_psymtabs): Use ranged for.
9683         * psymtab.h (class objfile_psymtabs): New.
9684         (require_partial_symbols): Return objfile_psymtabs.
9685         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9686
9687 2019-01-09  Tom Tromey  <tom@tromey.com>
9688
9689         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9690         (find_pc_mapped_section, list_overlays_command)
9691         (map_overlay_command, unmap_overlay_command)
9692         (simple_overlay_update): Use all_objfiles.
9693         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9694         * printcmd.c (info_symbol_command): Use all_objfiles.
9695         * objfiles.h (ALL_OBJSECTIONS): Remove.
9696         * maint.c (maintenance_translate_address): Use all_objfiles.
9697         * gcore.c (gcore_create_callback): Use all_objfiles.
9698         (objfile_find_memory_regions): Likewise.
9699
9700 2019-01-09  Tom Tromey  <tom@tromey.com>
9701
9702         * symtab.c (find_line_symtab, info_sources_command)
9703         (make_source_files_completion_list): Use objfile_compunits.
9704         * source.c (select_source_symtab): Use objfile_compunits.
9705         * objfiles.h (struct objfile): Update comment.
9706         (ALL_OBJFILES): Remove.
9707         (ALL_FILETABS): Remove.
9708         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9709         objfile_compunits.
9710
9711 2019-01-09  Tom Tromey  <tom@tromey.com>
9712
9713         * symmisc.c (print_objfile_statistics, dump_objfile)
9714         (maintenance_print_symbols): Use compunit_filetabs.
9715         * source.c (forget_cached_source_info_for_objfile): Use
9716         compunit_filetabs.
9717         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9718         (ALL_FILETABS): Use compunit_filetabs.
9719         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9720         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9721
9722 2019-01-09  Tom Tromey  <tom@tromey.com>
9723
9724         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9725         (compunit_filetabs): New.
9726         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9727         compunit_filetabs.
9728         (info_sources_command, make_source_files_completion_list): Remove
9729         declaration.
9730         * symmisc.c (print_objfile_statistics, dump_objfile)
9731         (maintenance_print_symbols): Remove declaration.
9732         (maintenance_info_symtabs): Use compunit_filetabs.
9733         (maintenance_info_line_tables): Likewise.
9734         * source.c (select_source_symtab): Change local variable name.
9735         (forget_cached_source_info_for_objfile): Remove declaration.
9736         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9737         * objfiles.c (objfile_relocate1): Remove declaration.
9738         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9739         declaration.
9740         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9741         * coffread.c (coff_symtab_read): Remove declaration.
9742         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9743         compunit_filetabs.
9744
9745 2019-01-09  Tom Tromey  <tom@tromey.com>
9746
9747         * symtab.c (lookup_objfile_from_block)
9748         (find_pc_sect_compunit_symtab, search_symbols)
9749         (default_collect_symbol_completion_matches_break_on): Use
9750         objfile_compunits.
9751         * objfiles.h (ALL_COMPUNITS): Remove.
9752         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9753         * cp-support.c (add_symbol_overload_list_qualified): Use
9754         objfile_compunits.
9755         * ada-lang.c (ada_collect_symbol_completion_matches)
9756         (ada_add_global_exceptions): Use objfile_compunits.
9757
9758 2019-01-09  Tom Tromey  <tom@tromey.com>
9759
9760         * source.c (select_source_symtab)
9761         (forget_cached_source_info_for_objfile): Remove declaration.
9762         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9763         declaration.
9764         * maint.c (count_symtabs_and_blocks): Remove declaration.
9765         * cp-support.c (add_symbol_overload_list_qualified): Remove
9766         declaration.
9767         * coffread.c (coff_symtab_read): Remove declaration.
9768         * symtab.c (lookup_symbol_in_objfile_symtabs)
9769         (basic_lookup_transparent_type_1): Use objfile_compunits.
9770         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9771         (info_sources_command, search_symbols)
9772         (default_collect_symbol_completion_matches_break_on)
9773         (make_source_files_completion_list): Remove declaration.
9774         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9775         (ada_collect_symbol_completion_matches)
9776         (ada_add_global_exceptions): Remove declaration.
9777         * linespec.c (iterate_over_all_matching_symtabs): Use
9778         objfile_compunits.
9779         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9780         (class objfile_compunits): New.
9781         (ALL_COMPUNITS): Use objfile_compunits.
9782         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9783         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9784         objfile_compunits.
9785         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9786
9787 2019-01-09  Tom Tromey  <tom@tromey.com>
9788
9789         * symtab.c (search_symbols)
9790         (default_collect_symbol_completion_matches_break_on): Use
9791         objfile_msymbols.
9792         * ada-lang.c (ada_lookup_simple_minsym)
9793         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9794         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9795         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9796         objfile_msymbols.
9797         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9798         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9799         * objc-lang.c (find_methods): Use objfile_msymbols.
9800         (info_selectors_command, info_classes_command): Likewise.
9801         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9802         * objfiles.h (class objfile_msymbols): New.
9803         (ALL_OBJFILE_MSYMBOLS): Remove.
9804         (ALL_MSYMBOLS): Remove.
9805
9806 2019-01-09  Tom Tromey  <tom@tromey.com>
9807
9808         * common/next-iterator.h (next_adapter): Add Iterator template
9809         parameter.
9810         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9811         (class all_objfiles_safe): New.
9812         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9813         * objfiles.c (put_objfile_before): Update comment.
9814         (add_separate_debug_objfile): Likewise.
9815         (free_all_objfiles): Use all_objfiles_safe.
9816         (objfile_purge_solibs): Likewise.
9817
9818 2019-01-09  Tom Tromey  <tom@tromey.com>
9819
9820         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9821         (expand_symtab_containing_pc, lookup_static_symbol)
9822         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9823         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9824         all_objfiles.
9825         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9826         * breakpoint.c (create_overlay_event_breakpoint)
9827         (create_longjmp_master_breakpoint)
9828         (create_std_terminate_master_breakpoint)
9829         (create_exception_master_breakpoint): Use all_objfiles.
9830         * linux-thread-db.c (try_thread_db_load_from_pdir)
9831         (has_libpthread): Use all_objfiles.
9832         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9833         * linespec.c (iterate_over_all_matching_symtabs)
9834         (search_minsyms_for_name): Use all_objfiles.
9835         * maint.c (maintenance_info_sections): Use all_objfiles.
9836         * main.c (captured_main_1): Use all_objfiles.
9837         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9838         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9839         * guile/scm-pretty-print.c
9840         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9841         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9842         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9843         (maintenance_print_msymbols): Use all_objfiles.
9844         * source.c (select_source_symtab): Use all_objfiles.
9845         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9846         * symfile.c (remove_symbol_file_command)
9847         (expand_symtabs_matching, map_symbol_filenames): Use
9848         all_objfiles.
9849         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9850         all_objfiles.
9851         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9852         * objc-lang.c (find_methods): Use all_objfiles.
9853         * objfiles.c (have_partial_symbols, have_full_symbols)
9854         (have_minimal_symbols, qsort_cmp)
9855         (default_iterate_over_objfiles_in_search_order): Use
9856         all_objfiles.
9857         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9858         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9859         (maintenance_check_psymtabs): Use all_objfiles.
9860         (ALL_PSYMTABS): Remove.
9861         * compile/compile-object-run.c (do_module_cleanup): Use
9862         all_objfiles.
9863         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9864         * cp-support.c (add_symbol_overload_list_qualified): Use
9865         all_objfiles.
9866         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9867         Use all_objfiles.
9868         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9869         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9870         all_objfiles.
9871         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9872         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9873         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9874         Uses all_objfiles.
9875         * solib.c (solib_read_symbols): Use all_objfiles
9876
9877 2019-01-09  Tom Tromey  <tom@tromey.com>
9878
9879         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9880         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9881         all_objfiles.
9882         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9883         * symmisc.c (print_symbol_bcache_statistics)
9884         (print_objfile_statistics, maintenance_print_objfiles)
9885         (maintenance_info_symtabs, maintenance_check_symtabs)
9886         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9887         all_objfiles.
9888         * source.c (forget_cached_source_info): Use all_objfiles.
9889         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9890         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9891         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9892         * objfiles.c (update_section_map): Use all_objfiles.
9893         (shared_objfile_contains_address_p): Likewise.
9894         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9895         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9896
9897 2019-01-09  Tom Tromey  <tom@tromey.com>
9898
9899         * common/next-iterator.h: New file.
9900         * objfiles.h (class all_objfiles): New.
9901         (struct objfile_iterator): New.
9902
9903 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9904
9905         * NEWS: Move the description of the changed "frame", "select-frame",
9906          and "info frame" commands to the Changed commands section.
9907
9908 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9909
9910         * gdbtypes.c (check_stub_method_group): Remove handling of old
9911         mangling schemes.
9912         * linespec.c (find_methods): Likewise.
9913         * stabsread.c (read_member_functions): Likewise.
9914         * valops.c (search_struct_method): Likewise.
9915         (value_struct_elt_for_reference): Likewise.
9916         * NEWS: Mention this change.
9917
9918 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9919
9920         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9921         print_source_lines.
9922         * source.c (print_source_lines_base): Update line number check.
9923         (print_source_lines): New function.
9924         (source_lines_range::source_lines_range): New function.
9925         * source.h (class source_lines_range): New class.
9926         (print_source_lines): New declaration.
9927
9928 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9929
9930         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9931
9932 2019-01-08  Tom Tromey  <tom@tromey.com>
9933             Simon Marchi  <simon.marchi@ericsson.com>
9934
9935         PR gdb/24060
9936         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9937         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9938         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9939         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9940         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9941         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9942
9943 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9944
9945         * source.c (select_source_symtab): Move header comment to
9946         declaration in source.h.
9947         (forget_cached_source_info_for_objfile): Likewise.
9948         (forget_cached_source_info): Likewise.
9949         (identify_source_line): Likewise.
9950         * source.h (identify_source_line): Move declaration from symtab.h
9951         and add comment from source.c
9952         (print_source_lines): Likewise.
9953         (forget_cached_source_info_for_objfile): Likewise.
9954         (forget_cached_source_info): Likewise.
9955         (select_source_symtab): Likewise.
9956         (enum print_source_lines_flag): Move definition from symtab.h.
9957         * symtab.h (identify_source_line): Move declaration to source.h.
9958         (print_source_lines): Likewise.
9959         (forget_cached_source_info_for_objfile): Likewise.
9960         (forget_cached_source_info): Likewise.
9961         (select_source_symtab): Likewise.
9962         (enum print_source_lines_flag): Move definition to source.h.
9963         * tui/tui-hooks.c: Add 'source.h' include.
9964
9965 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9966
9967         * source.c (print_source_lines_base): Handle requests to print
9968         reverse line number sequences, and guard against empty lines
9969         string.
9970
9971 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9972
9973         * source.c (print_source_lines_base): Fix skip of '\r' if next
9974         character is '\n'.
9975
9976 2019-01-06  Tom Tromey  <tom@tromey.com>
9977
9978         * c-exp.y (struct c_parse_state) <macro_original_text,
9979         expansion_obstack>: New member.
9980         (macro_original_text, expansion_obstack): Remove globals.
9981         (scan_macro_expansion, scanning_macro_expansion)
9982         (finished_macro_expansion): Update.
9983         (scan_macro_cleanup): Remove.
9984         (yylex, c_parse): Update.
9985
9986 2019-01-06  Tom Tromey  <tom@tromey.com>
9987
9988         * c-exp.y (struct c_parse_state) <strings>: New member.
9989         (operator_stoken): Update.
9990
9991 2019-01-06  Tom Tromey  <tom@tromey.com>
9992
9993         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9994         (union type_stack_elt) <typelist_val>: Now a pointer to
9995         std::vector.
9996         (type_stack_cleanup): Don't declare.
9997         (push_typelist): Update.
9998         * parse.c (pop_typelist): Return a std::vector.
9999         (push_typelist): Take a std::vector.
10000         (follow_types): Update.  Do not free args.
10001         (type_stack_cleanup): Remove.
10002         * c-exp.y (struct c_parse_state): New.
10003         (cpstate): New global.
10004         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10005         (nonempty_typelist): Update.
10006         (func_mod): Create a new vector.
10007         (c_parse): Create a c_parse_state.
10008         (check_parameter_typelist): Do not delete params.
10009         (function_method): Update.  Do not delete type_list.
10010
10011 2019-01-06  Tom Tromey  <tom@tromey.com>
10012
10013         PR gdb/28155:
10014         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10015         check_typedef.
10016         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10017         (print_return_value): Likewise.
10018
10019 2019-01-05  Tom Tromey  <tom@tromey.com>
10020
10021         * contrib/cleanup_check.py: Remove.
10022         * contrib/gcc-with-excheck: Remove.
10023         * contrib/exsummary.py: Remove.
10024         * contrib/excheck.py: Remove.
10025
10026 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10027
10028         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10029         NULL. Initialize tpprev to NULL instead of assigning it
10030         to NULL on the next statement.
10031         * windows-nat.c (windows_delete_thread): Remove check for
10032         main_thread_id before printing thread exit notifications.
10033         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10034         Remove thread ID check against main_thread_id.
10035         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10036         windows_delete_thread.
10037         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10038
10039 2019-01-04  Tom Tromey  <tom@tromey.com>
10040
10041         * compile/compile.c (_initialize_compile): Use upper case for
10042         metasyntactic variables.
10043         * symmisc.c (_initialize_symmisc): Use upper case for
10044         metasyntactic variables.
10045         * psymtab.c (_initialize_psymtab): Use upper case for
10046         metasyntactic variables.
10047         * demangle.c (demangle_command): Use upper case for metasyntactic
10048         variables.
10049         (_initialize_demangler): Likewise.
10050         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10051         variables.
10052
10053 2019-01-03  Tom Tromey  <tom@tromey.com>
10054
10055         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10056
10057 2019-01-03  Tom Tromey  <tom@tromey.com>
10058
10059         * python/py-symtab.c (salpy_str): Update.
10060         (struct salpy_sal_object) <symtab>: Now a PyObject.
10061         (salpy_dealloc): Update.
10062         (del_objfile_sal): Use gdbpy_ref.
10063
10064 2019-01-03  Tom Tromey  <tom@tromey.com>
10065
10066         * python/py-type.c (convert_field): Use new_reference.  Return
10067         gdbpy_ref.
10068         (make_fielditem): Return gdbpy_ref.
10069         (typy_fields): Update.
10070         (typy_getitem): Update.
10071         (field_name): Return gdbpy_ref.  Use new_reference.
10072         (typy_iterator_iternext): Update.
10073
10074 2019-01-03  Tom Tromey  <tom@tromey.com>
10075
10076         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10077
10078 2019-01-03  Tom Tromey  <tom@tromey.com>
10079
10080         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10081         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10082         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10083         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10084         (pspy_set_type_printers): Likewise.
10085         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10086         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10087         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10088         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10089         (objfpy_set_type_printers): Likewise.
10090
10091 2019-01-03  Tom Tromey  <tom@tromey.com>
10092
10093         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10094         (gdbpy_print_stack): Use gdbpy_err_fetch.
10095         * python/python-internal.h (class gdbpy_err_fetch): New class.
10096         (class gdbpy_enter) <m_error_type, m_error_value,
10097         m_error_traceback>: Remove.
10098         <m_error>: New member.
10099         (gdbpy_exception_to_string): Don't declare.
10100         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10101         * python/py-value.c (convert_value_from_python): Use
10102         gdbpy_err_fetch.
10103         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10104         gdbpy_exception_to_string.
10105         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10106         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10107         gdbpy_err_fetch.
10108
10109 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10110
10111         * linux-nat.c (delete_lwp_cleanup): Delete.
10112         (struct lwp_deleter): New struct.
10113         (lwp_info_up): New typedef.
10114         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10115         lwp_info_up.
10116
10117 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10118
10119         * linux-fork.c (class scoped_switch_fork_info): New class.
10120         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10121
10122 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10123
10124         * valops.c (find_overload_match): Remove use of null_cleanup, and
10125         calls to do_cleanups.
10126
10127 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10128
10129         * compile/compile-cplus-types.c
10130         (compile_cplus_instance::decl_name): Handle changes to
10131         cp_func_name.
10132         * cp-support.c (cp_func_name): Update header comment, update
10133         return type.
10134         * cp-support.h (cp_func_name): Update return type in declaration.
10135         * valops.c (find_overload_match): Move temp_func local to top
10136         level of function and change its type.  Use temp_func to hold and
10137         delete temporary string obtained from cp_func_name.
10138
10139 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10140
10141         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10142         gdb::char_vector, remove cleanup, and update uses of `msg`.
10143
10144 2019-01-03  Jim Wilson  <jimw@sifive.com>
10145
10146         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10147
10148 2019-01-02  Tom Tromey  <tom@tromey.com>
10149
10150         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10151         (tdesc_parse_xml): Remove cleanups.
10152         * target-descriptions.h (make_cleanup_free_target_description):
10153         Don't declare.
10154         (target_desc_deleter): New struct.
10155         (target_desc_up): New typedef.
10156         * target-descriptions.c (target_desc_deleter::operator()): Rename
10157         from free_target_description.
10158         (make_cleanup_free_target_description): Remove.
10159
10160 2019-01-02  Tom Tromey  <tom@tromey.com>
10161
10162         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10163         constructor, destructor.
10164         (linespec_parser): Remove typedef.
10165         (~linespec_parser): Rename from linespec_parser_delete.
10166         (linespec_lex_to_end, linespec_complete_label)
10167         (linespec_complete): Update.
10168         (decode_line_full): Remove cleanups.
10169         (decode_line_1): Update.
10170
10171 2019-01-02  Tom Tromey  <tom@tromey.com>
10172
10173         * python/python-internal.h (inferior_to_inferior_object): Change
10174         return type.
10175         * python/py-exitedevent.c (create_exited_event_object): Update.
10176         * python/py-inferior.c (inferior_to_inferior_object): Return
10177         gdbpy_ref.
10178         (python_new_inferior, python_inferior_deleted)
10179         (thread_to_thread_object, delete_thread_object)
10180         (build_inferior_list, gdbpy_selected_inferior): Update.
10181         * python/py-infthread.c (create_thread_object): Update.  Also fail
10182         if inferior_to_inferior_object fails.
10183
10184 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10185
10186         * inferior.h (class inferior) <displaced_step_state>: New field.
10187         * infrun.h (struct displaced_step_state): Move here from
10188         infrun.c.  Initialize fields, add constructor.
10189         <inf>: Remove field.
10190         <reset>: New method.
10191         * infrun.c (struct displaced_step_inferior_state): Move to
10192         infrun.h.
10193         (displaced_step_inferior_states): Remove.
10194         (get_displaced_stepping_state): Adust.
10195         (displaced_step_in_progress_any_inferior): Adjust.
10196         (displaced_step_in_progress_thread): Adjust.
10197         (displaced_step_in_progress): Adjust.
10198         (add_displaced_stepping_state): Remove.
10199         (get_displaced_step_closure_by_addr): Adjust.
10200         (remove_displaced_stepping_state): Remove.
10201         (infrun_inferior_exit): Call displaced_step_state.reset.
10202         (use_displaced_stepping): Don't check for NULL.
10203         (displaced_step_prepare_throw): Call
10204         get_displaced_stepping_state.
10205         (displaced_step_fixup): Don't check for NULL.
10206         (prepare_for_detach): Don't check for NULL.
10207
10208 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10209
10210         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10211          in case of call that did not complete.
10212
10213 2019-01-02  Andrey Utkin  <autkin@undo.io>
10214
10215         * symfile.c (find_separate_debug_file): Fix search of debug files for
10216         remote debuggee.
10217
10218 2019-01-02  Tom Tromey  <tom@tromey.com>
10219
10220         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10221         indentation.
10222         * python/py-frame.c (frapy_older): Remove cast.
10223         (frapy_newer): Likewise.
10224         * python/py-breakpoint.c (local_setattro): Remove cast.
10225         * python/py-arch.c (archpy_name): Remove local variable.
10226         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10227
10228 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10229
10230         * unittests/basic_string_view/element_access/char/empty.cc:
10231         Fix year range in copyright header.
10232
10233 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10234
10235         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10236         Delete.
10237         <operator==>: Update with for removed field.
10238         <hash>: Likewise.
10239         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10240         <isa_features>: ...this.
10241         <abi_features>: New field.
10242         (riscv_isa_flen): Update comment.
10243         (riscv_abi_xlen): New declaration.
10244         (riscv_abi_flen): New declaration.
10245         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10246         isa_features.
10247         (riscv_abi_xlen): New function.
10248         (riscv_isa_flen): Update to get answer from isa_features.
10249         (riscv_abi_flen): New function.
10250         (riscv_has_fp_abi): Update to get answer from abi_features.
10251         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10252         xlen and flen.
10253         (riscv_call_info) <xlen, flen>: Update comment.
10254         (riscv_call_arg_struct): Remove invalid assertions
10255         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10256         is removed.
10257         (riscv_gdbarch_init): Gather isa features and abi features
10258         separately, ensure both match on the gdbarch when reusing an old
10259         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10260         a target with 64-bit float hardware.
10261
10262 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10263
10264         * source.c (search_command_helper): Stop reverse search
10265         when line 1 has been searched.
10266
10267 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10268
10269         * record-full.c (record_full_base_target::close): Rewrite
10270         record_full_core_buf_list free logic.
10271
10272 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10273
10274         * break-catch-syscall.c (print_one_catch_syscall): xfree
10275         the last text.
10276
10277 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10278
10279         * top.c (print_gdb_version): Update Copyright year in version
10280         message.
10281
10282 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10283
10284         Update copyright year range in all GDB files.
10285
10286 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10287
10288         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10289
10290 For older changes see ChangeLog-2018.
10291 \f
10292 Local Variables:
10293 mode: change-log
10294 left-margin: 8
10295 fill-column: 74
10296 version-control: never
10297 coding: utf-8
10298 End:
10299