gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
   4         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
   5         from tui_erase_data_content.
   6         (tui_data_window::display_all_data)
   7         (tui_data_window::refresh_all)
   8         (tui_data_window::do_scroll_vertical): Update.
   9         * tui/tui-regs.c (tui_show_registers): Update.
  10         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
  11         New method.
  12
  13 2019-07-17  Tom Tromey  <tom@tromey.com>
  14
  15         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
  16         declare.
  17         * tui/tui-windata.c
  18         (tui_data_window::delete_data_content_windows): Rename from
  19         tui_delete_data_content_windows.
  20         (tui_data_window::display_all_data)
  21         (tui_data_window::do_scroll_vertical): Update.
  22         * tui/tui-data.h (struct tui_data_window)
  23         <delete_data_content_windows>: New method.
  24
  25 2019-07-17  Tom Tromey  <tom@tromey.com>
  26
  27         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
  28         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
  29
  30 2019-07-17  Tom Tromey  <tom@tromey.com>
  31
  32         * tui/tui-windata.h (tui_display_all_data): Don't declare.
  33         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
  34         from tui_display_all_data.
  35         * tui/tui-win.c
  36         (tui_data_window::do_make_visible_with_new_height): Update.
  37         * tui/tui-regs.c (tui_show_registers): Update.
  38         * tui/tui-layout.c (tui_set_layout): Update.
  39         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
  40         method.
  41
  42 2019-07-17  Tom Tromey  <tom@tromey.com>
  43
  44         * tui/tui-windata.h (tui_display_data_from): Don't declare.
  45         * tui/tui-windata.c (tui_display_data_from): Remove.
  46         (tui_data_window::refresh_all): Update.
  47
  48 2019-07-17  Tom Tromey  <tom@tromey.com>
  49
  50         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
  51         * tui/tui-windata.c (tui_display_data_from_line): Remove.
  52         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
  53         tui_display_registers_from_line.
  54         * tui/tui-regs.h (tui_display_registers_from_line): Update.
  55         * tui/tui-regs.c (tui_display_registers_from_line): Remove
  56         "force_display" parameter.
  57
  58 2019-07-17  Tom Tromey  <tom@tromey.com>
  59
  60         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
  61         declare.
  62         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
  63         Rename from tui_first_reg_element_no_inline.
  64         (tui_display_reg_element_at_line)
  65         (tui_display_registers_from_line): Update.
  66         * tui/tui-data.h (struct tui_data_window)
  67         <first_reg_element_no_inline>: New method.
  68
  69 2019-07-17  Tom Tromey  <tom@tromey.com>
  70
  71         * tui/tui-windata.c (tui_display_data_from)
  72         (tui_data_window::do_scroll_vertical): Update.
  73         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
  74         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
  75         Rename from tui_line_from_reg_element_no.
  76         (tui_display_registers_from_line): Update.
  77         * tui/tui-data.h (struct tui_data_window)
  78         <line_from_reg_element_no>: New method.
  79
  80 2019-07-17  Tom Tromey  <tom@tromey.com>
  81
  82         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
  83         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
  84         tui_last_regs_line_no.
  85         (tui_display_reg_element_at_line)
  86         (tui_display_registers_from_line): Update.
  87         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
  88         method.
  89
  90 2019-07-17  Tom Tromey  <tom@tromey.com>
  91
  92         PR tui/24722:
  93         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
  94         (tui_update_breakpoint_info): Add "being_deleted" parameter.
  95         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
  96         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
  97         (tui_update_breakpoint_info): Likewise.
  98         * tui/tui-hooks.c (tui_event_create_breakpoint)
  99         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 100         Update.
 101
 102 2019-07-17  Tom Tromey  <tom@tromey.com>
 103
 104         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 105
 106 2019-07-17  Tom Tromey  <tom@tromey.com>
 107
 108         * tui/tui-winsource.c (tui_update_source_window_as_is)
 109         (tui_update_source_windows_with_addr): Update.
 110         * tui/tui-source.h (tui_set_source_content)
 111         (tui_show_symtab_source): Add "win_info" parameter.
 112         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 113         parameter.
 114         (tui_show_symtab_source): Likewise.
 115
 116 2019-07-17  Tom Tromey  <tom@tromey.com>
 117
 118         * tui/tui-wingeneral.c
 119         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 120
 121 2019-07-17  Tom Tromey  <tom@tromey.com>
 122
 123         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 124         (struct tui_cmd_window) <can_scroll>: New method.
 125         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 126         method.
 127
 128 2019-07-17  Tom Tromey  <tromey@adacore.com>
 129
 130         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 131         do_field_signed>: Rename.  Change type of "value".
 132         * ui-out.c (ui_out::field_signed): Rename from field_int.
 133         Change type of "value".
 134         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 135         type of "value".
 136         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 137         do_field_int.  Change type of "value".
 138         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 139         do_field_int.  Change type of "value".
 140         * tracepoint.c (trace_status_mi, tfind_1)
 141         (print_one_static_tracepoint_marker): Update.
 142         * thread.c (print_thread_info_1, print_selected_thread_frame):
 143         Update.
 144         * stack.c (print_frame, print_frame_info): Update.
 145         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 146         Update.
 147         * source.c (print_source_lines_base): Update.
 148         * skip.c (info_skip_command): Update.
 149         * record-btrace.c (btrace_ui_out_decode_error)
 150         (btrace_call_history_src_line): Update.
 151         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 152         Update.
 153         * progspace.c (print_program_space): Update.
 154         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 155         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 156         do_field_int.  Change type of "value".
 157         * mi/mi-out.c (mi_ui_out::do_table_begin)
 158         (mi_ui_out::do_table_header): Update.
 159         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 160         type of "value".
 161         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 162         (mi_cmd_data_list_changed_registers, output_register)
 163         (mi_cmd_data_read_memory, mi_load_progress)
 164         (mi_cmd_trace_frame_collected): Update.
 165         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 166         Update.
 167         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 168         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 169         (mi_cmd_var_list_children, varobj_update_one): Update.
 170         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 171         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 172         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 173         * inferior.c (print_inferior): Update.
 174         * gdb_bfd.c (print_one_bfd): Update.
 175         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 176         Update.
 177         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 178         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 179         do_field_int.  Change type of "value".
 180         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 181         do_field_int.  Change type of "value".
 182         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 183         (print_one_breakpoint_location, print_it_catch_fork)
 184         (print_one_catch_fork, print_it_catch_vfork)
 185         (print_one_catch_vfork, print_it_catch_solib)
 186         (print_it_catch_exec, print_it_ranged_breakpoint)
 187         (print_mention_watchpoint, print_mention_masked_watchpoint)
 188         (bkpt_print_it, update_static_tracepoint): Update.
 189         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 190         * break-catch-syscall.c (print_it_catch_syscall): Update.
 191         * ada-tasks.c (print_ada_task_info): Update.
 192         * ada-lang.c (print_it_exception, print_mention_exception):
 193         Update.
 194
 195 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 196
 197         PR breakpoints/24541
 198         * gdbarch.c: Regenerate.
 199         * gdbarch.h: Regenerate.
 200         * gdbarch.sh: Adjust return type and parameter types for
 201         'stap_adjust_register'.
 202         (i386_stap_adjust_register): Adjust signature and return new
 203         register name.
 204         * stap-probe.c (stap_parse_register_operand): Adjust use of
 205         'gdbarch_stap_adjust_register'.
 206
 207 2019-07-17  Tom Tromey  <tromey@adacore.com>
 208
 209         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 210         declare VEC.
 211         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 212         std::vector.
 213         (struct s390_process_info): Add initializers.
 214         (s390_add_process): Use new.
 215         (s390_linux_nat_target::low_forget_process): Use delete.
 216         (s390_linux_nat_target::low_new_fork)
 217         (s390_linux_nat_target::stopped_by_watchpoint)
 218         (s390_linux_nat_target::low_prepare_to_resume)
 219         (s390_linux_nat_target::insert_watchpoint)
 220         (s390_linux_nat_target::insert_hw_breakpoint)
 221         (s390_linux_nat_target::remove_watchpoint)
 222         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 223
 224 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 225
 226         * aarch64-fbsd-nat.c: Include regcache.h.
 227         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 228         argument.
 229         (aarch64_fbsd_nat_target::fetch_registers)
 230         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 231         variable.
 232         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 233
 234 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 235
 236         * fbsd-nat.c: Include gdbarch.h.
 237
 238 2019-07-15  Tom Tromey  <tromey@adacore.com>
 239
 240         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 241
 242 2019-07-15  Tom Tromey  <tromey@adacore.com>
 243
 244         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 245         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 246         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 247         * cli-out.c (cli_ui_out::do_field_int): New method.
 248         * ui-out.c (ui_out::field_unsigned): New method.
 249         * symfile.c (generic_load): Use field_unsigned.
 250         (print_transfer_performance): Likewise.
 251         * record-btrace.c (ui_out_field_uint): Remove.
 252         (btrace_call_history_insn_range, btrace_call_history): Use
 253         field_unsigned.
 254         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 255         field_unsigned.
 256         * ui-out.h (class ui_out) <field_unsigned>: New method.
 257         <do_field_unsigned>: Likewise.
 258
 259 2019-07-15  Tom Tromey  <tromey@adacore.com>
 260
 261         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 262         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 263         * target.c (flash_erase_command): Use field_string.
 264         * infrun.c (print_signal_received_reason): Use field_string.
 265         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 266         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 267         field_string.
 268         * ada-tasks.c (print_ada_task_info): Use field_string.
 269
 270 2019-07-15  Tom Tromey  <tromey@adacore.com>
 271
 272         * target.c (flash_erase_command): Use field_core_addr.
 273         * symfile.c (generic_load): Use field_core_addr.
 274         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 275         Use field_core_addr.
 276         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 277         field_core_addr.
 278
 279 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 280
 281         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 282         value if its desired type is smaller than a CORE_ADDR and signed.
 283
 284 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 285
 286         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 287         of changes to field names, and use new is_reference field to
 288         decide if a property is a reference or not.
 289         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 290         field.
 291         (struct dwarf2_property_baton): Update header comment, rename
 292         'referenced_type' to 'property_type' and update comments.
 293         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 294         default property type, store in property baton, update to take
 295         accound of renamed field.
 296         (read_func_scope): Update call to attr_to_dynamic_prop.
 297         (read_array_type): Likewise.
 298         (dwarf2_per_cu_addr_sized_int_type): New function.
 299         (read_subrange_index_type): Move type finding code to
 300         dwarf2_per_cu_addr_sized_int_type.
 301         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 302         (dwarf2_per_cu_addr_type): New function.
 303         (set_die_type): Update calls to attr_to_dynamic_prop.
 304
 305 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 306
 307         * dwarf2read.c (read_subrange_index_type): New function.
 308         (read_subrange_type): Move code into new function and call it.
 309         * gdbtypes.c (create_range_type): Add some asserts.
 310
 311 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 312
 313         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 314         update return statements.
 315         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 316         declaration, and update comment to match.
 317         * gdbtypes.c (resolve_dynamic_array): Update call to
 318         dwarf2_evaluate_property to match new return type.
 319
 320 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 321
 322         * valarith.c (value_subscripted_rvalue): Change lowerbound
 323         parameter type from int to LONGEST.
 324         * value.h (value_subscripted_rvalue): Likewise in declaration.
 325
 326 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 327
 328         * cli/cli-utils.c (info_print_command_completer): New function.
 329         * cli/cli-utils.h: Add 'completer.h' include, and forward
 330         declaration for 'struct cmd_list_element'.
 331         (info_print_command_completer): Declare.
 332         * stack.c (_initialize_stack): Add completer for 'info locals' and
 333         'info args'.
 334         * symtab.c (_initialize_symtab): Add completer for 'info
 335         variables' and 'info functions'.
 336         * NEWS: Mention completion for additional info commands.
 337
 338 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 339
 340         * cli/cli-utils.c (extract_info_print_args): Delete.
 341         (extract_arg_maybe_quoted): Delete.
 342         (info_print_options_defs): New variable.
 343         (make_info_print_options_def_group): New function.
 344         (extract_info_print_options): Define new function.
 345         * cli/cli-utils.h (extract_info_print_args): Delete.
 346         (struct info_print_options): New structure.
 347         (extract_info_print_options): Declare new function.
 348         * stack.c (info_locals_command): Update to use new
 349         extract_info_print_options, also add a header comment.
 350         (info_args_command): Likewise.
 351         * symtab.c (info_variables_command): Likewise.
 352         (info_functions_command): Likewise.
 353
 354 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 355
 356         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 357         to extract string arguments.
 358         * common/common-utils.c (extract_string_maybe_quoted): New function.
 359         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 360
 361 2019-07-11  Tom Tromey  <tromey@adacore.com>
 362
 363         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 364         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 365         * top.h (gdbinit): Don't declare.
 366         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 367         into...
 368         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 369         * top.c (gdb_init): Don't call init_cli_cmds.
 370         (gdbinit): Remove.
 371         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 372
 373 2019-07-11  Tom Tromey  <tromey@adacore.com>
 374
 375         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 376         after it has been moved.
 377
 378 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 379
 380         * valops.c (value_must_coerce_to_target): Change return type to
 381         bool.
 382         * value.h (value_must_coerce_to_target): Likewise.
 383
 384 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 385
 386         * breakpoint.c (is_hardware_watchpoint): Remove
 387         forward-declaration.
 388         (is_masked_watchpoint): Change return type to bool.
 389         (is_tracepoint): Likewise.
 390         (is_breakpoint): Likewise.
 391         (is_hardware_watchpoint): Likewise.
 392         (is_watchpoint): Likewise.
 393         (is_no_memory_software_watchpoint): Likewise.
 394         (is_catchpoint): Likewise.
 395         (breakpoint_1): Make FILTER parameter's return type bool.
 396         is_masked_watchpoint): Change return type to bool.
 397         (save_breakpoints): Make FILTER parameter's return type bool.
 398         * breakpoint.h (is_breakpoint): Change return type to bool.
 399         (is_watchpoint): Likewise.
 400         (is_catchpoint): Likewise.
 401         (is_tracepoint): Likewise.
 402
 403 2019-07-10  Tom Tromey  <tom@tromey.com>
 404
 405         * defs.h: Don't include gdbarch.h.
 406         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 407         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 408         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 409         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 410         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 411         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 412         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 413         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 414         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 415         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 416         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 417         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 418         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 419         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 420         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 421         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 422         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 423         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 424         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 425         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 426         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 427         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 428         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 429         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 430         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 431         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 432         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 433
 434 2019-07-10  Tom Tromey  <tromey@adacore.com>
 435
 436         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 437         * breakpoint.c (init_ada_exception_breakpoint): Register as
 438         bp_catchpoint.
 439         (print_one_breakpoint_location, print_one_breakpoint): Use
 440         is_ada_exception_catchpoint.
 441         * ada-lang.c (class ada_catchpoint_location): Pass
 442         bp_loc_software_breakpoint to bp_location constructor.
 443         (is_ada_exception_catchpoint): New function.
 444
 445 2019-07-10  Tom Tromey  <tromey@adacore.com>
 446
 447         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 448         VEC.
 449         (struct arm_exidx_entry): New method operator<.
 450         (struct arm_exidx_data) <section_maps>: Change type.
 451         (arm_exidx_data_free): Remove.
 452         (arm_exidx_data_key): Change type.  Move lower.
 453         (arm_exidx_new_objfile): Update.
 454         (arm_compare_exidx_entries): Remove.
 455         (arm_find_exidx_entry, _initialize_arm_tdep)
 456
 457 2019-07-10  Tom Tromey  <tromey@adacore.com>
 458
 459         * solib-spu.c (ocl_program_data_key): Change type.
 460         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 461         Update.
 462
 463 2019-07-10  Tom Tromey  <tromey@adacore.com>
 464
 465         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 466         (struct solib_aix_inferior_data) <library_list>: Change type.
 467         (solib_aix_inferior_data_handle): Change type.
 468         (get_solib_aix_inferior_data): Update.
 469         (solib_aix_free_library_list): Remove.
 470         (library_list_start_library): Update.
 471         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 472         return type.
 473         (solib_aix_get_library_list)
 474         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 475         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 476
 477 2019-07-10  Tom Tromey  <tromey@adacore.com>
 478
 479         * solib-dsbt.c (struct dsbt_info): Add initializers.
 480         (solib_dsbt_pspace_data): Change type.
 481         (dsbt_pspace_data_cleanup): Remove.
 482         (get_dsbt_info, _initialize_dsbt_solib): Update.
 483
 484 2019-07-10  Tom Tromey  <tromey@adacore.com>
 485
 486         * spu-tdep.c (spu_overlay_data): Change type.
 487         (spu_get_overlay_table, spu_overlay_new_objfile)
 488         (_initialize_spu_tdep): Update.
 489
 490 2019-07-10  Tom Tromey  <tromey@adacore.com>
 491
 492         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 493         destructor.
 494         (dbx_objfile_data_key): Change type and declare later.
 495         (DBX_SYMFILE_INFO): Rewrite.
 496         * dbxread.c (dbx_objfile_data_key): Change type.
 497         (dbx_symfile_init): Update.
 498         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 499         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 500         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 501
 502 2019-07-10  Tom Tromey  <tromey@adacore.com>
 503
 504         * jit.c (jit_program_space_key): Change type.  Move lower.
 505         (get_jit_program_space_data): Update.
 506         (jit_program_space_data_cleanup): Remove.
 507         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 508         Update.
 509         (struct jit_program_space_data): Add initializers.
 510
 511 2019-07-10  Tom Tromey  <tromey@adacore.com>
 512
 513         * solib-darwin.c (struct darwin_info): Add initializers.
 514         (solib_darwin_pspace_data): Change type.
 515         (darwin_pspace_data_cleanup): Remove.
 516         (get_darwin_info, _initialize_darwin_solib): Update.
 517
 518 2019-07-10  Tom Tromey  <tromey@adacore.com>
 519
 520         * remote-sim.c (struct sim_inferior_data): Add initializers,
 521         constructor, and destructor.
 522         (sim_inferior_data_key): Change type.  Move lower.
 523         (check_for_duplicate_sim_descriptor): Update.
 524         (get_sim_inferior_data): Use new.  Update.
 525         (~sim_inferior_data_cleanup): Rename from
 526         sim_inferior_data_cleanup.  Simplify.
 527         (gdbsim_close_inferior, simulator_command)
 528         (sim_command_completer, _initialize_remote_sim): Update.
 529         (next_pid, INITIAL_PID): Move earlier.
 530
 531 2019-07-10  Tom Tromey  <tromey@adacore.com>
 532
 533         * python/python-internal.h (create_thread_object): Return
 534         gdbpy_ref.
 535         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 536         * python/py-inferior.c (struct threadlist_entry): Add
 537         constructor.
 538         <thread_obj>: Now a gdbpy_ref.
 539         (thread_to_thread_object): Update.
 540         (add_thread_object): Use new.
 541         (delete_thread_object): Use delete.
 542         (infpy_threads): Update.
 543         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 544         GIL.
 545
 546 2019-07-10  Tom Tromey  <tromey@adacore.com>
 547
 548         * valops.c (value_cast): Specialize error message for Ada.
 549
 550 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 551
 552         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 553
 554 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 555
 556         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 557         bpstat_should_step): Return bool, adjust comments.
 558         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 559         bpstat_should_step): Likewise.
 560
 561 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 562
 563         * features/Makefile: Use feature target descriptions for Arm.
 564         * features/arm/arm-core.c: Generate new file.
 565         * features/arm/arm-fpa.c: Likewise.
 566         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 567         * features/arm/arm-m-profile.c: Likewise.
 568         * features/arm/arm-vfpv2.c: Likewise.
 569         * features/arm/arm-vfpv3.c: Likewise.
 570         * features/arm/xscale-iwmmxt.c: Likewise.
 571         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 572
 573 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 574
 575         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 576         ptrace earlier.
 577
 578 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 579
 580         * features/aarch64-pauth.c: Regenerate.
 581
 582 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 583
 584         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 585         bool.
 586         (bpstat_what): Use false instead of 0.
 587
 588 2019-07-09  Pedro Alves  <palves@redhat.com>
 589
 590         * break-catch-throw.c (is_exception_catchpoint): New.
 591         * breakpoint.c (print_one_breakpoint_location): New parameter
 592         'raw_loc'.  Handle it.  Use
 593         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 594         looking at the breakpoint's type.
 595         (print_one_breakpoint): If handling "maint info breakpoints", also
 596         print locations of exception catchpoints.
 597         * breakpoint.h (is_exception_catchpoint): Declare.
 598
 599 2019-07-09  Pedro Alves  <palves@redhat.com>
 600
 601         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 602         "addr" field.
 603         (allocate_location_exception_catchpoint): New.
 604         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 605         (initialize_throw_catchpoint_ops): Install
 606         allocate_location_exception_catchpoint as allocate_location
 607         method.
 608         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 609         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 610         bp_loc_other.
 611         (breakpoint_address_is_meaningful): Delete.
 612         (bl_address_is_meaningful): New.
 613         (breakpoint_locations_match): Adjust comment.
 614         (bp_location_from_bp_type): New, factored out of...
 615         (bp_location::bp_location(breakpoint *)): ... this.
 616         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 617         factored out of...
 618         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 619         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 620         breakpoint_address_is_meaningful.
 621         (bp_locations_compare): Adjust comment.
 622         (update_global_location_list): Use bl_address_is_meaningful
 623         instead of breakpoint_address_is_meaningful.
 624         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 625         explicit.
 626         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 627         * python/py-breakpoint.c (bppy_get_location): No longer check
 628         whether location is null.
 629
 630 2019-07-09  Pedro Alves  <palves@redhat.com>
 631
 632         PR c++/15468
 633         * breakpoint.c (print_one_breakpoint_location): Remove
 634         single-location assert.
 635
 636 2019-07-09  Tom Tromey  <tom@tromey.com>
 637
 638         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 639         * configure: Rebuild.
 640         * configure.ac: Change common to gdbsupport.
 641         * gdbsupport: Rename from common.
 642         * acinclude.m4: Change common to gdbsupport.
 643         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 644         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 645         gdbsupport.
 646         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 647         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 648         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 649         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 650         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 651         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 652         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 653         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 654         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 655         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 656         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 657         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 658         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 659         coff-pe-read.c, command.h, compile/compile-c-support.c,
 660         compile/compile-c.h, compile/compile-cplus-symbols.c,
 661         compile/compile-cplus-types.c, compile/compile-cplus.h,
 662         compile/compile-loc2c.c, compile/compile.c, completer.c,
 663         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 664         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 665         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 666         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 667         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 668         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 669         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 670         features/aarch64-core.c, features/aarch64-fpu.c,
 671         features/aarch64-pauth.c, features/aarch64-sve.c,
 672         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 673         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 674         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 675         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 676         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 677         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 678         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 679         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 680         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 681         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 682         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 683         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 684         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 685         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 686         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 687         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 688         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 689         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 690         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 691         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 692         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 693         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 694         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 695         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 696         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 697         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 698         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 699         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 700         minsyms.c, mips-linux-tdep.c, namespace.h,
 701         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 702         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 703         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 704         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 705         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 706         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 707         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 708         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 709         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 710         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 711         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 712         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 713         procfs.c, producer.c, progspace.h, psymtab.h,
 714         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 715         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 716         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 717         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 718         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 719         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 720         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 721         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 722         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 723         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 724         target-memory.c, target.c, target.h, target/waitstatus.c,
 725         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 726         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 727         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 728         unittests/array-view-selftests.c,
 729         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 730         unittests/common-utils-selftests.c,
 731         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 732         unittests/format_pieces-selftests.c,
 733         unittests/function-view-selftests.c,
 734         unittests/lookup_name_info-selftests.c,
 735         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 736         unittests/mkdir-recursive-selftests.c,
 737         unittests/observable-selftests.c,
 738         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 739         unittests/parse-connection-spec-selftests.c,
 740         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 741         unittests/scoped_fd-selftests.c,
 742         unittests/scoped_mmap-selftests.c,
 743         unittests/scoped_restore-selftests.c,
 744         unittests/string_view-selftests.c, unittests/style-selftests.c,
 745         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 746         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 747         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 748         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 749         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 750         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 751
 752 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 753
 754         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 755         bool value.
 756         (decode_digits_ordinary): Set explicit_line field in sal.
 757         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 758         symtab_and_line that was set on an explicit line number in
 759         assembler code.  Do always update the recorded symtab and line if
 760         we do skip the prologue.
 761
 762 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 763
 764         * breakpoint.c (set_breakpoint_location_function): Remove
 765         explicit_loc parameter.
 766         (momentary_breakpoint_from_master): Update call to
 767         set_breakpoint_location_function.
 768         (add_location_to_breakpoint): Likewise.
 769
 770 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 771
 772         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 773         required features based on default bfd type when no specific bfd
 774         is present.
 775
 776 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 777
 778         * NEWS: Mention that GDB printf and eval commands can now print
 779         C-style and Ada-style convenience var strings without
 780         calling the inferior.
 781         * printcmd.c (printf_c_string): Locally print GDB internal var
 782         instead of transiting via the inferior.
 783         (printf_wide_c_string): Likewise.
 784
 785 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 786
 787         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 788
 789 2019-07-04  Tom Tromey  <tom@tromey.com>
 790
 791         PR tui/24724:
 792         * tui/tui-winsource.c (tui_clear_source_content): Update.
 793         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 794         (tui_update_breakpoint_info): Update.
 795         (tui_set_exec_info_content): Update.
 796         * tui/tui-source.c (tui_set_source_content_nil): Update.
 797         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 798         has_break.
 799         * tui/tui-data.h (enum tui_bp_flag): New.
 800         (tui_bp_flags): New enum flags type.
 801         (struct tui_source_element) <break_mode>: Change type.  Rename
 802         from has_break.
 803         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 804         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 805         constants.
 806         * tui/tui-winsource.h: Fix comment.
 807
 808 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 809
 810         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 811         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 812         (store_fpregs_to_thread)
 813         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 814         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 815         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 816         (IWMMXT_REGS_SIZE): Add define.
 817         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 818         (fetch_vfp_regs, store_vfp_regs)
 819         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 820         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 821
 822 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 823
 824         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 825         defines.
 826         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 827         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 828         (ARM_INT_REGISTER_SIZE): ...to this.
 829         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 830         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 831         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 832         (arm_linux_collect_gregset, supply_nwfpe_register)
 833         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 834         defines.
 835         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 836         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 837         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 838         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 839         (arm_return_in_memory, arm_store_return_value)
 840         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 841         (arm_record_ld_st_multiple): Likewise.
 842         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 843         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 844
 845 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 846
 847         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 848         AARCH64_DISPLACED_MODIFIED_INSNS.
 849         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 850         (aarch64_displaced_step_copy_insn): Likewise.
 851         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 852         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 853         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 854         ARM_DISPLACED_MODIFIED_INSNS.
 855         * arm-tdep.c (arm_gdbarch_init): Likewise.
 856         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 857         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 858         (struct arm_displaced_step_closure): Use
 859         ARM_DISPLACED_MODIFIED_INSNS.
 860
 861 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 862
 863         * features/Makefile: Remove unused xml files.
 864         * features/aarch64.xml: Remove.
 865         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 866         * features/i386/amd64-avx-avx512.xml: Remove.
 867         * features/i386/amd64-avx-linux.xml: Remove.
 868         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 869         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 870         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 871         * features/i386/amd64-avx-mpx.xml: Remove.
 872         * features/i386/amd64-avx.xml: Remove.
 873         * features/i386/amd64-linux.xml: Remove.
 874         * features/i386/amd64-mpx-linux.xml: Remove.
 875         * features/i386/amd64-mpx.xml: Remove.
 876         * features/i386/amd64.xml: Remove.
 877         * features/i386/i386-avx-avx512-linux.xml: Remove.
 878         * features/i386/i386-avx-avx512.xml: Remove.
 879         * features/i386/i386-avx-linux.xml: Remove.
 880         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 881         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 882         * features/i386/i386-avx-mpx-linux.xml: Remove.
 883         * features/i386/i386-avx-mpx.xml: Remove.
 884         * features/i386/i386-avx.xml: Remove.
 885         * features/i386/i386-linux.xml: Remove.
 886         * features/i386/i386-mmx-linux.xml: Remove.
 887         * features/i386/i386-mmx.xml: Remove.
 888         * features/i386/i386-mpx-linux.xml: Remove.
 889         * features/i386/i386-mpx.xml: Remove.
 890         * features/i386/i386.xml: Remove.
 891         * features/i386/x32-avx-avx512-linux.xml: Remove.
 892         * features/i386/x32-avx-linux.xml: Remove.
 893         * features/i386/x32-linux.xml: Remove.
 894
 895 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 896
 897         * regformats/aarch64.dat: Remove.
 898         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 899         * regformats/i386/amd64-avx-linux.dat: Remove.
 900         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 901         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 902         * regformats/i386/amd64-linux.dat: Remove.
 903         * regformats/i386/amd64-mpx-linux.dat: Remove.
 904         * regformats/i386/amd64.dat: Remove.
 905         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 906         * regformats/i386/i386-avx-linux.dat: Remove.
 907         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 908         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 909         * regformats/i386/i386-linux.dat: Remove.
 910         * regformats/i386/i386-mmx-linux.dat: Remove.
 911         * regformats/i386/i386-mpx-linux.dat: Remove.
 912         * regformats/i386/i386.dat: Remove.
 913         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 914         * regformats/i386/x32-avx-linux.dat: Remove.
 915         * regformats/i386/x32-linux.dat: Remove.
 916
 917 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 918
 919         * aarch64-tdep.c: Remove xml self tests.
 920         * amd64-linux-tdep.c: Likewise.
 921         * amd64-tdep.c: Likewise.
 922         * i386-linux-tdep.c: Likewise.
 923         * i386-tdep.c: Likewise.
 924
 925 2019-07-03  Pedro Alves  <palves@redhat.com>
 926
 927         PR cli/24732
 928         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 929         (pipe_cmd_option_defs): New.
 930         (make_pipe_cmd_options_def_group): New.
 931         (pipe_command): Use gdb::option::process_options.
 932         (pipe_command_completer): New function.
 933         (_initialize_cli_cmds): Install completer for "pipe" command.
 934
 935 2019-07-03  Pedro Alves  <palves@redhat.com>
 936
 937         * cli/cli-option.c (union option_value) <string>: New field.
 938         (struct option_def_and_value): Add ctor, move ctor, dtor and
 939         use DISABLE_COPY_AND_ASSIGN.
 940         (option_def_and_value::clear_value): New.
 941         (parse_option, save_option_value_in_ctx, get_val_type_str)
 942         (add_setshow_cmds_for_options): Handle var_string.
 943         * cli-option.h (union option_def::var_address) <string>: New
 944         field.
 945         (struct string_option_def): New.
 946         * maint-test-options.c (struct test_options_opts): Add default
 947         ctor and use DISABLE_COPY_AND_ASSIGN.
 948         <string_opt>: New field.
 949         (test_options_opts::~test_options_opts): New.
 950         (test_options_opts::dump): Also dump "-string".
 951         (test_options_option_defs): Install "string.
 952
 953 2019-07-03  Pedro Alves  <palves@redhat.com>
 954
 955         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 956         option_value with a null enumeration.
 957         (complete_options): Save the option values in the context.
 958         (save_option_value_in_ctx): New, factored out from ...
 959         (process_options): ... here.
 960         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 961         of the function.
 962         * maint-test-options.c (test_options_opts::dump): New, factored
 963         out from ...
 964         (maintenance_test_options_command_mode): ... here.
 965         (maintenance_test_options_command_completion_result): Delete.
 966         (maintenance_test_options_command_completion_text): Update
 967         comment.
 968         (maintenance_show_test_options_completion_result): Change
 969         prototype.  Just print
 970         maintenance_test_options_command_completion_text.
 971         (save_completion_result): New.
 972         (maintenance_test_options_completer_mode): Pass options context to
 973         complete_options, and then save a dump.
 974         (_initialize_maint_test_options): Use add_cmd to install "maint
 975         show test-options-completion-result".
 976
 977 2019-07-03  Pedro Alves  <palves@redhat.com>
 978
 979         * NEWS (New commands): Mention "with" and "maint with".
 980         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 981         (with_command, with_command_completer): New.
 982         (pipe_command): Adjust to new repeat_previous
 983         interface.
 984         (_initialize_cli_cmds): Install the "with" command and its "w"
 985         alias.
 986         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 987         declarations.
 988         * cli/cli-setshow.c (parse_cli_var_uinteger)
 989         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 990         argument strings for all var_types.
 991         (get_setshow_command_value_string): New, factored out from ...
 992         (do_show_command): ... this.
 993         * cli/cli-setshow.h: Include <string>.
 994         (get_setshow_command_value_string): Declare.
 995         * command.h (repeat_previous): Now returns const char *.  Adjust
 996         comment.
 997         * maint.c: Include "cli/cli-cmds.h".
 998         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 999         (_initialize_maint_cmds): Register the "maintenance with" command.
1000         * top.c (repeat_previous): Move bits from pipe_command here:
1001         Return the saved command line, if any; error out if there's no
1002         command to relaunch.
1003
1004 2019-07-03  Pedro Alves  <palves@redhat.com>
1005
1006         * NEWS (New commands): Mention "maint set/show test-settings"
1007         instead of "maint test-settings".
1008         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1009         (maintenance_test_settings_set_list): Rename to ...
1010         (maintenance_set_test_settings_list): ... this.
1011         (maintenance_test_settings_show_list): Rename to  ...
1012         (maintenance_show_test_settings_list): ... this.
1013         (maintenance_test_settings_cmd): Delete.
1014         (maintenance_test_settings_set_cmd): ...
1015         (maintenance_set_test_settings_cmd): ... this.
1016         (maintenance_test_settings_show_cmd): ...
1017         (maintenance_show_test_settings_cmd): ... this.
1018         (maintenance_test_settings_show_value_cmd):
1019         (maintenance_show_test_settings_value_cmd): ... this.
1020         (_initialize_maint_test_settings): No longer install the "maint
1021         test-settings" prefix command.  Rename "maint test-settings set"
1022         to "maint set test-settings", and "maint test-settings show" to
1023         "maint show test-settings".  Adjust all subcommands.
1024
1025 2019-07-03  Pedro Alves  <palves@redhat.com>
1026
1027         * maint-test-settings.c: Fix file's intro comment.  Replace all
1028         references to "test-options" with references to "test-settings",
1029         in comments.
1030
1031 2019-07-03  Pedro Alves  <palves@redhat.com>
1032
1033         * maint-test-settings.c (maintenance_test_settings_xxx)
1034         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1035         New.
1036         (maintenance_test_settings_enums): Use them.
1037         (maintenance_test_settings_enum): Default to
1038         maintenance_test_settings_xxx.
1039         (_initialize_maint_test_settings): Initialize
1040         MAINTENANCE_TEST_SETTINGS_FILENAME.
1041
1042 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1043
1044         * breakpoint.h (remove_breakpoints_inf): Change return type to
1045         void, move function documentation here.
1046         * breakpoint.c (remove_breakpoints_inf): Change return type to
1047         void, move function documentation to header.
1048
1049 2019-07-02  Pedro Alves  <palves@redhat.com>
1050
1051         * NEWS (Completion improvements): Mention "info threads".
1052         * thread.c (struct info_threads_opts, info_threads_option_defs)
1053         (make_info_threads_options_def_group): New.
1054         (info_threads_command): Use gdb::option::process_options.
1055         (info_threads_command_completer): New.
1056         (_initialize_thread): Use gdb::option::build_help to build the
1057         help text for "info threads".
1058
1059 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1060
1061         * defs.h (generic_load): Move from here...
1062         * symfile.h (generic_load): ... to here.  Rename name parameter
1063         to args.
1064         * symfile.c (generic_load): Add comment.
1065
1066 2019-07-01  Tom Tromey  <tromey@adacore.com>
1067
1068         * dwarf2read.c
1069         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1070         declaration of without_params.  Fix formatting.
1071
1072 2019-07-01  Tom Tromey  <tromey@adacore.com>
1073
1074         * ada-exp.y (find_primitive_type): Update.
1075         * ada-lang.h (ada_lookup_symbol): Update.
1076         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1077         parameter.
1078         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1079
1080 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1081
1082         PR breakpoints/24541
1083         * gdbarch.c: Regenerate.
1084         * gdbarch.h: Regenerate.
1085         * gdbarch.sh: Add 'stap_adjust_register'.
1086         * i386-tdep.c: Include '<unordered_set>'.
1087         (i386_stap_adjust_register): New function.
1088         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1089         * stap-probe.c (stap_parse_register_operand): Call
1090         'gdbarch_stap_adjust_register'.
1091
1092 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1093
1094         PR python/24742
1095         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1096         * python/python.c (do_start_initialization): Use 'xmalloc'
1097         instead of 'PyMem_Malloc'.
1098
1099 2019-06-28  Tom Tromey  <tromey@adacore.com>
1100
1101         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1102         for Ada.
1103
1104 2019-06-27  Tom Tromey  <tromey@adacore.com>
1105
1106         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1107         objfile_key.
1108         (arm_find_mapping_symbol, arm_record_special_symbol)
1109         (_initialize_arm_tdep): Update.
1110         (arm_objfile_data_free): Remove.
1111
1112 2019-06-27  Tom Tromey  <tromey@adacore.com>
1113
1114         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1115         to cp_print_static_field.
1116
1117 2019-06-26  Tom Tromey  <tromey@adacore.com>
1118
1119         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1120         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1121         declare.
1122
1123 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1124
1125         * features/aarch64-core.c (create_feature_aarch64_core):
1126         Regenerate.
1127         * features/aarch64-core.xml: Add cpsr flags.
1128
1129 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1130
1131         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1132         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1133
1134 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1135
1136         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1137         field.
1138         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1139         use.
1140         (arm_record_special_symbol): Don't insert new symbol in sorted
1141         position, push it at the end.
1142
1143 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1144
1145         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1146         (arm_mapping_symbol_s): Remove.
1147         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1148         (arm_mapping_symbol_vec): New typedef.
1149         (struct arm_per_objfile): Add constructor.
1150         <section_maps>: Change type to
1151         std::unique_ptr<arm_mapping_symbol_vec[]>.
1152         (arm_compare_mapping_symbols): Remove.
1153         (arm_find_mapping_symbol): Adjust to section_maps type change.
1154         (arm_objfile_data_free): Call delete on arm_per_objfile.
1155         (arm_record_special_symbol): Adjust to section_maps type change.
1156         Allocate arm_per_objfile with new.
1157
1158 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1159
1160         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1161         with the command prefix.
1162
1163 2019-06-25  Tom Tromey  <tom@tromey.com>
1164
1165         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1166         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1167
1168 2019-06-25  Tom Tromey  <tom@tromey.com>
1169
1170         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1171         type.
1172         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1173         protected.
1174
1175 2019-06-25  Tom Tromey  <tom@tromey.com>
1176
1177         * tui/tui-winsource.c
1178         (tui_source_window_base::set_is_exec_point_at): Add check against
1179         LOA_ADDRESS.
1180
1181 2019-06-25  Tom Tromey  <tom@tromey.com>
1182
1183         * tui/tui-source.c (tui_set_source_content): Don't check before
1184         xfree.
1185         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1186
1187 2019-06-25  Tom Tromey  <tom@tromey.com>
1188
1189         * tui/tui-winsource.h (tui_update_source_window_as_is)
1190         (tui_alloc_source_buffer, tui_line_is_displayed)
1191         (tui_addr_is_displayed): Change type of win_info.
1192         * tui/tui-winsource.c (tui_update_source_window_as_is)
1193         (tui_clear_source_content, tui_show_source_line)
1194         (tui_show_source_content, tui_source_window_base::refill)
1195         (tui_source_window_base::set_is_exec_point_at)
1196         (tui_source_window_base::set_is_exec_point_at)
1197         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1198         (tui_alloc_source_buffer, tui_line_is_displayed)
1199         (tui_addr_is_displayed): Change type of win_info.  Update.
1200         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1201         (tui_source_window_base::do_make_visible_with_new_height):
1202         Update.
1203         * tui/tui-source.c (tui_set_source_content)
1204         (tui_set_source_content_nil)
1205         (tui_source_window::do_scroll_vertical): Update.
1206         * tui/tui-layout.c (show_layout): Update.
1207         * tui/tui-disasm.c (tui_set_disassem_content)
1208         (tui_disasm_window::do_scroll_vertical): Update.
1209         * tui/tui-data.h (tui_win_content): Remove.
1210         (struct tui_gen_win_info) <content, content_size>: Remove.
1211         (struct tui_source_element): Add initializers and destructor.
1212         (union tui_which_element, struct tui_win_element): Remove.
1213         (struct tui_source_window_base) <content>: New field.
1214         (struct tui_data_window): Remove destructor.
1215         (tui_alloc_content, tui_free_win_content)
1216         (tui_free_all_source_wins_content): Don't declare.
1217         * tui/tui-data.c (tui_initialize_static_data): Update.
1218         (init_content_element, tui_alloc_content): Remove.
1219         (~tui_gen_win_info): Update.
1220         (~tui_data_window, tui_free_all_source_wins_content)
1221         (tui_free_win_content, free_content, free_content_elements):
1222         Remove.
1223
1224 2019-06-25  Tom Tromey  <tom@tromey.com>
1225
1226         * tui/tui-winsource.h (tui_clear_source_content)
1227         (tui_erase_source_content, tui_show_source_content): Change type
1228         of win_info.
1229         * tui/tui-winsource.c (tui_clear_source_content)
1230         (tui_erase_source_content, tui_show_source_content): Change type
1231         of win_info.
1232         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1233         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1234         win_info.
1235         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1236         win_info.
1237         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1238
1239 2019-06-25  Tom Tromey  <tom@tromey.com>
1240
1241         * tui/tui-winsource.c (tui_clear_source_content)
1242         (tui_source_window_base::set_is_exec_point_at): Update.
1243         * tui/tui-source.c (tui_set_source_content_nil): Update.
1244         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1245         a bool.
1246         * tui/tui-data.c (init_content_element): Update.
1247
1248 2019-06-25  Tom Tromey  <tom@tromey.com>
1249
1250         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1251         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1252         * tui/tui-layout.c (init_and_make_win): Update.
1253         * tui/tui.h (enum tui_win_type): Update.
1254         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1255         tui_win_is_auxillary.
1256         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1257         tui_win_is_auxillary.
1258
1259 2019-06-25  Tom Tromey  <tom@tromey.com>
1260
1261         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1262         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1263         (tui_delete_data_content_windows, tui_display_all_data)
1264         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1265         Update.
1266         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1267         * tui/tui-regs.c (tui_last_regs_line_no)
1268         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1269         (tui_show_registers): Update.
1270         (tui_show_register_group): Return void.  Update.
1271         (tui_display_registers_from, tui_display_reg_element_at_line)
1272         (tui_display_registers_from_line, tui_check_register_values):
1273         Update.
1274         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1275         member.
1276         (struct tui_data_window) <regs_content>: Now a std::vector.
1277         <regs_content_count>: Remove.
1278         (tui_add_content_elements, tui_free_data_content): Don't declare.
1279         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1280         (init_content_element): Remove DATA_WIN case.  Add assert.
1281         (tui_add_content_elements): Remove.
1282         (tui_data_window): Update.
1283         (tui_free_data_content): Remove.
1284         (free_content_elements): Remove DATA_WIN case.
1285
1286 2019-06-25  Tom Tromey  <tom@tromey.com>
1287
1288         * tui/tui-data.c (tui_data_item_window): Update.
1289         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1290         * tui/tui-windata.c (tui_display_all_data)
1291         (tui_display_data_from_line): Update.
1292         (tui_check_data_values): Remove.
1293         * tui/tui-regs.c (tui_show_register_group)
1294         (tui_display_reg_element_at_line): Update.
1295         * tui/tui-hooks.c (tui_register_changed)
1296         (tui_refresh_frame_and_register_information): Call
1297         tui_check_register_values.
1298         * tui/tui-data.h (struct tui_data_window) <data_content,
1299         data_content_count, data_type>: Remove.
1300         (enum tui_data_type): Remove.
1301
1302         * tui/tui-data.c (tui_data_window::clear_detail)
1303         (~tui_data_window): Update.
1304
1305 2019-06-25  Tom Tromey  <tom@tromey.com>
1306
1307         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1308         declare.
1309         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1310         Rename from tui_first_data_item_displayed.  Update.
1311         (tui_data_window::refresh_all)
1312         (tui_data_window::do_scroll_vertical): Update.
1313         * tui/tui-data.h (struct tui_data_window)
1314         <first_data_item_displayed>: Declare new method.
1315
1316 2019-06-25  Tom Tromey  <tom@tromey.com>
1317
1318         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1319         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1320         contents...
1321         (tui_initialize_static_data): ...here.
1322
1323 2019-06-25  Tom Tromey  <tom@tromey.com>
1324
1325         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1326         (tui_display_registers_from, tui_check_register_values): Update.
1327         (tui_display_register): Remove win_info parameter; update.
1328         (tui_get_register): Change type of parameters.
1329         * tui/tui-data.h (struct tui_data_element): Remove.
1330         (union tui_which_element) <data>: Remove.
1331         <data_window>: Change type.
1332         (struct tui_data_item_window): New.
1333         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1334         case.  Add assert.
1335         (~tui_data_item_window): New destructor.
1336         (free_content_elements): Remove DATA_ITEM_WIN case.
1337
1338 2019-06-25  Tom Tromey  <tom@tromey.com>
1339
1340         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1341         Remove.
1342
1343 2019-06-25  Tom Tromey  <tom@tromey.com>
1344
1345         * tui/tui-data.h (struct tui_command_element): Remove.
1346         (union tui_which_element) <command>: Remove.
1347         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1348         assert.
1349         (free_content_elements): Remove CMD_WIN case.
1350
1351 2019-06-25  Tom Tromey  <tom@tromey.com>
1352
1353         * tui/tui-layout.c (tui_set_layout): Update.
1354         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1355         * tui/tui-data.c (layout_def): Update.
1356
1357 2019-06-25  Tom Tromey  <tom@tromey.com>
1358
1359         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1360         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1361         (tui_source_window_base::set_new_height): Update.
1362         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1363         Update.
1364         (tui_set_locator_fullname, tui_set_locator_info)
1365         (tui_show_frame_info): Update.
1366         * tui/tui-source.c (tui_set_source_content)
1367         (tui_source_is_displayed): Update.
1368         * tui/tui-layout.c (show_source_disasm_command, show_data)
1369         (show_source_or_disasm_and_command): Update.
1370         * tui/tui-disasm.c (tui_set_disassem_content)
1371         (tui_get_begin_asm_address): Update.
1372         * tui/tui-data.h (struct tui_locator_element): Remove.
1373         (union tui_which_element) <locator>: Remove.
1374         (struct tui_locator_window): New.
1375         (tui_locator_win_info_ptr): Change return type.
1376         * tui/tui-data.c (_locator): Change type.
1377         (tui_locator_win_info_ptr): Change return type.
1378         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1379         (tui_alloc_content): Add assert.
1380
1381 2019-06-25  Tom Tromey  <tom@tromey.com>
1382
1383         * tui/tui-winsource.c
1384         (tui_exec_info_window::maybe_allocate_content): New method.
1385         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1386         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1387         (make_source_or_disasm_window): Add cast.
1388         * tui/tui-data.h (union tui_which_element) <simple_string>:
1389         Remove.
1390         (struct tui_source_info): New.
1391         (struct tui_source_window_base) <execution_info>: Change type.
1392         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1393         case, and add assert.
1394         (tui_alloc_content): Add assert.
1395
1396 2019-06-25  Tom Tromey  <tom@tromey.com>
1397
1398         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1399         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1400         * tui/tui-data.c (tui_alloc_win_info): Remove.
1401
1402 2019-06-25  Tom Tromey  <tom@tromey.com>
1403
1404         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1405         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1406         can_highlight.
1407
1408 2019-06-25  Tom Tromey  <tom@tromey.com>
1409
1410         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1411         make_visible_with_new_height method.
1412         (tui_win_info::make_visible_with_new_height): New method.
1413         (tui_source_window_base::do_make_visible_with_new_height)
1414         (tui_data_window::do_make_visible_with_new_height)
1415         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1416         (make_visible_with_new_height): Remove.
1417         (tui_resize_all, tui_adjust_win_heights): Use
1418         make_visible_with_new_height method.
1419         * tui/tui-data.h (struct tui_win_info)
1420         <do_make_visible_with_new_height, make_visible_with_new_height>:
1421         New methods.
1422         (struct tui_source_window_base, struct tui_data_window)
1423         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1424         methods.
1425
1426 2019-06-25  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1429         method.
1430         (update_tab_width): Call update_tab_width method.
1431         * tui/tui-data.h (struct tui_win_info)
1432         (struct tui_source_window_base) <update_tab_width>: New methods.
1433
1434 2019-06-25  Tom Tromey  <tom@tromey.com>
1435
1436         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1437         parameter.
1438         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1439         parameter.
1440         (tui_gen_win_info::make_visible): Update.
1441         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1442         parameter.
1443         * tui/tui-data.h (enum tui_box): New enum.
1444         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1445
1446 2019-06-25  Tom Tromey  <tom@tromey.com>
1447
1448         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1449         init_and_make_win for EXEC_INFO_WIN.
1450         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1451         longer inline.
1452         (struct tui_win_info) <~tui_win_info>: Inline.
1453         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1454         Don't declare.
1455         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1456         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1457         Remove.
1458         (tui_initialize_static_data): Update.
1459         (~tui_gen_win_info): Handle more cleanup here.
1460         (~tui_source_window_base): Delete "execution_info".
1461         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1462
1463 2019-06-25  Tom Tromey  <tom@tromey.com>
1464
1465         * tui/tui-layout.c (make_command_window): Don't set
1466         can_highlight.
1467         (show_source_disasm_command): Call the reset method.
1468         (show_data): Don't set can_highlight.  Call the reset method.
1469         (tui_gen_win_info::reset): Rename from init_gen_win_info
1470         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1471         (show_source_or_disasm_and_command): Call the reset method.
1472         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1473         (struct tui_cmd_window): Set can_highlight.
1474
1475 2019-06-25  Tom Tromey  <tom@tromey.com>
1476
1477         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1478         from make_visible.
1479         (tui_make_visible, tui_make_invisible): Rewrite.
1480         (tui_win_info::make_visible): Remove.
1481         (tui_source_window_base::make_visible): Update.
1482         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1483         method.  Moved from...
1484         (struct tui_win_info) <make_visible>: ...here.
1485
1486 2019-06-25  Tom Tromey  <tom@tromey.com>
1487
1488         * tui/tui-winsource.c
1489         (tui_source_window_base::do_scroll_horizontal): Remove direction
1490         parameter.
1491         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1492         direction parameter.
1493         * tui/tui-win.c (tui_win_info::forward_scroll)
1494         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1495         (tui_win_info::right_scroll): Update.
1496         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1497         direction parameter.
1498         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1499         direction parameter.
1500         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1501         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1502         Remove direction parameter.
1503         (struct tui_source_window_base, struct tui_source_window)
1504         (struct tui_disasm_window, struct tui_data_window)
1505         (struct tui_cmd_window): Update.
1506
1507 2019-06-25  Tom Tromey  <tom@tromey.com>
1508
1509         * tui/tui-winsource.h (tui_set_exec_info_content)
1510         (tui_show_exec_info_content, tui_erase_exec_info_content)
1511         (tui_clear_exec_info_content, tui_update_exec_info): Change
1512         argument to tui_source_window_base.
1513         * tui/tui-winsource.c (tui_set_exec_info_content)
1514         (tui_show_exec_info_content, tui_erase_exec_info_content)
1515         (tui_clear_exec_info_content, tui_update_exec_info): Change
1516         argument to tui_source_window_base.
1517
1518 2019-06-25  Tom Tromey  <tom@tromey.com>
1519
1520         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1521         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1522
1523 2019-06-25  Tom Tromey  <tom@tromey.com>
1524
1525         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1526         check.
1527
1528 2019-06-25  Tom Tromey  <tom@tromey.com>
1529
1530         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1531         type to void.
1532         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1533         type to void.
1534         * tui/tui-source.c (tui_set_source_content): Update.
1535         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1536
1537 2019-06-25  Tom Tromey  <tom@tromey.com>
1538
1539         * tui/tui-win.c (window_name_completer, tui_set_focus)
1540         (tui_all_windows_info): Use name method.
1541         * tui/tui-data.h (struct tui_gen_win_info)
1542         (struct tui_source_window, struct tui_disasm_window)
1543         (struct tui_data_window, struct tui_cmd_window) <name>: New
1544         method.
1545         (tui_win_name): Don't declare.
1546         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1547         (tui_win_name): Remove.
1548
1549 2019-06-25  Tom Tromey  <tom@tromey.com>
1550
1551         * tui/tui-winsource.h (tui_update_source_window)
1552         (tui_update_source_window_as_is): Change parameter type.
1553         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1554         to be a tui_source_window_base.
1555         (tui_update_source_window_as_is): Likewise.
1556         * tui/tui-win.c (make_visible_with_new_height): Update.
1557
1558 2019-06-25  Tom Tromey  <tom@tromey.com>
1559
1560         * tui/tui-winsource.c (tui_erase_source_content)
1561         (tui_show_source_content, tui_show_exec_info_content)
1562         (tui_erase_exec_info_content): Use refresh_window method.
1563         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1564         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1565         from tui_refresh_win.
1566         (tui_data_window::refresh_window): New method.
1567         (tui_win_info::refresh, tui_source_window_base::refresh)
1568         (tui_refresh_all): Use refresh_window method.
1569         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1570         method.
1571         * tui/tui-regs.c (tui_display_register): Call refresh_window
1572         method.
1573         * tui/tui-layout.c (show_source_disasm_command)
1574         (show_source_or_disasm_and_command): Call refresh_window method.
1575         * tui/tui-data.h (struct tui_gen_win_info)
1576         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1577         New method.
1578
1579 2019-06-25  Tom Tromey  <tom@tromey.com>
1580
1581         * tui/tui.c (tui_rl_other_window, tui_enable)
1582         (tui_is_window_visible, tui_get_command_dimension): Update.
1583         * tui/tui-winsource.c (tui_update_source_window_as_is)
1584         (tui_clear_source_content, tui_erase_source_content)
1585         (tui_show_source_line, tui_source_window_base::refill)
1586         (tui_source_window_base::do_scroll_horizontal)
1587         (tui_source_window_base::set_is_exec_point_at)
1588         (tui_update_breakpoint_info, tui_set_exec_info_content)
1589         (tui_alloc_source_buffer, tui_line_is_displayed)
1590         (tui_addr_is_displayed): Update.
1591         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1592         (tui_check_and_display_highlight_if_needed)
1593         (tui_win_info::make_visible, tui_win_info::refresh)
1594         (tui_refresh_all): Update.
1595         * tui/tui-windata.c (tui_first_data_item_displayed)
1596         (tui_delete_data_content_windows, tui_erase_data_content)
1597         (tui_display_all_data, tui_data_window::refresh_all)
1598         (tui_check_data_values): Update.
1599         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1600         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1601         (tui_win_info::backward_scroll, tui_refresh_all_win)
1602         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1603         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1604         (tui_source_window_base::set_new_height)
1605         (tui_data_window::set_new_height)
1606         (make_invisible_and_set_new_height)
1607         (make_visible_with_new_height, new_height_ok)
1608         (parse_scrolling_args): Update.
1609         * tui/tui-stack.c (tui_show_frame_info): Update.
1610         * tui/tui-source.c (tui_set_source_content)
1611         (tui_set_source_content_nil, tui_source_is_displayed)
1612         (tui_source_window::do_scroll_vertical): Update.
1613         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1614         (tui_display_registers_from, tui_display_reg_element_at_line)
1615         (tui_check_register_values, tui_reg_command): Update.
1616         * tui/tui-layout.c (tui_default_win_height)
1617         (show_source_disasm_command, show_data, init_and_make_win)
1618         (show_source_or_disasm_and_command): Update.
1619         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1620         (tui_redisplay_readline, tui_mld_flush)
1621         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1622         (tui_getc): Update.
1623         * tui/tui-disasm.c (tui_set_disassem_content)
1624         (tui_disasm_window::do_scroll_vertical): Update.
1625         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1626         Now virtual.
1627         (struct tui_win_info): Derive from tui_gen_win_info.
1628         <~tui_win_info>: Mark as override.
1629         <generic>: Remove member.
1630         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1631         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1632         (~tui_data_window, ~tui_win_info)
1633         (tui_free_all_source_wins_content): Update.
1634         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1635
1636 2019-06-25  Tom Tromey  <tom@tromey.com>
1637
1638         * tui/tui-layout.c (init_and_make_win): Use new.
1639         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1640         destructor, initializers.
1641         (tui_alloc_generic_win_info): Don't declare.
1642         * tui/tui-data.c (_locator): Add argument to constructor.
1643         (source_win, disasm_win): New globals.
1644         (exec_info): Remove.
1645         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1646         Update.
1647         (tui_alloc_generic_win_info): Remove.
1648         (init_content_element): Use new.
1649         (tui_win_info::tui_win_info): Update.
1650         (free_content_elements) <case DATA_WIN>: Use delete.
1651
1652 2019-06-25  Tom Tromey  <tom@tromey.com>
1653
1654         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1655         * tui/tui-windata.c (tui_first_data_item_displayed)
1656         (tui_delete_data_content_windows): Update.
1657         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1658         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1659         (tui_display_registers_from, tui_check_register_values): Update.
1660         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1661         pointer.
1662         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1663         window.
1664         (tui_free_data_content): Update.
1665         (free_content_elements) <case DATA_WIN>: Free the window.
1666
1667 2019-06-25  Tom Tromey  <tom@tromey.com>
1668
1669         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1670         Update.
1671         * tui/tui-layout.c (make_command_window)
1672         (show_source_disasm_command, show_data, init_and_make_win)
1673         (show_source_or_disasm_and_command): Update.
1674         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1675         method.
1676         <can_highight, is_highlighted>: Now bool.
1677         (tui_set_win_highlight): Don't declare.
1678         * tui/tui-data.c (tui_set_win_highlight): Remove.
1679
1680 2019-06-25  Tom Tromey  <tom@tromey.com>
1681
1682         * tui/tui-wingeneral.c (make_visible): Remove check of window
1683         type.
1684
1685 2019-06-25  Tom Tromey  <tom@tromey.com>
1686
1687         * tui/tui-win.c (tui_win_info::max_height)
1688         (tui_cmd_window::max_height): New methods.
1689         (new_height_ok): Call max_height.
1690         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1691         <max_height>: New method.
1692
1693 2019-06-25  Tom Tromey  <tom@tromey.com>
1694
1695         * tui/tui-win.c (tui_source_window_base::set_new_height)
1696         (tui_data_window::set_new_height): New methods.
1697         (make_invisible_and_set_new_height): Call set_new_height method.
1698         * tui/tui-data.h (struct tui_win_info)
1699         (struct tui_source_window_base, struct tui_data_window)
1700         <set_new_height>: New method.
1701
1702 2019-06-25  Tom Tromey  <tom@tromey.com>
1703
1704         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1705         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1706         tui_refresh_data_win.
1707         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1708         method.
1709         (tui_refresh_all_win): Call the refresh_all method.
1710         (tui_set_focus): Likewise.
1711         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1712         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1713         Likewise.
1714
1715 2019-06-25  Tom Tromey  <tom@tromey.com>
1716
1717         * tui/tui-winsource.h (tui_refill_source_window)
1718         (tui_set_is_exec_point_at): Don't declare.
1719         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1720         (tui_source_window_base::refill): Rename from
1721         tui_refill_source_window.
1722         (tui_source_window_base::do_scroll_horizontal): Update.
1723         (tui_source_window_base::set_is_exec_point_at): Rename from
1724         tui_set_is_exec_point_at.
1725         (tui_update_all_breakpoint_info): Update.
1726         * tui/tui-stack.c (tui_show_frame_info): Update.
1727         * tui/tui-layout.c (show_data): Add cast.
1728         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1729         * tui/tui-data.h (struct tui_source_window_base) <refill,
1730         set_is_exec_point_at>: New methods.
1731         (tui_source_windows, tui_add_to_source_windows): Update types.
1732         (tui_add_to_source_windows): Remove redundant declaration.
1733         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1734         (tui_source_windows): Change return type.
1735         (tui_clear_source_windows_detail): Update.
1736         (tui_add_to_source_windows): Change type of parameter.
1737         (tui_free_all_source_wins_content): Update.
1738
1739 2019-06-25  Tom Tromey  <tom@tromey.com>
1740
1741         * tui/tui-wingeneral.c (tui_win_info::refresh)
1742         (tui_source_window_base::refresh): New methods.
1743         (tui_refresh_all): Call the refresh method.
1744         * tui/tui-data.h (struct tui_win_info)
1745         (struct tui_source_window_base) <refresh>: New method.
1746
1747 2019-06-25  Tom Tromey  <tom@tromey.com>
1748
1749         * tui/tui.h (tui_is_window_visible): Return bool.
1750         * tui/tui.c (tui_is_window_visible): Return bool.
1751         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1752         (tui_make_visible, tui_make_invisible)
1753         (tui_win_info::make_visible)
1754         (tui_source_window_base::make_visible, make_all_visible)
1755         (tui_make_all_visible, tui_make_all_invisible): Update.
1756         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1757         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1758         bool.
1759         (struct tui_win_info, struct tui_source_window_base)
1760         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1761         * tui/tui-data.c (tui_init_generic_part): Update.
1762
1763 2019-06-25  Tom Tromey  <tom@tromey.com>
1764
1765         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1766         (tui_source_window_base::make_visible): New methods.
1767         (make_all_visible): Make method call.
1768         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1769         (struct tui_source_window_base, struct tui_cmd_window): Override
1770         make_visible.
1771         (tui_win_is_source_type): Don't declare.
1772         * tui/tui-data.c (tui_win_is_source_type): Remove.
1773
1774 2019-06-25  Tom Tromey  <tom@tromey.com>
1775
1776         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1777         NULL check.
1778
1779 2019-06-25  Tom Tromey  <tom@tromey.com>
1780
1781         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1782         Inline constructor.  Add initializers for members.
1783         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1784         constructors; now inline in class.
1785
1786 2019-06-25  Tom Tromey  <tom@tromey.com>
1787
1788         * tui/tui-regs.c (tui_show_registers): Update.
1789         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1790         bool.
1791         * tui/tui-data.c (tui_data_window::clear_detail)
1792         (tui_data_window): Update.
1793
1794 2019-06-25  Tom Tromey  <tom@tromey.com>
1795
1796         * tui/tui-windata.c (tui_display_all_data)
1797         (tui_display_data_from_line, tui_display_data_from)
1798         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1799         Update.
1800         * tui/tui-regs.c (tui_last_regs_line_no)
1801         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1802         (tui_show_registers, tui_show_register_group)
1803         (tui_display_registers_from, tui_display_reg_element_at_line)
1804         (tui_display_registers_from_line, tui_check_register_values)
1805         (tui_reg_next, tui_reg_prev): Update.
1806         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1807         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1808         tui_data_window.
1809         (struct tui_win_info) <detail>: Remove.  Add new fields from
1810         tui_data_info.
1811         (TUI_DATA_WIN): Add cast.
1812         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1813         (~tui_data_window): Simplify.
1814
1815 2019-06-25  Tom Tromey  <tom@tromey.com>
1816
1817         * tui/tui-layout.c (show_source_disasm_command)
1818         (show_source_or_disasm_and_command): Update.
1819         * tui/tui-io.c (update_cmdwin_start_line)
1820         (tui_redisplay_readline): Update.
1821         * tui/tui-data.h (struct tui_command_info): Remove.
1822         (struct tui_win_info) <detail>: Remove command_info member.
1823         (struct tui_data_window) <start_line>: New member, from
1824         tui_command_info.
1825         (TUI_CMD_WIN): Add casts.
1826
1827 2019-06-25  Tom Tromey  <tom@tromey.com>
1828
1829         * tui/tui-winsource.c (tui_update_source_window)
1830         (tui_refill_source_window)
1831         (tui_source_window_base::do_scroll_horizontal)
1832         (tui_update_breakpoint_info, tui_set_exec_info_content)
1833         (tui_show_exec_info_content, tui_erase_exec_info_content)
1834         (tui_clear_exec_info_content): Update.
1835         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1836         Update.
1837         * tui/tui-win.c (make_invisible_and_set_new_height)
1838         (make_visible_with_new_height): Update.
1839         * tui/tui-source.c (tui_set_source_content)
1840         (tui_show_symtab_source): Update.
1841         * tui/tui-layout.c (extract_display_start_addr)
1842         (show_source_disasm_command, show_data)
1843         (make_source_or_disasm_window)
1844         (show_source_or_disasm_and_command): Update.
1845         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1846         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1847         "gdbarch".
1848         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1849         to tui_source_window_base.
1850         (struct tui_win_info) <detail>: Remove source_info member.
1851         (struct tui_source_window_base) <has_locator>: Inline.
1852         Move contents from tui_source_info; rename has_locator member to
1853         m_has_locator.
1854         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1855         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1856         header file.
1857         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1858         Simplify.
1859         (tui_free_all_source_wins_content): Cast to
1860         tui_source_window_base.
1861
1862 2019-06-25  Tom Tromey  <tom@tromey.com>
1863
1864         * tui/tui-win.c (make_invisible_and_set_new_height)
1865         (make_visible_with_new_height): Call has_locator method.
1866         * tui/tui-layout.c (show_source_disasm_command, show_data)
1867         (show_source_or_disasm_and_command): Update for bool change.
1868         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1869         (tui_win_info) <has_locator>: New method.
1870         (struct tui_source_window_base) <has_locator>: New method.
1871         (tui_win_has_locator): Don't declare.
1872         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1873         from tui_win_has_locator.
1874         (tui_source_window_base): Use false, not FALSE.
1875
1876 2019-06-25  Tom Tromey  <tom@tromey.com>
1877
1878         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1879         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1880         clear_detail method directly.
1881         (tui_clear_win_detail): Remove.
1882
1883 2019-06-25  Tom Tromey  <tom@tromey.com>
1884
1885         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1886         "this", not TUI_DISASM_WIN.
1887
1888 2019-06-25  Tom Tromey  <tom@tromey.com>
1889
1890         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1891         declare.
1892         * tui/tui-winsource.c
1893         (tui_source_window_base::do_scroll_horizontal): Rename from
1894         tui_horizontal_source_scroll.
1895         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1896         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1897         from tui_vertical_data_scroll.
1898         * tui/tui-win.h (tui_scroll): Don't declare.
1899         * tui/tui-win.c (tui_win_info::forward_scroll)
1900         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1901         (tui_win_info::right_scroll): Rename and update.
1902         (tui_scroll_forward_command, tui_scroll_backward_command)
1903         (tui_scroll_left_command, tui_scroll_right_command): Update.
1904         (tui_scroll): Remove.
1905         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1906         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1907         from tui_vertical_source_scroll.
1908         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1909         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1910         from tui_vertical_disassem_scroll.
1911         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1912         do_scroll_horizontal>: New methods.
1913         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1914         Likewise.
1915         (struct tui_source_window_base): Add do_scroll_horizontal.
1916         (struct tui_source_window, struct tui_disasm_window): Add
1917         do_scroll_vertical.
1918         (struct tui_data_window, struct tui_cmd_window): Add
1919         do_scroll_horizontal and do_scroll_vertical.
1920         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1921
1922 2019-06-25  Tom Tromey  <tom@tromey.com>
1923
1924         * tui/tui-data.h (struct tui_source_window_base): New struct.
1925         (struct tui_source_window): Derive from tui_source_window_base.
1926         (struct tui_disasm_window): New struct.
1927         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1928         from tui_source_window::clear_detail.
1929         (tui_source_window_base): Rename from tui_source_window.
1930         (~tui_source_window_base): Rename from ~tui_source_window.
1931         (tui_alloc_win_info): Create a tui_disasm_window.
1932
1933 2019-06-25  Tom Tromey  <tom@tromey.com>
1934
1935         * tui/tui-data.h (struct tui_source_window)
1936         (struct tui_data_window): Declare destructors.
1937         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1938         destructors.
1939         (tui_win_info): Simplify.
1940
1941 2019-06-25  Tom Tromey  <tom@tromey.com>
1942
1943         * tui/tui-winsource.c (tui_display_main)
1944         (tui_update_source_windows_with_addr)
1945         (tui_update_all_breakpoint_info): Update.
1946         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1947         (new_height_ok, parse_scrolling_args): Update.
1948         * tui/tui-stack.c (tui_show_frame_info): Update.
1949         * tui/tui-data.h (struct tui_list): Remove.
1950         (tui_source_windows): Return a reference to a std::vector.
1951         * tui/tui-data.c (source_windows): Now a std::vector.
1952         (tui_source_windows): Change return type.
1953         (tui_clear_source_windows): Rewrite.
1954         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1955         (tui_free_all_source_wins_content): Rewrite.
1956
1957 2019-06-25  Tom Tromey  <tom@tromey.com>
1958
1959         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1960         (struct tui_data_window, struct tui_cmd_window): Declare
1961         clear_detail method.
1962         * tui/tui-data.c (tui_source_window::clear_detail)
1963         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1964         methods.
1965         (tui_clear_win_detail): Simplify.
1966
1967 2019-06-25  Tom Tromey  <tom@tromey.com>
1968
1969         * tui/tui-layout.c (make_source_window, make_disasm_window)
1970         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1971         Return the new window.
1972         (show_source_disasm_command, show_data)
1973         (show_source_or_disasm_and_command): Update.
1974
1975 2019-06-25  Tom Tromey  <tom@tromey.com>
1976
1977         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1978         parameter.  Return the new window.
1979         (show_source_disasm_command): Update and remove NULL check.
1980         (show_source_or_disasm_and_command): Update.
1981
1982 2019-06-25  Tom Tromey  <tom@tromey.com>
1983
1984         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1985
1986 2019-06-25  Tom Tromey  <tom@tromey.com>
1987
1988         * tui/tui-data.h (struct tui_win_info): Make constructor
1989         protected.  Make destructor virtual.  Add initializers.
1990         (tui_source_window, tui_data_window, tui_cmd_window): New
1991         classes.
1992         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1993         constructor.  Add "type" parameter.
1994         (tui_source_window, tui_data_window, tui_cmd_window): New
1995         constructors.
1996         (tui_alloc_win_info): Instantiate the appropriate subclass.
1997
1998 2019-06-25  Tom Tromey  <tom@tromey.com>
1999
2000         * tui/tui-win.c (tui_resize_all): Use delete.
2001         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2002         destructor.
2003         (tui_free_window): Don't declare.
2004         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2005         Update.
2006
2007 2019-06-25  Tom Tromey  <tom@tromey.com>
2008
2009         * tui/tui-data.h (struct tui_win_info): Add constructor.
2010         * tui/tui-data.c (tui_alloc_win_info): Use new.
2011         (tui_free_window): Use delete.
2012
2013 2019-06-22  Tom Tromey  <tom@tromey.com>
2014
2015         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2016         declare.
2017         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2018
2019 2019-06-22  Tom Tromey  <tom@tromey.com>
2020
2021         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2022         declare.
2023         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2024
2025 2019-06-22  Tom de Vries  <tdevries@suse.de>
2026
2027         * dwarf2read.c (create_addrmap_from_aranges)
2028         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2029         instead of '%zu'.
2030
2031 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2032
2033         * dwarf2read.h (dwarf2_section_info_def): Remove.
2034         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2035         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2036         std::vector<dwarf2_section_info>.
2037         (struct dwo_file) <~dwo_file>: Remove.
2038         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2039         types field.
2040         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2041         (dwarf2_read_debug_names): Likewise.
2042         (create_debug_types_hash_table): Change parameter type to
2043         array_view, adjust code accordingly.
2044         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2045         (partial_die_info::fixup): Likewise.
2046         (determine_prefix): Likewise.
2047         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2048
2049 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2050
2051         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2052         gdb_bfd_ref_ptr.
2053         <~dwo_file>: Remove call to gdb_bfd_unref.
2054         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2055         gdb_bfd_ref_ptr::get.
2056
2057 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2058
2059         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2060         type to htab_up.
2061         * dwarf2read.c (struct dwo_file): Initialize fields.
2062         <~dwo_file>: New.
2063         (free_dwo_file): Remove, move content to ~dwo_file.
2064         (struct dwo_file_deleter): Remove.
2065         (dwo_file_up>: Remove custom deleter.
2066         (free_dwo_files): Remove.
2067         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2068         dwo_files.
2069         (process_skeletonless_type_units): Call unique_ptr::get.
2070         (allocate_dwo_file_hash_table): Add deleter to created hash
2071         table.  Change return type to htab_up.
2072         (lookup_dwo_file_slot): Don't memset dwo_file, call
2073         unique_ptr::get.
2074         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2075         (create_dwo_unit_in_dwp_v2): Likewise.
2076         (open_and_init_dwo_file): Likewise.
2077         (free_dwo_file_from_slot): Remove.
2078
2079 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2080
2081         * dwarf2read.h (struct dwarf2_section_info) <readin,
2082         is_virtual>: Change type to bool.
2083         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2084         true instead of 1.
2085
2086 2019-06-19  Tom Tromey  <tom@tromey.com>
2087
2088         * tui/tui-data.h (tui_init_content_element): Don't declare.
2089
2090 2019-06-19  Tom Tromey  <tom@tromey.com>
2091
2092         * tui/tui-data.h (tui_init_win_info): Don't declare.
2093
2094 2019-06-19  Tom de Vries  <tdevries@suse.de>
2095
2096         * dwarf2read.h (abstract_to_concrete): Change type to
2097         std::unordered_map<sect_offset, std::vector<sect_offset>,
2098         gdb::hash_enum<sect_offset>>.
2099
2100 2019-06-19  Tom Tromey  <tromey@adacore.com>
2101
2102         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2103         EVAL_AVOID_SIDE_EFFECTS specially.
2104
2105 2019-06-19  Tom Tromey  <tromey@adacore.com>
2106
2107         * source-cache.c (highlighter): New global.
2108         (source_cache::get_source_lines): Create a highlighter on demand.
2109
2110 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2111
2112         * defs.h (deprecated_interactive_hook): Delete declaration.
2113         * interps.c (clear_interpreter_hooks): Remove use of
2114         deprecated_interactive_hook.
2115         * top.c (deprecated_interactive_hook): Delete definition.
2116         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2117
2118 2019-06-18  Tom de Vries  <tdevries@suse.de>
2119
2120         PR gdb/24515
2121         * dwarf2read.h (abstract_to_concrete): Change type from
2122         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2123         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2124         * dwarf2read.c (read_variable): Update.
2125         (dwarf2_fetch_die_loc_sect_off): Update.
2126
2127 2019-06-17  Tom de Vries  <tdevries@suse.de>
2128
2129         PR gdb/24617
2130         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2131         accessing parent[parent_len - 1].
2132
2133 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2134
2135         PR gdb/24364
2136         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2137         call dtrace_process_dof with NULL dof.
2138
2139 2019-06-16  Tom de Vries  <tdevries@suse.de>
2140
2141         PR gdb/24445
2142         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2143
2144 2019-06-16  Tom Tromey  <tom@tromey.com>
2145
2146         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2147         (make_all_visible): Use address of member.
2148
2149 2019-06-16  Tom Tromey  <tom@tromey.com>
2150
2151         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2152         (tui_free_window, free_content, free_content_elements): Remove
2153         unnecessary cast.
2154         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2155         cast.
2156         * tui/tui-regs.c (tui_show_register_group)
2157         (tui_display_registers_from, tui_display_reg_element_at_line):
2158         Remove unnecessary cast.
2159
2160 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2161
2162         * linux-nat.c (normal_mask): Delete.
2163         (_initialize_linux_nat): Don't initialise normal_mask.
2164
2165 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2166
2167         PR gdb/24445
2168         * dwarf-index-write.h (write_psymtabs_to_index): Add
2169         dwz_basename parameter.
2170         * dwarf-index-write.c (write_gdbindex): Move file writing to
2171         write_gdbindex_1.  Change return type void.
2172         (assert_file_size): Move up, remove filename parameter.
2173         (write_gdbindex_1): New function.
2174         (write_debug_names): Change return type to void, call
2175         assert_file_size.
2176         (struct index_wip_file): New struct.
2177         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2178         file logic to index_wip_file.  Write index for dwz file if
2179         needed.
2180         (save_gdb_index_command): Pass basename of dwz file, if present.
2181         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2182         build-id of dwz file, if present.
2183         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2184         (dwarf2_get_dwz_file): Likewise.
2185         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2186         (dwarf2_get_dwz_file): Likewise.
2187
2188 2019-06-16  Tom Tromey  <tom@tromey.com>
2189
2190         * coffread.c (process_coff_symbol): Use xstrdup.
2191         * value.c (create_internalvar): Use xstrdup.
2192
2193 2019-06-16  Tom Tromey  <tom@tromey.com>
2194
2195         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2196         * breakpoint.c (stopin_command, stopat_command)
2197         (until_break_command, decode_location_default): Remove unnecessary
2198         cast.
2199         * utils.c (subset_compare): Remove unnecessary cast.
2200         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2201         cast.
2202         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2203         cast.
2204         * infcmd.c (path_command): Remove unnecessary cast.
2205         * coffread.c (decode_type): Remove unnecessary cast.
2206         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2207         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2208         * tui/tui-stack.c (tui_show_locator_content)
2209         (tui_show_frame_info): Remove unnecessary cast.
2210         * tui/tui-win.c (tui_scroll_forward_command)
2211         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2212         (parse_scrolling_args): Remove unnecessary cast.
2213         * tui/tui-data.c (init_win_info, tui_del_window)
2214         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2215         (free_content_elements): Remove unnecessary cast.
2216         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2217         unnecessary cast.
2218         * tui/tui-source.c (tui_set_source_content)
2219         (tui_vertical_source_scroll): Remove unnecessary cast.
2220         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2221         cast.
2222         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2223         * tui/tui-regs.c (tui_display_registers_from)
2224         (tui_display_register): Remove unnecessary cast.
2225         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2226         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2227         (make_visible): Remove unnecessary cast.
2228         * tui/tui-winsource.c (tui_erase_source_content)
2229         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2230         unnecessary cast.
2231         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2232         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2233         * stabsread.c (read_type, read_array_type, read_range_type):
2234         Remove unnecessary cast.
2235         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2236         (parse_symbol, parse_type, upgrade_type, parse_external)
2237         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2238         unnecessary cast.
2239         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2240
2241 2019-06-16  Tom Tromey  <tom@tromey.com>
2242
2243         * tui/tui-data.c (tui_alloc_generic_win_info)
2244         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2245         checks.
2246
2247 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2248             Andrew Burgess  <andrew.burgess@embecosm.com>
2249
2250         * f-typeprint.c (f_print_type): Don't return early for not
2251         associated or not allocated types.
2252         (f_type_print_varspec_suffix): Add print_rank parameter and print
2253         ranks of array types in case they dangling.
2254         (f_type_print_base): Add print_rank parameter.
2255
2256 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2257
2258         * NEWS: Mention new MI commands.
2259         * break-catch-throw.c (enum exception_event_kind): Move to
2260         breakpoint.h.
2261         (print_mention_exception_catchpoint): Output text as a single
2262         message.
2263         (catch_exception_command_1): Rename to...
2264         (catch_exception_event): ...this, make non-static, update header
2265         command, and change some parameter types.
2266         (catch_catch_command): Update for changes to
2267         catch_exception_command_1.
2268         (catch_throw_command): Likewise.
2269         (catch_rethrow_command): Likewise.
2270         * breakpoint.c (enum exception_event_kind): Delete.
2271         * breakpoint.h (enum exception_event_kind): Moved here from
2272         break-catch-throw.c.
2273         (catch_exception_event): Declare.
2274         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2275         (mi_cmd_catch_throw): New function.
2276         (mi_cmd_catch_rethrow): New function.
2277         (mi_cmd_catch_catch): New function.
2278         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2279         'catch-catch' entries.
2280         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2281         (mi_cmd_catch_rethrow): Declare.
2282         (mi_cmd_catch_catch): Declare.
2283
2284 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2285
2286         * annotate.c (annotate_source_line): Change return type to void,
2287         update implementation to match.
2288         * annotate.h (annotate_source_line): Change return type to void,
2289         update header comment.
2290         * stack.c (print_frame_info): Don't change what frame information
2291         is printed based on whether annotations are on or not.
2292
2293 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2294
2295         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2296         (annotate_source): Make static.
2297         (annotate_source_line): Moved from source.c and renamed from
2298         identify_source_line.  Update the return type.
2299         * annotate.h (annotate_source): Delete declaration.
2300         (annotate_source_line): Declaration moved from source.h, and
2301         renamed from identify_source_line.  Return type updated.
2302         * source.c (identify_source_line): Moved to annotate.c and renamed
2303         to annotate_source_line.
2304         (info_line_command): Remove check of annotation_level.
2305         * source.h (identify_source_line): Move declaration to annotate.h
2306         and rename to annotate_source_line.
2307         * stack.c: Add 'annotate.h' include.
2308         (print_frame_info): Remove check of annotation_level before
2309         calling annotate_source_line.
2310
2311 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2312
2313         * source-cache.c (source_cache::get_plain_source_lines): Use
2314         open_source_file_with_line_charpos instead of just
2315         open_source_file, remove call to find_source_lines.
2316         (source_cache::get_source_lines): Likewise.
2317         * source.c (find_source_lines): Make static.
2318         (get_filename_and_charpos): Renamed into...
2319         (open_source_file_with_line_charpos): ..this along with changes to
2320         return a scoped_fd, and some other minor clean ups.
2321         (identify_source_line): Use open_source_file_with_line_charpos.
2322         (search_command_helper): Use open_source_file_with_line_charpos
2323         instead of just open_source_file, remove call to
2324         find_source_lines.
2325         * source.h (open_source_file_with_line_charpos): Declare new
2326         function.
2327         (find_source_lines): Delete declaration.
2328
2329 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2330
2331         * source.c (get_filename_and_charpos): Remove fullname
2332         parameter.
2333         (identify_source_line): Update call to get_filename_and_charpos.
2334
2335 2019-06-14  Tom Tromey  <tromey@adacore.com>
2336
2337         PR gdb/24502:
2338         * ui-style.h (skip_ansi_escape): Update comment.
2339         * ui-file.h (class no_terminal_escape_file): New class.
2340         * ui-file.c (no_terminal_escape_file::write)
2341         (no_terminal_escape_file::puts): New methods.
2342         * cli/cli-logging.c (handle_redirections): Use
2343         no_terminal_escape_file.
2344
2345 2019-06-14  Tom Tromey  <tromey@adacore.com>
2346
2347         * NEWS: Move convenience variable news above Python news.
2348
2349 2019-06-14  Tom Tromey  <tom@tromey.com>
2350
2351         * gnulib: Move directory to top-level.
2352         * configure.ac: Don't configure gnulib.
2353         * configure: Rebuild.
2354         * common/common-defs.h: Use new path to gnulib.
2355         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2356         (GNULIB_H): Remove.
2357         (INCGNU): Look in new gnulib location.
2358         (HFILES_NO_SRCDIR): Remove gnulib files.
2359         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2360         (generated_files): Remove GNULIB_H.
2361         ($(LIBGNU), all-lib): Remove targets.
2362         (distclean): Don't mention GNULIB_BUILDDIR.
2363         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2364
2365 2019-06-14  Tom Tromey  <tromey@adacore.com>
2366
2367         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2368         Warn if symbol file does not provide any symbols.
2369
2370 2019-06-14  Tom Tromey  <tromey@adacore.com>
2371
2372         * source.c (find_and_open_source): Respect basenames_may_differ.
2373
2374 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2375
2376         * annotate.c (annotate_breakpoints_invalid): Make use of
2377         scoped_restore_terminal_state.
2378         (annotate_frames_invalid): Likewise.
2379
2380 2019-06-14  Tom Tromey  <tromey@adacore.com>
2381
2382         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2383         allow assignment to an internalvar.
2384
2385 2019-06-14  Tom Tromey  <tromey@adacore.com>
2386
2387         * ada-lex.l: Allow "_" in attribute names.
2388
2389 2019-06-14  Tom Tromey  <tromey@adacore.com>
2390
2391         PR gdb/24653:
2392         * regcache.c (registers_changed): Don't call alloca.
2393         * top.c (execute_command): Don't call alloca.
2394
2395 2019-06-13  Pedro Alves  <palves@redhat.com>
2396
2397         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2398         'expression'.  When parsing an expression, error out if there's
2399         junk after "unlimited".
2400         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2401         (do_set_command): Adjust calls to is_unlimited_literal.
2402
2403 2019-06-13  Pedro Alves  <palves@redhat.com>
2404
2405         * compile/compile.c (make_compile_options_def_group): Add braces
2406         around array_view initializer.
2407         * thread.c (make_thread_apply_all_options_def_group)
2408         (make_thread_apply_all_options_def_group): Likewise.
2409
2410 2019-06-13  Pedro Alves  <palves@redhat.com>
2411
2412         * NEWS (New commands): Mention "maint test-options
2413         require-delimiter", "maint test-options unknown-is-error", "maint
2414         test-options unknown-is-operand" and "maint show
2415         test-options-completion-result".
2416         (New command options, command completion): New section.
2417         (Completion improvements): New section.
2418         Mention that you can abbreviate "unlimited".
2419
2420 2019-06-13  Pedro Alves  <palves@redhat.com>
2421
2422         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2423         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2424         * unittests/cli-utils-selftests.c (test_parse_flags)
2425         (test_parse_flags_qcs): Delete.
2426         (test_cli_utils): Don't call deleted functions.
2427
2428 2019-06-13  Pedro Alves  <palves@redhat.com>
2429
2430         * thread.c: Include "cli/cli-option.h".
2431         (tp_array_compar_ascending): Global.
2432         (tp_array_compar): Delete function.
2433         (tp_array_compar_ascending, tp_array_compar_descending): New
2434         functions.
2435         (ascending_option_def, qcs_flag_option_def)
2436         (thr_qcs_flags_option_defs)
2437         (make_thread_apply_all_options_def_group)
2438         (make_thread_apply_options_def_group): New.
2439         (thread_apply_all_command): Use gdb::option::process_options.
2440         (thread_apply_command_completer)
2441         (thread_apply_all_command_completer): New.
2442         (thread_apply_command): Use gdb::option::process_options.
2443         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2444         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2445         to generate help text of "thread apply".  Adjust "taas"'s help.
2446         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2447         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2448
2449 2019-06-13  Pedro Alves  <palves@redhat.com>
2450
2451         * thread.c (thread_apply_command): Check for invalid TID with
2452         isdigit instead of !isalpha.
2453
2454 2019-06-13  Pedro Alves  <palves@redhat.com>
2455
2456         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2457         (validate_flags_qcs): New.
2458         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2459         (validate_flags_qcs): Declare.
2460         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2461         (make_frame_apply_options_def_group): New.
2462         (frame_apply_command_count): Process options with
2463         gdb::option::process_options.
2464         (frame_apply_completer): New.
2465         (frame_apply_level_completer, frame_apply_all_completer)
2466         (frame_apply_completer): New.
2467         (_initialize_stack): Update help of "frame apply", "frame apply
2468         level", "frame apply all" and "faas" to mention supported options
2469         and install command completers.
2470         * stack.h (frame_apply_all_completer): Declare.
2471         * thread.c: Include "stack.h".
2472         (tfaas_command): Add "--".
2473         (_initialize_thread): Update help "tfaas" to mention supported
2474         options and install command completer.
2475
2476 2019-06-13  Pedro Alves  <palves@redhat.com>
2477
2478         * completer.c (complete_nested_command_line): New.
2479         (gdb_completion_word_break_characters_throw): Add assertion.
2480         * completer.h (complete_nested_command_line): Declare.
2481
2482 2019-06-13  Pedro Alves  <palves@redhat.com>
2483
2484         * stack.c (parse_backtrace_qualifiers): New.
2485         (backtrace_command): Use it.
2486         (backtrace_command_completer): Complete on qualifiers.
2487
2488 2019-06-13  Pedro Alves  <palves@redhat.com>
2489
2490         * frame.c: Include "cli/cli-option.h.
2491         (user_set_backtrace_options): New.
2492         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2493         Delete.
2494         (get_prev_frame): Adjust.
2495         (boolean_option_def, uinteger_option_def)
2496         (set_backtrace_option_defs): New.
2497         (_initialize_frame): Adjust and use
2498         gdb::option::add_setshow_cmds_for_options to install "set
2499         backtrace past-main" and "set backtrace past-entry".
2500         * frame.h: Include "cli/cli-option.h".
2501         (struct frame_print_options): Forward declare.
2502         (print_frame_arguments_all, print_frame_arguments_scalars)
2503         (print_frame_arguments_none): Declare.
2504         (print_entry_values): Delete declaration.
2505         (struct frame_print_options, user_frame_print_options): New.
2506         (struct set_backtrace_options): New.
2507         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2508         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2509         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2510         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2511         (list_args_or_locals): Add frame_print_options parameter.
2512         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2513         * python/py-framefilter.c (enumerate_args): Pass down
2514         USER_FRAME_PRINT_OPTIONS.
2515         * stack.c: Include "cli/cli-option.h".
2516         (print_frame_arguments_all, print_frame_arguments_scalars)
2517         (print_frame_arguments_none): Declare.
2518         (print_raw_frame_arguments, print_entry_values): Delete.
2519         (user_frame_print_options): New.
2520         (boolean_option_def, enum_option_def, frame_print_option_defs):
2521         New.
2522         (struct backtrace_cmd_options): New.
2523         (bt_flag_option_def): New.
2524         (backtrace_command_option_defs): New.
2525         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2526         (print_frame_arg, read_frame_arg, print_frame_args)
2527         (print_frame_info, print_frame): Add frame_print_options parameter
2528         and use it.
2529         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2530         (backtrace_command_1): Add frame_print_options and
2531         backtrace_cmd_options parameters and use them.
2532         (make_backtrace_options_def_group): New.
2533         (backtrace_command): Process command options with
2534         gdb::option::process_options.
2535         (backtrace_command_completer): New.
2536         (_initialize_stack): Extend "backtrace"'s help to mention
2537         supported options.  Install completer for "backtrace".
2538         Install some settings commands with add_setshow_cmds_for_options.
2539
2540 2019-06-13  Pedro Alves  <palves@redhat.com>
2541
2542         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2543         and that "set/show print raw frame-arguments" are now deprecated.
2544
2545         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2546         command.
2547         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2548         * stack.c (_initialize_stack): Install "set/show print
2549         raw-frame-arguments", and deprecate "set/show print raw
2550         frame-arguments".
2551         * valprint.c (_initialize_valprint): Deprecate "set/show print
2552         raw".
2553
2554 2019-06-13  Pedro Alves  <palves@redhat.com>
2555
2556         * compile/compile.c (struct compile_options): New.
2557         (compile_flag_option_def, compile_command_option_defs)
2558         (make_compile_options_def_group): New.
2559         (compile_file_command): Handle options with
2560         gdb::option::process_options.
2561         (compile_file_command_completer): New function.
2562         (compile_code_command): Handle options with
2563         gdb::option::process_options.
2564         (compile_code_command_completer): New function.
2565         (_initialize_compiler): Install completers for "compile code" and
2566         "compile file".  Mention available options in "compile code" and
2567         "compile code"'s help.
2568         * completer.c (advance_to_completion_word): New, factored out from
2569         ...
2570         (advance_to_expression_complete_word_point): ... this.
2571         (advance_to_filename_complete_word_point): New.
2572         * completer.h (advance_to_filename_complete_word_point): New
2573         declaration.
2574
2575 2019-06-13  Pedro Alves  <palves@redhat.com>
2576
2577         * compile/compile.c: Include "cli/cli-option.h".
2578         (compile_print_value): Scope data pointer is now a
2579         value_print_options pointer; adjust.
2580         (compile_print_command): Process options.  Scope data pointer is
2581         now a value_print_options pointer; adjust.
2582         (_initialize_compile): Update "compile print"'s help to include
2583         supported options.  Install a completer for "compile print".
2584         * cp-valprint.c (show_vtblprint, show_objectprint)
2585         (show_static_field_print): Delete.
2586         (_initialize_cp_valprint): Don't install "set print
2587         static-members", "set print vtbl", "set print object" here.
2588         * printcmd.c: Include "cli/cli-option.h" and
2589         "common/gdb_optional.h".
2590         (print_command_parse_format): Rework to fill in a
2591         value_print_options instead of a format_data.
2592         (print_value): Change parameter type from format_data pointer to
2593         value_print_options reference.  Adjust.
2594         (print_command_1): Process options.  Adjust to pass down a
2595         value_print_options.
2596         (print_command_completer): New.
2597         (_initialize_printcmd): Install print_command_completer as
2598         handle_brkchars completer for the "print" command.  Update
2599         "print"'s help to include supported options.
2600         * valprint.c: Include "cli/cli-option.h".
2601         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2602         here from cp-valprint.c.
2603         (boolean_option_def, uinteger_option_def)
2604         (value_print_option_defs, make_value_print_options_def_group):
2605         New.  Use gdb::option::add_setshow_cmds_for_options to install
2606         "set print elements", "set print null-stop", "set print repeats",
2607         "set print pretty", "set print union", "set print array", "set
2608         print address", "set print symbol", "set print array-indexes".
2609         * valprint.h: Include <string> and "cli/cli-option.h".
2610         (make_value_print_options_def_group): Declare.
2611         (print_value): Change parameter type from format_data pointer to
2612         value_print_options reference.
2613         (print_command_completer): Declare.
2614
2615 2019-06-13  Pedro Alves  <palves@redhat.com>
2616
2617         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2618         (COMMON_SFILES): Add maint-test-settings.c.
2619         * cli/cli-decode.c (boolean_enums): New global, factored out from
2620         ...
2621         (add_setshow_boolean_cmd): ... here.
2622         * cli/cli-decode.h (boolean_enums): Declare.
2623         * cli/cli-option.c: New file.
2624         * cli/cli-option.h: New file.
2625         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2626         factored out from ...
2627         (parse_cli_boolean_value(const char *)): ... this.
2628         (is_unlimited_literal): Change parameter type to pointer to
2629         pointer.  Adjust and advance ARG pointer.
2630         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2631         (parse_cli_var_enum): New, factored out from ...
2632         (do_set_command): ... this.  Adjust.
2633         * cli/cli-setshow.h (parse_cli_boolean_value)
2634         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2635         (parse_cli_var_enum): Declare.
2636         * cli/cli-utils.c: Include "cli/cli-option.h".
2637         (get_ulongest): New.
2638         * cli/cli-utils.h (get_ulongest): Declare.
2639         (check_for_argument): New overloads.
2640         * maint-test-options.c: New file.
2641
2642 2019-06-13  Pedro Alves  <palves@redhat.com>
2643
2644         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2645         parse a range if "-" is at the end of the string.
2646
2647 2019-06-13  Pedro Alves  <palves@redhat.com>
2648
2649         * cli/cli-setshow.c (parse_auto_binary_operation)
2650         (parse_cli_boolean_value): Don't allow "o".
2651
2652 2019-06-13  Pedro Alves  <palves@redhat.com>
2653
2654         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2655         * NEWS: Mention maint test-settings KIND.
2656         * maint-test-settings.c: New file.
2657
2658 2019-06-13  Pedro Alves  <palves@redhat.com>
2659
2660         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2661         completer.
2662         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2663         "set" completers.
2664
2665 2019-06-13  Pedro Alves  <palves@redhat.com>
2666
2667         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2668         after item.
2669
2670 2019-06-13  Pedro Alves  <palves@redhat.com>
2671
2672         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2673
2674 2019-06-13  Pedro Alves <palves@redhat.com>
2675
2676         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2677         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2678         call.
2679         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2680         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2681         calls.
2682         (check_for_argument): Skip spaces after argument.
2683
2684 2019-06-13  Pedro Alves  <palves@redhat.com>
2685
2686         * thread.c (thread_apply_command): Adjust TID parsing.
2687         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2688         detected before end of string.
2689         (tid_is_in_list): Error out if LIST is invalid.
2690
2691 2019-06-13  Pedro Alves  <palves@redhat.com>
2692
2693         * completer.c (complete_line_internal_1): Rewind completion word
2694         point.
2695         (completion_tracker::advance_custom_word_point_by): Change
2696         parameter type to int.
2697         * completer.h (completion_tracker::advance_custom_word_point_by):
2698         Likewise.
2699
2700 2019-06-13  Pedro Alves  <palves@redhat.com>
2701
2702         * completer.c (advance_to_completion_word): Handle delimiters.
2703
2704 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2705
2706         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2707
2708 2019-06-11  Tom Tromey  <tom@tromey.com>
2709
2710         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2711         (xmalloc_failed): Move to alloc.c.
2712         * alloc.c: New file.
2713         * Makefile.in (COMMON_SFILES): Add alloc.c.
2714
2715 2019-06-11  Tom Tromey  <tom@tromey.com>
2716
2717         * nat/linux-waitpid.c: Don't include server.h.
2718         (linux_debug): Remove.
2719         (my_waitpid): Update.
2720
2721 2019-06-11  Tom Tromey  <tromey@adacore.com>
2722
2723         * infcall.c (_initialize_infcall): Remove trailing newline from
2724         help.
2725         * user-regs.c (_initialize_user_regs): Remove trailing newline
2726         from help.
2727         * typeprint.c (_initialize_typeprint): Remove trailing newline
2728         from help.
2729         * reverse.c (_initialize_reverse): Remove trailing newlines from
2730         help.
2731         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2732         from help.
2733         * language.c (add_set_language_command): Remove trailing newline
2734         from help.
2735         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2736         help.
2737         * disasm.c (_initialize_disasm): Remove trailing newline from
2738         help.
2739         * top.c (init_main): Remove trailing newline from help.
2740         * interps.c (_initialize_interpreter): Remove trailing newline
2741         from help.
2742         * btrace.c (_initialize_btrace): Remove trailing newlines from
2743         help.
2744         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2745         from help.
2746         * python/python.c (_initialize_python): Remove trailing newline
2747         from help.
2748         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2749         help.
2750         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2751         from help.  Reformat some text.
2752         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2753         from help.
2754         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2755         newline from help.
2756
2757 2019-06-11  Tom Tromey  <tromey@adacore.com>
2758
2759         * darwin-nat.c (darwin_decode_exception_message)
2760         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2761
2762 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2763
2764         * valops.c (value_slice): Check for not allocated or not
2765         associated values.
2766
2767 2019-06-10  Tom de Vries  <tdevries@suse.de>
2768
2769         PR gdb/24618
2770         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2771         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2772         invalid.
2773
2774 2019-06-10  Tom de Vries  <tdevries@suse.de>
2775
2776         PR gdb/24611
2777         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2778         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2779
2780 2019-06-10  Tom de Vries  <tdevries@suse.de>
2781
2782         PR symtab/24545
2783         * symtab.c (struct demangled_name_entry): Add language field.
2784         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2785         static minimal symbol".  Set and use language field.
2786
2787 2019-06-10  Tom Tromey  <tromey@adacore.com>
2788
2789         * ada-lang.c (_initialize_ada_language): Update help text.
2790
2791 2019-06-10  Tom Tromey  <tromey@adacore.com>
2792
2793         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2794         with a newline.
2795         * guile/guile.c (handle_boot_error): Don't end warning with a
2796         newline.
2797         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2798         warning with a newline.
2799         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2800         newline.
2801         (s12z_frame_cache): Likewise.
2802         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2803         a newline.
2804         * solib-svr4.c (disable_probes_interface): Don't end warning with
2805         a newline.
2806         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2807         newline.
2808         * python/python.c (do_finish_initialization): Don't end warning
2809         with a newline.
2810
2811 2019-06-10  Tom Tromey  <tom@tromey.com>
2812
2813         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2814         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2815         gdbpy_enter.
2816
2817 2019-06-10  Tom Tromey  <tromey@adacore.com>
2818
2819         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2820         data.
2821         (elf_new_init): Don't call stabsread_new_init.
2822         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2823         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2824         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2825
2826 2019-06-10  Tom de Vries  <tdevries@suse.de>
2827
2828         PR symtab/16264
2829         PR symtab/24517
2830         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2831
2832 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2833
2834         * source.c (find_and_open_source): Also rewrite relative file
2835         names.
2836
2837 2019-04-26  Amos Bird  <amosbird@gmail.com>
2838
2839         * annotate.c (annotate_thread_exited): Add "thread-exited"
2840         annotation.
2841
2842 2019-06-06  Tom Tromey  <tromey@adacore.com>
2843
2844         * maint.h (class scoped_command_stats): Use
2845         DISABLE_COPY_AND_ASSIGN.
2846         <print_time>: New method.
2847         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2848         print_time.
2849         (scoped_command_stats::print_time): New method.
2850
2851 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2852
2853         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2854         instructions of lengths 6 or 8 bytes.
2855
2856 2019-06-04  Pedro Alves  <palves@redhat.com>
2857
2858         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2859
2860         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2861         * breakpoint.c (condition_completer): Likewise.
2862         * cli/cli-dump.c (scan_expression): Likewise.
2863         * common/filestuff.c (mkdir_recursive): Likewise.
2864         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2865         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2866         (gdb_abspath): Likewise.
2867         * compile/compile-cplus-types.c
2868         (compile_cplus_instance::decl_name): Likewise.
2869         * completer.c (complete_explicit_location):
2870         (signal_completer, reg_or_group_completer_1): Likewise.
2871         * cp-support.c (cp_remove_params_if_any): Likewise.
2872         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2873         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2874         * infcmd.c (strip_bg_char): Likewise.
2875         * linespec.c (copy_token_string): Likewise.
2876         * mi/mi-main.c (output_cores): Likewise.
2877         * psymtab.c (psymtab_search_name):
2878         * symfile.c (test_set_ext_lang_command): Likewise.
2879         * target.c (target_fileio_read_stralloc): Likewise.
2880         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2881         * value.c (complete_internalvar): Likewise.
2882
2883 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2884
2885         Add objfile property to gdb.Type.
2886         * NEWS: Mention Python API addition.
2887         * python/py-type.c (typy_get_objfile): New method.
2888
2889 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2890
2891         * NEWS: Mention the new set|show style [title|highlight].
2892         Mention changes to "show style", "help" and "apropos".
2893
2894 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2895
2896         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2897         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2898         instead of print_help_for_command.
2899         (print_doc_of_command): New function.
2900         (help_list): Add 'apropos -v word' suggestion.
2901         (print_help_for_command): Style the command name using title style.
2902         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2903         (_initialize_cli_cmds): Describe -v in apropos_command help.
2904
2905 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2906
2907         * cli/cli-style.h (cli_style_option): Add name in constructor,
2908         add m_name class member, add constructor with intensity,
2909         add name class function.
2910         (cli_style_option::add_setshow_commands): Remove name argument.
2911         (highlight_style, title_style): New styles.
2912         * cli/cli-style.c (do_show): New function that shows a style
2913         characteristic styling the style name with itself.
2914         (set_style_name): New function.
2915         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2916         Update all callers according to the changes in cli/cli-style.h.
2917         * utils.h (fputs_highlighted): New function.
2918         * utils.c (fputs_highlighted): Likewise.
2919
2920 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2921
2922         * NEWS: Mention new pipe command and new convenience variables.
2923
2924 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2925
2926         * cli/cli-cmds.c (pipe_command): New function.
2927         (_initialize_cli_cmds): Call add_com for pipe_command.
2928         Define | as an alias for pipe.
2929         (exit_status_set_internal_vars): New function.
2930         (shell_escape): Call exit_status_set_internal_vars.
2931         cli/cli-decode.c (find_command_name_length): Recognize | as
2932         a single character command.
2933
2934 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2935
2936         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2937         top.c (execute_command_to_ui_file): New function, mostly a copy
2938         of execute_command_to_string.
2939         (execute_command_to_string): Implement by calling
2940         execute_command_to_ui_file.
2941
2942 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2943
2944         * top.h (saved_command_line): Remove declaration.
2945         * top.c (previous_saved_command_line, previous_repeat_arguments):
2946         New variables.
2947         (saved_command_line): Make static, define together with other
2948         'repeat variables'.
2949         (dont_repeat): Clear repeat_arguments.
2950         (repeat_previous, get_saved_command_line, save_command_line):
2951         New functions.
2952         (gdb_init): Initialize saved_command_line
2953         and previous_saved_command_line.
2954         * main.c (captured_main_1): Remove saved_command_line initialization.
2955         * event-top.c (handle_line_of_input): Update to use
2956         the new 'repeat' related functions instead of direct access to
2957         saved_command_line.
2958         * command.h (repeat_previous, get_saved_command_line,
2959         save_command_line): New declarations.
2960         (dont_repeat): Add comment.
2961
2962 2019-05-30  Tom Tromey  <tromey@adacore.com>
2963
2964         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2965         Fix comment.
2966         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2967
2968 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2969
2970         PR cli/24587
2971         * completer.c (complete): Initialize variable word.
2972
2973 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2974
2975         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2976         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2977         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2978         'body' is NULL to the outter 'if', protecting the '!is_define'
2979         situation as well.
2980
2981 2019-05-29  Tom Tromey  <tromey@adacore.com>
2982
2983         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2984         (dwarf_unknown): New function.
2985         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2986         (dwarf_type_encoding_name): Use dwarf_unknown.
2987
2988 2019-05-29  Tom Tromey  <tromey@adacore.com>
2989
2990         PR c++/20020:
2991         * cp-valprint.c (cp_print_value_fields): Call
2992         cp_print_static_field inside "try".
2993
2994 2019-05-29  Tom Tromey  <tromey@adacore.com>
2995
2996         * inflow.c (struct terminal_info): Add default operator=.
2997         * configure: Rebuild.
2998         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2999         -Wdeprecated-copy-dtor, -Wredundant-move.
3000
3001 2019-05-29  Tom Tromey  <tromey@adacore.com>
3002
3003         * NEWS: Add entry.
3004         * infcmd.c (print_return_value_1): Handle finish_print
3005         option.
3006         (show_print_finish): New function.
3007         (_initialize_infcmd): Add "set/show print finish" commands.
3008         * valprint.c (user_print_options): Initialize new member.
3009         * valprint.h (struct value_print_options) <finish_print>: New
3010         member.
3011
3012 2019-05-28  Tom Tromey  <tromey@adacore.com>
3013
3014         * ada-lang.c (ada_remove_Xbn_suffix)
3015         (find_old_style_renaming_symbol)
3016         (parse_old_style_renaming): Remove.
3017         (ada_find_renaming_symbol): Don't call
3018         find_old_style_renaming_symbol.
3019         (ada_is_renaming_symbol): Rename from
3020         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3021         bool.  Now static.
3022         (ada_read_var_value): Update and simplify.
3023         * ada-exp.y (write_var_or_type): Remove old code.
3024
3025 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3026
3027         * event-top.c: Remove include comment.
3028         * inflow.c (class scoped_ignore_sigttou): Move from here...
3029         * inflow.h (class scoped_ignore_sigttou): ...to here.
3030         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3031         * top.c:  Remove include comment.
3032
3033 2019-05-27  Tom Tromey  <tom@tromey.com>
3034
3035         * NEWS: Fix typo.
3036
3037 2019-05-22  Tom Tromey  <tromey@adacore.com>
3038
3039         * target.c (target_follow_exec): Constify parameter.
3040         * target-delegates.c: Rebuild.
3041         * remote.c (remote_target::follow_exec): Constify parameter.
3042         * infrun.c (follow_exec): Constify parameter.
3043         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3044         (target_follow_exec): Likewise.
3045
3046 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3047
3048         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3049         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3050
3051 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3052
3053         * NEWS: Add debugredirect and testsuite sections.
3054
3055 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3056
3057         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3058         target descriptions using exclusively floating point register name
3059         aliases.
3060
3061 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3062
3063         PR gdb/18644:
3064         * f-lang.c (build_fortran_types): Handle the case where
3065         gdbarch_floatformat_for_type returns a nullptr.
3066
3067 2019-05-21  Tom de Vries  <tdevries@suse.de>
3068
3069         PR cli/24587
3070         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3071
3072 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3073
3074         PR gdb/18644:
3075         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3076         16-byte floats.
3077         * i386-tdep.c (i386_floatformat_for_type): Use
3078         floatformats_ia64_quad for the 16-byte floating point component
3079         within a fortran 32-byte complex number.
3080
3081 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3082
3083         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3084         delete default constructor.
3085         (find_partial_die): Update to return const struct.
3086         (partial_die_parent_scope): Move variable declaration into scope
3087         of its use and change its type to auto.
3088         (guess_partial_die_structure_name): Likewise.
3089         (partial_die_info::fixup): Likewise.
3090
3091 2019-05-17  Tom Tromey  <tromey@adacore.com>
3092
3093         * source.c (find_and_open_source): Remove cast.
3094
3095 2019-05-17  Tom Tromey  <tromey@adacore.com>
3096
3097         * annotate.c (annotate_source): Make "filename" const.
3098         * annotate.h (annotate_source): Use const.
3099
3100 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3101
3102         * disasm.c (set_disassembler_options): Send errors to stderr.
3103
3104 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3105
3106         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3107         (cli_interp_base::set_logging): Check debug_redirect.
3108         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3109         * cli/cli-logging.c (debug_redirect): Add static variable.
3110         (pop_output_files): Add default param.
3111         (handle_redirections): Print debug setting.
3112         (show_logging_command): Likewise.
3113         (_initialize_cli_logging): Add debugredirect command.
3114         * interps.c (current_interp_set_logging): Add debug_redirect
3115         parameter.
3116         * interps.h (set_logging): Add debug_redirect parameter.
3117         (current_interp_set_logging): Likewise.
3118         * mi/mi-common.h: Likewise.
3119         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3120
3121 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3122             Tom Tromey  <tromey@adacore.com>
3123
3124         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3125         directly.
3126         * cli/cli-interp.h (make_logging_output): Remove declaration.
3127         * cli/cli-logging.c (make_logging_output): Remove function.
3128         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3129         directly.
3130         * ui-file.c (tee_file::tee_file): Remove bools.
3131         (tee_file::~tee_file): Remove deletes.
3132         * ui-file.h (tee_file): Remove bools.
3133
3134 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3135
3136         * mi/mi-cmds.h (mi_cmd_complete): New function.
3137         * mi/mi-main.c (mi_cmd_complete): Likewise.
3138         * mi/mi-cmds.c: Define new MI command -complete.
3139         * NEWS: Mention new -complete command.
3140
3141 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3142
3143         * completer.h (complete): New function.
3144         * completer.c (complete): Likewise.
3145         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3146         function defined in completer.h.
3147
3148 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3149
3150         * MAINTAINERS (Write After Approval): Add myself.
3151
3152 2019-05-17  Tom de Vries  <tdevries@suse.de>
3153
3154         PR gdb/24094
3155         * dwarf2read.c (struct cu_partial_die_info): New struct.
3156         (find_partial_die): Return cu_partial_die_info.
3157         (partial_die_parent_scope, guess_partial_die_structure_name)
3158         (partial_die_info::fixup): Handle new return type of find_partial_die.
3159
3160 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3161
3162         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3163         "std::string", simplifying the algorithm.
3164
3165 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3166
3167         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3168         (stap_static_probe_ops::get_probes): Likewise.
3169
3170 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3171
3172         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3173         '-')" and "else if".
3174         (stap_parse_single_operand): Join checks for
3175         "gdbarch_stap_parse_special_token_p" and
3176         "gdbarch_stap_parse_special_token" in the same "if" statement.
3177         Invert check when verifying for operation on register
3178         displacement.
3179
3180 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3181
3182         * stap-probe.c (stap_get_opcode): Update comment.
3183         (stap_get_expected_argument_type): Likewise.
3184         (handle_stap_probe): Likewise.
3185
3186 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3187
3188         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3189         return type to 'bool'.  Adjust comment.  Use 'bool' when
3190         appropriate.
3191         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3192         * stap-probe.c (stap_parse_argument_1): Likewise.
3193         (stap_is_operator): Likewise.
3194         (stap_is_generic_prefix): Likewise.
3195         (stap_is_register_prefix): Likewise.
3196         (stap_is_register_indirection_prefix): Likewise.
3197         (stap_is_integer_prefix): Likewise.
3198         (stap_generic_check_suffix): Likewise.
3199         (stap_check_integer_suffix): Likewise.
3200         (stap_check_register_suffix): Likewise.
3201         (stap_check_register_indirection_suffix): Likewise.
3202         (stap_parse_register_operand): Likewise.
3203         (stap_parse_single_operand): Likewise.
3204         (stap_parse_argument_1): Likewise.
3205         (stap_probe::get_argument_count): Likewise.
3206         (stap_is_operator): Likewise.
3207
3208 2019-05-16  Tom Tromey  <tromey@adacore.com>
3209
3210         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3211         keyword to foreach.
3212
3213 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3214
3215         * linux-thread-db.c (try_thread_db_load_1): Change return type
3216         to bool.
3217         (try_thread_db_load): Likewise.
3218         (try_thread_db_load_from_pdir_1): Likewise.
3219         (try_thread_db_load_from_pdir): Likewise.
3220         (try_thread_db_load_from_sdir): Likewise.
3221         (try_thread_db_load_from_dir): Likewise.
3222         (thread_db_load_search): Likewise.
3223         (has_libpthread): Likewise.
3224         (thread_db_load): Likewise.
3225
3226 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3227
3228         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3229         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3230         NULL, and complain/return if that's the case.
3231
3232 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3233
3234         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3235         (advance, posn, abstract_read_memory): New functions.
3236         [struct mem_read_abstraction]: New struct.
3237         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3238
3239 2019-05-14  Tom Tromey  <tromey@adacore.com>
3240
3241         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3242         value is not lval_memory.
3243
3244 2019-05-14  Tom Tromey  <tromey@adacore.com>
3245
3246         * solib.c (info_sharedlibrary_command): Style the file name.
3247
3248 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3249
3250         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3251         (aarch64_vnv_type): Likewise.
3252         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3253         * common/tdesc.c: Likewise.
3254         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3255         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3256         * features/aarch64-fpu.xml: Add ieee half view.
3257         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3258         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3259         * gdbtypes.h (struct builtin_type): Likewise.
3260         (struct objfile_type): Likewise.
3261
3262 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3263
3264         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3265         typo.
3266         * location.h (string_to_event_location): Likewise.
3267
3268 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3269
3270         GDB 8.3 released.
3271
3272 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3273
3274         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3275         New variable declaration.
3276         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3277         New variable.
3278         (print_one_breakpoint): Use ui_out::test_flags and new global
3279         variable to compute use_fixed_output.
3280         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3281         Remove.
3282         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3283         (mi_multi_location_breakpoint_output_fixed): Remove.
3284         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3285         new variable.
3286         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3287         fix_multi_location_breakpoint_output flag if version >= 3.
3288         * ui-out.h (enum ui_out_flag)
3289         <fix_multi_location_breakpoint_output>: New enumerator.
3290
3291 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3292
3293         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3294
3295 2019-05-10  Tom Tromey  <tromey@adacore.com>
3296
3297         * ada-lang.c (catch_ada_completer): New function.
3298         (_initialize_ada_language): Use it.
3299
3300 2019-05-10  Tom Tromey  <tromey@adacore.com>
3301
3302         * thread.c (print_thread_info): Make "requested_threads" const.
3303         * gdbthread.h (print_thread_info): Make "requested_threads"
3304         const.
3305         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3306         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3307
3308 2019-05-08  Tom Tromey  <tom@tromey.com>
3309
3310         * gdbtypes.c (objfile_type_data): Change type.
3311         (objfile_type, _initialize_gdbtypes): Update.
3312
3313 2019-05-08  Tom Tromey  <tom@tromey.com>
3314
3315         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3316         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3317         (_initialize_dwarf2_frame): Update.
3318
3319 2019-05-08  Tom Tromey  <tom@tromey.com>
3320
3321         * objc-lang.c (objc_objfile_data): Change type.
3322         (find_methods): Update.
3323         (_initialize_objc_lang): Remove.
3324
3325 2019-05-08  Tom Tromey  <tom@tromey.com>
3326
3327         * stabsread.c (rs6000_builtin_type_data): Change type.
3328         (rs6000_builtin_type, _initialize_stabsread): Update.
3329
3330 2019-05-08  Tom Tromey  <tom@tromey.com>
3331
3332         * mips-tdep.c (mips_pdr_data): Remove.
3333         (_initialize_mips_tdep): Update.
3334
3335 2019-05-08  Tom Tromey  <tom@tromey.com>
3336
3337         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3338         (hppa_init_objfile_priv_data, read_unwind_info)
3339         (find_unwind_entry, _initialize_hppa_tdep): Update.
3340
3341 2019-05-08  Tom Tromey  <tom@tromey.com>
3342
3343         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3344         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3345         on obstack.
3346         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3347
3348 2019-05-08  Tom Tromey  <tom@tromey.com>
3349
3350         * mdebugread.c (basic_type_data): Change type.
3351         (basic_type, _initialize_mdebugread): Update.
3352
3353 2019-05-08  Tom Tromey  <tom@tromey.com>
3354
3355         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3356
3357 2019-05-08  Tom Tromey  <tom@tromey.com>
3358
3359         * nto-tdep.c (nto_inferior_data_reg): Change type.
3360         (nto_inferior_data): Update.
3361         (nto_inferior_data_cleanup, nto_new_inferior_data)
3362         (_initialize_nto_tdep): Remove.
3363         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3364
3365 2019-05-08  Tom Tromey  <tom@tromey.com>
3366
3367         * ada-lang.c (struct ada_inferior_data): Add initializers.
3368         (ada_inferior_data): Change type.
3369         (ada_inferior_data_cleanup): Remove.
3370         (get_ada_inferior_data, ada_inferior_exit)
3371         (struct ada_pspace_data): Add initializers, destructor.
3372         (ada_pspace_data_handle): Change type.
3373         (get_ada_pspace_data): Update.
3374         (ada_pspace_data_cleanup): Remove.
3375
3376 2019-05-08  Tom Tromey  <tom@tromey.com>
3377
3378         * coffread.c (struct coff_symfile_info): Add initializers.
3379         (coff_objfile_data_key): Move lower.  Change type.
3380         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3381         Update.
3382         (coff_free_info): Remove.
3383
3384 2019-05-08  Tom Tromey  <tom@tromey.com>
3385
3386         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3387         (fbsd_pspace_data_handle): Move lower.  Change type.
3388         (get_fbsd_pspace_data): Update.
3389         (fbsd_pspace_data_cleanup): Remove.
3390         (_initialize_fbsd_tdep): Update.
3391
3392 2019-05-08  Tom Tromey  <tom@tromey.com>
3393
3394         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3395         (get_ada_tasks_pspace_data): Update.
3396         (ada_tasks_pspace_data_cleanup): Remove.
3397         (_initialize_tasks): Update.
3398         (ada_tasks_inferior_data_handle): Change type.
3399         (get_ada_tasks_inferior_data): Update.
3400         (ada_tasks_inferior_data_cleanup): Remove.
3401         (struct ada_tasks_pspace_data): Add initializers.
3402
3403 2019-05-08  Tom Tromey  <tom@tromey.com>
3404
3405         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3406         * symfile-debug.c (debug_sym_get_probes): Change type.
3407         * stap-probe.c (handle_stap_probe):
3408         (stap_static_probe_ops::get_probes): Change type.
3409         * probe.h (class static_probe_ops) <get_probes>: Change type.
3410         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3411         (parse_probes_in_pspace): Update.
3412         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3413         Update.
3414         (any_static_probe_ops::get_probes): Change type.
3415         * elfread.c (elfread_data): New typedef.
3416         (probe_key): Change type.
3417         (elf_get_probes): Likewise.  Update.
3418         (probe_key_free): Remove.
3419         (_initialize_elfread): Update.
3420         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3421         Change type.
3422         (dtrace_process_dof_probe, dtrace_process_dof)
3423         (dtrace_static_probe_ops::get_probe): Change type.
3424
3425 2019-05-08  Tom Tromey  <tom@tromey.com>
3426
3427         * xcoffread.c (struct xcoff_symfile_info): Rename from
3428         coff_symfile_info.  Add initializers.
3429         (xcoff_objfile_data_key): Move lower.  Change type.
3430         (XCOFF_DATA): Rewrite.
3431         (xcoff_free_info): Remove.
3432         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3433         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3434         (xcoff_initial_scan): Update.
3435
3436 2019-05-08  Tom Tromey  <tom@tromey.com>
3437
3438         * solib-svr4.c (struct svr4_info): Add initializers and
3439         destructor.
3440         <probes_table>: Now an htab_up.
3441         (solib_svr4_pspace_data): Change type.
3442         (free_probes_table): Simplify.
3443         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3444         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3445         (probes_table_remove_objfile_probes, register_solib_event_probe)
3446         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3447         (_initialize_svr4_solib): Update.
3448
3449 2019-05-08  Tom Tromey  <tom@tromey.com>
3450
3451         * remote.c (remote_pspace_data): Change type.
3452         (remote_pspace_data_cleanup): Remove.
3453         (get_remote_exec_file, set_pspace_remote_exec_file)
3454         (_initialize_remote): Update.
3455
3456 2019-05-08  Tom Tromey  <tom@tromey.com>
3457
3458         * breakpoint.c (breakpoint_objfile_key): Change type.
3459         (get_breakpoint_objfile_data): Update.
3460         (free_breakpoint_objfile_data): Remove.
3461         (_initialize_breakpoint): Update.
3462
3463 2019-05-08  Tom Tromey  <tom@tromey.com>
3464
3465         * linux-tdep.c (struct linux_info): Add initializers.
3466         (linux_inferior_data): Move.  Change type.
3467         (invalidate_linux_cache_inf): Update.
3468         (linux_inferior_data_cleanup): Remove.
3469         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3470
3471 2019-05-08  Tom Tromey  <tom@tromey.com>
3472
3473         * auxv.c (auxv_inferior_data): Move.  Change type.
3474         (auxv_inferior_data_cleanup): Remove.
3475         (invalidate_auxv_cache_inf): Rewrite.
3476         (get_auxv_inferior_data, _initialize_auxv): Update.
3477
3478 2019-05-08  Tom Tromey  <tom@tromey.com>
3479
3480         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3481         (symfile_debug_objfile_data_key): Change type.
3482         (symfile_debug_installed, debug_qf_has_symbols)
3483         (debug_qf_find_last_source_symtab)
3484         (debug_qf_forget_cached_source_info)
3485         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3486         (debug_qf_print_stats, debug_qf_dump)
3487         (debug_qf_expand_symtabs_for_function)
3488         (debug_qf_expand_all_symtabs)
3489         (debug_qf_expand_symtabs_with_fullname)
3490         (debug_qf_map_matching_symbols)
3491         (debug_qf_expand_symtabs_matching)
3492         (debug_qf_find_pc_sect_compunit_symtab)
3493         (debug_qf_map_symbol_filenames)
3494         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3495         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3496         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3497         (debug_sym_read_linetable, debug_sym_relocate): Update.
3498         (symfile_debug_free_objfile): Remove.
3499         (install_symfile_debug_logging, _initialize_symfile_debug):
3500         Update.
3501
3502 2019-05-08  Tom Tromey  <tom@tromey.com>
3503
3504         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3505         allocate_on_obstack.
3506         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3507         (get_dwarf2_per_objfile): Update.
3508         (set_dwarf2_per_objfile): Remove.
3509         (dwarf2_has_info, dwarf2_get_section_info): Update.
3510         (dwarf2_free_objfile): Remove.
3511         (_initialize_dwarf2_read): Update.
3512
3513 2019-05-08  Tom Tromey  <tom@tromey.com>
3514
3515         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3516         initializers.
3517         <unsupported_script_warning_printed,
3518         script_not_found_warning_printed>: Now bool.
3519         (auto_load_pspace_data): Change type.
3520         (~auto_load_pspace_info): Rename from
3521         auto_load_pspace_data_cleanup.
3522         (get_auto_load_pspace_data, init_loaded_scripts_info)
3523         (clear_section_scripts, maybe_print_unsupported_script_warning)
3524         (maybe_print_script_not_found_warning, _initialize_auto_load):
3525         Update.
3526
3527 2019-05-08  Tom Tromey  <tom@tromey.com>
3528
3529         * objfiles.c (objfile_pspace_info): Add destructor and
3530         initializers.
3531         (objfiles_pspace_data): Change type.
3532         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3533         (get_objfile_pspace_data): Update.
3534         (objfiles_bfd_data): Change type.
3535         (get_objfile_bfd_data): Update.
3536         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3537
3538 2019-05-08  Tom Tromey  <tom@tromey.com>
3539
3540         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3541         Change type.
3542         (get_catch_syscall_inferior_data): Update.
3543         (catch_syscall_inferior_data_cleanup): Remove.
3544         (_initialize_break_catch_syscall): Update.
3545
3546 2019-05-08  Tom Tromey  <tom@tromey.com>
3547
3548         * inflow.c (struct terminal_info): Add destructor and
3549         initializers.
3550         (inflow_inferior_data): Change type.
3551         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3552         (get_inflow_inferior_data, inflow_inferior_exit)
3553         (swap_terminal_info, _initialize_inflow): Update.
3554
3555 2019-05-08  Tom Tromey  <tom@tromey.com>
3556
3557         * target-dcache.c (target_dcache_cleanup): Remove.
3558         (target_dcache_aspace_key): Change type.
3559         (target_dcache_init_p, target_dcache_invalidate)
3560         (target_dcache_get, target_dcache_get_or_init)
3561         (_initialize_target_dcache): Update.
3562         * dcache.h (struct dcache_deleter): New.
3563
3564 2019-05-08  Tom Tromey  <tom@tromey.com>
3565
3566         * symtab.c (struct symbol_cache): Add destructor and
3567         initializers.
3568         (symbol_cache_key): Move.  Change type.
3569         (make_symbol_cache, free_symbol_cache): Remove.
3570         (get_symbol_cache): Update.
3571         (symbol_cache_cleanup): Remove.
3572         (ALL_PSPACES, symbol_cache_flush)
3573         (maintenance_print_symbol_cache)
3574         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3575         Update.
3576
3577 2019-05-08  Tom Tromey  <tom@tromey.com>
3578
3579         * symtab.c (struct main_info): Add destructor and initializers.
3580         (main_progspace_key): Move.  Change type.
3581         (get_main_info): Update.
3582         (main_info_cleanup): Remove.
3583         (_initialize_symtab): Update.
3584
3585 2019-05-08  Tom Tromey  <tom@tromey.com>
3586
3587         * registry.h (DECLARE_REGISTRY): Define the _key class.
3588
3589 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3590
3591         * NEWS: Merge two 'New commands' sections.
3592
3593 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3594
3595         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3596         parameter and use Ada language definition instead.
3597         (ada_val_print_ptr): Remove unused language parameter.
3598         (ada_val_print_num): Remove language parameter and use Ada language
3599         definition instead.
3600         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3601         parameter.
3602         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3603         parameter and use Ada language definition instead.
3604         (ada_val_print_1): Update all ada_val_print_xxx calls.
3605         Remove language parameter.
3606         (ada_val_print): Update ada_val_print_1 call.
3607
3608 2019-05-08  Tom Tromey  <tromey@adacore.com>
3609
3610         * remote.c (remote_hw_watchpoint_limit)
3611         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3612         Now static.
3613
3614 2019-05-08  Tom Tromey  <tromey@adacore.com>
3615
3616         * maint.c (_initialize_maint_cmds): Move initialization code to
3617         remote.c.
3618         (watchdog, show_watchdog): Move to remote.c.
3619         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3620         "watchdog" static.
3621         (_initialize_remote): Move initialization code from maint.c.
3622         * defs.h (watchdog): Don't declare.
3623
3624 2019-05-08  Tom Tromey  <tromey@adacore.com>
3625
3626         * tui/tui-interp.c: Include main.h.
3627         * interps.c: Include main.h.
3628         * main.h (interpreter_p): Declare.
3629         * defs.h (interpreter_p): Don't declare.
3630
3631 2019-05-08  Tom Tromey  <tromey@adacore.com>
3632
3633         * dwarf2loc.c: Include dwarf2read.h.
3634         * defs.h (read_unsigned_leb128): Don't declare.
3635         * dwarf2read.h (read_unsigned_leb128): Declare.
3636
3637 2019-05-08  Tom Tromey  <tromey@adacore.com>
3638
3639         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3640         method.
3641
3642 2019-05-08  Tom Tromey  <tromey@adacore.com>
3643
3644         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3645         when no wrap column is set.
3646
3647 2019-05-08  Tom Tromey  <tromey@adacore.com>
3648
3649         * c-lang.c (c_get_string): Handle non-C-style arrays.
3650
3651 2019-05-08  Tom Tromey  <tromey@adacore.com>
3652
3653         * typeprint.c (print_offset_data::update): Print the bit offset,
3654         not the number of bits remaining.
3655
3656 2019-05-08  Tom Tromey  <tromey@adacore.com>
3657
3658         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3659         padding at end of comment.
3660
3661 2019-05-08  Tom Tromey  <tromey@adacore.com>
3662
3663         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3664         Compare main types.
3665
3666 2019-05-06  Tom Tromey  <tom@tromey.com>
3667
3668         * common/scoped_mmap.c: Include common-defs.h.
3669         * common/scoped_mmap.h: Don't include config.h.
3670
3671 2019-05-04  Tom Tromey  <tom@tromey.com>
3672
3673         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3674         (struct aarch64_call_info): Add initializers.
3675         <si>: Now a std::vector.
3676         (pass_on_stack, aarch64_push_dummy_call): Update.
3677
3678 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3679             Tom Tromey  <tom@tromey.com>
3680
3681         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3682         (ppc_threads): Now a std::vector.  Now static.
3683         (hwdebug_find_thread_points_by_tid)
3684         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3685         Update.
3686
3687 2019-05-04  Tom Tromey  <tom@tromey.com>
3688
3689         * arc-tdep.c (arc_tdesc_init): Return bool.
3690
3691 2019-05-04  Tom Tromey  <tom@tromey.com>
3692
3693         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3694         Use gdb_assert_not_reached.
3695
3696 2019-05-04  Tom Tromey  <tom@tromey.com>
3697
3698         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3699         "false".
3700
3701 2019-05-04  Tom Tromey  <tom@tromey.com>
3702
3703         * arc-tdep.c (arc_tdesc_init): Use bool.
3704
3705 2019-05-04  Tom Tromey  <tom@tromey.com>
3706
3707         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3708
3709 2019-05-04  Tom Tromey  <tom@tromey.com>
3710
3711         * cli/cli-cmds.c (valid_command_p): Return bool.
3712
3713 2019-05-04  Tom Tromey  <tom@tromey.com>
3714
3715         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3716         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3717
3718 2019-05-04  Raul Tambre  <raul@tambre.ee>
3719
3720         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3721         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3722         operator for comparison.
3723
3724 2019-05-04  Tom Tromey  <tom@tromey.com>
3725
3726         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3727         (lookup_partial_symbol, print_partial_symbols)
3728         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3729         (psymbol_compare): Update.
3730         (add_psymbol_to_bcache): Clear the entire psymbol.
3731         (maintenance_check_psymtabs): Update.
3732         * psympriv.h (struct partial_symbol): Don't derive from
3733         general_symbol_info.
3734         <obj_section, unrelocated_address, address,
3735         set_unrelocated_address>: Update.
3736         <ginfo>: New member.
3737         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3738         (debug_names::write_psymbols): Update.
3739
3740 2019-05-04  Tom de Vries  <tdevries@suse.de>
3741
3742         * contrib/cc-with-tweaks.sh: Support -n arg.
3743
3744 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3745
3746         * corelow.c (core_target::detach): Ensure frame cache and
3747         register caches are cleared.
3748         inferior.c (exit_inferior_1): Likewise.
3749
3750 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3751             Tom Tromey  <tom@tromey.com>
3752
3753         * dictionary.c (collate_pending_symbols_by_language): Remove
3754         "struct" from foreach.
3755         * symtab.c (lookup_global_symbol_from_objfile)
3756         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3757         foreach.
3758         * ser-tcp.c (net_open): Remove "struct" from foreach.
3759         * objfiles.c (objfile_relocate, objfile_rebase)
3760         (objfile_has_symbols): Remove "struct" from foreach.
3761         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3762         from foreach.
3763         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3764         foreach.
3765         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3766         "struct" from foreach.
3767         * ada-lang.c (create_excep_cond_exprs)
3768         (ada_exception_catchpoint_cond_string): Remove "struct" from
3769         foreach.
3770
3771 2019-05-03  Tom Tromey  <tromey@adacore.com>
3772
3773         * ada-exp.y (convert_char_literal): Check suffix of each
3774         enumerator.
3775
3776 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3777
3778         PR ada/21406:
3779         * ada-exp.y (yywrap): Don't define.
3780         * ada-lex.l (%option): Add noyywrap
3781         (yywrap): Remove.
3782
3783 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3784
3785         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3786         _WIN32_WINNT to the XP level, unless already defined to a higher
3787         level.
3788
3789         * unittests/parse-connection-spec-selftests.c:
3790         * ser-tcp.c:
3791         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3792         override.
3793
3794         * symfile.c (find_separate_debug_file): Remove colon from the
3795         drive spec of DOS/Windows file names of the target, so that the
3796         file name produced from DEBUGDIR and the target's directory will
3797         be valid on DOS/Windows systems.
3798
3799 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3800
3801         * rust-lang.c (val_print_struct): Handle printing structures
3802         containing strings.
3803
3804 2019-05-02  Tom Tromey  <tromey@adacore.com>
3805
3806         * valarith.c (_initialize_valarith): Remove.
3807
3808 2019-05-01  Tom Tromey  <tromey@adacore.com>
3809
3810         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3811         bitfields.
3812
3813 2019-05-01  Tom Tromey  <tromey@adacore.com>
3814
3815         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3816         for big-endian copies.
3817
3818 2019-04-30  Ali Tamur  <tamur@google.com>
3819         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3820         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3821         (read_3_bytes): New function.
3822
3823 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3824
3825         * windows-nat.c (main_thread_id): Delete.
3826         (handle_output_debug_string): Replace main_thread_id by
3827         current_event.dwThreadId.
3828         (fake_create_process): Likewise.
3829         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3830         Do not set main_thread_id.
3831         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3832         current_event.dwThreadId.
3833         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3834
3835 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3836
3837         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3838         Use current_event.dwThreadId instead of main_thread_id.
3839
3840 2019-04-30  Tom Tromey  <tromey@adacore.com>
3841
3842         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3843         (create_excep_cond_exprs): Iterate over program spaces.
3844         (ada_exception_catchpoint_cond_string): Examine all minimal
3845         symbols for exception types.
3846
3847 2019-04-30  Tom Tromey  <tromey@adacore.com>
3848
3849         PR c++/24470:
3850         * dwarf2read.c (process_structure_scope): Handle case where type
3851         has template parameters but no symbol was created.
3852
3853 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3854             Chris January  <chris.january@arm.com>
3855
3856         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3857         qualifier.
3858         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3859
3860 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3861
3862         * f-typeprint.c (f_print_type): Update rules for printing
3863         whitespace.
3864         (f_type_print_varspec_suffix): Likewise.
3865
3866 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3867             Chris January  <chris.january@arm.com>
3868
3869         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3870         function arguments.
3871
3872 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3873
3874         * f-lang.c (build_fortran_types): Change name of void type to
3875         lower case.
3876         * f-typeprint.c (f_type_print_base): Print the name of the void
3877         type, rather than a fixed string.
3878         * f-valprint.c (f_decorations): Use lower case void string.
3879
3880 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3881             Chris January  <chris.january@arm.com>
3882
3883         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3884         types for Fortran.
3885
3886 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3887             Chris January  <chris.january@arm.com>
3888             David Lecomber  <david.lecomber@arm.com>
3889
3890         * f-exp.y (BINOP_INTRINSIC): New token.
3891         (exp): New parser rule handling BINOP_INTRINSIC.
3892         (f77_keywords): Add new builtin procedures.
3893         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3894         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3895         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3896         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3897         (print_unop_subexp_f): New function.
3898         (print_binop_subexp_f): New function.
3899         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3900         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3901         (dump_subexp_body_f): Likewise.
3902         (operator_check_f): Likewise.
3903         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3904         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3905
3906 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3907
3908         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3909         UNOP_KIND.
3910         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3911         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3912         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3913         (operator_length_f): New fuction.
3914         (print_subexp_f): New function.
3915         (op_name_f): New function.
3916         (dump_subexp_body_f): New function.
3917         (operator_check_f): New function.
3918         (exp_descriptor_f): Replace standard expression handling functions
3919         with new functions.
3920         * gdb/fortran-operator.def: New file.
3921         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3922         * gdb/std-operator.def: Remove UNOP_KIND.
3923
3924 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3925
3926         * std-operator.def: Remove unbalanced, stray double quote
3927         character.
3928
3929 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3930             Chris January  <chris.january@arm.com>
3931             Daniel Everett  <daniel.everett@arm.com>
3932             Nick Forrington  <nick.forrington@arm.com>
3933             Richard Bunt  <richard.bunt@arm.com>
3934
3935         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3936         of depth when printing anonymous structs or unions.
3937         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3938         Don't print either the top-level value, or the children if the
3939         max-depth is exceeded.
3940         (ppscm_print_children): When printing the key of a map, allow one
3941         extra level of depth.
3942         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3943         print either the top-level value, or the children if the max-depth
3944         is exceeded.
3945         (print_children): When printing the key of a map, allow one extra
3946         level of depth.
3947         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3948         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3949         (user_print_options): Initialise max_depth field.
3950         (val_print_scalar_or_string_type_p): New function.
3951         (val_print): Check to see if the max depth has been reached.
3952         (val_print_check_max_depth): Define new function.
3953         (show_print_max_depth): New function.
3954         (_initialize_valprint): Add 'print max-depth' option.
3955         * valprint.h (struct value_print_options) <max_depth>: New field.
3956         (val_print_check_max_depth): Declare new function.
3957         * NEWS: Document new feature.
3958
3959 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3960
3961         * ada-lang.c (ada_language_defn): Initialise new field.
3962         * c-lang.c (c_is_string_type_p): New function.
3963         (c_language_defn): Initialise new field.
3964         (cplus_language_defn): Initialise new field.
3965         (asm_language_defn): Initialise new field.
3966         (minimal_language_defn): Initialise new field.
3967         * c-lang.h (c_is_string_type_p): Declare new function.
3968         * d-lang.c (d_language_defn): Initialise new field.
3969         * f-lang.c (f_is_string_type_p): New function.
3970         (f_language_defn): Initialise new field.
3971         * go-lang.c (go_is_string_type_p): New function.
3972         (go_language_defn): Initialise new field.
3973         * language.c (default_is_string_type_p): New function.
3974         (unknown_language_defn): Initialise new field.
3975         (auto_language_defn): Initialise new field.
3976         * language.h (struct language_defn) <la_is_string_type_p>: New
3977         member variable.
3978         (default_is_string_type_p): Declare new function.
3979         * m2-lang.c (m2_language_defn): Initialise new field.
3980         * objc-lang.c (objc_language_defn): Initialise new field.
3981         * opencl-lang.c (opencl_language_defn): Initialise new field.
3982         * p-lang.c (pascal_is_string_type_p): New function.
3983         (pascal_language_defn): Initialise new field.
3984         * rust-lang.c (rust_is_string_type_p): New function.
3985         (rust_language_defn): Initialise new field.
3986
3987 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3988
3989         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3990         New field.
3991         * ada-lang.c (ada_language_defn): Initialise new field.
3992         * c-lang.c (c_language_defn): Likewise.
3993         (cplus_language_defn): Likewise.
3994         (asm_language_defn): Likewise.
3995         (minimal_language_defn): Likewise.
3996         * d-lang.c (d_language_defn): Likewise.
3997         * f-lang.c (f_language_defn): Likewise.
3998         * go-lang.c (go_language_defn): Likewise.
3999         * language.c (unknown_language_defn): Likewise.
4000         (auto_language_defn): Likewise.
4001         * m2-lang.c (m2_language_defn): Likewise.
4002         * objc-lang.c (objc_language_defn): Likewise.
4003         * opencl-lang.c (opencl_language_defn): Likewise.
4004         * p-lang.c (pascal_language_defn): Likewise.
4005         * rust-lang.c (rust_language_defn): Likewise.
4006
4007 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4008
4009         * ada-lang.c (ada_is_character_type): Change return type to bool.
4010         (ada_is_string_type): Likewise.
4011         * ada-lang.h (ada_is_character_type): Update declaration
4012         (ada_is_string_type): Likewise.
4013
4014 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4015
4016         Support style in 'frame|thread apply'
4017
4018         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4019         * record.c (record_start, record_stop): Update callers of
4020         execute_command_to_string with false.
4021         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4022         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4023         methods.
4024         (class string_file): New constructor with term_out parameter.
4025         Override methods term_out and can_emit_style_escape.  New member
4026         term_out.
4027         (class stdio_file): Override can_emit_style_escape.
4028         (class tee_file): Override term_out and can_emit_style_escape.
4029         * utils.h (can_emit_style_escape): Remove.
4030         * utils.c (can_emit_style_escape): Likewise.
4031         Update all callers of can_emit_style_escape (SOMESTREAM) to
4032         SOMESTREAM->can_emit_style_escape.
4033         * source-cache.c (source_cache::get_source_lines): Likewise.
4034         * stack.c (frame_apply_command_count): Call execute_command_to_string
4035         passing the term_out characteristic of the current gdb_stdout.
4036         * thread.c (thr_try_catch_cmd): Likewise.
4037         * top.c (execute_command_to_string): pass term_out parameter
4038         to construct the string_file for the command output.
4039         * ui-file.c (term_cli_styling): New function (most code moved
4040         from utils.c can_emit_style_escape).
4041         (string_file::string_file, string_file::can_emit_style_escape,
4042         stdio_file::can_emit_style_escape, tee_file::term_out,
4043         tee_file::can_emit_style_escape): New functions.
4044
4045 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4046
4047         * NEWS: Mention the new set|show may-call-functions.
4048         * infcall.c (may_call_functions_p): New variable.
4049         (show_may_call_functions_p): New function.
4050         (call_function_by_hand_dummy): Throws an error if not
4051         may-call-functions.
4052         (_initialize_infcall): Call add_setshow_boolean_cmd for
4053         may-call-functions.
4054
4055 2019-04-25  Keith Seitz  <keiths@redhat.com>
4056
4057         PR c++/24367
4058         * cp-support.c (inspect_type): Don't attempt substitutions
4059         of symbol with the same name.
4060
4061 2019-04-25  Tom Tromey  <tromey@adacore.com>
4062
4063         PR gdb/24475:
4064         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4065         static.
4066
4067 2019-04-25  Tom Tromey  <tromey@adacore.com>
4068
4069         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4070         rvalue reference.
4071         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4072         (gdb_xml_parser::parse): Use std::move.
4073         * python/python-internal.h (gdbpy_convert_exception): Take a const
4074         reference.
4075         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4076         std::move.
4077         * python/py-utils.c (gdbpy_convert_exception): Take a const
4078         reference.
4079         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4080         Use std::move.
4081         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4082         Use std::move.
4083         * mi/mi-main.c (mi_print_exception): Take a const reference.
4084         * main.c (handle_command_errors): Take a const reference.
4085         * linespec.c (parse_linespec): Use std::move.
4086         * infcall.c (run_inferior_call): Use std::move.
4087         (call_function_by_hand_dummy): Use std::move.
4088         * exec.c (try_open_exec_file): Use std::move.
4089         * exceptions.h (exception_print, exception_fprintf)
4090         (exception_print_same): Update.
4091         * exceptions.c (print_exception, exception_print)
4092         (exception_fprintf, exception_print_same): Change parameters to
4093         const reference.
4094         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4095         * common/new-op.c: Use std::move.
4096         * common/common-exceptions.h (struct gdb_exception): Add move
4097         constructor.
4098         (struct gdb_exception_error, struct gdb_exception_quit, struct
4099         gdb_quit_bad_alloc): Change constructor to move constructor.
4100         (throw_exception): Change parameter to rvalue reference.
4101         * common/common-exceptions.c (throw_exception): Take rvalue
4102         reference.
4103         * cli/cli-interp.c (safe_execute_command): Use std::move.
4104         * breakpoint.c (insert_bp_location, location_to_sals): Use
4105         std::move.
4106
4107 2019-04-25  Tom Tromey  <tromey@adacore.com>
4108
4109         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4110         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4111         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4112         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4113         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4114         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4115         guile/scm-value.c: Use unpack.
4116         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4117         gdbscm_gdb_exception.
4118         (gdbscm_throw_gdb_exception): Likewise.
4119         (struct gdbscm_gdb_exception): New.
4120         (unpack): New function.
4121         (gdbscm_wrap): Use unpack.
4122
4123 2019-04-25  Tom Tromey  <tromey@adacore.com>
4124
4125         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4126         (gdb_rl_callback_handler): Use std::move.
4127         * common/common-exceptions.h (struct gdb_exception): Add move
4128         assignment operator.
4129         (throw_exception_sjlj): Change "exception" to const reference.
4130         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4131         (throw_exception_sjlj): Change "exception" to const reference.
4132
4133 2019-04-25  Tom Tromey  <tromey@adacore.com>
4134
4135         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4136         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4137         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4138         Update.
4139         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4140         Update.
4141         * mi/mi-interp.c (mi_interp::exec): Update.
4142         * linespec.c (parse_linespec): Update.
4143         * infcall.c (run_inferior_call): Update.
4144         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4145         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4146         (gdbscm_lookup_global_symbol): Update.
4147         * guile/scm-param.c (gdbscm_parameter_value): Update.
4148         * guile/scm-frame.c (gdbscm_frame_read_register)
4149         (gdbscm_frame_read_var): Update.
4150         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4151         * exec.c (try_open_exec_file): Update.
4152         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4153         (gdb_rl_callback_handler): Update.
4154         * common/common-exceptions.h (exception_none): Don't declare.
4155         * common/common-exceptions.c (exception_none): Don't define.
4156         (struct catcher) <exception>: Update.
4157         * cli/cli-interp.c (safe_execute_command): Update.
4158         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4159
4160 2019-04-25  Ali Tamur  <tamur@google.com>
4161
4162         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4163         (read_attribute_value): Likewise.
4164         (dwarf2_read_addr_index): Update comment.
4165         (read_str_index): Add DW_FORM_strx.
4166         (dwarf2_string_attr): Likewise.
4167         (dwarf2_const_value_attr): Likewise.
4168         (dump_die_shallow): Likewise.
4169         (dwarf2_fetch_constant_bytes): Likewise.
4170         (skip_form_bytes): Likewise.
4171         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4172
4173 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4174
4175         PR corefiles/11608
4176         PR corefiles/18187
4177         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4178         OFFSET.  Verify if current mapping contains an ELF header.
4179         (linux_find_memory_regions_full): Adjust call to
4180         dump_mapping_p.
4181
4182 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4183             Kang Li <kanglictf@gmail.com>
4184
4185         PR gdb/21600
4186
4187         * dwarf2-frame.c (read_initial_length): Be consistent about using
4188         unsigned representation of length.
4189         (decode_frame_entry_1): Likewise.  Check for wraparound of
4190         end pointer as well as buffer overflow.
4191
4192 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4193
4194         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4195         "vq".
4196
4197 2019-04-24  Tom Tromey  <tromey@adacore.com>
4198
4199         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4200
4201 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4202
4203         * s12z-tdep.c (s12z_unwind_pc): Delete.
4204         (s12z_unwind_sp): Delete.
4205         (s12z_gdbarch_init): Don't register deleted functions with
4206         gdbarch.
4207
4208 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4209
4210         * rl78-tdep.c (rl78_unwind_sp): Delete.
4211         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4212
4213 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4214
4215         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4216         (xstormy16_unwind_pc): Delete.
4217         (xstormy16_dummy_id): Delete.
4218         (xstormy16_gdbarch_init): Don't register deleted functions with
4219         gdbarch.
4220
4221 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4222
4223         * vax-tdep.c (vax_unwind_pc): Delete.
4224         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4225
4226 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4227
4228         * v850-tdep.c (v850_unwind_sp): Delete.
4229         (v850_unwind_pc): Delete.
4230         (v850_dummy_id): Delete.
4231         (v850_gdbarch_init): Don't register deleted functions with
4232         gdbarch.
4233
4234 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4235
4236         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4237         (tilegx_unwind_pc): Delete.
4238         (tilegx_unwind_dummy_id): Delete.
4239         (tilegx_gdbarch_init): Don't register deleted functions with
4240         gdbarch.
4241
4242 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4243
4244         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4245         (tic6x_dummy_id): Delete.
4246         (tic6x_gdbarch_init): Don't register deleted functions with
4247         gdbarch.
4248
4249 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4250
4251         * sparc-tdep.c (sparc_unwind_pc): Delete.
4252         (sparc32_gdbarch_init): Don't register deleted function with
4253         gdbarch.
4254
4255 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4256
4257         * sh-tdep.c (sh_unwind_sp): Delete.
4258         (sh_unwind_pc): Delete.
4259         (sh_dummy_id): Delete.
4260         (sh_gdbarch_init): Don't register deleted functions with
4261         gdbarch.
4262
4263 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4264
4265         * score-tdep.c (score_unwind_sp): Delete.
4266         (score_unwind_pc): Delete.
4267         (score_dummy_id): Delete.
4268         (score_gdbarch_init): Don't register deleted functions with
4269         gdbarch.
4270
4271 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4272
4273         * rx-tdep.c (rx_unwind_pc): Delete.
4274         (rx_unwind_sp): Delete.
4275         (rx_dummy_id): Delete.
4276         (rx_gdbarch_init): Don't register deleted functions with
4277         gdbarch.  Update comment.
4278
4279 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4280
4281         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4282         (rs6000_dummy_id): Delete.
4283         (rs6000_gdbarch_init): Don't register deleted functions with
4284         gdbarch.
4285
4286 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4287
4288         * or1k-tdep.c (or1k_dummy_id): Delete.
4289         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4290
4291 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4292
4293         * nios2-tdep.c (nios2_dummy_id): Delete.
4294         (nios2_unwind_sp): Delete.
4295         (nios2_gdbarch_init): Don't register deleted functions with
4296         gdbarch.
4297
4298 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4299
4300         * nds32-tdep.c (nds32_dummy_id): Delete.
4301         (nds32_unwind_pc): Delete.
4302         (nds32_unwind_sp): Delete.
4303         (nds32_gdbarch_init): Don't register deleted functions with
4304         gdbarch.
4305
4306 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4307
4308         * msp430-tdep.c (msp430_unwind_pc): Delete.
4309         (msp430_unwind_sp): Delete.
4310         (msp430_dummy_id): Delete.
4311         (msp430_gdbarch_init): Don't register deleted functions with
4312         gdbarch.
4313
4314 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4315
4316         * moxie-tdep.c (moxie_unwind_sp): Delete.
4317         (moxie_unwind_pc): Delete.
4318         (moxie_dummy_id): Delete.
4319         (moxie_gdbarch_init): Don't register deleted functions with
4320         gdbarch.
4321
4322 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4323
4324         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4325         (mn10300_unwind_pc): Delete.
4326         (mn10300_unwind_sp): Delete.
4327         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4328         mn10300_unwind_sp.
4329         (mn10300_frame_unwind_init): Don't register deleted functions with
4330         gdbarch.
4331
4332 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4333
4334         * mep-tdep.c (mep_unwind_pc): Delete.
4335         (mep_unwind_sp): Delete.
4336         (mep_dummy_id): Delete.
4337         (mep_gdbarch_init): Don't register deleted functions with
4338         gdbarch.
4339
4340 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4341
4342         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4343         (m68hc11_unwind_sp): Delete.
4344         (m68hc11_gdbarch_init): Don't register deleted functions with
4345         gdbarch.
4346
4347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4348
4349         * m32r-tdep.c (m32r_unwind_sp): Delete.
4350         (m32r_unwind_pc): Delete.
4351         (m32r_dummy_id): Delete.
4352         (m32r_gdbarch_init): Don't register deleted functions with
4353         gdbarch.
4354
4355 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4356
4357         * m32c-tdep.c (m32c_unwind_pc): Delete.
4358         (m32c_unwind_sp): Delete.
4359         (m32c_dummy_id): Delete.
4360         (m32c_gdbarch_init): Don't register deleted functions with
4361         gdbarch.
4362
4363 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4364
4365         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4366         (lm32_unwind_pc): Delete.
4367         (lm32_dummy_id): Delete.
4368         (lm32_gdbarch_init): Don't register deleted functions with
4369         gdbarch.
4370
4371 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4372
4373         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4374         (iq2000_unwind_pc): Delete.
4375         (iq2000_dummy_id): Delete.
4376         (iq2000_gdbarch_init): Don't register deleted functions with
4377         gdbarch.
4378
4379 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4380
4381         * nds32-tdep.c (nds32_type_align): Delete.
4382         (nds32_push_dummy_call): Use type_align instead.
4383
4384 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4385
4386         * arm-tdep.c (arm_type_align): Only handle vector override case.
4387         (arm_push_dummy_call): Use type_align.
4388         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4389
4390 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4391
4392         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4393         case.
4394         (pass_on_stack): Use type_align.
4395         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4396         function.
4397
4398 2019-04-23  Tom Tromey  <tromey@adacore.com>
4399
4400         * dwarf2read.c (line_header::file_name_at): Remove unused
4401         overload.
4402
4403 2019-04-23  Tom de Vries  <tdevries@suse.de>
4404
4405         PR gdb/24438
4406         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4407         invocation.
4408
4409
4410 2019-03-27  Ali Tamur  <tamur@google.com>
4411
4412         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4413         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4414         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4415         (dwarf_expr_context::get_addr_index): Likewise
4416         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4417         (symbol_needs_eval_context::get_addr_index): Likewise
4418         (disassemble_dwarf_expression): Add DW_OP_addrx
4419         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4420         (read_cutu_die_from_dwo): Update comment
4421         (skip_one_die): Add DW_FORM_addrx
4422         (read_attribute_value): Likewise
4423         (var_decode_location): Add DW_OP_addrx
4424         (dwarf2_const_value_attr): Add DW_FORM_addrx
4425         (dump_die_shallow): Likewise
4426         (dwarf2_fetch_constant_bytes): Likewise
4427         (decode_locdesc): Add DW_OP_addrx
4428         (skip_form_bytes): Add DW_FORM_addrx
4429
4430 2019-04-22  Ali Tamur  <tamur@google.com>
4431
4432         * MAINTAINERS (Write After Approval): Add self.
4433
4434 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4435
4436         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4437         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4438         (open_symbol_file_object): Likewise.
4439         (svr4_default_sos): Add info parameter.
4440         (svr4_read_so_list): Likewise.
4441         (svr4_current_sos_direct): Adjust functions calls to pass down
4442         info.
4443         (svr4_current_sos_1): Add info parameter.
4444         (svr4_current_sos): Call get_svr4_info, pass info down to
4445         svr4_current_sos_1.
4446         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4447         get_svr4_info.
4448         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4449         get_svr4_info.
4450         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4451         to get_svr4_info.
4452         (probes_table_remove_objfile_probes): Likewise.
4453         (register_solib_event_probe): Add info parameter.
4454         (solist_update_incremental): Pass info parameter down to
4455         svr4_read_so_list.
4456         (disable_probes_interface): Add info parameter.
4457         (svr4_handle_solib_event): Pass current_program_space to
4458         get_svr4_info.  Adjust disable_probes_interface cleanup.
4459         (svr4_create_probe_breakpoints): Add info parameter, pass it
4460         down to register_solib_event_probe.
4461         (svr4_create_solib_event_breakpoints): Add info parameter,
4462         pass it down to svr4_create_probe_breakpoints.
4463         (enable_break): Pass info down to
4464         svr4_create_solib_event_breakpoints.
4465         (svr4_solib_create_inferior_hook): Pass current_program_space to
4466         get_svr4_info.
4467         (svr4_clear_solib): Likewise.
4468
4469 2019-04-22  Pedro Alves  <palves@redhat.com>
4470
4471         * solib-svr4.c (svr4_free_objfile_observer): New.
4472         (probe_and_action::objfile): New field.
4473         (probes_table_htab_remove_objfile_probes)
4474         (probes_table_remove_objfile_probes): New functions.
4475         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4476         in the new probe_and_action.  Don't store the probe in 'lookup'.
4477         (svr4_create_probe_breakpoints): Pass objfile to
4478         register_solib_event_probe.
4479         (_initialize_svr4_solib): Register a free_objfile observer.
4480
4481 2019-04-19  Tom Tromey  <tom@tromey.com>
4482
4483         * common/queue.h: Remove.
4484
4485 2019-04-19  Tom Tromey  <tom@tromey.com>
4486
4487         * event-loop.c: Don't include "common/queue.h".
4488
4489 2019-04-19  Tom Tromey  <tom@tromey.com>
4490
4491         * remote.c (remote_target): Use delete.
4492         * remote-notif.h: Include <list>, not "common/queue.h".
4493         (notif_client_p): Remove typedef.
4494         (remote_notif_state): Add constructor, destructor, initializer.
4495         <notif_queue>: Now a std::list.
4496         (remote_notif_state_xfree): Don't declare.
4497         * remote-notif.c (remote_notif_process, handle_notification)
4498         (remote_notif_state_allocate): Update.
4499         (~remote_notif_state): Rename from remote_notif_state_xfree.
4500
4501 2019-04-19  Tom Tromey  <tom@tromey.com>
4502
4503         * symfile.c (reread_symbols): Update.
4504         * objfiles.c (objfile_register_static_link)
4505         (objfile_lookup_static_link): Update
4506         (~objfile) Don't delete static_links.
4507         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4508
4509 2019-04-19  Tom Tromey  <tom@tromey.com>
4510
4511         * type-stack.h (struct type_stack) <insert>: Constify string.
4512         * type-stack.c (type_stack::insert): Constify string.
4513         * gdbtypes.h (lookup_template_type): Update.
4514         (address_space_name_to_int): Update.
4515         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4516         const.
4517         (lookup_template_type): Make name const.
4518         * c-exp.y: Update rules.
4519         (lex_one_token, classify_name, classify_inner_name)
4520         (c_print_token): Update.
4521         * p-exp.y: Update rules.
4522         (yylex): Update.
4523         * f-exp.y: Update rules.
4524         (yylex): Update.
4525         * d-exp.y: Update rules.
4526         (lex_one_token, classify_name, classify_inner_name): Update.
4527         * parse.c (write_dollar_variable, copy_name): Return std::string.
4528         * parser-defs.h (copy_name): Change return type.
4529         * m2-exp.y: Update rules.
4530         (yylex): Update.
4531         * go-exp.y (lex_one_token): Update.
4532         Update rules.
4533         (classify_unsafe_function, classify_packaged_name)
4534         (classify_name, yylex): Update.
4535
4536 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4537
4538         * configure.ac: add --enable-source-highlight switch.
4539         * configure: Regenerate.
4540         * top.c (print_gdb_version): plumb --enable-source-highlight
4541         status to "show configuration".
4542
4543 2019-04-19  Tom Tromey  <tromey@adacore.com>
4544
4545         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4546         Check ADA_TYPE_P.
4547         (empty_record, ada_template_to_fixed_record_type_1)
4548         (template_to_static_fixed_type)
4549         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4550         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4551         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4552         macros.
4553
4554 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4555
4556         PR symtab/24423:
4557         * source.c (print_source_lines_base): Advance "iter" when a
4558         control character is seen.
4559
4560 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4561
4562         * inferior.h (struct infcall_suspend_state_deleter):
4563         Catch exception in destructor to avoid crash.
4564
4565 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4566
4567         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4568         close to the add_com "shell".
4569
4570 2019-04-18  Tom Tromey  <tromey@adacore.com>
4571
4572         * process-stratum-target.h (class process_stratum_target)
4573         <stratum>: Add "final".
4574
4575 2019-04-17  Tom Tromey  <tromey@adacore.com>
4576
4577         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4578         against nullptr before use.
4579
4580 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4581
4582         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4583
4584 2019-04-17  Jim Wilson  <jimw@sifive.com>
4585             Andrew Burgess  <andrew.burgess@embecosm.com>
4586
4587         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4588         code read might fail, assume 4-byte breakpoint in that case.
4589
4590 2019-04-15  Leszek Swirski  <leszeks@google.com>
4591
4592         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4593         rather than a hand-rolled POD check when checking for forced MEMORY
4594         classification.
4595
4596 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4597
4598         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4599         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4600         function.
4601         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4602         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4603         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4604         declaration.
4605
4606 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4607
4608         * aarch64-linux-nat.c
4609         (aarch64_linux_nat_target::thread_architecture): Add override.
4610         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4611         each VQ.
4612
4613 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4614
4615         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4616
4617 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4618
4619         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4620         target types of size 96-bits, add some additional comments, and
4621         check that the builtin type we found was the correct size.
4622
4623 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4624
4625         * utils.c (prompt_for_continue): Don't restore the styling at the
4626         end, as applied_style has the wrong value.  This fixes styling in
4627         long lists of file names that are interrupted by the "Continue?"
4628         prompt.
4629
4630 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4631
4632         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4633         * c-lang.c (c_language_defn): Likewise.
4634         (cplus_language_defn): Likewise.
4635         (asm_language_defn): Likewise.
4636         (minimal_language_defn): Likewise.
4637         * d-lang.c (d_language_defn): Likewise.
4638         * f-lang.c (f_language_defn): Likewise.
4639         * go-lang.c (go_language_defn): Likewise.
4640         * language.c (unknown_language_defn): Likewise.
4641         (auto_language_defn): Likewise.
4642         * language.h (struct language_defn): Remove la_magic field.
4643         (LANG_MAGIC): Delete.
4644         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4645         * objc-lang.c (objc_language_defn): Likewise.
4646         * opencl-lang.c (opencl_language_defn): Likewise.
4647         * p-lang.c (pascal_language_defn): Likewise.
4648         * rust-lang.c (rust_language_defn): Likewise.
4649
4650 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4651
4652         * riscv-tdep.c (riscv_type_align): New function.
4653         (riscv_type_alignment): Delete.
4654         (riscv_arg_location): Use 'type_align'.
4655         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4656
4657 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4658
4659         * gdbtypes.c (type_align): A struct with no non-static fields also
4660         has alignment of 1.
4661
4662 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4663
4664         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4665         component to 0.
4666         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4667         member.
4668         (riscv_struct_info::analyse): New implementation using new
4669         analyse_inner member function.
4670         (riscv_struct_info::field_offset): New member function.
4671         (riscv_struct_info::m_offsets): New member variable.
4672         (riscv_struct_info::analyse_inner): New private member function,
4673         takes the old implementation of riscv_struct_info::analyse but
4674         extended to track field offsets.
4675         (riscv_call_arg_struct): Update the struct folding special cases
4676         to handle cases where empty C++ structs, which are non-zero
4677         length, are found.
4678         (riscv_arg_location): Initialise the length of each location, a
4679         non-zero length now indicates the location is in use.
4680         (riscv_push_dummy_call): Allow for the first location having a
4681         non-zero offset when setting up arguments.
4682         (riscv_return_value): Likewise, but for return values.
4683
4684 2019-04-11  Tom Tromey  <tromey@adacore.com>
4685
4686         * utils.c (internal_vproblem): Make "msg" const.
4687
4688 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4689
4690         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4691         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4692         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4693         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4694
4695 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4696
4697         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4698         function.
4699         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4700         of amd64_collect_native_gregset.
4701         (amd64_linux_nat_target::store_registers): Likewise.
4702
4703 2019-04-10  Tom Tromey  <tom@tromey.com>
4704
4705         * symtab.c (lookup_global_symbol_from_objfile)
4706         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4707         * objfiles.h (class separate_debug_iterator): New.
4708         (class separate_debug_range): New.
4709         (struct objfile) <separate_debug_objfiles>: New method.
4710         (objfile_separate_debug_iterate): Don't declare.
4711         * objfiles.c (separate_debug_iterator::operator++): Rename from
4712         objfile_separate_debug_iterate.
4713         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4714         iterator.
4715         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4716         iterator.
4717
4718 2019-04-10  Tom Tromey  <tom@tromey.com>
4719
4720         * symfile.c (reread_symbols): Remove old comment.
4721         * objfiles.c (free_all_objfiles): Fix a typo.
4722
4723 2019-04-10  Tom Tromey  <tom@tromey.com>
4724
4725         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4726         * minsyms.c (lookup_minimal_symbol): Use foreach.
4727         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4728         (lookup_minimal_symbol_solib_trampoline): Likewise.
4729         * symfile.c (reread_symbols): Use foreach.
4730
4731 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4732             Tom Tromey  <tromey@adacore.com>
4733
4734         PR rust/24414:
4735         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4736         (rust_lex_int_test): Change "value" to be LONGEST.
4737         (rust_lex_tests): Add test for long integer literal.
4738
4739 2019-04-09  Tom Tromey  <tromey@adacore.com>
4740
4741         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4742         to bool.
4743         (extended_remote_target::attach): Update.
4744         (remote_target::remote_notice_new_inferior): Update.
4745         (remote_target::add_current_inferior_and_thread): Update.
4746         * inferior.c (exit_inferior_1): Use "false".
4747         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4748
4749 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4750
4751         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4752         the "start" command.
4753
4754 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4755
4756         * python/py-inferior.c (infpy_thread_from_thread_handle):
4757         Adjust comments to reflect renaming of thread_from_thread_handle
4758         to thread_from_handle.  Adjust keywords.  Fix type error message.
4759         (inferior_object_methods): Add thread_from_handle.  Retain
4760         thread_from_thread_handle, but mark it as deprecated.
4761
4762 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4763
4764         * gdbthread.h (find_thread_by_handle): Revise declaration.
4765         * thread.c (find_thread_by_handle): Likewise.  Adjust
4766         implementation too.
4767         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4768         support for buffer objects as handles.
4769
4770 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4771
4772         * python/py-infthread.c (thpy_thread_handle): New function.
4773         (thread_object_methods): Register thpy_thread_handle.
4774
4775 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4776
4777         * gdbthread.h (thread_to_thread_handle): Declare.
4778         * thread.c (gdbtypes.h): Include.
4779         (thread_to_thread_handle): New function.
4780
4781         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4782         (target_thread_info_to_thread_handle): Declare.
4783         * target.c (target_thread_info_to_thread_handle): New function.
4784         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4785         * target-delegates.c: Regenerate.
4786
4787         * linux-thread-db.c (class thread_db_target): Add method
4788         thread_info_to_thread_handle.
4789         (thread_db_target::thread_info_to_thread_handle): Define.
4790         * remote.c (class remote_target): Add new method
4791         thread_info_to_thread_handle.
4792         (remote_target::thread_info_to_thread_handle): Define.
4793
4794 2019-04-08  Pedro Alves  <palves@redhat.com>
4795
4796         * common/common-exceptions.c (throw_exception): Don't create
4797         named object to throw; throw directly.
4798         (throw_it): Likewise.  Don't initialize gdb_exception::message
4799         here, with new; pass FMT and AP to the ctor instead.
4800         * common/common-exceptions.h: Include <string>.
4801         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4802         const char *, va_list)): New ctor.  Use std::make_shared.
4803         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4804         errors)): Delete.
4805         (gdb_exception_error::gdb_exception_error(enum errors, const char
4806         *, va_list)): New.
4807         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4808         Add assertion.
4809         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4810         errors)): Delete.
4811         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4812         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4813         Add assertion.
4814
4815 2019-04-08  Tom Tromey  <tom@tromey.com>
4816
4817         * valops.c (value_rtti_indirect_type): Replace throw_exception
4818         with throw.
4819         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4820         with throw.
4821         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4822         throw.
4823         * target.c (target_translate_tls_address): Replace throw_exception
4824         with throw.
4825         * stack.c (frame_apply_command_count): Replace throw_exception
4826         with throw.
4827         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4828         throw.
4829         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4830         with throw.
4831         * rs6000-tdep.c (rs6000_frame_cache)
4832         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4833         * remote.c: Replace throw_exception with throw.
4834         * record-full.c (record_full_message, record_full_wait_1)
4835         (record_full_restore): Replace throw_exception with throw.
4836         * record-btrace.c:
4837         (get_thread_current_frame_id, record_btrace_start_replaying)
4838         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4839         (cmd_record_btrace_start): Replace throw_exception with throw.
4840         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4841         throw.
4842         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4843         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4844         * linespec.c:
4845         (find_linespec_symbols): Replace throw_exception with throw.
4846         * infrun.c (displaced_step_prepare, resume): Replace
4847         throw_exception with throw.
4848         * infcmd.c (post_create_inferior): Replace throw_exception with
4849         throw.
4850         * inf-loop.c (inferior_event_handler): Replace throw_exception
4851         with throw.
4852         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4853         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4854         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4855         (get_prev_frame_always, get_frame_pc_if_available)
4856         (get_frame_address_in_block_if_available, get_frame_language):
4857         Replace throw_exception with throw.
4858         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4859         throw_exception with throw.
4860         * eval.c (fetch_subexp_value, evaluate_var_value)
4861         (evaluate_funcall, evaluate_subexp_standard): Replace
4862         throw_exception with throw.
4863         * dwarf2loc.c (call_site_find_chain)
4864         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4865         Replace throw_exception with throw.
4866         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4867         with throw.
4868         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4869         throw.
4870         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4871         * completer.c (complete_line_internal): Replace throw_exception
4872         with throw.
4873         * compile/compile-object-run.c (compile_object_run): Replace
4874         throw_exception with throw.
4875         * cli/cli-script.c (process_next_line): Replace throw_exception
4876         with throw.
4877         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4878         (btrace_enable, btrace_maint_update_pt_packets): Replace
4879         throw_exception with throw.
4880         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4881         throw_exception with throw.
4882         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4883         throw_exception with throw.
4884         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4885         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4886         * aarch64-tdep.c (aarch64_make_prologue_cache)
4887         (aarch64_make_stub_cache): Replace throw_exception with throw.
4888
4889 2019-04-08  Tom Tromey  <tom@tromey.com>
4890
4891         * common/common-exceptions.c (throw_exception): Rename from
4892         throw_exception_cxx.  Remove old copy.  Make argument const.
4893         (throw_it): Create and throw exception objects directly.
4894         * common/common-exceptions.h (throw_exception): Make argument
4895         const.
4896         (struct gdb_exception_error): Add constructor.
4897         (struct gdb_exception_quit): Add constructor.
4898
4899 2019-04-08  Tom Tromey  <tom@tromey.com>
4900
4901         * common/common-exceptions.h (exception_rethrow): Don't declare.
4902         (TRY_SJLJ): Update comment.
4903         (TRY, CATCH, END_CATCH): Remove.
4904         * common/common-exceptions.c (exception_rethrow): Remove.
4905
4906 2019-04-08  Tom Tromey  <tom@tromey.com>
4907
4908         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4909         Remove.
4910         (gdb_exception_error): Rename from
4911         gdb_exception_RETURN_MASK_ERROR.
4912         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4913         (gdb_quit_bad_alloc): Update.
4914         * aarch64-tdep.c: Update.
4915         * ada-lang.c: Update.
4916         * ada-typeprint.c: Update.
4917         * ada-valprint.c: Update.
4918         * amd64-tdep.c: Update.
4919         * arch-utils.c: Update.
4920         * break-catch-throw.c: Update.
4921         * breakpoint.c: Update.
4922         * btrace.c: Update.
4923         * c-varobj.c: Update.
4924         * cli/cli-cmds.c: Update.
4925         * cli/cli-interp.c: Update.
4926         * cli/cli-script.c: Update.
4927         * common/common-exceptions.c: Update.
4928         * common/new-op.c: Update.
4929         * common/selftest.c: Update.
4930         * compile/compile-c-symbols.c: Update.
4931         * compile/compile-cplus-symbols.c: Update.
4932         * compile/compile-object-load.c: Update.
4933         * compile/compile-object-run.c: Update.
4934         * completer.c: Update.
4935         * corelow.c: Update.
4936         * cp-abi.c: Update.
4937         * cp-support.c: Update.
4938         * cp-valprint.c: Update.
4939         * darwin-nat.c: Update.
4940         * disasm-selftests.c: Update.
4941         * dtrace-probe.c: Update.
4942         * dwarf-index-cache.c: Update.
4943         * dwarf-index-write.c: Update.
4944         * dwarf2-frame-tailcall.c: Update.
4945         * dwarf2-frame.c: Update.
4946         * dwarf2loc.c: Update.
4947         * dwarf2read.c: Update.
4948         * eval.c: Update.
4949         * event-loop.c: Update.
4950         * event-top.c: Update.
4951         * exec.c: Update.
4952         * f-valprint.c: Update.
4953         * fbsd-tdep.c: Update.
4954         * frame-unwind.c: Update.
4955         * frame.c: Update.
4956         * gdbtypes.c: Update.
4957         * gnu-v3-abi.c: Update.
4958         * guile/guile-internal.h: Update.
4959         * guile/scm-block.c: Update.
4960         * guile/scm-breakpoint.c: Update.
4961         * guile/scm-cmd.c: Update.
4962         * guile/scm-disasm.c: Update.
4963         * guile/scm-frame.c: Update.
4964         * guile/scm-lazy-string.c: Update.
4965         * guile/scm-math.c: Update.
4966         * guile/scm-param.c: Update.
4967         * guile/scm-ports.c: Update.
4968         * guile/scm-pretty-print.c: Update.
4969         * guile/scm-symbol.c: Update.
4970         * guile/scm-symtab.c: Update.
4971         * guile/scm-type.c: Update.
4972         * guile/scm-value.c: Update.
4973         * i386-linux-tdep.c: Update.
4974         * i386-tdep.c: Update.
4975         * inf-loop.c: Update.
4976         * infcall.c: Update.
4977         * infcmd.c: Update.
4978         * infrun.c: Update.
4979         * jit.c: Update.
4980         * language.c: Update.
4981         * linespec.c: Update.
4982         * linux-fork.c: Update.
4983         * linux-nat.c: Update.
4984         * linux-tdep.c: Update.
4985         * linux-thread-db.c: Update.
4986         * main.c: Update.
4987         * mi/mi-cmd-break.c: Update.
4988         * mi/mi-cmd-stack.c: Update.
4989         * mi/mi-interp.c: Update.
4990         * mi/mi-main.c: Update.
4991         * objc-lang.c: Update.
4992         * p-valprint.c: Update.
4993         * parse.c: Update.
4994         * ppc-linux-tdep.c: Update.
4995         * printcmd.c: Update.
4996         * python/py-arch.c: Update.
4997         * python/py-breakpoint.c: Update.
4998         * python/py-cmd.c: Update.
4999         * python/py-finishbreakpoint.c: Update.
5000         * python/py-frame.c: Update.
5001         * python/py-framefilter.c: Update.
5002         * python/py-gdb-readline.c: Update.
5003         * python/py-inferior.c: Update.
5004         * python/py-infthread.c: Update.
5005         * python/py-lazy-string.c: Update.
5006         * python/py-linetable.c: Update.
5007         * python/py-objfile.c: Update.
5008         * python/py-param.c: Update.
5009         * python/py-prettyprint.c: Update.
5010         * python/py-progspace.c: Update.
5011         * python/py-record-btrace.c: Update.
5012         * python/py-record.c: Update.
5013         * python/py-symbol.c: Update.
5014         * python/py-type.c: Update.
5015         * python/py-unwind.c: Update.
5016         * python/py-utils.c: Update.
5017         * python/py-value.c: Update.
5018         * python/python.c: Update.
5019         * record-btrace.c: Update.
5020         * record-full.c: Update.
5021         * remote-fileio.c: Update.
5022         * remote.c: Update.
5023         * riscv-tdep.c: Update.
5024         * rs6000-aix-tdep.c: Update.
5025         * rs6000-tdep.c: Update.
5026         * rust-exp.y: Update.
5027         * rust-lang.c: Update.
5028         * s390-tdep.c: Update.
5029         * selftest-arch.c: Update.
5030         * solib-dsbt.c: Update.
5031         * solib-frv.c: Update.
5032         * solib-spu.c: Update.
5033         * solib-svr4.c: Update.
5034         * solib.c: Update.
5035         * sparc64-linux-tdep.c: Update.
5036         * stack.c: Update.
5037         * symfile-mem.c: Update.
5038         * symmisc.c: Update.
5039         * target.c: Update.
5040         * thread.c: Update.
5041         * top.c: Update.
5042         * tracefile-tfile.c: Update.
5043         * tui/tui.c: Update.
5044         * typeprint.c: Update.
5045         * unittests/cli-utils-selftests.c: Update.
5046         * unittests/parse-connection-spec-selftests.c: Update.
5047         * valops.c: Update.
5048         * valprint.c: Update.
5049         * value.c: Update.
5050         * varobj.c: Update.
5051         * windows-nat.c: Update.
5052         * x86-linux-nat.c: Update.
5053         * xml-support.c: Update.
5054
5055 2019-04-08  Tom Tromey  <tom@tromey.com>
5056
5057         * xml-support.c: Use C++ exception handling.
5058         * x86-linux-nat.c: Use C++ exception handling.
5059         * windows-nat.c: Use C++ exception handling.
5060         * varobj.c: Use C++ exception handling.
5061         * value.c: Use C++ exception handling.
5062         * valprint.c: Use C++ exception handling.
5063         * valops.c: Use C++ exception handling.
5064         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5065         handling.
5066         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5067         * typeprint.c: Use C++ exception handling.
5068         * tui/tui.c: Use C++ exception handling.
5069         * tracefile-tfile.c: Use C++ exception handling.
5070         * top.c: Use C++ exception handling.
5071         * thread.c: Use C++ exception handling.
5072         * target.c: Use C++ exception handling.
5073         * symmisc.c: Use C++ exception handling.
5074         * symfile-mem.c: Use C++ exception handling.
5075         * stack.c: Use C++ exception handling.
5076         * sparc64-linux-tdep.c: Use C++ exception handling.
5077         * solib.c: Use C++ exception handling.
5078         * solib-svr4.c: Use C++ exception handling.
5079         * solib-spu.c: Use C++ exception handling.
5080         * solib-frv.c: Use C++ exception handling.
5081         * solib-dsbt.c: Use C++ exception handling.
5082         * selftest-arch.c: Use C++ exception handling.
5083         * s390-tdep.c: Use C++ exception handling.
5084         * rust-lang.c: Use C++ exception handling.
5085         * rust-exp.y: Use C++ exception handling.
5086         * rs6000-tdep.c: Use C++ exception handling.
5087         * rs6000-aix-tdep.c: Use C++ exception handling.
5088         * riscv-tdep.c: Use C++ exception handling.
5089         * remote.c: Use C++ exception handling.
5090         * remote-fileio.c: Use C++ exception handling.
5091         * record-full.c: Use C++ exception handling.
5092         * record-btrace.c: Use C++ exception handling.
5093         * python/python.c: Use C++ exception handling.
5094         * python/py-value.c: Use C++ exception handling.
5095         * python/py-utils.c: Use C++ exception handling.
5096         * python/py-unwind.c: Use C++ exception handling.
5097         * python/py-type.c: Use C++ exception handling.
5098         * python/py-symbol.c: Use C++ exception handling.
5099         * python/py-record.c: Use C++ exception handling.
5100         * python/py-record-btrace.c: Use C++ exception handling.
5101         * python/py-progspace.c: Use C++ exception handling.
5102         * python/py-prettyprint.c: Use C++ exception handling.
5103         * python/py-param.c: Use C++ exception handling.
5104         * python/py-objfile.c: Use C++ exception handling.
5105         * python/py-linetable.c: Use C++ exception handling.
5106         * python/py-lazy-string.c: Use C++ exception handling.
5107         * python/py-infthread.c: Use C++ exception handling.
5108         * python/py-inferior.c: Use C++ exception handling.
5109         * python/py-gdb-readline.c: Use C++ exception handling.
5110         * python/py-framefilter.c: Use C++ exception handling.
5111         * python/py-frame.c: Use C++ exception handling.
5112         * python/py-finishbreakpoint.c: Use C++ exception handling.
5113         * python/py-cmd.c: Use C++ exception handling.
5114         * python/py-breakpoint.c: Use C++ exception handling.
5115         * python/py-arch.c: Use C++ exception handling.
5116         * printcmd.c: Use C++ exception handling.
5117         * ppc-linux-tdep.c: Use C++ exception handling.
5118         * parse.c: Use C++ exception handling.
5119         * p-valprint.c: Use C++ exception handling.
5120         * objc-lang.c: Use C++ exception handling.
5121         * mi/mi-main.c: Use C++ exception handling.
5122         * mi/mi-interp.c: Use C++ exception handling.
5123         * mi/mi-cmd-stack.c: Use C++ exception handling.
5124         * mi/mi-cmd-break.c: Use C++ exception handling.
5125         * main.c: Use C++ exception handling.
5126         * linux-thread-db.c: Use C++ exception handling.
5127         * linux-tdep.c: Use C++ exception handling.
5128         * linux-nat.c: Use C++ exception handling.
5129         * linux-fork.c: Use C++ exception handling.
5130         * linespec.c: Use C++ exception handling.
5131         * language.c: Use C++ exception handling.
5132         * jit.c: Use C++ exception handling.
5133         * infrun.c: Use C++ exception handling.
5134         * infcmd.c: Use C++ exception handling.
5135         * infcall.c: Use C++ exception handling.
5136         * inf-loop.c: Use C++ exception handling.
5137         * i386-tdep.c: Use C++ exception handling.
5138         * i386-linux-tdep.c: Use C++ exception handling.
5139         * guile/scm-value.c: Use C++ exception handling.
5140         * guile/scm-type.c: Use C++ exception handling.
5141         * guile/scm-symtab.c: Use C++ exception handling.
5142         * guile/scm-symbol.c: Use C++ exception handling.
5143         * guile/scm-pretty-print.c: Use C++ exception handling.
5144         * guile/scm-ports.c: Use C++ exception handling.
5145         * guile/scm-param.c: Use C++ exception handling.
5146         * guile/scm-math.c: Use C++ exception handling.
5147         * guile/scm-lazy-string.c: Use C++ exception handling.
5148         * guile/scm-frame.c: Use C++ exception handling.
5149         * guile/scm-disasm.c: Use C++ exception handling.
5150         * guile/scm-cmd.c: Use C++ exception handling.
5151         * guile/scm-breakpoint.c: Use C++ exception handling.
5152         * guile/scm-block.c: Use C++ exception handling.
5153         * guile/guile-internal.h: Use C++ exception handling.
5154         * gnu-v3-abi.c: Use C++ exception handling.
5155         * gdbtypes.c: Use C++ exception handling.
5156         * frame.c: Use C++ exception handling.
5157         * frame-unwind.c: Use C++ exception handling.
5158         * fbsd-tdep.c: Use C++ exception handling.
5159         * f-valprint.c: Use C++ exception handling.
5160         * exec.c: Use C++ exception handling.
5161         * event-top.c: Use C++ exception handling.
5162         * event-loop.c: Use C++ exception handling.
5163         * eval.c: Use C++ exception handling.
5164         * dwarf2read.c: Use C++ exception handling.
5165         * dwarf2loc.c: Use C++ exception handling.
5166         * dwarf2-frame.c: Use C++ exception handling.
5167         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5168         * dwarf-index-write.c: Use C++ exception handling.
5169         * dwarf-index-cache.c: Use C++ exception handling.
5170         * dtrace-probe.c: Use C++ exception handling.
5171         * disasm-selftests.c: Use C++ exception handling.
5172         * darwin-nat.c: Use C++ exception handling.
5173         * cp-valprint.c: Use C++ exception handling.
5174         * cp-support.c: Use C++ exception handling.
5175         * cp-abi.c: Use C++ exception handling.
5176         * corelow.c: Use C++ exception handling.
5177         * completer.c: Use C++ exception handling.
5178         * compile/compile-object-run.c: Use C++ exception handling.
5179         * compile/compile-object-load.c: Use C++ exception handling.
5180         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5181         * compile/compile-c-symbols.c: Use C++ exception handling.
5182         * common/selftest.c: Use C++ exception handling.
5183         * common/new-op.c: Use C++ exception handling.
5184         * cli/cli-script.c: Use C++ exception handling.
5185         * cli/cli-interp.c: Use C++ exception handling.
5186         * cli/cli-cmds.c: Use C++ exception handling.
5187         * c-varobj.c: Use C++ exception handling.
5188         * btrace.c: Use C++ exception handling.
5189         * breakpoint.c: Use C++ exception handling.
5190         * break-catch-throw.c: Use C++ exception handling.
5191         * arch-utils.c: Use C++ exception handling.
5192         * amd64-tdep.c: Use C++ exception handling.
5193         * ada-valprint.c: Use C++ exception handling.
5194         * ada-typeprint.c: Use C++ exception handling.
5195         * ada-lang.c: Use C++ exception handling.
5196         * aarch64-tdep.c: Use C++ exception handling.
5197
5198 2019-04-08  Tom Tromey  <tom@tromey.com>
5199
5200         * xml-support.c (gdb_xml_parser::parse): Update.
5201         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5202         * value.c (show_convenience): Update.
5203         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5204         (test_parse_flags_qcs): Update.
5205         * thread.c (thr_try_catch_cmd): Update.
5206         * target.c (target_translate_tls_address): Update.
5207         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5208         (info_frame_command_core, frame_apply_command_count): Update.
5209         * rust-exp.y (rust_lex_exception_test): Update.
5210         * riscv-tdep.c (riscv_print_one_register_info): Update.
5211         * remote.c (remote_target::enable_btrace): Update.
5212         * record-btrace.c (record_btrace_enable_warn): Update.
5213         * python/py-utils.c (gdbpy_convert_exception): Update.
5214         * printcmd.c (do_one_display, print_variable_and_value): Update.
5215         * mi/mi-main.c (mi_print_exception): Update.
5216         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5217         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5218         * linux-nat.c (linux_nat_target::attach): Update.
5219         * linux-fork.c (class scoped_switch_fork_info): Update.
5220         * infrun.c (displaced_step_prepare): Update.
5221         * infcall.c (call_function_by_hand_dummy): Update.
5222         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5223         * gnu-v3-abi.c (print_one_vtable): Update.
5224         * frame.c (get_prev_frame_always): Update.
5225         * f-valprint.c (info_common_command_for_block): Update.
5226         * exec.c (try_open_exec_file): Update.
5227         * exceptions.c (print_exception, exception_print)
5228         (exception_fprintf, exception_print_same): Update.
5229         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5230         * dwarf-index-cache.c (index_cache::store)
5231         (index_cache::lookup_gdb_index): Update.
5232         * darwin-nat.c (maybe_cache_shell): Update.
5233         * cp-valprint.c (cp_print_value_fields): Update.
5234         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5235         (gcc_cplus_symbol_address): Update.
5236         * compile/compile-c-symbols.c (gcc_convert_symbol)
5237         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5238         * common/selftest.c: Update.
5239         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5240         a std::string.
5241         (exception_try_scope_entry, exception_try_scope_exit): Don't
5242         declare.
5243         (struct exception_try_scope): Remove.
5244         (TRY): Don't use exception_try_scope.
5245         (struct gdb_exception): Add constructor, operator=.
5246         <what>: New method.
5247         (struct gdb_exception_RETURN_MASK_ALL)
5248         (struct gdb_exception_RETURN_MASK_ERROR)
5249         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5250         (struct gdb_quit_bad_alloc): Update.
5251         * common/common-exceptions.c (exception_none): Change
5252         initializer.
5253         (struct catcher) <state, exception>: Initialize inline.
5254         <prev>: Remove member.
5255         (current_catcher): Remove.
5256         (catchers): New global.
5257         (exceptions_state_mc_init): Simplify.
5258         (catcher_pop): Remove.
5259         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5260         (try_scope_depth, exception_try_scope_entry)
5261         (exception_try_scope_exit): Remove.
5262         (throw_exception_sjlj): Update.
5263         (exception_messages, exception_messages_size): Remove.
5264         (throw_it): Simplify.
5265         (gdb_exception_sliced_copy): Remove.
5266         (throw_exception_cxx): Update.
5267         * cli/cli-script.c (script_from_file): Update.
5268         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5269         Update.
5270         * ada-valprint.c (ada_val_print): Update.
5271         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5272         (create_excep_cond_exprs): Update.
5273
5274 2019-04-08  Tom Tromey  <tom@tromey.com>
5275
5276         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5277         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5278         (TRY, CATCH, END_CATCH): Remove some definitions.
5279         * common/common-exceptions.c: Don't use GDB_XCPT.
5280         (catcher_list_size): Remove.
5281         (throw_exception, throw_it): Simplify.
5282
5283 2019-04-05  Tom Tromey  <tom@tromey.com>
5284
5285         Revert the header-sorting patch.
5286         * ft32-tdep.c: Revert.
5287         * frv-tdep.c: Revert.
5288         * frv-linux-tdep.c: Revert.
5289         * frame.c: Revert.
5290         * frame-unwind.c: Revert.
5291         * frame-base.c: Revert.
5292         * fork-child.c: Revert.
5293         * findvar.c: Revert.
5294         * findcmd.c: Revert.
5295         * filesystem.c: Revert.
5296         * filename-seen-cache.h: Revert.
5297         * filename-seen-cache.c: Revert.
5298         * fbsd-tdep.c: Revert.
5299         * fbsd-nat.h: Revert.
5300         * fbsd-nat.c: Revert.
5301         * f-valprint.c: Revert.
5302         * f-typeprint.c: Revert.
5303         * f-lang.c: Revert.
5304         * extension.h: Revert.
5305         * extension.c: Revert.
5306         * extension-priv.h: Revert.
5307         * expprint.c: Revert.
5308         * exec.h: Revert.
5309         * exec.c: Revert.
5310         * exceptions.c: Revert.
5311         * event-top.c: Revert.
5312         * event-loop.c: Revert.
5313         * eval.c: Revert.
5314         * elfread.c: Revert.
5315         * dwarf2read.h: Revert.
5316         * dwarf2read.c: Revert.
5317         * dwarf2loc.c: Revert.
5318         * dwarf2expr.h: Revert.
5319         * dwarf2expr.c: Revert.
5320         * dwarf2-frame.c: Revert.
5321         * dwarf2-frame-tailcall.c: Revert.
5322         * dwarf-index-write.h: Revert.
5323         * dwarf-index-write.c: Revert.
5324         * dwarf-index-common.c: Revert.
5325         * dwarf-index-cache.h: Revert.
5326         * dwarf-index-cache.c: Revert.
5327         * dummy-frame.c: Revert.
5328         * dtrace-probe.c: Revert.
5329         * disasm.h: Revert.
5330         * disasm.c: Revert.
5331         * disasm-selftests.c: Revert.
5332         * dictionary.c: Revert.
5333         * dicos-tdep.c: Revert.
5334         * demangle.c: Revert.
5335         * dcache.h: Revert.
5336         * dcache.c: Revert.
5337         * darwin-nat.h: Revert.
5338         * darwin-nat.c: Revert.
5339         * darwin-nat-info.c: Revert.
5340         * d-valprint.c: Revert.
5341         * d-namespace.c: Revert.
5342         * d-lang.c: Revert.
5343         * ctf.c: Revert.
5344         * csky-tdep.c: Revert.
5345         * csky-linux-tdep.c: Revert.
5346         * cris-tdep.c: Revert.
5347         * cris-linux-tdep.c: Revert.
5348         * cp-valprint.c: Revert.
5349         * cp-support.c: Revert.
5350         * cp-namespace.c: Revert.
5351         * cp-abi.c: Revert.
5352         * corelow.c: Revert.
5353         * corefile.c: Revert.
5354         * continuations.c: Revert.
5355         * completer.h: Revert.
5356         * completer.c: Revert.
5357         * complaints.c: Revert.
5358         * coffread.c: Revert.
5359         * coff-pe-read.c: Revert.
5360         * cli-out.h: Revert.
5361         * cli-out.c: Revert.
5362         * charset.c: Revert.
5363         * c-varobj.c: Revert.
5364         * c-valprint.c: Revert.
5365         * c-typeprint.c: Revert.
5366         * c-lang.c: Revert.
5367         * buildsym.c: Revert.
5368         * buildsym-legacy.c: Revert.
5369         * build-id.h: Revert.
5370         * build-id.c: Revert.
5371         * btrace.c: Revert.
5372         * bsd-uthread.c: Revert.
5373         * breakpoint.h: Revert.
5374         * breakpoint.c: Revert.
5375         * break-catch-throw.c: Revert.
5376         * break-catch-syscall.c: Revert.
5377         * break-catch-sig.c: Revert.
5378         * blockframe.c: Revert.
5379         * block.c: Revert.
5380         * bfin-tdep.c: Revert.
5381         * bfin-linux-tdep.c: Revert.
5382         * bfd-target.c: Revert.
5383         * bcache.c: Revert.
5384         * ax-general.c: Revert.
5385         * ax-gdb.h: Revert.
5386         * ax-gdb.c: Revert.
5387         * avr-tdep.c: Revert.
5388         * auxv.c: Revert.
5389         * auto-load.c: Revert.
5390         * arm-wince-tdep.c: Revert.
5391         * arm-tdep.c: Revert.
5392         * arm-symbian-tdep.c: Revert.
5393         * arm-pikeos-tdep.c: Revert.
5394         * arm-obsd-tdep.c: Revert.
5395         * arm-nbsd-tdep.c: Revert.
5396         * arm-nbsd-nat.c: Revert.
5397         * arm-linux-tdep.c: Revert.
5398         * arm-linux-nat.c: Revert.
5399         * arm-fbsd-tdep.c: Revert.
5400         * arm-fbsd-nat.c: Revert.
5401         * arm-bsd-tdep.c: Revert.
5402         * arch-utils.c: Revert.
5403         * arc-tdep.c: Revert.
5404         * arc-newlib-tdep.c: Revert.
5405         * annotate.h: Revert.
5406         * annotate.c: Revert.
5407         * amd64-windows-tdep.c: Revert.
5408         * amd64-windows-nat.c: Revert.
5409         * amd64-tdep.c: Revert.
5410         * amd64-sol2-tdep.c: Revert.
5411         * amd64-obsd-tdep.c: Revert.
5412         * amd64-obsd-nat.c: Revert.
5413         * amd64-nbsd-tdep.c: Revert.
5414         * amd64-nbsd-nat.c: Revert.
5415         * amd64-nat.c: Revert.
5416         * amd64-linux-tdep.c: Revert.
5417         * amd64-linux-nat.c: Revert.
5418         * amd64-fbsd-tdep.c: Revert.
5419         * amd64-fbsd-nat.c: Revert.
5420         * amd64-dicos-tdep.c: Revert.
5421         * amd64-darwin-tdep.c: Revert.
5422         * amd64-bsd-nat.c: Revert.
5423         * alpha-tdep.c: Revert.
5424         * alpha-obsd-tdep.c: Revert.
5425         * alpha-nbsd-tdep.c: Revert.
5426         * alpha-mdebug-tdep.c: Revert.
5427         * alpha-linux-tdep.c: Revert.
5428         * alpha-linux-nat.c: Revert.
5429         * alpha-bsd-tdep.c: Revert.
5430         * alpha-bsd-nat.c: Revert.
5431         * aix-thread.c: Revert.
5432         * agent.c: Revert.
5433         * addrmap.c: Revert.
5434         * ada-varobj.c: Revert.
5435         * ada-valprint.c: Revert.
5436         * ada-typeprint.c: Revert.
5437         * ada-tasks.c: Revert.
5438         * ada-lang.c: Revert.
5439         * aarch64-tdep.c: Revert.
5440         * aarch64-ravenscar-thread.c: Revert.
5441         * aarch64-newlib-tdep.c: Revert.
5442         * aarch64-linux-tdep.c: Revert.
5443         * aarch64-linux-nat.c: Revert.
5444         * aarch64-fbsd-tdep.c: Revert.
5445         * aarch64-fbsd-nat.c: Revert.
5446         * aarch32-linux-nat.c: Revert.
5447
5448 2019-04-05  Tom Tromey  <tom@tromey.com>
5449
5450         * ft32-tdep.c: Sort headers.
5451         * frv-tdep.c: Sort headers.
5452         * frv-linux-tdep.c: Sort headers.
5453         * frame.c: Sort headers.
5454         * frame-unwind.c: Sort headers.
5455         * frame-base.c: Sort headers.
5456         * fork-child.c: Sort headers.
5457         * findvar.c: Sort headers.
5458         * findcmd.c: Sort headers.
5459         * filesystem.c: Sort headers.
5460         * filename-seen-cache.h: Sort headers.
5461         * filename-seen-cache.c: Sort headers.
5462         * fbsd-tdep.c: Sort headers.
5463         * fbsd-nat.h: Sort headers.
5464         * fbsd-nat.c: Sort headers.
5465         * f-valprint.c: Sort headers.
5466         * f-typeprint.c: Sort headers.
5467         * f-lang.c: Sort headers.
5468         * extension.h: Sort headers.
5469         * extension.c: Sort headers.
5470         * extension-priv.h: Sort headers.
5471         * expprint.c: Sort headers.
5472         * exec.h: Sort headers.
5473         * exec.c: Sort headers.
5474         * exceptions.c: Sort headers.
5475         * event-top.c: Sort headers.
5476         * event-loop.c: Sort headers.
5477         * eval.c: Sort headers.
5478         * elfread.c: Sort headers.
5479         * dwarf2read.h: Sort headers.
5480         * dwarf2read.c: Sort headers.
5481         * dwarf2loc.c: Sort headers.
5482         * dwarf2expr.h: Sort headers.
5483         * dwarf2expr.c: Sort headers.
5484         * dwarf2-frame.c: Sort headers.
5485         * dwarf2-frame-tailcall.c: Sort headers.
5486         * dwarf-index-write.h: Sort headers.
5487         * dwarf-index-write.c: Sort headers.
5488         * dwarf-index-common.c: Sort headers.
5489         * dwarf-index-cache.h: Sort headers.
5490         * dwarf-index-cache.c: Sort headers.
5491         * dummy-frame.c: Sort headers.
5492         * dtrace-probe.c: Sort headers.
5493         * disasm.h: Sort headers.
5494         * disasm.c: Sort headers.
5495         * disasm-selftests.c: Sort headers.
5496         * dictionary.c: Sort headers.
5497         * dicos-tdep.c: Sort headers.
5498         * demangle.c: Sort headers.
5499         * dcache.h: Sort headers.
5500         * dcache.c: Sort headers.
5501         * darwin-nat.h: Sort headers.
5502         * darwin-nat.c: Sort headers.
5503         * darwin-nat-info.c: Sort headers.
5504         * d-valprint.c: Sort headers.
5505         * d-namespace.c: Sort headers.
5506         * d-lang.c: Sort headers.
5507         * ctf.c: Sort headers.
5508         * csky-tdep.c: Sort headers.
5509         * csky-linux-tdep.c: Sort headers.
5510         * cris-tdep.c: Sort headers.
5511         * cris-linux-tdep.c: Sort headers.
5512         * cp-valprint.c: Sort headers.
5513         * cp-support.c: Sort headers.
5514         * cp-namespace.c: Sort headers.
5515         * cp-abi.c: Sort headers.
5516         * corelow.c: Sort headers.
5517         * corefile.c: Sort headers.
5518         * continuations.c: Sort headers.
5519         * completer.h: Sort headers.
5520         * completer.c: Sort headers.
5521         * complaints.c: Sort headers.
5522         * coffread.c: Sort headers.
5523         * coff-pe-read.c: Sort headers.
5524         * cli-out.h: Sort headers.
5525         * cli-out.c: Sort headers.
5526         * charset.c: Sort headers.
5527         * c-varobj.c: Sort headers.
5528         * c-valprint.c: Sort headers.
5529         * c-typeprint.c: Sort headers.
5530         * c-lang.c: Sort headers.
5531         * buildsym.c: Sort headers.
5532         * buildsym-legacy.c: Sort headers.
5533         * build-id.h: Sort headers.
5534         * build-id.c: Sort headers.
5535         * btrace.c: Sort headers.
5536         * bsd-uthread.c: Sort headers.
5537         * breakpoint.h: Sort headers.
5538         * breakpoint.c: Sort headers.
5539         * break-catch-throw.c: Sort headers.
5540         * break-catch-syscall.c: Sort headers.
5541         * break-catch-sig.c: Sort headers.
5542         * blockframe.c: Sort headers.
5543         * block.c: Sort headers.
5544         * bfin-tdep.c: Sort headers.
5545         * bfin-linux-tdep.c: Sort headers.
5546         * bfd-target.c: Sort headers.
5547         * bcache.c: Sort headers.
5548         * ax-general.c: Sort headers.
5549         * ax-gdb.h: Sort headers.
5550         * ax-gdb.c: Sort headers.
5551         * avr-tdep.c: Sort headers.
5552         * auxv.c: Sort headers.
5553         * auto-load.c: Sort headers.
5554         * arm-wince-tdep.c: Sort headers.
5555         * arm-tdep.c: Sort headers.
5556         * arm-symbian-tdep.c: Sort headers.
5557         * arm-pikeos-tdep.c: Sort headers.
5558         * arm-obsd-tdep.c: Sort headers.
5559         * arm-nbsd-tdep.c: Sort headers.
5560         * arm-nbsd-nat.c: Sort headers.
5561         * arm-linux-tdep.c: Sort headers.
5562         * arm-linux-nat.c: Sort headers.
5563         * arm-fbsd-tdep.c: Sort headers.
5564         * arm-fbsd-nat.c: Sort headers.
5565         * arm-bsd-tdep.c: Sort headers.
5566         * arch-utils.c: Sort headers.
5567         * arc-tdep.c: Sort headers.
5568         * arc-newlib-tdep.c: Sort headers.
5569         * annotate.h: Sort headers.
5570         * annotate.c: Sort headers.
5571         * amd64-windows-tdep.c: Sort headers.
5572         * amd64-windows-nat.c: Sort headers.
5573         * amd64-tdep.c: Sort headers.
5574         * amd64-sol2-tdep.c: Sort headers.
5575         * amd64-obsd-tdep.c: Sort headers.
5576         * amd64-obsd-nat.c: Sort headers.
5577         * amd64-nbsd-tdep.c: Sort headers.
5578         * amd64-nbsd-nat.c: Sort headers.
5579         * amd64-nat.c: Sort headers.
5580         * amd64-linux-tdep.c: Sort headers.
5581         * amd64-linux-nat.c: Sort headers.
5582         * amd64-fbsd-tdep.c: Sort headers.
5583         * amd64-fbsd-nat.c: Sort headers.
5584         * amd64-dicos-tdep.c: Sort headers.
5585         * amd64-darwin-tdep.c: Sort headers.
5586         * amd64-bsd-nat.c: Sort headers.
5587         * alpha-tdep.c: Sort headers.
5588         * alpha-obsd-tdep.c: Sort headers.
5589         * alpha-nbsd-tdep.c: Sort headers.
5590         * alpha-mdebug-tdep.c: Sort headers.
5591         * alpha-linux-tdep.c: Sort headers.
5592         * alpha-linux-nat.c: Sort headers.
5593         * alpha-bsd-tdep.c: Sort headers.
5594         * alpha-bsd-nat.c: Sort headers.
5595         * aix-thread.c: Sort headers.
5596         * agent.c: Sort headers.
5597         * addrmap.c: Sort headers.
5598         * ada-varobj.c: Sort headers.
5599         * ada-valprint.c: Sort headers.
5600         * ada-typeprint.c: Sort headers.
5601         * ada-tasks.c: Sort headers.
5602         * ada-lang.c: Sort headers.
5603         * aarch64-tdep.c: Sort headers.
5604         * aarch64-ravenscar-thread.c: Sort headers.
5605         * aarch64-newlib-tdep.c: Sort headers.
5606         * aarch64-linux-tdep.c: Sort headers.
5607         * aarch64-linux-nat.c: Sort headers.
5608         * aarch64-fbsd-tdep.c: Sort headers.
5609         * aarch64-fbsd-nat.c: Sort headers.
5610         * aarch32-linux-nat.c: Sort headers.
5611
5612 2019-04-04  Tom Tromey  <tom@tromey.com>
5613
5614         * varobj.c (varobj_create): Update.
5615         * rust-exp.y (struct rust_parser) <update_innermost_block,
5616         lookup_symbol>: New methods.
5617         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5618         Rename.
5619         (rust_parser::rust_lookup_type)
5620         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5621         * printcmd.c (display_command, do_one_display): Update.
5622         * parser-defs.h (struct parser_state) <parser_state>: Add
5623         "tracker" parameter.
5624         (block_tracker): New member.
5625         (class innermost_block_tracker) <innermost_block_tracker>: Add
5626         "types" parameter.
5627         <reset>: Remove method.
5628         (innermost_block): Don't declare.
5629         (null_post_parser): Update.
5630         * parse.c (innermost_block): Remove global.
5631         (write_dollar_variable): Update.
5632         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5633         Remove "tracker_types" parameter.
5634         (parse_expression): Add "tracker" parameter.
5635         (parse_expression_for_completion): Update.
5636         (null_post_parser): Add "tracker" parameter.
5637         * p-exp.y: Update rules.
5638         * m2-exp.y: Update rules.
5639         * language.h (struct language_defn) <la_post_parser>: Add
5640         "tracker" parameter.
5641         * go-exp.y: Update rules.
5642         * f-exp.y: Update rules.
5643         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5644         parameter.
5645         * d-exp.y: Update rules.
5646         * c-exp.y: Update rules.
5647         * breakpoint.c (set_breakpoint_condition): Create an
5648         innermost_block_tracker.
5649         (watch_command_1): Likewise.
5650         * ada-lang.c (resolve): Add "tracker" parameter.
5651         (resolve_subexp): Likewise.
5652         * ada-exp.y (write_var_from_sym): Update.
5653
5654 2019-04-04  Tom Tromey  <tom@tromey.com>
5655
5656         * type-stack.h: New file.
5657         * type-stack.c: New file.
5658         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5659         type-stack.h.
5660         (insert_into_type_stack, insert_type, push_type, push_type_int)
5661         (insert_type_address_space, pop_type, pop_type_int)
5662         (pop_typelist, pop_type_stack, append_type_stack)
5663         (push_type_stack, get_type_stack, push_typelist)
5664         (follow_type_instance_flags, follow_types): Don't declare.
5665         * parse.c (type_stack): Remove global.
5666         (parse_exp_in_context): Update.
5667         (insert_into_type_stack, insert_type, push_type, push_type_int)
5668         (insert_type_address_space, pop_type, pop_type_int)
5669         (pop_typelist, pop_type_stack, append_type_stack)
5670         (push_type_stack, get_type_stack, push_typelist)
5671         (follow_type_instance_flags, follow_types): Remove (moved to
5672         type-stack.c).
5673         * f-exp.y (type_stack): New global.
5674         Update rules.
5675         (push_kind_type, f_parse): Update.
5676         * d-exp.y (type_stack): New global.
5677         Update rules.
5678         (d_parse): Update.
5679         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5680         Update rules.
5681         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5682         (HFILES_NO_SRCDIR): Add type-stack.h.
5683
5684 2019-04-04  Tom Tromey  <tom@tromey.com>
5685
5686         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5687         (rust_parser::convert_ast_to_expression, rust_parse)
5688         (rust_lex_test_completion, rust_lex_tests): Update.
5689         * parser-defs.h (struct expr_completion_state): New.
5690         (struct parser_state) <parser_state>: Add completion parameter.
5691         <mark_struct_expression, mark_completion_tag>: New methods.
5692         <parse_completion, m_completion_state>: New members.
5693         (prefixify_expression, null_post_parser): Update.
5694         (mark_struct_expression, mark_completion_tag): Don't declare.
5695         * parse.c (parse_completion, expout_last_struct)
5696         (expout_tag_completion_type, expout_completion_name): Remove
5697         globals.
5698         (parser_state::mark_struct_expression)
5699         (parser_state::mark_completion_tag): Now methods.
5700         (prefixify_expression): Add last_struct parameter.
5701         (prefixify_subexp): Likewise.
5702         (parse_exp_1): Update.
5703         (parse_exp_in_context): Add cstate parameter.  Update.
5704         (parse_expression_for_completion): Create an
5705         expr_completion_state.
5706         (null_post_parser): Add "completion" parameter.
5707         * p-exp.y: Update rules.
5708         (yylex): Update.
5709         * language.h (struct language_defn) <la_post_parser>: Add
5710         "completing" parameter.
5711         * go-exp.y: Update rules.
5712         (lex_one_token): Update.
5713         * expression.h (parse_completion): Don't declare.
5714         * d-exp.y: Update rules.
5715         (lex_one_token): Update rules.
5716         * c-exp.y: Update rules.
5717         (lex_one_token): Update.
5718         * ada-lang.c (resolve): Add "parse_completion" parameter.
5719         (resolve_subexp): Likewise.
5720         (ada_resolve_function): Likewise.
5721
5722 2019-04-04  Tom Tromey  <tom@tromey.com>
5723
5724         * parser-defs.h (struct parser_state) <start_arglist,
5725         end_arglist>: New methods.
5726         <arglist_len, m_funcall_chain>: New members.
5727         (arglist_len, start_arglist, end_arglist): Don't declare.
5728         * parse.c (arglist_len, funcall_chain): Remove global.
5729         (start_arglist, end_arglist): Remove functions.
5730         (parse_exp_in_context): Update.
5731         * p-exp.y: Update rules.
5732         * m2-exp.y: Update rules.
5733         * go-exp.y: Update rules.
5734         * f-exp.y: Update rules.
5735         * d-exp.y: Update rules.
5736         * c-exp.y: Update rules.
5737
5738 2019-04-04  Tom Tromey  <tom@tromey.com>
5739
5740         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5741         lex_operator, push_back>: New methods.
5742         Update all rules.
5743         (rust_parser::lex_hex, lex_escape): Rename and update.
5744         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5745         (rust_parser::lex_operator): Rename and update.
5746         (rust_parser::lex_number, rustyylex, rustyyerror)
5747         (rust_lex_test_init, rust_lex_test_sequence)
5748         (rust_lex_test_push_back, rust_lex_tests): Update.
5749         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5750         parameter.
5751         <lexptr, prev_lexptr>: New members.
5752         (lexptr, prev_lexptr): Don't declare.
5753         * parse.c (lexptr, prev_lexptr): Remove globals.
5754         (parse_exp_in_context): Update.
5755         * p-exp.y (yylex, yyerror): Update.
5756         * m2-exp.y (parse_number, yylex, yyerror): Update.
5757         * go-exp.y (lex_one_token, yyerror): Update.
5758         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5759         * d-exp.y (lex_one_token, yyerror): Update.
5760         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5761         (lex_one_token, yyerror): Update.
5762         * ada-lex.l (YY_INPUT): Update.
5763         (rewind_to_char): Update.
5764         * ada-exp.y (yyerror): Update.
5765
5766 2019-04-04  Tom Tromey  <tom@tromey.com>
5767
5768         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5769         * parser-defs.h (struct parser_state) <parser_state>: Add new
5770         parameter.
5771         <comma_terminates>: New member.
5772         (comma_terminates): Don't declare global.
5773         * parse.c (comma_terminates): Remove global.
5774         (parse_exp_in_context): Update.
5775         * p-exp.y (yylex): Update.
5776         * m2-exp.y (yylex): Update.
5777         * go-exp.y (lex_one_token): Update.
5778         * f-exp.y (yylex): Update.
5779         * d-exp.y (lex_one_token): Update.
5780         * c-exp.y (lex_one_token): Update.
5781         * ada-lex.l: Update.
5782
5783 2019-04-04  Tom Tromey  <tom@tromey.com>
5784
5785         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5786         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5787         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5788         * parser-defs.h (paren_depth): Don't declare.
5789         * parse.c (paren_depth): Remove global.
5790         (parse_exp_in_context): Update.
5791         * p-exp.y (paren_depth): New global.
5792         (pascal_parse): Initialize it.
5793         * m2-exp.y (paren_depth): New global.
5794         (m2_parse): Initialize it.
5795         * go-exp.y (paren_depth): New global.
5796         (go_parse): Initialize it.
5797         * f-exp.y (paren_depth): New global.
5798         (f_parse): Initialize it.
5799         * d-exp.y (paren_depth): New global.
5800         (d_parse): Initialize it.
5801         * c-exp.y (paren_depth): New global.
5802         (c_parse): Initialize it.
5803         * ada-lex.l (paren_depth): New global.
5804         (lexer_init): Initialize it.
5805
5806 2019-04-04  Tom Tromey  <tom@tromey.com>
5807
5808         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5809         (rust_parser::convert_ast_to_type)
5810         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5811         * parser-defs.h (struct parser_state) <parser_state>: Add
5812         parameters.  Initialize new members.
5813         <expression_context_block, expression_context_pc>: New members.
5814         * parse.c (expression_context_block, expression_context_pc):
5815         Remove globals.
5816         (parse_exp_in_context): Update.
5817         * p-exp.y: Update all rules.
5818         (yylex): Update.
5819         * m2-exp.y: Update all rules.
5820         (yylex): Update.
5821         * go-exp.y (yylex): Update.
5822         * f-exp.y (yylex): Update.
5823         * d-exp.y: Update all rules.
5824         (yylex): Update.
5825         * c-exp.y: Update all rules.
5826         (lex_one_token, classify_name, yylex, c_parse): Update.
5827         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5828
5829 2019-04-04  Tom Tromey  <tom@tromey.com>
5830
5831         * gdbarch.h, gdbarch.c: Rebuild.
5832         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5833         * stap-probe.h:
5834         (struct stap_parse_info): Replace "parser_state" with
5835         "expr_builder".
5836         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5837         (parser_state): New class.
5838         * parse.c (expr_builder): Rename.
5839         (expr_builder::release): Rename.
5840         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5841         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5842         (write_exp_elt_longcst, write_exp_elt_floatcst)
5843         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5844         (write_exp_string_vector, write_exp_bitstring)
5845         (write_exp_msymbol, mark_struct_expression)
5846         (write_dollar_variable)
5847         (insert_type_address_space, increase_expout_size): Replace
5848         "parser_state" with "expr_builder".
5849         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5850         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5851         "parser_state" with "expr_builder".
5852
5853 2019-04-04  Tom Tromey  <tom@tromey.com>
5854
5855         * rust-exp.y: Replace "parse_language" with method call.
5856         * p-exp.y:
5857         (yylex): Replace "parse_language" with method call.
5858         * m2-exp.y:
5859         (yylex): Replace "parse_language" with method call.
5860         * go-exp.y (classify_name): Replace "parse_language" with method
5861         call.
5862         * f-exp.y (yylex): Replace "parse_language" with method call.
5863         * d-exp.y (lex_one_token): Replace "parse_language" with method
5864         call.
5865         * c-exp.y:
5866         (lex_one_token, classify_name, yylex): Replace "parse_language"
5867         with method call.
5868         * ada-exp.y (find_primitive_type, type_char)
5869         (type_system_address): Replace "parse_language" with method call.
5870
5871 2019-04-04  Tom Tromey  <tom@tromey.com>
5872
5873         * rust-exp.y: Replace "parse_gdbarch" with method call.
5874         * parse.c (write_dollar_variable, insert_type_address_space):
5875         Replace "parse_gdbarch" with method call.
5876         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5877         call.
5878         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5879         call.
5880         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5881         "parse_gdbarch" with method call.
5882         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5883         with method call.
5884         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5885         "parse_gdbarch" with method call.
5886         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5887         "parse_gdbarch" with method call.
5888         * c-exp.y (parse_type, parse_number, classify_name): Replace
5889         "parse_gdbarch" with method call.
5890         * ada-lex.l: Replace "parse_gdbarch" with method call.
5891         * ada-exp.y (parse_type, find_primitive_type, type_char)
5892         (type_system_address): Replace "parse_gdbarch" with method call.
5893
5894 2019-04-04  Tom Tromey  <tom@tromey.com>
5895
5896         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5897         * stap-probe.c (stap_parse_argument): Update.
5898         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5899         initial_size parameter.
5900         * rust-exp.y (rust_lex_tests): Update.
5901         * parse.c (parser_state): Update.
5902         (parse_exp_in_context): Update.
5903         * parser-defs.h (struct parser_state) <parser_state>: Remove
5904         "initial_size" parameter.
5905
5906 2019-04-04  Tom Tromey  <tom@tromey.com>
5907
5908         * parser-defs.h (increase_expout_size): Don't declare.
5909         * parse.c (increase_expout_size): Now static.
5910
5911 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5912
5913         * gnu-nat.c (gnu_nat_target::wait): Fix
5914         target_waitstatus_to_string call.
5915
5916 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5917
5918         * eval.c (evaluate_subexp_standard): Handle internal functions
5919         during Fortran function call handling.
5920
5921 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5922
5923         * NEWS: Mention new internal functions.
5924         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5925         (read_base_type): Use dwarf2_init_complex_target_type.
5926         * value.c (creal_internal_fn): New function.
5927         (cimag_internal_fn): New function.
5928         (_initialize_values): Register new internal functions.
5929
5930 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5931
5932         * infrun.c (stop_all_threads): If debug_infrun, always
5933         trace the wait status after wait_one, using
5934         target_waitstatus_to_string and target_pid_to_str.
5935         (handle_inferior_event): Replace various trace of
5936         wait status kind by a single trace.
5937         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5938         wait status kind image by target_waitstatus_to_string.
5939         * target/waitstatus.c (target_waitstatus_to_string): Fix
5940         obsolete comment.
5941
5942 2019-04-01  Tom Tromey  <tromey@adacore.com>
5943
5944         PR symtab/23331:
5945         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5946
5947 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5948             Pedro Alves  <palves@redhat.com>
5949
5950         * top.c (quit_force): Call 'finalize_values'.
5951         * value.c (finalize_values): New function.
5952         * value.h (finalize_values): Declare.
5953
5954 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5955
5956         * NEWS: Announce $_gdb_major and $_gdb_minor.
5957
5958         * top.c (init_gdb_version_vars): New function.
5959         (gdb_init): Call init_gdb_version_vars.
5960
5961 2019-03-29  Tom Tromey  <tromey@adacore.com>
5962
5963         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5964         help text.  Remove dead code.
5965
5966 2019-03-29  Keith Seitz  <keiths@redhat.com>
5967
5968         From Siddhesh Poyarekar:
5969         * f-lang.h (f77_get_upperbound): Return LONGEST.
5970         (f77_get_lowerbound): Likewise.
5971         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5972         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5973         print them.
5974         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5975         plongest to format print it.
5976         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5977         (f77_get_upperbound): Likewise.
5978         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5979         LOWER_BOUND to LONGEST.
5980         (f77_create_arrayprint_offset_tbl): Likewise.
5981
5982 2019-03-29  Keith Seitz  <keiths@redhat.com>
5983
5984         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5985         %s/pulongest for TYPE_LENGTH instead of %d in format
5986         strings.
5987         * ada-typerint.c (ada_print_type): Likewise.
5988         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5989         * compile/compile-c-support.c (generate_register_struct): Likewise.
5990         * gdbtypes.c (recursive_dump_type): Likewise.
5991         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5992         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5993         instead of %d in format strings.
5994         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5995         to std::min to ULONGEST.
5996         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5997         instead of %d in format strings.
5998         * tracepoint.c (info_scope_command): Likewise.
5999         * typeprint.c (print_offset_data::update)
6000         (print_offset_data::finish): Likewise.
6001         * xtensa-tdep.c (xtensa_store_return_value)
6002         (xtensa_push_dummy_call): Likewise.
6003
6004 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6005
6006         * windows-nat.c (display_selector): Fixed format specifications
6007         for 64-bit Cygwin.
6008
6009 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6010
6011         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6012
6013 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6014
6015         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6016         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6017         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6018         (nios2_linux_init_abi): Install it.
6019
6020 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6021
6022         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6023
6024 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6025
6026         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6027
6028 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6029             Tom Tromey  <tromey@adacore.com>
6030
6031         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6032
6033 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6034
6035         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6036         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6037         method to compute the bounds of range types. Also print "[evaluated]"
6038         if the bounds' values come from a dynamic evaluation.
6039
6040 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6041
6042         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6043         whitespace when pretty printing is on.
6044
6045 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6046
6047         * ppc-linux-nat.c: Add include.
6048
6049 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6050
6051         * NEWS: Mention AArch64 Pointer Authentication.
6052
6053 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6054
6055         * arm-linux-nat.c: Add include.
6056
6057 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6058
6059         * source-cache.c (source_cache::get_source_lines): Re-read
6060         fullname after calling open_source_file.
6061
6062 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6063
6064         * NEWS: Mention TLS support for FreeBSD.
6065
6066 2019-03-25  Tom Tromey  <tromey@adacore.com>
6067
6068         * minsyms.c (BUNCH_SIZE): Update comment.
6069         (~minimal_symbol_reader): Remove old comment.
6070         (compact_minimal_symbols): Update comment.
6071         (minimal_symbol_reader::install): Remove old comment.  Update
6072         other comments.
6073
6074 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6075
6076         * s390-linux-nat.c: Add include.
6077
6078 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6079
6080         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6081         Call linux_get_hwcap.
6082         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6083         Likewise.
6084         (aarch64_linux_get_hwcap): Remove function.
6085         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6086         declaration.
6087         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6088         linux_get_hwcap.
6089         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6090         * linux-tdep.c (linux_get_hwcap): Add function.
6091         (linux_get_hwcap2): Likewise.
6092         * linux-tdep.h (linux_get_hwcap): Add declaration.
6093         (linux_get_hwcap2): Likewise.
6094         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6095         (ppc_linux_get_hwcap2): Likewise.
6096         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6097         linux_get_hwcap.
6098         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6099         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6100         (ppc_linux_nat_target::read_description): Likewise.
6101         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6102         * s390-linux-nat.c: Likewise.
6103         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6104
6105 2019-03-24  Tom Tromey  <tom@tromey.com>
6106
6107         * ada-lang.c (standard_lookup): Simplify initialization.
6108         (ada_lookup_symbol_nonlocal): Simplify return.
6109         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6110         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6111         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6112         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6113         initialization.
6114         * solib.c (solib_global_lookup): Simplify.
6115         * symtab.c (null_block_symbol): Remove.
6116         (symbol_cache_lookup): Simplify returns.
6117         (lookup_language_this): Simplify returns.
6118         (lookup_symbol_aux): Simplify return.
6119         (lookup_local_symbol): Simplify returns.
6120         (lookup_global_symbol_from_objfile): Simplify return.
6121         (lookup_symbol_in_objfile_symtabs)
6122         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6123         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6124         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6125         * cp-namespace.c (cp_lookup_bare_symbol)
6126         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6127         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6128         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6129         (cp_lookup_symbol_via_imports): Simplify initialization.
6130         (find_symbol_in_baseclass): Likewise.
6131         * symtab.h (null_block_symbol): Remove.
6132         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6133         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6134         (d_lookup_symbol_module): Likewise.
6135         (find_symbol_in_baseclass): Simplify initialization.
6136
6137 2019-03-24  Tom Tromey  <tom@tromey.com>
6138
6139         * expression.h: Don't include symtab.h.
6140         (struct block): Forward declare.
6141
6142 2019-03-24  Tom Tromey  <tom@tromey.com>
6143
6144         * c-exp.y (typebase): Remove casts.
6145         * gdbtypes.c (lookup_unsigned_typename, )
6146         (lookup_signed_typename): Remove cast.
6147         * eval.c (parse_to_comma_and_eval): Remove cast.
6148         * parse.c (write_dollar_variable): Remove cast.
6149         * block.h (struct block) <superblock>: Now const.
6150         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6151         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6152         (map_block): Make "block" const.
6153         * symfile.h (struct quick_symbol_functions)
6154         <map_matching_symbols>: Constify block argument to "callback".
6155         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6156         const.
6157         (find_pc_sect_compunit_symtab): Make "b" const.
6158         (find_symbol_at_address): Likewise.
6159         (search_symbols): Likewise.
6160         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6161         (dw2_debug_names_lookup_symbol): Likewise.
6162         (dw2_map_matching_symbols): Update.
6163         * p-valprint.c (pascal_val_print): Remove "block".
6164         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6165         (aux_add_nonlocal_symbols): Make "block" const.
6166         (resolve_subexp): Remove cast.
6167         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6168         const.
6169         (iterate_over_file_blocks): Likewise.
6170         * f-exp.y (%union) <bval>: Remove.
6171         * coffread.c (patch_opaque_types): Make "b" const.
6172         * spu-tdep.c (spu_catch_start): Make "block" const.
6173         * c-valprint.c (print_unpacked_pointer): Remove "block".
6174         * symmisc.c (dump_symtab_1): Make "b" const.
6175         (block_depth): Make "block" const.
6176         * d-exp.y (%union) <bval>: Remove.
6177         * cp-support.h (cp_lookup_rtti_type): Update.
6178         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6179         * psymtab.c (psym_lookup_symbol): Make "block" const.
6180         (maintenance_check_psymtabs): Make "b" const.
6181         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6182         (enumerate_locals, enumerate_args): Update.
6183         * python/py-symtab.c (stpy_global_block): Make "block" const.
6184         (stpy_static_block): Likewise.
6185         * inline-frame.c (block_starting_point_at): Make "new_block"
6186         const.
6187         * block.c (find_block_in_blockvector): Make return type const.
6188         (blockvector_for_pc_sect): Make "b" const.
6189         (find_block_in_blockvector): Make "b" const.
6190
6191 2019-03-23  Tom Tromey  <tom@tromey.com>
6192
6193         * varobj.c (varobj_create): Update.
6194         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6195         * printcmd.c (display_command, do_one_display): Don't reset
6196         innermost_block.
6197         * parser-defs.h (enum innermost_block_tracker_type): Move to
6198         expression.h.
6199         (innermost_block): Update comment.
6200         * parse.c (parse_exp_1): Add tracker_types parameter.
6201         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6202         tracker_types parameter.  Reset innermost_block.
6203         (parse_exp_in_context): Remove.
6204         (parse_expression_for_completion): Update.
6205         * objfiles.c (~objfile): Don't reset expression_context_block or
6206         innermost_block.
6207         * expression.h (enum innermost_block_tracker_type): Move from
6208         parser-defs.h.
6209         (parse_exp_1): Add tracker_types parameter.
6210         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6211         reset innermost_block.
6212
6213 2019-03-23  Tom Tromey  <tom@tromey.com>
6214
6215         * objfiles.h: Include bcache.h.
6216
6217 2019-03-23  Tom Tromey  <tom@tromey.com>
6218
6219         * linespec.c (get_current_search_block): Use
6220         scoped_restore_current_language.
6221         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6222
6223 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6224             Jiong Wang  <jiong.wang@arm.com>
6225
6226         * aarch64-linux-tdep.c
6227         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6228         section.
6229         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6230
6231 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6232             Jiong Wang  <jiong.wang@arm.com>
6233
6234         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6235         instructions.
6236         (aarch64_analyze_prologue_test): Add PACIASP test.
6237         (aarch64_prologue_prev_register): Unmask PC value.
6238
6239 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6240             Jiong Wang  <jiong.wang@arm.com>
6241
6242         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6243         (aarch64_dwarf2_prev_register): Unmask PC value.
6244         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6245         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6246         DW_CFA_AARCH64_negate_ra_state.
6247         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6248
6249 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6250             Jiong Wang  <jiong.wang@arm.com>
6251
6252         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6253         registers.
6254         (aarch64_pseudo_register_name): Likewise.
6255         (aarch64_pseudo_register_type): Likewise.
6256         (aarch64_pseudo_register_reggroup_p): Likewise.
6257         (aarch64_gdbarch_init): Add pauth registers.
6258         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6259         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6260         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6261         (struct gdbarch_tdep): Add regnum for ra_state.
6262
6263 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6264             Jiong Wang  <jiong.wang@arm.com>
6265
6266         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6267
6268 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6269             Jiong Wang  <jiong.wang@arm.com>
6270
6271         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6272         function.
6273         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6274         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6275         (aarch64_gdbarch_init): Add puth registers.
6276         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6277         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6278         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6279
6280 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6281             Jiong Wang  <jiong.wang@arm.com>
6282
6283         * aarch64-linux-nat.c
6284         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6285         * aarch64-linux-tdep.c
6286         (aarch64_linux_core_read_description): Likewise.
6287         (aarch64_linux_get_hwcap): New function.
6288         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6289         (aarch64_linux_get_hwcap): New declaration.
6290
6291 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6292             Jiong Wang  <jiong.wang@arm.com>
6293
6294         * aarch64-linux-nat.c
6295         (aarch64_linux_nat_target::read_description): Add pauth param.
6296         * aarch64-linux-tdep.c
6297         (aarch64_linux_core_read_description): Likewise.
6298         * aarch64-tdep.c (struct target_desc): Add in pauth.
6299         (aarch64_read_description): Add pauth param.
6300         (aarch64_gdbarch_init): Likewise.
6301         * aarch64-tdep.h (aarch64_read_description): Likewise.
6302         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6303         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6304         * features/Makefile: Add new files.
6305         * features/aarch64-pauth.c: New file.
6306         * features/aarch64-pauth.xml: New file.
6307
6308 2019-03-20  Tom Tromey  <tromey@adacore.com>
6309
6310         * infrun.c (handle_inferior_event): Rename from
6311         handle_inferior_event_1.  Create a scoped_value_mark.
6312         (handle_inferior_event): Remove.
6313
6314 2019-03-19  Tom Tromey  <tromey@adacore.com>
6315
6316         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6317         * infrun.h (print_stop_event): Add "displays" parameter.
6318         * infrun.c (print_stop_event): Add "displays" parameter.
6319
6320 2019-03-19  Pedro Alves  <palves@redhat.com>
6321
6322         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6323         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6324         to -1.  Fix TABs vs spaces.
6325         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6326         * tui/tui-out.h (tui_ui_out) Add intro comments.
6327         <m_line, m_start_of_line>: In-class initialize, and add describing
6328         comment.
6329
6330 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6331
6332         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6333         variable names.
6334         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6335
6336 2019-03-18  Pedro Alves  <palves@redhat.com>
6337             Eli Zaretskii <eliz@gnu.org>
6338
6339         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6340         m_line and m_start_of_line.
6341
6342 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6343
6344         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6345         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6346         it returns a newline.  This fixes a regression in TU mode, whereby
6347         the next line is output on the same screen line as the user input.
6348
6349 2019-03-18  Tom Tromey  <tromey@adacore.com>
6350
6351         * minsyms.c (minimal_symbol_reader::install): Remove call to
6352         obstack_blank.
6353
6354 2019-03-18  Pedro Alves  <palves@redhat.com>
6355
6356         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6357         New globals.
6358         (apply_style): New, factored out from ...
6359         (apply_ansi_escape): ... this.  Handle reverse video mode.
6360         (tui_set_reverse_mode): New function.
6361         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6362         * tui/tui-winsource.c (tui_show_source_line): Use
6363         tui_set_reverse_mode instead of setting A_STANDOUT.
6364         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6365         New setter methods.
6366
6367 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6368
6369         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6370         Handle tabs.
6371
6372 2019-03-18  Tom Tromey  <tromey@adacore.com>
6373
6374         * ada-lang.c (empty_array): Add "high" parameter.
6375         (ada_evaluate_subexp): Update.
6376
6377 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6378
6379         * unittests/string_view-selftests.c: Define
6380         _initialize_string_view_selftests unconditionally.
6381
6382 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6383
6384         PR gdb/24350
6385         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6386
6387 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6388
6389         PR gdb/24351
6390         * windows-nat.c (display_selector): Fix format specifiers.
6391
6392 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6393
6394         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6395         tui_refill_source_window instead of tui_refresh_win, to update the
6396         current execution line.  This fixes redisplay of the current line
6397         when stepping through the code with "next" or "step".
6398
6399 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6400
6401         * source-cache.c (source_cache::get_source_lines): Call
6402         find_source_lines to initialize s->nlines.  This fixes vertical
6403         scrolling of TUI source window when the DOWN arrow is pressed.
6404
6405 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6406
6407         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6408         linux-thread-db.c (_initialize_thread_db): Likewise.
6409
6410 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6411
6412         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6413         wclrtoeol in tui_show_source_line".  This reverts changes made in
6414         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6415
6416 2019-03-15  Tom Tromey  <tom@tromey.com>
6417
6418         * symtab.h (struct minimal_symbol): Derive from
6419         general_symbol_info.
6420         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6421         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6422         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6423         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6424         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6425         (MSYMBOL_SEARCH_NAME): Update.
6426         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6427         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6428         * minsyms.c (minimal_symbol_reader::record_full): Update.
6429
6430 2019-03-15  Tom Tromey  <tom@tromey.com>
6431
6432         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6433
6434 2019-03-15  Tom Tromey  <tom@tromey.com>
6435
6436         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6437         unique_xmalloc_ptr.
6438         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6439         Update.
6440         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6441         (build_minimal_symbol_hash_tables)
6442         (minimal_symbol_reader::install): Update.
6443
6444 2019-03-15  Tom Tromey  <tom@tromey.com>
6445
6446         * symtab.c (create_demangled_names_hash): Update.
6447         (symbol_set_names): Update.
6448         * objfiles.h (struct objfile_per_bfd_storage)
6449         <demangled_names_hash>: Now an htab_up.
6450         * objfiles.c (objfile_per_bfd_storage): Simplify.
6451
6452 2019-03-15  Tom Tromey  <tom@tromey.com>
6453
6454         * objfiles.h (struct objfile_per_bfd_storage): Declare
6455         destructor.
6456         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6457         New.
6458         (get_objfile_bfd_data): Use new.  Don't initialize
6459         language_of_main.
6460         (free_objfile_per_bfd_storage): Remove.
6461         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6462
6463 2019-03-15  Tom Tromey  <tom@tromey.com>
6464
6465         * symfile.c (reread_symbols): Update.
6466         * objfiles.c (objfile::objfile): Update.
6467         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6468         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6469         comment.
6470         (minimal_symbol_reader::install): Update.
6471         (terminate_minimal_symbol_table): Remove.
6472         * jit.c (jit_object_close_impl): Update.
6473
6474 2019-03-15  Tom Tromey  <tom@tromey.com>
6475
6476         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6477         initializations.
6478
6479 2019-03-15  Tom Tromey  <tom@tromey.com>
6480
6481         * objfiles.h (struct objfile_per_bfd_storage)
6482         <demangled_hash_languages>: Now a bitset.
6483         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6484         (lookup_minimal_symbol): Update.
6485
6486 2019-03-15  Tom Tromey  <tom@tromey.com>
6487
6488         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6489         Don't return the symbol.
6490         * coffread.c (record_minimal_symbol): Use record_full.
6491
6492 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6493
6494         The MS-Windows port of ncurses fails to switch to a color pair if
6495         one or both of the colors are the implicit default colors.  This
6496         change records the default colors when TUI is initialized, and
6497         then specifies them explicitly when a color pair uses the default
6498         colors.  This allows color styling in TUI mode on MS-Windows.
6499
6500         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6501         ncurses_norm_attr.
6502         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6503         colors in ncurses_norm_attr.
6504         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6505         "none", replace it with the default color recorded in
6506         ncurses_norm_attr.
6507
6508 2019-03-14  Tom Tromey  <tromey@adacore.com>
6509
6510         * source-cache.h (class source_cache) <get_source_lines>: Return
6511         std::string.
6512         * source-cache.c (source_cache::extract_lines): Handle case where
6513         first_pos==npos.  Return std::string.
6514         (source_cache::get_source_lines): Update.
6515
6516 2019-03-14  Tom Tromey  <tromey@adacore.com>
6517
6518         * NEWS: Add item for "style sources" commands.
6519         * source-cache.c (source_cache::get_source_lines): Check
6520         source_styling.
6521         * cli/cli-style.c (source_styling): New global.
6522         (_initialize_cli_style): Add "style sources" commands.
6523         (show_style_sources): New function.
6524         * cli/cli-style.h (source_styling): Declare.
6525
6526 2019-03-14  Pedro Alves  <palves@redhat.com>
6527             Tom Tromey  <tromey@adacore.com>
6528
6529         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6530         * tui/tui-winsource.c (tui_refill_source_window): New function,
6531         from...
6532         (tui_horizontal_source_scroll): ... here.  Move some logic.
6533         * cli/cli-style.c (set_style_enabled): Notify new observable.
6534         * tui/tui-hooks.c (tui_redisplay_source): New function.
6535         (tui_attach_detach_observers): Attach or detach
6536         tui_redisplay_source.
6537         * observable.h (source_styling_changed): New observable.
6538         * observable.c: Define source_styling_changed observable.
6539
6540 2019-03-13  Tom Tromey  <tromey@adacore.com>
6541
6542         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6543         (i386_gnu_nat_target::store_registers): Update.
6544         * target-debug.h (target_debug_print_std_string): New macro.
6545         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6546         * windows-tdep.c (display_one_tib): Update.
6547         * tui/tui-stack.c (tui_make_status_line): Update.
6548         * top.c (print_inferior_quit_action): Update.
6549         * thread.c (thr_try_catch_cmd): Update.
6550         (add_thread_with_info): Update.
6551         (thread_target_id_str): Update.
6552         (thr_try_catch_cmd): Update.
6553         (thread_command): Update.
6554         (thread_find_command): Update.
6555         * record-btrace.c (record_btrace_target::info_record)
6556         (record_btrace_resume_thread, record_btrace_target::resume)
6557         (record_btrace_cancel_resume, record_btrace_step_thread)
6558         (record_btrace_target::wait, record_btrace_target::wait)
6559         (record_btrace_target::wait, record_btrace_target::stop): Update.
6560         * progspace.c (print_program_space): Update.
6561         * process-stratum-target.c
6562         (process_stratum_target::thread_address_space): Update.
6563         * linux-fork.c (linux_fork_mourn_inferior)
6564         (detach_checkpoint_command, info_checkpoints_command)
6565         (linux_fork_context): Update.
6566         (linux_fork_detach): Update.
6567         (class scoped_switch_fork_info): Update.
6568         (delete_checkpoint_command): Update.
6569         * infrun.c (follow_fork_inferior): Update.
6570         (follow_fork_inferior): Update.
6571         (proceed_after_vfork_done): Update.
6572         (handle_vfork_child_exec_or_exit): Update.
6573         (follow_exec): Update.
6574         (displaced_step_prepare_throw): Update.
6575         (displaced_step_restore): Update.
6576         (start_step_over): Update.
6577         (resume_1): Update.
6578         (clear_proceed_status_thread): Update.
6579         (proceed): Update.
6580         (print_target_wait_results): Update.
6581         (do_target_wait): Update.
6582         (context_switch): Update.
6583         (stop_all_threads): Update.
6584         (restart_threads): Update.
6585         (finish_step_over): Update.
6586         (handle_signal_stop): Update.
6587         (switch_back_to_stepped_thread): Update.
6588         (keep_going_pass_signal): Update.
6589         (print_exited_reason): Update.
6590         (normal_stop): Update.
6591         * inferior.c (inferior_pid_to_str): Change return type.
6592         (print_selected_inferior): Update.
6593         (add_inferior): Update.
6594         (detach_inferior): Update.
6595         * dummy-frame.c (fprint_dummy_frames): Update.
6596         * dcache.c (dcache_info_1): Update.
6597         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6598         (btrace_fetch, btrace_clear): Update.
6599         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6600         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6601         type.
6602         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6603         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6604         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6605         * gdbarch.c, gdbarch.h: Rebuild.
6606         * gdbarch.sh (core_pid_to_str): Change return type.
6607         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6608         return type.
6609         (windows_nat_target::pid_to_str): Change return type.
6610         (windows_delete_thread): Update.
6611         (windows_nat_target::attach): Update.
6612         (windows_nat_target::files_info): Update.
6613         * target-delegates.c: Rebuild.
6614         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6615         return type.
6616         (sol_thread_target::pid_to_str): Change return type.
6617         * remote.c (class remote_target) <pid_to_str>: Change return
6618         type.
6619         (remote_target::pid_to_str): Change return type.
6620         (extended_remote_target::attach, remote_target::remote_stop_ns)
6621         (remote_target::remote_notif_remove_queued_reply)
6622         (remote_target::push_stop_reply, remote_target::disable_btrace):
6623         Update.
6624         (extended_remote_target::attach): Update.
6625         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6626         type.
6627         (gdbsim_target::pid_to_str): Change return type.
6628         * ravenscar-thread.c (struct ravenscar_thread_target)
6629         <pid_to_str>: Change return type.
6630         (ravenscar_thread_target::pid_to_str): Change return type.
6631         * procfs.c (class procfs_target) <pid_to_str>: Change return
6632         type.
6633         (procfs_target::pid_to_str): Change return type.
6634         (procfs_target::attach): Update.
6635         (procfs_target::detach): Update.
6636         (procfs_target::fetch_registers): Update.
6637         (procfs_target::store_registers): Update.
6638         (procfs_target::wait): Update.
6639         (procfs_target::files_info): Update.
6640         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6641         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6642         return type.
6643         (nto_procfs_target::pid_to_str): Change return type.
6644         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6645         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6646         return type.
6647         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6648         (exit_lwp): Update.
6649         (attach_proc_task_lwp_callback, get_detach_signal)
6650         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6651         (linux_nat_target::resume, wait_lwp, stop_callback)
6652         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6653         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6654         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6655         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6656         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6657         type.
6658         (inf_ptrace_target::attach): Update.
6659         (inf_ptrace_target::files_info): Update.
6660         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6661         type.
6662         (go32_nat_target::pid_to_str): Change return type.
6663         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6664         (gnu_nat_target::wait): Update.
6665         (gnu_nat_target::wait): Update.
6666         (gnu_nat_target::resume): Update.
6667         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6668         (fbsd_nat_target::wait): Update.
6669         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6670         type.
6671         (darwin_nat_target::attach): Update.
6672         * corelow.c (class core_target) <pid_to_str>: Change return type.
6673         (core_target::pid_to_str): Change return type.
6674         * target.c (normal_pid_to_str): Change return type.
6675         (default_pid_to_str): Likewise.
6676         (target_pid_to_str): Change return type.
6677         (target_translate_tls_address): Update.
6678         (target_announce_detach): Update.
6679         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6680         return type.
6681         (bsd_uthread_target::pid_to_str): Change return type.
6682         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6683         type.
6684         (bsd_kvm_target::pid_to_str): Change return type.
6685         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6686         return type.
6687         (aix_thread_target::pid_to_str): Change return type.
6688         * target.h (struct target_ops) <pid_to_str>: Change return type.
6689         (target_pid_to_str, normal_pid_to_str): Likewise.
6690         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6691         type.
6692         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6693         type.
6694         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6695         return type.
6696         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6697         type.
6698         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6699         type.
6700         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6701         return type.
6702
6703 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6704
6705         * NEWS: Mention that the new default MI version is 3.  Mention
6706         changes to the output of commands and events that deal with
6707         multi-location breakpoints.
6708         * breakpoint.c: Include "mi/mi-out.h".
6709         (print_one_breakpoint): Change output syntax if using MI version
6710         >= 3.
6711         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6712         New.
6713         (mi_multi_location_breakpoint_output_fixed): New.
6714         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6715         (mi_cmd_fix_multi_location_breakpoint_output): New.
6716         (mi_multi_location_breakpoint_output_fixed): New.
6717         * mi/mi-cmds.c (mi_cmds): Register command
6718         -fix-multi-location-breakpoint-output.
6719         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6720         interpreter "mi".
6721
6722 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6723
6724         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6725         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6726         instantiate mi_ui_out based on interpreter name.
6727         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6728         * mi/mi-main.c (mi_load_progress): Likewise.
6729
6730 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6731
6732         * NEWS: Combine separate "New targets" sections for 8.3.
6733
6734 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6735
6736         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6737         (ppcfbsd_init_abi): Install gdbarch
6738         "fetch_tls_load_module_address" and "get_thread_local_address"
6739         methods.
6740
6741 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6742
6743         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6744         (riscv_fbsd_init_abi): Install gdbarch
6745         "fetch_tls_load_module_address" and "get_thread_local_address"
6746         methods.
6747
6748 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6749
6750         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6751         (i386fbsd_init_abi): Install gdbarch
6752         "fetch_tls_load_module_address" and "get_thread_local_address"
6753         methods.
6754
6755 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6756
6757         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6758         (amd64fbsd_init_abi): Install gdbarch
6759         "fetch_tls_load_module_address" and "get_thread_local_address"
6760         methods.
6761
6762 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6763
6764         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6765         (struct fbsd_pspace_data): New type.
6766         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6767         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6768         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6769         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6770         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6771
6772 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6773
6774         * gdbtypes.c (lookup_struct_elt): New function.
6775         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6776         * gdbtypes.h (struct struct_elt): New type.
6777         (lookup_struct_elt): New prototype.
6778
6779 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6780
6781         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6782         remove disabled code block.
6783
6784 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6785
6786         * gdbarch.sh (get_thread_local_address): New method.
6787         * gdbarch.h, gdbarch.c: Regenerate.
6788         * target.c (target_translate_tls_address): Use
6789         gdbarch_get_thread_local_address if present instead of
6790         target::get_thread_local_address.
6791
6792 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6793
6794         * target.h (target::get_thread_local_address): Update comment.
6795
6796 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6797
6798         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6799         objfile->separate_debug_objfile_backlink if not NULL.
6800
6801 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6802
6803         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6804         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6805         (amd64bsd_store_inferior_registers): Likewise.
6806         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6807         Enable segment base registers.
6808         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6809         PT_GETFSBASE and PT_GETGSBASE.
6810         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6811         PT_SETGSBASE.
6812         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6813         segment base registers.
6814         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6815
6816 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6817
6818         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6819         Update calls to i386_target_description to add 'segments'
6820         parameter.
6821         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6822         add segment base registers.
6823         * arch/i386.c (i386_create_target_description): Add 'segments'
6824         parameter to enable segment base registers.
6825         * arch/i386.h (i386_create_target_description): Likewise.
6826         * features/i386/32bit-segments.xml: New file.
6827         * features/i386/32bit-segments.c: Generate.
6828         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6829         call to i386_target_description to add 'segments' parameter.
6830         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6831         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6832         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6833         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6834         if feature is present.
6835         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6836         Add 'segments' parameter to call to i386_target_description.
6837         (i386_target_description): Add 'segments' parameter to enable
6838         segment base registers.
6839         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6840         to call to i386_target_description.
6841         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6842         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6843         Define I386_NUM_REGS.
6844         (i386_target_description): Add 'segments' parameter to enable
6845         segment base registers.
6846
6847 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6848
6849         PR/24325
6850         * source-cache.c: #undef open and close, to avoid unresolved
6851         externals during linking.
6852
6853 2019-03-12  Tom Tromey  <tromey@adacore.com>
6854
6855         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6856         const.  Add initializers.
6857         (_initialize_remote): Don't initialize ptid globals.
6858
6859 2019-03-12  Pedro Alves  <palves@redhat.com>
6860
6861         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6862
6863 2019-03-12  Pedro Alves  <palves@redhat.com>
6864
6865         * cp-name-parser.y (main): Remove unused 'len' variable.
6866
6867 2019-03-12  Tom Tromey  <tromey@adacore.com>
6868
6869         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6870         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6871
6872 2019-03-12  Tom Tromey  <tromey@adacore.com>
6873
6874         * linux-nat.c (iterate_over_lwps): Update.
6875         (stop_callback): Remove parameter.
6876         (stop_wait_callback, detach_callback, resume_set_callback)
6877         (select_singlestep_lwp_callback, set_ignore_sigint)
6878         (status_callback, resumed_callback, resume_clear_callback)
6879         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6880         data parameter.
6881         (linux_nat_target::detach, linux_nat_target::resume)
6882         (linux_stop_and_wait_all_lwps, select_event_lwp)
6883         (linux_nat_filter_event, linux_nat_wait_1)
6884         (linux_nat_target::kill, linux_nat_target::stop)
6885         (linux_nat_target::stop): Update.
6886         (linux_nat_resume_callback): Change type.
6887         (resume_stopped_resumed_lwps, count_events_callback)
6888         (select_event_lwp_callback): Likewise.
6889         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6890         * arm-linux-nat.c (struct update_registers_data): Remove.
6891         (update_registers_callback): Change type.
6892         (arm_linux_insert_hw_breakpoint1): Update.
6893         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6894         parameter.
6895         (x86_linux_dr_set_addr): Update.
6896         (x86_linux_dr_set_control): Update.
6897         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6898         (iterate_over_lwps): Use gdb::function_view.
6899         * nat/aarch64-linux-hw-point.c (struct
6900         aarch64_dr_update_callback_param): Remove.
6901         (debug_reg_change_callback): Change type.
6902         (aarch64_notify_debug_reg_change): Update.
6903         * s390-linux-nat.c (s390_refresh_per_info): Update.
6904
6905 2019-03-11  Tom Tromey  <tromey@adacore.com>
6906
6907         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6908         redundant assignment to "this_cu".
6909
6910 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6911
6912         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6913
6914 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6915
6916         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6917         from...
6918         (rank_one_type): ... this.
6919
6920 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6921
6922         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6923         from...
6924         (rank_one_type): ... this.
6925
6926 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6927
6928         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6929         from...
6930         (rank_one_type): ... this.
6931
6932 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6933
6934         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6935         from...
6936         (rank_one_type): ... this.
6937
6938 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6939
6940         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6941         from...
6942         (rank_one_type): ... this.
6943
6944 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6945
6946         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6947         from...
6948         (rank_one_type): ... this.
6949
6950 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6951
6952         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6953         from...
6954         (rank_one_type): ... this.
6955
6956 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6957
6958         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6959         from...
6960         (rank_one_type): ... this.
6961
6962 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6963
6964         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6965         from...
6966         (rank_one_type): ... this.
6967
6968 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6969
6970         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6971         from...
6972         (rank_one_type): ... this.
6973
6974 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6975
6976         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6977         from...
6978         (rank_one_type): ... this.
6979
6980 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6981
6982         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6983         from...
6984         (rank_one_type): ... this.
6985
6986 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6987
6988         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6989         inferior-events' shows the example events.
6990
6991 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6992
6993         Support styling on native MS-Windows console
6994
6995         PR/24315
6996         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6997         on MS-Windows if $TERM is not defined.
6998
6999         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7000
7001         * posix-hdep.c (gdb_console_fputs):
7002         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7003         functions.
7004         * ui-file.h (gdb_console_fputs): Add prototype.
7005
7006         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7007         back to fputs only if the former returns zero.
7008
7009 2019-03-07  Tom Tromey  <tom@tromey.com>
7010
7011         * symmisc.c (print_symbol_bcache_statistics): Update.
7012         (print_objfile_statistics): Update.
7013         * symfile.c (allocate_symtab): Update.
7014         * stabsread.c: Don't include bcache.h.
7015         * psymtab.h (struct psymbol_bcache): Don't declare.
7016         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7017         (psymbol_bcache_init, psymbol_bcache_free)
7018         (psymbol_bcache_get_bcache): Don't declare.
7019         * psymtab.c (struct psymbol_bcache): Remove.
7020         (psymtab_storage::psymtab_storage): Update.
7021         (psymtab_storage::~psymtab_storage): Update.
7022         (psymbol_bcache_init, psymbol_bcache_free)
7023         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7024         (add_psymbol_to_bcache): Update.
7025         (allocate_psymtab): Update.
7026         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7027         macro_cache>: No longer pointers.
7028         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7029         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7030         * macrotab.c (macro_bcache): Update.
7031         * macroexp.c: Don't include bcache.h.
7032         * gdbtypes.c (check_types_worklist): Update.
7033         (types_deeply_equal): Remove TRY/CATCH.  Update.
7034         * elfread.c (elf_symtab_read): Update.
7035         * dwarf2read.c: Don't include bcache.h.
7036         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7037         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7038         (print_bcache_statistics, bcache_memory_used): Don't declare.
7039         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7040         methods.  Rename all data members.
7041         * bcache.c (struct bcache): Move to bcache.h.
7042         (bcache::expand_hash_table): Rename from expand_hash_table.
7043         (bcache): Remove.
7044         (bcache::insert): Rename from bcache_full.
7045         (bcache::compare): Rename from bcache_compare.
7046         (bcache_xmalloc): Remove.
7047         (bcache::~bcache): Rename from bcache_xfree.
7048         (bcache::print_statistics): Rename from print_bcache_statistics.
7049         (bcache::memory_used): Rename from bcache_memory_used.
7050
7051 2019-03-07  Pedro Alves  <palves@redhat.com>
7052
7053         * infrun.c (normal_stop): Also check for
7054         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7055
7056 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7057
7058         * f-lang.c (value_from_host_double): Moved to...
7059         * value.c (value_from_host_double): ...here.
7060         * value.h (value_from_host_double): Declare.
7061         * guile/scm-math.c (vlscm_convert_typed_number): Use
7062         value_from_host_double.
7063         (vlscm_convert_number): Likewise.
7064         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7065         * python/py-value.c (convert_value_from_python): Likewise.
7066
7067 2019-03-06  Tom Tromey  <tom@tromey.com>
7068
7069         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7070
7071 2019-03-06  Tom Tromey  <tom@tromey.com>
7072
7073         * utils.h (free_current_contents): Don't declare.
7074         * utils.c (free_current_contents): Remove.
7075
7076 2019-03-06  Tom Tromey  <tom@tromey.com>
7077
7078         * top.c (quit_force): Update.
7079         * main.c (captured_command_loop): Update.
7080         * common/new-op.c (operator new): Update.
7081         * common/common-exceptions.c (struct catcher)
7082         <save_cleanup_chain>: Remove member.
7083         (exceptions_state_mc_init): Update.
7084         (exception_try_scope_entry): Return nullptr.
7085         (exception_try_scope_exit, exception_rethrow)
7086         (throw_exception_sjlj, throw_exception_cxx): Update.
7087         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7088         (all_cleanups, do_cleanups, discard_cleanups)
7089         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7090         (restore_cleanups, restore_final_cleanups): Don't declare.
7091         (do_final_cleanups): Remove parameter.
7092         * common/cleanups.c (cleanup_chain, make_cleanup)
7093         (make_cleanup_dtor, all_cleanups, do_cleanups)
7094         (discard_my_cleanups, discard_cleanups)
7095         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7096         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7097         (null_cleanup): Remove.
7098         (do_final_cleanups): Remove parameter.
7099
7100 2019-03-06  Tom Tromey  <tom@tromey.com>
7101
7102         * remote.c (remote_target::remote_parse_stop_reply): Use
7103         unique_xmalloc_ptr.
7104
7105 2019-03-06  Tom Tromey  <tom@tromey.com>
7106
7107         * stabsread.c (struct stabs_field_info): Rename from field_info.
7108         <list, fnlist>: Add initializers.
7109         <obstack>: New member.
7110         (read_member_functions, read_struct_fields, read_baseclasses):
7111         Allocate on obstack.  Don't use cleanups.
7112         (read_one_struct_field, read_member_functions, read_struct_fields)
7113         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7114         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7115         (read_struct_type): Update.
7116
7117 2019-03-06  Tom Tromey  <tom@tromey.com>
7118
7119         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7120         * common/filestuff.h (make_cleanup_close): Don't declare.
7121         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7122         Remove.
7123
7124 2019-03-06  Tom Tromey  <tom@tromey.com>
7125
7126         * solib-aix.c: Use make_scope_exit.
7127
7128 2019-03-06  Tom Tromey  <tom@tromey.com>
7129
7130         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7131         Use make_scope_exit.
7132
7133 2019-03-06  Tom Tromey  <tom@tromey.com>
7134
7135         * solib-svr4.c (disable_probes_interface): Remove parameter.
7136         (svr4_handle_solib_event): Use make_scope_exit.
7137
7138 2019-03-06  Tom Tromey  <tom@tromey.com>
7139
7140         * remote.c (struct stop_reply_deleter): Remove.
7141         (stop_reply_up): Update.
7142         (struct stop_reply): Derive from notif_event.  Don't typedef.
7143         <regcache>: Now a std::vector.
7144         (stop_reply_xfree): Remove.
7145         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7146         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7147         (remote_target::discard_pending_stop_replies): Use delete.
7148         (remote_target::remote_parse_stop_reply): Update.
7149         (remote_target::process_stop_reply): Update.
7150         * remote-notif.h (struct notif_event): Add virtual destructor.
7151         Remove "dtr" member.
7152         (struct notif_client) <alloc_event>: Return a unique_ptr.
7153         (notif_event_xfree): Don't declare.
7154         (notif_event_up): New typedef.
7155         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7156         (notif_event_xfree, do_notif_event_xfree): Remove.
7157         (remote_notif_state_xfree): Update.
7158
7159 2019-03-06  Tom Tromey  <tom@tromey.com>
7160
7161         * infrun.c (displaced_step_clear_cleanup): Now a
7162         forward_scope_exit type.
7163         (displaced_step_prepare_throw): Update.
7164         (displaced_step_fixup): Update.
7165
7166 2019-03-06  Tom Tromey  <tom@tromey.com>
7167
7168         * inferior.h (class inferior): Update comment.
7169         * gdbthread.h (class thread_info): Update comment.
7170
7171 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7172             Tom Tromey  <tom@tromey.com>
7173
7174         * stabsread.h (struct stab_section_list): Remove.
7175         (coffstab_build_psymtabs): Update.
7176         * dbxread.c (symbuf_sections): Now a std::vector.
7177         (sect_idx): New global.
7178         (fill_symbuf): Update.
7179         (coffstab_build_psymtabs): Change type of stabsects parameter.
7180         Update.
7181         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7182         std::vector.
7183         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7184         (coff_locate_sections): Update.
7185         (coff_symfile_read): Remove cleanups.  Update.
7186         (init_stringtab): Add storage parameter.
7187         (free_stringtab, free_stringtab_cleanup): Remove.
7188         (init_lineno): Add storage parameter.
7189         (free_linetab, free_linetab_cleanup): Remove.
7190
7191 2019-03-06  Pedro Alves  <palves@redhat.com>
7192
7193         * linux-fork.c (fork_info::clobber_regs): Delete.
7194         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7195         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7196         comment.  Adjust.
7197         (scoped_switch_fork_info::scoped_switch_fork_info)
7198         (checkpoint_command, linux_fork_context): Adjust
7199         fork_save_infrun_state calls.
7200
7201 2019-03-06  Pedro Alves  <palves@redhat.com>
7202
7203         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7204         (inf_has_multiple_threads): Return 'bool' and rewrite using
7205         inferior_info::threads().
7206
7207 2019-03-06  Pedro Alves  <palves@redhat.com>
7208
7209         * linux-fork.c: Include <list>.
7210         (fork_list): Now a std::list instance.
7211         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7212         (forks_exist_p, find_last_fork): Adjust.
7213         (new_fork): Delete.
7214         (one_fork_p): New.
7215         (add_fork): Adjust.
7216         (free_fork): Delete, folded into fork_info::~fork_info().
7217         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7218         Adjust.
7219         (init_fork_list): Delete.
7220         (linux_fork_killall, linux_fork_mourn_inferior)
7221         (linux_fork_detach, info_checkpoints_command): Adjust.
7222         (_initialize_linux_fork): No longer call init_fork_list.
7223
7224 2019-03-06  Pedro Alves  <palves@redhat.com>
7225
7226         * linux-fork.c (new_fork): New, split out of ...
7227         (add_fork): ... this.  Return void.  Move "first fork" special
7228         case from here, to ...
7229         (checkpoint_command): ... here.
7230         * linux-linux.h (add_fork): Return void.
7231
7232 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7233
7234         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7235
7236 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7237             Chris January  <chris.january@arm.com>
7238             David Lecomber  <david.lecomber@arm.com>
7239
7240         * f-exp.y: New token, UNOP_INTRINSIC.
7241         (exp): New pattern using UNOP_INTRINSIC token.
7242         (f77_keywords): Add 'abs' keyword.
7243         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7244         (value_from_host_double): New function.
7245         (evaluate_subexp_f): Support UNOP_ABS.
7246
7247 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7248
7249         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7250         types.
7251
7252 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7253
7254         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7255         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7256         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7257
7258 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7259
7260         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7261
7262 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7263             Chris January  <chris.january@arm.com>
7264
7265         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7266         * f-exp.y: Define 'KIND' token.
7267         (exp): New pattern for KIND expressions.
7268         (ptype): Handle types with a kind extension.
7269         (direct_abs_decl): Extend to spot kind extensions.
7270         (f77_keywords): Add 'kind' to the list.
7271         (push_kind_type): New function.
7272         (convert_to_kind_type): New function.
7273         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7274         * parse.c (operator_length_standard): Likewise.
7275         * parser-defs.h (enum type_pieces): Add tp_kind.
7276         * std-operator.def: Add UNOP_KIND.
7277
7278 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7279
7280         * f-exp.y (f_parse): Set yydebug.
7281
7282 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7283
7284         * f-lang.c (evaluate_subexp_f): New function.
7285         (exp_descriptor_f): New global.
7286         (f_language_defn): Use exp_descriptor_f instead of
7287         exp_descriptor_standard.
7288
7289 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7290
7291         * f-exp.y (struct token): Add comments.
7292         (dot_ops): Remove uppercase versions and the end marker.
7293         (f77_keywords): Likewise.
7294         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7295         entries in the dot_ops array are case insensitive, and use
7296         strncasecmp to compare strings.  Also some whitespace cleanup in
7297         this area.  Similar for the f77_keywords array, except entries in
7298         this list might be case sensitive.
7299
7300 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7301
7302         * f-exp.y (struct f77_boolean_val): Add comments.
7303         (boolean_values): Remove uppercase versions, and end marker.
7304         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7305         and use strncasecmp to achieve case insensitivity.  Additionally,
7306         perform whitespace cleanup around this code.
7307
7308 2019-03-06  Tom Tromey  <tromey@adacore.com>
7309
7310         * remote-sim.c (gdbsim_target_open): Use result of
7311         gdb_argv::release.
7312
7313 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7314         Dirk Schubert  <dirk.schubert@arm.com>
7315         Chris January  <chris.january@arm.com>
7316
7317         * eval.c (evaluate_subexp_standard): Call Fortran argument
7318         wrapping logic.
7319         * f-lang.c (struct value): A value which can be passed into a
7320         Fortran function call.
7321         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7322         where appropriate.
7323         (struct type): Value ready for a Fortran function call.
7324         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7325         is needed.
7326         * f-lang.h (fortran_argument_convert): Declaration.
7327         (fortran_preserve_arg_pointer): Declaration.
7328         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7329
7330 2019-03-05  Tom Tromey  <tromey@adacore.com>
7331
7332         * python/py-prettyprint.c (print_string_repr): Remove #if.
7333         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7334
7335 2019-03-05  Tom Tromey  <tromey@adacore.com>
7336
7337         * target.c (the_dummy_target): Move later.  Change type to
7338         "dummy_target".
7339         (initialize_targets): Don't initialize the_dummy_target.
7340
7341 2019-03-05  Tom Tromey  <tromey@adacore.com>
7342
7343         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7344         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7345
7346 2019-03-05  Tom Tromey  <tromey@adacore.com>
7347
7348         * windows-nat.c (windows_nat_target::attach)
7349         (windows_nat_target::detach): Don't call gdb_flush.
7350         * valprint.c (generic_val_print, val_print, val_print_string):
7351         Don't call gdb_flush.
7352         * utils.c (defaulted_query): Don't call gdb_flush.
7353         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7354         * target.c (target_announce_detach): Don't call gdb_flush.
7355         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7356         * remote.c (extended_remote_target::attach): Don't call
7357         gdb_flush.
7358         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7359         * printcmd.c (do_examine): Don't call gdb_flush.
7360         (info_display_command): Don't call gdb_flush.
7361         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7362         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7363         * memattr.c (info_mem_command): Don't call gdb_flush.
7364         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7365         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7366         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7367         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7368         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7369         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7370         (gnu_nat_target::detach): Don't call gdb_flush.
7371         * f-valprint.c (f_val_print): Don't call gdb_flush.
7372         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7373         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7374         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7375         gdb_flush.
7376         * c-valprint.c (c_val_print): Don't call gdb_flush.
7377         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7378
7379 2019-03-05  Tom Tromey  <tromey@adacore.com>
7380
7381         * varobj.c (update_dynamic_varobj_children): Update.
7382         (install_default_visualizer): Use reset, not release.
7383         * value.c (set_internalvar): Update.
7384         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7385         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7386         ATTRIBUTE_UNUSED_RESULT.
7387
7388 2019-03-05  Tom Tromey  <tromey@adacore.com>
7389
7390         * remote.c (class scoped_remote_fd) <release>: Add
7391         ATTRIBUTE_UNUSED_RESULT.
7392
7393 2019-03-05  Tom Tromey  <tromey@adacore.com>
7394
7395         * macroexp.c (struct macro_buffer) <release>: Add
7396         ATTRIBUTE_UNUSED_RESULT.
7397
7398 2019-03-05  Tom Tromey  <tromey@adacore.com>
7399
7400         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7401         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7402         ATTRIBUTE_UNUSED_RESULT.
7403
7404 2019-03-05  Tom Tromey  <tromey@adacore.com>
7405
7406         * common/scoped_fd.h (class scoped_fd) <release>: Add
7407         ATTRIBUTE_UNUSED_RESULT.
7408
7409 2019-03-05  Tom Tromey  <tromey@adacore.com>
7410
7411         * parser-defs.h (struct parser_state) <release>: Add
7412         ATTRIBUTE_UNUSED_RESULT.
7413
7414 2019-03-05  Tom Tromey  <tromey@adacore.com>
7415
7416         * utils.h (class gdb_argv) <release>: Add
7417         ATTRIBUTE_UNUSED_RESULT.
7418         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7419
7420 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7421
7422         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7423         for-loop range, to avoid compiler warnings.
7424
7425         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7426         avoid compiler warnings about unused variables.
7427
7428         * NEWS: Mention end of support for native debugging on MS-Windows
7429         before XP.
7430
7431         PR gdb/24292
7432         * common/netstuff.c:
7433         * gdbserver/gdbreplay.c
7434         * gdbserver/remote-utils.c:
7435         * ser-tcp.c:
7436         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7437         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7438         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7439         'getaddrinfo' and 'freeaddrinfo' were not available before
7440         Windows XP, and mingw.org's MinGW headers by default define
7441         _WIN32_WINNT to 0x500.
7442
7443 2019-03-01  Gary Benson <gbenson@redhat.com>
7444
7445         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7446
7447 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7448             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7449
7450         PR gdb/8527
7451         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7452         set_sigint_trap, clear_sigint_trap.
7453
7454 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7455
7456         * target.c (target_detach): Clear the regcache and the
7457         frame cache.
7458
7459 2019-02-27  Pedro Alves  <palves@redhat.com>
7460
7461         * utils.c (set_screen_size): When we cap the height/width sizes,
7462         tweak the corresponding command variable to show "unlimited":
7463
7464 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7465             Pedro Alves  <palves@redhat.com>
7466
7467         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7468         before calling rl_set_screen_size.
7469
7470 2019-02-27  Tom Tromey  <tromey@adacore.com>
7471
7472         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7473         define.
7474         * python/py-value.c: Remove Python 2.4 workaround.
7475         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7476         workaround.
7477         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7478         Python 2.4 workaround.
7479         * python/python-internal.h: Remove Python 2.4 comment.
7480         (Py_ssize_t): Don't define.
7481         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7482         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7483         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7484         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7485         * python/python.c (do_start_initialization): Remove Python 2.4
7486         workaround.
7487         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7488         (print_children): Remove Python 2.4 workaround.
7489         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7490         workaround.
7491         (CHARBUFFERPROC_NAME): Remove.
7492         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7493         Python 2.4 workaround.
7494
7495 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7496
7497         * NEWS: Note minimum Python version.
7498
7499 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7500
7501         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7502         code from these functions.  Remove corresponding ifdefs.  Use
7503         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7504         Remove gotos and target of gotos.
7505         (infpy_search_memory): Likewise.
7506
7507 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7508
7509         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7510         (hppa_gdbarch_init): Don't register deleted functions with
7511         gdbarch.
7512
7513 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7514
7515         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7516         (h8300_unwind_sp): Delete.
7517         (h8300_dummy_id): Delete.
7518         (h8300_gdbarch_init): Don't register deleted functions with
7519         gdbarch.
7520
7521 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7522
7523         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7524         (ft32_unwind_pc): Delete.
7525         (ft32_unwind_sp): Delete.
7526         (ft32_gdbarch_init): Don't register deleted functions with
7527         gdbarch.
7528
7529 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7530
7531         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7532         (frv_unwind_pc): Delete.
7533         (frv_unwind_sp): Delete.
7534         (frv_gdbarch_init): Don't register deleted functions with
7535         gdbarch.
7536
7537 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7538
7539         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7540         (riscv_unwind_pc): Delete.
7541         (riscv_unwind_sp): Delete.
7542         (riscv_gdbarch_init): Don't register deleted functions with
7543         gdbarch.
7544
7545 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7546
7547         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7548         (csky_unwind_pc): Delete.
7549         (csky_unwind_sp): Delete.
7550         (csky_gdbarch_init): Don't register deleted functions with
7551         gdbarch.
7552
7553 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7554
7555         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7556         (cris_unwind_pc): Delete.
7557         (cris_unwind_sp): Delete.
7558         (cris_gdbarch_init): Don't register deleted functions with
7559         gdbarch.
7560
7561 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7562
7563         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7564         (bfin_unwind_pc): Delete.
7565         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7566
7567 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7568
7569         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7570         (arm_unwind_pc): Delete.
7571         (arm_unwind_sp): Delete.
7572         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7573
7574 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7575
7576         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7577         (arc_unwind_pc): Delete.
7578         (arc_unwind_sp): Delete.
7579         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7580
7581 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7582
7583         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7584         (alpha_unwind_pc): Delete.
7585         (alpha_gdbarch_init): Don't register deleted functions with
7586         gdbarch.
7587
7588 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7589
7590         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7591         (aarch64_unwind_pc): Delete.
7592         (aarch64_unwind_sp): Delete.
7593         (aarch64_gdbarch_init): Don't register deleted functions with
7594         gdbarch.
7595
7596 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7597
7598         * gdbtypes.c (type_align): Don't consider static members when
7599         computing structure alignment.
7600
7601 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7602
7603         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7604         return 0 for other types.
7605         * arch-utils.c (default_type_align): Always return 0.
7606         * gdbarch.h: Regenerate.
7607         * gdbarch.sh (type_align): Extend comment.
7608         * gdbtypes.c (type_align): Add additional comments, always call
7609         gdbarch_type_align before applying the default rules.
7610         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7611         generic code will then apply a suitable default.
7612         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7613         types, return 0 for other types.
7614
7615 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7616
7617         * NEWS: Create a new section for the next release branch.
7618         Rename the section of the current branch, now that it has
7619         been cut.
7620
7621 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7622
7623         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7624         * version.in: Bump version to 8.3.50.DATE-git.
7625
7626 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7627
7628         * aix-thread.c (ptid_cmp): Remove unused variable.
7629         (get_signaled_thread): Likewise.
7630         (store_regs_user_thread): Likewise.
7631         (store_regs_kernel_thread): Likewise.
7632         (fetch_regs_kernel_thread): Remove shadowed variable.
7633
7634 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7635
7636         * features/riscv/32bit-cpu.xml: Add register numbers.
7637         * features/riscv/32bit-fpu.c: Regenerate.
7638         * features/riscv/32bit-fpu.xml: Add register numbers.
7639         * features/riscv/64bit-cpu.xml: Add register numbers.
7640         * features/riscv/64bit-fpu.c: Regenerate.
7641         * features/riscv/64bit-fpu.xml: Add register numbers.
7642
7643 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7644
7645         * NEWS: Mention two argument form of gdb.Value constructor.
7646         * python/py-value.c (convert_buffer_and_type_to_value): New
7647         function.
7648         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7649         Add support for handling an optional second argument.  Call
7650         convert_buffer_and_type_to_value as appropriate.
7651         * python/python-internal.h (Py_buffer_deleter): New struct.
7652         (Py_buffer_up): New typedef.
7653
7654 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7655
7656         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7657         instead of releasing ownership.
7658
7659 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7660
7661         * dwarf2read.c (open_and_init_dwp_file): Call
7662         elf_numsections instead of bfd_count_sections to initialize
7663         dwp_file->num_sections.
7664
7665 2019-02-25  Tom Tromey  <tromey@adacore.com>
7666
7667         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7668
7669 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7670
7671         * gcore.in: Add '--readnever' option when invoking GDB.
7672
7673 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7674
7675         * MAINTAINERS: Update my email address.
7676
7677 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7678
7679         * build-id.c (build_id_to_debug_bfd_1): New function.
7680         (build_id_to_debug_bfd): Look for separate debug file in
7681         sysroot.
7682
7683 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7684
7685         * gdbarch.sh: Update the copyright year range that is placed into
7686         generated files.
7687
7688 2019-02-22  Keith Seitz  <keiths@redhat.com>
7689
7690         PR symtab/23853
7691         * linespec.c (create_sals_line_offset): Search for the default
7692         symtab's filename instead of its fullname.
7693
7694 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7695
7696         * NEWS: Update style defaults.
7697
7698 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7699
7700         * main.c (captured_main_1): Disable styling in batch mode.
7701
7702 2019-02-20  Tom Tromey  <tom@tromey.com>
7703
7704         * symtab.c (symtab_symbol_info): Fix typos.
7705
7706 2019-02-20  Tom Tromey  <tromey@adacore.com>
7707
7708         * findcmd.c (_initialize_mem_search): Use upper case for
7709         metasyntactic variables.
7710
7711 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7712
7713         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7714         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7715
7716 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7717
7718         * top.h (source_file_name): Change to std::string.
7719         * top.c (source_file_name): Likewise.
7720         (command_line_input): Adjust.
7721         * cli/cli-script.c (script_from_file): Adjust.
7722
7723 2019-02-19  Tom Tromey  <tromey@adacore.com>
7724
7725         * ravenscar-thread.c
7726         (ravenscar_thread_target::update_thread_list): Don't call
7727         ada_build_task_list.
7728         * ada-lang.h (ada_build_task_list): Don't declare.
7729         * ada-tasks.c (struct ada_tasks_inferior_data)
7730         <task_list_valid_p>: Now bool.
7731         (read_known_tasks, ada_task_list_changed)
7732         (ada_tasks_invalidate_inferior_data): Update.
7733         (read_known_tasks_array): Return bool.
7734         (read_known_tasks_list): Likewise.
7735         (read_known_tasks): Return void.
7736         (ada_build_task_list): Now static.
7737
7738 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7739
7740         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7741         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7742
7743 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7744
7745         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7746         variant for ada_tasks_pspace_data_handle and
7747         ada_tasks_inferior_data_handle.
7748         (ada_tasks_pspace_data_cleanup): New function.
7749         (ada_tasks_inferior_data_cleanup): New function.
7750
7751 2019-02-17  Tom Tromey  <tom@tromey.com>
7752
7753         * macrotab.h (macro_source_fullname): Return a std::string.
7754         * macrotab.c (macro_include, check_for_redefinition)
7755         (macro_undef, macro_lookup_definition, foreach_macro)
7756         (foreach_macro_in_scope): Update.
7757         (macro_source_fullname): Return a std::string.
7758         * macrocmd.c (show_pp_source_pos): Update.
7759
7760 2019-02-17  Tom Tromey  <tom@tromey.com>
7761
7762         * macrocmd.c (show_pp_source_pos): Style the file names.
7763
7764 2019-02-17  Tom Tromey  <tom@tromey.com>
7765
7766         PR tui/24197:
7767         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7768
7769 2019-02-17  Tom Tromey  <tom@tromey.com>
7770
7771         * ada-lang.c (user_select_syms): Use filtered printing.
7772         * utils.c (wrap_style): New global.
7773         (desired_style): Remove.
7774         (emit_style_escape): Add stream parameter.
7775         (set_output_style, reset_terminal_style, prompt_for_continue):
7776         Update.
7777         (flush_wrap_buffer): Only flush gdb_stdout.
7778         (wrap_here): Set wrap_style.
7779         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7780         treat escape sequences as a character.  Change when wrap buffer is
7781         flushed.
7782         (fputs_styled): Do not set the output style when the default is
7783         requested.
7784         * ui-style.h (struct ui_file_style) <is_default>: New method.
7785         * source.c (print_source_lines_base): Emit escape sequences in one
7786         piece.
7787
7788 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7789
7790         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7791         integers and enumeration types.
7792
7793 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7794
7795         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7796         instead of lookup_symbol_in_language
7797         (do_exact_match): New function.
7798         (ada_get_symbol_name_matcher): Return do_exact_match when
7799         doing a verbatim match.
7800
7801 2019-02-15  Tom Tromey  <tromey@adacore.com>
7802
7803         * ravenscar-thread.c (ravenscar_thread_target::resume)
7804         (ravenscar_thread_target::wait): Special case wildcard requests.
7805
7806 2019-02-15  Tom Tromey  <tromey@adacore.com>
7807
7808         * ravenscar-thread.c (base_ptid): Remove.
7809         (struct ravenscar_thread_target) <close>: New method.
7810         <m_base_ptid>: New member.
7811         <update_inferior_ptid, active_task, task_is_currently_active,
7812         runtime_initialized>: Declare methods.
7813         <ravenscar_thread_target>: Add constructor.
7814         (ravenscar_thread_target::task_is_currently_active)
7815         (ravenscar_thread_target::update_inferior_ptid)
7816         (ravenscar_runtime_initialized): Rename.  Now methods.
7817         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7818         (ravenscar_thread_target::update_thread_list): Update.
7819         (ravenscar_thread_target::active_task): Now method.
7820         (ravenscar_thread_target::store_registers)
7821         (ravenscar_thread_target::prepare_to_store)
7822         (ravenscar_thread_target::prepare_to_store)
7823         (ravenscar_thread_target::mourn_inferior): Update.
7824         (ravenscar_inferior_created): Use "new" to create target.
7825         (ravenscar_thread_target::get_ada_task_ptid): Update.
7826         (_initialize_ravenscar): Don't initialize base_ptid.
7827         (ravenscar_ops): Remove global.
7828
7829 2019-02-15  Tom Tromey  <tromey@adacore.com>
7830
7831         * target.h (push_target): Declare new overload.
7832         * target.c (push_target): New overload, taking an rvalue reference.
7833         * remote.c (remote_target::open_1): Use push_target overload.
7834         * corelow.c (core_target_open): Use push_target overload.
7835
7836 2019-02-15  Tom Tromey  <tromey@adacore.com>
7837
7838         * ravenscar-thread.c (is_ravenscar_task)
7839         (ravenscar_task_is_currently_active): Return bool.
7840         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7841         (_initialize_ravenscar): Remove "(void)".
7842         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7843         Return bool.
7844
7845 2019-02-15  Tom Tromey  <tromey@adacore.com>
7846
7847         * ravenscar-thread.c (ravenscar_runtime_initializer)
7848         (has_ravenscar_runtime, get_running_thread_id)
7849         (ravenscar_thread_target::resume): Fix indentation.
7850
7851 2019-02-15  Tom Tromey  <tromey@adacore.com>
7852
7853         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7854         from ravenscar_arch_ops.
7855         (sparc_ravenscar_ops::fetch_registers)
7856         (sparc_ravenscar_ops::store_registers): Now methods.
7857         (sparc_ravenscar_prepare_to_store): Remove.
7858         (sparc_ravenscar_ops): Redefine.
7859         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7860         methods and destructor.  Remove members.
7861         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7862         (ravenscar_thread_target::store_registers)
7863         (ravenscar_thread_target::prepare_to_store): Update.
7864         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7865         Remove.
7866         (struct ppc_ravenscar_powerpc_ops): Derive from
7867         ravenscar_arch_ops.
7868         (ppc_ravenscar_powerpc_ops::fetch_registers)
7869         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7870         (ppc_ravenscar_powerpc_ops): Redefine.
7871         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7872         (ppc_ravenscar_e500_ops::fetch_registers)
7873         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7874         (ppc_ravenscar_e500_ops): Redefine.
7875         * aarch64-ravenscar-thread.c
7876         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7877         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7878         (aarch64_ravenscar_fetch_registers)
7879         (aarch64_ravenscar_store_registers): Now methods.
7880         (aarch64_ravenscar_ops): Redefine.
7881
7882 2019-02-15  Tom Tromey  <tromey@adacore.com>
7883
7884         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7885         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7886         (ravenscar_thread_target::stopped_by_watchpoint)
7887         (ravenscar_thread_target::stopped_data_address)
7888         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7889
7890 2019-02-15  Tom Tromey  <tromey@adacore.com>
7891
7892         * ravenscar-thread.c: Fix some typos.
7893
7894 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7895             Tom Tromey  <tromey@adacore.com>
7896
7897         * ada-lang.c (ada_exception_sal): Change addr_string to a
7898         std::string.
7899         (create_ada_exception_catchpoint): Update.
7900
7901 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7902             Tom Tromey  <tromey@adacore.com>
7903
7904         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7905         (bp_location_ops): Remove.
7906         (base_breakpoint_allocate_location): Update.
7907         (free_bp_location): Update.
7908         * ada-lang.c (class ada_catchpoint_location)
7909         <ada_catchpoint_location>: Remove ops parameter.
7910         (ada_catchpoint_location_dtor): Remove.
7911         (ada_catchpoint_location_ops): Remove.
7912         (allocate_location_exception): Update.
7913         * breakpoint.h (struct bp_location_ops): Remove.
7914         (class bp_location) <bp_location>: Remove bp_location_ops
7915         parameter.
7916         <~bp_location>: Add destructor.
7917         <ops>: Remove.
7918
7919 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7920             Pedro Alves  <palves@redhat.com>
7921
7922         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7923         'PATH_MAX'.
7924
7925 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7926             Samuel Thibault  <samuel.thibault@gnu.org>
7927             Thomas Schwinge  <thomas@codesourcery.com>
7928
7929         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7930         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7931
7932 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7933
7934         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7935         (check_empty): Use "const char *".
7936
7937         * gnu-nat.c (gnu_nat_target::detach): Instead of
7938         'detach_inferior (pid)' call
7939         'detach_inferior (find_inferior_pid (pid))'.
7940
7941         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7942         'nat/fork-inferior.o'.
7943         * gnu-nat.c: #include "nat/fork-inferior.h".
7944
7945         * gnu-nat.c (gnu_nat_target::detach): Instead of
7946         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7947         * gnu-nat.h: #include "inf-child.h".
7948         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7949         'i386_gnu_nat_target::fetch_registers'.
7950         (gnu_store_registers): Rename/move to
7951         'i386_gnu_nat_target::store_registers'.
7952
7953         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7954         * gnu-nat.h (mach_thread_info): New function.
7955         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7956
7957         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7958
7959 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7960
7961         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7962
7963 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7964
7965         * windows-nat.c (windows_add_thread): Add new parameter
7966         "main_thread_p" with default value set to false.  Update
7967         function documentation as well as all callers.
7968         (windows_delete_thread): Likewise.
7969         (fake_create_process): Update call to windows_add_thread.
7970         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7971         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7972         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7973         call to windows_delete_thread.
7974
7975 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7976
7977         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7978
7979 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7980
7981         * symfile.c (find_separate_debug_file): Use canonical path of
7982         sysroot with child_path instead of gdb_sysroot if it is valid.
7983
7984 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7985
7986         * symfile.c (find_separate_debug_file): Use child_path to
7987         determine if an object file is under a sysroot.
7988
7989 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7990
7991         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7992         unittests/child-path-selftests.c.
7993         * common/pathstuff.c (child_path): New function.
7994         * common/pathstuff.h (child_path): New prototype.
7995         * unittests/child-path-selftests.c: New file.
7996
7997 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7998
7999         * symfile.c (find_separate_debug_file): Look for separate debug
8000         files in debug directories under the sysroot.
8001
8002 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8003
8004         * symtab.h (struct minimal_symbol data_p): New const method.
8005         (struct minimal_symbol text_p): Likewise.
8006         * symtab.c (output_source_filename): Use file name style
8007         to print file name.
8008         (print_symbol_info): Likewise.
8009         (print_msymbol_info): Use address style to print addresses.
8010         Use function name style to print executable text symbols.
8011         (expand_symtab_containing_pc): Use data_p.
8012         (find_pc_sect_compunit_symtab): Likewise.
8013
8014 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8015
8016         * breakpoint.c (describe_other_breakpoints): Use address style
8017         to print addresses.
8018         (say_where): Likewise.
8019
8020 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8021
8022         * ada-typeprint.c (print_func_type): Print function name
8023         style to print function name.
8024         * c-typeprint.c (c_print_type_1): Likewise.
8025
8026 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8027
8028         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8029         for execve.
8030
8031 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8032
8033         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8034         type_stack.
8035
8036 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8037
8038         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8039         TYPE_CODE_REF types.
8040
8041 2019-02-08  Jim Wilson  <jimw@sifive.com>
8042
8043         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8044         (riscv_linux_fregset): New.
8045         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8046
8047 2019-02-07  Tom Tromey  <tom@tromey.com>
8048
8049         * thread.c (thread_cancel_execution_command): Update.
8050         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8051         methods.
8052         (struct thread_fsm_ops): Remove.
8053         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8054         (thread_fsm_should_stop, thread_fsm_return_value)
8055         (thread_fsm_set_finished, thread_fsm_finished_p)
8056         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8057         Don't declare.
8058         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8059         * infrun.c (clear_proceed_status_thread)
8060         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8061         (print_stop_event): Update.
8062         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8063         Add constructor.
8064         (step_command_fsm_ops): Remove.
8065         (new_step_command_fsm): Remove.
8066         (step_1): Update.
8067         (step_command_fsm::should_stop): Rename from
8068         step_command_fsm_should_stop.
8069         (step_command_fsm::clean_up): Rename from
8070         step_command_fsm_clean_up.
8071         (step_command_fsm::do_async_reply_reason): Rename from
8072         step_command_fsm_async_reply_reason.
8073         (struct until_next_fsm): Inherit from thread_fsm.  Add
8074         constructor.
8075         (until_next_fsm_ops): Remove.
8076         (new_until_next_fsm): Remove.
8077         (until_next_fsm::should_stop): Rename from
8078         until_next_fsm_should_stop.
8079         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8080         (until_next_fsm::do_async_reply_reason): Rename from
8081         until_next_fsm_async_reply_reason.
8082         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8083         constructor.  Change type of breakpoint.
8084         (finish_command_fsm_ops): Remove.
8085         (new_finish_command_fsm): Remove.
8086         (finish_command_fsm::should_stop): Rename from
8087         finish_command_fsm_should_stop.
8088         (finish_command_fsm::clean_up): Rename from
8089         finish_command_fsm_clean_up.
8090         (finish_command_fsm::return_value): Rename from
8091         finish_command_fsm_return_value.
8092         (finish_command_fsm::do_async_reply_reason): Rename from
8093         finish_command_fsm_async_reply_reason.
8094         (finish_command): Update.
8095         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8096         Add constructor.
8097         (call_thread_fsm_ops): Remove.
8098         (call_thread_fsm::call_thread_fsm): Rename from
8099         new_call_thread_fsm.
8100         (call_thread_fsm::should_stop): Rename from
8101         call_thread_fsm_should_stop.
8102         (call_thread_fsm::should_notify_stop): Rename from
8103         call_thread_fsm_should_notify_stop.
8104         (run_inferior_call, call_function_by_hand_dummy): Update.
8105         * cli/cli-interp.c (should_print_stop_to_console): Update.
8106         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8107         Add constructor.  Change type of location_breakpoint,
8108         caller_breakpoint.
8109         (until_break_fsm_ops): Remove.
8110         (new_until_break_fsm): Remove.
8111         (until_break_fsm::should_stop): Rename from
8112         until_break_fsm_should_stop.
8113         (until_break_fsm::clean_up): Rename from
8114         until_break_fsm_clean_up.
8115         (until_break_fsm::do_async_reply_reason): Rename from
8116         until_break_fsm_async_reply_reason.
8117         (until_break_command): Update.
8118         * thread-fsm.c: Remove.
8119         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8120
8121 2019-02-07  Tom Tromey  <tom@tromey.com>
8122
8123         * yy-remap.h: Add include guard.
8124         * xtensa-tdep.h: Add include guard.
8125         * xcoffread.h: Rename include guard.
8126         * varobj-iter.h: Add include guard.
8127         * tui/tui.h: Rename include guard.
8128         * tui/tui-winsource.h: Rename include guard.
8129         * tui/tui-wingeneral.h: Rename include guard.
8130         * tui/tui-windata.h: Rename include guard.
8131         * tui/tui-win.h: Rename include guard.
8132         * tui/tui-stack.h: Rename include guard.
8133         * tui/tui-source.h: Rename include guard.
8134         * tui/tui-regs.h: Rename include guard.
8135         * tui/tui-out.h: Rename include guard.
8136         * tui/tui-layout.h: Rename include guard.
8137         * tui/tui-io.h: Rename include guard.
8138         * tui/tui-hooks.h: Rename include guard.
8139         * tui/tui-file.h: Rename include guard.
8140         * tui/tui-disasm.h: Rename include guard.
8141         * tui/tui-data.h: Rename include guard.
8142         * tui/tui-command.h: Rename include guard.
8143         * tic6x-tdep.h: Add include guard.
8144         * target/waitstatus.h: Rename include guard.
8145         * target/wait.h: Rename include guard.
8146         * target/target.h: Rename include guard.
8147         * target/resume.h: Rename include guard.
8148         * target-float.h: Rename include guard.
8149         * stabsread.h: Add include guard.
8150         * rs6000-tdep.h: Add include guard.
8151         * riscv-fbsd-tdep.h: Add include guard.
8152         * regformats/regdef.h: Rename include guard.
8153         * record.h: Rename include guard.
8154         * python/python.h: Rename include guard.
8155         * python/python-internal.h: Rename include guard.
8156         * python/py-stopevent.h: Rename include guard.
8157         * python/py-ref.h: Rename include guard.
8158         * python/py-record.h: Rename include guard.
8159         * python/py-record-full.h: Rename include guard.
8160         * python/py-record-btrace.h: Rename include guard.
8161         * python/py-instruction.h: Rename include guard.
8162         * python/py-events.h: Rename include guard.
8163         * python/py-event.h: Rename include guard.
8164         * procfs.h: Add include guard.
8165         * proc-utils.h: Add include guard.
8166         * p-lang.h: Add include guard.
8167         * or1k-tdep.h: Rename include guard.
8168         * observable.h: Rename include guard.
8169         * nto-tdep.h: Rename include guard.
8170         * nat/x86-linux.h: Rename include guard.
8171         * nat/x86-linux-dregs.h: Rename include guard.
8172         * nat/x86-gcc-cpuid.h: Add include guard.
8173         * nat/x86-dregs.h: Rename include guard.
8174         * nat/x86-cpuid.h: Rename include guard.
8175         * nat/ppc-linux.h: Rename include guard.
8176         * nat/mips-linux-watch.h: Rename include guard.
8177         * nat/linux-waitpid.h: Rename include guard.
8178         * nat/linux-ptrace.h: Rename include guard.
8179         * nat/linux-procfs.h: Rename include guard.
8180         * nat/linux-osdata.h: Rename include guard.
8181         * nat/linux-nat.h: Rename include guard.
8182         * nat/linux-namespaces.h: Rename include guard.
8183         * nat/linux-btrace.h: Rename include guard.
8184         * nat/glibc_thread_db.h: Rename include guard.
8185         * nat/gdb_thread_db.h: Rename include guard.
8186         * nat/gdb_ptrace.h: Rename include guard.
8187         * nat/fork-inferior.h: Rename include guard.
8188         * nat/amd64-linux-siginfo.h: Rename include guard.
8189         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8190         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8191         * nat/aarch64-linux.h: Rename include guard.
8192         * nat/aarch64-linux-hw-point.h: Rename include guard.
8193         * mn10300-tdep.h: Add include guard.
8194         * mips-linux-tdep.h: Add include guard.
8195         * mi/mi-parse.h: Rename include guard.
8196         * mi/mi-out.h: Rename include guard.
8197         * mi/mi-main.h: Rename include guard.
8198         * mi/mi-interp.h: Rename include guard.
8199         * mi/mi-getopt.h: Rename include guard.
8200         * mi/mi-console.h: Rename include guard.
8201         * mi/mi-common.h: Rename include guard.
8202         * mi/mi-cmds.h: Rename include guard.
8203         * mi/mi-cmd-break.h: Rename include guard.
8204         * m2-lang.h: Add include guard.
8205         * location.h: Rename include guard.
8206         * linux-record.h: Rename include guard.
8207         * linux-nat.h: Add include guard.
8208         * linux-fork.h: Add include guard.
8209         * i386-darwin-tdep.h: Rename include guard.
8210         * hppa-linux-offsets.h: Add include guard.
8211         * guile/guile.h: Rename include guard.
8212         * guile/guile-internal.h: Rename include guard.
8213         * gnu-nat.h: Rename include guard.
8214         * gdb-stabs.h: Rename include guard.
8215         * frv-tdep.h: Add include guard.
8216         * f-lang.h: Add include guard.
8217         * event-loop.h: Add include guard.
8218         * darwin-nat.h: Rename include guard.
8219         * cp-abi.h: Rename include guard.
8220         * config/sparc/nm-sol2.h: Rename include guard.
8221         * config/nm-nto.h: Rename include guard.
8222         * config/nm-linux.h: Add include guard.
8223         * config/i386/nm-i386gnu.h: Rename include guard.
8224         * config/djgpp/nl_types.h: Rename include guard.
8225         * config/djgpp/langinfo.h: Rename include guard.
8226         * compile/gcc-cp-plugin.h: Add include guard.
8227         * compile/gcc-c-plugin.h: Add include guard.
8228         * compile/compile.h: Rename include guard.
8229         * compile/compile-object-run.h: Rename include guard.
8230         * compile/compile-object-load.h: Rename include guard.
8231         * compile/compile-internal.h: Rename include guard.
8232         * compile/compile-cplus.h: Rename include guard.
8233         * compile/compile-c.h: Rename include guard.
8234         * common/xml-utils.h: Rename include guard.
8235         * common/x86-xstate.h: Rename include guard.
8236         * common/version.h: Rename include guard.
8237         * common/vec.h: Rename include guard.
8238         * common/tdesc.h: Rename include guard.
8239         * common/selftest.h: Rename include guard.
8240         * common/scoped_restore.h: Rename include guard.
8241         * common/scoped_mmap.h: Rename include guard.
8242         * common/scoped_fd.h: Rename include guard.
8243         * common/safe-iterator.h: Rename include guard.
8244         * common/run-time-clock.h: Rename include guard.
8245         * common/refcounted-object.h: Rename include guard.
8246         * common/queue.h: Rename include guard.
8247         * common/ptid.h: Rename include guard.
8248         * common/print-utils.h: Rename include guard.
8249         * common/preprocessor.h: Rename include guard.
8250         * common/pathstuff.h: Rename include guard.
8251         * common/observable.h: Rename include guard.
8252         * common/netstuff.h: Rename include guard.
8253         * common/job-control.h: Rename include guard.
8254         * common/host-defs.h: Rename include guard.
8255         * common/gdb_wait.h: Rename include guard.
8256         * common/gdb_vecs.h: Rename include guard.
8257         * common/gdb_unlinker.h: Rename include guard.
8258         * common/gdb_unique_ptr.h: Rename include guard.
8259         * common/gdb_tilde_expand.h: Rename include guard.
8260         * common/gdb_sys_time.h: Rename include guard.
8261         * common/gdb_string_view.h: Rename include guard.
8262         * common/gdb_splay_tree.h: Rename include guard.
8263         * common/gdb_setjmp.h: Rename include guard.
8264         * common/gdb_ref_ptr.h: Rename include guard.
8265         * common/gdb_optional.h: Rename include guard.
8266         * common/gdb_locale.h: Rename include guard.
8267         * common/gdb_assert.h: Rename include guard.
8268         * common/filtered-iterator.h: Rename include guard.
8269         * common/filestuff.h: Rename include guard.
8270         * common/fileio.h: Rename include guard.
8271         * common/environ.h: Rename include guard.
8272         * common/common-utils.h: Rename include guard.
8273         * common/common-types.h: Rename include guard.
8274         * common/common-regcache.h: Rename include guard.
8275         * common/common-inferior.h: Rename include guard.
8276         * common/common-gdbthread.h: Rename include guard.
8277         * common/common-exceptions.h: Rename include guard.
8278         * common/common-defs.h: Rename include guard.
8279         * common/common-debug.h: Rename include guard.
8280         * common/cleanups.h: Rename include guard.
8281         * common/buffer.h: Rename include guard.
8282         * common/btrace-common.h: Rename include guard.
8283         * common/break-common.h: Rename include guard.
8284         * cli/cli-utils.h: Rename include guard.
8285         * cli/cli-style.h: Rename include guard.
8286         * cli/cli-setshow.h: Rename include guard.
8287         * cli/cli-script.h: Rename include guard.
8288         * cli/cli-interp.h: Rename include guard.
8289         * cli/cli-decode.h: Rename include guard.
8290         * cli/cli-cmds.h: Rename include guard.
8291         * charset-list.h: Add include guard.
8292         * buildsym-legacy.h: Rename include guard.
8293         * bfin-tdep.h: Add include guard.
8294         * ax.h: Rename include guard.
8295         * arm-linux-tdep.h: Add include guard.
8296         * arm-fbsd-tdep.h: Add include guard.
8297         * arch/xtensa.h: Rename include guard.
8298         * arch/tic6x.h: Add include guard.
8299         * arch/i386.h: Add include guard.
8300         * arch/arm.h: Rename include guard.
8301         * arch/arm-linux.h: Rename include guard.
8302         * arch/arm-get-next-pcs.h: Rename include guard.
8303         * arch/amd64.h: Add include guard.
8304         * arch/aarch64-insn.h: Rename include guard.
8305         * arch-utils.h: Rename include guard.
8306         * annotate.h: Add include guard.
8307         * amd64-darwin-tdep.h: Rename include guard.
8308         * aarch64-linux-tdep.h: Add include guard.
8309         * aarch64-fbsd-tdep.h: Add include guard.
8310         * aarch32-linux-nat.h: Add include guard.
8311
8312 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8313
8314         * macrotab.c (macro_define_internal): New function that
8315         factorizes macro_define_object_internal and macro_define_function
8316         code.
8317         (macro_define_object_internal): Use macro_define_internal.
8318         (macro_define_function): Likewise.
8319
8320 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8321
8322         * macrocmd.c (extract_identifier): Return
8323         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8324         callers.
8325
8326 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8327
8328         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8329
8330 2019-02-05  Tom Tromey  <tom@tromey.com>
8331
8332         * target.c (target_stack::unpush): Move assertion earlier.
8333
8334 2019-01-30  Tom Tromey  <tom@tromey.com>
8335
8336         PR python/23615:
8337         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8338         (gdbpy_parse_and_eval): Likewise.
8339         * python/python-internal.h (gdbpy_allow_threads): New class.
8340
8341 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8342
8343         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8344         (aarch64_fbsd_fpregmap): Move earlier.
8345         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8346         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8347         instead of individual calls to trad_frame_set_reg_addr.
8348         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8349         earlier.
8350         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8351         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8352         instead of individual calls to trad_frame_set_reg_addr.
8353
8354 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8355
8356         * CONTRIBUTE: Replace contribution list with wiki link.
8357
8358 2019-01-25  Tom Tromey  <tom@tromey.com>
8359
8360         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8361
8362 2019-01-25  Tom Tromey  <tom@tromey.com>
8363
8364         * xtensa-linux-nat.c: Fix common/ includes.
8365         * xml-support.h: Fix common/ includes.
8366         * xml-support.c: Fix common/ includes.
8367         * x86-linux-nat.c: Fix common/ includes.
8368         * windows-nat.c: Fix common/ includes.
8369         * varobj.h: Fix common/ includes.
8370         * varobj.c: Fix common/ includes.
8371         * value.c: Fix common/ includes.
8372         * valops.c: Fix common/ includes.
8373         * utils.c: Fix common/ includes.
8374         * unittests/xml-utils-selftests.c: Fix common/ includes.
8375         * unittests/utils-selftests.c: Fix common/ includes.
8376         * unittests/unpack-selftests.c: Fix common/ includes.
8377         * unittests/tracepoint-selftests.c: Fix common/ includes.
8378         * unittests/style-selftests.c: Fix common/ includes.
8379         * unittests/string_view-selftests.c: Fix common/ includes.
8380         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8381         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8382         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8383         * unittests/rsp-low-selftests.c: Fix common/ includes.
8384         * unittests/parse-connection-spec-selftests.c: Fix common/
8385         includes.
8386         * unittests/optional-selftests.c: Fix common/ includes.
8387         * unittests/offset-type-selftests.c: Fix common/ includes.
8388         * unittests/observable-selftests.c: Fix common/ includes.
8389         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8390         * unittests/memrange-selftests.c: Fix common/ includes.
8391         * unittests/memory-map-selftests.c: Fix common/ includes.
8392         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8393         * unittests/function-view-selftests.c: Fix common/ includes.
8394         * unittests/environ-selftests.c: Fix common/ includes.
8395         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8396         * unittests/common-utils-selftests.c: Fix common/ includes.
8397         * unittests/cli-utils-selftests.c: Fix common/ includes.
8398         * unittests/array-view-selftests.c: Fix common/ includes.
8399         * ui-file.c: Fix common/ includes.
8400         * tui/tui-io.c: Fix common/ includes.
8401         * tracepoint.h: Fix common/ includes.
8402         * tracepoint.c: Fix common/ includes.
8403         * tracefile-tfile.c: Fix common/ includes.
8404         * top.h: Fix common/ includes.
8405         * top.c: Fix common/ includes.
8406         * thread.c: Fix common/ includes.
8407         * target/waitstatus.h: Fix common/ includes.
8408         * target/waitstatus.c: Fix common/ includes.
8409         * target.h: Fix common/ includes.
8410         * target.c: Fix common/ includes.
8411         * target-memory.c: Fix common/ includes.
8412         * target-descriptions.c: Fix common/ includes.
8413         * symtab.h: Fix common/ includes.
8414         * symfile.c: Fix common/ includes.
8415         * stap-probe.c: Fix common/ includes.
8416         * spu-linux-nat.c: Fix common/ includes.
8417         * sparc-nat.c: Fix common/ includes.
8418         * source.c: Fix common/ includes.
8419         * solib.c: Fix common/ includes.
8420         * solib-target.c: Fix common/ includes.
8421         * ser-unix.c: Fix common/ includes.
8422         * ser-tcp.c: Fix common/ includes.
8423         * ser-pipe.c: Fix common/ includes.
8424         * ser-base.c: Fix common/ includes.
8425         * selftest-arch.c: Fix common/ includes.
8426         * s12z-tdep.c: Fix common/ includes.
8427         * rust-exp.y: Fix common/ includes.
8428         * rs6000-aix-tdep.c: Fix common/ includes.
8429         * riscv-tdep.c: Fix common/ includes.
8430         * remote.c: Fix common/ includes.
8431         * remote-notif.h: Fix common/ includes.
8432         * remote-fileio.h: Fix common/ includes.
8433         * remote-fileio.c: Fix common/ includes.
8434         * regcache.h: Fix common/ includes.
8435         * regcache.c: Fix common/ includes.
8436         * record-btrace.c: Fix common/ includes.
8437         * python/python.c: Fix common/ includes.
8438         * python/py-type.c: Fix common/ includes.
8439         * python/py-inferior.c: Fix common/ includes.
8440         * progspace.h: Fix common/ includes.
8441         * producer.c: Fix common/ includes.
8442         * procfs.c: Fix common/ includes.
8443         * proc-api.c: Fix common/ includes.
8444         * printcmd.c: Fix common/ includes.
8445         * ppc-linux-nat.c: Fix common/ includes.
8446         * parser-defs.h: Fix common/ includes.
8447         * osdata.c: Fix common/ includes.
8448         * obsd-nat.c: Fix common/ includes.
8449         * nat/x86-linux.c: Fix common/ includes.
8450         * nat/x86-linux-dregs.c: Fix common/ includes.
8451         * nat/x86-dregs.h: Fix common/ includes.
8452         * nat/x86-dregs.c: Fix common/ includes.
8453         * nat/ppc-linux.c: Fix common/ includes.
8454         * nat/mips-linux-watch.h: Fix common/ includes.
8455         * nat/mips-linux-watch.c: Fix common/ includes.
8456         * nat/linux-waitpid.c: Fix common/ includes.
8457         * nat/linux-ptrace.h: Fix common/ includes.
8458         * nat/linux-ptrace.c: Fix common/ includes.
8459         * nat/linux-procfs.c: Fix common/ includes.
8460         * nat/linux-personality.c: Fix common/ includes.
8461         * nat/linux-osdata.c: Fix common/ includes.
8462         * nat/linux-namespaces.c: Fix common/ includes.
8463         * nat/linux-btrace.h: Fix common/ includes.
8464         * nat/linux-btrace.c: Fix common/ includes.
8465         * nat/fork-inferior.c: Fix common/ includes.
8466         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8467         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8468         * nat/aarch64-linux.c: Fix common/ includes.
8469         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8470         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8471         * namespace.h: Fix common/ includes.
8472         * mips-linux-tdep.c: Fix common/ includes.
8473         * minsyms.c: Fix common/ includes.
8474         * mi/mi-parse.h: Fix common/ includes.
8475         * mi/mi-main.c: Fix common/ includes.
8476         * mi/mi-cmd-env.c: Fix common/ includes.
8477         * memrange.h: Fix common/ includes.
8478         * memattr.c: Fix common/ includes.
8479         * maint.h: Fix common/ includes.
8480         * maint.c: Fix common/ includes.
8481         * main.c: Fix common/ includes.
8482         * machoread.c: Fix common/ includes.
8483         * location.c: Fix common/ includes.
8484         * linux-thread-db.c: Fix common/ includes.
8485         * linux-nat.c: Fix common/ includes.
8486         * linux-fork.c: Fix common/ includes.
8487         * inline-frame.c: Fix common/ includes.
8488         * infrun.c: Fix common/ includes.
8489         * inflow.c: Fix common/ includes.
8490         * inferior.h: Fix common/ includes.
8491         * inferior.c: Fix common/ includes.
8492         * infcmd.c: Fix common/ includes.
8493         * inf-ptrace.c: Fix common/ includes.
8494         * inf-child.c: Fix common/ includes.
8495         * ia64-linux-nat.c: Fix common/ includes.
8496         * i387-tdep.c: Fix common/ includes.
8497         * i386-tdep.c: Fix common/ includes.
8498         * i386-linux-tdep.c: Fix common/ includes.
8499         * i386-linux-nat.c: Fix common/ includes.
8500         * i386-go32-tdep.c: Fix common/ includes.
8501         * i386-fbsd-tdep.c: Fix common/ includes.
8502         * i386-fbsd-nat.c: Fix common/ includes.
8503         * guile/scm-type.c: Fix common/ includes.
8504         * guile/guile.c: Fix common/ includes.
8505         * go32-nat.c: Fix common/ includes.
8506         * gnu-nat.c: Fix common/ includes.
8507         * gdbthread.h: Fix common/ includes.
8508         * gdbarch-selftests.c: Fix common/ includes.
8509         * gdb_usleep.c: Fix common/ includes.
8510         * gdb_select.h: Fix common/ includes.
8511         * gdb_bfd.c: Fix common/ includes.
8512         * gcore.c: Fix common/ includes.
8513         * fork-child.c: Fix common/ includes.
8514         * findvar.c: Fix common/ includes.
8515         * fbsd-nat.c: Fix common/ includes.
8516         * event-top.c: Fix common/ includes.
8517         * event-loop.c: Fix common/ includes.
8518         * dwarf2read.c: Fix common/ includes.
8519         * dwarf2loc.c: Fix common/ includes.
8520         * dwarf2-frame.c: Fix common/ includes.
8521         * dwarf-index-cache.c: Fix common/ includes.
8522         * dtrace-probe.c: Fix common/ includes.
8523         * disasm-selftests.c: Fix common/ includes.
8524         * defs.h: Fix common/ includes.
8525         * csky-tdep.c: Fix common/ includes.
8526         * cp-valprint.c: Fix common/ includes.
8527         * cp-support.h: Fix common/ includes.
8528         * cp-support.c: Fix common/ includes.
8529         * corelow.c: Fix common/ includes.
8530         * completer.h: Fix common/ includes.
8531         * completer.c: Fix common/ includes.
8532         * compile/compile.c: Fix common/ includes.
8533         * compile/compile-loc2c.c: Fix common/ includes.
8534         * compile/compile-cplus-types.c: Fix common/ includes.
8535         * compile/compile-cplus-symbols.c: Fix common/ includes.
8536         * command.h: Fix common/ includes.
8537         * cli/cli-dump.c: Fix common/ includes.
8538         * cli/cli-cmds.c: Fix common/ includes.
8539         * charset.c: Fix common/ includes.
8540         * build-id.c: Fix common/ includes.
8541         * btrace.h: Fix common/ includes.
8542         * btrace.c: Fix common/ includes.
8543         * breakpoint.h: Fix common/ includes.
8544         * breakpoint.c: Fix common/ includes.
8545         * ax.h:
8546         (enum agent_op): Fix common/ includes.
8547         * ax-general.c (struct aop_map): Fix common/ includes.
8548         * ax-gdb.c: Fix common/ includes.
8549         * auxv.c: Fix common/ includes.
8550         * auto-load.c: Fix common/ includes.
8551         * arm-tdep.c: Fix common/ includes.
8552         * arch/riscv.c: Fix common/ includes.
8553         * arch/ppc-linux-common.c: Fix common/ includes.
8554         * arch/i386.c: Fix common/ includes.
8555         * arch/arm.c: Fix common/ includes.
8556         * arch/arm-linux.c: Fix common/ includes.
8557         * arch/arm-get-next-pcs.c: Fix common/ includes.
8558         * arch/amd64.c: Fix common/ includes.
8559         * arch/aarch64.c: Fix common/ includes.
8560         * arch/aarch64-insn.c: Fix common/ includes.
8561         * arch-utils.c: Fix common/ includes.
8562         * amd64-windows-tdep.c: Fix common/ includes.
8563         * amd64-tdep.c: Fix common/ includes.
8564         * amd64-sol2-tdep.c: Fix common/ includes.
8565         * amd64-obsd-tdep.c: Fix common/ includes.
8566         * amd64-nbsd-tdep.c: Fix common/ includes.
8567         * amd64-linux-tdep.c: Fix common/ includes.
8568         * amd64-linux-nat.c: Fix common/ includes.
8569         * amd64-fbsd-tdep.c: Fix common/ includes.
8570         * amd64-fbsd-nat.c: Fix common/ includes.
8571         * amd64-dicos-tdep.c: Fix common/ includes.
8572         * amd64-darwin-tdep.c: Fix common/ includes.
8573         * agent.c: Fix common/ includes.
8574         * ada-lang.h: Fix common/ includes.
8575         * ada-lang.c: Fix common/ includes.
8576         * aarch64-tdep.c: Fix common/ includes.
8577
8578 2019-01-25  Tom Tromey  <tom@tromey.com>
8579
8580         * common/create-version.sh: Use common/version.h.
8581
8582 2019-01-24  Pedro Alves  <palves@redhat.com>
8583
8584         * infrun.c (signal_stop, signal_print, signal_program)
8585         (signal_catch, signal_pass): Now arrays instead of pointers.
8586         (update_signals_program_target, do_target_resume)
8587         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8588         * linux-nat.c (linux_nat_target::pass_signals)
8589         (linux_nat_target::create_inferior, linux_nat_target::attach):
8590         Adjust.
8591         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8592         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8593         * procfs.c (procfs_target::pass_signals): Adjust.
8594         * record-full.c (record_full_target::resume): Adjust.
8595         * remote.c (remote_target::pass_signals)
8596         (remote_target::program_signals): Adjust.
8597         * target-debug.h (target_debug_print_signals): Now takes a
8598         gdb::array_view as parameter.  Adjust.
8599         * target.h (target_ops) <pass_signals, program_signals>: Replace
8600         pointer and length parameters with gdb::array_view.
8601         (target_pass_signals, target_program_signals): Likewise.
8602         * target-delegates.c: Regenerate.
8603
8604 2019-01-24  Pedro Alves  <palves@redhat.com>
8605
8606         * common/forward-scope-exit.h
8607         (forward_scope_exit::forward_scope_exit): Pass arguments to
8608         m_bind_function directly, instead of creating a std::bind and
8609         copying that.
8610
8611 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8612
8613         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8614         for static members.
8615         (pass_in_v_vfp_candidate): Likewise.
8616
8617 2019-01-23  Tom Tromey  <tom@tromey.com>
8618             Pedro Alves  <palves@redhat.com>
8619
8620         * regcache.c (class regcache_invalidator): Remove.
8621         (regcache::raw_write): Use make_scope_exit.
8622
8623 2019-01-23  Tom Tromey  <tom@tromey.com>
8624
8625         * ui-out.h (class ui_out_emit_type): Update comment.
8626
8627 2019-01-23  Tom Tromey  <tom@tromey.com>
8628
8629         * infrun.c (fetch_inferior_event): Update comment.
8630
8631 2019-01-23  Tom Tromey  <tom@tromey.com>
8632             Pedro Alves  <palves@redhat.com>
8633
8634         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8635         parameter.
8636         (fetch_inferior_event): Use SCOPE_EXIT.
8637
8638
8639 2019-01-23  Tom Tromey  <tom@tromey.com>
8640             Pedro Alves  <palves@redhat.com>
8641
8642         * infrun.c (disable_thread_events): Delete.
8643         (stop_all_threads): Use SCOPE_EXIT.
8644
8645 2019-01-23  Tom Tromey  <tom@tromey.com>
8646             Pedro Alves  <palves@redhat.com>
8647
8648         * symfile.c: Include forward-scope-exit.h.
8649         (clear_symtab_users_cleanup): Replace forward declaration with
8650         a FORWARD_SCOPE_EXIT.
8651         (syms_from_objfile_1): Use the forward_scope_exit and
8652         gdb::optional instead of cleanup_function.
8653         (reread_symbols): Use the forward_scope_exit instead of
8654         cleanup_function.
8655         (clear_symtab_users_cleanup): Remove function.
8656
8657 2019-01-23  Tom Tromey  <tom@tromey.com>
8658             Pedro Alves  <palves@redhat.com>
8659
8660         * linux-nat.c: Include scope-exit.h.
8661         (cleanup_target_stop): Remove.
8662         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8663         SCOPE_EXIT.
8664
8665 2019-01-23  Tom Tromey  <tom@tromey.com>
8666             Pedro Alves  <palves@redhat.com>
8667
8668         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8669         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8670
8671 2019-01-23  Tom Tromey  <tom@tromey.com>
8672             Andrew Burgess  <andrew.burgess@embecosm.com>
8673             Pedro Alves  <palves@redhat.com>
8674
8675         * infrun.c (fetch_inferior_event): Use scope_exit.
8676         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8677         * top.c (execute_command): Use scope_exit.
8678         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8679         * utils.c (do_bpstat_clear_actions_cleanup)
8680         (make_bpstat_clear_actions_cleanup): Remove.
8681
8682 2019-01-23  Tom Tromey  <tom@tromey.com>
8683             Pedro Alves  <palves@redhat.com>
8684
8685         * infrun.c: Include "common/scope-exit.h"
8686         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8687         (wait_for_inferior): Use SCOPE_EXIT.
8688         (fetch_inferior_event): Use scope_exit.
8689
8690 2019-01-23  Tom Tromey  <tom@tromey.com>
8691             Pedro Alves  <palves@redhat.com>
8692
8693         * breakpoint.c (create_breakpoint): Remove cleanup.
8694
8695 2019-01-23  Tom Tromey  <tom@tromey.com>
8696             Andrew Burgess  <andrew.burgess@embecosm.com>
8697             Pedro Alves  <palves@redhat.com>
8698
8699 2019-01-23  Pedro Alves  <palves@redhat.com>
8700
8701         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8702
8703 2019-01-23  Pedro Alves  <palves@redhat.com>
8704             Andrew Burgess  <andrew.burgess@embecosm.com>
8705
8706         * gdbthread.h: Include "common/forward-scope-exit.h".
8707         (scoped_finish_thread_state): Redefine custom class in terms of
8708         forward_scope_exit.
8709
8710 2019-01-23  Pedro Alves  <palves@redhat.com>
8711             Andrew Burgess  <andrew.burgess@embecosm.com>
8712
8713         * common/forward-scope-exit.h: New file.
8714
8715 2019-01-23  Pedro Alves  <palves@redhat.com>
8716             Andrew Burgess  <andrew.burgess@embecosm.com>
8717             Tom Tromey  <tom@tromey.com>
8718
8719         * common/scope-exit.h: New file.
8720
8721 2019-01-23  Pedro Alves  <palves@redhat.com>
8722
8723         * common/preprocessor.h (ESC): Rename to ...
8724         (ESC_PARENS): ... this.
8725         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8726         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8727
8728 2019-01-23  Tom Tromey  <tom@tromey.com>
8729
8730         * language.h (class scoped_switch_to_sym_language_if_auto):
8731         Initialize m_lang in both cases.
8732
8733 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8734
8735         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8736         with XCNEW.
8737
8738 2019-01-22  Tom Tromey  <tom@tromey.com>
8739
8740         * corelow.c: Do not include sys/file.h.
8741
8742 2019-01-22  Tom Tromey  <tom@tromey.com>
8743
8744         * tui/tui-wingeneral.h: Include gdb_curses.h.
8745
8746 2019-01-22  Tom Tromey  <tom@tromey.com>
8747
8748         * source-cache.h (class source_cache) <get_source_lines,
8749         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8750
8751 2019-01-22  Tom Tromey  <tom@tromey.com>
8752
8753         * remote-fileio.h (struct remote_target): Declare.
8754
8755 2019-01-22  Tom Tromey  <tom@tromey.com>
8756
8757         * python/py-arch.c: Do not include py-ref.h.
8758         * python/py-bpevent.c: Do not include py-ref.h.
8759         * python/py-cmd.c: Do not include py-ref.h.
8760         * python/py-continueevent.c: Do not include py-ref.h.
8761         * python/py-event.h: Do not include py-ref.h.
8762         * python/py-evtregistry.c: Do not include py-ref.h.
8763         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8764         * python/py-frame.c: Do not include py-ref.h.
8765         * python/py-framefilter.c: Do not include py-ref.h.
8766         * python/py-function.c: Do not include py-ref.h.
8767         * python/py-infevents.c: Do not include py-ref.h.
8768         * python/py-linetable.c: Do not include py-ref.h.
8769         * python/py-objfile.c: Do not include py-ref.h.
8770         * python/py-param.c: Do not include py-ref.h.
8771         * python/py-prettyprint.c: Do not include py-ref.h.
8772         * python/py-progspace.c: Do not include py-ref.h.
8773         * python/py-symbol.c: Do not include py-ref.h.
8774         * python/py-symtab.c: Do not include py-ref.h.
8775         * python/py-type.c: Do not include py-ref.h.
8776         * python/py-unwind.c: Do not include py-ref.h.
8777         * python/py-utils.c: Do not include py-ref.h.
8778         * python/py-value.c: Do not include py-ref.h.
8779         * python/py-varobj.c: Do not include py-ref.h.
8780         * python/py-xmethods.c: Do not include py-ref.h.
8781         * python/python.c: Do not include py-ref.h.
8782         * varobj.c: Do not include py-ref.h.
8783
8784 2019-01-22  Tom Tromey  <tom@tromey.com>
8785
8786         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8787         keyword for bcache.
8788
8789 2019-01-22  Tom Tromey  <tom@tromey.com>
8790
8791         * compile/compile-cplus-types.c: Remove a comment by #include.
8792
8793 2019-01-22  Tom Tromey  <tom@tromey.com>
8794
8795         * compile/gcc-c-plugin.h: Include compile-internal.h.
8796
8797 2019-01-22  Tom Tromey  <tom@tromey.com>
8798
8799         * stabsread.c (EXTERN): Do not define.
8800         (symnum, next_symbol_text_func, processing_gcc_compilation)
8801         (within_function, global_sym_chain, global_stabs)
8802         (previous_stab_code, this_object_header_files)
8803         (n_this_object_header_files)
8804         (n_allocated_this_object_header_files): Define.
8805         * stabsread.h (EXTERN): Never define.  Use "extern".
8806
8807 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8808
8809         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8810         history_value.
8811
8812 2019-01-21  Tom Tromey  <tom@tromey.com>
8813
8814         * ui-out.c: Fix includes.
8815         * tui/tui-source.c: Fix includes.
8816         * target.c: Fix includes.
8817         * remote.c: Fix includes.
8818         * regcache.c: Fix includes.
8819         * python/py-block.c: Fix includes.
8820         * printcmd.c: Fix includes.
8821         * or1k-tdep.c: Fix includes.
8822         * mi/mi-main.c: Fix includes.
8823         * m32r-tdep.c: Fix includes.
8824         * csky-tdep.c: Fix includes.
8825         * compile/compile-cplus-types.c: Fix includes.
8826         * cli/cli-interp.c: Fix includes.
8827
8828 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8829
8830         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8831         for padding.
8832
8833 2019-01-16  Tom Tromey  <tom@tromey.com>
8834
8835         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8836         earlier.
8837         (struct objfile) <msymbols_range>: Move from top level.
8838         <msymbols>: New method.
8839         (class objfile_msymbols): Remove.
8840         * symtab.c (default_collect_symbol_completion_matches_break_on):
8841         Update.
8842         * symmisc.c (dump_msymbols): Update.
8843         * stabsread.c (scan_file_globals): Update.
8844         * objc-lang.c (info_selectors_command, info_classes_command)
8845         (find_methods): Update.
8846         * minsyms.c (find_solib_trampoline_target): Update.
8847         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8848         * coffread.c (coff_symfile_read): Update.
8849         * ada-lang.c (ada_lookup_simple_minsym)
8850         (ada_collect_symbol_completion_matches): Update.
8851
8852 2019-01-16  Tom Tromey  <tom@tromey.com>
8853
8854         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8855         type.  Remove no-argument constructor.
8856         <iterator::operator++>: Simplify.
8857         <begin>: Update.
8858         <end>: Use minimal_symbol_count.
8859
8860 2019-01-16  Tom Tromey  <tom@tromey.com>
8861
8862         * objfiles.h (struct objfile) <psymtabs>: New method.
8863         (class objfile_psymtabs): Remove.
8864         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8865         typedef.
8866         <range>: New method.
8867         (require_partial_symbols): Change return type.
8868         * psymtab.c (require_partial_symbols)
8869         (psym_expand_symtabs_matching): Update.
8870         * mdebugread.c (parse_partial_symbols): Update.
8871         * dbxread.c (dbx_end_psymtab): Update.
8872
8873 2019-01-15  Tom Tromey  <tom@tromey.com>
8874
8875         * symtab.c (lookup_objfile_from_block)
8876         (lookup_symbol_in_objfile_symtabs)
8877         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8878         (find_line_symtab, info_sources_command)
8879         (default_collect_symbol_completion_matches_break_on)
8880         (make_source_files_completion_list): Update.
8881         * symmisc.c (print_objfile_statistics, dump_objfile)
8882         (maintenance_print_symbols, maintenance_info_symtabs)
8883         (maintenance_check_symtabs, maintenance_info_line_tables):
8884         Update.
8885         * source.c (select_source_symtab)
8886         (forget_cached_source_info_for_objfile): Update.
8887         * objfiles.h (class objfile_compunits): Remove.
8888         (struct objfile) <compunits_range>: New typedef.
8889         (compunits): New method.
8890         * objfiles.c (objfile_relocate1): Update.
8891         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8892         * maint.c (count_symtabs_and_blocks): Update.
8893         * linespec.c (iterate_over_all_matching_symtabs): Update.
8894         * cp-support.c (add_symbol_overload_list_qualified): Update.
8895         * coffread.c (coff_symtab_read): Update.
8896         * ada-lang.c (add_nonlocal_symbols)
8897         (ada_collect_symbol_completion_matches)
8898         (ada_add_global_exceptions): Update.
8899
8900 2019-01-15  Tom Tromey  <tom@tromey.com>
8901
8902         * progspace.h (program_space) <objfiles_safe_range>: New
8903         typedef.
8904         <objfiles_safe>: New method.
8905         * objfiles.h (class all_objfiles_safe): Remove.
8906         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8907         * jit.c (jit_inferior_exit_hook): Update.
8908
8909 2019-01-17  Tom Tromey  <tom@tromey.com>
8910
8911         * progspace.h (program_space) <objfiles_range>: New typedef.
8912         <objfiles>: New method.
8913         <objfiles_head>: Rename from objfiles.
8914         (object_files): Update.
8915         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8916         * guile/scm-pretty-print.c
8917         (ppscm_find_pretty_printer_from_objfiles): Update.
8918         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8919         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8920         Update.
8921         * python/py-progspace.c (pspy_get_objfiles): Update.
8922         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8923         Update.
8924         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8925         (objfpy_lookup_objfile_by_build_id): Update.
8926         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8927         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8928         Update.
8929         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8930         (expand_symtab_containing_pc, lookup_objfile_from_block)
8931         (lookup_static_symbol, basic_lookup_transparent_type)
8932         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8933         (find_line_symtab, info_sources_command)
8934         (default_collect_symbol_completion_matches_break_on)
8935         (make_source_files_completion_list, find_main_name): Update.
8936         * symmisc.c (print_symbol_bcache_statistics)
8937         (print_objfile_statistics, maintenance_print_symbols)
8938         (maintenance_print_msymbols, maintenance_print_objfiles)
8939         (maintenance_info_symtabs, maintenance_check_symtabs)
8940         (maintenance_expand_symtabs, maintenance_info_line_tables):
8941         Update.
8942         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8943         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8944         (map_overlay_command, unmap_overlay_command)
8945         (simple_overlay_update, expand_symtabs_matching)
8946         (map_symbol_filenames): Update.
8947         * symfile-debug.c (set_debug_symfile): Update.
8948         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8949         Update.
8950         * source.c (select_source_symtab, forget_cached_source_info):
8951         Update.
8952         * solib.c (solib_read_symbols): Update.
8953         * solib-spu.c (append_ocl_sos): Update.
8954         * psymtab.c (maintenance_print_psymbols)
8955         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8956         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8957         * printcmd.c (info_symbol_command): Update.
8958         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8959         Update.
8960         * objfiles.h (class all_objfiles): Remove.
8961         * objfiles.c (have_partial_symbols, have_full_symbols)
8962         (have_minimal_symbols, qsort_cmp, update_section_map)
8963         (shared_objfile_contains_address_p)
8964         (default_iterate_over_objfiles_in_search_order): Update.
8965         * objc-lang.c (info_selectors_command, info_classes_command)
8966         (find_methods): Update.
8967         * minsyms.c (find_solib_trampoline_target): Update.
8968         * maint.c (maintenance_info_sections)
8969         (maintenance_translate_address, count_symtabs_and_blocks):
8970         Update.
8971         * main.c (captured_main_1): Update.
8972         * linux-thread-db.c (try_thread_db_load_from_pdir)
8973         (has_libpthread): Update.
8974         * linespec.c (iterate_over_all_matching_symtabs)
8975         (search_minsyms_for_name): Update.
8976         * jit.c (jit_find_objf_with_entry_addr): Update.
8977         * hppa-tdep.c (find_unwind_entry)
8978         (hppa_lookup_stub_minimal_symbol): Update.
8979         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8980         Update.
8981         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8982         (elf_gnu_ifunc_resolve_by_got): Update.
8983         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8984         * dwarf-index-write.c (save_gdb_index_command): Update.
8985         * cp-support.c (add_symbol_overload_list_qualified): Update.
8986         * breakpoint.c (create_overlay_event_breakpoint)
8987         (create_longjmp_master_breakpoint)
8988         (create_std_terminate_master_breakpoint)
8989         (create_exception_master_breakpoint): Update.
8990         * blockframe.c (find_pc_partial_function): Update.
8991         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8992         (ada_collect_symbol_completion_matches)
8993         (ada_add_global_exceptions): Update.
8994
8995 2019-01-17  Tom Tromey  <tom@tromey.com>
8996
8997         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8998         declare VEC.
8999         (solib_target_parse_libraries): Change return type.
9000         (library_list_start_segment, library_list_start_section)
9001         (library_list_end_library, library_list_start_library); Update.
9002         (solib_target_free_library_list): Remove.
9003         (solib_target_parse_libraries): Remove cleanup.  Change return
9004         type.
9005         (solib_target_current_sos): Update.
9006
9007 2019-01-17  Tom Tromey  <tromey@bapiya>
9008
9009         * valprint.c: Replace "the the" with "the".
9010         * symtab.c: Replace "the the" with "the".
9011         * solib.c: Replace "the the" with "the".
9012         * solib-dsbt.c: Replace "the the" with "the".
9013         * linespec.c: Replace "the the" with "the".
9014         * dwarf2loc.h: Replace "the the" with "the".
9015         * amd64-windows-tdep.c: Replace "the the" with "the".
9016         * aarch64-tdep.c: Replace "the the" with "the".
9017
9018 2019-01-16  Keith Seitz  <keiths@redhat.com>
9019
9020         PR gdb/23773
9021         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9022         <builder>: Rename to ..
9023         <m_builder>: ... this and make private.
9024         (dwarf2_cu::get_builder): New method.  Change all users of
9025         `builder' to use this method.
9026         (dwarf2_start_symtab): Move to ...
9027         (dwarf2_cu::start_symtab): ... here.  Update all callers
9028         (setup_type_unit_groups): Move to ...
9029         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9030         callers.
9031         (dwarf2_cu::reset_builder): New method.
9032         (process_full_compunit, process_full_type_unit): Use
9033         dwarf2_cu::reset_builder.
9034         (follow_die_offset): Record the ancestor CU if it is different
9035         from the followed DIE's CU.
9036         (follow_die_sig_1): Likewise.
9037
9038 2019-01-15  Tom Tromey  <tom@tromey.com>
9039
9040         * remote.c (class remote_state) <buf>: Now a char_vector.
9041         <buf_size>: Remove.
9042         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9043         parameter.
9044         (remote_target::getpkt_or_notif_sane_1)
9045         (remote_target::getpkt_sane)
9046         (remote_target::getpkt_or_notif_sane): Likewise.
9047         (class remote_target) <putpkt>: New overload.
9048         (remote_target::read_frame): Change type of "buf_p".  Remove
9049         sizeof_p parameter.
9050         (packet_ok): New overload.
9051         (packet_check_result): New overload.
9052         Update all uses.
9053
9054 2019-01-14  Tom Tromey  <tom@tromey.com>
9055
9056         * remote-notif.c (handle_notification, remote_notif_ack)
9057         (remote_notif_parse): Make "buf" const.
9058         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9059         const.
9060         (remote_notif_parse, remote_notif_ack, handle_notification):
9061         Likewise.
9062         * remote.c (remote_notif_stop_parse): Make "buf" const.
9063         (remote_target::remote_parse_stop_reply): Make "buf" const.
9064         (remote_notif_stop_ack): Make "buf" const.
9065
9066 2019-01-14  Tom Tromey  <tom@tromey.com>
9067
9068         * remote.c (remote_console_output): Make parameter const.
9069
9070 2019-01-14  Tom Tromey  <tom@tromey.com>
9071
9072         * target-debug.h (target_debug_print_signals): Constify.
9073         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9074         * procfs.c (procfs_target::pass_signals): Update.
9075         * linux-nat.c (linux_nat_target::pass_signals): Update.
9076         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9077         * target-delegates.c: Rebuild.
9078         * remote.c (remote_target::program_signals): Update.
9079         (remote_target::pass_signals): Update.
9080         * target.c (target_pass_signals): Constify argument.
9081         (target_program_signals): Likewise.
9082         * target.h (struct target_ops) <pass_signals, program_signals>:
9083         Constify argument.
9084         (target_pass_signals, target_program_signals): Constify argument.
9085
9086 2019-01-14  Tom Tromey  <tom@tromey.com>
9087
9088         PR tui/28819:
9089         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9090
9091 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9092
9093         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9094         field.
9095         * rs6000-tdep.c: Include reggroups.h.
9096         (IS_V_ALIAS_PSEUDOREG): Define.
9097         (rs6000_register_name): Return names for the "vX" aliases.
9098         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9099         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9100         aliases.  Call default_register_reggroup_p for all other
9101         pseudo-registers.
9102         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9103         New functions.
9104         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9105         Handle "vX" aliases.
9106         (v_alias_pseudo_register_collect): New function.
9107         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9108         (rs6000_gdbarch_init): Initialize "vX" aliases as
9109         pseudo-registers.  Restore registration of
9110         rs6000_pseudo_register_reggroup_p with
9111         set_tdesc_pseudo_register_reggroup_p.
9112
9113 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9114
9115         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9116         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9117         set_gdbarch_num_pseudo_regs.
9118
9119 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9120
9121         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9122         Remove arg prefixname, add do_set and do_show.
9123         Add member functions set_list and show_list.
9124         * cli/cli-style.c (class cli_style_option): Update accordingly.
9125         (style_set_list): Move to file scope.
9126         (style_show_list): Likewise.
9127         (set_style): Call help_list.
9128         (show_style): Call cmd_show_list.
9129         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9130         Update to use the new macro.
9131
9132 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9133
9134         * ada-lang.c (_initialize_ada_language): Expand the help text
9135         for the "catch exception" command.
9136
9137 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9138
9139         * symtab.c (matching_obj_sections): Initialize obj,
9140         declare it closer to its usage.
9141
9142 2019-01-10  Tom Tromey  <tom@tromey.com>
9143
9144         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9145         (basic_inf_threads_range): Remove.
9146         (inf_threads_range, inf_non_exited_threads_range)
9147         (safe_inf_threads_range): Use next_adapter.
9148
9149 2019-01-10  Keith Seitz  <keiths@redhat.com>
9150
9151         PR gdb/23712
9152         PR symtab/23010
9153         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9154         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9155
9156 2019-01-10  Keith Seitz  <keiths@redhat.com>
9157
9158         PR gdb/23712
9159         PR symtab/23010
9160         * dictionary.c (pending_to_vector): Remove.
9161         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9162         Remove _1 suffix, replacing functions of the same name.  Update
9163         all callers.
9164         (dict_create_hashed, dict_create_hashed_expandable)
9165         (dict_create_linear, dict_create_linear_expandable, dict_free)
9166         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9167         Make functions static.
9168
9169 2019-01-10  Keith Seitz  <keiths@redhat.com>
9170
9171         PR gdb/23712
9172         PR symtab/23010
9173         * dictionary.h (struct dictionary): Replace declaration with
9174         multidictionary.
9175         (dict_create_hashed, dict_create_hashed_expandable)
9176         (dict_create_linear, dict_create_linear_expandable)
9177         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9178         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9179         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9180         taking multidictionary argument.
9181         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9182         * block.h (struct block) <dict>: Change to multidictionary
9183         and rename `multidict'.
9184         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9185         symmisc.c: Update all dictionary references to multidictionary.
9186
9187 2019-01-10  Keith Seitz  <keiths@redhat.com>
9188
9189         PR gdb/23712
9190         PR symtab/23010
9191         * dictionary.c: Include unordered_map.
9192         (pending_to_vector): New function.
9193         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9194         Rewrite the non-"_1" functions to take vector instead
9195         of linked list.
9196         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9197         "new" _1 versions of the same name.
9198         (multidictionary): Define.
9199         (std::hash<enum language): New definition.
9200         (collate_pending_symbols_by_language, mdict_create_hashed)
9201         (mdict_create_hashed_expandable, mdict_create_linear)
9202         (mdict_create_linear_expandable, mdict_free)
9203         (find_language_dictionary, create_new_language_dictionary)
9204         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9205         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9206         (mdict_size, mdict_empty): New functions.
9207         * dictionary.h (mdict_iterator): Define.
9208
9209 2019-01-10  Pedro Alves  <palves@redhat.com>
9210
9211         * breakpoint.c (read_uploaded_action)
9212         (create_tracepoint_from_upload): Adjust to use
9213         gdb::unique_xmalloc_ptr.
9214         * ctf.c (ctf_write_uploaded_tp):
9215         (SET_ARRAY_FIELD): Use emplace_back.
9216         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9217         * tracefile-tfile.c (tfile_write_uploaded_tp):
9218         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9219         gdb::unique_xmalloc_ptr.
9220         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9221         at_string, cond_string, cmd_strings>: Replace char pointers
9222         with gdb::unique_xmalloc_ptr.
9223
9224 2019-01-10  Pedro Alves  <palves@redhat.com>
9225
9226         * solib-target.c (library_list_start_library): Don't xstrdup name.
9227
9228 2019-01-10  Pedro Alves  <palves@redhat.com>
9229
9230         * mdebugread.c (parse_partial_symbols): Use
9231         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9232
9233 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9234
9235         * linux-fork.c (scoped_switch_fork_info)
9236         <~scoped_switch_fork_info>: Fix incorrect variable name.
9237
9238 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9239
9240         * linux-fork.c (scoped_switch_fork_info)
9241         <scoped_switch_fork_info>: Make explicit.
9242         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9243
9244 2019-01-10  Tom Tromey  <tom@tromey.com>
9245
9246         * objfiles.h (objfile::reset_psymtabs): Update.
9247         * objfiles.c (objfile::objfile): Update.
9248         * psymtab.h (psymtab_storage::obstack): Update.
9249         (psymtab_storage::m_obstack): Use gdb::optional.
9250         (class psymtab_storage): Update comment.  Remove objfile
9251         parameter.
9252         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9253
9254 2019-01-10  Tom Tromey  <tom@tromey.com>
9255
9256         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9257         <free_psymtabs>: Now private.
9258         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9259         (allocate_psymtab): Use new method.
9260
9261 2019-01-10  Tom Tromey  <tom@tromey.com>
9262
9263         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9264         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9265         * mdebugread.c (parse_partial_symbols): Use
9266         allocate_dependencies.
9267         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9268         allocate_dependencies.
9269         (process_psymtab_comp_unit_reader)
9270         (build_type_psymtab_dependencies): Likewise.
9271         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9272
9273 2019-01-10  Tom Tromey  <tom@tromey.com>
9274
9275         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9276         PSYMBOL_SET_LANGUAGE.
9277         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9278
9279 2019-01-10  Tom Tromey  <tom@tromey.com>
9280
9281         * psymtab.h (psymtab_storage::obstack): New method.
9282         <m_obstack>: Rename from obstack; now private.
9283         * psymtab.c (psymtab_storage): Update.
9284         * dwarf2read.c (create_addrmap_from_index)
9285         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9286         Update.
9287
9288 2019-01-10  Tom Tromey  <tom@tromey.com>
9289
9290         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9291         * objfiles.h (objfile::reset_psymtabs): New method.
9292
9293 2019-01-10  Tom Tromey  <tom@tromey.com>
9294
9295         * symmisc.c (print_symbol_bcache_statistics): Update.
9296         (print_objfile_statistics): Update.
9297         * symfile.c (reread_symbols): Update.
9298         * psymtab.h (class psymtab_storage): New.
9299         * psymtab.c (psymtab_storage): New constructor.
9300         (~psymtab_storage): New destructor.
9301         (require_partial_symbols): Update.
9302         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9303         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9304         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9305         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9306         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9307         (start_psymtab_common, end_psymtab_common)
9308         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9309         (allocate_psymtab): Update.
9310         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9311         Update.
9312         (dump_psymtab_addrmap, maintenance_print_psymbols)
9313         (maintenance_check_psymtabs): Update.
9314         (class objfile_psymtabs): Move to objfiles.h.
9315         * psympriv.h (discard_psymtab): Now inline.
9316         (psymtab_discarder::psymtab_discarder): Update.
9317         (psymtab_discarder::~psymtab_discarder): Update.
9318         (ALL_OBJFILE_PSYMTABS): Rewrite.
9319         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9320         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9321         Remove fields.
9322         <partial_symtabs>: New field.
9323         (class objfile_psymtabs): Move from psymtab.h.  Update.
9324         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9325         psymbol_cache.
9326         (objfile::~objfile): Don't destroy psymbol_cache.
9327         * mdebugread.c (parse_partial_symbols): Update.
9328         * dwarf2read.c (create_addrmap_from_index)
9329         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9330         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9331         (add_partial_subprogram, dwarf2_ranges_read): Update.
9332         * dwarf-index-write.c (write_address_map)
9333         (write_one_signatured_type, recursively_write_psymbols)
9334         (class debug_names, class debug_names, write_psymtabs_to_index):
9335         Update.
9336
9337 2019-01-10  Tom Tromey  <tom@tromey.com>
9338
9339         * symtab.h (SYMBOL_SET_NAMES): Update.
9340         (symbol_set_names): Update.
9341         (MSYMBOL_SET_NAMES): Update.
9342         * symtab.c (symbol_set_names): Change argument to be an
9343         objfile_per_bfd_storage.
9344         * psymtab.c (add_psymbol_to_bcache): Update.
9345         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9346
9347 2019-01-10  Tom Tromey  <tom@tromey.com>
9348
9349         * symtab.c (create_demangled_names_hash): Change argument to be an
9350         objfile_per_bfd_storage.
9351         (symbol_set_names): Update.
9352
9353 2019-01-10  Tom Tromey  <tom@tromey.com>
9354
9355         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9356         init_psymbol_list.
9357         * psymtab.c (init_psymbol_list): Do nothing if already called.
9358         * psympriv.h (init_psymbol_list): Add comment.
9359         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9360         init_psymbol_list.
9361         * dbxread.c (dbx_symfile_read): Unconditionally call
9362         init_psymbol_list.
9363
9364 2019-01-10  Tom Tromey  <tom@tromey.com>
9365
9366         * xcoffread.c (scan_xcoff_symtab): Update.
9367         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9368         "where".
9369         * mdebugread.c (parse_partial_symbols)
9370         (handle_psymbol_enumerators): Update.
9371         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9372         * dbxread.c (read_dbx_symtab): Update.
9373         * psympriv.h (psymbol_placement): New enum.
9374         (add_psymbol_to_list): Update.
9375
9376 2019-01-10  Tom Tromey  <tom@tromey.com>
9377
9378         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9379         static_psymbols parameters.
9380         (scan_xcoff_symtab): Update.
9381         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9382         static_psymbols parameters.
9383         * psympriv.h (start_psymtab_common): Update.
9384         * mdebugread.c (parse_partial_symbols): Update.
9385         * dwarf2read.c (create_partial_symtab): Update.
9386         * dbxread.c (read_dbx_symtab): Update.
9387         (start_psymtab): Remove global_psymbols and static_psymbols
9388         parameters.
9389
9390 2019-01-10  Tom Tromey  <tom@tromey.com>
9391
9392         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9393         * psymtab.c (allocate_psymtab): Add comment.
9394         * psympriv.h (allocate_psymtab): Add comment.
9395         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9396         initializations.
9397         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9398
9399 2019-01-10  Tom Tromey  <tom@tromey.com>
9400
9401         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9402         Don't declare.
9403         * mipsread.c: Include mdebugread.h.
9404         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9405         Declare.
9406         * elfread.c: Include mdebugread.h.
9407
9408 2019-01-09  Tom Tromey  <tom@tromey.com>
9409
9410         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9411         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9412         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9413         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9414         (psym_lookup_symbol, psym_find_last_source_symtab)
9415         (psym_forget_cached_source_info, psym_print_stats)
9416         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9417         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9418         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9419         (psym_find_compunit_symtab_by_address)
9420         (maintenance_print_psymbols, maintenance_info_psymtabs)
9421         (maintenance_check_psymtabs): Use ranged for.
9422         * psymtab.h (class objfile_psymtabs): New.
9423         (require_partial_symbols): Return objfile_psymtabs.
9424         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9425
9426 2019-01-09  Tom Tromey  <tom@tromey.com>
9427
9428         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9429         (find_pc_mapped_section, list_overlays_command)
9430         (map_overlay_command, unmap_overlay_command)
9431         (simple_overlay_update): Use all_objfiles.
9432         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9433         * printcmd.c (info_symbol_command): Use all_objfiles.
9434         * objfiles.h (ALL_OBJSECTIONS): Remove.
9435         * maint.c (maintenance_translate_address): Use all_objfiles.
9436         * gcore.c (gcore_create_callback): Use all_objfiles.
9437         (objfile_find_memory_regions): Likewise.
9438
9439 2019-01-09  Tom Tromey  <tom@tromey.com>
9440
9441         * symtab.c (find_line_symtab, info_sources_command)
9442         (make_source_files_completion_list): Use objfile_compunits.
9443         * source.c (select_source_symtab): Use objfile_compunits.
9444         * objfiles.h (struct objfile): Update comment.
9445         (ALL_OBJFILES): Remove.
9446         (ALL_FILETABS): Remove.
9447         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9448         objfile_compunits.
9449
9450 2019-01-09  Tom Tromey  <tom@tromey.com>
9451
9452         * symmisc.c (print_objfile_statistics, dump_objfile)
9453         (maintenance_print_symbols): Use compunit_filetabs.
9454         * source.c (forget_cached_source_info_for_objfile): Use
9455         compunit_filetabs.
9456         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9457         (ALL_FILETABS): Use compunit_filetabs.
9458         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9459         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9460
9461 2019-01-09  Tom Tromey  <tom@tromey.com>
9462
9463         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9464         (compunit_filetabs): New.
9465         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9466         compunit_filetabs.
9467         (info_sources_command, make_source_files_completion_list): Remove
9468         declaration.
9469         * symmisc.c (print_objfile_statistics, dump_objfile)
9470         (maintenance_print_symbols): Remove declaration.
9471         (maintenance_info_symtabs): Use compunit_filetabs.
9472         (maintenance_info_line_tables): Likewise.
9473         * source.c (select_source_symtab): Change local variable name.
9474         (forget_cached_source_info_for_objfile): Remove declaration.
9475         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9476         * objfiles.c (objfile_relocate1): Remove declaration.
9477         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9478         declaration.
9479         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9480         * coffread.c (coff_symtab_read): Remove declaration.
9481         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9482         compunit_filetabs.
9483
9484 2019-01-09  Tom Tromey  <tom@tromey.com>
9485
9486         * symtab.c (lookup_objfile_from_block)
9487         (find_pc_sect_compunit_symtab, search_symbols)
9488         (default_collect_symbol_completion_matches_break_on): Use
9489         objfile_compunits.
9490         * objfiles.h (ALL_COMPUNITS): Remove.
9491         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9492         * cp-support.c (add_symbol_overload_list_qualified): Use
9493         objfile_compunits.
9494         * ada-lang.c (ada_collect_symbol_completion_matches)
9495         (ada_add_global_exceptions): Use objfile_compunits.
9496
9497 2019-01-09  Tom Tromey  <tom@tromey.com>
9498
9499         * source.c (select_source_symtab)
9500         (forget_cached_source_info_for_objfile): Remove declaration.
9501         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9502         declaration.
9503         * maint.c (count_symtabs_and_blocks): Remove declaration.
9504         * cp-support.c (add_symbol_overload_list_qualified): Remove
9505         declaration.
9506         * coffread.c (coff_symtab_read): Remove declaration.
9507         * symtab.c (lookup_symbol_in_objfile_symtabs)
9508         (basic_lookup_transparent_type_1): Use objfile_compunits.
9509         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9510         (info_sources_command, search_symbols)
9511         (default_collect_symbol_completion_matches_break_on)
9512         (make_source_files_completion_list): Remove declaration.
9513         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9514         (ada_collect_symbol_completion_matches)
9515         (ada_add_global_exceptions): Remove declaration.
9516         * linespec.c (iterate_over_all_matching_symtabs): Use
9517         objfile_compunits.
9518         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9519         (class objfile_compunits): New.
9520         (ALL_COMPUNITS): Use objfile_compunits.
9521         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9522         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9523         objfile_compunits.
9524         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9525
9526 2019-01-09  Tom Tromey  <tom@tromey.com>
9527
9528         * symtab.c (search_symbols)
9529         (default_collect_symbol_completion_matches_break_on): Use
9530         objfile_msymbols.
9531         * ada-lang.c (ada_lookup_simple_minsym)
9532         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9533         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9534         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9535         objfile_msymbols.
9536         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9537         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9538         * objc-lang.c (find_methods): Use objfile_msymbols.
9539         (info_selectors_command, info_classes_command): Likewise.
9540         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9541         * objfiles.h (class objfile_msymbols): New.
9542         (ALL_OBJFILE_MSYMBOLS): Remove.
9543         (ALL_MSYMBOLS): Remove.
9544
9545 2019-01-09  Tom Tromey  <tom@tromey.com>
9546
9547         * common/next-iterator.h (next_adapter): Add Iterator template
9548         parameter.
9549         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9550         (class all_objfiles_safe): New.
9551         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9552         * objfiles.c (put_objfile_before): Update comment.
9553         (add_separate_debug_objfile): Likewise.
9554         (free_all_objfiles): Use all_objfiles_safe.
9555         (objfile_purge_solibs): Likewise.
9556
9557 2019-01-09  Tom Tromey  <tom@tromey.com>
9558
9559         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9560         (expand_symtab_containing_pc, lookup_static_symbol)
9561         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9562         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9563         all_objfiles.
9564         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9565         * breakpoint.c (create_overlay_event_breakpoint)
9566         (create_longjmp_master_breakpoint)
9567         (create_std_terminate_master_breakpoint)
9568         (create_exception_master_breakpoint): Use all_objfiles.
9569         * linux-thread-db.c (try_thread_db_load_from_pdir)
9570         (has_libpthread): Use all_objfiles.
9571         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9572         * linespec.c (iterate_over_all_matching_symtabs)
9573         (search_minsyms_for_name): Use all_objfiles.
9574         * maint.c (maintenance_info_sections): Use all_objfiles.
9575         * main.c (captured_main_1): Use all_objfiles.
9576         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9577         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9578         * guile/scm-pretty-print.c
9579         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9580         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9581         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9582         (maintenance_print_msymbols): Use all_objfiles.
9583         * source.c (select_source_symtab): Use all_objfiles.
9584         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9585         * symfile.c (remove_symbol_file_command)
9586         (expand_symtabs_matching, map_symbol_filenames): Use
9587         all_objfiles.
9588         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9589         all_objfiles.
9590         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9591         * objc-lang.c (find_methods): Use all_objfiles.
9592         * objfiles.c (have_partial_symbols, have_full_symbols)
9593         (have_minimal_symbols, qsort_cmp)
9594         (default_iterate_over_objfiles_in_search_order): Use
9595         all_objfiles.
9596         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9597         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9598         (maintenance_check_psymtabs): Use all_objfiles.
9599         (ALL_PSYMTABS): Remove.
9600         * compile/compile-object-run.c (do_module_cleanup): Use
9601         all_objfiles.
9602         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9603         * cp-support.c (add_symbol_overload_list_qualified): Use
9604         all_objfiles.
9605         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9606         Use all_objfiles.
9607         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9608         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9609         all_objfiles.
9610         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9611         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9612         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9613         Uses all_objfiles.
9614         * solib.c (solib_read_symbols): Use all_objfiles
9615
9616 2019-01-09  Tom Tromey  <tom@tromey.com>
9617
9618         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9619         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9620         all_objfiles.
9621         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9622         * symmisc.c (print_symbol_bcache_statistics)
9623         (print_objfile_statistics, maintenance_print_objfiles)
9624         (maintenance_info_symtabs, maintenance_check_symtabs)
9625         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9626         all_objfiles.
9627         * source.c (forget_cached_source_info): Use all_objfiles.
9628         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9629         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9630         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9631         * objfiles.c (update_section_map): Use all_objfiles.
9632         (shared_objfile_contains_address_p): Likewise.
9633         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9634         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9635
9636 2019-01-09  Tom Tromey  <tom@tromey.com>
9637
9638         * common/next-iterator.h: New file.
9639         * objfiles.h (class all_objfiles): New.
9640         (struct objfile_iterator): New.
9641
9642 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9643
9644         * NEWS: Move the description of the changed "frame", "select-frame",
9645          and "info frame" commands to the Changed commands section.
9646
9647 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9648
9649         * gdbtypes.c (check_stub_method_group): Remove handling of old
9650         mangling schemes.
9651         * linespec.c (find_methods): Likewise.
9652         * stabsread.c (read_member_functions): Likewise.
9653         * valops.c (search_struct_method): Likewise.
9654         (value_struct_elt_for_reference): Likewise.
9655         * NEWS: Mention this change.
9656
9657 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9658
9659         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9660         print_source_lines.
9661         * source.c (print_source_lines_base): Update line number check.
9662         (print_source_lines): New function.
9663         (source_lines_range::source_lines_range): New function.
9664         * source.h (class source_lines_range): New class.
9665         (print_source_lines): New declaration.
9666
9667 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9668
9669         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9670
9671 2019-01-08  Tom Tromey  <tom@tromey.com>
9672             Simon Marchi  <simon.marchi@ericsson.com>
9673
9674         PR gdb/24060
9675         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9676         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9677         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9678         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9679         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9680         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9681
9682 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9683
9684         * source.c (select_source_symtab): Move header comment to
9685         declaration in source.h.
9686         (forget_cached_source_info_for_objfile): Likewise.
9687         (forget_cached_source_info): Likewise.
9688         (identify_source_line): Likewise.
9689         * source.h (identify_source_line): Move declaration from symtab.h
9690         and add comment from source.c
9691         (print_source_lines): Likewise.
9692         (forget_cached_source_info_for_objfile): Likewise.
9693         (forget_cached_source_info): Likewise.
9694         (select_source_symtab): Likewise.
9695         (enum print_source_lines_flag): Move definition from symtab.h.
9696         * symtab.h (identify_source_line): Move declaration to source.h.
9697         (print_source_lines): Likewise.
9698         (forget_cached_source_info_for_objfile): Likewise.
9699         (forget_cached_source_info): Likewise.
9700         (select_source_symtab): Likewise.
9701         (enum print_source_lines_flag): Move definition to source.h.
9702         * tui/tui-hooks.c: Add 'source.h' include.
9703
9704 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9705
9706         * source.c (print_source_lines_base): Handle requests to print
9707         reverse line number sequences, and guard against empty lines
9708         string.
9709
9710 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9711
9712         * source.c (print_source_lines_base): Fix skip of '\r' if next
9713         character is '\n'.
9714
9715 2019-01-06  Tom Tromey  <tom@tromey.com>
9716
9717         * c-exp.y (struct c_parse_state) <macro_original_text,
9718         expansion_obstack>: New member.
9719         (macro_original_text, expansion_obstack): Remove globals.
9720         (scan_macro_expansion, scanning_macro_expansion)
9721         (finished_macro_expansion): Update.
9722         (scan_macro_cleanup): Remove.
9723         (yylex, c_parse): Update.
9724
9725 2019-01-06  Tom Tromey  <tom@tromey.com>
9726
9727         * c-exp.y (struct c_parse_state) <strings>: New member.
9728         (operator_stoken): Update.
9729
9730 2019-01-06  Tom Tromey  <tom@tromey.com>
9731
9732         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9733         (union type_stack_elt) <typelist_val>: Now a pointer to
9734         std::vector.
9735         (type_stack_cleanup): Don't declare.
9736         (push_typelist): Update.
9737         * parse.c (pop_typelist): Return a std::vector.
9738         (push_typelist): Take a std::vector.
9739         (follow_types): Update.  Do not free args.
9740         (type_stack_cleanup): Remove.
9741         * c-exp.y (struct c_parse_state): New.
9742         (cpstate): New global.
9743         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9744         (nonempty_typelist): Update.
9745         (func_mod): Create a new vector.
9746         (c_parse): Create a c_parse_state.
9747         (check_parameter_typelist): Do not delete params.
9748         (function_method): Update.  Do not delete type_list.
9749
9750 2019-01-06  Tom Tromey  <tom@tromey.com>
9751
9752         PR gdb/28155:
9753         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9754         check_typedef.
9755         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9756         (print_return_value): Likewise.
9757
9758 2019-01-05  Tom Tromey  <tom@tromey.com>
9759
9760         * contrib/cleanup_check.py: Remove.
9761         * contrib/gcc-with-excheck: Remove.
9762         * contrib/exsummary.py: Remove.
9763         * contrib/excheck.py: Remove.
9764
9765 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9766
9767         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9768         NULL. Initialize tpprev to NULL instead of assigning it
9769         to NULL on the next statement.
9770         * windows-nat.c (windows_delete_thread): Remove check for
9771         main_thread_id before printing thread exit notifications.
9772         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9773         Remove thread ID check against main_thread_id.
9774         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9775         windows_delete_thread.
9776         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9777
9778 2019-01-04  Tom Tromey  <tom@tromey.com>
9779
9780         * compile/compile.c (_initialize_compile): Use upper case for
9781         metasyntactic variables.
9782         * symmisc.c (_initialize_symmisc): Use upper case for
9783         metasyntactic variables.
9784         * psymtab.c (_initialize_psymtab): Use upper case for
9785         metasyntactic variables.
9786         * demangle.c (demangle_command): Use upper case for metasyntactic
9787         variables.
9788         (_initialize_demangler): Likewise.
9789         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9790         variables.
9791
9792 2019-01-03  Tom Tromey  <tom@tromey.com>
9793
9794         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9795
9796 2019-01-03  Tom Tromey  <tom@tromey.com>
9797
9798         * python/py-symtab.c (salpy_str): Update.
9799         (struct salpy_sal_object) <symtab>: Now a PyObject.
9800         (salpy_dealloc): Update.
9801         (del_objfile_sal): Use gdbpy_ref.
9802
9803 2019-01-03  Tom Tromey  <tom@tromey.com>
9804
9805         * python/py-type.c (convert_field): Use new_reference.  Return
9806         gdbpy_ref.
9807         (make_fielditem): Return gdbpy_ref.
9808         (typy_fields): Update.
9809         (typy_getitem): Update.
9810         (field_name): Return gdbpy_ref.  Use new_reference.
9811         (typy_iterator_iternext): Update.
9812
9813 2019-01-03  Tom Tromey  <tom@tromey.com>
9814
9815         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9816
9817 2019-01-03  Tom Tromey  <tom@tromey.com>
9818
9819         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9820         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9821         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9822         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9823         (pspy_set_type_printers): Likewise.
9824         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9825         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9826         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9827         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9828         (objfpy_set_type_printers): Likewise.
9829
9830 2019-01-03  Tom Tromey  <tom@tromey.com>
9831
9832         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9833         (gdbpy_print_stack): Use gdbpy_err_fetch.
9834         * python/python-internal.h (class gdbpy_err_fetch): New class.
9835         (class gdbpy_enter) <m_error_type, m_error_value,
9836         m_error_traceback>: Remove.
9837         <m_error>: New member.
9838         (gdbpy_exception_to_string): Don't declare.
9839         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9840         * python/py-value.c (convert_value_from_python): Use
9841         gdbpy_err_fetch.
9842         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9843         gdbpy_exception_to_string.
9844         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9845         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9846         gdbpy_err_fetch.
9847
9848 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9849
9850         * linux-nat.c (delete_lwp_cleanup): Delete.
9851         (struct lwp_deleter): New struct.
9852         (lwp_info_up): New typedef.
9853         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9854         lwp_info_up.
9855
9856 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9857
9858         * linux-fork.c (class scoped_switch_fork_info): New class.
9859         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9860
9861 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9862
9863         * valops.c (find_overload_match): Remove use of null_cleanup, and
9864         calls to do_cleanups.
9865
9866 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9867
9868         * compile/compile-cplus-types.c
9869         (compile_cplus_instance::decl_name): Handle changes to
9870         cp_func_name.
9871         * cp-support.c (cp_func_name): Update header comment, update
9872         return type.
9873         * cp-support.h (cp_func_name): Update return type in declaration.
9874         * valops.c (find_overload_match): Move temp_func local to top
9875         level of function and change its type.  Use temp_func to hold and
9876         delete temporary string obtained from cp_func_name.
9877
9878 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9879
9880         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9881         gdb::char_vector, remove cleanup, and update uses of `msg`.
9882
9883 2019-01-03  Jim Wilson  <jimw@sifive.com>
9884
9885         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9886
9887 2019-01-02  Tom Tromey  <tom@tromey.com>
9888
9889         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9890         (tdesc_parse_xml): Remove cleanups.
9891         * target-descriptions.h (make_cleanup_free_target_description):
9892         Don't declare.
9893         (target_desc_deleter): New struct.
9894         (target_desc_up): New typedef.
9895         * target-descriptions.c (target_desc_deleter::operator()): Rename
9896         from free_target_description.
9897         (make_cleanup_free_target_description): Remove.
9898
9899 2019-01-02  Tom Tromey  <tom@tromey.com>
9900
9901         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9902         constructor, destructor.
9903         (linespec_parser): Remove typedef.
9904         (~linespec_parser): Rename from linespec_parser_delete.
9905         (linespec_lex_to_end, linespec_complete_label)
9906         (linespec_complete): Update.
9907         (decode_line_full): Remove cleanups.
9908         (decode_line_1): Update.
9909
9910 2019-01-02  Tom Tromey  <tom@tromey.com>
9911
9912         * python/python-internal.h (inferior_to_inferior_object): Change
9913         return type.
9914         * python/py-exitedevent.c (create_exited_event_object): Update.
9915         * python/py-inferior.c (inferior_to_inferior_object): Return
9916         gdbpy_ref.
9917         (python_new_inferior, python_inferior_deleted)
9918         (thread_to_thread_object, delete_thread_object)
9919         (build_inferior_list, gdbpy_selected_inferior): Update.
9920         * python/py-infthread.c (create_thread_object): Update.  Also fail
9921         if inferior_to_inferior_object fails.
9922
9923 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9924
9925         * inferior.h (class inferior) <displaced_step_state>: New field.
9926         * infrun.h (struct displaced_step_state): Move here from
9927         infrun.c.  Initialize fields, add constructor.
9928         <inf>: Remove field.
9929         <reset>: New method.
9930         * infrun.c (struct displaced_step_inferior_state): Move to
9931         infrun.h.
9932         (displaced_step_inferior_states): Remove.
9933         (get_displaced_stepping_state): Adust.
9934         (displaced_step_in_progress_any_inferior): Adjust.
9935         (displaced_step_in_progress_thread): Adjust.
9936         (displaced_step_in_progress): Adjust.
9937         (add_displaced_stepping_state): Remove.
9938         (get_displaced_step_closure_by_addr): Adjust.
9939         (remove_displaced_stepping_state): Remove.
9940         (infrun_inferior_exit): Call displaced_step_state.reset.
9941         (use_displaced_stepping): Don't check for NULL.
9942         (displaced_step_prepare_throw): Call
9943         get_displaced_stepping_state.
9944         (displaced_step_fixup): Don't check for NULL.
9945         (prepare_for_detach): Don't check for NULL.
9946
9947 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9948
9949         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9950          in case of call that did not complete.
9951
9952 2019-01-02  Andrey Utkin  <autkin@undo.io>
9953
9954         * symfile.c (find_separate_debug_file): Fix search of debug files for
9955         remote debuggee.
9956
9957 2019-01-02  Tom Tromey  <tom@tromey.com>
9958
9959         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9960         indentation.
9961         * python/py-frame.c (frapy_older): Remove cast.
9962         (frapy_newer): Likewise.
9963         * python/py-breakpoint.c (local_setattro): Remove cast.
9964         * python/py-arch.c (archpy_name): Remove local variable.
9965         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9966
9967 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9968
9969         * unittests/basic_string_view/element_access/char/empty.cc:
9970         Fix year range in copyright header.
9971
9972 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9973
9974         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9975         Delete.
9976         <operator==>: Update with for removed field.
9977         <hash>: Likewise.
9978         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9979         <isa_features>: ...this.
9980         <abi_features>: New field.
9981         (riscv_isa_flen): Update comment.
9982         (riscv_abi_xlen): New declaration.
9983         (riscv_abi_flen): New declaration.
9984         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9985         isa_features.
9986         (riscv_abi_xlen): New function.
9987         (riscv_isa_flen): Update to get answer from isa_features.
9988         (riscv_abi_flen): New function.
9989         (riscv_has_fp_abi): Update to get answer from abi_features.
9990         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9991         xlen and flen.
9992         (riscv_call_info) <xlen, flen>: Update comment.
9993         (riscv_call_arg_struct): Remove invalid assertions
9994         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9995         is removed.
9996         (riscv_gdbarch_init): Gather isa features and abi features
9997         separately, ensure both match on the gdbarch when reusing an old
9998         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9999         a target with 64-bit float hardware.
10000
10001 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10002
10003         * source.c (search_command_helper): Stop reverse search
10004         when line 1 has been searched.
10005
10006 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10007
10008         * record-full.c (record_full_base_target::close): Rewrite
10009         record_full_core_buf_list free logic.
10010
10011 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10012
10013         * break-catch-syscall.c (print_one_catch_syscall): xfree
10014         the last text.
10015
10016 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10017
10018         * top.c (print_gdb_version): Update Copyright year in version
10019         message.
10020
10021 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10022
10023         Update copyright year range in all GDB files.
10024
10025 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10026
10027         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10028
10029 For older changes see ChangeLog-2018.
10030 \f
10031 Local Variables:
10032 mode: change-log
10033 left-margin: 8
10034 fill-column: 74
10035 version-control: never
10036 coding: utf-8
10037 End:
10038