* irix5-nat.c (string.h): Include near beginning of file.
[deliverable/binutils-gdb.git] / gdb / ChangeLog
1 Sun Feb 12 13:47:30 1995 Stan Shebs <shebs@andros.cygnus.com>
2
3 * irix5-nat.c (string.h): Include near beginning of file.
4
5 Sun Feb 12 12:36:38 1995 Jim Kingdon (kingdon@lioth.cygnus.com)
6
7 * valops.c (value_arg_coerce): Use VALUE_TYPE not SYMBOL_TYPE on
8 arg, it is a value not a symbol.
9
10 gcc -Wall lint:
11 * eval.c: Move declaration of evaluate_subexp_with_coercion from here..
12 * expression.h: ..to here.
13 * expression.h: Include value.h.
14 * ch-lang.c (evaluate_subexp_chill): Add default case in switch.
15
16 Sun Feb 12 11:03:47 1995 Per Bothner <bothner@kalessin.cygnus.com>
17
18 * language.h (struct language_defn): New field evaluate_exp.
19 * c-lang.c (c_language_defn, cplus_language_defn, asm_langauge_defn),
20 f-lang.c (f_language_defn), language.c (unknown_language_defn,
21 auto_language_defn, local_language_defn), m2-lang.c (m2_language_defn):
22 Set evaluate_exp to evaluate_subexp_standard.
23 * ch-lang.c (evaluate_subexp_chill): New function. Chill-specific
24 support for MULTI_SUBSCRIPT.
25 (chill_language_defn): Set evaluate_exp to evaluate_subexp_chill.
26 * eval.c (enum noside): Move from here ....
27 * expression.h (enum noside): ... to here.
28 (evaluate_subexp_standard): New prototype.
29 * eval.c (evaluate_subexp): Renamed to evaluate_subexp_standard.
30 Removed lo-longer-needed test for chill_varying_type.
31 (evaluate_subexp): New. Calls exp->language_defn->evaluate_exp.
32
33 * ch-exp.y (maybe_expression_list): New non-terminal.
34 (primitive_value): Allow empty parameter list.
35
36 Sun Feb 12 10:02:16 1995 Per Bothner <bothner@cygnus.com>
37
38 * buildsym.c (finish_block): If finishing a function without known
39 parameter type info, set that from parameter symbols.
40 * c-typeprint.c (c_type_print_varspec_suffix): For TYPE_CODE_FUNC,
41 print parameter types, if available.
42 * ch-typeprint.c (chill_type_print_base): Likewise.
43
44 * gdbtypes.h (struct type): Remove function type field.
45 (TYPE_FUNCTION_TYPE): Remove macro. We can't as simply re-use
46 function types now that we're also storing parameter types.
47 And the payoff is much less.
48 * gdbtypes.c (make_function_type): Don't use/set TYPE_FUNCTION_TYPE.
49 (recursive_dump_type): Don't print TYPE_FUNCTION_TYPE.
50 * dwarfread.c (read_subroutine_type): Don't set TYPE_FUNCTION_TYPE.
51
52 * valops.c (value_arg_coerce): Now takes param_type argument.
53 (call_function_by_hand): Convert arguments with value_arg_coerce
54 early, and overwrite original args with converted args.
55 No longer need multiple calls to value_arg_coerce.
56 (value_arg_push): Removed.
57 * hppa-tdep.c (hppa_push_arguments): No longer call value_arg_coerce.
58 * mips-tdep.c (mips_push_arguments): Likewise.
59 * alpha-tdep.c (alpha_push_arguments): Likewise.
60 * rs6000-tdep.c (push_arguments, ran_out_of_registers_for_arguments):
61 Likewise.
62 * value.h (value_arg_coerce): Remove declaration. (It's now static.)
63
64 * valops.c (value_cast): Do COERCE_VARYING_ARRAY after COERCE_REF.
65
66 * symtab.c (add_param_to_type): Remove (commented-out) function,
67 since that functionality has been re-written.
68 * coffread.c: Remove commented-out add_param_to_type support.
69 * mdebugread.c (parse_symbol): Likewise.
70 * stabsread.c (define_symbol): Likewise.
71
72 Sun Feb 12 09:03:47 1995 Jim Kingdon (kingdon@lioth.cygnus.com)
73
74 * buildsym.c (start_subfile): Set language for f2c like for cfront.
75
76 Thu Feb 9 20:20:11 1995 Rob Savoye <rob@darkstar.cygnus.com>
77
78 * op50n-rom.c: Add the control registers.
79
80 Thu Feb 9 15:46:39 1995 Stan Shebs <shebs@andros.cygnus.com>
81
82 * Makefile.in (CLIBS): Add $(LIBIBERTY) before, in addition to
83 after, any host/target/native libraries.
84 * dcache.c (insque, remque): Remove declarations.
85 * gdbtypes.h (type_code): Remove trailing comma.
86
87 From Peter Schauer:
88 * xcoffread.c (read_xcoff_symtab) [C_HIDEXT]: Move #ifdef
89 STATIC_NODEBUG_VARS inside case.
90
91 Thu Feb 9 07:43:41 1995 Jim Kingdon <kingdon@deneb.cygnus.com>
92
93 * config/sparc/tm-sun4sol2.h: Define STATIC_TRANSFORM_NAME.
94 * partial-stab.h: Call it.
95 * stabsread.c (define_symbol) [STATIC_TRANSFORM_NAME]: Call
96 STATIC_TRANSFORM_NAME to get the name and use minimal symbols to
97 get the address.
98 * sparc-tdep.c (solaris_static_transform_name): New function.
99
100 Thu Feb 9 12:09:09 1995 Jeff Law (law@snake.cs.utah.edu)
101
102 * somread.c (som_symtab_read): Handle dynamic relocation for both
103 text and data symbols.
104 (som_symfile_offsets): If objfile is a shared library, then get
105 text and data offsets from the shared library structures.
106 * somsolib.c (som_solib_add): Copy the bfd pointer from the
107 objfile rather than reopening the file again.
108 (som_solib_section_offsets): New function.
109 * somsolib.h (som_solib_section_offsets): Declare.
110
111 Wed Feb 8 20:32:18 1995 Jim Kingdon <kingdon@deneb.cygnus.com>
112
113 * config/sparc/tm-sun4sol2.h, dbxread.c: Rename
114 N_SO_ADDRESS_MAYBE_MISSING to SOFUN_ADDRESS_MAYBE_MISSING.
115 * symtab.h (minimal_symbol) [SOFUN_ADDRESS_MAYBE_MISSING]: Add
116 filename field.
117 * elfread.c (record_minimal_symbol_and_info),
118 minsyms.c, symtab.h (prim_record_minimal_symbol_and_info): Return
119 newly created symbol.
120 * elfread.c (elf_symtab_read) [SOFUN_ADDRESS_MAYBE_MISSING]:
121 Set filename field of minimal symbol.
122 * symmisc.c (dump_msymbols) [SOFUN_ADDRESS_MAYBE_MISSING]:
123 Print filename field.
124 * minsyms.c, symtab.h (lookup_minimal_symbol): New arg sfile.
125 * symm-tdep.c, somsolib.c, hppa-tdep.c, c-exp.y, f-exp.y,
126 m2-exp.y, nindy-tdep.c, m3-nat.c, irix5-nat.c, hpread.c,
127 os9kread.c, breakpoint.c, alpha-tdep.c, valops.c, symtab.c,
128 printcmd.c, dbxread.c: Change callers to pass NULL for sfile.
129 * dbxread.c (process_one_symbol) [SOFUN_ADDRESS_MAYBE_MISSING]:
130 Find address of function from minimal symbols.
131 * partial-stab.h, case 'f', 'F': Call find_stab_function_addr
132 instead of getting pst->textlow from the stab.
133 * minsyms.c (find_stab_function_addr): New function.
134
135 Wed Feb 8 19:19:56 1995 Rob Savoye <rob@darkstar.cygnus.com>
136
137 * monitor.c: Fix so all the output shows up in the GUI command
138 window.
139
140 Mon Feb 6 18:50:59 1995 Stan Shebs <shebs@andros.cygnus.com>
141
142 * i386-tdep.c (_initialize_i386_tdep): Put void decl on separate
143 line, so init.c generation works correctly.
144 start-sanitize-arc
145 * arc-tdep.c (_initialize_arc_tdep): Ditto.
146 end-sanitize-arc
147
148 Mon Feb 6 14:44:36 1995 Rob Savoye <rob@darkstar.cygnus.com>
149
150 * config/mips/idt.mt: Add support for the lsi33k target.
151 * config/sparc/sun4sol2.mh: Add support for ser-tcp.
152 * array-rom.c: Finish the rest of the support commands needed by
153 GDB.
154 * mips-tdep.c: Add LSI33k register names and processor type.
155
156 start-sanitize-gdbtk
157 Sun Feb 5 20:32:44 1995 Jim Kingdon (kingdon@lioth.cygnus.com)
158
159 * gdbtk.c (gdb_disassemble): Deference pointer to function before
160 calling it (pre-ANSI compilers generally require this).
161
162 end-sanitize-gdbtk
163 Sat Feb 4 13:29:52 1995 Stan Shebs <shebs@andros.cygnus.com>
164
165 * config/m68k/est.mt (TDEPFILES): Remove m68k-pinsn.o.
166
167 Fri Feb 3 16:47:31 1995 Kung Hsu <kung@mexican.cygnus.com>
168
169 * ser-go32-para.c (dos_read): fix syntax errors.
170
171 Fri Feb 3 11:19:20 1995 Stu Grossman (grossman@cygnus.com)
172
173 * core.c (dis_asm_read_memory), defs.h, top.c: Get rid of
174 dis_asm_read_memory_hook. We can now call the disassemblers
175 directly and have no need for this hook anymore.
176 start-sanitize-gdbtk
177 * gdbtk.c (gdb_disassemble): Ditto.
178 end-sanitize-gdbtk
179 * defs.h, printcmd.c: Make print_insn be static.
180
181 * ser-go32.c (dos_comisr): Make this 8 bit clean.
182 * (dos_open dos_close): Allow multiple opens to the same device.
183 Use a ref count to prevent unwanted deallocations.
184 * sparcl-tdep.c: Put #ifdefs around all socket stuff to make GO32
185 happy.
186 * (sparclite_ops): Switch to download_stratum.
187 * target.h (enum strata): Move download_stratum before
188 process_stratum so that executable targets get pushed on top of
189 download targets.
190
191 Thu Feb 2 19:02:45 1995 Rob Savoye <rob@darkstar.cygnus.com>
192
193 * array-rom.c: Remove the non GDB remote protocol config stuff.
194
195 * monitor.c: All reading/writing functions for memory and
196 registers work.
197
198 Thu Feb 2 16:11:04 1995 Kung Hsu <kung@mexican.cygnus.com>
199
200 start-sanitize-arc
201 * config/arc/arc.mt: new target makefile for arc processor.
202 * config/arc/tm-arc.h: new target header for arc processor.
203 * config/arc/go32.mh: new go32 host makefile for arc processor.
204 * config/arc/xm-go32.h: new go32 host header for arc processor.
205 * arc-tdep.c: new target dependent codes for arc processor.
206 * remote-arc.c: new file for arc-specific protocol through
207 parallel line.
208 end-sanitize-arc
209 * ser-go32-para.c: new file for go32 parallel port communication.
210
211 Thu Feb 2 13:58:40 1995 Stan Shebs <shebs@andros.cygnus.com>
212
213 * Makefile.in (VERSION): Bump to 4.13.2.
214
215 Thu Feb 2 07:27:56 1995 Jim Kingdon (kingdon@lioth.cygnus.com)
216
217 Fix compiler warnings:
218 * remote-e7000.c (printf_e7000debug): Rename to puts_e7000debug
219 and have the caller do the sprintf. Saves us from varargs hell.
220 (normal): Define before use.
221 * remote-e7000.c: Reindent a few things.
222
223 Wed Feb 1 21:16:42 1995 Per Bothner <bothner@kalessin.cygnus.com>
224
225 * f-typeprint.c (f_type_print_varspec_suffix): Print array index
226 ranges in reverse order.
227 * f-valprint.c (f77_create_arrayprint_offset_tbl): Fix calculation.
228
229 * eval.c (evaluate_subscript): Don't call value_subscript, since
230 it adjusts for lower bound and enforces ranges.
231
232 * expression.h (exp_code): Remove MULTI_F77_SUBSCRIPT, OP_F77_SUBSTR.
233 * eval.c, parse.c: Removed uses of removed opcodes.
234 * eval.c (evaluate_subexp): Clean up handling of
235 OP_UNDETERMINED_ARGLIST (no backtracking, more general).
236
237 * f-valprint.c (f_val_print): Print TYPE_CODE_STRING using
238 LA_PRINT_STRING, and not val_print_string (which reads from inferior).
239
240 * ch-lang.c (chill_is_varying_struct), ch-lang.h: Remve function
241 duplicate function made redundant by chill_varying_type.
242
243 Re-write of f77 string and complex number support:
244
245 * language.h (struct language_defn): New fields string_lower_bound
246 and string_char_type.
247 * c-lang.c (c_language_defn, cplus_language_defn, asm_language_defn),
248 language.c (unknown_language_defn, auto_language_defn,
249 local_language_defn), m2-lang.c (m2_language_defn), f-lang.c
250 (f_language_defn), ch-lang.c (chill_language_defn): Set new fields.
251 * gdbtypes.c (create_string_type): Use new string_char_type field.
252 * valops.c (value_string): Use new string_lower_bound field.
253
254 * defs.h (TARGET_COMPLEX_BIT, TARGET_DOUBLE_COMPLEX_BIT): Removed.
255 * f-lang.c (f_create_fundamental_type, _initialize_f_language),
256 m2-lang.c (m2_create_fundamental_type),
257 gdbtypes.c (_initialize_gdbtypes): Set TYPE_TARGET_TYPE of complex
258 types. Set their TYPE_CODEs to TYPE_CODE_COMPLEX.
259 * mdebugread.c (mdebug_type_complex, mdebug_type_double_complex):
260 Removed. Use builtin_type_complex and builtin_type_double_complex.
261
262 * gdbtypes.h (enum type_code): Removed TYPE_CODE_LITERAL_STRING
263 and TYPE_CODE_LITERAL_COMPLEX.
264 * c-typeprint.c, f-typeprint.c, f-valprint.c, eval.c: Removed uses of
265 TYPE_CODE_LITERAL_STRING and TYPE_CODE_LITERAL_COMPLEX.
266 * gdbtypes.c, gdbtypes.h (f77_create_literal_complex_type,
267 f77_create_literal_string_type): Removed.
268 * value.h (VALUE_LITERAL_DATA, VALUE_SUBSTRING_MEMADDR,
269 VALUE_SUBSTRING_MYADDR): Removed.
270
271 * expression.h (enum exp_opcode): Rename OP_F77_LITERAL_COMPLEX to
272 OP_COMPLEX.
273 * parse.c: Update accordingly.
274
275 * f-valprint.c (f77_print_cmplx): Removed.
276 (f_val_print case TYPE_CODE_COMPLEX): Re-write to use print_floating.
277
278 * f-exp.y (STRING_LITERAL): Use OP_STRING instead of OP_ARRAY.
279 * eval.c (evaluate_subexp): For case OP_ARRAY, don't call
280 f77_value_literal_string.
281 * valops.c, value.h (f77_value_literal_string, f77_value_substring,
282 f77_assign_from_literal_string, f77_assign_from_literal_complex):
283 Removed.
284 (value_assign): No longer need to handle literal types.
285 * valops.c (f77_value_literal_complex), value.h: Re-written and
286 renamed to value_literal_complex. Last arg is now a (complex) type.
287 * valops.c (f77_cast_into_complex): Re-written and renamed to
288 cast_into_complex.
289 * eval.c (evaluate_subexp): Update accordingly.
290
291 * ch-valprint.c (chill_val_print): On TYPE_CODE_STRING, don't
292 print address for non-'s'-formats.
293 * ch-typeprint.c, ch-valprint.c: Use chill_varying_type instead
294 of chill_is_varying_struct.
295
296 Wed Feb 1 13:27:33 1995 Stan Shebs <shebs@andros.cygnus.com>
297
298 gcc -Wall lint.
299 * alpha-tdep.c (alpha_in_lenient_prologue): Comment out.
300 (after_prologue): Remove unused local b.
301 * procfs.c (thread.h): Include.
302 (pr_flag_table, pr_why_table, faults_table, siginfo_table): Use
303 nested braces in initializer.
304 * top.c (initialize_targets, initialize_utils): Declare.
305 (locate_arg, insert_args): Add parens around tested assignments.
306 * remote-utils.c (sr_scan_args): Remove decl of strtol.
307 * remote.c (thread.h): Include.
308 (remote_wait): Remove unused local p2.
309 * sparc-tdep.c (fill_gregset, fill_fpregset): Remove decls of
310 registers array.
311
312 defs.h (stdlib.h): Include.
313 (exit, perror, atoi, qsort, memcpy, memcmp): Don't declare.
314 (fclose, atof, malloc, realloc, free, strchr, strrchr, strstr,
315 strtok, strerror): Don't specify parameter types in declaration.
316
317 Wed Feb 1 12:23:57 1995 Per Bothner <bothner@kalessin.cygnus.com>
318
319 * ch-exp.y (value_string_element, string_primitive_value,
320 start_element, left_element, right_element, slice_size,
321 lower_element, upper_element, first_element): Removed.
322 (value_string_slice, value_array_slice): Replaced by ...
323 (slice): New non-terminal, with working slice support.
324 (primitive_value_lparen, rparen): New non-terminals.
325 (maybe_tuple_elements): New non-terminal, to allow empty tuples.
326 (idtokentab): Added "up".
327
328 * value.h (COERCE_VARYING_ARRAY): New macro.
329 * valarith.c (value_subscript): Use it.
330 * valops.c (value_cast): Likewise. Also, do nothing if already
331 correct type, and allow converting from/to range to/from scalar.
332
333 * valops.c, value.h (varying_to_slice, value_slice): New functions.
334 * eval.c (OP_ARRAY): Add cast for array element.
335 * expression.h (TERNOP_SLICE, TERNOP_SLICE_COUNT): New exp_opcodes.
336 * valops.c (chill_varying_type): Moved function frp, here ...
337 * gdbtypes.c (chill_varying_type), gdbtypes.h: ... to here.
338 * parse.c (length_of_subexp, prefixify_subexp): Add support
339 for TERNOP_SLICE, TERNOP_SLICE_COUNT.
340 * expprint.c (print_subexp, dump_expression): Likewise.
341 * eval.c (evaluate_subexp): Likewise.
342
343 * eval.c (evaluate_subexp case MULTI_SUBSCRIPT): Don't call
344 value_x_binop on a Chill varying string.
345
346 Tue Jan 31 13:51:53 1995 Jim Kingdon (kingdon@lioth.cygnus.com)
347
348 * config/m68k/monitor.mt,
349 config/pa/{hppabsd.mt,hppahpux.mt,hppaosf.mt,hppapro.mt}: Put
350 depfiles in TDEPFILES not REMOTE_O.
351
352 Tue Jan 31 11:14:44 1995 Steve Chamberlain <sac@splat>
353
354 From nigel@algor.co.uk.
355 * ser-go32.c (dos_close): Don't crash if scb null.
356 (dos_sendbreak): New function.
357 (dos_ops): Point to dos_sendbreak.
358 (dos_info): Calculate COM number correctly.
359
360 Tue Jan 31 09:40:11 1995 Jim Kingdon (kingdon@lioth.cygnus.com)
361
362 * xcoffread.c (process_xcoff_symbol): Use new variables
363 func_symbol_type and var_symbol_type as type of functions and
364 variables which don't have any stabs associated with them.
365 Reindent most of function.
366 (_initialize_xcoffread): Initialize *_symbol_type.
367
368 * xcoffread.c (read_xcoff_symtab): Reindent most of function.
369 Put C_HIDEXT symbols in the minimal symbols, rather than ignoring
370 them (this part commented out as I didn't quite get it to work).
371 (cs_to_section, find_targ_sec): New functions, to support above code.
372 * xcoffread.c (RECORD_MINIMAL_SYMBOL): Only skip '.' if it is
373 actually present.
374
375 Mon Jan 30 17:34:24 1995 Stu Grossman (grossman@cygnus.com)
376 start-sanitize-gdbtk
377 * gdbtk.tcl (create_file_win): Disable old popup menu for source
378 window.
379 end-sanitize-gdbtk
380 * sparcl-tdep.c: Add `sparclite' target for doing serial and udp
381 downloads to SPARClite demo boards.
382
383 Sun Jan 29 09:43:22 1995 Jim Kingdon (kingdon@lioth.cygnus.com)
384
385 * remote.c, remote-pa.c: Remove #if 0'd icache code. It has had
386 no hope of working as is for a long time (in particular, shebs' 27
387 Jan 95 change confuses the issue further--target_read_memory and
388 xfer_core_file do *not* do the same thing in this context).
389 Revise comment.
390
391 Sat Jan 28 13:40:46 1995 Peter Schauer (pes@regent.e-technik.tu-muenchen.de)
392
393 * elfread.c (elf_symtab_read): Do not test BSF_GLOBAL for
394 procedure linkage table symbols, it is no longer set due to the
395 Jan 6 BFD change in bfd/elfcode.h.
396
397 Fri Jan 27 17:08:06 1995 Stan Shebs <shebs@andros.cygnus.com>
398
399 * top.c (use_windows): Clarify comments.
400
401 * convex-tdep.c (xfer_core_file): Comment out.
402 * config/convex/tm-convex.h (XFER_CORE_FILE): Remove.
403 * remote.c, remote-pa.c (remote_fetch_word): Change xfer_core_file
404 references to target_read_memory.
405 * gdbcore.h (xfer_core_file, core_open, core_detach): Remove
406 declarations.
407 * corelow.c (core_open, core_detach): Make static.
408
409 * arm-tdep.c: Make it compile.
410 (exec_file_command, xfer_core_file): Comment out.
411 (arm_print_insn): Remove, now in libopcodes.
412 (skip_prologue): Comment out most of body.
413 (arm_frame_find_saved_regs): Move here from tm-arm.h.
414 (_initialize_arm_tdep): Set tm_print_insn.
415 * config/arm/tm-arm.h: Remove old refs to first_object_file_end.
416 (XFER_CORE_FILE): Remove.
417 (FRAME_FIND_SAVED_REGS): Call arm_frame_find_saved_regs.
418
419 Fri Jan 27 08:48:28 1995 Jim Kingdon (kingdon@lioth.cygnus.com)
420
421 * Makefile.in (CHILL_LIB): Define as in testsuite/Makefile.in.
422
423 Thu Jan 26 18:24:41 1995 Jim Kingdon <kingdon@deneb.cygnus.com>
424
425 * symtab.c (find_pc_line): When subtracting one to get a line
426 number, make sure not to end up with zero.
427
428 * remote-vx.c: Revert all of Kung's changes of 16 Jan. The
429 problems with those changes were (a) the file didn't compile, (b)
430 they changed memset to bzero--memset is correct, (c) they took out
431 code to deal with boards lacking floating point, (d) who knows
432 what I didn't discover in a quick read.
433
434 Thu Jan 26 17:32:54 1995 Stu Grossman (grossman@cygnus.com)
435
436 * sparcl-tdep.c: Clean up formatting and indentation.
437
438 Thu Jan 26 10:49:59 1995 Steve Chamberlain <sac@splat>
439
440 * remote-hms.c (hms_ops): Change ref of hr_load_image
441 to gr_load_image.
442 (dcache_flush, dcache_hit, dcache_value, dcache_fetch,
443 dcache_poke, dcache_init): Deleted.
444 (hms_open, hms_resume, hms_fetch_word, hms_store_word):
445 Use dcache routines provided by remote-util.h
446
447 Thu Jan 26 12:08:31 1995 Michael Meissner <meissner@cygnus.com>
448
449 * configure.in: Add support for powerpc-*-eabi.
450
451 * powerpc/tm-ppc-eabi.h, powerpc/pcc-eabi.mt: New files for
452 PowerPC support.
453
454 Wed Jan 25 18:13:14 1995 Per Bothner <bothner@kalessin.cygnus.com>
455
456 * language.h (struct language_defn): New field c_style_arrays.
457 * language.c (unknown_language_defn, auto_language_defn,
458 local_language_defn), c-lang.c (c_language_defn, cplus_language_defn,
459 asm_language_defn): Set c_style_arrays to true.
460 * m2-lang.c (m2_language_defn), ch-lang.c (chill_language_defn),
461 f-lang.c (f_language_defn): Set c_style_arrays to false.
462 * valops.c (value_string): If c_style_array is not set,
463 allocate string in gdb (not inferior) using allocate_value.
464
465 * value.h (COERCE_ARRAY), valops.c (value_addr, value_arg_coerce):
466 Only call value_coerce_array if current_language->c_style_arrays.
467 * values.c: Add #include "language.h". (Needed for COERCE_ARRAY.)
468
469 * valops.c (chill_varying_type): New predicate.
470 * valops.c (value_cast): Support assigning a fixed string or array
471 to a variable string/array structure.
472
473 * valarith.c (value_subscripted_rvalue): Extra parameter lowerbound.
474 Check index>=lowerbound, and then add lowerbound to index here,
475 instead of in caller. Generalize to arbitrary lval_types.
476 (value_subscript): Use enhanced value_subscripted_rvalue if
477 c_style_arrays is false (and index is in range).
478
479 Wed Jan 25 18:23:46 1995 Stu Grossman (grossman@cygnus.com)
480
481 * gdbtk.c (gdbtk_init): Prevent segfault when gdbtk.tcl can't be
482 found.
483 * gdbtk.tcl: Initialize expr_update_list() to prevent errors when
484 popping up expression window for the first time.
485
486 Wed Jan 25 18:13:14 1995 Per Bothner <bothner@kalessin.cygnus.com>
487
488 * eval.c (evaluate_subexp case OP_ARRAY): Fix calls to memset:
489 TYPE_LENGTH is length in bytes, not bits.
490
491 Wed Jan 25 08:19:35 1995 Jim Kingdon (kingdon@lioth.cygnus.com)
492
493 * infrun.c (proceed): Flush stdout before resuming inferior.
494 * infcmd.c (step_1), annotate.c (annotate_starting):
495 Don't bother to flush here.
496
497 Wed Jan 25 01:11:21 1995 Jeff Law (law@snake.cs.utah.edu)
498
499 * hpread.c (hpread_process_one_debug_symbol): Fix lines garbled
500 by an ill-advised global search and replace.
501
502 Tue Jan 24 12:10:28 1995 Stu Grossman (grossman@cygnus.com)
503
504 * gdbtk.tcl (create_registers_window): Work around a radiobutton
505 widget bug to make Options|Natural button work.
506
507 * gdbtk.c (gdb_disassemble): Fix problem with source+assembly and
508 g++ caused by out-of-order pc's.
509 * gdbtk.tcl (files_command): Remove duplicate file names. Also,
510 add scrollbar.
511
512 Mon Jan 23 17:21:09 1995 Stu Grossman (grossman@cygnus.com)
513
514 * gdbtk.tcl: Take .gdbtkinit if it exists. Makes gdbtk match the
515 doc!
516
517 Mon Jan 23 13:11:46 1995 Per Bothner <bothner@kalessin.cygnus.com>
518
519 Add support for Chill bitstring literals (e.h. H'FF00').
520 * ch-exp.y (match_bitstring_literal): Fix for proper endianness.
521 * expprint.c (print_subexp): Don't call error on OP_BITSTRING,
522 just print B'<unimlemented>'.
523 * gdbtypes.c (create_set_type): Fix bug in length calculation.
524 * valops.c, value.h (value_bitstring): New function.
525 * eval.c (evaluate_subexp): Implement support for OP_BITSTRING.
526
527 * ch-typeprint.c (chill_type_print_base): For TYPE_CODE_FUNC,
528 check that return type is non-void, and print in proper Chill syntax.
529
530 Mon Jan 23 12:20:34 1995 Rob Savoye <rob@darkstar.cygnus.com>
531
532 * Makefile.in: Remove references to remote-mon.c.
533 * remote-mon.c: remove. Replaced by rom68k-rom.c.
534 * rom68k-rom.c: Support for Rom68k monitor.
535
536 Mon Jan 23 10:50:57 1995 Jim Kingdon (kingdon@lioth.cygnus.com)
537
538 * Makefile.in (CHILL_FOR_TARGET): Update -L argument to point to
539 gcc/ch/runtime not chillrt, since that is where the chill runtime
540 lives now.
541
542 Mon Jan 23 00:06:57 1995 Steve Chamberlain <sac@splat>
543
544 * remote-hms.c (hms_load): Delete.
545 (target_ops): Use hr_load_image.
546
547 * remote-e7000.c, remote-z8k.c, remote-nindy.c (target_ops):
548 Define memory_insert/remove_breakpoint.
549 * xm-go32.h: Remove redundant SIGs.
550
551 Thu Jan 19 20:26:58 1995 Steve Chamberlain <sac@splat>
552
553 * ser-go32.c: Rewritten by nigel@algor.co.uk.
554
555 Fri Jan 20 15:23:55 1995 Per Bothner <bothner@kalessin.cygnus.com>
556
557 * expression.h (OP_LABELED): New operator, for Chill
558 labeled structre tuples.
559 * ch-exp.y (tuple_element, named_record_element, tuple_elements):
560 New non-terminals, to handle labeled structure tuples.
561 (tuple): Re-define using tuple_elements.
562 * eval.c (evaluate_labeled_field_init): New function, to handle
563 initialization of structure fields, possibly using OP_LABELED.
564 (evaluate_subexp): Use it.
565 * expprint.c (print_subexp case): For OP_ARRAY, use Chill syntax
566 for Chill. Handled OP_LABELED.
567 * parse.c (length_of_subexp, prefixify_subexp): Handle OP_LABELED.
568
569 * eval.c (evaluate_subexp): Handle Chill Powerset tuples.
570 * valarith.c (value_bit_index): Just treat bitstring as represented
571 by an array of bytes. Alignment is handled by compiler.
572
573 Wed Jan 18 19:00:29 1995 Stan Shebs <shebs@andros.cygnus.com>
574
575 * h8300-tdep.c (gdb_print_insn_h8300): Fix typo (&info -> info).
576 * sh-tdep.c (gdb_print_insn_sh): Ditto.
577
578 Wed Jan 18 11:25:43 1995 Kung Hsu <kung@mexican.cygnus.com>
579
580 * remote-os9k.c (rombug_open): Fix a bug in exception handling
581 command.
582 * remote-os9k.c (rombug_write_inferior_memory): reset buffer after
583 write.
584
585 Tue Jan 17 09:48:38 1995 Jim Kingdon <kingdon@lioth.cygnus.com>
586
587 * parse.c (_initialize_parse): Improve wording of names of
588 msym_*_symbol_type.
589
590 Tue Jan 17 14:00:58 1995 Ian Lance Taylor <ian@sanguine.cygnus.com>
591
592 * config/mips/tm-mips.h (enum mips_fpu_type): New enum.
593 (mips_fpu): Change type to enum mips_fpu_type.
594 (FIX_CALL_DUMMY): Handle mips_fpu == MIPS_FPU_SINGLE.
595 * mips-tdep.c (mips_fpu): Change type to enum mips_fpu_type.
596 Don't initialize.
597 (mips_fpu_string): New static variable.
598 (mips_push_dummy_frame): Handle mips_fpu == MIPS_FPU_SINGLE.
599 (mips_pop_frame): Likewise.
600 (mips_extract_return_value): Likewise.
601 (mips_store_return_value): Likewise.
602 (mips_set_fpu_command): New static function.
603 (mips_show_fpu_command): New static function.
604 (_initialize_mips_tdep): Change handling of set/show mipsfpu.
605
606 Tue Jan 17 09:48:38 1995 Jim Kingdon <kingdon@lioth.cygnus.com>
607
608 * a29k-tdep.c (gdb_print_insn_a29k): Fix typo (&info -> info).
609
610 * parse.c (write_exp_msymbol): Use new variables
611 msym_*_symbol_type as type of msymbol expression.
612 (_initialize_parse): Initialize them.
613
614 Mon Jan 16 18:11:03 1995 Stan Shebs <shebs@andros.cygnus.com>
615
616 General cleanup and simplication of disassembler interface.
617 * a29k-pinsn.c, arm-pinsn.c, convex-pinsn.c, gould-pinsn.c,
618 hppa-pinsn.c, i386-pinsn.c, i960-pinsn.c, m68k-pinsn.c,
619 m88k-pinsn.c, mips-pinsn.c, ns32k-pinsn.c, pyr-pinsn.c,
620 rs6000-pinsn.c, sparc-pinsn.c, tahoe-pinsn.c, vax-pinsn.c: Remove.
621 * gould-tdep.c, ns32k-tdep.c, tahoe-tdep.c, vax-tdep.c: New files,
622 had been -pinsn.c files.
623 * Makefile.in (ALLDEPFILES): Remove removed files.
624 (a29k-pinsn.o, arm-pinsn.o, convex-pinsn.o, gould-pinsn.o,
625 hppa-pinsn.o, i386-pinsn.o, i960-pinsn.o, m68k-pinsn.o,
626 m88k-pinsn.o, mips-pinsn.o, ns32k-pinsn.o, pyr-pinsn.o,
627 rs6000-pinsn.o, sparc-pinsn.o, tahoe-pinsn.o, vax-pinsn.o):
628 Remove compile actions.
629 * arm-tdep.o, gould-tdep.o, ns32k-tdep.o, tahoe-tdep.o,
630 vax-tdep.o: Add compile actions.
631 * defs.h (tm_print_insn): New global.
632 * a29k-tdep.c (gdb_print_insn_a29k): New function.
633 (_initialize_a29k_tdep): Rename from _initialize_29k,
634 set tm_print_insn.
635 * alpha-tdep.c (print_insn): Remove.
636 (_initialize_alpha_tdep): Set tm_print_insn.
637 * arm-tdep.c (arm_print_insn): New function, was print_insn
638 in arm-pinsn.c.
639 * convex-tdep.c (convex_print_insn): New function, was print_insn
640 in convex-pinsn.c.
641 * h8300-tdep.c (print_insn): Remove.
642 (gdb_print_insn_h8300): New function.
643 (_initialize_h8300_tdep): New function.
644 * h8500-tdep.c (print_insn): Remove.
645 (_initialize_h8500_tdep): New function.
646 * hppa-tdep.c (_initialize_hppa_tdep): Set tm_print_insn.
647 * i386-tdep.c (_initialize_i386_tdep): New function.
648 * i960-tdep.c (mem, next_insn): New functions, were in
649 i960-pinsn.c.
650 (_initialize_i960_tdep): Set tm_print_insn.
651 * m68k-tdep.c (_initialize_m68k_tdep): New function.
652 * m88k-tdep.c (_initialize_m88k_tdep): New function.
653 * mips-tdep.c (gdb_print_insn_mips): New function.
654 (_initialize_mips_tdep): Set tm_print_insn.
655 * pyr-tdep.c (pyr_print_insn): New function, was print_insn
656 in pyr-pinsn.c.
657 * rs6000-tdep.c (_initialize_rs6000_tdep): New function.
658 * sh-tdep.c (print_insn): Remove.
659 (gdb_print_insn_sh): New function.
660 (_initialize_sh_tdep): Set tm_print_insn.
661 * sparc-tdep.c (_initialize_sparc_tdep): New function.
662 * w65-tdep.c (print_insn): Remove.
663 (_initialize_w65_tdep): New function.
664 * z8k-tdep.c (print_insn): Remove.
665 (gdb_print_insn_z8k): New function.
666 (_initialize_z8k_tdep): Set tm_print_insn.
667 * printcmd.c (print_insn): New function, generic disassembler.
668 * config/*/*.mt (TDEPFILES): Remove refs to *-pinsn.o.
669
670 Mon Jan 16 15:43:29 1995 Kung Hsu <kung@mexican.cygnus.com>
671
672 * Makefile.in: add new files remote-vx29k.c, config/a29k/tm-vx29k.h,
673 and config/a29k/vx29k.mt.
674 * configure.in: add new configuration a29k-*-vxworks.
675 * remote-vx29k.c: new file merged from WRS.
676 * remote-vx.c: merge changes from WRS.
677 * config/a29k/vx29k.mt: new file for new configuration.
678 * config/a29k/tm-vx29k.h: new header file for newconfiguration.
679
680 Sun Jan 15 14:36:19 1995 Steve Chamberlain <sac@splat>
681
682 * breakpoint.h (disable_breakpoint, enable_breakpoint):
683 New declarations.
684 (enum bpdisp): Change name of 'delete' member to 'del'.
685 (struct bpstat): Changed name to 'bpstats'.
686 * breakpoint.c (disable_breakpoint, enable_breakpoint,
687 breakpoint_chain): Made globally visible.
688 (bpstat_stop_status): Use new name for bpstat.
689 (break_command_1, watch_command_1, catch_command_1,
690 breakpoint_auto_delete, denable_delete_breakpoint): Use 'del'
691 instead of 'delete'.
692 (set_breakpoint_sal): New function.
693 * defs.h (registers_changed_hook): New declaration.
694 * infcmd.c (run_stack_dummy): 'delete' is now 'del'.
695 * inflow.c (new_tty): Treat WIN32 in same way as __GO32__
696 * main.c (main): Don't scan options when in WIN32 and exit
697 without entering main loop.
698 * m2-exp.y (m2_elx): Member 'class' is now 'aclass'.
699 * symtab.h (struct symbol, struct partial_symbol): Changed name of
700 member 'class' to 'aclass'.
701 (SYMBOL_CLASS, PSYMBOL_CLASS): Reflect change.
702 * top.c (registers_changed_hook): New definition.
703 * utils.c (quit, notice_quit, initialize_utils): Treate WIN32
704 in same way as __GO32__.
705 * value.h (c_typedef_print): Rename 'new' argument.
706
707 * w65-tdep.c, config/tm-w65.h, config/w65.mt: New files.
708 * configure.in: Suppprt for w65,
709
710
711 Sat Jan 14 11:18:11 1995 Jim Kingdon <kingdon@lioth.cygnus.com>
712
713 * infcmd.c (signal_command): For "signal 0", pass (CORE_ADDR)-1,
714 not stop_pc, to proceed.
715
716 * eval.c (evaluate_subexp): Clear expect_type except for C++ and CHILL.
717
718 Fri Jan 13 17:52:57 1995 Jim Kingdon <kingdon@lioth.cygnus.com>
719
720 * infcmd.c (signal_command): Accept "signal 0"; the change to not
721 accept it was accidental. "handle 0" and "info signal 0" remain
722 illegal, though.
723
724 Fri Jan 13 15:19:01 1995 Stan Shebs <shebs@andros.cygnus.com>
725
726 * Makefile.in (all): Don't make libgdb-files.
727 (libgdb): New action, makes libgdb-files.
728
729 Thu Jan 12 21:23:25 1995 Per Bothner <bothner@kalessin.cygnus.com>
730
731 * stabsread.c (read_enum_type): When pending enum symbols are
732 put into the enum type, they must be inserted in "backwards
733 order, in case we've overflowed a struct pending buffer.
734
735 start-sanitize-gdbtk
736 Thu Jan 12 15:02:40 1995 Stu Grossman (grossman@cygnus.com)
737
738 * gdbtk.c, gdbtk.tcl: Update/add copyright.
739 * gdbtk.tcl (build_framework): Several fixes for filespec widget,
740 including dismiss button, and better error handling.
741 * (create_command_win): Bind button 2 to retrieve selection.
742 end-sanitize-gdbtk
743
744 Thu Jan 12 09:33:24 1995 Peter Schauer (pes@regent.e-technik.tu-muenchen.de)
745
746 * README: Add note about SPARCworks cc release 3.0 and higher.
747
748 Add procfs support for Alpha OSF/1-2.x.
749 * config/alpha/nm-osf.h: Renamed from nm-alpha.h, generic
750 OSF/1 native support.
751 * config/alpha/alpha-osf1.mh (NAT_FILE): Changed accordingly.
752 (MUNCH_DEFINE): Removed.
753 * config/alpha/alpha-osf2.mh, config/alpha/nm-osf2.h: New files
754 for procfs support.
755 * configure.in (alpha-dec-osf*): Use alpha-osf2.mh for OSF/1
756 release 2.x and higher, else alpha-osf1.mh, as the procfs support
757 in release 1.x is incomplete.
758 * Makefile.in (ALLCONFIG): Add config/alpha/alpha-osf2.mh.
759 * alpha-nat.c (supply_gregset, fill_gregset, supply_fpgregset,
760 fill_fpgregset): New routines for procfs support.
761 * inftarg.c (_initialize_inftarg): Don't add ptrace support
762 if we have an optional procfs and /proc is accessible.
763 * procfs.c: Include sys/fault.h and sys/syscall.h before
764 including sys/procfs.h.
765 (unconditionally_kill_inferior): If PROCFS_NEED_PIOCSSIG_FOR_KILL
766 is defined, additionally perform a PIOCSSIG to really terminate
767 the inferior.
768 (create_procinfo): Always return a result.
769 (create_procinfo, do_attach): Don't trace T_IFAULT faults if
770 PROCFS_DONT_TRACE_IFAULT is defined.
771 (procfs_init_inferior): Use START_INFERIOR_TRAPS_EXPECTED as
772 argument to startup_inferior if it is defined.
773 (proc_set_exec_trap): If PIOCSSPCACT is defined, use it instead
774 of tracing exits from exec system calls. Needed for the user level
775 loader under Alpha OSF/1.
776 (do_detach): Clear any pending signal if we want to detach from
777 a process without a signal.
778 (set_proc_siginfo): If PROCFS_DONT_PIOCSSIG_CURSIG is defined,
779 don't issue a PIOCSSIG if pr_cursig already contains the signal we
780 intend to set.
781 (info_proc_signals): If PROCFS_SIGPEND_OFFSET is defined, the
782 pending signals are numbered from 1 instead of 0.
783 (info_proc_mappings): Increase size of output format for addresses
784 if BFD_HOST_64_BIT is defined.
785 (procfs_stop): Renamed from child_stop.
786 (_initialize_procfs): Don't add procfs support if we have an
787 optional procfs and /proc is not accessible.
788
789 start-sanitize-gdbtk
790 Wed Jan 11 17:06:55 1995 Stu Grossman (grossman@cygnus.com)
791
792 * gdbtk.tcl: Add button to control mixed source disassembly.
793 Use text widgets in expr window. The give me more control over
794 layout.
795 Add auto-updating of exprs in expression window.
796 Handle expressions out of scope a bit better.
797 Make selected window pop up to the top when invoked via the
798 menubar.
799 Make copyright message have raised relief.
800
801 * gdbtk.c (gdbtk_init): Improve handling for errors in gdbtk.tcl
802 during startup.
803 end-sanitize-gdbtk
804
805 Wed Jan 11 17:53:26 1995 Rob Savoye <rob@darkstar.cygnus.com>
806
807 * array-rom.c: Add support for most commands.
808
809 * monitor.c: Add GDB remote protocol for the hybrid environment on
810 the Array board.
811
812 Wed Jan 11 00:44:01 1995 Jeff Law (law@snake.cs.utah.edu)
813
814 * command.c (show_user_1): Use print_command_line to show a user
815 defined command (including control structures).
816
817 * top.c (init_main): Change documentation for user defined
818 commands to indicate they may accept up to ten arguments.
819
820 Tue Jan 10 16:22:41 1995 Jim Kingdon <kingdon@lioth.cygnus.com>
821
822 * mips-tdep.c (mips_skip_prologue): Accept or as well as addu for
823 `move $s8, $sp' instruction.
824
825 Sun Jan 8 12:45:34 1995 Jim Kingdon <kingdon@deneb.cygnus.com>
826
827 * target.c, target.h (target_signal_from_command): New function.
828 * infrun.c (handle_command, signals_info), infcmd.c
829 (signal_command): Use it.
830 * infrun.c, infcmd.c: Update docstrings for these commands.
831
832 * target.h (enum target_signal), target.c (signals), target.c
833 (target_signal_from_host, target_signal_to_host): Add
834 TARGET_SIGNAL_REALTIME_* and TARGET_SIGNAL_PRIO for lynx.
835 * config/tm-lynx.h: Define signal numbers for realtime events.
836
837 Sat Jan 7 07:23:53 1995 Peter Schauer (pes@regent.e-technik.tu-muenchen.de)
838
839 * dbxread.c (process_one_symbol): Handle N_FUN symbols
840 for Sun acc 3.0 under SunOS4.
841
842 Changes to improve handling of runtime common symbols
843 under SunOS4.
844 * minsyms.c (get_symbol_leading_char): New routine to determine
845 the leading symbol character for an objfile.
846 (prim_record_minimal_symbol_and_info, install_minimal_symbols):
847 Use it.
848 * objfiles.h (rt_common_objfile): New global, points to objfile
849 containing the runtime common minimal symbols.
850 * objfiles.c (free_objfile): Mark rt_common_objfile as
851 unallocated before freeing it.
852 * solib.c (allocate_rt_common_objfile): New routine to allocate
853 an objfile for the runtime common minimal symbols.
854 (solib_add_common_symbols): Allocate an objfile for the runtime
855 common symbols if necessary and put common symbols into it.
856 Clean up code and comments.
857 (solib_add, special_symbol_handling): Cleanup comments regarding
858 runtime common symbols.
859 * stabsread.c (scan_file_globals_1): New routine, contains
860 old scan_file_globals code. Checks if there are any unresolved
861 global symbols before starting the expensive minimal symbol table
862 search.
863 (scan_file_globals): Now calls scan_file_globals_1 for the passed
864 objfile and eventually for the runtime common objfile. Complains
865 about any unresolved global symbols and removes them from the
866 global symbol chain to avoid dangling pointers into the symbol
867 table if the symbol table is reread.
868
869 Thu Jan 5 17:38:29 1995 Stu Grossman (grossman@cygnus.com)
870
871 * Makefile.in (install_only uninstall): Indent for clarity.
872
873 * core.c (dis_asm_read_memory): Add call to
874 dis_asm_read_memory_hook to provide alternate way for disassembler
875 to read memory.
876
877 * defs.h: Protect from multiple inclusion. Add decl for
878 dis_asm_read_memory_hook.
879
880 * top.c: Make window startup be the default.
881 * Add dis_asm_read_memory_hook.
882
883 start-sanitize-gdbtk
884 * gdbtk.c (finish_saving_output): Don't do anything if not saving
885 output.
886 * (breakpoint_notify): Don't send null filename to tcl.
887 * (gdb_eval): New tcl command to eval an expression.
888 * (gdb_disassemble): New tcl command to do disassembly. This
889 allows tcl code to choose between exec file and target memeory,
890 and can also do mixed source and assembly.
891 * (gdbtk_init): Move reading of gdbtk.tcl to the end to make sure
892 that more of the environment is set up. Also, create link between
893 gdb and tcl vars disassemble{-_}from{-_}exec.
894
895 * gdbtk.tcl: New expression window support.
896 * Make assembly window be 80 columns wide.
897 * Use new disassembly method. Add menu items to select
898 disassembly from exec file or target.
899 * Change View menubar item to Options.
900
901 * Get rid of Stack, Breakpoints, Signals, and Variables Windows,
902 since they don't exist yet.
903
904 * Pop up a copyright window on startup.
905 end-sanitize-gdbtk
906
907 Thu Jan 5 01:16:40 1995 Jeff Law (law@snake.cs.utah.edu)
908
909 * stabsread.c (define_symbol): Handle `a' symbol type used for
910 reference parameter passed in a register.
911
912 start-sanitize-gdbtk
913 Wed Jan 4 19:49:10 1995 Stan Shebs <shebs@andros.cygnus.com>
914
915 * gdbtk.tcl (build_framework): Add standard commands menu, more
916 windows to standard windows menu.
917 (not_implemented_yet): Clarify message.
918 end-sanitize-gdbtk
919
920 Wed Jan 4 12:27:29 1995 Kung Hsu <kung@mexican.cygnus.com>
921
922 * defs.h: move include tm.h up, so that the type LONGEST can
923 also based on the target requirement to determine. In this case
924 target mips64.
925
926 * remote-os9k.c (rombug_open): catch exception e in rombug.
927 * remote-os9k.c (rombug_wait): print message before register display
928 from rombug.
929
930 Wed Jan 4 09:18:27 1995 Jim Kingdon (kingdon@lioth.cygnus.com)
931
932 * top.c (locate_arg): Call strchr not index.
933
934 Tue Jan 3 16:52:03 1995 Per Bothner <bothner@kalessin.cygnus.com>
935
936 * ch-exp.y (literal): Recognize NULL.
937 (tuple): Parse simple unlabelled tuples.
938 * eval.c (evaluate_subexp case OP_ARRAY): Use expect_type to
939 evaluate brace-initializer-expressions depending on context.
940 (evaluate_subexp case UNOP_CAST): Pass the target type as
941 expected type when evaluating the expression.
942
943 * ch-typeprint.c (chill_type_print_base): Get names of PTR and
944 BOOL from TYPE_NAME.
945 * ch-valprint.c (chill_print_type_scalar): New function, to handle
946 TYPE_CODE_RANGE better than print_type_scalar does.
947 (chill_val_print_array_elements): Use above new function.
948
949 Mon Jan 2 15:02:51 1995 Stan Shebs <shebs@andros.cygnus.com>
950
951 * remote-udi.c (udi_load): Tell symbol_file_add that the
952 program being loaded is the main program.
953
954 For older changes see ChangeLog-94
955 \f
956 Local Variables:
957 mode: indented-text
958 left-margin: 8
959 fill-column: 74
960 version-control: never
961 End:
This page took 0.047592 seconds and 5 git commands to generate.