1 2019-08-07 Nick Alcock <nick.alcock@oracle.com>
3 * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
4 * ctf-open.c (ctf_file_close): Free it.
5 * ctf-create.c (ctf_serialize): Adjust.
6 (membcmp): When reporting a conflict due to an error, report the
8 (ctf_add_type): Turn into a ctf_add_processing wrapper. Rename to...
9 (ctf_add_type_internal): ... this. Hand back types we are already
10 in the middle of adding immediately. Hand back structs/unions with
11 the same number of members immediately. Do not walk the dynamic
12 list. Call ctf_add_type_internal, not ctf_add_type. Handle
13 forwards promoted to other types and the inverse case identically.
14 Add structs to the mapping as soon as we intern them, before they
17 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
19 * ctf-impl.h (ctf_names_t): New.
20 (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
21 (ctf_file_t) <ctf_structs>: Likewise.
22 <ctf_unions>: Likewise.
23 <ctf_enums>: Likewise.
24 <ctf_names>: Likewise.
25 <ctf_lookups>: Improve comment.
26 <ctf_ptrtab_len>: New.
27 <ctf_prov_strtab>: New.
28 <ctf_str_prov_offset>: New.
29 <ctf_dtbyname>: Remove, redundant to the names hashes.
30 <ctf_dtnextid>: Remove, redundant to ctf_typemax.
31 (ctf_dtdef_t) <dtd_name>: Remove.
32 <dtd_data>: Note that the ctt_name is now populated.
33 (ctf_str_atom_t) <csa_offset>: This is now the strtab
34 offset for internal strings too.
35 <csa_external_offset>: New, the external strtab offset.
36 (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
37 (ctf_name_table): New declaration.
38 (ctf_lookup_by_rawname): Likewise.
39 (ctf_lookup_by_rawhash): Likewise.
40 (ctf_set_ctl_hashes): Likewise.
41 (ctf_serialize): Likewise.
42 (ctf_dtd_insert): Adjust.
43 (ctf_simple_open_internal): Likewise.
44 (ctf_bufopen_internal): Likewise.
45 (ctf_list_empty_p): Likewise.
46 (ctf_str_remove_ref): Likewise.
47 (ctf_str_add): Returns uint32_t now.
48 (ctf_str_add_ref): Likewise.
49 (ctf_str_add_external): Now returns a boolean (int).
50 * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
51 for strings in the appropriate range.
52 (ctf_str_create_atoms): Create the ctf_prov_strtab. Detect OOM
53 when adding the null string to the new strtab.
54 (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
55 (ctf_str_add_ref_internal): Add make_provisional argument. If
56 make_provisional, populate the offset and fill in the
57 ctf_prov_strtab accordingly.
58 (ctf_str_add): Return the offset, not the string.
59 (ctf_str_add_ref): Likewise.
60 (ctf_str_add_external): Return a success integer.
61 (ctf_str_remove_ref): New, remove a single ref.
62 (ctf_str_count_strtab): Do not count the initial null string's
63 length or the existence or length of any unreferenced internal
65 (ctf_str_populate_sorttab): Skip atoms with no refs.
66 (ctf_str_write_strtab): Populate the nullstr earlier. Add one
67 to the cts_len for the null string, since it is no longer done
68 in ctf_str_count_strtab. Adjust for csa_external_offset rename.
69 Populate the csa_offset for both internal and external cases.
70 Flush the ctf_prov_strtab afterwards, and reset the
72 * ctf-create.c (ctf_grow_ptrtab): New.
73 (ctf_create): Call it. Initialize new fields rather than old
74 ones. Tell ctf_bufopen_internal that this is a writable dictionary.
75 Set the ctl hashes and data model.
76 (ctf_update): Rename to...
77 (ctf_serialize): ... this. Leave a compatibility function behind.
78 Tell ctf_simple_open_internal that this is a writable dictionary.
79 Pass the new fields along from the old dictionary. Drop
80 ctf_dtnextid and ctf_dtbyname. Use ctf_strraw, not dtd_name.
81 Do not zero out the DTD's ctt_name.
82 (ctf_prefixed_name): Rename to...
83 (ctf_name_table): ... this. No longer return a prefixed name: return
84 the applicable name table instead.
85 (ctf_dtd_insert): Use it, and use the right name table. Pass in the
86 kind we're adding. Migrate away from dtd_name.
87 (ctf_dtd_delete): Adjust similarly. Remove the ref to the
89 (ctf_dtd_lookup_type_by_name): Remove.
90 (ctf_dynamic_type): Always return NULL on read-only dictionaries.
91 No longer check ctf_dtnextid: check ctf_typemax instead.
92 (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
93 (ctf_rollback): Likewise. No longer fail with ECTF_OVERROLLBACK. Use
94 ctf_name_table and the right name table, and migrate away from
95 dtd_name as in ctf_dtd_delete.
96 (ctf_add_generic): Pass in the kind explicitly and pass it to
97 ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid. Migrate away
98 from dtd_name to using ctf_str_add_ref to populate the ctt_name.
99 Grow the ptrtab if needed.
100 (ctf_add_encoded): Pass in the kind.
101 (ctf_add_slice): Likewise.
102 (ctf_add_array): Likewise.
103 (ctf_add_function): Likewise.
104 (ctf_add_typedef): Likewise.
105 (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
106 ctt_name rather than dtd_name.
107 (ctf_add_struct_sized): Pass in the kind. Use
108 ctf_lookup_by_rawname, not ctf_hash_lookup_type /
109 ctf_dtd_lookup_type_by_name.
110 (ctf_add_union_sized): Likewise.
111 (ctf_add_enum): Likewise.
112 (ctf_add_enum_encoded): Likewise.
113 (ctf_add_forward): Likewise.
114 (ctf_add_type): Likewise.
115 (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
116 being initialized until after the call.
117 (ctf_write_mem): Likewise.
118 (ctf_write): Likewise.
119 * ctf-archive.c (arc_write_one_ctf): Likewise.
120 * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
121 ctf_hash_lookup_type.
122 (ctf_lookup_by_id): No longer check the readonly types if the
123 dictionary is writable.
124 * ctf-open.c (init_types): Assert that this dictionary is not
125 writable. Adjust to use the new name hashes, ctf_name_table,
126 and ctf_ptrtab_len. GNU style fix for the final ptrtab scan.
127 (ctf_bufopen_internal): New 'writable' parameter. Flip on LCTF_RDWR
128 if set. Drop out early when dictionary is writable. Split the
129 ctf_lookups initialization into...
130 (ctf_set_cth_hashes): ... this new function.
131 (ctf_simple_open_internal): Adjust. New 'writable' parameter.
132 (ctf_simple_open): Adjust accordingly.
133 (ctf_bufopen): Likewise.
134 (ctf_file_close): Destroy the appropriate name hashes. No longer
135 destroy ctf_dtbyname, which is gone.
136 (ctf_getdatasect): Remove spurious "extern".
137 * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
138 specified name table, given a kind.
139 (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
140 (ctf_member_iter): Add support for iterating over the
142 (ctf_enum_iter): Likewise.
143 (ctf_variable_iter): Likewise.
144 (ctf_type_rvisit): Likewise.
145 (ctf_member_info): Add support for types in the dynamic type list.
146 (ctf_enum_name): Likewise.
147 (ctf_enum_value): Likewise.
148 (ctf_func_type_info): Likewise.
149 (ctf_func_type_args): Likewise.
150 * ctf-link.c (ctf_accumulate_archive_names): No longer call
152 (ctf_link_write): Likewise.
153 (ctf_link_intern_extern_string): Adjust for new
154 ctf_str_add_external return value.
155 (ctf_link_add_strtab): Likewise.
156 * ctf-util.c (ctf_list_empty_p): New.
158 2019-08-05 Nick Alcock <nick.alcock@oracle.com>
160 * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
162 * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
164 (ctf_add_variable): Likewise for variables pointing to them.
165 * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
166 type link failure, but do warn for others.
167 * ctf-dump.c (ctf_dump_format_type): Likewise. Do not assume all
169 (ctf_dump_member): Likewise.
170 (ctf_dump_type): Likewise.
171 (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
172 (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
173 (ctf_dump_header): Likewise.
174 (ctf_dump_label): likewise.
175 (ctf_dump_objts): likewise.
176 (ctf_dump_funcs): likewise.
177 (ctf_dump_var): likewise.
178 (ctf_dump_str): Likewise.
180 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
182 * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
184 (AM_INSTALL_LIBBFD): Likewise.
185 (dlopen): Note why this is necessary in a comment.
186 (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
188 (SHARED_LDFLAGS): Likewise.
189 (BFD_LIBADD): Likewise, for libbfd.
190 (BFD_DEPENDENCIES): Likewise.
191 (VERSION_FLAGS): Initialize, using a version script if ld supports
192 one, or libtool -export-symbols-regex otherwise.
193 (AC_CONFIG_MACRO_DIR): Add ../BFD.
194 * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
196 (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
197 (noinst_LIBRARIES): Replace with...
198 [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
199 [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
200 libctf-nobfd.la as well.
201 [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
202 [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
203 (libctf_a_SOURCES): Rename to...
204 (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
206 (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
207 with ctf-open-bfd.c added.
208 (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
209 (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
210 (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
211 * Makefile.am [INSTALL_LIBCTF]: Use it.
212 * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
214 * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
215 the unstable components).
216 * Makefile.in: Regenerated.
217 * config.h.in: Likewise.
218 * configure: Likewise.
220 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
222 * configure.ac (INSTALL_LIBCTF): New, controlled by
223 --enable-install-libctf.
224 [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
225 * Makefile.in: Regenerated.
226 * configure: Regenerated.
228 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
230 * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
231 * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
233 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
235 * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
237 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
239 * ctf-impl.h (includes): Include <sys/param.h> here.
241 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
243 * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
244 (flip_objts): Likewise.
245 (flip_vars): Likewise.
246 (flip_types): Likewise.
248 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
250 * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
251 freeing functions: if set, free the key and value if the slot
252 already exists. Always reassign the key.
253 (ctf_dynhash_insert): Adjust call appropriately.
254 (ctf_hash_insert_type): Likewise.
256 2019-08-03 Nick Alcock <nick.alcock@oracle.com>
258 * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
259 type kind. Allow forwards to unify with pre-existing structs/
262 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
264 * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
265 <ctf_link_memb_name_changer>: Likewise.
266 <ctf_link_memb_name_changer_arg>: Likewise.
267 * ctf-create.c (ctf_update): Update accordingly.
268 * ctf-open.c (ctf_file_close): Likewise.
269 * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
270 (ctf_link_add_cu_mapping): New.
271 (ctf_link_set_memb_name_changer): Likewise.
272 (ctf_change_parent_name): New.
273 (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
274 allocated by the caller's ctf_link_memb_name_changer.
275 <ndynames>: Likewise.
276 (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
277 (ctf_link_write): Likewise (for _CTF_SECTION only): also call
278 ctf_change_parent_name. Free any resulting names.
280 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
282 * ctf-link.c (ctf_create_per_cu): New, refactored out of...
283 (ctf_link_one_type): ... here, with parent-name setting added.
284 (check_variable): New.
285 (ctf_link_one_variable): Likewise.
286 (ctf_link_one_input_archive_member): Call it.
287 * ctf-error.c (_ctf_errlist): Updated with new errors.
289 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
291 * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
292 (struct ctf_link_type_mapping_key): New.
293 (ctf_hash_type_mapping_key): Likewise.
294 (ctf_hash_eq_type_mapping_key): Likewise.
295 (ctf_add_type_mapping): Likewise.
296 (ctf_type_mapping): Likewise.
297 (ctf_dynhash_empty): Likewise.
298 * ctf-open.c (ctf_file_close): Update accordingly.
299 * ctf-create.c (ctf_update): Likewise.
300 (ctf_add_type): Populate the mapping.
301 * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
302 (ctf_hash_eq_type_mapping_key): Check the key for equality.
303 (ctf_dynhash_insert): Fix comment typo.
304 (ctf_dynhash_empty): New.
305 * ctf-link.c (ctf_add_type_mapping): New.
306 (ctf_type_mapping): Likewise.
307 (empty_link_type_mapping): New.
308 (ctf_link_one_input_archive): Call it.
310 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
312 * ctf-link.c: New file, linking of the string and type sections.
313 * Makefile.am (libctf_a_SOURCES): Add it.
314 * Makefile.in: Regenerate.
316 * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
318 * ctf-create.c (ctf_update): Update accordingly.
319 * ctf-open.c (ctf_file_close): Likewise.
320 * ctf-error.c (_ctf_errlist): Updated with new errors.
322 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
324 * ctf-dump.c (ctf_dump_funcs): Check the right error value.
326 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
328 * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
330 (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
331 (ctf_dump_format_type): Add non-root-type { } notation.
332 Add root flag to prototype.
333 (ctf_dump_label): Adjust accordingly.
334 (ctf_dump_objts): Likewise.
335 (ctf_dump_var): Likewise.
337 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
339 * ctf-create.c (ctf_compress_write): Fix double-free.
341 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
343 * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
345 (ctf_arc_write_fd): ... this new function.
346 * ctf-create.c (ctf_write_mem): New.
348 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
350 * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
351 (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
352 (ctf_str_add_ref): Name the last arg.
353 (ctf_str_add_external) New.
354 (ctf_str_add_strraw_explicit): Likewise.
355 (ctf_simple_open_internal): Likewise.
356 (ctf_bufopen_internal): Likewise.
358 * ctf-string.c (ctf_strraw_explicit): Split from...
359 (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
360 (ctf_str_add_ref_internal): Return the atom, not the
362 (ctf_str_add): Adjust accordingly.
363 (ctf_str_add_ref): Likewise. Move up in the file.
364 (ctf_str_add_external): New: update the csa_offset.
365 (ctf_str_count_strtab): Only account for strings with no csa_offset
366 in the internal strtab length.
367 (ctf_str_write_strtab): If the csa_offset is set, update the
368 string's refs without writing the string out, and update the
369 ctf_syn_ext_strtab. Make OOM handling less ugly.
370 * ctf-create.c (struct ctf_sort_var_arg_cb): New.
371 (ctf_update): Handle failure to populate the strtab. Pass in the
372 new ctf_sort_var arg. Adjust for ctf_syn_ext_strtab addition.
373 Call ctf_simple_open_internal, not ctf_simple_open.
374 (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
376 * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
377 ctf_strraw). Adjust to diagnose ECTF_STRTAB nonetheless.
378 * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
379 (ctf_file_close): Destroy the ctf_syn_ext_strtab.
380 (ctf_simple_open): Rename to, and reimplement as a wrapper around...
381 (ctf_simple_open_internal): ... this new function, which calls
382 ctf_bufopen_internal.
383 (ctf_bufopen): Rename to, and reimplement as a wrapper around...
384 (ctf_bufopen_internal): ... this new function, which sets
387 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
389 * ctf_types.c (ctf_type_iter_all): New.
391 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
393 * ctf-open.c (init_symtab): Check for overflow against the right
395 (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
396 (upgrade_types_v1): Note that these sections are not checked.
397 (flip_header): Endian-swap the header fields.
398 (flip_ctf): Endian-swap the sections.
399 (flip_objts): Update comment.
400 (ctf_bufopen): Check header offsets and alignment for validity.
402 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
404 * ctf-open-bfd.c: Add <assert.h>.
405 (ctf_bfdopen_ctfsect): Open string and symbol tables using
406 techniques borrowed from bfd_elf_sym_name.
407 (ctf_new_archive_internal): Improve comment.
408 * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
409 * ctf-open.c (ctf_bufopen): Allow opening with a string section but
410 no symbol section, but not vice versa.
412 2019-07-08 Nick Alcock <nick.alcock@oracle.com>
414 * ctf-impl.h (ctf_file_t): New field ctf_openflags.
415 * ctf-open.c (ctf_bufopen): Set it. No longer dump header offsets.
416 * ctf-dump.c (dump_header): New function, dump the CTF header.
418 (ctf_dump_header_strfield): New function.
419 (ctf_dump_header_sectfield): Likewise.
421 2019-07-06 Nick Alcock <nick.alcock@oracle.com>
423 * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
424 ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
425 * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
426 ctf_base: do not assume that it is always sizeof (ctf_header_t).
427 Print out ctf_cuname: only print out ctf_parname if set.
428 (ctf_free_base): Removed, ctf_base is no longer freed: free
430 (ctf_set_version): Fix spacing.
431 (upgrade_header): New, in-place header upgrading.
432 (upgrade_types): Rename to...
433 (upgrade_types_v1): ... this. Free ctf_dynbase, not ctf_base. No
434 longer track old and new headers separately. No longer allow for
435 header sizes explicitly: squeeze the headers out on upgrade (they
436 are preserved in fp->ctf_header). Set ctf_dynbase, ctf_base and
437 ctf_buf explicitly. Use ctf_free, not ctf_free_base.
438 (upgrade_types): New, also handle ctf_parmax updating.
439 (flip_header): Flip ctf_cuname.
440 (flip_types): Flip BUF explicitly rather than deriving BUF from
442 (ctf_bufopen): Store the header in fp->ctf_header. Correct minimum
443 required alignment of objtoff and funcoff. No longer store it in
444 the ctf_buf unless that buf is derived unmodified from the input.
445 Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
446 that duplicate fields in ctf_file: move allocation of ctf_file
447 further up instead. Call upgrade_header as needed. Move
448 version-specific ctf_parmax initialization into upgrade_types. More
449 concise error handling.
450 (ctf_file_close): No longer test for null pointers before freeing.
451 Free ctf_dyncuname, ctf_dynbase, and ctf_header. Do not call
454 (ctf_cuname_set): New.
455 * ctf-create.c (ctf_update): Populate ctf_cuname.
456 (ctf_gzwrite): Write out the header explicitly. Remove obsolescent
458 (ctf_write): Likewise.
459 (ctf_compress_write): Get the header from ctf_header, not ctf_base.
460 Fix the compression length: fp->ctf_size never counted the CTF
461 header. Simplify the compress call accordingly.
463 2019-07-11 Hans-Peter Nilsson <hp@bitrange.com>
465 * ctf-endian.h: Don't assume htole64 and le64toh are always
466 present if HAVE_ENDIAN_H; also check if htole64 is defined.
467 [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
468 not bswap_identity_64.
470 2019-09-18 Alan Modra <amodra@gmail.com>
472 * ctf-open-bfd.c: Update throughout for bfd section macro changes.
474 2019-09-09 Phil Blundell <pb@pbcl.net>
476 binutils 2.33 branch created.
478 2019-07-18 Nick Alcock <nick.alcock@oracle.com>
480 * ctf-types.c (ctf_type_aname_raw): New.
481 (ctf_func_type_info): Likewise.
482 (ctf_func_type_args): Likewise.
483 * ctf-error.c (_ctf_errlist): Fix description.
484 * ctf-lookup.c: Fix file description.
486 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
488 * ctf-create.c (ctf_create): Fix off-by-one error.
490 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
492 * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
494 (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
495 (struct ctf_str_atom): New, disambiguated single string.
496 (struct ctf_str_atom_ref): New, points to some other location that
497 references this string's offset.
498 (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
499 Remove member ctf_dtvstrlen: we no longer track the total strlen
501 (ctf_str_create_atoms): Declare new function in ctf-string.c.
502 (ctf_str_free_atoms): Likewise.
503 (ctf_str_add): Likewise.
504 (ctf_str_add_ref): Likewise.
505 (ctf_str_rollback): Likewise.
506 (ctf_str_purge_refs): Likewise.
507 (ctf_str_write_strtab): Likewise.
508 (ctf_realloc): Declare new function in ctf-util.c.
510 * ctf-open.c (ctf_bufopen): Create the atoms table.
511 (ctf_file_close): Destroy it.
512 * ctf-create.c (ctf_update): Copy-and-free it on update. No longer
513 special-case the position of the parname string. Construct the
514 strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
515 rest of each buffer element is constructed, not via open-coding:
516 realloc the CTF buffer and append the strtab to it. No longer
517 maintain ctf_dtvstrlen. Sort the variable entry table later, after
519 (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
520 (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
521 after buffer element construction instead.
522 (ctf_copy_lmembers): Likewise.
523 (ctf_copy_emembers): Likewise.
524 (ctf_create): No longer maintain the ctf_dtvstrlen.
525 (ctf_dtd_delete): Likewise.
526 (ctf_dvd_delete): Likewise.
527 (ctf_add_generic): Likewise.
528 (ctf_add_enumerator): Likewise.
529 (ctf_add_member_offset): Likewise.
530 (ctf_add_variable): Likewise.
532 * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
533 if there are active ctf_str_num_refs.
534 (ctf_strraw): Move to ctf-string.c.
535 (ctf_strptr): Likewise.
536 * ctf-string.c: New file, strtab manipulation.
538 * Makefile.am (libctf_a_SOURCES): Add it.
539 * Makefile.in: Regenerate.
541 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
543 * ctf-impl.h (ctf_hash_iter_f): New.
544 (ctf_dynhash_iter): New declaration.
545 (ctf_dynhash_iter_remove): New declaration.
546 * ctf-hash.c (ctf_dynhash_iter): Define.
547 (ctf_dynhash_iter_remove): Likewise.
548 (ctf_hashtab_traverse): New.
549 (ctf_hashtab_traverse_remove): Likewise.
550 (struct ctf_traverse_cb_arg): Likewise.
551 (struct ctf_traverse_remove_cb_arg): Likewise.
553 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
555 * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
557 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
559 * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
560 (ctf_dump_funcs): Likewise.
562 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
564 * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
565 (ctf_fdopen): Check for endian-swapped raw CTF magic, and
566 little-endian CTF archive magic. Do not check the CTF version:
567 ctf_simple_open does that in endian-safe ways. Do not dereference
568 null pointers on open failure.
570 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
572 * ctf-open.c (get_vbytes_common): Return the new slice size.
573 (ctf_bufopen): Flip the endianness of the CTF-section header copy.
574 Remember to copy in the CTF data when opening an uncompressed
575 foreign-endian CTF file. Prune useless variable manipulation.
577 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
579 * ctf-open.c (ctf_types): Fail when unidentified type kinds are
582 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
584 * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
587 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
589 * ctf-subr.c (_PAGESIZE): Remove.
590 (ctf_data_alloc): Likewise.
591 (ctf_data_free): Likewise.
592 (ctf_data_protect): Likewise.
593 * ctf-impl.h: Remove declarations.
594 * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
595 ctf_free, not ctf_data_free.
596 (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc. Free
597 the buffer again on compression error.
598 * ctf-open.c (ctf_set_base): No longer track the size: call
599 ctf_free, not ctf_data_free.
600 (upgrade_types): Likewise. Call ctf_alloc, not ctf_data_alloc.
601 (ctf_bufopen): Likewise. No longer call ctf_data_protect.
603 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
605 * ctf-create.c (ctf_dtd_insert): Pass on error returns from
607 (ctf_dvd_insert): Likewise.
608 (ctf_add_generic): Likewise.
609 (ctf_add_variable): Likewise.
610 * ctf-impl.h: Adjust declarations.
612 2019-06-14 Alan Modra <amodra@gmail.com>
614 * configure: Regenerate.
616 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
618 * ctf-decls.h: Include <libiberty.h>.
619 * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
621 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
623 * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
624 (ctf_dump_objts): Likewise.
625 (ctf_dump_funcs): Likewise.
626 (ctf_dump_member): Likewise.
627 (ctf_dump_str): Likewise.
629 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
631 * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
632 * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
634 2019-06-05 Nick Alcock <nick.alcock@oracle.com>
636 * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
637 (ctf_arc_open_by_offset): Likewise.
638 * ctf-create.c (ctf_add_type): Likewise.
640 2019-06-04 Tom Tromey <tromey@adacore.com>
642 * ctf-create.c (ctf_add_encoded, ctf_add_slice)
643 (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
645 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
647 * configure.ac: Check for O_CLOEXEC.
648 * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
649 * config.h.in: Regenerate.
650 * configure: Likewise.
652 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
654 * qsort_r.c: Rename to...
655 * ctf-qsort_r.c: ... this.
656 (_quicksort): Define to ctf_qsort_r.
657 * ctf-decls.h (qsort_r): Remove.
659 (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
660 (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
661 * Makefile.am (libctf_a_LIBADD): Remove.
662 (libctf_a_SOURCES): New, add ctf-qsort_r.c.
663 * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
664 * ctf-create.c (ctf_update): Likewise.
665 * configure.ac: Check for BSD versus GNU qsort_r signature.
666 * Makefile.in: Regenerate.
667 * config.h.in: Likewise.
668 * configure: Likewise.
670 2019-06-03 Nick Alcock <nick.alcock@oracle.com>
672 * ctf-dump.c (ctf_dump_funcs): Free in the right place.
674 2019-05-29 Nick Alcock <nick.alcock@oracle.com>
676 * Makefile.am (ZLIB): New.
678 (AM_CFLAGS): Use them.
679 (libctf_a_LIBADD): New, for LIBOBJS.
680 * configure.ac: Check for zlib, endian.h, and qsort_r.
681 * ctf-endian.h: New, providing htole64 and le64toh.
682 * swap.h: Code style fixes.
683 (bswap_identity_64): New.
684 * qsort_r.c: New, from gnulib (with one added #include).
685 * ctf-decls.h: New, providing a conditional qsort_r declaration,
686 and unconditional definitions of MIN and MAX.
687 * ctf-impl.h: Use it. Do not use <sys/errno.h>.
688 (ctf_set_errno): Now returns unsigned long.
689 * ctf-util.c (ctf_set_errno): Adjust here too.
690 * ctf-archive.c: Use ctf-endian.h.
691 (ctf_arc_open_by_offset): Use memset, not bzero. Drop cts_type,
692 cts_flags and cts_offset.
693 (ctf_arc_write): Drop debugging dependent on the size of off_t.
694 * ctf-create.c: Provide a definition of roundup if not defined.
695 (ctf_create): Drop cts_type, cts_flags and cts_offset.
696 (ctf_add_reftype): Do not check if type IDs are below zero.
697 (ctf_add_slice): Likewise.
698 (ctf_add_typedef): Likewise.
699 (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
700 when known error-free. Drop CTF_ERR usage for functions returning
702 (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
704 (ctf_add_variable): Likewise.
708 (ctf_add_type): Likewise. Cast error-returning ssize_t's to size_t
709 when known error-free.
710 * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
711 returning int: use CTF_ERR for functions returning ctf_type_id.
712 (ctf_dump_label): Likewise.
713 (ctf_dump_objts): Likewise.
714 * ctf-labels.c (ctf_label_topmost): Likewise.
715 (ctf_label_iter): Likewise.
716 (ctf_label_info): Likewise.
717 * ctf-lookup.c (ctf_func_args): Likewise.
718 * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
719 (ctf_bufopen): Likewise. Use zlib types as needed.
720 * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
722 (ctf_enum_iter): Likewise.
723 (ctf_type_size): Likewise.
724 (ctf_type_align): Likewise. Cast to size_t where appropriate.
725 (ctf_type_kind_unsliced): Likewise.
726 (ctf_type_kind): Likewise.
727 (ctf_type_encoding): Likewise.
728 (ctf_member_info): Likewise.
729 (ctf_array_info): Likewise.
730 (ctf_enum_value): Likewise.
731 (ctf_type_rvisit): Likewise.
732 * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
734 (ctf_simple_open): Likewise.
735 (ctf_bfdopen_ctfsect): Likewise. Set cts_size properly.
736 * Makefile.in: Regenerate.
737 * aclocal.m4: Likewise.
738 * config.h: Likewise.
739 * configure: Likewise.
741 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
743 * configure.in: Check for bfd_section_from_elf_index.
744 * configure: Regenerate.
745 * config.h.in [HAVE_BFD_ELF]: Likewise.
746 * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
747 abfd is potentially unused now.
749 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
752 * Makefile.in: Regenerated.
753 * config.h.in: Likewise.
754 * aclocal.m4: Likewise.
755 * configure: Likewise.
757 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
761 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
765 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
767 * ctf-impl.h (_libctf_version): New declaration.
768 * ctf-subr.c (_libctf_version): Define it.
771 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
773 * ctf-create.c (enumcmp): New.
777 (ctf_add_type): Likewise.
779 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
781 * ctf-lookup.c (isqualifier): New.
782 (ctf_lookup_by_name): Likewise.
783 (struct ctf_lookup_var_key): Likewise.
784 (ctf_lookup_var): Likewise.
785 (ctf_lookup_variable): Likewise.
786 (ctf_lookup_symbol_name): Likewise.
787 (ctf_lookup_by_symbol): Likewise.
788 (ctf_func_info): Likewise.
789 (ctf_func_args): Likewise.
791 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
793 * ctf-decl.c: New file.
794 * ctf-types.c: Likewise.
795 * ctf-impl.h: New declarations.
797 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
799 * ctf-open-bfd.c: New file.
800 * ctf-open.c (ctf_close): New.
801 * ctf-impl.h: Include bfd.h.
802 (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
803 (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
805 (ctf_bfdopen_ctfsect): New declaration.
806 (_CTF_SECTION): likewise.
808 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
810 * ctf-archive.c: New.
811 * ctf-impl.h (ctf_archive_internal): New type.
812 (ctf_arc_open_internal): New declaration.
813 (ctf_arc_bufopen): Likewise.
814 (ctf_arc_close_internal): Likewise.
816 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
818 * ctf-open.c: New file.
821 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
823 * ctf-create.c: New file.
824 * ctf-lookup.c: New file.
826 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
828 * ctf-impl.h: New definitions and declarations for type creation
831 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
833 * ctf-hash.c: New file.
834 * ctf-impl.h: New declarations.
836 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
838 * ctf-error.c: New file.
840 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
842 * ctf-util.c: New file.
844 * ctf-impl.h: Include it, and add declarations.
846 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
848 * ctf-impl.h: New file.
849 * ctf-subr.c: New file.
856 version-control: never