libctf/ChangeLog

   1 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
   2
   3         * ctf-impl.h (ctf_assert): New.
   4         (ctf_err_warning_t): Likewise.
   5         (ctf_file_t) <ctf_errs_warnings>: Likewise.
   6         (ctf_err_warn): New prototype.
   7         (ctf_assert_fail_internal): Likewise.
   8         * ctf-inlines.h (ctf_assert_internal): Likewise.
   9         * ctf-open.c (ctf_file_close): Free ctf_errs_warnings.
  10         * ctf-create.c (ctf_serialize): Copy it on serialization.
  11         * ctf-subr.c (ctf_err_warn): New, add an error/warning.
  12         (ctf_errwarning_next): New iterator, free and pass back
  13         errors/warnings in succession.
  14         * libctf.ver (ctf_errwarning_next): Add.
  15
  16 2020-07-22  Egeyar Bagcioglu  <egeyar.bagcioglu@oracle.com>
  17
  18         * ctf-types.c (ctf_variable_iter): Fix error return.
  19
  20 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  21
  22         * ctf-open.c (ctf_bufopen_internal): Diagnose invalid flags.
  23
  24 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  25
  26         ctf-decls.h (ctf_qsort_compar_thunk): Fix arg passing.
  27
  28 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  29
  30         * ctf-impl.h (ctf_next_hkv_t): New, kv-pairs passed to
  31         sorting functions.
  32         (ctf_next_t) <u.ctn_sorted_hkv>: New, sorted kv-pairs for
  33         ctf_dynhash_next_sorted.
  34         <cu.ctn_h>: New, pointer to the dynhash under iteration.
  35         <cu.ctn_s>: New, pointer to the dynset under iteration.
  36         (ctf_hash_sort_f): Sorting function passed to...
  37         (ctf_dynhash_next_sorted): ... this new function.
  38         (ctf_dynhash_next): New.
  39         (ctf_dynset_next): New.
  40         * ctf-inlines.h (ctf_dynhash_cnext_sorted): New.
  41         (ctf_dynhash_cnext): New.
  42         (ctf_dynset_cnext): New.
  43         * ctf-hash.c (ctf_dynhash_next_sorted): New.
  44         (ctf_dynhash_next): New.
  45         (ctf_dynset_next): New.
  46         * ctf-util.c (ctf_next_destroy): Free the u.ctn_sorted_hkv if
  47         needed.
  48         (ctf_next_copy): Alloc-and-copy the u.ctn_sorted_hkv if needed.
  49
  50 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  51
  52         * ctf-impl.h (ctf_next): New.
  53         (ctf_get_dict): New prototype.
  54         * ctf-lookup.c (ctf_get_dict): New, split out of...
  55         (ctf_lookup_by_id): ... here.
  56         * ctf-util.c (ctf_next_create): New.
  57         (ctf_next_destroy): New.
  58         (ctf_next_copy): New.
  59         * ctf-types.c (includes): Add <assert.h>.
  60         (ctf_member_next): New.
  61         (ctf_enum_next): New.
  62         (ctf_type_iter): Document the lack of iteration over parent
  63         types.
  64         (ctf_type_next): New.
  65         (ctf_variable_next): New.
  66         * ctf-archive.c (ctf_archive_next): New.
  67         * libctf.ver: Add new public functions.
  68
  69 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  70
  71         * libctf.ver (ctf_ref): New.
  72         * ctf-open.c (ctf_ref): Implement it.
  73
  74 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  75
  76         * ctf-inlines.h (ctf_forwardable_kind): New.
  77         * ctf-create.c (ctf_add_forward): Use it.
  78
  79 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  80
  81         * ctf-impl.h (ctf_get_ctt_size): Move definition from here...
  82         * ctf-inlines.h (ctf_get_ctt_size): ... to here.
  83
  84 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
  85
  86         * ctf-hash.c (ctf_dynset_eq_string): New.
  87         (ctf_dynset_create): New.
  88         (DYNSET_EMPTY_ENTRY_REPLACEMENT): New.
  89         (DYNSET_DELETED_ENTRY_REPLACEMENT): New.
  90         (key_to_internal): New.
  91         (internal_to_key): New.
  92         (ctf_dynset_insert): New.
  93         (ctf_dynset_remove): New.
  94         (ctf_dynset_destroy): New.
  95         (ctf_dynset_lookup): New.
  96         (ctf_dynset_exists): New.
  97         (ctf_dynset_lookup_any): New.
  98         (ctf_hash_insert_type): Coding style.
  99         (ctf_hash_define_type): Likewise.
 100         * ctf-impl.h (ctf_dynset_t): New.
 101         (ctf_dynset_eq_string): New.
 102         (ctf_dynset_create): New.
 103         (ctf_dynset_insert): New.
 104         (ctf_dynset_remove): New.
 105         (ctf_dynset_destroy): New.
 106         (ctf_dynset_lookup): New.
 107         (ctf_dynset_exists): New.
 108         (ctf_dynset_lookup_any): New.
 109         * ctf-inlines.h (ctf_dynset_cinsert): New.
 110
 111 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 112
 113         * ctf-hash.c (ctf_helem_t) <key_free>: Remove.
 114         <value_free>: Likewise.
 115         <owner>: New.
 116         (ctf_dynhash_item_free): Indirect through the owner.
 117         (ctf_dynhash_create): Only pass in ctf_dynhash_item_free and
 118         allocate space for the key_free and value_free fields fields
 119         if necessary.
 120         (ctf_hashtab_insert): Likewise.  Fix OOM errno value.
 121         (ctf_dynhash_insert): Only access ctf_hashtab's key_free and
 122         value_free if they will exist.  Set the slot's owner, but only
 123         if it exists.
 124         (ctf_dynhash_remove): Adjust.
 125
 126 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 127
 128         * ctf-hash.c (ctf_hashtab_insert): Free the key passed in if
 129         there is a key-freeing function and the key already exists.
 130
 131 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 132
 133         * ctf-inlines.h: New file.
 134         * ctf-impl.h: Include it.
 135         (ctf_hash_iter_find_f): New typedef.
 136         (ctf_dynhash_elements): New.
 137         (ctf_dynhash_lookup_kv): New.
 138         (ctf_dynhash_iter_find): New.
 139         * ctf-hash.c (ctf_dynhash_lookup_kv): New.
 140         (ctf_traverse_find_cb_arg_t): New.
 141         (ctf_hashtab_traverse_find): New.
 142         (ctf_dynhash_iter_find): New.
 143         (ctf_dynhash_elements): New.
 144
 145 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 146
 147         * ctf-impl.h [!__GNUC__] (__extension__): Define to nothing.
 148
 149 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 150
 151         * ctf-archive.c (ctf_archive_count): New.
 152         * libctf.ver: New public function.
 153
 154 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 155
 156         * ctf-types.c (ctf_member_count): New.
 157         * libctf.ver: New public function.
 158
 159 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 160
 161         * ctf-types.c (ctf_type_kind_forwarded): New.
 162
 163 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 164
 165         * ctf-types.c (ctf_type_name_raw): New.
 166         (ctf_type_aname_raw): Reimplement accordingly.
 167
 168 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 169
 170         * ctf-subr.c (ctf_dprintf): _libctf_debug is unlikely to be set.
 171
 172 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 173
 174         * ctf-impl.h (struct ctf_archive_internal)
 175         <ctfi_unmap_on_close>: New.
 176         (ctf_new_archive_internal): Adjust.
 177         * ctf-archive.c (ctf_new_archive_internal): Likewise.
 178         Initialize ctfi_unmap_on_close.  Adjust error path.
 179         (ctf_arc_bufopen): Adjust ctf_new_archive_internal call
 180         (unmap_on_close is 0).
 181         (ctf_arc_close): Only unmap if ctfi_unmap_on_close.
 182         * ctf-open-bfd.c (ctf_fdopen): Adjust.
 183
 184 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 185
 186         * ctf-types.c (ctf_type_aname): Return ECTF_CORRUPT if
 187         ints, floats or typedefs have no name.  Fix comment typo.
 188
 189 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 190
 191         * ctf-create.c (ctf_add_slice): Support slices of any kind that
 192         resolves to an integral type.
 193         * ctf-types.c (ctf_type_encoding): Resolve the type before
 194         fishing its encoding out.
 195
 196 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 197
 198         * ctf-create.c (ctf_create): Mark dirty.
 199
 200 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 201
 202         * ctf-create.c (membcmp)  Skip nameless members.
 203
 204 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 205
 206         * ctf-create.c (ctf_add_member_offset): Support names of ""
 207         as if they were the null pointer.
 208
 209 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 210
 211         * ctf-open.c (init_types): Remove typeless CTF_K_FORWARD
 212         special-casing.
 213
 214 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 215
 216         * ctf-types.c (ctf_type_reference): Add support for dynamic slices.
 217
 218 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 219
 220         * ctf-create.c (ctf_serialize): Add cast.
 221         (ctf_add_slice): Likewise.
 222
 223 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 224
 225         * ctf-impl.h (ctf_dtdef_t) <dtu_argv>: Fix type.
 226         * ctf-create.c (ctf_add_function): Check for unimplemented type
 227         and populate at the same time.  Populate one-by-one, not via
 228         memcpy.
 229         (ctf_serialize): Remove unnecessary cast.
 230         * ctf-types.c (ctf_func_type_info): Likewise.
 231         (ctf_func_type_args): Likewise.  Fix comment typo.
 232
 233 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 234
 235         * ctf-create.c (ctf_add_reftype): Support refs to type zero.
 236         (ctf_add_array): Support array contents of type zero.
 237         (ctf_add_function): Support arguments and return types of
 238         type zero.
 239         (ctf_add_typedef): Support typedefs to type zero.
 240         (ctf_add_member_offset): Support members of type zero,
 241         unless added at unspecified (naturally-aligned) offset.
 242
 243 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 244
 245         * ctf-error.c: Include <stddef.h>, for offsetof.
 246         (_ctf_errlist): Migrate to...
 247         (_ctf_errlist_t): ... this.
 248         (_ctf_erridx): New, indexes into _ctf_errlist_t.
 249         (_ctf_nerr): Remove.
 250         (ctf_errmsg): Adjust accordingly.
 251         * Makefile.am (BUILT_SOURCES): Note...
 252         (ctf-error.h): ... this new rule.
 253         * Makefile.in: Regenerate.
 254         * mkerrors.sed: New, process ctf-api.h to generate ctf-error.h.
 255         * .gitignore: New, ignore ctf-error.h.
 256
 257 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 258
 259         * ctf-impl.h: Fix typos in comments.
 260
 261 2020-07-22  Nick Clifton  <nickc@redhat.com>
 262
 263         * ctf-archive.c (ctf_arc_write): Avoid calling close twice on the
 264         same file descriptor.
 265
 266 2020-07-04  Nick Clifton  <nickc@redhat.com>
 267
 268         Binutils 2.35 branch created.
 269
 270 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 271
 272         * aclocal.m4: Add config/gettext-sister.m4: Shuffle into
 273         alphabetical order.
 274         * configure.ac: Add ZW_GNU_GETTEXT_SISTER_DIR.
 275         * config.h.in: Regenerated.
 276         * Makefile.in: Likewise.
 277         * configure: Likewise.
 278
 279 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 280
 281         * ctf-create.c: Include <unistd.h>.
 282         * ctf-open-bfd.c: Likewise.
 283
 284 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 285
 286         PR libctf/25120
 287         * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls.
 288         * swap.h (bswap_16): Do not assume that presence of <byteswap.h>
 289         means this is declared.
 290         (bswap_32): Likewise.
 291         (bswap_64): Likewise.
 292         (bswap_identity_64): Remove, unused.
 293         * configure: Regenerated.
 294         * config.h.in: Likewise.
 295
 296 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 297
 298         PR libctf/25120
 299         * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback.
 300         (_libctf_unlikely_): Likewise.
 301         (_libctf_unused): Likewise.
 302         (_libctf_malloc_): Likewise.
 303
 304 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 305
 306         PR libctf/25120
 307         * ctf-archive.c (search_nametbl): No longer global: declare...
 308         (ctf_arc_open_by_name_internal): ... here. Use bsearch_r.
 309         (search_modent_by_name): Take and use ARG for the nametbl.
 310
 311 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 312
 313         * ctf-impl.h (ctf_new_archive_internal): Declare.
 314         (ctf_arc_bufopen): Remove.
 315         (ctf_archive_internal) <ctfi_free_symsect>: New.
 316         * ctf-archive.c (ctf_arc_close): Use it.
 317         (ctf_arc_bufopen): Fuse into...
 318         (ctf_new_archive_internal): ... this, moved across from...
 319         * ctf-open-bfd.c: ... here.
 320         (ctf_bfdopen_ctfsect): Use ctf_arc_bufopen.
 321         * libctf.ver: Add it.
 322
 323 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 324
 325         * ctf-create.c (ctf_add_forward): Intern in the right namespace.
 326         (ctf_dtd_delete): Remove correspondingly.
 327         (ctf_rollback): Likewise.
 328
 329 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 330
 331         * ctf-create.c (ctf_add_type_internal): Hand back existing types
 332         unchanged.
 333
 334 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 335
 336         * ctf-create.c (ctf_add_forward): Don't add forwards to
 337         types that already exist.
 338
 339 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 340
 341         * ctf-open.c (init_types): Only intern root-visible types.
 342         * ctf-create.c (ctf_dtd_insert): Likewise.
 343         (ctf_dtd_delete): Only remove root-visible types.
 344         (ctf_rollback): Likewise.
 345         (ctf_add_generic): Adjust.
 346         (ctf_add_struct_sized): Adjust comment.
 347         (ctf_add_union_sized): Likewise.
 348         (ctf_add_enum): Likewise.
 349         * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
 350
 351 2020-03-11  John Baldwin  <jhb@FreeBSD.org>
 352
 353         * swap.h (bswap_identity_64): Make static.
 354
 355 2020-01-18  Nick Clifton  <nickc@redhat.com>
 356
 357         Binutils 2.34 branch created.
 358
 359 2020-01-05  Joel Brobecker  <brobecker@adacore.com>
 360
 361         PR binutils/25155:
 362         * configure.ac: Add AC_CHECK_DECLS([asprintf]).
 363         * configure, config.h.in: Regenerate.
 364
 365 2020-01-01  Alan Modra  <amodra@gmail.com>
 366
 367         Update year range in copyright notice of all files.
 368
 369 2019-10-16  Simon Marchi  <simon.marchi@polymtl.ca>
 370
 371         * swap.h (bswap_16, bswap_32, bswap_64): Make static.
 372
 373 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
 374
 375         * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
 376         * ctf-types.c (ctf_type_lname): Likewise.
 377
 378 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 379
 380         * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
 381         ctf_import after the first for a given file.
 382
 383 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 384
 385         * ctf-impl.h (ctf_str_append_noerr): Declare.
 386         * ctf-util.c (ctf_str_append_noerr): Define in terms of
 387         ctf_str_append.
 388         * ctf-dump.c (str_append): New, call it.
 389         (ctf_dump_format_type): Use str_append, not ctf_str_append.
 390         (ctf_dump_label): Likewise.
 391         (ctf_dump_objts): Likewise.
 392         (ctf_dump_funcs): Likewise.
 393         (ctf_dump_var): Likewise.
 394         (ctf_dump_member): Likewise.
 395         (ctf_dump_type): Likewise.
 396         (ctf_dump): Likewise.
 397
 398 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 399
 400         * ctf-impl.h (ctf_alloc): Remove.
 401         (ctf_free): Likewise.
 402         (ctf_strdup): Likewise.
 403         * ctf-subr.c (ctf_alloc): Remove.
 404         (ctf_free): Likewise.
 405         * ctf-util.c (ctf_strdup): Remove.
 406
 407         * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
 408         ctf_free; strdup, not ctf_strdup.
 409         (ctf_dtd_delete): Likewise.
 410         (ctf_dvd_delete): Likewise.
 411         (ctf_add_generic): Likewise.
 412         (ctf_add_function): Likewise.
 413         (ctf_add_enumerator): Likewise.
 414         (ctf_add_member_offset): Likewise.
 415         (ctf_add_variable): Likewise.
 416         (membadd): Likewise.
 417         (ctf_compress_write): Likewise.
 418         (ctf_write_mem): Likewise.
 419         * ctf-decl.c (ctf_decl_push): Likewise.
 420         (ctf_decl_fini): Likewise.
 421         (ctf_decl_sprintf): Likewise.  Check for OOM.
 422         * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
 423         ctf_free; strdup, not ctf_strdup.
 424         (ctf_dump_free): Likewise.
 425         (ctf_dump): Likewise.
 426         * ctf-open.c (upgrade_types_v1): Likewise.
 427         (init_types): Likewise.
 428         (ctf_file_close): Likewise.
 429         (ctf_bufopen_internal): Likewise.  Check for OOM.
 430         (ctf_parent_name_set): Likewise: report the OOM to the caller.
 431         (ctf_cuname_set): Likewise.
 432         (ctf_import): Likewise.
 433         * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
 434         free, not ctf_free; strdup, not ctf_strdup.
 435         (ctf_str_free_atom): Likewise.
 436         (ctf_str_create_atoms): Likewise.
 437         (ctf_str_add_ref_internal): Likewise.
 438         (ctf_str_remove_ref): Likewise.
 439         (ctf_str_write_strtab): Likewise.
 440
 441 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
 442
 443         * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
 444         work right for non-int/fps.
 445
 446 2019-08-08  Nick Alcock  <nick.alcock@oracle.com>
 447
 448         * ctf-types.c (ctf_type_name): Don't strlen a potentially-
 449         null pointer.
 450
 451 2019-08-07  Nick Alcock  <nick.alcock@oracle.com>
 452
 453         * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
 454         * ctf-open.c (ctf_file_close): Free it.
 455         * ctf-create.c (ctf_serialize): Adjust.
 456         (membcmp): When reporting a conflict due to an error, report the
 457         error.
 458         (ctf_add_type): Turn into a ctf_add_processing wrapper.  Rename to...
 459         (ctf_add_type_internal): ... this.  Hand back types we are already
 460         in the middle of adding immediately.  Hand back structs/unions with
 461         the same number of members immediately.  Do not walk the dynamic
 462         list.  Call ctf_add_type_internal, not ctf_add_type.  Handle
 463         forwards promoted to other types and the inverse case identically.
 464         Add structs to the mapping as soon as we intern them, before they
 465         gain any members.
 466
 467 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
 468
 469         * ctf-impl.h (ctf_names_t): New.
 470         (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
 471         (ctf_file_t) <ctf_structs>: Likewise.
 472         <ctf_unions>: Likewise.
 473         <ctf_enums>: Likewise.
 474         <ctf_names>: Likewise.
 475         <ctf_lookups>: Improve comment.
 476         <ctf_ptrtab_len>: New.
 477         <ctf_prov_strtab>: New.
 478         <ctf_str_prov_offset>: New.
 479         <ctf_dtbyname>: Remove, redundant to the names hashes.
 480         <ctf_dtnextid>: Remove, redundant to ctf_typemax.
 481         (ctf_dtdef_t) <dtd_name>: Remove.
 482         <dtd_data>: Note that the ctt_name is now populated.
 483         (ctf_str_atom_t) <csa_offset>: This is now the strtab
 484         offset for internal strings too.
 485         <csa_external_offset>: New, the external strtab offset.
 486         (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
 487         (ctf_name_table): New declaration.
 488         (ctf_lookup_by_rawname): Likewise.
 489         (ctf_lookup_by_rawhash): Likewise.
 490         (ctf_set_ctl_hashes): Likewise.
 491         (ctf_serialize): Likewise.
 492         (ctf_dtd_insert): Adjust.
 493         (ctf_simple_open_internal): Likewise.
 494         (ctf_bufopen_internal): Likewise.
 495         (ctf_list_empty_p): Likewise.
 496         (ctf_str_remove_ref): Likewise.
 497         (ctf_str_add): Returns uint32_t now.
 498         (ctf_str_add_ref): Likewise.
 499         (ctf_str_add_external): Now returns a boolean (int).
 500         * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
 501         for strings in the appropriate range.
 502         (ctf_str_create_atoms): Create the ctf_prov_strtab.  Detect OOM
 503         when adding the null string to the new strtab.
 504         (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
 505         (ctf_str_add_ref_internal): Add make_provisional argument.  If
 506         make_provisional, populate the offset and fill in the
 507         ctf_prov_strtab accordingly.
 508         (ctf_str_add): Return the offset, not the string.
 509         (ctf_str_add_ref): Likewise.
 510         (ctf_str_add_external): Return a success integer.
 511         (ctf_str_remove_ref): New, remove a single ref.
 512         (ctf_str_count_strtab): Do not count the initial null string's
 513         length or the existence or length of any unreferenced internal
 514         atoms.
 515         (ctf_str_populate_sorttab): Skip atoms with no refs.
 516         (ctf_str_write_strtab): Populate the nullstr earlier.  Add one
 517         to the cts_len for the null string, since it is no longer done
 518         in ctf_str_count_strtab.  Adjust for csa_external_offset rename.
 519         Populate the csa_offset for both internal and external cases.
 520         Flush the ctf_prov_strtab afterwards, and reset the
 521         ctf_str_prov_offset.
 522         * ctf-create.c (ctf_grow_ptrtab): New.
 523         (ctf_create): Call it.  Initialize new fields rather than old
 524         ones.  Tell ctf_bufopen_internal that this is a writable dictionary.
 525         Set the ctl hashes and data model.
 526         (ctf_update): Rename to...
 527         (ctf_serialize): ... this.  Leave a compatibility function behind.
 528         Tell ctf_simple_open_internal that this is a writable dictionary.
 529         Pass the new fields along from the old dictionary.  Drop
 530         ctf_dtnextid and ctf_dtbyname.  Use ctf_strraw, not dtd_name.
 531         Do not zero out the DTD's ctt_name.
 532         (ctf_prefixed_name): Rename to...
 533         (ctf_name_table): ... this.  No longer return a prefixed name: return
 534         the applicable name table instead.
 535         (ctf_dtd_insert): Use it, and use the right name table.  Pass in the
 536         kind we're adding.  Migrate away from dtd_name.
 537         (ctf_dtd_delete): Adjust similarly.  Remove the ref to the
 538         deleted ctt_name.
 539         (ctf_dtd_lookup_type_by_name): Remove.
 540         (ctf_dynamic_type): Always return NULL on read-only dictionaries.
 541         No longer check ctf_dtnextid: check ctf_typemax instead.
 542         (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
 543         (ctf_rollback): Likewise.  No longer fail with ECTF_OVERROLLBACK. Use
 544         ctf_name_table and the right name table, and migrate away from
 545         dtd_name as in ctf_dtd_delete.
 546         (ctf_add_generic): Pass in the kind explicitly and pass it to
 547         ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid.  Migrate away
 548         from dtd_name to using ctf_str_add_ref to populate the ctt_name.
 549         Grow the ptrtab if needed.
 550         (ctf_add_encoded): Pass in the kind.
 551         (ctf_add_slice): Likewise.
 552         (ctf_add_array): Likewise.
 553         (ctf_add_function): Likewise.
 554         (ctf_add_typedef): Likewise.
 555         (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
 556         ctt_name rather than dtd_name.
 557         (ctf_add_struct_sized): Pass in the kind.  Use
 558         ctf_lookup_by_rawname, not ctf_hash_lookup_type /
 559         ctf_dtd_lookup_type_by_name.
 560         (ctf_add_union_sized): Likewise.
 561         (ctf_add_enum): Likewise.
 562         (ctf_add_enum_encoded): Likewise.
 563         (ctf_add_forward): Likewise.
 564         (ctf_add_type): Likewise.
 565         (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
 566         being initialized until after the call.
 567         (ctf_write_mem): Likewise.
 568         (ctf_write): Likewise.
 569         * ctf-archive.c (arc_write_one_ctf): Likewise.
 570         * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
 571         ctf_hash_lookup_type.
 572         (ctf_lookup_by_id): No longer check the readonly types if the
 573         dictionary is writable.
 574         * ctf-open.c (init_types): Assert that this dictionary is not
 575         writable.  Adjust to use the new name hashes, ctf_name_table,
 576         and ctf_ptrtab_len.  GNU style fix for the final ptrtab scan.
 577         (ctf_bufopen_internal): New 'writable' parameter.  Flip on LCTF_RDWR
 578         if set.  Drop out early when dictionary is writable.  Split the
 579         ctf_lookups initialization into...
 580         (ctf_set_cth_hashes): ... this new function.
 581         (ctf_simple_open_internal): Adjust.  New 'writable' parameter.
 582         (ctf_simple_open): Adjust accordingly.
 583         (ctf_bufopen): Likewise.
 584         (ctf_file_close): Destroy the appropriate name hashes.  No longer
 585         destroy ctf_dtbyname, which is gone.
 586         (ctf_getdatasect): Remove spurious "extern".
 587         * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
 588         specified name table, given a kind.
 589         (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
 590         (ctf_member_iter): Add support for iterating over the
 591         dynamic type list.
 592         (ctf_enum_iter): Likewise.
 593         (ctf_variable_iter): Likewise.
 594         (ctf_type_rvisit): Likewise.
 595         (ctf_member_info): Add support for types in the dynamic type list.
 596         (ctf_enum_name): Likewise.
 597         (ctf_enum_value): Likewise.
 598         (ctf_func_type_info): Likewise.
 599         (ctf_func_type_args): Likewise.
 600         * ctf-link.c (ctf_accumulate_archive_names): No longer call
 601         ctf_update.
 602         (ctf_link_write): Likewise.
 603         (ctf_link_intern_extern_string): Adjust for new
 604         ctf_str_add_external return value.
 605         (ctf_link_add_strtab): Likewise.
 606         * ctf-util.c (ctf_list_empty_p): New.
 607
 608 2019-08-05  Nick Alcock  <nick.alcock@oracle.com>
 609
 610         * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
 611         type zero.
 612         * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
 613         members and types.
 614         (ctf_add_variable): Likewise for variables pointing to them.
 615         * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
 616         type link failure, but do warn for others.
 617         * ctf-dump.c (ctf_dump_format_type): Likewise.  Do not assume all
 618         errors to be ENOMEM.
 619         (ctf_dump_member): Likewise.
 620         (ctf_dump_type): Likewise.
 621         (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
 622         (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
 623         (ctf_dump_header): Likewise.
 624         (ctf_dump_label): likewise.
 625         (ctf_dump_objts): likewise.
 626         (ctf_dump_funcs): likewise.
 627         (ctf_dump_var): likewise.
 628         (ctf_dump_str): Likewise.
 629
 630 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
 631
 632         * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
 633         (LT_INIT): Likewise.
 634         (AM_INSTALL_LIBBFD): Likewise.
 635         (dlopen): Note why this is necessary in a comment.
 636         (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
 637         opcodes/.
 638         (SHARED_LDFLAGS): Likewise.
 639         (BFD_LIBADD): Likewise, for libbfd.
 640         (BFD_DEPENDENCIES): Likewise.
 641         (VERSION_FLAGS): Initialize, using a version script if ld supports
 642         one, or libtool -export-symbols-regex otherwise.
 643         (AC_CONFIG_MACRO_DIR): Add ../BFD.
 644         * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
 645         (INCDIR): New.
 646         (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
 647         (noinst_LIBRARIES): Replace with...
 648         [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
 649         [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
 650         libctf-nobfd.la as well.
 651         [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
 652         [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
 653         (libctf_a_SOURCES): Rename to...
 654         (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
 655         ctf-open-bfd.c.
 656         (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
 657         with ctf-open-bfd.c added.
 658         (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
 659         (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
 660         (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
 661         * Makefile.am [INSTALL_LIBCTF]: Use it.
 662         * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
 663         libtool macros.
 664         * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
 665         the unstable components).
 666         * Makefile.in: Regenerated.
 667         * config.h.in: Likewise.
 668         * configure: Likewise.
 669
 670 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 671
 672         * configure.ac (INSTALL_LIBCTF): New, controlled by
 673         --enable-install-libctf.
 674         [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
 675         * Makefile.in: Regenerated.
 676         * configure: Regenerated.
 677
 678 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 679
 680         * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
 681         * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
 682
 683 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 684
 685         * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
 686
 687 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 688
 689         * ctf-impl.h (includes): Include <sys/param.h> here.
 690
 691 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 692
 693         * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
 694         (flip_objts): Likewise.
 695         (flip_vars): Likewise.
 696         (flip_types): Likewise.
 697
 698 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 699
 700         * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
 701         freeing functions: if set, free the key and value if the slot
 702         already exists.  Always reassign the key.
 703         (ctf_dynhash_insert): Adjust call appropriately.
 704         (ctf_hash_insert_type): Likewise.
 705
 706 2019-08-03  Nick Alcock  <nick.alcock@oracle.com>
 707
 708         * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
 709         type kind.  Allow forwards to unify with pre-existing structs/
 710         unions/enums.
 711
 712 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 713
 714         * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
 715         <ctf_link_memb_name_changer>: Likewise.
 716         <ctf_link_memb_name_changer_arg>: Likewise.
 717         * ctf-create.c (ctf_update): Update accordingly.
 718         * ctf-open.c (ctf_file_close): Likewise.
 719         * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
 720         (ctf_link_add_cu_mapping): New.
 721         (ctf_link_set_memb_name_changer): Likewise.
 722         (ctf_change_parent_name): New.
 723         (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
 724         allocated by the caller's ctf_link_memb_name_changer.
 725         <ndynames>: Likewise.
 726         (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
 727         (ctf_link_write): Likewise (for _CTF_SECTION only): also call
 728         ctf_change_parent_name.  Free any resulting names.
 729
 730 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 731
 732         * ctf-link.c (ctf_create_per_cu): New, refactored out of...
 733         (ctf_link_one_type): ... here, with parent-name setting added.
 734         (check_variable): New.
 735         (ctf_link_one_variable): Likewise.
 736         (ctf_link_one_input_archive_member): Call it.
 737         * ctf-error.c (_ctf_errlist): Updated with new errors.
 738
 739 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 740
 741         * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
 742         (struct ctf_link_type_mapping_key): New.
 743         (ctf_hash_type_mapping_key): Likewise.
 744         (ctf_hash_eq_type_mapping_key): Likewise.
 745         (ctf_add_type_mapping): Likewise.
 746         (ctf_type_mapping): Likewise.
 747         (ctf_dynhash_empty): Likewise.
 748         * ctf-open.c (ctf_file_close): Update accordingly.
 749         * ctf-create.c (ctf_update): Likewise.
 750         (ctf_add_type): Populate the mapping.
 751         * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
 752         (ctf_hash_eq_type_mapping_key): Check the key for equality.
 753         (ctf_dynhash_insert): Fix comment typo.
 754         (ctf_dynhash_empty): New.
 755         * ctf-link.c (ctf_add_type_mapping): New.
 756         (ctf_type_mapping): Likewise.
 757         (empty_link_type_mapping): New.
 758         (ctf_link_one_input_archive): Call it.
 759
 760 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 761
 762         * ctf-link.c: New file, linking of the string and type sections.
 763         * Makefile.am (libctf_a_SOURCES): Add it.
 764         * Makefile.in: Regenerate.
 765
 766         * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
 767         ctf_link_outputs.
 768         * ctf-create.c (ctf_update): Update accordingly.
 769         * ctf-open.c (ctf_file_close): Likewise.
 770         * ctf-error.c (_ctf_errlist): Updated with new errors.
 771
 772 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 773
 774         * ctf-dump.c (ctf_dump_funcs): Check the right error value.
 775
 776 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 777
 778         * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
 779         ctf_type_iter.
 780         (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
 781         (ctf_dump_format_type): Add non-root-type { } notation.
 782         Add root flag to prototype.
 783         (ctf_dump_label): Adjust accordingly.
 784         (ctf_dump_objts): Likewise.
 785         (ctf_dump_var): Likewise.
 786
 787 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 788
 789         * ctf-create.c (ctf_compress_write): Fix double-free.
 790
 791 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 792
 793         * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
 794         of...
 795         (ctf_arc_write_fd): ... this new function.
 796         * ctf-create.c (ctf_write_mem): New.
 797
 798 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 799
 800         * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
 801         (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
 802         (ctf_str_add_ref): Name the last arg.
 803         (ctf_str_add_external) New.
 804         (ctf_str_add_strraw_explicit): Likewise.
 805         (ctf_simple_open_internal): Likewise.
 806         (ctf_bufopen_internal): Likewise.
 807
 808         * ctf-string.c (ctf_strraw_explicit): Split from...
 809         (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
 810         (ctf_str_add_ref_internal): Return the atom, not the
 811         string.
 812         (ctf_str_add): Adjust accordingly.
 813         (ctf_str_add_ref): Likewise.  Move up in the file.
 814         (ctf_str_add_external): New: update the csa_offset.
 815         (ctf_str_count_strtab): Only account for strings with no csa_offset
 816         in the internal strtab length.
 817         (ctf_str_write_strtab): If the csa_offset is set, update the
 818         string's refs without writing the string out, and update the
 819         ctf_syn_ext_strtab.  Make OOM handling less ugly.
 820         * ctf-create.c (struct ctf_sort_var_arg_cb): New.
 821         (ctf_update): Handle failure to populate the strtab.  Pass in the
 822         new ctf_sort_var arg.  Adjust for ctf_syn_ext_strtab addition.
 823         Call ctf_simple_open_internal, not ctf_simple_open.
 824         (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
 825         strings by hand.
 826         * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
 827         ctf_strraw).  Adjust to diagnose ECTF_STRTAB nonetheless.
 828         * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
 829         (ctf_file_close): Destroy the ctf_syn_ext_strtab.
 830         (ctf_simple_open): Rename to, and reimplement as a wrapper around...
 831         (ctf_simple_open_internal): ... this new function, which calls
 832         ctf_bufopen_internal.
 833         (ctf_bufopen): Rename to, and reimplement as a wrapper around...
 834         (ctf_bufopen_internal): ... this new function, which sets
 835         ctf_syn_ext_strtab.
 836
 837 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 838
 839         * ctf_types.c (ctf_type_iter_all): New.
 840
 841 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 842
 843         * ctf-open.c (init_symtab): Check for overflow against the right
 844         section.
 845         (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
 846         (upgrade_types_v1): Note that these sections are not checked.
 847         (flip_header): Endian-swap the header fields.
 848         (flip_ctf): Endian-swap the sections.
 849         (flip_objts): Update comment.
 850         (ctf_bufopen): Check header offsets and alignment for validity.
 851
 852 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 853
 854         * ctf-open-bfd.c: Add <assert.h>.
 855         (ctf_bfdopen_ctfsect): Open string and symbol tables using
 856         techniques borrowed from bfd_elf_sym_name.
 857         (ctf_new_archive_internal): Improve comment.
 858         * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
 859         * ctf-open.c (ctf_bufopen): Allow opening with a string section but
 860         no symbol section, but not vice versa.
 861
 862 2019-07-08  Nick Alcock  <nick.alcock@oracle.com>
 863
 864         * ctf-impl.h (ctf_file_t): New field ctf_openflags.
 865         * ctf-open.c (ctf_bufopen): Set it.  No longer dump header offsets.
 866         * ctf-dump.c (dump_header): New function, dump the CTF header.
 867         (ctf_dump): Call it.
 868         (ctf_dump_header_strfield): New function.
 869         (ctf_dump_header_sectfield): Likewise.
 870
 871 2019-07-06  Nick Alcock  <nick.alcock@oracle.com>
 872
 873         * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
 874         ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
 875         * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
 876         ctf_base: do not assume that it is always sizeof (ctf_header_t).
 877         Print out ctf_cuname: only print out ctf_parname if set.
 878         (ctf_free_base): Removed, ctf_base is no longer freed: free
 879         ctf_dynbase instead.
 880         (ctf_set_version): Fix spacing.
 881         (upgrade_header): New, in-place header upgrading.
 882         (upgrade_types): Rename to...
 883         (upgrade_types_v1): ... this.  Free ctf_dynbase, not ctf_base.  No
 884         longer track old and new headers separately.  No longer allow for
 885         header sizes explicitly: squeeze the headers out on upgrade (they
 886         are preserved in fp->ctf_header).  Set ctf_dynbase, ctf_base and
 887         ctf_buf explicitly.  Use ctf_free, not ctf_free_base.
 888         (upgrade_types): New, also handle ctf_parmax updating.
 889         (flip_header): Flip ctf_cuname.
 890         (flip_types): Flip BUF explicitly rather than deriving BUF from
 891         BASE.
 892         (ctf_bufopen): Store the header in fp->ctf_header.  Correct minimum
 893         required alignment of objtoff and funcoff.  No longer store it in
 894         the ctf_buf unless that buf is derived unmodified from the input.
 895         Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
 896         that duplicate fields in ctf_file: move allocation of ctf_file
 897         further up instead.  Call upgrade_header as needed.  Move
 898         version-specific ctf_parmax initialization into upgrade_types.  More
 899         concise error handling.
 900         (ctf_file_close): No longer test for null pointers before freeing.
 901         Free ctf_dyncuname, ctf_dynbase, and ctf_header.  Do not call
 902         ctf_free_base.
 903         (ctf_cuname): New.
 904         (ctf_cuname_set): New.
 905         * ctf-create.c (ctf_update): Populate ctf_cuname.
 906         (ctf_gzwrite): Write out the header explicitly.  Remove obsolescent
 907         comment.
 908         (ctf_write): Likewise.
 909         (ctf_compress_write): Get the header from ctf_header, not ctf_base.
 910         Fix the compression length: fp->ctf_size never counted the CTF
 911         header.  Simplify the compress call accordingly.
 912
 913 2019-07-11  Hans-Peter Nilsson  <hp@bitrange.com>
 914
 915         * ctf-endian.h: Don't assume htole64 and le64toh are always
 916         present if HAVE_ENDIAN_H; also check if htole64 is defined.
 917         [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
 918         not bswap_identity_64.
 919
 920 2019-09-18  Alan Modra  <amodra@gmail.com>
 921
 922         * ctf-open-bfd.c: Update throughout for bfd section macro changes.
 923
 924 2019-09-09  Phil Blundell  <pb@pbcl.net>
 925
 926         binutils 2.33 branch created.
 927
 928 2019-07-18  Nick Alcock  <nick.alcock@oracle.com>
 929
 930         * ctf-types.c (ctf_type_aname_raw): New.
 931         (ctf_func_type_info): Likewise.
 932         (ctf_func_type_args): Likewise.
 933         * ctf-error.c (_ctf_errlist): Fix description.
 934         * ctf-lookup.c: Fix file description.
 935
 936 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 937
 938         * ctf-create.c (ctf_create): Fix off-by-one error.
 939
 940 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 941
 942         * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
 943         struct ctf_strs.
 944         (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
 945         (struct ctf_str_atom): New, disambiguated single string.
 946         (struct ctf_str_atom_ref): New, points to some other location that
 947         references this string's offset.
 948         (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
 949         Remove member ctf_dtvstrlen: we no longer track the total strlen
 950         as we add strings.
 951         (ctf_str_create_atoms): Declare new function in ctf-string.c.
 952         (ctf_str_free_atoms): Likewise.
 953         (ctf_str_add): Likewise.
 954         (ctf_str_add_ref): Likewise.
 955         (ctf_str_rollback): Likewise.
 956         (ctf_str_purge_refs): Likewise.
 957         (ctf_str_write_strtab): Likewise.
 958         (ctf_realloc): Declare new function in ctf-util.c.
 959
 960         * ctf-open.c (ctf_bufopen): Create the atoms table.
 961         (ctf_file_close): Destroy it.
 962         * ctf-create.c (ctf_update): Copy-and-free it on update.  No longer
 963         special-case the position of the parname string.  Construct the
 964         strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
 965         rest of each buffer element is constructed, not via open-coding:
 966         realloc the CTF buffer and append the strtab to it.  No longer
 967         maintain ctf_dtvstrlen.  Sort the variable entry table later, after
 968         strtab construction.
 969         (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
 970         (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
 971         after buffer element construction instead.
 972         (ctf_copy_lmembers): Likewise.
 973         (ctf_copy_emembers): Likewise.
 974         (ctf_create): No longer maintain the ctf_dtvstrlen.
 975         (ctf_dtd_delete): Likewise.
 976         (ctf_dvd_delete): Likewise.
 977         (ctf_add_generic): Likewise.
 978         (ctf_add_enumerator): Likewise.
 979         (ctf_add_member_offset): Likewise.
 980         (ctf_add_variable): Likewise.
 981         (membadd): Likewise.
 982         * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
 983         if there are active ctf_str_num_refs.
 984         (ctf_strraw): Move to ctf-string.c.
 985         (ctf_strptr): Likewise.
 986         * ctf-string.c: New file, strtab manipulation.
 987
 988         * Makefile.am (libctf_a_SOURCES): Add it.
 989         * Makefile.in: Regenerate.
 990
 991 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 992
 993         * ctf-impl.h (ctf_hash_iter_f): New.
 994         (ctf_dynhash_iter): New declaration.
 995         (ctf_dynhash_iter_remove): New declaration.
 996         * ctf-hash.c (ctf_dynhash_iter): Define.
 997         (ctf_dynhash_iter_remove): Likewise.
 998         (ctf_hashtab_traverse): New.
 999         (ctf_hashtab_traverse_remove): Likewise.
1000         (struct ctf_traverse_cb_arg): Likewise.
1001         (struct ctf_traverse_remove_cb_arg): Likewise.
1002
1003 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1004
1005         * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
1006
1007 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1008
1009         * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
1010         (ctf_dump_funcs): Likewise.
1011
1012 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1013
1014         * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
1015         (ctf_fdopen): Check for endian-swapped raw CTF magic, and
1016         little-endian CTF archive magic.  Do not check the CTF version:
1017         ctf_simple_open does that in endian-safe ways.  Do not dereference
1018         null pointers on open failure.
1019
1020 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1021
1022         * ctf-open.c (get_vbytes_common): Return the new slice size.
1023         (ctf_bufopen): Flip the endianness of the CTF-section header copy.
1024         Remember to copy in the CTF data when opening an uncompressed
1025         foreign-endian CTF file.  Prune useless variable manipulation.
1026
1027 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1028
1029         * ctf-open.c (ctf_types): Fail when unidentified type kinds are
1030         seen.
1031
1032 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1033
1034         * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
1035         output.
1036
1037 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1038
1039         * ctf-subr.c (_PAGESIZE): Remove.
1040         (ctf_data_alloc): Likewise.
1041         (ctf_data_free): Likewise.
1042         (ctf_data_protect): Likewise.
1043         * ctf-impl.h: Remove declarations.
1044         * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
1045         ctf_free, not ctf_data_free.
1046         (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc.  Free
1047         the buffer again on compression error.
1048         * ctf-open.c (ctf_set_base): No longer track the size: call
1049         ctf_free, not ctf_data_free.
1050         (upgrade_types): Likewise.  Call ctf_alloc, not ctf_data_alloc.
1051         (ctf_bufopen): Likewise.  No longer call ctf_data_protect.
1052
1053 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1054
1055         * ctf-create.c (ctf_dtd_insert): Pass on error returns from
1056         ctf_dynhash_insert.
1057         (ctf_dvd_insert): Likewise.
1058         (ctf_add_generic): Likewise.
1059         (ctf_add_variable): Likewise.
1060         * ctf-impl.h: Adjust declarations.
1061
1062 2019-06-14  Alan Modra  <amodra@gmail.com>
1063
1064         * configure: Regenerate.
1065
1066 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1067
1068         * ctf-decls.h: Include <libiberty.h>.
1069         * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
1070
1071 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1072
1073         * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
1074         (ctf_dump_objts): Likewise.
1075         (ctf_dump_funcs): Likewise.
1076         (ctf_dump_member): Likewise.
1077         (ctf_dump_str): Likewise.
1078
1079 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1080
1081         * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
1082         * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
1083
1084 2019-06-05  Nick Alcock  <nick.alcock@oracle.com>
1085
1086         * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
1087         (ctf_arc_open_by_offset): Likewise.
1088         * ctf-create.c (ctf_add_type): Likewise.
1089
1090 2019-06-04  Tom Tromey  <tromey@adacore.com>
1091
1092         * ctf-create.c (ctf_add_encoded, ctf_add_slice)
1093         (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
1094
1095 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
1096
1097         * configure.ac: Check for O_CLOEXEC.
1098         * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
1099         * config.h.in: Regenerate.
1100         * configure: Likewise.
1101
1102 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
1103
1104         * qsort_r.c: Rename to...
1105         * ctf-qsort_r.c: ... this.
1106         (_quicksort): Define to ctf_qsort_r.
1107         * ctf-decls.h (qsort_r): Remove.
1108         (ctf_qsort_r): Add.
1109         (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
1110         (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
1111         * Makefile.am (libctf_a_LIBADD): Remove.
1112         (libctf_a_SOURCES): New, add ctf-qsort_r.c.
1113         * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
1114         * ctf-create.c (ctf_update): Likewise.
1115         * configure.ac: Check for BSD versus GNU qsort_r signature.
1116         * Makefile.in: Regenerate.
1117         * config.h.in: Likewise.
1118         * configure: Likewise.
1119
1120 2019-06-03  Nick Alcock  <nick.alcock@oracle.com>
1121
1122         * ctf-dump.c (ctf_dump_funcs): Free in the right place.
1123
1124 2019-05-29  Nick Alcock  <nick.alcock@oracle.com>
1125
1126         * Makefile.am (ZLIB): New.
1127         (ZLIBINC): Likewise.
1128         (AM_CFLAGS): Use them.
1129         (libctf_a_LIBADD): New, for LIBOBJS.
1130         * configure.ac: Check for zlib, endian.h, and qsort_r.
1131         * ctf-endian.h: New, providing htole64 and le64toh.
1132         * swap.h: Code style fixes.
1133         (bswap_identity_64): New.
1134         * qsort_r.c: New, from gnulib (with one added #include).
1135         * ctf-decls.h: New, providing a conditional qsort_r declaration,
1136         and unconditional definitions of MIN and MAX.
1137         * ctf-impl.h: Use it.  Do not use <sys/errno.h>.
1138         (ctf_set_errno): Now returns unsigned long.
1139         * ctf-util.c (ctf_set_errno): Adjust here too.
1140         * ctf-archive.c: Use ctf-endian.h.
1141         (ctf_arc_open_by_offset): Use memset, not bzero.  Drop cts_type,
1142         cts_flags and cts_offset.
1143         (ctf_arc_write): Drop debugging dependent on the size of off_t.
1144         * ctf-create.c: Provide a definition of roundup if not defined.
1145         (ctf_create): Drop cts_type, cts_flags and cts_offset.
1146         (ctf_add_reftype): Do not check if type IDs are below zero.
1147         (ctf_add_slice): Likewise.
1148         (ctf_add_typedef): Likewise.
1149         (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
1150         when known error-free.  Drop CTF_ERR usage for functions returning
1151         int.
1152         (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
1153         int.
1154         (ctf_add_variable): Likewise.
1155         (enumcmp): Likewise.
1156         (enumadd): Likewise.
1157         (membcmp): Likewise.
1158         (ctf_add_type): Likewise.  Cast error-returning ssize_t's to size_t
1159         when known error-free.
1160         * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
1161         returning int: use CTF_ERR for functions returning ctf_type_id.
1162         (ctf_dump_label): Likewise.
1163         (ctf_dump_objts): Likewise.
1164         * ctf-labels.c (ctf_label_topmost): Likewise.
1165         (ctf_label_iter): Likewise.
1166         (ctf_label_info): Likewise.
1167         * ctf-lookup.c (ctf_func_args): Likewise.
1168         * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
1169         (ctf_bufopen): Likewise.  Use zlib types as needed.
1170         * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
1171         returning int.
1172         (ctf_enum_iter): Likewise.
1173         (ctf_type_size): Likewise.
1174         (ctf_type_align): Likewise.  Cast to size_t where appropriate.
1175         (ctf_type_kind_unsliced): Likewise.
1176         (ctf_type_kind): Likewise.
1177         (ctf_type_encoding): Likewise.
1178         (ctf_member_info): Likewise.
1179         (ctf_array_info): Likewise.
1180         (ctf_enum_value): Likewise.
1181         (ctf_type_rvisit): Likewise.
1182         * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
1183         cts_offset.
1184         (ctf_simple_open): Likewise.
1185         (ctf_bfdopen_ctfsect): Likewise.  Set cts_size properly.
1186         * Makefile.in: Regenerate.
1187         * aclocal.m4: Likewise.
1188         * config.h: Likewise.
1189         * configure: Likewise.
1190
1191 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1192
1193         * configure.in: Check for bfd_section_from_elf_index.
1194         * configure: Regenerate.
1195         * config.h.in [HAVE_BFD_ELF]: Likewise.
1196         * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
1197         abfd is potentially unused now.
1198
1199 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1200
1201         * Makefile.am: New.
1202         * Makefile.in: Regenerated.
1203         * config.h.in: Likewise.
1204         * aclocal.m4: Likewise.
1205         * configure: Likewise.
1206
1207 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1208
1209         * ctf-dump.c: New.
1210
1211 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1212
1213         * ctf-labels.c: New.
1214
1215 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1216
1217         * ctf-impl.h (_libctf_version): New declaration.
1218         * ctf-subr.c (_libctf_version): Define it.
1219         (ctf_version): New.
1220
1221 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1222
1223         * ctf-create.c (enumcmp): New.
1224         (enumadd): Likewise.
1225         (membcmp): Likewise.
1226         (membadd): Likewise.
1227         (ctf_add_type): Likewise.
1228
1229 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1230
1231         * ctf-lookup.c (isqualifier): New.
1232         (ctf_lookup_by_name): Likewise.
1233         (struct ctf_lookup_var_key): Likewise.
1234         (ctf_lookup_var): Likewise.
1235         (ctf_lookup_variable): Likewise.
1236         (ctf_lookup_symbol_name): Likewise.
1237         (ctf_lookup_by_symbol): Likewise.
1238         (ctf_func_info): Likewise.
1239         (ctf_func_args): Likewise.
1240
1241 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1242
1243         * ctf-decl.c: New file.
1244         * ctf-types.c: Likewise.
1245         * ctf-impl.h: New declarations.
1246
1247 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1248
1249         * ctf-open-bfd.c: New file.
1250         * ctf-open.c (ctf_close): New.
1251         * ctf-impl.h: Include bfd.h.
1252         (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
1253         (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
1254         ctfi_bfd_close.
1255         (ctf_bfdopen_ctfsect): New declaration.
1256         (_CTF_SECTION): likewise.
1257
1258 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1259
1260         * ctf-archive.c: New.
1261         * ctf-impl.h (ctf_archive_internal): New type.
1262         (ctf_arc_open_internal): New declaration.
1263         (ctf_arc_bufopen): Likewise.
1264         (ctf_arc_close_internal): Likewise.
1265
1266 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1267
1268         * ctf-open.c: New file.
1269         * swap.h: Likewise.
1270
1271 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1272
1273         * ctf-create.c: New file.
1274         * ctf-lookup.c: New file.
1275
1276 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1277
1278         * ctf-impl.h: New definitions and declarations for type creation
1279         and lookup.
1280
1281 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1282
1283         * ctf-hash.c: New file.
1284         * ctf-impl.h: New declarations.
1285
1286 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1287
1288         * ctf-error.c: New file.
1289
1290 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1291
1292         * ctf-util.c: New file.
1293         * elf.h: Likewise.
1294         * ctf-impl.h: Include it, and add declarations.
1295
1296 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1297
1298         * ctf-impl.h: New file.
1299         * ctf-subr.c: New file.
1300
1301 \f
1302 Local Variables:
1303 mode: change-log
1304 left-margin: 8
1305 fill-column: 76
1306 version-control: never
1307 End: