1 2020-07-22 Nick Clifton <nickc@redhat.com>
3 * ctf-archive.c (ctf_arc_write): Avoid calling close twice on the
6 2020-07-04 Nick Clifton <nickc@redhat.com>
8 Binutils 2.35 branch created.
10 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
12 * aclocal.m4: Add config/gettext-sister.m4: Shuffle into
14 * configure.ac: Add ZW_GNU_GETTEXT_SISTER_DIR.
15 * config.h.in: Regenerated.
16 * Makefile.in: Likewise.
17 * configure: Likewise.
19 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
21 * ctf-create.c: Include <unistd.h>.
22 * ctf-open-bfd.c: Likewise.
24 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
27 * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls.
28 * swap.h (bswap_16): Do not assume that presence of <byteswap.h>
29 means this is declared.
32 (bswap_identity_64): Remove, unused.
33 * configure: Regenerated.
34 * config.h.in: Likewise.
36 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
39 * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback.
40 (_libctf_unlikely_): Likewise.
41 (_libctf_unused): Likewise.
42 (_libctf_malloc_): Likewise.
44 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
47 * ctf-archive.c (search_nametbl): No longer global: declare...
48 (ctf_arc_open_by_name_internal): ... here. Use bsearch_r.
49 (search_modent_by_name): Take and use ARG for the nametbl.
51 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
53 * ctf-impl.h (ctf_new_archive_internal): Declare.
54 (ctf_arc_bufopen): Remove.
55 (ctf_archive_internal) <ctfi_free_symsect>: New.
56 * ctf-archive.c (ctf_arc_close): Use it.
57 (ctf_arc_bufopen): Fuse into...
58 (ctf_new_archive_internal): ... this, moved across from...
59 * ctf-open-bfd.c: ... here.
60 (ctf_bfdopen_ctfsect): Use ctf_arc_bufopen.
63 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
65 * ctf-create.c (ctf_add_forward): Intern in the right namespace.
66 (ctf_dtd_delete): Remove correspondingly.
67 (ctf_rollback): Likewise.
69 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
71 * ctf-create.c (ctf_add_type_internal): Hand back existing types
74 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
76 * ctf-create.c (ctf_add_forward): Don't add forwards to
77 types that already exist.
79 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
81 * ctf-open.c (init_types): Only intern root-visible types.
82 * ctf-create.c (ctf_dtd_insert): Likewise.
83 (ctf_dtd_delete): Only remove root-visible types.
84 (ctf_rollback): Likewise.
85 (ctf_add_generic): Adjust.
86 (ctf_add_struct_sized): Adjust comment.
87 (ctf_add_union_sized): Likewise.
88 (ctf_add_enum): Likewise.
89 * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
91 2020-03-11 John Baldwin <jhb@FreeBSD.org>
93 * swap.h (bswap_identity_64): Make static.
95 2020-01-18 Nick Clifton <nickc@redhat.com>
97 Binutils 2.34 branch created.
99 2020-01-05 Joel Brobecker <brobecker@adacore.com>
102 * configure.ac: Add AC_CHECK_DECLS([asprintf]).
103 * configure, config.h.in: Regenerate.
105 2020-01-01 Alan Modra <amodra@gmail.com>
107 Update year range in copyright notice of all files.
109 2019-10-16 Simon Marchi <simon.marchi@polymtl.ca>
111 * swap.h (bswap_16, bswap_32, bswap_64): Make static.
113 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
115 * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
116 * ctf-types.c (ctf_type_lname): Likewise.
118 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
120 * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
121 ctf_import after the first for a given file.
123 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
125 * ctf-impl.h (ctf_str_append_noerr): Declare.
126 * ctf-util.c (ctf_str_append_noerr): Define in terms of
128 * ctf-dump.c (str_append): New, call it.
129 (ctf_dump_format_type): Use str_append, not ctf_str_append.
130 (ctf_dump_label): Likewise.
131 (ctf_dump_objts): Likewise.
132 (ctf_dump_funcs): Likewise.
133 (ctf_dump_var): Likewise.
134 (ctf_dump_member): Likewise.
135 (ctf_dump_type): Likewise.
136 (ctf_dump): Likewise.
138 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
140 * ctf-impl.h (ctf_alloc): Remove.
141 (ctf_free): Likewise.
142 (ctf_strdup): Likewise.
143 * ctf-subr.c (ctf_alloc): Remove.
144 (ctf_free): Likewise.
145 * ctf-util.c (ctf_strdup): Remove.
147 * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
148 ctf_free; strdup, not ctf_strdup.
149 (ctf_dtd_delete): Likewise.
150 (ctf_dvd_delete): Likewise.
151 (ctf_add_generic): Likewise.
152 (ctf_add_function): Likewise.
153 (ctf_add_enumerator): Likewise.
154 (ctf_add_member_offset): Likewise.
155 (ctf_add_variable): Likewise.
157 (ctf_compress_write): Likewise.
158 (ctf_write_mem): Likewise.
159 * ctf-decl.c (ctf_decl_push): Likewise.
160 (ctf_decl_fini): Likewise.
161 (ctf_decl_sprintf): Likewise. Check for OOM.
162 * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
163 ctf_free; strdup, not ctf_strdup.
164 (ctf_dump_free): Likewise.
165 (ctf_dump): Likewise.
166 * ctf-open.c (upgrade_types_v1): Likewise.
167 (init_types): Likewise.
168 (ctf_file_close): Likewise.
169 (ctf_bufopen_internal): Likewise. Check for OOM.
170 (ctf_parent_name_set): Likewise: report the OOM to the caller.
171 (ctf_cuname_set): Likewise.
172 (ctf_import): Likewise.
173 * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
174 free, not ctf_free; strdup, not ctf_strdup.
175 (ctf_str_free_atom): Likewise.
176 (ctf_str_create_atoms): Likewise.
177 (ctf_str_add_ref_internal): Likewise.
178 (ctf_str_remove_ref): Likewise.
179 (ctf_str_write_strtab): Likewise.
181 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
183 * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
184 work right for non-int/fps.
186 2019-08-08 Nick Alcock <nick.alcock@oracle.com>
188 * ctf-types.c (ctf_type_name): Don't strlen a potentially-
191 2019-08-07 Nick Alcock <nick.alcock@oracle.com>
193 * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
194 * ctf-open.c (ctf_file_close): Free it.
195 * ctf-create.c (ctf_serialize): Adjust.
196 (membcmp): When reporting a conflict due to an error, report the
198 (ctf_add_type): Turn into a ctf_add_processing wrapper. Rename to...
199 (ctf_add_type_internal): ... this. Hand back types we are already
200 in the middle of adding immediately. Hand back structs/unions with
201 the same number of members immediately. Do not walk the dynamic
202 list. Call ctf_add_type_internal, not ctf_add_type. Handle
203 forwards promoted to other types and the inverse case identically.
204 Add structs to the mapping as soon as we intern them, before they
207 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
209 * ctf-impl.h (ctf_names_t): New.
210 (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
211 (ctf_file_t) <ctf_structs>: Likewise.
212 <ctf_unions>: Likewise.
213 <ctf_enums>: Likewise.
214 <ctf_names>: Likewise.
215 <ctf_lookups>: Improve comment.
216 <ctf_ptrtab_len>: New.
217 <ctf_prov_strtab>: New.
218 <ctf_str_prov_offset>: New.
219 <ctf_dtbyname>: Remove, redundant to the names hashes.
220 <ctf_dtnextid>: Remove, redundant to ctf_typemax.
221 (ctf_dtdef_t) <dtd_name>: Remove.
222 <dtd_data>: Note that the ctt_name is now populated.
223 (ctf_str_atom_t) <csa_offset>: This is now the strtab
224 offset for internal strings too.
225 <csa_external_offset>: New, the external strtab offset.
226 (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
227 (ctf_name_table): New declaration.
228 (ctf_lookup_by_rawname): Likewise.
229 (ctf_lookup_by_rawhash): Likewise.
230 (ctf_set_ctl_hashes): Likewise.
231 (ctf_serialize): Likewise.
232 (ctf_dtd_insert): Adjust.
233 (ctf_simple_open_internal): Likewise.
234 (ctf_bufopen_internal): Likewise.
235 (ctf_list_empty_p): Likewise.
236 (ctf_str_remove_ref): Likewise.
237 (ctf_str_add): Returns uint32_t now.
238 (ctf_str_add_ref): Likewise.
239 (ctf_str_add_external): Now returns a boolean (int).
240 * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
241 for strings in the appropriate range.
242 (ctf_str_create_atoms): Create the ctf_prov_strtab. Detect OOM
243 when adding the null string to the new strtab.
244 (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
245 (ctf_str_add_ref_internal): Add make_provisional argument. If
246 make_provisional, populate the offset and fill in the
247 ctf_prov_strtab accordingly.
248 (ctf_str_add): Return the offset, not the string.
249 (ctf_str_add_ref): Likewise.
250 (ctf_str_add_external): Return a success integer.
251 (ctf_str_remove_ref): New, remove a single ref.
252 (ctf_str_count_strtab): Do not count the initial null string's
253 length or the existence or length of any unreferenced internal
255 (ctf_str_populate_sorttab): Skip atoms with no refs.
256 (ctf_str_write_strtab): Populate the nullstr earlier. Add one
257 to the cts_len for the null string, since it is no longer done
258 in ctf_str_count_strtab. Adjust for csa_external_offset rename.
259 Populate the csa_offset for both internal and external cases.
260 Flush the ctf_prov_strtab afterwards, and reset the
262 * ctf-create.c (ctf_grow_ptrtab): New.
263 (ctf_create): Call it. Initialize new fields rather than old
264 ones. Tell ctf_bufopen_internal that this is a writable dictionary.
265 Set the ctl hashes and data model.
266 (ctf_update): Rename to...
267 (ctf_serialize): ... this. Leave a compatibility function behind.
268 Tell ctf_simple_open_internal that this is a writable dictionary.
269 Pass the new fields along from the old dictionary. Drop
270 ctf_dtnextid and ctf_dtbyname. Use ctf_strraw, not dtd_name.
271 Do not zero out the DTD's ctt_name.
272 (ctf_prefixed_name): Rename to...
273 (ctf_name_table): ... this. No longer return a prefixed name: return
274 the applicable name table instead.
275 (ctf_dtd_insert): Use it, and use the right name table. Pass in the
276 kind we're adding. Migrate away from dtd_name.
277 (ctf_dtd_delete): Adjust similarly. Remove the ref to the
279 (ctf_dtd_lookup_type_by_name): Remove.
280 (ctf_dynamic_type): Always return NULL on read-only dictionaries.
281 No longer check ctf_dtnextid: check ctf_typemax instead.
282 (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
283 (ctf_rollback): Likewise. No longer fail with ECTF_OVERROLLBACK. Use
284 ctf_name_table and the right name table, and migrate away from
285 dtd_name as in ctf_dtd_delete.
286 (ctf_add_generic): Pass in the kind explicitly and pass it to
287 ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid. Migrate away
288 from dtd_name to using ctf_str_add_ref to populate the ctt_name.
289 Grow the ptrtab if needed.
290 (ctf_add_encoded): Pass in the kind.
291 (ctf_add_slice): Likewise.
292 (ctf_add_array): Likewise.
293 (ctf_add_function): Likewise.
294 (ctf_add_typedef): Likewise.
295 (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
296 ctt_name rather than dtd_name.
297 (ctf_add_struct_sized): Pass in the kind. Use
298 ctf_lookup_by_rawname, not ctf_hash_lookup_type /
299 ctf_dtd_lookup_type_by_name.
300 (ctf_add_union_sized): Likewise.
301 (ctf_add_enum): Likewise.
302 (ctf_add_enum_encoded): Likewise.
303 (ctf_add_forward): Likewise.
304 (ctf_add_type): Likewise.
305 (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
306 being initialized until after the call.
307 (ctf_write_mem): Likewise.
308 (ctf_write): Likewise.
309 * ctf-archive.c (arc_write_one_ctf): Likewise.
310 * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
311 ctf_hash_lookup_type.
312 (ctf_lookup_by_id): No longer check the readonly types if the
313 dictionary is writable.
314 * ctf-open.c (init_types): Assert that this dictionary is not
315 writable. Adjust to use the new name hashes, ctf_name_table,
316 and ctf_ptrtab_len. GNU style fix for the final ptrtab scan.
317 (ctf_bufopen_internal): New 'writable' parameter. Flip on LCTF_RDWR
318 if set. Drop out early when dictionary is writable. Split the
319 ctf_lookups initialization into...
320 (ctf_set_cth_hashes): ... this new function.
321 (ctf_simple_open_internal): Adjust. New 'writable' parameter.
322 (ctf_simple_open): Adjust accordingly.
323 (ctf_bufopen): Likewise.
324 (ctf_file_close): Destroy the appropriate name hashes. No longer
325 destroy ctf_dtbyname, which is gone.
326 (ctf_getdatasect): Remove spurious "extern".
327 * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
328 specified name table, given a kind.
329 (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
330 (ctf_member_iter): Add support for iterating over the
332 (ctf_enum_iter): Likewise.
333 (ctf_variable_iter): Likewise.
334 (ctf_type_rvisit): Likewise.
335 (ctf_member_info): Add support for types in the dynamic type list.
336 (ctf_enum_name): Likewise.
337 (ctf_enum_value): Likewise.
338 (ctf_func_type_info): Likewise.
339 (ctf_func_type_args): Likewise.
340 * ctf-link.c (ctf_accumulate_archive_names): No longer call
342 (ctf_link_write): Likewise.
343 (ctf_link_intern_extern_string): Adjust for new
344 ctf_str_add_external return value.
345 (ctf_link_add_strtab): Likewise.
346 * ctf-util.c (ctf_list_empty_p): New.
348 2019-08-05 Nick Alcock <nick.alcock@oracle.com>
350 * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
352 * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
354 (ctf_add_variable): Likewise for variables pointing to them.
355 * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
356 type link failure, but do warn for others.
357 * ctf-dump.c (ctf_dump_format_type): Likewise. Do not assume all
359 (ctf_dump_member): Likewise.
360 (ctf_dump_type): Likewise.
361 (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
362 (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
363 (ctf_dump_header): Likewise.
364 (ctf_dump_label): likewise.
365 (ctf_dump_objts): likewise.
366 (ctf_dump_funcs): likewise.
367 (ctf_dump_var): likewise.
368 (ctf_dump_str): Likewise.
370 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
372 * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
374 (AM_INSTALL_LIBBFD): Likewise.
375 (dlopen): Note why this is necessary in a comment.
376 (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
378 (SHARED_LDFLAGS): Likewise.
379 (BFD_LIBADD): Likewise, for libbfd.
380 (BFD_DEPENDENCIES): Likewise.
381 (VERSION_FLAGS): Initialize, using a version script if ld supports
382 one, or libtool -export-symbols-regex otherwise.
383 (AC_CONFIG_MACRO_DIR): Add ../BFD.
384 * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
386 (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
387 (noinst_LIBRARIES): Replace with...
388 [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
389 [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
390 libctf-nobfd.la as well.
391 [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
392 [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
393 (libctf_a_SOURCES): Rename to...
394 (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
396 (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
397 with ctf-open-bfd.c added.
398 (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
399 (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
400 (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
401 * Makefile.am [INSTALL_LIBCTF]: Use it.
402 * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
404 * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
405 the unstable components).
406 * Makefile.in: Regenerated.
407 * config.h.in: Likewise.
408 * configure: Likewise.
410 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
412 * configure.ac (INSTALL_LIBCTF): New, controlled by
413 --enable-install-libctf.
414 [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
415 * Makefile.in: Regenerated.
416 * configure: Regenerated.
418 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
420 * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
421 * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
423 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
425 * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
427 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
429 * ctf-impl.h (includes): Include <sys/param.h> here.
431 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
433 * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
434 (flip_objts): Likewise.
435 (flip_vars): Likewise.
436 (flip_types): Likewise.
438 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
440 * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
441 freeing functions: if set, free the key and value if the slot
442 already exists. Always reassign the key.
443 (ctf_dynhash_insert): Adjust call appropriately.
444 (ctf_hash_insert_type): Likewise.
446 2019-08-03 Nick Alcock <nick.alcock@oracle.com>
448 * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
449 type kind. Allow forwards to unify with pre-existing structs/
452 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
454 * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
455 <ctf_link_memb_name_changer>: Likewise.
456 <ctf_link_memb_name_changer_arg>: Likewise.
457 * ctf-create.c (ctf_update): Update accordingly.
458 * ctf-open.c (ctf_file_close): Likewise.
459 * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
460 (ctf_link_add_cu_mapping): New.
461 (ctf_link_set_memb_name_changer): Likewise.
462 (ctf_change_parent_name): New.
463 (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
464 allocated by the caller's ctf_link_memb_name_changer.
465 <ndynames>: Likewise.
466 (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
467 (ctf_link_write): Likewise (for _CTF_SECTION only): also call
468 ctf_change_parent_name. Free any resulting names.
470 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
472 * ctf-link.c (ctf_create_per_cu): New, refactored out of...
473 (ctf_link_one_type): ... here, with parent-name setting added.
474 (check_variable): New.
475 (ctf_link_one_variable): Likewise.
476 (ctf_link_one_input_archive_member): Call it.
477 * ctf-error.c (_ctf_errlist): Updated with new errors.
479 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
481 * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
482 (struct ctf_link_type_mapping_key): New.
483 (ctf_hash_type_mapping_key): Likewise.
484 (ctf_hash_eq_type_mapping_key): Likewise.
485 (ctf_add_type_mapping): Likewise.
486 (ctf_type_mapping): Likewise.
487 (ctf_dynhash_empty): Likewise.
488 * ctf-open.c (ctf_file_close): Update accordingly.
489 * ctf-create.c (ctf_update): Likewise.
490 (ctf_add_type): Populate the mapping.
491 * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
492 (ctf_hash_eq_type_mapping_key): Check the key for equality.
493 (ctf_dynhash_insert): Fix comment typo.
494 (ctf_dynhash_empty): New.
495 * ctf-link.c (ctf_add_type_mapping): New.
496 (ctf_type_mapping): Likewise.
497 (empty_link_type_mapping): New.
498 (ctf_link_one_input_archive): Call it.
500 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
502 * ctf-link.c: New file, linking of the string and type sections.
503 * Makefile.am (libctf_a_SOURCES): Add it.
504 * Makefile.in: Regenerate.
506 * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
508 * ctf-create.c (ctf_update): Update accordingly.
509 * ctf-open.c (ctf_file_close): Likewise.
510 * ctf-error.c (_ctf_errlist): Updated with new errors.
512 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
514 * ctf-dump.c (ctf_dump_funcs): Check the right error value.
516 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
518 * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
520 (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
521 (ctf_dump_format_type): Add non-root-type { } notation.
522 Add root flag to prototype.
523 (ctf_dump_label): Adjust accordingly.
524 (ctf_dump_objts): Likewise.
525 (ctf_dump_var): Likewise.
527 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
529 * ctf-create.c (ctf_compress_write): Fix double-free.
531 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
533 * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
535 (ctf_arc_write_fd): ... this new function.
536 * ctf-create.c (ctf_write_mem): New.
538 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
540 * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
541 (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
542 (ctf_str_add_ref): Name the last arg.
543 (ctf_str_add_external) New.
544 (ctf_str_add_strraw_explicit): Likewise.
545 (ctf_simple_open_internal): Likewise.
546 (ctf_bufopen_internal): Likewise.
548 * ctf-string.c (ctf_strraw_explicit): Split from...
549 (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
550 (ctf_str_add_ref_internal): Return the atom, not the
552 (ctf_str_add): Adjust accordingly.
553 (ctf_str_add_ref): Likewise. Move up in the file.
554 (ctf_str_add_external): New: update the csa_offset.
555 (ctf_str_count_strtab): Only account for strings with no csa_offset
556 in the internal strtab length.
557 (ctf_str_write_strtab): If the csa_offset is set, update the
558 string's refs without writing the string out, and update the
559 ctf_syn_ext_strtab. Make OOM handling less ugly.
560 * ctf-create.c (struct ctf_sort_var_arg_cb): New.
561 (ctf_update): Handle failure to populate the strtab. Pass in the
562 new ctf_sort_var arg. Adjust for ctf_syn_ext_strtab addition.
563 Call ctf_simple_open_internal, not ctf_simple_open.
564 (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
566 * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
567 ctf_strraw). Adjust to diagnose ECTF_STRTAB nonetheless.
568 * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
569 (ctf_file_close): Destroy the ctf_syn_ext_strtab.
570 (ctf_simple_open): Rename to, and reimplement as a wrapper around...
571 (ctf_simple_open_internal): ... this new function, which calls
572 ctf_bufopen_internal.
573 (ctf_bufopen): Rename to, and reimplement as a wrapper around...
574 (ctf_bufopen_internal): ... this new function, which sets
577 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
579 * ctf_types.c (ctf_type_iter_all): New.
581 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
583 * ctf-open.c (init_symtab): Check for overflow against the right
585 (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
586 (upgrade_types_v1): Note that these sections are not checked.
587 (flip_header): Endian-swap the header fields.
588 (flip_ctf): Endian-swap the sections.
589 (flip_objts): Update comment.
590 (ctf_bufopen): Check header offsets and alignment for validity.
592 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
594 * ctf-open-bfd.c: Add <assert.h>.
595 (ctf_bfdopen_ctfsect): Open string and symbol tables using
596 techniques borrowed from bfd_elf_sym_name.
597 (ctf_new_archive_internal): Improve comment.
598 * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
599 * ctf-open.c (ctf_bufopen): Allow opening with a string section but
600 no symbol section, but not vice versa.
602 2019-07-08 Nick Alcock <nick.alcock@oracle.com>
604 * ctf-impl.h (ctf_file_t): New field ctf_openflags.
605 * ctf-open.c (ctf_bufopen): Set it. No longer dump header offsets.
606 * ctf-dump.c (dump_header): New function, dump the CTF header.
608 (ctf_dump_header_strfield): New function.
609 (ctf_dump_header_sectfield): Likewise.
611 2019-07-06 Nick Alcock <nick.alcock@oracle.com>
613 * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
614 ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
615 * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
616 ctf_base: do not assume that it is always sizeof (ctf_header_t).
617 Print out ctf_cuname: only print out ctf_parname if set.
618 (ctf_free_base): Removed, ctf_base is no longer freed: free
620 (ctf_set_version): Fix spacing.
621 (upgrade_header): New, in-place header upgrading.
622 (upgrade_types): Rename to...
623 (upgrade_types_v1): ... this. Free ctf_dynbase, not ctf_base. No
624 longer track old and new headers separately. No longer allow for
625 header sizes explicitly: squeeze the headers out on upgrade (they
626 are preserved in fp->ctf_header). Set ctf_dynbase, ctf_base and
627 ctf_buf explicitly. Use ctf_free, not ctf_free_base.
628 (upgrade_types): New, also handle ctf_parmax updating.
629 (flip_header): Flip ctf_cuname.
630 (flip_types): Flip BUF explicitly rather than deriving BUF from
632 (ctf_bufopen): Store the header in fp->ctf_header. Correct minimum
633 required alignment of objtoff and funcoff. No longer store it in
634 the ctf_buf unless that buf is derived unmodified from the input.
635 Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
636 that duplicate fields in ctf_file: move allocation of ctf_file
637 further up instead. Call upgrade_header as needed. Move
638 version-specific ctf_parmax initialization into upgrade_types. More
639 concise error handling.
640 (ctf_file_close): No longer test for null pointers before freeing.
641 Free ctf_dyncuname, ctf_dynbase, and ctf_header. Do not call
644 (ctf_cuname_set): New.
645 * ctf-create.c (ctf_update): Populate ctf_cuname.
646 (ctf_gzwrite): Write out the header explicitly. Remove obsolescent
648 (ctf_write): Likewise.
649 (ctf_compress_write): Get the header from ctf_header, not ctf_base.
650 Fix the compression length: fp->ctf_size never counted the CTF
651 header. Simplify the compress call accordingly.
653 2019-07-11 Hans-Peter Nilsson <hp@bitrange.com>
655 * ctf-endian.h: Don't assume htole64 and le64toh are always
656 present if HAVE_ENDIAN_H; also check if htole64 is defined.
657 [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
658 not bswap_identity_64.
660 2019-09-18 Alan Modra <amodra@gmail.com>
662 * ctf-open-bfd.c: Update throughout for bfd section macro changes.
664 2019-09-09 Phil Blundell <pb@pbcl.net>
666 binutils 2.33 branch created.
668 2019-07-18 Nick Alcock <nick.alcock@oracle.com>
670 * ctf-types.c (ctf_type_aname_raw): New.
671 (ctf_func_type_info): Likewise.
672 (ctf_func_type_args): Likewise.
673 * ctf-error.c (_ctf_errlist): Fix description.
674 * ctf-lookup.c: Fix file description.
676 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
678 * ctf-create.c (ctf_create): Fix off-by-one error.
680 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
682 * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
684 (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
685 (struct ctf_str_atom): New, disambiguated single string.
686 (struct ctf_str_atom_ref): New, points to some other location that
687 references this string's offset.
688 (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
689 Remove member ctf_dtvstrlen: we no longer track the total strlen
691 (ctf_str_create_atoms): Declare new function in ctf-string.c.
692 (ctf_str_free_atoms): Likewise.
693 (ctf_str_add): Likewise.
694 (ctf_str_add_ref): Likewise.
695 (ctf_str_rollback): Likewise.
696 (ctf_str_purge_refs): Likewise.
697 (ctf_str_write_strtab): Likewise.
698 (ctf_realloc): Declare new function in ctf-util.c.
700 * ctf-open.c (ctf_bufopen): Create the atoms table.
701 (ctf_file_close): Destroy it.
702 * ctf-create.c (ctf_update): Copy-and-free it on update. No longer
703 special-case the position of the parname string. Construct the
704 strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
705 rest of each buffer element is constructed, not via open-coding:
706 realloc the CTF buffer and append the strtab to it. No longer
707 maintain ctf_dtvstrlen. Sort the variable entry table later, after
709 (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
710 (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
711 after buffer element construction instead.
712 (ctf_copy_lmembers): Likewise.
713 (ctf_copy_emembers): Likewise.
714 (ctf_create): No longer maintain the ctf_dtvstrlen.
715 (ctf_dtd_delete): Likewise.
716 (ctf_dvd_delete): Likewise.
717 (ctf_add_generic): Likewise.
718 (ctf_add_enumerator): Likewise.
719 (ctf_add_member_offset): Likewise.
720 (ctf_add_variable): Likewise.
722 * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
723 if there are active ctf_str_num_refs.
724 (ctf_strraw): Move to ctf-string.c.
725 (ctf_strptr): Likewise.
726 * ctf-string.c: New file, strtab manipulation.
728 * Makefile.am (libctf_a_SOURCES): Add it.
729 * Makefile.in: Regenerate.
731 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
733 * ctf-impl.h (ctf_hash_iter_f): New.
734 (ctf_dynhash_iter): New declaration.
735 (ctf_dynhash_iter_remove): New declaration.
736 * ctf-hash.c (ctf_dynhash_iter): Define.
737 (ctf_dynhash_iter_remove): Likewise.
738 (ctf_hashtab_traverse): New.
739 (ctf_hashtab_traverse_remove): Likewise.
740 (struct ctf_traverse_cb_arg): Likewise.
741 (struct ctf_traverse_remove_cb_arg): Likewise.
743 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
745 * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
747 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
749 * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
750 (ctf_dump_funcs): Likewise.
752 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
754 * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
755 (ctf_fdopen): Check for endian-swapped raw CTF magic, and
756 little-endian CTF archive magic. Do not check the CTF version:
757 ctf_simple_open does that in endian-safe ways. Do not dereference
758 null pointers on open failure.
760 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
762 * ctf-open.c (get_vbytes_common): Return the new slice size.
763 (ctf_bufopen): Flip the endianness of the CTF-section header copy.
764 Remember to copy in the CTF data when opening an uncompressed
765 foreign-endian CTF file. Prune useless variable manipulation.
767 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
769 * ctf-open.c (ctf_types): Fail when unidentified type kinds are
772 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
774 * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
777 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
779 * ctf-subr.c (_PAGESIZE): Remove.
780 (ctf_data_alloc): Likewise.
781 (ctf_data_free): Likewise.
782 (ctf_data_protect): Likewise.
783 * ctf-impl.h: Remove declarations.
784 * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
785 ctf_free, not ctf_data_free.
786 (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc. Free
787 the buffer again on compression error.
788 * ctf-open.c (ctf_set_base): No longer track the size: call
789 ctf_free, not ctf_data_free.
790 (upgrade_types): Likewise. Call ctf_alloc, not ctf_data_alloc.
791 (ctf_bufopen): Likewise. No longer call ctf_data_protect.
793 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
795 * ctf-create.c (ctf_dtd_insert): Pass on error returns from
797 (ctf_dvd_insert): Likewise.
798 (ctf_add_generic): Likewise.
799 (ctf_add_variable): Likewise.
800 * ctf-impl.h: Adjust declarations.
802 2019-06-14 Alan Modra <amodra@gmail.com>
804 * configure: Regenerate.
806 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
808 * ctf-decls.h: Include <libiberty.h>.
809 * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
811 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
813 * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
814 (ctf_dump_objts): Likewise.
815 (ctf_dump_funcs): Likewise.
816 (ctf_dump_member): Likewise.
817 (ctf_dump_str): Likewise.
819 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
821 * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
822 * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
824 2019-06-05 Nick Alcock <nick.alcock@oracle.com>
826 * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
827 (ctf_arc_open_by_offset): Likewise.
828 * ctf-create.c (ctf_add_type): Likewise.
830 2019-06-04 Tom Tromey <tromey@adacore.com>
832 * ctf-create.c (ctf_add_encoded, ctf_add_slice)
833 (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
835 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
837 * configure.ac: Check for O_CLOEXEC.
838 * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
839 * config.h.in: Regenerate.
840 * configure: Likewise.
842 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
844 * qsort_r.c: Rename to...
845 * ctf-qsort_r.c: ... this.
846 (_quicksort): Define to ctf_qsort_r.
847 * ctf-decls.h (qsort_r): Remove.
849 (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
850 (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
851 * Makefile.am (libctf_a_LIBADD): Remove.
852 (libctf_a_SOURCES): New, add ctf-qsort_r.c.
853 * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
854 * ctf-create.c (ctf_update): Likewise.
855 * configure.ac: Check for BSD versus GNU qsort_r signature.
856 * Makefile.in: Regenerate.
857 * config.h.in: Likewise.
858 * configure: Likewise.
860 2019-06-03 Nick Alcock <nick.alcock@oracle.com>
862 * ctf-dump.c (ctf_dump_funcs): Free in the right place.
864 2019-05-29 Nick Alcock <nick.alcock@oracle.com>
866 * Makefile.am (ZLIB): New.
868 (AM_CFLAGS): Use them.
869 (libctf_a_LIBADD): New, for LIBOBJS.
870 * configure.ac: Check for zlib, endian.h, and qsort_r.
871 * ctf-endian.h: New, providing htole64 and le64toh.
872 * swap.h: Code style fixes.
873 (bswap_identity_64): New.
874 * qsort_r.c: New, from gnulib (with one added #include).
875 * ctf-decls.h: New, providing a conditional qsort_r declaration,
876 and unconditional definitions of MIN and MAX.
877 * ctf-impl.h: Use it. Do not use <sys/errno.h>.
878 (ctf_set_errno): Now returns unsigned long.
879 * ctf-util.c (ctf_set_errno): Adjust here too.
880 * ctf-archive.c: Use ctf-endian.h.
881 (ctf_arc_open_by_offset): Use memset, not bzero. Drop cts_type,
882 cts_flags and cts_offset.
883 (ctf_arc_write): Drop debugging dependent on the size of off_t.
884 * ctf-create.c: Provide a definition of roundup if not defined.
885 (ctf_create): Drop cts_type, cts_flags and cts_offset.
886 (ctf_add_reftype): Do not check if type IDs are below zero.
887 (ctf_add_slice): Likewise.
888 (ctf_add_typedef): Likewise.
889 (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
890 when known error-free. Drop CTF_ERR usage for functions returning
892 (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
894 (ctf_add_variable): Likewise.
898 (ctf_add_type): Likewise. Cast error-returning ssize_t's to size_t
899 when known error-free.
900 * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
901 returning int: use CTF_ERR for functions returning ctf_type_id.
902 (ctf_dump_label): Likewise.
903 (ctf_dump_objts): Likewise.
904 * ctf-labels.c (ctf_label_topmost): Likewise.
905 (ctf_label_iter): Likewise.
906 (ctf_label_info): Likewise.
907 * ctf-lookup.c (ctf_func_args): Likewise.
908 * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
909 (ctf_bufopen): Likewise. Use zlib types as needed.
910 * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
912 (ctf_enum_iter): Likewise.
913 (ctf_type_size): Likewise.
914 (ctf_type_align): Likewise. Cast to size_t where appropriate.
915 (ctf_type_kind_unsliced): Likewise.
916 (ctf_type_kind): Likewise.
917 (ctf_type_encoding): Likewise.
918 (ctf_member_info): Likewise.
919 (ctf_array_info): Likewise.
920 (ctf_enum_value): Likewise.
921 (ctf_type_rvisit): Likewise.
922 * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
924 (ctf_simple_open): Likewise.
925 (ctf_bfdopen_ctfsect): Likewise. Set cts_size properly.
926 * Makefile.in: Regenerate.
927 * aclocal.m4: Likewise.
928 * config.h: Likewise.
929 * configure: Likewise.
931 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
933 * configure.in: Check for bfd_section_from_elf_index.
934 * configure: Regenerate.
935 * config.h.in [HAVE_BFD_ELF]: Likewise.
936 * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
937 abfd is potentially unused now.
939 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
942 * Makefile.in: Regenerated.
943 * config.h.in: Likewise.
944 * aclocal.m4: Likewise.
945 * configure: Likewise.
947 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
951 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
955 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
957 * ctf-impl.h (_libctf_version): New declaration.
958 * ctf-subr.c (_libctf_version): Define it.
961 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
963 * ctf-create.c (enumcmp): New.
967 (ctf_add_type): Likewise.
969 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
971 * ctf-lookup.c (isqualifier): New.
972 (ctf_lookup_by_name): Likewise.
973 (struct ctf_lookup_var_key): Likewise.
974 (ctf_lookup_var): Likewise.
975 (ctf_lookup_variable): Likewise.
976 (ctf_lookup_symbol_name): Likewise.
977 (ctf_lookup_by_symbol): Likewise.
978 (ctf_func_info): Likewise.
979 (ctf_func_args): Likewise.
981 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
983 * ctf-decl.c: New file.
984 * ctf-types.c: Likewise.
985 * ctf-impl.h: New declarations.
987 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
989 * ctf-open-bfd.c: New file.
990 * ctf-open.c (ctf_close): New.
991 * ctf-impl.h: Include bfd.h.
992 (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
993 (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
995 (ctf_bfdopen_ctfsect): New declaration.
996 (_CTF_SECTION): likewise.
998 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1000 * ctf-archive.c: New.
1001 * ctf-impl.h (ctf_archive_internal): New type.
1002 (ctf_arc_open_internal): New declaration.
1003 (ctf_arc_bufopen): Likewise.
1004 (ctf_arc_close_internal): Likewise.
1006 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1008 * ctf-open.c: New file.
1011 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1013 * ctf-create.c: New file.
1014 * ctf-lookup.c: New file.
1016 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1018 * ctf-impl.h: New definitions and declarations for type creation
1021 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1023 * ctf-hash.c: New file.
1024 * ctf-impl.h: New declarations.
1026 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1028 * ctf-error.c: New file.
1030 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1032 * ctf-util.c: New file.
1034 * ctf-impl.h: Include it, and add declarations.
1036 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1038 * ctf-impl.h: New file.
1039 * ctf-subr.c: New file.
1046 version-control: never