1 2020-11-20 Nick Alcock <nick.alcock@oracle.com>
3 * ctf-impl.h (CTF_INDEX_PAD_THRESHOLD): New.
4 (_libctf_nonnull_): Likewise.
5 (ctf_in_flight_dynsym_t): New.
6 (ctf_dict_t) <ctf_funcidx_names>: Likewise.
7 <ctf_objtidx_names>: Likewise.
8 <ctf_nfuncidx>: Likewise.
9 <ctf_nobjtidx>: Likewise.
10 <ctf_funcidx_sxlate>: Likewise.
11 <ctf_objtidx_sxlate>: Likewise.
12 <ctf_objthash>: Likewise.
13 <ctf_funchash>: Likewise.
14 <ctf_dynsyms>: Likewise.
15 <ctf_dynsymidx>: Likewise.
16 <ctf_dynsymmax>: Likewise.
17 <ctf_in_flight_dynsym>: Likewise.
18 (struct ctf_next) <u.ctn_next>: Likewise.
19 (ctf_symtab_skippable): New prototype.
20 (ctf_add_funcobjt_sym): Likewise.
21 (ctf_dynhash_sort_by_name): Likewise.
22 (ctf_sym_to_elf64): Rename to...
23 (ctf_elf32_to_link_sym): ... this, and...
24 (ctf_elf64_to_link_sym): ... this.
25 * ctf-open.c (init_symtab): Check for lack of CTF_F_NEWFUNCINFO
26 flag, and presence of index sections. Refactor out
27 ctf_symtab_skippable and ctf_elf*_to_link_sym, and use them. Use
28 ctf_link_sym_t, not Elf64_Sym. Skip initializing objt or func
29 sxlate sections if corresponding index section is present. Adjust
30 for new func info section format.
31 (ctf_bufopen_internal): Add ctf_err_warn to corrupt-file error
32 handling. Report incorrect-length index sections. Always do an
33 init_symtab, even if there is no symtab section (there may be index
35 (flip_objts): Adjust comment: func and objt sections are actually
36 identical in structure now, no need to caveat.
37 (ctf_dict_close): Free newly-added data structures.
38 * ctf-create.c (ctf_create): Initialize them.
39 (ctf_symtab_skippable): New, refactored out of
40 init_symtab, with st_nameidx_set check added.
41 (ctf_add_funcobjt_sym): New, add a function or object symbol to the
42 ctf_objthash or ctf_funchash, by name.
43 (ctf_add_objt_sym): Call it.
44 (ctf_add_func_sym): Likewise.
45 (symtypetab_delete_nonstatic_vars): New, delete vars also present as
47 (CTF_SYMTYPETAB_EMIT_FUNCTION): New flag to symtypetab emitters:
48 this is a function emission, not a data object emission.
49 (CTF_SYMTYPETAB_EMIT_PAD): New flag to symtypetab emitters: emit
50 pads for symbols with no type (only set for unindexed sections).
51 (CTF_SYMTYPETAB_FORCE_INDEXED): New flag to symtypetab emitters:
53 (symtypetab_density): New, figure out section sizes.
54 (emit_symtypetab): New, emit a symtypetab.
55 (emit_symtypetab_index): New, emit a symtypetab index.
56 (ctf_serialize): Call them, emitting suitably sorted symtypetab
57 sections and indexes. Set suitable header flags. Copy over new
59 * ctf-hash.c (ctf_dynhash_sort_by_name): New, used to impose an
60 order on symtypetab index sections.
61 * ctf-link.c (ctf_add_type_mapping): Delete erroneous comment
62 relating to code that was never committed.
63 (ctf_link_one_variable): Improve variable name.
64 (check_sym): New, symtypetab analogue of check_variable.
65 (ctf_link_deduplicating_one_symtypetab): New.
66 (ctf_link_deduplicating_syms): Likewise.
67 (ctf_link_deduplicating): Call them.
68 (ctf_link_deduplicating_per_cu): Note that we don't call them in
70 (ctf_link_add_strtab): Set the error on the fp correctly.
71 (ctf_link_add_linker_symbol): New (no longer a do-nothing stub), add
72 a linker symbol to the in-flight list.
73 (ctf_link_shuffle_syms): New (no longer a do-nothing stub), turn the
74 in-flight list into a mapping we can use, now its names are
75 resolvable in the external strtab.
76 * ctf-string.c (ctf_str_rollback_atom): Don't roll back atoms with
77 external strtab offsets.
78 (ctf_str_rollback): Adjust comment.
79 (ctf_str_write_strtab): Migrate ctf_syn_ext_strtab population from
81 (ctf_str_add_external): ... to string addition time.
82 * ctf-lookup.c (ctf_lookup_var_key_t): Rename to...
83 (ctf_lookup_idx_key_t): ... this, now we use it for syms too.
84 <clik_names>: New member, a name table.
85 (ctf_lookup_var): Adjust accordingly.
86 (ctf_lookup_variable): Likewise.
87 (ctf_lookup_by_id): Shuffle further up in the file.
88 (ctf_symidx_sort_arg_cb): New, callback for...
89 (sort_symidx_by_name): ... this new function to sort a symidx
90 found to be unsorted (likely originating from the compiler).
91 (ctf_symidx_sort): New, sort a symidx.
92 (ctf_lookup_symbol_name): Support dynamic symbols with indexes
93 provided by the linker. Use ctf_link_sym_t, not Elf64_Sym.
94 Check the parent if a child lookup fails.
95 (ctf_lookup_by_symbol): Likewise. Work for function symbols too.
96 (ctf_symbol_next): New, iterate over symbols with types (without
98 (ctf_lookup_idx_name): New, bsearch for symbol names in indexes.
99 (ctf_try_lookup_indexed): New, attempt an indexed lookup.
100 (ctf_func_info): Reimplement in terms of ctf_lookup_by_symbol.
101 (ctf_func_args): Likewise.
102 (ctf_get_dict): Move...
103 * ctf-types.c (ctf_get_dict): ... here.
104 * ctf-util.c (ctf_sym_to_elf64): Re-express as...
105 (ctf_elf64_to_link_sym): ... this. Add new st_symidx field, and
106 st_nameidx_set (always 0, so st_nameidx can be ignored). Look in
107 the ELF strtab for names.
108 (ctf_elf32_to_link_sym): Likewise, for Elf32_Sym.
109 (ctf_next_destroy): Destroy ctf_next_t.u.ctn_next if need be.
110 * libctf.ver: Add ctf_symbol_next, ctf_add_objt_sym and
113 2020-11-20 Nick Alcock <nick.alcock@oracle.com>
115 * ctf-link.c (ctf_link_shuffle_syms): Adjust.
116 (ctf_link_add_linker_symbol): New, unimplemented stub.
117 * libctf.ver: Add it.
118 * ctf-create.c (ctf_serialize): Set CTF_F_DYNSTR on newly-serialized
120 * ctf-open-bfd.c (ctf_bfdopen_ctfsect): Check for the flag: open the
121 symtab/strtab if not present, dynsym/dynstr otherwise.
122 * ctf-archive.c (ctf_arc_bufpreamble): New, get the preamble from
123 some arbitrary member of a CTF archive.
124 * ctf-impl.h (ctf_arc_bufpreamble): Declare it.
126 2020-11-20 Nick Alcock <nick.alcock@oracle.com>
128 * ctf-archive.c (ctf_arc_open_by_offset): Rename to...
129 (ctf_dict_open_by_offset): ... this. Adjust callers.
130 (ctf_arc_open_by_name_internal): Rename to...
131 (ctf_dict_open_internal): ... this. Adjust callers.
132 (ctf_arc_open_by_name_sections): Rename to...
133 (ctf_dict_open_sections): ... this, keeping compatibility function.
134 (ctf_arc_open_by_name): Rename to...
135 (ctf_dict_open): ... this, keeping compatibility function.
136 * libctf.ver: New functions added.
137 * ctf-link.c (ctf_link_one_input_archive): Adjusted accordingly.
138 (ctf_link_deduplicating_open_inputs): Likewise.
140 2020-11-20 Nick Alcock <nick.alcock@oracle.com>
142 * ctf-impl.h: Rename ctf_file_t to ctf_dict_t: all declarations
144 (ctf_fileops): Rename to...
145 (ctf_dictops): ... this.
146 (ctf_dedup_t) <cd_id_to_file_t>: Rename to...
147 <cd_id_to_dict_t>: ... this.
148 (ctf_file_t): Fix outdated comment.
149 <ctf_fileops>: Rename to...
150 <ctf_dictops>: ... this.
151 (struct ctf_archive_internal) <ctfi_file>: Rename to...
152 <ctfi_dict>: ... this.
153 * ctf-archive.c: Rename ctf_file_t to ctf_dict_t.
154 Rename ctf_archive.ctfa_nfiles to ctfa_ndicts.
155 Rename ctf_file_close to ctf_dict_close. All users adjusted.
156 * ctf-create.c: Likewise. Refer to CTF dicts, not CTF containers.
157 (ctf_bundle_t) <ctb_file>: Rename to...
158 <ctb_dict): ... this.
159 * ctf-decl.c: Rename ctf_file_t to ctf_dict_t.
160 * ctf-dedup.c: Likewise. Rename ctf_file_close to
161 ctf_dict_close. Refer to CTF dicts, not CTF containers.
162 * ctf-dump.c: Likewise.
163 * ctf-error.c: Likewise.
164 * ctf-hash.c: Likewise.
165 * ctf-inlines.h: Likewise.
166 * ctf-labels.c: Likewise.
167 * ctf-link.c: Likewise.
168 * ctf-lookup.c: Likewise.
169 * ctf-open-bfd.c: Likewise.
170 * ctf-string.c: Likewise.
171 * ctf-subr.c: Likewise.
172 * ctf-types.c: Likewise.
173 * ctf-util.c: Likewise.
174 * ctf-open.c: Likewise.
175 (ctf_file_close): Rename to...
176 (ctf_dict_close): ...this.
177 (ctf_file_close): New trivial wrapper around ctf_dict_close, for
179 (ctf_parent_file): Rename to...
180 (ctf_parent_dict): ... this.
181 (ctf_parent_file): New trivial wrapper around ctf_parent_dict, for
183 * libctf.ver: Add ctf_dict_close and ctf_parent_dict.
185 2020-10-21 Tom Tromey <tromey@adacore.com>
187 * mkerrors.sed: Remove.
188 * ctf-error.c (_CTF_FIRST): New define.
189 (_CTF_ITEM): Define this, not _CTF_STR.
190 (_ctf_errlist, _ctf_erridx): Use _CTF_ERRORS.
191 (ERRSTRFIELD): Rewrite.
192 (ERRSTRFIELD1): Remove.
193 * Makefile.in: Rebuild.
194 * Makefile.am (BUILT_SOURCES): Remove.
195 (ctf-error.h): Remove.
197 2020-08-27 Nick Alcock <nick.alcock@oracle.com>
199 * ctf-subr.c (open_errors): New list.
200 (ctf_err_warn): Calls with NULL fp append to open_errors. Add err
201 parameter, and use it to decorate the debug stream with errmsgs.
202 (ctf_err_warn_to_open): Splice errors from a CTF dict into the
204 (ctf_errwarning_next): Calls with NULL fp report from open_errors.
205 New err param to report iteration errors (including end-of-iteration)
207 (ctf_assert_fail_internal): Adjust ctf_err_warn call for new err
208 parameter: gettextize.
209 * ctf-impl.h (ctfo_get_vbytes): Add ctf_file_t parameter.
210 (LCTF_VBYTES): Adjust.
211 (ctf_err_warn_to_open): New.
212 (ctf_err_warn): Adjust.
213 (ctf_bundle): Used in only one place: move...
214 * ctf-create.c: ... here.
215 (enumcmp): Use ctf_err_warn, not ctf_dprintf, passing the err number
216 down as needed. Don't emit the errmsg. Gettextize.
218 (ctf_add_type_internal): Likewise.
219 (ctf_write_mem): Likewise.
220 (ctf_compress_write): Likewise. Report errors writing the header or
222 (ctf_write): Likewise.
223 * ctf-archive.c (ctf_arc_write_fd): Use ctf_err_warn, not
224 ctf_dprintf, and gettextize, as above.
225 (ctf_arc_write): Likewise.
226 (ctf_arc_bufopen): Likewise.
227 (ctf_arc_open_internal): Likewise.
228 * ctf-labels.c (ctf_label_iter): Likewise.
229 * ctf-open-bfd.c (ctf_bfdclose): Likewise.
230 (ctf_bfdopen): Likewise.
231 (ctf_bfdopen_ctfsect): Likewise.
232 (ctf_fdopen): Likewise.
233 * ctf-string.c (ctf_str_write_strtab): Likewise.
234 * ctf-types.c (ctf_type_resolve): Likewise.
235 * ctf-open.c (get_vbytes_common): Likewise. Pass down the ctf dict.
236 (get_vbytes_v1): Pass down the ctf dict.
237 (get_vbytes_v2): Likewise.
238 (flip_ctf): Likewise.
239 (flip_types): Likewise. Use ctf_err_warn, not ctf_dprintf, and
240 gettextize, as above.
241 (upgrade_types_v1): Adjust calls.
242 (init_types): Use ctf_err_warn, not ctf_dprintf, as above.
243 (ctf_bufopen_internal): Likewise. Adjust calls. Transplant errors
244 emitted into individual dicts into the open errors if this turns
245 out to be a failed open in the end.
246 * ctf-dump.c (ctf_dump_format_type): Adjust ctf_err_warn for new err
247 argument. Gettextize. Don't emit the errmsg.
248 (ctf_dump_funcs): Likewise. Collapse err label into its only case.
249 (ctf_dump_type): Likewise.
250 * ctf-link.c (ctf_create_per_cu): Adjust ctf_err_warn for new err
251 argument. Gettextize. Don't emit the errmsg.
252 (ctf_link_one_type): Likewise.
253 (ctf_link_lazy_open): Likewise.
254 (ctf_link_one_input_archive): Likewise.
255 (ctf_link_deduplicating_count_inputs): Likewise.
256 (ctf_link_deduplicating_open_inputs): Likewise.
257 (ctf_link_deduplicating_close_inputs): Likewise.
258 (ctf_link_deduplicating): Likewise.
259 (ctf_link): Likewise.
260 (ctf_link_deduplicating_per_cu): Likewise. Add some missed
261 ctf_set_errnos to obscure error cases.
262 * ctf-dedup.c (ctf_dedup_rhash_type): Adjust ctf_err_warn for new
263 err argument. Gettextize. Don't emit the errmsg.
264 (ctf_dedup_populate_mappings): Likewise.
265 (ctf_dedup_detect_name_ambiguity): Likewise.
266 (ctf_dedup_init): Likewise.
267 (ctf_dedup_multiple_input_dicts): Likewise.
268 (ctf_dedup_conflictify_unshared): Likewise.
269 (ctf_dedup): Likewise.
270 (ctf_dedup_rwalk_one_output_mapping): Likewise.
271 (ctf_dedup_id_to_target): Likewise.
272 (ctf_dedup_emit_type): Likewise.
273 (ctf_dedup_emit_struct_members): Likewise.
274 (ctf_dedup_populate_type_mapping): Likewise.
275 (ctf_dedup_populate_type_mappings): Likewise.
276 (ctf_dedup_emit): Likewise.
277 (ctf_dedup_hash_type): Likewise. Fix a bit of messed-up error
279 (ctf_dedup_rwalk_one_output_mapping): Likewise. Don't hide
280 unknown-type-kind messages (which signify file corruption).
282 2020-08-27 Nick Alcock <nick.alcock@oracle.com>
284 * configure.ac: Adjust package name to simply 'libctf': arbitrarily
285 declare this to be version 1.2.0.
286 * Makefile.am (AM_CPPFLAGS): Add @INCINTL@.
287 * Makefile.in: Regenerated.
288 * configure: Regenerated.
289 * ctf-intl.h: New file, lightly modified from opcodes/opintl.h.
290 * ctf-impl.h: Include it.
291 * ctf-error.r (_ctf_errlist_t): Mark strings as noop-translatable.
292 (ctf_errmsg): Actually translate them.
294 2020-07-26 Eli Zaretskii <eliz@gnu.org>
297 * ctf-create.c (EOVERFLOW): If not defined by system header,
298 redirect to ERANGE as a poor man's substitute.
299 * ctf-subr.c (ENOTSUP): If not defined, use ENOSYS instead.
301 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
303 * ctf-create.c (ctf_dtd_insert): Add uintptr_t casts.
304 (ctf_dtd_delete): Likewise.
305 (ctf_dtd_lookup): Likewise.
306 (ctf_rollback): Likewise.
307 * ctf-hash.c (ctf_hash_lookup_type): Likewise.
308 * ctf-types.c (ctf_lookup_by_rawhash): Likewise.
310 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
312 * ctf-lookup.c (ctf_lookup_by_name): Adjust.
314 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
316 * ctf-archive.c (ctf_arc_bufopen): Endian-swap the archive magic
319 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
321 * ctf-impl.h (ctf_list_splice): New.
322 * ctf-util.h (ctf_list_splice): Likewise.
323 * ctf-link.c (link_sort_inputs_cb_arg_t): Likewise.
324 (ctf_link_sort_inputs): Likewise.
325 (ctf_link_deduplicating_count_inputs): Likewise.
326 (ctf_link_deduplicating_open_inputs): Likewise.
327 (ctf_link_deduplicating_close_inputs): Likewise.
328 (ctf_link_deduplicating_variables): Likewise.
329 (ctf_link_deduplicating_per_cu): Likewise.
330 (ctf_link_deduplicating): Likewise.
333 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
335 * ctf-link.c (ctf_link_one_input_archive_member): Check
336 CTF_LINK_OMIT_VARIABLES_SECTION.
338 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
340 * ctf-impl.h (ctf_type_id_key): New, the key in the
342 (ctf_dedup): New, core deduplicator state.
343 (ctf_file_t) <ctf_dedup>: New.
344 <ctf_dedup_atoms>: New.
345 <ctf_dedup_atoms_alloc>: New.
346 (ctf_hash_type_id_key): New prototype.
347 (ctf_hash_eq_type_id_key): Likewise.
348 (ctf_dedup_atoms_init): Likewise.
349 * ctf-hash.c (ctf_hash_eq_type_id_key): New.
350 (ctf_dedup_atoms_init): Likewise.
351 * ctf-create.c (ctf_serialize): Adjusted.
352 (ctf_add_encoded): No longer static.
353 (ctf_add_reftype): Likewise.
354 * ctf-open.c (ctf_file_close): Destroy the
355 ctf_dedup_atoms_alloc.
356 * ctf-dedup.c: New file.
357 * ctf-decls.h [!HAVE_DECL_STPCPY]: Add prototype.
358 * configure.ac: Check for stpcpy.
359 * Makefile.am: Add it.
360 * Makefile.in: Regenerate.
361 * config.h.in: Regenerate.
362 * configure: Regenerate.
364 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
366 * configure.ac: Add --enable-libctf-hash-debugging.
367 * aclocal.m4: Pull in enable.m4, for GCC_ENABLE.
368 * Makefile.in: Regenerated.
369 * configure: Likewise.
370 * config.h.in: Likewise.
371 * ctf-impl.h [ENABLE_LIBCTF_HASH_DEBUGGING]
372 (ctf_assert): Define to assert.
374 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
376 * ctf-sha1.h: New, inline wrappers around sha1_init_ctx and
378 * ctf-impl.h: Include it.
379 (ctf_sha1_init): New.
380 (ctf_sha1_add): Likewise.
381 (ctf_sha1_fini): Likewise.
382 * ctf-sha1.c: New, non-inline wrapper around sha1_finish_ctx
384 * Makefile.am: Add file.
385 * Makefile.in: Regenerate.
387 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
389 * libctf.ver (ctf_link_set_variable_filter): Add.
390 * ctf-impl.h (ctf_file_t) <ctf_link_variable_filter>: New.
391 <ctf_link_variable_filter_arg>: Likewise.
392 * ctf-create.c (ctf_serialize): Adjust.
393 * ctf-link.c (ctf_link_set_variable_filter): New, set it.
394 (ctf_link_one_variable): Call it if set.
396 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
398 * ctf-link.c (ctf_link_one_variable): Check the dst_type for
399 conflicts, not the source type.
401 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
403 * ctf-impl.h (ctf_file_t): Improve comments.
404 <ctf_link_cu_mapping>: Split into...
405 <ctf_link_in_cu_mapping>: ... this...
406 <ctf_link_out_cu_mapping>: ... and this.
407 * ctf-create.c (ctf_serialize): Adjust.
408 * ctf-open.c (ctf_file_close): Likewise.
409 * ctf-link.c (ctf_create_per_cu): Look things up in the
410 in_cu_mapping instead of the cu_mapping.
411 (ctf_link_add_cu_mapping): The deduplicating link will define
412 what happens if many FROMs share a TO.
413 (ctf_link_add_cu_mapping): Create in_cu_mapping and
414 out_cu_mapping. Do not create ctf_link_outputs here any more, or
415 create per-CU dicts here: they are already created when needed.
416 (ctf_link_one_variable): Log a debug message if we skip a
417 variable due to its type being concealed in a CU-mapped link.
418 (This is probably too common a case to make into a warning.)
419 (ctf_link): Create empty per-CU dicts if requested.
421 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
423 * ctf-link.c (ctf_link_write): Close the fd.
425 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
427 * Makefile.am: Set -DNOBFD=1 in libctf-nobfd, and =0 elsewhere.
428 * Makefile.in: Regenerated.
429 * ctf-impl.h (ctf_link_input_name): New.
430 (ctf_file_t) <ctf_link_flags>: New.
431 * ctf-create.c (ctf_serialize): Adjust accordingly.
432 * ctf-link.c: Define ctf_open as weak when PIC.
433 (ctf_arc_close_thunk): Remove unnecessary thunk.
434 (ctf_file_close_thunk): Likewise.
435 (ctf_link_input_name): New.
436 (ctf_link_input_t): New value of the ctf_file_t.ctf_link_input.
437 (ctf_link_input_close): Adjust accordingly.
438 (ctf_link_add_ctf_internal): New, split from...
439 (ctf_link_add_ctf): ... here. Return error if lazy loading of
440 CTF is not possible. Change to just call...
441 (ctf_link_add): ... this new function.
442 (ctf_link_add_cu_mapping): Transition to ctf_err_warn. Drop the
443 ctf_file_close_thunk.
444 (ctf_link_in_member_cb_arg_t) <file_name> Rename to...
445 <in_file_name>: ... this.
447 <share_mode>: Likewise (migrated to ctf_link_flags).
448 <done_main_member>: Rename to...
449 <done_parent>: ... this.
450 <main_input_fp>: Rename to...
451 <in_fp_parent>: ... this.
453 (ctf_link_one_type): Adjuwt accordingly. Transition to
454 ctf_err_warn, removing a TODO.
455 (ctf_link_one_variable): Note a case too common to warn about.
456 Report in the debug stream if a cu-mapped link prevents addition
457 of a conflicting variable.
458 (ctf_link_one_input_archive_member): Adjust.
459 (ctf_link_lazy_open): New, open a CTF archive for linking when
461 (ctf_link_close_one_input_archive): New, close it again.
462 (ctf_link_one_input_archive): Adjust for lazy opening, member
463 renames, and ctf_err_warn transition. Move the
464 empty_link_type_mapping call to...
465 (ctf_link): ... here. Adjut for renamings and thunk removal.
466 Don't spuriously fail if some input contains no CTF data.
467 (ctf_link_write): ctf_err_warn transition.
468 * libctf.ver: Remove not-yet-stable comment.
470 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
472 * ctf-impl.h (ctf_strerror): Delete.
473 * ctf-subr.c (ctf_strerror): Likewise.
474 * ctf-error.c (ctf_errmsg): Stop using ctf_strerror: just use
477 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
479 * ctf-impl.c (ctf_file_t) <ctf_parent_unreffed>: New.
480 (ctf_import_unref): New.
481 * ctf-open.c (ctf_file_close) Drop the refcount all the way to
482 zero. Don't recurse back in if the refcount is already zero.
483 (ctf_import): Check ctf_parent_unreffed before deciding whether
484 to close a pre-existing parent. Set it to zero.
485 (ctf_import_unreffed): New, as above, setting
486 ctf_parent_unreffed to 1.
487 * ctf-create.c (ctf_serialize): Do not ctf_import into the new
488 child: use direct assignment, and set unreffed on the new and
490 * ctf-link.c (ctf_create_per_cu): Import the parent using
493 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
495 * ctf-impl.h (ctf_link_type_mapping_key): Rename to...
496 (ctf_link_type_key): ... this, adjusting member prefixes to
498 (ctf_hash_type_mapping_key): Rename to...
499 (ctf_hash_type_key): ... this.
500 (ctf_hash_eq_type_mapping_key): Rename to...
501 (ctf_hash_eq_type_key): ... this.
502 * ctf-hash.c (ctf_hash_type_mapping_key): Rename to...
503 (ctf_hash_type_key): ... this, and adjust for member name
505 (ctf_hash_eq_type_mapping_key): Rename to...
506 (ctf_hash_eq_type_key): ... this, and adjust for member name
508 * ctf-link.c (ctf_add_type_mapping): Adjust. Note the lack of
509 need for out-of-memory checking in this code.
510 (ctf_type_mapping): Adjust.
512 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
514 configure.ac: Check for vasprintf.
515 configure: Regenerated.
516 config.h.in: Likewise.
518 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
520 * ctf-archive.c (ctf_arc_bufopen): Fix message.
522 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
524 * ctf-impl.h (struct ctf_archive_internal) <ctfi_free_strsect>
526 * ctf-open-bfd.c (ctf_bfdopen_ctfsect): Explicitly open a strtab
527 if the input has no symtab, rather than dividing by
528 zero. Arrange to free it later via ctfi_free_ctfsect.
529 * ctf-archive.c (ctf_new_archive_internal): Do not
530 ctfi_free_strsect by default.
531 (ctf_arc_close): Possibly free it here.
533 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
535 * ctf-dump.c (ctf_is_slice): Delete, unnecessary.
536 (ctf_dump_format_type): improve slice formatting. Always print
537 the type size, even of slices.
538 (ctf_dump_member): Print slices (-> bitfields) differently from
539 non-slices. Failure to format a type is not an OOM.
541 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
543 * ctf-dump.c (ctf_dump_format_type): Emit a warning.
544 (ctf_dump_label): Swallow errors from ctf_dump_format_type.
545 (ctf_dump_objts): Likewise.
546 (ctf_dump_var): Likewise.
547 (ctf_dump_type): Do not emit a duplicate message. Move to
548 ctf_err_warning, and swallow all errors.
550 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
552 * ctf-decl.c (ctf_decl_fini): Free the cd_buf.
553 (ctf_decl_buf): Once it escapes, don't try to free it later.
555 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
557 * ctf-types.c (ctf_type_aname): Print arg types here...
558 * ctf-dump.c (ctf_dump_funcs): ... not here: but do substitute
559 in the type name here.
561 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
563 * ctf-impl.h (ctf_assert): New.
564 (ctf_err_warning_t): Likewise.
565 (ctf_file_t) <ctf_errs_warnings>: Likewise.
566 (ctf_err_warn): New prototype.
567 (ctf_assert_fail_internal): Likewise.
568 * ctf-inlines.h (ctf_assert_internal): Likewise.
569 * ctf-open.c (ctf_file_close): Free ctf_errs_warnings.
570 * ctf-create.c (ctf_serialize): Copy it on serialization.
571 * ctf-subr.c (ctf_err_warn): New, add an error/warning.
572 (ctf_errwarning_next): New iterator, free and pass back
573 errors/warnings in succession.
574 * libctf.ver (ctf_errwarning_next): Add.
576 2020-07-22 Egeyar Bagcioglu <egeyar.bagcioglu@oracle.com>
578 * ctf-types.c (ctf_variable_iter): Fix error return.
580 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
582 * ctf-open.c (ctf_bufopen_internal): Diagnose invalid flags.
584 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
586 ctf-decls.h (ctf_qsort_compar_thunk): Fix arg passing.
588 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
590 * ctf-impl.h (ctf_next_hkv_t): New, kv-pairs passed to
592 (ctf_next_t) <u.ctn_sorted_hkv>: New, sorted kv-pairs for
593 ctf_dynhash_next_sorted.
594 <cu.ctn_h>: New, pointer to the dynhash under iteration.
595 <cu.ctn_s>: New, pointer to the dynset under iteration.
596 (ctf_hash_sort_f): Sorting function passed to...
597 (ctf_dynhash_next_sorted): ... this new function.
598 (ctf_dynhash_next): New.
599 (ctf_dynset_next): New.
600 * ctf-inlines.h (ctf_dynhash_cnext_sorted): New.
601 (ctf_dynhash_cnext): New.
602 (ctf_dynset_cnext): New.
603 * ctf-hash.c (ctf_dynhash_next_sorted): New.
604 (ctf_dynhash_next): New.
605 (ctf_dynset_next): New.
606 * ctf-util.c (ctf_next_destroy): Free the u.ctn_sorted_hkv if
608 (ctf_next_copy): Alloc-and-copy the u.ctn_sorted_hkv if needed.
610 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
612 * ctf-impl.h (ctf_next): New.
613 (ctf_get_dict): New prototype.
614 * ctf-lookup.c (ctf_get_dict): New, split out of...
615 (ctf_lookup_by_id): ... here.
616 * ctf-util.c (ctf_next_create): New.
617 (ctf_next_destroy): New.
618 (ctf_next_copy): New.
619 * ctf-types.c (includes): Add <assert.h>.
620 (ctf_member_next): New.
621 (ctf_enum_next): New.
622 (ctf_type_iter): Document the lack of iteration over parent
624 (ctf_type_next): New.
625 (ctf_variable_next): New.
626 * ctf-archive.c (ctf_archive_next): New.
627 * libctf.ver: Add new public functions.
629 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
631 * libctf.ver (ctf_ref): New.
632 * ctf-open.c (ctf_ref): Implement it.
634 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
636 * ctf-inlines.h (ctf_forwardable_kind): New.
637 * ctf-create.c (ctf_add_forward): Use it.
639 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
641 * ctf-impl.h (ctf_get_ctt_size): Move definition from here...
642 * ctf-inlines.h (ctf_get_ctt_size): ... to here.
644 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
646 * ctf-hash.c (ctf_dynset_eq_string): New.
647 (ctf_dynset_create): New.
648 (DYNSET_EMPTY_ENTRY_REPLACEMENT): New.
649 (DYNSET_DELETED_ENTRY_REPLACEMENT): New.
650 (key_to_internal): New.
651 (internal_to_key): New.
652 (ctf_dynset_insert): New.
653 (ctf_dynset_remove): New.
654 (ctf_dynset_destroy): New.
655 (ctf_dynset_lookup): New.
656 (ctf_dynset_exists): New.
657 (ctf_dynset_lookup_any): New.
658 (ctf_hash_insert_type): Coding style.
659 (ctf_hash_define_type): Likewise.
660 * ctf-impl.h (ctf_dynset_t): New.
661 (ctf_dynset_eq_string): New.
662 (ctf_dynset_create): New.
663 (ctf_dynset_insert): New.
664 (ctf_dynset_remove): New.
665 (ctf_dynset_destroy): New.
666 (ctf_dynset_lookup): New.
667 (ctf_dynset_exists): New.
668 (ctf_dynset_lookup_any): New.
669 * ctf-inlines.h (ctf_dynset_cinsert): New.
671 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
673 * ctf-hash.c (ctf_helem_t) <key_free>: Remove.
674 <value_free>: Likewise.
676 (ctf_dynhash_item_free): Indirect through the owner.
677 (ctf_dynhash_create): Only pass in ctf_dynhash_item_free and
678 allocate space for the key_free and value_free fields fields
680 (ctf_hashtab_insert): Likewise. Fix OOM errno value.
681 (ctf_dynhash_insert): Only access ctf_hashtab's key_free and
682 value_free if they will exist. Set the slot's owner, but only
684 (ctf_dynhash_remove): Adjust.
686 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
688 * ctf-hash.c (ctf_hashtab_insert): Free the key passed in if
689 there is a key-freeing function and the key already exists.
691 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
693 * ctf-inlines.h: New file.
694 * ctf-impl.h: Include it.
695 (ctf_hash_iter_find_f): New typedef.
696 (ctf_dynhash_elements): New.
697 (ctf_dynhash_lookup_kv): New.
698 (ctf_dynhash_iter_find): New.
699 * ctf-hash.c (ctf_dynhash_lookup_kv): New.
700 (ctf_traverse_find_cb_arg_t): New.
701 (ctf_hashtab_traverse_find): New.
702 (ctf_dynhash_iter_find): New.
703 (ctf_dynhash_elements): New.
705 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
707 * ctf-impl.h [!__GNUC__] (__extension__): Define to nothing.
709 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
711 * ctf-archive.c (ctf_archive_count): New.
712 * libctf.ver: New public function.
714 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
716 * ctf-types.c (ctf_member_count): New.
717 * libctf.ver: New public function.
719 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
721 * ctf-types.c (ctf_type_kind_forwarded): New.
723 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
725 * ctf-types.c (ctf_type_name_raw): New.
726 (ctf_type_aname_raw): Reimplement accordingly.
728 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
730 * ctf-subr.c (ctf_dprintf): _libctf_debug is unlikely to be set.
732 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
734 * ctf-impl.h (struct ctf_archive_internal)
735 <ctfi_unmap_on_close>: New.
736 (ctf_new_archive_internal): Adjust.
737 * ctf-archive.c (ctf_new_archive_internal): Likewise.
738 Initialize ctfi_unmap_on_close. Adjust error path.
739 (ctf_arc_bufopen): Adjust ctf_new_archive_internal call
740 (unmap_on_close is 0).
741 (ctf_arc_close): Only unmap if ctfi_unmap_on_close.
742 * ctf-open-bfd.c (ctf_fdopen): Adjust.
744 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
746 * ctf-types.c (ctf_type_aname): Return ECTF_CORRUPT if
747 ints, floats or typedefs have no name. Fix comment typo.
749 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
751 * ctf-create.c (ctf_add_slice): Support slices of any kind that
752 resolves to an integral type.
753 * ctf-types.c (ctf_type_encoding): Resolve the type before
754 fishing its encoding out.
756 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
758 * ctf-create.c (ctf_create): Mark dirty.
760 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
762 * ctf-create.c (membcmp) Skip nameless members.
764 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
766 * ctf-create.c (ctf_add_member_offset): Support names of ""
767 as if they were the null pointer.
769 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
771 * ctf-open.c (init_types): Remove typeless CTF_K_FORWARD
774 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
776 * ctf-types.c (ctf_type_reference): Add support for dynamic slices.
778 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
780 * ctf-create.c (ctf_serialize): Add cast.
781 (ctf_add_slice): Likewise.
783 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
785 * ctf-impl.h (ctf_dtdef_t) <dtu_argv>: Fix type.
786 * ctf-create.c (ctf_add_function): Check for unimplemented type
787 and populate at the same time. Populate one-by-one, not via
789 (ctf_serialize): Remove unnecessary cast.
790 * ctf-types.c (ctf_func_type_info): Likewise.
791 (ctf_func_type_args): Likewise. Fix comment typo.
793 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
795 * ctf-create.c (ctf_add_reftype): Support refs to type zero.
796 (ctf_add_array): Support array contents of type zero.
797 (ctf_add_function): Support arguments and return types of
799 (ctf_add_typedef): Support typedefs to type zero.
800 (ctf_add_member_offset): Support members of type zero,
801 unless added at unspecified (naturally-aligned) offset.
803 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
805 * ctf-error.c: Include <stddef.h>, for offsetof.
806 (_ctf_errlist): Migrate to...
807 (_ctf_errlist_t): ... this.
808 (_ctf_erridx): New, indexes into _ctf_errlist_t.
810 (ctf_errmsg): Adjust accordingly.
811 * Makefile.am (BUILT_SOURCES): Note...
812 (ctf-error.h): ... this new rule.
813 * Makefile.in: Regenerate.
814 * mkerrors.sed: New, process ctf-api.h to generate ctf-error.h.
815 * .gitignore: New, ignore ctf-error.h.
817 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
819 * ctf-impl.h: Fix typos in comments.
821 2020-07-22 Nick Clifton <nickc@redhat.com>
823 * ctf-archive.c (ctf_arc_write): Avoid calling close twice on the
824 same file descriptor.
826 2020-07-04 Nick Clifton <nickc@redhat.com>
828 Binutils 2.35 branch created.
830 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
832 * aclocal.m4: Add config/gettext-sister.m4: Shuffle into
834 * configure.ac: Add ZW_GNU_GETTEXT_SISTER_DIR.
835 * config.h.in: Regenerated.
836 * Makefile.in: Likewise.
837 * configure: Likewise.
839 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
841 * ctf-create.c: Include <unistd.h>.
842 * ctf-open-bfd.c: Likewise.
844 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
847 * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls.
848 * swap.h (bswap_16): Do not assume that presence of <byteswap.h>
849 means this is declared.
850 (bswap_32): Likewise.
851 (bswap_64): Likewise.
852 (bswap_identity_64): Remove, unused.
853 * configure: Regenerated.
854 * config.h.in: Likewise.
856 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
859 * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback.
860 (_libctf_unlikely_): Likewise.
861 (_libctf_unused): Likewise.
862 (_libctf_malloc_): Likewise.
864 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
867 * ctf-archive.c (search_nametbl): No longer global: declare...
868 (ctf_arc_open_by_name_internal): ... here. Use bsearch_r.
869 (search_modent_by_name): Take and use ARG for the nametbl.
871 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
873 * ctf-impl.h (ctf_new_archive_internal): Declare.
874 (ctf_arc_bufopen): Remove.
875 (ctf_archive_internal) <ctfi_free_symsect>: New.
876 * ctf-archive.c (ctf_arc_close): Use it.
877 (ctf_arc_bufopen): Fuse into...
878 (ctf_new_archive_internal): ... this, moved across from...
879 * ctf-open-bfd.c: ... here.
880 (ctf_bfdopen_ctfsect): Use ctf_arc_bufopen.
881 * libctf.ver: Add it.
883 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
885 * ctf-create.c (ctf_add_forward): Intern in the right namespace.
886 (ctf_dtd_delete): Remove correspondingly.
887 (ctf_rollback): Likewise.
889 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
891 * ctf-create.c (ctf_add_type_internal): Hand back existing types
894 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
896 * ctf-create.c (ctf_add_forward): Don't add forwards to
897 types that already exist.
899 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
901 * ctf-open.c (init_types): Only intern root-visible types.
902 * ctf-create.c (ctf_dtd_insert): Likewise.
903 (ctf_dtd_delete): Only remove root-visible types.
904 (ctf_rollback): Likewise.
905 (ctf_add_generic): Adjust.
906 (ctf_add_struct_sized): Adjust comment.
907 (ctf_add_union_sized): Likewise.
908 (ctf_add_enum): Likewise.
909 * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
911 2020-03-11 John Baldwin <jhb@FreeBSD.org>
913 * swap.h (bswap_identity_64): Make static.
915 2020-01-18 Nick Clifton <nickc@redhat.com>
917 Binutils 2.34 branch created.
919 2020-01-05 Joel Brobecker <brobecker@adacore.com>
922 * configure.ac: Add AC_CHECK_DECLS([asprintf]).
923 * configure, config.h.in: Regenerate.
925 2020-01-01 Alan Modra <amodra@gmail.com>
927 Update year range in copyright notice of all files.
929 2019-10-16 Simon Marchi <simon.marchi@polymtl.ca>
931 * swap.h (bswap_16, bswap_32, bswap_64): Make static.
933 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
935 * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
936 * ctf-types.c (ctf_type_lname): Likewise.
938 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
940 * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
941 ctf_import after the first for a given file.
943 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
945 * ctf-impl.h (ctf_str_append_noerr): Declare.
946 * ctf-util.c (ctf_str_append_noerr): Define in terms of
948 * ctf-dump.c (str_append): New, call it.
949 (ctf_dump_format_type): Use str_append, not ctf_str_append.
950 (ctf_dump_label): Likewise.
951 (ctf_dump_objts): Likewise.
952 (ctf_dump_funcs): Likewise.
953 (ctf_dump_var): Likewise.
954 (ctf_dump_member): Likewise.
955 (ctf_dump_type): Likewise.
956 (ctf_dump): Likewise.
958 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
960 * ctf-impl.h (ctf_alloc): Remove.
961 (ctf_free): Likewise.
962 (ctf_strdup): Likewise.
963 * ctf-subr.c (ctf_alloc): Remove.
964 (ctf_free): Likewise.
965 * ctf-util.c (ctf_strdup): Remove.
967 * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
968 ctf_free; strdup, not ctf_strdup.
969 (ctf_dtd_delete): Likewise.
970 (ctf_dvd_delete): Likewise.
971 (ctf_add_generic): Likewise.
972 (ctf_add_function): Likewise.
973 (ctf_add_enumerator): Likewise.
974 (ctf_add_member_offset): Likewise.
975 (ctf_add_variable): Likewise.
977 (ctf_compress_write): Likewise.
978 (ctf_write_mem): Likewise.
979 * ctf-decl.c (ctf_decl_push): Likewise.
980 (ctf_decl_fini): Likewise.
981 (ctf_decl_sprintf): Likewise. Check for OOM.
982 * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
983 ctf_free; strdup, not ctf_strdup.
984 (ctf_dump_free): Likewise.
985 (ctf_dump): Likewise.
986 * ctf-open.c (upgrade_types_v1): Likewise.
987 (init_types): Likewise.
988 (ctf_file_close): Likewise.
989 (ctf_bufopen_internal): Likewise. Check for OOM.
990 (ctf_parent_name_set): Likewise: report the OOM to the caller.
991 (ctf_cuname_set): Likewise.
992 (ctf_import): Likewise.
993 * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
994 free, not ctf_free; strdup, not ctf_strdup.
995 (ctf_str_free_atom): Likewise.
996 (ctf_str_create_atoms): Likewise.
997 (ctf_str_add_ref_internal): Likewise.
998 (ctf_str_remove_ref): Likewise.
999 (ctf_str_write_strtab): Likewise.
1001 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
1003 * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
1004 work right for non-int/fps.
1006 2019-08-08 Nick Alcock <nick.alcock@oracle.com>
1008 * ctf-types.c (ctf_type_name): Don't strlen a potentially-
1011 2019-08-07 Nick Alcock <nick.alcock@oracle.com>
1013 * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
1014 * ctf-open.c (ctf_file_close): Free it.
1015 * ctf-create.c (ctf_serialize): Adjust.
1016 (membcmp): When reporting a conflict due to an error, report the
1018 (ctf_add_type): Turn into a ctf_add_processing wrapper. Rename to...
1019 (ctf_add_type_internal): ... this. Hand back types we are already
1020 in the middle of adding immediately. Hand back structs/unions with
1021 the same number of members immediately. Do not walk the dynamic
1022 list. Call ctf_add_type_internal, not ctf_add_type. Handle
1023 forwards promoted to other types and the inverse case identically.
1024 Add structs to the mapping as soon as we intern them, before they
1027 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
1029 * ctf-impl.h (ctf_names_t): New.
1030 (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
1031 (ctf_file_t) <ctf_structs>: Likewise.
1032 <ctf_unions>: Likewise.
1033 <ctf_enums>: Likewise.
1034 <ctf_names>: Likewise.
1035 <ctf_lookups>: Improve comment.
1036 <ctf_ptrtab_len>: New.
1037 <ctf_prov_strtab>: New.
1038 <ctf_str_prov_offset>: New.
1039 <ctf_dtbyname>: Remove, redundant to the names hashes.
1040 <ctf_dtnextid>: Remove, redundant to ctf_typemax.
1041 (ctf_dtdef_t) <dtd_name>: Remove.
1042 <dtd_data>: Note that the ctt_name is now populated.
1043 (ctf_str_atom_t) <csa_offset>: This is now the strtab
1044 offset for internal strings too.
1045 <csa_external_offset>: New, the external strtab offset.
1046 (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
1047 (ctf_name_table): New declaration.
1048 (ctf_lookup_by_rawname): Likewise.
1049 (ctf_lookup_by_rawhash): Likewise.
1050 (ctf_set_ctl_hashes): Likewise.
1051 (ctf_serialize): Likewise.
1052 (ctf_dtd_insert): Adjust.
1053 (ctf_simple_open_internal): Likewise.
1054 (ctf_bufopen_internal): Likewise.
1055 (ctf_list_empty_p): Likewise.
1056 (ctf_str_remove_ref): Likewise.
1057 (ctf_str_add): Returns uint32_t now.
1058 (ctf_str_add_ref): Likewise.
1059 (ctf_str_add_external): Now returns a boolean (int).
1060 * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
1061 for strings in the appropriate range.
1062 (ctf_str_create_atoms): Create the ctf_prov_strtab. Detect OOM
1063 when adding the null string to the new strtab.
1064 (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
1065 (ctf_str_add_ref_internal): Add make_provisional argument. If
1066 make_provisional, populate the offset and fill in the
1067 ctf_prov_strtab accordingly.
1068 (ctf_str_add): Return the offset, not the string.
1069 (ctf_str_add_ref): Likewise.
1070 (ctf_str_add_external): Return a success integer.
1071 (ctf_str_remove_ref): New, remove a single ref.
1072 (ctf_str_count_strtab): Do not count the initial null string's
1073 length or the existence or length of any unreferenced internal
1075 (ctf_str_populate_sorttab): Skip atoms with no refs.
1076 (ctf_str_write_strtab): Populate the nullstr earlier. Add one
1077 to the cts_len for the null string, since it is no longer done
1078 in ctf_str_count_strtab. Adjust for csa_external_offset rename.
1079 Populate the csa_offset for both internal and external cases.
1080 Flush the ctf_prov_strtab afterwards, and reset the
1081 ctf_str_prov_offset.
1082 * ctf-create.c (ctf_grow_ptrtab): New.
1083 (ctf_create): Call it. Initialize new fields rather than old
1084 ones. Tell ctf_bufopen_internal that this is a writable dictionary.
1085 Set the ctl hashes and data model.
1086 (ctf_update): Rename to...
1087 (ctf_serialize): ... this. Leave a compatibility function behind.
1088 Tell ctf_simple_open_internal that this is a writable dictionary.
1089 Pass the new fields along from the old dictionary. Drop
1090 ctf_dtnextid and ctf_dtbyname. Use ctf_strraw, not dtd_name.
1091 Do not zero out the DTD's ctt_name.
1092 (ctf_prefixed_name): Rename to...
1093 (ctf_name_table): ... this. No longer return a prefixed name: return
1094 the applicable name table instead.
1095 (ctf_dtd_insert): Use it, and use the right name table. Pass in the
1096 kind we're adding. Migrate away from dtd_name.
1097 (ctf_dtd_delete): Adjust similarly. Remove the ref to the
1099 (ctf_dtd_lookup_type_by_name): Remove.
1100 (ctf_dynamic_type): Always return NULL on read-only dictionaries.
1101 No longer check ctf_dtnextid: check ctf_typemax instead.
1102 (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
1103 (ctf_rollback): Likewise. No longer fail with ECTF_OVERROLLBACK. Use
1104 ctf_name_table and the right name table, and migrate away from
1105 dtd_name as in ctf_dtd_delete.
1106 (ctf_add_generic): Pass in the kind explicitly and pass it to
1107 ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid. Migrate away
1108 from dtd_name to using ctf_str_add_ref to populate the ctt_name.
1109 Grow the ptrtab if needed.
1110 (ctf_add_encoded): Pass in the kind.
1111 (ctf_add_slice): Likewise.
1112 (ctf_add_array): Likewise.
1113 (ctf_add_function): Likewise.
1114 (ctf_add_typedef): Likewise.
1115 (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
1116 ctt_name rather than dtd_name.
1117 (ctf_add_struct_sized): Pass in the kind. Use
1118 ctf_lookup_by_rawname, not ctf_hash_lookup_type /
1119 ctf_dtd_lookup_type_by_name.
1120 (ctf_add_union_sized): Likewise.
1121 (ctf_add_enum): Likewise.
1122 (ctf_add_enum_encoded): Likewise.
1123 (ctf_add_forward): Likewise.
1124 (ctf_add_type): Likewise.
1125 (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
1126 being initialized until after the call.
1127 (ctf_write_mem): Likewise.
1128 (ctf_write): Likewise.
1129 * ctf-archive.c (arc_write_one_ctf): Likewise.
1130 * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
1131 ctf_hash_lookup_type.
1132 (ctf_lookup_by_id): No longer check the readonly types if the
1133 dictionary is writable.
1134 * ctf-open.c (init_types): Assert that this dictionary is not
1135 writable. Adjust to use the new name hashes, ctf_name_table,
1136 and ctf_ptrtab_len. GNU style fix for the final ptrtab scan.
1137 (ctf_bufopen_internal): New 'writable' parameter. Flip on LCTF_RDWR
1138 if set. Drop out early when dictionary is writable. Split the
1139 ctf_lookups initialization into...
1140 (ctf_set_cth_hashes): ... this new function.
1141 (ctf_simple_open_internal): Adjust. New 'writable' parameter.
1142 (ctf_simple_open): Adjust accordingly.
1143 (ctf_bufopen): Likewise.
1144 (ctf_file_close): Destroy the appropriate name hashes. No longer
1145 destroy ctf_dtbyname, which is gone.
1146 (ctf_getdatasect): Remove spurious "extern".
1147 * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
1148 specified name table, given a kind.
1149 (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
1150 (ctf_member_iter): Add support for iterating over the
1152 (ctf_enum_iter): Likewise.
1153 (ctf_variable_iter): Likewise.
1154 (ctf_type_rvisit): Likewise.
1155 (ctf_member_info): Add support for types in the dynamic type list.
1156 (ctf_enum_name): Likewise.
1157 (ctf_enum_value): Likewise.
1158 (ctf_func_type_info): Likewise.
1159 (ctf_func_type_args): Likewise.
1160 * ctf-link.c (ctf_accumulate_archive_names): No longer call
1162 (ctf_link_write): Likewise.
1163 (ctf_link_intern_extern_string): Adjust for new
1164 ctf_str_add_external return value.
1165 (ctf_link_add_strtab): Likewise.
1166 * ctf-util.c (ctf_list_empty_p): New.
1168 2019-08-05 Nick Alcock <nick.alcock@oracle.com>
1170 * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
1172 * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
1174 (ctf_add_variable): Likewise for variables pointing to them.
1175 * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
1176 type link failure, but do warn for others.
1177 * ctf-dump.c (ctf_dump_format_type): Likewise. Do not assume all
1178 errors to be ENOMEM.
1179 (ctf_dump_member): Likewise.
1180 (ctf_dump_type): Likewise.
1181 (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
1182 (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
1183 (ctf_dump_header): Likewise.
1184 (ctf_dump_label): likewise.
1185 (ctf_dump_objts): likewise.
1186 (ctf_dump_funcs): likewise.
1187 (ctf_dump_var): likewise.
1188 (ctf_dump_str): Likewise.
1190 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
1192 * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
1193 (LT_INIT): Likewise.
1194 (AM_INSTALL_LIBBFD): Likewise.
1195 (dlopen): Note why this is necessary in a comment.
1196 (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
1198 (SHARED_LDFLAGS): Likewise.
1199 (BFD_LIBADD): Likewise, for libbfd.
1200 (BFD_DEPENDENCIES): Likewise.
1201 (VERSION_FLAGS): Initialize, using a version script if ld supports
1202 one, or libtool -export-symbols-regex otherwise.
1203 (AC_CONFIG_MACRO_DIR): Add ../BFD.
1204 * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
1206 (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
1207 (noinst_LIBRARIES): Replace with...
1208 [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
1209 [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
1210 libctf-nobfd.la as well.
1211 [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
1212 [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
1213 (libctf_a_SOURCES): Rename to...
1214 (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
1216 (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
1217 with ctf-open-bfd.c added.
1218 (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
1219 (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
1220 (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
1221 * Makefile.am [INSTALL_LIBCTF]: Use it.
1222 * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
1224 * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
1225 the unstable components).
1226 * Makefile.in: Regenerated.
1227 * config.h.in: Likewise.
1228 * configure: Likewise.
1230 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
1232 * configure.ac (INSTALL_LIBCTF): New, controlled by
1233 --enable-install-libctf.
1234 [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
1235 * Makefile.in: Regenerated.
1236 * configure: Regenerated.
1238 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
1240 * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
1241 * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
1243 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
1245 * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
1247 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1249 * ctf-impl.h (includes): Include <sys/param.h> here.
1251 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
1253 * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
1254 (flip_objts): Likewise.
1255 (flip_vars): Likewise.
1256 (flip_types): Likewise.
1258 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
1260 * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
1261 freeing functions: if set, free the key and value if the slot
1262 already exists. Always reassign the key.
1263 (ctf_dynhash_insert): Adjust call appropriately.
1264 (ctf_hash_insert_type): Likewise.
1266 2019-08-03 Nick Alcock <nick.alcock@oracle.com>
1268 * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
1269 type kind. Allow forwards to unify with pre-existing structs/
1272 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
1274 * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
1275 <ctf_link_memb_name_changer>: Likewise.
1276 <ctf_link_memb_name_changer_arg>: Likewise.
1277 * ctf-create.c (ctf_update): Update accordingly.
1278 * ctf-open.c (ctf_file_close): Likewise.
1279 * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
1280 (ctf_link_add_cu_mapping): New.
1281 (ctf_link_set_memb_name_changer): Likewise.
1282 (ctf_change_parent_name): New.
1283 (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
1284 allocated by the caller's ctf_link_memb_name_changer.
1285 <ndynames>: Likewise.
1286 (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
1287 (ctf_link_write): Likewise (for _CTF_SECTION only): also call
1288 ctf_change_parent_name. Free any resulting names.
1290 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1292 * ctf-link.c (ctf_create_per_cu): New, refactored out of...
1293 (ctf_link_one_type): ... here, with parent-name setting added.
1294 (check_variable): New.
1295 (ctf_link_one_variable): Likewise.
1296 (ctf_link_one_input_archive_member): Call it.
1297 * ctf-error.c (_ctf_errlist): Updated with new errors.
1299 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1301 * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
1302 (struct ctf_link_type_mapping_key): New.
1303 (ctf_hash_type_mapping_key): Likewise.
1304 (ctf_hash_eq_type_mapping_key): Likewise.
1305 (ctf_add_type_mapping): Likewise.
1306 (ctf_type_mapping): Likewise.
1307 (ctf_dynhash_empty): Likewise.
1308 * ctf-open.c (ctf_file_close): Update accordingly.
1309 * ctf-create.c (ctf_update): Likewise.
1310 (ctf_add_type): Populate the mapping.
1311 * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
1312 (ctf_hash_eq_type_mapping_key): Check the key for equality.
1313 (ctf_dynhash_insert): Fix comment typo.
1314 (ctf_dynhash_empty): New.
1315 * ctf-link.c (ctf_add_type_mapping): New.
1316 (ctf_type_mapping): Likewise.
1317 (empty_link_type_mapping): New.
1318 (ctf_link_one_input_archive): Call it.
1320 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1322 * ctf-link.c: New file, linking of the string and type sections.
1323 * Makefile.am (libctf_a_SOURCES): Add it.
1324 * Makefile.in: Regenerate.
1326 * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
1328 * ctf-create.c (ctf_update): Update accordingly.
1329 * ctf-open.c (ctf_file_close): Likewise.
1330 * ctf-error.c (_ctf_errlist): Updated with new errors.
1332 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1334 * ctf-dump.c (ctf_dump_funcs): Check the right error value.
1336 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1338 * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
1340 (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
1341 (ctf_dump_format_type): Add non-root-type { } notation.
1342 Add root flag to prototype.
1343 (ctf_dump_label): Adjust accordingly.
1344 (ctf_dump_objts): Likewise.
1345 (ctf_dump_var): Likewise.
1347 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1349 * ctf-create.c (ctf_compress_write): Fix double-free.
1351 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1353 * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
1355 (ctf_arc_write_fd): ... this new function.
1356 * ctf-create.c (ctf_write_mem): New.
1358 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1360 * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
1361 (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
1362 (ctf_str_add_ref): Name the last arg.
1363 (ctf_str_add_external) New.
1364 (ctf_str_add_strraw_explicit): Likewise.
1365 (ctf_simple_open_internal): Likewise.
1366 (ctf_bufopen_internal): Likewise.
1368 * ctf-string.c (ctf_strraw_explicit): Split from...
1369 (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
1370 (ctf_str_add_ref_internal): Return the atom, not the
1372 (ctf_str_add): Adjust accordingly.
1373 (ctf_str_add_ref): Likewise. Move up in the file.
1374 (ctf_str_add_external): New: update the csa_offset.
1375 (ctf_str_count_strtab): Only account for strings with no csa_offset
1376 in the internal strtab length.
1377 (ctf_str_write_strtab): If the csa_offset is set, update the
1378 string's refs without writing the string out, and update the
1379 ctf_syn_ext_strtab. Make OOM handling less ugly.
1380 * ctf-create.c (struct ctf_sort_var_arg_cb): New.
1381 (ctf_update): Handle failure to populate the strtab. Pass in the
1382 new ctf_sort_var arg. Adjust for ctf_syn_ext_strtab addition.
1383 Call ctf_simple_open_internal, not ctf_simple_open.
1384 (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
1386 * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
1387 ctf_strraw). Adjust to diagnose ECTF_STRTAB nonetheless.
1388 * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
1389 (ctf_file_close): Destroy the ctf_syn_ext_strtab.
1390 (ctf_simple_open): Rename to, and reimplement as a wrapper around...
1391 (ctf_simple_open_internal): ... this new function, which calls
1392 ctf_bufopen_internal.
1393 (ctf_bufopen): Rename to, and reimplement as a wrapper around...
1394 (ctf_bufopen_internal): ... this new function, which sets
1397 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1399 * ctf_types.c (ctf_type_iter_all): New.
1401 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1403 * ctf-open.c (init_symtab): Check for overflow against the right
1405 (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
1406 (upgrade_types_v1): Note that these sections are not checked.
1407 (flip_header): Endian-swap the header fields.
1408 (flip_ctf): Endian-swap the sections.
1409 (flip_objts): Update comment.
1410 (ctf_bufopen): Check header offsets and alignment for validity.
1412 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1414 * ctf-open-bfd.c: Add <assert.h>.
1415 (ctf_bfdopen_ctfsect): Open string and symbol tables using
1416 techniques borrowed from bfd_elf_sym_name.
1417 (ctf_new_archive_internal): Improve comment.
1418 * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
1419 * ctf-open.c (ctf_bufopen): Allow opening with a string section but
1420 no symbol section, but not vice versa.
1422 2019-07-08 Nick Alcock <nick.alcock@oracle.com>
1424 * ctf-impl.h (ctf_file_t): New field ctf_openflags.
1425 * ctf-open.c (ctf_bufopen): Set it. No longer dump header offsets.
1426 * ctf-dump.c (dump_header): New function, dump the CTF header.
1427 (ctf_dump): Call it.
1428 (ctf_dump_header_strfield): New function.
1429 (ctf_dump_header_sectfield): Likewise.
1431 2019-07-06 Nick Alcock <nick.alcock@oracle.com>
1433 * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
1434 ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
1435 * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
1436 ctf_base: do not assume that it is always sizeof (ctf_header_t).
1437 Print out ctf_cuname: only print out ctf_parname if set.
1438 (ctf_free_base): Removed, ctf_base is no longer freed: free
1439 ctf_dynbase instead.
1440 (ctf_set_version): Fix spacing.
1441 (upgrade_header): New, in-place header upgrading.
1442 (upgrade_types): Rename to...
1443 (upgrade_types_v1): ... this. Free ctf_dynbase, not ctf_base. No
1444 longer track old and new headers separately. No longer allow for
1445 header sizes explicitly: squeeze the headers out on upgrade (they
1446 are preserved in fp->ctf_header). Set ctf_dynbase, ctf_base and
1447 ctf_buf explicitly. Use ctf_free, not ctf_free_base.
1448 (upgrade_types): New, also handle ctf_parmax updating.
1449 (flip_header): Flip ctf_cuname.
1450 (flip_types): Flip BUF explicitly rather than deriving BUF from
1452 (ctf_bufopen): Store the header in fp->ctf_header. Correct minimum
1453 required alignment of objtoff and funcoff. No longer store it in
1454 the ctf_buf unless that buf is derived unmodified from the input.
1455 Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
1456 that duplicate fields in ctf_file: move allocation of ctf_file
1457 further up instead. Call upgrade_header as needed. Move
1458 version-specific ctf_parmax initialization into upgrade_types. More
1459 concise error handling.
1460 (ctf_file_close): No longer test for null pointers before freeing.
1461 Free ctf_dyncuname, ctf_dynbase, and ctf_header. Do not call
1464 (ctf_cuname_set): New.
1465 * ctf-create.c (ctf_update): Populate ctf_cuname.
1466 (ctf_gzwrite): Write out the header explicitly. Remove obsolescent
1468 (ctf_write): Likewise.
1469 (ctf_compress_write): Get the header from ctf_header, not ctf_base.
1470 Fix the compression length: fp->ctf_size never counted the CTF
1471 header. Simplify the compress call accordingly.
1473 2019-07-11 Hans-Peter Nilsson <hp@bitrange.com>
1475 * ctf-endian.h: Don't assume htole64 and le64toh are always
1476 present if HAVE_ENDIAN_H; also check if htole64 is defined.
1477 [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
1478 not bswap_identity_64.
1480 2019-09-18 Alan Modra <amodra@gmail.com>
1482 * ctf-open-bfd.c: Update throughout for bfd section macro changes.
1484 2019-09-09 Phil Blundell <pb@pbcl.net>
1486 binutils 2.33 branch created.
1488 2019-07-18 Nick Alcock <nick.alcock@oracle.com>
1490 * ctf-types.c (ctf_type_aname_raw): New.
1491 (ctf_func_type_info): Likewise.
1492 (ctf_func_type_args): Likewise.
1493 * ctf-error.c (_ctf_errlist): Fix description.
1494 * ctf-lookup.c: Fix file description.
1496 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1498 * ctf-create.c (ctf_create): Fix off-by-one error.
1500 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1502 * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
1504 (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
1505 (struct ctf_str_atom): New, disambiguated single string.
1506 (struct ctf_str_atom_ref): New, points to some other location that
1507 references this string's offset.
1508 (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
1509 Remove member ctf_dtvstrlen: we no longer track the total strlen
1511 (ctf_str_create_atoms): Declare new function in ctf-string.c.
1512 (ctf_str_free_atoms): Likewise.
1513 (ctf_str_add): Likewise.
1514 (ctf_str_add_ref): Likewise.
1515 (ctf_str_rollback): Likewise.
1516 (ctf_str_purge_refs): Likewise.
1517 (ctf_str_write_strtab): Likewise.
1518 (ctf_realloc): Declare new function in ctf-util.c.
1520 * ctf-open.c (ctf_bufopen): Create the atoms table.
1521 (ctf_file_close): Destroy it.
1522 * ctf-create.c (ctf_update): Copy-and-free it on update. No longer
1523 special-case the position of the parname string. Construct the
1524 strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
1525 rest of each buffer element is constructed, not via open-coding:
1526 realloc the CTF buffer and append the strtab to it. No longer
1527 maintain ctf_dtvstrlen. Sort the variable entry table later, after
1528 strtab construction.
1529 (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
1530 (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
1531 after buffer element construction instead.
1532 (ctf_copy_lmembers): Likewise.
1533 (ctf_copy_emembers): Likewise.
1534 (ctf_create): No longer maintain the ctf_dtvstrlen.
1535 (ctf_dtd_delete): Likewise.
1536 (ctf_dvd_delete): Likewise.
1537 (ctf_add_generic): Likewise.
1538 (ctf_add_enumerator): Likewise.
1539 (ctf_add_member_offset): Likewise.
1540 (ctf_add_variable): Likewise.
1541 (membadd): Likewise.
1542 * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
1543 if there are active ctf_str_num_refs.
1544 (ctf_strraw): Move to ctf-string.c.
1545 (ctf_strptr): Likewise.
1546 * ctf-string.c: New file, strtab manipulation.
1548 * Makefile.am (libctf_a_SOURCES): Add it.
1549 * Makefile.in: Regenerate.
1551 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1553 * ctf-impl.h (ctf_hash_iter_f): New.
1554 (ctf_dynhash_iter): New declaration.
1555 (ctf_dynhash_iter_remove): New declaration.
1556 * ctf-hash.c (ctf_dynhash_iter): Define.
1557 (ctf_dynhash_iter_remove): Likewise.
1558 (ctf_hashtab_traverse): New.
1559 (ctf_hashtab_traverse_remove): Likewise.
1560 (struct ctf_traverse_cb_arg): Likewise.
1561 (struct ctf_traverse_remove_cb_arg): Likewise.
1563 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1565 * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
1567 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1569 * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
1570 (ctf_dump_funcs): Likewise.
1572 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1574 * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
1575 (ctf_fdopen): Check for endian-swapped raw CTF magic, and
1576 little-endian CTF archive magic. Do not check the CTF version:
1577 ctf_simple_open does that in endian-safe ways. Do not dereference
1578 null pointers on open failure.
1580 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1582 * ctf-open.c (get_vbytes_common): Return the new slice size.
1583 (ctf_bufopen): Flip the endianness of the CTF-section header copy.
1584 Remember to copy in the CTF data when opening an uncompressed
1585 foreign-endian CTF file. Prune useless variable manipulation.
1587 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1589 * ctf-open.c (ctf_types): Fail when unidentified type kinds are
1592 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1594 * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
1597 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1599 * ctf-subr.c (_PAGESIZE): Remove.
1600 (ctf_data_alloc): Likewise.
1601 (ctf_data_free): Likewise.
1602 (ctf_data_protect): Likewise.
1603 * ctf-impl.h: Remove declarations.
1604 * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
1605 ctf_free, not ctf_data_free.
1606 (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc. Free
1607 the buffer again on compression error.
1608 * ctf-open.c (ctf_set_base): No longer track the size: call
1609 ctf_free, not ctf_data_free.
1610 (upgrade_types): Likewise. Call ctf_alloc, not ctf_data_alloc.
1611 (ctf_bufopen): Likewise. No longer call ctf_data_protect.
1613 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1615 * ctf-create.c (ctf_dtd_insert): Pass on error returns from
1617 (ctf_dvd_insert): Likewise.
1618 (ctf_add_generic): Likewise.
1619 (ctf_add_variable): Likewise.
1620 * ctf-impl.h: Adjust declarations.
1622 2019-06-14 Alan Modra <amodra@gmail.com>
1624 * configure: Regenerate.
1626 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1628 * ctf-decls.h: Include <libiberty.h>.
1629 * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
1631 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1633 * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
1634 (ctf_dump_objts): Likewise.
1635 (ctf_dump_funcs): Likewise.
1636 (ctf_dump_member): Likewise.
1637 (ctf_dump_str): Likewise.
1639 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1641 * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
1642 * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
1644 2019-06-05 Nick Alcock <nick.alcock@oracle.com>
1646 * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
1647 (ctf_arc_open_by_offset): Likewise.
1648 * ctf-create.c (ctf_add_type): Likewise.
1650 2019-06-04 Tom Tromey <tromey@adacore.com>
1652 * ctf-create.c (ctf_add_encoded, ctf_add_slice)
1653 (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
1655 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
1657 * configure.ac: Check for O_CLOEXEC.
1658 * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
1659 * config.h.in: Regenerate.
1660 * configure: Likewise.
1662 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
1664 * qsort_r.c: Rename to...
1665 * ctf-qsort_r.c: ... this.
1666 (_quicksort): Define to ctf_qsort_r.
1667 * ctf-decls.h (qsort_r): Remove.
1669 (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
1670 (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
1671 * Makefile.am (libctf_a_LIBADD): Remove.
1672 (libctf_a_SOURCES): New, add ctf-qsort_r.c.
1673 * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
1674 * ctf-create.c (ctf_update): Likewise.
1675 * configure.ac: Check for BSD versus GNU qsort_r signature.
1676 * Makefile.in: Regenerate.
1677 * config.h.in: Likewise.
1678 * configure: Likewise.
1680 2019-06-03 Nick Alcock <nick.alcock@oracle.com>
1682 * ctf-dump.c (ctf_dump_funcs): Free in the right place.
1684 2019-05-29 Nick Alcock <nick.alcock@oracle.com>
1686 * Makefile.am (ZLIB): New.
1687 (ZLIBINC): Likewise.
1688 (AM_CFLAGS): Use them.
1689 (libctf_a_LIBADD): New, for LIBOBJS.
1690 * configure.ac: Check for zlib, endian.h, and qsort_r.
1691 * ctf-endian.h: New, providing htole64 and le64toh.
1692 * swap.h: Code style fixes.
1693 (bswap_identity_64): New.
1694 * qsort_r.c: New, from gnulib (with one added #include).
1695 * ctf-decls.h: New, providing a conditional qsort_r declaration,
1696 and unconditional definitions of MIN and MAX.
1697 * ctf-impl.h: Use it. Do not use <sys/errno.h>.
1698 (ctf_set_errno): Now returns unsigned long.
1699 * ctf-util.c (ctf_set_errno): Adjust here too.
1700 * ctf-archive.c: Use ctf-endian.h.
1701 (ctf_arc_open_by_offset): Use memset, not bzero. Drop cts_type,
1702 cts_flags and cts_offset.
1703 (ctf_arc_write): Drop debugging dependent on the size of off_t.
1704 * ctf-create.c: Provide a definition of roundup if not defined.
1705 (ctf_create): Drop cts_type, cts_flags and cts_offset.
1706 (ctf_add_reftype): Do not check if type IDs are below zero.
1707 (ctf_add_slice): Likewise.
1708 (ctf_add_typedef): Likewise.
1709 (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
1710 when known error-free. Drop CTF_ERR usage for functions returning
1712 (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
1714 (ctf_add_variable): Likewise.
1715 (enumcmp): Likewise.
1716 (enumadd): Likewise.
1717 (membcmp): Likewise.
1718 (ctf_add_type): Likewise. Cast error-returning ssize_t's to size_t
1719 when known error-free.
1720 * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
1721 returning int: use CTF_ERR for functions returning ctf_type_id.
1722 (ctf_dump_label): Likewise.
1723 (ctf_dump_objts): Likewise.
1724 * ctf-labels.c (ctf_label_topmost): Likewise.
1725 (ctf_label_iter): Likewise.
1726 (ctf_label_info): Likewise.
1727 * ctf-lookup.c (ctf_func_args): Likewise.
1728 * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
1729 (ctf_bufopen): Likewise. Use zlib types as needed.
1730 * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
1732 (ctf_enum_iter): Likewise.
1733 (ctf_type_size): Likewise.
1734 (ctf_type_align): Likewise. Cast to size_t where appropriate.
1735 (ctf_type_kind_unsliced): Likewise.
1736 (ctf_type_kind): Likewise.
1737 (ctf_type_encoding): Likewise.
1738 (ctf_member_info): Likewise.
1739 (ctf_array_info): Likewise.
1740 (ctf_enum_value): Likewise.
1741 (ctf_type_rvisit): Likewise.
1742 * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
1744 (ctf_simple_open): Likewise.
1745 (ctf_bfdopen_ctfsect): Likewise. Set cts_size properly.
1746 * Makefile.in: Regenerate.
1747 * aclocal.m4: Likewise.
1748 * config.h: Likewise.
1749 * configure: Likewise.
1751 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1753 * configure.in: Check for bfd_section_from_elf_index.
1754 * configure: Regenerate.
1755 * config.h.in [HAVE_BFD_ELF]: Likewise.
1756 * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
1757 abfd is potentially unused now.
1759 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1762 * Makefile.in: Regenerated.
1763 * config.h.in: Likewise.
1764 * aclocal.m4: Likewise.
1765 * configure: Likewise.
1767 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1771 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1773 * ctf-labels.c: New.
1775 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1777 * ctf-impl.h (_libctf_version): New declaration.
1778 * ctf-subr.c (_libctf_version): Define it.
1781 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1783 * ctf-create.c (enumcmp): New.
1784 (enumadd): Likewise.
1785 (membcmp): Likewise.
1786 (membadd): Likewise.
1787 (ctf_add_type): Likewise.
1789 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1791 * ctf-lookup.c (isqualifier): New.
1792 (ctf_lookup_by_name): Likewise.
1793 (struct ctf_lookup_var_key): Likewise.
1794 (ctf_lookup_var): Likewise.
1795 (ctf_lookup_variable): Likewise.
1796 (ctf_lookup_symbol_name): Likewise.
1797 (ctf_lookup_by_symbol): Likewise.
1798 (ctf_func_info): Likewise.
1799 (ctf_func_args): Likewise.
1801 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1803 * ctf-decl.c: New file.
1804 * ctf-types.c: Likewise.
1805 * ctf-impl.h: New declarations.
1807 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1809 * ctf-open-bfd.c: New file.
1810 * ctf-open.c (ctf_close): New.
1811 * ctf-impl.h: Include bfd.h.
1812 (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
1813 (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
1815 (ctf_bfdopen_ctfsect): New declaration.
1816 (_CTF_SECTION): likewise.
1818 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1820 * ctf-archive.c: New.
1821 * ctf-impl.h (ctf_archive_internal): New type.
1822 (ctf_arc_open_internal): New declaration.
1823 (ctf_arc_bufopen): Likewise.
1824 (ctf_arc_close_internal): Likewise.
1826 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1828 * ctf-open.c: New file.
1831 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1833 * ctf-create.c: New file.
1834 * ctf-lookup.c: New file.
1836 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1838 * ctf-impl.h: New definitions and declarations for type creation
1841 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1843 * ctf-hash.c: New file.
1844 * ctf-impl.h: New declarations.
1846 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1848 * ctf-error.c: New file.
1850 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1852 * ctf-util.c: New file.
1854 * ctf-impl.h: Include it, and add declarations.
1856 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1858 * ctf-impl.h: New file.
1859 * ctf-subr.c: New file.
1866 version-control: never