libctf/ChangeLog

   1 2020-11-20  Nick Alcock  <nick.alcock@oracle.com>
   2
   3         * ctf-dump.c (ctf_dump_header): Dump the new flags bits and the index
   4         section lengths.
   5         (ctf_dump_objts): Report indexed sections.  Also dump functions.  Use
   6         ctf_symbol_next, not manual looping.
   7         (ctf_dump_funcs): Delete.
   8         (ctf_dump): Use ctf_dump_objts, not ctf_dump_funcs.
   9
  10 2020-11-20  Nick Alcock  <nick.alcock@oracle.com>
  11
  12         * ctf-impl.h (CTF_INDEX_PAD_THRESHOLD): New.
  13         (_libctf_nonnull_): Likewise.
  14         (ctf_in_flight_dynsym_t): New.
  15         (ctf_dict_t) <ctf_funcidx_names>: Likewise.
  16         <ctf_objtidx_names>: Likewise.
  17         <ctf_nfuncidx>: Likewise.
  18         <ctf_nobjtidx>: Likewise.
  19         <ctf_funcidx_sxlate>: Likewise.
  20         <ctf_objtidx_sxlate>: Likewise.
  21         <ctf_objthash>: Likewise.
  22         <ctf_funchash>: Likewise.
  23         <ctf_dynsyms>: Likewise.
  24         <ctf_dynsymidx>: Likewise.
  25         <ctf_dynsymmax>: Likewise.
  26         <ctf_in_flight_dynsym>: Likewise.
  27         (struct ctf_next) <u.ctn_next>: Likewise.
  28         (ctf_symtab_skippable): New prototype.
  29         (ctf_add_funcobjt_sym): Likewise.
  30         (ctf_dynhash_sort_by_name): Likewise.
  31         (ctf_sym_to_elf64): Rename to...
  32         (ctf_elf32_to_link_sym): ... this, and...
  33         (ctf_elf64_to_link_sym): ... this.
  34         * ctf-open.c (init_symtab): Check for lack of CTF_F_NEWFUNCINFO
  35         flag, and presence of index sections.  Refactor out
  36         ctf_symtab_skippable and ctf_elf*_to_link_sym, and use them.  Use
  37         ctf_link_sym_t, not Elf64_Sym.  Skip initializing objt or func
  38         sxlate sections if corresponding index section is present.  Adjust
  39         for new func info section format.
  40         (ctf_bufopen_internal): Add ctf_err_warn to corrupt-file error
  41         handling.  Report incorrect-length index sections.  Always do an
  42         init_symtab, even if there is no symtab section (there may be index
  43         sections still).
  44         (flip_objts): Adjust comment: func and objt sections are actually
  45         identical in structure now, no need to caveat.
  46         (ctf_dict_close):  Free newly-added data structures.
  47         * ctf-create.c (ctf_create): Initialize them.
  48         (ctf_symtab_skippable): New, refactored out of
  49         init_symtab, with st_nameidx_set check added.
  50         (ctf_add_funcobjt_sym): New, add a function or object symbol to the
  51         ctf_objthash or ctf_funchash, by name.
  52         (ctf_add_objt_sym): Call it.
  53         (ctf_add_func_sym): Likewise.
  54         (symtypetab_delete_nonstatic_vars): New, delete vars also present as
  55         data objects.
  56         (CTF_SYMTYPETAB_EMIT_FUNCTION): New flag to symtypetab emitters:
  57         this is a function emission, not a data object emission.
  58         (CTF_SYMTYPETAB_EMIT_PAD): New flag to symtypetab emitters: emit
  59         pads for symbols with no type (only set for unindexed sections).
  60         (CTF_SYMTYPETAB_FORCE_INDEXED): New flag to symtypetab emitters:
  61         always emit indexed.
  62         (symtypetab_density): New, figure out section sizes.
  63         (emit_symtypetab): New, emit a symtypetab.
  64         (emit_symtypetab_index): New, emit a symtypetab index.
  65         (ctf_serialize): Call them, emitting suitably sorted symtypetab
  66         sections and indexes.  Set suitable header flags.  Copy over new
  67         fields.
  68         * ctf-hash.c (ctf_dynhash_sort_by_name): New, used to impose an
  69         order on symtypetab index sections.
  70         * ctf-link.c (ctf_add_type_mapping): Delete erroneous comment
  71         relating to code that was never committed.
  72         (ctf_link_one_variable): Improve variable name.
  73         (check_sym): New, symtypetab analogue of check_variable.
  74         (ctf_link_deduplicating_one_symtypetab): New.
  75         (ctf_link_deduplicating_syms): Likewise.
  76         (ctf_link_deduplicating): Call them.
  77         (ctf_link_deduplicating_per_cu): Note that we don't call them in
  78         this case (yet).
  79         (ctf_link_add_strtab): Set the error on the fp correctly.
  80         (ctf_link_add_linker_symbol): New (no longer a do-nothing stub), add
  81         a linker symbol to the in-flight list.
  82         (ctf_link_shuffle_syms): New (no longer a do-nothing stub), turn the
  83         in-flight list into a mapping we can use, now its names are
  84         resolvable in the external strtab.
  85         * ctf-string.c (ctf_str_rollback_atom): Don't roll back atoms with
  86         external strtab offsets.
  87         (ctf_str_rollback): Adjust comment.
  88         (ctf_str_write_strtab): Migrate ctf_syn_ext_strtab population from
  89         writeout time...
  90         (ctf_str_add_external): ... to string addition time.
  91         * ctf-lookup.c (ctf_lookup_var_key_t): Rename to...
  92         (ctf_lookup_idx_key_t): ... this, now we use it for syms too.
  93         <clik_names>: New member, a name table.
  94         (ctf_lookup_var): Adjust accordingly.
  95         (ctf_lookup_variable): Likewise.
  96         (ctf_lookup_by_id): Shuffle further up in the file.
  97         (ctf_symidx_sort_arg_cb): New, callback for...
  98         (sort_symidx_by_name): ... this new function to sort a symidx
  99         found to be unsorted (likely originating from the compiler).
 100         (ctf_symidx_sort): New, sort a symidx.
 101         (ctf_lookup_symbol_name): Support dynamic symbols with indexes
 102         provided by the linker.  Use ctf_link_sym_t, not Elf64_Sym.
 103         Check the parent if a child lookup fails.
 104         (ctf_lookup_by_symbol): Likewise.  Work for function symbols too.
 105         (ctf_symbol_next): New, iterate over symbols with types (without
 106         sorting).
 107         (ctf_lookup_idx_name): New, bsearch for symbol names in indexes.
 108         (ctf_try_lookup_indexed): New, attempt an indexed lookup.
 109         (ctf_func_info): Reimplement in terms of ctf_lookup_by_symbol.
 110         (ctf_func_args): Likewise.
 111         (ctf_get_dict): Move...
 112         * ctf-types.c (ctf_get_dict): ... here.
 113         * ctf-util.c (ctf_sym_to_elf64): Re-express as...
 114         (ctf_elf64_to_link_sym): ... this.  Add new st_symidx field, and
 115         st_nameidx_set (always 0, so st_nameidx can be ignored).  Look in
 116         the ELF strtab for names.
 117         (ctf_elf32_to_link_sym): Likewise, for Elf32_Sym.
 118         (ctf_next_destroy): Destroy ctf_next_t.u.ctn_next if need be.
 119         * libctf.ver: Add ctf_symbol_next, ctf_add_objt_sym and
 120         ctf_add_func_sym.
 121
 122 2020-11-20  Nick Alcock  <nick.alcock@oracle.com>
 123
 124         * ctf-link.c (ctf_link_shuffle_syms): Adjust.
 125         (ctf_link_add_linker_symbol): New, unimplemented stub.
 126         * libctf.ver: Add it.
 127         * ctf-create.c (ctf_serialize): Set CTF_F_DYNSTR on newly-serialized
 128         dicts.
 129         * ctf-open-bfd.c (ctf_bfdopen_ctfsect): Check for the flag: open the
 130         symtab/strtab if not present, dynsym/dynstr otherwise.
 131         * ctf-archive.c (ctf_arc_bufpreamble): New, get the preamble from
 132         some arbitrary member of a CTF archive.
 133         * ctf-impl.h (ctf_arc_bufpreamble): Declare it.
 134
 135 2020-11-20  Nick Alcock  <nick.alcock@oracle.com>
 136
 137         * ctf-archive.c (ctf_arc_open_by_offset): Rename to...
 138         (ctf_dict_open_by_offset): ... this.  Adjust callers.
 139         (ctf_arc_open_by_name_internal): Rename to...
 140         (ctf_dict_open_internal): ... this.  Adjust callers.
 141         (ctf_arc_open_by_name_sections): Rename to...
 142         (ctf_dict_open_sections): ... this, keeping compatibility function.
 143         (ctf_arc_open_by_name): Rename to...
 144         (ctf_dict_open): ... this, keeping compatibility function.
 145         * libctf.ver: New functions added.
 146         * ctf-link.c (ctf_link_one_input_archive): Adjusted accordingly.
 147         (ctf_link_deduplicating_open_inputs): Likewise.
 148
 149 2020-11-20  Nick Alcock  <nick.alcock@oracle.com>
 150
 151         * ctf-impl.h: Rename ctf_file_t to ctf_dict_t: all declarations
 152         adjusted.
 153         (ctf_fileops): Rename to...
 154         (ctf_dictops): ... this.
 155         (ctf_dedup_t) <cd_id_to_file_t>: Rename to...
 156         <cd_id_to_dict_t>: ... this.
 157         (ctf_file_t): Fix outdated comment.
 158         <ctf_fileops>: Rename to...
 159         <ctf_dictops>: ... this.
 160         (struct ctf_archive_internal) <ctfi_file>: Rename to...
 161         <ctfi_dict>: ... this.
 162         * ctf-archive.c: Rename ctf_file_t to ctf_dict_t.
 163         Rename ctf_archive.ctfa_nfiles to ctfa_ndicts.
 164         Rename ctf_file_close to ctf_dict_close.  All users adjusted.
 165         * ctf-create.c: Likewise.  Refer to CTF dicts, not CTF containers.
 166         (ctf_bundle_t) <ctb_file>: Rename to...
 167         <ctb_dict): ... this.
 168         * ctf-decl.c: Rename ctf_file_t to ctf_dict_t.
 169         * ctf-dedup.c: Likewise.  Rename ctf_file_close to
 170         ctf_dict_close. Refer to CTF dicts, not CTF containers.
 171         * ctf-dump.c: Likewise.
 172         * ctf-error.c: Likewise.
 173         * ctf-hash.c: Likewise.
 174         * ctf-inlines.h: Likewise.
 175         * ctf-labels.c: Likewise.
 176         * ctf-link.c: Likewise.
 177         * ctf-lookup.c: Likewise.
 178         * ctf-open-bfd.c: Likewise.
 179         * ctf-string.c: Likewise.
 180         * ctf-subr.c: Likewise.
 181         * ctf-types.c: Likewise.
 182         * ctf-util.c: Likewise.
 183         * ctf-open.c: Likewise.
 184         (ctf_file_close): Rename to...
 185         (ctf_dict_close): ...this.
 186         (ctf_file_close): New trivial wrapper around ctf_dict_close, for
 187         compatibility.
 188         (ctf_parent_file): Rename to...
 189         (ctf_parent_dict): ... this.
 190         (ctf_parent_file): New trivial wrapper around ctf_parent_dict, for
 191         compatibility.
 192         * libctf.ver: Add ctf_dict_close and ctf_parent_dict.
 193
 194 2020-10-21  Tom Tromey  <tromey@adacore.com>
 195
 196         * mkerrors.sed: Remove.
 197         * ctf-error.c (_CTF_FIRST): New define.
 198         (_CTF_ITEM): Define this, not _CTF_STR.
 199         (_ctf_errlist, _ctf_erridx): Use _CTF_ERRORS.
 200         (ERRSTRFIELD): Rewrite.
 201         (ERRSTRFIELD1): Remove.
 202         * Makefile.in: Rebuild.
 203         * Makefile.am (BUILT_SOURCES): Remove.
 204         (ctf-error.h): Remove.
 205
 206 2020-08-27  Nick Alcock  <nick.alcock@oracle.com>
 207
 208         * ctf-subr.c (open_errors): New list.
 209         (ctf_err_warn): Calls with NULL fp append to open_errors.  Add err
 210         parameter, and use it to decorate the debug stream with errmsgs.
 211         (ctf_err_warn_to_open): Splice errors from a CTF dict into the
 212         open_errors.
 213         (ctf_errwarning_next): Calls with NULL fp report from open_errors.
 214         New err param to report iteration errors (including end-of-iteration)
 215         when fp is NULL.
 216         (ctf_assert_fail_internal): Adjust ctf_err_warn call for new err
 217         parameter: gettextize.
 218         * ctf-impl.h (ctfo_get_vbytes): Add ctf_file_t parameter.
 219         (LCTF_VBYTES): Adjust.
 220         (ctf_err_warn_to_open): New.
 221         (ctf_err_warn): Adjust.
 222         (ctf_bundle): Used in only one place: move...
 223         * ctf-create.c: ... here.
 224         (enumcmp): Use ctf_err_warn, not ctf_dprintf, passing the err number
 225         down as needed.  Don't emit the errmsg.  Gettextize.
 226         (membcmp): Likewise.
 227         (ctf_add_type_internal): Likewise.
 228         (ctf_write_mem): Likewise.
 229         (ctf_compress_write): Likewise.  Report errors writing the header or
 230         body.
 231         (ctf_write): Likewise.
 232         * ctf-archive.c (ctf_arc_write_fd): Use ctf_err_warn, not
 233         ctf_dprintf, and gettextize, as above.
 234         (ctf_arc_write): Likewise.
 235         (ctf_arc_bufopen): Likewise.
 236         (ctf_arc_open_internal): Likewise.
 237         * ctf-labels.c (ctf_label_iter): Likewise.
 238         * ctf-open-bfd.c (ctf_bfdclose): Likewise.
 239         (ctf_bfdopen): Likewise.
 240         (ctf_bfdopen_ctfsect): Likewise.
 241         (ctf_fdopen): Likewise.
 242         * ctf-string.c (ctf_str_write_strtab): Likewise.
 243         * ctf-types.c (ctf_type_resolve): Likewise.
 244         * ctf-open.c (get_vbytes_common): Likewise. Pass down the ctf dict.
 245         (get_vbytes_v1): Pass down the ctf dict.
 246         (get_vbytes_v2): Likewise.
 247         (flip_ctf): Likewise.
 248         (flip_types): Likewise. Use ctf_err_warn, not ctf_dprintf, and
 249         gettextize, as above.
 250         (upgrade_types_v1): Adjust calls.
 251         (init_types): Use ctf_err_warn, not ctf_dprintf, as above.
 252         (ctf_bufopen_internal): Likewise. Adjust calls. Transplant errors
 253         emitted into individual dicts into the open errors if this turns
 254         out to be a failed open in the end.
 255         * ctf-dump.c (ctf_dump_format_type): Adjust ctf_err_warn for new err
 256         argument.  Gettextize.  Don't emit the errmsg.
 257         (ctf_dump_funcs): Likewise.  Collapse err label into its only case.
 258         (ctf_dump_type): Likewise.
 259         * ctf-link.c (ctf_create_per_cu): Adjust ctf_err_warn for new err
 260         argument.  Gettextize.  Don't emit the errmsg.
 261         (ctf_link_one_type): Likewise.
 262         (ctf_link_lazy_open): Likewise.
 263         (ctf_link_one_input_archive): Likewise.
 264         (ctf_link_deduplicating_count_inputs): Likewise.
 265         (ctf_link_deduplicating_open_inputs): Likewise.
 266         (ctf_link_deduplicating_close_inputs): Likewise.
 267         (ctf_link_deduplicating): Likewise.
 268         (ctf_link): Likewise.
 269         (ctf_link_deduplicating_per_cu): Likewise. Add some missed
 270         ctf_set_errnos to obscure error cases.
 271         * ctf-dedup.c (ctf_dedup_rhash_type): Adjust ctf_err_warn for new
 272         err argument.  Gettextize.  Don't emit the errmsg.
 273         (ctf_dedup_populate_mappings): Likewise.
 274         (ctf_dedup_detect_name_ambiguity): Likewise.
 275         (ctf_dedup_init): Likewise.
 276         (ctf_dedup_multiple_input_dicts): Likewise.
 277         (ctf_dedup_conflictify_unshared): Likewise.
 278         (ctf_dedup): Likewise.
 279         (ctf_dedup_rwalk_one_output_mapping): Likewise.
 280         (ctf_dedup_id_to_target): Likewise.
 281         (ctf_dedup_emit_type): Likewise.
 282         (ctf_dedup_emit_struct_members): Likewise.
 283         (ctf_dedup_populate_type_mapping): Likewise.
 284         (ctf_dedup_populate_type_mappings): Likewise.
 285         (ctf_dedup_emit): Likewise.
 286         (ctf_dedup_hash_type): Likewise. Fix a bit of messed-up error
 287         status setting.
 288         (ctf_dedup_rwalk_one_output_mapping): Likewise. Don't hide
 289         unknown-type-kind messages (which signify file corruption).
 290
 291 2020-08-27  Nick Alcock  <nick.alcock@oracle.com>
 292
 293         * configure.ac: Adjust package name to simply 'libctf': arbitrarily
 294         declare this to be version 1.2.0.
 295         * Makefile.am (AM_CPPFLAGS): Add @INCINTL@.
 296         * Makefile.in: Regenerated.
 297         * configure: Regenerated.
 298         * ctf-intl.h: New file, lightly modified from opcodes/opintl.h.
 299         * ctf-impl.h: Include it.
 300         * ctf-error.r (_ctf_errlist_t): Mark strings as noop-translatable.
 301         (ctf_errmsg): Actually translate them.
 302
 303 2020-07-26  Eli Zaretskii  <eliz@gnu.org>
 304
 305         PR binutils/25155:
 306         * ctf-create.c (EOVERFLOW): If not defined by system header,
 307         redirect to ERANGE as a poor man's substitute.
 308         * ctf-subr.c (ENOTSUP): If not defined, use ENOSYS instead.
 309
 310 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 311
 312         * ctf-create.c (ctf_dtd_insert): Add uintptr_t casts.
 313         (ctf_dtd_delete): Likewise.
 314         (ctf_dtd_lookup): Likewise.
 315         (ctf_rollback): Likewise.
 316         * ctf-hash.c (ctf_hash_lookup_type): Likewise.
 317         * ctf-types.c (ctf_lookup_by_rawhash): Likewise.
 318
 319 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 320
 321         * ctf-lookup.c (ctf_lookup_by_name): Adjust.
 322
 323 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 324
 325         * ctf-archive.c (ctf_arc_bufopen): Endian-swap the archive magic
 326         number if needed.
 327
 328 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 329
 330         * ctf-impl.h (ctf_list_splice): New.
 331         * ctf-util.h (ctf_list_splice): Likewise.
 332         * ctf-link.c (link_sort_inputs_cb_arg_t): Likewise.
 333         (ctf_link_sort_inputs): Likewise.
 334         (ctf_link_deduplicating_count_inputs): Likewise.
 335         (ctf_link_deduplicating_open_inputs): Likewise.
 336         (ctf_link_deduplicating_close_inputs): Likewise.
 337         (ctf_link_deduplicating_variables): Likewise.
 338         (ctf_link_deduplicating_per_cu): Likewise.
 339         (ctf_link_deduplicating): Likewise.
 340         (ctf_link): Call it.
 341
 342 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 343
 344         * ctf-link.c (ctf_link_one_input_archive_member): Check
 345         CTF_LINK_OMIT_VARIABLES_SECTION.
 346
 347 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 348
 349         * ctf-impl.h (ctf_type_id_key): New, the key in the
 350         cd_id_to_file_t.
 351         (ctf_dedup): New, core deduplicator state.
 352         (ctf_file_t) <ctf_dedup>: New.
 353         <ctf_dedup_atoms>: New.
 354         <ctf_dedup_atoms_alloc>: New.
 355         (ctf_hash_type_id_key): New prototype.
 356         (ctf_hash_eq_type_id_key): Likewise.
 357         (ctf_dedup_atoms_init): Likewise.
 358         * ctf-hash.c (ctf_hash_eq_type_id_key): New.
 359         (ctf_dedup_atoms_init): Likewise.
 360         * ctf-create.c (ctf_serialize): Adjusted.
 361         (ctf_add_encoded): No longer static.
 362         (ctf_add_reftype): Likewise.
 363         * ctf-open.c (ctf_file_close): Destroy the
 364         ctf_dedup_atoms_alloc.
 365         * ctf-dedup.c: New file.
 366         * ctf-decls.h [!HAVE_DECL_STPCPY]: Add prototype.
 367         * configure.ac: Check for stpcpy.
 368         * Makefile.am: Add it.
 369         * Makefile.in: Regenerate.
 370         * config.h.in: Regenerate.
 371         * configure: Regenerate.
 372
 373 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 374
 375         * configure.ac: Add --enable-libctf-hash-debugging.
 376         * aclocal.m4: Pull in enable.m4, for GCC_ENABLE.
 377         * Makefile.in: Regenerated.
 378         * configure: Likewise.
 379         * config.h.in: Likewise.
 380         * ctf-impl.h [ENABLE_LIBCTF_HASH_DEBUGGING]
 381         (ctf_assert): Define to assert.
 382
 383 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 384
 385         * ctf-sha1.h: New, inline wrappers around sha1_init_ctx and
 386         sha1_process_bytes.
 387         * ctf-impl.h: Include it.
 388         (ctf_sha1_init): New.
 389         (ctf_sha1_add): Likewise.
 390         (ctf_sha1_fini): Likewise.
 391         * ctf-sha1.c: New, non-inline wrapper around sha1_finish_ctx
 392         producing strings.
 393         * Makefile.am: Add file.
 394         * Makefile.in: Regenerate.
 395
 396 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 397
 398         * libctf.ver (ctf_link_set_variable_filter): Add.
 399         * ctf-impl.h (ctf_file_t) <ctf_link_variable_filter>: New.
 400         <ctf_link_variable_filter_arg>: Likewise.
 401         * ctf-create.c (ctf_serialize): Adjust.
 402         * ctf-link.c (ctf_link_set_variable_filter): New, set it.
 403         (ctf_link_one_variable): Call it if set.
 404
 405 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 406
 407         * ctf-link.c (ctf_link_one_variable): Check the dst_type for
 408         conflicts, not the source type.
 409
 410 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 411
 412         * ctf-impl.h (ctf_file_t): Improve comments.
 413         <ctf_link_cu_mapping>: Split into...
 414         <ctf_link_in_cu_mapping>: ... this...
 415         <ctf_link_out_cu_mapping>: ... and this.
 416         * ctf-create.c (ctf_serialize): Adjust.
 417         * ctf-open.c (ctf_file_close): Likewise.
 418         * ctf-link.c (ctf_create_per_cu): Look things up in the
 419         in_cu_mapping instead of the cu_mapping.
 420         (ctf_link_add_cu_mapping): The deduplicating link will define
 421         what happens if many FROMs share a TO.
 422         (ctf_link_add_cu_mapping): Create in_cu_mapping and
 423         out_cu_mapping. Do not create ctf_link_outputs here any more, or
 424         create per-CU dicts here: they are already created when needed.
 425         (ctf_link_one_variable): Log a debug message if we skip a
 426         variable due to its type being concealed in a CU-mapped link.
 427         (This is probably too common a case to make into a warning.)
 428         (ctf_link): Create empty per-CU dicts if requested.
 429
 430 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 431
 432         * ctf-link.c (ctf_link_write): Close the fd.
 433
 434 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 435
 436         * Makefile.am: Set -DNOBFD=1 in libctf-nobfd, and =0 elsewhere.
 437         * Makefile.in: Regenerated.
 438         * ctf-impl.h (ctf_link_input_name): New.
 439         (ctf_file_t) <ctf_link_flags>: New.
 440         * ctf-create.c (ctf_serialize): Adjust accordingly.
 441         * ctf-link.c: Define ctf_open as weak when PIC.
 442         (ctf_arc_close_thunk): Remove unnecessary thunk.
 443         (ctf_file_close_thunk): Likewise.
 444         (ctf_link_input_name): New.
 445         (ctf_link_input_t): New value of the ctf_file_t.ctf_link_input.
 446         (ctf_link_input_close): Adjust accordingly.
 447         (ctf_link_add_ctf_internal): New, split from...
 448         (ctf_link_add_ctf): ... here.  Return error if lazy loading of
 449         CTF is not possible.  Change to just call...
 450         (ctf_link_add): ... this new function.
 451         (ctf_link_add_cu_mapping): Transition to ctf_err_warn.  Drop the
 452         ctf_file_close_thunk.
 453         (ctf_link_in_member_cb_arg_t) <file_name> Rename to...
 454         <in_file_name>: ... this.
 455         <arcname>: Drop.
 456         <share_mode>: Likewise (migrated to ctf_link_flags).
 457         <done_main_member>: Rename to...
 458         <done_parent>: ... this.
 459         <main_input_fp>: Rename to...
 460         <in_fp_parent>: ... this.
 461         <cu_mapped>: New.
 462         (ctf_link_one_type): Adjuwt accordingly.  Transition to
 463         ctf_err_warn, removing a TODO.
 464         (ctf_link_one_variable): Note a case too common to warn about.
 465         Report in the debug stream if a cu-mapped link prevents addition
 466         of a conflicting variable.
 467         (ctf_link_one_input_archive_member): Adjust.
 468         (ctf_link_lazy_open): New, open a CTF archive for linking when
 469         needed.
 470         (ctf_link_close_one_input_archive): New, close it again.
 471         (ctf_link_one_input_archive): Adjust for lazy opening, member
 472         renames, and ctf_err_warn transition.  Move the
 473         empty_link_type_mapping call to...
 474         (ctf_link): ... here.  Adjut for renamings and thunk removal.
 475         Don't spuriously fail if some input contains no CTF data.
 476         (ctf_link_write): ctf_err_warn transition.
 477         * libctf.ver: Remove not-yet-stable comment.
 478
 479 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 480
 481         * ctf-impl.h (ctf_strerror): Delete.
 482         * ctf-subr.c (ctf_strerror): Likewise.
 483         * ctf-error.c (ctf_errmsg): Stop using ctf_strerror: just use
 484         strerror directly.
 485
 486 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 487
 488         * ctf-impl.c (ctf_file_t) <ctf_parent_unreffed>: New.
 489         (ctf_import_unref): New.
 490         * ctf-open.c (ctf_file_close) Drop the refcount all the way to
 491         zero.  Don't recurse back in if the refcount is already zero.
 492         (ctf_import): Check ctf_parent_unreffed before deciding whether
 493         to close a pre-existing parent.  Set it to zero.
 494         (ctf_import_unreffed): New, as above, setting
 495         ctf_parent_unreffed to 1.
 496         * ctf-create.c (ctf_serialize): Do not ctf_import into the new
 497         child: use direct assignment, and set unreffed on the new and
 498         old children.
 499         * ctf-link.c (ctf_create_per_cu): Import the parent using
 500         ctf_import_unreffed.
 501
 502 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 503
 504         * ctf-impl.h (ctf_link_type_mapping_key): Rename to...
 505         (ctf_link_type_key): ... this, adjusting member prefixes to
 506         match.
 507         (ctf_hash_type_mapping_key): Rename to...
 508         (ctf_hash_type_key): ... this.
 509         (ctf_hash_eq_type_mapping_key): Rename to...
 510         (ctf_hash_eq_type_key): ... this.
 511         * ctf-hash.c (ctf_hash_type_mapping_key): Rename to...
 512         (ctf_hash_type_key): ... this, and adjust for member name
 513         changes.
 514         (ctf_hash_eq_type_mapping_key): Rename to...
 515         (ctf_hash_eq_type_key): ... this, and adjust for member name
 516         changes.
 517         * ctf-link.c (ctf_add_type_mapping): Adjust.  Note the lack of
 518         need for out-of-memory checking in this code.
 519         (ctf_type_mapping): Adjust.
 520
 521 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 522
 523         configure.ac: Check for vasprintf.
 524         configure: Regenerated.
 525         config.h.in: Likewise.
 526
 527 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 528
 529         * ctf-archive.c (ctf_arc_bufopen): Fix message.
 530
 531 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 532
 533         * ctf-impl.h (struct ctf_archive_internal) <ctfi_free_strsect>
 534         New.
 535         * ctf-open-bfd.c (ctf_bfdopen_ctfsect): Explicitly open a strtab
 536         if the input has no symtab, rather than dividing by
 537         zero. Arrange to free it later via ctfi_free_ctfsect.
 538         * ctf-archive.c (ctf_new_archive_internal): Do not
 539         ctfi_free_strsect by default.
 540         (ctf_arc_close): Possibly free it here.
 541
 542 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 543
 544         * ctf-dump.c (ctf_is_slice): Delete, unnecessary.
 545         (ctf_dump_format_type): improve slice formatting.  Always print
 546         the type size, even of slices.
 547         (ctf_dump_member): Print slices (-> bitfields) differently from
 548         non-slices.  Failure to format a type is not an OOM.
 549
 550 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 551
 552         * ctf-dump.c (ctf_dump_format_type): Emit a warning.
 553         (ctf_dump_label): Swallow errors from ctf_dump_format_type.
 554         (ctf_dump_objts): Likewise.
 555         (ctf_dump_var): Likewise.
 556         (ctf_dump_type): Do not emit a duplicate message.  Move to
 557         ctf_err_warning, and swallow all errors.
 558
 559 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 560
 561         * ctf-decl.c (ctf_decl_fini): Free the cd_buf.
 562         (ctf_decl_buf): Once it escapes, don't try to free it later.
 563
 564 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 565
 566         * ctf-types.c (ctf_type_aname): Print arg types here...
 567         * ctf-dump.c (ctf_dump_funcs): ... not here: but do substitute
 568         in the type name here.
 569
 570 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 571
 572         * ctf-impl.h (ctf_assert): New.
 573         (ctf_err_warning_t): Likewise.
 574         (ctf_file_t) <ctf_errs_warnings>: Likewise.
 575         (ctf_err_warn): New prototype.
 576         (ctf_assert_fail_internal): Likewise.
 577         * ctf-inlines.h (ctf_assert_internal): Likewise.
 578         * ctf-open.c (ctf_file_close): Free ctf_errs_warnings.
 579         * ctf-create.c (ctf_serialize): Copy it on serialization.
 580         * ctf-subr.c (ctf_err_warn): New, add an error/warning.
 581         (ctf_errwarning_next): New iterator, free and pass back
 582         errors/warnings in succession.
 583         * libctf.ver (ctf_errwarning_next): Add.
 584
 585 2020-07-22  Egeyar Bagcioglu  <egeyar.bagcioglu@oracle.com>
 586
 587         * ctf-types.c (ctf_variable_iter): Fix error return.
 588
 589 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 590
 591         * ctf-open.c (ctf_bufopen_internal): Diagnose invalid flags.
 592
 593 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 594
 595         ctf-decls.h (ctf_qsort_compar_thunk): Fix arg passing.
 596
 597 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 598
 599         * ctf-impl.h (ctf_next_hkv_t): New, kv-pairs passed to
 600         sorting functions.
 601         (ctf_next_t) <u.ctn_sorted_hkv>: New, sorted kv-pairs for
 602         ctf_dynhash_next_sorted.
 603         <cu.ctn_h>: New, pointer to the dynhash under iteration.
 604         <cu.ctn_s>: New, pointer to the dynset under iteration.
 605         (ctf_hash_sort_f): Sorting function passed to...
 606         (ctf_dynhash_next_sorted): ... this new function.
 607         (ctf_dynhash_next): New.
 608         (ctf_dynset_next): New.
 609         * ctf-inlines.h (ctf_dynhash_cnext_sorted): New.
 610         (ctf_dynhash_cnext): New.
 611         (ctf_dynset_cnext): New.
 612         * ctf-hash.c (ctf_dynhash_next_sorted): New.
 613         (ctf_dynhash_next): New.
 614         (ctf_dynset_next): New.
 615         * ctf-util.c (ctf_next_destroy): Free the u.ctn_sorted_hkv if
 616         needed.
 617         (ctf_next_copy): Alloc-and-copy the u.ctn_sorted_hkv if needed.
 618
 619 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 620
 621         * ctf-impl.h (ctf_next): New.
 622         (ctf_get_dict): New prototype.
 623         * ctf-lookup.c (ctf_get_dict): New, split out of...
 624         (ctf_lookup_by_id): ... here.
 625         * ctf-util.c (ctf_next_create): New.
 626         (ctf_next_destroy): New.
 627         (ctf_next_copy): New.
 628         * ctf-types.c (includes): Add <assert.h>.
 629         (ctf_member_next): New.
 630         (ctf_enum_next): New.
 631         (ctf_type_iter): Document the lack of iteration over parent
 632         types.
 633         (ctf_type_next): New.
 634         (ctf_variable_next): New.
 635         * ctf-archive.c (ctf_archive_next): New.
 636         * libctf.ver: Add new public functions.
 637
 638 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 639
 640         * libctf.ver (ctf_ref): New.
 641         * ctf-open.c (ctf_ref): Implement it.
 642
 643 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 644
 645         * ctf-inlines.h (ctf_forwardable_kind): New.
 646         * ctf-create.c (ctf_add_forward): Use it.
 647
 648 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 649
 650         * ctf-impl.h (ctf_get_ctt_size): Move definition from here...
 651         * ctf-inlines.h (ctf_get_ctt_size): ... to here.
 652
 653 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 654
 655         * ctf-hash.c (ctf_dynset_eq_string): New.
 656         (ctf_dynset_create): New.
 657         (DYNSET_EMPTY_ENTRY_REPLACEMENT): New.
 658         (DYNSET_DELETED_ENTRY_REPLACEMENT): New.
 659         (key_to_internal): New.
 660         (internal_to_key): New.
 661         (ctf_dynset_insert): New.
 662         (ctf_dynset_remove): New.
 663         (ctf_dynset_destroy): New.
 664         (ctf_dynset_lookup): New.
 665         (ctf_dynset_exists): New.
 666         (ctf_dynset_lookup_any): New.
 667         (ctf_hash_insert_type): Coding style.
 668         (ctf_hash_define_type): Likewise.
 669         * ctf-impl.h (ctf_dynset_t): New.
 670         (ctf_dynset_eq_string): New.
 671         (ctf_dynset_create): New.
 672         (ctf_dynset_insert): New.
 673         (ctf_dynset_remove): New.
 674         (ctf_dynset_destroy): New.
 675         (ctf_dynset_lookup): New.
 676         (ctf_dynset_exists): New.
 677         (ctf_dynset_lookup_any): New.
 678         * ctf-inlines.h (ctf_dynset_cinsert): New.
 679
 680 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 681
 682         * ctf-hash.c (ctf_helem_t) <key_free>: Remove.
 683         <value_free>: Likewise.
 684         <owner>: New.
 685         (ctf_dynhash_item_free): Indirect through the owner.
 686         (ctf_dynhash_create): Only pass in ctf_dynhash_item_free and
 687         allocate space for the key_free and value_free fields fields
 688         if necessary.
 689         (ctf_hashtab_insert): Likewise.  Fix OOM errno value.
 690         (ctf_dynhash_insert): Only access ctf_hashtab's key_free and
 691         value_free if they will exist.  Set the slot's owner, but only
 692         if it exists.
 693         (ctf_dynhash_remove): Adjust.
 694
 695 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 696
 697         * ctf-hash.c (ctf_hashtab_insert): Free the key passed in if
 698         there is a key-freeing function and the key already exists.
 699
 700 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 701
 702         * ctf-inlines.h: New file.
 703         * ctf-impl.h: Include it.
 704         (ctf_hash_iter_find_f): New typedef.
 705         (ctf_dynhash_elements): New.
 706         (ctf_dynhash_lookup_kv): New.
 707         (ctf_dynhash_iter_find): New.
 708         * ctf-hash.c (ctf_dynhash_lookup_kv): New.
 709         (ctf_traverse_find_cb_arg_t): New.
 710         (ctf_hashtab_traverse_find): New.
 711         (ctf_dynhash_iter_find): New.
 712         (ctf_dynhash_elements): New.
 713
 714 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 715
 716         * ctf-impl.h [!__GNUC__] (__extension__): Define to nothing.
 717
 718 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 719
 720         * ctf-archive.c (ctf_archive_count): New.
 721         * libctf.ver: New public function.
 722
 723 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 724
 725         * ctf-types.c (ctf_member_count): New.
 726         * libctf.ver: New public function.
 727
 728 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 729
 730         * ctf-types.c (ctf_type_kind_forwarded): New.
 731
 732 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 733
 734         * ctf-types.c (ctf_type_name_raw): New.
 735         (ctf_type_aname_raw): Reimplement accordingly.
 736
 737 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 738
 739         * ctf-subr.c (ctf_dprintf): _libctf_debug is unlikely to be set.
 740
 741 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 742
 743         * ctf-impl.h (struct ctf_archive_internal)
 744         <ctfi_unmap_on_close>: New.
 745         (ctf_new_archive_internal): Adjust.
 746         * ctf-archive.c (ctf_new_archive_internal): Likewise.
 747         Initialize ctfi_unmap_on_close.  Adjust error path.
 748         (ctf_arc_bufopen): Adjust ctf_new_archive_internal call
 749         (unmap_on_close is 0).
 750         (ctf_arc_close): Only unmap if ctfi_unmap_on_close.
 751         * ctf-open-bfd.c (ctf_fdopen): Adjust.
 752
 753 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 754
 755         * ctf-types.c (ctf_type_aname): Return ECTF_CORRUPT if
 756         ints, floats or typedefs have no name.  Fix comment typo.
 757
 758 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 759
 760         * ctf-create.c (ctf_add_slice): Support slices of any kind that
 761         resolves to an integral type.
 762         * ctf-types.c (ctf_type_encoding): Resolve the type before
 763         fishing its encoding out.
 764
 765 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 766
 767         * ctf-create.c (ctf_create): Mark dirty.
 768
 769 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 770
 771         * ctf-create.c (membcmp)  Skip nameless members.
 772
 773 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 774
 775         * ctf-create.c (ctf_add_member_offset): Support names of ""
 776         as if they were the null pointer.
 777
 778 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 779
 780         * ctf-open.c (init_types): Remove typeless CTF_K_FORWARD
 781         special-casing.
 782
 783 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 784
 785         * ctf-types.c (ctf_type_reference): Add support for dynamic slices.
 786
 787 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 788
 789         * ctf-create.c (ctf_serialize): Add cast.
 790         (ctf_add_slice): Likewise.
 791
 792 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 793
 794         * ctf-impl.h (ctf_dtdef_t) <dtu_argv>: Fix type.
 795         * ctf-create.c (ctf_add_function): Check for unimplemented type
 796         and populate at the same time.  Populate one-by-one, not via
 797         memcpy.
 798         (ctf_serialize): Remove unnecessary cast.
 799         * ctf-types.c (ctf_func_type_info): Likewise.
 800         (ctf_func_type_args): Likewise.  Fix comment typo.
 801
 802 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 803
 804         * ctf-create.c (ctf_add_reftype): Support refs to type zero.
 805         (ctf_add_array): Support array contents of type zero.
 806         (ctf_add_function): Support arguments and return types of
 807         type zero.
 808         (ctf_add_typedef): Support typedefs to type zero.
 809         (ctf_add_member_offset): Support members of type zero,
 810         unless added at unspecified (naturally-aligned) offset.
 811
 812 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 813
 814         * ctf-error.c: Include <stddef.h>, for offsetof.
 815         (_ctf_errlist): Migrate to...
 816         (_ctf_errlist_t): ... this.
 817         (_ctf_erridx): New, indexes into _ctf_errlist_t.
 818         (_ctf_nerr): Remove.
 819         (ctf_errmsg): Adjust accordingly.
 820         * Makefile.am (BUILT_SOURCES): Note...
 821         (ctf-error.h): ... this new rule.
 822         * Makefile.in: Regenerate.
 823         * mkerrors.sed: New, process ctf-api.h to generate ctf-error.h.
 824         * .gitignore: New, ignore ctf-error.h.
 825
 826 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 827
 828         * ctf-impl.h: Fix typos in comments.
 829
 830 2020-07-22  Nick Clifton  <nickc@redhat.com>
 831
 832         * ctf-archive.c (ctf_arc_write): Avoid calling close twice on the
 833         same file descriptor.
 834
 835 2020-07-04  Nick Clifton  <nickc@redhat.com>
 836
 837         Binutils 2.35 branch created.
 838
 839 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 840
 841         * aclocal.m4: Add config/gettext-sister.m4: Shuffle into
 842         alphabetical order.
 843         * configure.ac: Add ZW_GNU_GETTEXT_SISTER_DIR.
 844         * config.h.in: Regenerated.
 845         * Makefile.in: Likewise.
 846         * configure: Likewise.
 847
 848 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 849
 850         * ctf-create.c: Include <unistd.h>.
 851         * ctf-open-bfd.c: Likewise.
 852
 853 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 854
 855         PR libctf/25120
 856         * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls.
 857         * swap.h (bswap_16): Do not assume that presence of <byteswap.h>
 858         means this is declared.
 859         (bswap_32): Likewise.
 860         (bswap_64): Likewise.
 861         (bswap_identity_64): Remove, unused.
 862         * configure: Regenerated.
 863         * config.h.in: Likewise.
 864
 865 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 866
 867         PR libctf/25120
 868         * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback.
 869         (_libctf_unlikely_): Likewise.
 870         (_libctf_unused): Likewise.
 871         (_libctf_malloc_): Likewise.
 872
 873 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 874
 875         PR libctf/25120
 876         * ctf-archive.c (search_nametbl): No longer global: declare...
 877         (ctf_arc_open_by_name_internal): ... here. Use bsearch_r.
 878         (search_modent_by_name): Take and use ARG for the nametbl.
 879
 880 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 881
 882         * ctf-impl.h (ctf_new_archive_internal): Declare.
 883         (ctf_arc_bufopen): Remove.
 884         (ctf_archive_internal) <ctfi_free_symsect>: New.
 885         * ctf-archive.c (ctf_arc_close): Use it.
 886         (ctf_arc_bufopen): Fuse into...
 887         (ctf_new_archive_internal): ... this, moved across from...
 888         * ctf-open-bfd.c: ... here.
 889         (ctf_bfdopen_ctfsect): Use ctf_arc_bufopen.
 890         * libctf.ver: Add it.
 891
 892 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 893
 894         * ctf-create.c (ctf_add_forward): Intern in the right namespace.
 895         (ctf_dtd_delete): Remove correspondingly.
 896         (ctf_rollback): Likewise.
 897
 898 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 899
 900         * ctf-create.c (ctf_add_type_internal): Hand back existing types
 901         unchanged.
 902
 903 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 904
 905         * ctf-create.c (ctf_add_forward): Don't add forwards to
 906         types that already exist.
 907
 908 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 909
 910         * ctf-open.c (init_types): Only intern root-visible types.
 911         * ctf-create.c (ctf_dtd_insert): Likewise.
 912         (ctf_dtd_delete): Only remove root-visible types.
 913         (ctf_rollback): Likewise.
 914         (ctf_add_generic): Adjust.
 915         (ctf_add_struct_sized): Adjust comment.
 916         (ctf_add_union_sized): Likewise.
 917         (ctf_add_enum): Likewise.
 918         * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
 919
 920 2020-03-11  John Baldwin  <jhb@FreeBSD.org>
 921
 922         * swap.h (bswap_identity_64): Make static.
 923
 924 2020-01-18  Nick Clifton  <nickc@redhat.com>
 925
 926         Binutils 2.34 branch created.
 927
 928 2020-01-05  Joel Brobecker  <brobecker@adacore.com>
 929
 930         PR binutils/25155:
 931         * configure.ac: Add AC_CHECK_DECLS([asprintf]).
 932         * configure, config.h.in: Regenerate.
 933
 934 2020-01-01  Alan Modra  <amodra@gmail.com>
 935
 936         Update year range in copyright notice of all files.
 937
 938 2019-10-16  Simon Marchi  <simon.marchi@polymtl.ca>
 939
 940         * swap.h (bswap_16, bswap_32, bswap_64): Make static.
 941
 942 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
 943
 944         * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
 945         * ctf-types.c (ctf_type_lname): Likewise.
 946
 947 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 948
 949         * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
 950         ctf_import after the first for a given file.
 951
 952 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 953
 954         * ctf-impl.h (ctf_str_append_noerr): Declare.
 955         * ctf-util.c (ctf_str_append_noerr): Define in terms of
 956         ctf_str_append.
 957         * ctf-dump.c (str_append): New, call it.
 958         (ctf_dump_format_type): Use str_append, not ctf_str_append.
 959         (ctf_dump_label): Likewise.
 960         (ctf_dump_objts): Likewise.
 961         (ctf_dump_funcs): Likewise.
 962         (ctf_dump_var): Likewise.
 963         (ctf_dump_member): Likewise.
 964         (ctf_dump_type): Likewise.
 965         (ctf_dump): Likewise.
 966
 967 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
 968
 969         * ctf-impl.h (ctf_alloc): Remove.
 970         (ctf_free): Likewise.
 971         (ctf_strdup): Likewise.
 972         * ctf-subr.c (ctf_alloc): Remove.
 973         (ctf_free): Likewise.
 974         * ctf-util.c (ctf_strdup): Remove.
 975
 976         * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
 977         ctf_free; strdup, not ctf_strdup.
 978         (ctf_dtd_delete): Likewise.
 979         (ctf_dvd_delete): Likewise.
 980         (ctf_add_generic): Likewise.
 981         (ctf_add_function): Likewise.
 982         (ctf_add_enumerator): Likewise.
 983         (ctf_add_member_offset): Likewise.
 984         (ctf_add_variable): Likewise.
 985         (membadd): Likewise.
 986         (ctf_compress_write): Likewise.
 987         (ctf_write_mem): Likewise.
 988         * ctf-decl.c (ctf_decl_push): Likewise.
 989         (ctf_decl_fini): Likewise.
 990         (ctf_decl_sprintf): Likewise.  Check for OOM.
 991         * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
 992         ctf_free; strdup, not ctf_strdup.
 993         (ctf_dump_free): Likewise.
 994         (ctf_dump): Likewise.
 995         * ctf-open.c (upgrade_types_v1): Likewise.
 996         (init_types): Likewise.
 997         (ctf_file_close): Likewise.
 998         (ctf_bufopen_internal): Likewise.  Check for OOM.
 999         (ctf_parent_name_set): Likewise: report the OOM to the caller.
1000         (ctf_cuname_set): Likewise.
1001         (ctf_import): Likewise.
1002         * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
1003         free, not ctf_free; strdup, not ctf_strdup.
1004         (ctf_str_free_atom): Likewise.
1005         (ctf_str_create_atoms): Likewise.
1006         (ctf_str_add_ref_internal): Likewise.
1007         (ctf_str_remove_ref): Likewise.
1008         (ctf_str_write_strtab): Likewise.
1009
1010 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
1011
1012         * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
1013         work right for non-int/fps.
1014
1015 2019-08-08  Nick Alcock  <nick.alcock@oracle.com>
1016
1017         * ctf-types.c (ctf_type_name): Don't strlen a potentially-
1018         null pointer.
1019
1020 2019-08-07  Nick Alcock  <nick.alcock@oracle.com>
1021
1022         * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
1023         * ctf-open.c (ctf_file_close): Free it.
1024         * ctf-create.c (ctf_serialize): Adjust.
1025         (membcmp): When reporting a conflict due to an error, report the
1026         error.
1027         (ctf_add_type): Turn into a ctf_add_processing wrapper.  Rename to...
1028         (ctf_add_type_internal): ... this.  Hand back types we are already
1029         in the middle of adding immediately.  Hand back structs/unions with
1030         the same number of members immediately.  Do not walk the dynamic
1031         list.  Call ctf_add_type_internal, not ctf_add_type.  Handle
1032         forwards promoted to other types and the inverse case identically.
1033         Add structs to the mapping as soon as we intern them, before they
1034         gain any members.
1035
1036 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
1037
1038         * ctf-impl.h (ctf_names_t): New.
1039         (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
1040         (ctf_file_t) <ctf_structs>: Likewise.
1041         <ctf_unions>: Likewise.
1042         <ctf_enums>: Likewise.
1043         <ctf_names>: Likewise.
1044         <ctf_lookups>: Improve comment.
1045         <ctf_ptrtab_len>: New.
1046         <ctf_prov_strtab>: New.
1047         <ctf_str_prov_offset>: New.
1048         <ctf_dtbyname>: Remove, redundant to the names hashes.
1049         <ctf_dtnextid>: Remove, redundant to ctf_typemax.
1050         (ctf_dtdef_t) <dtd_name>: Remove.
1051         <dtd_data>: Note that the ctt_name is now populated.
1052         (ctf_str_atom_t) <csa_offset>: This is now the strtab
1053         offset for internal strings too.
1054         <csa_external_offset>: New, the external strtab offset.
1055         (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
1056         (ctf_name_table): New declaration.
1057         (ctf_lookup_by_rawname): Likewise.
1058         (ctf_lookup_by_rawhash): Likewise.
1059         (ctf_set_ctl_hashes): Likewise.
1060         (ctf_serialize): Likewise.
1061         (ctf_dtd_insert): Adjust.
1062         (ctf_simple_open_internal): Likewise.
1063         (ctf_bufopen_internal): Likewise.
1064         (ctf_list_empty_p): Likewise.
1065         (ctf_str_remove_ref): Likewise.
1066         (ctf_str_add): Returns uint32_t now.
1067         (ctf_str_add_ref): Likewise.
1068         (ctf_str_add_external): Now returns a boolean (int).
1069         * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
1070         for strings in the appropriate range.
1071         (ctf_str_create_atoms): Create the ctf_prov_strtab.  Detect OOM
1072         when adding the null string to the new strtab.
1073         (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
1074         (ctf_str_add_ref_internal): Add make_provisional argument.  If
1075         make_provisional, populate the offset and fill in the
1076         ctf_prov_strtab accordingly.
1077         (ctf_str_add): Return the offset, not the string.
1078         (ctf_str_add_ref): Likewise.
1079         (ctf_str_add_external): Return a success integer.
1080         (ctf_str_remove_ref): New, remove a single ref.
1081         (ctf_str_count_strtab): Do not count the initial null string's
1082         length or the existence or length of any unreferenced internal
1083         atoms.
1084         (ctf_str_populate_sorttab): Skip atoms with no refs.
1085         (ctf_str_write_strtab): Populate the nullstr earlier.  Add one
1086         to the cts_len for the null string, since it is no longer done
1087         in ctf_str_count_strtab.  Adjust for csa_external_offset rename.
1088         Populate the csa_offset for both internal and external cases.
1089         Flush the ctf_prov_strtab afterwards, and reset the
1090         ctf_str_prov_offset.
1091         * ctf-create.c (ctf_grow_ptrtab): New.
1092         (ctf_create): Call it.  Initialize new fields rather than old
1093         ones.  Tell ctf_bufopen_internal that this is a writable dictionary.
1094         Set the ctl hashes and data model.
1095         (ctf_update): Rename to...
1096         (ctf_serialize): ... this.  Leave a compatibility function behind.
1097         Tell ctf_simple_open_internal that this is a writable dictionary.
1098         Pass the new fields along from the old dictionary.  Drop
1099         ctf_dtnextid and ctf_dtbyname.  Use ctf_strraw, not dtd_name.
1100         Do not zero out the DTD's ctt_name.
1101         (ctf_prefixed_name): Rename to...
1102         (ctf_name_table): ... this.  No longer return a prefixed name: return
1103         the applicable name table instead.
1104         (ctf_dtd_insert): Use it, and use the right name table.  Pass in the
1105         kind we're adding.  Migrate away from dtd_name.
1106         (ctf_dtd_delete): Adjust similarly.  Remove the ref to the
1107         deleted ctt_name.
1108         (ctf_dtd_lookup_type_by_name): Remove.
1109         (ctf_dynamic_type): Always return NULL on read-only dictionaries.
1110         No longer check ctf_dtnextid: check ctf_typemax instead.
1111         (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
1112         (ctf_rollback): Likewise.  No longer fail with ECTF_OVERROLLBACK. Use
1113         ctf_name_table and the right name table, and migrate away from
1114         dtd_name as in ctf_dtd_delete.
1115         (ctf_add_generic): Pass in the kind explicitly and pass it to
1116         ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid.  Migrate away
1117         from dtd_name to using ctf_str_add_ref to populate the ctt_name.
1118         Grow the ptrtab if needed.
1119         (ctf_add_encoded): Pass in the kind.
1120         (ctf_add_slice): Likewise.
1121         (ctf_add_array): Likewise.
1122         (ctf_add_function): Likewise.
1123         (ctf_add_typedef): Likewise.
1124         (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
1125         ctt_name rather than dtd_name.
1126         (ctf_add_struct_sized): Pass in the kind.  Use
1127         ctf_lookup_by_rawname, not ctf_hash_lookup_type /
1128         ctf_dtd_lookup_type_by_name.
1129         (ctf_add_union_sized): Likewise.
1130         (ctf_add_enum): Likewise.
1131         (ctf_add_enum_encoded): Likewise.
1132         (ctf_add_forward): Likewise.
1133         (ctf_add_type): Likewise.
1134         (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
1135         being initialized until after the call.
1136         (ctf_write_mem): Likewise.
1137         (ctf_write): Likewise.
1138         * ctf-archive.c (arc_write_one_ctf): Likewise.
1139         * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
1140         ctf_hash_lookup_type.
1141         (ctf_lookup_by_id): No longer check the readonly types if the
1142         dictionary is writable.
1143         * ctf-open.c (init_types): Assert that this dictionary is not
1144         writable.  Adjust to use the new name hashes, ctf_name_table,
1145         and ctf_ptrtab_len.  GNU style fix for the final ptrtab scan.
1146         (ctf_bufopen_internal): New 'writable' parameter.  Flip on LCTF_RDWR
1147         if set.  Drop out early when dictionary is writable.  Split the
1148         ctf_lookups initialization into...
1149         (ctf_set_cth_hashes): ... this new function.
1150         (ctf_simple_open_internal): Adjust.  New 'writable' parameter.
1151         (ctf_simple_open): Adjust accordingly.
1152         (ctf_bufopen): Likewise.
1153         (ctf_file_close): Destroy the appropriate name hashes.  No longer
1154         destroy ctf_dtbyname, which is gone.
1155         (ctf_getdatasect): Remove spurious "extern".
1156         * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
1157         specified name table, given a kind.
1158         (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
1159         (ctf_member_iter): Add support for iterating over the
1160         dynamic type list.
1161         (ctf_enum_iter): Likewise.
1162         (ctf_variable_iter): Likewise.
1163         (ctf_type_rvisit): Likewise.
1164         (ctf_member_info): Add support for types in the dynamic type list.
1165         (ctf_enum_name): Likewise.
1166         (ctf_enum_value): Likewise.
1167         (ctf_func_type_info): Likewise.
1168         (ctf_func_type_args): Likewise.
1169         * ctf-link.c (ctf_accumulate_archive_names): No longer call
1170         ctf_update.
1171         (ctf_link_write): Likewise.
1172         (ctf_link_intern_extern_string): Adjust for new
1173         ctf_str_add_external return value.
1174         (ctf_link_add_strtab): Likewise.
1175         * ctf-util.c (ctf_list_empty_p): New.
1176
1177 2019-08-05  Nick Alcock  <nick.alcock@oracle.com>
1178
1179         * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
1180         type zero.
1181         * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
1182         members and types.
1183         (ctf_add_variable): Likewise for variables pointing to them.
1184         * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
1185         type link failure, but do warn for others.
1186         * ctf-dump.c (ctf_dump_format_type): Likewise.  Do not assume all
1187         errors to be ENOMEM.
1188         (ctf_dump_member): Likewise.
1189         (ctf_dump_type): Likewise.
1190         (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
1191         (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
1192         (ctf_dump_header): Likewise.
1193         (ctf_dump_label): likewise.
1194         (ctf_dump_objts): likewise.
1195         (ctf_dump_funcs): likewise.
1196         (ctf_dump_var): likewise.
1197         (ctf_dump_str): Likewise.
1198
1199 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
1200
1201         * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
1202         (LT_INIT): Likewise.
1203         (AM_INSTALL_LIBBFD): Likewise.
1204         (dlopen): Note why this is necessary in a comment.
1205         (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
1206         opcodes/.
1207         (SHARED_LDFLAGS): Likewise.
1208         (BFD_LIBADD): Likewise, for libbfd.
1209         (BFD_DEPENDENCIES): Likewise.
1210         (VERSION_FLAGS): Initialize, using a version script if ld supports
1211         one, or libtool -export-symbols-regex otherwise.
1212         (AC_CONFIG_MACRO_DIR): Add ../BFD.
1213         * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
1214         (INCDIR): New.
1215         (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
1216         (noinst_LIBRARIES): Replace with...
1217         [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
1218         [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
1219         libctf-nobfd.la as well.
1220         [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
1221         [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
1222         (libctf_a_SOURCES): Rename to...
1223         (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
1224         ctf-open-bfd.c.
1225         (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
1226         with ctf-open-bfd.c added.
1227         (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
1228         (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
1229         (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
1230         * Makefile.am [INSTALL_LIBCTF]: Use it.
1231         * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
1232         libtool macros.
1233         * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
1234         the unstable components).
1235         * Makefile.in: Regenerated.
1236         * config.h.in: Likewise.
1237         * configure: Likewise.
1238
1239 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1240
1241         * configure.ac (INSTALL_LIBCTF): New, controlled by
1242         --enable-install-libctf.
1243         [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
1244         * Makefile.in: Regenerated.
1245         * configure: Regenerated.
1246
1247 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1248
1249         * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
1250         * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
1251
1252 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1253
1254         * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
1255
1256 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1257
1258         * ctf-impl.h (includes): Include <sys/param.h> here.
1259
1260 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1261
1262         * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
1263         (flip_objts): Likewise.
1264         (flip_vars): Likewise.
1265         (flip_types): Likewise.
1266
1267 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1268
1269         * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
1270         freeing functions: if set, free the key and value if the slot
1271         already exists.  Always reassign the key.
1272         (ctf_dynhash_insert): Adjust call appropriately.
1273         (ctf_hash_insert_type): Likewise.
1274
1275 2019-08-03  Nick Alcock  <nick.alcock@oracle.com>
1276
1277         * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
1278         type kind.  Allow forwards to unify with pre-existing structs/
1279         unions/enums.
1280
1281 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
1282
1283         * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
1284         <ctf_link_memb_name_changer>: Likewise.
1285         <ctf_link_memb_name_changer_arg>: Likewise.
1286         * ctf-create.c (ctf_update): Update accordingly.
1287         * ctf-open.c (ctf_file_close): Likewise.
1288         * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
1289         (ctf_link_add_cu_mapping): New.
1290         (ctf_link_set_memb_name_changer): Likewise.
1291         (ctf_change_parent_name): New.
1292         (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
1293         allocated by the caller's ctf_link_memb_name_changer.
1294         <ndynames>: Likewise.
1295         (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
1296         (ctf_link_write): Likewise (for _CTF_SECTION only): also call
1297         ctf_change_parent_name.  Free any resulting names.
1298
1299 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1300
1301         * ctf-link.c (ctf_create_per_cu): New, refactored out of...
1302         (ctf_link_one_type): ... here, with parent-name setting added.
1303         (check_variable): New.
1304         (ctf_link_one_variable): Likewise.
1305         (ctf_link_one_input_archive_member): Call it.
1306         * ctf-error.c (_ctf_errlist): Updated with new errors.
1307
1308 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1309
1310         * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
1311         (struct ctf_link_type_mapping_key): New.
1312         (ctf_hash_type_mapping_key): Likewise.
1313         (ctf_hash_eq_type_mapping_key): Likewise.
1314         (ctf_add_type_mapping): Likewise.
1315         (ctf_type_mapping): Likewise.
1316         (ctf_dynhash_empty): Likewise.
1317         * ctf-open.c (ctf_file_close): Update accordingly.
1318         * ctf-create.c (ctf_update): Likewise.
1319         (ctf_add_type): Populate the mapping.
1320         * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
1321         (ctf_hash_eq_type_mapping_key): Check the key for equality.
1322         (ctf_dynhash_insert): Fix comment typo.
1323         (ctf_dynhash_empty): New.
1324         * ctf-link.c (ctf_add_type_mapping): New.
1325         (ctf_type_mapping): Likewise.
1326         (empty_link_type_mapping): New.
1327         (ctf_link_one_input_archive): Call it.
1328
1329 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1330
1331         * ctf-link.c: New file, linking of the string and type sections.
1332         * Makefile.am (libctf_a_SOURCES): Add it.
1333         * Makefile.in: Regenerate.
1334
1335         * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
1336         ctf_link_outputs.
1337         * ctf-create.c (ctf_update): Update accordingly.
1338         * ctf-open.c (ctf_file_close): Likewise.
1339         * ctf-error.c (_ctf_errlist): Updated with new errors.
1340
1341 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1342
1343         * ctf-dump.c (ctf_dump_funcs): Check the right error value.
1344
1345 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1346
1347         * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
1348         ctf_type_iter.
1349         (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
1350         (ctf_dump_format_type): Add non-root-type { } notation.
1351         Add root flag to prototype.
1352         (ctf_dump_label): Adjust accordingly.
1353         (ctf_dump_objts): Likewise.
1354         (ctf_dump_var): Likewise.
1355
1356 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1357
1358         * ctf-create.c (ctf_compress_write): Fix double-free.
1359
1360 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1361
1362         * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
1363         of...
1364         (ctf_arc_write_fd): ... this new function.
1365         * ctf-create.c (ctf_write_mem): New.
1366
1367 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1368
1369         * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
1370         (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
1371         (ctf_str_add_ref): Name the last arg.
1372         (ctf_str_add_external) New.
1373         (ctf_str_add_strraw_explicit): Likewise.
1374         (ctf_simple_open_internal): Likewise.
1375         (ctf_bufopen_internal): Likewise.
1376
1377         * ctf-string.c (ctf_strraw_explicit): Split from...
1378         (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
1379         (ctf_str_add_ref_internal): Return the atom, not the
1380         string.
1381         (ctf_str_add): Adjust accordingly.
1382         (ctf_str_add_ref): Likewise.  Move up in the file.
1383         (ctf_str_add_external): New: update the csa_offset.
1384         (ctf_str_count_strtab): Only account for strings with no csa_offset
1385         in the internal strtab length.
1386         (ctf_str_write_strtab): If the csa_offset is set, update the
1387         string's refs without writing the string out, and update the
1388         ctf_syn_ext_strtab.  Make OOM handling less ugly.
1389         * ctf-create.c (struct ctf_sort_var_arg_cb): New.
1390         (ctf_update): Handle failure to populate the strtab.  Pass in the
1391         new ctf_sort_var arg.  Adjust for ctf_syn_ext_strtab addition.
1392         Call ctf_simple_open_internal, not ctf_simple_open.
1393         (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
1394         strings by hand.
1395         * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
1396         ctf_strraw).  Adjust to diagnose ECTF_STRTAB nonetheless.
1397         * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
1398         (ctf_file_close): Destroy the ctf_syn_ext_strtab.
1399         (ctf_simple_open): Rename to, and reimplement as a wrapper around...
1400         (ctf_simple_open_internal): ... this new function, which calls
1401         ctf_bufopen_internal.
1402         (ctf_bufopen): Rename to, and reimplement as a wrapper around...
1403         (ctf_bufopen_internal): ... this new function, which sets
1404         ctf_syn_ext_strtab.
1405
1406 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1407
1408         * ctf_types.c (ctf_type_iter_all): New.
1409
1410 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1411
1412         * ctf-open.c (init_symtab): Check for overflow against the right
1413         section.
1414         (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
1415         (upgrade_types_v1): Note that these sections are not checked.
1416         (flip_header): Endian-swap the header fields.
1417         (flip_ctf): Endian-swap the sections.
1418         (flip_objts): Update comment.
1419         (ctf_bufopen): Check header offsets and alignment for validity.
1420
1421 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
1422
1423         * ctf-open-bfd.c: Add <assert.h>.
1424         (ctf_bfdopen_ctfsect): Open string and symbol tables using
1425         techniques borrowed from bfd_elf_sym_name.
1426         (ctf_new_archive_internal): Improve comment.
1427         * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
1428         * ctf-open.c (ctf_bufopen): Allow opening with a string section but
1429         no symbol section, but not vice versa.
1430
1431 2019-07-08  Nick Alcock  <nick.alcock@oracle.com>
1432
1433         * ctf-impl.h (ctf_file_t): New field ctf_openflags.
1434         * ctf-open.c (ctf_bufopen): Set it.  No longer dump header offsets.
1435         * ctf-dump.c (dump_header): New function, dump the CTF header.
1436         (ctf_dump): Call it.
1437         (ctf_dump_header_strfield): New function.
1438         (ctf_dump_header_sectfield): Likewise.
1439
1440 2019-07-06  Nick Alcock  <nick.alcock@oracle.com>
1441
1442         * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
1443         ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
1444         * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
1445         ctf_base: do not assume that it is always sizeof (ctf_header_t).
1446         Print out ctf_cuname: only print out ctf_parname if set.
1447         (ctf_free_base): Removed, ctf_base is no longer freed: free
1448         ctf_dynbase instead.
1449         (ctf_set_version): Fix spacing.
1450         (upgrade_header): New, in-place header upgrading.
1451         (upgrade_types): Rename to...
1452         (upgrade_types_v1): ... this.  Free ctf_dynbase, not ctf_base.  No
1453         longer track old and new headers separately.  No longer allow for
1454         header sizes explicitly: squeeze the headers out on upgrade (they
1455         are preserved in fp->ctf_header).  Set ctf_dynbase, ctf_base and
1456         ctf_buf explicitly.  Use ctf_free, not ctf_free_base.
1457         (upgrade_types): New, also handle ctf_parmax updating.
1458         (flip_header): Flip ctf_cuname.
1459         (flip_types): Flip BUF explicitly rather than deriving BUF from
1460         BASE.
1461         (ctf_bufopen): Store the header in fp->ctf_header.  Correct minimum
1462         required alignment of objtoff and funcoff.  No longer store it in
1463         the ctf_buf unless that buf is derived unmodified from the input.
1464         Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
1465         that duplicate fields in ctf_file: move allocation of ctf_file
1466         further up instead.  Call upgrade_header as needed.  Move
1467         version-specific ctf_parmax initialization into upgrade_types.  More
1468         concise error handling.
1469         (ctf_file_close): No longer test for null pointers before freeing.
1470         Free ctf_dyncuname, ctf_dynbase, and ctf_header.  Do not call
1471         ctf_free_base.
1472         (ctf_cuname): New.
1473         (ctf_cuname_set): New.
1474         * ctf-create.c (ctf_update): Populate ctf_cuname.
1475         (ctf_gzwrite): Write out the header explicitly.  Remove obsolescent
1476         comment.
1477         (ctf_write): Likewise.
1478         (ctf_compress_write): Get the header from ctf_header, not ctf_base.
1479         Fix the compression length: fp->ctf_size never counted the CTF
1480         header.  Simplify the compress call accordingly.
1481
1482 2019-07-11  Hans-Peter Nilsson  <hp@bitrange.com>
1483
1484         * ctf-endian.h: Don't assume htole64 and le64toh are always
1485         present if HAVE_ENDIAN_H; also check if htole64 is defined.
1486         [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
1487         not bswap_identity_64.
1488
1489 2019-09-18  Alan Modra  <amodra@gmail.com>
1490
1491         * ctf-open-bfd.c: Update throughout for bfd section macro changes.
1492
1493 2019-09-09  Phil Blundell  <pb@pbcl.net>
1494
1495         binutils 2.33 branch created.
1496
1497 2019-07-18  Nick Alcock  <nick.alcock@oracle.com>
1498
1499         * ctf-types.c (ctf_type_aname_raw): New.
1500         (ctf_func_type_info): Likewise.
1501         (ctf_func_type_args): Likewise.
1502         * ctf-error.c (_ctf_errlist): Fix description.
1503         * ctf-lookup.c: Fix file description.
1504
1505 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1506
1507         * ctf-create.c (ctf_create): Fix off-by-one error.
1508
1509 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1510
1511         * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
1512         struct ctf_strs.
1513         (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
1514         (struct ctf_str_atom): New, disambiguated single string.
1515         (struct ctf_str_atom_ref): New, points to some other location that
1516         references this string's offset.
1517         (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
1518         Remove member ctf_dtvstrlen: we no longer track the total strlen
1519         as we add strings.
1520         (ctf_str_create_atoms): Declare new function in ctf-string.c.
1521         (ctf_str_free_atoms): Likewise.
1522         (ctf_str_add): Likewise.
1523         (ctf_str_add_ref): Likewise.
1524         (ctf_str_rollback): Likewise.
1525         (ctf_str_purge_refs): Likewise.
1526         (ctf_str_write_strtab): Likewise.
1527         (ctf_realloc): Declare new function in ctf-util.c.
1528
1529         * ctf-open.c (ctf_bufopen): Create the atoms table.
1530         (ctf_file_close): Destroy it.
1531         * ctf-create.c (ctf_update): Copy-and-free it on update.  No longer
1532         special-case the position of the parname string.  Construct the
1533         strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
1534         rest of each buffer element is constructed, not via open-coding:
1535         realloc the CTF buffer and append the strtab to it.  No longer
1536         maintain ctf_dtvstrlen.  Sort the variable entry table later, after
1537         strtab construction.
1538         (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
1539         (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
1540         after buffer element construction instead.
1541         (ctf_copy_lmembers): Likewise.
1542         (ctf_copy_emembers): Likewise.
1543         (ctf_create): No longer maintain the ctf_dtvstrlen.
1544         (ctf_dtd_delete): Likewise.
1545         (ctf_dvd_delete): Likewise.
1546         (ctf_add_generic): Likewise.
1547         (ctf_add_enumerator): Likewise.
1548         (ctf_add_member_offset): Likewise.
1549         (ctf_add_variable): Likewise.
1550         (membadd): Likewise.
1551         * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
1552         if there are active ctf_str_num_refs.
1553         (ctf_strraw): Move to ctf-string.c.
1554         (ctf_strptr): Likewise.
1555         * ctf-string.c: New file, strtab manipulation.
1556
1557         * Makefile.am (libctf_a_SOURCES): Add it.
1558         * Makefile.in: Regenerate.
1559
1560 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1561
1562         * ctf-impl.h (ctf_hash_iter_f): New.
1563         (ctf_dynhash_iter): New declaration.
1564         (ctf_dynhash_iter_remove): New declaration.
1565         * ctf-hash.c (ctf_dynhash_iter): Define.
1566         (ctf_dynhash_iter_remove): Likewise.
1567         (ctf_hashtab_traverse): New.
1568         (ctf_hashtab_traverse_remove): Likewise.
1569         (struct ctf_traverse_cb_arg): Likewise.
1570         (struct ctf_traverse_remove_cb_arg): Likewise.
1571
1572 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1573
1574         * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
1575
1576 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
1577
1578         * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
1579         (ctf_dump_funcs): Likewise.
1580
1581 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1582
1583         * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
1584         (ctf_fdopen): Check for endian-swapped raw CTF magic, and
1585         little-endian CTF archive magic.  Do not check the CTF version:
1586         ctf_simple_open does that in endian-safe ways.  Do not dereference
1587         null pointers on open failure.
1588
1589 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1590
1591         * ctf-open.c (get_vbytes_common): Return the new slice size.
1592         (ctf_bufopen): Flip the endianness of the CTF-section header copy.
1593         Remember to copy in the CTF data when opening an uncompressed
1594         foreign-endian CTF file.  Prune useless variable manipulation.
1595
1596 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1597
1598         * ctf-open.c (ctf_types): Fail when unidentified type kinds are
1599         seen.
1600
1601 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1602
1603         * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
1604         output.
1605
1606 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1607
1608         * ctf-subr.c (_PAGESIZE): Remove.
1609         (ctf_data_alloc): Likewise.
1610         (ctf_data_free): Likewise.
1611         (ctf_data_protect): Likewise.
1612         * ctf-impl.h: Remove declarations.
1613         * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
1614         ctf_free, not ctf_data_free.
1615         (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc.  Free
1616         the buffer again on compression error.
1617         * ctf-open.c (ctf_set_base): No longer track the size: call
1618         ctf_free, not ctf_data_free.
1619         (upgrade_types): Likewise.  Call ctf_alloc, not ctf_data_alloc.
1620         (ctf_bufopen): Likewise.  No longer call ctf_data_protect.
1621
1622 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
1623
1624         * ctf-create.c (ctf_dtd_insert): Pass on error returns from
1625         ctf_dynhash_insert.
1626         (ctf_dvd_insert): Likewise.
1627         (ctf_add_generic): Likewise.
1628         (ctf_add_variable): Likewise.
1629         * ctf-impl.h: Adjust declarations.
1630
1631 2019-06-14  Alan Modra  <amodra@gmail.com>
1632
1633         * configure: Regenerate.
1634
1635 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1636
1637         * ctf-decls.h: Include <libiberty.h>.
1638         * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
1639
1640 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1641
1642         * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
1643         (ctf_dump_objts): Likewise.
1644         (ctf_dump_funcs): Likewise.
1645         (ctf_dump_member): Likewise.
1646         (ctf_dump_str): Likewise.
1647
1648 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
1649
1650         * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
1651         * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
1652
1653 2019-06-05  Nick Alcock  <nick.alcock@oracle.com>
1654
1655         * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
1656         (ctf_arc_open_by_offset): Likewise.
1657         * ctf-create.c (ctf_add_type): Likewise.
1658
1659 2019-06-04  Tom Tromey  <tromey@adacore.com>
1660
1661         * ctf-create.c (ctf_add_encoded, ctf_add_slice)
1662         (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
1663
1664 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
1665
1666         * configure.ac: Check for O_CLOEXEC.
1667         * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
1668         * config.h.in: Regenerate.
1669         * configure: Likewise.
1670
1671 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
1672
1673         * qsort_r.c: Rename to...
1674         * ctf-qsort_r.c: ... this.
1675         (_quicksort): Define to ctf_qsort_r.
1676         * ctf-decls.h (qsort_r): Remove.
1677         (ctf_qsort_r): Add.
1678         (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
1679         (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
1680         * Makefile.am (libctf_a_LIBADD): Remove.
1681         (libctf_a_SOURCES): New, add ctf-qsort_r.c.
1682         * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
1683         * ctf-create.c (ctf_update): Likewise.
1684         * configure.ac: Check for BSD versus GNU qsort_r signature.
1685         * Makefile.in: Regenerate.
1686         * config.h.in: Likewise.
1687         * configure: Likewise.
1688
1689 2019-06-03  Nick Alcock  <nick.alcock@oracle.com>
1690
1691         * ctf-dump.c (ctf_dump_funcs): Free in the right place.
1692
1693 2019-05-29  Nick Alcock  <nick.alcock@oracle.com>
1694
1695         * Makefile.am (ZLIB): New.
1696         (ZLIBINC): Likewise.
1697         (AM_CFLAGS): Use them.
1698         (libctf_a_LIBADD): New, for LIBOBJS.
1699         * configure.ac: Check for zlib, endian.h, and qsort_r.
1700         * ctf-endian.h: New, providing htole64 and le64toh.
1701         * swap.h: Code style fixes.
1702         (bswap_identity_64): New.
1703         * qsort_r.c: New, from gnulib (with one added #include).
1704         * ctf-decls.h: New, providing a conditional qsort_r declaration,
1705         and unconditional definitions of MIN and MAX.
1706         * ctf-impl.h: Use it.  Do not use <sys/errno.h>.
1707         (ctf_set_errno): Now returns unsigned long.
1708         * ctf-util.c (ctf_set_errno): Adjust here too.
1709         * ctf-archive.c: Use ctf-endian.h.
1710         (ctf_arc_open_by_offset): Use memset, not bzero.  Drop cts_type,
1711         cts_flags and cts_offset.
1712         (ctf_arc_write): Drop debugging dependent on the size of off_t.
1713         * ctf-create.c: Provide a definition of roundup if not defined.
1714         (ctf_create): Drop cts_type, cts_flags and cts_offset.
1715         (ctf_add_reftype): Do not check if type IDs are below zero.
1716         (ctf_add_slice): Likewise.
1717         (ctf_add_typedef): Likewise.
1718         (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
1719         when known error-free.  Drop CTF_ERR usage for functions returning
1720         int.
1721         (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
1722         int.
1723         (ctf_add_variable): Likewise.
1724         (enumcmp): Likewise.
1725         (enumadd): Likewise.
1726         (membcmp): Likewise.
1727         (ctf_add_type): Likewise.  Cast error-returning ssize_t's to size_t
1728         when known error-free.
1729         * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
1730         returning int: use CTF_ERR for functions returning ctf_type_id.
1731         (ctf_dump_label): Likewise.
1732         (ctf_dump_objts): Likewise.
1733         * ctf-labels.c (ctf_label_topmost): Likewise.
1734         (ctf_label_iter): Likewise.
1735         (ctf_label_info): Likewise.
1736         * ctf-lookup.c (ctf_func_args): Likewise.
1737         * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
1738         (ctf_bufopen): Likewise.  Use zlib types as needed.
1739         * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
1740         returning int.
1741         (ctf_enum_iter): Likewise.
1742         (ctf_type_size): Likewise.
1743         (ctf_type_align): Likewise.  Cast to size_t where appropriate.
1744         (ctf_type_kind_unsliced): Likewise.
1745         (ctf_type_kind): Likewise.
1746         (ctf_type_encoding): Likewise.
1747         (ctf_member_info): Likewise.
1748         (ctf_array_info): Likewise.
1749         (ctf_enum_value): Likewise.
1750         (ctf_type_rvisit): Likewise.
1751         * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
1752         cts_offset.
1753         (ctf_simple_open): Likewise.
1754         (ctf_bfdopen_ctfsect): Likewise.  Set cts_size properly.
1755         * Makefile.in: Regenerate.
1756         * aclocal.m4: Likewise.
1757         * config.h: Likewise.
1758         * configure: Likewise.
1759
1760 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1761
1762         * configure.in: Check for bfd_section_from_elf_index.
1763         * configure: Regenerate.
1764         * config.h.in [HAVE_BFD_ELF]: Likewise.
1765         * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
1766         abfd is potentially unused now.
1767
1768 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1769
1770         * Makefile.am: New.
1771         * Makefile.in: Regenerated.
1772         * config.h.in: Likewise.
1773         * aclocal.m4: Likewise.
1774         * configure: Likewise.
1775
1776 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1777
1778         * ctf-dump.c: New.
1779
1780 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1781
1782         * ctf-labels.c: New.
1783
1784 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1785
1786         * ctf-impl.h (_libctf_version): New declaration.
1787         * ctf-subr.c (_libctf_version): Define it.
1788         (ctf_version): New.
1789
1790 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1791
1792         * ctf-create.c (enumcmp): New.
1793         (enumadd): Likewise.
1794         (membcmp): Likewise.
1795         (membadd): Likewise.
1796         (ctf_add_type): Likewise.
1797
1798 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1799
1800         * ctf-lookup.c (isqualifier): New.
1801         (ctf_lookup_by_name): Likewise.
1802         (struct ctf_lookup_var_key): Likewise.
1803         (ctf_lookup_var): Likewise.
1804         (ctf_lookup_variable): Likewise.
1805         (ctf_lookup_symbol_name): Likewise.
1806         (ctf_lookup_by_symbol): Likewise.
1807         (ctf_func_info): Likewise.
1808         (ctf_func_args): Likewise.
1809
1810 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1811
1812         * ctf-decl.c: New file.
1813         * ctf-types.c: Likewise.
1814         * ctf-impl.h: New declarations.
1815
1816 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1817
1818         * ctf-open-bfd.c: New file.
1819         * ctf-open.c (ctf_close): New.
1820         * ctf-impl.h: Include bfd.h.
1821         (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
1822         (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
1823         ctfi_bfd_close.
1824         (ctf_bfdopen_ctfsect): New declaration.
1825         (_CTF_SECTION): likewise.
1826
1827 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1828
1829         * ctf-archive.c: New.
1830         * ctf-impl.h (ctf_archive_internal): New type.
1831         (ctf_arc_open_internal): New declaration.
1832         (ctf_arc_bufopen): Likewise.
1833         (ctf_arc_close_internal): Likewise.
1834
1835 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1836
1837         * ctf-open.c: New file.
1838         * swap.h: Likewise.
1839
1840 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1841
1842         * ctf-create.c: New file.
1843         * ctf-lookup.c: New file.
1844
1845 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1846
1847         * ctf-impl.h: New definitions and declarations for type creation
1848         and lookup.
1849
1850 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1851
1852         * ctf-hash.c: New file.
1853         * ctf-impl.h: New declarations.
1854
1855 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1856
1857         * ctf-error.c: New file.
1858
1859 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1860
1861         * ctf-util.c: New file.
1862         * elf.h: Likewise.
1863         * ctf-impl.h: Include it, and add declarations.
1864
1865 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
1866
1867         * ctf-impl.h: New file.
1868         * ctf-subr.c: New file.
1869
1870 \f
1871 Local Variables:
1872 mode: change-log
1873 left-margin: 8
1874 fill-column: 76
1875 version-control: never
1876 End: