1 2020-07-04 Nick Clifton <nickc@redhat.com>
3 Binutils 2.35 branch created.
5 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
7 * aclocal.m4: Add config/gettext-sister.m4: Shuffle into
9 * configure.ac: Add ZW_GNU_GETTEXT_SISTER_DIR.
10 * config.h.in: Regenerated.
11 * Makefile.in: Likewise.
12 * configure: Likewise.
14 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
16 * ctf-create.c: Include <unistd.h>.
17 * ctf-open-bfd.c: Likewise.
19 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
22 * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls.
23 * swap.h (bswap_16): Do not assume that presence of <byteswap.h>
24 means this is declared.
27 (bswap_identity_64): Remove, unused.
28 * configure: Regenerated.
29 * config.h.in: Likewise.
31 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
34 * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback.
35 (_libctf_unlikely_): Likewise.
36 (_libctf_unused): Likewise.
37 (_libctf_malloc_): Likewise.
39 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
42 * ctf-archive.c (search_nametbl): No longer global: declare...
43 (ctf_arc_open_by_name_internal): ... here. Use bsearch_r.
44 (search_modent_by_name): Take and use ARG for the nametbl.
46 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
48 * ctf-impl.h (ctf_new_archive_internal): Declare.
49 (ctf_arc_bufopen): Remove.
50 (ctf_archive_internal) <ctfi_free_symsect>: New.
51 * ctf-archive.c (ctf_arc_close): Use it.
52 (ctf_arc_bufopen): Fuse into...
53 (ctf_new_archive_internal): ... this, moved across from...
54 * ctf-open-bfd.c: ... here.
55 (ctf_bfdopen_ctfsect): Use ctf_arc_bufopen.
58 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
60 * ctf-create.c (ctf_add_forward): Intern in the right namespace.
61 (ctf_dtd_delete): Remove correspondingly.
62 (ctf_rollback): Likewise.
64 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
66 * ctf-create.c (ctf_add_type_internal): Hand back existing types
69 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
71 * ctf-create.c (ctf_add_forward): Don't add forwards to
72 types that already exist.
74 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
76 * ctf-open.c (init_types): Only intern root-visible types.
77 * ctf-create.c (ctf_dtd_insert): Likewise.
78 (ctf_dtd_delete): Only remove root-visible types.
79 (ctf_rollback): Likewise.
80 (ctf_add_generic): Adjust.
81 (ctf_add_struct_sized): Adjust comment.
82 (ctf_add_union_sized): Likewise.
83 (ctf_add_enum): Likewise.
84 * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
86 2020-03-11 John Baldwin <jhb@FreeBSD.org>
88 * swap.h (bswap_identity_64): Make static.
90 2020-01-18 Nick Clifton <nickc@redhat.com>
92 Binutils 2.34 branch created.
94 2020-01-05 Joel Brobecker <brobecker@adacore.com>
97 * configure.ac: Add AC_CHECK_DECLS([asprintf]).
98 * configure, config.h.in: Regenerate.
100 2020-01-01 Alan Modra <amodra@gmail.com>
102 Update year range in copyright notice of all files.
104 2019-10-16 Simon Marchi <simon.marchi@polymtl.ca>
106 * swap.h (bswap_16, bswap_32, bswap_64): Make static.
108 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
110 * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
111 * ctf-types.c (ctf_type_lname): Likewise.
113 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
115 * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
116 ctf_import after the first for a given file.
118 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
120 * ctf-impl.h (ctf_str_append_noerr): Declare.
121 * ctf-util.c (ctf_str_append_noerr): Define in terms of
123 * ctf-dump.c (str_append): New, call it.
124 (ctf_dump_format_type): Use str_append, not ctf_str_append.
125 (ctf_dump_label): Likewise.
126 (ctf_dump_objts): Likewise.
127 (ctf_dump_funcs): Likewise.
128 (ctf_dump_var): Likewise.
129 (ctf_dump_member): Likewise.
130 (ctf_dump_type): Likewise.
131 (ctf_dump): Likewise.
133 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
135 * ctf-impl.h (ctf_alloc): Remove.
136 (ctf_free): Likewise.
137 (ctf_strdup): Likewise.
138 * ctf-subr.c (ctf_alloc): Remove.
139 (ctf_free): Likewise.
140 * ctf-util.c (ctf_strdup): Remove.
142 * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
143 ctf_free; strdup, not ctf_strdup.
144 (ctf_dtd_delete): Likewise.
145 (ctf_dvd_delete): Likewise.
146 (ctf_add_generic): Likewise.
147 (ctf_add_function): Likewise.
148 (ctf_add_enumerator): Likewise.
149 (ctf_add_member_offset): Likewise.
150 (ctf_add_variable): Likewise.
152 (ctf_compress_write): Likewise.
153 (ctf_write_mem): Likewise.
154 * ctf-decl.c (ctf_decl_push): Likewise.
155 (ctf_decl_fini): Likewise.
156 (ctf_decl_sprintf): Likewise. Check for OOM.
157 * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
158 ctf_free; strdup, not ctf_strdup.
159 (ctf_dump_free): Likewise.
160 (ctf_dump): Likewise.
161 * ctf-open.c (upgrade_types_v1): Likewise.
162 (init_types): Likewise.
163 (ctf_file_close): Likewise.
164 (ctf_bufopen_internal): Likewise. Check for OOM.
165 (ctf_parent_name_set): Likewise: report the OOM to the caller.
166 (ctf_cuname_set): Likewise.
167 (ctf_import): Likewise.
168 * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
169 free, not ctf_free; strdup, not ctf_strdup.
170 (ctf_str_free_atom): Likewise.
171 (ctf_str_create_atoms): Likewise.
172 (ctf_str_add_ref_internal): Likewise.
173 (ctf_str_remove_ref): Likewise.
174 (ctf_str_write_strtab): Likewise.
176 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
178 * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
179 work right for non-int/fps.
181 2019-08-08 Nick Alcock <nick.alcock@oracle.com>
183 * ctf-types.c (ctf_type_name): Don't strlen a potentially-
186 2019-08-07 Nick Alcock <nick.alcock@oracle.com>
188 * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
189 * ctf-open.c (ctf_file_close): Free it.
190 * ctf-create.c (ctf_serialize): Adjust.
191 (membcmp): When reporting a conflict due to an error, report the
193 (ctf_add_type): Turn into a ctf_add_processing wrapper. Rename to...
194 (ctf_add_type_internal): ... this. Hand back types we are already
195 in the middle of adding immediately. Hand back structs/unions with
196 the same number of members immediately. Do not walk the dynamic
197 list. Call ctf_add_type_internal, not ctf_add_type. Handle
198 forwards promoted to other types and the inverse case identically.
199 Add structs to the mapping as soon as we intern them, before they
202 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
204 * ctf-impl.h (ctf_names_t): New.
205 (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
206 (ctf_file_t) <ctf_structs>: Likewise.
207 <ctf_unions>: Likewise.
208 <ctf_enums>: Likewise.
209 <ctf_names>: Likewise.
210 <ctf_lookups>: Improve comment.
211 <ctf_ptrtab_len>: New.
212 <ctf_prov_strtab>: New.
213 <ctf_str_prov_offset>: New.
214 <ctf_dtbyname>: Remove, redundant to the names hashes.
215 <ctf_dtnextid>: Remove, redundant to ctf_typemax.
216 (ctf_dtdef_t) <dtd_name>: Remove.
217 <dtd_data>: Note that the ctt_name is now populated.
218 (ctf_str_atom_t) <csa_offset>: This is now the strtab
219 offset for internal strings too.
220 <csa_external_offset>: New, the external strtab offset.
221 (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
222 (ctf_name_table): New declaration.
223 (ctf_lookup_by_rawname): Likewise.
224 (ctf_lookup_by_rawhash): Likewise.
225 (ctf_set_ctl_hashes): Likewise.
226 (ctf_serialize): Likewise.
227 (ctf_dtd_insert): Adjust.
228 (ctf_simple_open_internal): Likewise.
229 (ctf_bufopen_internal): Likewise.
230 (ctf_list_empty_p): Likewise.
231 (ctf_str_remove_ref): Likewise.
232 (ctf_str_add): Returns uint32_t now.
233 (ctf_str_add_ref): Likewise.
234 (ctf_str_add_external): Now returns a boolean (int).
235 * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
236 for strings in the appropriate range.
237 (ctf_str_create_atoms): Create the ctf_prov_strtab. Detect OOM
238 when adding the null string to the new strtab.
239 (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
240 (ctf_str_add_ref_internal): Add make_provisional argument. If
241 make_provisional, populate the offset and fill in the
242 ctf_prov_strtab accordingly.
243 (ctf_str_add): Return the offset, not the string.
244 (ctf_str_add_ref): Likewise.
245 (ctf_str_add_external): Return a success integer.
246 (ctf_str_remove_ref): New, remove a single ref.
247 (ctf_str_count_strtab): Do not count the initial null string's
248 length or the existence or length of any unreferenced internal
250 (ctf_str_populate_sorttab): Skip atoms with no refs.
251 (ctf_str_write_strtab): Populate the nullstr earlier. Add one
252 to the cts_len for the null string, since it is no longer done
253 in ctf_str_count_strtab. Adjust for csa_external_offset rename.
254 Populate the csa_offset for both internal and external cases.
255 Flush the ctf_prov_strtab afterwards, and reset the
257 * ctf-create.c (ctf_grow_ptrtab): New.
258 (ctf_create): Call it. Initialize new fields rather than old
259 ones. Tell ctf_bufopen_internal that this is a writable dictionary.
260 Set the ctl hashes and data model.
261 (ctf_update): Rename to...
262 (ctf_serialize): ... this. Leave a compatibility function behind.
263 Tell ctf_simple_open_internal that this is a writable dictionary.
264 Pass the new fields along from the old dictionary. Drop
265 ctf_dtnextid and ctf_dtbyname. Use ctf_strraw, not dtd_name.
266 Do not zero out the DTD's ctt_name.
267 (ctf_prefixed_name): Rename to...
268 (ctf_name_table): ... this. No longer return a prefixed name: return
269 the applicable name table instead.
270 (ctf_dtd_insert): Use it, and use the right name table. Pass in the
271 kind we're adding. Migrate away from dtd_name.
272 (ctf_dtd_delete): Adjust similarly. Remove the ref to the
274 (ctf_dtd_lookup_type_by_name): Remove.
275 (ctf_dynamic_type): Always return NULL on read-only dictionaries.
276 No longer check ctf_dtnextid: check ctf_typemax instead.
277 (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
278 (ctf_rollback): Likewise. No longer fail with ECTF_OVERROLLBACK. Use
279 ctf_name_table and the right name table, and migrate away from
280 dtd_name as in ctf_dtd_delete.
281 (ctf_add_generic): Pass in the kind explicitly and pass it to
282 ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid. Migrate away
283 from dtd_name to using ctf_str_add_ref to populate the ctt_name.
284 Grow the ptrtab if needed.
285 (ctf_add_encoded): Pass in the kind.
286 (ctf_add_slice): Likewise.
287 (ctf_add_array): Likewise.
288 (ctf_add_function): Likewise.
289 (ctf_add_typedef): Likewise.
290 (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
291 ctt_name rather than dtd_name.
292 (ctf_add_struct_sized): Pass in the kind. Use
293 ctf_lookup_by_rawname, not ctf_hash_lookup_type /
294 ctf_dtd_lookup_type_by_name.
295 (ctf_add_union_sized): Likewise.
296 (ctf_add_enum): Likewise.
297 (ctf_add_enum_encoded): Likewise.
298 (ctf_add_forward): Likewise.
299 (ctf_add_type): Likewise.
300 (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
301 being initialized until after the call.
302 (ctf_write_mem): Likewise.
303 (ctf_write): Likewise.
304 * ctf-archive.c (arc_write_one_ctf): Likewise.
305 * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
306 ctf_hash_lookup_type.
307 (ctf_lookup_by_id): No longer check the readonly types if the
308 dictionary is writable.
309 * ctf-open.c (init_types): Assert that this dictionary is not
310 writable. Adjust to use the new name hashes, ctf_name_table,
311 and ctf_ptrtab_len. GNU style fix for the final ptrtab scan.
312 (ctf_bufopen_internal): New 'writable' parameter. Flip on LCTF_RDWR
313 if set. Drop out early when dictionary is writable. Split the
314 ctf_lookups initialization into...
315 (ctf_set_cth_hashes): ... this new function.
316 (ctf_simple_open_internal): Adjust. New 'writable' parameter.
317 (ctf_simple_open): Adjust accordingly.
318 (ctf_bufopen): Likewise.
319 (ctf_file_close): Destroy the appropriate name hashes. No longer
320 destroy ctf_dtbyname, which is gone.
321 (ctf_getdatasect): Remove spurious "extern".
322 * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
323 specified name table, given a kind.
324 (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
325 (ctf_member_iter): Add support for iterating over the
327 (ctf_enum_iter): Likewise.
328 (ctf_variable_iter): Likewise.
329 (ctf_type_rvisit): Likewise.
330 (ctf_member_info): Add support for types in the dynamic type list.
331 (ctf_enum_name): Likewise.
332 (ctf_enum_value): Likewise.
333 (ctf_func_type_info): Likewise.
334 (ctf_func_type_args): Likewise.
335 * ctf-link.c (ctf_accumulate_archive_names): No longer call
337 (ctf_link_write): Likewise.
338 (ctf_link_intern_extern_string): Adjust for new
339 ctf_str_add_external return value.
340 (ctf_link_add_strtab): Likewise.
341 * ctf-util.c (ctf_list_empty_p): New.
343 2019-08-05 Nick Alcock <nick.alcock@oracle.com>
345 * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
347 * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
349 (ctf_add_variable): Likewise for variables pointing to them.
350 * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
351 type link failure, but do warn for others.
352 * ctf-dump.c (ctf_dump_format_type): Likewise. Do not assume all
354 (ctf_dump_member): Likewise.
355 (ctf_dump_type): Likewise.
356 (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
357 (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
358 (ctf_dump_header): Likewise.
359 (ctf_dump_label): likewise.
360 (ctf_dump_objts): likewise.
361 (ctf_dump_funcs): likewise.
362 (ctf_dump_var): likewise.
363 (ctf_dump_str): Likewise.
365 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
367 * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
369 (AM_INSTALL_LIBBFD): Likewise.
370 (dlopen): Note why this is necessary in a comment.
371 (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
373 (SHARED_LDFLAGS): Likewise.
374 (BFD_LIBADD): Likewise, for libbfd.
375 (BFD_DEPENDENCIES): Likewise.
376 (VERSION_FLAGS): Initialize, using a version script if ld supports
377 one, or libtool -export-symbols-regex otherwise.
378 (AC_CONFIG_MACRO_DIR): Add ../BFD.
379 * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
381 (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
382 (noinst_LIBRARIES): Replace with...
383 [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
384 [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
385 libctf-nobfd.la as well.
386 [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
387 [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
388 (libctf_a_SOURCES): Rename to...
389 (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
391 (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
392 with ctf-open-bfd.c added.
393 (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
394 (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
395 (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
396 * Makefile.am [INSTALL_LIBCTF]: Use it.
397 * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
399 * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
400 the unstable components).
401 * Makefile.in: Regenerated.
402 * config.h.in: Likewise.
403 * configure: Likewise.
405 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
407 * configure.ac (INSTALL_LIBCTF): New, controlled by
408 --enable-install-libctf.
409 [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
410 * Makefile.in: Regenerated.
411 * configure: Regenerated.
413 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
415 * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
416 * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
418 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
420 * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
422 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
424 * ctf-impl.h (includes): Include <sys/param.h> here.
426 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
428 * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
429 (flip_objts): Likewise.
430 (flip_vars): Likewise.
431 (flip_types): Likewise.
433 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
435 * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
436 freeing functions: if set, free the key and value if the slot
437 already exists. Always reassign the key.
438 (ctf_dynhash_insert): Adjust call appropriately.
439 (ctf_hash_insert_type): Likewise.
441 2019-08-03 Nick Alcock <nick.alcock@oracle.com>
443 * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
444 type kind. Allow forwards to unify with pre-existing structs/
447 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
449 * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
450 <ctf_link_memb_name_changer>: Likewise.
451 <ctf_link_memb_name_changer_arg>: Likewise.
452 * ctf-create.c (ctf_update): Update accordingly.
453 * ctf-open.c (ctf_file_close): Likewise.
454 * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
455 (ctf_link_add_cu_mapping): New.
456 (ctf_link_set_memb_name_changer): Likewise.
457 (ctf_change_parent_name): New.
458 (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
459 allocated by the caller's ctf_link_memb_name_changer.
460 <ndynames>: Likewise.
461 (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
462 (ctf_link_write): Likewise (for _CTF_SECTION only): also call
463 ctf_change_parent_name. Free any resulting names.
465 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
467 * ctf-link.c (ctf_create_per_cu): New, refactored out of...
468 (ctf_link_one_type): ... here, with parent-name setting added.
469 (check_variable): New.
470 (ctf_link_one_variable): Likewise.
471 (ctf_link_one_input_archive_member): Call it.
472 * ctf-error.c (_ctf_errlist): Updated with new errors.
474 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
476 * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
477 (struct ctf_link_type_mapping_key): New.
478 (ctf_hash_type_mapping_key): Likewise.
479 (ctf_hash_eq_type_mapping_key): Likewise.
480 (ctf_add_type_mapping): Likewise.
481 (ctf_type_mapping): Likewise.
482 (ctf_dynhash_empty): Likewise.
483 * ctf-open.c (ctf_file_close): Update accordingly.
484 * ctf-create.c (ctf_update): Likewise.
485 (ctf_add_type): Populate the mapping.
486 * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
487 (ctf_hash_eq_type_mapping_key): Check the key for equality.
488 (ctf_dynhash_insert): Fix comment typo.
489 (ctf_dynhash_empty): New.
490 * ctf-link.c (ctf_add_type_mapping): New.
491 (ctf_type_mapping): Likewise.
492 (empty_link_type_mapping): New.
493 (ctf_link_one_input_archive): Call it.
495 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
497 * ctf-link.c: New file, linking of the string and type sections.
498 * Makefile.am (libctf_a_SOURCES): Add it.
499 * Makefile.in: Regenerate.
501 * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
503 * ctf-create.c (ctf_update): Update accordingly.
504 * ctf-open.c (ctf_file_close): Likewise.
505 * ctf-error.c (_ctf_errlist): Updated with new errors.
507 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
509 * ctf-dump.c (ctf_dump_funcs): Check the right error value.
511 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
513 * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
515 (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
516 (ctf_dump_format_type): Add non-root-type { } notation.
517 Add root flag to prototype.
518 (ctf_dump_label): Adjust accordingly.
519 (ctf_dump_objts): Likewise.
520 (ctf_dump_var): Likewise.
522 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
524 * ctf-create.c (ctf_compress_write): Fix double-free.
526 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
528 * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
530 (ctf_arc_write_fd): ... this new function.
531 * ctf-create.c (ctf_write_mem): New.
533 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
535 * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
536 (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
537 (ctf_str_add_ref): Name the last arg.
538 (ctf_str_add_external) New.
539 (ctf_str_add_strraw_explicit): Likewise.
540 (ctf_simple_open_internal): Likewise.
541 (ctf_bufopen_internal): Likewise.
543 * ctf-string.c (ctf_strraw_explicit): Split from...
544 (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
545 (ctf_str_add_ref_internal): Return the atom, not the
547 (ctf_str_add): Adjust accordingly.
548 (ctf_str_add_ref): Likewise. Move up in the file.
549 (ctf_str_add_external): New: update the csa_offset.
550 (ctf_str_count_strtab): Only account for strings with no csa_offset
551 in the internal strtab length.
552 (ctf_str_write_strtab): If the csa_offset is set, update the
553 string's refs without writing the string out, and update the
554 ctf_syn_ext_strtab. Make OOM handling less ugly.
555 * ctf-create.c (struct ctf_sort_var_arg_cb): New.
556 (ctf_update): Handle failure to populate the strtab. Pass in the
557 new ctf_sort_var arg. Adjust for ctf_syn_ext_strtab addition.
558 Call ctf_simple_open_internal, not ctf_simple_open.
559 (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
561 * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
562 ctf_strraw). Adjust to diagnose ECTF_STRTAB nonetheless.
563 * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
564 (ctf_file_close): Destroy the ctf_syn_ext_strtab.
565 (ctf_simple_open): Rename to, and reimplement as a wrapper around...
566 (ctf_simple_open_internal): ... this new function, which calls
567 ctf_bufopen_internal.
568 (ctf_bufopen): Rename to, and reimplement as a wrapper around...
569 (ctf_bufopen_internal): ... this new function, which sets
572 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
574 * ctf_types.c (ctf_type_iter_all): New.
576 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
578 * ctf-open.c (init_symtab): Check for overflow against the right
580 (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
581 (upgrade_types_v1): Note that these sections are not checked.
582 (flip_header): Endian-swap the header fields.
583 (flip_ctf): Endian-swap the sections.
584 (flip_objts): Update comment.
585 (ctf_bufopen): Check header offsets and alignment for validity.
587 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
589 * ctf-open-bfd.c: Add <assert.h>.
590 (ctf_bfdopen_ctfsect): Open string and symbol tables using
591 techniques borrowed from bfd_elf_sym_name.
592 (ctf_new_archive_internal): Improve comment.
593 * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
594 * ctf-open.c (ctf_bufopen): Allow opening with a string section but
595 no symbol section, but not vice versa.
597 2019-07-08 Nick Alcock <nick.alcock@oracle.com>
599 * ctf-impl.h (ctf_file_t): New field ctf_openflags.
600 * ctf-open.c (ctf_bufopen): Set it. No longer dump header offsets.
601 * ctf-dump.c (dump_header): New function, dump the CTF header.
603 (ctf_dump_header_strfield): New function.
604 (ctf_dump_header_sectfield): Likewise.
606 2019-07-06 Nick Alcock <nick.alcock@oracle.com>
608 * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
609 ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
610 * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
611 ctf_base: do not assume that it is always sizeof (ctf_header_t).
612 Print out ctf_cuname: only print out ctf_parname if set.
613 (ctf_free_base): Removed, ctf_base is no longer freed: free
615 (ctf_set_version): Fix spacing.
616 (upgrade_header): New, in-place header upgrading.
617 (upgrade_types): Rename to...
618 (upgrade_types_v1): ... this. Free ctf_dynbase, not ctf_base. No
619 longer track old and new headers separately. No longer allow for
620 header sizes explicitly: squeeze the headers out on upgrade (they
621 are preserved in fp->ctf_header). Set ctf_dynbase, ctf_base and
622 ctf_buf explicitly. Use ctf_free, not ctf_free_base.
623 (upgrade_types): New, also handle ctf_parmax updating.
624 (flip_header): Flip ctf_cuname.
625 (flip_types): Flip BUF explicitly rather than deriving BUF from
627 (ctf_bufopen): Store the header in fp->ctf_header. Correct minimum
628 required alignment of objtoff and funcoff. No longer store it in
629 the ctf_buf unless that buf is derived unmodified from the input.
630 Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
631 that duplicate fields in ctf_file: move allocation of ctf_file
632 further up instead. Call upgrade_header as needed. Move
633 version-specific ctf_parmax initialization into upgrade_types. More
634 concise error handling.
635 (ctf_file_close): No longer test for null pointers before freeing.
636 Free ctf_dyncuname, ctf_dynbase, and ctf_header. Do not call
639 (ctf_cuname_set): New.
640 * ctf-create.c (ctf_update): Populate ctf_cuname.
641 (ctf_gzwrite): Write out the header explicitly. Remove obsolescent
643 (ctf_write): Likewise.
644 (ctf_compress_write): Get the header from ctf_header, not ctf_base.
645 Fix the compression length: fp->ctf_size never counted the CTF
646 header. Simplify the compress call accordingly.
648 2019-07-11 Hans-Peter Nilsson <hp@bitrange.com>
650 * ctf-endian.h: Don't assume htole64 and le64toh are always
651 present if HAVE_ENDIAN_H; also check if htole64 is defined.
652 [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
653 not bswap_identity_64.
655 2019-09-18 Alan Modra <amodra@gmail.com>
657 * ctf-open-bfd.c: Update throughout for bfd section macro changes.
659 2019-09-09 Phil Blundell <pb@pbcl.net>
661 binutils 2.33 branch created.
663 2019-07-18 Nick Alcock <nick.alcock@oracle.com>
665 * ctf-types.c (ctf_type_aname_raw): New.
666 (ctf_func_type_info): Likewise.
667 (ctf_func_type_args): Likewise.
668 * ctf-error.c (_ctf_errlist): Fix description.
669 * ctf-lookup.c: Fix file description.
671 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
673 * ctf-create.c (ctf_create): Fix off-by-one error.
675 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
677 * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
679 (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
680 (struct ctf_str_atom): New, disambiguated single string.
681 (struct ctf_str_atom_ref): New, points to some other location that
682 references this string's offset.
683 (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
684 Remove member ctf_dtvstrlen: we no longer track the total strlen
686 (ctf_str_create_atoms): Declare new function in ctf-string.c.
687 (ctf_str_free_atoms): Likewise.
688 (ctf_str_add): Likewise.
689 (ctf_str_add_ref): Likewise.
690 (ctf_str_rollback): Likewise.
691 (ctf_str_purge_refs): Likewise.
692 (ctf_str_write_strtab): Likewise.
693 (ctf_realloc): Declare new function in ctf-util.c.
695 * ctf-open.c (ctf_bufopen): Create the atoms table.
696 (ctf_file_close): Destroy it.
697 * ctf-create.c (ctf_update): Copy-and-free it on update. No longer
698 special-case the position of the parname string. Construct the
699 strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
700 rest of each buffer element is constructed, not via open-coding:
701 realloc the CTF buffer and append the strtab to it. No longer
702 maintain ctf_dtvstrlen. Sort the variable entry table later, after
704 (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
705 (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
706 after buffer element construction instead.
707 (ctf_copy_lmembers): Likewise.
708 (ctf_copy_emembers): Likewise.
709 (ctf_create): No longer maintain the ctf_dtvstrlen.
710 (ctf_dtd_delete): Likewise.
711 (ctf_dvd_delete): Likewise.
712 (ctf_add_generic): Likewise.
713 (ctf_add_enumerator): Likewise.
714 (ctf_add_member_offset): Likewise.
715 (ctf_add_variable): Likewise.
717 * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
718 if there are active ctf_str_num_refs.
719 (ctf_strraw): Move to ctf-string.c.
720 (ctf_strptr): Likewise.
721 * ctf-string.c: New file, strtab manipulation.
723 * Makefile.am (libctf_a_SOURCES): Add it.
724 * Makefile.in: Regenerate.
726 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
728 * ctf-impl.h (ctf_hash_iter_f): New.
729 (ctf_dynhash_iter): New declaration.
730 (ctf_dynhash_iter_remove): New declaration.
731 * ctf-hash.c (ctf_dynhash_iter): Define.
732 (ctf_dynhash_iter_remove): Likewise.
733 (ctf_hashtab_traverse): New.
734 (ctf_hashtab_traverse_remove): Likewise.
735 (struct ctf_traverse_cb_arg): Likewise.
736 (struct ctf_traverse_remove_cb_arg): Likewise.
738 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
740 * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
742 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
744 * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
745 (ctf_dump_funcs): Likewise.
747 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
749 * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
750 (ctf_fdopen): Check for endian-swapped raw CTF magic, and
751 little-endian CTF archive magic. Do not check the CTF version:
752 ctf_simple_open does that in endian-safe ways. Do not dereference
753 null pointers on open failure.
755 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
757 * ctf-open.c (get_vbytes_common): Return the new slice size.
758 (ctf_bufopen): Flip the endianness of the CTF-section header copy.
759 Remember to copy in the CTF data when opening an uncompressed
760 foreign-endian CTF file. Prune useless variable manipulation.
762 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
764 * ctf-open.c (ctf_types): Fail when unidentified type kinds are
767 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
769 * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
772 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
774 * ctf-subr.c (_PAGESIZE): Remove.
775 (ctf_data_alloc): Likewise.
776 (ctf_data_free): Likewise.
777 (ctf_data_protect): Likewise.
778 * ctf-impl.h: Remove declarations.
779 * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
780 ctf_free, not ctf_data_free.
781 (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc. Free
782 the buffer again on compression error.
783 * ctf-open.c (ctf_set_base): No longer track the size: call
784 ctf_free, not ctf_data_free.
785 (upgrade_types): Likewise. Call ctf_alloc, not ctf_data_alloc.
786 (ctf_bufopen): Likewise. No longer call ctf_data_protect.
788 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
790 * ctf-create.c (ctf_dtd_insert): Pass on error returns from
792 (ctf_dvd_insert): Likewise.
793 (ctf_add_generic): Likewise.
794 (ctf_add_variable): Likewise.
795 * ctf-impl.h: Adjust declarations.
797 2019-06-14 Alan Modra <amodra@gmail.com>
799 * configure: Regenerate.
801 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
803 * ctf-decls.h: Include <libiberty.h>.
804 * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
806 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
808 * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
809 (ctf_dump_objts): Likewise.
810 (ctf_dump_funcs): Likewise.
811 (ctf_dump_member): Likewise.
812 (ctf_dump_str): Likewise.
814 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
816 * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
817 * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
819 2019-06-05 Nick Alcock <nick.alcock@oracle.com>
821 * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
822 (ctf_arc_open_by_offset): Likewise.
823 * ctf-create.c (ctf_add_type): Likewise.
825 2019-06-04 Tom Tromey <tromey@adacore.com>
827 * ctf-create.c (ctf_add_encoded, ctf_add_slice)
828 (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
830 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
832 * configure.ac: Check for O_CLOEXEC.
833 * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
834 * config.h.in: Regenerate.
835 * configure: Likewise.
837 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
839 * qsort_r.c: Rename to...
840 * ctf-qsort_r.c: ... this.
841 (_quicksort): Define to ctf_qsort_r.
842 * ctf-decls.h (qsort_r): Remove.
844 (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
845 (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
846 * Makefile.am (libctf_a_LIBADD): Remove.
847 (libctf_a_SOURCES): New, add ctf-qsort_r.c.
848 * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
849 * ctf-create.c (ctf_update): Likewise.
850 * configure.ac: Check for BSD versus GNU qsort_r signature.
851 * Makefile.in: Regenerate.
852 * config.h.in: Likewise.
853 * configure: Likewise.
855 2019-06-03 Nick Alcock <nick.alcock@oracle.com>
857 * ctf-dump.c (ctf_dump_funcs): Free in the right place.
859 2019-05-29 Nick Alcock <nick.alcock@oracle.com>
861 * Makefile.am (ZLIB): New.
863 (AM_CFLAGS): Use them.
864 (libctf_a_LIBADD): New, for LIBOBJS.
865 * configure.ac: Check for zlib, endian.h, and qsort_r.
866 * ctf-endian.h: New, providing htole64 and le64toh.
867 * swap.h: Code style fixes.
868 (bswap_identity_64): New.
869 * qsort_r.c: New, from gnulib (with one added #include).
870 * ctf-decls.h: New, providing a conditional qsort_r declaration,
871 and unconditional definitions of MIN and MAX.
872 * ctf-impl.h: Use it. Do not use <sys/errno.h>.
873 (ctf_set_errno): Now returns unsigned long.
874 * ctf-util.c (ctf_set_errno): Adjust here too.
875 * ctf-archive.c: Use ctf-endian.h.
876 (ctf_arc_open_by_offset): Use memset, not bzero. Drop cts_type,
877 cts_flags and cts_offset.
878 (ctf_arc_write): Drop debugging dependent on the size of off_t.
879 * ctf-create.c: Provide a definition of roundup if not defined.
880 (ctf_create): Drop cts_type, cts_flags and cts_offset.
881 (ctf_add_reftype): Do not check if type IDs are below zero.
882 (ctf_add_slice): Likewise.
883 (ctf_add_typedef): Likewise.
884 (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
885 when known error-free. Drop CTF_ERR usage for functions returning
887 (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
889 (ctf_add_variable): Likewise.
893 (ctf_add_type): Likewise. Cast error-returning ssize_t's to size_t
894 when known error-free.
895 * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
896 returning int: use CTF_ERR for functions returning ctf_type_id.
897 (ctf_dump_label): Likewise.
898 (ctf_dump_objts): Likewise.
899 * ctf-labels.c (ctf_label_topmost): Likewise.
900 (ctf_label_iter): Likewise.
901 (ctf_label_info): Likewise.
902 * ctf-lookup.c (ctf_func_args): Likewise.
903 * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
904 (ctf_bufopen): Likewise. Use zlib types as needed.
905 * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
907 (ctf_enum_iter): Likewise.
908 (ctf_type_size): Likewise.
909 (ctf_type_align): Likewise. Cast to size_t where appropriate.
910 (ctf_type_kind_unsliced): Likewise.
911 (ctf_type_kind): Likewise.
912 (ctf_type_encoding): Likewise.
913 (ctf_member_info): Likewise.
914 (ctf_array_info): Likewise.
915 (ctf_enum_value): Likewise.
916 (ctf_type_rvisit): Likewise.
917 * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
919 (ctf_simple_open): Likewise.
920 (ctf_bfdopen_ctfsect): Likewise. Set cts_size properly.
921 * Makefile.in: Regenerate.
922 * aclocal.m4: Likewise.
923 * config.h: Likewise.
924 * configure: Likewise.
926 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
928 * configure.in: Check for bfd_section_from_elf_index.
929 * configure: Regenerate.
930 * config.h.in [HAVE_BFD_ELF]: Likewise.
931 * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
932 abfd is potentially unused now.
934 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
937 * Makefile.in: Regenerated.
938 * config.h.in: Likewise.
939 * aclocal.m4: Likewise.
940 * configure: Likewise.
942 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
946 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
950 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
952 * ctf-impl.h (_libctf_version): New declaration.
953 * ctf-subr.c (_libctf_version): Define it.
956 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
958 * ctf-create.c (enumcmp): New.
962 (ctf_add_type): Likewise.
964 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
966 * ctf-lookup.c (isqualifier): New.
967 (ctf_lookup_by_name): Likewise.
968 (struct ctf_lookup_var_key): Likewise.
969 (ctf_lookup_var): Likewise.
970 (ctf_lookup_variable): Likewise.
971 (ctf_lookup_symbol_name): Likewise.
972 (ctf_lookup_by_symbol): Likewise.
973 (ctf_func_info): Likewise.
974 (ctf_func_args): Likewise.
976 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
978 * ctf-decl.c: New file.
979 * ctf-types.c: Likewise.
980 * ctf-impl.h: New declarations.
982 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
984 * ctf-open-bfd.c: New file.
985 * ctf-open.c (ctf_close): New.
986 * ctf-impl.h: Include bfd.h.
987 (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
988 (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
990 (ctf_bfdopen_ctfsect): New declaration.
991 (_CTF_SECTION): likewise.
993 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
995 * ctf-archive.c: New.
996 * ctf-impl.h (ctf_archive_internal): New type.
997 (ctf_arc_open_internal): New declaration.
998 (ctf_arc_bufopen): Likewise.
999 (ctf_arc_close_internal): Likewise.
1001 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1003 * ctf-open.c: New file.
1006 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1008 * ctf-create.c: New file.
1009 * ctf-lookup.c: New file.
1011 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1013 * ctf-impl.h: New definitions and declarations for type creation
1016 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1018 * ctf-hash.c: New file.
1019 * ctf-impl.h: New declarations.
1021 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1023 * ctf-error.c: New file.
1025 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1027 * ctf-util.c: New file.
1029 * ctf-impl.h: Include it, and add declarations.
1031 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1033 * ctf-impl.h: New file.
1034 * ctf-subr.c: New file.
1041 version-control: never