PR25172, Wrong description of --stop-address=ADDR switch

[deliverable/binutils-gdb.git] / bfd / coffgen.c

diff --git a/bfd/coffgen.c b/bfd/coffgen.c
index 7f2d18107ba22d94e42de144897b4ca15c9001d7..ba7bb5eaf42573668eedb8289816e721a129d928 100644 (file)
--- a/bfd/coffgen.c
+++ b/bfd/coffgen.c
@@ -1,5 +1,5 @@
 /* Support for the generic parts of COFF, for BFD.
 /* Support for the generic parts of COFF, for BFD.

-   Copyright (C) 1990-2018 Free Software Foundation, Inc.
+   Copyright (C) 1990-2019 Free Software Foundation, Inc.

    Written by Cygnus Support.
 
    This file is part of BFD, the Binary File Descriptor library.
    Written by Cygnus Support.
 
    This file is part of BFD, the Binary File Descriptor library.


@@ -37,6 +37,7 @@
    coff_data (abfd).  */
 
 #include "sysdep.h"
    coff_data (abfd).  */
 
 #include "sysdep.h"

+#include <limits.h>

 #include "bfd.h"
 #include "libbfd.h"
 #include "coff/internal.h"
 #include "bfd.h"
 #include "libbfd.h"
 #include "coff/internal.h"


@@ -216,7 +217,7 @@ make_a_section_from_file (bfd *abfd,
          break;
        }
       if (new_name != NULL)
          break;
        }
       if (new_name != NULL)

-       bfd_rename_section (abfd, return_section, new_name);
+       bfd_rename_section (return_section, new_name);

     }
 
   return result;
     }
 
   return result;


@@ -256,14 +257,14 @@ coff_real_object_p (bfd *abfd,
   if ((internal_f->f_flags & F_EXEC) != 0)
     abfd->flags |= D_PAGED;
 
   if ((internal_f->f_flags & F_EXEC) != 0)
     abfd->flags |= D_PAGED;
 

-  bfd_get_symcount (abfd) = internal_f->f_nsyms;
+  abfd->symcount = internal_f->f_nsyms;

   if (internal_f->f_nsyms)
     abfd->flags |= HAS_SYMS;
 
   if (internal_a != (struct internal_aouthdr *) NULL)
   if (internal_f->f_nsyms)
     abfd->flags |= HAS_SYMS;
 
   if (internal_a != (struct internal_aouthdr *) NULL)

-    bfd_get_start_address (abfd) = internal_a->entry;
+    abfd->start_address = internal_a->entry;

   else
   else

-    bfd_get_start_address (abfd) = 0;
+    abfd->start_address = 0;

 
   /* Set up the tdata area.  ECOFF uses its own routine, and overrides
      abfd->flags.  */
 
   /* Set up the tdata area.  ECOFF uses its own routine, and overrides
      abfd->flags.  */


@@ -308,7 +309,7 @@ coff_real_object_p (bfd *abfd,
  fail2:
   abfd->tdata.any = tdata_save;
   abfd->flags = oflags;
  fail2:
   abfd->tdata.any = tdata_save;
   abfd->flags = oflags;

-  bfd_get_start_address (abfd) = ostart;
+  abfd->start_address = ostart;

   return (const bfd_target *) NULL;
 }
 
   return (const bfd_target *) NULL;
 }
 


@@ -1521,7 +1522,8 @@ coff_pointerize_aux (bfd *abfd,
                     combined_entry_type *table_base,
                     combined_entry_type *symbol,
                     unsigned int indaux,
                     combined_entry_type *table_base,
                     combined_entry_type *symbol,
                     unsigned int indaux,

-                    combined_entry_type *auxent)
+                    combined_entry_type *auxent,
+                    combined_entry_type *table_end)

 {
   unsigned int type = symbol->u.syment.n_type;
   unsigned int n_sclass = symbol->u.syment.n_sclass;
 {
   unsigned int type = symbol->u.syment.n_type;
   unsigned int n_sclass = symbol->u.syment.n_sclass;


@@ -1547,16 +1549,22 @@ coff_pointerize_aux (bfd *abfd,
 
   if ((ISFCN (type) || ISTAG (n_sclass) || n_sclass == C_BLOCK
        || n_sclass == C_FCN)
 
   if ((ISFCN (type) || ISTAG (n_sclass) || n_sclass == C_BLOCK
        || n_sclass == C_FCN)

-      && auxent->u.auxent.x_sym.x_fcnary.x_fcn.x_endndx.l > 0)
+      && auxent->u.auxent.x_sym.x_fcnary.x_fcn.x_endndx.l > 0
+      && auxent->u.auxent.x_sym.x_fcnary.x_fcn.x_endndx.l
+      < (long) obj_raw_syment_count (abfd)
+      && table_base + auxent->u.auxent.x_sym.x_fcnary.x_fcn.x_endndx.l
+      < table_end)

     {
       auxent->u.auxent.x_sym.x_fcnary.x_fcn.x_endndx.p =
        table_base + auxent->u.auxent.x_sym.x_fcnary.x_fcn.x_endndx.l;
       auxent->fix_end = 1;
     }
     {
       auxent->u.auxent.x_sym.x_fcnary.x_fcn.x_endndx.p =
        table_base + auxent->u.auxent.x_sym.x_fcnary.x_fcn.x_endndx.l;
       auxent->fix_end = 1;
     }

+

   /* A negative tagndx is meaningless, but the SCO 3.2v4 cc can
      generate one, so we must be careful to ignore it.  */
   if ((unsigned long) auxent->u.auxent.x_sym.x_tagndx.l
   /* A negative tagndx is meaningless, but the SCO 3.2v4 cc can
      generate one, so we must be careful to ignore it.  */
   if ((unsigned long) auxent->u.auxent.x_sym.x_tagndx.l

-      < obj_raw_syment_count (abfd))
+      < obj_raw_syment_count (abfd)
+      && table_base + auxent->u.auxent.x_sym.x_tagndx.l < table_end)

     {
       auxent->u.auxent.x_sym.x_tagndx.p =
        table_base + auxent->u.auxent.x_sym.x_tagndx.l;
     {
       auxent->u.auxent.x_sym.x_tagndx.p =
        table_base + auxent->u.auxent.x_sym.x_tagndx.l;


@@ -1647,8 +1655,8 @@ _bfd_coff_get_external_symbols (bfd *abfd)
          && size > bfd_get_file_size (abfd)))
 
     {
          && size > bfd_get_file_size (abfd)))
 
     {

-      _bfd_error_handler (_("%pB: corrupt symbol count: %#Lx"),
-                         abfd, obj_raw_syment_count (abfd));
+      _bfd_error_handler (_("%pB: corrupt symbol count: %#" PRIx64 ""),
+                         abfd, (uint64_t) obj_raw_syment_count (abfd));

       return FALSE;
     }
 
       return FALSE;
     }
 


@@ -1656,8 +1664,10 @@ _bfd_coff_get_external_symbols (bfd *abfd)
   if (syms == NULL)
     {
       /* PR 21013: Provide an error message when the alloc fails.  */
   if (syms == NULL)
     {
       /* PR 21013: Provide an error message when the alloc fails.  */

-      _bfd_error_handler (_("%pB: not enough memory to allocate space for %#Lx symbols of size %#Lx"),
-                         abfd, obj_raw_syment_count (abfd), symesz);
+      _bfd_error_handler (_("%pB: not enough memory to allocate space "
+                           "for %#" PRIx64 " symbols of size %#" PRIx64),
+                         abfd, (uint64_t) obj_raw_syment_count (abfd),
+                         (uint64_t) symesz);

       return FALSE;
     }
 
       return FALSE;
     }
 


@@ -1723,7 +1733,7 @@ _bfd_coff_read_string_table (bfd *abfd)
     {
       _bfd_error_handler
        /* xgettext: c-format */
     {
       _bfd_error_handler
        /* xgettext: c-format */

-       (_("%pB: bad string table size %Lu"), abfd, strsize);
+       (_("%pB: bad string table size %" PRIu64), abfd, (uint64_t) strsize);

       bfd_set_error (bfd_error_bad_value);
       return NULL;
     }
       bfd_set_error (bfd_error_bad_value);
       return NULL;
     }


@@ -1865,7 +1875,7 @@ coff_get_normalized_symtab (bfd *abfd)
 
          internal_ptr->is_sym = FALSE;
          coff_pointerize_aux (abfd, internal, symbol_ptr, i,
 
          internal_ptr->is_sym = FALSE;
          coff_pointerize_aux (abfd, internal, symbol_ptr, i,

-                              internal_ptr);
+                              internal_ptr, internal_end);

        }
     }
 
        }
     }
 


@@ -2005,6 +2015,13 @@ coff_get_reloc_upper_bound (bfd *abfd, sec_ptr asect)
       bfd_set_error (bfd_error_invalid_operation);
       return -1;
     }
       bfd_set_error (bfd_error_invalid_operation);
       return -1;
     }

+#if SIZEOF_LONG == SIZEOF_INT
+  if (asect->reloc_count >= LONG_MAX / sizeof (arelent *))
+    {
+      bfd_set_error (bfd_error_file_too_big);
+      return -1;
+    }
+#endif

   return (asect->reloc_count + 1) * sizeof (arelent *);
 }
 
   return (asect->reloc_count + 1) * sizeof (arelent *);
 }
 


@@ -2273,7 +2290,7 @@ coff_find_nearest_line_with_names (bfd *abfd,
   /* Also try examining DWARF2 debugging information.  */
   if (_bfd_dwarf2_find_nearest_line (abfd, symbols, NULL, section, offset,
                                     filename_ptr, functionname_ptr,
   /* Also try examining DWARF2 debugging information.  */
   if (_bfd_dwarf2_find_nearest_line (abfd, symbols, NULL, section, offset,
                                     filename_ptr, functionname_ptr,

-                                    line_ptr, NULL, debug_sections, 0,
+                                    line_ptr, NULL, debug_sections,

                                     &coff_data(abfd)->dwarf2_find_line_info))
     return TRUE;
 
                                     &coff_data(abfd)->dwarf2_find_line_info))
     return TRUE;
 


@@ -2285,7 +2302,7 @@ coff_find_nearest_line_with_names (bfd *abfd,
      information.  So try again, using a bias against the address sought.  */
   if (coff_data (abfd)->dwarf2_find_line_info != NULL)
     {
      information.  So try again, using a bias against the address sought.  */
   if (coff_data (abfd)->dwarf2_find_line_info != NULL)
     {

-      bfd_signed_vma bias;
+      bfd_signed_vma bias = 0;

 
       /* Create a cache of the result for the next call.  */
       if (sec_data == NULL && section->owner == abfd)
 
       /* Create a cache of the result for the next call.  */
       if (sec_data == NULL && section->owner == abfd)


@@ -2297,10 +2314,11 @@ coff_find_nearest_line_with_names (bfd *abfd,
 
       if (sec_data != NULL && sec_data->saved_bias)
        bias = sec_data->saved_bias;
 
       if (sec_data != NULL && sec_data->saved_bias)
        bias = sec_data->saved_bias;

-      else
+      else if (symbols)

        {
          bias = _bfd_dwarf2_find_symbol_bias (symbols,
                                               & coff_data (abfd)->dwarf2_find_line_info);
        {
          bias = _bfd_dwarf2_find_symbol_bias (symbols,
                                               & coff_data (abfd)->dwarf2_find_line_info);

+

          if (sec_data)
            {
              sec_data->saved_bias = TRUE;
          if (sec_data)
            {
              sec_data->saved_bias = TRUE;


@@ -2312,7 +2330,7 @@ coff_find_nearest_line_with_names (bfd *abfd,
          && _bfd_dwarf2_find_nearest_line (abfd, symbols, NULL, section,
                                            offset + bias,
                                            filename_ptr, functionname_ptr,
          && _bfd_dwarf2_find_nearest_line (abfd, symbols, NULL, section,
                                            offset + bias,
                                            filename_ptr, functionname_ptr,

-                                           line_ptr, NULL, debug_sections, 0,
+                                           line_ptr, NULL, debug_sections,

                                            &coff_data(abfd)->dwarf2_find_line_info))
        return TRUE;
     }
                                            &coff_data(abfd)->dwarf2_find_line_info))
        return TRUE;
     }


@@ -2348,7 +2366,7 @@ coff_find_nearest_line_with_names (bfd *abfd,
       bfd_vma maxdiff;
 
       /* Look through the C_FILE symbols to find the best one.  */
       bfd_vma maxdiff;
 
       /* Look through the C_FILE symbols to find the best one.  */

-      sec_vma = bfd_get_section_vma (abfd, section);
+      sec_vma = bfd_section_vma (section);

       *filename_ptr = (char *) p->u.syment._n._n_n._n_offset;
       maxdiff = (bfd_vma) 0 - (bfd_vma) 1;
       while (1)
       *filename_ptr = (char *) p->u.syment._n._n_n._n_offset;
       maxdiff = (bfd_vma) 0 - (bfd_vma) 1;
       while (1)


@@ -2629,6 +2647,9 @@ _bfd_coff_section_already_linked (bfd *abfd,
   struct bfd_section_already_linked_hash_entry *already_linked_list;
   struct coff_comdat_info *s_comdat;
 
   struct bfd_section_already_linked_hash_entry *already_linked_list;
   struct coff_comdat_info *s_comdat;
 

+  if (sec->output_section == bfd_abs_section_ptr)
+    return FALSE;
+

   flags = sec->flags;
   if ((flags & SEC_LINK_ONCE) == 0)
     return FALSE;
   flags = sec->flags;
   if ((flags & SEC_LINK_ONCE) == 0)
     return FALSE;


@@ -2637,7 +2658,7 @@ _bfd_coff_section_already_linked (bfd *abfd,
   if ((flags & SEC_GROUP) != 0)
     return FALSE;
 
   if ((flags & SEC_GROUP) != 0)
     return FALSE;
 

-  name = bfd_get_section_name (abfd, sec);
+  name = bfd_section_name (sec);

   s_comdat = bfd_coff_get_comdat_section (abfd, sec);
 
   if (s_comdat != NULL)
   s_comdat = bfd_coff_get_comdat_section (abfd, sec);
 
   if (s_comdat != NULL)


@@ -3022,7 +3043,7 @@ coff_gc_sweep (bfd *abfd ATTRIBUTE_UNUSED, struct bfd_link_info *info)
 
          if (info->print_gc_sections && o->size != 0)
            /* xgettext: c-format */
 
          if (info->print_gc_sections && o->size != 0)
            /* xgettext: c-format */

-           _bfd_error_handler (_("Removing unused section '%pA' in file '%pB'"),
+           _bfd_error_handler (_("removing unused section '%pA' in file '%pB'"),

                                o, sub);
 
 #if 0
                                o, sub);
 
 #if 0


@@ -3099,7 +3120,7 @@ bfd_coff_gc_sections (bfd *abfd ATTRIBUTE_UNUSED, struct bfd_link_info *info)
   if (!bed->can_gc_sections
       || !is_coff_hash_table (info->hash))
     {
   if (!bed->can_gc_sections
       || !is_coff_hash_table (info->hash))
     {

-      _bfd_error_handler(_("Warning: gc-sections option ignored"));
+      _bfd_error_handler(_("warning: gc-sections option ignored"));

       return TRUE;
     }
 #endif
       return TRUE;
     }
 #endif


@@ -3134,3 +3155,14 @@ bfd_coff_gc_sections (bfd *abfd ATTRIBUTE_UNUSED, struct bfd_link_info *info)
   /* ... and mark SEC_EXCLUDE for those that go.  */
   return coff_gc_sweep (abfd, info);
 }
   /* ... and mark SEC_EXCLUDE for those that go.  */
   return coff_gc_sweep (abfd, info);
 }

+
+/* Return name used to identify a comdat group.  */
+
+const char *
+bfd_coff_group_name (bfd *abfd, const asection *sec)
+{
+  struct coff_comdat_info *ci = bfd_coff_get_comdat_section (abfd, sec);
+  if (ci != NULL)
+    return ci->name;
+  return NULL;
+}