binutils: Make DWARF register name lookup be via a function pointer

[deliverable/binutils-gdb.git] / binutils / windres.c

diff --git a/binutils/windres.c b/binutils/windres.c
index 05615c432c59a528fe61ff432259528c46a38188..9132fa8e97c0864cc63bf89e2c769fbd6f0cb0b1 100644 (file)
--- a/binutils/windres.c
+++ b/binutils/windres.c
@@ -1,6 +1,5 @@
 /* windres.c -- a program to manipulate Windows resources
 /* windres.c -- a program to manipulate Windows resources

-   Copyright 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004, 2005, 2007
-   Free Software Foundation, Inc.
+   Copyright (C) 1997-2019 Free Software Foundation, Inc.

    Written by Ian Lance Taylor, Cygnus Support.
    Rewritten by Kai Tietz, Onevision.
 
    Written by Ian Lance Taylor, Cygnus Support.
    Rewritten by Kai Tietz, Onevision.
 


@@ -8,7 +7,7 @@
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by

-   the Free Software Foundation; either version 2 of the License, or
+   the Free Software Foundation; either version 3 of the License, or

    (at your option) any later version.
 
    This program is distributed in the hope that it will be useful,
    (at your option) any later version.
 
    This program is distributed in the hope that it will be useful,


@@ -37,7 +36,6 @@
 
 #include "sysdep.h"
 #include <assert.h>
 
 #include "sysdep.h"
 #include <assert.h>

-#include <time.h>

 #include "bfd.h"
 #include "getopt.h"
 #include "bucomm.h"
 #include "bfd.h"
 #include "getopt.h"
 #include "bucomm.h"


@@ -46,11 +44,6 @@
 #include "obstack.h"
 #include "windres.h"
 
 #include "obstack.h"
 #include "windres.h"
 

-/* Defined in bfd/binary.c.  Used to set architecture and machine of input
-   binary files.  */
-extern enum bfd_architecture  bfd_external_binary_architecture;
-extern unsigned long          bfd_external_machine;
-

 /* Used by resrc.c at least.  */
 
 int verbose = 0;
 /* Used by resrc.c at least.  */
 
 int verbose = 0;


@@ -58,7 +51,7 @@ int verbose = 0;
 int target_is_bigendian = 0;
 const char *def_target_arch;
 
 int target_is_bigendian = 0;
 const char *def_target_arch;
 

-static void set_endianess (bfd *, const char *);
+static void set_endianness (bfd *, const char *);

 
 /* An enumeration of format types.  */
 
 
 /* An enumeration of format types.  */
 


@@ -157,7 +150,7 @@ res_init (void)
 void *
 res_alloc (rc_uint_type bytes)
 {
 void *
 res_alloc (rc_uint_type bytes)
 {

-  return (void *) obstack_alloc (&res_obstack, (size_t) bytes);
+  return obstack_alloc (&res_obstack, (size_t) bytes);

 }
 
 /* We also use an obstack to save memory used while writing out a set
 }
 
 /* We also use an obstack to save memory used while writing out a set


@@ -178,7 +171,7 @@ reswr_init (void)
 void *
 reswr_alloc (rc_uint_type bytes)
 {
 void *
 reswr_alloc (rc_uint_type bytes)
 {

-  return (void *) obstack_alloc (&reswr_obstack, (size_t) bytes);
+  return obstack_alloc (&reswr_obstack, (size_t) bytes);

 }
 \f
 /* Open a file using the include directory search list.  */
 }
 \f
 /* Open a file using the include directory search list.  */


@@ -211,6 +204,7 @@ open_file_search (const char *filename, const char *mode, const char *errmsg,
              *real_filename = n;
              return e;
            }
              *real_filename = n;
              return e;
            }

+         free (n);

 
          if (errno != ENOENT)
            break;
 
          if (errno != ENOENT)
            break;


@@ -344,17 +338,12 @@ define_resource (rc_res_directory **resources, int cids,
 
       if (*resources == NULL)
        {
 
       if (*resources == NULL)
        {

-         static unsigned int timeval;
-
-         /* Use the same timestamp for every resource created in a
-             single run.  */
-         if (timeval == 0)
-           timeval = time (NULL);
-

          *resources = ((rc_res_directory *)
                        res_alloc (sizeof (rc_res_directory)));
          (*resources)->characteristics = 0;
          *resources = ((rc_res_directory *)
                        res_alloc (sizeof (rc_res_directory)));
          (*resources)->characteristics = 0;

-         (*resources)->time = timeval;
+         /* Using a real timestamp only serves to create non-deterministic
+            results.  Use zero instead.  */
+         (*resources)->time = 0;

          (*resources)->major = 0;
          (*resources)->minor = 0;
          (*resources)->entries = NULL;
          (*resources)->major = 0;
          (*resources)->minor = 0;
          (*resources)->entries = NULL;


@@ -669,6 +658,7 @@ usage (FILE *stream, int status)
   -O --output-format=<format>  Specify output format\n\
   -F --target=<target>         Specify COFF target\n\
      --preprocessor=<program>  Program to use to preprocess rc file\n\
   -O --output-format=<format>  Specify output format\n\
   -F --target=<target>         Specify COFF target\n\
      --preprocessor=<program>  Program to use to preprocess rc file\n\

+     --preprocessor-arg=<arg>  Additional preprocessor argument\n\

   -I --include-dir=<dir>       Include directory when preprocessing rc file\n\
   -D --define <sym>[=<val>]    Define SYM when preprocessing rc file\n\
   -U --undefine <sym>          Undefine SYM when preprocessing rc file\n\
   -I --include-dir=<dir>       Include directory when preprocessing rc file\n\
   -D --define <sym>[=<val>]    Define SYM when preprocessing rc file\n\
   -U --undefine <sym>          Undefine SYM when preprocessing rc file\n\


@@ -731,12 +721,16 @@ quot (const char *string)
 
 /* Long options.  */
 
 
 /* Long options.  */
 

-/* 150 isn't special; it's just an arbitrary non-ASCII char value.  */
-
-#define OPTION_PREPROCESSOR    150
-#define OPTION_USE_TEMP_FILE   (OPTION_PREPROCESSOR + 1)
-#define OPTION_NO_USE_TEMP_FILE        (OPTION_USE_TEMP_FILE + 1)
-#define OPTION_YYDEBUG         (OPTION_NO_USE_TEMP_FILE + 1)
+enum option_values
+{
+  /* 150 isn't special; it's just an arbitrary non-ASCII char value.  */
+  OPTION_PREPROCESSOR  = 150,
+  OPTION_USE_TEMP_FILE,
+  OPTION_NO_USE_TEMP_FILE,
+  OPTION_YYDEBUG,
+  OPTION_INCLUDE_DIR,
+  OPTION_PREPROCESSOR_ARG
+};

 
 static const struct option long_options[] =
 {
 
 static const struct option long_options[] =
 {


@@ -746,7 +740,8 @@ static const struct option long_options[] =
   {"output-format", required_argument, 0, 'O'},
   {"target", required_argument, 0, 'F'},
   {"preprocessor", required_argument, 0, OPTION_PREPROCESSOR},
   {"output-format", required_argument, 0, 'O'},
   {"target", required_argument, 0, 'F'},
   {"preprocessor", required_argument, 0, OPTION_PREPROCESSOR},

-  {"include-dir", required_argument, 0, 'I'},
+  {"preprocessor-arg", required_argument, 0, OPTION_PREPROCESSOR_ARG},
+  {"include-dir", required_argument, 0, OPTION_INCLUDE_DIR},

   {"define", required_argument, 0, 'D'},
   {"undefine", required_argument, 0, 'U'},
   {"verbose", no_argument, 0, 'v'},
   {"define", required_argument, 0, 'D'},
   {"undefine", required_argument, 0, 'U'},
   {"verbose", no_argument, 0, 'v'},


@@ -765,6 +760,12 @@ windres_add_include_dir (const char *p)
 {
   struct include_dir *n, **pp;
 
 {
   struct include_dir *n, **pp;
 

+  /* Computing paths is often complicated and error prone.
+     The easiest way to check for mistakes is at the time
+     we add them to include_dirs.  */
+  assert (p != NULL);
+  assert (*p != '\0');
+

   n = xmalloc (sizeof *n);
   n->next = NULL;
   n->dir = (char * ) p;
   n = xmalloc (sizeof *n);
   n->next = NULL;
   n->dir = (char * ) p;


@@ -807,10 +808,12 @@ main (int argc, char **argv)
 
   program_name = argv[0];
   xmalloc_set_program_name (program_name);
 
   program_name = argv[0];
   xmalloc_set_program_name (program_name);

+  bfd_set_error_program_name (program_name);

 
   expandargv (&argc, &argv);
 
 
   expandargv (&argc, &argv);
 

-  bfd_init ();
+  if (bfd_init () != BFD_INIT_MAGIC)
+    fatal (_("fatal error: libbfd ABI mismatch"));

   set_default_bfd_target ();
 
   res_init ();
   set_default_bfd_target ();
 
   res_init ();


@@ -884,6 +887,24 @@ main (int argc, char **argv)
          preprocessor = optarg;
          break;
 
          preprocessor = optarg;
          break;
 

+       case OPTION_PREPROCESSOR_ARG:
+         if (preprocargs == NULL)
+           {
+             quotedarg = quot (optarg);
+             preprocargs = xstrdup (quotedarg);
+           }
+         else
+           {
+             char *n;
+
+             quotedarg = quot (optarg);
+             n = xmalloc (strlen (preprocargs) + strlen (quotedarg) + 2);
+             sprintf (n, "%s %s", preprocargs, quotedarg);
+             free (preprocargs);
+             preprocargs = n;
+           }
+         break;
+

        case 'D':
        case 'U':
          if (preprocargs == NULL)
        case 'D':
        case 'U':
          if (preprocargs == NULL)


@@ -917,12 +938,27 @@ main (int argc, char **argv)
          input_format_tmp = format_from_name (optarg, 0);
          if (input_format_tmp != RES_FORMAT_UNKNOWN)
            {
          input_format_tmp = format_from_name (optarg, 0);
          if (input_format_tmp != RES_FORMAT_UNKNOWN)
            {

-             fprintf (stderr,
-                      _("Option -I is deprecated for setting the input format, please use -J instead.\n"));
-             input_format = input_format_tmp;
-             break;
+             struct stat statbuf;
+             char modebuf[11];
+
+             if (stat (optarg, & statbuf) == 0
+                 /* Coded this way to avoid importing knowledge of S_ISDIR into this file.  */
+                 && (mode_string (statbuf.st_mode, modebuf), modebuf[0] == 'd'))
+               /* We have a -I option with a directory name that just happens
+                  to match a format name as well.  eg: -I res  Assume that the
+                  user knows what they are doing and do not complain.  */
+               ;
+             else
+               {
+                 fprintf (stderr,
+                          _("Option -I is deprecated for setting the input format, please use -J instead.\n"));
+                 input_format = input_format_tmp;
+                 break;
+               }

            }
            }

+         /* Fall through.  */

 
 

+       case OPTION_INCLUDE_DIR:

          if (preprocargs == NULL)
            {
              quotedarg = quot (optarg);
          if (preprocargs == NULL)
            {
              quotedarg = quot (optarg);


@@ -1008,7 +1044,7 @@ main (int argc, char **argv)
        output_format = format_from_filename (output_filename, 0);
     }
 
        output_format = format_from_filename (output_filename, 0);
     }
 

-  set_endianess (NULL, target);
+  set_endianness (NULL, target);

 
   /* Read the input file.  */
   switch (input_format)
 
   /* Read the input file.  */
   switch (input_format)


@@ -1056,38 +1092,18 @@ main (int argc, char **argv)
   return 0;
 }
 
   return 0;
 }
 

-static void set_endianess (bfd *abfd, const char *target)
+static void
+set_endianness (bfd *abfd, const char *target)

 {
   const bfd_target *target_vec;
 
   def_target_arch = NULL;
 {
   const bfd_target *target_vec;
 
   def_target_arch = NULL;

-  target_vec = bfd_find_target (target, abfd);
+  target_vec = bfd_get_target_info (target, abfd, &target_is_bigendian, NULL,
+                                   &def_target_arch);

   if (! target_vec)
   if (! target_vec)

-    fatal ("Can't detect target endianess and architecture.");
-  target_is_bigendian = ((target_vec->byteorder == BFD_ENDIAN_BIG) ? 1 : 0);
-  {
-    const char *tname = target_vec->name;
-    const char **arch = bfd_arch_list();
-    if (arch && tname)
-      {
-       if (strchr (tname, '-') != NULL)
-         tname = strchr (tname, '-') + 1;
-       while (*arch != NULL)
-         {
-           const char *in_a = strstr (*arch, tname);
-           char end_ch = (in_a ? in_a[strlen(tname)] : 0);
-           if (in_a && (in_a == *arch || in_a[-1] == ':')
-               && end_ch == 0)
-             {
-               def_target_arch = *arch;
-               break;
-             }
-           arch++;
-         }
-      }
-    if (! def_target_arch)
-      fatal ("Can't detect architecture.");
-  }
+    fatal ("Can't detect target endianness and architecture.");
+  if (! def_target_arch)
+    fatal ("Can't detect architecture.");

 }
 
 bfd *
 }
 
 bfd *


@@ -1101,12 +1117,12 @@ windres_open_as_binary (const char *filename, int rdmode)
 
   if (rdmode && ! bfd_check_format (abfd, bfd_object))
     fatal ("can't open `%s' for input.", filename);
 
   if (rdmode && ! bfd_check_format (abfd, bfd_object))
     fatal ("can't open `%s' for input.", filename);

-  
+

   return abfd;
 }
 
 void
   return abfd;
 }
 
 void

-set_windres_bfd_endianess (windres_bfd *wrbfd, int is_bigendian)
+set_windres_bfd_endianness (windres_bfd *wrbfd, int is_bigendian)

 {
   assert (!! wrbfd);
   switch (WR_KIND(wrbfd))
 {
   assert (!! wrbfd);
   switch (WR_KIND(wrbfd))


@@ -1150,8 +1166,8 @@ set_windres_bfd (windres_bfd *wrbfd, bfd *abfd, asection *sec, rc_uint_type kind
 }
 
 void
 }
 
 void

-set_windres_bfd_content(windres_bfd *wrbfd, const void *data, rc_uint_type off,
-                       rc_uint_type length)
+set_windres_bfd_content (windres_bfd *wrbfd, const void *data, rc_uint_type off,
+                        rc_uint_type length)

 {
   if (WR_KIND(wrbfd) != WR_KIND_TARGET)
     {
 {
   if (WR_KIND(wrbfd) != WR_KIND_TARGET)
     {


@@ -1163,8 +1179,8 @@ set_windres_bfd_content(windres_bfd *wrbfd, const void *data, rc_uint_type off,
 }
 
 void
 }
 
 void

-get_windres_bfd_content(windres_bfd *wrbfd, void *data, rc_uint_type off,
-                       rc_uint_type length)
+get_windres_bfd_content (windres_bfd *wrbfd, void *data, rc_uint_type off,
+                        rc_uint_type length)

 {
   if (WR_KIND(wrbfd) != WR_KIND_TARGET)
     {
 {
   if (WR_KIND(wrbfd) != WR_KIND_TARGET)
     {


@@ -1296,7 +1312,7 @@ static rc_uint_type
 target_get_8 (const void *p, rc_uint_type length)
 {
   rc_uint_type ret;
 target_get_8 (const void *p, rc_uint_type length)
 {
   rc_uint_type ret;

-  
+

   if (length < 1)
     fatal ("Resource too small for getting 8-bit value.");
 
   if (length < 1)
     fatal ("Resource too small for getting 8-bit value.");
 


@@ -1309,7 +1325,7 @@ target_get_16 (const void *p, rc_uint_type length)
 {
   if (length < 2)
     fatal ("Resource too small for getting 16-bit value.");
 {
   if (length < 2)
     fatal ("Resource too small for getting 16-bit value.");

-  
+

   if (target_is_bigendian)
     return bfd_getb16 (p);
   else
   if (target_is_bigendian)
     return bfd_getb16 (p);
   else


@@ -1321,7 +1337,7 @@ target_get_32 (const void *p, rc_uint_type length)
 {
   if (length < 4)
     fatal ("Resource too small for getting 32-bit value.");
 {
   if (length < 4)
     fatal ("Resource too small for getting 32-bit value.");

-  
+

   if (target_is_bigendian)
     return bfd_getb32 (p);
   else
   if (target_is_bigendian)
     return bfd_getb32 (p);
   else


@@ -1339,7 +1355,7 @@ static void
 target_put_16 (void *p, rc_uint_type value)
 {
   assert (!! p);
 target_put_16 (void *p, rc_uint_type value)
 {
   assert (!! p);

-  
+

   if (target_is_bigendian)
     bfd_putb16 (value, p);
   else
   if (target_is_bigendian)
     bfd_putb16 (value, p);
   else


@@ -1350,7 +1366,7 @@ static void
 target_put_32 (void *p, rc_uint_type value)
 {
   assert (!! p);
 target_put_32 (void *p, rc_uint_type value)
 {
   assert (!! p);

-  
+

   if (target_is_bigendian)
     bfd_putb32 (value, p);
   else
   if (target_is_bigendian)
     bfd_putb32 (value, p);
   else


@@ -1389,5 +1405,5 @@ int wr_print (FILE *e, const char *fmt, ...)
   va_start (arg, fmt);
   r += vfprintf (e, fmt, arg);
   va_end (arg);
   va_start (arg, fmt);
   r += vfprintf (e, fmt, arg);
   va_end (arg);

-  return r;    
+  return r;

 }
 }