Resume the inferior with signal rather than stepping over

[deliverable/binutils-gdb.git] / gdb / mep-tdep.c

diff --git a/gdb/mep-tdep.c b/gdb/mep-tdep.c
index bd200c1443726f66f1313e9f3aa88fddd5919ecf..a110b04dab1a7a407c87f55a8d9bdef338f63911 100644 (file)
--- a/gdb/mep-tdep.c
+++ b/gdb/mep-tdep.c
@@ -1,7 +1,6 @@
 /* Target-dependent code for the Toshiba MeP for GDB, the GNU debugger.
 
 /* Target-dependent code for the Toshiba MeP for GDB, the GNU debugger.
 

-   Copyright (C) 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010
-   Free Software Foundation, Inc.
+   Copyright (C) 2001-2016 Free Software Foundation, Inc.

 
    Contributed by Red Hat, Inc.
 
 
    Contributed by Red Hat, Inc.
 


@@ -28,7 +27,6 @@
 #include "gdbtypes.h"
 #include "gdbcmd.h"
 #include "gdbcore.h"
 #include "gdbtypes.h"
 #include "gdbcmd.h"
 #include "gdbcore.h"

-#include "gdb_string.h"

 #include "value.h"
 #include "inferior.h"
 #include "dis-asm.h"
 #include "value.h"
 #include "inferior.h"
 #include "dis-asm.h"


@@ -49,8 +47,6 @@
 #include "cgen/bitset.h"
 #include "infcall.h"
 
 #include "cgen/bitset.h"
 #include "infcall.h"
 

-#include "gdb_assert.h"
-

 /* Get the user's customized MeP coprocessor register names from
    libopcodes.  */
 #include "opcodes/mep-desc.h"
 /* Get the user's customized MeP coprocessor register names from
    libopcodes.  */
 #include "opcodes/mep-desc.h"


@@ -264,7 +260,7 @@ me_module_register_set (CONFIG_ATTR me_module,
        mask contains any of the me_module's coprocessor ISAs,
        specifically excluding the generic coprocessor register sets.  */
 
        mask contains any of the me_module's coprocessor ISAs,
        specifically excluding the generic coprocessor register sets.  */
 

-  CGEN_CPU_DESC desc = gdbarch_tdep (target_gdbarch)->cpu_desc;
+  CGEN_CPU_DESC desc = gdbarch_tdep (target_gdbarch ())->cpu_desc;

   const CGEN_HW_ENTRY *hw;
 
   if (me_module == CONFIG_NONE)
   const CGEN_HW_ENTRY *hw;
 
   if (me_module == CONFIG_NONE)


@@ -788,7 +784,9 @@ static int
 mep_debug_reg_to_regnum (struct gdbarch *gdbarch, int debug_reg)
 {
   /* The debug info uses the raw register numbers.  */
 mep_debug_reg_to_regnum (struct gdbarch *gdbarch, int debug_reg)
 {
   /* The debug info uses the raw register numbers.  */

-  return mep_raw_to_pseudo[debug_reg];
+  if (debug_reg >= 0 && debug_reg < ARRAY_SIZE (mep_raw_to_pseudo))
+    return mep_raw_to_pseudo[debug_reg];
+  return -1;

 }
 
 
 }
 
 


@@ -804,7 +802,7 @@ mep_pseudo_cr_size (int pseudo)
            || IS_FP_CR64_REGNUM (pseudo))
     return 64;
   else
            || IS_FP_CR64_REGNUM (pseudo))
     return 64;
   else

-    gdb_assert (0);
+    gdb_assert_not_reached ("unexpected coprocessor pseudo register");

 }
 
 
 }
 
 


@@ -833,7 +831,7 @@ mep_pseudo_cr_index (int pseudo)
   else if (IS_FP_CR64_REGNUM (pseudo))
       return pseudo - MEP_FIRST_FP_CR64_REGNUM;
   else
   else if (IS_FP_CR64_REGNUM (pseudo))
       return pseudo - MEP_FIRST_FP_CR64_REGNUM;
   else

-    gdb_assert (0);
+    gdb_assert_not_reached ("unexpected coprocessor pseudo register");

 }
 
 
 }
 
 


@@ -845,17 +843,17 @@ mep_pseudo_cr_index (int pseudo)
    from the ELF header's e_flags field of the current executable
    file.  */
 static CONFIG_ATTR
    from the ELF header's e_flags field of the current executable
    file.  */
 static CONFIG_ATTR

-current_me_module ()
+current_me_module (void)

 {
   if (target_has_registers)
     {
       ULONGEST regval;
       regcache_cooked_read_unsigned (get_current_regcache (),
                                     MEP_MODULE_REGNUM, &regval);
 {
   if (target_has_registers)
     {
       ULONGEST regval;
       regcache_cooked_read_unsigned (get_current_regcache (),
                                     MEP_MODULE_REGNUM, &regval);

-      return regval;
+      return (CONFIG_ATTR) regval;

     }
   else
     }
   else

-    return gdbarch_tdep (target_gdbarch)->me_module;
+    return gdbarch_tdep (target_gdbarch ())->me_module;

 }
 
 
 }
 
 


@@ -868,7 +866,7 @@ current_me_module ()
    then use the 'module_opt' field we computed when we build the
    gdbarch object for this module.  */
 static unsigned int
    then use the 'module_opt' field we computed when we build the
    gdbarch object for this module.  */
 static unsigned int

-current_options ()
+current_options (void)

 {
   if (target_has_registers)
     {
 {
   if (target_has_registers)
     {


@@ -885,7 +883,7 @@ current_options ()
 /* Return the width of the current me_module's coprocessor data bus,
    in bits.  This is either 32 or 64.  */
 static int
 /* Return the width of the current me_module's coprocessor data bus,
    in bits.  This is either 32 or 64.  */
 static int

-current_cop_data_bus_width ()
+current_cop_data_bus_width (void)

 {
   return me_module_cop_data_bus_width (current_me_module ());
 }
 {
   return me_module_cop_data_bus_width (current_me_module ());
 }


@@ -894,7 +892,7 @@ current_cop_data_bus_width ()
 /* Return the keyword table of coprocessor general-purpose register
    names appropriate for the me_module we're dealing with.  */
 static CGEN_KEYWORD *
 /* Return the keyword table of coprocessor general-purpose register
    names appropriate for the me_module we're dealing with.  */
 static CGEN_KEYWORD *

-current_cr_names ()
+current_cr_names (void)

 {
   const CGEN_HW_ENTRY *hw
     = me_module_register_set (current_me_module (), "h-cr-", HW_H_CR);
 {
   const CGEN_HW_ENTRY *hw
     = me_module_register_set (current_me_module (), "h-cr-", HW_H_CR);


@@ -906,7 +904,7 @@ current_cr_names ()
 /* Return non-zero if the coprocessor general-purpose registers are
    floating-point values, zero otherwise.  */
 static int
 /* Return non-zero if the coprocessor general-purpose registers are
    floating-point values, zero otherwise.  */
 static int

-current_cr_is_float ()
+current_cr_is_float (void)

 {
   const CGEN_HW_ENTRY *hw
     = me_module_register_set (current_me_module (), "h-cr-", HW_H_CR);
 {
   const CGEN_HW_ENTRY *hw
     = me_module_register_set (current_me_module (), "h-cr-", HW_H_CR);


@@ -918,7 +916,7 @@ current_cr_is_float ()
 /* Return the keyword table of coprocessor control register names
    appropriate for the me_module we're dealing with.  */
 static CGEN_KEYWORD *
 /* Return the keyword table of coprocessor control register names
    appropriate for the me_module we're dealing with.  */
 static CGEN_KEYWORD *

-current_ccr_names ()
+current_ccr_names (void)

 {
   const CGEN_HW_ENTRY *hw
     = me_module_register_set (current_me_module (), "h-ccr-", HW_H_CCR);
 {
   const CGEN_HW_ENTRY *hw
     = me_module_register_set (current_me_module (), "h-ccr-", HW_H_CCR);


@@ -1109,7 +1107,7 @@ mep_register_type (struct gdbarch *gdbarch, int reg_nr)
             return builtin_type (gdbarch)->builtin_uint64;
         }
       else
             return builtin_type (gdbarch)->builtin_uint64;
         }
       else

-        gdb_assert (0);
+        gdb_assert_not_reached ("unexpected cr size");

     }
 
   /* All other registers are 32 bits long.  */
     }
 
   /* All other registers are 32 bits long.  */


@@ -1126,45 +1124,43 @@ mep_read_pc (struct regcache *regcache)
   return pc;
 }
 
   return pc;
 }
 

-static void
-mep_write_pc (struct regcache *regcache, CORE_ADDR pc)
-{
-  regcache_cooked_write_unsigned (regcache, MEP_PC_REGNUM, pc);
-}
-
-
-static void
+static enum register_status

 mep_pseudo_cr32_read (struct gdbarch *gdbarch,
                       struct regcache *regcache,
                       int cookednum,
 mep_pseudo_cr32_read (struct gdbarch *gdbarch,
                       struct regcache *regcache,
                       int cookednum,

-                      void *buf)
+                      gdb_byte *buf)

 {
 {

+  enum register_status status;

   enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
   /* Read the raw register into a 64-bit buffer, and then return the
      appropriate end of that buffer.  */
   int rawnum = mep_pseudo_to_raw[cookednum];
   enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
   /* Read the raw register into a 64-bit buffer, and then return the
      appropriate end of that buffer.  */
   int rawnum = mep_pseudo_to_raw[cookednum];

-  char buf64[8];
+  gdb_byte buf64[8];

 
   gdb_assert (TYPE_LENGTH (register_type (gdbarch, rawnum)) == sizeof (buf64));
   gdb_assert (TYPE_LENGTH (register_type (gdbarch, cookednum)) == 4);
 
   gdb_assert (TYPE_LENGTH (register_type (gdbarch, rawnum)) == sizeof (buf64));
   gdb_assert (TYPE_LENGTH (register_type (gdbarch, cookednum)) == 4);

-  regcache_raw_read (regcache, rawnum, buf64);
-  /* Slow, but legible.  */
-  store_unsigned_integer (buf, 4, byte_order,
-                         extract_unsigned_integer (buf64, 8, byte_order));
+  status = regcache_raw_read (regcache, rawnum, buf64);
+  if (status == REG_VALID)
+    {
+      /* Slow, but legible.  */
+      store_unsigned_integer (buf, 4, byte_order,
+                             extract_unsigned_integer (buf64, 8, byte_order));
+    }
+  return status;

 }
 
 
 }
 
 

-static void
+static enum register_status

 mep_pseudo_cr64_read (struct gdbarch *gdbarch,
                       struct regcache *regcache,
                       int cookednum,
 mep_pseudo_cr64_read (struct gdbarch *gdbarch,
                       struct regcache *regcache,
                       int cookednum,

-                      void *buf)
+                      gdb_byte *buf)

 {
 {

-  regcache_raw_read (regcache, mep_pseudo_to_raw[cookednum], buf);
+  return regcache_raw_read (regcache, mep_pseudo_to_raw[cookednum], buf);

 }
 
 
 }
 
 

-static void
+static enum register_status

 mep_pseudo_register_read (struct gdbarch *gdbarch,
                           struct regcache *regcache,
                           int cookednum,
 mep_pseudo_register_read (struct gdbarch *gdbarch,
                           struct regcache *regcache,
                           int cookednum,


@@ -1172,15 +1168,15 @@ mep_pseudo_register_read (struct gdbarch *gdbarch,
 {
   if (IS_CSR_REGNUM (cookednum)
       || IS_CCR_REGNUM (cookednum))
 {
   if (IS_CSR_REGNUM (cookednum)
       || IS_CCR_REGNUM (cookednum))

-    regcache_raw_read (regcache, mep_pseudo_to_raw[cookednum], buf);
+    return regcache_raw_read (regcache, mep_pseudo_to_raw[cookednum], buf);

   else if (IS_CR32_REGNUM (cookednum)
            || IS_FP_CR32_REGNUM (cookednum))
   else if (IS_CR32_REGNUM (cookednum)
            || IS_FP_CR32_REGNUM (cookednum))

-    mep_pseudo_cr32_read (gdbarch, regcache, cookednum, buf);
+    return mep_pseudo_cr32_read (gdbarch, regcache, cookednum, buf);

   else if (IS_CR64_REGNUM (cookednum)
            || IS_FP_CR64_REGNUM (cookednum))
   else if (IS_CR64_REGNUM (cookednum)
            || IS_FP_CR64_REGNUM (cookednum))

-    mep_pseudo_cr64_read (gdbarch, regcache, cookednum, buf);
+    return mep_pseudo_cr64_read (gdbarch, regcache, cookednum, buf);

   else
   else

-    gdb_assert (0);
+    gdb_assert_not_reached ("unexpected pseudo register");

 }
 
 
 }
 
 


@@ -1188,7 +1184,7 @@ static void
 mep_pseudo_csr_write (struct gdbarch *gdbarch,
                       struct regcache *regcache,
                       int cookednum,
 mep_pseudo_csr_write (struct gdbarch *gdbarch,
                       struct regcache *regcache,
                       int cookednum,

-                      const void *buf)
+                      const gdb_byte *buf)

 {
   enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
   int size = register_size (gdbarch, cookednum);
 {
   enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
   int size = register_size (gdbarch, cookednum);


@@ -1219,13 +1215,13 @@ static void
 mep_pseudo_cr32_write (struct gdbarch *gdbarch,
                        struct regcache *regcache,
                        int cookednum,
 mep_pseudo_cr32_write (struct gdbarch *gdbarch,
                        struct regcache *regcache,
                        int cookednum,

-                       const void *buf)
+                       const gdb_byte *buf)

 {
   enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
   /* Expand the 32-bit value into a 64-bit value, and write that to
      the pseudoregister.  */
   int rawnum = mep_pseudo_to_raw[cookednum];
 {
   enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
   /* Expand the 32-bit value into a 64-bit value, and write that to
      the pseudoregister.  */
   int rawnum = mep_pseudo_to_raw[cookednum];

-  char buf64[8];
+  gdb_byte buf64[8];

   
   gdb_assert (TYPE_LENGTH (register_type (gdbarch, rawnum)) == sizeof (buf64));
   gdb_assert (TYPE_LENGTH (register_type (gdbarch, cookednum)) == 4);
   
   gdb_assert (TYPE_LENGTH (register_type (gdbarch, rawnum)) == sizeof (buf64));
   gdb_assert (TYPE_LENGTH (register_type (gdbarch, cookednum)) == 4);


@@ -1240,7 +1236,7 @@ static void
 mep_pseudo_cr64_write (struct gdbarch *gdbarch,
                      struct regcache *regcache,
                      int cookednum,
 mep_pseudo_cr64_write (struct gdbarch *gdbarch,
                      struct regcache *regcache,
                      int cookednum,

-                     const void *buf)
+                     const gdb_byte *buf)

 {
   regcache_raw_write (regcache, mep_pseudo_to_raw[cookednum], buf);
 }
 {
   regcache_raw_write (regcache, mep_pseudo_to_raw[cookednum], buf);
 }


@@ -1263,7 +1259,7 @@ mep_pseudo_register_write (struct gdbarch *gdbarch,
   else if (IS_CCR_REGNUM (cookednum))
     regcache_raw_write (regcache, mep_pseudo_to_raw[cookednum], buf);
   else
   else if (IS_CCR_REGNUM (cookednum))
     regcache_raw_write (regcache, mep_pseudo_to_raw[cookednum], buf);
   else

-    gdb_assert (0);
+    gdb_assert_not_reached ("unexpected pseudo register");

 }
 
 
 }
 
 


@@ -1271,7 +1267,7 @@ mep_pseudo_register_write (struct gdbarch *gdbarch,
 /* Disassembly.  */
 
 /* The mep disassembler needs to know about the section in order to
 /* Disassembly.  */
 
 /* The mep disassembler needs to know about the section in order to

-   work correctly. */
+   work correctly.  */

 static int
 mep_gdb_print_insn (bfd_vma pc, disassemble_info * info)
 {
 static int
 mep_gdb_print_insn (bfd_vma pc, disassemble_info * info)
 {


@@ -1325,7 +1321,7 @@ mep_gdb_print_insn (bfd_vma pc, disassemble_info * info)
      Every bundle is four bytes long, and naturally aligned, and can hold
      one or two instructions:
      - 16-bit core instruction; 16-bit coprocessor instruction
      Every bundle is four bytes long, and naturally aligned, and can hold
      one or two instructions:
      - 16-bit core instruction; 16-bit coprocessor instruction

-       These execute in parallel.       
+       These execute in parallel.

      - 32-bit core instruction
      - 32-bit coprocessor instruction
 
      - 32-bit core instruction
      - 32-bit coprocessor instruction
 


@@ -1333,9 +1329,9 @@ mep_gdb_print_insn (bfd_vma pc, disassemble_info * info)
      Every bundle is eight bytes long, and naturally aligned, and can hold
      one or two instructions:
      - 16-bit core instruction; 48-bit (!) coprocessor instruction
      Every bundle is eight bytes long, and naturally aligned, and can hold
      one or two instructions:
      - 16-bit core instruction; 48-bit (!) coprocessor instruction

-       These execute in parallel.       
+       These execute in parallel.

      - 32-bit core instruction; 32-bit coprocessor instruction
      - 32-bit core instruction; 32-bit coprocessor instruction

-       These execute in parallel.       
+       These execute in parallel.

      - 64-bit coprocessor instruction
 
    Now, the MeP manual doesn't define any 48- or 64-bit coprocessor
      - 64-bit coprocessor instruction
 
    Now, the MeP manual doesn't define any 48- or 64-bit coprocessor


@@ -1420,13 +1416,13 @@ mep_pc_in_vliw_section (CORE_ADDR pc)
    anyway.  */
 
 static CORE_ADDR 
    anyway.  */
 
 static CORE_ADDR 

-mep_get_insn (struct gdbarch *gdbarch, CORE_ADDR pc, long *insn)
+mep_get_insn (struct gdbarch *gdbarch, CORE_ADDR pc, unsigned long *insn)

 {
   enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
   int pc_in_vliw_section;
   int vliw_mode;
   int insn_len;
 {
   enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
   int pc_in_vliw_section;
   int vliw_mode;
   int insn_len;

-  char buf[2];
+  gdb_byte buf[2];

 
   *insn = 0;
 
 
   *insn = 0;
 


@@ -1488,7 +1484,7 @@ mep_get_insn (struct gdbarch *gdbarch, CORE_ADDR pc, long *insn)
 
       /* We'd better be in either core, 32-bit VLIW, or 64-bit VLIW mode.  */
       else
 
       /* We'd better be in either core, 32-bit VLIW, or 64-bit VLIW mode.  */
       else

-        gdb_assert (0);
+        gdb_assert_not_reached ("unexpected vliw mode");

     }
   
   /* Otherwise, the top two bits of the major opcode are (again) what
     }
   
   /* Otherwise, the top two bits of the major opcode are (again) what


@@ -1792,8 +1788,7 @@ mep_analyze_prologue (struct gdbarch *gdbarch,
           int disp = SWBH_32_OFFSET (insn);
           int size = (IS_SB (insn) ? 1
                       : IS_SH (insn) ? 2
           int disp = SWBH_32_OFFSET (insn);
           int size = (IS_SB (insn) ? 1
                       : IS_SH (insn) ? 2

-                      : IS_SW (insn) ? 4
-                      : (gdb_assert (0), 1));
+                      : (gdb_assert (IS_SW (insn)), 4));

           pv_t addr = pv_add_constant (reg[rm], disp);
 
           if (pv_area_store_would_trash (stack, addr))
           pv_t addr = pv_add_constant (reg[rm], disp);
 
           if (pv_area_store_would_trash (stack, addr))


@@ -1826,7 +1821,7 @@ mep_analyze_prologue (struct gdbarch *gdbarch,
             body, gcc 4.x will use a BRA instruction to branch to the
             loop condition checking code.  This BRA instruction is
             marked as part of the prologue.  We therefore set next_pc
             body, gcc 4.x will use a BRA instruction to branch to the
             loop condition checking code.  This BRA instruction is
             marked as part of the prologue.  We therefore set next_pc

-            to this branch target and also stop the prologue scan. 
+            to this branch target and also stop the prologue scan.

             The instructions at and beyond the branch target should
             no longer be associated with the prologue.
             
             The instructions at and beyond the branch target should
             no longer be associated with the prologue.
             


@@ -1908,7 +1903,7 @@ mep_analyze_prologue (struct gdbarch *gdbarch,
 static CORE_ADDR
 mep_skip_prologue (struct gdbarch *gdbarch, CORE_ADDR pc)
 {
 static CORE_ADDR
 mep_skip_prologue (struct gdbarch *gdbarch, CORE_ADDR pc)
 {

-  char *name;
+  const char *name;

   CORE_ADDR func_addr, func_end;
   struct mep_prologue p;
 
   CORE_ADDR func_addr, func_end;
   struct mep_prologue p;
 


@@ -1957,10 +1952,11 @@ mep_analyze_frame_prologue (struct frame_info *this_frame,
         stop_addr = func_start;
 
       mep_analyze_prologue (get_frame_arch (this_frame),
         stop_addr = func_start;
 
       mep_analyze_prologue (get_frame_arch (this_frame),

-                           func_start, stop_addr, *this_prologue_cache);
+                           func_start, stop_addr,
+                           (struct mep_prologue *) *this_prologue_cache);

     }
 
     }
 

-  return *this_prologue_cache;
+  return (struct mep_prologue *) *this_prologue_cache;

 }
 
 
 }
 
 


@@ -2090,6 +2086,7 @@ mep_frame_prev_register (struct frame_info *this_frame,
 
 static const struct frame_unwind mep_frame_unwind = {
   NORMAL_FRAME,
 
 static const struct frame_unwind mep_frame_unwind = {
   NORMAL_FRAME,

+  default_frame_unwind_stop_reason,

   mep_frame_this_id,
   mep_frame_prev_register,
   NULL,
   mep_frame_this_id,
   mep_frame_prev_register,
   NULL,


@@ -2146,7 +2143,7 @@ mep_extract_return_value (struct gdbarch *arch,
   else
     offset = 0;
 
   else
     offset = 0;
 

-  /* Return values that do fit in a single register are returned in R0. */
+  /* Return values that do fit in a single register are returned in R0.  */

   regcache_cooked_read_part (regcache, MEP_R0_REGNUM,
                              offset, TYPE_LENGTH (type),
                              valbuf);
   regcache_cooked_read_part (regcache, MEP_R0_REGNUM,
                              offset, TYPE_LENGTH (type),
                              valbuf);


@@ -2181,17 +2178,16 @@ mep_store_return_value (struct gdbarch *arch,
 
   /* Return values larger than a single register are returned in
      memory, pointed to by R0.  Unfortunately, we can't count on R0
 
   /* Return values larger than a single register are returned in
      memory, pointed to by R0.  Unfortunately, we can't count on R0

-     pointing to the return buffer, so we raise an error here. */
+     pointing to the return buffer, so we raise an error here.  */

   else
   else

-    error ("GDB cannot set return values larger than four bytes; "
-           "the Media Processor's\n"
-           "calling conventions do not provide enough information "
-           "to do this.\n"
-           "Try using the 'return' command with no argument.");
+    error (_("\
+GDB cannot set return values larger than four bytes; the Media Processor's\n\
+calling conventions do not provide enough information to do this.\n\
+Try using the 'return' command with no argument."));

 }
 
 static enum return_value_convention
 }
 
 static enum return_value_convention

-mep_return_value (struct gdbarch *gdbarch, struct type *func_type,
+mep_return_value (struct gdbarch *gdbarch, struct value *function,

                  struct type *type, struct regcache *regcache,
                  gdb_byte *readbuf, const gdb_byte *writebuf)
 {
                  struct type *type, struct regcache *regcache,
                  gdb_byte *readbuf, const gdb_byte *writebuf)
 {


@@ -2210,12 +2206,11 @@ mep_return_value (struct gdbarch *gdbarch, struct type *func_type,
        {
          /* Return values larger than a single register are returned in
             memory, pointed to by R0.  Unfortunately, we can't count on R0
        {
          /* Return values larger than a single register are returned in
             memory, pointed to by R0.  Unfortunately, we can't count on R0

-            pointing to the return buffer, so we raise an error here. */
-         error ("GDB cannot set return values larger than four bytes; "
-                "the Media Processor's\n"
-                "calling conventions do not provide enough information "
-                "to do this.\n"
-                "Try using the 'return' command with no argument.");
+            pointing to the return buffer, so we raise an error here.  */
+         error (_("\
+GDB cannot set return values larger than four bytes; the Media Processor's\n\
+calling conventions do not provide enough information to do this.\n\
+Try using the 'return' command with no argument."));

        }
       return RETURN_VALUE_ABI_RETURNS_ADDRESS;
     }
        }
       return RETURN_VALUE_ABI_RETURNS_ADDRESS;
     }


@@ -2247,15 +2242,15 @@ mep_frame_align (struct gdbarch *gdbarch, CORE_ADDR sp)
    4.2.1 Core register conventions
 
    - Parameters should be evaluated from left to right, and they
    4.2.1 Core register conventions
 
    - Parameters should be evaluated from left to right, and they

-     should be held in $1,$2,$3,$4 in order. The fifth parameter or
-     after should be held in the stack. If the size is larger than 4
+     should be held in $1,$2,$3,$4 in order.  The fifth parameter or
+     after should be held in the stack.  If the size is larger than 4

      bytes in the first four parameters, the pointer should be held in
      bytes in the first four parameters, the pointer should be held in

-     the registers instead. If the size is larger than 4 bytes in the
+     the registers instead.  If the size is larger than 4 bytes in the

      fifth parameter or after, the pointer should be held in the stack.
 
      fifth parameter or after, the pointer should be held in the stack.
 

-   - Return value of a function should be held in register $0. If the
+   - Return value of a function should be held in register $0.  If the

      size of return value is larger than 4 bytes, $1 should hold the
      size of return value is larger than 4 bytes, $1 should hold the

-     pointer pointing memory that would hold the return value. In this
+     pointer pointing memory that would hold the return value.  In this

      case, the first parameter should be held in $2, the second one in
      $3, and the third one in $4, and the forth parameter or after
      should be held in the stack.
      case, the first parameter should be held in $2, the second one in
      $3, and the third one in $4, and the forth parameter or after
      should be held in the stack.


@@ -2335,11 +2330,10 @@ mep_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
 
   for (i = 0; i < argc; i++)
     {
 
   for (i = 0; i < argc; i++)
     {

-      unsigned arg_size = TYPE_LENGTH (value_type (argv[i]));

       ULONGEST value;
 
       /* Arguments that fit in a GPR get expanded to fill the GPR.  */
       ULONGEST value;
 
       /* Arguments that fit in a GPR get expanded to fill the GPR.  */

-      if (arg_size <= MEP_GPR_SIZE)
+      if (TYPE_LENGTH (value_type (argv[i])) <= MEP_GPR_SIZE)

         value = extract_unsigned_integer (value_contents (argv[i]),
                                           TYPE_LENGTH (value_type (argv[i])),
                                          byte_order);
         value = extract_unsigned_integer (value_contents (argv[i]),
                                           TYPE_LENGTH (value_type (argv[i])),
                                          byte_order);


@@ -2357,7 +2351,7 @@ mep_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
         }
       else
         {
         }
       else
         {

-          char buf[MEP_GPR_SIZE];
+          gdb_byte buf[MEP_GPR_SIZE];

           store_unsigned_integer (buf, MEP_GPR_SIZE, byte_order, value);
           write_memory (arg_stack, buf, MEP_GPR_SIZE);
           arg_stack += MEP_GPR_SIZE;
           store_unsigned_integer (buf, MEP_GPR_SIZE, byte_order, value);
           write_memory (arg_stack, buf, MEP_GPR_SIZE);
           arg_stack += MEP_GPR_SIZE;


@@ -2404,7 +2398,10 @@ mep_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
       /* The way to get the me_module code depends on the object file
          format.  At the moment, we only know how to handle ELF.  */
       if (bfd_get_flavour (info.abfd) == bfd_target_elf_flavour)
       /* The way to get the me_module code depends on the object file
          format.  At the moment, we only know how to handle ELF.  */
       if (bfd_get_flavour (info.abfd) == bfd_target_elf_flavour)

-        me_module = elf_elfheader (info.abfd)->e_flags & EF_MEP_INDEX_MASK;
+       {
+         int flag = elf_elfheader (info.abfd)->e_flags & EF_MEP_INDEX_MASK;
+         me_module = (CONFIG_ATTR) flag;
+       }

       else
         me_module = CONFIG_NONE;
     }
       else
         me_module = CONFIG_NONE;
     }


@@ -2428,14 +2425,14 @@ mep_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
           
           fputc_unfiltered ('\n', gdb_stderr);
           if (module_name)
           
           fputc_unfiltered ('\n', gdb_stderr);
           if (module_name)

-            warning ("the MeP module '%s' is %s-endian, but the executable\n"
-                     "%s is %s-endian.",
+            warning (_("the MeP module '%s' is %s-endian, but the executable\n"
+                      "%s is %s-endian."),

                      module_name, module_endianness,
                      file_name, file_endianness);
           else
                      module_name, module_endianness,
                      file_name, file_endianness);
           else

-            warning ("the selected MeP module is %s-endian, but the "
-                     "executable\n"
-                     "%s is %s-endian.",
+            warning (_("the selected MeP module is %s-endian, but the "
+                      "executable\n"
+                      "%s is %s-endian."),

                      module_endianness, file_name, file_endianness);
         }
     }
                      module_endianness, file_name, file_endianness);
         }
     }


@@ -2450,7 +2447,7 @@ mep_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
     if (gdbarch_tdep (arches->gdbarch)->me_module == me_module)
       return arches->gdbarch;
 
     if (gdbarch_tdep (arches->gdbarch)->me_module == me_module)
       return arches->gdbarch;
 

-  tdep = (struct gdbarch_tdep *) xmalloc (sizeof (struct gdbarch_tdep));
+  tdep = XNEW (struct gdbarch_tdep);

   gdbarch = gdbarch_alloc (&info, tdep);
 
   /* Get a CGEN CPU descriptor for this architecture.  */
   gdbarch = gdbarch_alloc (&info, tdep);
 
   /* Get a CGEN CPU descriptor for this architecture.  */


@@ -2469,8 +2466,8 @@ mep_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
 
   /* Register set.  */
   set_gdbarch_read_pc (gdbarch, mep_read_pc);
 
   /* Register set.  */
   set_gdbarch_read_pc (gdbarch, mep_read_pc);

-  set_gdbarch_write_pc (gdbarch, mep_write_pc);

   set_gdbarch_num_regs (gdbarch, MEP_NUM_RAW_REGS);
   set_gdbarch_num_regs (gdbarch, MEP_NUM_RAW_REGS);

+  set_gdbarch_pc_regnum (gdbarch, MEP_PC_REGNUM);

   set_gdbarch_sp_regnum (gdbarch, MEP_SP_REGNUM);
   set_gdbarch_register_name (gdbarch, mep_register_name);
   set_gdbarch_register_type (gdbarch, mep_register_type);
   set_gdbarch_sp_regnum (gdbarch, MEP_SP_REGNUM);
   set_gdbarch_register_name (gdbarch, mep_register_name);
   set_gdbarch_register_type (gdbarch, mep_register_type);