Replace calls to abort() with calls to internal_error().

[deliverable/binutils-gdb.git] / gdb / monitor.c

diff --git a/gdb/monitor.c b/gdb/monitor.c
index e57c010383db00f9da113274488d1e9a5fb5877a..7e3580e1b11e819a9bd50f7120b6337200085946 100644 (file)
--- a/gdb/monitor.c
+++ b/gdb/monitor.c
@@ -1,5 +1,5 @@
 /* Remote debugging interface for boot monitors, for GDB.
 /* Remote debugging interface for boot monitors, for GDB.

-   Copyright 1990-1993, 1995-1997, 1999-2000 Free Software Foundation, Inc.
+   Copyright 1990-1993, 1995-1997, 1999-2000, 2001 Free Software Foundation, Inc.

    Contributed by Cygnus Support.  Written by Rob Savoye for Cygnus.
    Resurrected from the ashes by Stu Grossman.
 
    Contributed by Cygnus Support.  Written by Rob Savoye for Cygnus.
    Resurrected from the ashes by Stu Grossman.
 


@@ -23,7 +23,7 @@
 /* This file was derived from various remote-* modules. It is a collection
    of generic support functions so GDB can talk directly to a ROM based
    monitor. This saves use from having to hack an exception based handler
 /* This file was derived from various remote-* modules. It is a collection
    of generic support functions so GDB can talk directly to a ROM based
    monitor. This saves use from having to hack an exception based handler

-   into existance, and makes for quick porting.
+   into existence, and makes for quick porting.

 
    This module talks to a debug monitor called 'MONITOR', which
    We communicate with MONITOR via either a direct serial line, or a TCP
 
    This module talks to a debug monitor called 'MONITOR', which
    We communicate with MONITOR via either a direct serial line, or a TCP


@@ -40,7 +40,6 @@
 #include "defs.h"
 #include "gdbcore.h"
 #include "target.h"
 #include "defs.h"
 #include "gdbcore.h"
 #include "target.h"

-#include "gdb_wait.h"

 #include <signal.h>
 #include <ctype.h>
 #include "gdb_string.h"
 #include <signal.h>
 #include <ctype.h>
 #include "gdb_string.h"


@@ -50,58 +49,57 @@
 #include "monitor.h"
 #include "gdbcmd.h"
 #include "inferior.h"
 #include "monitor.h"
 #include "gdbcmd.h"
 #include "inferior.h"

-#include "gnu-regex.h"
-#include "dcache.h"
+#include "gdb_regex.h"

 #include "srec.h"
 
 static char *dev_name;
 static struct target_ops *targ_ops;
 
 #include "srec.h"
 
 static char *dev_name;
 static struct target_ops *targ_ops;
 

-static void monitor_vsprintf PARAMS ((char *sndbuf, char *pattern, va_list args));
+static void monitor_vsprintf (char *sndbuf, char *pattern, va_list args);

 
 

-static int readchar PARAMS ((int timeout));
+static int readchar (int timeout);

 
 

-static void monitor_fetch_register PARAMS ((int regno));
-static void monitor_store_register PARAMS ((int regno));
+static void monitor_fetch_register (int regno);
+static void monitor_store_register (int regno);

 
 static void monitor_printable_string (char *newstr, char *oldstr, int len);
 static void monitor_error (char *function, char *message, CORE_ADDR memaddr, int len, char *string, int final_char);
 
 static void monitor_printable_string (char *newstr, char *oldstr, int len);
 static void monitor_error (char *function, char *message, CORE_ADDR memaddr, int len, char *string, int final_char);

-static void monitor_detach PARAMS ((char *args, int from_tty));
-static void monitor_resume PARAMS ((int pid, int step, enum target_signal sig));
-static void monitor_interrupt PARAMS ((int signo));
-static void monitor_interrupt_twice PARAMS ((int signo));
-static void monitor_interrupt_query PARAMS ((void));
-static void monitor_wait_cleanup PARAMS ((void *old_timeout));
-
-static int monitor_wait PARAMS ((int pid, struct target_waitstatus * status));
-static void monitor_fetch_registers PARAMS ((int regno));
-static void monitor_store_registers PARAMS ((int regno));
-static void monitor_prepare_to_store PARAMS ((void));
-static int monitor_xfer_memory PARAMS ((CORE_ADDR memaddr, char *myaddr, int len, int write, struct target_ops * target));
-static void monitor_files_info PARAMS ((struct target_ops * ops));
-static int monitor_insert_breakpoint PARAMS ((CORE_ADDR addr, char *shadow));
-static int monitor_remove_breakpoint PARAMS ((CORE_ADDR addr, char *shadow));
-static void monitor_kill PARAMS ((void));
-static void monitor_load PARAMS ((char *file, int from_tty));
-static void monitor_mourn_inferior PARAMS ((void));
-static void monitor_stop PARAMS ((void));
-
-static int monitor_read_memory PARAMS ((CORE_ADDR addr, char *myaddr, int len));
-static int monitor_write_memory PARAMS ((CORE_ADDR addr, char *myaddr, int len));
-static int monitor_write_memory_bytes PARAMS ((CORE_ADDR addr,
-                                              char *myaddr, int len));
-static int monitor_write_memory_block PARAMS ((
-                                               CORE_ADDR memaddr,
-                                               char *myaddr,
-                                               int len));
-static int monitor_expect_regexp PARAMS ((struct re_pattern_buffer * pat,
-                                         char *buf, int buflen));
-static void monitor_dump_regs PARAMS ((void));
+static void monitor_detach (char *args, int from_tty);
+static void monitor_resume (int pid, int step, enum target_signal sig);
+static void monitor_interrupt (int signo);
+static void monitor_interrupt_twice (int signo);
+static void monitor_interrupt_query (void);
+static void monitor_wait_cleanup (void *old_timeout);
+
+static int monitor_wait (int pid, struct target_waitstatus *status);
+static void monitor_fetch_registers (int regno);
+static void monitor_store_registers (int regno);
+static void monitor_prepare_to_store (void);
+static int monitor_xfer_memory (CORE_ADDR memaddr, char *myaddr, int len,
+                               int write, 
+                               struct mem_attrib *attrib,
+                               struct target_ops *target);
+static void monitor_files_info (struct target_ops *ops);
+static int monitor_insert_breakpoint (CORE_ADDR addr, char *shadow);
+static int monitor_remove_breakpoint (CORE_ADDR addr, char *shadow);
+static void monitor_kill (void);
+static void monitor_load (char *file, int from_tty);
+static void monitor_mourn_inferior (void);
+static void monitor_stop (void);
+
+static int monitor_read_memory (CORE_ADDR addr, char *myaddr, int len);
+static int monitor_write_memory (CORE_ADDR addr, char *myaddr, int len);
+static int monitor_write_memory_bytes (CORE_ADDR addr, char *myaddr, int len);
+static int monitor_write_memory_block (CORE_ADDR memaddr,
+                                      char *myaddr, int len);
+static int monitor_expect_regexp (struct re_pattern_buffer *pat,
+                                 char *buf, int buflen);
+static void monitor_dump_regs (void);

 #if 0
 #if 0

-static int from_hex PARAMS ((int a));
-static unsigned long get_hex_word PARAMS ((void));
+static int from_hex (int a);
+static unsigned long get_hex_word (void);

 #endif
 #endif

-static void parse_register_dump PARAMS ((char *, int));
+static void parse_register_dump (char *, int);

 
 static struct monitor_ops *current_monitor;
 
 
 static struct monitor_ops *current_monitor;
 


@@ -132,7 +130,6 @@ static char getmem_resp_delim_fastmap[256];
 static int dump_reg_flag;      /* Non-zero means do a dump_registers cmd when
                                   monitor_wait wakes up.  */
 
 static int dump_reg_flag;      /* Non-zero means do a dump_registers cmd when
                                   monitor_wait wakes up.  */
 

-static DCACHE *remote_dcache;

 static int first_time = 0;     /* is this the first time we're executing after 
                                   gaving created the child proccess? */
 
 static int first_time = 0;     /* is this the first time we're executing after 
                                   gaving created the child proccess? */
 


@@ -245,8 +242,7 @@ monitor_error (char *function, char *message,
 /* Convert hex digit A to a number.  */
 
 static int
 /* Convert hex digit A to a number.  */
 
 static int

-fromhex (a)
-     int a;
+fromhex (int a)

 {
   if (a >= '0' && a <= '9')
     return a - '0';
 {
   if (a >= '0' && a <= '9')
     return a - '0';


@@ -273,10 +269,7 @@ fromhex (a)
  */
 
 static void
  */
 
 static void

-monitor_vsprintf (sndbuf, pattern, args)
-     char *sndbuf;
-     char *pattern;
-     va_list args;
+monitor_vsprintf (char *sndbuf, char *pattern, va_list args)

 {
   char format[10];
   char fmt;
 {
   char format[10];
   char fmt;


@@ -342,7 +335,7 @@ monitor_printf_noecho (char *pattern,...)
 
   len = strlen (sndbuf);
   if (len + 1 > sizeof sndbuf)
 
   len = strlen (sndbuf);
   if (len + 1 > sizeof sndbuf)

-    abort ();
+    internal_error (__FILE__, __LINE__, "failed internal consistency check");

 
   if (monitor_debug_p)
     {
 
   if (monitor_debug_p)
     {


@@ -370,7 +363,7 @@ monitor_printf (char *pattern,...)
 
   len = strlen (sndbuf);
   if (len + 1 > sizeof sndbuf)
 
   len = strlen (sndbuf);
   if (len + 1 > sizeof sndbuf)

-    abort ();
+    internal_error (__FILE__, __LINE__, "failed internal consistency check");

 
   if (monitor_debug_p)
     {
 
   if (monitor_debug_p)
     {


@@ -393,9 +386,7 @@ monitor_printf (char *pattern,...)
 /* Write characters to the remote system.  */
 
 void
 /* Write characters to the remote system.  */
 
 void

-monitor_write (buf, buflen)
-     char *buf;
-     int buflen;
+monitor_write (char *buf, int buflen)

 {
   if (SERIAL_WRITE (monitor_desc, buf, buflen))
     fprintf_unfiltered (gdb_stderr, "SERIAL_WRITE failed: %s\n",
 {
   if (SERIAL_WRITE (monitor_desc, buf, buflen))
     fprintf_unfiltered (gdb_stderr, "SERIAL_WRITE failed: %s\n",


@@ -408,7 +399,7 @@ monitor_write (buf, buflen)
    and without printing remote debug information.  */
 
 int
    and without printing remote debug information.  */
 
 int

-monitor_readchar ()
+monitor_readchar (void)

 {
   int c;
   int looping;
 {
   int c;
   int looping;


@@ -437,8 +428,7 @@ monitor_readchar ()
    timeout stuff.  */
 
 static int
    timeout stuff.  */
 
 static int

-readchar (timeout)
-     int timeout;
+readchar (int timeout)

 {
   int c;
   static enum
 {
   int c;
   static enum


@@ -516,10 +506,7 @@ readchar (timeout)
    will be at the end of BUF.  */
 
 int
    will be at the end of BUF.  */
 
 int

-monitor_expect (string, buf, buflen)
-     char *string;
-     char *buf;
-     int buflen;
+monitor_expect (char *string, char *buf, int buflen)

 {
   char *p = string;
   int obuflen = buflen;
 {
   char *p = string;
   int obuflen = buflen;


@@ -533,7 +520,7 @@ monitor_expect (string, buf, buflen)
       fprintf_unfiltered (gdb_stdlog, "MON Expecting '%s'\n", safe_string);
     }
 
       fprintf_unfiltered (gdb_stdlog, "MON Expecting '%s'\n", safe_string);
     }
 

-  immediate_quit = 1;
+  immediate_quit++;

   while (1)
     {
       if (buf)
   while (1)
     {
       if (buf)


@@ -541,7 +528,7 @@ monitor_expect (string, buf, buflen)
          if (buflen < 2)
            {
              *buf = '\000';
          if (buflen < 2)
            {
              *buf = '\000';

-             immediate_quit = 0;
+             immediate_quit--;

              return -1;
            }
 
              return -1;
            }
 


@@ -561,7 +548,7 @@ monitor_expect (string, buf, buflen)
          p++;
          if (*p == '\0')
            {
          p++;
          if (*p == '\0')
            {

-             immediate_quit = 0;
+             immediate_quit--;

 
              if (buf)
                {
 
              if (buf)
                {


@@ -624,10 +611,7 @@ monitor_expect (string, buf, buflen)
 /* Search for a regexp.  */
 
 static int
 /* Search for a regexp.  */
 
 static int

-monitor_expect_regexp (pat, buf, buflen)
-     struct re_pattern_buffer *pat;
-     char *buf;
-     int buflen;
+monitor_expect_regexp (struct re_pattern_buffer *pat, char *buf, int buflen)

 {
   char *mybuf;
   char *p;
 {
   char *mybuf;
   char *p;


@@ -678,9 +662,7 @@ monitor_expect_regexp (pat, buf, buflen)
    getting into states from which we can't recover.  */
 
 int
    getting into states from which we can't recover.  */
 
 int

-monitor_expect_prompt (buf, buflen)
-     char *buf;
-     int buflen;
+monitor_expect_prompt (char *buf, int buflen)

 {
   monitor_debug ("MON Expecting prompt\n");
   return monitor_expect (current_monitor->prompt, buf, buflen);
 {
   monitor_debug ("MON Expecting prompt\n");
   return monitor_expect (current_monitor->prompt, buf, buflen);


@@ -691,7 +673,7 @@ monitor_expect_prompt (buf, buflen)
 
 #if 0
 static unsigned long
 
 #if 0
 static unsigned long

-get_hex_word ()
+get_hex_word (void)

 {
   unsigned long val;
   int i;
 {
   unsigned long val;
   int i;


@@ -716,10 +698,8 @@ get_hex_word ()
 #endif
 
 static void
 #endif
 
 static void

-compile_pattern (pattern, compiled_pattern, fastmap)
-     char *pattern;
-     struct re_pattern_buffer *compiled_pattern;
-     char *fastmap;
+compile_pattern (char *pattern, struct re_pattern_buffer *compiled_pattern,
+                char *fastmap)

 {
   int tmp;
   const char *val;
 {
   int tmp;
   const char *val;


@@ -743,10 +723,7 @@ compile_pattern (pattern, compiled_pattern, fastmap)
    for communication.  */
 
 void
    for communication.  */
 
 void

-monitor_open (args, mon_ops, from_tty)
-     char *args;
-     struct monitor_ops *mon_ops;
-     int from_tty;
+monitor_open (char *args, struct monitor_ops *mon_ops, int from_tty)

 {
   char *name;
   char **p;
 {
   char *name;
   char **p;


@@ -776,8 +753,8 @@ monitor_open (args, mon_ops, from_tty)
   unpush_target (targ_ops);
 
   if (dev_name)
   unpush_target (targ_ops);
 
   if (dev_name)

-    free (dev_name);
-  dev_name = strsave (args);
+    xfree (dev_name);
+  dev_name = xstrdup (args);

 
   monitor_desc = SERIAL_OPEN (dev_name);
 
 
   monitor_desc = SERIAL_OPEN (dev_name);
 


@@ -860,10 +837,6 @@ monitor_open (args, mon_ops, from_tty)
 
   monitor_printf (current_monitor->line_term);
 
 
   monitor_printf (current_monitor->line_term);
 

-  if (current_monitor->flags & MO_HAS_BLOCKWRITES)
-    remote_dcache = dcache_init (monitor_read_memory, monitor_write_memory_block);
-  else
-    remote_dcache = dcache_init (monitor_read_memory, monitor_write_memory);

   start_remote ();
 }
 
   start_remote ();
 }
 


@@ -871,8 +844,7 @@ monitor_open (args, mon_ops, from_tty)
    control.  */
 
 void
    control.  */
 
 void

-monitor_close (quitting)
-     int quitting;
+monitor_close (int quitting)

 {
   if (monitor_desc)
     SERIAL_CLOSE (monitor_desc);
 {
   if (monitor_desc)
     SERIAL_CLOSE (monitor_desc);


@@ -880,7 +852,7 @@ monitor_close (quitting)
   /* Free breakpoint memory */
   if (breakaddr != NULL)
     {
   /* Free breakpoint memory */
   if (breakaddr != NULL)
     {

-      free (breakaddr);
+      xfree (breakaddr);

       breakaddr = NULL;
     }
 
       breakaddr = NULL;
     }
 


@@ -891,9 +863,7 @@ monitor_close (quitting)
    when you want to detach and do something else with your gdb.  */
 
 static void
    when you want to detach and do something else with your gdb.  */
 
 static void

-monitor_detach (args, from_tty)
-     char *args;
-     int from_tty;
+monitor_detach (char *args, int from_tty)

 {
   pop_target ();               /* calls monitor_close to do the real work */
   if (from_tty)
 {
   pop_target ();               /* calls monitor_close to do the real work */
   if (from_tty)


@@ -903,9 +873,7 @@ monitor_detach (args, from_tty)
 /* Convert VALSTR into the target byte-ordered value of REGNO and store it.  */
 
 char *
 /* Convert VALSTR into the target byte-ordered value of REGNO and store it.  */
 
 char *

-monitor_supply_register (regno, valstr)
-     int regno;
-     char *valstr;
+monitor_supply_register (int regno, char *valstr)

 {
   ULONGEST val;
   unsigned char regbuf[MAX_REGISTER_RAW_SIZE];
 {
   ULONGEST val;
   unsigned char regbuf[MAX_REGISTER_RAW_SIZE];


@@ -951,16 +919,8 @@ monitor_supply_register (regno, valstr)
 
 /* Tell the remote machine to resume.  */
 
 
 /* Tell the remote machine to resume.  */
 

-void
-flush_monitor_dcache ()
-{
-  dcache_flush (remote_dcache);
-}
-

 static void
 static void

-monitor_resume (pid, step, sig)
-     int pid, step;
-     enum target_signal sig;
+monitor_resume (int pid, int step, enum target_signal sig)

 {
   /* Some monitors require a different command when starting a program */
   monitor_debug ("MON resume\n");
 {
   /* Some monitors require a different command when starting a program */
   monitor_debug ("MON resume\n");


@@ -972,7 +932,6 @@ monitor_resume (pid, step, sig)
        dump_reg_flag = 1;
       return;
     }
        dump_reg_flag = 1;
       return;
     }

-  dcache_flush (remote_dcache);

   if (step)
     monitor_printf (current_monitor->step);
   else
   if (step)
     monitor_printf (current_monitor->step);
   else


@@ -992,9 +951,7 @@ monitor_resume (pid, step, sig)
    string which are passed down to monitor specific code.  */
 
 static void
    string which are passed down to monitor specific code.  */
 
 static void

-parse_register_dump (buf, len)
-     char *buf;
-     int len;
+parse_register_dump (char *buf, int len)

 {
   monitor_debug ("MON Parsing  register dump\n");
   while (1)
 {
   monitor_debug ("MON Parsing  register dump\n");
   while (1)


@@ -1027,8 +984,7 @@ parse_register_dump (buf, len)
    packet.  */
 
 static void
    packet.  */
 
 static void

-monitor_interrupt (signo)
-     int signo;
+monitor_interrupt (int signo)

 {
   /* If this doesn't work, try more severe steps.  */
   signal (signo, monitor_interrupt_twice);
 {
   /* If this doesn't work, try more severe steps.  */
   signal (signo, monitor_interrupt_twice);


@@ -1042,8 +998,7 @@ monitor_interrupt (signo)
 /* The user typed ^C twice.  */
 
 static void
 /* The user typed ^C twice.  */
 
 static void

-monitor_interrupt_twice (signo)
-     int signo;
+monitor_interrupt_twice (int signo)

 {
   signal (signo, ofunc);
 
 {
   signal (signo, ofunc);
 


@@ -1055,7 +1010,7 @@ monitor_interrupt_twice (signo)
 /* Ask the user what to do when an interrupt is received.  */
 
 static void
 /* Ask the user what to do when an interrupt is received.  */
 
 static void

-monitor_interrupt_query ()
+monitor_interrupt_query (void)

 {
   target_terminal_ours ();
 
 {
   target_terminal_ours ();
 


@@ -1070,8 +1025,7 @@ Give up (and stop debugging it)? "))
 }
 
 static void
 }
 
 static void

-monitor_wait_cleanup (old_timeout)
-     void *old_timeout;
+monitor_wait_cleanup (void *old_timeout)

 {
   timeout = *(int *) old_timeout;
   signal (SIGINT, ofunc);
 {
   timeout = *(int *) old_timeout;
   signal (SIGINT, ofunc);


@@ -1117,9 +1071,7 @@ monitor_wait_filter (char *buf,
    status just as `wait' would.  */
 
 static int
    status just as `wait' would.  */
 
 static int

-monitor_wait (pid, status)
-     int pid;
-     struct target_waitstatus *status;
+monitor_wait (int pid, struct target_waitstatus *status)

 {
   int old_timeout = timeout;
   char buf[TARGET_BUF_SIZE];
 {
   int old_timeout = timeout;
   char buf[TARGET_BUF_SIZE];


@@ -1202,15 +1154,17 @@ monitor_wait (pid, status)
    errno value.  */
 
 static void
    errno value.  */
 
 static void

-monitor_fetch_register (regno)
-     int regno;
+monitor_fetch_register (int regno)

 {
   char *name;
 {
   char *name;

-  static char zerobuf[MAX_REGISTER_RAW_SIZE] =
-  {0};
-  char regbuf[MAX_REGISTER_RAW_SIZE * 2 + 1];
+  char *zerobuf;
+  char *regbuf;

   int i;
 
   int i;
 

+  regbuf  = alloca (MAX_REGISTER_RAW_SIZE * 2 + 1);
+  zerobuf = alloca (MAX_REGISTER_RAW_SIZE);
+  memset (zerobuf, 0, MAX_REGISTER_RAW_SIZE);
+

   name = current_monitor->regnames[regno];
   monitor_debug ("MON fetchreg %d '%s'\n", regno, name ? name : "(null name)");
 
   name = current_monitor->regnames[regno];
   monitor_debug ("MON fetchreg %d '%s'\n", regno, name ? name : "(null name)");
 


@@ -1319,7 +1273,7 @@ monitor_dump_reg_block (char *block_cmd)
 /* Call the specific function if it has been provided */
 
 static void
 /* Call the specific function if it has been provided */
 
 static void

-monitor_dump_regs ()
+monitor_dump_regs (void)

 {
   char buf[TARGET_BUF_SIZE];
   int resp_len;
 {
   char buf[TARGET_BUF_SIZE];
   int resp_len;


@@ -1332,12 +1286,11 @@ monitor_dump_regs ()
       parse_register_dump (buf, resp_len);
     }
   else
       parse_register_dump (buf, resp_len);
     }
   else

-    abort ();                  /* Need some way to read registers */
+    internal_error (__FILE__, __LINE__, "failed internal consistency check");                  /* Need some way to read registers */

 }
 
 static void
 }
 
 static void

-monitor_fetch_registers (regno)
-     int regno;
+monitor_fetch_registers (int regno)

 {
   monitor_debug ("MON fetchregs\n");
   if (current_monitor->getreg.cmd)
 {
   monitor_debug ("MON fetchregs\n");
   if (current_monitor->getreg.cmd)


@@ -1360,8 +1313,7 @@ monitor_fetch_registers (regno)
 /* Store register REGNO, or all if REGNO == 0.  Return errno value.  */
 
 static void
 /* Store register REGNO, or all if REGNO == 0.  Return errno value.  */
 
 static void

-monitor_store_register (regno)
-     int regno;
+monitor_store_register (int regno)

 {
   char *name;
   ULONGEST val;
 {
   char *name;
   ULONGEST val;


@@ -1374,7 +1326,8 @@ monitor_store_register (regno)
     }
 
   val = read_register (regno);
     }
 
   val = read_register (regno);

-  monitor_debug ("MON storeg %d %s\n", regno, preg (val));
+  monitor_debug ("MON storeg %d %s\n", regno,
+                phex (val, REGISTER_RAW_SIZE (regno)));

 
   /* send the register deposit command */
 
 
   /* send the register deposit command */
 


@@ -1406,8 +1359,7 @@ monitor_store_register (regno)
 /* Store the remote registers.  */
 
 static void
 /* Store the remote registers.  */
 
 static void

-monitor_store_registers (regno)
-     int regno;
+monitor_store_registers (int regno)

 {
   if (regno >= 0)
     {
 {
   if (regno >= 0)
     {


@@ -1426,23 +1378,19 @@ monitor_store_registers (regno)
    debugged.  */
 
 static void
    debugged.  */
 
 static void

-monitor_prepare_to_store ()
+monitor_prepare_to_store (void)

 {
   /* Do nothing, since we can store individual regs */
 }
 
 static void
 {
   /* Do nothing, since we can store individual regs */
 }
 
 static void

-monitor_files_info (ops)
-     struct target_ops *ops;
+monitor_files_info (struct target_ops *ops)

 {
   printf_unfiltered ("\tAttached to %s at %d baud.\n", dev_name, baud_rate);
 }
 
 static int
 {
   printf_unfiltered ("\tAttached to %s at %d baud.\n", dev_name, baud_rate);
 }
 
 static int

-monitor_write_memory (memaddr, myaddr, len)
-     CORE_ADDR memaddr;
-     char *myaddr;
-     int len;
+monitor_write_memory (CORE_ADDR memaddr, char *myaddr, int len)

 {
   unsigned int val, hostval;
   char *cmd;
 {
   unsigned int val, hostval;
   char *cmd;


@@ -1538,10 +1486,7 @@ monitor_write_memory (memaddr, myaddr, len)
 
 
 static int
 
 
 static int

-monitor_write_even_block (memaddr, myaddr, len)
-     CORE_ADDR memaddr;
-     char *myaddr;
-     int len;
+monitor_write_even_block (CORE_ADDR memaddr, char *myaddr, int len)

 {
   unsigned int val;
   int written = 0;;
 {
   unsigned int val;
   int written = 0;;


@@ -1568,10 +1513,7 @@ monitor_write_even_block (memaddr, myaddr, len)
 
 
 static int
 
 
 static int

-monitor_write_memory_bytes (memaddr, myaddr, len)
-     CORE_ADDR memaddr;
-     char *myaddr;
-     int len;
+monitor_write_memory_bytes (CORE_ADDR memaddr, char *myaddr, int len)

 {
   unsigned char val;
   int written = 0;
 {
   unsigned char val;
   int written = 0;


@@ -1663,10 +1605,7 @@ longlong_hexchars (unsigned long long value,
    Which possably entails endian conversions
  */
 static int
    Which possably entails endian conversions
  */
 static int

-monitor_write_memory_longlongs (memaddr, myaddr, len)
-     CORE_ADDR memaddr;
-     char *myaddr;
-     int len;
+monitor_write_memory_longlongs (CORE_ADDR memaddr, char *myaddr, int len)

 {
   static char hexstage[20];    /* At least 16 digits required, plus null */
   char *endstring;
 {
   static char hexstage[20];    /* At least 16 digits required, plus null */
   char *endstring;


@@ -1714,10 +1653,7 @@ monitor_write_memory_longlongs (memaddr, myaddr, len)
  */
 
 static int
  */
 
 static int

-monitor_write_memory_block (memaddr, myaddr, len)
-     CORE_ADDR memaddr;
-     char *myaddr;
-     int len;
+monitor_write_memory_block (CORE_ADDR memaddr, char *myaddr, int len)

 {
   int written;
   written = 0;
 {
   int written;
   written = 0;


@@ -1747,10 +1683,7 @@ monitor_write_memory_block (memaddr, myaddr, len)
    which can only read a single byte/word/etc. at a time.  */
 
 static int
    which can only read a single byte/word/etc. at a time.  */
 
 static int

-monitor_read_memory_single (memaddr, myaddr, len)
-     CORE_ADDR memaddr;
-     char *myaddr;
-     int len;
+monitor_read_memory_single (CORE_ADDR memaddr, char *myaddr, int len)

 {
   unsigned int val;
   char membuf[sizeof (int) * 2 + 1];
 {
   unsigned int val;
   char membuf[sizeof (int) * 2 + 1];


@@ -1877,10 +1810,7 @@ monitor_read_memory_single (memaddr, myaddr, len)
    than 16 bytes at a time.  */
 
 static int
    than 16 bytes at a time.  */
 
 static int

-monitor_read_memory (memaddr, myaddr, len)
-     CORE_ADDR memaddr;
-     char *myaddr;
-     int len;
+monitor_read_memory (CORE_ADDR memaddr, char *myaddr, int len)

 {
   unsigned int val;
   char buf[512];
 {
   unsigned int val;
   char buf[512];


@@ -2053,19 +1983,34 @@ monitor_read_memory (memaddr, myaddr, len)
   return len;
 }
 
   return len;
 }
 

+/* Transfer LEN bytes between target address MEMADDR and GDB address
+   MYADDR.  Returns 0 for success, errno code for failure. TARGET is
+   unused. */
+

 static int
 static int

-monitor_xfer_memory (memaddr, myaddr, len, write, target)
-     CORE_ADDR memaddr;
-     char *myaddr;
-     int len;
-     int write;
-     struct target_ops *target;        /* ignored */
+monitor_xfer_memory (CORE_ADDR memaddr, char *myaddr, int len, int write,
+                    struct mem_attrib *attrib ATTRIBUTE_UNUSED,
+                    struct target_ops *target ATTRIBUTE_UNUSED)

 {
 {

-  return dcache_xfer_memory (remote_dcache, memaddr, myaddr, len, write);
+  int res;
+
+  if (write)
+    {
+      if (current_monitor->flags & MO_HAS_BLOCKWRITES)
+       res = monitor_write_memory_block(memaddr, myaddr, len);
+      else
+       res = monitor_write_memory(memaddr, myaddr, len);
+    }
+  else
+    {
+      res = monitor_read_memory(memaddr, myaddr, len);
+    }
+
+  return res;

 }
 
 static void
 }
 
 static void

-monitor_kill ()
+monitor_kill (void)

 {
   return;                      /* ignore attempts to kill target system */
 }
 {
   return;                      /* ignore attempts to kill target system */
 }


@@ -2074,10 +2019,7 @@ monitor_kill ()
    the program at that point.  */
 
 static void
    the program at that point.  */
 
 static void

-monitor_create_inferior (exec_file, args, env)
-     char *exec_file;
-     char *args;
-     char **env;
+monitor_create_inferior (char *exec_file, char *args, char **env)

 {
   if (args && (*args != '\000'))
     error ("Args are not supported by the monitor.");
 {
   if (args && (*args != '\000'))
     error ("Args are not supported by the monitor.");


@@ -2093,7 +2035,7 @@ monitor_create_inferior (exec_file, args, env)
    instructions.  */
 
 static void
    instructions.  */
 
 static void

-monitor_mourn_inferior ()
+monitor_mourn_inferior (void)

 {
   unpush_target (targ_ops);
   generic_mourn_inferior ();   /* Do all the proper things now */
 {
   unpush_target (targ_ops);
   generic_mourn_inferior ();   /* Do all the proper things now */


@@ -2102,9 +2044,7 @@ monitor_mourn_inferior ()
 /* Tell the monitor to add a breakpoint.  */
 
 static int
 /* Tell the monitor to add a breakpoint.  */
 
 static int

-monitor_insert_breakpoint (addr, shadow)
-     CORE_ADDR addr;
-     char *shadow;
+monitor_insert_breakpoint (CORE_ADDR addr, char *shadow)

 {
   int i;
   unsigned char *bp;
 {
   int i;
   unsigned char *bp;


@@ -2138,9 +2078,7 @@ monitor_insert_breakpoint (addr, shadow)
 /* Tell the monitor to remove a breakpoint.  */
 
 static int
 /* Tell the monitor to remove a breakpoint.  */
 
 static int

-monitor_remove_breakpoint (addr, shadow)
-     CORE_ADDR addr;
-     char *shadow;
+monitor_remove_breakpoint (CORE_ADDR addr, char *shadow)

 {
   int i;
 
 {
   int i;
 


@@ -2177,7 +2115,7 @@ monitor_remove_breakpoint (addr, shadow)
    an S-record.  Return non-zero if the ACK is received properly.  */
 
 static int
    an S-record.  Return non-zero if the ACK is received properly.  */
 
 static int

-monitor_wait_srec_ack ()
+monitor_wait_srec_ack (void)

 {
   int ch;
 
 {
   int ch;
 


@@ -2203,11 +2141,8 @@ monitor_wait_srec_ack ()
 /* monitor_load -- download a file. */
 
 static void
 /* monitor_load -- download a file. */
 
 static void

-monitor_load (file, from_tty)
-     char *file;
-     int from_tty;
+monitor_load (char *file, int from_tty)

 {
 {

-  dcache_flush (remote_dcache);

   monitor_debug ("MON load\n");
 
   if (current_monitor->load_routine)
   monitor_debug ("MON load\n");
 
   if (current_monitor->load_routine)


@@ -2254,7 +2189,7 @@ monitor_load (file, from_tty)
 }
 
 static void
 }
 
 static void

-monitor_stop ()
+monitor_stop (void)

 {
   monitor_debug ("MON stop\n");
   if ((current_monitor->flags & MO_SEND_BREAK_ON_STOP) != 0)
 {
   monitor_debug ("MON stop\n");
   if ((current_monitor->flags & MO_SEND_BREAK_ON_STOP) != 0)


@@ -2294,8 +2229,7 @@ monitor_rcmd (char *command,
 
 #if 0
 static int
 
 #if 0
 static int

-from_hex (a)
-     int a;
+from_hex (int a)

 {
   if (a >= '0' && a <= '9')
     return a - '0';
 {
   if (a >= '0' && a <= '9')
     return a - '0';


@@ -2309,7 +2243,7 @@ from_hex (a)
 #endif
 
 char *
 #endif
 
 char *

-monitor_get_dev_name ()
+monitor_get_dev_name (void)

 {
   return dev_name;
 }
 {
   return dev_name;
 }


@@ -2388,8 +2322,7 @@ init_base_monitor_ops (void)
 /* Init the target_ops structure pointed at by OPS */
 
 void
 /* Init the target_ops structure pointed at by OPS */
 
 void

-init_monitor_ops (ops)
-     struct target_ops *ops;
+init_monitor_ops (struct target_ops *ops)

 {
   if (monitor_ops.to_magic != OPS_MAGIC)
     init_base_monitor_ops ();
 {
   if (monitor_ops.to_magic != OPS_MAGIC)
     init_base_monitor_ops ();


@@ -2400,7 +2333,7 @@ init_monitor_ops (ops)
 /* Define additional commands that are usually only used by monitors.  */
 
 void
 /* Define additional commands that are usually only used by monitors.  */
 
 void

-_initialize_remote_monitors ()
+_initialize_remote_monitors (void)

 {
   init_base_monitor_ops ();
   add_show_from_set (add_set_cmd ("hash", no_class, var_boolean,
 {
   init_base_monitor_ops ();
   add_show_from_set (add_set_cmd ("hash", no_class, var_boolean,


@@ -2410,15 +2343,11 @@ When enabled, a hashmark \'#\' is displayed.",
                                  &setlist),
                     &showlist);
 
                                  &setlist),
                     &showlist);
 

-#if 0
-  /* FIXME: cagney/1999-10-07: Wait until there is a generic ``set
-     debug ...'' rather than another ``set ...debug'' command. */

   add_show_from_set
   add_show_from_set

-    (add_set_cmd ("monitordebug", no_class, var_zinteger,
+    (add_set_cmd ("monitor", no_class, var_zinteger,

                  (char *) &monitor_debug_p,
                  "Set debugging of remote monitor communication.\n\
 When enabled, communication between GDB and the remote monitor\n\
                  (char *) &monitor_debug_p,
                  "Set debugging of remote monitor communication.\n\
 When enabled, communication between GDB and the remote monitor\n\

-is displayed.", &setlist),
-     &showlist);
-#endif
+is displayed.", &setdebuglist),
+     &showdebuglist);

 }
 }