projects
/
deliverable
/
binutils-gdb.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Revert "GDB: Remote target can now accept the form unix::/path/to/socket."
[deliverable/binutils-gdb.git]
/
gdb
/
serial.c
diff --git
a/gdb/serial.c
b/gdb/serial.c
index abc050ec49d0bc525ba98619372c43dda86cab6b..7f9362a3bf35550fdc5cad7a5ec4c8668c637538 100644
(file)
--- a/
gdb/serial.c
+++ b/
gdb/serial.c
@@
-1,6
+1,6
@@
/* Generic serial interface routines
/* Generic serial interface routines
- Copyright (C) 1992-201
5
Free Software Foundation, Inc.
+ Copyright (C) 1992-201
8
Free Software Foundation, Inc.
This file is part of GDB.
This file is part of GDB.
@@
-23,18
+23,13
@@
#include "gdbcmd.h"
#include "cli/cli-utils.h"
#include "gdbcmd.h"
#include "cli/cli-utils.h"
-extern void _initialize_serial (void);
-
/* Is serial being debugged? */
static unsigned int global_serial_debug_p;
/* Is serial being debugged? */
static unsigned int global_serial_debug_p;
-typedef const struct serial_ops *serial_ops_p;
-DEF_VEC_P (serial_ops_p);
-
/* Serial I/O handlers. */
/* Serial I/O handlers. */
-
VEC (serial_ops_p) *serial_ops_list = NULL
;
+
static std::vector<const struct serial_ops *> serial_ops_list
;
/* Pointer to list of scb's. */
/* Pointer to list of scb's. */
@@
-148,10
+143,7
@@
serial_log_command (struct target_ops *self, const char *cmd)
static const struct serial_ops *
serial_interface_lookup (const char *name)
{
static const struct serial_ops *
serial_interface_lookup (const char *name)
{
- const struct serial_ops *ops;
- int i;
-
- for (i = 0; VEC_iterate (serial_ops_p, serial_ops_list, i, ops); ++i)
+ for (const serial_ops *ops : serial_ops_list)
if (strcmp (name, ops->name) == 0)
return ops;
if (strcmp (name, ops->name) == 0)
return ops;
@@
-161,7
+153,7
@@
serial_interface_lookup (const char *name)
void
serial_add_interface (const struct serial_ops *optable)
{
void
serial_add_interface (const struct serial_ops *optable)
{
-
VEC_safe_push (serial_ops_p, serial_ops_list,
optable);
+
serial_ops_list.push_back (
optable);
}
/* Return the open serial device for FD, if found, or NULL if FD is
}
/* Return the open serial device for FD, if found, or NULL if FD is
@@
-179,25
+171,41
@@
serial_for_fd (int fd)
return NULL;
}
return NULL;
}
+/* Create a new serial for OPS. */
+
+static struct serial *
+new_serial (const struct serial_ops *ops)
+{
+ struct serial *scb;
+
+ scb = XCNEW (struct serial);
+
+ scb->ops = ops;
+
+ scb->bufp = scb->buf;
+ scb->error_fd = -1;
+ scb->refcnt = 1;
+
+ return scb;
+}
+
+static struct serial *serial_open_ops_1 (const struct serial_ops *ops,
+ const char *open_name);
+
/* Open up a device or a network socket, depending upon the syntax of NAME. */
struct serial *
serial_open (const char *name)
{
/* Open up a device or a network socket, depending upon the syntax of NAME. */
struct serial *
serial_open (const char *name)
{
- struct serial *scb;
const struct serial_ops *ops;
const char *open_name = name;
const struct serial_ops *ops;
const char *open_name = name;
- if (strcmp (name, "pc") == 0)
- ops = serial_interface_lookup ("pc");
- else if (startswith (name, "lpt"))
- ops = serial_interface_lookup ("parallel");
- else if (startswith (name, "|"))
+ if (startswith (name, "|"))
{
ops = serial_interface_lookup ("pipe");
/* Discard ``|'' and any space before the command itself. */
++open_name;
{
ops = serial_interface_lookup ("pipe");
/* Discard ``|'' and any space before the command itself. */
++open_name;
- open_name = skip_spaces
_const
(open_name);
+ open_name = skip_spaces (open_name);
}
/* Check for a colon, suggesting an IP address/port pair.
Do this *after* checking for all the interesting prefixes. We
}
/* Check for a colon, suggesting an IP address/port pair.
Do this *after* checking for all the interesting prefixes. We
@@
-205,19
+213,32
@@
serial_open (const char *name)
else if (strchr (name, ':'))
ops = serial_interface_lookup ("tcp");
else
else if (strchr (name, ':'))
ops = serial_interface_lookup ("tcp");
else
- ops = serial_interface_lookup ("hardwire");
+ {
+#ifndef USE_WIN32API
+ /* Check to see if name is a socket. If it is, then treat it
+ as such. Otherwise assume that it's a character device. */
+ struct stat sb;
+ if (stat (name, &sb) == 0 && (sb.st_mode & S_IFMT) == S_IFSOCK)
+ ops = serial_interface_lookup ("local");
+ else
+#endif
+ ops = serial_interface_lookup ("hardwire");
+ }
if (!ops)
return NULL;
if (!ops)
return NULL;
- scb = XNEW (struct serial);
+ return serial_open_ops_1 (ops, open_name);
+}
- scb->ops = ops;
+/* Open up a serial for OPS, passing OPEN_NAME to the open method. */
- scb->bufcnt = 0;
- scb->bufp = scb->buf;
- scb->error_fd = -1;
- scb->refcnt = 1;
+static struct serial *
+serial_open_ops_1 (const struct serial_ops *ops, const char *open_name)
+{
+ struct serial *scb;
+
+ scb = new_serial (ops);
/* `...->open (...)' would get expanded by the open(2) syscall macro. */
if ((*scb->ops->open) (scb, open_name))
/* `...->open (...)' would get expanded by the open(2) syscall macro. */
if ((*scb->ops->open) (scb, open_name))
@@
-226,24
+247,30
@@
serial_open (const char *name)
return NULL;
}
return NULL;
}
- scb->name = xstrdup (name);
scb->next = scb_base;
scb->next = scb_base;
- scb->debug_p = 0;
- scb->async_state = 0;
- scb->async_handler = NULL;
- scb->async_context = NULL;
scb_base = scb;
if (serial_logfile != NULL)
{
scb_base = scb;
if (serial_logfile != NULL)
{
- serial_logfp = gdb_fopen (serial_logfile, "w");
- if (serial_logfp == NULL)
+ stdio_file_up file (new stdio_file ());
+
+ if (!file->open (serial_logfile, "w"))
perror_with_name (serial_logfile);
perror_with_name (serial_logfile);
+
+ serial_logfp = file.release ();
}
return scb;
}
}
return scb;
}
+/* See serial.h. */
+
+struct serial *
+serial_open_ops (const struct serial_ops *ops)
+{
+ return serial_open_ops_1 (ops, NULL);
+}
+
/* Open a new serial stream using a file handle, using serial
interface ops OPS. */
/* Open a new serial stream using a file handle, using serial
interface ops OPS. */
@@
-262,21
+289,9
@@
serial_fdopen_ops (const int fd, const struct serial_ops *ops)
if (!ops)
return NULL;
if (!ops)
return NULL;
- scb = XCNEW (struct serial);
-
- scb->ops = ops;
+ scb = new_serial (ops);
- scb->bufcnt = 0;
- scb->bufp = scb->buf;
- scb->error_fd = -1;
- scb->refcnt = 1;
-
- scb->name = NULL;
scb->next = scb_base;
scb->next = scb_base;
- scb->debug_p = 0;
- scb->async_state = 0;
- scb->async_handler = NULL;
- scb->async_context = NULL;
scb_base = scb;
if ((ops->fdopen) != NULL)
scb_base = scb;
if ((ops->fdopen) != NULL)
@@
-304,7
+319,7
@@
do_serial_close (struct serial *scb, int really_close)
serial_current_type = 0;
/* XXX - What if serial_logfp == gdb_stdout or gdb_stderr? */
serial_current_type = 0;
/* XXX - What if serial_logfp == gdb_stdout or gdb_stderr? */
-
ui_file_delete (serial_logfp)
;
+
delete serial_logfp
;
serial_logfp = NULL;
}
serial_logfp = NULL;
}
@@
-315,9
+330,6
@@
do_serial_close (struct serial *scb, int really_close)
if (really_close)
scb->ops->close (scb);
if (really_close)
scb->ops->close (scb);
- if (scb->name)
- xfree (scb->name);
-
/* For serial_is_open. */
scb->bufp = NULL;
/* For serial_is_open. */
scb->bufp = NULL;
@@
-432,16
+444,14
@@
serial_write (struct serial *scb, const void *buf, size_t count)
}
void
}
void
-serial_printf (struct serial *desc, const char *format,...)
+serial_printf (struct serial *desc, const char *format,
...)
{
va_list args;
{
va_list args;
- char *buf;
va_start (args, format);
va_start (args, format);
-
buf = xstr
vprintf (format, args);
- serial_write (desc, buf
, strlen (buf
));
+
std::string buf = string_
vprintf (format, args);
+ serial_write (desc, buf
.c_str (), buf.length (
));
- xfree (buf);
va_end (args);
}
va_end (args);
}
@@
-504,14
+514,6
@@
serial_print_tty_state (struct serial *scb,
scb->ops->print_tty_state (scb, ttystate, stream);
}
scb->ops->print_tty_state (scb, ttystate, stream);
}
-int
-serial_noflush_set_tty_state (struct serial *scb,
- serial_ttystate new_ttystate,
- serial_ttystate old_ttystate)
-{
- return scb->ops->noflush_set_tty_state (scb, new_ttystate, old_ttystate);
-}
-
int
serial_setbaudrate (struct serial *scb, int rate)
{
int
serial_setbaudrate (struct serial *scb, int rate)
{
@@
-618,7
+620,7
@@
static struct cmd_list_element *serial_set_cmdlist;
static struct cmd_list_element *serial_show_cmdlist;
static void
static struct cmd_list_element *serial_show_cmdlist;
static void
-serial_set_cmd (char *args, int from_tty)
+serial_set_cmd (c
onst c
har *args, int from_tty)
{
printf_unfiltered ("\"set serial\" must be followed "
"by the name of a command.\n");
{
printf_unfiltered ("\"set serial\" must be followed "
"by the name of a command.\n");
@@
-626,7
+628,7
@@
serial_set_cmd (char *args, int from_tty)
}
static void
}
static void
-serial_show_cmd (char *args, int from_tty)
+serial_show_cmd (c
onst c
har *args, int from_tty)
{
cmd_show_list (serial_show_cmdlist, from_tty, "");
}
{
cmd_show_list (serial_show_cmdlist, from_tty, "");
}
@@
-660,7
+662,7
@@
static const char *parity = parity_none;
/* Set serial_parity value. */
static void
/* Set serial_parity value. */
static void
-set_parity (char *ignore_args, int from_tty, struct cmd_list_element *c)
+set_parity (c
onst c
har *ignore_args, int from_tty, struct cmd_list_element *c)
{
if (parity == parity_odd)
serial_parity = GDBPARITY_ODD;
{
if (parity == parity_odd)
serial_parity = GDBPARITY_ODD;
This page took
0.027627 seconds
and
4
git commands to generate.