KVM: PPC: Book3S PR: Rework kvmppc_mmu_book3s_64_xlate()
[deliverable/linux.git] / arch / powerpc / kvm / book3s_64_mmu.c
index b871721c0050e8e3f04353f80c925f63c89afded..7e345e00661a73065a85fc1c6d0a2e4ef7e44108 100644 (file)
@@ -26,6 +26,7 @@
 #include <asm/tlbflush.h>
 #include <asm/kvm_ppc.h>
 #include <asm/kvm_book3s.h>
+#include <asm/mmu-hash64.h>
 
 /* #define DEBUG_MMU */
 
@@ -76,6 +77,24 @@ static struct kvmppc_slb *kvmppc_mmu_book3s_64_find_slbe(
        return NULL;
 }
 
+static int kvmppc_slb_sid_shift(struct kvmppc_slb *slbe)
+{
+       return slbe->tb ? SID_SHIFT_1T : SID_SHIFT;
+}
+
+static u64 kvmppc_slb_offset_mask(struct kvmppc_slb *slbe)
+{
+       return (1ul << kvmppc_slb_sid_shift(slbe)) - 1;
+}
+
+static u64 kvmppc_slb_calc_vpn(struct kvmppc_slb *slb, gva_t eaddr)
+{
+       eaddr &= kvmppc_slb_offset_mask(slb);
+
+       return (eaddr >> VPN_SHIFT) |
+               ((slb->vsid) << (kvmppc_slb_sid_shift(slb) - VPN_SHIFT));
+}
+
 static u64 kvmppc_mmu_book3s_64_ea_to_vp(struct kvm_vcpu *vcpu, gva_t eaddr,
                                         bool data)
 {
@@ -85,11 +104,7 @@ static u64 kvmppc_mmu_book3s_64_ea_to_vp(struct kvm_vcpu *vcpu, gva_t eaddr,
        if (!slb)
                return 0;
 
-       if (slb->tb)
-               return (((u64)eaddr >> 12) & 0xfffffff) |
-                      (((u64)slb->vsid) << 28);
-
-       return (((u64)eaddr >> 12) & 0xffff) | (((u64)slb->vsid) << 16);
+       return kvmppc_slb_calc_vpn(slb, eaddr);
 }
 
 static int kvmppc_mmu_book3s_64_get_pagesize(struct kvmppc_slb *slbe)
@@ -100,7 +115,8 @@ static int kvmppc_mmu_book3s_64_get_pagesize(struct kvmppc_slb *slbe)
 static u32 kvmppc_mmu_book3s_64_get_page(struct kvmppc_slb *slbe, gva_t eaddr)
 {
        int p = kvmppc_mmu_book3s_64_get_pagesize(slbe);
-       return ((eaddr & 0xfffffff) >> p);
+
+       return ((eaddr & kvmppc_slb_offset_mask(slbe)) >> p);
 }
 
 static hva_t kvmppc_mmu_book3s_64_get_pteg(
@@ -109,13 +125,15 @@ static hva_t kvmppc_mmu_book3s_64_get_pteg(
                                bool second)
 {
        u64 hash, pteg, htabsize;
-       u32 page;
+       u32 ssize;
        hva_t r;
+       u64 vpn;
 
-       page = kvmppc_mmu_book3s_64_get_page(slbe, eaddr);
        htabsize = ((1 << ((vcpu_book3s->sdr1 & 0x1f) + 11)) - 1);
 
-       hash = slbe->vsid ^ page;
+       vpn = kvmppc_slb_calc_vpn(slbe, eaddr);
+       ssize = slbe->tb ? MMU_SEGSIZE_1T : MMU_SEGSIZE_256M;
+       hash = hpt_hash(vpn, kvmppc_mmu_book3s_64_get_pagesize(slbe), ssize);
        if (second)
                hash = ~hash;
        hash &= ((1ULL << 39ULL) - 1ULL);
@@ -146,7 +164,7 @@ static u64 kvmppc_mmu_book3s_64_get_avpn(struct kvmppc_slb *slbe, gva_t eaddr)
        u64 avpn;
 
        avpn = kvmppc_mmu_book3s_64_get_page(slbe, eaddr);
-       avpn |= slbe->vsid << (28 - p);
+       avpn |= slbe->vsid << (kvmppc_slb_sid_shift(slbe) - p);
 
        if (p < 24)
                avpn >>= ((80 - p) - 56) - 8;
@@ -164,11 +182,13 @@ static int kvmppc_mmu_book3s_64_xlate(struct kvm_vcpu *vcpu, gva_t eaddr,
        hva_t ptegp;
        u64 pteg[16];
        u64 avpn = 0;
+       u64 v, r;
+       u64 v_val, v_mask;
+       u64 eaddr_mask;
        int i;
-       u8 key = 0;
+       u8 pp, key = 0;
        bool found = false;
-       bool perm_err = false;
-       int second = 0;
+       bool second = false;
        ulong mp_ea = vcpu->arch.magic_page_ea;
 
        /* Magic page override */
@@ -190,13 +210,23 @@ static int kvmppc_mmu_book3s_64_xlate(struct kvm_vcpu *vcpu, gva_t eaddr,
        if (!slbe)
                goto no_seg_found;
 
+       avpn = kvmppc_mmu_book3s_64_get_avpn(slbe, eaddr);
+       v_val = avpn & HPTE_V_AVPN;
+
+       if (slbe->tb)
+               v_val |= SLB_VSID_B_1T;
+       if (slbe->large)
+               v_val |= HPTE_V_LARGE;
+       v_val |= HPTE_V_VALID;
+
+       v_mask = SLB_VSID_B | HPTE_V_AVPN | HPTE_V_LARGE | HPTE_V_VALID |
+               HPTE_V_SECONDARY;
+
 do_second:
        ptegp = kvmppc_mmu_book3s_64_get_pteg(vcpu_book3s, slbe, eaddr, second);
        if (kvm_is_error_hva(ptegp))
                goto no_page_found;
 
-       avpn = kvmppc_mmu_book3s_64_get_avpn(slbe, eaddr);
-
        if(copy_from_user(pteg, (void __user *)ptegp, sizeof(pteg))) {
                printk(KERN_ERR "KVM can't copy data from 0x%lx!\n", ptegp);
                goto no_page_found;
@@ -208,101 +238,75 @@ do_second:
                key = 4;
 
        for (i=0; i<16; i+=2) {
-               u64 v = pteg[i];
-               u64 r = pteg[i+1];
-
-               /* Valid check */
-               if (!(v & HPTE_V_VALID))
-                       continue;
-               /* Hash check */
-               if ((v & HPTE_V_SECONDARY) != second)
-                       continue;
-
-               /* AVPN compare */
-               if (HPTE_V_AVPN_VAL(avpn) == HPTE_V_AVPN_VAL(v)) {
-                       u8 pp = (r & HPTE_R_PP) | key;
-                       int eaddr_mask = 0xFFF;
-
-                       gpte->eaddr = eaddr;
-                       gpte->vpage = kvmppc_mmu_book3s_64_ea_to_vp(vcpu,
-                                                                   eaddr,
-                                                                   data);
-                       if (slbe->large)
-                               eaddr_mask = 0xFFFFFF;
-                       gpte->raddr = (r & HPTE_R_RPN) | (eaddr & eaddr_mask);
-                       gpte->may_execute = ((r & HPTE_R_N) ? false : true);
-                       gpte->may_read = false;
-                       gpte->may_write = false;
-
-                       switch (pp) {
-                       case 0:
-                       case 1:
-                       case 2:
-                       case 6:
-                               gpte->may_write = true;
-                               /* fall through */
-                       case 3:
-                       case 5:
-                       case 7:
-                               gpte->may_read = true;
-                               break;
-                       }
-
-                       if (!gpte->may_read) {
-                               perm_err = true;
-                               continue;
-                       }
-
-                       dprintk("KVM MMU: Translated 0x%lx [0x%llx] -> 0x%llx "
-                               "-> 0x%lx\n",
-                               eaddr, avpn, gpte->vpage, gpte->raddr);
+               /* Check all relevant fields of 1st dword */
+               if ((pteg[i] & v_mask) == v_val) {
                        found = true;
                        break;
                }
        }
 
-       /* Update PTE R and C bits, so the guest's swapper knows we used the
-        * page */
-       if (found) {
-               u32 oldr = pteg[i+1];
-
-               if (gpte->may_read) {
-                       /* Set the accessed flag */
-                       pteg[i+1] |= HPTE_R_R;
-               }
-               if (gpte->may_write) {
-                       /* Set the dirty flag */
-                       pteg[i+1] |= HPTE_R_C;
-               } else {
-                       dprintk("KVM: Mapping read-only page!\n");
-               }
-
-               /* Write back into the PTEG */
-               if (pteg[i+1] != oldr)
-                       copy_to_user((void __user *)ptegp, pteg, sizeof(pteg));
+       if (!found) {
+               if (second)
+                       goto no_page_found;
+               v_val |= HPTE_V_SECONDARY;
+               second = true;
+               goto do_second;
+       }
 
-               return 0;
-       } else {
-               dprintk("KVM MMU: No PTE found (ea=0x%lx sdr1=0x%llx "
-                       "ptegp=0x%lx)\n",
-                       eaddr, to_book3s(vcpu)->sdr1, ptegp);
-               for (i = 0; i < 16; i += 2)
-                       dprintk("   %02d: 0x%llx - 0x%llx (0x%llx)\n",
-                               i, pteg[i], pteg[i+1], avpn);
-
-               if (!second) {
-                       second = HPTE_V_SECONDARY;
-                       goto do_second;
-               }
+       v = pteg[i];
+       r = pteg[i+1];
+       pp = (r & HPTE_R_PP) | key;
+       eaddr_mask = 0xFFF;
+
+       gpte->eaddr = eaddr;
+       gpte->vpage = kvmppc_mmu_book3s_64_ea_to_vp(vcpu, eaddr, data);
+       if (slbe->large)
+               eaddr_mask = 0xFFFFFF;
+       gpte->raddr = (r & HPTE_R_RPN & ~eaddr_mask) | (eaddr & eaddr_mask);
+       gpte->may_execute = ((r & HPTE_R_N) ? false : true);
+       gpte->may_read = false;
+       gpte->may_write = false;
+
+       switch (pp) {
+       case 0:
+       case 1:
+       case 2:
+       case 6:
+               gpte->may_write = true;
+               /* fall through */
+       case 3:
+       case 5:
+       case 7:
+               gpte->may_read = true;
+               break;
        }
 
+       dprintk("KVM MMU: Translated 0x%lx [0x%llx] -> 0x%llx "
+               "-> 0x%lx\n",
+               eaddr, avpn, gpte->vpage, gpte->raddr);
 
-no_page_found:
+       /* Update PTE R and C bits, so the guest's swapper knows we used the
+        * page */
+       if (gpte->may_read) {
+               /* Set the accessed flag */
+               r |= HPTE_R_R;
+       }
+       if (data && gpte->may_write) {
+               /* Set the dirty flag -- XXX even if not writing */
+               r |= HPTE_R_C;
+       }
 
+       /* Write back into the PTEG */
+       if (pteg[i+1] != r) {
+               pteg[i+1] = r;
+               copy_to_user((void __user *)ptegp, pteg, sizeof(pteg));
+       }
 
-       if (perm_err)
+       if (!gpte->may_read)
                return -EPERM;
+       return 0;
 
+no_page_found:
        return -ENOENT;
 
 no_seg_found:
@@ -334,7 +338,7 @@ static void kvmppc_mmu_book3s_64_slbmte(struct kvm_vcpu *vcpu, u64 rs, u64 rb)
        slbe->large = (rs & SLB_VSID_L) ? 1 : 0;
        slbe->tb    = (rs & SLB_VSID_B_1T) ? 1 : 0;
        slbe->esid  = slbe->tb ? esid_1t : esid;
-       slbe->vsid  = rs >> 12;
+       slbe->vsid  = (rs & ~SLB_VSID_B) >> (kvmppc_slb_sid_shift(slbe) - 16);
        slbe->valid = (rb & SLB_ESID_V) ? 1 : 0;
        slbe->Ks    = (rs & SLB_VSID_KS) ? 1 : 0;
        slbe->Kp    = (rs & SLB_VSID_KP) ? 1 : 0;
@@ -375,6 +379,7 @@ static u64 kvmppc_mmu_book3s_64_slbmfev(struct kvm_vcpu *vcpu, u64 slb_nr)
 static void kvmppc_mmu_book3s_64_slbie(struct kvm_vcpu *vcpu, u64 ea)
 {
        struct kvmppc_slb *slbe;
+       u64 seg_size;
 
        dprintk("KVM MMU: slbie(0x%llx)\n", ea);
 
@@ -386,8 +391,11 @@ static void kvmppc_mmu_book3s_64_slbie(struct kvm_vcpu *vcpu, u64 ea)
        dprintk("KVM MMU: slbie(0x%llx, 0x%llx)\n", ea, slbe->esid);
 
        slbe->valid = false;
+       slbe->orige = 0;
+       slbe->origv = 0;
 
-       kvmppc_mmu_map_segment(vcpu, ea);
+       seg_size = 1ull << kvmppc_slb_sid_shift(slbe);
+       kvmppc_mmu_flush_segment(vcpu, ea & ~(seg_size - 1), seg_size);
 }
 
 static void kvmppc_mmu_book3s_64_slbia(struct kvm_vcpu *vcpu)
@@ -396,8 +404,11 @@ static void kvmppc_mmu_book3s_64_slbia(struct kvm_vcpu *vcpu)
 
        dprintk("KVM MMU: slbia()\n");
 
-       for (i = 1; i < vcpu->arch.slb_nr; i++)
+       for (i = 1; i < vcpu->arch.slb_nr; i++) {
                vcpu->arch.slb[i].valid = false;
+               vcpu->arch.slb[i].orige = 0;
+               vcpu->arch.slb[i].origv = 0;
+       }
 
        if (vcpu->arch.shared->msr & MSR_IR) {
                kvmppc_mmu_flush_segments(vcpu);
@@ -467,8 +478,14 @@ static int kvmppc_mmu_book3s_64_esid_to_vsid(struct kvm_vcpu *vcpu, ulong esid,
 
        if (vcpu->arch.shared->msr & (MSR_DR|MSR_IR)) {
                slb = kvmppc_mmu_book3s_64_find_slbe(vcpu, ea);
-               if (slb)
+               if (slb) {
                        gvsid = slb->vsid;
+                       if (slb->tb) {
+                               gvsid <<= SID_SHIFT_1T - SID_SHIFT;
+                               gvsid |= esid & ((1ul << (SID_SHIFT_1T - SID_SHIFT)) - 1);
+                               gvsid |= VSID_1T;
+                       }
+               }
        }
 
        switch (vcpu->arch.shared->msr & (MSR_DR|MSR_IR)) {
This page took 0.036481 seconds and 5 git commands to generate.