Always pass a valid section header offset to elf_parse_notes

[deliverable/binutils-gdb.git] / bfd / coff-ppc.c

diff --git a/bfd/coff-ppc.c b/bfd/coff-ppc.c
index a931f6a876bc76d67482983a47ac6920630fd352..6755e54f87b529d6f97684d47eb55983b90a495b 100644 (file)
--- a/bfd/coff-ppc.c
+++ b/bfd/coff-ppc.c
@@ -79,9 +79,10 @@ extern void dump_toc (void *);
 #define HASH_CHECK_DCL char eye_catcher[8];
 #define HASH_CHECK_INIT(ret)      strcpy(ret->eye_catcher, EYE)
 #define HASH_CHECK(addr) \
- if (strcmp(addr->eye_catcher, EYE) != 0) \
+ if (strcmp (addr->eye_catcher, EYE) != 0) \
   { \
     fprintf (stderr,\
+    /* xgettext: c-format */ \
     _("File %s, line %d, Hash check failure, bad eye %8s\n"), \
     __FILE__, __LINE__, addr->eye_catcher); \
     abort (); \
@@ -844,7 +845,7 @@ ppc_record_toc_entry (bfd *abfd,
          /* The size must fit in a 16-bit displacement.  */
          if (global_toc_size > 65535)
            {
-             (*_bfd_error_handler) (_("TOC overflow"));
+             _bfd_error_handler (_("TOC overflow"));
              bfd_set_error (bfd_error_file_too_big);
              return FALSE;
            }
@@ -862,7 +863,7 @@ ppc_record_toc_entry (bfd *abfd,
          /* The size must fit in a 16-bit displacement.  */
          if (global_toc_size >= 65535)
            {
-             (*_bfd_error_handler) (_("TOC overflow"));
+             _bfd_error_handler (_("TOC overflow"));
              bfd_set_error (bfd_error_file_too_big);
              return FALSE;
            }
@@ -1037,7 +1038,8 @@ coff_ppc_relocate_section (bfd *output_bfd,
       switch (r_type)
        {
        default:
-         (*_bfd_error_handler)
+         _bfd_error_handler
+           /* xgettext: c-format */
            (_("%B: unsupported relocation type 0x%02x"), input_bfd, r_type);
          bfd_set_error (bfd_error_bad_value);
          return FALSE;
@@ -1127,8 +1129,10 @@ coff_ppc_relocate_section (bfd *output_bfd,
                    /* The size must still fit in a 16-bit displacement.  */
                    if ((bfd_vma) our_toc_offset >= 65535)
                      {
-                       (*_bfd_error_handler)
-                         (_("%B: Relocation for %s of %lx exceeds Toc size limit"),
+                       _bfd_error_handler
+                         /* xgettext: c-format */
+                         (_("%B: Relocation for %s of %lx exceeds "
+                            "Toc size limit"),
                           input_bfd, name,
                           (unsigned long) our_toc_offset);
                        bfd_set_error (bfd_error_bad_value);
@@ -1180,7 +1184,8 @@ coff_ppc_relocate_section (bfd *output_bfd,
            if ((r_flags & IMAGE_REL_PPC_TOCDEFN) != IMAGE_REL_PPC_TOCDEFN
                && (bfd_vma) our_toc_offset > toc_section->size)
              {
-               (*_bfd_error_handler)
+               _bfd_error_handler
+                 /* xgettext: c-format */
                  (_("%B: Relocation exceeds allocated TOC (%lx)"),
                   input_bfd, (unsigned long) toc_section->size);
                bfd_set_error (bfd_error_bad_value);
@@ -1234,7 +1239,8 @@ coff_ppc_relocate_section (bfd *output_bfd,
            else
              my_name = h->root.root.root.string;
 
-           (*_bfd_error_handler)
+           _bfd_error_handler
+             /* xgettext: c-format */
              (_("Warning: unsupported reloc %s <file %B, section %A>\n"
                 "sym %ld (%s), r_vaddr %ld (%lx)"),
               input_bfd, input_section, howto->name,
@@ -1252,7 +1258,8 @@ coff_ppc_relocate_section (bfd *output_bfd,
              break;
            my_name = h->root.root.root.string;
 
-           (*_bfd_error_handler)
+           _bfd_error_handler
+             /* xgettext: c-format */
              (_("%B: Out of order IMGLUE reloc for %s"), input_bfd, my_name);
            bfd_set_error (bfd_error_bad_value);
            return FALSE;
@@ -1483,6 +1490,7 @@ dump_toc (void * vfile)
          else
            {
              fprintf (file,
+                      /* xgettext: c-format */
                      _("**** global_toc_size %ld(%lx), thunk_size %ld(%lx)\n"),
                       global_toc_size, (unsigned long) global_toc_size,
                       thunk_size, (unsigned long) thunk_size);
@@ -1759,9 +1767,10 @@ ppc_coff_rtype2howto (arelent *relent, struct internal_reloc *internal)
        howto = ppc_coff_howto_table + IMAGE_REL_PPC_TOCREL16;
       break;
     default:
-      (*_bfd_error_handler) (_("warning: unsupported reloc %s [%d] used -- it may not work"),
-                            ppc_coff_howto_table[r_type].name,
-                            r_type);
+      _bfd_error_handler
+       /* xgettext: c-format */
+       (_("warning: unsupported reloc %s [%d] used -- it may not work"),
+        ppc_coff_howto_table[r_type].name, r_type);
       howto = ppc_coff_howto_table + r_type;
       break;
     }
@@ -1830,9 +1839,10 @@ coff_ppc_rtype_to_howto (bfd *abfd ATTRIBUTE_UNUSED,
       howto = ppc_coff_howto_table + r_type;
       break;
     default:
-      (*_bfd_error_handler) (_("warning: unsupported reloc %s [%d] used -- it may not work"),
-                            ppc_coff_howto_table[r_type].name,
-                            r_type);
+      _bfd_error_handler
+       /* xgettext: c-format */
+       (_("warning: unsupported reloc %s [%d] used -- it may not work"),
+        ppc_coff_howto_table[r_type].name, r_type);
       howto = ppc_coff_howto_table + r_type;
       break;
     }