gdb/testsuite: Add compiler options parameter to function_range helper
[deliverable/binutils-gdb.git] / gdb / elfread.c
index 9a6ce0ee37168f011e0ee64e2b36614d8e78e461..42c4e77785f36f5c6aa1ec118dc1e45298a30da5 100644 (file)
@@ -49,6 +49,8 @@
 #include "mdebugread.h"
 #include "ctfread.h"
 #include "gdbsupport/gdb_string_view.h"
+#include "gdbsupport/scoped_fd.h"
+#include "debuginfod-support.h"
 
 /* Forward declarations.  */
 extern const struct sym_fns elf_sym_fns_gdb_index;
@@ -210,11 +212,16 @@ record_minimal_symbol (minimal_symbol_reader &reader,
       || ms_type == mst_text_gnu_ifunc)
     address = gdbarch_addr_bits_remove (gdbarch, address);
 
+  /* We only setup section information for allocatable sections.  Usually
+     we'd only expect to find msymbols for allocatable sections, but if the
+     ELF is malformed then this might not be the case.  In that case don't
+     create an msymbol that references an uninitialised section object.  */
+  int section_index = 0;
+  if ((bfd_section_flags (bfd_section) & SEC_ALLOC) == SEC_ALLOC)
+    section_index = gdb_bfd_section_index (objfile->obfd, bfd_section);
+
   struct minimal_symbol *result
-    = reader.record_full (name, copy_name, address,
-                         ms_type,
-                         gdb_bfd_section_index (objfile->obfd,
-                                                bfd_section));
+    = reader.record_full (name, copy_name, address, ms_type, section_index);
   if ((objfile->flags & OBJF_MAINLINE) == 0
       && (ms_type == mst_data || ms_type == mst_bss))
     result->maybe_copied = 1;
@@ -348,11 +355,7 @@ elf_symtab_read (minimal_symbol_reader &reader,
       if (type == ST_DYNAMIC && !stripped)
        continue;
       if (sym->flags & BSF_FILE)
-       {
-         filesymname
-           = ((const char *) objfile->per_bfd->filename_cache.insert
-              (sym->name, strlen (sym->name) + 1));
-       }
+       filesymname = objfile->intern (sym->name);
       else if (sym->flags & BSF_SECTION_SYM)
        continue;
       else if (sym->flags & (BSF_GLOBAL | BSF_LOCAL | BSF_WEAK
@@ -1311,8 +1314,36 @@ elf_symfile_read (struct objfile *objfile, symfile_add_flags symfile_flags)
          symbol_file_add_separate (debug_bfd.get (), debugfile.c_str (),
                                    symfile_flags, objfile);
        }
-       else
+      else
+       {
          has_dwarf2 = false;
+         const struct bfd_build_id *build_id = build_id_bfd_get (objfile->obfd);
+
+         if (build_id != nullptr)
+           {
+             gdb::unique_xmalloc_ptr<char> symfile_path;
+             scoped_fd fd (debuginfod_debuginfo_query (build_id->data,
+                                                       build_id->size,
+                                                       objfile->original_name,
+                                                       &symfile_path));
+
+             if (fd.get () >= 0)
+               {
+                 /* File successfully retrieved from server.  */
+                 gdb_bfd_ref_ptr debug_bfd (symfile_bfd_open (symfile_path.get ()));
+
+                 if (debug_bfd == nullptr)
+                   warning (_("File \"%s\" from debuginfod cannot be opened as bfd"),
+                            objfile->original_name);
+                 else if (build_id_verify (debug_bfd.get (), build_id->size, build_id->data))
+                   {
+                     symbol_file_add_separate (debug_bfd.get (), symfile_path.get (),
+                                               symfile_flags, objfile);
+                     has_dwarf2 = true;
+                   }
+               }
+           }
+       }
     }
 
   /* Read the CTF section only if there is no DWARF info.  */
This page took 0.026263 seconds and 4 git commands to generate.