Make gdbreplay use more common routines

[deliverable/binutils-gdb.git] / gdb / gcore.in

diff --git a/gdb/gcore.in b/gdb/gcore.in
index 5a80eff88c46a9656267cc863dc6208b86ba33fb..233c00d3664826658b5690c1542434a6d30882b1 100644 (file)
--- a/gdb/gcore.in
+++ b/gdb/gcore.in
@@ -1,6 +1,6 @@
-#!/bin/sh
+#!/usr/bin/env bash
 
-#   Copyright (C) 2003-2015 Free Software Foundation, Inc.
+#   Copyright (C) 2003-2018 Free Software Foundation, Inc.
 
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -20,27 +20,39 @@
 # It starts up gdb, attaches to the given PID and invokes the gcore command.
 #
 
-if [ "$#" -eq "0" ]
-then
-    echo "usage:  @GCORE_TRANSFORM_NAME@ [-o filename] pid"
-    exit 2
-fi
-
 # Need to check for -o option, but set default basename to "core".
 name=core
 
-if [ "$1" = "-o" ]
+# When the -a option is present, this may hold additional commands
+# to ensure gdb dumps all mappings (OS dependent).
+dump_all_cmds=()
+
+while getopts :ao: opt; do
+    case "$opt" in
+        a)
+            case "$OSTYPE" in
+                linux*)
+                    dump_all_cmds=("-ex" "set use-coredump-filter off")
+                    dump_all_cmds+=("-ex" "set dump-excluded-mappings on")
+                    ;;
+            esac
+            ;;
+        o)
+            name=$OPTARG
+            ;;
+        *)
+            echo "usage:  @GCORE_TRANSFORM_NAME@ [-a] [-o filename] pid"
+            exit 2
+            ;;
+    esac
+done
+
+shift $((OPTIND-1))
+
+if [ "$#" -eq "0" ]
 then
-    if [ "$#" -lt "3" ]
-    then
-       # Not enough arguments.
-       echo "usage:  @GCORE_TRANSFORM_NAME@ [-o filename] pid"
-       exit 2
-    fi
-    name=$2
-
-    # Shift over to start of pid list
-    shift; shift
+    echo "usage:  @GCORE_TRANSFORM_NAME@ [-a] [-o filename] pid"
+    exit 2
 fi
 
 # Attempt to fetch the absolute path to the gcore script that was
@@ -72,7 +84,7 @@ fi
 
 # Check if the GDB binary is in the expected path.  If not, just
 # quit with a message.
-if [ ! -f "$binary_path"/@GDB_TRANSFORM_NAME@ ]; then
+if [ ! -f "$binary_path/@GDB_TRANSFORM_NAME@" ]; then
   echo "gcore: GDB binary (${binary_path}/@GDB_TRANSFORM_NAME@) not found"
   exit 1
 fi
@@ -81,15 +93,16 @@ fi
 rc=0
 
 # Loop through pids
-for pid in $*
+for pid in "$@"
 do
        # `</dev/null' to avoid touching interactive terminal if it is
        # available but not accessible as GDB would get stopped on SIGTTIN.
-       $binary_path/@GDB_TRANSFORM_NAME@ </dev/null --nx --batch \
+       "$binary_path/@GDB_TRANSFORM_NAME@" </dev/null --nx --batch \
            -ex "set pagination off" -ex "set height 0" -ex "set width 0" \
+           "${dump_all_cmds[@]}" \
            -ex "attach $pid" -ex "gcore $name.$pid" -ex detach -ex quit
 
-       if [ -r $name.$pid ] ; then 
+       if [ -r "$name.$pid" ] ; then
            rc=0
        else
            echo "@GCORE_TRANSFORM_NAME@: failed to create $name.$pid"