Remove some uses of "object_files"
[deliverable/binutils-gdb.git] / gdb / linespec.c
index b1ab462e663770d3389e030174a350e1ae49af71..c42ddba731510dfab7a128515323ae02ec099a4b 100644 (file)
@@ -1130,7 +1130,6 @@ iterate_over_all_matching_symtabs
    struct program_space *search_pspace, bool include_inline,
    gdb::function_view<symbol_found_callback_ftype> callback)
 {
-  struct objfile *objfile;
   struct program_space *pspace;
 
   ALL_PSPACES (pspace)
@@ -1142,46 +1141,46 @@ iterate_over_all_matching_symtabs
 
     set_current_program_space (pspace);
 
-    ALL_OBJFILES (objfile)
-    {
-      struct compunit_symtab *cu;
-
-      if (objfile->sf)
-       objfile->sf->qf->expand_symtabs_matching (objfile,
-                                                 NULL,
-                                                 lookup_name,
-                                                 NULL, NULL,
-                                                 search_domain);
-
-      ALL_OBJFILE_COMPUNITS (objfile, cu)
-       {
-         struct symtab *symtab = COMPUNIT_FILETABS (cu);
+    for (objfile *objfile : current_program_space->objfiles ())
+      {
+       if (objfile->sf)
+         objfile->sf->qf->expand_symtabs_matching (objfile,
+                                                   NULL,
+                                                   lookup_name,
+                                                   NULL, NULL,
+                                                   search_domain);
+
+       for (compunit_symtab *cu : objfile->compunits ())
+         {
+           struct symtab *symtab = COMPUNIT_FILETABS (cu);
 
-         iterate_over_file_blocks (symtab, lookup_name, name_domain, callback);
+           iterate_over_file_blocks (symtab, lookup_name, name_domain,
+                                     callback);
 
-         if (include_inline)
-           {
-             struct block *block;
-             int i;
+           if (include_inline)
+             {
+               const struct block *block;
+               int i;
 
-             for (i = FIRST_LOCAL_BLOCK;
-                  i < BLOCKVECTOR_NBLOCKS (SYMTAB_BLOCKVECTOR (symtab));
-                  i++)
-               {
-                 block = BLOCKVECTOR_BLOCK (SYMTAB_BLOCKVECTOR (symtab), i);
-                 state->language->la_iterate_over_symbols
-                   (block, lookup_name, name_domain, [&] (block_symbol *bsym)
-                    {
-                      /* Restrict calls to CALLBACK to symbols
-                         representing inline symbols only.  */
-                      if (SYMBOL_INLINED (bsym->symbol))
-                        return callback (bsym);
-                      return true;
-                    });
-               }
-           }
-       }
-    }
+               for (i = FIRST_LOCAL_BLOCK;
+                    i < BLOCKVECTOR_NBLOCKS (SYMTAB_BLOCKVECTOR (symtab));
+                    i++)
+                 {
+                   block = BLOCKVECTOR_BLOCK (SYMTAB_BLOCKVECTOR (symtab), i);
+                   state->language->la_iterate_over_symbols
+                     (block, lookup_name, name_domain,
+                      [&] (block_symbol *bsym)
+                      {
+                        /* Restrict calls to CALLBACK to symbols
+                           representing inline symbols only.  */
+                        if (SYMBOL_INLINED (bsym->symbol))
+                          return callback (bsym);
+                        return true;
+                      });
+                 }
+             }
+         }
+      }
   }
 }
 
@@ -1191,16 +1190,10 @@ iterate_over_all_matching_symtabs
 static const struct block *
 get_current_search_block (void)
 {
-  const struct block *block;
-  enum language save_language;
-
   /* get_selected_block can change the current language when there is
      no selected frame yet.  */
-  save_language = current_language->la_language;
-  block = get_selected_block (0);
-  set_language (save_language);
-
-  return block;
+  scoped_restore_current_language save_language;
+  return get_selected_block (0);
 }
 
 /* Iterate over static and global blocks.  */
@@ -1210,7 +1203,7 @@ iterate_over_file_blocks
   (struct symtab *symtab, const lookup_name_info &name,
    domain_enum domain, gdb::function_view<symbol_found_callback_ftype> callback)
 {
-  struct block *block;
+  const struct block *block;
 
   for (block = BLOCKVECTOR_BLOCK (SYMTAB_BLOCKVECTOR (symtab), STATIC_BLOCK);
        block != NULL;
@@ -1251,17 +1244,6 @@ find_methods (struct type *t, enum language t_lang, const char *name,
           --method_counter)
        {
          const char *method_name = TYPE_FN_FIELDLIST_NAME (t, method_counter);
-         char dem_opname[64];
-
-         if (startswith (method_name, "__") ||
-             startswith (method_name, "op") ||
-             startswith (method_name, "type"))
-           {
-             if (cplus_demangle_opname (method_name, dem_opname, DMGL_ANSI))
-               method_name = dem_opname;
-             else if (cplus_demangle_opname (method_name, dem_opname, 0))
-               method_name = dem_opname;
-           }
 
          if (symbol_name_compare (method_name, lookup_name, NULL))
            {
@@ -1457,7 +1439,7 @@ convert_results_to_lsals (struct linespec_state *self,
 
 /* A structure that contains two string representations of a struct
    linespec_canonical_name:
-     - one where the the symtab's fullname is used;
+     - one where the symtab's fullname is used;
      - one where the filename followed the "set filename-display"
        setting.  */
 
@@ -2114,16 +2096,14 @@ create_sals_line_offset (struct linespec_state *self,
   if (ls->file_symtabs->size () == 1
       && ls->file_symtabs->front () == nullptr)
     {
-      const char *fullname;
-
       set_current_program_space (self->program_space);
 
       /* Make sure we have at least a default source line.  */
       set_default_source_symtab_and_line ();
       initialize_defaults (&self->default_symtab, &self->default_line);
-      fullname = symtab_to_fullname (self->default_symtab);
       *ls->file_symtabs
-       = collect_symtabs_from_filename (fullname, self->search_pspace);
+       = collect_symtabs_from_filename (self->default_symtab->filename,
+                                        self->search_pspace);
       use_default = 1;
     }
 
@@ -2403,16 +2383,15 @@ convert_explicit_location_to_linespec (struct linespec_state *self,
 
   if (source_filename != NULL)
     {
-      TRY
+      try
        {
          *result->file_symtabs
            = symtabs_from_filename (source_filename, self->search_pspace);
        }
-      CATCH (except, RETURN_MASK_ERROR)
+      catch (const gdb_exception_error &except)
        {
          source_file_not_found_error (source_filename);
        }
-      END_CATCH
       result->explicit_loc.source_filename = xstrdup (source_filename);
     }
   else
@@ -2628,17 +2607,16 @@ parse_linespec (linespec_parser *parser, const char *arg,
       gdb::unique_xmalloc_ptr<char> user_filename = copy_token_string (token);
 
       /* Check if the input is a filename.  */
-      TRY
+      try
        {
          *PARSER_RESULT (parser)->file_symtabs
            = symtabs_from_filename (user_filename.get (),
                                     PARSER_STATE (parser)->search_pspace);
        }
-      CATCH (ex, RETURN_MASK_ERROR)
+      catch (const gdb_exception_error &ex)
        {
          file_exception = ex;
        }
-      END_CATCH
 
       if (file_exception.reason >= 0)
        {
@@ -2767,6 +2745,7 @@ static void
 linespec_state_destructor (struct linespec_state *self)
 {
   htab_delete (self->addr_set);
+  xfree (self->canonical_names);
 }
 
 /* Delete a linespec parser.  */
@@ -2942,7 +2921,7 @@ linespec_complete_label (completion_tracker &tracker,
 
   line_offset unknown_offset = { 0, LINE_OFFSET_UNKNOWN };
 
-  TRY
+  try
     {
       convert_explicit_location_to_linespec (PARSER_STATE (&parser),
                                             PARSER_RESULT (&parser),
@@ -2951,11 +2930,10 @@ linespec_complete_label (completion_tracker &tracker,
                                             func_name_match_type,
                                             NULL, unknown_offset);
     }
-  CATCH (ex, RETURN_MASK_ERROR)
+  catch (const gdb_exception_error &ex)
     {
       return;
     }
-  END_CATCH
 
   complete_label (tracker, &parser, label_name);
 }
@@ -2978,14 +2956,13 @@ linespec_complete (completion_tracker &tracker, const char *text,
 
   /* Parse as much as possible.  parser.completion_word will hold
      furthest completion point we managed to parse to.  */
-  TRY
+  try
     {
       parse_linespec (&parser, text, match_type);
     }
-  CATCH (except, RETURN_MASK_ERROR)
+  catch (const gdb_exception_error &except)
     {
     }
-  END_CATCH
 
   if (parser.completion_quote_char != '\0'
       && parser.completion_quote_end != NULL
@@ -3167,17 +3144,16 @@ event_location_to_sals (linespec_parser *parser,
     case LINESPEC_LOCATION:
       {
        PARSER_STATE (parser)->is_linespec = 1;
-       TRY
+       try
          {
            const linespec_location *ls = get_linespec_location (location);
            result = parse_linespec (parser,
                                     ls->spec_string, ls->match_type);
          }
-       CATCH (except, RETURN_MASK_ERROR)
+       catch (const gdb_exception_error &except)
          {
-           throw_exception (except);
+           throw;
          }
-       END_CATCH
       }
       break;
 
@@ -3978,7 +3954,7 @@ find_linespec_symbols (struct linespec_state *state,
       if (!classes.empty ())
        {
          /* Now locate a list of suitable methods named METHOD.  */
-         TRY
+         try
            {
              find_method (state, file_symtabs,
                           klass.c_str (), method.c_str (),
@@ -3987,12 +3963,11 @@ find_linespec_symbols (struct linespec_state *state,
 
          /* If successful, we're done.  If NOT_FOUND_ERROR
             was not thrown, rethrow the exception that we did get.  */
-         CATCH (except, RETURN_MASK_ERROR)
+         catch (const gdb_exception_error &except)
            {
              if (except.error != NOT_FOUND_ERROR)
-               throw_exception (except);
+               throw;
            }
-         END_CATCH
        }
     }
 }
@@ -4361,8 +4336,6 @@ search_minsyms_for_name (struct collect_info *info,
 
       ALL_PSPACES (pspace)
       {
-       struct objfile *objfile;
-
        if (search_pspace != NULL && search_pspace != pspace)
          continue;
        if (pspace->executing_startup)
@@ -4370,17 +4343,17 @@ search_minsyms_for_name (struct collect_info *info,
 
        set_current_program_space (pspace);
 
-       ALL_OBJFILES (objfile)
-       {
-         iterate_over_minimal_symbols (objfile, name,
-                                       [&] (struct minimal_symbol *msym)
+       for (objfile *objfile : current_program_space->objfiles ())
+         {
+           iterate_over_minimal_symbols (objfile, name,
+                                         [&] (struct minimal_symbol *msym)
                                          {
                                            add_minsym (msym, objfile, nullptr,
                                                        info->state->list_mode,
                                                        &minsyms);
                                            return false;
                                          });
-       }
+         }
       }
     }
   else
This page took 0.027819 seconds and 4 git commands to generate.