[gdb] Fix more typos in comments
[deliverable/binutils-gdb.git] / gdb / mdebugread.c
index 2b54fef051aa74e01efd3a2880e878f6909f3c23..557d0e4817a0cb39ce0cd0ca20135bfc0930360c 100644 (file)
@@ -187,7 +187,7 @@ static const struct ecoff_debug_swap *debug_swap;
 
 static struct ecoff_debug_info *debug_info;
 
-/* Pointer to current file decriptor record, and its index.  */
+/* Pointer to current file descriptor record, and its index.  */
 
 static FDR *cur_fdr;
 static int cur_fd;
@@ -348,7 +348,7 @@ mdebug_build_psymtabs (minimal_symbol_reader &reader,
   init_header_files ();
         
   /* Make sure all the FDR information is swapped in.  */
-  if (info->fdr == (FDR *) NULL)
+  if (info->fdr == NULL)
     {
       char *fdr_src;
       char *fdr_end;
@@ -593,7 +593,7 @@ parse_symbol (SYMR *sh, union aux_ext *ax, char *ext_sh, int bigend,
   long svalue = sh->value;
   int bitsize;
 
-  if (ext_sh == (char *) NULL)
+  if (ext_sh == NULL)
     name = debug_info->ssext + sh->iss;
   else
     name = debug_info->ss + cur_fdr->issBase + sh->iss;
@@ -632,7 +632,7 @@ parse_symbol (SYMR *sh, union aux_ext *ax, char *ext_sh, int bigend,
       b = BLOCKVECTOR_BLOCK (SYMTAB_BLOCKVECTOR (top_stack->cur_st),
                             GLOBAL_BLOCK);
       s = new_symbol (name);
-      SYMBOL_VALUE_ADDRESS (s) = (CORE_ADDR) sh->value;
+      SET_SYMBOL_VALUE_ADDRESS (s, (CORE_ADDR) sh->value);
       add_data_symbol (sh, ax, bigend, s, LOC_STATIC, b, objfile, name);
       break;
 
@@ -649,7 +649,7 @@ parse_symbol (SYMR *sh, union aux_ext *ax, char *ext_sh, int bigend,
          global_sym_chain[bucket] = s;
        }
       else
-       SYMBOL_VALUE_ADDRESS (s) = (CORE_ADDR) sh->value;
+       SET_SYMBOL_VALUE_ADDRESS (s, (CORE_ADDR) sh->value);
       add_data_symbol (sh, ax, bigend, s, LOC_STATIC, b, objfile, name);
       break;
 
@@ -706,7 +706,7 @@ parse_symbol (SYMR *sh, union aux_ext *ax, char *ext_sh, int bigend,
       s = new_symbol (name);
       SYMBOL_DOMAIN (s) = VAR_DOMAIN;  /* So that it can be used */
       SYMBOL_ACLASS_INDEX (s) = LOC_LABEL;     /* but not misused.  */
-      SYMBOL_VALUE_ADDRESS (s) = (CORE_ADDR) sh->value;
+      SET_SYMBOL_VALUE_ADDRESS (s, (CORE_ADDR) sh->value);
       SYMBOL_TYPE (s) = objfile_type (objfile)->builtin_int;
       add_symbol (s, top_stack->cur_st, top_stack->cur_block);
       break;
@@ -1005,7 +1005,7 @@ parse_symbol (SYMR *sh, union aux_ext *ax, char *ext_sh, int bigend,
 
        /* Create a new type or use the pending type.  */
        pend = is_pending_symbol (cur_fdr, ext_sh);
-       if (pend == (struct mdebug_pending *) NULL)
+       if (pend == NULL)
          {
            t = new_type (NULL);
            add_pending (cur_fdr, ext_sh, t);
@@ -1066,8 +1066,8 @@ parse_symbol (SYMR *sh, union aux_ext *ax, char *ext_sh, int bigend,
                enum_sym = allocate_symbol (mdebugread_objfile);
                SYMBOL_SET_LINKAGE_NAME
                  (enum_sym,
-                  (char *) obstack_copy0 (&mdebugread_objfile->objfile_obstack,
-                                          f->name, strlen (f->name)));
+                  obstack_strdup (&mdebugread_objfile->objfile_obstack,
+                                  f->name));
                SYMBOL_ACLASS_INDEX (enum_sym) = LOC_CONST;
                SYMBOL_TYPE (enum_sym) = t;
                SYMBOL_DOMAIN (enum_sym) = VAR_DOMAIN;
@@ -1267,9 +1267,9 @@ parse_symbol (SYMR *sh, union aux_ext *ax, char *ext_sh, int bigend,
 
       /* Parse the type or use the pending type.  */
       pend = is_pending_symbol (cur_fdr, ext_sh);
-      if (pend == (struct mdebug_pending *) NULL)
+      if (pend == NULL)
        {
-         t = parse_type (cur_fd, ax, sh->index, (int *) NULL, bigend, name);
+         t = parse_type (cur_fd, ax, sh->index, NULL, bigend, name);
          add_pending (cur_fdr, ext_sh, t);
        }
       else
@@ -1579,7 +1579,7 @@ parse_type (int fd, union aux_ext *ax, unsigned int aux_index, int *bs,
       int width = AUX_GET_WIDTH (bigend, ax);
 
       /* Inhibit core dumps if TIR is corrupted.  */
-      if (bs == (int *) NULL)
+      if (bs == NULL)
        {
          /* Alpha cc -migrate encodes char and unsigned char types
             as short and unsigned short types with a field width of 8.
@@ -1626,7 +1626,7 @@ parse_type (int fd, union aux_ext *ax, unsigned int aux_index, int *bs,
       xref_fh = get_rfd (fd, rf);
       xref_fd = xref_fh - debug_info->fdr;
       tp = parse_type (xref_fd, debug_info->external_aux + xref_fh->iauxBase,
-                   rn->index, (int *) NULL, xref_fh->fBigendian, sym_name);
+                   rn->index, NULL, xref_fh->fBigendian, sym_name);
     }
 
   /* All these types really point to some (common) MIPS type
@@ -1644,7 +1644,7 @@ parse_type (int fd, union aux_ext *ax, unsigned int aux_index, int *bs,
 
       /* Try to cross reference this type, build new type on failure.  */
       ax += cross_ref (fd, ax, &tp, type_code, &name, bigend, sym_name);
-      if (tp == (struct type *) NULL)
+      if (tp == NULL)
        tp = init_type (mdebugread_objfile, type_code, 0, NULL);
 
       /* DEC c89 produces cross references to qualified aggregate types,
@@ -1688,9 +1688,7 @@ parse_type (int fd, union aux_ext *ax, unsigned int aux_index, int *bs,
          else if (TYPE_NAME (tp) == NULL
                   || strcmp (TYPE_NAME (tp), name) != 0)
            TYPE_NAME (tp)
-             = ((const char *)
-                obstack_copy0 (&mdebugread_objfile->objfile_obstack,
-                               name, strlen (name)));
+             = obstack_strdup (&mdebugread_objfile->objfile_obstack, name);
        }
     }
 
@@ -1704,7 +1702,7 @@ parse_type (int fd, union aux_ext *ax, unsigned int aux_index, int *bs,
 
       /* Try to cross reference this type, build new type on failure.  */
       ax += cross_ref (fd, ax, &tp, type_code, &name, bigend, sym_name);
-      if (tp == (struct type *) NULL)
+      if (tp == NULL)
        tp = init_type (mdebugread_objfile, type_code, 0, NULL);
 
       /* Make sure that TYPE_CODE(tp) has an expected type code.
@@ -1726,9 +1724,7 @@ parse_type (int fd, union aux_ext *ax, unsigned int aux_index, int *bs,
          if (TYPE_NAME (tp) == NULL
              || strcmp (TYPE_NAME (tp), name) != 0)
            TYPE_NAME (tp)
-             = ((const char *)
-                obstack_copy0 (&mdebugread_objfile->objfile_obstack,
-                               name, strlen (name)));
+             = obstack_strdup (&mdebugread_objfile->objfile_obstack, name);
        }
     }
   if (t->bt == btTypedef)
@@ -1737,7 +1733,7 @@ parse_type (int fd, union aux_ext *ax, unsigned int aux_index, int *bs,
 
       /* Try to cross reference this type, it should succeed.  */
       ax += cross_ref (fd, ax, &tp, type_code, &name, bigend, sym_name);
-      if (tp == (struct type *) NULL)
+      if (tp == NULL)
        {
          complaint (_("unable to cross ref btTypedef for %s"), sym_name);
          tp = basic_type (btInt, mdebugread_objfile);
@@ -1841,7 +1837,7 @@ upgrade_type (int fd, struct type **tpp, int tq, union aux_ext *ax, int bigend,
 
       indx = parse_type (fh - debug_info->fdr,
                         debug_info->external_aux + fh->iauxBase,
-                        id, (int *) NULL, bigend, sym_name);
+                        id, NULL, bigend, sym_name);
 
       /* The bounds type should be an integer type, but might be anything
          else due to corrupt aux entries.  */
@@ -1860,10 +1856,9 @@ upgrade_type (int fd, struct type **tpp, int tq, union aux_ext *ax, int bigend,
       ax++;
       rf = AUX_GET_WIDTH (bigend, ax); /* bit size of array element */
 
-      range = create_static_range_type ((struct type *) NULL, indx,
-                                       lower, upper);
+      range = create_static_range_type (NULL, indx, lower, upper);
 
-      t = create_array_type ((struct type *) NULL, *tpp, range);
+      t = create_array_type (NULL, *tpp, range);
 
       /* We used to fill in the supplied array element bitsize
          here if the TYPE_LENGTH of the target type was zero.
@@ -1998,7 +1993,7 @@ parse_procedure (PDR *pr, struct compunit_symtab *search_symtab,
       s = new_symbol (sh_name);
       SYMBOL_DOMAIN (s) = VAR_DOMAIN;
       SYMBOL_CLASS (s) = LOC_BLOCK;
-      /* Donno its type, hope int is ok.  */
+      /* Don't know its type, hope int is ok.  */
       SYMBOL_TYPE (s)
        = lookup_function_type (objfile_type (pst->objfile)->builtin_int);
       add_symbol (s, top_stack->cur_st, top_stack->cur_block);
@@ -2144,7 +2139,7 @@ parse_external (EXTR *es, int bigend, struct section_offsets *section_offsets,
 
       /* Note that the case of a symbol with indexNil must be handled
          anyways by parse_symbol().  */
-      parse_symbol (&es->asym, ax, (char *) NULL,
+      parse_symbol (&es->asym, ax, NULL,
                    bigend, section_offsets, objfile);
       break;
     default:
@@ -2343,7 +2338,7 @@ parse_partial_symbols (minimal_symbol_reader &reader,
      the text section (and fh->adr) really starts at zero.  */
   text_sect = bfd_get_section_by_name (cur_bfd, ".text");
   if (text_sect != NULL
-      && (bfd_get_section_flags (cur_bfd, text_sect) & SEC_RELOC))
+      && (bfd_section_flags (text_sect) & SEC_RELOC))
     relocatable = 1;
 
   extern_tab = XOBNEWVEC (&objfile->objfile_obstack, EXTR, hdr->iextMax);
@@ -2447,7 +2442,7 @@ parse_partial_symbols (minimal_symbol_reader &reader,
      (inefficient; 
      assumes no side-effects result from ignoring ECOFF symbol)
      3) create it, but lookup ELF's minimal symbol and use it's section
-     during relocation, then modify "uniqify" phase to merge and 
+     during relocation, then modify "uniquify" phase to merge and
      eliminate the duplicate symbol
      (highly inefficient)
 
@@ -3053,7 +3048,7 @@ parse_partial_symbols (minimal_symbol_reader &reader,
                          namestring = gdbarch_static_transform_name
                                         (gdbarch, namestring);
 
-                       add_psymbol_to_list (namestring, p - namestring, 1,
+                       add_psymbol_to_list (namestring, p - namestring, true,
                                             VAR_DOMAIN, LOC_STATIC,
                                             SECT_OFF_DATA (objfile),
                                             psymbol_placement::STATIC,
@@ -3064,7 +3059,7 @@ parse_partial_symbols (minimal_symbol_reader &reader,
                        /* The addresses in these entries are reported
                           to be wrong.  See the code that reads 'G's
                           for symtabs.  */
-                       add_psymbol_to_list (namestring, p - namestring, 1,
+                       add_psymbol_to_list (namestring, p - namestring, true,
                                             VAR_DOMAIN, LOC_STATIC,
                                             SECT_OFF_DATA (objfile),
                                             psymbol_placement::GLOBAL,
@@ -3083,7 +3078,7 @@ parse_partial_symbols (minimal_symbol_reader &reader,
                            || (p == namestring + 1
                                && namestring[0] != ' '))
                          {
-                           add_psymbol_to_list (namestring, p - namestring, 1,
+                           add_psymbol_to_list (namestring, p - namestring, true,
                                                 STRUCT_DOMAIN, LOC_TYPEDEF,
                                                 -1,
                                                 psymbol_placement::STATIC,
@@ -3092,7 +3087,7 @@ parse_partial_symbols (minimal_symbol_reader &reader,
                              {
                                /* Also a typedef with the same name.  */
                                add_psymbol_to_list (namestring,
-                                                    p - namestring, 1,
+                                                    p - namestring, true,
                                                     VAR_DOMAIN, LOC_TYPEDEF,
                                                     -1,
                                                     psymbol_placement::STATIC,
@@ -3106,8 +3101,8 @@ parse_partial_symbols (minimal_symbol_reader &reader,
                        if (p != namestring)    /* a name is there, not
                                                   just :T...  */
                          {
-                           add_psymbol_to_list (namestring, p - namestring, 1,
-                                                VAR_DOMAIN, LOC_TYPEDEF,
+                           add_psymbol_to_list (namestring, p - namestring,
+                                                true, VAR_DOMAIN, LOC_TYPEDEF,
                                                 -1,
                                                 psymbol_placement::STATIC,
                                                 0, psymtab_language, objfile);
@@ -3171,7 +3166,7 @@ parse_partial_symbols (minimal_symbol_reader &reader,
                                /* Note that the value doesn't matter for
                                   enum constants in psymtabs, just in
                                   symtabs.  */
-                               add_psymbol_to_list (p, q - p, 1,
+                               add_psymbol_to_list (p, q - p, true,
                                                     VAR_DOMAIN, LOC_CONST,
                                                     -1,
                                                     psymbol_placement::STATIC,
@@ -3190,7 +3185,7 @@ parse_partial_symbols (minimal_symbol_reader &reader,
                        continue;
                      case 'c':
                        /* Constant, e.g. from "const" in Pascal.  */
-                       add_psymbol_to_list (namestring, p - namestring, 1,
+                       add_psymbol_to_list (namestring, p - namestring, true,
                                             VAR_DOMAIN, LOC_CONST, -1,
                                             psymbol_placement::STATIC,
                                             0, psymtab_language, objfile);
@@ -3203,7 +3198,7 @@ parse_partial_symbols (minimal_symbol_reader &reader,
                            function_outside_compilation_unit_complaint
                              (copy.c_str ());
                          }
-                       add_psymbol_to_list (namestring, p - namestring, 1,
+                       add_psymbol_to_list (namestring, p - namestring, true,
                                             VAR_DOMAIN, LOC_BLOCK,
                                             SECT_OFF_TEXT (objfile),
                                             psymbol_placement::STATIC,
@@ -3222,7 +3217,7 @@ parse_partial_symbols (minimal_symbol_reader &reader,
                            function_outside_compilation_unit_complaint
                              (copy.c_str ());
                          }
-                       add_psymbol_to_list (namestring, p - namestring, 1,
+                       add_psymbol_to_list (namestring, p - namestring, true,
                                             VAR_DOMAIN, LOC_BLOCK,
                                             SECT_OFF_TEXT (objfile),
                                             psymbol_placement::GLOBAL,
@@ -3447,7 +3442,7 @@ parse_partial_symbols (minimal_symbol_reader &reader,
 
                  /* Usually there is a local and a global stProc symbol
                     for a function.  This means that the function name
-                    has already been entered into the mimimal symbol table
+                    has already been entered into the minimal symbol table
                     while processing the global symbols in pass 2 above.
                     One notable exception is the PROGRAM name from
                     f77 compiled executables, it is only put out as
@@ -3457,13 +3452,13 @@ parse_partial_symbols (minimal_symbol_reader &reader,
                     symbol table, and the MAIN__ symbol via the minimal
                     symbol table.  */
                  if (sh.st == stProc)
-                   add_psymbol_to_list (sym_name, strlen (sym_name), 1,
+                   add_psymbol_to_list (sym_name, strlen (sym_name), true,
                                         VAR_DOMAIN, LOC_BLOCK,
                                         section,
                                         psymbol_placement::GLOBAL,
                                         sh.value, psymtab_language, objfile);
                  else
-                   add_psymbol_to_list (sym_name, strlen (sym_name), 1,
+                   add_psymbol_to_list (sym_name, strlen (sym_name), true,
                                         VAR_DOMAIN, LOC_BLOCK,
                                         section,
                                         psymbol_placement::STATIC,
@@ -3530,7 +3525,7 @@ parse_partial_symbols (minimal_symbol_reader &reader,
                      && sh.iss != 0
                      && sh.index != cur_sdx + 2)
                    {
-                     add_psymbol_to_list (sym_name, strlen (sym_name), 1,
+                     add_psymbol_to_list (sym_name, strlen (sym_name), true,
                                           STRUCT_DOMAIN, LOC_TYPEDEF, -1,
                                           psymbol_placement::STATIC,
                                           0, psymtab_language, objfile);
@@ -3570,7 +3565,7 @@ parse_partial_symbols (minimal_symbol_reader &reader,
                  continue;
                }
              /* Use this gdb symbol.  */
-             add_psymbol_to_list (sym_name, strlen (sym_name), 1,
+             add_psymbol_to_list (sym_name, strlen (sym_name), true,
                                   VAR_DOMAIN, theclass, section,
                                   psymbol_placement::STATIC,
                                   sh.value, psymtab_language, objfile);
@@ -3649,7 +3644,7 @@ parse_partial_symbols (minimal_symbol_reader &reader,
                  break;
                }
              char *sym_name = debug_info->ssext + psh->iss;
-             add_psymbol_to_list (sym_name, strlen (sym_name), 1,
+             add_psymbol_to_list (sym_name, strlen (sym_name), true,
                                   VAR_DOMAIN, theclass,
                                   section,
                                   psymbol_placement::GLOBAL,
@@ -3704,7 +3699,7 @@ parse_partial_symbols (minimal_symbol_reader &reader,
       fh = f_idx + debug_info->fdr;
       pst = fdr_to_pst[f_idx].pst;
 
-      if (pst == (struct partial_symtab *) NULL)
+      if (pst == NULL)
        continue;
 
       /* This should catch stabs-in-ecoff.  */
@@ -3734,8 +3729,8 @@ parse_partial_symbols (minimal_symbol_reader &reader,
          if (rh == f_idx)
            continue;
 
-         /* Do not add to dependeny list if psymtab was empty.  */
-         if (fdr_to_pst[rh].pst == (struct partial_symtab *) NULL)
+         /* Do not add to dependency list if psymtab was empty.  */
+         if (fdr_to_pst[rh].pst == NULL)
            continue;
          pst->dependencies[pst->number_of_dependencies++]
            = fdr_to_pst[rh].pst;
@@ -3812,7 +3807,7 @@ handle_psymbol_enumerators (struct objfile *objfile, FDR *fh, int stype,
 
       /* Note that the value doesn't matter for enum constants
          in psymtabs, just in symtabs.  */
-      add_psymbol_to_list (name, strlen (name), 1,
+      add_psymbol_to_list (name, strlen (name), true,
                           VAR_DOMAIN, LOC_CONST, -1,
                           psymbol_placement::STATIC, 0,
                           psymtab_language, objfile);
@@ -3866,7 +3861,7 @@ psymtab_to_symtab_1 (struct objfile *objfile,
     return;
   pst->readin = 1;
 
-  /* Read in all partial symbtabs on which this one is dependent.
+  /* Read in all partial symtabs on which this one is dependent.
      NOTE that we do have circular dependencies, sigh.  We solved
      that by setting pst->readin before this point.  */
 
@@ -3909,13 +3904,13 @@ psymtab_to_symtab_1 (struct objfile *objfile,
   mdebugread_objfile = objfile;
   cur_fd = FDR_IDX (pst);
   fh = ((cur_fd == -1)
-       ? (FDR *) NULL
+       ? NULL
        : debug_info->fdr + cur_fd);
   cur_fdr = fh;
 
   /* See comment in parse_partial_symbols about the @stabs sentinel.  */
   processing_gcc_compilation = 0;
-  if (fh != (FDR *) NULL && fh->csym >= 2)
+  if (fh != NULL && fh->csym >= 2)
     {
       SYMR sh;
 
@@ -4425,7 +4420,7 @@ cross_ref (int fd, union aux_ext *ax, struct type **tpp,
              *tpp = parse_type (xref_fd,
                                 debug_info->external_aux + fh->iauxBase,
                                 sh.index,
-                                (int *) NULL,
+                                NULL,
                                 fh->fBigendian,
                                 debug_info->ss + fh->issBase + sh.iss);
              add_pending (fh, esh, *tpp);
@@ -4451,7 +4446,7 @@ cross_ref (int fd, union aux_ext *ax, struct type **tpp,
          *tpp = parse_type (xref_fd,
                             debug_info->external_aux + fh->iauxBase,
                             sh.index,
-                            (int *) NULL,
+                            NULL,
                             fh->fBigendian,
                             debug_info->ss + fh->issBase + sh.iss);
        }
This page took 0.031736 seconds and 4 git commands to generate.