Remove ALL_OBJFILES_SAFE
[deliverable/binutils-gdb.git] / gdb / mdebugread.c
index 39276ab3bd450dc89dea00bd8b929ddfeda7e574..bb7e0667831b35d44d2294d694136a00ef57b477 100644 (file)
@@ -1,6 +1,6 @@
 /* Read a symbol table in ECOFF format (Third-Eye).
 
-   Copyright (C) 1986-2018 Free Software Foundation, Inc.
+   Copyright (C) 1986-2019 Free Software Foundation, Inc.
 
    Original version contributed by Alessandro Forin (af@cs.cmu.edu) at
    CMU.  Major work by Per Bothner, John Gilmore and Ian Lance Taylor
@@ -537,13 +537,9 @@ mdebug_reg_to_regnum (struct symbol *sym, struct gdbarch *gdbarch)
 {
   int regno = gdbarch_ecoff_reg_to_regnum (gdbarch, SYMBOL_VALUE (sym));
 
-  if (regno < 0
-      || regno >= (gdbarch_num_regs (gdbarch)
-                  + gdbarch_num_pseudo_regs (gdbarch)))
+  if (regno < 0 || regno >= gdbarch_num_cooked_regs (gdbarch))
     {
-      reg_value_complaint (regno,
-                          gdbarch_num_regs (gdbarch)
-                            + gdbarch_num_pseudo_regs (gdbarch),
+      reg_value_complaint (regno, gdbarch_num_cooked_regs (gdbarch),
                           SYMBOL_PRINT_NAME (sym));
 
       regno = gdbarch_sp_regnum (gdbarch); /* Known safe, though useless.  */
@@ -593,7 +589,6 @@ parse_symbol (SYMR *sh, union aux_ext *ax, char *ext_sh, int bigend,
   struct block *b;
   struct mdebug_pending *pend;
   struct type *t;
-  struct field *f;
   int count = 1;
   TIR tir;
   long svalue = sh->value;
@@ -1155,7 +1150,7 @@ parse_symbol (SYMR *sh, union aux_ext *ax, char *ext_sh, int bigend,
          const struct blockvector *bv
            = SYMTAB_BLOCKVECTOR (top_stack->cur_st);
          struct mdebug_extra_func_info *e;
-         struct block *b = top_stack->cur_block;
+         struct block *cblock = top_stack->cur_block;
          struct type *ftype = top_stack->cur_type;
          int i;
 
@@ -1179,12 +1174,12 @@ parse_symbol (SYMR *sh, union aux_ext *ax, char *ext_sh, int bigend,
            {
              struct block *b_bad = BLOCKVECTOR_BLOCK (bv, i);
 
-             if (BLOCK_SUPERBLOCK (b_bad) == b
+             if (BLOCK_SUPERBLOCK (b_bad) == cblock
                  && BLOCK_START (b_bad) == top_stack->procadr
                  && BLOCK_END (b_bad) == top_stack->procadr)
                {
-                 BLOCK_START (b_bad) = BLOCK_START (b);
-                 BLOCK_END (b_bad) = BLOCK_END (b);
+                 BLOCK_START (b_bad) = BLOCK_START (cblock);
+                 BLOCK_END (b_bad) = BLOCK_END (cblock);
                }
            }
 
@@ -1205,7 +1200,7 @@ parse_symbol (SYMR *sh, union aux_ext *ax, char *ext_sh, int bigend,
                    TYPE_ALLOC (ftype, nparams * sizeof (struct field));
 
                  iparams = 0;
-                 ALL_BLOCK_SYMBOLS (b, iter, sym)
+                 ALL_BLOCK_SYMBOLS (cblock, iter, sym)
                    {
                      if (iparams == nparams)
                        break;
@@ -1246,13 +1241,16 @@ parse_symbol (SYMR *sh, union aux_ext *ax, char *ext_sh, int bigend,
       break;
 
     case stMember:             /* member of struct or union */
-      f = &TYPE_FIELDS (top_stack->cur_type)[top_stack->cur_field++];
-      FIELD_NAME (*f) = name;
-      SET_FIELD_BITPOS (*f, sh->value);
-      bitsize = 0;
-      FIELD_TYPE (*f) = parse_type (cur_fd, ax, sh->index,
-                                   &bitsize, bigend, name);
-      FIELD_BITSIZE (*f) = bitsize;
+      {
+       struct field *f
+         = &TYPE_FIELDS (top_stack->cur_type)[top_stack->cur_field++];
+       FIELD_NAME (*f) = name;
+       SET_FIELD_BITPOS (*f, sh->value);
+       bitsize = 0;
+       FIELD_TYPE (*f) = parse_type (cur_fd, ax, sh->index,
+                                     &bitsize, bigend, name);
+       FIELD_BITSIZE (*f) = bitsize;
+      }
       break;
 
     case stIndirect:           /* forward declaration on Irix5 */
@@ -2383,10 +2381,10 @@ parse_partial_symbols (minimal_symbol_reader &reader,
   fdr_to_pst = fdr_to_pst_holder.data ();
   fdr_to_pst++;
   {
-    struct partial_symtab *pst = new_psymtab ("", objfile);
+    struct partial_symtab *new_pst = new_psymtab ("", objfile);
 
-    fdr_to_pst[-1].pst = pst;
-    FDR_IDX (pst) = -1;
+    fdr_to_pst[-1].pst = new_pst;
+    FDR_IDX (new_pst) = -1;
   }
 
   /* Allocate the global pending list.  */
@@ -2885,7 +2883,7 @@ parse_partial_symbols (minimal_symbol_reader &reader,
                  case N_SO:
                    {
                      static int prev_so_symnum = -10;
-                     const char *p;
+                     const char *basename;
 
                      /* A zero value is probably an indication for the
                         SunPRO 3.0 compiler.  dbx_end_psymtab explicitly tests
@@ -2925,8 +2923,8 @@ parse_partial_symbols (minimal_symbol_reader &reader,
                         the second the file name.  If pst exists, is
                         empty, and has a filename ending in '/', we assume
                         the previous N_SO was a directory name.  */
-                     p = lbasename (namestring);
-                     if (p != namestring && *p == '\000')
+                     basename = lbasename (namestring);
+                     if (basename != namestring && *basename == '\000')
                        continue;               /* Simply ignore directory
                                                   name SOs.  */
 
@@ -3195,13 +3193,9 @@ parse_partial_symbols (minimal_symbol_reader &reader,
                      case 'f':
                        if (! pst)
                          {
-                           int name_len = p - namestring;
-                           char *name = (char *) xmalloc (name_len + 1);
-
-                           memcpy (name, namestring, name_len);
-                           name[name_len] = '\0';
-                           function_outside_compilation_unit_complaint (name);
-                           xfree (name);
+                           std::string copy (namestring, p);
+                           function_outside_compilation_unit_complaint
+                             (copy.c_str ());
                          }
                        add_psymbol_to_list (namestring, p - namestring, 1,
                                             VAR_DOMAIN, LOC_BLOCK,
@@ -3218,13 +3212,9 @@ parse_partial_symbols (minimal_symbol_reader &reader,
                      case 'F':
                        if (! pst)
                          {
-                           int name_len = p - namestring;
-                           char *name = (char *) xmalloc (name_len + 1);
-
-                           memcpy (name, namestring, name_len);
-                           name[name_len] = '\0';
-                           function_outside_compilation_unit_complaint (name);
-                           xfree (name);
+                           std::string copy (namestring, p);
+                           function_outside_compilation_unit_complaint
+                             (copy.c_str ());
                          }
                        add_psymbol_to_list (namestring, p - namestring, 1,
                                             VAR_DOMAIN, LOC_BLOCK,
@@ -3353,7 +3343,7 @@ parse_partial_symbols (minimal_symbol_reader &reader,
        {
          for (cur_sdx = 0; cur_sdx < fh->csym;)
            {
-             char *name;
+             char *sym_name;
              enum address_class theclass;
              CORE_ADDR minsym_value;
              short section = -1;
@@ -3380,7 +3370,7 @@ parse_partial_symbols (minimal_symbol_reader &reader,
                  continue;
                }
 
-             name = debug_info->ss + fh->issBase + sh.iss;
+             sym_name = debug_info->ss + fh->issBase + sh.iss;
 
              minsym_value = sh.value;
 
@@ -3413,7 +3403,7 @@ parse_partial_symbols (minimal_symbol_reader &reader,
                  int new_sdx;
 
                case stStaticProc:
-                 reader.record_with_info (name, minsym_value,
+                 reader.record_with_info (sym_name, minsym_value,
                                           mst_file_text,
                                           SECT_OFF_TEXT (objfile));
 
@@ -3425,7 +3415,7 @@ parse_partial_symbols (minimal_symbol_reader &reader,
                    {
                      /* Should not happen, but does when cross-compiling
                         with the MIPS compiler.  FIXME -- pull later.  */
-                     index_complaint (name);
+                     index_complaint (sym_name);
                      new_sdx = cur_sdx + 1;    /* Don't skip at all.  */
                    }
                  else
@@ -3438,7 +3428,7 @@ parse_partial_symbols (minimal_symbol_reader &reader,
                    {
                      /* This should not happen either... FIXME.  */
                      complaint (_("bad proc end in aux found from symbol %s"),
-                                name);
+                                sym_name);
                      new_sdx = cur_sdx + 1;    /* Don't skip backward.  */
                    }
 
@@ -3464,13 +3454,13 @@ parse_partial_symbols (minimal_symbol_reader &reader,
                     symbol table, and the MAIN__ symbol via the minimal
                     symbol table.  */
                  if (sh.st == stProc)
-                   add_psymbol_to_list (name, strlen (name), 1,
+                   add_psymbol_to_list (sym_name, strlen (sym_name), 1,
                                         VAR_DOMAIN, LOC_BLOCK,
                                         section,
                                         &objfile->global_psymbols,
                                         sh.value, psymtab_language, objfile);
                  else
-                   add_psymbol_to_list (name, strlen (name), 1,
+                   add_psymbol_to_list (sym_name, strlen (sym_name), 1,
                                         VAR_DOMAIN, LOC_BLOCK,
                                         section,
                                         &objfile->static_psymbols,
@@ -3500,11 +3490,11 @@ parse_partial_symbols (minimal_symbol_reader &reader,
 
                case stStatic:  /* Variable */
                  if (SC_IS_DATA (sh.sc))
-                   reader.record_with_info (name, minsym_value,
+                   reader.record_with_info (sym_name, minsym_value,
                                             mst_file_data,
                                             SECT_OFF_DATA (objfile));
                  else
-                   reader.record_with_info (name, minsym_value,
+                   reader.record_with_info (sym_name, minsym_value,
                                             mst_file_bss,
                                             SECT_OFF_BSS (objfile));
                  theclass = LOC_STATIC;
@@ -3537,7 +3527,7 @@ parse_partial_symbols (minimal_symbol_reader &reader,
                      && sh.iss != 0
                      && sh.index != cur_sdx + 2)
                    {
-                     add_psymbol_to_list (name, strlen (name), 1,
+                     add_psymbol_to_list (sym_name, strlen (sym_name), 1,
                                           STRUCT_DOMAIN, LOC_TYPEDEF, -1,
                                           &objfile->static_psymbols,
                                           0, psymtab_language, objfile);
@@ -3549,7 +3539,8 @@ parse_partial_symbols (minimal_symbol_reader &reader,
                  if (new_sdx <= cur_sdx)
                    {
                      /* This happens with the Ultrix kernel.  */
-                     complaint (_("bad aux index at block symbol %s"), name);
+                     complaint (_("bad aux index at block symbol %s"),
+                                sym_name);
                      new_sdx = cur_sdx + 1;    /* Don't skip backward.  */
                    }
                  cur_sdx = new_sdx;
@@ -3567,16 +3558,16 @@ parse_partial_symbols (minimal_symbol_reader &reader,
                  goto skip;
 
                default:
-                 /* Both complaints are valid:  one gives symbol name,
+                 /* Both complaints are valid:  one gives symbol sym_name,
                     the other the offending symbol type.  */
                  complaint (_("unknown local symbol %s"),
-                            name);
+                            sym_name);
                  complaint (_("with type %d"), sh.st);
                  cur_sdx++;
                  continue;
                }
              /* Use this gdb symbol.  */
-             add_psymbol_to_list (name, strlen (name), 1,
+             add_psymbol_to_list (sym_name, strlen (sym_name), 1,
                                   VAR_DOMAIN, theclass, section,
                                   &objfile->static_psymbols,
                                   sh.value, psymtab_language, objfile);
@@ -3593,7 +3584,6 @@ parse_partial_symbols (minimal_symbol_reader &reader,
            {
              enum address_class theclass;
              SYMR *psh;
-             char *name;
              CORE_ADDR svalue;
              short section;
 
@@ -3655,8 +3645,8 @@ parse_partial_symbols (minimal_symbol_reader &reader,
                  theclass = LOC_STATIC;
                  break;
                }
-             name = debug_info->ssext + psh->iss;
-             add_psymbol_to_list (name, strlen (name), 1,
+             char *sym_name = debug_info->ssext + psh->iss;
+             add_psymbol_to_list (sym_name, strlen (sym_name), 1,
                                   VAR_DOMAIN, theclass,
                                   section,
                                   &objfile->global_psymbols,
This page took 0.027896 seconds and 4 git commands to generate.