* serial.h (SERIAL_SET_TTY_STATE): Comment return value.

[deliverable/binutils-gdb.git] / gdb / objfiles.c

diff --git a/gdb/objfiles.c b/gdb/objfiles.c
index b890657c99efe1d922d1be48180ee3173f7f11c2..4358f65de089733b2445f10ebb7dc10de686262b 100644 (file)
--- a/gdb/objfiles.c
+++ b/gdb/objfiles.c
@@ -77,8 +77,7 @@ add_to_objfile_sections (abfd, asect, objfile_p_char)
   flagword aflag;
 
   aflag = bfd_get_section_flags (abfd, asect);
-  /* FIXME, we need to handle BSS segment here...it alloc's but doesn't load */
-  if (!(aflag & SEC_LOAD))
+  if (!(aflag & SEC_ALLOC))
     return;
   if (0 == bfd_section_size (abfd, asect))
     return;
@@ -92,14 +91,18 @@ add_to_objfile_sections (abfd, asect, objfile_p_char)
 }
 
 /* Builds a section table for OBJFILE.
-   Returns 0 if OK, 1 on error.  */
+   Returns 0 if OK, 1 on error (in which case bfd_error contains the
+   error).  */
 
-static int
+int
 build_objfile_section_table (objfile)
      struct objfile *objfile;
 {
-  if (objfile->sections)
-    abort();
+  /* objfile->sections can be already set when reading a mapped symbol
+     file.  I believe that we do need to rebuild the section table in
+     this case (we rebuild other things derived from the bfd), but we
+     can't free the old one (it's in the psymbol_obstack).  So we just
+     waste some memory.  */
 
   objfile->sections_end = 0;
   bfd_map_over_sections (objfile->obfd, add_to_objfile_sections, (char *)objfile);
@@ -356,6 +359,8 @@ free_objfile (objfile)
       (t->to_detach) (NULL, 0);
   }
 #endif
+  /* I *think* all our callers call clear_symtab_users.  If so, no need
+     to call this here.  */
   clear_pc_function_cache ();
 
   /* The last thing we do is free the objfile struct itself for the
@@ -636,7 +641,7 @@ open_existing_mapped_file (symsfilename, mtime, mapped)
        {
          if (error_pre_print)
            {
-             printf (error_pre_print);
+             printf_unfiltered (error_pre_print);
            }
          print_sys_errmsg (symsfilename, errno);
        }
@@ -706,7 +711,7 @@ open_mapped_file (filename, mtime, mapped)
        {
          if (error_pre_print)
            {
-             printf (error_pre_print);
+             printf_unfiltered (error_pre_print);
            }
          print_sys_errmsg (symsfilename, errno);
        }