/* Process record and replay target for GDB, the GNU debugger.
- Copyright (C) 2008-2017 Free Software Foundation, Inc.
+ Copyright (C) 2008-2021 Free Software Foundation, Inc.
This file is part of GDB.
#include "gdbcmd.h"
#include "completer.h"
#include "record.h"
-#include "observer.h"
+#include "observable.h"
#include "inferior.h"
-#include "common/common-utils.h"
+#include "gdbsupport/common-utils.h"
#include "cli/cli-utils.h"
#include "disasm.h"
static unsigned int record_call_history_size_setshow_var;
struct cmd_list_element *record_cmdlist = NULL;
-struct cmd_list_element *record_goto_cmdlist = NULL;
+static struct cmd_list_element *record_goto_cmdlist = NULL;
struct cmd_list_element *set_record_cmdlist = NULL;
struct cmd_list_element *show_record_cmdlist = NULL;
struct cmd_list_element *info_record_cmdlist = NULL;
t = find_record_target ();
if (t == NULL)
- error (_("No record target is currently active.\n"
- "Use one of the \"target record-<tab><tab>\" commands first."));
+ error (_("No recording is currently active.\n"
+ "Use the \"record full\" or \"record btrace\" command first."));
return t;
}
if (method == NULL)
{
if (format == NULL)
- execute_command_to_string ((char *) "record", from_tty);
+ execute_command_to_string ("record", from_tty, false);
else
error (_("Invalid format."));
}
else if (strcmp (method, "full") == 0)
{
if (format == NULL)
- execute_command_to_string ((char *) "record full", from_tty);
+ execute_command_to_string ("record full", from_tty, false);
else
error (_("Invalid format."));
}
else if (strcmp (method, "btrace") == 0)
{
if (format == NULL)
- execute_command_to_string ((char *) "record btrace", from_tty);
+ execute_command_to_string ("record btrace", from_tty, false);
else if (strcmp (format, "bts") == 0)
- execute_command_to_string ((char *) "record btrace bts", from_tty);
+ execute_command_to_string ("record btrace bts", from_tty, false);
else if (strcmp (format, "pt") == 0)
- execute_command_to_string ((char *) "record btrace pt", from_tty);
+ execute_command_to_string ("record btrace pt", from_tty, false);
else
error (_("Invalid format."));
}
void
record_stop (int from_tty)
{
- execute_command_to_string ((char *) "record stop", from_tty);
+ execute_command_to_string ("record stop", from_tty, false);
}
/* See record.h. */
static void
record_stop (struct target_ops *t)
{
- DEBUG ("stop %s", t->to_shortname);
+ DEBUG ("stop %s", t->shortname ());
- t->to_stop_recording (t);
+ t->stop_recording ();
}
/* Unpush the record target. */
static void
record_unpush (struct target_ops *t)
{
- DEBUG ("unpush %s", t->to_shortname);
+ DEBUG ("unpush %s", t->shortname ());
unpush_target (t);
}
void
record_disconnect (struct target_ops *t, const char *args, int from_tty)
{
- gdb_assert (t->to_stratum == record_stratum);
+ gdb_assert (t->stratum () == record_stratum);
- DEBUG ("disconnect %s", t->to_shortname);
+ DEBUG ("disconnect %s", t->shortname ());
record_stop (t);
record_unpush (t);
/* See record.h. */
void
-record_detach (struct target_ops *t, const char *args, int from_tty)
+record_detach (struct target_ops *t, inferior *inf, int from_tty)
{
- gdb_assert (t->to_stratum == record_stratum);
+ gdb_assert (t->stratum () == record_stratum);
- DEBUG ("detach %s", t->to_shortname);
+ DEBUG ("detach %s", t->shortname ());
record_stop (t);
record_unpush (t);
- target_detach (args, from_tty);
+ target_detach (inf, from_tty);
}
/* See record.h. */
void
record_mourn_inferior (struct target_ops *t)
{
- gdb_assert (t->to_stratum == record_stratum);
+ gdb_assert (t->stratum () == record_stratum);
- DEBUG ("mourn inferior %s", t->to_shortname);
+ DEBUG ("mourn inferior %s", t->shortname ());
/* It is safer to not stop recording. Resources will be freed when
threads are discarded. */
void
record_kill (struct target_ops *t)
{
- gdb_assert (t->to_stratum == record_stratum);
+ gdb_assert (t->stratum () == record_stratum);
- DEBUG ("kill %s", t->to_shortname);
+ DEBUG ("kill %s", t->shortname ());
/* It is safer to not stop recording. Resources will be freed when
threads are discarded. */
static void
cmd_record_start (const char *args, int from_tty)
{
- execute_command ((char *) "target record-full", from_tty);
+ execute_command ("target record-full", from_tty);
}
/* Truncate the record log from the present point
printf_unfiltered (_("Process record is stopped and all execution "
"logs are deleted.\n"));
- observer_notify_record_changed (current_inferior (), 0, NULL, NULL);
+ gdb::observers::record_changed.notify (current_inferior (), 0, NULL, NULL);
}
-/* The "set record" command. */
-
-static void
-set_record_command (const char *args, int from_tty)
-{
- printf_unfiltered (_("\"set record\" must be followed "
- "by an apporpriate subcommand.\n"));
- help_list (set_record_cmdlist, "set record ", all_commands, gdb_stdout);
-}
-
-/* The "show record" command. */
-
-static void
-show_record_command (const char *args, int from_tty)
-{
- cmd_show_list (show_record_cmdlist, from_tty, "");
-}
/* The "info record" command. */
t = find_record_target ();
if (t == NULL)
{
- printf_filtered (_("No record target is currently active.\n"));
+ printf_filtered (_("No recording is currently active.\n"));
return;
}
- printf_filtered (_("Active record target: %s\n"), t->to_shortname);
- t->to_info_record (t);
+ printf_filtered (_("Active record target: %s\n"), t->shortname ());
+ t->info_record ();
}
/* The "record save" command. */
{
/* Default recfile name is "gdb_record.PID". */
xsnprintf (recfilename_buffer, sizeof (recfilename_buffer),
- "gdb_record.%d", ptid_get_pid (inferior_ptid));
+ "gdb_record.%d", inferior_ptid.pid ());
recfilename = recfilename_buffer;
}
{
const char *pos;
char *end;
- int number;
pos = skip_spaces (*arg);
/* Read function-call-history modifiers from an argument string. */
-static int
+static record_print_flags
get_call_history_modifiers (const char **arg)
{
- int modifiers;
- const char *args;
-
- modifiers = 0;
- args = *arg;
+ record_print_flags modifiers = 0;
+ const char *args = *arg;
if (args == NULL)
return modifiers;
static void
cmd_record_call_history (const char *arg, int from_tty)
{
- int flags, size;
-
require_record_target ();
- flags = get_call_history_modifiers (&arg);
+ record_print_flags flags = get_call_history_modifiers (&arg);
- size = command_size_to_target_size (record_call_history_size);
+ int size = command_size_to_target_size (record_call_history_size);
if (arg == NULL || *arg == 0 || strcmp (arg, "+") == 0)
target_call_history (size, flags);
[0..UINT_MAX]. See command_size_to_target_size. */
static void
-set_record_insn_history_size (char *args, int from_tty,
+set_record_insn_history_size (const char *args, int from_tty,
struct cmd_list_element *c)
{
validate_history_size (&record_insn_history_size_setshow_var,
[0..UINT_MAX]. See command_size_to_target_size. */
static void
-set_record_call_history_size (char *args, int from_tty,
+set_record_call_history_size (const char *args, int from_tty,
struct cmd_list_element *c)
{
validate_history_size (&record_call_history_size_setshow_var,
&record_call_history_size);
}
+void _initialize_record ();
void
-_initialize_record (void)
+_initialize_record ()
{
struct cmd_list_element *c;
set_cmd_completer (c, filename_completer);
add_com_alias ("rec", "record", class_obscure, 1);
- add_prefix_cmd ("record", class_support, set_record_command,
- _("Set record options"), &set_record_cmdlist,
- "set record ", 0, &setlist);
+ add_basic_prefix_cmd ("record", class_support,
+ _("Set record options."), &set_record_cmdlist,
+ "set record ", 0, &setlist);
add_alias_cmd ("rec", "record", class_obscure, 1, &setlist);
- add_prefix_cmd ("record", class_support, show_record_command,
- _("Show record options"), &show_record_cmdlist,
- "show record ", 0, &showlist);
+ add_show_prefix_cmd ("record", class_support,
+ _("Show record options."), &show_record_cmdlist,
+ "show record ", 0, &showlist);
add_alias_cmd ("rec", "record", class_obscure, 1, &showlist);
add_prefix_cmd ("record", class_support, info_record_command,
- _("Info record options"), &info_record_cmdlist,
+ _("Info record options."), &info_record_cmdlist,
"info record ", 0, &infolist);
add_alias_cmd ("rec", "record", class_obscure, 1, &infolist);
c = add_cmd ("save", class_obscure, cmd_record_save,
_("Save the execution log to a file.\n\
-Argument is optional filename.\n\
-Default filename is 'gdb_record.<process_id>'."),
+Usage: record save [FILENAME]\n\
+Default filename is 'gdb_record.PROCESS_ID'."),
&record_cmdlist);
set_cmd_completer (c, filename_completer);
add_cmd ("delete", class_obscure, cmd_record_delete,
_("Delete the rest of execution log and start recording it anew."),
- &record_cmdlist);
+ &record_cmdlist);
add_alias_cmd ("d", "delete", class_obscure, 1, &record_cmdlist);
add_alias_cmd ("del", "delete", class_obscure, 1, &record_cmdlist);
add_cmd ("stop", class_obscure, cmd_record_stop,
_("Stop the record/replay target."),
- &record_cmdlist);
+ &record_cmdlist);
add_alias_cmd ("s", "stop", class_obscure, 1, &record_cmdlist);
add_prefix_cmd ("goto", class_obscure, cmd_record_goto, _("\
from the first argument.\n\
The number of instructions to disassemble can be defined with \"set record \
instruction-history-size\"."),
- &record_cmdlist);
+ &record_cmdlist);
add_cmd ("function-call-history", class_obscure, cmd_record_call_history, _("\
Prints the execution history at function granularity.\n\
from the first argument.\n\
The number of functions to print can be defined with \"set record \
function-call-history-size\"."),
- &record_cmdlist);
+ &record_cmdlist);
/* Sync command control variables. */
record_insn_history_size_setshow_var = record_insn_history_size;