Lint fixes from Paul Eggert (eggert@twinsun.com):

[deliverable/binutils-gdb.git] / gdb / remote-vx.c

diff --git a/gdb/remote-vx.c b/gdb/remote-vx.c
index 39644f3ba1f6d85d9a78146a5bbe77e6c5c264eb..91d2e87f6e0c770fd3bbb05e443584fcc29968f2 100644 (file)
--- a/gdb/remote-vx.c
+++ b/gdb/remote-vx.c
@@ -26,14 +26,13 @@ Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.  */
 #include "gdbcore.h"
 #include "command.h"
 #include "symtab.h"
-#include "symfile.h"           /* for struct complaint */
+#include "complaints.h"
 
 #include <string.h>
 #include <errno.h>
 #include <signal.h>
 #include <fcntl.h>
 #include <sys/types.h>
-#include <sys/time.h>
 #include <sys/socket.h>
 #define malloc bogon_malloc    /* Sun claims "char *malloc()" not void * */
 #define free bogon_free                /* Sun claims "int free()" not void */
@@ -49,7 +48,6 @@ Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.  */
 #include "vx-share/xdr_ld.h"
 #include "vx-share/xdr_rdb.h"
 #include "vx-share/dbgRpcLib.h"
-#include "vx-share/reg.h"
 
 #include <symtab.h>
 
@@ -811,7 +809,7 @@ vx_lookup_symbol (name, pAddr)
   status = net_clnt_call (VX_SYMBOL_INQ, xdr_wrapstring, &name,
                          xdr_SYMBOL_ADDR, &symbolAddr);
   if (status != RPC_SUCCESS) {
-      complain (&cant_contact_target, 0);
+      complain (&cant_contact_target);
       return -1;
   }
 
@@ -1126,8 +1124,7 @@ vx_open (args, from_tty)
   clnt_freeres (pClient, xdr_ldtabl, &loadTable);
 }
 \f
-/* attach_command --
-   takes a task started up outside of gdb and ``attaches'' to it.
+/* Takes a task started up outside of gdb and ``attaches'' to it.
    This stops it cold in its tracks and allows us to start tracing it.  */
 
 static void
@@ -1141,8 +1138,6 @@ vx_attach (args, from_tty)
   Ptrace_return ptrace_out;
   int status;
 
-  dont_repeat();
-
   if (!args)
     error_no_arg ("process-id to attach");
 
@@ -1170,23 +1165,6 @@ vx_attach (args, from_tty)
   push_target (&vx_run_ops);
   inferior_pid = pid;
   vx_running = 0;
-
-  mark_breakpoints_out ();
-
-  /* Set up the "saved terminal modes" of the inferior
-     based on what modes we are starting it with.  */
-  target_terminal_init ();
-
-  /* Install inferior's terminal modes.  */
-  target_terminal_inferior ();
-
-  /* We will get a task spawn event immediately.  */
-  init_wait_for_inferior ();
-  clear_proceed_status ();
-  stop_soon_quietly = 1;
-  wait_for_inferior ();
-  stop_soon_quietly = 0;
-  normal_stop ();
 }
 
 
@@ -1252,14 +1230,15 @@ vx_kill ()
 
   status = net_ptrace_clnt_call (PTRACE_KILL, &ptrace_in, &ptrace_out);
   if (status == -1)
-    error (rpcerr);
-  if (ptrace_out.status == -1)
+    warning (rpcerr);
+  else if (ptrace_out.status == -1)
     {
       errno = ptrace_out.errno;
       perror_with_name ("Killing VxWorks process");
     }
 
-  /* If it gives good status, the process is *gone*, no events remain.  */
+  /* If it gives good status, the process is *gone*, no events remain.
+     If the kill failed, assume the process is gone anyhow.  */
   inferior_pid = 0;
   pop_target ();       /* go back to non-executing VxWorks connection */
 }
@@ -1340,6 +1319,7 @@ Specify the name of the machine to connect to.",
        vx_lookup_symbol,
        vx_create_inferior, 0,  /* mourn_inferior */
        0, /* can_run */
+       0, /* notice_signals */
        core_stratum, 0, /* next */
        1, 1, 0, 0, 0,  /* all mem, mem, stack, regs, exec */
        0, 0,                   /* Section pointers */
@@ -1363,6 +1343,7 @@ struct target_ops vx_run_ops = {
        vx_lookup_symbol,
        0, vx_mourn_inferior,
        0,  /* can_run */
+       0, /* notice_signals */
        process_stratum, 0, /* next */
        0, 1, 1, 1, 1,  /* all mem, mem, stack, regs, exec */
                        /* all_mem is off to avoid spurious msg in "i files" */