PR23169 bogus test

[deliverable/binutils-gdb.git] / ld / testsuite / ld-ifunc / ifunc.exp

diff --git a/ld/testsuite/ld-ifunc/ifunc.exp b/ld/testsuite/ld-ifunc/ifunc.exp
index cb019d9d91136910de9618fab7a1647d04fb1862..612d91402fdd4e1e04d19fc57a1d4571da45dc22 100644 (file)
--- a/ld/testsuite/ld-ifunc/ifunc.exp
+++ b/ld/testsuite/ld-ifunc/ifunc.exp
@@ -33,10 +33,8 @@ if {!(([istarget "i?86-*-*"]
        || [istarget "s390*-*-*"])
       && ([istarget "*-*-elf*"]
          || [istarget "*-*-nacl*"]
-         || (([istarget "*-*-linux*"]
-              || [istarget "*-*-gnu*"])
-             && ![istarget "*-*-*aout*"]
-             && ![istarget "*-*-*oldld*"]))) } {
+         || [istarget "*-*-linux*"]
+         || [istarget "*-*-gnu*"])) } {
     verbose "IFUNC tests not run - target does not support IFUNC"
     return
 }
@@ -47,6 +45,16 @@ if ![check_shared_lib_support] {
     return
 }
 
+# This test does not need a compiler...
+run_dump_test "ifuncmod5"
+
+set test_list [lsort [glob -nocomplain $srcdir/$subdir/*.d]]
+foreach t $test_list {
+    # We need to strip the ".d", but can leave the dirname.
+    verbose [file rootname $t]
+    run_dump_test [file rootname $t]
+}
+
 # We need a working compiler.  (Strictly speaking this is
 # not true, we could use target specific assembler files).
 if { [which $CC] == 0 } {
@@ -424,13 +432,6 @@ run_ld_link_exec_tests [list \
     ] \
 ]
 
-set test_list [lsort [glob -nocomplain $srcdir/$subdir/*.d]]
-foreach t $test_list {
-    # We need to strip the ".d", but can leave the dirname.
-    verbose [file rootname $t]
-    run_dump_test [file rootname $t]
-}
-
 # Run-time tests which require working IFUNC support.
 if { ![check_ifunc_available] } {
     return
@@ -580,6 +581,76 @@ run_cc_link_tests [list \
        {} \
        "libpr18841cn.so" \
     ] \
+    [list \
+       "Build libpr23169a.so" \
+       "-shared" \
+       "-fPIC -O2 -g" \
+       { pr23169a.c } \
+       {} \
+       "libpr23169a.so" \
+    ] \
+    [list \
+       "Build libpr23169b.so" \
+       "-shared -Wl,-z,now" \
+       "-fPIC -O2 -g" \
+       { pr23169a.c } \
+       {} \
+       "libpr23169b.so" \
+    ] \
+    [list \
+       "Build pr23169a" \
+       "$NOPIE_LDFLAGS -Wl,--no-as-needed tmpdir/libpr23169a.so" \
+       "$NOPIE_CFLAGS -O2 -g" \
+       { pr23169b.c pr23169c.c } \
+       {{readelf {--dyn-syms} pr23169a.rd} \
+        {readelf {-r -W} pr23169b.rd}} \
+       "pr23169a" \
+    ] \
+    [list \
+       "Build pr23169b" \
+       "-pie -Wl,--no-as-needed tmpdir/libpr23169a.so" \
+       "-fPIE -O2 -g" \
+       { pr23169b.c pr23169c.c } \
+       {{readelf {--dyn-syms} pr23169c.rd} \
+        {readelf {-r -W} pr23169b.rd}} \
+       "pr23169b" \
+    ] \
+    [list \
+       "Build pr23169c" \
+       "$NOPIE_LDFLAGS -Wl,--no-as-needed tmpdir/libpr23169a.so" \
+       "-fPIE -O2 -g" \
+       { pr23169b.c pr23169c.c } \
+       {{readelf {--dyn-syms} pr23169c.rd} \
+        {readelf {-r -W} pr23169b.rd}} \
+       "pr23169c" \
+    ] \
+    [list \
+       "Build pr23169d" \
+       "$NOPIE_LDFLAGS -Wl,--no-as-needed,-z,now tmpdir/libpr23169b.so" \
+       "$NOPIE_CFLAGS -O2 -g" \
+       { pr23169b.c pr23169c.c } \
+       {{readelf {--dyn-syms} pr23169a.rd} \
+        {readelf {-r -W} pr23169b.rd}} \
+       "pr23169d" \
+    ] \
+    [list \
+       "Build pr23169e" \
+       "-pie -Wl,--no-as-needed,-z,now tmpdir/libpr23169b.so" \
+       "-fPIE -O2 -g" \
+       { pr23169b.c pr23169c.c } \
+       {{readelf {--dyn-syms} pr23169c.rd} \
+        {readelf {-r -W} pr23169b.rd}} \
+       "pr23169e" \
+    ] \
+    [list \
+       "Build pr23169f" \
+       "$NOPIE_LDFLAGS -Wl,--no-as-needed,-z,now tmpdir/libpr23169b.so" \
+       "-fPIE -O2 -g" \
+       { pr23169b.c pr23169c.c } \
+       {{readelf {--dyn-syms} pr23169c.rd} \
+        {readelf {-r -W} pr23169b.rd}} \
+       "pr23169f" \
+    ] \
 ]
 
 run_ld_link_exec_tests [list \
@@ -632,3 +703,70 @@ run_ld_link_exec_tests [list \
        "pr18841.out" \
     ] \
 ]
+
+# The pr23169 testcase is not valid.  In general, you can't call ifunc
+# resolvers in another binary unless you know what you're doing.  In
+# particular you must ensure that the binary containing the resolver
+# is relocated before the resolver is called (for example, the
+# function addresses returned by the resolver may be loaded from the
+# GOT).
+# That does not happen for the pr23169 testcase where the resolver is
+# in the executable (which is relocated last by ld.so).
+if { [isnative]
+     && ![istarget "powerpc-*-*"] } {
+run_ld_link_exec_tests [list \
+    [list \
+       "Run pr23169a" \
+       "$NOPIE_LDFLAGS -Wl,--no-as-needed tmpdir/libpr23169a.so" \
+       "" \
+       { pr23169b.c pr23169c.c } \
+       "pr23169a" \
+       "pass.out" \
+       "$NOPIE_CFLAGS -O2 -g" \
+    ] \
+    [list \
+       "Run pr23169b" \
+       "-pie -Wl,--no-as-needed tmpdir/libpr23169a.so" \
+       "" \
+       { pr23169b.c pr23169c.c } \
+       "pr23169b" \
+       "pass.out" \
+       "-fPIE -O2 -g" \
+    ] \
+    [list \
+       "Run pr23169c" \
+       "$NOPIE_LDFLAGS -Wl,--no-as-needed tmpdir/libpr23169a.so" \
+       "" \
+       { pr23169b.c pr23169c.c } \
+       "pr23169c" \
+       "pass.out" \
+       "-fPIE -O2 -g" \
+    ] \
+    [list \
+       "Run pr23169d" \
+       "$NOPIE_LDFLAGS -Wl,--no-as-needed,-z,now tmpdir/libpr23169b.so" \
+       "" \
+       { pr23169b.c pr23169c.c } \
+       "pr23169d" \
+       "pass.out" \
+       "$NOPIE_CFLAGS -O2 -g" \
+    ] \
+    [list \
+       "Run pr23169e" \
+       "-pie -Wl,--no-as-needed,-z,now tmpdir/libpr23169b.so" \
+       "" \
+       { pr23169b.c pr23169c.c } \
+       "pr23169e" \
+       "pass.out" \
+       "-fPIE -O2 -g" \
+    ] \
+    [list \
+       "Run pr23169f" \
+       "$NOPIE_LDFLAGS -Wl,--no-as-needed,-z,now tmpdir/libpr23169b.so" \
+       "" \
+       { pr23169b.c pr23169c.c } \
+       "pr23169f" \
+       "pass.out" \
+       "-fPIE -O2 -g" \
+    ] \
+]}