lib: list_sort_test(): simplify and harden cleanup

[deliverable/linux.git] / lib / list_sort.c

diff --git a/lib/list_sort.c b/lib/list_sort.c
index 1183fa70a44d26cfc673b6d5d2f645b7026f50dd..a34c78c30d56615d0eb8334310772178fd328a65 100644 (file)
--- a/lib/list_sort.c
+++ b/lib/list_sort.c
@@ -207,18 +207,18 @@ static int __init cmp(void *priv, struct list_head *a, struct list_head *b)
 
 static int __init list_sort_test(void)
 {
-       int i, count = 1, err = -EINVAL;
+       int i, count = 1, err = -ENOMEM;
        struct debug_el *el;
-       struct list_head *cur, *tmp;
+       struct list_head *cur;
        LIST_HEAD(head);
 
        printk(KERN_DEBUG "list_sort_test: start testing list_sort()\n");
 
-       elts = kmalloc(sizeof(void *) * TEST_LIST_LEN, GFP_KERNEL);
+       elts = kcalloc(TEST_LIST_LEN, sizeof(*elts), GFP_KERNEL);
        if (!elts) {
                printk(KERN_ERR "list_sort_test: error: cannot allocate "
                                "memory\n");
-               goto exit;
+               return err;
        }
 
        for (i = 0; i < TEST_LIST_LEN; i++) {
@@ -239,6 +239,7 @@ static int __init list_sort_test(void)
 
        list_sort(NULL, &head, cmp);
 
+       err = -EINVAL;
        for (cur = head.next; cur->next != &head; cur = cur->next) {
                struct debug_el *el1;
                int cmp_result;
@@ -271,6 +272,11 @@ static int __init list_sort_test(void)
                }
                count++;
        }
+       if (head.prev != cur) {
+               printk(KERN_ERR "list_sort_test: error: list is corrupted\n");
+               goto exit;
+       }
+
 
        if (count != TEST_LIST_LEN) {
                printk(KERN_ERR "list_sort_test: error: bad list length %d",
@@ -280,11 +286,9 @@ static int __init list_sort_test(void)
 
        err = 0;
 exit:
+       for (i = 0; i < TEST_LIST_LEN; i++)
+               kfree(elts[i]);
        kfree(elts);
-       list_for_each_safe(cur, tmp, &head) {
-               list_del(cur);
-               kfree(container_of(cur, struct debug_el, list));
-       }
        return err;
 }
 module_init(list_sort_test);