[VLAN]: Clean up initialization code

[deliverable/linux.git] / net / 8021q / vlanproc.c

diff --git a/net/8021q/vlanproc.c b/net/8021q/vlanproc.c
index 6cefdf8e381a3b40bf9d6d78c5535e25bab6f612..971e6233801eab307ef56506e9a18038465d424b 100644 (file)
--- a/net/8021q/vlanproc.c
+++ b/net/8021q/vlanproc.c
@@ -158,15 +158,18 @@ void vlan_proc_cleanup(void)
 int __init vlan_proc_init(void)
 {
        proc_vlan_dir = proc_mkdir(name_root, init_net.proc_net);
-       if (proc_vlan_dir) {
-               proc_vlan_conf = create_proc_entry(name_conf,
-                                                  S_IFREG|S_IRUSR|S_IWUSR,
-                                                  proc_vlan_dir);
-               if (proc_vlan_conf) {
-                       proc_vlan_conf->proc_fops = &vlan_fops;
-                       return 0;
-               }
-       }
+       if (!proc_vlan_dir)
+               goto err;
+
+       proc_vlan_conf = create_proc_entry(name_conf, S_IFREG|S_IRUSR|S_IWUSR,
+                                          proc_vlan_dir);
+       if (!proc_vlan_conf)
+               goto err;
+       proc_vlan_conf->proc_fops = &vlan_fops;
+       return 0;
+
+err:
+       pr_err("%s: can't create entry in proc filesystem!\n", __FUNCTION__);
        vlan_proc_cleanup();
        return -ENOBUFS;
 }
@@ -179,13 +182,6 @@ int vlan_proc_add_dev (struct net_device *vlandev)
 {
        struct vlan_dev_info *dev_info = VLAN_DEV_INFO(vlandev);
 
-       if (!(vlandev->priv_flags & IFF_802_1Q_VLAN)) {
-               printk(KERN_ERR
-                      "ERROR:  vlan_proc_add, device -:%s:- is NOT a VLAN\n",
-                      vlandev->name);
-               return -EINVAL;
-       }
-
        dev_info->dent = create_proc_entry(vlandev->name,
                                           S_IFREG|S_IRUSR|S_IWUSR,
                                           proc_vlan_dir);
@@ -194,11 +190,6 @@ int vlan_proc_add_dev (struct net_device *vlandev)
 
        dev_info->dent->proc_fops = &vlandev_fops;
        dev_info->dent->data = vlandev;
-
-#ifdef VLAN_DEBUG
-       printk(KERN_ERR "vlan_proc_add, device -:%s:- being added.\n",
-              vlandev->name);
-#endif
        return 0;
 }
 
@@ -207,28 +198,11 @@ int vlan_proc_add_dev (struct net_device *vlandev)
  */
 int vlan_proc_rem_dev(struct net_device *vlandev)
 {
-       if (!vlandev) {
-               printk(VLAN_ERR "%s: invalid argument: %p\n",
-                       __FUNCTION__, vlandev);
-               return -EINVAL;
-       }
-
-       if (!(vlandev->priv_flags & IFF_802_1Q_VLAN)) {
-               printk(VLAN_DBG "%s: invalid argument, device: %s is not a VLAN device, priv_flags: 0x%4hX.\n",
-                       __FUNCTION__, vlandev->name, vlandev->priv_flags);
-               return -EINVAL;
-       }
-
-#ifdef VLAN_DEBUG
-       printk(VLAN_DBG "%s: dev: %p\n", __FUNCTION__, vlandev);
-#endif
-
        /** NOTE:  This will consume the memory pointed to by dent, it seems. */
        if (VLAN_DEV_INFO(vlandev)->dent) {
                remove_proc_entry(VLAN_DEV_INFO(vlandev)->dent->name, proc_vlan_dir);
                VLAN_DEV_INFO(vlandev)->dent = NULL;
        }
-
        return 0;
 }
 
@@ -316,7 +290,7 @@ static int vlandev_seq_show(struct seq_file *seq, void *offset)
 {
        struct net_device *vlandev = (struct net_device *) seq->private;
        const struct vlan_dev_info *dev_info = VLAN_DEV_INFO(vlandev);
-       struct net_device_stats *stats;
+       struct net_device_stats *stats = &vlandev->stats;
        static const char fmt[] = "%30s %12lu\n";
        int i;
 
@@ -327,9 +301,6 @@ static int vlandev_seq_show(struct seq_file *seq, void *offset)
                       vlandev->name, dev_info->vlan_id,
                       (int)(dev_info->flags & 1), vlandev->priv_flags);
 
-
-       stats = vlan_dev_get_stats(vlandev);
-
        seq_printf(seq, fmt, "total frames received", stats->rx_packets);
        seq_printf(seq, fmt, "total bytes received", stats->rx_bytes);
        seq_printf(seq, fmt, "Broadcast/Multicast Rcvd", stats->multicast);