netns xfrm: per-netns state GC work
[deliverable/linux.git] / net / xfrm / xfrm_state.c
index 508337f97249d421e524013cdd83c86b6cbbf210..69c0b06bf7567401784aa1cbeb15c2adb961ac8c 100644 (file)
@@ -44,19 +44,7 @@ u32 sysctl_xfrm_acq_expires __read_mostly = 30;
 
 static DEFINE_SPINLOCK(xfrm_state_lock);
 
-/* Hash table to find appropriate SA towards given target (endpoint
- * of tunnel or destination of transport mode) allowed by selector.
- *
- * Main use is finding SA after policy selected tunnel or transport mode.
- * Also, it can be used by ah/esp icmp error handler to find offending SA.
- */
-static LIST_HEAD(xfrm_state_all);
-static struct hlist_head *xfrm_state_bydst __read_mostly;
-static struct hlist_head *xfrm_state_bysrc __read_mostly;
-static struct hlist_head *xfrm_state_byspi __read_mostly;
-static unsigned int xfrm_state_hmask __read_mostly;
 static unsigned int xfrm_state_hashmax __read_mostly = 1 * 1024 * 1024;
-static unsigned int xfrm_state_num;
 static unsigned int xfrm_state_genid;
 
 static struct xfrm_state_afinfo *xfrm_state_get_afinfo(unsigned int family);
@@ -74,20 +62,20 @@ static inline unsigned int xfrm_dst_hash(xfrm_address_t *daddr,
                                         u32 reqid,
                                         unsigned short family)
 {
-       return __xfrm_dst_hash(daddr, saddr, reqid, family, xfrm_state_hmask);
+       return __xfrm_dst_hash(daddr, saddr, reqid, family, init_net.xfrm.state_hmask);
 }
 
 static inline unsigned int xfrm_src_hash(xfrm_address_t *daddr,
                                         xfrm_address_t *saddr,
                                         unsigned short family)
 {
-       return __xfrm_src_hash(daddr, saddr, family, xfrm_state_hmask);
+       return __xfrm_src_hash(daddr, saddr, family, init_net.xfrm.state_hmask);
 }
 
 static inline unsigned int
 xfrm_spi_hash(xfrm_address_t *daddr, __be32 spi, u8 proto, unsigned short family)
 {
-       return __xfrm_spi_hash(daddr, spi, proto, family, xfrm_state_hmask);
+       return __xfrm_spi_hash(daddr, spi, proto, family, init_net.xfrm.state_hmask);
 }
 
 static void xfrm_hash_transfer(struct hlist_head *list,
@@ -121,16 +109,16 @@ static void xfrm_hash_transfer(struct hlist_head *list,
        }
 }
 
-static unsigned long xfrm_hash_new_size(void)
+static unsigned long xfrm_hash_new_size(unsigned int state_hmask)
 {
-       return ((xfrm_state_hmask + 1) << 1) *
-               sizeof(struct hlist_head);
+       return ((state_hmask + 1) << 1) * sizeof(struct hlist_head);
 }
 
 static DEFINE_MUTEX(hash_resize_mutex);
 
-static void xfrm_hash_resize(struct work_struct *__unused)
+static void xfrm_hash_resize(struct work_struct *work)
 {
+       struct net *net = container_of(work, struct net, xfrm.state_hash_work);
        struct hlist_head *ndst, *nsrc, *nspi, *odst, *osrc, *ospi;
        unsigned long nsize, osize;
        unsigned int nhashmask, ohashmask;
@@ -138,7 +126,7 @@ static void xfrm_hash_resize(struct work_struct *__unused)
 
        mutex_lock(&hash_resize_mutex);
 
-       nsize = xfrm_hash_new_size();
+       nsize = xfrm_hash_new_size(net->xfrm.state_hmask);
        ndst = xfrm_hash_alloc(nsize);
        if (!ndst)
                goto out_unlock;
@@ -157,19 +145,19 @@ static void xfrm_hash_resize(struct work_struct *__unused)
        spin_lock_bh(&xfrm_state_lock);
 
        nhashmask = (nsize / sizeof(struct hlist_head)) - 1U;
-       for (i = xfrm_state_hmask; i >= 0; i--)
-               xfrm_hash_transfer(xfrm_state_bydst+i, ndst, nsrc, nspi,
+       for (i = net->xfrm.state_hmask; i >= 0; i--)
+               xfrm_hash_transfer(net->xfrm.state_bydst+i, ndst, nsrc, nspi,
                                   nhashmask);
 
-       odst = xfrm_state_bydst;
-       osrc = xfrm_state_bysrc;
-       ospi = xfrm_state_byspi;
-       ohashmask = xfrm_state_hmask;
+       odst = net->xfrm.state_bydst;
+       osrc = net->xfrm.state_bysrc;
+       ospi = net->xfrm.state_byspi;
+       ohashmask = net->xfrm.state_hmask;
 
-       xfrm_state_bydst = ndst;
-       xfrm_state_bysrc = nsrc;
-       xfrm_state_byspi = nspi;
-       xfrm_state_hmask = nhashmask;
+       net->xfrm.state_bydst = ndst;
+       net->xfrm.state_bysrc = nsrc;
+       net->xfrm.state_byspi = nspi;
+       net->xfrm.state_hmask = nhashmask;
 
        spin_unlock_bh(&xfrm_state_lock);
 
@@ -182,16 +170,12 @@ out_unlock:
        mutex_unlock(&hash_resize_mutex);
 }
 
-static DECLARE_WORK(xfrm_hash_work, xfrm_hash_resize);
-
 DECLARE_WAIT_QUEUE_HEAD(km_waitq);
 EXPORT_SYMBOL(km_waitq);
 
 static DEFINE_RWLOCK(xfrm_state_afinfo_lock);
 static struct xfrm_state_afinfo *xfrm_state_afinfo[NPROTO];
 
-static struct work_struct xfrm_state_gc_work;
-static HLIST_HEAD(xfrm_state_gc_list);
 static DEFINE_SPINLOCK(xfrm_state_gc_lock);
 
 int __xfrm_state_delete(struct xfrm_state *x);
@@ -401,14 +385,15 @@ static void xfrm_state_gc_destroy(struct xfrm_state *x)
        kfree(x);
 }
 
-static void xfrm_state_gc_task(struct work_struct *data)
+static void xfrm_state_gc_task(struct work_struct *work)
 {
+       struct net *net = container_of(work, struct net, xfrm.state_gc_work);
        struct xfrm_state *x;
        struct hlist_node *entry, *tmp;
        struct hlist_head gc_list;
 
        spin_lock_bh(&xfrm_state_gc_lock);
-       hlist_move_list(&xfrm_state_gc_list, &gc_list);
+       hlist_move_list(&net->xfrm.state_gc_list, &gc_list);
        spin_unlock_bh(&xfrm_state_gc_lock);
 
        hlist_for_each_entry_safe(x, entry, tmp, &gc_list, gclist)
@@ -504,13 +489,14 @@ out:
 
 static void xfrm_replay_timer_handler(unsigned long data);
 
-struct xfrm_state *xfrm_state_alloc(void)
+struct xfrm_state *xfrm_state_alloc(struct net *net)
 {
        struct xfrm_state *x;
 
        x = kzalloc(sizeof(struct xfrm_state), GFP_ATOMIC);
 
        if (x) {
+               write_pnet(&x->xs_net, net);
                atomic_set(&x->refcnt, 1);
                atomic_set(&x->tunnel_users, 0);
                INIT_LIST_HEAD(&x->km.all);
@@ -540,9 +526,9 @@ void __xfrm_state_destroy(struct xfrm_state *x)
        WARN_ON(x->km.state != XFRM_STATE_DEAD);
 
        spin_lock_bh(&xfrm_state_gc_lock);
-       hlist_add_head(&x->gclist, &xfrm_state_gc_list);
+       hlist_add_head(&x->gclist, &init_net.xfrm.state_gc_list);
        spin_unlock_bh(&xfrm_state_gc_lock);
-       schedule_work(&xfrm_state_gc_work);
+       schedule_work(&init_net.xfrm.state_gc_work);
 }
 EXPORT_SYMBOL(__xfrm_state_destroy);
 
@@ -558,7 +544,7 @@ int __xfrm_state_delete(struct xfrm_state *x)
                hlist_del(&x->bysrc);
                if (x->id.spi)
                        hlist_del(&x->byspi);
-               xfrm_state_num--;
+               init_net.xfrm.state_num--;
                spin_unlock(&xfrm_state_lock);
 
                /* All xfrm_state objects are created by xfrm_state_alloc.
@@ -591,11 +577,11 @@ xfrm_state_flush_secctx_check(u8 proto, struct xfrm_audit *audit_info)
 {
        int i, err = 0;
 
-       for (i = 0; i <= xfrm_state_hmask; i++) {
+       for (i = 0; i <= init_net.xfrm.state_hmask; i++) {
                struct hlist_node *entry;
                struct xfrm_state *x;
 
-               hlist_for_each_entry(x, entry, xfrm_state_bydst+i, bydst) {
+               hlist_for_each_entry(x, entry, init_net.xfrm.state_bydst+i, bydst) {
                        if (xfrm_id_proto_match(x->id.proto, proto) &&
                           (err = security_xfrm_state_delete(x)) != 0) {
                                xfrm_audit_state_delete(x, 0,
@@ -626,11 +612,11 @@ int xfrm_state_flush(u8 proto, struct xfrm_audit *audit_info)
        if (err)
                goto out;
 
-       for (i = 0; i <= xfrm_state_hmask; i++) {
+       for (i = 0; i <= init_net.xfrm.state_hmask; i++) {
                struct hlist_node *entry;
                struct xfrm_state *x;
 restart:
-               hlist_for_each_entry(x, entry, xfrm_state_bydst+i, bydst) {
+               hlist_for_each_entry(x, entry, init_net.xfrm.state_bydst+i, bydst) {
                        if (!xfrm_state_kern(x) &&
                            xfrm_id_proto_match(x->id.proto, proto)) {
                                xfrm_state_hold(x);
@@ -660,8 +646,8 @@ EXPORT_SYMBOL(xfrm_state_flush);
 void xfrm_sad_getinfo(struct xfrmk_sadinfo *si)
 {
        spin_lock_bh(&xfrm_state_lock);
-       si->sadcnt = xfrm_state_num;
-       si->sadhcnt = xfrm_state_hmask;
+       si->sadcnt = init_net.xfrm.state_num;
+       si->sadhcnt = init_net.xfrm.state_hmask;
        si->sadhmcnt = xfrm_state_hashmax;
        spin_unlock_bh(&xfrm_state_lock);
 }
@@ -687,7 +673,7 @@ static struct xfrm_state *__xfrm_state_lookup(xfrm_address_t *daddr, __be32 spi,
        struct xfrm_state *x;
        struct hlist_node *entry;
 
-       hlist_for_each_entry(x, entry, xfrm_state_byspi+h, byspi) {
+       hlist_for_each_entry(x, entry, init_net.xfrm.state_byspi+h, byspi) {
                if (x->props.family != family ||
                    x->id.spi       != spi ||
                    x->id.proto     != proto)
@@ -719,7 +705,7 @@ static struct xfrm_state *__xfrm_state_lookup_byaddr(xfrm_address_t *daddr, xfrm
        struct xfrm_state *x;
        struct hlist_node *entry;
 
-       hlist_for_each_entry(x, entry, xfrm_state_bysrc+h, bysrc) {
+       hlist_for_each_entry(x, entry, init_net.xfrm.state_bysrc+h, bysrc) {
                if (x->props.family != family ||
                    x->id.proto     != proto)
                        continue;
@@ -763,9 +749,9 @@ __xfrm_state_locate(struct xfrm_state *x, int use_spi, int family)
 static void xfrm_hash_grow_check(int have_hash_collision)
 {
        if (have_hash_collision &&
-           (xfrm_state_hmask + 1) < xfrm_state_hashmax &&
-           xfrm_state_num > xfrm_state_hmask)
-               schedule_work(&xfrm_hash_work);
+           (init_net.xfrm.state_hmask + 1) < xfrm_state_hashmax &&
+           init_net.xfrm.state_num > init_net.xfrm.state_hmask)
+               schedule_work(&init_net.xfrm.state_hash_work);
 }
 
 struct xfrm_state *
@@ -785,7 +771,7 @@ xfrm_state_find(xfrm_address_t *daddr, xfrm_address_t *saddr,
 
        spin_lock_bh(&xfrm_state_lock);
        h = xfrm_dst_hash(daddr, saddr, tmpl->reqid, family);
-       hlist_for_each_entry(x, entry, xfrm_state_bydst+h, bydst) {
+       hlist_for_each_entry(x, entry, init_net.xfrm.state_bydst+h, bydst) {
                if (x->props.family == family &&
                    x->props.reqid == tmpl->reqid &&
                    !(x->props.flags & XFRM_STATE_WILDRECV) &&
@@ -835,7 +821,7 @@ xfrm_state_find(xfrm_address_t *daddr, xfrm_address_t *saddr,
                        error = -EEXIST;
                        goto out;
                }
-               x = xfrm_state_alloc();
+               x = xfrm_state_alloc(&init_net);
                if (x == NULL) {
                        error = -ENOMEM;
                        goto out;
@@ -854,18 +840,18 @@ xfrm_state_find(xfrm_address_t *daddr, xfrm_address_t *saddr,
 
                if (km_query(x, tmpl, pol) == 0) {
                        x->km.state = XFRM_STATE_ACQ;
-                       list_add(&x->km.all, &xfrm_state_all);
-                       hlist_add_head(&x->bydst, xfrm_state_bydst+h);
+                       list_add(&x->km.all, &init_net.xfrm.state_all);
+                       hlist_add_head(&x->bydst, init_net.xfrm.state_bydst+h);
                        h = xfrm_src_hash(daddr, saddr, family);
-                       hlist_add_head(&x->bysrc, xfrm_state_bysrc+h);
+                       hlist_add_head(&x->bysrc, init_net.xfrm.state_bysrc+h);
                        if (x->id.spi) {
                                h = xfrm_spi_hash(&x->id.daddr, x->id.spi, x->id.proto, family);
-                               hlist_add_head(&x->byspi, xfrm_state_byspi+h);
+                               hlist_add_head(&x->byspi, init_net.xfrm.state_byspi+h);
                        }
                        x->lft.hard_add_expires_seconds = sysctl_xfrm_acq_expires;
                        x->timer.expires = jiffies + sysctl_xfrm_acq_expires*HZ;
                        add_timer(&x->timer);
-                       xfrm_state_num++;
+                       init_net.xfrm.state_num++;
                        xfrm_hash_grow_check(x->bydst.next != NULL);
                } else {
                        x->km.state = XFRM_STATE_DEAD;
@@ -895,7 +881,7 @@ xfrm_stateonly_find(xfrm_address_t *daddr, xfrm_address_t *saddr,
 
        spin_lock(&xfrm_state_lock);
        h = xfrm_dst_hash(daddr, saddr, reqid, family);
-       hlist_for_each_entry(x, entry, xfrm_state_bydst+h, bydst) {
+       hlist_for_each_entry(x, entry, init_net.xfrm.state_bydst+h, bydst) {
                if (x->props.family == family &&
                    x->props.reqid == reqid &&
                    !(x->props.flags & XFRM_STATE_WILDRECV) &&
@@ -923,20 +909,20 @@ static void __xfrm_state_insert(struct xfrm_state *x)
 
        x->genid = ++xfrm_state_genid;
 
-       list_add(&x->km.all, &xfrm_state_all);
+       list_add(&x->km.all, &init_net.xfrm.state_all);
 
        h = xfrm_dst_hash(&x->id.daddr, &x->props.saddr,
                          x->props.reqid, x->props.family);
-       hlist_add_head(&x->bydst, xfrm_state_bydst+h);
+       hlist_add_head(&x->bydst, init_net.xfrm.state_bydst+h);
 
        h = xfrm_src_hash(&x->id.daddr, &x->props.saddr, x->props.family);
-       hlist_add_head(&x->bysrc, xfrm_state_bysrc+h);
+       hlist_add_head(&x->bysrc, init_net.xfrm.state_bysrc+h);
 
        if (x->id.spi) {
                h = xfrm_spi_hash(&x->id.daddr, x->id.spi, x->id.proto,
                                  x->props.family);
 
-               hlist_add_head(&x->byspi, xfrm_state_byspi+h);
+               hlist_add_head(&x->byspi, init_net.xfrm.state_byspi+h);
        }
 
        mod_timer(&x->timer, jiffies + HZ);
@@ -945,7 +931,7 @@ static void __xfrm_state_insert(struct xfrm_state *x)
 
        wake_up(&km_waitq);
 
-       xfrm_state_num++;
+       init_net.xfrm.state_num++;
 
        xfrm_hash_grow_check(x->bydst.next != NULL);
 }
@@ -960,7 +946,7 @@ static void __xfrm_state_bump_genids(struct xfrm_state *xnew)
        unsigned int h;
 
        h = xfrm_dst_hash(&xnew->id.daddr, &xnew->props.saddr, reqid, family);
-       hlist_for_each_entry(x, entry, xfrm_state_bydst+h, bydst) {
+       hlist_for_each_entry(x, entry, init_net.xfrm.state_bydst+h, bydst) {
                if (x->props.family     == family &&
                    x->props.reqid      == reqid &&
                    !xfrm_addr_cmp(&x->id.daddr, &xnew->id.daddr, family) &&
@@ -985,7 +971,7 @@ static struct xfrm_state *__find_acq_core(unsigned short family, u8 mode, u32 re
        struct hlist_node *entry;
        struct xfrm_state *x;
 
-       hlist_for_each_entry(x, entry, xfrm_state_bydst+h, bydst) {
+       hlist_for_each_entry(x, entry, init_net.xfrm.state_bydst+h, bydst) {
                if (x->props.reqid  != reqid ||
                    x->props.mode   != mode ||
                    x->props.family != family ||
@@ -1017,7 +1003,7 @@ static struct xfrm_state *__find_acq_core(unsigned short family, u8 mode, u32 re
        if (!create)
                return NULL;
 
-       x = xfrm_state_alloc();
+       x = xfrm_state_alloc(&init_net);
        if (likely(x)) {
                switch (family) {
                case AF_INET:
@@ -1052,12 +1038,12 @@ static struct xfrm_state *__find_acq_core(unsigned short family, u8 mode, u32 re
                xfrm_state_hold(x);
                x->timer.expires = jiffies + sysctl_xfrm_acq_expires*HZ;
                add_timer(&x->timer);
-               list_add(&x->km.all, &xfrm_state_all);
-               hlist_add_head(&x->bydst, xfrm_state_bydst+h);
+               list_add(&x->km.all, &init_net.xfrm.state_all);
+               hlist_add_head(&x->bydst, init_net.xfrm.state_bydst+h);
                h = xfrm_src_hash(daddr, saddr, family);
-               hlist_add_head(&x->bysrc, xfrm_state_bysrc+h);
+               hlist_add_head(&x->bysrc, init_net.xfrm.state_bysrc+h);
 
-               xfrm_state_num++;
+               init_net.xfrm.state_num++;
 
                xfrm_hash_grow_check(x->bydst.next != NULL);
        }
@@ -1125,7 +1111,7 @@ EXPORT_SYMBOL(xfrm_state_add);
 static struct xfrm_state *xfrm_state_clone(struct xfrm_state *orig, int *errp)
 {
        int err = -ENOMEM;
-       struct xfrm_state *x = xfrm_state_alloc();
+       struct xfrm_state *x = xfrm_state_alloc(&init_net);
        if (!x)
                goto error;
 
@@ -1208,7 +1194,7 @@ struct xfrm_state * xfrm_migrate_state_find(struct xfrm_migrate *m)
        if (m->reqid) {
                h = xfrm_dst_hash(&m->old_daddr, &m->old_saddr,
                                  m->reqid, m->old_family);
-               hlist_for_each_entry(x, entry, xfrm_state_bydst+h, bydst) {
+               hlist_for_each_entry(x, entry, init_net.xfrm.state_bydst+h, bydst) {
                        if (x->props.mode != m->mode ||
                            x->id.proto != m->proto)
                                continue;
@@ -1225,7 +1211,7 @@ struct xfrm_state * xfrm_migrate_state_find(struct xfrm_migrate *m)
        } else {
                h = xfrm_src_hash(&m->old_daddr, &m->old_saddr,
                                  m->old_family);
-               hlist_for_each_entry(x, entry, xfrm_state_bysrc+h, bysrc) {
+               hlist_for_each_entry(x, entry, init_net.xfrm.state_bysrc+h, bysrc) {
                        if (x->props.mode != m->mode ||
                            x->id.proto != m->proto)
                                continue;
@@ -1453,11 +1439,11 @@ static struct xfrm_state *__xfrm_find_acq_byseq(u32 seq)
 {
        int i;
 
-       for (i = 0; i <= xfrm_state_hmask; i++) {
+       for (i = 0; i <= init_net.xfrm.state_hmask; i++) {
                struct hlist_node *entry;
                struct xfrm_state *x;
 
-               hlist_for_each_entry(x, entry, xfrm_state_bydst+i, bydst) {
+               hlist_for_each_entry(x, entry, init_net.xfrm.state_bydst+i, bydst) {
                        if (x->km.seq == seq &&
                            x->km.state == XFRM_STATE_ACQ) {
                                xfrm_state_hold(x);
@@ -1532,7 +1518,7 @@ int xfrm_alloc_spi(struct xfrm_state *x, u32 low, u32 high)
        if (x->id.spi) {
                spin_lock_bh(&xfrm_state_lock);
                h = xfrm_spi_hash(&x->id.daddr, x->id.spi, x->id.proto, x->props.family);
-               hlist_add_head(&x->byspi, xfrm_state_byspi+h);
+               hlist_add_head(&x->byspi, init_net.xfrm.state_byspi+h);
                spin_unlock_bh(&xfrm_state_lock);
 
                err = 0;
@@ -1558,10 +1544,10 @@ int xfrm_state_walk(struct xfrm_state_walk *walk,
 
        spin_lock_bh(&xfrm_state_lock);
        if (list_empty(&walk->all))
-               x = list_first_entry(&xfrm_state_all, struct xfrm_state_walk, all);
+               x = list_first_entry(&init_net.xfrm.state_all, struct xfrm_state_walk, all);
        else
                x = list_entry(&walk->all, struct xfrm_state_walk, all);
-       list_for_each_entry_from(x, &xfrm_state_all, all) {
+       list_for_each_entry_from(x, &init_net.xfrm.state_all, all) {
                if (x->state == XFRM_STATE_DEAD)
                        continue;
                state = container_of(x, struct xfrm_state, km);
@@ -2080,20 +2066,52 @@ error:
 
 EXPORT_SYMBOL(xfrm_init_state);
 
-void __init xfrm_state_init(void)
+int __net_init xfrm_state_init(struct net *net)
 {
        unsigned int sz;
 
+       INIT_LIST_HEAD(&net->xfrm.state_all);
+
        sz = sizeof(struct hlist_head) * 8;
 
-       xfrm_state_bydst = xfrm_hash_alloc(sz);
-       xfrm_state_bysrc = xfrm_hash_alloc(sz);
-       xfrm_state_byspi = xfrm_hash_alloc(sz);
-       if (!xfrm_state_bydst || !xfrm_state_bysrc || !xfrm_state_byspi)
-               panic("XFRM: Cannot allocate bydst/bysrc/byspi hashes.");
-       xfrm_state_hmask = ((sz / sizeof(struct hlist_head)) - 1);
+       net->xfrm.state_bydst = xfrm_hash_alloc(sz);
+       if (!net->xfrm.state_bydst)
+               goto out_bydst;
+       net->xfrm.state_bysrc = xfrm_hash_alloc(sz);
+       if (!net->xfrm.state_bysrc)
+               goto out_bysrc;
+       net->xfrm.state_byspi = xfrm_hash_alloc(sz);
+       if (!net->xfrm.state_byspi)
+               goto out_byspi;
+       net->xfrm.state_hmask = ((sz / sizeof(struct hlist_head)) - 1);
+
+       net->xfrm.state_num = 0;
+       INIT_WORK(&net->xfrm.state_hash_work, xfrm_hash_resize);
+       INIT_HLIST_HEAD(&net->xfrm.state_gc_list);
+       INIT_WORK(&net->xfrm.state_gc_work, xfrm_state_gc_task);
+       return 0;
+
+out_byspi:
+       xfrm_hash_free(net->xfrm.state_bysrc, sz);
+out_bysrc:
+       xfrm_hash_free(net->xfrm.state_bydst, sz);
+out_bydst:
+       return -ENOMEM;
+}
+
+void xfrm_state_fini(struct net *net)
+{
+       unsigned int sz;
+
+       WARN_ON(!list_empty(&net->xfrm.state_all));
 
-       INIT_WORK(&xfrm_state_gc_work, xfrm_state_gc_task);
+       sz = (net->xfrm.state_hmask + 1) * sizeof(struct hlist_head);
+       WARN_ON(!hlist_empty(net->xfrm.state_byspi));
+       xfrm_hash_free(net->xfrm.state_byspi, sz);
+       WARN_ON(!hlist_empty(net->xfrm.state_bysrc));
+       xfrm_hash_free(net->xfrm.state_bysrc, sz);
+       WARN_ON(!hlist_empty(net->xfrm.state_bydst));
+       xfrm_hash_free(net->xfrm.state_bydst, sz);
 }
 
 #ifdef CONFIG_AUDITSYSCALL
@@ -2109,16 +2127,12 @@ static void xfrm_audit_helper_sainfo(struct xfrm_state *x,
 
        switch(x->props.family) {
        case AF_INET:
-               audit_log_format(audit_buf,
-                                " src=" NIPQUAD_FMT " dst=" NIPQUAD_FMT,
-                                NIPQUAD(x->props.saddr.a4),
-                                NIPQUAD(x->id.daddr.a4));
+               audit_log_format(audit_buf, " src=%pI4 dst=%pI4",
+                                &x->props.saddr.a4, &x->id.daddr.a4);
                break;
        case AF_INET6:
-               audit_log_format(audit_buf,
-                                " src=" NIP6_FMT " dst=" NIP6_FMT,
-                                NIP6(*(struct in6_addr *)x->props.saddr.a6),
-                                NIP6(*(struct in6_addr *)x->id.daddr.a6));
+               audit_log_format(audit_buf, " src=%pI6 dst=%pI6",
+                                x->props.saddr.a6, x->id.daddr.a6);
                break;
        }
 
@@ -2134,18 +2148,14 @@ static void xfrm_audit_helper_pktinfo(struct sk_buff *skb, u16 family,
        switch (family) {
        case AF_INET:
                iph4 = ip_hdr(skb);
-               audit_log_format(audit_buf,
-                                " src=" NIPQUAD_FMT " dst=" NIPQUAD_FMT,
-                                NIPQUAD(iph4->saddr),
-                                NIPQUAD(iph4->daddr));
+               audit_log_format(audit_buf, " src=%pI4 dst=%pI4",
+                                &iph4->saddr, &iph4->daddr);
                break;
        case AF_INET6:
                iph6 = ipv6_hdr(skb);
                audit_log_format(audit_buf,
-                                " src=" NIP6_FMT " dst=" NIP6_FMT
-                                " flowlbl=0x%x%02x%02x",
-                                NIP6(iph6->saddr),
-                                NIP6(iph6->daddr),
+                                " src=%pI6 dst=%pI6 flowlbl=0x%x%02x%02x",
+                                &iph6->saddr,&iph6->daddr,
                                 iph6->flow_lbl[0] & 0x0f,
                                 iph6->flow_lbl[1],
                                 iph6->flow_lbl[2]);
This page took 0.034826 seconds and 5 git commands to generate.