lttng: Fix more Sonar warnings in LTTng Tracer Control

[deliverable/tracecompass.git] / org.eclipse.linuxtools.lttng2.ui / src / org / eclipse / linuxtools / internal / lttng2 / ui / views / control / dialogs / GetEventInfoDialog.java

diff --git a/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/GetEventInfoDialog.java b/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/GetEventInfoDialog.java
index e71ce19ab3bf58a9aa79525d45fb56299e13abbc..28ebd7fb4ca70cb00dc9f543a936ddf0009fc999 100644 (file)
--- a/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/GetEventInfoDialog.java
+++ b/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/GetEventInfoDialog.java
@@ -55,18 +55,6 @@ public class GetEventInfoDialog extends Dialog implements IGetEventInfoDialog {
     // ------------------------------------------------------------------------
     // Attributes
     // ------------------------------------------------------------------------
-    /**
-     * The dialog composite.
-     */
-    private Composite fDialogComposite = null;
-    /**
-     * The Group for the session combo box.
-     */
-    private Group fSessionsGroup = null;
-    /**
-     * The Group for the channel combo box.
-     */
-    private Group fChannelsGroup = null;
     /**
      * The session combo box.
      */
@@ -160,19 +148,19 @@ public class GetEventInfoDialog extends Dialog implements IGetEventInfoDialog {
     protected Control createDialogArea(Composite parent) {
 
         // Main dialog panel
-        fDialogComposite = new Composite(parent, SWT.NONE);
+        Composite dialogComposite = new Composite(parent, SWT.NONE);
         GridLayout layout = new GridLayout(1, true);
-        fDialogComposite.setLayout(layout);
-        fDialogComposite.setLayoutData(new GridData(GridData.FILL_BOTH));
+        dialogComposite.setLayout(layout);
+        dialogComposite.setLayoutData(new GridData(GridData.FILL_BOTH));
 
-        fSessionsGroup = new Group(fDialogComposite, SWT.SHADOW_NONE);
-        fSessionsGroup.setText(Messages.TraceControl_EnableEventsSessionGroupName);
+        Group sessionsGroup = new Group(dialogComposite, SWT.SHADOW_NONE);
+        sessionsGroup.setText(Messages.TraceControl_EnableEventsSessionGroupName);
         layout = new GridLayout(1, true);
-        fSessionsGroup.setLayout(layout);
+        sessionsGroup.setLayout(layout);
         GridData data = new GridData(GridData.FILL_HORIZONTAL);
-        fSessionsGroup.setLayoutData(data);
+        sessionsGroup.setLayoutData(data);
 
-        fSessionsCombo = new CCombo(fSessionsGroup, SWT.READ_ONLY);
+        fSessionsCombo = new CCombo(sessionsGroup, SWT.READ_ONLY);
         fSessionsCombo.setToolTipText(Messages.TraceControl_EnableEventsSessionsTooltip);
         fSessionsCombo.setLayoutData(new GridData(GridData.FILL_HORIZONTAL));
 
@@ -184,14 +172,14 @@ public class GetEventInfoDialog extends Dialog implements IGetEventInfoDialog {
         fSessionsCombo.setItems(items);
         fSessionsCombo.setEnabled(fSessions.length > 0);
 
-        fChannelsGroup = new Group(fDialogComposite, SWT.SHADOW_NONE);
-        fChannelsGroup.setText(Messages.TraceControl_EnableEventsChannelGroupName);
+        Group channelsGroup = new Group(dialogComposite, SWT.SHADOW_NONE);
+        channelsGroup.setText(Messages.TraceControl_EnableEventsChannelGroupName);
         layout = new GridLayout(1, true);
-        fChannelsGroup.setLayout(layout);
+        channelsGroup.setLayout(layout);
         data = new GridData(GridData.FILL_HORIZONTAL);
-        fChannelsGroup.setLayoutData(data);
+        channelsGroup.setLayoutData(data);
 
-        fChannelsCombo = new CCombo(fChannelsGroup, SWT.READ_ONLY);
+        fChannelsCombo = new CCombo(channelsGroup, SWT.READ_ONLY);
         fChannelsCombo.setToolTipText(Messages.TraceControl_EnableEventsChannelsTooltip);
         fChannelsCombo.setLayoutData(new GridData(GridData.FILL_HORIZONTAL));
         fChannelsCombo.setEnabled(false);
@@ -236,7 +224,7 @@ public class GetEventInfoDialog extends Dialog implements IGetEventInfoDialog {
 
         // take first session to test whether events filtering is supported or not
         if (fSessions[0].isEventFilteringSupported() && !fIsKernel) {
-            Group filterMainGroup = new Group(fDialogComposite, SWT.SHADOW_NONE);
+            Group filterMainGroup = new Group(dialogComposite, SWT.SHADOW_NONE);
             filterMainGroup.setText(Messages.TraceControl_EnableEventsFilterGroupName);
             layout = new GridLayout(2, false);
             filterMainGroup.setLayout(layout);
@@ -251,7 +239,7 @@ public class GetEventInfoDialog extends Dialog implements IGetEventInfoDialog {
 
         getShell().setMinimumSize(new Point(300, 200));
 
-        return fDialogComposite;
+        return dialogComposite;
     }
 
     @Override