ASoC: wm8903: Move interrupt request to I2C probe
[deliverable/linux.git] / sound / soc / codecs / wm8903.c
index f6a3fc5f09c024f83cd33233c9b236665f17efa9..7261a68aac6fa87ac39272b1c6d5d06a27d15b90 100644 (file)
@@ -1,7 +1,7 @@
 /*
  * wm8903.c  --  WM8903 ALSA SoC Audio driver
  *
- * Copyright 2008 Wolfson Microelectronics
+ * Copyright 2008-12 Wolfson Microelectronics
  * Copyright 2011-2012 NVIDIA, Inc.
  *
  * Author: Mark Brown <broonie@opensource.wolfsonmicro.com>
@@ -1636,17 +1636,27 @@ EXPORT_SYMBOL_GPL(wm8903_mic_detect);
 
 static irqreturn_t wm8903_irq(int irq, void *data)
 {
-       struct snd_soc_codec *codec = data;
-       struct wm8903_priv *wm8903 = snd_soc_codec_get_drvdata(codec);
-       int mic_report;
-       int int_pol;
-       int int_val = 0;
-       int mask = ~snd_soc_read(codec, WM8903_INTERRUPT_STATUS_1_MASK);
+       struct wm8903_priv *wm8903 = data;
+       int mic_report, ret;
+       unsigned int int_val, mask, int_pol;
+
+       ret = regmap_read(wm8903->regmap, WM8903_INTERRUPT_STATUS_1_MASK,
+                         &mask);
+       if (ret != 0) {
+               dev_err(wm8903->dev, "Failed to read IRQ mask: %d\n", ret);
+               return IRQ_NONE;
+       }
 
-       int_val = snd_soc_read(codec, WM8903_INTERRUPT_STATUS_1) & mask;
+       ret = regmap_read(wm8903->regmap, WM8903_INTERRUPT_STATUS_1, &int_val);
+       if (ret != 0) {
+               dev_err(wm8903->dev, "Failed to read IRQ status: %d\n", ret);
+               return IRQ_NONE;
+       }
+
+       int_val &= ~mask;
 
        if (int_val & WM8903_WSEQ_BUSY_EINT) {
-               dev_warn(codec->dev, "Write sequencer done\n");
+               dev_warn(wm8903->dev, "Write sequencer done\n");
        }
 
        /*
@@ -1657,22 +1667,28 @@ static irqreturn_t wm8903_irq(int irq, void *data)
         * the polarity register.
         */
        mic_report = wm8903->mic_last_report;
-       int_pol = snd_soc_read(codec, WM8903_INTERRUPT_POLARITY_1);
+       ret = regmap_read(wm8903->regmap, WM8903_INTERRUPT_POLARITY_1,
+                         &int_pol);
+       if (ret != 0) {
+               dev_err(wm8903->dev, "Failed to read interrupt polarity: %d\n",
+                       ret);
+               return IRQ_HANDLED;
+       }
 
 #ifndef CONFIG_SND_SOC_WM8903_MODULE
        if (int_val & (WM8903_MICSHRT_EINT | WM8903_MICDET_EINT))
-               trace_snd_soc_jack_irq(dev_name(codec->dev));
+               trace_snd_soc_jack_irq(dev_name(wm8903->dev));
 #endif
 
        if (int_val & WM8903_MICSHRT_EINT) {
-               dev_dbg(codec->dev, "Microphone short (pol=%x)\n", int_pol);
+               dev_dbg(wm8903->dev, "Microphone short (pol=%x)\n", int_pol);
 
                mic_report ^= wm8903->mic_short;
                int_pol ^= WM8903_MICSHRT_INV;
        }
 
        if (int_val & WM8903_MICDET_EINT) {
-               dev_dbg(codec->dev, "Microphone detect (pol=%x)\n", int_pol);
+               dev_dbg(wm8903->dev, "Microphone detect (pol=%x)\n", int_pol);
 
                mic_report ^= wm8903->mic_det;
                int_pol ^= WM8903_MICDET_INV;
@@ -1680,8 +1696,8 @@ static irqreturn_t wm8903_irq(int irq, void *data)
                msleep(wm8903->mic_delay);
        }
 
-       snd_soc_update_bits(codec, WM8903_INTERRUPT_POLARITY_1,
-                           WM8903_MICSHRT_INV | WM8903_MICDET_INV, int_pol);
+       regmap_update_bits(wm8903->regmap, WM8903_INTERRUPT_POLARITY_1,
+                          WM8903_MICSHRT_INV | WM8903_MICDET_INV, int_pol);
 
        snd_soc_jack_report(wm8903->mic_jack, mic_report,
                            wm8903->mic_short | wm8903->mic_det);
@@ -1879,11 +1895,8 @@ static void wm8903_free_gpio(struct wm8903_priv *wm8903)
 static int wm8903_probe(struct snd_soc_codec *codec)
 {
        struct wm8903_priv *wm8903 = snd_soc_codec_get_drvdata(codec);
-       struct wm8903_platform_data *pdata = wm8903->pdata;
-       int ret, i;
-       int trigger, irq_pol;
+       int ret;
        u16 val;
-       bool mic_gpio = false;
 
        wm8903->codec = codec;
        codec->control_data = wm8903->regmap;
@@ -1894,73 +1907,6 @@ static int wm8903_probe(struct snd_soc_codec *codec)
                return ret;
        }
 
-       /* Set up GPIOs, detect if any are MIC detect outputs */
-       for (i = 0; i < ARRAY_SIZE(pdata->gpio_cfg); i++) {
-               if ((!pdata->gpio_cfg[i]) ||
-                   (pdata->gpio_cfg[i] > WM8903_GPIO_CONFIG_ZERO))
-                       continue;
-
-               snd_soc_write(codec, WM8903_GPIO_CONTROL_1 + i,
-                               pdata->gpio_cfg[i] & 0x7fff);
-
-               val = (pdata->gpio_cfg[i] & WM8903_GP1_FN_MASK)
-                       >> WM8903_GP1_FN_SHIFT;
-
-               switch (val) {
-               case WM8903_GPn_FN_MICBIAS_CURRENT_DETECT:
-               case WM8903_GPn_FN_MICBIAS_SHORT_DETECT:
-                       mic_gpio = true;
-                       break;
-               default:
-                       break;
-               }
-       }
-
-       /* Set up microphone detection */
-       snd_soc_write(codec, WM8903_MIC_BIAS_CONTROL_0,
-                       pdata->micdet_cfg);
-
-       /* Microphone detection needs the WSEQ clock */
-       if (pdata->micdet_cfg)
-               snd_soc_update_bits(codec, WM8903_WRITE_SEQUENCER_0,
-                                   WM8903_WSEQ_ENA, WM8903_WSEQ_ENA);
-
-       /* If microphone detection is enabled by pdata but
-           * detected via IRQ then interrupts can be lost before
-           * the machine driver has set up microphone detection
-           * IRQs as the IRQs are clear on read.  The detection
-           * will be enabled when the machine driver configures.
-           */
-       WARN_ON(!mic_gpio && (pdata->micdet_cfg & WM8903_MICDET_ENA));
-
-       wm8903->mic_delay = pdata->micdet_delay;
-
-       if (wm8903->irq) {
-               if (pdata->irq_active_low) {
-                       trigger = IRQF_TRIGGER_LOW;
-                       irq_pol = WM8903_IRQ_POL;
-               } else {
-                       trigger = IRQF_TRIGGER_HIGH;
-                       irq_pol = 0;
-               }
-
-               snd_soc_update_bits(codec, WM8903_INTERRUPT_CONTROL,
-                                   WM8903_IRQ_POL, irq_pol);
-               
-               ret = request_threaded_irq(wm8903->irq, NULL, wm8903_irq,
-                                          trigger | IRQF_ONESHOT,
-                                          "wm8903", codec);
-               if (ret != 0) {
-                       dev_err(codec->dev, "Failed to request IRQ: %d\n",
-                               ret);
-                       return ret;
-               }
-
-               /* Enable write sequencer interrupts */
-               snd_soc_update_bits(codec, WM8903_INTERRUPT_STATUS_1_MASK,
-                                   WM8903_IM_WSEQ_BUSY_EINT, 0);
-       }
-
        /* power on device */
        wm8903_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
 
@@ -2001,11 +1947,7 @@ static int wm8903_probe(struct snd_soc_codec *codec)
 /* power down chip */
 static int wm8903_remove(struct snd_soc_codec *codec)
 {
-       struct wm8903_priv *wm8903 = snd_soc_codec_get_drvdata(codec);
-
        wm8903_set_bias_level(codec, SND_SOC_BIAS_OFF);
-       if (wm8903->irq)
-               free_irq(wm8903->irq, codec);
 
        return 0;
 }
@@ -2115,8 +2057,10 @@ static __devinit int wm8903_i2c_probe(struct i2c_client *i2c,
 {
        struct wm8903_platform_data *pdata = dev_get_platdata(&i2c->dev);
        struct wm8903_priv *wm8903;
-       unsigned int val;
-       int ret;
+       int trigger;
+       bool mic_gpio = false;
+       unsigned int val, irq_pol;
+       int ret, i;
 
        wm8903 = devm_kzalloc(&i2c->dev,  sizeof(struct wm8903_priv),
                              GFP_KERNEL);
@@ -2124,7 +2068,7 @@ static __devinit int wm8903_i2c_probe(struct i2c_client *i2c,
                return -ENOMEM;
        wm8903->dev = &i2c->dev;
 
-       wm8903->regmap = regmap_init_i2c(i2c, &wm8903_regmap);
+       wm8903->regmap = devm_regmap_init_i2c(i2c, &wm8903_regmap);
        if (IS_ERR(wm8903->regmap)) {
                ret = PTR_ERR(wm8903->regmap);
                dev_err(&i2c->dev, "Failed to allocate register map: %d\n",
@@ -2133,7 +2077,6 @@ static __devinit int wm8903_i2c_probe(struct i2c_client *i2c,
        }
 
        i2c_set_clientdata(i2c, wm8903);
-       wm8903->irq = i2c->irq;
 
        /* If no platform data was supplied, create storage for defaults */
        if (pdata) {
@@ -2160,6 +2103,8 @@ static __devinit int wm8903_i2c_probe(struct i2c_client *i2c,
                }
        }
 
+       pdata = wm8903->pdata;
+
        ret = regmap_read(wm8903->regmap, WM8903_SW_RESET_AND_ID, &val);
        if (ret != 0) {
                dev_err(&i2c->dev, "Failed to read chip ID: %d\n", ret);
@@ -2184,6 +2129,74 @@ static __devinit int wm8903_i2c_probe(struct i2c_client *i2c,
 
        wm8903_init_gpio(wm8903);
 
+       /* Set up GPIO pin state, detect if any are MIC detect outputs */
+       for (i = 0; i < ARRAY_SIZE(pdata->gpio_cfg); i++) {
+               if ((!pdata->gpio_cfg[i]) ||
+                   (pdata->gpio_cfg[i] > WM8903_GPIO_CONFIG_ZERO))
+                       continue;
+
+               regmap_write(wm8903->regmap, WM8903_GPIO_CONTROL_1 + i,
+                               pdata->gpio_cfg[i] & 0x7fff);
+
+               val = (pdata->gpio_cfg[i] & WM8903_GP1_FN_MASK)
+                       >> WM8903_GP1_FN_SHIFT;
+
+               switch (val) {
+               case WM8903_GPn_FN_MICBIAS_CURRENT_DETECT:
+               case WM8903_GPn_FN_MICBIAS_SHORT_DETECT:
+                       mic_gpio = true;
+                       break;
+               default:
+                       break;
+               }
+       }
+
+       /* Set up microphone detection */
+       regmap_write(wm8903->regmap, WM8903_MIC_BIAS_CONTROL_0,
+                    pdata->micdet_cfg);
+
+       /* Microphone detection needs the WSEQ clock */
+       if (pdata->micdet_cfg)
+               regmap_update_bits(wm8903->regmap, WM8903_WRITE_SEQUENCER_0,
+                                  WM8903_WSEQ_ENA, WM8903_WSEQ_ENA);
+
+       /* If microphone detection is enabled by pdata but
+        * detected via IRQ then interrupts can be lost before
+        * the machine driver has set up microphone detection
+        * IRQs as the IRQs are clear on read.  The detection
+        * will be enabled when the machine driver configures.
+        */
+       WARN_ON(!mic_gpio && (pdata->micdet_cfg & WM8903_MICDET_ENA));
+
+       wm8903->mic_delay = pdata->micdet_delay;
+
+       if (i2c->irq) {
+               if (pdata->irq_active_low) {
+                       trigger = IRQF_TRIGGER_LOW;
+                       irq_pol = WM8903_IRQ_POL;
+               } else {
+                       trigger = IRQF_TRIGGER_HIGH;
+                       irq_pol = 0;
+               }
+
+               regmap_update_bits(wm8903->regmap, WM8903_INTERRUPT_CONTROL,
+                                  WM8903_IRQ_POL, irq_pol);
+
+               ret = request_threaded_irq(i2c->irq, NULL, wm8903_irq,
+                                          trigger | IRQF_ONESHOT,
+                                          "wm8903", wm8903);
+               if (ret != 0) {
+                       dev_err(wm8903->dev, "Failed to request IRQ: %d\n",
+                               ret);
+                       return ret;
+               }
+
+               /* Enable write sequencer interrupts */
+               regmap_update_bits(wm8903->regmap,
+                                  WM8903_INTERRUPT_STATUS_1_MASK,
+                                  WM8903_IM_WSEQ_BUSY_EINT, 0);
+       }
+
        ret = snd_soc_register_codec(&i2c->dev,
                        &soc_codec_dev_wm8903, &wm8903_dai, 1);
        if (ret != 0)
@@ -2191,7 +2204,6 @@ static __devinit int wm8903_i2c_probe(struct i2c_client *i2c,
 
        return 0;
 err:
-       regmap_exit(wm8903->regmap);
        return ret;
 }
 
@@ -2199,8 +2211,9 @@ static __devexit int wm8903_i2c_remove(struct i2c_client *client)
 {
        struct wm8903_priv *wm8903 = i2c_get_clientdata(client);
 
+       if (client->irq)
+               free_irq(client->irq, wm8903);
        wm8903_free_gpio(wm8903);
-       regmap_exit(wm8903->regmap);
        snd_soc_unregister_codec(&client->dev);
 
        return 0;
This page took 0.028187 seconds and 5 git commands to generate.