ASoC: simple-card: simplify code
[deliverable/linux.git] / sound / soc / generic / simple-card.c
index 2a1b1b5b5221089f32e395087e9c4651ddd00799..9068ab474ab45959651a083b660a3a3a98274ddf 100644 (file)
@@ -60,8 +60,10 @@ static int asoc_simple_card_dai_init(struct snd_soc_pcm_runtime *rtd)
 static int
 asoc_simple_card_sub_parse_of(struct device_node *np,
                              struct asoc_simple_dai *dai,
-                             struct device_node **node)
+                             const struct device_node **p_node,
+                             const char **name)
 {
+       struct device_node *node;
        struct clk *clk;
        int ret;
 
@@ -69,12 +71,13 @@ asoc_simple_card_sub_parse_of(struct device_node *np,
         * get node via "sound-dai = <&phandle port>"
         * it will be used as xxx_of_node on soc_bind_dai_link()
         */
-       *node = of_parse_phandle(np, "sound-dai", 0);
-       if (!*node)
+       node = of_parse_phandle(np, "sound-dai", 0);
+       if (!node)
                return -ENODEV;
+       *p_node = node;
 
        /* get dai->name */
-       ret = snd_soc_of_get_dai_name(np, &dai->name);
+       ret = snd_soc_of_get_dai_name(np, name);
        if (ret < 0)
                goto parse_error;
 
@@ -104,7 +107,7 @@ asoc_simple_card_sub_parse_of(struct device_node *np,
                                     "system-clock-frequency",
                                     &dai->sysclk);
        } else {
-               clk = of_clk_get(*node, 0);
+               clk = of_clk_get(node, 0);
                if (!IS_ERR(clk))
                        dai->sysclk = clk_get_rate(clk);
        }
@@ -112,18 +115,16 @@ asoc_simple_card_sub_parse_of(struct device_node *np,
        ret = 0;
 
 parse_error:
-       of_node_put(*node);
+       of_node_put(node);
 
        return ret;
 }
 
 static int asoc_simple_card_parse_of(struct device_node *node,
                                     struct asoc_simple_card_info *info,
-                                    struct device *dev,
-                                    struct device_node **of_cpu,
-                                    struct device_node **of_codec,
-                                    struct device_node **of_platform)
+                                    struct device *dev)
 {
+       struct snd_soc_dai_link *dai_link = info->snd_card.dai_link;
        struct device_node *np;
        char *name;
        int ret;
@@ -146,7 +147,8 @@ static int asoc_simple_card_parse_of(struct device_node *node,
        if (np)
                ret = asoc_simple_card_sub_parse_of(np,
                                                  &info->cpu_dai,
-                                                 of_cpu);
+                                                 &dai_link->cpu_of_node,
+                                                 &dai_link->cpu_dai_name);
        if (ret < 0)
                return ret;
 
@@ -156,32 +158,35 @@ static int asoc_simple_card_parse_of(struct device_node *node,
        if (np)
                ret = asoc_simple_card_sub_parse_of(np,
                                                  &info->codec_dai,
-                                                 of_codec);
+                                                 &dai_link->codec_of_node,
+                                                 &dai_link->codec_dai_name);
        if (ret < 0)
                return ret;
 
-       if (!info->cpu_dai.name || !info->codec_dai.name)
+       if (!dai_link->cpu_dai_name || !dai_link->codec_dai_name)
                return -EINVAL;
 
        /* card name is created from CPU/CODEC dai name */
        name = devm_kzalloc(dev,
-                           strlen(info->cpu_dai.name)   +
-                           strlen(info->codec_dai.name) + 2,
+                           strlen(dai_link->cpu_dai_name)   +
+                           strlen(dai_link->codec_dai_name) + 2,
                            GFP_KERNEL);
-       sprintf(name, "%s-%s", info->cpu_dai.name, info->codec_dai.name);
-       info->name = info->card = name;
+       sprintf(name, "%s-%s", dai_link->cpu_dai_name,
+                               dai_link->codec_dai_name);
+       info->snd_card.name = name;
+       dai_link->name = dai_link->stream_name = name;
 
        /* simple-card assumes platform == cpu */
-       *of_platform = *of_cpu;
+       dai_link->platform_of_node = dai_link->cpu_of_node;
 
-       dev_dbg(dev, "card-name : %s\n", info->card);
+       dev_dbg(dev, "card-name : %s\n", name);
        dev_dbg(dev, "platform : %04x\n", info->daifmt);
        dev_dbg(dev, "cpu : %s / %04x / %d\n",
-               info->cpu_dai.name,
+               dai_link->cpu_dai_name,
                info->cpu_dai.fmt,
                info->cpu_dai.sysclk);
        dev_dbg(dev, "codec : %s / %04x / %d\n",
-               info->codec_dai.name,
+               dai_link->codec_dai_name,
                info->codec_dai.fmt,
                info->codec_dai.sysclk);
 
@@ -191,27 +196,27 @@ static int asoc_simple_card_parse_of(struct device_node *node,
 static int asoc_simple_card_probe(struct platform_device *pdev)
 {
        struct asoc_simple_card_info *cinfo;
+       struct snd_soc_dai_link *dai_link;
        struct device_node *np = pdev->dev.of_node;
-       struct device_node *of_cpu, *of_codec, *of_platform;
        struct device *dev = &pdev->dev;
        int ret;
 
-       cinfo           = NULL;
-       of_cpu          = NULL;
-       of_codec        = NULL;
-       of_platform     = NULL;
-
        cinfo = devm_kzalloc(dev, sizeof(*cinfo), GFP_KERNEL);
        if (!cinfo)
                return -ENOMEM;
 
+       /*
+        * init snd_soc_card
+        */
+       cinfo->snd_card.owner           = THIS_MODULE;
+       cinfo->snd_card.dev = dev;
+       dai_link = &cinfo->snd_link;
+       cinfo->snd_card.dai_link = dai_link;
+       cinfo->snd_card.num_links = 1;
+
        if (np && of_device_is_available(np)) {
-               cinfo->snd_card.dev = dev;
 
-               ret = asoc_simple_card_parse_of(np, cinfo, dev,
-                                               &of_cpu,
-                                               &of_codec,
-                                               &of_platform);
+               ret = asoc_simple_card_parse_of(np, cinfo, dev);
                if (ret < 0) {
                        if (ret != -EPROBE_DEFER)
                                dev_err(dev, "parse error %d\n", ret);
@@ -224,40 +229,29 @@ static int asoc_simple_card_probe(struct platform_device *pdev)
                }
 
                memcpy(cinfo, dev->platform_data, sizeof(*cinfo));
-               cinfo->snd_card.dev = dev;
-       }
+               if (!cinfo->name        ||
+                   !cinfo->card        ||
+                   !cinfo->codec_dai.name      ||
+                   !cinfo->codec       ||
+                   !cinfo->platform    ||
+                   !cinfo->cpu_dai.name) {
+                       dev_err(dev, "insufficient asoc_simple_card_info settings\n");
+                       return -EINVAL;
+               }
 
-       if (!cinfo->name        ||
-           !cinfo->card        ||
-           !cinfo->codec_dai.name      ||
-           !(cinfo->codec              || of_codec)    ||
-           !(cinfo->platform           || of_platform) ||
-           !(cinfo->cpu_dai.name       || of_cpu)) {
-               dev_err(dev, "insufficient asoc_simple_card_info settings\n");
-               return -EINVAL;
+               cinfo->snd_card.name            = cinfo->card;
+               dai_link->name          = cinfo->name;
+               dai_link->stream_name   = cinfo->name;
+               dai_link->platform_name = cinfo->platform;
+               dai_link->codec_name    = cinfo->codec;
+               dai_link->cpu_dai_name  = cinfo->cpu_dai.name;
+               dai_link->codec_dai_name = cinfo->codec_dai.name;
        }
 
        /*
         * init snd_soc_dai_link
         */
-       cinfo->snd_link.name            = cinfo->name;
-       cinfo->snd_link.stream_name     = cinfo->name;
-       cinfo->snd_link.cpu_dai_name    = cinfo->cpu_dai.name;
-       cinfo->snd_link.platform_name   = cinfo->platform;
-       cinfo->snd_link.codec_name      = cinfo->codec;
-       cinfo->snd_link.codec_dai_name  = cinfo->codec_dai.name;
-       cinfo->snd_link.cpu_of_node     = of_cpu;
-       cinfo->snd_link.codec_of_node   = of_codec;
-       cinfo->snd_link.platform_of_node = of_platform;
-       cinfo->snd_link.init            = asoc_simple_card_dai_init;
-
-       /*
-        * init snd_soc_card
-        */
-       cinfo->snd_card.name            = cinfo->card;
-       cinfo->snd_card.owner           = THIS_MODULE;
-       cinfo->snd_card.dai_link        = &cinfo->snd_link;
-       cinfo->snd_card.num_links       = 1;
+       dai_link->init = asoc_simple_card_dai_init;
 
        snd_soc_card_set_drvdata(&cinfo->snd_card, cinfo);
 
This page took 0.028303 seconds and 5 git commands to generate.