ASoC: rsrc-card: use asoc_simple_card_clean_reference()
[deliverable/linux.git] / sound / soc / sh / rcar / rsrc-card.c
index 1bc7ecfc42a9e18004d7726e2de45ca06f1542ca..16dc13e0bec9e237a5dbaafec26818a4de05ec82 100644 (file)
@@ -20,6 +20,7 @@
 #include <sound/jack.h>
 #include <sound/soc.h>
 #include <sound/soc-dai.h>
+#include <sound/simple_card_utils.h>
 
 struct rsrc_card_of_data {
        const char *prefix;
@@ -46,25 +47,13 @@ static const struct of_device_id rsrc_card_of_match[] = {
 };
 MODULE_DEVICE_TABLE(of, rsrc_card_of_match);
 
-#define DAI_NAME_NUM   32
-struct rsrc_card_dai {
-       unsigned int sysclk;
-       unsigned int tx_slot_mask;
-       unsigned int rx_slot_mask;
-       int slots;
-       int slot_width;
-       struct clk *clk;
-       char dai_name[DAI_NAME_NUM];
-};
-
 #define IDX_CPU                0
 #define IDX_CODEC      1
 struct rsrc_card_priv {
        struct snd_soc_card snd_card;
        struct snd_soc_codec_conf codec_conf;
-       struct rsrc_card_dai *dai_props;
+       struct asoc_simple_dai *dai_props;
        struct snd_soc_dai_link *dai_link;
-       int dai_num;
        u32 convert_rate;
        u32 convert_channels;
 };
@@ -73,11 +62,14 @@ struct rsrc_card_priv {
 #define rsrc_priv_to_link(priv, i) ((priv)->snd_card.dai_link + (i))
 #define rsrc_priv_to_props(priv, i) ((priv)->dai_props + (i))
 
+#define DAI    "sound-dai"
+#define CELL   "#sound-dai-cells"
+
 static int rsrc_card_startup(struct snd_pcm_substream *substream)
 {
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct rsrc_card_priv *priv =   snd_soc_card_get_drvdata(rtd->card);
-       struct rsrc_card_dai *dai_props =
+       struct asoc_simple_dai *dai_props =
                rsrc_priv_to_props(priv, rtd->num);
 
        return clk_prepare_enable(dai_props->clk);
@@ -87,7 +79,7 @@ static void rsrc_card_shutdown(struct snd_pcm_substream *substream)
 {
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct rsrc_card_priv *priv =   snd_soc_card_get_drvdata(rtd->card);
-       struct rsrc_card_dai *dai_props =
+       struct asoc_simple_dai *dai_props =
                rsrc_priv_to_props(priv, rtd->num);
 
        clk_disable_unprepare(dai_props->clk);
@@ -103,9 +95,8 @@ static int rsrc_card_dai_init(struct snd_soc_pcm_runtime *rtd)
        struct rsrc_card_priv *priv = snd_soc_card_get_drvdata(rtd->card);
        struct snd_soc_dai *dai;
        struct snd_soc_dai_link *dai_link;
-       struct rsrc_card_dai *dai_props;
+       struct asoc_simple_dai *dai_props;
        int num = rtd->num;
-       int ret;
 
        dai_link        = rsrc_priv_to_link(priv, num);
        dai_props       = rsrc_priv_to_props(priv, num);
@@ -113,30 +104,7 @@ static int rsrc_card_dai_init(struct snd_soc_pcm_runtime *rtd)
                                rtd->cpu_dai :
                                rtd->codec_dai;
 
-       if (dai_props->sysclk) {
-               ret = snd_soc_dai_set_sysclk(dai, 0, dai_props->sysclk, 0);
-               if (ret && ret != -ENOTSUPP) {
-                       dev_err(dai->dev, "set_sysclk error\n");
-                       goto err;
-               }
-       }
-
-       if (dai_props->slots) {
-               ret = snd_soc_dai_set_tdm_slot(dai,
-                                              dai_props->tx_slot_mask,
-                                              dai_props->rx_slot_mask,
-                                              dai_props->slots,
-                                              dai_props->slot_width);
-               if (ret && ret != -ENOTSUPP) {
-                       dev_err(dai->dev, "set_tdm_slot error\n");
-                       goto err;
-               }
-       }
-
-       ret = 0;
-
-err:
-       return ret;
+       return asoc_simple_card_init_dai(dai, dai_props);
 }
 
 static int rsrc_card_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
@@ -159,56 +127,15 @@ static int rsrc_card_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
        return 0;
 }
 
-static int rsrc_card_parse_daifmt(struct device_node *node,
-                                 struct device_node *codec,
-                                 struct rsrc_card_priv *priv,
-                                 struct snd_soc_dai_link *dai_link,
-                                 unsigned int *retfmt)
-{
-       struct device_node *bitclkmaster = NULL;
-       struct device_node *framemaster = NULL;
-       unsigned int daifmt;
-
-       daifmt = snd_soc_of_parse_daifmt(node, NULL,
-                                        &bitclkmaster, &framemaster);
-       daifmt &= ~SND_SOC_DAIFMT_MASTER_MASK;
-
-       if (!bitclkmaster && !framemaster)
-               return -EINVAL;
-
-       if (codec == bitclkmaster)
-               daifmt |= (codec == framemaster) ?
-                       SND_SOC_DAIFMT_CBM_CFM : SND_SOC_DAIFMT_CBM_CFS;
-       else
-               daifmt |= (codec == framemaster) ?
-                       SND_SOC_DAIFMT_CBS_CFM : SND_SOC_DAIFMT_CBS_CFS;
-
-       of_node_put(bitclkmaster);
-       of_node_put(framemaster);
-
-       *retfmt = daifmt;
-
-       return 0;
-}
-
 static int rsrc_card_parse_links(struct device_node *np,
                                 struct rsrc_card_priv *priv,
                                 int idx, bool is_fe)
 {
+       struct device *dev = rsrc_priv_to_dev(priv);
        struct snd_soc_dai_link *dai_link = rsrc_priv_to_link(priv, idx);
-       struct rsrc_card_dai *dai_props = rsrc_priv_to_props(priv, idx);
-       struct of_phandle_args args;
+       struct asoc_simple_dai *dai_props = rsrc_priv_to_props(priv, idx);
        int ret;
 
-       /*
-        * Get node via "sound-dai = <&phandle port>"
-        * it will be used as xxx_of_node on soc_bind_dai_link()
-        */
-       ret = of_parse_phandle_with_args(np, "sound-dai",
-                                        "#sound-dai-cells", 0, &args);
-       if (ret)
-               return ret;
-
        /* Parse TDM slot */
        ret = snd_soc_of_parse_tdm_slot(np,
                                        &dai_props->tx_slot_mask,
@@ -219,6 +146,8 @@ static int rsrc_card_parse_links(struct device_node *np,
                return ret;
 
        if (is_fe) {
+               int is_single_links = 0;
+
                /* BE is dummy */
                dai_link->codec_of_node         = NULL;
                dai_link->codec_dai_name        = "snd-soc-dummy-dai";
@@ -227,28 +156,24 @@ static int rsrc_card_parse_links(struct device_node *np,
                /* FE settings */
                dai_link->dynamic               = 1;
                dai_link->dpcm_merged_format    = 1;
-               dai_link->cpu_of_node           = args.np;
-               ret = snd_soc_of_get_dai_name(np, &dai_link->cpu_dai_name);
+
+               ret = asoc_simple_card_parse_cpu(np, dai_link, DAI, CELL,
+                                                &is_single_links);
+               if (ret)
+                       return ret;
+
+               ret = asoc_simple_card_parse_clk_cpu(np, dai_link, dai_props);
                if (ret < 0)
                        return ret;
 
-               /* set dai_name */
-               snprintf(dai_props->dai_name, DAI_NAME_NUM, "fe.%s",
-                        dai_link->cpu_dai_name);
-
-               /*
-                * In soc_bind_dai_link() will check cpu name after
-                * of_node matching if dai_link has cpu_dai_name.
-                * but, it will never match if name was created by
-                * fmt_single_name() remove cpu_dai_name if cpu_args
-                * was 0. See:
-                *      fmt_single_name()
-                *      fmt_multiple_name()
-                */
-               if (!args.args_count)
-                       dai_link->cpu_dai_name = NULL;
+               ret = asoc_simple_card_set_dailink_name(dev, dai_link,
+                                                       "fe.%s",
+                                                       dai_link->cpu_dai_name);
+               if (ret < 0)
+                       return ret;
+
+               asoc_simple_card_canonicalize_cpu(dai_link, is_single_links);
        } else {
-               struct device *dev = rsrc_priv_to_dev(priv);
                const struct rsrc_card_of_data *of_data;
 
                of_data = of_device_get_match_data(dev);
@@ -261,8 +186,18 @@ static int rsrc_card_parse_links(struct device_node *np,
                /* BE settings */
                dai_link->no_pcm                = 1;
                dai_link->be_hw_params_fixup    = rsrc_card_be_hw_params_fixup;
-               dai_link->codec_of_node         = args.np;
-               ret = snd_soc_of_get_dai_name(np, &dai_link->codec_dai_name);
+
+               ret = asoc_simple_card_parse_codec(np, dai_link, DAI, CELL);
+               if (ret < 0)
+                       return ret;
+
+               ret = asoc_simple_card_parse_clk_codec(np, dai_link, dai_props);
+               if (ret < 0)
+                       return ret;
+
+               ret = asoc_simple_card_set_dailink_name(dev, dai_link,
+                                                       "be.%s",
+                                                       dai_link->codec_dai_name);
                if (ret < 0)
                        return ret;
 
@@ -276,88 +211,29 @@ static int rsrc_card_parse_links(struct device_node *np,
                                                      dai_link->codec_of_node,
                                                      "audio-prefix");
                }
-
-               /* set dai_name */
-               snprintf(dai_props->dai_name, DAI_NAME_NUM, "be.%s",
-                        dai_link->codec_dai_name);
        }
 
-       /* Simple Card assumes platform == cpu */
-       dai_link->platform_of_node      = dai_link->cpu_of_node;
+       ret = asoc_simple_card_canonicalize_dailink(dai_link);
+       if (ret < 0)
+               return ret;
+
        dai_link->dpcm_playback         = 1;
        dai_link->dpcm_capture          = 1;
-       dai_link->name                  = dai_props->dai_name;
-       dai_link->stream_name           = dai_props->dai_name;
        dai_link->ops                   = &rsrc_card_ops;
        dai_link->init                  = rsrc_card_dai_init;
 
-       return 0;
-}
-
-static int rsrc_card_parse_clk(struct device_node *np,
-                              struct rsrc_card_priv *priv,
-                              int idx, bool is_fe)
-{
-       struct snd_soc_dai_link *dai_link = rsrc_priv_to_link(priv, idx);
-       struct rsrc_card_dai *dai_props = rsrc_priv_to_props(priv, idx);
-       struct clk *clk;
-       struct device_node *of_np = is_fe ?     dai_link->cpu_of_node :
-                                               dai_link->codec_of_node;
-       u32 val;
-
-       /*
-        * Parse dai->sysclk come from "clocks = <&xxx>"
-        * (if system has common clock)
-        *  or "system-clock-frequency = <xxx>"
-        *  or device's module clock.
-        */
-       if (of_property_read_bool(np, "clocks")) {
-               clk = of_clk_get(np, 0);
-               if (IS_ERR(clk))
-                       return PTR_ERR(clk);
-
-               dai_props->sysclk = clk_get_rate(clk);
-               dai_props->clk = clk;
-       } else if (!of_property_read_u32(np, "system-clock-frequency", &val)) {
-               dai_props->sysclk = val;
-       } else {
-               clk = of_clk_get(of_np, 0);
-               if (!IS_ERR(clk))
-                       dai_props->sysclk = clk_get_rate(clk);
-       }
-
-       return 0;
-}
-
-static int rsrc_card_dai_sub_link_of(struct device_node *node,
-                                    struct device_node *np,
-                                    struct rsrc_card_priv *priv,
-                                    int idx, bool is_fe)
-{
-       struct device *dev = rsrc_priv_to_dev(priv);
-       struct snd_soc_dai_link *dai_link = rsrc_priv_to_link(priv, idx);
-       struct rsrc_card_dai *dai_props = rsrc_priv_to_props(priv, idx);
-       int ret;
-
-       ret = rsrc_card_parse_links(np, priv, idx, is_fe);
-       if (ret < 0)
-               return ret;
-
-       ret = rsrc_card_parse_clk(np, priv, idx, is_fe);
-       if (ret < 0)
-               return ret;
-
        dev_dbg(dev, "\t%s / %04x / %d\n",
-               dai_props->dai_name,
+               dai_link->name,
                dai_link->dai_fmt,
                dai_props->sysclk);
 
-       return ret;
+       return 0;
 }
 
 static int rsrc_card_dai_link_of(struct device_node *node,
                                 struct rsrc_card_priv *priv)
 {
+       struct device *dev = rsrc_priv_to_dev(priv);
        struct snd_soc_dai_link *dai_link;
        struct device_node *np;
        unsigned int daifmt = 0;
@@ -370,8 +246,8 @@ static int rsrc_card_dai_link_of(struct device_node *node,
                dai_link = rsrc_priv_to_link(priv, i);
 
                if (strcmp(np->name, "codec") == 0) {
-                       ret = rsrc_card_parse_daifmt(node, np, priv,
-                                                    dai_link, &daifmt);
+                       ret = asoc_simple_card_parse_daifmt(dev, node, np,
+                                                           NULL, &daifmt);
                        if (ret < 0)
                                return ret;
                        break;
@@ -388,7 +264,7 @@ static int rsrc_card_dai_link_of(struct device_node *node,
                if (strcmp(np->name, "cpu") == 0)
                        is_fe = true;
 
-               ret = rsrc_card_dai_sub_link_of(node, np, priv, i, is_fe);
+               ret = rsrc_card_parse_links(np, priv, i, is_fe);
                if (ret < 0)
                        return ret;
                i++;
@@ -402,7 +278,7 @@ static int rsrc_card_parse_of(struct device_node *node,
                              struct device *dev)
 {
        const struct rsrc_card_of_data *of_data = of_device_get_match_data(dev);
-       struct rsrc_card_dai *props;
+       struct asoc_simple_dai *props;
        struct snd_soc_dai_link *links;
        int ret;
        int num;
@@ -418,7 +294,6 @@ static int rsrc_card_parse_of(struct device_node *node,
 
        priv->dai_props = props;
        priv->dai_link  = links;
-       priv->dai_num   = num;
 
        /* Init snd_soc_card */
        priv->snd_card.owner                    = THIS_MODULE;
@@ -436,9 +311,6 @@ static int rsrc_card_parse_of(struct device_node *node,
                                               "audio-routing");
        }
 
-       /* Parse the card name from DT */
-       snd_soc_of_parse_card_name(&priv->snd_card, "card-name");
-
        /* sampling rate convert */
        of_property_read_u32(node, "convert-rate", &priv->convert_rate);
 
@@ -454,24 +326,10 @@ static int rsrc_card_parse_of(struct device_node *node,
        if (ret < 0)
                return ret;
 
-       if (!priv->snd_card.name)
-               priv->snd_card.name = priv->snd_card.dai_link->name;
-
-       return 0;
-}
-
-/* Decrease the reference count of the device nodes */
-static int rsrc_card_unref(struct snd_soc_card *card)
-{
-       struct snd_soc_dai_link *dai_link;
-       int num_links;
+       ret = asoc_simple_card_parse_card_name(&priv->snd_card, "card-");
+       if (ret < 0)
+               return ret;
 
-       for (num_links = 0, dai_link = card->dai_link;
-            num_links < card->num_links;
-            num_links++, dai_link++) {
-               of_node_put(dai_link->cpu_of_node);
-               of_node_put(dai_link->codec_of_node);
-       }
        return 0;
 }
 
@@ -500,7 +358,7 @@ static int rsrc_card_probe(struct platform_device *pdev)
        if (ret >= 0)
                return ret;
 err:
-       rsrc_card_unref(&priv->snd_card);
+       asoc_simple_card_clean_reference(&priv->snd_card);
 
        return ret;
 }
@@ -509,7 +367,7 @@ static int rsrc_card_remove(struct platform_device *pdev)
 {
        struct snd_soc_card *card = platform_get_drvdata(pdev);
 
-       return rsrc_card_unref(card);
+       return asoc_simple_card_clean_reference(card);
 }
 
 static struct platform_driver rsrc_card = {
This page took 0.035939 seconds and 5 git commands to generate.