X-Git-Url: http://drtracing.org/?a=blobdiff_plain;ds=sidebyside;f=gdb%2Fcorelow.c;h=bfa2893e5ad07b102a5bb47b0ac543ff793ecf39;hb=3e43a32aaa2d78fca10dea6746b820176f39bcc8;hp=d8148318979cad1624ce703f331f7dddd9743f18;hpb=0fb0cc7590113e9b459dfcc48dc71c9d419d9580;p=deliverable%2Fbinutils-gdb.git diff --git a/gdb/corelow.c b/gdb/corelow.c index d814831897..bfa2893e5a 100644 --- a/gdb/corelow.c +++ b/gdb/corelow.c @@ -1,8 +1,8 @@ /* Core dump and executable file functions below target vector, for GDB. Copyright (C) 1986, 1987, 1989, 1991, 1992, 1993, 1994, 1995, 1996, 1997, - 1998, 1999, 2000, 2001, 2003, 2004, 2005, 2006, 2007, 2008, 2009 - Free Software Foundation, Inc. + 1998, 1999, 2000, 2001, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, + 2011 Free Software Foundation, Inc. This file is part of GDB. @@ -45,6 +45,8 @@ #include "exceptions.h" #include "solib.h" #include "filenames.h" +#include "progspace.h" +#include "objfiles.h" #ifndef O_LARGEFILE @@ -57,8 +59,8 @@ static struct core_fns *core_file_fns = NULL; -/* The core_fns for a core file handler that is prepared to read the core - file currently open on core_bfd. */ +/* The core_fns for a core file handler that is prepared to read the + core file currently open on core_bfd. */ static struct core_fns *core_vec = NULL; @@ -67,6 +69,17 @@ static struct core_fns *core_vec = NULL; struct gdbarch *core_gdbarch = NULL; +/* Per-core data. Currently, only the section table. Note that these + target sections are *not* mapped in the current address spaces' set + of target sections --- those should come only from pure executable + or shared library bfds. The core bfd sections are an + implementation detail of the core target, just like ptrace is for + unix child targets. */ +static struct target_section_table *core_data; + +/* True if we needed to fake the pid of the loaded core inferior. */ +static int core_has_fake_pid = 0; + static void core_files_info (struct target_ops *); static struct core_fns *sniff_core_bfd (bfd *); @@ -81,25 +94,21 @@ static void core_close (int); static void core_close_cleanup (void *ignore); -static void get_core_registers (struct regcache *, int); - static void add_to_thread_list (bfd *, asection *, void *); -static int core_file_thread_alive (ptid_t tid); - static void init_core_ops (void); void _initialize_corelow (void); -struct target_ops core_ops; +static struct target_ops core_ops; /* An arbitrary identifier for the core inferior. */ #define CORELOW_PID 1 -/* Link a new core_fns into the global core_file_fns list. Called on gdb - startup by the _initialize routine in each core file register reader, to - register information about each format the the reader is prepared to - handle. */ +/* Link a new core_fns into the global core_file_fns list. Called on + gdb startup by the _initialize routine in each core file register + reader, to register information about each format the the reader is + prepared to handle. */ void deprecated_add_core_fns (struct core_fns *cf) @@ -110,7 +119,7 @@ deprecated_add_core_fns (struct core_fns *cf) /* The default function that core file handlers can use to examine a core file BFD and decide whether or not to accept the job of - reading the core file. */ + reading the core file. */ int default_core_sniffer (struct core_fns *our_fns, bfd *abfd) @@ -124,7 +133,7 @@ default_core_sniffer (struct core_fns *our_fns, bfd *abfd) /* Walk through the list of core functions to find a set that can handle the core file open on ABFD. Default to the first one in the list if nothing matches. Returns pointer to set that is - selected. */ + selected. */ static struct core_fns * sniff_core_bfd (bfd *abfd) @@ -133,7 +142,8 @@ sniff_core_bfd (bfd *abfd) struct core_fns *yummy = NULL; int matches = 0;; - /* Don't sniff if we have support for register sets in CORE_GDBARCH. */ + /* Don't sniff if we have support for register sets in + CORE_GDBARCH. */ if (core_gdbarch && gdbarch_regset_from_core_section_p (core_gdbarch)) return NULL; @@ -152,7 +162,8 @@ sniff_core_bfd (bfd *abfd) } else if (matches == 0) { - warning (_("\"%s\": no core file handler recognizes format, using default"), + warning (_("\"%s\": no core file handler " + "recognizes format, using default"), bfd_get_filename (abfd)); } if (yummy == NULL) @@ -164,7 +175,7 @@ sniff_core_bfd (bfd *abfd) /* The default is to reject every core file format we see. Either BFD has to recognize it, or we have to provide a function in the - core file handler that recognizes it. */ + core file handler that recognizes it. */ int default_check_format (bfd *abfd) @@ -172,7 +183,7 @@ default_check_format (bfd *abfd) return (0); } -/* Attempt to recognize core file formats that BFD rejects. */ +/* Attempt to recognize core file formats that BFD rejects. */ static int gdb_check_format (bfd *abfd) @@ -189,8 +200,8 @@ gdb_check_format (bfd *abfd) return (0); } -/* Discard all vestiges of any previous core file and mark data and stack - spaces as empty. */ +/* Discard all vestiges of any previous core file and mark data and + stack spaces as empty. */ static void core_close (int quitting) @@ -199,25 +210,24 @@ core_close (int quitting) if (core_bfd) { - inferior_ptid = null_ptid; /* Avoid confusion from thread stuff */ - delete_inferior_silent (CORELOW_PID); + int pid = ptid_get_pid (inferior_ptid); + inferior_ptid = null_ptid; /* Avoid confusion from thread + stuff. */ + exit_inferior_silent (pid); - /* Clear out solib state while the bfd is still open. See - comments in clear_solib in solib.c. */ + /* Clear out solib state while the bfd is still open. See + comments in clear_solib in solib.c. */ clear_solib (); + xfree (core_data->sections); + xfree (core_data); + core_data = NULL; + core_has_fake_pid = 0; + name = bfd_get_filename (core_bfd); - if (!bfd_close (core_bfd)) - warning (_("cannot close \"%s\": %s"), - name, bfd_errmsg (bfd_get_error ())); + gdb_bfd_close_or_warn (core_bfd); xfree (name); core_bfd = NULL; - if (core_ops.to_sections) - { - xfree (core_ops.to_sections); - core_ops.to_sections = NULL; - core_ops.to_sections_end = NULL; - } } core_vec = NULL; core_gdbarch = NULL; @@ -229,37 +239,43 @@ core_close_cleanup (void *ignore) core_close (0/*ignored*/); } -/* Look for sections whose names start with `.reg/' so that we can extract the - list of threads in a core file. */ +/* Look for sections whose names start with `.reg/' so that we can + extract the list of threads in a core file. */ static void add_to_thread_list (bfd *abfd, asection *asect, void *reg_sect_arg) { ptid_t ptid; - int thread_id; + int core_tid; + int pid, lwpid; asection *reg_sect = (asection *) reg_sect_arg; if (strncmp (bfd_section_name (abfd, asect), ".reg/", 5) != 0) return; - thread_id = atoi (bfd_section_name (abfd, asect) + 5); + core_tid = atoi (bfd_section_name (abfd, asect) + 5); - ptid = ptid_build (ptid_get_pid (inferior_ptid), thread_id, 0); + pid = bfd_core_file_pid (core_bfd); + if (pid == 0) + { + core_has_fake_pid = 1; + pid = CORELOW_PID; + } - if (ptid_get_lwp (inferior_ptid) == 0) - /* The main thread has already been added before getting here, and - this is the first time we hear about a thread id. Assume this - is the main thread. */ - thread_change_ptid (inferior_ptid, ptid); - else - /* Nope, really a new thread. */ - add_thread (ptid); + lwpid = core_tid; + + if (current_inferior ()->pid == 0) + inferior_appeared (current_inferior (), pid); + + ptid = ptid_build (pid, lwpid, 0); + + add_thread (ptid); /* Warning, Will Robinson, looking at BFD private data! */ if (reg_sect != NULL - && asect->filepos == reg_sect->filepos) /* Did we find .reg? */ - inferior_ptid = ptid; /* Yes, make it current */ + && asect->filepos == reg_sect->filepos) /* Did we find .reg? */ + inferior_ptid = ptid; /* Yes, make it current. */ } /* This routine opens and sets up the core file bfd. */ @@ -274,21 +290,22 @@ core_open (char *filename, int from_tty) bfd *temp_bfd; int scratch_chan; int flags; - int corelow_pid = CORELOW_PID; target_preopen (from_tty); if (!filename) { if (core_bfd) - error (_("No core file specified. (Use `detach' to stop debugging a core file.)")); + error (_("No core file specified. (Use `detach' " + "to stop debugging a core file.)")); else error (_("No core file specified.")); } filename = tilde_expand (filename); - if (!IS_ABSOLUTE_PATH(filename)) + if (!IS_ABSOLUTE_PATH (filename)) { - temp = concat (current_directory, "/", filename, (char *)NULL); + temp = concat (current_directory, "/", + filename, (char *) NULL); xfree (filename); filename = temp; } @@ -310,19 +327,20 @@ core_open (char *filename, int from_tty) if (temp_bfd == NULL) perror_with_name (filename); - if (!bfd_check_format (temp_bfd, bfd_core) && - !gdb_check_format (temp_bfd)) + if (!bfd_check_format (temp_bfd, bfd_core) + && !gdb_check_format (temp_bfd)) { /* Do it after the err msg */ - /* FIXME: should be checking for errors from bfd_close (for one thing, - on error it does not free all the storage associated with the - bfd). */ + /* FIXME: should be checking for errors from bfd_close (for one + thing, on error it does not free all the storage associated + with the bfd). */ make_cleanup_bfd_close (temp_bfd); error (_("\"%s\" is not a core dump: %s"), filename, bfd_errmsg (bfd_get_error ())); } - /* Looks semi-reasonable. Toss the old core file and work on the new. */ + /* Looks semi-reasonable. Toss the old core file and work on the + new. */ discard_cleanups (old_chain); /* Don't free filename any more */ unpush_target (&core_ops); @@ -342,9 +360,12 @@ core_open (char *filename, int from_tty) validate_files (); + core_data = XZALLOC (struct target_section_table); + /* Find the data section */ - if (build_section_table (core_bfd, &core_ops.to_sections, - &core_ops.to_sections_end)) + if (build_section_table (core_bfd, + &core_data->sections, + &core_data->sections_end)) error (_("\"%s\": Can't find sections: %s"), bfd_get_filename (core_bfd), bfd_errmsg (bfd_get_error ())); @@ -358,32 +379,51 @@ core_open (char *filename, int from_tty) push_target (&core_ops); discard_cleanups (old_chain); - add_inferior_silent (corelow_pid); - /* Do this before acknowledging the inferior, so if post_create_inferior throws (can happen easilly if you're loading a core file with the wrong exec), we aren't left with threads from the previous inferior. */ init_thread_list (); - /* Set INFERIOR_PTID early, so an upper layer can rely on it being - set while in the target_find_new_threads call below. */ - inferior_ptid = pid_to_ptid (corelow_pid); - - /* Assume ST --- Add a main task. We'll later detect when we go - from ST to MT. */ - add_thread_silent (inferior_ptid); + inferior_ptid = null_ptid; + core_has_fake_pid = 0; - /* This is done first, before anything has a chance to query the - inferior for information such as symbols. */ - post_create_inferior (&core_ops, from_tty); + /* Need to flush the register cache (and the frame cache) from a + previous debug session. If inferior_ptid ends up the same as the + last debug session --- e.g., b foo; run; gcore core1; step; gcore + core2; core core1; core core2 --- then there's potential for + get_current_regcache to return the cached regcache of the + previous session, and the frame cache being stale. */ + registers_changed (); /* Build up thread list from BFD sections, and possibly set the current thread to the .reg/NN section matching the .reg - section. */ + section. */ bfd_map_over_sections (core_bfd, add_to_thread_list, bfd_get_section_by_name (core_bfd, ".reg")); + if (ptid_equal (inferior_ptid, null_ptid)) + { + /* Either we found no .reg/NN section, and hence we have a + non-threaded core (single-threaded, from gdb's perspective), + or for some reason add_to_thread_list couldn't determine + which was the "main" thread. The latter case shouldn't + usually happen, but we're dealing with input here, which can + always be broken in different ways. */ + struct thread_info *thread = first_thread_of_process (-1); + + if (thread == NULL) + { + inferior_appeared (current_inferior (), CORELOW_PID); + inferior_ptid = pid_to_ptid (CORELOW_PID); + add_thread_silent (inferior_ptid); + } + else + switch_to_thread (thread->ptid); + } + + post_create_inferior (&core_ops, from_tty); + /* Now go through the target stack looking for threads since there may be a thread_stratum target loaded on top of target core by now. The layer above should claim threads found in the BFD @@ -396,13 +436,19 @@ core_open (char *filename, int from_tty) siggy = bfd_core_file_failing_signal (core_bfd); if (siggy > 0) - /* NOTE: target_signal_from_host() converts a target signal value - into gdb's internal signal value. Unfortunately gdb's internal - value is called ``target_signal'' and this function got the - name ..._from_host(). */ - printf_filtered (_("Program terminated with signal %d, %s.\n"), siggy, - target_signal_to_string ( - gdbarch_target_signal_from_host (core_gdbarch, siggy))); + { + /* NOTE: target_signal_from_host() converts a target signal + value into gdb's internal signal value. Unfortunately gdb's + internal value is called ``target_signal'' and this function + got the name ..._from_host(). */ + enum target_signal sig = (core_gdbarch != NULL + ? gdbarch_target_signal_from_host (core_gdbarch, + siggy) + : target_signal_from_host (siggy)); + + printf_filtered (_("Program terminated with signal %d, %s.\n"), + siggy, target_signal_to_string (sig)); + } /* Fetch all registers from core file. */ target_fetch_registers (get_current_regcache (), -1); @@ -423,6 +469,23 @@ core_detach (struct target_ops *ops, char *args, int from_tty) printf_filtered (_("No core file now.\n")); } +#ifdef DEPRECATED_IBM6000_TARGET + +/* Resize the core memory's section table, by NUM_ADDED. Returns a + pointer into the first new slot. This will not be necessary when + the rs6000 target is converted to use the standard solib + framework. */ + +struct target_section * +deprecated_core_resize_section_table (int num_added) +{ + int old_count; + + old_count = resize_section_table (core_data, num_added); + return core_data->sections + old_count; +} + +#endif /* Try to retrieve registers from a section in core_bfd, and supply them to core_vec->core_read_registers, as the register set numbered @@ -438,13 +501,14 @@ core_detach (struct target_ops *ops, char *args, int from_tty) NAME section contains, for use in error messages. If REQUIRED is non-zero, print an error if the core file doesn't - have a section by the appropriate name. Otherwise, just do nothing. */ + have a section by the appropriate name. Otherwise, just do + nothing. */ static void get_core_register_section (struct regcache *regcache, - char *name, + const char *name, int which, - char *human_name, + const char *human_name, int required) { static char *section_name = NULL; @@ -453,8 +517,10 @@ get_core_register_section (struct regcache *regcache, char *contents; xfree (section_name); + if (ptid_get_lwp (inferior_ptid)) - section_name = xstrprintf ("%s/%ld", name, ptid_get_lwp (inferior_ptid)); + section_name = xstrprintf ("%s/%ld", name, + ptid_get_lwp (inferior_ptid)); else section_name = xstrdup (name); @@ -462,7 +528,8 @@ get_core_register_section (struct regcache *regcache, if (! section) { if (required) - warning (_("Couldn't find %s registers in core file."), human_name); + warning (_("Couldn't find %s registers in core file."), + human_name); return; } @@ -480,7 +547,8 @@ get_core_register_section (struct regcache *regcache, { const struct regset *regset; - regset = gdbarch_regset_from_core_section (core_gdbarch, name, size); + regset = gdbarch_regset_from_core_section (core_gdbarch, + name, size); if (regset == NULL) { if (required) @@ -502,13 +570,16 @@ get_core_register_section (struct regcache *regcache, /* Get the registers out of a core file. This is the machine- independent part. Fetch_core_registers is the machine-dependent - part, typically implemented in the xm-file for each architecture. */ + part, typically implemented in the xm-file for each + architecture. */ /* We just get all the registers, so we don't use regno. */ static void -get_core_registers (struct regcache *regcache, int regno) +get_core_registers (struct target_ops *ops, + struct regcache *regcache, int regno) { + struct core_regset_section *sect_list; int i; if (!(core_gdbarch && gdbarch_regset_from_core_section_p (core_gdbarch)) @@ -519,16 +590,30 @@ get_core_registers (struct regcache *regcache, int regno) return; } - get_core_register_section (regcache, - ".reg", 0, "general-purpose", 1); - get_core_register_section (regcache, - ".reg2", 2, "floating-point", 0); - get_core_register_section (regcache, - ".reg-xfp", 3, "extended floating-point", 0); - get_core_register_section (regcache, - ".reg-ppc-vmx", 3, "ppc Altivec", 0); - get_core_register_section (regcache, - ".reg-ppc-vsx", 4, "POWER7 VSX", 0); + sect_list = gdbarch_core_regset_sections (get_regcache_arch (regcache)); + if (sect_list) + while (sect_list->sect_name != NULL) + { + if (strcmp (sect_list->sect_name, ".reg") == 0) + get_core_register_section (regcache, sect_list->sect_name, + 0, sect_list->human_name, 1); + else if (strcmp (sect_list->sect_name, ".reg2") == 0) + get_core_register_section (regcache, sect_list->sect_name, + 2, sect_list->human_name, 0); + else + get_core_register_section (regcache, sect_list->sect_name, + 3, sect_list->human_name, 0); + + sect_list++; + } + + else + { + get_core_register_section (regcache, + ".reg", 0, "general-purpose", 1); + get_core_register_section (regcache, + ".reg2", 2, "floating-point", 0); + } /* Supply dummy value for all registers not found in the core. */ for (i = 0; i < gdbarch_num_regs (get_regcache_arch (regcache)); i++) @@ -539,24 +624,53 @@ get_core_registers (struct regcache *regcache, int regno) static void core_files_info (struct target_ops *t) { - print_section_info (t, core_bfd); + print_section_info (core_data, core_bfd); } +struct spuid_list +{ + gdb_byte *buf; + ULONGEST offset; + LONGEST len; + ULONGEST pos; + ULONGEST written; +}; + +static void +add_to_spuid_list (bfd *abfd, asection *asect, void *list_p) +{ + struct spuid_list *list = list_p; + enum bfd_endian byte_order + = bfd_big_endian (abfd) ? BFD_ENDIAN_BIG : BFD_ENDIAN_LITTLE; + int fd, pos = 0; + + sscanf (bfd_section_name (abfd, asect), "SPU/%d/regs%n", &fd, &pos); + if (pos == 0) + return; + + if (list->pos >= list->offset && list->pos + 4 <= list->offset + list->len) + { + store_unsigned_integer (list->buf + list->pos - list->offset, + 4, byte_order, fd); + list->written += 4; + } + list->pos += 4; +} + static LONGEST core_xfer_partial (struct target_ops *ops, enum target_object object, const char *annex, gdb_byte *readbuf, - const gdb_byte *writebuf, ULONGEST offset, LONGEST len) + const gdb_byte *writebuf, ULONGEST offset, + LONGEST len) { switch (object) { case TARGET_OBJECT_MEMORY: - if (readbuf) - return (*ops->deprecated_xfer_memory) (offset, readbuf, - len, 0/*read*/, NULL, ops); - if (writebuf) - return (*ops->deprecated_xfer_memory) (offset, (gdb_byte *) writebuf, - len, 1/*write*/, NULL, ops); - return -1; + return section_table_xfer_memory_partial (readbuf, writebuf, + offset, len, + core_data->sections, + core_data->sections_end, + NULL); case TARGET_OBJECT_AUXV: if (readbuf) @@ -566,7 +680,6 @@ core_xfer_partial (struct target_ops *ops, enum target_object object, struct bfd_section *section; bfd_size_type size; - char *contents; section = bfd_get_section_by_name (core_bfd, ".auxv"); if (section == NULL) @@ -594,11 +707,11 @@ core_xfer_partial (struct target_ops *ops, enum target_object object, if (readbuf) { /* When the StackGhost cookie is stored in core file, BFD - represents this with a fake section called ".wcookie". */ + represents this with a fake section called + ".wcookie". */ struct bfd_section *section; bfd_size_type size; - char *contents; section = bfd_get_section_by_name (core_bfd, ".wcookie"); if (section == NULL) @@ -634,20 +747,70 @@ core_xfer_partial (struct target_ops *ops, enum target_object object, } /* FALL THROUGH */ + case TARGET_OBJECT_SPU: + if (readbuf && annex) + { + /* When the SPU contexts are stored in a core file, BFD + represents this with a fake section called + "SPU/". */ + + struct bfd_section *section; + bfd_size_type size; + char sectionstr[100]; + + xsnprintf (sectionstr, sizeof sectionstr, "SPU/%s", annex); + + section = bfd_get_section_by_name (core_bfd, sectionstr); + if (section == NULL) + return -1; + + size = bfd_section_size (core_bfd, section); + if (offset >= size) + return 0; + size -= offset; + if (size > len) + size = len; + if (size > 0 + && !bfd_get_section_contents (core_bfd, section, readbuf, + (file_ptr) offset, size)) + { + warning (_("Couldn't read SPU section in core file.")); + return -1; + } + + return size; + } + else if (readbuf) + { + /* NULL annex requests list of all present spuids. */ + struct spuid_list list; + + list.buf = readbuf; + list.offset = offset; + list.len = len; + list.pos = 0; + list.written = 0; + bfd_map_over_sections (core_bfd, add_to_spuid_list, &list); + return list.written; + } + return -1; + default: if (ops->beneath != NULL) - return ops->beneath->to_xfer_partial (ops->beneath, object, annex, - readbuf, writebuf, offset, len); + return ops->beneath->to_xfer_partial (ops->beneath, object, + annex, readbuf, + writebuf, offset, len); return -1; } } /* If mourn is being called in all the right places, this could be say - `gdb internal error' (since generic_mourn calls breakpoint_init_inferior). */ + `gdb internal error' (since generic_mourn calls + breakpoint_init_inferior). */ static int -ignore (struct bp_target_info *bp_tgt) +ignore (struct gdbarch *gdbarch, struct bp_target_info *bp_tgt) { return 0; } @@ -660,7 +823,7 @@ ignore (struct bp_target_info *bp_tgt) behaviour. */ static int -core_file_thread_alive (ptid_t tid) +core_thread_alive (struct target_ops *ops, ptid_t ptid) { return 1; } @@ -673,25 +836,61 @@ core_file_thread_alive (ptid_t tid) static const struct target_desc * core_read_description (struct target_ops *target) { - if (gdbarch_core_read_description_p (current_gdbarch)) - return gdbarch_core_read_description (current_gdbarch, target, core_bfd); + if (core_gdbarch && gdbarch_core_read_description_p (core_gdbarch)) + return gdbarch_core_read_description (core_gdbarch, + target, core_bfd); return NULL; } static char * -core_pid_to_str (ptid_t ptid) +core_pid_to_str (struct target_ops *ops, ptid_t ptid) { static char buf[64]; + int pid; - if (ptid_get_lwp (ptid) == 0) - xsnprintf (buf, sizeof buf, "
"); - else - xsnprintf (buf, sizeof buf, "Thread %ld", ptid_get_lwp (ptid)); + /* The preferred way is to have a gdbarch/OS specific + implementation. */ + if (core_gdbarch + && gdbarch_core_pid_to_str_p (core_gdbarch)) + return gdbarch_core_pid_to_str (core_gdbarch, ptid); + + /* Otherwise, if we don't have one, we'll just fallback to + "process", with normal_pid_to_str. */ + + /* Try the LWPID field first. */ + pid = ptid_get_lwp (ptid); + if (pid != 0) + return normal_pid_to_str (pid_to_ptid (pid)); + /* Otherwise, this isn't a "threaded" core -- use the PID field, but + only if it isn't a fake PID. */ + if (!core_has_fake_pid) + return normal_pid_to_str (ptid); + + /* No luck. We simply don't have a valid PID to print. */ + xsnprintf (buf, sizeof buf, "
"); return buf; } +static int +core_has_memory (struct target_ops *ops) +{ + return (core_bfd != NULL); +} + +static int +core_has_stack (struct target_ops *ops) +{ + return (core_bfd != NULL); +} + +static int +core_has_registers (struct target_ops *ops) +{ + return (core_bfd != NULL); +} + /* Fill in core_ops with its defined operations and properties. */ static void @@ -707,34 +906,30 @@ init_core_ops (void) core_ops.to_detach = core_detach; core_ops.to_fetch_registers = get_core_registers; core_ops.to_xfer_partial = core_xfer_partial; - core_ops.deprecated_xfer_memory = xfer_memory; core_ops.to_files_info = core_files_info; core_ops.to_insert_breakpoint = ignore; core_ops.to_remove_breakpoint = ignore; core_ops.to_create_inferior = find_default_create_inferior; - core_ops.to_thread_alive = core_file_thread_alive; + core_ops.to_thread_alive = core_thread_alive; core_ops.to_read_description = core_read_description; core_ops.to_pid_to_str = core_pid_to_str; - core_ops.to_stratum = core_stratum; - core_ops.to_has_memory = 1; - core_ops.to_has_stack = 1; - core_ops.to_has_registers = 1; + core_ops.to_stratum = process_stratum; + core_ops.to_has_memory = core_has_memory; + core_ops.to_has_stack = core_has_stack; + core_ops.to_has_registers = core_has_registers; core_ops.to_magic = OPS_MAGIC; -} -/* non-zero if we should not do the add_target call in - _initialize_corelow; not initialized (i.e., bss) so that - the target can initialize it (i.e., data) if appropriate. - This needs to be set at compile time because we don't know - for sure whether the target's initialize routine is called - before us or after us. */ -int coreops_suppress_target; + if (core_target) + internal_error (__FILE__, __LINE__, + _("init_core_ops: core target already exists (\"%s\")."), + core_target->to_longname); + core_target = &core_ops; +} void _initialize_corelow (void) { init_core_ops (); - if (!coreops_suppress_target) - add_target (&core_ops); + add_target (&core_ops); }