X-Git-Url: http://drtracing.org/?a=blobdiff_plain;f=binutils%2Freadelf.c;h=d3e94579ce719edab17a7ab416c944adf2008931;hb=8d5ff12c8e030489bd57eb02922abbee0300ef1e;hp=3fb94e86b456534d8e159a672ca637a495d7b006;hpb=e54b12b7797ece3410070f0d634b8ba9117dc1e1;p=deliverable%2Fbinutils-gdb.git diff --git a/binutils/readelf.c b/binutils/readelf.c index 3fb94e86b4..d3e94579ce 100644 --- a/binutils/readelf.c +++ b/binutils/readelf.c @@ -19,8 +19,8 @@ You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software - Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA - 02111-1307, USA. */ + Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA + 02110-1301, USA. */ /* The difference between readelf and objdump: @@ -86,6 +86,7 @@ #include "elf/i960.h" #include "elf/ia64.h" #include "elf/ip2k.h" +#include "elf/m32c.h" #include "elf/m32r.h" #include "elf/m68k.h" #include "elf/m68hc11.h" @@ -94,6 +95,7 @@ #include "elf/mmix.h" #include "elf/mn10200.h" #include "elf/mn10300.h" +#include "elf/ms1.h" #include "elf/msp430.h" #include "elf/or32.h" #include "elf/pj.h" @@ -117,60 +119,61 @@ #include "libiberty.h" char *program_name = "readelf"; -long archive_file_offset; -unsigned long archive_file_size; -unsigned long dynamic_addr; -bfd_size_type dynamic_size; -unsigned int dynamic_nent; -char *dynamic_strings; -unsigned long dynamic_strings_length; -char *string_table; -unsigned long string_table_length; -unsigned long num_dynamic_syms; -Elf_Internal_Sym *dynamic_symbols; -Elf_Internal_Syminfo *dynamic_syminfo; -unsigned long dynamic_syminfo_offset; -unsigned int dynamic_syminfo_nent; -char program_interpreter[64]; -bfd_vma dynamic_info[DT_JMPREL + 1]; -bfd_vma version_info[16]; -Elf_Internal_Ehdr elf_header; -Elf_Internal_Shdr *section_headers; -Elf_Internal_Phdr *program_headers; -Elf_Internal_Dyn *dynamic_section; -Elf_Internal_Shdr *symtab_shndx_hdr; -int show_name; -int do_dynamic; -int do_syms; -int do_reloc; -int do_sections; -int do_section_groups; -int do_segments; -int do_unwind; -int do_using_dynamic; -int do_header; -int do_dump; -int do_version; -int do_wide; -int do_histogram; -int do_debugging; -int do_debug_info; -int do_debug_abbrevs; -int do_debug_lines; -int do_debug_pubnames; -int do_debug_aranges; -int do_debug_ranges; -int do_debug_frames; -int do_debug_frames_interp; -int do_debug_macinfo; -int do_debug_str; -int do_debug_loc; -int do_arch; -int do_notes; -int is_32bit_elf; -int have_frame_base; -int need_base_address; -unsigned long saved_base_address; +static long archive_file_offset; +static unsigned long archive_file_size; +static unsigned long dynamic_addr; +static bfd_size_type dynamic_size; +static unsigned int dynamic_nent; +static char *dynamic_strings; +static unsigned long dynamic_strings_length; +static char *string_table; +static unsigned long string_table_length; +static unsigned long num_dynamic_syms; +static Elf_Internal_Sym *dynamic_symbols; +static Elf_Internal_Syminfo *dynamic_syminfo; +static unsigned long dynamic_syminfo_offset; +static unsigned int dynamic_syminfo_nent; +static char program_interpreter[64]; +static bfd_vma dynamic_info[DT_JMPREL + 1]; +static bfd_vma version_info[16]; +static Elf_Internal_Ehdr elf_header; +static Elf_Internal_Shdr *section_headers; +static Elf_Internal_Phdr *program_headers; +static Elf_Internal_Dyn *dynamic_section; +static Elf_Internal_Shdr *symtab_shndx_hdr; +static int show_name; +static int do_dynamic; +static int do_syms; +static int do_reloc; +static int do_sections; +static int do_section_groups; +static int do_section_details; +static int do_segments; +static int do_unwind; +static int do_using_dynamic; +static int do_header; +static int do_dump; +static int do_version; +static int do_wide; +static int do_histogram; +static int do_debugging; +static int do_debug_info; +static int do_debug_abbrevs; +static int do_debug_lines; +static int do_debug_pubnames; +static int do_debug_aranges; +static int do_debug_ranges; +static int do_debug_frames; +static int do_debug_frames_interp; +static int do_debug_macinfo; +static int do_debug_str; +static int do_debug_loc; +static int do_arch; +static int do_notes; +static int is_32bit_elf; +static int have_frame_base; +static int need_base_address; +static bfd_vma eh_addr_size; struct group_list { @@ -184,10 +187,9 @@ struct group unsigned int group_index; }; -struct group *section_groups; -size_t group_count = 0; - -struct group **section_headers_groups; +static size_t group_count; +static struct group *section_groups; +static struct group **section_headers_groups; /* A dynamic array of flags indicating for which sections a hex dump has been requested (via the -x switch) and/or a disassembly dump @@ -206,7 +208,7 @@ unsigned int num_dump_sects = 0; #define DISASS_DUMP (1 << 1) #define DEBUG_DUMP (1 << 2) -/* How to rpint a vma value. */ +/* How to print a vma value. */ typedef enum print_mode { HEX, @@ -248,20 +250,6 @@ static void (*byte_put) (unsigned char *, bfd_vma, int); #define BYTE_GET(field) byte_get (field, sizeof (field)) -/* If we can support a 64 bit data type then BFD64 should be defined - and sizeof (bfd_vma) == 8. In this case when translating from an - external 8 byte field to an internal field, we can assume that the - internal field is also 8 bytes wide and so we can extract all the data. - If, however, BFD64 is not defined, then we must assume that the - internal data structure only has 4 byte wide fields that are the - equivalent of the 8 byte wide external counterparts, and so we must - truncate the data. */ -#ifdef BFD64 -#define BYTE_GET8(field) byte_get (field, -8) -#else -#define BYTE_GET8(field) byte_get (field, 8) -#endif - #define NUM_ELEM(array) (sizeof (array) / sizeof ((array)[0])) #define GET_ELF_SYMBOLS(file, section) \ @@ -277,7 +265,7 @@ static void (*byte_put) (unsigned char *, bfd_vma, int); #define streq(a,b) (strcmp ((a), (b)) == 0) #define strneq(a,b,n) (strncmp ((a), (b), (n)) == 0) -static void +static void ATTRIBUTE_PRINTF_1 error (const char *message, ...) { va_list args; @@ -288,7 +276,7 @@ error (const char *message, ...) va_end (args); } -static void +static void ATTRIBUTE_PRINTF_1 warn (const char *message, ...) { va_list args; @@ -300,16 +288,47 @@ warn (const char *message, ...) } static void * -get_data (void *var, FILE *file, long offset, size_t size, const char *reason) +cmalloc (size_t nmemb, size_t size) +{ + /* Check for overflow. */ + if (nmemb >= ~(size_t) 0 / size) + return NULL; + else + return malloc (nmemb * size); +} + +static void * +xcmalloc (size_t nmemb, size_t size) +{ + /* Check for overflow. */ + if (nmemb >= ~(size_t) 0 / size) + return NULL; + else + return xmalloc (nmemb * size); +} + +static void * +xcrealloc (void *ptr, size_t nmemb, size_t size) +{ + /* Check for overflow. */ + if (nmemb >= ~(size_t) 0 / size) + return NULL; + else + return xrealloc (ptr, nmemb * size); +} + +static void * +get_data (void *var, FILE *file, long offset, size_t size, size_t nmemb, + const char *reason) { void *mvar; - if (size == 0) + if (size == 0 || nmemb == 0) return NULL; if (fseek (file, archive_file_offset + offset, SEEK_SET)) { - error (_("Unable to seek to 0x%x for %s\n"), + error (_("Unable to seek to 0x%lx for %s\n"), archive_file_offset + offset, reason); return NULL; } @@ -317,19 +336,25 @@ get_data (void *var, FILE *file, long offset, size_t size, const char *reason) mvar = var; if (mvar == NULL) { - mvar = malloc (size); + /* Check for overflow. */ + if (nmemb < (~(size_t) 0 - 1) / size) + /* + 1 so that we can '\0' terminate invalid string table sections. */ + mvar = malloc (size * nmemb + 1); if (mvar == NULL) { - error (_("Out of memory allocating 0x%x bytes for %s\n"), - size, reason); + error (_("Out of memory allocating 0x%lx bytes for %s\n"), + (unsigned long)(size * nmemb), reason); return NULL; } + + ((char *) mvar)[size * nmemb] = '\0'; } - if (fread (mvar, size, 1, file) != 1) + if (fread (mvar, size, nmemb, file) != nmemb) { - error (_("Unable to read in 0x%x bytes of %s\n"), size, reason); + error (_("Unable to read in 0x%lx bytes of %s\n"), + (unsigned long)(size * nmemb), reason); if (mvar != var) free (mvar); return NULL; @@ -365,11 +390,6 @@ byte_get_little_endian (unsigned char *field, int size) #ifdef BFD64 case 8: - case -8: - /* This is a special case, generated by the BYTE_GET8 macro. - It means that we are loading an 8 byte value from a field - in an external structure into an 8 byte value in a field - in an internal structure. */ return ((bfd_vma) (field[0])) | (((bfd_vma) (field[1])) << 8) | (((bfd_vma) (field[2])) << 16) @@ -399,7 +419,6 @@ byte_get_signed (unsigned char *field, int size) case 4: return (x ^ 0x80000000) - 0x80000000; case 8: - case -8: return x; default: abort (); @@ -434,8 +453,60 @@ byte_put_little_endian (unsigned char *field, bfd_vma value, int size) } } +#if defined BFD64 && !BFD_HOST_64BIT_LONG +static int +print_dec_vma (bfd_vma vma, int is_signed) +{ + char buf[40]; + char *bufp = buf; + int nc = 0; + + if (is_signed && (bfd_signed_vma) vma < 0) + { + vma = -vma; + putchar ('-'); + nc = 1; + } + + do + { + *bufp++ = '0' + vma % 10; + vma /= 10; + } + while (vma != 0); + nc += bufp - buf; + + while (bufp > buf) + putchar (*--bufp); + return nc; +} + +static int +print_hex_vma (bfd_vma vma) +{ + char buf[32]; + char *bufp = buf; + int nc; + + do + { + char digit = '0' + (vma & 0x0f); + if (digit > '9') + digit += 'a' - '0' - 10; + *bufp++ = digit; + vma >>= 4; + } + while (vma != 0); + nc = bufp - buf; + + while (bufp > buf) + putchar (*--bufp); + return nc; +} +#endif + /* Print a VMA value. */ -static void +static int print_vma (bfd_vma vma, print_mode mode) { #ifdef BFD64 @@ -445,106 +516,85 @@ print_vma (bfd_vma vma, print_mode mode) switch (mode) { case FULL_HEX: - printf ("0x"); - /* Drop through. */ + return printf ("0x%8.8lx", (unsigned long) vma); + case LONG_HEX: - printf ("%8.8lx", (unsigned long) vma); - break; + return printf ("%8.8lx", (unsigned long) vma); case DEC_5: if (vma <= 99999) - { - printf ("%5ld", (long) vma); - break; - } + return printf ("%5ld", (long) vma); /* Drop through. */ + case PREFIX_HEX: - printf ("0x"); - /* Drop through. */ + return printf ("0x%lx", (unsigned long) vma); + case HEX: - printf ("%lx", (unsigned long) vma); - break; + return printf ("%lx", (unsigned long) vma); case DEC: - printf ("%ld", (unsigned long) vma); - break; + return printf ("%ld", (unsigned long) vma); case UNSIGNED: - printf ("%lu", (unsigned long) vma); - break; + return printf ("%lu", (unsigned long) vma); } } #ifdef BFD64 else { + int nc = 0; + switch (mode) { case FULL_HEX: - printf ("0x"); + nc = printf ("0x"); /* Drop through. */ case LONG_HEX: printf_vma (vma); - break; + return nc + 16; case PREFIX_HEX: - printf ("0x"); + nc = printf ("0x"); /* Drop through. */ case HEX: #if BFD_HOST_64BIT_LONG - printf ("%lx", vma); + return nc + printf ("%lx", vma); #else - if (_bfd_int64_high (vma)) - printf ("%lx%8.8lx", _bfd_int64_high (vma), _bfd_int64_low (vma)); - else - printf ("%lx", _bfd_int64_low (vma)); + return nc + print_hex_vma (vma); #endif - break; case DEC: #if BFD_HOST_64BIT_LONG - printf ("%ld", vma); + return printf ("%ld", vma); #else - if (_bfd_int64_high (vma)) - /* ugg */ - printf ("++%ld", _bfd_int64_low (vma)); - else - printf ("%ld", _bfd_int64_low (vma)); + return print_dec_vma (vma, 1); #endif - break; case DEC_5: #if BFD_HOST_64BIT_LONG if (vma <= 99999) - printf ("%5ld", vma); + return printf ("%5ld", vma); else - printf ("%#lx", vma); + return printf ("%#lx", vma); #else - if (_bfd_int64_high (vma)) - /* ugg */ - printf ("++%ld", _bfd_int64_low (vma)); - else if (vma <= 99999) - printf ("%5ld", _bfd_int64_low (vma)); + if (vma <= 99999) + return printf ("%5ld", _bfd_int64_low (vma)); else - printf ("%#lx", _bfd_int64_low (vma)); + return print_hex_vma (vma); #endif - break; case UNSIGNED: #if BFD_HOST_64BIT_LONG - printf ("%lu", vma); + return printf ("%lu", vma); #else - if (_bfd_int64_high (vma)) - /* ugg */ - printf ("++%lu", _bfd_int64_low (vma)); - else - printf ("%lu", _bfd_int64_low (vma)); + return print_dec_vma (vma, 0); #endif - break; } } #endif + return 0; } /* Display a symbol on stdout. If do_wide is not true then @@ -575,27 +625,21 @@ byte_get_big_endian (unsigned char *field, int size) case 2: return ((unsigned int) (field[1])) | (((int) (field[0])) << 8); +#ifndef BFD64 + case 8: + /* Although we are extracing data from an 8 byte wide field, + we are returning only 4 bytes of data. */ + field += 4; + /* Fall thru */ +#endif case 4: return ((unsigned long) (field[3])) | (((unsigned long) (field[2])) << 8) | (((unsigned long) (field[1])) << 16) | (((unsigned long) (field[0])) << 24); -#ifndef BFD64 - case 8: - /* Although we are extracing data from an 8 byte wide field, - we are returning only 4 bytes of data. */ - return ((unsigned long) (field[7])) - | (((unsigned long) (field[6])) << 8) - | (((unsigned long) (field[5])) << 16) - | (((unsigned long) (field[4])) << 24); -#else +#ifdef BFD64 case 8: - case -8: - /* This is a special case, generated by the BYTE_GET8 macro. - It means that we are loading an 8 byte value from a field - in an external structure into an 8 byte value in a field - in an internal structure. */ return ((bfd_vma) (field[7])) | (((bfd_vma) (field[6])) << 8) | (((bfd_vma) (field[5])) << 16) @@ -644,6 +688,20 @@ byte_put_big_endian (unsigned char *field, bfd_vma value, int size) } } +/* Return a pointer to section NAME, or NULL if no such section exists. */ + +static Elf_Internal_Shdr * +find_section (const char *name) +{ + unsigned int i; + + for (i = 0; i < elf_header.e_shnum; i++) + if (streq (SECTION_NAME (section_headers + i), name)) + return section_headers + i; + + return NULL; +} + /* Guess the relocation size commonly used by the specific machines. */ static int @@ -710,6 +768,8 @@ guess_is_rela (unsigned long e_machine) case EM_XTENSA: case EM_XTENSA_OLD: case EM_M32R: + case EM_M32C: + case EM_MS1: return TRUE; case EM_MMA: @@ -750,16 +810,17 @@ slurp_rela_relocs (FILE *file, { Elf32_External_Rela *erelas; - erelas = get_data (NULL, file, rel_offset, rel_size, _("relocs")); + erelas = get_data (NULL, file, rel_offset, 1, rel_size, _("relocs")); if (!erelas) return 0; nrelas = rel_size / sizeof (Elf32_External_Rela); - relas = malloc (nrelas * sizeof (Elf_Internal_Rela)); + relas = cmalloc (nrelas, sizeof (Elf_Internal_Rela)); if (relas == NULL) { + free (erelas); error (_("out of memory parsing relocs")); return 0; } @@ -777,25 +838,26 @@ slurp_rela_relocs (FILE *file, { Elf64_External_Rela *erelas; - erelas = get_data (NULL, file, rel_offset, rel_size, _("relocs")); + erelas = get_data (NULL, file, rel_offset, 1, rel_size, _("relocs")); if (!erelas) return 0; nrelas = rel_size / sizeof (Elf64_External_Rela); - relas = malloc (nrelas * sizeof (Elf_Internal_Rela)); + relas = cmalloc (nrelas, sizeof (Elf_Internal_Rela)); if (relas == NULL) { + free (erelas); error (_("out of memory parsing relocs")); return 0; } for (i = 0; i < nrelas; i++) { - relas[i].r_offset = BYTE_GET8 (erelas[i].r_offset); - relas[i].r_info = BYTE_GET8 (erelas[i].r_info); - relas[i].r_addend = BYTE_GET8 (erelas[i].r_addend); + relas[i].r_offset = BYTE_GET (erelas[i].r_offset); + relas[i].r_info = BYTE_GET (erelas[i].r_info); + relas[i].r_addend = BYTE_GET (erelas[i].r_addend); } free (erelas); @@ -820,16 +882,17 @@ slurp_rel_relocs (FILE *file, { Elf32_External_Rel *erels; - erels = get_data (NULL, file, rel_offset, rel_size, _("relocs")); + erels = get_data (NULL, file, rel_offset, 1, rel_size, _("relocs")); if (!erels) return 0; nrels = rel_size / sizeof (Elf32_External_Rel); - rels = malloc (nrels * sizeof (Elf_Internal_Rela)); + rels = cmalloc (nrels, sizeof (Elf_Internal_Rela)); if (rels == NULL) { + free (erels); error (_("out of memory parsing relocs")); return 0; } @@ -847,24 +910,25 @@ slurp_rel_relocs (FILE *file, { Elf64_External_Rel *erels; - erels = get_data (NULL, file, rel_offset, rel_size, _("relocs")); + erels = get_data (NULL, file, rel_offset, 1, rel_size, _("relocs")); if (!erels) return 0; nrels = rel_size / sizeof (Elf64_External_Rel); - rels = malloc (nrels * sizeof (Elf_Internal_Rela)); + rels = cmalloc (nrels, sizeof (Elf_Internal_Rela)); if (rels == NULL) { + free (erels); error (_("out of memory parsing relocs")); return 0; } for (i = 0; i < nrels; i++) { - rels[i].r_offset = BYTE_GET8 (erels[i].r_offset); - rels[i].r_info = BYTE_GET8 (erels[i].r_info); + rels[i].r_offset = BYTE_GET (erels[i].r_offset); + rels[i].r_info = BYTE_GET (erels[i].r_info); rels[i].r_addend = 0; } @@ -1213,6 +1277,14 @@ dump_relocations (FILE *file, case EM_XTENSA: rtype = elf_xtensa_reloc_type (type); break; + + case EM_M32C: + rtype = elf_m32c_reloc_type (type); + break; + + case EM_MS1: + rtype = elf_ms1_reloc_type (type); + break; } if (rtype == NULL) @@ -1224,7 +1296,31 @@ dump_relocations (FILE *file, else printf (do_wide ? "%-22.22s" : "%-17.17s", rtype); - if (symtab_index) + if (elf_header.e_machine == EM_ALPHA + && streq (rtype, "R_ALPHA_LITUSE") + && is_rela) + { + switch (rels[i].r_addend) + { + case LITUSE_ALPHA_ADDR: rtype = "ADDR"; break; + case LITUSE_ALPHA_BASE: rtype = "BASE"; break; + case LITUSE_ALPHA_BYTOFF: rtype = "BYTOFF"; break; + case LITUSE_ALPHA_JSR: rtype = "JSR"; break; + case LITUSE_ALPHA_TLSGD: rtype = "TLSGD"; break; + case LITUSE_ALPHA_TLSLDM: rtype = "TLSLDM"; break; + case LITUSE_ALPHA_JSRDIRECT: rtype = "JSRDIRECT"; break; + default: rtype = NULL; + } + if (rtype) + printf (" (%s)", rtype); + else + { + putchar (' '); + printf (_(""), + (unsigned long) rels[i].r_addend); + } + } + else if (symtab_index) { if (symtab == NULL || symtab_index >= nsyms) printf (" bad symbol index: %08lx", (unsigned long) symtab_index); @@ -1259,6 +1355,9 @@ dump_relocations (FILE *file, sec_name = "ABS"; else if (psym->st_shndx == SHN_COMMON) sec_name = "COMMON"; + else if (elf_header.e_machine == EM_X86_64 + && psym->st_shndx == SHN_X86_64_LCOMMON) + sec_name = "LARGE_COMMON"; else if (elf_header.e_machine == EM_IA_64 && elf_header.e_ident[EI_OSABI] == ELFOSABI_HPUX && psym->st_shndx == SHN_IA_64_ANSI_COMMON) @@ -1274,7 +1373,7 @@ dump_relocations (FILE *file, } else if (strtab == NULL) printf (_(""), psym->st_name); - else if (psym->st_name > strtablen) + else if (psym->st_name >= strtablen) printf (_(""), psym->st_name); else print_symbol (22, strtab + psym->st_name); @@ -1290,8 +1389,7 @@ dump_relocations (FILE *file, print_vma (rels[i].r_addend, LONG_HEX); } - if (elf_header.e_machine == EM_SPARCV9 - && streq (rtype, "R_SPARC_OLO10")) + if (elf_header.e_machine == EM_SPARCV9 && streq (rtype, "R_SPARC_OLO10")) printf (" + %lx", (unsigned long) ELF64_R_TYPE_DATA (info)); putchar ('\n'); @@ -1393,6 +1491,17 @@ get_sparc64_dynamic_type (unsigned long type) } } +static const char * +get_ppc_dynamic_type (unsigned long type) +{ + switch (type) + { + case DT_PPC_GOT: return "PPC_GOT"; + default: + return NULL; + } +} + static const char * get_ppc64_dynamic_type (unsigned long type) { @@ -1424,6 +1533,17 @@ get_parisc_dynamic_type (unsigned long type) case DT_HP_GST_SIZE: return "HP_GST_SIZE"; case DT_HP_GST_VERSION: return "HP_GST_VERSION"; case DT_HP_GST_HASHVAL: return "HP_GST_HASHVAL"; + case DT_HP_EPLTREL: return "HP_GST_EPLTREL"; + case DT_HP_EPLTRELSZ: return "HP_GST_EPLTRELSZ"; + case DT_HP_FILTERED: return "HP_FILTERED"; + case DT_HP_FILTER_TLS: return "HP_FILTER_TLS"; + case DT_HP_COMPAT_FILTERED: return "HP_COMPAT_FILTERED"; + case DT_HP_LAZYLOAD: return "HP_LAZYLOAD"; + case DT_HP_BIND_NOW_COUNT: return "HP_BIND_NOW_COUNT"; + case DT_PLT: return "PLT"; + case DT_PLT_SIZE: return "PLT_SIZE"; + case DT_DLT: return "DLT"; + case DT_DLT_SIZE: return "DLT_SIZE"; default: return NULL; } @@ -1440,10 +1560,21 @@ get_ia64_dynamic_type (unsigned long type) } } +static const char * +get_alpha_dynamic_type (unsigned long type) +{ + switch (type) + { + case DT_ALPHA_PLTRO: return "ALPHA_PLTRO"; + default: + return NULL; + } +} + static const char * get_dynamic_type (unsigned long type) { - static char buff[32]; + static char buff[64]; switch (type) { @@ -1533,12 +1664,18 @@ get_dynamic_type (unsigned long type) case EM_SPARCV9: result = get_sparc64_dynamic_type (type); break; + case EM_PPC: + result = get_ppc_dynamic_type (type); + break; case EM_PPC64: result = get_ppc64_dynamic_type (type); break; case EM_IA_64: result = get_ia64_dynamic_type (type); break; + case EM_ALPHA: + result = get_alpha_dynamic_type (type); + break; default: result = NULL; break; @@ -1547,9 +1684,11 @@ get_dynamic_type (unsigned long type) if (result != NULL) return result; - sprintf (buff, _("Processor Specific: %lx"), type); + snprintf (buff, sizeof (buff), _("Processor Specific: %lx"), type); } - else if ((type >= DT_LOOS) && (type <= DT_HIOS)) + else if (((type >= DT_LOOS) && (type <= DT_HIOS)) + || (elf_header.e_machine == EM_PARISC + && (type >= OLD_DT_LOOS) && (type <= OLD_DT_HIOS))) { const char *result; @@ -1566,10 +1705,11 @@ get_dynamic_type (unsigned long type) if (result != NULL) return result; - sprintf (buff, _("Operating System specific: %lx"), type); + snprintf (buff, sizeof (buff), _("Operating System specific: %lx"), + type); } else - sprintf (buff, _(": %lx"), type); + snprintf (buff, sizeof (buff), _(": %lx"), type); return buff; } @@ -1590,11 +1730,11 @@ get_file_type (unsigned e_type) default: if ((e_type >= ET_LOPROC) && (e_type <= ET_HIPROC)) - sprintf (buff, _("Processor Specific: (%x)"), e_type); + snprintf (buff, sizeof (buff), _("Processor Specific: (%x)"), e_type); else if ((e_type >= ET_LOOS) && (e_type <= ET_HIOS)) - sprintf (buff, _("OS Specific: (%x)"), e_type); + snprintf (buff, sizeof (buff), _("OS Specific: (%x)"), e_type); else - sprintf (buff, _(": %x"), e_type); + snprintf (buff, sizeof (buff), _(": %x"), e_type); return buff; } } @@ -1700,8 +1840,10 @@ get_machine_name (unsigned e_machine) case EM_IQ2000: return "Vitesse IQ2000"; case EM_XTENSA_OLD: case EM_XTENSA: return "Tensilica Xtensa Processor"; + case EM_M32C: return "Renesas M32c"; + case EM_MS1: return "Morpho Techologies MS1 processor"; default: - sprintf (buff, _(": %x"), e_machine); + snprintf (buff, sizeof (buff), _(": %x"), e_machine); return buff; } } @@ -2209,11 +2351,25 @@ get_osabi_name (unsigned int osabi) case ELFOSABI_STANDALONE: return _("Standalone App"); case ELFOSABI_ARM: return "ARM"; default: - sprintf (buff, _(""), osabi); + snprintf (buff, sizeof (buff), _(""), osabi); return buff; } } +static const char * +get_arm_segment_type (unsigned long type) +{ + switch (type) + { + case PT_ARM_EXIDX: + return "EXIDX"; + default: + break; + } + + return NULL; +} + static const char * get_mips_segment_type (unsigned long type) { @@ -2249,8 +2405,13 @@ get_parisc_segment_type (unsigned long type) case PT_HP_CORE_MMF: return "HP_CORE_MMF"; case PT_HP_PARALLEL: return "HP_PARALLEL"; case PT_HP_FASTBIND: return "HP_FASTBIND"; + case PT_HP_OPT_ANNOT: return "HP_OPT_ANNOT"; + case PT_HP_HSL_ANNOT: return "HP_HSL_ANNOT"; + case PT_HP_STACK: return "HP_STACK"; + case PT_HP_CORE_UTSNAME: return "HP_CORE_UTSNAME"; case PT_PARISC_ARCHEXT: return "PARISC_ARCHEXT"; case PT_PARISC_UNWIND: return "PARISC_UNWIND"; + case PT_PARISC_WEAKORDER: return "PARISC_WEAKORDER"; default: break; } @@ -2304,6 +2465,9 @@ get_segment_type (unsigned long p_type) switch (elf_header.e_machine) { + case EM_ARM: + result = get_arm_segment_type (p_type); + break; case EM_MIPS: case EM_MIPS_RS3_LE: result = get_mips_segment_type (p_type); @@ -2347,7 +2511,7 @@ get_segment_type (unsigned long p_type) sprintf (buff, "LOOS+%lx", p_type - PT_LOOS); } else - sprintf (buff, _(": %lx"), p_type); + snprintf (buff, sizeof (buff), _(": %lx"), p_type); return buff; } @@ -2411,6 +2575,10 @@ get_parisc_section_type_name (unsigned int sh_type) case SHT_PARISC_EXT: return "PARISC_EXT"; case SHT_PARISC_UNWIND: return "PARISC_UNWIND"; case SHT_PARISC_DOC: return "PARISC_DOC"; + case SHT_PARISC_ANNOT: return "PARISC_ANNOT"; + case SHT_PARISC_SYMEXTN: return "PARISC_SYMEXTN"; + case SHT_PARISC_STUBS: return "PARISC_STUBS"; + case SHT_PARISC_DLKM: return "PARISC_DLKM"; default: break; } @@ -2531,7 +2699,7 @@ get_section_type_name (unsigned int sh_type) else if ((sh_type >= SHT_LOUSER) && (sh_type <= SHT_HIUSER)) sprintf (buff, "LOUSER+%x", sh_type - SHT_LOUSER); else - sprintf (buff, _(": %x"), sh_type); + snprintf (buff, sizeof (buff), _(": %x"), sh_type); return buff; } @@ -2539,7 +2707,7 @@ get_section_type_name (unsigned int sh_type) #define OPTION_DEBUG_DUMP 512 -struct option options[] = +static struct option options[] = { {"all", no_argument, 0, 'a'}, {"file-header", no_argument, 0, 'h'}, @@ -2550,6 +2718,8 @@ struct option options[] = {"sections", no_argument, 0, 'S'}, {"section-headers", no_argument, 0, 'S'}, {"section-groups", no_argument, 0, 'g'}, + {"section-details", no_argument, 0, 't'}, + {"full-section-name",no_argument, 0, 'N'}, {"symbols", no_argument, 0, 's'}, {"syms", no_argument, 0, 's'}, {"relocs", no_argument, 0, 'r'}, @@ -2584,6 +2754,7 @@ usage (void) -S --section-headers Display the sections' header\n\ --sections An alias for --section-headers\n\ -g --section-groups Display the section groups\n\ + -t --section-details Display the section details\n\ -e --headers Equivalent to: -h -l -S\n\ -s --syms Display the symbol table\n\ --symbols An alias for --syms\n\ @@ -2656,7 +2827,7 @@ parse_args (int argc, char **argv) usage (); while ((c = getopt_long - (argc, argv, "ersuahnldSDAIgw::x:i:vVWH", options, NULL)) != EOF) + (argc, argv, "ersuahnldSDAINtgw::x:i:vVWH", options, NULL)) != EOF) { char *cp; int section; @@ -2687,6 +2858,11 @@ parse_args (int argc, char **argv) case 'g': do_section_groups++; break; + case 't': + case 'N': + do_sections++; + do_section_details++; + break; case 'e': do_header++; do_sections++; @@ -2929,7 +3105,7 @@ get_elf_class (unsigned int elf_class) case ELFCLASS32: return "ELF32"; case ELFCLASS64: return "ELF64"; default: - sprintf (buff, _(""), elf_class); + snprintf (buff, sizeof (buff), _(""), elf_class); return buff; } } @@ -2945,7 +3121,7 @@ get_data_encoding (unsigned int encoding) case ELFDATA2LSB: return _("2's complement, little endian"); case ELFDATA2MSB: return _("2's complement, big endian"); default: - sprintf (buff, _(""), encoding); + snprintf (buff, sizeof (buff), _(""), encoding); return buff; } } @@ -3050,7 +3226,7 @@ get_32bit_program_headers (FILE *file, Elf_Internal_Phdr *program_headers) unsigned int i; phdrs = get_data (NULL, file, elf_header.e_phoff, - elf_header.e_phentsize * elf_header.e_phnum, + elf_header.e_phentsize, elf_header.e_phnum, _("program headers")); if (!phdrs) return 0; @@ -3083,7 +3259,7 @@ get_64bit_program_headers (FILE *file, Elf_Internal_Phdr *program_headers) unsigned int i; phdrs = get_data (NULL, file, elf_header.e_phoff, - elf_header.e_phentsize * elf_header.e_phnum, + elf_header.e_phentsize, elf_header.e_phnum, _("program headers")); if (!phdrs) return 0; @@ -3094,12 +3270,12 @@ get_64bit_program_headers (FILE *file, Elf_Internal_Phdr *program_headers) { internal->p_type = BYTE_GET (external->p_type); internal->p_flags = BYTE_GET (external->p_flags); - internal->p_offset = BYTE_GET8 (external->p_offset); - internal->p_vaddr = BYTE_GET8 (external->p_vaddr); - internal->p_paddr = BYTE_GET8 (external->p_paddr); - internal->p_filesz = BYTE_GET8 (external->p_filesz); - internal->p_memsz = BYTE_GET8 (external->p_memsz); - internal->p_align = BYTE_GET8 (external->p_align); + internal->p_offset = BYTE_GET (external->p_offset); + internal->p_vaddr = BYTE_GET (external->p_vaddr); + internal->p_paddr = BYTE_GET (external->p_paddr); + internal->p_filesz = BYTE_GET (external->p_filesz); + internal->p_memsz = BYTE_GET (external->p_memsz); + internal->p_align = BYTE_GET (external->p_align); } free (phdrs); @@ -3118,7 +3294,7 @@ get_program_headers (FILE *file) if (program_headers != NULL) return 1; - phdrs = malloc (elf_header.e_phnum * sizeof (Elf_Internal_Phdr)); + phdrs = cmalloc (elf_header.e_phnum, sizeof (Elf_Internal_Phdr)); if (phdrs == NULL) { @@ -3285,15 +3461,9 @@ process_program_headers (FILE *file) if (section_headers != NULL) { Elf_Internal_Shdr *sec; - unsigned int j; - - for (j = 0, sec = section_headers; - j < elf_header.e_shnum; - j++, sec++) - if (streq (SECTION_NAME (sec), ".dynamic")) - break; - if (j == elf_header.e_shnum || sec->sh_size == 0) + sec = find_section (".dynamic"); + if (sec == NULL || sec->sh_size == 0) { error (_("no .dynamic section in the dynamic segment")); break; @@ -3337,13 +3507,11 @@ process_program_headers (FILE *file) putc ('\n', stdout); } - if (do_segments && section_headers != NULL) + if (do_segments && section_headers != NULL && string_table != NULL) { printf (_("\n Section to Segment mapping:\n")); printf (_(" Segment Sections...\n")); - assert (string_table != NULL); - for (i = 0; i < elf_header.e_phnum; i++) { unsigned int j; @@ -3421,11 +3589,11 @@ get_32bit_section_headers (FILE *file, unsigned int num) unsigned int i; shdrs = get_data (NULL, file, elf_header.e_shoff, - elf_header.e_shentsize * num, _("section headers")); + elf_header.e_shentsize, num, _("section headers")); if (!shdrs) return 0; - section_headers = malloc (num * sizeof (Elf_Internal_Shdr)); + section_headers = cmalloc (num, sizeof (Elf_Internal_Shdr)); if (section_headers == NULL) { @@ -3462,11 +3630,11 @@ get_64bit_section_headers (FILE *file, unsigned int num) unsigned int i; shdrs = get_data (NULL, file, elf_header.e_shoff, - elf_header.e_shentsize * num, _("section headers")); + elf_header.e_shentsize, num, _("section headers")); if (!shdrs) return 0; - section_headers = malloc (num * sizeof (Elf_Internal_Shdr)); + section_headers = cmalloc (num, sizeof (Elf_Internal_Shdr)); if (section_headers == NULL) { @@ -3480,10 +3648,10 @@ get_64bit_section_headers (FILE *file, unsigned int num) { internal->sh_name = BYTE_GET (shdrs[i].sh_name); internal->sh_type = BYTE_GET (shdrs[i].sh_type); - internal->sh_flags = BYTE_GET8 (shdrs[i].sh_flags); - internal->sh_addr = BYTE_GET8 (shdrs[i].sh_addr); - internal->sh_size = BYTE_GET8 (shdrs[i].sh_size); - internal->sh_entsize = BYTE_GET8 (shdrs[i].sh_entsize); + internal->sh_flags = BYTE_GET (shdrs[i].sh_flags); + internal->sh_addr = BYTE_GET (shdrs[i].sh_addr); + internal->sh_size = BYTE_GET (shdrs[i].sh_size); + internal->sh_entsize = BYTE_GET (shdrs[i].sh_entsize); internal->sh_link = BYTE_GET (shdrs[i].sh_link); internal->sh_info = BYTE_GET (shdrs[i].sh_info); internal->sh_offset = BYTE_GET (shdrs[i].sh_offset); @@ -3505,7 +3673,7 @@ get_32bit_elf_symbols (FILE *file, Elf_Internal_Shdr *section) Elf_Internal_Sym *psym; unsigned int j; - esyms = get_data (NULL, file, section->sh_offset, section->sh_size, + esyms = get_data (NULL, file, section->sh_offset, 1, section->sh_size, _("symbols")); if (!esyms) return NULL; @@ -3516,7 +3684,7 @@ get_32bit_elf_symbols (FILE *file, Elf_Internal_Shdr *section) == (unsigned long) SECTION_HEADER_NUM (section - section_headers))) { shndx = get_data (NULL, file, symtab_shndx_hdr->sh_offset, - symtab_shndx_hdr->sh_size, _("symtab shndx")); + 1, symtab_shndx_hdr->sh_size, _("symtab shndx")); if (!shndx) { free (esyms); @@ -3525,7 +3693,7 @@ get_32bit_elf_symbols (FILE *file, Elf_Internal_Shdr *section) } number = section->sh_size / section->sh_entsize; - isyms = malloc (number * sizeof (Elf_Internal_Sym)); + isyms = cmalloc (number, sizeof (Elf_Internal_Sym)); if (isyms == NULL) { @@ -3568,7 +3736,7 @@ get_64bit_elf_symbols (FILE *file, Elf_Internal_Shdr *section) Elf_Internal_Sym *psym; unsigned int j; - esyms = get_data (NULL, file, section->sh_offset, section->sh_size, + esyms = get_data (NULL, file, section->sh_offset, 1, section->sh_size, _("symbols")); if (!esyms) return NULL; @@ -3579,7 +3747,7 @@ get_64bit_elf_symbols (FILE *file, Elf_Internal_Shdr *section) == (unsigned long) SECTION_HEADER_NUM (section - section_headers))) { shndx = get_data (NULL, file, symtab_shndx_hdr->sh_offset, - symtab_shndx_hdr->sh_size, _("symtab shndx")); + 1, symtab_shndx_hdr->sh_size, _("symtab shndx")); if (!shndx) { free (esyms); @@ -3588,7 +3756,7 @@ get_64bit_elf_symbols (FILE *file, Elf_Internal_Shdr *section) } number = section->sh_size / section->sh_entsize; - isyms = malloc (number * sizeof (Elf_Internal_Sym)); + isyms = cmalloc (number, sizeof (Elf_Internal_Sym)); if (isyms == NULL) { @@ -3610,8 +3778,8 @@ get_64bit_elf_symbols (FILE *file, Elf_Internal_Shdr *section) if (psym->st_shndx == SHN_XINDEX && shndx != NULL) psym->st_shndx = byte_get ((unsigned char *) &shndx[j], sizeof (shndx[j])); - psym->st_value = BYTE_GET8 (esyms[j].st_value); - psym->st_size = BYTE_GET8 (esyms[j].st_size); + psym->st_value = BYTE_GET (esyms[j].st_value); + psym->st_size = BYTE_GET (esyms[j].st_size); } if (shndx) @@ -3624,9 +3792,38 @@ get_64bit_elf_symbols (FILE *file, Elf_Internal_Shdr *section) static const char * get_elf_section_flags (bfd_vma sh_flags) { - static char buff[32]; + static char buff[1024]; + char *p = buff; + int field_size = is_32bit_elf ? 8 : 16; + int index, size = sizeof (buff) - (field_size + 4 + 1); + bfd_vma os_flags = 0; + bfd_vma proc_flags = 0; + bfd_vma unknown_flags = 0; + const struct + { + const char *str; + int len; + } + flags [] = + { + { "WRITE", 5 }, + { "ALLOC", 5 }, + { "EXEC", 4 }, + { "MERGE", 5 }, + { "STRINGS", 7 }, + { "INFO LINK", 9 }, + { "LINK ORDER", 10 }, + { "OS NONCONF", 10 }, + { "GROUP", 5 }, + { "TLS", 3 } + }; - *buff = 0; + if (do_section_details) + { + sprintf (buff, "[%*.*lx]: ", + field_size, field_size, (unsigned long) sh_flags); + p += field_size + 4; + } while (sh_flags) { @@ -3635,36 +3832,134 @@ get_elf_section_flags (bfd_vma sh_flags) flag = sh_flags & - sh_flags; sh_flags &= ~ flag; - switch (flag) + if (do_section_details) { - case SHF_WRITE: strcat (buff, "W"); break; - case SHF_ALLOC: strcat (buff, "A"); break; - case SHF_EXECINSTR: strcat (buff, "X"); break; - case SHF_MERGE: strcat (buff, "M"); break; - case SHF_STRINGS: strcat (buff, "S"); break; - case SHF_INFO_LINK: strcat (buff, "I"); break; - case SHF_LINK_ORDER: strcat (buff, "L"); break; - case SHF_OS_NONCONFORMING: strcat (buff, "O"); break; - case SHF_GROUP: strcat (buff, "G"); break; - case SHF_TLS: strcat (buff, "T"); break; + switch (flag) + { + case SHF_WRITE: index = 0; break; + case SHF_ALLOC: index = 1; break; + case SHF_EXECINSTR: index = 2; break; + case SHF_MERGE: index = 3; break; + case SHF_STRINGS: index = 4; break; + case SHF_INFO_LINK: index = 5; break; + case SHF_LINK_ORDER: index = 6; break; + case SHF_OS_NONCONFORMING: index = 7; break; + case SHF_GROUP: index = 8; break; + case SHF_TLS: index = 9; break; - default: - if (flag & SHF_MASKOS) + default: + index = -1; + break; + } + + if (index != -1) { - strcat (buff, "o"); - sh_flags &= ~ SHF_MASKOS; + if (p != buff + field_size + 4) + { + if (size < (10 + 2)) + abort (); + size -= 2; + *p++ = ','; + *p++ = ' '; + } + + size -= flags [index].len; + p = stpcpy (p, flags [index].str); } + else if (flag & SHF_MASKOS) + os_flags |= flag; else if (flag & SHF_MASKPROC) + proc_flags |= flag; + else + unknown_flags |= flag; + } + else + { + switch (flag) { - strcat (buff, "p"); - sh_flags &= ~ SHF_MASKPROC; + case SHF_WRITE: *p = 'W'; break; + case SHF_ALLOC: *p = 'A'; break; + case SHF_EXECINSTR: *p = 'X'; break; + case SHF_MERGE: *p = 'M'; break; + case SHF_STRINGS: *p = 'S'; break; + case SHF_INFO_LINK: *p = 'I'; break; + case SHF_LINK_ORDER: *p = 'L'; break; + case SHF_OS_NONCONFORMING: *p = 'O'; break; + case SHF_GROUP: *p = 'G'; break; + case SHF_TLS: *p = 'T'; break; + + default: + if (elf_header.e_machine == EM_X86_64 + && flag == SHF_X86_64_LARGE) + *p = 'l'; + else if (flag & SHF_MASKOS) + { + *p = 'o'; + sh_flags &= ~ SHF_MASKOS; + } + else if (flag & SHF_MASKPROC) + { + *p = 'p'; + sh_flags &= ~ SHF_MASKPROC; + } + else + *p = 'x'; + break; } - else - strcat (buff, "x"); - break; + p++; } } + if (do_section_details) + { + if (os_flags) + { + size -= 5 + field_size; + if (p != buff + field_size + 4) + { + if (size < (2 + 1)) + abort (); + size -= 2; + *p++ = ','; + *p++ = ' '; + } + sprintf (p, "OS (%*.*lx)", field_size, field_size, + (unsigned long) os_flags); + p += 5 + field_size; + } + if (proc_flags) + { + size -= 7 + field_size; + if (p != buff + field_size + 4) + { + if (size < (2 + 1)) + abort (); + size -= 2; + *p++ = ','; + *p++ = ' '; + } + sprintf (p, "PROC (%*.*lx)", field_size, field_size, + (unsigned long) proc_flags); + p += 7 + field_size; + } + if (unknown_flags) + { + size -= 10 + field_size; + if (p != buff + field_size + 4) + { + if (size < (2 + 1)) + abort (); + size -= 2; + *p++ = ','; + *p++ = ' '; + } + sprintf (p, "UNKNOWN (%*.*lx)", field_size, field_size, + (unsigned long) unknown_flags); + p += 10 + field_size; + } + } + + *p = '\0'; return buff; } @@ -3697,17 +3992,17 @@ process_section_headers (FILE *file) return 0; /* Read in the string table, so that we have names to display. */ - section = SECTION_HEADER (elf_header.e_shstrndx); - - if (section->sh_size != 0) + if (SECTION_HEADER_INDEX (elf_header.e_shstrndx) < elf_header.e_shnum) { - string_table = get_data (NULL, file, section->sh_offset, - section->sh_size, _("string table")); + section = SECTION_HEADER (elf_header.e_shstrndx); - if (string_table == NULL) - return 0; + if (section->sh_size != 0) + { + string_table = get_data (NULL, file, section->sh_offset, + 1, section->sh_size, _("string table")); - string_table_length = section->sh_size; + string_table_length = string_table != NULL ? section->sh_size : 0; + } } /* Scan the sections for the dynamic symbol table @@ -3717,6 +4012,42 @@ process_section_headers (FILE *file) dynamic_syminfo = NULL; symtab_shndx_hdr = NULL; + eh_addr_size = is_32bit_elf ? 4 : 8; + switch (elf_header.e_machine) + { + case EM_MIPS: + case EM_MIPS_RS3_LE: + /* The 64-bit MIPS EABI uses a combination of 32-bit ELF and 64-bit + FDE addresses. However, the ABI also has a semi-official ILP32 + variant for which the normal FDE address size rules apply. + + GCC 4.0 marks EABI64 objects with a dummy .gcc_compiled_longXX + section, where XX is the size of longs in bits. Unfortunately, + earlier compilers provided no way of distinguishing ILP32 objects + from LP64 objects, so if there's any doubt, we should assume that + the official LP64 form is being used. */ + if ((elf_header.e_flags & EF_MIPS_ABI) == E_MIPS_ABI_EABI64 + && find_section (".gcc_compiled_long32") == NULL) + eh_addr_size = 8; + break; + } + +#define CHECK_ENTSIZE_VALUES(section, i, size32, size64) \ + do \ + { \ + size_t expected_entsize \ + = is_32bit_elf ? size32 : size64; \ + if (section->sh_entsize != expected_entsize) \ + error (_("Section %d has invalid sh_entsize %lx (expected %lx)\n"), \ + i, (unsigned long int) section->sh_entsize, \ + (unsigned long int) expected_entsize); \ + section->sh_entsize = expected_entsize; \ + } \ + while (0) +#define CHECK_ENTSIZE(section, i, type) \ + CHECK_ENTSIZE_VALUES (section, i, sizeof (Elf32_External_##type), \ + sizeof (Elf64_External_##type)) + for (i = 0, section = section_headers; i < elf_header.e_shnum; i++, section++) @@ -3731,6 +4062,7 @@ process_section_headers (FILE *file) continue; } + CHECK_ENTSIZE (section, i, Sym); num_dynamic_syms = section->sh_size / section->sh_entsize; dynamic_symbols = GET_ELF_SYMBOLS (file, section); } @@ -3744,7 +4076,7 @@ process_section_headers (FILE *file) } dynamic_strings = get_data (NULL, file, section->sh_offset, - section->sh_size, _("dynamic strings")); + 1, section->sh_size, _("dynamic strings")); dynamic_strings_length = section->sh_size; } else if (section->sh_type == SHT_SYMTAB_SHNDX) @@ -3756,6 +4088,14 @@ process_section_headers (FILE *file) } symtab_shndx_hdr = section; } + else if (section->sh_type == SHT_SYMTAB) + CHECK_ENTSIZE (section, i, Sym); + else if (section->sh_type == SHT_GROUP) + CHECK_ENTSIZE_VALUES (section, i, GRP_ENTRY_SIZE, GRP_ENTRY_SIZE); + else if (section->sh_type == SHT_REL) + CHECK_ENTSIZE (section, i, Rel); + else if (section->sh_type == SHT_RELA) + CHECK_ENTSIZE (section, i, Rela); else if ((do_debugging || do_debug_info || do_debug_abbrevs || do_debug_lines || do_debug_pubnames || do_debug_aranges || do_debug_frames || do_debug_macinfo || do_debug_str @@ -3795,25 +4135,63 @@ process_section_headers (FILE *file) printf (_("\nSection Header:\n")); if (is_32bit_elf) - printf - (_(" [Nr] Name Type Addr Off Size ES Flg Lk Inf Al\n")); + { + if (do_section_details) + { + printf (_(" [Nr] Name\n")); + printf (_(" Type Addr Off Size ES Lk Inf Al\n")); + } + else + printf + (_(" [Nr] Name Type Addr Off Size ES Flg Lk Inf Al\n")); + } else if (do_wide) - printf - (_(" [Nr] Name Type Address Off Size ES Flg Lk Inf Al\n")); + { + if (do_section_details) + { + printf (_(" [Nr] Name\n")); + printf (_(" Type Address Off Size ES Lk Inf Al\n")); + } + else + printf + (_(" [Nr] Name Type Address Off Size ES Flg Lk Inf Al\n")); + } else { - printf (_(" [Nr] Name Type Address Offset\n")); - printf (_(" Size EntSize Flags Link Info Align\n")); + if (do_section_details) + { + printf (_(" [Nr] Name\n")); + printf (_(" Type Address Offset Link\n")); + printf (_(" Size EntSize Info Align\n")); + } + else + { + printf (_(" [Nr] Name Type Address Offset\n")); + printf (_(" Size EntSize Flags Link Info Align\n")); + } } + if (do_section_details) + printf (_(" Flags\n")); + for (i = 0, section = section_headers; i < elf_header.e_shnum; i++, section++) { - printf (" [%2u] %-17.17s %-15.15s ", - SECTION_HEADER_NUM (i), - SECTION_NAME (section), - get_section_type_name (section->sh_type)); + if (do_section_details) + { + printf (" [%2u] %s\n", + SECTION_HEADER_NUM (i), + SECTION_NAME (section)); + if (is_32bit_elf || do_wide) + printf (" %-15.15s ", + get_section_type_name (section->sh_type)); + } + else + printf (" [%2u] %-17.17s %-15.15s ", + SECTION_HEADER_NUM (i), + SECTION_NAME (section), + get_section_type_name (section->sh_type)); if (is_32bit_elf) { @@ -3824,7 +4202,10 @@ process_section_headers (FILE *file) (unsigned long) section->sh_size, (unsigned long) section->sh_entsize); - printf (" %3s ", get_elf_section_flags (section->sh_flags)); + if (do_section_details) + fputs (" ", stdout); + else + printf (" %3s ", get_elf_section_flags (section->sh_flags)); printf ("%2ld %3lu %2ld\n", (unsigned long) section->sh_link, @@ -3859,7 +4240,10 @@ process_section_headers (FILE *file) print_vma (section->sh_entsize, LONG_HEX); } - printf (" %3s ", get_elf_section_flags (section->sh_flags)); + if (do_section_details) + fputs (" ", stdout); + else + printf (" %3s ", get_elf_section_flags (section->sh_flags)); printf ("%2ld %3lu ", (unsigned long) section->sh_link, @@ -3873,6 +4257,27 @@ process_section_headers (FILE *file) putchar ('\n'); } } + else if (do_section_details) + { + printf (" %-15.15s ", + get_section_type_name (section->sh_type)); + print_vma (section->sh_addr, LONG_HEX); + if ((long) section->sh_offset == section->sh_offset) + printf (" %16.16lx", (unsigned long) section->sh_offset); + else + { + printf (" "); + print_vma (section->sh_offset, LONG_HEX); + } + printf (" %ld\n ", (unsigned long) section->sh_link); + print_vma (section->sh_size, LONG_HEX); + putchar (' '); + print_vma (section->sh_entsize, LONG_HEX); + + printf (" %-16lu %ld\n", + (unsigned long) section->sh_info, + (unsigned long) section->sh_addralign); + } else { putchar (' '); @@ -3896,9 +4301,13 @@ process_section_headers (FILE *file) (unsigned long) section->sh_info, (unsigned long) section->sh_addralign); } + + if (do_section_details) + printf (" %s\n", get_elf_section_flags (section->sh_flags)); } - printf (_("Key to Flags:\n\ + if (!do_section_details) + printf (_("Key to Flags:\n\ W (write), A (alloc), X (execute), M (merge), S (strings)\n\ I (info), L (link order), G (group), x (unknown)\n\ O (extra OS processing required) o (OS specific), p (processor specific)\n")); @@ -3916,7 +4325,7 @@ get_group_flags (unsigned int flags) return "COMDAT"; default: - sprintf (buff, _("[: 0x%x]"), flags); + snprintf (buff, sizeof (buff), _("[: 0x%x]"), flags); break; } return buff; @@ -3928,11 +4337,19 @@ process_section_groups (FILE *file) Elf_Internal_Shdr *section; unsigned int i; struct group *group; + Elf_Internal_Shdr *symtab_sec, *strtab_sec; + Elf_Internal_Sym *symtab; + char *strtab; + size_t strtab_size; + + /* Don't process section groups unless needed. */ + if (!do_unwind && !do_section_groups) + return 1; if (elf_header.e_shnum == 0) { if (do_section_groups) - printf (_("\nThere are no section groups in this file.\n")); + printf (_("\nThere are no sections in this file.\n")); return 1; } @@ -3953,12 +4370,21 @@ process_section_groups (FILE *file) } /* Scan the sections for the group section. */ + group_count = 0; for (i = 0, section = section_headers; i < elf_header.e_shnum; i++, section++) if (section->sh_type == SHT_GROUP) group_count++; + if (group_count == 0) + { + if (do_section_groups) + printf (_("\nThere are no section groups in this file.\n")); + + return 1; + } + section_groups = calloc (group_count, sizeof (struct group)); if (section_groups == NULL) @@ -3967,6 +4393,11 @@ process_section_groups (FILE *file) return 0; } + symtab_sec = NULL; + strtab_sec = NULL; + symtab = NULL; + strtab = NULL; + strtab_size = 0; for (i = 0, section = section_headers, group = section_groups; i < elf_header.e_shnum; i++, section++) @@ -3974,20 +4405,28 @@ process_section_groups (FILE *file) if (section->sh_type == SHT_GROUP) { char *name = SECTION_NAME (section); - char *group_name, *strtab, *start, *indices; + char *group_name; + unsigned char *start, *indices; unsigned int entry, j, size; + Elf_Internal_Shdr *sec; Elf_Internal_Sym *sym; - Elf_Internal_Shdr *symtab_sec, *strtab_sec, *sec; - Elf_Internal_Sym *symtab; /* Get the symbol table. */ - symtab_sec = SECTION_HEADER (section->sh_link); - if (symtab_sec->sh_type != SHT_SYMTAB) + if (SECTION_HEADER_INDEX (section->sh_link) >= elf_header.e_shnum + || ((sec = SECTION_HEADER (section->sh_link))->sh_type + != SHT_SYMTAB)) { error (_("Bad sh_link in group section `%s'\n"), name); continue; } - symtab = GET_ELF_SYMBOLS (file, symtab_sec); + + if (symtab_sec != sec) + { + symtab_sec = sec; + if (symtab) + free (symtab); + symtab = GET_ELF_SYMBOLS (file, symtab_sec); + } sym = symtab + section->sh_info; @@ -4001,21 +4440,41 @@ process_section_groups (FILE *file) } group_name = SECTION_NAME (section_headers + sec_index); + strtab_sec = NULL; + if (strtab) + free (strtab); strtab = NULL; + strtab_size = 0; } else { /* Get the string table. */ - strtab_sec = SECTION_HEADER (symtab_sec->sh_link); - strtab = get_data (NULL, file, strtab_sec->sh_offset, - strtab_sec->sh_size, - _("string table")); - - group_name = strtab + sym->st_name; + if (SECTION_HEADER_INDEX (symtab_sec->sh_link) + >= elf_header.e_shnum) + { + strtab_sec = NULL; + if (strtab) + free (strtab); + strtab = NULL; + strtab_size = 0; + } + else if (strtab_sec + != (sec = SECTION_HEADER (symtab_sec->sh_link))) + { + strtab_sec = sec; + if (strtab) + free (strtab); + strtab = get_data (NULL, file, strtab_sec->sh_offset, + 1, strtab_sec->sh_size, + _("string table")); + strtab_size = strtab != NULL ? strtab_sec->sh_size : 0; + } + group_name = sym->st_name < strtab_size + ? strtab + sym->st_name : ""; } start = get_data (NULL, file, section->sh_offset, - section->sh_size, _("section data")); + 1, section->sh_size, _("section data")); indices = start; size = (section->sh_size / section->sh_entsize) - 1; @@ -4024,8 +4483,8 @@ process_section_groups (FILE *file) if (do_section_groups) { - printf ("\n%s group section `%s' [%s] contains %u sections:\n", - get_group_flags (entry), name, group_name, size); + printf ("\n%s group section [%5u] `%s' [%s] contains %u sections:\n", + get_group_flags (entry), i, name, group_name, size); printf (_(" [Index] Name\n")); } @@ -4039,12 +4498,42 @@ process_section_groups (FILE *file) entry = byte_get (indices, 4); indices += 4; + if (SECTION_HEADER_INDEX (entry) >= elf_header.e_shnum) + { + error (_("section [%5u] in group section [%5u] > maximum section [%5u]\n"), + entry, i, elf_header.e_shnum - 1); + continue; + } + else if (entry >= SHN_LORESERVE && entry <= SHN_HIRESERVE) + { + error (_("invalid section [%5u] in group section [%5u]\n"), + entry, i); + continue; + } + if (section_headers_groups [SECTION_HEADER_INDEX (entry)] != NULL) { - error (_("section [%5u] already in group section [%5u]\n"), - entry, section_headers_groups [SECTION_HEADER_INDEX (entry)]->group_index); - continue; + if (entry) + { + error (_("section [%5u] in group section [%5u] already in group section [%5u]\n"), + entry, i, + section_headers_groups [SECTION_HEADER_INDEX (entry)]->group_index); + continue; + } + else + { + /* Intel C/C++ compiler may put section 0 in a + section group. We just warn it the first time + and ignore it afterwards. */ + static int warned = 0; + if (!warned) + { + error (_("section 0 in group section [%5u]\n"), + section_headers_groups [SECTION_HEADER_INDEX (entry)]->group_index); + warned++; + } + } } section_headers_groups [SECTION_HEADER_INDEX (entry)] @@ -4053,8 +4542,7 @@ process_section_groups (FILE *file) if (do_section_groups) { sec = SECTION_HEADER (entry); - printf (" [%5u] %s\n", - entry, SECTION_NAME (sec)); + printf (" [%5u] %s\n", entry, SECTION_NAME (sec)); } g = xmalloc (sizeof (struct group_list)); @@ -4063,10 +4551,6 @@ process_section_groups (FILE *file) group->root = g; } - if (symtab) - free (symtab); - if (strtab) - free (strtab); if (start) free (start); @@ -4074,10 +4558,14 @@ process_section_groups (FILE *file) } } + if (symtab) + free (symtab); + if (strtab) + free (strtab); return 1; } -struct +static struct { const char *name; int reloc; @@ -4185,26 +4673,37 @@ process_relocs (FILE *file) is_rela = section->sh_type == SHT_RELA; - if (section->sh_link) + if (section->sh_link + && SECTION_HEADER_INDEX (section->sh_link) + < elf_header.e_shnum) { Elf_Internal_Shdr *symsec; Elf_Internal_Sym *symtab; unsigned long nsyms; - unsigned long strtablen; + unsigned long strtablen = 0; char *strtab = NULL; symsec = SECTION_HEADER (section->sh_link); + if (symsec->sh_type != SHT_SYMTAB + && symsec->sh_type != SHT_DYNSYM) + continue; + nsyms = symsec->sh_size / symsec->sh_entsize; symtab = GET_ELF_SYMBOLS (file, symsec); if (symtab == NULL) continue; - strsec = SECTION_HEADER (symsec->sh_link); + if (SECTION_HEADER_INDEX (symsec->sh_link) + < elf_header.e_shnum) + { + strsec = SECTION_HEADER (symsec->sh_link); - strtab = get_data (NULL, file, strsec->sh_offset, - strsec->sh_size, _("string table")); - strtablen = strtab == NULL ? 0 : strsec->sh_size; + strtab = get_data (NULL, file, strsec->sh_offset, + 1, strsec->sh_size, + _("string table")); + strtablen = strtab == NULL ? 0 : strsec->sh_size; + } dump_relocations (file, rel_offset, rel_size, symtab, nsyms, strtab, strtablen, is_rela); @@ -4302,12 +4801,9 @@ find_symbol_for_address (Elf_Internal_Sym *symtab, static void dump_ia64_unwind (struct ia64_unw_aux_info *aux) { - bfd_vma addr_size; struct ia64_unw_table_entry *tp; int in_body; - addr_size = is_32bit_elf ? 4 : 8; - for (tp = aux->table; tp < aux->table + aux->table_len; ++tp) { bfd_vma stamp; @@ -4337,14 +4833,14 @@ dump_ia64_unwind (struct ia64_unw_aux_info *aux) (unsigned long) (tp->info.offset - aux->seg_base)); head = aux->info + (tp->info.offset - aux->info_addr); - stamp = BYTE_GET8 ((unsigned char *) head); + stamp = byte_get ((unsigned char *) head, sizeof (stamp)); printf (" v%u, flags=0x%lx (%s%s), len=%lu bytes\n", (unsigned) UNW_VER (stamp), (unsigned long) ((stamp & UNW_FLAG_MASK) >> 32), UNW_FLAG_EHANDLER (stamp) ? " ehandler" : "", UNW_FLAG_UHANDLER (stamp) ? " uhandler" : "", - (unsigned long) (addr_size * UNW_LENGTH (stamp))); + (unsigned long) (eh_addr_size * UNW_LENGTH (stamp))); if (UNW_VER (stamp) != 1) { @@ -4353,7 +4849,7 @@ dump_ia64_unwind (struct ia64_unw_aux_info *aux) } in_body = 0; - for (dp = head + 8; dp < head + 8 + addr_size * UNW_LENGTH (stamp);) + for (dp = head + 8; dp < head + 8 + eh_addr_size * UNW_LENGTH (stamp);) dp = unw_decode (dp, in_body, & in_body); } } @@ -4363,7 +4859,7 @@ slurp_ia64_unwind_table (FILE *file, struct ia64_unw_aux_info *aux, Elf_Internal_Shdr *sec) { - unsigned long size, addr_size, nrelas, i; + unsigned long size, nrelas, i; Elf_Internal_Phdr *seg; struct ia64_unw_table_entry *tep; Elf_Internal_Shdr *relsec; @@ -4372,8 +4868,6 @@ slurp_ia64_unwind_table (FILE *file, Elf_Internal_Sym *sym; const char *relname; - addr_size = is_32bit_elf ? 4 : 8; - /* First, find the starting address of the segment that includes this section: */ @@ -4400,12 +4894,13 @@ slurp_ia64_unwind_table (FILE *file, /* Second, build the unwind table from the contents of the unwind section: */ size = sec->sh_size; - table = get_data (NULL, file, sec->sh_offset, size, _("unwind table")); + table = get_data (NULL, file, sec->sh_offset, 1, size, _("unwind table")); if (!table) return 0; - tep = aux->table = xmalloc (size / (3 * addr_size) * sizeof (aux->table[0])); - for (tp = table; tp < table + size; tp += 3 * addr_size, ++tep) + aux->table = xcmalloc (size / (3 * eh_addr_size), sizeof (aux->table[0])); + tep = aux->table; + for (tp = table; tp < table + size; tp += 3 * eh_addr_size, ++tep) { tep->start.section = SHN_UNDEF; tep->end.section = SHN_UNDEF; @@ -4418,9 +4913,9 @@ slurp_ia64_unwind_table (FILE *file, } else { - tep->start.offset = BYTE_GET8 ((unsigned char *) tp + 0); - tep->end.offset = BYTE_GET8 ((unsigned char *) tp + 8); - tep->info.offset = BYTE_GET8 ((unsigned char *) tp + 16); + tep->start.offset = BYTE_GET ((unsigned char *) tp + 0); + tep->end.offset = BYTE_GET ((unsigned char *) tp + 8); + tep->info.offset = BYTE_GET ((unsigned char *) tp + 16); } tep->start.offset += aux->seg_base; tep->end.offset += aux->seg_base; @@ -4435,6 +4930,7 @@ slurp_ia64_unwind_table (FILE *file, ++relsec) { if (relsec->sh_type != SHT_RELA + || SECTION_HEADER_INDEX (relsec->sh_info) >= elf_header.e_shnum || SECTION_HEADER (relsec->sh_info) != sec) continue; @@ -4461,9 +4957,9 @@ slurp_ia64_unwind_table (FILE *file, continue; } - i = rp->r_offset / (3 * addr_size); + i = rp->r_offset / (3 * eh_addr_size); - switch (rp->r_offset/addr_size % 3) + switch (rp->r_offset/eh_addr_size % 3) { case 0: aux->table[i].start.section = sym->st_shndx; @@ -4485,7 +4981,7 @@ slurp_ia64_unwind_table (FILE *file, free (rela); } - aux->table_len = size / (3 * addr_size); + aux->table_len = size / (3 * eh_addr_size); return 1; } @@ -4493,24 +4989,23 @@ static int ia64_process_unwind (FILE *file) { Elf_Internal_Shdr *sec, *unwsec = NULL, *strsec; - unsigned long i, addr_size, unwcount = 0, unwstart = 0; + unsigned long i, unwcount = 0, unwstart = 0; struct ia64_unw_aux_info aux; memset (& aux, 0, sizeof (aux)); - addr_size = is_32bit_elf ? 4 : 8; - for (i = 0, sec = section_headers; i < elf_header.e_shnum; ++i, ++sec) { - if (sec->sh_type == SHT_SYMTAB) + if (sec->sh_type == SHT_SYMTAB + && SECTION_HEADER_INDEX (sec->sh_link) < elf_header.e_shnum) { aux.nsyms = sec->sh_size / sec->sh_entsize; aux.symtab = GET_ELF_SYMBOLS (file, sec); strsec = SECTION_HEADER (sec->sh_link); - aux.strtab_size = strsec->sh_size; aux.strtab = get_data (NULL, file, strsec->sh_offset, - aux.strtab_size, _("string table")); + 1, strsec->sh_size, _("string table")); + aux.strtab_size = aux.strtab != NULL ? strsec->sh_size : 0; } else if (sec->sh_type == SHT_IA_64_UNWIND) unwcount++; @@ -4591,7 +5086,7 @@ ia64_process_unwind (FILE *file) { aux.info_size = sec->sh_size; aux.info_addr = sec->sh_addr; - aux.info = get_data (NULL, file, sec->sh_offset, aux.info_size, + aux.info = get_data (NULL, file, sec->sh_offset, 1, aux.info_size, _("unwind info")); printf (_("\nUnwind section ")); @@ -4603,7 +5098,7 @@ ia64_process_unwind (FILE *file) printf (_(" at offset 0x%lx contains %lu entries:\n"), (unsigned long) unwsec->sh_offset, - (unsigned long) (unwsec->sh_size / (3 * addr_size))); + (unsigned long) (unwsec->sh_size / (3 * eh_addr_size))); (void) slurp_ia64_unwind_table (file, & aux, unwsec); @@ -4677,10 +5172,8 @@ struct hppa_unw_aux_info static void dump_hppa_unwind (struct hppa_unw_aux_info *aux) { - bfd_vma addr_size; struct hppa_unw_table_entry *tp; - addr_size = is_32bit_elf ? 4 : 8; for (tp = aux->table; tp < aux->table + aux->table_len; ++tp) { bfd_vma offset; @@ -4747,7 +5240,7 @@ slurp_hppa_unwind_table (FILE *file, struct hppa_unw_aux_info *aux, Elf_Internal_Shdr *sec) { - unsigned long size, unw_ent_size, addr_size, nrelas, i; + unsigned long size, unw_ent_size, nentries, nrelas, i; Elf_Internal_Phdr *seg; struct hppa_unw_table_entry *tep; Elf_Internal_Shdr *relsec; @@ -4756,8 +5249,6 @@ slurp_hppa_unwind_table (FILE *file, Elf_Internal_Sym *sym; const char *relname; - addr_size = is_32bit_elf ? 4 : 8; - /* First, find the starting address of the segment that includes this section. */ @@ -4785,35 +5276,30 @@ slurp_hppa_unwind_table (FILE *file, /* Second, build the unwind table from the contents of the unwind section. */ size = sec->sh_size; - table = get_data (NULL, file, sec->sh_offset, size, _("unwind table")); + table = get_data (NULL, file, sec->sh_offset, 1, size, _("unwind table")); if (!table) return 0; - unw_ent_size = 2 * addr_size + 8; + unw_ent_size = 16; + nentries = size / unw_ent_size; + size = unw_ent_size * nentries; - tep = aux->table = xmalloc (size / unw_ent_size * sizeof (aux->table[0])); + tep = aux->table = xcmalloc (nentries, sizeof (aux->table[0])); - for (tp = table; tp < table + size; tp += (2 * addr_size + 8), ++tep) + for (tp = table; tp < table + size; tp += unw_ent_size, ++tep) { unsigned int tmp1, tmp2; tep->start.section = SHN_UNDEF; tep->end.section = SHN_UNDEF; - if (is_32bit_elf) - { - tep->start.offset = byte_get ((unsigned char *) tp + 0, 4); - tep->end.offset = byte_get ((unsigned char *) tp + 4, 4); - tmp1 = byte_get ((unsigned char *) tp + 8, 4); - tmp2 = byte_get ((unsigned char *) tp + 12, 4); - } - else - { - tep->start.offset = BYTE_GET8 ((unsigned char *) tp + 0); - tep->end.offset = BYTE_GET8 ((unsigned char *) tp + 8); - tmp1 = byte_get ((unsigned char *) tp + 16, 4); - tmp2 = byte_get ((unsigned char *) tp + 20, 4); - } + tep->start.offset = byte_get ((unsigned char *) tp + 0, 4); + tep->end.offset = byte_get ((unsigned char *) tp + 4, 4); + tmp1 = byte_get ((unsigned char *) tp + 8, 4); + tmp2 = byte_get ((unsigned char *) tp + 12, 4); + + tep->start.offset += aux->seg_base; + tep->end.offset += aux->seg_base; tep->Cannot_unwind = (tmp1 >> 31) & 0x1; tep->Millicode = (tmp1 >> 30) & 0x1; @@ -4846,9 +5332,6 @@ slurp_hppa_unwind_table (FILE *file, tep->Pseudo_SP_Set = (tmp2 >> 28) & 0x1; tep->reserved4 = (tmp2 >> 27) & 0x1; tep->Total_frame_size = tmp2 & 0x7ffffff; - - tep->start.offset += aux->seg_base; - tep->end.offset += aux->seg_base; } free (table); @@ -4859,6 +5342,7 @@ slurp_hppa_unwind_table (FILE *file, ++relsec) { if (relsec->sh_type != SHT_RELA + || SECTION_HEADER_INDEX (relsec->sh_info) >= elf_header.e_shnum || SECTION_HEADER (relsec->sh_info) != sec) continue; @@ -4888,7 +5372,7 @@ slurp_hppa_unwind_table (FILE *file, i = rp->r_offset / unw_ent_size; - switch ((rp->r_offset % unw_ent_size) / addr_size) + switch ((rp->r_offset % unw_ent_size) / eh_addr_size) { case 0: aux->table[i].start.section = sym->st_shndx; @@ -4906,7 +5390,7 @@ slurp_hppa_unwind_table (FILE *file, free (rela); } - aux->table_len = size / unw_ent_size; + aux->table_len = nentries; return 1; } @@ -4918,25 +5402,25 @@ hppa_process_unwind (FILE *file) Elf_Internal_Shdr *unwsec = NULL; Elf_Internal_Shdr *strsec; Elf_Internal_Shdr *sec; - unsigned long addr_size; unsigned long i; memset (& aux, 0, sizeof (aux)); - assert (string_table != NULL); - addr_size = is_32bit_elf ? 4 : 8; + if (string_table == NULL) + return 1; for (i = 0, sec = section_headers; i < elf_header.e_shnum; ++i, ++sec) { - if (sec->sh_type == SHT_SYMTAB) + if (sec->sh_type == SHT_SYMTAB + && SECTION_HEADER_INDEX (sec->sh_link) < elf_header.e_shnum) { aux.nsyms = sec->sh_size / sec->sh_entsize; aux.symtab = GET_ELF_SYMBOLS (file, sec); strsec = SECTION_HEADER (sec->sh_link); - aux.strtab_size = strsec->sh_size; aux.strtab = get_data (NULL, file, strsec->sh_offset, - aux.strtab_size, _("string table")); + 1, strsec->sh_size, _("string table")); + aux.strtab_size = aux.strtab != NULL ? strsec->sh_size : 0; } else if (streq (SECTION_NAME (sec), ".PARISC.unwind")) unwsec = sec; @@ -4954,7 +5438,7 @@ hppa_process_unwind (FILE *file) printf (_(" at offset 0x%lx contains %lu entries:\n"), (unsigned long) sec->sh_offset, - (unsigned long) (sec->sh_size / (2 * addr_size + 8))); + (unsigned long) (sec->sh_size / (2 * eh_addr_size + 8))); slurp_hppa_unwind_table (file, &aux, sec); if (aux.table_len > 0) @@ -5042,9 +5526,9 @@ dynamic_section_mips_val (Elf_Internal_Dyn *entry) time_t time = entry->d_un.d_val; tmp = gmtime (&time); - sprintf (timebuf, "%04u-%02u-%02uT%02u:%02u:%02u", - tmp->tm_year + 1900, tmp->tm_mon + 1, tmp->tm_mday, - tmp->tm_hour, tmp->tm_min, tmp->tm_sec); + snprintf (timebuf, sizeof (timebuf), "%04u-%02u-%02uT%02u:%02u:%02u", + tmp->tm_year + 1900, tmp->tm_mon + 1, tmp->tm_mday, + tmp->tm_hour, tmp->tm_min, tmp->tm_sec); printf ("Time Stamp: %s\n", timebuf); } break; @@ -5095,7 +5579,13 @@ dynamic_section_parisc_val (Elf_Internal_Dyn *entry) { DT_HP_BIND_RESTRICTED, "HP_BIND_RESTRICTED" }, { DT_HP_BIND_SYMBOLIC, "HP_BIND_SYMBOLIC" }, { DT_HP_RPATH_FIRST, "HP_RPATH_FIRST" }, - { DT_HP_BIND_DEPTH_FIRST, "HP_BIND_DEPTH_FIRST" } + { DT_HP_BIND_DEPTH_FIRST, "HP_BIND_DEPTH_FIRST" }, + { DT_HP_GST, "HP_GST" }, + { DT_HP_SHLIB_FIXED, "HP_SHLIB_FIXED" }, + { DT_HP_MERGE_SHLIB_SEG, "HP_MERGE_SHLIB_SEG" }, + { DT_HP_NODELETE, "HP_NODELETE" }, + { DT_HP_GROUP, "HP_GROUP" }, + { DT_HP_PROTECT_LINKAGE_TABLE, "HP_PROTECT_LINKAGE_TABLE" } }; int first = 1; size_t cnt; @@ -5152,7 +5642,7 @@ get_32bit_dynamic_section (FILE *file) Elf32_External_Dyn *edyn, *ext; Elf_Internal_Dyn *entry; - edyn = get_data (NULL, file, dynamic_addr, dynamic_size, + edyn = get_data (NULL, file, dynamic_addr, 1, dynamic_size, _("dynamic section")); if (!edyn) return 0; @@ -5169,7 +5659,7 @@ get_32bit_dynamic_section (FILE *file) break; } - dynamic_section = malloc (dynamic_nent * sizeof (*entry)); + dynamic_section = cmalloc (dynamic_nent, sizeof (*entry)); if (dynamic_section == NULL) { error (_("Out of memory\n")); @@ -5196,7 +5686,7 @@ get_64bit_dynamic_section (FILE *file) Elf64_External_Dyn *edyn, *ext; Elf_Internal_Dyn *entry; - edyn = get_data (NULL, file, dynamic_addr, dynamic_size, + edyn = get_data (NULL, file, dynamic_addr, 1, dynamic_size, _("dynamic section")); if (!edyn) return 0; @@ -5209,11 +5699,11 @@ get_64bit_dynamic_section (FILE *file) ext++) { dynamic_nent++; - if (BYTE_GET8 (ext->d_tag) == DT_NULL) + if (BYTE_GET (ext->d_tag) == DT_NULL) break; } - dynamic_section = malloc (dynamic_nent * sizeof (*entry)); + dynamic_section = cmalloc (dynamic_nent, sizeof (*entry)); if (dynamic_section == NULL) { error (_("Out of memory\n")); @@ -5225,8 +5715,8 @@ get_64bit_dynamic_section (FILE *file) entry < dynamic_section + dynamic_nent; ext++, entry++) { - entry->d_tag = BYTE_GET8 (ext->d_tag); - entry->d_un.d_val = BYTE_GET8 (ext->d_un.d_val); + entry->d_tag = BYTE_GET (ext->d_tag); + entry->d_un.d_val = BYTE_GET (ext->d_un.d_val); } free (edyn); @@ -5234,13 +5724,11 @@ get_64bit_dynamic_section (FILE *file) return 1; } -static const char * -get_dynamic_flags (bfd_vma flags) +static void +print_dynamic_flags (bfd_vma flags) { - static char buff[128]; - char *p = buff; + int first = 1; - *p = '\0'; while (flags) { bfd_vma flag; @@ -5248,22 +5736,22 @@ get_dynamic_flags (bfd_vma flags) flag = flags & - flags; flags &= ~ flag; - if (p != buff) - *p++ = ' '; + if (first) + first = 0; + else + putc (' ', stdout); switch (flag) { - case DF_ORIGIN: strcpy (p, "ORIGIN"); break; - case DF_SYMBOLIC: strcpy (p, "SYMBOLIC"); break; - case DF_TEXTREL: strcpy (p, "TEXTREL"); break; - case DF_BIND_NOW: strcpy (p, "BIND_NOW"); break; - case DF_STATIC_TLS: strcpy (p, "STATIC_TLS"); break; - default: strcpy (p, "unknown"); break; + case DF_ORIGIN: fputs ("ORIGIN", stdout); break; + case DF_SYMBOLIC: fputs ("SYMBOLIC", stdout); break; + case DF_TEXTREL: fputs ("TEXTREL", stdout); break; + case DF_BIND_NOW: fputs ("BIND_NOW", stdout); break; + case DF_STATIC_TLS: fputs ("STATIC_TLS", stdout); break; + default: fputs ("unknown", stdout); break; } - - p = strchr (p, '\0'); } - return buff; + puts (""); } /* Parse and display the contents of the dynamic section. */ @@ -5373,7 +5861,7 @@ process_dynamic_section (FILE *file) continue; } - dynamic_strings = get_data (NULL, file, offset, str_tab_len, + dynamic_strings = get_data (NULL, file, offset, 1, str_tab_len, _("dynamic string table")); dynamic_strings_length = str_tab_len; break; @@ -5408,8 +5896,8 @@ process_dynamic_section (FILE *file) Elf_Internal_Syminfo *syminfo; /* There is a syminfo section. Read the data. */ - extsyminfo = get_data (NULL, file, dynamic_syminfo_offset, syminsz, - _("symbol information")); + extsyminfo = get_data (NULL, file, dynamic_syminfo_offset, 1, + syminsz, _("symbol information")); if (!extsyminfo) return 0; @@ -5460,7 +5948,7 @@ process_dynamic_section (FILE *file) { case DT_FLAGS: if (do_dynamic) - puts (get_dynamic_flags (entry->d_un.d_val)); + print_dynamic_flags (entry->d_un.d_val); break; case DT_AUXILIARY: @@ -5885,9 +6373,13 @@ process_version_sections (FILE *file) printf_vma (section->sh_addr); printf (_(" Offset: %#08lx Link: %lx (%s)\n"), (unsigned long) section->sh_offset, section->sh_link, - SECTION_NAME (SECTION_HEADER (section->sh_link))); + SECTION_HEADER_INDEX (section->sh_link) + < elf_header.e_shnum + ? SECTION_NAME (SECTION_HEADER (section->sh_link)) + : ""); - edefs = get_data (NULL, file, section->sh_offset, section->sh_size, + edefs = get_data (NULL, file, section->sh_offset, 1, + section->sh_size, _("version definition section")); if (!edefs) break; @@ -5974,9 +6466,13 @@ process_version_sections (FILE *file) printf_vma (section->sh_addr); printf (_(" Offset: %#08lx Link to section: %ld (%s)\n"), (unsigned long) section->sh_offset, section->sh_link, - SECTION_NAME (SECTION_HEADER (section->sh_link))); + SECTION_HEADER_INDEX (section->sh_link) + < elf_header.e_shnum + ? SECTION_NAME (SECTION_HEADER (section->sh_link)) + : ""); - eneed = get_data (NULL, file, section->sh_offset, section->sh_size, + eneed = get_data (NULL, file, section->sh_offset, 1, + section->sh_size, _("version need section")); if (!eneed) break; @@ -6056,8 +6552,15 @@ process_version_sections (FILE *file) Elf_Internal_Shdr *string_sec; long off; + if (SECTION_HEADER_INDEX (section->sh_link) >= elf_header.e_shnum) + break; + link_section = SECTION_HEADER (section->sh_link); - total = section->sh_size / section->sh_entsize; + total = section->sh_size / sizeof (Elf_External_Versym); + + if (SECTION_HEADER_INDEX (link_section->sh_link) + >= elf_header.e_shnum) + break; found = 1; @@ -6065,7 +6568,7 @@ process_version_sections (FILE *file) string_sec = SECTION_HEADER (link_section->sh_link); - strtab = get_data (NULL, file, string_sec->sh_offset, + strtab = get_data (NULL, file, string_sec->sh_offset, 1, string_sec->sh_size, _("version string table")); if (!strtab) break; @@ -6082,7 +6585,7 @@ process_version_sections (FILE *file) off = offset_from_vma (file, version_info[DT_VERSIONTAGIDX (DT_VERSYM)], total * sizeof (short)); - edata = get_data (NULL, file, off, total * sizeof (short), + edata = get_data (NULL, file, off, total, sizeof (short), _("version symbol data")); if (!edata) { @@ -6090,7 +6593,7 @@ process_version_sections (FILE *file) break; } - data = malloc (total * sizeof (short)); + data = cmalloc (total, sizeof (short)); for (cnt = total; cnt --;) data[cnt] = byte_get (edata + cnt * sizeof (short), @@ -6123,8 +6626,10 @@ process_version_sections (FILE *file) check_def = 1; check_need = 1; - if (SECTION_HEADER (symbols[cnt + j].st_shndx)->sh_type - != SHT_NOBITS) + if (SECTION_HEADER_INDEX (symbols[cnt + j].st_shndx) + >= elf_header.e_shnum + || SECTION_HEADER (symbols[cnt + j].st_shndx)->sh_type + != SHT_NOBITS) { if (symbols[cnt + j].st_shndx == SHN_UNDEF) check_def = 0; @@ -6149,7 +6654,7 @@ process_version_sections (FILE *file) Elf_External_Vernaux evna; unsigned long a_off; - get_data (&evn, file, offset, sizeof (evn), + get_data (&evn, file, offset, sizeof (evn), 1, _("version need")); ivn.vn_aux = BYTE_GET (evn.vn_aux); @@ -6160,7 +6665,7 @@ process_version_sections (FILE *file) do { get_data (&evna, file, a_off, sizeof (evna), - _("version need aux (2)")); + 1, _("version need aux (2)")); ivna.vna_next = BYTE_GET (evna.vna_next); ivna.vna_other = BYTE_GET (evna.vna_other); @@ -6201,7 +6706,7 @@ process_version_sections (FILE *file) do { - get_data (&evd, file, offset, sizeof (evd), + get_data (&evd, file, offset, sizeof (evd), 1, _("version def")); ivd.vd_next = BYTE_GET (evd.vd_next); @@ -6221,7 +6726,8 @@ process_version_sections (FILE *file) get_data (&evda, file, offset - ivd.vd_next + ivd.vd_aux, - sizeof (evda), _("version def aux")); + sizeof (evda), 1, + _("version def aux")); ivda.vda_name = BYTE_GET (evda.vda_name); @@ -6269,11 +6775,12 @@ get_symbol_binding (unsigned int binding) case STB_WEAK: return "WEAK"; default: if (binding >= STB_LOPROC && binding <= STB_HIPROC) - sprintf (buff, _(": %d"), binding); + snprintf (buff, sizeof (buff), _(": %d"), + binding); else if (binding >= STB_LOOS && binding <= STB_HIOS) - sprintf (buff, _(": %d"), binding); + snprintf (buff, sizeof (buff), _(": %d"), binding); else - sprintf (buff, _(": %d"), binding); + snprintf (buff, sizeof (buff), _(": %d"), binding); return buff; } } @@ -6304,7 +6811,7 @@ get_symbol_type (unsigned int type) if (elf_header.e_machine == EM_PARISC && type == STT_PARISC_MILLI) return "PARISC_MILLI"; - sprintf (buff, _(": %d"), type); + snprintf (buff, sizeof (buff), _(": %d"), type); } else if (type >= STT_LOOS && type <= STT_HIOS) { @@ -6316,10 +6823,10 @@ get_symbol_type (unsigned int type) return "HP_STUB"; } - sprintf (buff, _(": %d"), type); + snprintf (buff, sizeof (buff), _(": %d"), type); } else - sprintf (buff, _(": %d"), type); + snprintf (buff, sizeof (buff), _(": %d"), type); return buff; } } @@ -6352,6 +6859,9 @@ get_symbol_index_type (unsigned int type) && elf_header.e_machine == EM_IA_64 && elf_header.e_ident[EI_OSABI] == ELFOSABI_HPUX) return "ANSI_COM"; + else if (elf_header.e_machine == EM_X86_64 + && type == SHN_X86_64_LCOMMON) + return "LARGE_COM"; else if (type >= SHN_LOPROC && type <= SHN_HIPROC) sprintf (buff, "PRC[0x%04x]", type); else if (type >= SHN_LOOS && type <= SHN_HIOS) @@ -6366,13 +6876,13 @@ get_symbol_index_type (unsigned int type) return buff; } -static int * -get_dynamic_data (FILE *file, unsigned int number) +static bfd_vma * +get_dynamic_data (FILE *file, unsigned int number, unsigned int ent_size) { unsigned char *e_data; - int *i_data; + bfd_vma *i_data; - e_data = malloc (number * 4); + e_data = cmalloc (number, ent_size); if (e_data == NULL) { @@ -6380,13 +6890,13 @@ get_dynamic_data (FILE *file, unsigned int number) return NULL; } - if (fread (e_data, 4, number, file) != number) + if (fread (e_data, ent_size, number, file) != number) { error (_("Unable to read in dynamic data\n")); return NULL; } - i_data = malloc (number * sizeof (*i_data)); + i_data = cmalloc (number, sizeof (*i_data)); if (i_data == NULL) { @@ -6396,7 +6906,7 @@ get_dynamic_data (FILE *file, unsigned int number) } while (number--) - i_data[number] = byte_get (e_data + number * 4, 4); + i_data[number] = byte_get (e_data + number * ent_size, ent_size); free (e_data); @@ -6408,12 +6918,10 @@ static int process_symbol_table (FILE *file) { Elf_Internal_Shdr *section; - unsigned char nb[4]; - unsigned char nc[4]; - int nbuckets = 0; - int nchains = 0; - int *buckets = NULL; - int *chains = NULL; + bfd_vma nbuckets = 0; + bfd_vma nchains = 0; + bfd_vma *buckets = NULL; + bfd_vma *chains = NULL; if (! do_syms && !do_histogram) return 1; @@ -6421,6 +6929,16 @@ process_symbol_table (FILE *file) if (dynamic_info[DT_HASH] && ((do_using_dynamic && dynamic_strings != NULL) || do_histogram)) { + unsigned char nb[8]; + unsigned char nc[8]; + int hash_ent_size = 4; + + if ((elf_header.e_machine == EM_ALPHA + || elf_header.e_machine == EM_S390 + || elf_header.e_machine == EM_S390_OLD) + && elf_header.e_ident[EI_CLASS] == ELFCLASS64) + hash_ent_size = 8; + if (fseek (file, (archive_file_offset + offset_from_vma (file, dynamic_info[DT_HASH], @@ -6431,23 +6949,23 @@ process_symbol_table (FILE *file) return 0; } - if (fread (nb, sizeof (nb), 1, file) != 1) + if (fread (nb, hash_ent_size, 1, file) != 1) { error (_("Failed to read in number of buckets\n")); return 0; } - if (fread (nc, sizeof (nc), 1, file) != 1) + if (fread (nc, hash_ent_size, 1, file) != 1) { error (_("Failed to read in number of chains\n")); return 0; } - nbuckets = byte_get (nb, 4); - nchains = byte_get (nc, 4); + nbuckets = byte_get (nb, hash_ent_size); + nchains = byte_get (nc, hash_ent_size); - buckets = get_dynamic_data (file, nbuckets); - chains = get_dynamic_data (file, nchains); + buckets = get_dynamic_data (file, nbuckets, hash_ent_size); + chains = get_dynamic_data (file, nchains, hash_ent_size); if (buckets == NULL || chains == NULL) return 0; @@ -6456,8 +6974,8 @@ process_symbol_table (FILE *file) if (do_syms && dynamic_info[DT_HASH] && do_using_dynamic && dynamic_strings != NULL) { - int hn; - int si; + unsigned long hn; + bfd_vma si; printf (_("\nSymbol table for image:\n")); if (is_32bit_elf) @@ -6473,12 +6991,16 @@ process_symbol_table (FILE *file) for (si = buckets[hn]; si < nchains && si > 0; si = chains[si]) { Elf_Internal_Sym *psym; + int n; psym = dynamic_symbols + si; - printf (" %3d %3d: ", si, hn); + n = print_vma (si, DEC_5); + if (n < 5) + fputs (" " + n, stdout); + printf (" %3lu: ", hn); print_vma (psym->st_value, LONG_HEX); - putchar (' ' ); + putchar (' '); print_vma (psym->st_size, DEC_5); printf (" %6s", get_symbol_type (ELF_ST_TYPE (psym->st_info))); @@ -6502,7 +7024,8 @@ process_symbol_table (FILE *file) i++, section++) { unsigned int si; - char *strtab; + char *strtab = NULL; + unsigned long int strtab_size = 0; Elf_Internal_Sym *symtab; Elf_Internal_Sym *psym; @@ -6524,15 +7047,19 @@ process_symbol_table (FILE *file) continue; if (section->sh_link == elf_header.e_shstrndx) - strtab = string_table; - else + { + strtab = string_table; + strtab_size = string_table_length; + } + else if (SECTION_HEADER_INDEX (section->sh_link) < elf_header.e_shnum) { Elf_Internal_Shdr *string_sec; string_sec = SECTION_HEADER (section->sh_link); strtab = get_data (NULL, file, string_sec->sh_offset, - string_sec->sh_size, _("string table")); + 1, string_sec->sh_size, _("string table")); + strtab_size = strtab != NULL ? string_sec->sh_size : 0; } for (si = 0, psym = symtab; @@ -6547,7 +7074,8 @@ process_symbol_table (FILE *file) printf (" %-6s", get_symbol_binding (ELF_ST_BIND (psym->st_info))); printf (" %-3s", get_symbol_visibility (ELF_ST_VISIBILITY (psym->st_other))); printf (" %4s ", get_symbol_index_type (psym->st_shndx)); - print_symbol (25, strtab + psym->st_name); + print_symbol (25, psym->st_name < strtab_size + ? strtab + psym->st_name : ""); if (section->sh_type == SHT_DYNSYM && version_info[DT_VERSIONTAGIDX (DT_VERSYM)] != 0) @@ -6563,12 +7091,14 @@ process_symbol_table (FILE *file) sizeof data + si * sizeof (vers_data)); get_data (&data, file, offset + si * sizeof (vers_data), - sizeof (data), _("version data")); + sizeof (data), 1, _("version data")); vers_data = byte_get (data, 2); - is_nobits = (SECTION_HEADER (psym->st_shndx)->sh_type - == SHT_NOBITS); + is_nobits = (SECTION_HEADER_INDEX (psym->st_shndx) + < elf_header.e_shnum + && SECTION_HEADER (psym->st_shndx)->sh_type + == SHT_NOBITS); check_def = (psym->st_shndx != SHN_UNDEF); @@ -6590,7 +7120,7 @@ process_symbol_table (FILE *file) { unsigned long vna_off; - get_data (&evn, file, offset, sizeof (evn), + get_data (&evn, file, offset, sizeof (evn), 1, _("version need")); ivn.vn_aux = BYTE_GET (evn.vn_aux); @@ -6603,7 +7133,7 @@ process_symbol_table (FILE *file) Elf_External_Vernaux evna; get_data (&evna, file, vna_off, - sizeof (evna), + sizeof (evna), 1, _("version need aux (3)")); ivna.vna_other = BYTE_GET (evna.vna_other); @@ -6625,7 +7155,9 @@ process_symbol_table (FILE *file) if (ivna.vna_other == vers_data) { printf ("@%s (%d)", - strtab + ivna.vna_name, ivna.vna_other); + ivna.vna_name < strtab_size + ? strtab + ivna.vna_name : "", + ivna.vna_other); check_def = 0; } else if (! is_nobits) @@ -6654,7 +7186,7 @@ process_symbol_table (FILE *file) Elf_External_Verdef evd; get_data (&evd, file, offset, sizeof (evd), - _("version def")); + 1, _("version def")); ivd.vd_ndx = BYTE_GET (evd.vd_ndx); ivd.vd_aux = BYTE_GET (evd.vd_aux); @@ -6669,14 +7201,15 @@ process_symbol_table (FILE *file) offset += ivd.vd_aux; get_data (&evda, file, offset, sizeof (evda), - _("version def aux")); + 1, _("version def aux")); ivda.vda_name = BYTE_GET (evda.vda_name); if (psym->st_name != ivda.vda_name) printf ((vers_data & 0x8000) ? "@%s" : "@@%s", - strtab + ivda.vda_name); + ivda.vda_name < strtab_size + ? strtab + ivda.vda_name : ""); } } } @@ -6696,19 +7229,19 @@ process_symbol_table (FILE *file) if (do_histogram && buckets != NULL) { - int *lengths; - int *counts; - int hn; - int si; - int maxlength = 0; - int nzero_counts = 0; - int nsyms = 0; + unsigned long *lengths; + unsigned long *counts; + unsigned long hn; + bfd_vma si; + unsigned long maxlength = 0; + unsigned long nzero_counts = 0; + unsigned long nsyms = 0; - printf (_("\nHistogram for bucket list length (total of %d buckets):\n"), - nbuckets); + printf (_("\nHistogram for bucket list length (total of %lu buckets):\n"), + (unsigned long) nbuckets); printf (_(" Length Number %% of total Coverage\n")); - lengths = calloc (nbuckets, sizeof (int)); + lengths = calloc (nbuckets, sizeof (*lengths)); if (lengths == NULL) { error (_("Out of memory")); @@ -6716,9 +7249,6 @@ process_symbol_table (FILE *file) } for (hn = 0; hn < nbuckets; ++hn) { - if (! buckets[hn]) - continue; - for (si = buckets[hn]; si > 0 && si < nchains; si = chains[si]) { ++nsyms; @@ -6727,7 +7257,7 @@ process_symbol_table (FILE *file) } } - counts = calloc (maxlength + 1, sizeof (int)); + counts = calloc (maxlength + 1, sizeof (*counts)); if (counts == NULL) { error (_("Out of memory")); @@ -6739,13 +7269,14 @@ process_symbol_table (FILE *file) if (nbuckets > 0) { - printf (" 0 %-10d (%5.1f%%)\n", + unsigned long i; + printf (" 0 %-10lu (%5.1f%%)\n", counts[0], (counts[0] * 100.0) / nbuckets); - for (si = 1; si <= maxlength; ++si) + for (i = 1; i <= maxlength; ++i) { - nzero_counts += counts[si] * si; - printf ("%7d %-10d (%5.1f%%) %5.1f%%\n", - si, counts[si], (counts[si] * 100.0) / nbuckets, + nzero_counts += counts[i] * i; + printf ("%7lu %-10lu (%5.1f%%) %5.1f%%\n", + i, counts[i], (counts[i] * 100.0) / nbuckets, (nzero_counts * 100.0) / nsyms); } } @@ -6863,7 +7394,8 @@ dump_section (Elf_Internal_Shdr *section, FILE *file) addr = section->sh_addr; - start = get_data (NULL, file, section->sh_offset, bytes, _("section data")); + start = get_data (NULL, file, section->sh_offset, 1, bytes, + _("section data")); if (!start) return 0; @@ -6932,7 +7464,7 @@ dump_section (Elf_Internal_Shdr *section, FILE *file) static unsigned long int -read_leb128 (unsigned char *data, int *length_return, int sign) +read_leb128 (unsigned char *data, unsigned int *length_return, int sign) { unsigned long int result = 0; unsigned int num_read = 0; @@ -6989,14 +7521,14 @@ reset_state_machine (int is_stmt) state_machine_regs.last_file_entry = 0; } -/* Handled an extend line op. Returns true if this is the end - of sequence. */ +/* Handled an extend line op. + Returns the number of bytes read. */ static int process_extended_line_op (unsigned char *data, int is_stmt, int pointer_size) { unsigned char op_code; - int bytes_read; + unsigned int bytes_read; unsigned int len; unsigned char *name; unsigned long adr; @@ -7051,26 +7583,6 @@ process_extended_line_op (unsigned char *data, int is_stmt, int pointer_size) return len; } -/* Finds section NAME inside FILE and returns a - pointer to it, or NULL upon failure. */ - -static Elf_Internal_Shdr * -find_section (const char * name) -{ - Elf_Internal_Shdr *sec; - unsigned int i; - - for (i = elf_header.e_shnum, sec = section_headers + i - 1; - i; --i, --sec) - if (streq (SECTION_NAME (sec), name)) - break; - - if (i && sec && sec->sh_size != 0) - return sec; - - return NULL; -} - static const char *debug_str_contents; static bfd_vma debug_str_size; @@ -7090,7 +7602,7 @@ load_debug_str (FILE *file) debug_str_size = sec->sh_size; - debug_str_contents = get_data (NULL, file, sec->sh_offset, sec->sh_size, + debug_str_contents = get_data (NULL, file, sec->sh_offset, 1, sec->sh_size, _("debug_str section data")); } @@ -7112,7 +7624,10 @@ fetch_indirect_string (unsigned long offset) return _(""); if (offset > debug_str_size) - return _(""); + { + warn (_("DW_FORM_strp offset too big: %lx\n"), offset); + return _(""); + } return debug_str_contents + offset; } @@ -7136,7 +7651,7 @@ load_debug_loc (FILE *file) debug_loc_size = sec->sh_size; - debug_loc_contents = get_data (NULL, file, sec->sh_offset, sec->sh_size, + debug_loc_contents = get_data (NULL, file, sec->sh_offset, 1, sec->sh_size, _("debug_loc section data")); } @@ -7151,38 +7666,73 @@ free_debug_loc (void) debug_loc_size = 0; } -static const char * debug_range_contents; -static unsigned long debug_range_size; +static const char * debug_range_contents; +static unsigned long debug_range_size; + +static void +load_debug_range (FILE *file) +{ + Elf_Internal_Shdr *sec; + + /* If it is already loaded, do nothing. */ + if (debug_range_contents != NULL) + return; + + /* Locate the .debug_ranges section. */ + sec = find_section (".debug_ranges"); + if (sec == NULL) + return; + + debug_range_size = sec->sh_size; + + debug_range_contents = get_data (NULL, file, sec->sh_offset, 1, sec->sh_size, + _("debug_range section data")); +} + +static void +free_debug_range (void) +{ + if (debug_range_contents == NULL) + return; + + free ((char *) debug_range_contents); + debug_range_contents = NULL; + debug_range_size = 0; +} + +static unsigned char *debug_abbrev_contents; +static unsigned long debug_abbrev_size; static void -load_debug_range (FILE *file) +load_debug_abbrev (FILE *file) { Elf_Internal_Shdr *sec; /* If it is already loaded, do nothing. */ - if (debug_range_contents != NULL) + if (debug_abbrev_contents != NULL) return; - /* Locate the .debug_str section. */ - sec = find_section (".debug_ranges"); + /* Locate the .debug_ranges section. */ + sec = find_section (".debug_abbrev"); if (sec == NULL) return; - debug_range_size = sec->sh_size; + debug_abbrev_size = sec->sh_size; - debug_range_contents = get_data (NULL, file, sec->sh_offset, sec->sh_size, - _("debug_range section data")); + debug_abbrev_contents = get_data (NULL, file, sec->sh_offset, 1, + sec->sh_size, + _("debug_abbrev section data")); } static void -free_debug_range (void) +free_debug_abbrev (void) { - if (debug_range_contents == NULL) + if (debug_abbrev_contents == NULL) return; - free ((char *) debug_range_contents); - debug_range_contents = NULL; - debug_range_size = 0; + free ((char *) debug_abbrev_contents); + debug_abbrev_contents = NULL; + debug_abbrev_size = 0; } /* Apply addends of RELA relocations. */ @@ -7211,8 +7761,10 @@ debug_apply_rela_addends (FILE *file, Elf_Internal_Sym *sym; if (relsec->sh_type != SHT_RELA + || SECTION_HEADER_INDEX (relsec->sh_info) >= elf_header.e_shnum || SECTION_HEADER (relsec->sh_info) != section - || relsec->sh_size == 0) + || relsec->sh_size == 0 + || SECTION_HEADER_INDEX (relsec->sh_link) >= elf_header.e_shnum) continue; if (!slurp_rela_relocs (file, relsec->sh_offset, relsec->sh_size, @@ -7243,7 +7795,7 @@ debug_apply_rela_addends (FILE *file, example of this see the _clz.o binary in libgcc.a. */ && ELF32_ST_TYPE (sym->st_info) != STT_OBJECT) { - warn (_("%s: skipping unexpected symbol type %s in relocation in section .rela%s\n"), + warn (_("skipping unexpected symbol type %s in relocation in section .rela%s\n"), get_symbol_type (ELF32_ST_TYPE (sym->st_info)), SECTION_NAME (section)); continue; @@ -7251,6 +7803,18 @@ debug_apply_rela_addends (FILE *file, } else { + /* In MIPS little-endian objects, r_info isn't really a + 64-bit little-endian value: it has a 32-bit little-endian + symbol index followed by four individual byte fields. + Reorder INFO accordingly. */ + if (elf_header.e_machine == EM_MIPS + && elf_header.e_ident[EI_DATA] != ELFDATA2MSB) + rp->r_info = (((rp->r_info & 0xffffffff) << 32) + | ((rp->r_info >> 56) & 0xff) + | ((rp->r_info >> 40) & 0xff00) + | ((rp->r_info >> 24) & 0xff0000) + | ((rp->r_info >> 8) & 0xff000000)); + sym = symtab + ELF64_R_SYM (rp->r_info); if (ELF64_R_SYM (rp->r_info) != 0 @@ -7386,7 +7950,7 @@ process_abbrev_section (unsigned char *start, unsigned char *end) while (start < end) { - int bytes_read; + unsigned int bytes_read; unsigned long entry; unsigned long tag; unsigned long attribute; @@ -7501,7 +8065,7 @@ get_TAG_name (unsigned long tag) { static char buffer[100]; - sprintf (buffer, _("Unknown TAG value: %lx"), tag); + snprintf (buffer, sizeof (buffer), _("Unknown TAG value: %lx"), tag); return buffer; } } @@ -7537,7 +8101,7 @@ get_FORM_name (unsigned long form) { static char buffer[100]; - sprintf (buffer, _("Unknown FORM value: %lx"), form); + snprintf (buffer, sizeof (buffer), _("Unknown FORM value: %lx"), form); return buffer; } } @@ -7561,7 +8125,7 @@ decode_location_expression (unsigned char * data, unsigned long cu_offset) { unsigned op; - int bytes_read; + unsigned int bytes_read; unsigned long uvalue; unsigned char *end = data + length; int need_frame_base = 0; @@ -7895,120 +8459,6 @@ decode_location_expression (unsigned char * data, return need_frame_base; } -/* Decode a DW_AT_ranges attribute for 64bit DWARF3 . */ - -static void -decode_64bit_range (unsigned long offset, bfd_vma base_address) -{ - const char * start = debug_range_contents + offset; - const char * end = debug_range_contents + debug_range_size; - - do - { - bfd_vma a; - bfd_vma b; - - a = byte_get ((unsigned char *) start, 8); - b = byte_get ((unsigned char *) start + 8, 8); - - if (a == 0xffffffff) - { - base_address = b; - } - else if (a == 0 && b == 0) - break; - else if (a > b) - printf (_(" [corrupt: start > end]")); - else - { - printf (" "); - print_vma (base_address + a, PREFIX_HEX); - printf (" - "); - print_vma (base_address + b, PREFIX_HEX); - printf (", "); - } - - start += 16; - } - while (start < end); -} - -/* Decode a DW_AT_ranges attribute. */ - -static void -decode_range (unsigned long offset, bfd_vma base_address) -{ - const char * start; - const char * end; - - if (offset >= (debug_range_size - 8)) - { - printf (_("[corrupt: offset is outside the .debug_ranges section]")); - return; - } - - /* Since all entries in the .debug_ranges section are pairs of either - 4-byte integers (32-bit DWARF3) or 8-byte integers (64-bit DWARF3) - the offset should always be a multiple of 8 bytes. */ - if (offset % 8) - { - printf (_("[corrupt: offset is not a multiple of 8]")); - return; - } - - start = debug_range_contents + offset; - - if (offset > 0 - /* Be paranoid - check to see if the previous - two words were and end-of-range marker. */ - && (byte_get ((unsigned char *) start - 4, 4) != 0 - || byte_get ((unsigned char *) start - 8, 4) != 0)) - { - printf (_("[corrupt: offset is not at the start of a range]")); - return; - } - - end = debug_range_contents + debug_range_size; - - printf ("("); - do - { - unsigned long a; - unsigned long b; - - a = byte_get ((unsigned char *) start, 4); - b = byte_get ((unsigned char *) start + 4, 4); - - if (a == 0xffffffff) - { - if (b == 0xffffffff) - { - decode_64bit_range (offset, base_address); - return; - } - - base_address = b; - } - else if (a == 0 && b == 0) - break; - else if (a > b) - printf (_("[corrupt: start > end]")); - else - { - if (start > debug_range_contents + offset) - printf (", "); - - printf (_("0x%lx - 0x%lx"), - (unsigned long) base_address + a, - (unsigned long) base_address + b); - } - - start += 8; - } - while (start < end); - printf (")"); -} - /* This structure records the information that we extract from the.debug_info section. */ typedef struct @@ -8021,6 +8471,9 @@ typedef struct int *have_frame_base; unsigned int num_loc_offsets; unsigned int max_loc_offsets; + unsigned long *range_lists; + unsigned int num_range_lists; + unsigned int max_range_lists; } debug_info; @@ -8042,7 +8495,7 @@ read_and_display_attr_value (unsigned long attribute, { unsigned long uvalue = 0; unsigned char *block_start = NULL; - int bytes_read; + unsigned int bytes_read; switch (form) { @@ -8154,7 +8607,7 @@ read_and_display_attr_value (unsigned long attribute, printf (" %lx", uvalue); printf (" %lx", (unsigned long) byte_get (data + 4, 4)); } - if ((do_loc || do_debug_loc) + if ((do_loc || do_debug_loc || do_debug_ranges) && num_debug_info_entries == 0) { if (sizeof (uvalue) == 8) @@ -8218,12 +8671,12 @@ read_and_display_attr_value (unsigned long attribute, break; default: - warn (_("Unrecognized form: %d\n"), form); + warn (_("Unrecognized form: %lu\n"), form); break; } /* For some attributes we can display further information. */ - if ((do_loc || do_debug_loc) + if ((do_loc || do_debug_loc || do_debug_ranges) && num_debug_info_entries == 0) { switch (attribute) @@ -8249,11 +8702,11 @@ read_and_display_attr_value (unsigned long attribute, { max += 1024; debug_info_p->loc_offsets - = xrealloc (debug_info_p->loc_offsets, - max * sizeof (*debug_info_p->loc_offsets)); + = xcrealloc (debug_info_p->loc_offsets, + max, sizeof (*debug_info_p->loc_offsets)); debug_info_p->have_frame_base - = xrealloc (debug_info_p->have_frame_base, - max * sizeof (*debug_info_p->have_frame_base)); + = xcrealloc (debug_info_p->have_frame_base, + max, sizeof (*debug_info_p->have_frame_base)); debug_info_p->max_loc_offsets = max; } debug_info_p->loc_offsets [num] = uvalue; @@ -8267,6 +8720,26 @@ read_and_display_attr_value (unsigned long attribute, debug_info_p->base_address = uvalue; break; + case DW_AT_ranges: + if (form == DW_FORM_data4 || form == DW_FORM_data8) + { + /* Process range list. */ + unsigned int max = debug_info_p->max_range_lists; + unsigned int num = debug_info_p->num_range_lists; + + if (max == 0 || num >= max) + { + max += 1024; + debug_info_p->range_lists + = xcrealloc (debug_info_p->range_lists, + max, sizeof (*debug_info_p->range_lists)); + debug_info_p->max_range_lists = max; + } + debug_info_p->range_lists [num] = uvalue; + debug_info_p->num_range_lists++; + } + break; + default: break; } @@ -8341,6 +8814,7 @@ read_and_display_attr_value (unsigned long attribute, case DW_ATE_unsigned_char: printf ("(unsigned char)"); break; /* DWARF 2.1 value. */ case DW_ATE_imaginary_float: printf ("(imaginary float)"); break; + case DW_ATE_decimal_float: printf ("(decimal float)"); break; default: if (uvalue >= DW_ATE_lo_user && uvalue <= DW_ATE_hi_user) @@ -8447,15 +8921,6 @@ read_and_display_attr_value (unsigned long attribute, break; - case DW_AT_low_pc: - if (need_base_address) - saved_base_address = uvalue; - break; - - case DW_AT_ranges: - decode_range (uvalue, saved_base_address); - break; - default: break; } @@ -8570,7 +9035,8 @@ get_AT_name (unsigned long attribute) { static char buffer[100]; - sprintf (buffer, _("Unknown AT value: %lx"), attribute); + snprintf (buffer, sizeof (buffer), _("Unknown AT value: %lx"), + attribute); return buffer; } } @@ -8612,7 +9078,7 @@ process_debug_info (Elf_Internal_Shdr *section, unsigned char *start, unsigned int unit; unsigned int num_units = 0; - if ((do_loc || do_debug_loc) + if ((do_loc || do_debug_loc || do_debug_ranges) && num_debug_info_entries == 0) { unsigned long length; @@ -8642,8 +9108,8 @@ process_debug_info (Elf_Internal_Shdr *section, unsigned char *start, } /* Then allocate an array to hold the information. */ - debug_information = malloc (num_units * - sizeof (* debug_information)); + debug_information = cmalloc (num_units, + sizeof (* debug_information)); if (debug_information == NULL) { error (_("Not enough memory for a debug info array of %u entries"), @@ -8662,6 +9128,13 @@ process_debug_info (Elf_Internal_Shdr *section, unsigned char *start, load_debug_range (file); } + load_debug_abbrev (file); + if (debug_abbrev_contents == NULL) + { + warn (_("Unable to locate .debug_abbrev section!\n")); + return 0; + } + for (section_begin = start, unit = 0; start < end; unit++) { DWARF2_Internal_CompUnit compunit; @@ -8708,7 +9181,7 @@ process_debug_info (Elf_Internal_Shdr *section, unsigned char *start, compunit.cu_pointer_size = byte_get (hdrptr, 1); hdrptr += 1; - if ((do_loc || do_debug_loc) + if ((do_loc || do_debug_loc || do_debug_ranges) && num_debug_info_entries == 0) { debug_information [unit].cu_offset = cu_offset; @@ -8719,13 +9192,16 @@ process_debug_info (Elf_Internal_Shdr *section, unsigned char *start, debug_information [unit].have_frame_base = NULL; debug_information [unit].max_loc_offsets = 0; debug_information [unit].num_loc_offsets = 0; + debug_information [unit].range_lists = NULL; + debug_information [unit].max_range_lists= 0; + debug_information [unit].num_range_lists = 0; } tags = hdrptr; if (!do_loc) { - printf (_(" Compilation Unit @ %lx:\n"), cu_offset); + printf (_(" Compilation Unit @ offset 0x%lx:\n"), cu_offset); printf (_(" Length: %ld\n"), compunit.cu_length); printf (_(" Version: %d\n"), compunit.cu_version); printf (_(" Abbrev Offset: %ld\n"), compunit.cu_abbrev_offset); @@ -8740,34 +9216,15 @@ process_debug_info (Elf_Internal_Shdr *section, unsigned char *start, free_abbrevs (); - /* Read in the abbrevs used by this compilation unit. */ - { - Elf_Internal_Shdr *sec; - unsigned char *begin; - - /* Locate the .debug_abbrev section and process it. */ - sec = find_section (".debug_abbrev"); - if (sec == NULL) - { - warn (_("Unable to locate .debug_abbrev section!\n")); - return 0; - } - - begin = get_data (NULL, file, sec->sh_offset, sec->sh_size, - _("debug_abbrev section data")); - if (!begin) - return 0; - - process_abbrev_section (begin + compunit.cu_abbrev_offset, - begin + sec->sh_size); - - free (begin); - } + /* Process the abbrevs used by this compilation unit. */ + process_abbrev_section + (debug_abbrev_contents + compunit.cu_abbrev_offset, + debug_abbrev_contents + debug_abbrev_size); level = 0; while (tags < start) { - int bytes_read; + unsigned int bytes_read; unsigned long abbrev_number; abbrev_entry *entry; abbrev_attr *attr; @@ -8811,7 +9268,6 @@ process_debug_info (Elf_Internal_Shdr *section, unsigned char *start, break; case DW_TAG_compile_unit: need_base_address = 1; - saved_base_address = 0; break; case DW_TAG_entry_point: case DW_TAG_inlined_subroutine: @@ -8837,9 +9293,11 @@ process_debug_info (Elf_Internal_Shdr *section, unsigned char *start, } } - /* Set num_debug_info_entries here so that it can be used - to check if we need to proecess .debug_loc section. */ - if ((do_loc || do_debug_loc) + free_debug_abbrev (); + + /* Set num_debug_info_entries here so that it can be used to check if + we need to process .debug_loc and .debug_ranges sections. */ + if ((do_loc || do_debug_loc || do_debug_ranges) && num_debug_info_entries == 0) num_debug_info_entries = num_units; @@ -8923,7 +9381,7 @@ get_debug_info (FILE * file) if (section == NULL) return 0; - start = get_data (NULL, file, section->sh_offset, section->sh_size, + start = get_data (NULL, file, section->sh_offset, 1, section->sh_size, _("extracting information from .debug_info section")); if (start == NULL) return 0; @@ -9014,7 +9472,7 @@ display_debug_lines (Elf_Internal_Shdr *section, /* Get the pointer size from the comp unit associated with this block of line number information. */ pointer_size = get_pointer_size_and_offset_of_comp_unit - (comp_unit, ".debug_lines", NULL); + (comp_unit, ".debug_line", NULL); comp_unit ++; printf (_(" Length: %ld\n"), info.li_length); @@ -9025,7 +9483,9 @@ display_debug_lines (Elf_Internal_Shdr *section, printf (_(" Line Base: %d\n"), info.li_line_base); printf (_(" Line Range: %d\n"), info.li_line_range); printf (_(" Opcode Base: %d\n"), info.li_opcode_base); - printf (_(" (Pointer size: %u)\n"), pointer_size); + printf (_(" (Pointer size: %u)%s\n"), + pointer_size, + warned_about_missing_comp_units ? " [assumed]" : "" ); end_of_sequence = data + info.li_length + initial_length_size; @@ -9070,7 +9530,7 @@ display_debug_lines (Elf_Internal_Shdr *section, while (*data != 0) { unsigned char *name; - int bytes_read; + unsigned int bytes_read; printf (_(" %d\t"), ++state_machine_regs.last_file_entry); name = data; @@ -9097,7 +9557,7 @@ display_debug_lines (Elf_Internal_Shdr *section, { unsigned char op_code; int adv; - int bytes_read; + unsigned int bytes_read; op_code = *data++; @@ -9116,6 +9576,12 @@ display_debug_lines (Elf_Internal_Shdr *section, else switch (op_code) { case DW_LNS_extended_op: + if (pointer_size == 0) + { + warn (_("Extend line ops need a valid pointer size, guessing at 4\n")); + pointer_size = 4; + } + data += process_extended_line_op (data, info.li_default_is_stmt, pointer_size); break; @@ -9345,7 +9811,7 @@ display_debug_macinfo (Elf_Internal_Shdr *section, case DW_MACINFO_define: lineno = read_leb128 (curr, & bytes_read, 0); curr += bytes_read; - string = curr; + string = (char *) curr; curr += strlen (string) + 1; printf (_(" DW_MACINFO_define - lineno : %d macro : %s\n"), lineno, string); @@ -9354,7 +9820,7 @@ display_debug_macinfo (Elf_Internal_Shdr *section, case DW_MACINFO_undef: lineno = read_leb128 (curr, & bytes_read, 0); curr += bytes_read; - string = curr; + string = (char *) curr; curr += strlen (string) + 1; printf (_(" DW_MACINFO_undef - lineno : %d macro : %s\n"), lineno, string); @@ -9366,7 +9832,7 @@ display_debug_macinfo (Elf_Internal_Shdr *section, constant = read_leb128 (curr, & bytes_read, 0); curr += bytes_read; - string = curr; + string = (char *) curr; curr += strlen (string) + 1; printf (_(" DW_MACINFO_vendor_ext - constant : %d string : %s\n"), constant, string); @@ -9529,35 +9995,66 @@ display_debug_loc (Elf_Internal_Shdr *section, { if (start < next) warn (_("There is a hole [0x%lx - 0x%lx] in .debug_loc section.\n"), - start - section_begin, next - section_begin); + (long)(start - section_begin), (long)(next - section_begin)); else if (start > next) warn (_("There is an overlap [0x%lx - 0x%lx] in .debug_loc section.\n"), - start - section_begin, next - section_begin); + (long)(start - section_begin), (long)(next - section_begin)); } start = next; + if (offset >= bytes) + { + warn (_("Offset 0x%lx is bigger than .debug_loc section size.\n"), + offset); + continue; + } + while (1) { + if (start + 2 * pointer_size > section_end) + { + warn (_("Location list starting at offset 0x%lx is not terminated.\n"), + offset); + break; + } + begin = byte_get (start, pointer_size); start += pointer_size; end = byte_get (start, pointer_size); start += pointer_size; if (begin == 0 && end == 0) - break; + { + printf (_(" %8.8lx \n"), offset); + break; + } /* Check base address specifiers. */ if (begin == -1UL && end != -1UL) { base_address = end; - printf (" %8.8lx %8.8lx %8.8lx (base address)\n", + printf (_(" %8.8lx %8.8lx %8.8lx (base address)\n"), offset, begin, end); continue; } + if (start + 2 > section_end) + { + warn (_("Location list starting at offset 0x%lx is not terminated.\n"), + offset); + break; + } + length = byte_get (start, 2); start += 2; + if (start + length > section_end) + { + warn (_("Location list starting at offset 0x%lx is not terminated.\n"), + offset); + break; + } + printf (" %8.8lx %8.8lx %8.8lx (", offset, begin + base_address, end + base_address); need_frame_base = decode_location_expression (start, @@ -9578,8 +10075,6 @@ display_debug_loc (Elf_Internal_Shdr *section, start += length; } - - fputs (_(" \n"), stdout); } } return 1; @@ -9752,91 +10247,149 @@ display_debug_aranges (Elf_Internal_Shdr *section, } static int -display_64bit_debug_ranges (unsigned char * start, unsigned char * end) +display_debug_ranges (Elf_Internal_Shdr *section, + unsigned char *start, + FILE *file ATTRIBUTE_UNUSED) { - bfd_vma base_address = 0; + unsigned char *section_end; + unsigned long bytes; + unsigned char *section_begin = start; + unsigned int num_range_list = 0; + unsigned long last_offset = 0; + unsigned int first = 0; + unsigned int i; + unsigned int j; + int seen_first_offset = 0; + int use_debug_info = 1; + unsigned char *next; - while (start < end) + bytes = section->sh_size; + section_end = start + bytes; + + if (bytes == 0) + { + printf (_("\nThe .debug_ranges section is empty.\n")); + return 0; + } + + get_debug_info (file); + + /* Check the order of range list in .debug_info section. If + offsets of range lists are in the ascending order, we can + use `debug_information' directly. */ + for (i = 0; i < num_debug_info_entries; i++) { - bfd_vma a, b; + unsigned int num; - a = byte_get (start, 8); - b = byte_get (start + 8, 8); + num = debug_information [i].num_range_lists; + num_range_list += num; - if (a == 0xffffffffffffffffLL) - { - printf (_(" set base address to ")); - print_vma (b, PREFIX_HEX); - base_address = b; - } - else if (a == 0 && b == 0) - printf ( _("end of range")); - else if (a > b) - printf (_(" ")); - else if (base_address == 0) - { - printf ("range from base address + "); - print_vma (a, PREFIX_HEX); - printf (" to base address + "); - print_vma (b, PREFIX_HEX); - } - else + /* Check if we can use `debug_information' directly. */ + if (use_debug_info && num != 0) { - printf ("range from "); - print_vma (base_address + a, PREFIX_HEX); - printf (" to "); - print_vma (base_address + b, PREFIX_HEX); - } + if (!seen_first_offset) + { + /* This is the first range list. */ + last_offset = debug_information [i].range_lists [0]; + first = i; + seen_first_offset = 1; + j = 1; + } + else + j = 0; - start += 16; - printf ("\n"); + for (; j < num; j++) + { + if (last_offset > + debug_information [i].range_lists [j]) + { + use_debug_info = 0; + break; + } + last_offset = debug_information [i].range_lists [j]; + } + } } - return 1; -} + if (!use_debug_info) + /* FIXME: Should we handle this case? */ + error (_("Range lists in .debug_info section aren't in ascending order!\n")); -static int -display_debug_ranges (Elf_Internal_Shdr *section, - unsigned char *start, - FILE *file ATTRIBUTE_UNUSED) -{ - unsigned long base_address = 0; - unsigned char *end = start + section->sh_size; + if (!seen_first_offset) + error (_("No range lists in .debug_info section!\n")); - printf (_("The section %s contains:\n\n"), SECTION_NAME (section)); + if (debug_information [first].range_lists [0] != 0) + warn (_("Range lists in .debug_ranges section start at 0x%lx\n"), + debug_information [first].range_lists [0]); - while (start < end) + printf (_("Contents of the .debug_ranges section:\n\n")); + printf (_(" Offset Begin End\n")); + + seen_first_offset = 0; + for (i = first; i < num_debug_info_entries; i++) { - unsigned long a; - unsigned long b; + unsigned long begin; + unsigned long end; + unsigned long offset; + unsigned int pointer_size; + unsigned long base_address; - a = byte_get (start, 4); - b = byte_get (start + 4, 4); + pointer_size = debug_information [i].pointer_size; - if (a == 0xffffffff) + for (j = 0; j < debug_information [i].num_range_lists; j++) { - /* Attempt to handle 64-bit DWARF3 format. This assumes - that in a 32-bit DWARF3 file the base address will - never be 0xffffffff, and that the .debug_ranges section - will never contain a mixture of 32-bit and 64-bit entries. */ - if (b == 0xffffffff) - return display_64bit_debug_ranges (start, end); - - printf (_(" set base address to 0x%lx\n"), b); - base_address = b; - } - else if (a == 0 && b == 0) - printf (_(" end of range\n")); - else if (a > b) - printf (_(" \n")); - else if (base_address == 0) - printf (_(" range from base address + 0x%lx to base address + 0x%lx\n"), a, b); - else - printf (_(" range from 0x%lx to 0x%lx\n"), base_address + a, base_address + b); + offset = debug_information [i].range_lists [j]; + next = section_begin + offset; + base_address = debug_information [i].base_address; - start += 8; - } + if (!seen_first_offset) + seen_first_offset = 1; + else + { + if (start < next) + warn (_("There is a hole [0x%lx - 0x%lx] in .debug_ranges section.\n"), + (long)(start - section_begin), (long)(next - section_begin)); + else if (start > next) + warn (_("There is an overlap [0x%lx - 0x%lx] in .debug_ranges section.\n"), + (long)(start - section_begin), (long)(next - section_begin)); + } + start = next; + + while (1) + { + begin = byte_get (start, pointer_size); + start += pointer_size; + end = byte_get (start, pointer_size); + start += pointer_size; + + if (begin == 0 && end == 0) + { + printf (_(" %8.8lx \n"), offset); + break; + } + /* Check base address specifiers. */ + if (begin == -1UL && end != -1UL) + { + base_address = end; + printf (" %8.8lx %8.8lx %8.8lx (base address)\n", + offset, begin, end); + continue; + } + + printf (" %8.8lx %8.8lx %8.8lx", + offset, begin + base_address, end + base_address); + + if (begin == end) + fputs (_(" (start == end)"), stdout); + else if (begin > end) + fputs (_(" (start > end)"), stdout); + + putchar ('\n'); + } + } + } + putchar ('\n'); return 1; } @@ -9874,8 +10427,8 @@ frame_need_space (Frame_Chunk *fc, int reg) return; fc->ncols = reg + 1; - fc->col_type = xrealloc (fc->col_type, fc->ncols * sizeof (short int)); - fc->col_offset = xrealloc (fc->col_offset, fc->ncols * sizeof (int)); + fc->col_type = xcrealloc (fc->col_type, fc->ncols, sizeof (short int)); + fc->col_offset = xcrealloc (fc->col_offset, fc->ncols, sizeof (int)); while (prev < fc->ncols) { @@ -9956,7 +10509,7 @@ size_of_encoded_value (int encoding) switch (encoding & 0x7) { default: /* ??? */ - case 0: return is_32bit_elf ? 4 : 8; + case 0: return eh_addr_size; case 2: return 2; case 3: return 4; case 4: return 8; @@ -9988,9 +10541,8 @@ display_debug_frames (Elf_Internal_Shdr *section, Frame_Chunk *remembered_state = 0; Frame_Chunk *rs; int is_eh = streq (SECTION_NAME (section), ".eh_frame"); - int length_return; + unsigned int length_return; int max_regs = 0; - int addr_size = is_32bit_elf ? 4 : 8; printf (_("The section %s contains:\n"), SECTION_NAME (section)); @@ -10005,7 +10557,7 @@ display_debug_frames (Elf_Internal_Shdr *section, int need_col_headers = 1; unsigned char *augmentation_data = NULL; unsigned long augmentation_data_len = 0; - int encoded_ptr_size = addr_size; + int encoded_ptr_size = eh_addr_size; int offset_size; int initial_length_size; @@ -10057,8 +10609,8 @@ display_debug_frames (Elf_Internal_Shdr *section, version = *start++; - fc->augmentation = start; - start = strchr (start, '\0') + 1; + fc->augmentation = (char *) start; + start = (unsigned char *) strchr ((char *) start, '\0') + 1; if (fc->augmentation[0] == 'z') { @@ -10078,7 +10630,7 @@ display_debug_frames (Elf_Internal_Shdr *section, } else if (streq (fc->augmentation, "eh")) { - start += addr_size; + start += eh_addr_size; fc->code_factor = LEB (); fc->data_factor = SLEB (); if (version == 1) @@ -10134,7 +10686,7 @@ display_debug_frames (Elf_Internal_Shdr *section, if (augmentation_data_len) { unsigned char *p, *q; - p = fc->augmentation + 1; + p = (unsigned char *) fc->augmentation + 1; q = augmentation_data; while (1) @@ -10172,7 +10724,7 @@ display_debug_frames (Elf_Internal_Shdr *section, if (!cie) { - warn ("Invalid CIE pointer %08lx in FDE at %08lx\n", + warn ("Invalid CIE pointer %08lx in FDE at %p\n", cie_id, saved_start); start = block_end; fc->ncols = 0; @@ -10186,8 +10738,8 @@ display_debug_frames (Elf_Internal_Shdr *section, else { fc->ncols = cie->ncols; - fc->col_type = xmalloc (fc->ncols * sizeof (short int)); - fc->col_offset = xmalloc (fc->ncols * sizeof (int)); + fc->col_type = xcmalloc (fc->ncols, sizeof (short int)); + fc->col_offset = xcmalloc (fc->ncols, sizeof (int)); memcpy (fc->col_type, cie->col_type, fc->ncols * sizeof (short int)); memcpy (fc->col_offset, cie->col_offset, fc->ncols * sizeof (int)); fc->augmentation = cie->augmentation; @@ -10499,8 +11051,8 @@ display_debug_frames (Elf_Internal_Shdr *section, printf (" DW_CFA_remember_state\n"); rs = xmalloc (sizeof (Frame_Chunk)); rs->ncols = fc->ncols; - rs->col_type = xmalloc (rs->ncols * sizeof (short int)); - rs->col_offset = xmalloc (rs->ncols * sizeof (int)); + rs->col_type = xcmalloc (rs->ncols, sizeof (short int)); + rs->col_offset = xcmalloc (rs->ncols, sizeof (int)); memcpy (rs->col_type, fc->col_type, rs->ncols); memcpy (rs->col_offset, fc->col_offset, rs->ncols * sizeof (int)); rs->next = remembered_state; @@ -10558,7 +11110,7 @@ display_debug_frames (Elf_Internal_Shdr *section, if (! do_debug_frames_interp) { printf (" DW_CFA_def_cfa_expression ("); - decode_location_expression (start, addr_size, ul, 0); + decode_location_expression (start, eh_addr_size, ul, 0); printf (")\n"); } fc->cfa_exp = 1; @@ -10571,7 +11123,7 @@ display_debug_frames (Elf_Internal_Shdr *section, if (! do_debug_frames_interp) { printf (" DW_CFA_expression: r%ld (", reg); - decode_location_expression (start, addr_size, ul, 0); + decode_location_expression (start, eh_addr_size, ul, 0); printf (")\n"); } fc->col_type[reg] = DW_CFA_expression; @@ -10592,6 +11144,7 @@ display_debug_frames (Elf_Internal_Shdr *section, case DW_CFA_def_cfa_sf: fc->cfa_reg = LEB (); fc->cfa_offset = SLEB (); + fc->cfa_offset = fc->cfa_offset * fc->data_factor; fc->cfa_exp = 0; if (! do_debug_frames_interp) printf (" DW_CFA_def_cfa_sf: r%d ofs %d\n", @@ -10600,6 +11153,7 @@ display_debug_frames (Elf_Internal_Shdr *section, case DW_CFA_def_cfa_offset_sf: fc->cfa_offset = SLEB (); + fc->cfa_offset = fc->cfa_offset * fc->data_factor; if (! do_debug_frames_interp) printf (" DW_CFA_def_cfa_offset_sf: %d\n", fc->cfa_offset); break; @@ -10671,7 +11225,7 @@ display_debug_not_supported (Elf_Internal_Shdr *section, /* A structure containing the name of a debug section and a pointer to a function that can decode it. */ -struct +static struct { const char *const name; int (*display) (Elf_Internal_Shdr *, unsigned char *, FILE *); @@ -10720,7 +11274,7 @@ display_debug_section (Elf_Internal_Shdr *section, FILE *file) { unsigned char *start; - start = get_data (NULL, file, section->sh_offset, length, + start = get_data (NULL, file, section->sh_offset, 1, length, _("debug section data")); if (start == NULL) { @@ -10846,7 +11400,7 @@ process_mips_specific (FILE *file) size_t cnt; elib = get_data (NULL, file, liblist_offset, - liblistno * sizeof (Elf32_External_Lib), + liblistno, sizeof (Elf32_External_Lib), _("liblist")); if (elib) { @@ -10869,9 +11423,10 @@ process_mips_specific (FILE *file) liblist.l_flags = BYTE_GET (elib[cnt].l_flags); tmp = gmtime (&time); - sprintf (timebuf, "%04u-%02u-%02uT%02u:%02u:%02u", - tmp->tm_year + 1900, tmp->tm_mon + 1, tmp->tm_mday, - tmp->tm_hour, tmp->tm_min, tmp->tm_sec); + snprintf (timebuf, sizeof (timebuf), + "%04u-%02u-%02uT%02u:%02u:%02u", + tmp->tm_year + 1900, tmp->tm_mon + 1, tmp->tm_mday, + tmp->tm_hour, tmp->tm_min, tmp->tm_sec); printf ("%3lu: ", (unsigned long) cnt); if (VALID_DYNAMIC_NAME (liblist.l_name)) @@ -10934,11 +11489,11 @@ process_mips_specific (FILE *file) while (sect->sh_type != SHT_MIPS_OPTIONS) ++sect; - eopt = get_data (NULL, file, options_offset, sect->sh_size, + eopt = get_data (NULL, file, options_offset, 1, sect->sh_size, _("options")); if (eopt) { - iopt = malloc ((sect->sh_size / sizeof (eopt)) * sizeof (*iopt)); + iopt = cmalloc ((sect->sh_size / sizeof (eopt)), sizeof (*iopt)); if (iopt == NULL) { error (_("Out of memory")); @@ -11015,7 +11570,7 @@ process_mips_specific (FILE *file) reginfo.ri_cprmask[1] = BYTE_GET (ereg->ri_cprmask[1]); reginfo.ri_cprmask[2] = BYTE_GET (ereg->ri_cprmask[2]); reginfo.ri_cprmask[3] = BYTE_GET (ereg->ri_cprmask[3]); - reginfo.ri_gp_value = BYTE_GET8 (ereg->ri_gp_value); + reginfo.ri_gp_value = BYTE_GET (ereg->ri_gp_value); printf ("GPR %08lx GP 0x", reginfo.ri_gprmask); @@ -11130,7 +11685,7 @@ process_mips_specific (FILE *file) return 0; } - iconf = malloc (conflictsno * sizeof (*iconf)); + iconf = cmalloc (conflictsno, sizeof (*iconf)); if (iconf == NULL) { error (_("Out of memory")); @@ -11142,7 +11697,7 @@ process_mips_specific (FILE *file) Elf32_External_Conflict *econf32; econf32 = get_data (NULL, file, conflicts_offset, - conflictsno * sizeof (*econf32), _("conflict")); + conflictsno, sizeof (*econf32), _("conflict")); if (!econf32) return 0; @@ -11156,7 +11711,7 @@ process_mips_specific (FILE *file) Elf64_External_Conflict *econf64; econf64 = get_data (NULL, file, conflicts_offset, - conflictsno * sizeof (*econf64), _("conflict")); + conflictsno, sizeof (*econf64), _("conflict")); if (!econf64) return 0; @@ -11196,6 +11751,7 @@ process_gnu_liblist (FILE *file) Elf_Internal_Shdr *section, *string_sec; Elf32_External_Lib *elib; char *strtab; + size_t strtab_size; size_t cnt; unsigned i; @@ -11209,15 +11765,19 @@ process_gnu_liblist (FILE *file) switch (section->sh_type) { case SHT_GNU_LIBLIST: - elib = get_data (NULL, file, section->sh_offset, section->sh_size, + if (SECTION_HEADER_INDEX (section->sh_link) >= elf_header.e_shnum) + break; + + elib = get_data (NULL, file, section->sh_offset, 1, section->sh_size, _("liblist")); if (elib == NULL) break; string_sec = SECTION_HEADER (section->sh_link); - strtab = get_data (NULL, file, string_sec->sh_offset, + strtab = get_data (NULL, file, string_sec->sh_offset, 1, string_sec->sh_size, _("liblist string table")); + strtab_size = string_sec->sh_size; if (strtab == NULL || section->sh_entsize != sizeof (Elf32_External_Lib)) @@ -11247,15 +11807,18 @@ process_gnu_liblist (FILE *file) liblist.l_flags = BYTE_GET (elib[cnt].l_flags); tmp = gmtime (&time); - sprintf (timebuf, "%04u-%02u-%02uT%02u:%02u:%02u", - tmp->tm_year + 1900, tmp->tm_mon + 1, tmp->tm_mday, - tmp->tm_hour, tmp->tm_min, tmp->tm_sec); + snprintf (timebuf, sizeof (timebuf), + "%04u-%02u-%02uT%02u:%02u:%02u", + tmp->tm_year + 1900, tmp->tm_mon + 1, tmp->tm_mday, + tmp->tm_hour, tmp->tm_min, tmp->tm_sec); printf ("%3lu: ", (unsigned long) cnt); if (do_wide) - printf ("%-20s", strtab + liblist.l_name); + printf ("%-20s", liblist.l_name < strtab_size + ? strtab + liblist.l_name : ""); else - printf ("%-20.20s", strtab + liblist.l_name); + printf ("%-20.20s", liblist.l_name < strtab_size + ? strtab + liblist.l_name : ""); printf (" %s %#010lx %-7ld %-7ld\n", timebuf, liblist.l_checksum, liblist.l_version, liblist.l_flags); } @@ -11313,7 +11876,7 @@ get_note_type (unsigned e_type) break; } - sprintf (buff, _("Unknown note type: (0x%08x)"), e_type); + snprintf (buff, sizeof (buff), _("Unknown note type: (0x%08x)"), e_type); return buff; } @@ -11335,7 +11898,7 @@ get_netbsd_elfcore_note_type (unsigned e_type) if (e_type < NT_NETBSDCORE_FIRSTMACH) { - sprintf (buff, _("Unknown note type: (0x%08x)"), e_type); + snprintf (buff, sizeof (buff), _("Unknown note type: (0x%08x)"), e_type); return buff; } @@ -11374,7 +11937,8 @@ get_netbsd_elfcore_note_type (unsigned e_type) } } - sprintf (buff, _("PT_FIRSTMACH+%d"), e_type - NT_NETBSDCORE_FIRSTMACH); + snprintf (buff, sizeof (buff), _("PT_FIRSTMACH+%d"), + e_type - NT_NETBSDCORE_FIRSTMACH); return buff; } @@ -11419,7 +11983,7 @@ process_corefile_note_segment (FILE *file, bfd_vma offset, bfd_vma length) if (length <= 0) return 0; - pnotes = get_data (NULL, file, offset, length, _("notes")); + pnotes = get_data (NULL, file, offset, 1, length, _("notes")); if (!pnotes) return 0; @@ -11446,9 +12010,9 @@ process_corefile_note_segment (FILE *file, bfd_vma offset, bfd_vma length) if (((char *) next) > (((char *) pnotes) + length)) { - warn (_("corrupt note found at offset %x into core notes\n"), - ((char *) external) - ((char *) pnotes)); - warn (_(" type: %x, namesize: %08lx, descsize: %08lx\n"), + warn (_("corrupt note found at offset %lx into core notes\n"), + (long)((char *)external - (char *)pnotes)); + warn (_(" type: %lx, namesize: %08lx, descsize: %08lx\n"), inote.type, inote.namesz, inote.descsz); break; } @@ -11636,9 +12200,9 @@ get_file_header (FILE *file) elf_header.e_type = BYTE_GET (ehdr64.e_type); elf_header.e_machine = BYTE_GET (ehdr64.e_machine); elf_header.e_version = BYTE_GET (ehdr64.e_version); - elf_header.e_entry = BYTE_GET8 (ehdr64.e_entry); - elf_header.e_phoff = BYTE_GET8 (ehdr64.e_phoff); - elf_header.e_shoff = BYTE_GET8 (ehdr64.e_shoff); + elf_header.e_entry = BYTE_GET (ehdr64.e_entry); + elf_header.e_phoff = BYTE_GET (ehdr64.e_phoff); + elf_header.e_shoff = BYTE_GET (ehdr64.e_shoff); elf_header.e_flags = BYTE_GET (ehdr64.e_flags); elf_header.e_ehsize = BYTE_GET (ehdr64.e_ehsize); elf_header.e_phentsize = BYTE_GET (ehdr64.e_phentsize); @@ -11707,17 +12271,22 @@ process_object (char *file_name, FILE *file) if (! process_file_header ()) return 1; - if (! process_section_headers (file) - || ! process_section_groups (file)) + if (! process_section_headers (file)) { - /* Without loaded section headers and section groups we - cannot process lots of things. */ + /* Without loaded section headers we cannot process lots of + things. */ do_unwind = do_version = do_dump = do_arch = 0; if (! do_using_dynamic) do_syms = do_reloc = 0; } + if (! process_section_groups (file)) + { + /* Without loaded section groups we cannot process unwind. */ + do_unwind = 0; + } + if (process_program_headers (file)) process_dynamic_section (file); @@ -11804,11 +12373,15 @@ process_object (char *file_name, FILE *file) if (debug_information) { for (i = 0; i < num_debug_info_entries; i++) - if (!debug_information [i].max_loc_offsets) - { - free (debug_information [i].loc_offsets); - free (debug_information [i].have_frame_base); - } + { + if (!debug_information [i].max_loc_offsets) + { + free (debug_information [i].loc_offsets); + free (debug_information [i].have_frame_base); + } + if (!debug_information [i].max_range_lists) + free (debug_information [i].range_lists); + } free (debug_information); debug_information = NULL; num_debug_info_entries = 0; @@ -11918,7 +12491,7 @@ process_archive (char *file_name, FILE *file) off = strtoul (arhdr.ar_name + 1, NULL, 10); if (off >= longnames_size) { - error (_("%s: invalid archive string table offset %lu\n"), off); + error (_("%s: invalid archive string table offset %lu\n"), file_name, off); ret = 1; break; } @@ -11934,7 +12507,7 @@ process_archive (char *file_name, FILE *file) if (nameend == NULL) { - error (_("%s: bad archive file name\n")); + error (_("%s: bad archive file name\n"), file_name); ret = 1; break; }