X-Git-Url: http://drtracing.org/?a=blobdiff_plain;f=gdb%2Flinux-nat.c;h=c769010f99e250aaf9fa7e667307719d02601ae3;hb=1777feb0fea5ec350a86eecf81f71ccc60d4cf6f;hp=724cdee5032416333b79f73a6c5362aaa9595a5c;hpb=6c95b8df7fef5273da71c34775918c554aae0ea8;p=deliverable%2Fbinutils-gdb.git diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c index 724cdee503..c769010f99 100644 --- a/gdb/linux-nat.c +++ b/gdb/linux-nat.c @@ -1,7 +1,7 @@ /* GNU/Linux native-dependent code common to multiple platforms. - Copyright (C) 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009 - Free Software Foundation, Inc. + Copyright (C) 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, + 2011 Free Software Foundation, Inc. This file is part of GDB. @@ -38,12 +38,12 @@ #include "inf-ptrace.h" #include "auxv.h" #include /* for MAXPATHLEN */ -#include /* for elf_gregset etc. */ +#include /* for elf_gregset etc. */ #include "elf-bfd.h" /* for elfcore_write_* */ #include "gregset.h" /* for gregset */ #include "gdbcore.h" /* for get_exec_file */ #include /* for isdigit */ -#include "gdbthread.h" /* for struct thread_info etc. */ +#include "gdbthread.h" /* for struct thread_info etc. */ #include "gdb_stat.h" /* for struct stat */ #include /* for O_RDONLY */ #include "inf-loop.h" @@ -68,7 +68,7 @@ # endif #endif /* HAVE_PERSONALITY */ -/* This comment documents high-level logic of this file. +/* This comment documents high-level logic of this file. Waiting for events in sync mode =============================== @@ -76,20 +76,21 @@ Waiting for events in sync mode When waiting for an event in a specific thread, we just use waitpid, passing the specific pid, and not passing WNOHANG. -When waiting for an event in all threads, waitpid is not quite good. Prior to +When waiting for an event in all threads, waitpid is not quite good. Prior to version 2.4, Linux can either wait for event in main thread, or in secondary -threads. (2.4 has the __WALL flag). So, if we use blocking waitpid, we might +threads. (2.4 has the __WALL flag). So, if we use blocking waitpid, we might miss an event. The solution is to use non-blocking waitpid, together with sigsuspend. First, we use non-blocking waitpid to get an event in the main -process, if any. Second, we use non-blocking waitpid with the __WCLONED +process, if any. Second, we use non-blocking waitpid with the __WCLONED flag to check for events in cloned processes. If nothing is found, we use sigsuspend to wait for SIGCHLD. When SIGCHLD arrives, it means something happened to a child process -- and SIGCHLD will be delivered both for events in main debugged process and in cloned processes. As soon as we know there's -an event, we get back to calling nonblocking waitpid with and without __WCLONED. +an event, we get back to calling nonblocking waitpid with and without +__WCLONED. Note that SIGCHLD should be blocked between waitpid and sigsuspend calls, -so that we don't miss a signal. If SIGCHLD arrives in between, when it's +so that we don't miss a signal. If SIGCHLD arrives in between, when it's blocked, the signal becomes pending and sigsuspend immediately notices it and returns. @@ -166,7 +167,7 @@ blocked. */ #define PTRACE_SETOPTIONS 0x4200 #define PTRACE_GETEVENTMSG 0x4201 -/* options set using PTRACE_SETOPTIONS */ +/* Options set using PTRACE_SETOPTIONS. */ #define PTRACE_O_TRACESYSGOOD 0x00000001 #define PTRACE_O_TRACEFORK 0x00000002 #define PTRACE_O_TRACEVFORK 0x00000004 @@ -239,7 +240,8 @@ static void show_debug_linux_nat_async (struct ui_file *file, int from_tty, struct cmd_list_element *c, const char *value) { - fprintf_filtered (file, _("Debugging of GNU/Linux async lwp module is %s.\n"), + fprintf_filtered (file, + _("Debugging of GNU/Linux async lwp module is %s.\n"), value); } @@ -250,28 +252,28 @@ show_disable_randomization (struct ui_file *file, int from_tty, struct cmd_list_element *c, const char *value) { #ifdef HAVE_PERSONALITY - fprintf_filtered (file, _("\ -Disabling randomization of debuggee's virtual address space is %s.\n"), + fprintf_filtered (file, + _("Disabling randomization of debuggee's " + "virtual address space is %s.\n"), value); #else /* !HAVE_PERSONALITY */ - fputs_filtered (_("\ -Disabling randomization of debuggee's virtual address space is unsupported on\n\ -this platform.\n"), file); + fputs_filtered (_("Disabling randomization of debuggee's " + "virtual address space is unsupported on\n" + "this platform.\n"), file); #endif /* !HAVE_PERSONALITY */ } static void -set_disable_randomization (char *args, int from_tty, struct cmd_list_element *c) +set_disable_randomization (char *args, int from_tty, + struct cmd_list_element *c) { #ifndef HAVE_PERSONALITY - error (_("\ -Disabling randomization of debuggee's virtual address space is unsupported on\n\ -this platform.")); + error (_("Disabling randomization of debuggee's " + "virtual address space is unsupported on\n" + "this platform.")); #endif /* !HAVE_PERSONALITY */ } -static int linux_parent_pid; - struct simple_pid_list { int pid; @@ -285,8 +287,8 @@ struct simple_pid_list *stopped_pids; static int linux_supports_tracefork_flag = -1; -/* This variable is a tri-state flag: -1 for unknown, 0 if PTRACE_O_TRACESYSGOOD - can not be used, 1 if it can. */ +/* This variable is a tri-state flag: -1 for unknown, 0 if + PTRACE_O_TRACESYSGOOD can not be used, 1 if it can. */ static int linux_supports_tracesysgood_flag = -1; @@ -295,7 +297,7 @@ static int linux_supports_tracesysgood_flag = -1; static int linux_supports_tracevforkdone_flag = -1; -/* Async mode support */ +/* Async mode support. */ /* Zero if the async mode, although enabled, is masked, which means linux_nat_wait should behave as if async mode was off. */ @@ -348,7 +350,8 @@ async_file_mark (void) } static void linux_nat_async (void (*callback) - (enum inferior_event_type event_type, void *context), + (enum inferior_event_type event_type, + void *context), void *context); static int linux_nat_async_mask (int mask); static int kill_lwp (int lwpid, int signo); @@ -370,6 +373,7 @@ static void add_to_pid_list (struct simple_pid_list **listp, int pid, int status) { struct simple_pid_list *new_pid = xmalloc (sizeof (struct simple_pid_list)); + new_pid->pid = pid; new_pid->status = status; new_pid->next = *listp; @@ -377,7 +381,7 @@ add_to_pid_list (struct simple_pid_list **listp, int pid, int status) } static int -pull_pid_from_list (struct simple_pid_list **listp, int pid, int *status) +pull_pid_from_list (struct simple_pid_list **listp, int pid, int *statusp) { struct simple_pid_list **p; @@ -385,7 +389,8 @@ pull_pid_from_list (struct simple_pid_list **listp, int pid, int *status) if ((*p)->pid == pid) { struct simple_pid_list *next = (*p)->next; - *status = (*p)->status; + + *statusp = (*p)->status; xfree (*p); *p = next; return 1; @@ -405,8 +410,6 @@ linux_record_stopped_pid (int pid, int status) static void linux_tracefork_child (void) { - int ret; - ptrace (PTRACE_TRACEME, 0, 0, 0); kill (getpid (), SIGSTOP); fork (); @@ -416,13 +419,13 @@ linux_tracefork_child (void) /* Wrapper function for waitpid which handles EINTR. */ static int -my_waitpid (int pid, int *status, int flags) +my_waitpid (int pid, int *statusp, int flags) { int ret; do { - ret = waitpid (pid, status, flags); + ret = waitpid (pid, statusp, flags); } while (ret == -1 && errno == EINTR); @@ -475,7 +478,8 @@ linux_test_for_tracefork (int original_pid) else if (ret != child_pid) error (_("linux_test_for_tracefork: waitpid: unexpected result %d."), ret); if (! WIFSTOPPED (status)) - error (_("linux_test_for_tracefork: waitpid: unexpected status %d."), status); + error (_("linux_test_for_tracefork: waitpid: unexpected status %d."), + status); ret = ptrace (PTRACE_SETOPTIONS, child_pid, 0, PTRACE_O_TRACEFORK); if (ret != 0) @@ -490,10 +494,11 @@ linux_test_for_tracefork (int original_pid) ret = my_waitpid (child_pid, &status, 0); if (ret != child_pid) - warning (_("linux_test_for_tracefork: failed to wait for killed child")); + warning (_("linux_test_for_tracefork: failed " + "to wait for killed child")); else if (!WIFSIGNALED (status)) - warning (_("linux_test_for_tracefork: unexpected wait status 0x%x from " - "killed child"), status); + warning (_("linux_test_for_tracefork: unexpected " + "wait status 0x%x from killed child"), status); restore_child_signals_mask (&prev_mask); return; @@ -523,7 +528,8 @@ linux_test_for_tracefork (int original_pid) my_waitpid (second_pid, &second_status, 0); ret = ptrace (PTRACE_KILL, second_pid, 0, 0); if (ret != 0) - warning (_("linux_test_for_tracefork: failed to kill second child")); + warning (_("linux_test_for_tracefork: " + "failed to kill second child")); my_waitpid (second_pid, &status, 0); } } @@ -681,9 +687,10 @@ linux_child_follow_fork (struct target_ops *ops, int follow_child) in the foreground, the user will not be able to ctrl-c to get back the terminal, effectively hanging the debug session. */ fprintf_filtered (gdb_stderr, _("\ -Can not resume the parent process over vfork in the foreground while \n\ +Can not resume the parent process over vfork in the foreground while\n\ holding the child stopped. Try \"set detach-on-fork\" or \ \"set schedule-multiple\".\n")); + /* FIXME output string > 80 columns. */ return 1; } @@ -691,7 +698,7 @@ holding the child stopped. Try \"set detach-on-fork\" or \ { struct lwp_info *child_lp = NULL; - /* We're already attached to the parent, by default. */ + /* We're already attached to the parent, by default. */ /* Detach new forked process? */ if (detach_fork) @@ -713,7 +720,8 @@ holding the child stopped. Try \"set detach-on-fork\" or \ { target_terminal_ours (); fprintf_filtered (gdb_stdlog, - "Detaching after fork from child process %d.\n", + "Detaching after fork from " + "child process %d.\n", child_pid); } @@ -769,7 +777,7 @@ holding the child stopped. Try \"set detach-on-fork\" or \ breakpoint. If a "cloned-VM" event was propagated better throughout the core, this wouldn't be required. */ - solib_create_inferior_hook (); + solib_create_inferior_hook (0); } /* Let the thread_db layer learn about this new process. */ @@ -793,6 +801,7 @@ holding the child stopped. Try \"set detach-on-fork\" or \ subsequent child exec or exit is enough to know when does the child stops using the parent's address space. */ parent_inf->waiting_for_vfork_done = detach_fork; + parent_inf->pspace->breakpoints_not_allowed = detach_fork; lp = find_lwp_pid (pid_to_ptid (parent_pid)); gdb_assert (linux_supports_tracefork_flag >= 0); @@ -844,7 +853,8 @@ holding the child stopped. Try \"set detach-on-fork\" or \ if (debug_linux_nat) fprintf_unfiltered (gdb_stdlog, - "LCFF: no VFORK_DONE support, sleeping a bit\n"); + "LCFF: no VFORK_DONE " + "support, sleeping a bit\n"); usleep (10000); @@ -866,7 +876,6 @@ holding the child stopped. Try \"set detach-on-fork\" or \ } else { - struct thread_info *tp; struct inferior *parent_inf, *child_inf; struct lwp_info *lp; struct program_space *parent_pspace; @@ -875,12 +884,14 @@ holding the child stopped. Try \"set detach-on-fork\" or \ { target_terminal_ours (); if (has_vforked) - fprintf_filtered (gdb_stdlog, _("\ -Attaching after process %d vfork to child process %d.\n"), + fprintf_filtered (gdb_stdlog, + _("Attaching after process %d " + "vfork to child process %d.\n"), parent_pid, child_pid); else - fprintf_filtered (gdb_stdlog, _("\ -Attaching after process %d fork to child process %d.\n"), + fprintf_filtered (gdb_stdlog, + _("Attaching after process %d " + "fork to child process %d.\n"), parent_pid, child_pid); } @@ -951,7 +962,7 @@ Attaching after process %d fork to child process %d.\n"), shared libraries, and install the solib event breakpoint. If a "cloned-VM" event was propagated better throughout the core, this wouldn't be required. */ - solib_create_inferior_hook (); + solib_create_inferior_hook (0); } /* Let the thread_db layer learn about this new process. */ @@ -1075,7 +1086,6 @@ restore_child_signals_mask (sigset_t *prev_mask) static int stop_wait_callback (struct lwp_info *lp, void *data); static int linux_thread_alive (ptid_t ptid); static char *linux_child_pid_to_exec_file (int pid); -static int cancel_breakpoint (struct lwp_info *lp); /* Convert wait status STATUS to a string. Used for printing debug @@ -1097,32 +1107,13 @@ status_to_str (int status) } else if (WIFSIGNALED (status)) snprintf (buf, sizeof (buf), "%s (terminated)", - strsignal (WSTOPSIG (status))); + strsignal (WTERMSIG (status))); else snprintf (buf, sizeof (buf), "%d (exited)", WEXITSTATUS (status)); return buf; } -/* Initialize the list of LWPs. Note that this module, contrary to - what GDB's generic threads layer does for its thread list, - re-initializes the LWP lists whenever we mourn or detach (which - doesn't involve mourning) the inferior. */ - -static void -init_lwp_list (void) -{ - struct lwp_info *lp, *lpnext; - - for (lp = lwp_list; lp; lp = lpnext) - { - lpnext = lp->next; - xfree (lp); - } - - lwp_list = NULL; -} - /* Remove all LWPs belong to PID from the lwp list. */ static void @@ -1183,6 +1174,7 @@ add_lwp (ptid_t ptid) lp->waitstatus.kind = TARGET_WAITKIND_IGNORE; lp->ptid = ptid; + lp->core = -1; lp->next = lwp_list; lwp_list = lp; @@ -1238,33 +1230,6 @@ find_lwp_pid (ptid_t ptid) return NULL; } -/* Returns true if PTID matches filter FILTER. FILTER can be the wild - card MINUS_ONE_PTID (all ptid match it); can be a ptid representing - a process (ptid_is_pid returns true), in which case, all lwps of - that give process match, lwps of other process do not; or, it can - represent a specific thread, in which case, only that thread will - match true. PTID must represent an LWP, it can never be a wild - card. */ - -static int -ptid_match (ptid_t ptid, ptid_t filter) -{ - /* Since both parameters have the same type, prevent easy mistakes - from happening. */ - gdb_assert (!ptid_equal (ptid, minus_one_ptid) - && !ptid_equal (ptid, null_ptid)); - - if (ptid_equal (filter, minus_one_ptid)) - return 1; - if (ptid_is_pid (filter) - && ptid_get_pid (ptid) == ptid_get_pid (filter)) - return 1; - else if (ptid_equal (ptid, filter)) - return 1; - - return 0; -} - /* Call CALLBACK with its second argument set to DATA for every LWP in the list. If CALLBACK returns 1 for a particular LWP, return a pointer to the structure describing that LWP immediately. @@ -1695,7 +1660,8 @@ get_pending_status (struct lwp_info *lp, int *status) else if (non_stop && !is_executing (lp->ptid)) { struct thread_info *tp = find_thread_ptid (lp->ptid); - signo = tp->stop_signal; + + signo = tp->suspend.stop_signal; } else if (!non_stop) { @@ -1707,7 +1673,8 @@ get_pending_status (struct lwp_info *lp, int *status) if (GET_LWP (lp->ptid) == GET_LWP (last_ptid)) { struct thread_info *tp = find_thread_ptid (lp->ptid); - signo = tp->stop_signal; + + signo = tp->suspend.stop_signal; } } @@ -1723,8 +1690,9 @@ get_pending_status (struct lwp_info *lp, int *status) else if (!signal_pass_state (signo)) { if (debug_linux_nat) - fprintf_unfiltered (gdb_stdlog, "\ -GPT: lwp %s had signal %s, but it is in no pass state\n", + fprintf_unfiltered (gdb_stdlog, + "GPT: lwp %s had signal %s, " + "but it is in no pass state\n", target_pid_to_str (lp->ptid), target_signal_to_string (signo)); } @@ -1796,7 +1764,6 @@ linux_nat_detach (struct target_ops *ops, char *args, int from_tty) { int pid; int status; - enum target_signal sig; struct lwp_info *main_lwp; pid = GET_PID (inferior_ptid); @@ -1827,10 +1794,11 @@ linux_nat_detach (struct target_ops *ops, char *args, int from_tty) pass it along with PTRACE_DETACH. */ args = alloca (8); sprintf (args, "%d", (int) WSTOPSIG (status)); - fprintf_unfiltered (gdb_stdlog, - "LND: Sending signal %s to %s\n", - args, - target_pid_to_str (main_lwp->ptid)); + if (debug_linux_nat) + fprintf_unfiltered (gdb_stdlog, + "LND: Sending signal %s to %s\n", + args, + target_pid_to_str (main_lwp->ptid)); } delete_lwp (main_lwp->ptid); @@ -1881,12 +1849,15 @@ resume_callback (struct lwp_info *lp, void *data) lp->stopped = 0; lp->step = 0; memset (&lp->siginfo, 0, sizeof (lp->siginfo)); + lp->stopped_by_watchpoint = 0; } else if (lp->stopped && debug_linux_nat) - fprintf_unfiltered (gdb_stdlog, "RC: Not resuming sibling %s (has pending)\n", + fprintf_unfiltered (gdb_stdlog, + "RC: Not resuming sibling %s (has pending)\n", target_pid_to_str (lp->ptid)); else if (debug_linux_nat) - fprintf_unfiltered (gdb_stdlog, "RC: Not resuming sibling %s (not stopped)\n", + fprintf_unfiltered (gdb_stdlog, + "RC: Not resuming sibling %s (not stopped)\n", target_pid_to_str (lp->ptid)); return 0; @@ -1919,7 +1890,8 @@ linux_nat_resume (struct target_ops *ops, "LLR: Preparing to %s %s, %s, inferior_ptid %s\n", step ? "step" : "resume", target_pid_to_str (ptid), - signo ? strsignal (signo) : "0", + (signo != TARGET_SIGNAL_0 + ? strsignal (target_signal_to_host (signo)) : "0"), target_pid_to_str (inferior_ptid)); block_child_signals (&prev_mask); @@ -1928,14 +1900,8 @@ linux_nat_resume (struct target_ops *ops, resume_many = (ptid_equal (minus_one_ptid, ptid) || ptid_is_pid (ptid)); - if (!non_stop) - { - /* Mark the lwps we're resuming as resumed. */ - iterate_over_lwps (minus_one_ptid, resume_clear_callback, NULL); - iterate_over_lwps (ptid, resume_set_callback, NULL); - } - else - iterate_over_lwps (minus_one_ptid, resume_set_callback, NULL); + /* Mark the lwps we're resuming as resumed. */ + iterate_over_lwps (ptid, resume_set_callback, NULL); /* See if it's the current inferior that should be handled specially. */ @@ -1958,7 +1924,7 @@ linux_nat_resume (struct target_ops *ops, if (lp->status && WIFSTOPPED (lp->status)) { - int saved_signo; + enum target_signal saved_signo; struct inferior *inf; inf = find_inferior_pid (ptid_get_pid (lp->ptid)); @@ -1967,7 +1933,7 @@ linux_nat_resume (struct target_ops *ops, /* Defer to common code if we're gaining control of the inferior. */ - if (inf->stop_soon == NO_STOP_QUIETLY + if (inf->control.stop_soon == NO_STOP_QUIETLY && signal_stop_state (saved_signo) == 0 && signal_print_state (saved_signo) == 0 && signal_pass_state (saved_signo) == 1) @@ -2018,40 +1984,44 @@ linux_nat_resume (struct target_ops *ops, linux_ops->to_resume (linux_ops, ptid, step, signo); memset (&lp->siginfo, 0, sizeof (lp->siginfo)); + lp->stopped_by_watchpoint = 0; if (debug_linux_nat) fprintf_unfiltered (gdb_stdlog, "LLR: %s %s, %s (resume event thread)\n", step ? "PTRACE_SINGLESTEP" : "PTRACE_CONT", target_pid_to_str (ptid), - signo ? strsignal (signo) : "0"); + (signo != TARGET_SIGNAL_0 + ? strsignal (target_signal_to_host (signo)) : "0")); restore_child_signals_mask (&prev_mask); if (target_can_async_p ()) target_async (inferior_event_handler, 0); } -/* Issue kill to specified lwp. */ - -static int tkill_failed; +/* Send a signal to an LWP. */ static int kill_lwp (int lwpid, int signo) { - errno = 0; - -/* Use tkill, if possible, in case we are using nptl threads. If tkill - fails, then we are not using nptl threads and we should be using kill. */ + /* Use tkill, if possible, in case we are using nptl threads. If tkill + fails, then we are not using nptl threads and we should be using kill. */ #ifdef HAVE_TKILL_SYSCALL - if (!tkill_failed) - { - int ret = syscall (__NR_tkill, lwpid, signo); - if (errno != ENOSYS) - return ret; - errno = 0; - tkill_failed = 1; - } + { + static int tkill_failed; + + if (!tkill_failed) + { + int ret; + + errno = 0; + ret = syscall (__NR_tkill, lwpid, signo); + if (errno != ENOSYS) + return ret; + tkill_failed = 1; + } + } #endif return kill (lwpid, signo); @@ -2126,7 +2096,8 @@ linux_handle_syscall_trap (struct lwp_info *lp, int stopping) fprintf_unfiltered (gdb_stdlog, "LHST: stopping for %s of syscall %d" " for LWP %ld\n", - lp->syscall_state == TARGET_WAITKIND_SYSCALL_ENTRY + lp->syscall_state + == TARGET_WAITKIND_SYSCALL_ENTRY ? "entry" : "return", syscall_number, GET_LWP (lp->ptid)); @@ -2162,7 +2133,8 @@ linux_handle_syscall_trap (struct lwp_info *lp, int stopping) PT_CONTINUE, can not trigger a syscall trace event. */ if (debug_linux_nat) fprintf_unfiltered (gdb_stdlog, - "LHST: caught syscall event with no syscall catchpoints." + "LHST: caught syscall event " + "with no syscall catchpoints." " %d for LWP %ld, ignoring\n", syscall_number, GET_LWP (lp->ptid)); @@ -2196,7 +2168,6 @@ linux_handle_extended_wait (struct lwp_info *lp, int status, { int pid = GET_LWP (lp->ptid); struct target_waitstatus *ourstatus = &lp->waitstatus; - struct lwp_info *new_lp = NULL; int event = status >> 16; if (event == PTRACE_EVENT_FORK || event == PTRACE_EVENT_VFORK @@ -2260,9 +2231,10 @@ linux_handle_extended_wait (struct lwp_info *lp, int status, ourstatus->kind = TARGET_WAITKIND_VFORKED; else { - struct cleanup *old_chain; + struct lwp_info *new_lp; ourstatus->kind = TARGET_WAITKIND_IGNORE; + new_lp = add_lwp (BUILD_LWP (new_pid, GET_PID (lp->ptid))); new_lp->cloned = 1; new_lp->stopped = 1; @@ -2314,7 +2286,7 @@ linux_handle_extended_wait (struct lwp_info *lp, int status, catchpoints. */ if (!stopping) { - int signo; + enum target_signal signo; new_lp->stopped = 0; new_lp->resumed = 1; @@ -2326,10 +2298,28 @@ linux_handle_extended_wait (struct lwp_info *lp, int status, linux_ops->to_resume (linux_ops, pid_to_ptid (new_pid), 0, signo); } + else + { + if (status != 0) + { + /* We created NEW_LP so it cannot yet contain STATUS. */ + gdb_assert (new_lp->status == 0); + + /* Save the wait status to report later. */ + if (debug_linux_nat) + fprintf_unfiltered (gdb_stdlog, + "LHEW: waitpid of new LWP %ld, " + "saving status %s\n", + (long) GET_LWP (new_lp->ptid), + status_to_str (status)); + new_lp->status = status; + } + } if (debug_linux_nat) fprintf_unfiltered (gdb_stdlog, - "LHEW: Got clone event from LWP %ld, resuming\n", + "LHEW: Got clone event " + "from LWP %ld, resuming\n", GET_LWP (lp->ptid)); linux_ops->to_resume (linux_ops, pid_to_ptid (GET_LWP (lp->ptid)), 0, TARGET_SIGNAL_0); @@ -2359,8 +2349,9 @@ linux_handle_extended_wait (struct lwp_info *lp, int status, if (current_inferior ()->waiting_for_vfork_done) { if (debug_linux_nat) - fprintf_unfiltered (gdb_stdlog, "\ -LHEW: Got expected PTRACE_EVENT_VFORK_DONE from LWP %ld: stopping\n", + fprintf_unfiltered (gdb_stdlog, + "LHEW: Got expected PTRACE_EVENT_" + "VFORK_DONE from LWP %ld: stopping\n", GET_LWP (lp->ptid)); ourstatus->kind = TARGET_WAITKIND_VFORK_DONE; @@ -2368,8 +2359,9 @@ LHEW: Got expected PTRACE_EVENT_VFORK_DONE from LWP %ld: stopping\n", } if (debug_linux_nat) - fprintf_unfiltered (gdb_stdlog, "\ -LHEW: Got PTRACE_EVENT_VFORK_DONE from LWP %ld: resuming\n", + fprintf_unfiltered (gdb_stdlog, + "LHEW: Got PTRACE_EVENT_VFORK_DONE " + "from LWP %ld: resuming\n", GET_LWP (lp->ptid)); ptrace (PTRACE_CONT, GET_LWP (lp->ptid), 0, 0); return 1; @@ -2520,7 +2512,6 @@ static int linux_nat_has_pending_sigint (int pid) { sigset_t pending, blocked, ignored; - int i; linux_proc_pending_signals (pid, &pending, &blocked, &ignored); @@ -2569,6 +2560,111 @@ maybe_clear_ignore_sigint (struct lwp_info *lp) } } +/* Fetch the possible triggered data watchpoint info and store it in + LP. + + On some archs, like x86, that use debug registers to set + watchpoints, it's possible that the way to know which watched + address trapped, is to check the register that is used to select + which address to watch. Problem is, between setting the watchpoint + and reading back which data address trapped, the user may change + the set of watchpoints, and, as a consequence, GDB changes the + debug registers in the inferior. To avoid reading back a stale + stopped-data-address when that happens, we cache in LP the fact + that a watchpoint trapped, and the corresponding data address, as + soon as we see LP stop with a SIGTRAP. If GDB changes the debug + registers meanwhile, we have the cached data we can rely on. */ + +static void +save_sigtrap (struct lwp_info *lp) +{ + struct cleanup *old_chain; + + if (linux_ops->to_stopped_by_watchpoint == NULL) + { + lp->stopped_by_watchpoint = 0; + return; + } + + old_chain = save_inferior_ptid (); + inferior_ptid = lp->ptid; + + lp->stopped_by_watchpoint = linux_ops->to_stopped_by_watchpoint (); + + if (lp->stopped_by_watchpoint) + { + if (linux_ops->to_stopped_data_address != NULL) + lp->stopped_data_address_p = + linux_ops->to_stopped_data_address (¤t_target, + &lp->stopped_data_address); + else + lp->stopped_data_address_p = 0; + } + + do_cleanups (old_chain); +} + +/* See save_sigtrap. */ + +static int +linux_nat_stopped_by_watchpoint (void) +{ + struct lwp_info *lp = find_lwp_pid (inferior_ptid); + + gdb_assert (lp != NULL); + + return lp->stopped_by_watchpoint; +} + +static int +linux_nat_stopped_data_address (struct target_ops *ops, CORE_ADDR *addr_p) +{ + struct lwp_info *lp = find_lwp_pid (inferior_ptid); + + gdb_assert (lp != NULL); + + *addr_p = lp->stopped_data_address; + + return lp->stopped_data_address_p; +} + +/* Commonly any breakpoint / watchpoint generate only SIGTRAP. */ + +static int +sigtrap_is_event (int status) +{ + return WIFSTOPPED (status) && WSTOPSIG (status) == SIGTRAP; +} + +/* SIGTRAP-like events recognizer. */ + +static int (*linux_nat_status_is_event) (int status) = sigtrap_is_event; + +/* Check for SIGTRAP-like events in LP. */ + +static int +linux_nat_lp_status_is_event (struct lwp_info *lp) +{ + /* We check for lp->waitstatus in addition to lp->status, because we can + have pending process exits recorded in lp->status + and W_EXITCODE(0,0) == 0. We should probably have an additional + lp->status_p flag. */ + + return (lp->waitstatus.kind == TARGET_WAITKIND_IGNORE + && linux_nat_status_is_event (lp->status)); +} + +/* Set alternative SIGTRAP-like events recognizer. If + breakpoint_inserted_here_p there then gdbarch_decr_pc_after_break will be + applied. */ + +void +linux_nat_set_status_is_event (struct target_ops *t, + int (*status_is_event) (int status)) +{ + linux_nat_status_is_event = status_is_event; +} + /* Wait until LP is stopped. */ static int @@ -2598,7 +2694,8 @@ stop_wait_callback (struct lwp_info *lp, void *data) ptrace (PTRACE_CONT, GET_LWP (lp->ptid), 0, 0); if (debug_linux_nat) fprintf_unfiltered (gdb_stdlog, - "PTRACE_CONT %s, 0, 0 (%s) (discarding SIGINT)\n", + "PTRACE_CONT %s, 0, 0 (%s) " + "(discarding SIGINT)\n", target_pid_to_str (lp->ptid), errno ? safe_strerror (errno) : "OK"); @@ -2609,7 +2706,7 @@ stop_wait_callback (struct lwp_info *lp, void *data) if (WSTOPSIG (status) != SIGSTOP) { - if (WSTOPSIG (status) == SIGTRAP) + if (linux_nat_status_is_event (status)) { /* If a LWP other than the LWP that we're reporting an event for has hit a GDB breakpoint (as opposed to @@ -2627,7 +2724,9 @@ stop_wait_callback (struct lwp_info *lp, void *data) /* Save the trap's siginfo in case we need it later. */ save_siginfo (lp); - /* Now resume this LWP and get the SIGSTOP event. */ + save_sigtrap (lp); + + /* Now resume this LWP and get the SIGSTOP event. */ errno = 0; ptrace (PTRACE_CONT, GET_LWP (lp->ptid), 0, 0); if (debug_linux_nat) @@ -2642,12 +2741,12 @@ stop_wait_callback (struct lwp_info *lp, void *data) target_pid_to_str (lp->ptid)); } /* Hold this event/waitstatus while we check to see if - there are any more (we still want to get that SIGSTOP). */ + there are any more (we still want to get that SIGSTOP). */ stop_wait_callback (lp, NULL); /* Hold the SIGTRAP for handling by linux_nat_wait. If there's another event, throw it back into the - queue. */ + queue. */ if (lp->status) { if (debug_linux_nat) @@ -2658,14 +2757,14 @@ stop_wait_callback (struct lwp_info *lp, void *data) kill_lwp (GET_LWP (lp->ptid), WSTOPSIG (lp->status)); } - /* Save the sigtrap event. */ + /* Save the sigtrap event. */ lp->status = status; return 0; } else { /* The thread was stopped with a signal other than - SIGSTOP, and didn't accidentally trip a breakpoint. */ + SIGSTOP, and didn't accidentally trip a breakpoint. */ if (debug_linux_nat) { @@ -2674,7 +2773,7 @@ stop_wait_callback (struct lwp_info *lp, void *data) status_to_str ((int) status), target_pid_to_str (lp->ptid)); } - /* Now resume this LWP and get the SIGSTOP event. */ + /* Now resume this LWP and get the SIGSTOP event. */ errno = 0; ptrace (PTRACE_CONT, GET_LWP (lp->ptid), 0, 0); if (debug_linux_nat) @@ -2684,7 +2783,7 @@ stop_wait_callback (struct lwp_info *lp, void *data) errno ? safe_strerror (errno) : "OK"); /* Hold this event/waitstatus while we check to see if - there are any more (we still want to get that SIGSTOP). */ + there are any more (we still want to get that SIGSTOP). */ stop_wait_callback (lp, NULL); /* If the lp->status field is still empty, use it to @@ -2762,8 +2861,7 @@ count_events_callback (struct lwp_info *lp, void *data) gdb_assert (count != NULL); /* Count only resumed LWPs that have a SIGTRAP event pending. */ - if (lp->status != 0 && lp->resumed - && WIFSTOPPED (lp->status) && WSTOPSIG (lp->status) == SIGTRAP) + if (lp->resumed && linux_nat_lp_status_is_event (lp)) (*count)++; return 0; @@ -2789,9 +2887,8 @@ select_event_lwp_callback (struct lwp_info *lp, void *data) gdb_assert (selector != NULL); - /* Select only resumed LWPs that have a SIGTRAP event pending. */ - if (lp->status != 0 && lp->resumed - && WIFSTOPPED (lp->status) && WSTOPSIG (lp->status) == SIGTRAP) + /* Select only resumed LWPs that have a SIGTRAP event pending. */ + if (lp->resumed && linux_nat_lp_status_is_event (lp)) if ((*selector)-- == 0) return 1; @@ -2851,9 +2948,7 @@ cancel_breakpoints_callback (struct lwp_info *lp, void *data) delete or disable the breakpoint, but the LWP will have already tripped on it. */ - if (lp->waitstatus.kind == TARGET_WAITKIND_IGNORE - && lp->status != 0 - && WIFSTOPPED (lp->status) && WSTOPSIG (lp->status) == SIGTRAP + if (linux_nat_lp_status_is_event (lp) && cancel_breakpoint (lp)) /* Throw away the SIGTRAP. */ lp->status = 0; @@ -2970,7 +3065,7 @@ linux_nat_filter_event (int lwpid, int status, int options) } /* Make sure we don't report an event for the exit of an LWP not in - our list, i.e. not part of the current process. This can happen + our list, i.e. not part of the current process. This can happen if we detach from a program we original forked and then it exits. */ if (!WIFSTOPPED (status) && !lp) @@ -3026,9 +3121,13 @@ linux_nat_filter_event (int lwpid, int status, int options) return NULL; } - /* Save the trap's siginfo in case we need it later. */ - if (WIFSTOPPED (status) && WSTOPSIG (status) == SIGTRAP) - save_siginfo (lp); + if (linux_nat_status_is_event (status)) + { + /* Save the trap's siginfo in case we need it later. */ + save_siginfo (lp); + + save_sigtrap (lp); + } /* Check if the thread has exited. */ if ((WIFEXITED (status) || WIFSIGNALED (status)) @@ -3201,8 +3300,20 @@ retry: lp = NULL; status = 0; - /* Make sure there is at least one LWP that has been resumed. */ - gdb_assert (iterate_over_lwps (ptid, resumed_callback, NULL)); + /* Make sure that of those LWPs we want to get an event from, there + is at least one LWP that has been resumed. If there's none, just + bail out. The core may just be flushing asynchronously all + events. */ + if (iterate_over_lwps (ptid, resumed_callback, NULL) == NULL) + { + ourstatus->kind = TARGET_WAITKIND_IGNORE; + + if (debug_linux_nat_async) + fprintf_unfiltered (gdb_stdlog, "LLW: exit (no resumed LWP)\n"); + + restore_child_signals_mask (&prev_mask); + return minus_one_ptid; + } /* First check if there is a LWP with a wait status pending. */ if (pid == -1) @@ -3329,24 +3440,48 @@ retry: lp = linux_nat_filter_event (lwpid, status, options); + /* STATUS is now no longer valid, use LP->STATUS instead. */ + status = 0; + if (lp && ptid_is_pid (ptid) && ptid_get_pid (lp->ptid) != ptid_get_pid (ptid)) { + gdb_assert (lp->resumed); + if (debug_linux_nat) - fprintf (stderr, "LWP %ld got an event %06x, leaving pending.\n", - ptid_get_lwp (lp->ptid), status); + fprintf (stderr, + "LWP %ld got an event %06x, leaving pending.\n", + ptid_get_lwp (lp->ptid), lp->status); if (WIFSTOPPED (lp->status)) { if (WSTOPSIG (lp->status) != SIGSTOP) { - stop_callback (lp, NULL); - - /* Resume in order to collect the sigstop. */ - ptrace (PTRACE_CONT, GET_LWP (lp->ptid), 0, 0); - - stop_wait_callback (lp, NULL); + /* Cancel breakpoint hits. The breakpoint may + be removed before we fetch events from this + process to report to the core. It is best + not to assume the moribund breakpoints + heuristic always handles these cases --- it + could be too many events go through to the + core before this one is handled. All-stop + always cancels breakpoint hits in all + threads. */ + if (non_stop + && linux_nat_lp_status_is_event (lp) + && cancel_breakpoint (lp)) + { + /* Throw away the SIGTRAP. */ + lp->status = 0; + + if (debug_linux_nat) + fprintf (stderr, + "LLW: LWP %ld hit a breakpoint while" + " waiting for another process;" + " cancelled it\n", + ptid_get_lwp (lp->ptid)); + } + lp->stopped = 1; } else { @@ -3354,10 +3489,11 @@ retry: lp->signalled = 0; } } - else if (WIFEXITED (status) || WIFSIGNALED (status)) + else if (WIFEXITED (lp->status) || WIFSIGNALED (lp->status)) { if (debug_linux_nat) - fprintf (stderr, "Process %ld exited while stopping LWPs\n", + fprintf (stderr, + "Process %ld exited while stopping LWPs\n", ptid_get_lwp (lp->ptid)); /* This was the last lwp in the process. Since @@ -3458,7 +3594,7 @@ retry: if (WIFSTOPPED (status)) { - int signo = target_signal_from_host (WSTOPSIG (status)); + enum target_signal signo = target_signal_from_host (WSTOPSIG (status)); struct inferior *inf; inf = find_inferior_pid (ptid_get_pid (lp->ptid)); @@ -3469,7 +3605,7 @@ retry: skip the signal handler, or, if we're gaining control of the inferior. */ if (!lp->step - && inf->stop_soon == NO_STOP_QUIETLY + && inf->control.stop_soon == NO_STOP_QUIETLY && signal_stop_state (signo) == 0 && signal_print_state (signo) == 0 && signal_pass_state (signo) == 1) @@ -3488,7 +3624,9 @@ retry: lp->step ? "PTRACE_SINGLESTEP" : "PTRACE_CONT", target_pid_to_str (lp->ptid), - signo ? strsignal (signo) : "0"); + (signo != TARGET_SIGNAL_0 + ? strsignal (target_signal_to_host (signo)) + : "0")); lp->stopped = 0; goto retry; } @@ -3536,14 +3674,21 @@ retry: starvation. */ if (pid == -1) select_event_lwp (ptid, &lp, &status); - } - /* Now that we've selected our final event LWP, cancel any - breakpoints in other LWPs that have hit a GDB breakpoint. See - the comment in cancel_breakpoints_callback to find out why. */ - iterate_over_lwps (minus_one_ptid, cancel_breakpoints_callback, lp); + /* Now that we've selected our final event LWP, cancel any + breakpoints in other LWPs that have hit a GDB breakpoint. + See the comment in cancel_breakpoints_callback to find out + why. */ + iterate_over_lwps (minus_one_ptid, cancel_breakpoints_callback, lp); - if (WIFSTOPPED (status) && WSTOPSIG (status) == SIGTRAP) + /* In all-stop, from the core's perspective, all LWPs are now + stopped until a new resume action is sent over. */ + iterate_over_lwps (minus_one_ptid, resume_clear_callback, NULL); + } + else + lp->resumed = 0; + + if (linux_nat_status_is_event (status)) { if (debug_linux_nat) fprintf_unfiltered (gdb_stdlog, @@ -3563,9 +3708,57 @@ retry: fprintf_unfiltered (gdb_stdlog, "LLW: exit\n"); restore_child_signals_mask (&prev_mask); + + if (ourstatus->kind == TARGET_WAITKIND_EXITED + || ourstatus->kind == TARGET_WAITKIND_SIGNALLED) + lp->core = -1; + else + lp->core = linux_nat_core_of_thread_1 (lp->ptid); + return lp->ptid; } +/* Resume LWPs that are currently stopped without any pending status + to report, but are resumed from the core's perspective. */ + +static int +resume_stopped_resumed_lwps (struct lwp_info *lp, void *data) +{ + ptid_t *wait_ptid_p = data; + + if (lp->stopped + && lp->resumed + && lp->status == 0 + && lp->waitstatus.kind == TARGET_WAITKIND_IGNORE) + { + gdb_assert (is_executing (lp->ptid)); + + /* Don't bother if there's a breakpoint at PC that we'd hit + immediately, and we're not waiting for this LWP. */ + if (!ptid_match (lp->ptid, *wait_ptid_p)) + { + struct regcache *regcache = get_thread_regcache (lp->ptid); + CORE_ADDR pc = regcache_read_pc (regcache); + + if (breakpoint_inserted_here_p (get_regcache_aspace (regcache), pc)) + return 0; + } + + if (debug_linux_nat) + fprintf_unfiltered (gdb_stdlog, + "RSRL: resuming stopped-resumed LWP %s\n", + target_pid_to_str (lp->ptid)); + + linux_ops->to_resume (linux_ops, pid_to_ptid (GET_LWP (lp->ptid)), + lp->step, TARGET_SIGNAL_0); + lp->stopped = 0; + memset (&lp->siginfo, 0, sizeof (lp->siginfo)); + lp->stopped_by_watchpoint = 0; + } + + return 0; +} + static ptid_t linux_nat_wait (struct target_ops *ops, ptid_t ptid, struct target_waitstatus *ourstatus, @@ -3574,12 +3767,23 @@ linux_nat_wait (struct target_ops *ops, ptid_t event_ptid; if (debug_linux_nat) - fprintf_unfiltered (gdb_stdlog, "linux_nat_wait: [%s]\n", target_pid_to_str (ptid)); + fprintf_unfiltered (gdb_stdlog, + "linux_nat_wait: [%s]\n", target_pid_to_str (ptid)); /* Flush the async file first. */ if (target_can_async_p ()) async_file_flush (); + /* Resume LWPs that are currently stopped without any pending status + to report, but are resumed from the core's perspective. LWPs get + in this state if we find them stopping at a time we're not + interested in reporting the event (target_wait on a + specific_process, for example, see linux_nat_wait_1), and + meanwhile the event became uninteresting. Don't bother resuming + LWPs we're not going to wait for if they'd stop immediately. */ + if (non_stop) + iterate_over_lwps (minus_one_ptid, resume_stopped_resumed_lwps, &ptid); + event_ptid = linux_nat_wait_1 (ops, ptid, ourstatus, target_options); /* If we requested any event, and something came out, assume there @@ -3691,6 +3895,7 @@ linux_nat_kill (struct target_ops *ops) else { ptid_t ptid = pid_to_ptid (ptid_get_pid (inferior_ptid)); + /* Stop all threads before killing them, since ptrace requires that the thread is stopped to sucessfully PTRACE_KILL. */ iterate_over_lwps (ptid, stop_callback, NULL); @@ -3929,9 +4134,7 @@ read_mapping (FILE *mapfile, regions in the inferior for a corefile. */ static int -linux_nat_find_memory_regions (int (*func) (CORE_ADDR, - unsigned long, - int, int, int, void *), void *obfd) +linux_nat_find_memory_regions (find_memory_region_ftype func, void *obfd) { int pid = PIDGET (inferior_ptid); char mapsfilename[MAXPATHLEN]; @@ -3939,7 +4142,6 @@ linux_nat_find_memory_regions (int (*func) (CORE_ADDR, long long addr, endaddr, size, offset, inode; char permissions[8], device[8], filename[MAXPATHLEN]; int read, write, exec; - int ret; struct cleanup *cleanup; /* Compose the filename for the /proc memory map, and open it. */ @@ -3966,8 +4168,8 @@ linux_nat_find_memory_regions (int (*func) (CORE_ADDR, if (info_verbose) { fprintf_filtered (gdb_stdout, - "Save segment, %lld bytes at %s (%c%c%c)", - size, paddress (target_gdbarch, addr), + "Save segment, %s bytes at %s (%c%c%c)", + plongest (size), paddress (target_gdbarch, addr), read ? 'r' : ' ', write ? 'w' : ' ', exec ? 'x' : ' '); if (filename[0]) @@ -3986,7 +4188,7 @@ linux_nat_find_memory_regions (int (*func) (CORE_ADDR, static int find_signalled_thread (struct thread_info *info, void *data) { - if (info->stop_signal != TARGET_SIGNAL_0 + if (info->suspend.stop_signal != TARGET_SIGNAL_0 && ptid_get_pid (info->ptid) == ptid_get_pid (inferior_ptid)) return 1; @@ -4000,7 +4202,7 @@ find_stop_signal (void) iterate_over_threads (find_signalled_thread, NULL); if (info) - return info->stop_signal; + return info->suspend.stop_signal; else return TARGET_SIGNAL_0; } @@ -4013,8 +4215,6 @@ linux_nat_do_thread_registers (bfd *obfd, ptid_t ptid, char *note_data, int *note_size, enum target_signal stop_signal) { - gdb_gregset_t gregs; - gdb_fpregset_t fpregs; unsigned long lwp = ptid_get_lwp (ptid); struct gdbarch *gdbarch = target_gdbarch; struct regcache *regcache = get_thread_arch_regcache (ptid, gdbarch); @@ -4032,21 +4232,6 @@ linux_nat_do_thread_registers (bfd *obfd, ptid_t ptid, core_regset_p = gdbarch_regset_from_core_section_p (gdbarch); sect_list = gdbarch_core_regset_sections (gdbarch); - if (core_regset_p - && (regset = gdbarch_regset_from_core_section (gdbarch, ".reg", - sizeof (gregs))) != NULL - && regset->collect_regset != NULL) - regset->collect_regset (regset, regcache, -1, - &gregs, sizeof (gregs)); - else - fill_gregset (regcache, &gregs, -1); - - note_data = (char *) elfcore_write_prstatus (obfd, - note_data, - note_size, - lwp, - stop_signal, &gregs); - /* The loop below uses the new struct core_regset_section, which stores the supported section names and sizes for the core file. Note that note PRSTATUS needs to be treated specially. But the other notes are @@ -4054,12 +4239,6 @@ linux_nat_do_thread_registers (bfd *obfd, ptid_t ptid, if (core_regset_p && sect_list != NULL) while (sect_list->sect_name != NULL) { - /* .reg was already handled above. */ - if (strcmp (sect_list->sect_name, ".reg") == 0) - { - sect_list++; - continue; - } regset = gdbarch_regset_from_core_section (gdbarch, sect_list->sect_name, sect_list->size); @@ -4067,12 +4246,17 @@ linux_nat_do_thread_registers (bfd *obfd, ptid_t ptid, gdb_regset = xmalloc (sect_list->size); regset->collect_regset (regset, regcache, -1, gdb_regset, sect_list->size); - note_data = (char *) elfcore_write_register_note (obfd, - note_data, - note_size, - sect_list->sect_name, - gdb_regset, - sect_list->size); + + if (strcmp (sect_list->sect_name, ".reg") == 0) + note_data = (char *) elfcore_write_prstatus + (obfd, note_data, note_size, + lwp, target_signal_to_host (stop_signal), + gdb_regset); + else + note_data = (char *) elfcore_write_register_note + (obfd, note_data, note_size, + sect_list->sect_name, gdb_regset, + sect_list->size); xfree (gdb_regset); sect_list++; } @@ -4082,10 +4266,26 @@ linux_nat_do_thread_registers (bfd *obfd, ptid_t ptid, the new support, the code below should be deleted. */ else { + gdb_gregset_t gregs; + gdb_fpregset_t fpregs; + + if (core_regset_p + && (regset = gdbarch_regset_from_core_section (gdbarch, ".reg", + sizeof (gregs))) + != NULL && regset->collect_regset != NULL) + regset->collect_regset (regset, regcache, -1, + &gregs, sizeof (gregs)); + else + fill_gregset (regcache, &gregs, -1); + + note_data = (char *) elfcore_write_prstatus + (obfd, note_data, note_size, lwp, target_signal_to_host (stop_signal), + &gregs); + if (core_regset_p && (regset = gdbarch_regset_from_core_section (gdbarch, ".reg2", - sizeof (fpregs))) != NULL - && regset->collect_regset != NULL) + sizeof (fpregs))) + != NULL && regset->collect_regset != NULL) regset->collect_regset (regset, regcache, -1, &fpregs, sizeof (fpregs)); else @@ -4230,6 +4430,7 @@ static char * linux_spu_make_corefile_notes (bfd *obfd, char *note_data, int *note_size) { struct linux_spu_corefile_data args; + args.obfd = obfd; args.note_data = note_data; args.note_size = note_size; @@ -4247,13 +4448,11 @@ static char * linux_nat_make_corefile_notes (bfd *obfd, int *note_size) { struct linux_nat_corefile_thread_data thread_args; - struct cleanup *old_chain; /* The variable size must be >= sizeof (prpsinfo_t.pr_fname). */ char fname[16] = { '\0' }; /* The variable size must be >= sizeof (prpsinfo_t.pr_psargs). */ char psargs[80] = { '\0' }; char *note_data = NULL; - ptid_t current_ptid = inferior_ptid; ptid_t filter = pid_to_ptid (ptid_get_pid (inferior_ptid)); gdb_byte *auxv; int auxv_len; @@ -4323,7 +4522,6 @@ linux_nat_info_proc_cmd (char *args, int from_tty) int cwd_f = 1; int exe_f = 1; int mappings_f = 0; - int environ_f = 0; int status_f = 0; int stat_f = 0; int all = 0; @@ -4371,7 +4569,7 @@ linux_nat_info_proc_cmd (char *args, int from_tty) } else { - /* [...] (future options here) */ + /* [...] (future options here). */ } argv++; } @@ -4389,6 +4587,7 @@ linux_nat_info_proc_cmd (char *args, int from_tty) if ((procfile = fopen (fname1, "r")) != NULL) { struct cleanup *cleanup = make_cleanup_fclose (procfile); + if (fgets (buffer, sizeof (buffer), procfile)) printf_filtered ("cmdline = '%s'\n", buffer); else @@ -4484,6 +4683,7 @@ linux_nat_info_proc_cmd (char *args, int from_tty) if ((procfile = fopen (fname1, "r")) != NULL) { struct cleanup *cleanup = make_cleanup_fclose (procfile); + while (fgets (buffer, sizeof (buffer), procfile) != NULL) puts_filtered (buffer); do_cleanups (cleanup); @@ -4540,8 +4740,8 @@ linux_nat_info_proc_cmd (char *args, int from_tty) if (fscanf (procfile, "%ld ", <mp) > 0) printf_filtered (_("stime, children: %ld\n"), ltmp); if (fscanf (procfile, "%ld ", <mp) > 0) - printf_filtered (_("jiffies remaining in current time slice: %ld\n"), - ltmp); + printf_filtered (_("jiffies remaining in current " + "time slice: %ld\n"), ltmp); if (fscanf (procfile, "%ld ", <mp) > 0) printf_filtered (_("'nice' value: %ld\n"), ltmp); if (fscanf (procfile, "%lu ", <mp) > 0) @@ -4551,13 +4751,14 @@ linux_nat_info_proc_cmd (char *args, int from_tty) printf_filtered (_("jiffies until next SIGALRM: %lu\n"), (unsigned long) ltmp); if (fscanf (procfile, "%ld ", <mp) > 0) - printf_filtered (_("start time (jiffies since system boot): %ld\n"), - ltmp); + printf_filtered (_("start time (jiffies since " + "system boot): %ld\n"), ltmp); if (fscanf (procfile, "%lu ", <mp) > 0) printf_filtered (_("Virtual memory size: %lu\n"), (unsigned long) ltmp); if (fscanf (procfile, "%lu ", <mp) > 0) - printf_filtered (_("Resident set size: %lu\n"), (unsigned long) ltmp); + printf_filtered (_("Resident set size: %lu\n"), + (unsigned long) ltmp); if (fscanf (procfile, "%lu ", <mp) > 0) printf_filtered (_("rlim: %lu\n"), (unsigned long) ltmp); if (fscanf (procfile, "%lu ", <mp) > 0) @@ -4566,11 +4767,11 @@ linux_nat_info_proc_cmd (char *args, int from_tty) printf_filtered (_("End of text: 0x%lx\n"), ltmp); if (fscanf (procfile, "%lu ", <mp) > 0) printf_filtered (_("Start of stack: 0x%lx\n"), ltmp); -#if 0 /* Don't know how architecture-dependent the rest is... - Anyway the signal bitmap info is available from "status". */ - if (fscanf (procfile, "%lu ", <mp) > 0) /* FIXME arch? */ +#if 0 /* Don't know how architecture-dependent the rest is... + Anyway the signal bitmap info is available from "status". */ + if (fscanf (procfile, "%lu ", <mp) > 0) /* FIXME arch? */ printf_filtered (_("Kernel stack pointer: 0x%lx\n"), ltmp); - if (fscanf (procfile, "%lu ", <mp) > 0) /* FIXME arch? */ + if (fscanf (procfile, "%lu ", <mp) > 0) /* FIXME arch? */ printf_filtered (_("Kernel instr pointer: 0x%lx\n"), ltmp); if (fscanf (procfile, "%ld ", <mp) > 0) printf_filtered (_("Pending signals bitmap: 0x%lx\n"), ltmp); @@ -4580,7 +4781,7 @@ linux_nat_info_proc_cmd (char *args, int from_tty) printf_filtered (_("Ignored signals bitmap: 0x%lx\n"), ltmp); if (fscanf (procfile, "%ld ", <mp) > 0) printf_filtered (_("Catched signals bitmap: 0x%lx\n"), ltmp); - if (fscanf (procfile, "%lu ", <mp) > 0) /* FIXME arch? */ + if (fscanf (procfile, "%lu ", <mp) > 0) /* FIXME arch? */ printf_filtered (_("wchan (system call): 0x%lx\n"), ltmp); #endif do_cleanups (cleanup); @@ -4774,11 +4975,11 @@ add_line_to_sigset (const char *line, sigset_t *sigs) SIGS to match. */ void -linux_proc_pending_signals (int pid, sigset_t *pending, sigset_t *blocked, sigset_t *ignored) +linux_proc_pending_signals (int pid, sigset_t *pending, + sigset_t *blocked, sigset_t *ignored) { FILE *procfile; char buffer[MAXPATHLEN], fname[MAXPATHLEN]; - int signum; struct cleanup *cleanup; sigemptyset (pending); @@ -4815,8 +5016,8 @@ linux_proc_pending_signals (int pid, sigset_t *pending, sigset_t *blocked, sigse static LONGEST linux_nat_xfer_osdata (struct target_ops *ops, enum target_object object, - const char *annex, gdb_byte *readbuf, - const gdb_byte *writebuf, ULONGEST offset, LONGEST len) + const char *annex, gdb_byte *readbuf, + const gdb_byte *writebuf, ULONGEST offset, LONGEST len) { /* We make the process list snapshot when the object starts to be read. */ @@ -4828,6 +5029,45 @@ linux_nat_xfer_osdata (struct target_ops *ops, enum target_object object, gdb_assert (object == TARGET_OBJECT_OSDATA); + if (!annex) + { + if (offset == 0) + { + if (len_avail != -1 && len_avail != 0) + obstack_free (&obstack, NULL); + len_avail = 0; + buf = NULL; + obstack_init (&obstack); + obstack_grow_str (&obstack, "\n"); + + obstack_xml_printf (&obstack, + "" + "processes" + "" + "Listing of all processes" + ""); + + obstack_grow_str0 (&obstack, "\n"); + buf = obstack_finish (&obstack); + len_avail = strlen (buf); + } + + if (offset >= len_avail) + { + /* Done. Get rid of the obstack. */ + obstack_free (&obstack, NULL); + buf = NULL; + len_avail = 0; + return 0; + } + + if (len > len_avail - offset) + len = len_avail - offset; + memcpy (readbuf, buf + offset, len); + + return len; + } + if (strcmp (annex, "processes") != 0) return 0; @@ -4836,7 +5076,7 @@ linux_nat_xfer_osdata (struct target_ops *ops, enum target_object object, if (offset == 0) { if (len_avail != -1 && len_avail != 0) - obstack_free (&obstack, NULL); + obstack_free (&obstack, NULL); len_avail = 0; buf = NULL; obstack_init (&obstack); @@ -4844,60 +5084,63 @@ linux_nat_xfer_osdata (struct target_ops *ops, enum target_object object, dirp = opendir ("/proc"); if (dirp) - { - struct dirent *dp; - while ((dp = readdir (dirp)) != NULL) - { - struct stat statbuf; - char procentry[sizeof ("/proc/4294967295")]; - - if (!isdigit (dp->d_name[0]) - || NAMELEN (dp) > sizeof ("4294967295") - 1) - continue; - - sprintf (procentry, "/proc/%s", dp->d_name); - if (stat (procentry, &statbuf) == 0 - && S_ISDIR (statbuf.st_mode)) - { - char *pathname; - FILE *f; - char cmd[MAXPATHLEN + 1]; - struct passwd *entry; - - pathname = xstrprintf ("/proc/%s/cmdline", dp->d_name); - entry = getpwuid (statbuf.st_uid); - - if ((f = fopen (pathname, "r")) != NULL) - { - size_t len = fread (cmd, 1, sizeof (cmd) - 1, f); - if (len > 0) - { - int i; - for (i = 0; i < len; i++) - if (cmd[i] == '\0') - cmd[i] = ' '; - cmd[len] = '\0'; - - obstack_xml_printf ( - &obstack, - "" - "%s" - "%s" - "%s" - "", - dp->d_name, - entry ? entry->pw_name : "?", - cmd); - } - fclose (f); - } - - xfree (pathname); - } - } - - closedir (dirp); - } + { + struct dirent *dp; + + while ((dp = readdir (dirp)) != NULL) + { + struct stat statbuf; + char procentry[sizeof ("/proc/4294967295")]; + + if (!isdigit (dp->d_name[0]) + || NAMELEN (dp) > sizeof ("4294967295") - 1) + continue; + + sprintf (procentry, "/proc/%s", dp->d_name); + if (stat (procentry, &statbuf) == 0 + && S_ISDIR (statbuf.st_mode)) + { + char *pathname; + FILE *f; + char cmd[MAXPATHLEN + 1]; + struct passwd *entry; + + pathname = xstrprintf ("/proc/%s/cmdline", dp->d_name); + entry = getpwuid (statbuf.st_uid); + + if ((f = fopen (pathname, "r")) != NULL) + { + size_t len = fread (cmd, 1, sizeof (cmd) - 1, f); + + if (len > 0) + { + int i; + + for (i = 0; i < len; i++) + if (cmd[i] == '\0') + cmd[i] = ' '; + cmd[len] = '\0'; + + obstack_xml_printf ( + &obstack, + "" + "%s" + "%s" + "%s" + "", + dp->d_name, + entry ? entry->pw_name : "?", + cmd); + } + fclose (f); + } + + xfree (pathname); + } + } + + closedir (dirp); + } obstack_grow_str0 (&obstack, "\n"); buf = obstack_finish (&obstack); @@ -4928,7 +5171,7 @@ linux_xfer_partial (struct target_ops *ops, enum target_object object, LONGEST xfer; if (object == TARGET_OBJECT_AUXV) - return procfs_xfer_auxv (ops, object, annex, readbuf, writebuf, + return memory_xfer_auxv (ops, object, annex, readbuf, writebuf, offset, len); if (object == TARGET_OBJECT_OSDATA) @@ -5243,7 +5486,6 @@ linux_nat_stop_lwp (struct lwp_info *lwp, void *data) { if (!lwp->stopped) { - int pid, status; ptid_t ptid = lwp->ptid; if (debug_linux_nat) @@ -5276,12 +5518,13 @@ linux_nat_stop_lwp (struct lwp_info *lwp, void *data) if (debug_linux_nat) { if (find_thread_ptid (lwp->ptid)->stop_requested) - fprintf_unfiltered (gdb_stdlog, "\ -LNSL: already stopped/stop_requested %s\n", + fprintf_unfiltered (gdb_stdlog, + "LNSL: already stopped/stop_requested %s\n", target_pid_to_str (lwp->ptid)); else - fprintf_unfiltered (gdb_stdlog, "\ -LNSL: already stopped/no stop_requested yet %s\n", + fprintf_unfiltered (gdb_stdlog, + "LNSL: already stopped/no " + "stop_requested yet %s\n", target_pid_to_str (lwp->ptid)); } } @@ -5311,6 +5554,116 @@ linux_nat_close (int quitting) linux_ops->to_close (quitting); } +/* When requests are passed down from the linux-nat layer to the + single threaded inf-ptrace layer, ptids of (lwpid,0,0) form are + used. The address space pointer is stored in the inferior object, + but the common code that is passed such ptid can't tell whether + lwpid is a "main" process id or not (it assumes so). We reverse + look up the "main" process id from the lwp here. */ + +struct address_space * +linux_nat_thread_address_space (struct target_ops *t, ptid_t ptid) +{ + struct lwp_info *lwp; + struct inferior *inf; + int pid; + + pid = GET_LWP (ptid); + if (GET_LWP (ptid) == 0) + { + /* An (lwpid,0,0) ptid. Look up the lwp object to get at the + tgid. */ + lwp = find_lwp_pid (ptid); + pid = GET_PID (lwp->ptid); + } + else + { + /* A (pid,lwpid,0) ptid. */ + pid = GET_PID (ptid); + } + + inf = find_inferior_pid (pid); + gdb_assert (inf != NULL); + return inf->aspace; +} + +int +linux_nat_core_of_thread_1 (ptid_t ptid) +{ + struct cleanup *back_to; + char *filename; + FILE *f; + char *content = NULL; + char *p; + char *ts = 0; + int content_read = 0; + int i; + int core; + + filename = xstrprintf ("/proc/%d/task/%ld/stat", + GET_PID (ptid), GET_LWP (ptid)); + back_to = make_cleanup (xfree, filename); + + f = fopen (filename, "r"); + if (!f) + { + do_cleanups (back_to); + return -1; + } + + make_cleanup_fclose (f); + + for (;;) + { + int n; + + content = xrealloc (content, content_read + 1024); + n = fread (content + content_read, 1, 1024, f); + content_read += n; + if (n < 1024) + { + content[content_read] = '\0'; + break; + } + } + + make_cleanup (xfree, content); + + p = strchr (content, '('); + + /* Skip ")". */ + if (p != NULL) + p = strchr (p, ')'); + if (p != NULL) + p++; + + /* If the first field after program name has index 0, then core number is + the field with index 36. There's no constant for that anywhere. */ + if (p != NULL) + p = strtok_r (p, " ", &ts); + for (i = 0; p != NULL && i != 36; ++i) + p = strtok_r (NULL, " ", &ts); + + if (p == NULL || sscanf (p, "%d", &core) == 0) + core = -1; + + do_cleanups (back_to); + + return core; +} + +/* Return the cached value of the processor core for thread PTID. */ + +int +linux_nat_core_of_thread (struct target_ops *ops, ptid_t ptid) +{ + struct lwp_info *info = find_lwp_pid (ptid); + + if (info) + return info->core; + return -1; +} + void linux_nat_add_target (struct target_ops *t) { @@ -5333,6 +5686,9 @@ linux_nat_add_target (struct target_ops *t) t->to_thread_alive = linux_nat_thread_alive; t->to_pid_to_str = linux_nat_pid_to_str; t->to_has_thread_control = tc_schedlock; + t->to_thread_address_space = linux_nat_thread_address_space; + t->to_stopped_by_watchpoint = linux_nat_stopped_by_watchpoint; + t->to_stopped_data_address = linux_nat_stopped_data_address; t->to_can_async_p = linux_nat_can_async_p; t->to_is_async_p = linux_nat_is_async_p; @@ -5348,6 +5704,8 @@ linux_nat_add_target (struct target_ops *t) t->to_supports_multi_process = linux_nat_supports_multi_process; + t->to_core_of_thread = linux_nat_core_of_thread; + /* We don't change the stratum; this target will sit at process_stratum and thread_db will set at thread_stratum. This is a little strange, since this is a multi-threaded-capable @@ -5397,8 +5755,6 @@ extern initialize_file_ftype _initialize_linux_nat; void _initialize_linux_nat (void) { - sigset_t mask; - add_info ("proc", linux_nat_info_proc_cmd, _("\ Show /proc process information about any running process.\n\ Specify any process id, or use the program being debugged by default.\n\