X-Git-Url: http://drtracing.org/?a=blobdiff_plain;f=ld%2Ftestsuite%2Flib%2Fld-lib.exp;h=a481ce72199eda0ed670d11e37b1599bf21169d4;hb=241e64e3b42cd9eba514b8e0ad2ef39a337f10a5;hp=65a5ffb116a351630fb5493f84d865ce89500ab4;hpb=a747059210fbec5946a62431e8774190059d901d;p=deliverable%2Fbinutils-gdb.git diff --git a/ld/testsuite/lib/ld-lib.exp b/ld/testsuite/lib/ld-lib.exp index 65a5ffb116..2e7d368ce9 100644 --- a/ld/testsuite/lib/ld-lib.exp +++ b/ld/testsuite/lib/ld-lib.exp @@ -1,6 +1,5 @@ # Support routines for LD testsuite. -# Copyright 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, -# 2004, 2005, 2006, 2007, 2008, 2009 Free Software Foundation, Inc. +# Copyright (C) 1994-2018 Free Software Foundation, Inc. # # This file is part of the GNU Binutils. # @@ -19,6 +18,47 @@ # Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, # MA 02110-1301, USA. +proc load_common_lib { name } { + global srcdir + load_file $srcdir/../../binutils/testsuite/lib/$name +} + +load_common_lib binutils-common.exp + +# Returns 1 if the gcc for the target is at least version MAJOR.MINOR +# Returns 0 otherwise. +# +proc at_least_gcc_version { major minor } { + global CC + + if {![info exists CC]} { + set CC [find_gcc] + } + if { $CC == "" } { + return 0 + } + set state [remote_exec host $CC --version] + if { [lindex $state 0] != 0 } { + return 0; + } + set tmp "[lindex $state 1]\n" + # Look for (eg) 4.6.1 in the version output. + set ver_re "\[^\\.0-9\]+(\[1-9\]\[0-9\]*)\\.(\[0-9\]+)(?:\\.\[0-9\]+)?" + regexp $ver_re $tmp fred maj min + verbose "gcc version: $tmp" + if { ![info exists maj] || ![info exists min] } then { + perror "can't decipher gcc version number, fix the framework!" + return 0 + } + verbose "major gcc version is $maj, want at least $major" + if { $maj == $major } then { + verbose "minor gcc version is $min, want at least $minor" + return [expr $min >= $minor] + } else { + return [expr $maj > $major] + } +} + # Extract and print the version number of ld. # proc default_ld_version { ld } { @@ -43,14 +83,51 @@ proc default_ld_version { ld } { proc run_host_cmd { prog command } { global link_output + global gcc_B_opt + global ld_L_opt + global gcc_ld_B_opt_tested + global ld if { ![is_remote host] && [which "$prog"] == 0 } then { perror "$prog does not exist" return 0 } - verbose -log "$prog $command" - set status [remote_exec host [concat sh -c [list "$prog $command 2>&1"]] "" "/dev/null" "ld.tmp"] + # If we are compiling with gcc, we want to add gcc_B_opt and + # ld_L_opt to flags. However, if $prog already has -B options, + # which might be the case when running gcc out of a build + # directory, we want our -B options to come first. + set gccexe $prog + set gccparm [string first " " $gccexe] + set gccflags "" + if { $gccparm > 0 } then { + set gccflags [string range $gccexe $gccparm end] + set gccexe [string range $gccexe 0 $gccparm] + set prog $gccexe + } + set gccexe [string replace $gccexe 0 [string last "/" $gccexe] ""] + if {[string match "*cc*" $gccexe] || [string match "*++*" $gccexe]} then { + set gccflags "$gcc_B_opt $gccflags $ld_L_opt" + if {![info exists gcc_ld_B_opt_tested]} { + set gcc_ld_B_opt_tested 1 + set ld_version_message [run_host_cmd "$ld" "--version"] + set gcc_ld_version_message [run_host_cmd "$prog" "$gccflags -Wl,--version"] + if {[string first $ld_version_message $gcc_ld_version_message] < 0} { + perror "************************************************************************" + perror "Your compiler driver ignores -B when choosing ld." + perror "You will not be testing the new ld in many of the following tests." + set gcc_ld_version [run_host_cmd "$prog" "$gccflags --print-prog-name=ld"] + if {![string match "" $gcc_ld_version] && ![string match "ld" $gcc_ld_version]} { + + perror "It seems you will be testing $gcc_ld_version instead." + } + perror "************************************************************************" + } + } + } + + verbose -log "$prog $gccflags $command" + set status [remote_exec host [concat sh -c [list "$prog $gccflags $command 2>&1"]] "" "/dev/null" "ld.tmp"] remote_upload host "ld.tmp" set link_output [file_contents "ld.tmp"] regsub "\n$" $link_output "" link_output @@ -70,8 +147,12 @@ proc run_host_cmd { prog command } { proc run_host_cmd_yesno { prog command } { global exec_output + global errcnt warncnt set exec_output [prune_warnings [run_host_cmd "$prog" "$command"]] + # Ignore error and warning. + set errcnt 0 + set warncnt 0 if [string match "" $exec_output] then { return 1; } @@ -136,59 +217,18 @@ proc big_or_little_endian {} { return $flags } -# Link a program using ld. +# Link a program using ld # proc default_ld_link { ld target objects } { - global HOSTING_EMU - global HOSTING_CRT0 - global HOSTING_LIBS - global LIBS - global host_triplet - global link_output - global exec_output - - set objs "$HOSTING_CRT0 $objects" - set libs "$LIBS $HOSTING_LIBS" - - if [is_endian_output_format $objects] then { - set flags [big_or_little_endian] - } else { - set flags "" - } - - remote_file host delete $target - - return [run_host_cmd_yesno "$ld" "$HOSTING_EMU $flags -o $target $objs $libs"] -} - -# Link a program using ld, without including any libraries. -# -proc default_ld_simple_link { ld target objects } { global host_triplet - global gcc_ld_flag global exec_output + set flags "" if [is_endian_output_format $objects] then { set flags [big_or_little_endian] - } else { - set flags "" - } - - # If we are compiling with gcc, we want to add gcc_ld_flag to - # flags. Rather than determine this in some complex way, we guess - # based on the name of the compiler. - set ldexe $ld - set ldparm [string first " " $ld] - if { $ldparm > 0 } then { - set ldexe [string range $ld 0 $ldparm] - } - set ldexe [string replace $ldexe 0 [string last "/" $ldexe] ""] - if {[string match "*gcc*" $ldexe] || [string match "*++*" $ldexe]} then { - set flags "$gcc_ld_flag $flags" } remote_file host delete $target - set exec_output [run_host_cmd "$ld" "$flags -o $target $objects"] set exec_output [prune_warnings $exec_output] @@ -196,11 +236,7 @@ proc default_ld_simple_link { ld target objects } { # symbol, since the default linker script might use ENTRY. regsub -all "(^|\n)(\[^\n\]*: warning: cannot find entry symbol\[^\n\]*\n?)" $exec_output "\\1" exec_output - if [string match "" $exec_output] then { - return 1 - } else { - return 0 - } + return [string match "" $exec_output] } # Compile an object using cc. @@ -211,7 +247,7 @@ proc default_ld_compile { cc source object } { global srcdir global subdir global host_triplet - global gcc_gas_flag + global gcc_B_opt set cc_prog $cc if {[llength $cc_prog] > 1} then { @@ -225,11 +261,12 @@ proc default_ld_compile { cc source object } { remote_file build delete "$object" remote_file host delete "$object" - set flags "-I$srcdir/$subdir" + set flags "$gcc_B_opt -I$srcdir/$subdir" - # If we are compiling with gcc, we want to add gcc_gas_flag to - # flags. Rather than determine this in some complex way, we guess - # based on the name of the compiler. + # If we are compiling with gcc, we want to add gcc_B_opt to flags. + # However, if $prog already has -B options, which might be the + # case when running gcc out of a build directory, we want our -B + # options to come first. set ccexe $cc set ccparm [string first " " $cc] set ccflags "" @@ -238,29 +275,36 @@ proc default_ld_compile { cc source object } { set ccexe [string range $cc 0 $ccparm] set cc $ccexe } - set ccexe [string replace $ccexe 0 [string last "/" $ccexe] ""] - if {[string match "*gcc*" $ccexe] || [string match "*++*" $ccexe]} then { - set flags "$gcc_gas_flag $flags" - } + set ccexe [string replace $ccexe 0 [string last "/" $ccexe] ""] if {[string match "*++*" $ccexe]} { - set flags "$flags $CXXFLAGS" + append flags " $CXXFLAGS" } else { - set flags "$flags $CFLAGS" + append flags " $CFLAGS" + } + + if [board_info [target_info name] exists cflags] { + append flags " [board_info [target_info name] cflags]" } if [board_info [target_info name] exists multilib_flags] { append flags " [board_info [target_info name] multilib_flags]" } - verbose -log "$cc $flags $ccflags -c $source -o $object" + set cmd "$cc $flags $ccflags -c $source -o $object" + verbose -log "$cmd" - set status [remote_exec host [concat sh -c [list "$cc $flags $ccflags -c $source -o $object 2>&1"]] "" "/dev/null" "ld.tmp"] + set status [remote_exec host [concat sh -c [list "$cmd 2>&1"]] "" "/dev/null" "ld.tmp"] remote_upload host "ld.tmp" set exec_output [file_contents "ld.tmp"] remote_file build delete "ld.tmp" remote_file host delete "ld.tmp" set exec_output [prune_warnings $exec_output] + # Versions of gcc up to and including pre-release gcc-7, at least on + # some targets, generate .section directives with incorrect type. + # Ignore warnings from the assembler about this. + regsub -all "(^|\n)\[^\n\]*: ignoring incorrect section type \[^\n\]*" $exec_output "" exec_output + regsub -all "^\[^\n\]*: Assembler messages:\n" $exec_output "" exec_output if [string match "" $exec_output] then { if {![file exists $object]} then { regexp ".*/(\[^/\]*)$" $source all dobj @@ -284,14 +328,16 @@ proc default_ld_compile { cc source object } { # Assemble a file. # -proc default_ld_assemble { as source object } { +proc default_ld_assemble { as in_flags source object } { global ASFLAGS global host_triplet + global srcdir + global subdir if ![info exists ASFLAGS] { set ASFLAGS "" } - set flags [big_or_little_endian] - set exec_output [run_host_cmd "$as" "$flags $ASFLAGS -o $object $source"] + set flags "[big_or_little_endian] -I$srcdir/$subdir" + set exec_output [run_host_cmd "$as" "$flags $in_flags $ASFLAGS -o $object $source"] set exec_output [prune_warnings $exec_output] if [string match "" $exec_output] then { return 1 @@ -354,18 +400,20 @@ proc default_ld_nm { nm nmflags object } { # Define various symbols needed when not linking against all # target libs. -proc ld_simple_link_defsyms {} { +proc ld_link_defsyms {} { set flags "--defsym __stack_chk_fail=0" # ARM targets call __gccmain - if {[istarget arm*-*-*] || \ - [istarget strongarm*-*-*] || \ - [istarget xscale*-*-*] || \ - [istarget thumb-*-*] } { + if {[istarget arm*-*-*]} { append flags " --defsym __gccmain=0" } + # Windows targets need __main, some prefixed with underscore. + if {[istarget *-*-cygwin* ] || [istarget *-*-mingw*]} { + append flags " --defsym __main=0 --defsym ___main=0" + } + # PowerPC EABI code calls __eabi. if {[istarget powerpc*-*-eabi*] || [istarget powerpc*-*-rtems*]} { append flags " --defsym __eabi=0" @@ -377,7 +425,7 @@ proc ld_simple_link_defsyms {} { } # m6811/m6812 code has references to soft registers. - if {[istarget m6811-*-*] || [istarget m6812-*-*]} { + if {[istarget m6811-*-*] || [istarget m6812-*-*] || [istarget m68hc1*-*-*]} { append flags " --defsym _.frame=0 --defsym _.d1=0 --defsym _.d2=0" append flags " --defsym _.d3=0 --defsym _.d4=0" append flags " --defsym _.tmp=0 --defsym _.xy=0 --defsym _.z=0" @@ -393,180 +441,7 @@ proc ld_simple_link_defsyms {} { return $flags } -# True if the object format is known to be ELF. -# -proc is_elf_format {} { - if { ![istarget *-*-sysv4*] \ - && ![istarget *-*-unixware*] \ - && ![istarget *-*-elf*] \ - && ![istarget *-*-eabi*] \ - && ![istarget hppa*64*-*-hpux*] \ - && ![istarget *-*-linux*] \ - && ![istarget frv-*-uclinux*] \ - && ![istarget bfin-*-uclinux] \ - && ![istarget *-*-irix5*] \ - && ![istarget *-*-irix6*] \ - && ![istarget *-*-netbsd*] \ - && ![istarget *-*-solaris2*] } { - return 0 - } - - if { [istarget *-*-linux*aout*] \ - || [istarget *-*-linux*oldld*] } { - return 0 - } - - if { ![istarget *-*-netbsdelf*] \ - && ([istarget *-*-netbsd*aout*] \ - || [istarget *-*-netbsdpe*] \ - || [istarget arm*-*-netbsd*] \ - || [istarget sparc-*-netbsd*] \ - || [istarget i*86-*-netbsd*] \ - || [istarget m68*-*-netbsd*] \ - || [istarget vax-*-netbsd*] \ - || [istarget ns32k-*-netbsd*]) } { - return 0 - } - return 1 -} - -# True if the object format is known to be 64-bit ELF. -# -proc is_elf64 { binary_file } { - global READELF - global READELFFLAGS - - set readelf_size "" - catch "exec $READELF $READELFFLAGS -h $binary_file > readelf.out" got - - if ![string match "" $got] then { - return 0 - } - - if { ![regexp "\n\[ \]*Class:\[ \]*ELF(\[0-9\]+)\n" \ - [file_contents readelf.out] nil readelf_size] } { - return 0 - } - - if { $readelf_size == "64" } { - return 1 - } - - return 0 -} - -# True if the object format is known to be a.out. -# -proc is_aout_format {} { - if { [istarget *-*-*\[ab\]out*] \ - || [istarget *-*-linux*oldld*] \ - || [istarget *-*-msdos*] \ - || [istarget arm-*-netbsd] \ - || [istarget i?86-*-netbsd] \ - || [istarget i?86-*-mach*] \ - || [istarget i?86-*-vsta] \ - || [istarget pdp11-*-*] \ - || [istarget m68*-ericsson-ose] \ - || [istarget m68k-hp-bsd*] \ - || [istarget m68*-*-hpux*] \ - || [istarget m68*-*-netbsd] \ - || [istarget m68*-*-netbsd*4k*] \ - || [istarget m68k-sony-*] \ - || [istarget m68*-sun-sunos\[34\]*] \ - || [istarget m68*-wrs-vxworks*] \ - || [istarget ns32k-*-*] \ - || [istarget sparc*-*-netbsd] \ - || [istarget sparc-sun-sunos4*] \ - || [istarget vax-dec-ultrix*] \ - || [istarget vax-*-netbsd] } { - return 1 - } - return 0 -} - -# True if the object format is known to be PE COFF. -# -proc is_pecoff_format {} { - if { ![istarget *-*-mingw*] \ - && ![istarget *-*-cygwin*] \ - && ![istarget *-*-cegcc*] \ - && ![istarget *-*-pe*] } { - return 0 - } - - return 1 -} - -# Compares two files line-by-line. -# Returns differences if exist. -# Returns null if file(s) cannot be opened. -# -proc simple_diff { file_1 file_2 } { - global target - - set eof -1 - set differences 0 - - if [file exists $file_1] then { - set file_a [open $file_1 r] - } else { - warning "$file_1 doesn't exist" - return - } - - if [file exists $file_2] then { - set file_b [open $file_2 r] - } else { - fail "$file_2 doesn't exist" - return - } - - verbose "# Diff'ing: $file_1 $file_2\n" 2 - - while { [gets $file_a line] != $eof } { - if [regexp "^#.*$" $line] then { - continue - } else { - lappend list_a $line - } - } - close $file_a - - while { [gets $file_b line] != $eof } { - if [regexp "^#.*$" $line] then { - continue - } else { - lappend list_b $line - } - } - close $file_b - - for { set i 0 } { $i < [llength $list_a] } { incr i } { - set line_a [lindex $list_a $i] - set line_b [lindex $list_b $i] - - verbose "\t$file_1: $i: $line_a\n" 3 - verbose "\t$file_2: $i: $line_b\n" 3 - if [string compare $line_a $line_b] then { - verbose -log "\t$file_1: $i: $line_a\n" - verbose -log "\t$file_2: $i: $line_b\n" - - fail "Test: $target" - return - } - } - - if { [llength $list_a] != [llength $list_b] } { - fail "Test: $target" - return - } - - if $differences<1 then { - pass "Test: $target" - } -} - -# run_dump_test FILE +# run_dump_test FILE (optional:) EXTRA_OPTIONS # Copied from gas testsuite, tweaked and further extended. # # Assemble a .s file, then run some utility on it and check the output. @@ -591,6 +466,12 @@ proc simple_diff { file_1 file_2 } { # list ends with the first line that doesn't match the above syntax # (hmm, not great for error detection). # +# The optional EXTRA_OPTIONS argument to `run_dump_test' is a list of +# two-element lists. The first element of each is an option name, and +# the second additional arguments to be added on to the end of the +# option list as given in FILE.d. (If omitted, no additional options +# are added.) +# # The interesting options are: # # name: TEST-NAME @@ -610,6 +491,11 @@ proc simple_diff { file_1 file_2 } { # ld_after_inputfiles: FLAGS # Similar to "ld", but put after all input files. # +# objcopy_objects: FLAGS +# Run objcopy with the specified flags after assembling any source +# that has the special marker RUN_OBJCOPY in the source specific +# flags. +# # objcopy_linked_file: FLAGS # Run objcopy on the linked file with the specified flags. # This lets you transform the linked file using objcopy, before the @@ -622,6 +508,7 @@ proc simple_diff { file_1 file_2 } { # run_dump_test will guess which program to run by seeing which of # the flags options below is present. # +# readelf: FLAGS # objdump: FLAGS # nm: FLAGS # objcopy: FLAGS @@ -638,41 +525,94 @@ proc simple_diff { file_1 file_2 } { # More than one "source" directive can be given, which is useful # when testing linking. # +# dump: DUMP +# Match against DUMP.d. If omitted, this defaults to FILE.d. This +# is useful if several .d files differ by options only. Options are +# always read from FILE.d. +# # xfail: TARGET # The test is expected to fail on TARGET. This may occur more than # once. # # target: TARGET -# Only run the test for TARGET. This may occur more than once; the -# target being tested must match at least one. You may provide target -# name "cfi" for any target supporting the CFI statements. +# Only run the test for TARGET. +# You may provide target name "cfi" for any target supporting the +# CFI statements. You may provide target name "shared" for any +# target supporting shared libraries. Otherwise TARGET is called +# as a TCL procedure if surrounded by square brackets, or passed +# to "istarget" if not. +# This may occur more than once; the target being tested must match +# at least one. Otherwise the test will be marked unsupported. +# +# alltargets: TARGET +# Only run the test for TARGET. +# The syntax for TARGET is as with 'target'. +# This may occur more than once; the target being tested must match +# all of them. Otherwise the test will be marked unsupported. # # notarget: TARGET -# Do not run the test for TARGET. This may occur more than once; -# the target being tested must not match any of them. +# Do not run the test for TARGET. +# The syntax for TARGET is as with 'target'. +# This may occur more than once; the target being tested must not +# match any of them. Otherwise the test will be marked unsupported. +# +# skip: TARGET +# anyskip: TARGET +# noskip: TARGET +# These are exactly the same as "notarget", "alltargets" and +# "target" respectively, except that they do nothing at all if the +# check fails. They should only be used in groups, to construct a +# single test which is run on all targets but with variant options +# or expected output on some targets. (For example, see +# gas/arm/inst.d and gas/arm/wince_inst.d.) # # error: REGEX # An error with message matching REGEX must be emitted for the test -# to pass. The PROG, objdump, nm and objcopy options have no -# meaning and need not supplied if this is present. +# to pass. The PROG, readelf, objdump, nm and objcopy options have +# no meaning and need not be supplied if this is present. Multiple +# "error" directives append to the expected linker error message. +# +# error_output: FILE +# Means the same as 'error', except the regular expression lines +# are contains in FILE. # # warning: REGEX # Expect a linker warning matching REGEX. It is an error to issue -# both "error" and "warning". +# both "error" and "warning". Multiple "warning" directives +# append to the expected linker warning message. +# +# warning_output: FILE +# Means the same as 'warning', except the regular expression +# lines are contains in FILE. +# +# map: FILE +# Adding this option will cause the linker to generate a linker +# map file, using the -Map=MAPFILE command line option. If +# there is no -Map=MAPFILE in the 'ld: FLAGS' then one will be +# added to the linker command line. The contents of the +# generated MAPFILE are then compared against the regexp lines +# in FILE using `regexp_diff' (see below for details). # # Each option may occur at most once unless otherwise mentioned. # # After the option lines come regexp lines. `run_dump_test' calls # `regexp_diff' to compare the output of the dumping tool against the -# regexps in FILE.d. `regexp_diff' is defined later in this file; see -# further comments there. +# regexps in FILE.d. `regexp_diff' is defined in binutils-common.exp; +# see further comments there. # -proc run_dump_test { name } { +proc run_dump_test { name {extra_options {}} } { global subdir srcdir global OBJDUMP NM AS OBJCOPY READELF LD global OBJDUMPFLAGS NMFLAGS ASFLAGS OBJCOPYFLAGS READELFFLAGS LDFLAGS global host_triplet runtests global env verbose + global ld_elf_shared_opt + + if { [is_elf_format] && [check_shared_lib_support] } { + set ld_extra_opt "$ld_elf_shared_opt" + } else { + set ld_extra_opt "" + } if [string match "*/*" $name] { set file $name @@ -694,12 +634,17 @@ proc run_dump_test { name } { set dumpfile tmpdir/dump.out set run_ld 0 set run_objcopy 0 + set objfile_names {} set opts(as) {} set opts(ld) {} set opts(ld_after_inputfiles) {} set opts(xfail) {} set opts(target) {} + set opts(alltargets) {} set opts(notarget) {} + set opts(skip) {} + set opts(anyskip) {} + set opts(noskip) {} set opts(objdump) {} set opts(nm) {} set opts(objcopy) {} @@ -707,10 +652,14 @@ proc run_dump_test { name } { set opts(name) {} set opts(PROG) {} set opts(source) {} + set opts(dump) {} set opts(error) {} set opts(warning) {} + set opts(error_output) {} + set opts(warning_output) {} set opts(objcopy_linked_file) {} - set asflags(${file}.s) {} + set opts(objcopy_objects) {} + set opts(map) {} foreach i $opt_array { set opt_name [lindex $i 0] @@ -724,16 +673,38 @@ proc run_dump_test { name } { switch -- $opt_name { xfail {} target {} + alltargets {} notarget {} + skip {} + anyskip {} + noskip {} + warning {} + error {} source { - # Move any source-specific as-flags to a separate array to + # Move any source-specific as-flags to a separate list to # simplify processing. if { [llength $opt_val] > 1 } { - set asflags([lindex $opt_val 0]) [lrange $opt_val 1 end] + lappend asflags [lrange $opt_val 1 end] set opt_val [lindex $opt_val 0] } else { - set asflags($opt_val) {} + lappend asflags {} } + + # Create the object file name based on nothing but the source + # file name. + set new_objfile \ + [concat tmpdir/[file rootname [file tail [lindex $opt_val 0]]].o] + # But, sometimes, we have the exact same source filename in + # different directories (foo/src.s bar/src.s) which would lead + # us to try and create two src.o files. We detect this + # conflict here, and instead create src.o and src1.o. + set j 0 + while { [lsearch $objfile_names $new_objfile] != -1 } { + incr j + set new_objfile \ + [concat tmpdir/[file rootname [file tail [lindex $opt_val 0]]]${j}.o] + } + lappend objfile_names $new_objfile } default { if [string length $opts($opt_name)] { @@ -755,28 +726,93 @@ proc run_dump_test { name } { if { $opt_name == "as" || $opt_name == "ld" } { set opt_val [subst $opt_val] } - set opts($opt_name) [concat $opts($opt_name) $opt_val] + + # Append differently whether it's a message (without space) or + # an option or list (with space). + switch -- $opt_name { + warning - + error { + append opts($opt_name) $opt_val + } + default { + set opts($opt_name) [concat $opts($opt_name) $opt_val] + } + } + } + + foreach i $extra_options { + set opt_name [lindex $i 0] + set opt_val [lindex $i 1] + if ![info exists opts($opt_name)] { + perror "unknown option $opt_name given in extra_opts" + unresolved $subdir/$name + return + } + # Add extra option to end of existing option, adding space + # if necessary. + if { ![regexp "warning|error" $opt_name] + && [string length $opts($opt_name)] } { + append opts($opt_name) " " + } + append opts($opt_name) $opt_val } + foreach opt { as ld } { regsub {\[big_or_little_endian\]} $opts($opt) \ [big_or_little_endian] opts($opt) } + if { $opts(name) == "" } { + set testname "$subdir/$name" + } else { + set testname $opts(name) + } + # Decide early whether we should run the test for this target. + if { [llength $opts(noskip)] > 0 } { + set targmatch 0 + foreach targ $opts(noskip) { + if [match_target $targ] { + set targmatch 1 + break + } + } + if { $targmatch == 0 } { + return + } + } + foreach targ $opts(anyskip) { + if ![match_target $targ] { + return + } + } + foreach targ $opts(skip) { + if [match_target $targ] { + return + } + } if { [llength $opts(target)] > 0 } { set targmatch 0 foreach targ $opts(target) { - if [istarget $targ] { + if [match_target $targ] { set targmatch 1 break } } if { $targmatch == 0 } { + unsupported $testname + return + } + } + foreach targ $opts(alltargets) { + if ![match_target $targ] { + unsupported $testname return } } foreach targ $opts(notarget) { - if [istarget $targ] { + if [match_target $targ] { + unsupported $testname return } } @@ -784,7 +820,7 @@ proc run_dump_test { name } { set program "" # It's meaningless to require an output-testing method when we # expect an error. - if { $opts(error) == "" } { + if { $opts(error) == "" && $opts(error_output) == "" } { if {$opts(PROG) != ""} { switch -- $opts(PROG) { objdump { set program objdump } @@ -793,7 +829,7 @@ proc run_dump_test { name } { readelf { set program readelf } default { perror "unrecognized program option $opts(PROG) in $file.d" - unresolved $subdir/$name + unresolved $testname return } } } else { @@ -802,7 +838,7 @@ proc run_dump_test { name } { if {$opts($p) != ""} { if {$program != ""} { perror "ambiguous dump program in $file.d" - unresolved $subdir/$name + unresolved $testname return } else { set program $p @@ -810,21 +846,22 @@ proc run_dump_test { name } { } } } - if { $program == "" && $opts(warning) == "" } { + if { $program == "" \ + && $opts(map) == "" \ + && $opts(warning) == "" \ + && $opts(warning_output) == "" \ + && $opts(error) == "" \ + && $opts(error_output) == "" } { perror "dump program unspecified in $file.d" - unresolved $subdir/$name + unresolved $testname return } } - if { $opts(name) == "" } { - set testname "$subdir/$name" - } else { - set testname $opts(name) - } - if { $opts(source) == "" } { set sourcefiles [list ${file}.s] + set asflags [list ""] + set objfile_names [list tmpdir/[file tail ${file}].o] } else { set sourcefiles {} foreach sf $opts(source) { @@ -833,11 +870,15 @@ proc run_dump_test { name } { } else { lappend sourcefiles "$srcdir/$subdir/$sf" } - # Must have asflags indexed on source name. - set asflags($srcdir/$subdir/$sf) $asflags($sf) } } + if { $opts(dump) == "" } { + set dfile ${file}.d + } else { + set dfile $srcdir/$subdir/$opts(dump) + } + # Time to setup xfailures. foreach targ $opts(xfail) { setup_xfail $targ @@ -847,11 +888,18 @@ proc run_dump_test { name } { set objfiles {} for { set i 0 } { $i < [llength $sourcefiles] } { incr i } { set sourcefile [lindex $sourcefiles $i] + set sourceasflags [lindex $asflags $i] + set run_objcopy_objects 0 + + if { [string match "*RUN_OBJCOPY*" $sourceasflags] } { + set run_objcopy_objects 1 + } + regsub "RUN_OBJCOPY" $sourceasflags "" sourceasflags - set objfile "tmpdir/dump$i.o" + set objfile [lindex $objfile_names $i] catch "exec rm -f $objfile" exec_output lappend objfiles $objfile - set cmd "$AS $ASFLAGS $opts(as) $asflags($sourcefile) -o $objfile $sourcefile" + set cmd "$AS $ASFLAGS $opts(as) $sourceasflags -o $objfile $sourcefile" send_log "$cmd\n" set cmdret [remote_exec host [concat sh -c [list "$cmd 2>&1"]] "" "/dev/null" "ld.tmp"] @@ -861,7 +909,7 @@ proc run_dump_test { name } { remote_file build delete "ld.tmp" if { [lindex $cmdret 0] != 0 || ![string match "" $comp_output] } then { - send_log "$comp_output\n" + send_log -- "$comp_output\n" verbose "$comp_output" 3 set exitstat "succeeded" @@ -870,15 +918,71 @@ proc run_dump_test { name } { fail $testname return } - } - set expmsg $opts(error) - if { $opts(warning) != "" } { - if { $expmsg != "" } { - perror "$testname: mixing error and warning test-directives" - return + if { $run_objcopy_objects } { + set cmd "$OBJCOPY $opts(objcopy_objects) $objfile" + + send_log "$cmd\n" + set cmdret [remote_exec host [concat sh -c [list "$cmd 2>&1"]] \ + "" "/dev/null" "objcopy.tmp"] + remote_upload host "objcopy.tmp" + set comp_output [prune_warnings [file_contents "objcopy.tmp"]] + remote_file host delete "objcopy.tmp" + remote_file build delete "objcopy.tmp" + + if { [lindex $cmdret 0] != 0 \ + || ![string match "" $comp_output] } { + send_log -- "$comp_output\n" + verbose "$comp_output" 3 + + set exitstat "succeeded" + if { $cmdret != 0 } { set exitstat "failed" } + verbose -log "$exitstat with: <$comp_output>" + fail $testname + return + } } - set expmsg $opts(warning) + } + + if { (($opts(warning) != "") && ($opts(error) != "")) \ + || (($opts(warning) != "") && ($opts(error_output) != "")) \ + || (($opts(warning) != "") && ($opts(warning_output) != "")) \ + || (($opts(error) != "") && ($opts(warning_output) != "")) \ + || (($opts(error) != "") && ($opts(error_output) != "")) \ + || (($opts(warning_output) != "") && ($opts(error_output) != "")) } { + perror "$testname: bad mix of warning, error, warning_output, and error_output test-directives" + unresolved $testname + return + } + + set check_ld(source) "" + set check_ld(terminal) 0 + if { $opts(error) != "" \ + || $opts(warning) != "" \ + || $opts(error_output) != "" \ + || $opts(warning_output) != "" } { + + if { $opts(error) != "" || $opts(error_output) != "" } { + set check_ld(terminal) 1 + } else { + set check_ld(terminal) 0 + } + + if { $opts(error) != "" || $opts(warning) != "" } { + set check_ld(source) "regex" + if { $opts(error) != "" } { + set check_ld(regex) $opts(error) + } else { + set check_ld(regex) $opts(warning) + } + } else { + set check_ld(source) "file" + if { $opts(error_output) != "" } { + set check_ld(file) $opts(error_output) + } else { + set check_ld(file) $opts(warning_output) + } + } } # Perhaps link the file(s). @@ -888,9 +992,23 @@ proc run_dump_test { name } { # Add -L$srcdir/$subdir so that the linker command can use # linker scripts in the source directory. - set cmd "$LD $LDFLAGS -L$srcdir/$subdir \ + set cmd "$LD $ld_extra_opt $LDFLAGS -L$srcdir/$subdir \ $opts(ld) -o $objfile $objfiles $opts(ld_after_inputfiles)" + # If needed then check for, or add a -Map option. + set mapfile "" + if { $opts(map) != "" } then { + if { [regexp -- "-Map=(\[^ \]+)" $cmd all mapfile] } then { + # Found existing mapfile option + verbose -log "Existing mapfile '$mapfile' found" + } else { + # No mapfile option. + set mapfile "tmpdir/dump.map" + verbose -log "Adding mapfile '$mapfile'" + set cmd "$cmd -Map=$mapfile" + } + } + send_log "$cmd\n" set cmdret [remote_exec host [concat sh -c [list "$cmd 2>&1"]] "" "/dev/null" "ld.tmp"] remote_upload host "ld.tmp" @@ -918,28 +1036,55 @@ proc run_dump_test { name } { } regsub "\n$" $comp_output "" comp_output - if { $cmdret != 0 || $comp_output != "" || $expmsg != "" } then { + if { $cmdret != 0 || $comp_output != "" || $check_ld(source) != "" } then { set exitstat "succeeded" if { $cmdret != 0 } { set exitstat "failed" } - verbose -log "$exitstat with: <$comp_output>, expected: <$expmsg>" - send_log "$comp_output\n" + + if { $check_ld(source) == "regex" } { + verbose -log "$exitstat with: <$comp_output>, expected: <$check_ld(regex)>" + } elseif { $check_ld(source) == "file" } { + verbose -log "$exitstat with: <$comp_output>, expected in file $check_ld(file)" + set_file_contents "tmpdir/ld.messages" "$comp_output" + } else { + verbose -log "$exitstat with: <$comp_output>, no expected output" + } + send_log -- "$comp_output\n" verbose "$comp_output" 3 - if { [regexp $expmsg $comp_output] \ - && (($cmdret == 0) == ($opts(warning) != "")) } { - # We have the expected output from ld. - if { $opts(error) != "" || $program == "" } { + if { (($check_ld(source) == "") == ($comp_output == "")) \ + && (($cmdret == 0) == ($check_ld(terminal) == 0)) \ + && ((($check_ld(source) == "regex") \ + && ($check_ld(regex) == "") == ($comp_output == "") \ + && [regexp -- $check_ld(regex) $comp_output]) \ + || (($check_ld(source) == "file") \ + && (![regexp_diff "tmpdir/ld.messages" "$srcdir/$subdir/$check_ld(file)"]))) } { + # We have the expected output from ld. + if { $check_ld(terminal) || $program == "" } { pass $testname return } } else { - verbose -log "$exitstat with: <$comp_output>, expected: <$expmsg>" fail $testname return } } + + if { $opts(map) != "" } then { + # Check the map file matches. + set map_pattern_file $srcdir/$subdir/$opts(map) + verbose -log "Compare '$mapfile' against '$map_pattern_file'" + if { [regexp_diff $mapfile $map_pattern_file] } then { + fail "$testname (map file check)" + } else { + pass "$testname (map file check)" + } + + if { $program == "" } then { + return + } + } } else { - set objfile "tmpdir/dump0.o" + set objfile [lindex $objfiles 0] } # We must not have expected failure if we get here. @@ -974,6 +1119,7 @@ proc run_dump_test { name } { set env(LC_ALL) "C" send_log "$cmd\n" set cmdret [remote_exec host [concat sh -c [list "$cmd 2>ld.tmp"]] "" "/dev/null"] + set cmdret [lindex $cmdret 0] remote_upload host "ld.tmp" set comp_output [prune_warnings [file_contents "ld.tmp"]] remote_file host delete "ld.tmp" @@ -983,14 +1129,14 @@ proc run_dump_test { name } { } else { unset env(LC_ALL) } - if ![string match "" $comp_output] then { - send_log "$comp_output\n" + if { $cmdret != 0 || $comp_output != "" } { + send_log "exited abnormally with $cmdret, output:$comp_output\n" fail $testname return } if { $verbose > 2 } then { verbose "output is [file_contents $dumpfile]" 3 } - if { [regexp_diff $dumpfile "${file}.d"] } then { + if { [regexp_diff $dumpfile "${dfile}"] } then { fail $testname if { $verbose == 2 } then { verbose "output is [file_contents $dumpfile]" 2 } return @@ -1000,6 +1146,10 @@ proc run_dump_test { name } { } proc slurp_options { file } { + # If options_regsub(foo) is set to {a b}, then the contents of a + # "#foo:" line will have regsub -all applied to replace a with b. + global options_regsub + if [catch { set f [open $file r] } x] { #perror "couldn't open `$file': $x" perror "$x" @@ -1017,6 +1167,11 @@ proc slurp_options { file } { # Whitespace here is space-tab. if [regexp $pat $line xxx opt_name opt_val] { # match! + if [info exists options_regsub($opt_name)] { + set subst $options_regsub($opt_name) + regsub -all -- [lindex $subst 0] $opt_val [lindex $subst 1] \ + opt_val + } lappend opt_array [list $opt_name $opt_val] } else { break @@ -1026,109 +1181,6 @@ proc slurp_options { file } { return $opt_array } -# regexp_diff, copied from gas, based on simple_diff above. -# compares two files line-by-line -# file1 contains strings, file2 contains regexps and #-comments -# blank lines are ignored in either file -# returns non-zero if differences exist -# -proc regexp_diff { file_1 file_2 } { - - set eof -1 - set end_1 0 - set end_2 0 - set differences 0 - set diff_pass 0 - - if [file exists $file_1] then { - set file_a [open $file_1 r] - } else { - warning "$file_1 doesn't exist" - return 1 - } - - if [file exists $file_2] then { - set file_b [open $file_2 r] - } else { - fail "$file_2 doesn't exist" - close $file_a - return 1 - } - - verbose " Regexp-diff'ing: $file_1 $file_2" 2 - - while { 1 } { - set line_a "" - set line_b "" - while { [string length $line_a] == 0 } { - if { [gets $file_a line_a] == $eof } { - set end_1 1 - break - } - } - while { [string length $line_b] == 0 || [string match "#*" $line_b] } { - if [ string match "#pass" $line_b ] { - set end_2 1 - set diff_pass 1 - break - } elseif [ string match "#..." $line_b ] { - if { [gets $file_b line_b] == $eof } { - set end_2 1 - set diff_pass 1 - break - } - verbose "looking for \"^$line_b$\"" 3 - while { ![regexp "^$line_b$" "$line_a"] } { - verbose "skipping \"$line_a\"" 3 - if { [gets $file_a line_a] == $eof } { - set end_1 1 - break - } - } - break - } - if { [gets $file_b line_b] == $eof } { - set end_2 1 - break - } - } - - if { $diff_pass } { - break - } elseif { $end_1 && $end_2 } { - break - } elseif { $end_1 } { - send_log "extra regexps in $file_2 starting with \"^$line_b$\"\nEOF from $file_1\n" - verbose "extra regexps in $file_2 starting with \"^$line_b$\"\nEOF from $file_1" 3 - set differences 1 - break - } elseif { $end_2 } { - send_log "extra lines in $file_1 starting with \"^$line_a$\"\nEOF from $file_2\n" - verbose "extra lines in $file_1 starting with \"^$line_a$\"\nEOF from $file_2\n" 3 - set differences 1 - break - } else { - verbose "regexp \"^$line_b$\"\nline \"$line_a\"" 3 - if ![regexp "^$line_b$" "$line_a"] { - send_log "regexp_diff match failure\n" - send_log "regexp \"^$line_b$\"\nline \"$line_a\"\n" - set differences 1 - } - } - } - - if { $differences == 0 && !$diff_pass && [eof $file_a] != [eof $file_b] } { - send_log "$file_1 and $file_2 are different lengths\n" - verbose "$file_1 and $file_2 are different lengths" 3 - set differences 1 - } - - close $file_a - close $file_b - - return $differences -} - proc file_contents { filename } { set file [open $filename r] set contents [read $file] @@ -1136,12 +1188,18 @@ proc file_contents { filename } { return $contents } +proc set_file_contents { filename contents } { + set file [open $filename w] + puts $file "$contents" + close $file +} + # Create an archive using ar # proc ar_simple_create { ar aropts target objects } { remote_file host delete $target - set exec_output [run_host_cmd "$ar" "$aropts rc $target $objects"] + set exec_output [run_host_cmd "$ar" "-rc $aropts $target $objects"] set exec_output [prune_warnings $exec_output] if [string match "" $exec_output] then { @@ -1154,16 +1212,29 @@ proc ar_simple_create { ar aropts target objects } { # List contains test-items with 3 items followed by 2 lists, one item and # one optional item: -# 0:name 1:ld/ar options 2:assembler options -# 3:filenames of assembler files 4: action and options. 5: name of output file -# 6:compiler flags (optional) +# 0:name +# 1:ld/ar leading options, placed before object files +# 2:ld/ar trailing options, placed after object files +# 3:assembler options +# 4:filenames of assembler files +# 5:list of actions, options and expected outputs. +# 6:name of output file +# 7:compiler flags (optional) # -# Actions: -# objdump: Apply objdump options on result. Compare with regex (last arg). -# nm: Apply nm options on result. Compare with regex (last arg). -# readelf: Apply readelf options on result. Compare with regex (last arg). +# Actions: { command command-line-options file-containg-expected-output-regexps } +# Commands: +# objdump: Apply objdump options on result. +# nm: Apply nm options on result. +# readelf: Apply readelf options on result. +# ld: Don't apply anything on result. Compare output during linking with +# the file containing regexps (which is the second arg, not the third). +# Note that this *must* be the first action if it is to be used at all; +# in all other cases, any output from the linker during linking is +# treated as a sign of an error and FAILs the test. # -proc run_ld_link_tests { ldtests } { +# args is an optional list of target triplets to be xfailed. +# +proc run_ld_link_tests { ldtests args } { global ld global as global nm @@ -1176,6 +1247,14 @@ proc run_ld_link_tests { ldtests } { global CC global CFLAGS global runtests + global exec_output + global ld_elf_shared_opt + + if { [is_elf_format] && [check_shared_lib_support] } { + set ld_extra_opt "$ld_elf_shared_opt" + } else { + set ld_extra_opt "" + } foreach testitem $ldtests { set testname [lindex $testitem 0] @@ -1184,18 +1263,26 @@ proc run_ld_link_tests { ldtests } { continue } + foreach target $args { + setup_xfail $target + } + set ld_options [lindex $testitem 1] - set as_options [lindex $testitem 2] - set src_files [lindex $testitem 3] - set actions [lindex $testitem 4] - set binfile tmpdir/[lindex $testitem 5] - set cflags [lindex $testitem 6] + set ld_after [lindex $testitem 2] + set as_options [lindex $testitem 3] + set src_files [lindex $testitem 4] + set actions [lindex $testitem 5] + set binfile tmpdir/[lindex $testitem 6] + set cflags [lindex $testitem 7] set objfiles {} set is_unresolved 0 set failed 0 + set maybe_failed 0 + set ld_output "" # verbose -log "Testname is $testname" # verbose -log "ld_options is $ld_options" +# verbose -log "ld_after is $ld_after" # verbose -log "as_options is $as_options" # verbose -log "src_files is $src_files" # verbose -log "actions is $actions" @@ -1203,11 +1290,12 @@ proc run_ld_link_tests { ldtests } { # Assemble each file in the test. foreach src_file $src_files { - set objfile "tmpdir/[file rootname $src_file].o" + set fileroot "[file rootname [file tail $src_file]]" + set objfile "tmpdir/$fileroot.o" lappend objfiles $objfile if { [file extension $src_file] == ".c" } { - set as_file "tmpdir/[file rootname $src_file].s" + set as_file "tmpdir/$fileroot.s" if ![ld_compile "$CC -S $CFLAGS $cflags" $srcdir/$subdir/$src_file $as_file] { set is_unresolved 1 break @@ -1222,26 +1310,23 @@ proc run_ld_link_tests { ldtests } { } # Catch assembler errors. - if { $is_unresolved != 0 } { + if { $is_unresolved } { unresolved $testname continue } - if { [regexp ".*\\.a$" $binfile] } { - if { ![ar_simple_create $ar $ld_options $binfile "$objfiles"] } { - fail $testname + if { $binfile eq "tmpdir/" } { + # compile only + } elseif { [regexp ".*\\.a$" $binfile] } { + if { ![ar_simple_create $ar $ld_options $binfile "$objfiles $ld_after"] } { set failed 1 - } else { - set failed 0 } - } elseif { ![ld_simple_link $ld $binfile "-L$srcdir/$subdir $ld_options $objfiles"] } { - fail $testname - set failed 1 - } else { - set failed 0 + } elseif { ![ld_link $ld $binfile "$ld_extra_opt -L$srcdir/$subdir $ld_options $objfiles $ld_after"] } { + set maybe_failed 1 + set ld_output "$exec_output" } - if { $failed == 0 } { + if { !$failed } { foreach actionlist $actions { set action [lindex $actionlist 0] set progopts [lindex $actionlist 1] @@ -1257,6 +1342,8 @@ proc run_ld_link_tests { ldtests } { { set dump_prog $nm } readelf { set dump_prog $READELF } + ld + { set dump_prog "ld" } default { perror "Unrecognized action $action" @@ -1265,7 +1352,18 @@ proc run_ld_link_tests { ldtests } { } } - if { $dump_prog != "" } { + if { $action == "ld" } { + set regexpfile $progopts + verbose "regexpfile is $srcdir/$subdir/$regexpfile" + set_file_contents "tmpdir/ld.messages" "$ld_output" + verbose "ld.messages has '[file_contents tmpdir/ld.messages]'" + if { [regexp_diff "tmpdir/ld.messages" "$srcdir/$subdir/$regexpfile"] } then { + verbose "output is $ld_output" 2 + set failed 1 + break + } + set maybe_failed 0 + } elseif { !$maybe_failed && $dump_prog != "" } { set dumpfile [lindex $actionlist 2] set binary $dump_prog @@ -1281,7 +1379,7 @@ proc run_ld_link_tests { ldtests } { set comp_output [prune_warnings [file_contents "ld.stderr"]] remote_file host delete "ld.stderr" remote_file build delete "ld.stderr" - + if {[info exists old_lc_all]} { set env(LC_ALL) $old_lc_all } else { @@ -1307,18 +1405,14 @@ proc run_ld_link_tests { ldtests } { remote_file host delete "dump.out" } } - - if { $failed != 0 } { - fail $testname - } else { if { $is_unresolved == 0 } { - pass $testname - } } } - # Catch action errors. - if { $is_unresolved != 0 } { + if { $is_unresolved } { unresolved $testname - continue + } elseif { $maybe_failed || $failed } { + fail $testname + } else { + pass $testname } } } @@ -1346,11 +1440,10 @@ if ![string length [info proc prune_warnings]] { } } -# targets_to_xfail is a list of target triplets to be xfailed. # ldtests contains test-items with 3 items followed by 1 lists, 2 items # and 3 optional items: # 0:name -# 1:ld options +# 1:ld leading options, placed before object files # 2:assembler options # 3:filenames of source files # 4:name of output file @@ -1358,8 +1451,10 @@ if ![string length [info proc prune_warnings]] { # 6:compiler flags (optional) # 7:language (optional) # 8:linker warning (optional) +# 9:ld trailing options, placed after object files (optional) +# args is an optional list of target triplets to be xfailed. -proc run_ld_link_exec_tests { targets_to_xfail ldtests } { +proc run_ld_link_exec_tests { ldtests args } { global ld global as global srcdir @@ -1371,9 +1466,21 @@ proc run_ld_link_exec_tests { targets_to_xfail ldtests } { global CXXFLAGS global errcnt global exec_output + global board_cflags + global STATIC_LDFLAGS + + # When using GCC as the linker driver, we need to specify board cflags when + # linking because cflags may contain linker options. For example when + # linker options are included in GCC spec files then we need the -specs + # option. + if [board_info [target_info name] exists cflags] { + set board_cflags " [board_info [target_info name] cflags]" + } else { + set board_cflags "" + } foreach testitem $ldtests { - foreach target $targets_to_xfail { + foreach target $args { setup_xfail $target } set testname [lindex $testitem 0] @@ -1385,6 +1492,7 @@ proc run_ld_link_exec_tests { targets_to_xfail ldtests } { set cflags [lindex $testitem 6] set lang [lindex $testitem 7] set warning [lindex $testitem 8] + set ld_after [lindex $testitem 9] set objfiles {} set failed 0 @@ -1392,84 +1500,95 @@ proc run_ld_link_exec_tests { targets_to_xfail ldtests } { # verbose -log "ld_options is $ld_options" # verbose -log "as_options is $as_options" # verbose -log "src_files is $src_files" -# verbose -log "actions is $actions" # verbose -log "binfile is $binfile" # Assemble each file in the test. foreach src_file $src_files { - set objfile "tmpdir/[file rootname $src_file].o" + set fileroot "[file rootname [file tail $src_file]]" + set objfile "tmpdir/$fileroot.o" lappend objfiles $objfile - # We ignore warnings since some compilers may generate - # incorrect section attributes and the assembler will warn - # them. if { [ string match "c++" $lang ] } { - ld_compile "$CXX -c $CXXFLAGS $cflags" $srcdir/$subdir/$src_file $objfile + set cmd "$CXX -c $CXXFLAGS $cflags" } else { - ld_compile "$CC -c $CFLAGS $cflags" $srcdir/$subdir/$src_file $objfile + set cmd "$CC -c $CFLAGS $cflags" } - - # We have to use $CC to build PIE and shared library. - if { [ string match "c" $lang ] } { - set link_proc ld_simple_link - set link_cmd $CC - } elseif { [ string match "c++" $lang ] } { - set link_proc ld_simple_link - set link_cmd $CXX - } elseif { [ string match "-shared" $ld_options ] \ - || [ string match "-pie" $ld_options ] } { - set link_proc ld_simple_link - set link_cmd $CC - } else { - set link_proc ld_link - set link_cmd $ld + if ![ld_compile $cmd $srcdir/$subdir/$src_file $objfile] { + set failed 1 + break } + } + if { $failed != 0 } { + unresolved $testname + continue + } + + if { [ string match "asm" $lang ] } { + set link_proc ld_link + set link_cmd $ld + } elseif { [ string match "c++" $lang ] } { + set link_proc ld_link + set link_cmd $CXX + } else { + set link_proc ld_link + set link_cmd $CC + } - if ![$link_proc $link_cmd $binfile "-L$srcdir/$subdir $ld_options $objfiles"] { + if { $binfile eq "tmpdir/" } { + # compile only + pass $testname + continue; + } else { + if { [string match "" $STATIC_LDFLAGS] \ + && [regexp -- ".* \[-\]+static .*" " $board_cflags $ld_options $objfiles $ld_after "] } { + untested $testname + continue + } + if ![$link_proc $link_cmd $binfile "$board_cflags -L$srcdir/$subdir $ld_options $objfiles $ld_after"] { set failed 1 - } else { - set failed 0 } + } - # Check if exec_output is expected. - if { $warning != "" } then { - verbose -log "returned with: <$exec_output>, expected: <$warning>" - if { [regexp $warning $exec_output] } then { - set failed 0 - } else { - set failed 1 - } + # Check if exec_output is expected. + if { $warning != "" } then { + verbose -log "returned with: <$exec_output>, expected: <$warning>" + if { [regexp $warning $exec_output] } then { + set failed 0 + } else { + set failed 1 } + } + + if { $failed == 0 && [isnative] } { + send_log "Running: $binfile > $binfile.out\n" + verbose "Running: $binfile > $binfile.out" + catch "exec $binfile > $binfile.out" exec_output + + if ![string match "" $exec_output] then { + send_log "$exec_output\n" + verbose "$exec_output" 1 + set failed 1 + } else { + send_log "diff $binfile.out $srcdir/$subdir/$expfile\n" + verbose "diff $binfile.out $srcdir/$subdir/$expfile" + catch "exec diff $binfile.out $srcdir/$subdir/$expfile" exec_output + set exec_output [prune_warnings $exec_output] - if { $failed == 0 } { - send_log "Running: $binfile > $binfile.out\n" - verbose "Running: $binfile > $binfile.out" - catch "exec $binfile > $binfile.out" exec_output - if ![string match "" $exec_output] then { send_log "$exec_output\n" verbose "$exec_output" 1 set failed 1 - } else { - send_log "diff $binfile.out $srcdir/$subdir/$expfile\n" - verbose "diff $binfile.out $srcdir/$subdir/$expfile" - catch "exec diff $binfile.out $srcdir/$subdir/$expfile" exec_output - set exec_output [prune_warnings $exec_output] - - if ![string match "" $exec_output] then { - send_log "$exec_output\n" - verbose "$exec_output" 1 - set failed 1 - } } } + } - if { $failed != 0 } { - fail $testname - } else { - set errcnt 0 - pass $testname - } + if { $failed != 0 } { + fail $testname + } elseif ![isnative] { + unsupported $testname + } else { + set errcnt 0 + pass $testname } } } @@ -1488,6 +1607,10 @@ proc run_ld_link_exec_tests { targets_to_xfail ldtests } { # objdump: Apply objdump options on result. Compare with regex (last arg). # nm: Apply nm options on result. Compare with regex (last arg). # readelf: Apply readelf options on result. Compare with regex (last arg). +# warning: Check linker output against regex (last arg). +# error: Like 'warning' but checking output in error case. +# warning_output: Check linker output against regex in a file (last arg). +# error_output: Like 'warning_output' but checking output in error case. # proc run_cc_link_tests { ldtests } { global nm @@ -1501,6 +1624,15 @@ proc run_cc_link_tests { ldtests } { global CFLAGS global CXXFLAGS global ar + global exec_output + global board_cflags + global STATIC_LDFLAGS + + if [board_info [target_info name] exists cflags] { + set board_cflags " [board_info [target_info name] cflags]" + } else { + set board_cflags "" + } foreach testitem $ldtests { set testname [lindex $testitem 0] @@ -1513,21 +1645,68 @@ proc run_cc_link_tests { ldtests } { set objfiles {} set is_unresolved 0 set failed 0 + set check_ld(terminal) 0 + set check_ld(source) "" + + #verbose -log "testname is $testname" + #verbose -log "ldflags is $ldflags" + #verbose -log "cflags is $cflags" + #verbose -log "src_files is $src_files" + #verbose -log "actions is $actions" + #verbose -log "binfile is $binfile" + #verbose -log "lang is $lang" + + foreach actionlist $actions { + set action [lindex $actionlist 0] + set progopts [lindex $actionlist 1] + + # Find actions related to error/warning processing. + switch -- $action { + error + { + set check_ld(source) "regexp" + set check_ld(regexp) $progopts + set check_ld(terminal) 1 + } + warning + { + set check_ld(source) "regexp" + set check_ld(regexp) $progopts + } + error_output + { + set check_ld(source) "file" + set check_ld(file) $progopts + set check_ld(terminal) 1 + } + warning_output + { + set check_ld(source) "file" + set check_ld(file) $progopts + } + } + } # Compile each file in the test. foreach src_file $src_files { - set objfile "tmpdir/[file rootname $src_file].o" + set fileroot "[file rootname [file tail $src_file]]" + set objfile "tmpdir/$fileroot.o" lappend objfiles $objfile - # We ignore warnings since some compilers may generate - # incorrect section attributes and the assembler will warn - # them. if { [ string match "c++" $lang ] } { - ld_compile "$CXX -c $CXXFLAGS $cflags" $srcdir/$subdir/$src_file $objfile + set cmd "$CXX -c $CXXFLAGS $cflags" } else { - ld_compile "$CC -c $CFLAGS $cflags" $srcdir/$subdir/$src_file $objfile + set cmd "$CC -c $CFLAGS $cflags" + } + if ![ld_compile $cmd $srcdir/$subdir/$src_file $objfile] { + set failed 1 + break } } + if { $failed != 0 } { + unresolved $testname + continue + } # Clear error and warning counts. reset_vars @@ -1538,18 +1717,48 @@ proc run_cc_link_tests { ldtests } { set cc_cmd $CC } - if { [regexp ".*\\.a$" $binfile] } { + if { $binfile eq "tmpdir/" } { + # compile only + } elseif { [regexp ".*\\.a$" $binfile] } { if { ![ar_simple_create $ar $ldflags $binfile "$objfiles"] } { - fail $testname set failed 1 - } else { - set failed 0 } - } elseif { ![ld_simple_link $cc_cmd $binfile "-L$srcdir/$subdir $ldflags $objfiles"] } { - fail $testname - set failed 1 } else { - set failed 0 + if { [string match "" $STATIC_LDFLAGS] \ + && [regexp -- ".* \[-\]+static .*" " $board_cflags $ldflags $objfiles "] } { + untested $testname + continue + } + ld_link $cc_cmd $binfile "$board_cflags -L$srcdir/$subdir $ldflags $objfiles" + set ld_output "$exec_output" + + if { $check_ld(source) == "regexp" } then { + # Match output against regexp argument. + verbose -log "returned with: <$ld_output>, expected: <$check_ld(regexp)>" + if { ![regexp $check_ld(regexp) $ld_output] } then { + set failed 1 + } + } elseif { $check_ld(source) == "file" } then { + # Match output against patterns in a file. + set_file_contents "tmpdir/ld.messages" "$ld_output" + verbose "ld.messages has '[file_contents tmpdir/ld.messages]'" + if { [regexp_diff "tmpdir/ld.messages" "$srcdir/$subdir/$check_ld(file)"] } then { + verbose "output is $ld_output" 2 + set failed 1 + } + } + + if { $check_ld(source) != "" } then { + if { $ld_output == "" } then { + verbose -log "Linker was expected to give error or warning" + set failed 1 + } + } else { + if { $ld_output != "" } then { + verbose -log "Unexpected linker warning or error" + set failed 1 + } + } } if { $failed == 0 } { @@ -1568,6 +1777,10 @@ proc run_cc_link_tests { ldtests } { { set dump_prog $nm } readelf { set dump_prog $READELF } + error {} + warning {} + error_output {} + warning_output {} default { perror "Unrecognized action $action" @@ -1608,18 +1821,14 @@ proc run_cc_link_tests { ldtests } { } } } - - if { $failed != 0 } { - fail $testname - } else { if { $is_unresolved == 0 } { - pass $testname - } } } - # Catch action errors. - if { $is_unresolved != 0 } { + if { $failed } { + fail $testname + } elseif { $is_unresolved } { unresolved $testname - continue + } else { + pass $testname } } } @@ -1629,15 +1838,20 @@ proc run_cc_link_tests { ldtests } { proc check_gc_sections_available { } { global gc_sections_available_saved global ld - + if {![info exists gc_sections_available_saved]} { # Some targets don't support gc-sections despite whatever's # advertised by ld's options. - if { [istarget alpha*-*-*] - || [istarget mep-*-*] - || [istarget ia64-*-*] - || [istarget *-*-cygwin] - || [istarget *-*-mingw*] } { + if { [istarget alpha-*-*] + || [istarget d30v-*-*] + || [istarget dlx-*-*] + || [istarget hppa*64-*-*] + || [istarget ia64-*-*] + || [istarget mep-*-*] + || [istarget mn10200-*-*] + || [istarget pj*-*-*] + || [istarget pru*-*-*] + || [istarget xgate-*-*] } { set gc_sections_available_saved 0 return 0 } @@ -1651,6 +1865,8 @@ proc check_gc_sections_available { } { } # Check if the ld used by gcc supports --gc-sections. + # FIXME: this test is useless since ld --help always says + # --gc-sections is available set ld_output [remote_exec host $ld "--help"] if { [ string first "--gc-sections" $ld_output ] >= 0 } { set gc_sections_available_saved 1 @@ -1661,6 +1877,247 @@ proc check_gc_sections_available { } { return $gc_sections_available_saved } +# Returns true if -shared is supported on the target + +proc check_shared_lib_support { } { + global shared_available_saved + global ld + + if {![info exists shared_available_saved]} { + set ld_output [remote_exec host $ld "-shared"] + if { [ string first "not supported" $ld_output ] >= 0 } { + set shared_available_saved 0 + } else { + set shared_available_saved 1 + } + } + return $shared_available_saved +} + +# Return true if target uses genelf.em (assuming it is ELF). +proc is_generic_elf { } { + if { [istarget "d30v-*-*"] + || [istarget "dlx-*-*"] + || [istarget "fr30-*-*"] + || ([istarget "frv-*-*"] && ![istarget "frv-*-linux*"]) + || [istarget "ft32-*-*"] + || [istarget "iq2000-*-*"] + || [istarget "mn10200-*-*"] + || [istarget "moxie-*-*"] + || [istarget "msp430-*-*"] + || [istarget "mt-*-*"] + || [istarget "pj*-*-*"] + || [istarget "xgate-*-*"] } { + return 1; + } + return 0; +} + +proc is_underscore_target { } { + global is_underscore_target_saved + global target_triplet + global srcdir + + if { ![info exists is_underscore_target_saved] } { + set cmd "targ=$target_triplet . $srcdir/../../bfd/config.bfd &&" + append cmd { echo "$targ_underscore"} + verbose -log "$cmd" + set status [catch {exec sh -c $cmd} result] + if { $status == 0 && [string match "yes" $result] } { + set is_underscore_target_saved 1 + } else { + set is_underscore_target_saved 0 + } + } + return $is_underscore_target_saved +} + +# Returns true if the target ld supports the plugin API. +proc check_plugin_api_available { } { + global plugin_api_available_saved + global ld + if {![info exists plugin_api_available_saved]} { + # Check if the ld used by gcc supports --plugin. + set ld_output [remote_exec host $ld "--help"] + if { [ string first "-plugin PLUGIN" $ld_output ] >= 0 } { + set plugin_api_available_saved 1 + } else { + set plugin_api_available_saved 0 + } + } + return $plugin_api_available_saved +} + +# Sets ld_sysroot to the current sysroot (empty if not supported) and +# returns true if the target ld supports sysroot. +proc check_sysroot_available { } { + global ld_sysroot_available_saved ld ld_sysroot + if {![info exists ld_sysroot_available_saved]} { + # Check if ld supports --sysroot *other* than empty. + set ld_sysroot [string trimright [lindex [remote_exec host $ld "--print-sysroot"] 1]] + if { $ld_sysroot == "" } { + set ld_sysroot_available_saved 0 + } else { + set ld_sysroot_available_saved 1 + } + } + return $ld_sysroot_available_saved +} + +# Returns 1 if plugin is enabled in gcc. Returns 0 otherwise. +proc check_gcc_plugin_enabled { } { + global CC + + if {![info exists CC]} { + set CC [find_gcc] + } + if { $CC == ""} { + return 0 + } + set state [remote_exec host $CC -v] + if { [lindex $state 0] != 0 } { + return 0; + } + for { set i 1 } { $i < [llength $state] } { incr i } { + set v [lindex $state $i] + if { [ string match "*--disable-plugin*" $v ] } { + verbose "plugin is disabled by $v" + return 0; + } + } + + return 1; +} + +# Returns true if the target compiler supports LTO +proc check_lto_available { } { + global lto_available_saved + global CC + + if {![info exists lto_available_saved]} { + if { ![check_gcc_plugin_enabled] } { + set lto_available_saved 0 + return 0 + } + # This test will hide LTO bugs in ld. Since GCC 4.9 adds + # -ffat-lto-objects, we always run LTO tests on Linux with + # GCC 4.9 or newer. + if { [istarget "*-*-linux*"] && [at_least_gcc_version 4 9] } { + set lto_available_saved 1 + return 1 + } + # Check if gcc supports -flto -fuse-linker-plugin + set flags "" + if [board_info [target_info name] exists cflags] { + append flags " [board_info [target_info name] cflags]" + } + if [board_info [target_info name] exists ldflags] { + append flags " [board_info [target_info name] ldflags]" + } + + set basename "tmpdir/lto[pid]" + set src ${basename}.c + set output ${basename}.out + set f [open $src "w"] + puts $f "int main() { return 0; }" + close $f + if [is_remote host] { + set src [remote_download host $src] + } + set lto_available_saved [run_host_cmd_yesno "$CC" "$flags -flto -fuse-linker-plugin $src -o $output"] + remote_file host delete $src + remote_file host delete $output + file delete $src + } + return $lto_available_saved +} + +# Returns true if the target compiler supports LTO -ffat-lto-objects +proc check_lto_fat_available { } { + global lto_fat_available_saved + global CC + + if {![info exists lto_fat_available_saved]} { + if { ![check_gcc_plugin_enabled] } { + set lto_fat_available_saved 0 + return 0 + } + # This test will hide LTO bugs in ld. Since GCC 4.9 adds + # -ffat-lto-objects, we always run LTO tests on Linux with + # GCC 4.9 or newer. + if { [istarget "*-*-linux*"] && [at_least_gcc_version 4 9] } { + set lto_fat_available_saved 1 + return 1 + } + # Check if gcc supports -flto -fuse-linker-plugin + set flags "" + if [board_info [target_info name] exists cflags] { + append flags " [board_info [target_info name] cflags]" + } + if [board_info [target_info name] exists ldflags] { + append flags " [board_info [target_info name] ldflags]" + } + + set basename "tmpdir/lto[pid]" + set src ${basename}.c + set output ${basename}.out + set f [open $src "w"] + puts $f "int main() { return 0; }" + close $f + if [is_remote host] { + set src [remote_download host $src] + } + set lto_fat_available_saved [run_host_cmd_yesno "$CC" "$flags -flto -ffat-lto-objects -fuse-linker-plugin $src -o $output"] + remote_file host delete $src + remote_file host delete $output + file delete $src + } + return $lto_fat_available_saved +} + +# Returns true if the target compiler supports LTO and -shared +proc check_lto_shared_available { } { + global lto_shared_available_saved + global CC + + if {![info exists lto_shared_available_saved]} { + if { ![check_gcc_plugin_enabled] } { + set lto_shared_available_saved 0 + return 0 + } + # This test will hide LTO bugs in ld. Since GCC 4.9 adds + # -ffat-lto-objects, we always run LTO tests on Linux with + # GCC 4.9 or newer. + if { [istarget "*-*-linux*"] && [at_least_gcc_version 4 9] } { + set lto_shared_available_saved 1 + return 1 + } + # Check if gcc supports -flto -fuse-linker-plugin -shared + set flags "" + if [board_info [target_info name] exists cflags] { + append flags " [board_info [target_info name] cflags]" + } + if [board_info [target_info name] exists ldflags] { + append flags " [board_info [target_info name] ldflags]" + } + + set basename "tmpdir/lto_shared[pid]" + set src ${basename}.c + set output ${basename}.so + set f [open $src "w"] + puts $f "" + close $f + if [is_remote host] { + set src [remote_download host $src] + } + set lto_shared_available_saved [run_host_cmd_yesno "$CC" "$flags -shared -fPIC -flto -fuse-linker-plugin $src -o $output"] + remote_file host delete $src + remote_file host delete $output + file delete $src + } + return $lto_shared_available_saved +} + # Check if the assembler supports CFI statements. proc check_as_cfi { } { @@ -1687,6 +2144,102 @@ proc check_as_cfi { } { return $success } +# Returns true if IFUNC works. + +proc check_ifunc_available { } { + global ifunc_available_saved + global CC + + if {![info exists ifunc_available_saved]} { + if { [which $CC] == 0 } { + set ifunc_available_saved 0 + return 0 + } + # Check if gcc supports -flto -fuse-linker-plugin + set flags "" + if [board_info [target_info name] exists cflags] { + append flags " [board_info [target_info name] cflags]" + } + if [board_info [target_info name] exists ldflags] { + append flags " [board_info [target_info name] ldflags]" + } + + set basename "tmpdir/ifunc[pid]" + set src ${basename}.c + set output ${basename}.out + set f [open $src "w"] + puts $f "extern int library_func2 (void);" + puts $f "int main (void)" + puts $f "{" + puts $f " if (library_func2 () != 2) __builtin_abort ();" + puts $f " return 0; " + puts $f "}" + puts $f "static int library_func1 (void) {return 2; }" + puts $f "void *foo (void) __asm__ (\"library_func2\");" + puts $f "void *foo (void) { return library_func1; }" + puts $f "__asm__(\".type library_func2, %gnu_indirect_function\");" + close $f + if [is_remote host] { + set src [remote_download host $src] + } + set ifunc_available_saved [run_host_cmd_yesno "$CC" "$flags $src -o $output"] + if { [isnative] && $ifunc_available_saved == 1 } { + set ifunc_available_saved [run_host_cmd_yesno "$output" ""] + } + remote_file host delete $src + remote_file host delete $output + file delete $src + } + return $ifunc_available_saved +} + +# Returns true if ifunc attribute works. + +proc check_ifunc_attribute_available { } { + global ifunc_attribute_available_saved + global CC + + if {![info exists ifunc_attribute_available_saved]} { + if { [which $CC] == 0 } { + set ifunc_attribute_available_saved 0 + return 0 + } + # Check if gcc supports -flto -fuse-linker-plugin + set flags "" + if [board_info [target_info name] exists cflags] { + append flags " [board_info [target_info name] cflags]" + } + if [board_info [target_info name] exists ldflags] { + append flags " [board_info [target_info name] ldflags]" + } + + set basename "tmpdir/ifunc[pid]" + set src ${basename}.c + set output ${basename}.out + set f [open $src "w"] + puts $f "extern int library_func2 (void) __attribute__ ((ifunc (\"foo\")));" + puts $f "int main (void)" + puts $f "{" + puts $f " if (library_func2 () != 2) __builtin_abort ();" + puts $f " return 0; " + puts $f "}" + puts $f "static int library_func1 (void) {return 2; }" + puts $f "void *foo (void) { return library_func1; }" + close $f + if [is_remote host] { + set src [remote_download host $src] + } + set ifunc_attribute_available_saved [run_host_cmd_yesno "$CC" "$flags $src -o $output"] + if { [isnative] && $ifunc_attribute_available_saved == 1 } { + set ifunc_attribute_available_saved [run_host_cmd_yesno "$output" ""] + } + remote_file host delete $src + remote_file host delete $output + file delete $src + } + return $ifunc_attribute_available_saved +} + # Provide virtual target "cfi" for targets supporting CFI. rename "istarget" "istarget_ld" @@ -1694,5 +2247,107 @@ proc istarget { target } { if {$target == "cfi"} { return [check_as_cfi] } + if {$target == "shared"} { + return [check_shared_lib_support] + } return [istarget_ld $target] } + +# Return true if libdl is supported. + +proc check_libdl_available { } { + global libdl_available_saved + global CC + + if {![info exists libdl_available_saved]} { + if { [which $CC] == 0 } { + set libdl_available_saved 0 + return 0 + } + + set basename "tmpdir/dl_avail_test[pid]" + set src ${basename}.c + set output ${basename}.out + set f [open $src "w"] + # Sample test file. + puts $f "#include " + puts $f "int main (void)" + puts $f "{" + puts $f " dlopen (\"dummy.so\", RTLD_NOW);" + puts $f " return 0; " + puts $f "}" + close $f + if [is_remote host] { + set src [remote_download host $src] + } + set libdl_available_saved [run_host_cmd_yesno "$CC" "$src -o $output -ldl"] + remote_file host delete $src + remote_file host delete $output + file delete $src + } + return $libdl_available_saved +} + +# Returns true if GNU2 TLS works. + +proc check_gnu2_tls_available { } { + global gnu2_tls_available_saved + global CC + global GNU2_CFLAGS + + if {![info exists gnu2_tls_available_saved]} { + if { [which $CC] == 0 || "$GNU2_CFLAGS" == "" } { + set gnu2_tls_available_saved 0 + return 0 + } + # Check if GNU2 TLS works. + set flags "$GNU2_CFLAGS" + if [board_info [target_info name] exists cflags] { + append flags " [board_info [target_info name] cflags]" + } + if [board_info [target_info name] exists ldflags] { + append flags " [board_info [target_info name] ldflags]" + } + + set basename "tmpdir/gnu2_tls[pid]" + set src1 ${basename}1.c + set output1 ${basename}.so + set f [open $src1 "w"] + puts $f "extern __thread int zzz;" + puts $f "int foo (void)" + puts $f "{" + puts $f " return zzz;" + puts $f "}" + close $f + if [is_remote host] { + set src1 [remote_download host $src1] + } + set src2 ${basename}2.c + set output2 ${basename}.exe + set f [open $src2 "w"] + puts $f "__thread int zzz = 20;" + puts $f "extern int foo (void);" + puts $f "int main (void)" + puts $f "{" + puts $f " if (foo () != 20) __builtin_abort ();" + puts $f " return 0; " + puts $f "}" + close $f + if [is_remote host] { + set src2 [remote_download host $src2] + } + set gnu2_tls_available_saved [run_host_cmd_yesno "$CC" "-fPIC -shared $flags $src1 -o $output1"] + if { $gnu2_tls_available_saved == 1 } { + set gnu2_tls_available_saved [run_host_cmd_yesno "$CC" "$flags $src2 $output1 -o $output2"] + if { $gnu2_tls_available_saved == 1 } { + set gnu2_tls_available_saved [run_host_cmd_yesno "$output2" ""] + } + } + remote_file host delete $src1 + remote_file host delete $output1 + remote_file host delete $src2 + remote_file host delete $output2 + file delete $src1 $src2 + } + return $gnu2_tls_available_saved +}