ARM: mvebu: Fix the operand list in the inline asm of armada_370_xp_pmsu_idle_enter
authorGregory CLEMENT <gregory.clement@free-electrons.com>
Fri, 4 Jul 2014 14:22:16 +0000 (16:22 +0200)
committerJason Cooper <jason@lakedaemon.net>
Tue, 8 Jul 2014 12:25:39 +0000 (12:25 +0000)
commit0d461e1b087048b0cc37c9d7b351649578c507b4
treef037c11f9c4d6cc4f284cda160af916014d9d312
parent0e2be4c1121ae3dc2771c4d9b99d4c39ea9577d8
ARM: mvebu: Fix the operand list in the inline asm of armada_370_xp_pmsu_idle_enter

In the inline asm part of the function armada_370_xp_pmsu_idle_enter()
the input operand was used. The intent here was to let the compiler
choose this register so it could do the optimization it
needed.

However an input operand is not supposed to be modified by the inline
asm code. This can lead to improper generated instructions.

In some case generated instruction the compiler made the choice to
reuse the same register to store the return value. But in the assembly
part this register was modified, so it can lead to return an wrong
value.

The fix is to use a clobber. Thanks to this the compiler will know
that the value of this register will be modified.

Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Link: https://lkml.kernel.org/r/1404483736-16938-1-git-send-email-gregory.clement@free-electrons.com
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
arch/arm/mach-mvebu/pmsu.c
This page took 0.024162 seconds and 5 git commands to generate.