x86/mce: Make mce_chrdev_ops 'static const'
authorLuck, Tony <tony.luck@intel.com>
Thu, 3 Nov 2011 18:46:47 +0000 (11:46 -0700)
committerIngo Molnar <mingo@elte.hu>
Tue, 8 Nov 2011 15:17:11 +0000 (16:17 +0100)
commit66f5ddf30a59f811818656cb2833c80da0340cfa
treef10616e055f5c92007bf4a4304884a3a66b9b652
parent1ea6b8f48918282bdca0b32a34095504ee65bab5
x86/mce: Make mce_chrdev_ops 'static const'

Arjan would like to make struct file_operations const, but
mce-inject directly writes to the mce_chrdev_ops to install its
write handler. In an ideal world mce-inject would have its own
character device, but we have a sizable legacy of test scripts
that hardwire "/dev/mcelog", so it would be painful to switch to
a separate device now. Instead, this patch switches to a stub
function in the mce code, with a registration helper that
mce-inject can call when it is loaded.

Note that this would also allow for a sane process to allow
mce-inject to be unloaded again (with an unregister function,
and appropriate module_{get,put}() calls), but that is left for
potential future patches.

Reported-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Link: http://lkml.kernel.org/r/4eb2e1971326651a3b@agluck-desktop.sc.intel.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/include/asm/mce.h
arch/x86/kernel/cpu/mcheck/mce-inject.c
arch/x86/kernel/cpu/mcheck/mce.c
This page took 0.027359 seconds and 5 git commands to generate.