dmaengine: fix missing 'cnt' in ?: in dmatest
authorDr. David Alan Gilbert <linux@treblig.org>
Thu, 25 Aug 2011 23:13:55 +0000 (16:13 -0700)
committerDan Williams <dan.j.williams@intel.com>
Mon, 23 Jan 2012 19:43:18 +0000 (11:43 -0800)
commitd07a74a546981a09ba490936645fbf0d1340b96c
treeeda5193a28b09fd0f7af994b6762d33b5e8e5b53
parentdcd6c92267155e70a94b3927bce681ce74b80d1f
dmaengine: fix missing 'cnt' in ?: in dmatest

Hi,
  On the latest tree my compiler has started giving the warning:

drivers/dma/dmatest.c:575:28: warning: the omitted middle operand in ?: will always be ?true?, suggest explicit middle operand [-Wparentheses]

The following patch fixes the missing middle clause with the same
fix that Nicolas Ferre used in the similar clauses.
(There seems to have been a race between him fixing that and
the extra clause going in a little later).

I don't actually know the dmatest code/structures, nor do I own
any hardware to test it on (assuming it needs a DMA engine);
 but this patch builds, the existing code is almost certainly
wrong and the fix is the same as the corresponding lines above it.

(WTH is x=y?:z legal C anyway?)

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reported-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/dma/dmatest.c
This page took 0.024582 seconds and 5 git commands to generate.