drm/i915: Make use of intel_fb_obj() (v2)
authorMatt Roper <matthew.d.roper@intel.com>
Tue, 8 Jul 2014 14:50:07 +0000 (07:50 -0700)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 9 Jul 2014 11:52:03 +0000 (13:52 +0200)
commit2ff8fde1ea0992dfd735dce94f8cae2aacff8e5c
tree1082c38535671f978986032a6bab519fbbedd47d
parent155e63696caab748da3f344f66de503038a72024
drm/i915: Make use of intel_fb_obj() (v2)

This should hopefully simplify the display code slightly and also
solves at least one mistake in intel_pipe_set_base() where
to_intel_framebuffer(fb)->obj is referenced during local variable
initialization, before 'if (!fb)' gets checked.

Potential uses of this macro were identified via the following
Coccinelle patch:

        @@
        expression E;
        @@
        * to_intel_framebuffer(E)->obj

        @@
        expression E;
        identifier I;
        @@
          I = to_intel_framebuffer(E);
          ...
        * I->obj

v2: Rewrite some NULL tests in terms of the obj rather than the fb.
    Also add a WARN() if trying to pageflip with a disabled primary
    plane.  [Suggested by Chris Wilson]

Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_display.c
drivers/gpu/drm/i915/intel_dp.c
drivers/gpu/drm/i915/intel_pm.c
This page took 0.028513 seconds and 5 git commands to generate.