i8k: Fix temperature bug handling in i8k_get_temp()
authorPali Rohár <pali.rohar@gmail.com>
Tue, 18 Nov 2014 14:56:54 +0000 (15:56 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Nov 2014 03:29:36 +0000 (19:29 -0800)
commit723493ca59c8d81fed3e7f261165fee493a29ffa
tree966c77b05f2fbdb1e26f439c6587734b8c81baa0
parentca4f8280ff227e215f44e10f8f110b4c882b084b
i8k: Fix temperature bug handling in i8k_get_temp()

Static array prev[] was incorrectly initialized. It should be initialized to
some "invalid" temperature value (above I8K_MAX_TEMP).

Next, function should store "invalid" value to prev[] (above I8K_MAX_TEMP),
not valid (= I8K_MAX_TEMP) because whole temperature bug handling will not
work.

And last part, to not break existing detection of temperature sensors, register
them also if i8k report too high temperature (above I8K_MAX_TEMP). This is
needed because some sensors are sometimes turned off (e.g sensor on GPU which
can be turned off/on) and in this case SMM report too high value.

To prevent reporting "invalid" values to userspace, return -EINVAL. In this case
sensors which are currently turned off (e.g optimus/powerexpress/enduro gpu)
are reported as "N/A" by lm-sensors package.

Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/i8k.c
This page took 0.042827 seconds and 5 git commands to generate.