mlx4_core: Clean up error flow in mlx4_register_mac()
authorRoland Dreier <roland@purestorage.com>
Thu, 6 Oct 2011 16:33:11 +0000 (09:33 -0700)
committerRoland Dreier <roland@purestorage.com>
Thu, 6 Oct 2011 16:33:11 +0000 (09:33 -0700)
commit0f6740c7c455693f719580f34bb8afa8a298ea36
tree1302916de0b8d3ae3734156582b9fe0c81d50690
parent976d167615b64e14bc1491ca51d424e2ba9a5e84
mlx4_core: Clean up error flow in mlx4_register_mac()

Fix a leak of entry if radix_tree_insert() fails.

Also, reduce the indentation and make the flow easier to read by
sticking to the conventional

    err = do_something();
    if (err)
            return err;

    err = do_another();
    if (err)
            return err;

rather than mixing the direction of the test as

    err = do_something();
    if (!err) {
            err = do_another();
            if (err)
                    return err;
    } else
            return err;

Signed-off-by: Roland Dreier <roland@purestorage.com>
drivers/net/mlx4/port.c
This page took 0.024738 seconds and 5 git commands to generate.